Re: [PATCH v1] target/loongarch/cpu: Fix cpucfg default value

2022-07-19 Thread Richard Henderson
On 7/15/22 12:18, Xiaojuan Yang wrote: We should config cpucfg[20] to set value for the scache's ways, sets, and size arguments when loongarch cpu init. However, the old code wirte 'sets argument' twice, so we change one of them to 'size argument'. Signed-off-by: Xiaojuan Yang Queued. r~

[PATCH v2] i386: Disable BTS

2022-07-19 Thread Zhenzhong Duan
Since below KVM commit, KVM hided BTS as it's not supported yet. b9181c8ef356 ("KVM: x86/pmu: Avoid exposing Intel BTS feature") After below KVM commit, it gave control of MSR_IA32_MISC_ENABLES to userspace. 9fc222967a39 ("KVM: x86: Give host userspace full control of MSR_IA32_MISC_ENABLES") So

[PULL 11/14] tests/unit: Replace g_memdup() by g_memdup2()

2022-07-19 Thread Thomas Huth
From: Philippe Mathieu-Daudé Per https://discourse.gnome.org/t/port-your-module-from-g-memdup-to-g-memdup2-now/5538 The old API took the size of the memory to duplicate as a guint, whereas most memory functions take memory sizes as a gsize. This made it easy to accidentally pass a gsize t

[PULL 01/14] qga: treat get-guest-fsinfo as "best effort"

2022-07-19 Thread Thomas Huth
From: John Snow In some container environments, there may be references to block devices witnessable from a container through /proc/self/mountinfo that reference devices we simply don't have access to in the container, and cannot provide information about. Instead of failing the entire fsinfo co

[PULL 00/14] Testing and misc patches

2022-07-19 Thread Thomas Huth
Hi! The following changes since commit 782378973121addeb11b13fd12a6ac2e69faa33f: Merge tag 'pull-target-arm-20220718' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2022-07-18 16:29:32 +0100) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags

[PULL 05/14] tests/vm: upgrade Ubuntu 18.04 VM to 20.04

2022-07-19 Thread Thomas Huth
From: John Snow 18.04 has fallen out of our support window, so move ubuntu.aarch64 forward to ubuntu 20.04, which is now our oldest supported Ubuntu release. Notes: This checksum changes periodically; use a fixed point image with a known checksum so that the image isn't re-downloaded on every s

[PULL 14/14] python/qemu/qmp/legacy: Replace 'returns-whitelist' with the correct type

2022-07-19 Thread Thomas Huth
'returns-whitelist' has been renamed to 'command-returns-exceptions' in commit b86df3747848 ("qapi: Rename pragma *-whitelist to *-exceptions"). Message-Id: <20220711095721.61280-1-th...@redhat.com> Reviewed-by: John Snow Signed-off-by: Thomas Huth --- python/qemu/qmp/legacy.py | 2 +- 1 file c

[PULL 02/14] tests/vm: use 'cp' instead of 'ln' for temporary vm images

2022-07-19 Thread Thomas Huth
From: John Snow If the initial setup fails, you've permanently altered the state of the downloaded image in an unknowable way. Use 'cp' like our other test setup scripts do. Signed-off-by: John Snow Reviewed-by: Thomas Huth Reviewed-by: Daniel P. Berrangé Reviewed-by: Richard Henderson Messa

[PULL 03/14] tests/vm: switch CentOS 8 to CentOS 8 Stream

2022-07-19 Thread Thomas Huth
From: John Snow The old CentOS image didn't work anymore because it was already EOL at the beginning of 2022. Signed-off-by: John Snow Reviewed-by: Thomas Huth Reviewed-by: Daniel P. Berrangé Reviewed-by: Richard Henderson Message-Id: <20220708153503.18864-4-js...@redhat.com> Signed-off-by:

[PULL 08/14] tests/vm: add 1GB extra memory per core

2022-07-19 Thread Thomas Huth
From: John Snow If you try to run a 16 or 32 threaded test, you're going to run out of memory very quickly with qom-test and a few others. Bump the memory limit to try to scale with larger-core machines. Granted, this means that a 16 core processor is going to ask for 16GB, but you *probably* me

Re: [PATCH 1/4] Modifying ‘migrate’ qmp command to add multi-FD socket on particular source and destination pair

2022-07-19 Thread Markus Armbruster
Het Gala writes: > On 18/07/22 8:03 pm, Markus Armbruster wrote: >> Het Gala writes: >> >>> On 18/07/22 2:05 pm, Markus Armbruster wrote: Het Gala writes: > i) Modified the format of the qemu monitor command : 'migrate' by adding > a list, > each element in the list

[PULL 07/14] tests/vm: remove duplicate 'centos' VM test

2022-07-19 Thread Thomas Huth
From: John Snow This is listed twice by accident; we require genisoimage to run the test, so remove the unconditional entry. Signed-off-by: John Snow Reviewed-by: Thomas Huth Reviewed-by: Daniel P. Berrangé Reviewed-by: Richard Henderson Message-Id: <20220708153503.18864-8-js...@redhat.com>

[PULL 10/14] qtest/machine-none: Add LoongArch support

2022-07-19 Thread Thomas Huth
From: Song Gao Update the cpu_maps[] to support the LoongArch target. Signed-off-by: Song Gao Reviewed-by: Richard Henderson Message-Id: <20220713020258.601424-1-gaos...@loongson.cn> Signed-off-by: Thomas Huth --- tests/qtest/machine-none-test.c | 1 + 1 file changed, 1 insertion(+) diff --

[PULL 09/14] tests/vm: Remove docker cross-compile test from CentOS VM

2022-07-19 Thread Thomas Huth
From: John Snow The fedora container has since been split apart, so there's no suitable nearby target that would support "test-mingw" as it requires both x32 and x64 support -- so either fedora-cross-win32 nor fedora-cross-win64 would be truly suitable. Just remove this test as superfluous with

Re: [PATCH 1/1] target/riscv: Fix typo and restore Pointer Masking functionality for RISC-V

2022-07-19 Thread Alistair Francis
On Sun, Jul 17, 2022 at 8:17 PM Alexey Baturo wrote: > > From: Alexey Baturo > > Signed-off-by: Alexey Baturo Thanks! Applied to riscv-to-apply.next Alistair > --- > target/riscv/translate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/riscv/translate.c b/

Re: [PATCH 2/8] fpu/softfloat: Add LoongArch specialization for pickNaNMulAdd

2022-07-19 Thread Richard Henderson
On 7/16/22 14:24, Song Gao wrote: LoongArch system follows IEEE754-2008 specificationa. The (inf,zero,nan) case sets InvalidOp and returns the input value 'c', and Prefer sNaN over qNaN, in the c, a, b order. Signed-off-by: Song Gao Yep, matches paragraph 3 of 3.1.1.3. Non-numerical Result of

[PULL 13/14] util: Fix broken build on Haiku

2022-07-19 Thread Thomas Huth
A recent commit moved some Haiku-specific code parts from oslib-posix.c to cutils.c, but failed to move the corresponding header #include statement, too, so "make vm-build-haiku.x86_64" is currently broken. Fix it by moving the header #include, too. Fixes: 06680b15b4 ("include: move qemu_*_exec_di

[PULL 12/14] Replace 'whitelist' with 'allow'

2022-07-19 Thread Thomas Huth
Let's use more inclusive language here and avoid terms that are frowned upon nowadays. Message-Id: <20220711095300.60462-1-th...@redhat.com> Reviewed-by: John Snow Reviewed-by: Alex Bennée Signed-off-by: Thomas Huth --- docs/devel/submitting-a-patch.rst | 2 +- docs/tools/qemu-nbd.rst

[PULL 06/14] tests/vm: remove ubuntu.i386 VM test

2022-07-19 Thread Thomas Huth
From: John Snow Ubuntu 18.04 is out of our support window, and Ubuntu 20.04 does not support i386 anymore. The debian project does, but they do not provide any cloud images for it, a new expect-style script would have to be written. Since we have i386 cross-compiler tests hosted on GitLab CI, we

Re: [PATCH 3/8] target/loongarch: Fix float_convd/float_convs test failing

2022-07-19 Thread Richard Henderson
On 7/16/22 14:24, Song Gao wrote: We should result zero when exception is invalid and operation is nan Signed-off-by: Song Gao --- target/loongarch/fpu_helper.c | 143 +++--- 1 file changed, 80 insertions(+), 63 deletions(-) diff --git a/target/loongarch/fpu_help

Re: [PATCH v2 04/15] error-report: introduce overridable error_is_detailed()

2022-07-19 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Remove the direct dependency from error-report to monitor code. > This will allow to move error-report to a subproject. > > Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster

Re: [PATCH v2 05/15] stubs: remove needless error_vprintf_unless_qmp()

2022-07-19 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > stubs/error-printf.c | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/stubs/error-printf.c b/stubs/error-printf.c > index 0e326d801059..1afa0f62ca26 100644 > --- a/stubs/error-

Re: [PATCH 3/8] target/loongarch: Fix float_convd/float_convs test failing

2022-07-19 Thread Richard Henderson
On 7/19/22 12:42, Richard Henderson wrote: On 7/16/22 14:24, Song Gao wrote: We should result zero when exception is invalid and operation is nan Signed-off-by: Song Gao ---   target/loongarch/fpu_helper.c | 143 +++---   1 file changed, 80 insertions(+), 63 deletion

Re: [PATCH 0/8] tests/tcg/loongarch64: Add some tests.

2022-07-19 Thread Richard Henderson
On 7/16/22 14:24, Song Gao wrote: Hi, All This series adds some float reference files, fixes some float_convd/float_convs/float_madds bugs, and adds some instructions tests. Thanks. Song Gao Queued all of these. I added the #ifdef for pickNaN to patch 2, and I have left patch 3 as is. (My

Re: [PATCH] qtest/machine-none: Add LoongArch support

2022-07-19 Thread Richard Henderson
On 7/13/22 07:32, Song Gao wrote: Update the cpu_maps[] to support the LoongArch target. Signed-off-by: Song Gao --- tests/qtest/machine-none-test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qtest/machine-none-test.c b/tests/qtest/machine-none-test.c index d0f8cd9902..f92fab4

Re: [PATCH v2 12/19] vhost: add vhost_svq_poll

2022-07-19 Thread Jason Wang
在 2022/7/16 01:05, Eugenio Perez Martin 写道: On Fri, Jul 15, 2022 at 10:48 AM Jason Wang wrote: On Fri, Jul 15, 2022 at 1:39 PM Eugenio Perez Martin wrote: On Fri, Jul 15, 2022 at 5:59 AM Jason Wang wrote: On Fri, Jul 15, 2022 at 12:32 AM Eugenio Pérez wrote: It allows the Shadow Control

Re: [PATCH 1/6] hw/loongarch: Add fw_cfg table support

2022-07-19 Thread Richard Henderson
On 7/12/22 14:02, Xiaojuan Yang wrote: Add fw_cfg table for loongarch virt machine, including memmap table. Signed-off-by: Xiaojuan Yang --- hw/loongarch/fw_cfg.c | 33 ++ hw/loongarch/fw_cfg.h | 15 hw/loongarch/loongson3.c| 47 ++

Re: [PATCH 1/4] Modifying ‘migrate’ qmp command to add multi-FD socket on particular source and destination pair

2022-07-19 Thread Het Gala
On 19/07/22 12:36 pm, Markus Armbruster wrote: Het Gala writes: On 18/07/22 8:03 pm, Markus Armbruster wrote: Het Gala writes: On 18/07/22 2:05 pm, Markus Armbruster wrote: Het Gala writes: i) Modified the format of the qemu monitor command : 'migrate' by adding a list, each el

[PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

2022-07-19 Thread Alexey Kardashevskiy
The following changes since commit d2066bc50d690a6605307eaf0e72a9cf51e6fc25: target/ppc: Check page dir/table base alignment (2022-07-18 13:59:43 -0300) are available in the Git repository at: g...@github.com:aik/qemu.git tags/qemu-slof-20220719 for you to fetch changes up to

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

2022-07-19 Thread Alexey Kardashevskiy
...@github.com:aik/qemu.git tags/qemu-slof-20220719 for you to fetch changes up to 17c1ad657904787b1d986fb4c85431fee006a6ea: pseries: Update SLOF firmware image (2022-07-19 17:50:46 +1000) Alexey Kardashevskiy (1): pseries: Update SLOF

[PATCH] monitor: Support specified vCPU registers

2022-07-19 Thread zhenwei pi
Originally we have to get all the vCPU registers and parse the specified one. To improve the performance of this usage, allow user specified vCPU id to query registers. Run a VM with 16 vCPU, use bcc tool to track the latency of 'hmp_info_registers': 'info registers -a' uses about 3ms; 'info regis

Re: [PATCH 2/6] hw/loongarch: Add uefi bios loading support

2022-07-19 Thread Richard Henderson
On 7/12/22 14:02, Xiaojuan Yang wrote: Add uefi bios loading support, now only uefi bios is porting to loongarch virt machine. Signed-off-by: Xiaojuan Yang --- hw/loongarch/loongson3.c| 34 ++ include/hw/loongarch/virt.h | 4 2 files changed, 38 inse

Re: [PATCH 4/6] hw/loongarch: Add smbios support

2022-07-19 Thread Richard Henderson
On 7/12/22 14:02, Xiaojuan Yang wrote: Add smbios support for loongarch virt machine, and put them into fw_cfg table so that bios can parse them quickly. The weblink of smbios spec: https://www.dmtf.org/dsp/DSP0134, the version is 3.6.0. Signed-off-by: Xiaojuan Yang --- hw/loongarch/Kconfig

[PATCH v2] hw/pci/pci_bridge: ensure PCIe slots have only one slot

2022-07-19 Thread Roman Kagan
It's possible to create non-working configurations by attaching a device to a derivative of PCIe slot (pcie-root-port, ioh3420, etc) and specifying a slot number other that zero, e.g.: -device pcie-root-port,id=s0,... \ -device virtio-blk-pci,bus=s0,addr=4,... Make QEMU reject such config

Re: [PATCH v7 11/14] KVM: Register/unregister the guest private memory regions

2022-07-19 Thread Gupta, Pankaj
Hi Chao, Some comments below: If CONFIG_HAVE_KVM_PRIVATE_MEM=y, userspace can register/unregister the guest private memory regions through KVM_MEMORY_ENCRYPT_{UN,}REG_REGION ioctls. The patch reuses existing SEV ioctl but differs that the address in the region for private memory is gpa while SE

Re: [PATCH 3/6] hw/loongarch: Add linux kernel booting support

2022-07-19 Thread Richard Henderson
On 7/12/22 14:02, Xiaojuan Yang wrote: There are two situations to start system by kernel file. If exists bios option, system will boot from loaded bios file, else system will boot from hardcoded auxcode, and jump to kernel elf entry. Signed-off-by: Xiaojuan Yang --- hw/loongarch/loongson3.c |

Re: [PATCH 5/6] hw/loongarch: Add acpi ged support

2022-07-19 Thread Richard Henderson
On 7/12/22 14:02, Xiaojuan Yang wrote: Loongarch virt machine uses general hardware reduces acpi method, rather than LS7A acpi device. Now only power management function is used in acpi ged device, memory hotplug will be added later. Also acpi tables such as RSDP/RSDT/FADT etc. The acpi table ha

Re: [PATCH v11 00/10] vhost-vdpa: add support for configure interrupt

2022-07-19 Thread Cindy Lu
Hi Michael, Would you help review these patches, I wonder if this is ok to merge? please let me know if there is anything I need to do. Thanks Cindy On Mon, Jul 11, 2022 at 11:53 PM Cindy Lu wrote: > > These patches introduced the support for configure interrupt > > These codes are tested on x

Re: [PATCH 6/6] hw/loongarch: Add fdt support

2022-07-19 Thread Richard Henderson
On 7/12/22 14:02, Xiaojuan Yang wrote: Add LoongArch flatted device tree, adding cpu device node, firmware cfg node, pcie node into it, and create fdt rom memory region. Now fdt info is not full since only uefi bios uses fdt, linux kernel does not use fdt. Loongarch Linux kernel uses acpi table w

Re: [PATCH v1 0/6] Support booting bios and kernel for LoongArch

2022-07-19 Thread Richard Henderson
On 7/12/22 14:02, Xiaojuan Yang wrote: This series add some new funcitons for LoongArch virt machine. Support loading uefi bios and linux kernel to boot system, and add fw_cfg table, smbios table, acpi table, fdt table to transmit information for the system. We could get the uefi bios and linux

Re: [PATCH] tests: migration-test: Allow test to run without uffd

2022-07-19 Thread Daniel P . Berrangé
On Mon, Jul 18, 2022 at 03:14:37PM -0400, Peter Xu wrote: > Hi, Thomas, > > On Mon, Jul 18, 2022 at 08:23:26PM +0200, Thomas Huth wrote: > > On 07/07/2022 20.46, Peter Xu wrote: > > > We used to stop running all tests if uffd is not detected. However > > > logically that's only needed for postcop

Re: [PATCH] docs: List kvm as a supported accelerator on RISC-V

2022-07-19 Thread Thomas Huth
On 19/07/2022 10.26, Bin Meng wrote: Since commit fbf43c7dbf18 ("target/riscv: enable riscv kvm accel"), KVM accelerator is supported on RISC-V. Let's document it. Signed-off-by: Bin Meng --- docs/about/build-platforms.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

Re: [PATCH v3 1/5] target/loongarch/cpu: Fix cpu_class_by_name function

2022-07-19 Thread Igor Mammedov
On Tue, 19 Jul 2022 12:22:14 +0530 Richard Henderson wrote: > On 7/19/22 12:16, Richard Henderson wrote: > > On 7/15/22 11:37, Xiaojuan Yang wrote: > >> In loongarch_cpu_class_by_name(char *cpu_model) function, > >> the argument cpu_model already has the suffix '-loongarch-cpu', > >> so we shou

Re: [PATCH v2 12/19] vhost: add vhost_svq_poll

2022-07-19 Thread Eugenio Perez Martin
On Tue, Jul 19, 2022 at 9:38 AM Jason Wang wrote: > > > 在 2022/7/16 01:05, Eugenio Perez Martin 写道: > > On Fri, Jul 15, 2022 at 10:48 AM Jason Wang wrote: > >> On Fri, Jul 15, 2022 at 1:39 PM Eugenio Perez Martin > >> wrote: > >>> On Fri, Jul 15, 2022 at 5:59 AM Jason Wang wrote: > On Fri,

Re: [PATCH v2 12/19] vhost: add vhost_svq_poll

2022-07-19 Thread Jason Wang
On Tue, Jul 19, 2022 at 4:42 PM Eugenio Perez Martin wrote: > > On Tue, Jul 19, 2022 at 9:38 AM Jason Wang wrote: > > > > > > 在 2022/7/16 01:05, Eugenio Perez Martin 写道: > > > On Fri, Jul 15, 2022 at 10:48 AM Jason Wang wrote: > > >> On Fri, Jul 15, 2022 at 1:39 PM Eugenio Perez Martin > > >> w

Re: [PULL 00/30] ppc queue

2022-07-19 Thread Peter Maydell
On Mon, 18 Jul 2022 at 18:22, Daniel Henrique Barboza wrote: > > The following changes since commit 782378973121addeb11b13fd12a6ac2e69faa33f: > > Merge tag 'pull-target-arm-20220718' of > https://git.linaro.org/people/pmaydell/qemu-arm into staging (2022-07-18 > 16:29:32 +0100) > > are availab

Re: [PATCH v11 01/10] virtio: introduce macro IRTIO_CONFIG_IRQ_IDX

2022-07-19 Thread Jason Wang
在 2022/7/11 23:52, Cindy Lu 写道: To support configure interrupt for vhost-vdpa Introduce VIRTIO_CONFIG_IRQ_IDX -1 as configure interrupt's queue index, Then we can reuse the functions guest_notifier_mask and guest_notifier_pending. Add the check of queue index in these drivers, if the driver doe

Re: [PATCH v2 12/19] vhost: add vhost_svq_poll

2022-07-19 Thread Eugenio Perez Martin
On Tue, Jul 19, 2022 at 10:49 AM Jason Wang wrote: > > On Tue, Jul 19, 2022 at 4:42 PM Eugenio Perez Martin > wrote: > > > > On Tue, Jul 19, 2022 at 9:38 AM Jason Wang wrote: > > > > > > > > > 在 2022/7/16 01:05, Eugenio Perez Martin 写道: > > > > On Fri, Jul 15, 2022 at 10:48 AM Jason Wang wrote:

Re: [PATCH] util: Fix broken build on Haiku

2022-07-19 Thread Paolo Bonzini
Queued, thanks. Paolo

[PULL 0/3] Misc patches for QEMU 7.1 freeze

2022-07-19 Thread Paolo Bonzini
The following changes since commit 0ebf76aae58324b8f7bf6af798696687f5f4c2a9: Merge tag 'nvme-next-pull-request' of git://git.infradead.org/qemu-nvme into staging (2022-07-15 15:38:13 +0100) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for yo

[PULL 1/3] monitor: add support for boolean statistics

2022-07-19 Thread Paolo Bonzini
The next version of Linux will introduce boolean statistics, which can only have 0 or 1 values. Support them in the schema and in the HMP command. Suggested-by: Amneesh Singh Signed-off-by: Paolo Bonzini --- monitor/hmp-cmds.c | 2 ++ qapi/stats.json| 4 +++- 2 files changed, 5 insertions(

[PULL 3/3] util: Fix broken build on Haiku

2022-07-19 Thread Paolo Bonzini
From: Thomas Huth A recent commit moved some Haiku-specific code parts from oslib-posix.c to cutils.c, but failed to move the corresponding header #include statement, too, so "make vm-build-haiku.x86_64" is currently broken. Fix it by moving the header #include, too. Fixes: 06680b15b4 ("include:

[PULL 2/3] kvm: add support for boolean statistics

2022-07-19 Thread Paolo Bonzini
The next version of Linux will introduce boolean statistics, which can only have 0 or 1 values. Convert them to the new QAPI fields added in the previous commit. Signed-off-by: Paolo Bonzini --- accel/kvm/kvm-all.c | 10 +- linux-headers/linux/kvm.h | 1 + 2 files changed, 10 ins

Re: [PATCH 1/4] Modifying ‘migrate’ qmp command to add multi-FD socket on particular source and destination pair

2022-07-19 Thread Markus Armbruster
Het Gala writes: > On 19/07/22 12:36 pm, Markus Armbruster wrote: >> Het Gala writes: >> >>> On 18/07/22 8:03 pm, Markus Armbruster wrote: Het Gala writes: > On 18/07/22 2:05 pm, Markus Armbruster wrote: >> Het Gala writes: >> >>> i) Modified the format of the qemu mo

[PATCH v2 0/8] AArch64/HMAT support and tests

2022-07-19 Thread Hesham Almatary
This patchset adds support for AArch64/HMAT including a test. It relies on other two patch sets from: Brice Goglin: to support -numa without initiators on q35/x86. https://lore.kernel.org/all/ed23accb-2c8b-90f4-a7a3-f81cc57bf...@inria.fr/ Xiang Chen: to enable/support HMAT on AArch64. https:/

[PATCH v2 1/8] hmat acpi: Don't require initiator value in -numa

2022-07-19 Thread Hesham Almatary
From: Brice Goglin The "Memory Proximity Domain Attributes" structure of the ACPI HMAT has a "Processor Proximity Domain Valid" flag that is currently always set because Qemu -numa requires an initiator=X value when hmat=on. Unsetting this flag allows to create more complex memory topologies by h

[PATCH v2 4/8] tests: acpi: q35: update expected blobs *.hmat-noinitiators

2022-07-19 Thread Hesham Almatary
From: Brice Goglin expected HMAT: [000h 4]Signature : "HMAT"[Heterogeneous Memory Attributes Table] [004h 0004 4] Table Length : 0120 [008h 0008 1] Revision : 02 [009h 0009 1] Checksum : 4F [00Ah 0

[PATCH v2 6/8] hw/arm/virt: Enable HMAT on arm virt machine

2022-07-19 Thread Hesham Almatary
From: Xiang Chen Since the patchset ("Build ACPI Heterogeneous Memory Attribute Table (HMAT)"), HMAT is supported, but only x86 is enabled. Enable HMAT on arm virt machine. Signed-off-by: Xiang Chen Signed-off-by: Hesham Almatary Reviewed-by: Igor Mammedov --- hw/arm/Kconfig | 1 +

[PATCH v2 5/8] tests: Add HMAT AArch64/virt empty table files

2022-07-19 Thread Hesham Almatary
Signed-off-by: Hesham Almatary --- tests/data/acpi/virt/APIC.acpihmatvirt | 0 tests/data/acpi/virt/DSDT.acpihmatvirt | 0 tests/data/acpi/virt/HMAT.acpihmatvirt | 0 tests/data/acpi/virt/PPTT.acpihmatvirt | 0 tests/data/acpi/virt/SRAT.acpihmatvirt | 0 tests/qtest/bios-

[PATCH v2 2/8] tests: acpi: add and whitelist *.hmat-noinitiator expected blobs

2022-07-19 Thread Hesham Almatary
From: Brice Goglin .. which will be used by follow up hmat-noinitiator test-case. Signed-off-by: Brice Goglin Signed-off-by: Hesham Almatary --- tests/data/acpi/q35/APIC.acpihmat-noinitiator | 0 tests/data/acpi/q35/DSDT.acpihmat-noinitiator | 0 tests/data/acpi/q35/HMAT.acpihmat-noinitiator

[PATCH v2 8/8] tests: virt: Update expected *.acpihmatvirt tables

2022-07-19 Thread Hesham Almatary
* Expected ACPI Data Table [HMAT] [000h 4]Signature : "HMAT"[Heterogeneous Memory Attributes Table] [004h 0004 4] Table Length : 0120 [008h 0008 1] Revision : 02 [009h 0009 1] Checksum : 4F [00Ah 0010

[PATCH v2 7/8] tests: acpi: aarch64/virt: add a test for hmat nodes with no initiators

2022-07-19 Thread Hesham Almatary
This patch imitates the "tests: acpi: q35: add test for hmat nodes without initiators" commit to test numa nodes with different HMAT attributes, but on AArch64/virt. Tested with: qemu-system-aarch64 -accel tcg \ -machine virt,hmat=on,gic-version=3 -cpu cortex-a57 \ -bios qemu-efi-aarch64/QEMU_EFI

[PATCH v2 3/8] tests: acpi: q35: add test for hmat nodes without initiators

2022-07-19 Thread Hesham Almatary
From: Brice Goglin expected HMAT: [000h 4]Signature : "HMAT"[Heterogeneous Memory Attributes Table] [004h 0004 4] Table Length : 0120 [008h 0008 1] Revision : 02 [009h 0009 1] Checksum : 4F [00Ah 00

[PATCH v5 02/20] virtio-net: Expose MAC_TABLE_ENTRIES

2022-07-19 Thread Eugenio Pérez
vhost-vdpa control virtqueue needs to know the maximum entries supported by the virtio-net device, so we know if it is possible to apply the filter. Signed-off-by: Eugenio Pérez --- include/hw/virtio/virtio-net.h | 3 +++ hw/net/virtio-net.c| 1 - 2 files changed, 3 insertions(+), 1

Re: [PATCH qemu] target/s390x: support PRNO_TRNG instruction

2022-07-19 Thread David Hildenbrand
On 12.07.22 18:46, Jason A. Donenfeld wrote: > In order for hosts running inside of TCG to initialize the kernel's > random number generator, we should support the PRNO_TRNG instruction, > backed in the usual way with the qemu_guest_getrandom helper. This is > confirmed working on Linux 5.19-rc6. >

[PATCH v5 01/20] vhost: move descriptor translation to vhost_svq_vring_write_descs

2022-07-19 Thread Eugenio Pérez
It's done for both in and out descriptors so it's better placed here. Acked-by: Jason Wang Signed-off-by: Eugenio Pérez --- hw/virtio/vhost-shadow-virtqueue.c | 38 +- 1 file changed, 27 insertions(+), 11 deletions(-) diff --git a/hw/virtio/vhost-shadow-virtqueue.c

[PATCH v5 13/20] vhost: add vhost_svq_poll

2022-07-19 Thread Eugenio Pérez
It allows the Shadow Control VirtQueue to wait for the device to use the available buffers. Signed-off-by: Eugenio Pérez --- hw/virtio/vhost-shadow-virtqueue.h | 1 + hw/virtio/vhost-shadow-virtqueue.c | 27 +++ 2 files changed, 28 insertions(+) diff --git a/hw/virtio/v

[PATCH v5 00/20] vdpa net devices Rx filter change notification with Shadow VQ

2022-07-19 Thread Eugenio Pérez
Control virtqueue is used by networking device for accepting various commands from the driver. It's a must to support advanced configurations. Rx filtering event is issues by qemu when device's MAC address changed once and the previous one has not been queried by external agents. Shadow VirtQueue

[PATCH v5 15/20] vdpa: Export vhost_vdpa_dma_map and unmap calls

2022-07-19 Thread Eugenio Pérez
Shadow CVQ will copy buffers on qemu VA, so we avoid TOCTOU attacks from the guest that could set a different state in qemu device model and vdpa device. To do so, it needs to be able to map these new buffers to the device. Signed-off-by: Eugenio Pérez Acked-by: Jason Wang --- include/hw/virti

Re: [PATCH v7 13/14] KVM: Enable and expose KVM_MEM_PRIVATE

2022-07-19 Thread Gupta, Pankaj
Register private memslot to fd-based memory backing store and handle the memfile notifiers to zap the existing mappings. Currently the register is happened at memslot creating time and the initial support does not include page migration/swap. KVM_MEM_PRIVATE is not exposed by default, architectu

[PATCH v5 03/20] virtio-net: Expose ctrl virtqueue logic

2022-07-19 Thread Eugenio Pérez
This allows external vhost-net devices to modify the state of the VirtIO device model once the vhost-vdpa device has acknowledged the control commands. Signed-off-by: Eugenio Pérez --- include/hw/virtio/virtio-net.h | 4 ++ hw/net/virtio-net.c| 84 --

[PATCH v5 12/20] vhost: Expose vhost_svq_add

2022-07-19 Thread Eugenio Pérez
This allows external parts of SVQ to forward custom buffers to the device. Signed-off-by: Eugenio Pérez --- hw/virtio/vhost-shadow-virtqueue.h | 3 +++ hw/virtio/vhost-shadow-virtqueue.c | 6 +++--- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/virtio/vhost-shadow-virtqueue.h

[PATCH v5 17/20] vdpa: Buffer CVQ support on shadow virtqueue

2022-07-19 Thread Eugenio Pérez
Introduce the control virtqueue support for vDPA shadow virtqueue. This is needed for advanced networking features like rx filtering. Virtio-net control VQ copies the descriptors to qemu's VA, so we avoid TOCTOU with the guest's or device's memory every time there is a device model change. Otherw

[PATCH v5 06/20] vhost: Move vhost_svq_kick call to vhost_svq_add

2022-07-19 Thread Eugenio Pérez
The series needs to expose vhost_svq_add with full functionality, including kick Signed-off-by: Eugenio Pérez --- hw/virtio/vhost-shadow-virtqueue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/vhost-shadow-virtqueue.c b/hw/virtio/vhost-shadow-virtqueue.c index

[PATCH v5 04/20] vdpa: Avoid compiler to squash reads to used idx

2022-07-19 Thread Eugenio Pérez
In the next patch we will allow busypolling of this value. The compiler have a running path where shadow_used_idx, last_used_idx, and vring used idx are not modified within the same thread busypolling. This was not an issue before since we always cleared device event notifier before checking it, a

[PATCH v5 09/20] vhost: Add SVQDescState

2022-07-19 Thread Eugenio Pérez
This will allow SVQ to add context to the different queue elements. This patch only store the actual element, no functional change intended. Signed-off-by: Eugenio Pérez --- hw/virtio/vhost-shadow-virtqueue.h | 8 ++-- hw/virtio/vhost-shadow-virtqueue.c | 16 2 files chang

[PATCH v5 11/20] vhost: add vhost_svq_push_elem

2022-07-19 Thread Eugenio Pérez
This function allows external SVQ users to return guest's available buffers. Signed-off-by: Eugenio Pérez --- hw/virtio/vhost-shadow-virtqueue.h | 3 +++ hw/virtio/vhost-shadow-virtqueue.c | 16 2 files changed, 19 insertions(+) diff --git a/hw/virtio/vhost-shadow-virtqueue.h

[PATCH v5 18/20] vdpa: Extract get features part from vhost_vdpa_get_max_queue_pairs

2022-07-19 Thread Eugenio Pérez
To know the device features is needed for CVQ SVQ, so SVQ knows if it can handle all commands or not. Extract from vhost_vdpa_get_max_queue_pairs so we can reuse it. Signed-off-by: Eugenio Pérez Acked-by: Jason Wang --- net/vhost-vdpa.c | 30 -- 1 file changed, 20 in

[PATCH v5 05/20] vhost: Reorder vhost_svq_kick

2022-07-19 Thread Eugenio Pérez
Future code needs to call it from vhost_svq_add. No functional change intended. Signed-off-by: Eugenio Pérez --- hw/virtio/vhost-shadow-virtqueue.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/hw/virtio/vhost-shadow-virtqueue.c b/hw/virtio/

[PATCH v5 07/20] vhost: Check for queue full at vhost_svq_add

2022-07-19 Thread Eugenio Pérez
The series need to expose vhost_svq_add with full functionality, including checking for full queue. Signed-off-by: Eugenio Pérez --- hw/virtio/vhost-shadow-virtqueue.c | 59 +- 1 file changed, 33 insertions(+), 26 deletions(-) diff --git a/hw/virtio/vhost-shadow-virt

[PATCH v5 20/20] vdpa: Add x-svq to NetdevVhostVDPAOptions

2022-07-19 Thread Eugenio Pérez
Finally offering the possibility to enable SVQ from the command line. Signed-off-by: Eugenio Pérez Acked-by: Markus Armbruster --- qapi/net.json| 9 +- net/vhost-vdpa.c | 72 ++-- 2 files changed, 77 insertions(+), 4 deletions(-) diff --git

[PATCH v5 08/20] vhost: Decouple vhost_svq_add from VirtQueueElement

2022-07-19 Thread Eugenio Pérez
VirtQueueElement comes from the guest, but we're heading SVQ to be able to modify the element presented to the device without the guest's knowledge. To do so, make SVQ accept sg buffers directly, instead of using VirtQueueElement. Add vhost_svq_add_element to maintain element convenience. Signed

[PATCH v5 10/20] vhost: Track number of descs in SVQDescState

2022-07-19 Thread Eugenio Pérez
A guest's buffer continuos on GPA may need multiple descriptors on qemu's VA, so SVQ should track its length sepparatedly. Signed-off-by: Eugenio Pérez --- hw/virtio/vhost-shadow-virtqueue.h | 6 ++ hw/virtio/vhost-shadow-virtqueue.c | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-)

[PATCH v5 14/20] vhost: Add svq avail_handler callback

2022-07-19 Thread Eugenio Pérez
This allows external handlers to be aware of new buffers that the guest places in the virtqueue. When this callback is defined the ownership of the guest's virtqueue element is transferred to the callback. This means that if the user wants to forward the descriptor it needs to manually inject it.

Re: [PATCH v5 00/20] vdpa net devices Rx filter change notification with Shadow VQ

2022-07-19 Thread Eugenio Perez Martin
On Tue, Jul 19, 2022 at 12:01 PM Eugenio Pérez wrote: > > Control virtqueue is used by networking device for accepting various > commands from the driver. It's a must to support advanced configurations. > > Rx filtering event is issues by qemu when device's MAC address changed once > and > the pr

Re: [RFC PATCH 7/8] block: use the new _change_ API instead of _can_set_ and _set_

2022-07-19 Thread Emanuele Giuseppe Esposito
Am 18/07/2022 um 18:39 schrieb Paolo Bonzini: > On 7/12/22 23:19, Emanuele Giuseppe Esposito wrote: >> diff --git a/block/block-backend.c b/block/block-backend.c >> index 674eaaa2bf..6e90ac3a6a 100644 >> --- a/block/block-backend.c >> +++ b/block/block-backend.c >> @@ -2184,8 +2184,12 @@ static

[PATCH v5 16/20] vdpa: manual forward CVQ buffers

2022-07-19 Thread Eugenio Pérez
Do a simple forwarding of CVQ buffers, the same work SVQ could do but through callbacks. No functional change intended. Signed-off-by: Eugenio Pérez --- include/hw/virtio/vhost-vdpa.h | 3 ++ hw/virtio/vhost-vdpa.c | 3 +- net/vhost-vdpa.c | 58 +++

Re: [PATCH qemu] target/s390x: support PRNO_TRNG instruction

2022-07-19 Thread Thomas Huth
Hi Jason, thanks for you patch! Additionally to the things that David already mentioned, please have also a look at my comments below... On 12/07/2022 18.46, Jason A. Donenfeld wrote: In order for hosts running inside of TCG to initialize the kernel's random number generator, we should sup

[PATCH v5 19/20] vdpa: Add device migration blocker

2022-07-19 Thread Eugenio Pérez
Since the vhost-vdpa device is exposing _F_LOG, adding a migration blocker if it uses CVQ. However, qemu is able to migrate simple devices with no CVQ as long as they use SVQ. To allow it, add a placeholder error to vhost_vdpa, and only add to vhost_dev when used. vhost_dev machinery place the mig

Re: [PATCH] tests: migration-test: Allow test to run without uffd

2022-07-19 Thread Thomas Huth
On 18/07/2022 21.14, Peter Xu wrote: Hi, Thomas, On Mon, Jul 18, 2022 at 08:23:26PM +0200, Thomas Huth wrote: On 07/07/2022 20.46, Peter Xu wrote: We used to stop running all tests if uffd is not detected. However logically that's only needed for postcopy not the rest of tests. Keep running

Re: [PATCH] tests: migration-test: Allow test to run without uffd

2022-07-19 Thread Daniel P . Berrangé
On Tue, Jul 19, 2022 at 12:28:24PM +0200, Thomas Huth wrote: > On 18/07/2022 21.14, Peter Xu wrote: > > Hi, Thomas, > > > > On Mon, Jul 18, 2022 at 08:23:26PM +0200, Thomas Huth wrote: > > > On 07/07/2022 20.46, Peter Xu wrote: > > > > We used to stop running all tests if uffd is not detected. Ho

Re: [PATCH 1/4] Modifying ‘migrate’ qmp command to add multi-FD socket on particular source and destination pair

2022-07-19 Thread Het Gala
On 19/07/22 3:18 pm, Markus Armbruster wrote: Het Gala writes: On 19/07/22 12:36 pm, Markus Armbruster wrote: Het Gala writes: On 18/07/22 8:03 pm, Markus Armbruster wrote: Het Gala writes: On 18/07/22 2:05 pm, Markus Armbruster wrote: Het Gala writes: i) Modified the format of t

Re: [PATCH v2] hw/pci/pci_bridge: ensure PCIe slots have only one slot

2022-07-19 Thread Thomas Huth
On 19/07/2022 10.01, Roman Kagan wrote: It's possible to create non-working configurations by attaching a device to a derivative of PCIe slot (pcie-root-port, ioh3420, etc) and specifying a slot number other that zero, e.g.: -device pcie-root-port,id=s0,... \ -device virtio-blk-pci,bus

Re: [PATCH v2 0/3] target/s390x: vfmin/vfmax fixes

2022-07-19 Thread Thomas Huth
On 13/07/2022 20.26, Ilya Leoshkevich wrote: Hi, Uli has found an issue with finding maximum of different kinds of 0s; I wrote a test and found another one with finding maximum of different kinds of NaNs. Patches 1 and 2 fix those issues, patch 3 adds a vfmin/vfmax test. Best regards, Ilya v1

Re: [PATCH] virtio-gpu: update done only on the scanout associated with rect

2022-07-19 Thread Gerd Hoffmann
On Fri, May 06, 2022 at 10:09:30AM -0700, Dongwon Kim wrote: > On Fri, May 06, 2022 at 11:53:22AM +0400, Marc-André Lureau wrote: > > Hi > > > > On Fri, May 6, 2022 at 1:46 AM Dongwon Kim wrote: > > > > > It only needs to update the scanouts containing the rect area > > > coming with the resourc

Re: [PATCH qemu] target/s390x: support PRNO_TRNG instruction

2022-07-19 Thread Jason A. Donenfeld
Hi David, Thanks for your feedback. I'll CC you on v+1. Note that I don't know very much about s390x, so I may require some slight hand holding, but let's see how far I can get... On Tue, Jul 19, 2022 at 11:54:04AM +0200, David Hildenbrand wrote: > How is that warning avoided now? We have to sort

Re: [PATCH qemu] target/s390x: support PRNO_TRNG instruction

2022-07-19 Thread Jason A. Donenfeld
Hi Thomas, On Tue, Jul 19, 2022 at 12:00 PM Thomas Huth wrote: > > +{ > > +uint64_t addr = wrap_address(env, buf); > > I think you have to limit "len" to the lower 32-bit if not running in 64-bit > mode. Will do. > According to the Principles of Operation: > > "A specification exception

Re: [PATCH v3 00/19] vdpa net devices Rx filter change notification with Shadow VQ

2022-07-19 Thread Michael S. Tsirkin
On Fri, Jul 15, 2022 at 07:18:15PM +0200, Eugenio Pérez wrote: > Control virtqueue is used by networking device for accepting various > commands from the driver. It's a must to support advanced configurations. > > Rx filtering event is issues by qemu when device's MAC address changed once > and >

Re: [PATCH v3 00/19] vdpa net devices Rx filter change notification with Shadow VQ

2022-07-19 Thread Michael S. Tsirkin
On Mon, Jul 18, 2022 at 11:32:57AM +0800, Jason Wang wrote: > On Sat, Jul 16, 2022 at 1:18 AM Eugenio Pérez wrote: > > > > Control virtqueue is used by networking device for accepting various > > commands from the driver. It's a must to support advanced configurations. > > > > Rx filtering event i

Re: [QEMU PATCH v2 4/6] nvdimm: Implement ACPI NVDIMM Label Methods

2022-07-19 Thread Michael S. Tsirkin
On Tue, Jul 19, 2022 at 10:46:38AM +0800, Robert Hoo wrote: > Ping... Igor could you respond? It's been 3 weeks ...

  1   2   3   4   >