lcitool update required

Hi guys, Cirrus FreeBSD builds are now broken, because we're trying to install py38-* packages that no longer exist. There was, yesterday, an update to lcitool that addresses this. However in the meantime there has been a major change to the way lcitool is packaged such that we cannot merely

Re: [PATCH v2 10/11] pytest: add pytest to the meson build system

On Mon, 11 Jul 2022, John Snow wrote: > On Sun, Jul 10, 2022 at 1:01 PM Ani Sinha wrote: > > > > Integrate the pytest framework with the meson build system. This will make > > meson > > run all the pytests under the pytest directory. > > > > Signed-off-by: Ani Sinha > > --- > > tests/Makefi

[PATCH] vhost: Return earlier if used buffers overrun SVQ flush

Previous function misses the just picked avail buffer from the queue. This way keeps blocking the used queue until queue reset, but is cleaner to check before calling to vhost_svq_get_buf. Fixes: 100890f7cad50 ("vhost: Shadow virtqueue buffers forwarding") Acked-by: Jason Wang Signed-off-by: Euge

RE: [Qemu] how to use viriofs in qemu without NUMA

Hi, all, I have another question want to consult you. To enable DAX in virtiofs, according to the memu https://virtio-fs.gitlab.io/howto-qemu.html. I need to add "cache-size=2G" as below. -device vhost-user-fs-pci,queue-size=1024,chardev=char0,tag=myfs,cache-size=2G My qemu command is: sudo

[PATCH] vdpa: Clean vhost_vdpa_dev_start(dev, false)

Return value is never checked and is a clean path, so assume success Signed-off-by: Eugenio Pérez --- hw/virtio/vhost-vdpa.c | 33 ++--- 1 file changed, 10 insertions(+), 23 deletions(-) diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c index 66f054a12c..d

Re: [PATCH] iotests: fix copy-before-write for macOS and FreeBSD

On 7/5/22 21:07, Vladimir Sementsov-Ogievskiy wrote: strerror() represents ETIMEDOUT a bit different in Linux and macOS / FreeBSD. Let's support the latter too. Fixes: 9d05a87b77 ("iotests: copy-before-write: add cases for cbw-timeout option") Signed-off-by: Vladimir Sementsov-Ogievskiy --- A

Re: [PATCH 1/3] target/s390x: fix handling of zeroes in vfmin/vfmax

On 12.07.22 03:57, Ilya Leoshkevich wrote: > vfmin_res() / vfmax_res() are trying to check whether a and b are both > zeroes, but in reality they check that they are the same kind of zero. > This causes incorrect results when comparing positive and negative > zeroes. > > Fixes: da4807527f3b ("s390

Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits

On Mon, 11 Jul 2022, John Snow wrote: > On Sun, Jul 10, 2022 at 1:01 PM Ani Sinha wrote: > > > > This change adds python based test environment that can be used to run > > pytest > > from within a virtual environment. A bash script sets up a virtual > > environment > > and then runs the pyth

Re: [RFC PATCH v9 20/23] vdpa: Buffer CVQ support on shadow virtqueue

在 2022/7/7 02:40, Eugenio Pérez 写道: Introduce the control virtqueue support for vDPA shadow virtqueue. This is needed for advanced networking features like multiqueue. Virtio-net control VQ will copy the descriptors to qemu's VA, so we avoid TOCTOU with the guest's or device's memory every tim

Re: [PATCH 1/3] accel/tcg: Fix unaligned stores to s390x low-address-protected lowcore

On 11.07.22 20:56, Ilya Leoshkevich wrote: > If low-address-protection is active, unaligned stores to non-protected > parts of lowcore lead to protection exceptions. The reason is that in > such cases tlb_fill() call in store_helper_unaligned() covers > [0, addr + size) range, which contains the pr

Re: [PATCH] iotests/copy-before-write: specify required_fmts

On 7/6/22 22:38, Vladimir Sementsov-Ogievskiy wrote: Declare that we need copy-before-write filter to avoid failure when filter is not whitelisted. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/tests/copy-before-write | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(

Re: [PATCH 2/3] target/s390x: fix NaN propagation rules

On 12.07.22 03:57, Ilya Leoshkevich wrote: > s390x has the same NaN propagation rules as ARM, and not as x86. > > Signed-off-by: Ilya Leoshkevich > --- > fpu/softfloat-specialize.c.inc | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fpu/softfloat-specialize.c.inc b/fp

Re: [RFC v4 1/9] block: add block layer APIs resembling Linux ZonedBlockDevice ioctls.

On 7/12/22 11:13, Sam Li wrote: > By adding zone management operations in BlockDriver, storage > controller emulation can use the new block layer APIs including > zone_report and zone_mgmt(open, close, finish, reset). > > Signed-off-by: Sam Li > --- > block/block-backend.c| 41 +

Re: [RFC PATCH v9 21/23] vdpa: Add vhost_vdpa_start_control_svq

在 2022/7/7 02:40, Eugenio Pérez 写道: As a first step we only enable CVQ first than others. Future patches add state restore. Signed-off-by: Eugenio Pérez --- net/vhost-vdpa.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index e

Re: [PATCH v2 01/11] acpi/tests/bits: initial commit of test scripts that are run by biosbits

On Mon, 11 Jul 2022, John Snow wrote: > On Sun, Jul 10, 2022 at 1:01 PM Ani Sinha wrote: > > > > This is initial commit of cpuid, acpi and smbios python test scripts for > > biosbits to execute. No change has been made to them from the original code > > written by the biosbits author Josh Trip

Re: [RFC v4 3/9] file-posix: introduce get_sysfs_long_val for a block queue of sysfs attribute

On 7/12/22 11:13, Sam Li wrote: > Use sysfs attribute files to get the zoned device information in case > that ioctl() commands of zone management interface won't work. > > Signed-off-by: Sam Li > --- > block/file-posix.c | 38 +++--- > 1 file changed, 27 insertio

Re: [RFC v4 2/9] qemu-io: add zoned block device operations.

On 7/12/22 11:13, Sam Li wrote: > Add zoned storage commands of the device: zone_open(zo), zone_close(zc), > zone_reset(zs), zone_report(zp), zone_finish(zf). > > For example, it can be called by: > ./build/qemu-io --image-opts driver=zoned_host_device, filename=/dev/nullb0 > -c "zone_report 0 0 1

Re: [RFC PATCH v9 09/23] vhost: Add SVQElement

在 2022/7/11 17:33, Eugenio Perez Martin 写道: On Mon, Jul 11, 2022 at 11:00 AM Jason Wang wrote: 在 2022/7/7 02:39, Eugenio Pérez 写道: This will allow SVQ to add metadata to the different queue elements. To simplify changes, only store actual element at this patch. Signed-off-by: Eugenio Pérez

Re: [RFC PATCH v9 12/23] vhost: Add opaque member to SVQElement

在 2022/7/11 17:56, Eugenio Perez Martin 写道: On Mon, Jul 11, 2022 at 11:05 AM Jason Wang wrote: 在 2022/7/7 02:39, Eugenio Pérez 写道: When qemu injects buffers to the vdpa device it will be used to maintain contextual data. If SVQ has no operation, it will be used to maintain the VirtQueueElem

Re: [RFC v4 9/9] qapi: add support for zoned host device

On 7/12/22 11:13, Sam Li wrote: > --- > block/file-posix.c | 8 +++- > qapi/block-core.json | 7 +-- > 2 files changed, 12 insertions(+), 3 deletions(-) > > diff --git a/block/file-posix.c b/block/file-posix.c > index e9ad1d8e1e..4e0aa02acf 100644 > --- a/block/file-posix.c > +++ b/bloc

Re: [RFC v4 4/9] file-posix: introduce get_sysfs_str_val for device zoned model.

On 7/12/22 11:13, Sam Li wrote: > Signed-off-by: Sam Li > --- > block/file-posix.c | 60 > include/block/block-common.h | 4 +-- > 2 files changed, 62 insertions(+), 2 deletions(-) > > diff --git a/block/file-posix.c b/block/file-posix.c > index 31

Re: [RFC PATCH v9 04/23] vhost: Get vring base from vq, not svq

在 2022/7/8 18:10, Eugenio Perez Martin 写道: On Fri, Jul 8, 2022 at 11:12 AM Jason Wang wrote: On Thu, Jul 7, 2022 at 2:40 AM Eugenio Pérez wrote: The used idx used to match with this, but it will not match from the moment we introduce svq_inject. It might be better to explain what "svq_inje

Re: [RFC PATCH v9 08/23] vhost: Decouple vhost_svq_add_split from VirtQueueElement

在 2022/7/11 16:27, Eugenio Perez Martin 写道: On Mon, Jul 11, 2022 at 10:00 AM Jason Wang wrote: 在 2022/7/7 02:39, Eugenio Pérez 写道: VirtQueueElement comes from the guest, but we're heading SVQ to be able to inject element without the guest's knowledge. To do so, make this accept sg buffers

Re: [RFC PATCH v9 13/23] vhost: Add vhost_svq_inject

在 2022/7/11 17:43, Eugenio Perez Martin 写道: On Mon, Jul 11, 2022 at 11:14 AM Jason Wang wrote: 在 2022/7/7 02:39, Eugenio Pérez 写道: This allows qemu to inject buffers to the device. Not a native speaker but we probably need a better terminology than inject here. Since the CVQ is totally u

Re: [PULL 0/2] tcg patch queue

ository at: https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20220712 for you to fetch changes up to b0f650f0477ae775e0915e3d60ab5110ad5e9157: accel/tcg: Fix unaligned stores to s390x low-address-protected lowcore (2022-07-12 10:4

[PATCH 4/5] target/loongarch/tlb_helper: Fix coverity integer overflow error

Replace '1' with '1UL' to fix unintentional integer overflow errors in tlb_helper file. Fix coverity CID: 1489759 1489762 Signed-off-by: Xiaojuan Yang --- target/loongarch/tlb_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/loongarch/tlb_helper.c b/target

[PATCH 5/5] target/loongarch/op_helper: Fix coverity cond_at_most error

The boundary size of cpucfg array should be 0 to 20. So, using index bigger than 20 to access cpucfg[] must be forbidden. Fix coverity CID: 1489760 Signed-off-by: Xiaojuan Yang --- target/loongarch/op_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/loongarch/

[PATCH 2/5] hw/intc/loongarch_pch_pic: Fix coverity errors in update irq

Fix coverity errors: 1. In find_first_bit function, the 'size' argument need 'unsigned long' type, so we add the suffix 'UL' on 'size' argument when use the function. 2. In expression 1ULL << irq, left shifting by more than 63 bits has undefined behavior. And out-of-bounds access error occured when

[PATCH 1/5] target/loongarch/cpu: Fix cpu_class_by_name function

In loongarch_cpu_class_by_name(char *cpu_model) function, the argument cpu_model already has the suffix '-loongarch-cpu', so we should remove the LOONGARCH_CPU_TYPE_NAME(cpu_model) macro. Signed-off-by: Xiaojuan Yang --- target/loongarch/cpu.c | 5 + 1 file changed, 1 insertion(+), 4 deletio

Re: [PATCH RESEND] python/machine: Fix AF_UNIX path too long on macOS

On Mon, Jul 11, 2022 at 04:56:28PM -0400, John Snow wrote: > On Thu, Jul 7, 2022 at 2:46 PM Peter Delevoryas wrote: > > > > On Wed, Jul 06, 2022 at 05:52:48PM -0700, Peter Delevoryas wrote: > > > On Wed, Jul 06, 2022 at 09:46:48AM -0700, Peter Delevoryas wrote: > > > > On Wed, Jul 06, 2022 at 09:0

[PATCH 3/5] target/loongarch/cpu: Fix coverity errors about excp_names

Fix out-of-bounds errors when access excp_names[] array. the valid boundary size of excp_names should be 0 to ARRAY_SIZE(excp_names)-1. However, the general code do not consider the max boundary. Fix coverity CID: 1489758 Signed-off-by: Xiaojuan Yang --- target/loongarch/cpu.c | 6 +++--- 1 fil

[PATCH 5/6] hw/loongarch: Add acpi ged support

Loongarch virt machine uses general hardware reduces acpi method, rather than LS7A acpi device. Now only power management function is used in acpi ged device, memory hotplug will be added later. Also acpi tables such as RSDP/RSDT/FADT etc. The acpi table has submited to acpi spec, and will release

[PATCH v1 0/5] Fix LoongArch coverity error and cpu name bug

This series fix some errors for LoongArch virt machine 1. Fix coverity errors such as out-of-bounds, integer overflow, cond_at_most, etc. 2. Fix loongarch_cpu_class_by_name function. Xiaojuan Yang (5): target/loongarch/cpu: Fix cpu_class_by_name function hw/intc/loongarch_pch_pic: Fix coverity

[PATCH v1 0/6] Support booting bios and kernel for LoongArch

This series add some new funcitons for LoongArch virt machine. Support loading uefi bios and linux kernel to boot system, and add fw_cfg table, smbios table, acpi table, fdt table to transmit information for the system. We could get the uefi bios and linux kernel file by this address: The kernel

[PATCH 4/6] hw/loongarch: Add smbios support

Add smbios support for loongarch virt machine, and put them into fw_cfg table so that bios can parse them quickly. The weblink of smbios spec: https://www.dmtf.org/dsp/DSP0134, the version is 3.6.0. Signed-off-by: Xiaojuan Yang --- hw/loongarch/Kconfig| 1 + hw/loongarch/loongson3.c

[PATCH 2/6] hw/loongarch: Add uefi bios loading support

Add uefi bios loading support, now only uefi bios is porting to loongarch virt machine. Signed-off-by: Xiaojuan Yang --- hw/loongarch/loongson3.c| 34 ++ include/hw/loongarch/virt.h | 4 2 files changed, 38 insertions(+) diff --git a/hw/loongarch/loongs

[PATCH 1/6] hw/loongarch: Add fw_cfg table support

Add fw_cfg table for loongarch virt machine, including memmap table. Signed-off-by: Xiaojuan Yang --- hw/loongarch/fw_cfg.c | 33 ++ hw/loongarch/fw_cfg.h | 15 hw/loongarch/loongson3.c| 47 - hw/loongarch/m

Re: lcitool update required

On Tue, Jul 12, 2022 at 12:31:35PM +0530, Richard Henderson wrote: > Hi guys, > > Cirrus FreeBSD builds are now broken, because we're trying to install py38-* > packages that no longer exist. There was, yesterday, an update to lcitool > that addresses this. However in the meantime there has been

Re: [PULL 06/18] vfio-user: build library

On Wed, Jun 15, 2022 at 04:51:17PM +0100, Stefan Hajnoczi wrote: > From: Jagannathan Raman > > add the libvfio-user library as a submodule. build it as a meson > subproject. > > libvfio-user is distributed with BSD 3-Clause license and > json-c with MIT (Expat) license > > Signed-off-by: Elena

Re: [RFC PATCH v9 12/23] vhost: Add opaque member to SVQElement

On Tue, Jul 12, 2022 at 4:33 PM Eugenio Perez Martin wrote: > > On Tue, Jul 12, 2022 at 9:53 AM Jason Wang wrote: > > > > > > 在 2022/7/11 17:56, Eugenio Perez Martin 写道: > > > On Mon, Jul 11, 2022 at 11:05 AM Jason Wang wrote: > > >> > > >> 在 2022/7/7 02:39, Eugenio Pérez 写道: > > >>> When qemu i

Re: [PATCH] target/ppc/kvm: Skip ".." directory in kvmppc_find_cpu_dt

On Mon, Jul 11, 2022 at 04:37:43PM -0300, Murilo Opsfelder Araujo wrote: > Some systems have /proc/device-tree/cpus/../clock-frequency. However, > this is not the expected path for a CPU device tree directory. > > Signed-off-by: Murilo Opsfelder Araujo > Signed-off-by: Fabiano Rosas > --- > tar

[PATCH 3/6] hw/loongarch: Add linux kernel booting support

There are two situations to start system by kernel file. If exists bios option, system will boot from loaded bios file, else system will boot from hardcoded auxcode, and jump to kernel elf entry. Signed-off-by: Xiaojuan Yang --- hw/loongarch/loongson3.c | 114 +---

[PATCH 6/6] hw/loongarch: Add fdt support

Add LoongArch flatted device tree, adding cpu device node, firmware cfg node, pcie node into it, and create fdt rom memory region. Now fdt info is not full since only uefi bios uses fdt, linux kernel does not use fdt. Loongarch Linux kernel uses acpi table which is full in qemu virt machine. Signe

Re: [RFC PATCH v9 12/23] vhost: Add opaque member to SVQElement

On Tue, Jul 12, 2022 at 9:53 AM Jason Wang wrote: > > > 在 2022/7/11 17:56, Eugenio Perez Martin 写道: > > On Mon, Jul 11, 2022 at 11:05 AM Jason Wang wrote: > >> > >> 在 2022/7/7 02:39, Eugenio Pérez 写道: > >>> When qemu injects buffers to the vdpa device it will be used to maintain > >>> contextual

Re: [PATCH v6 09/10] i386/pc: relocate 4g start to 1T where applicable

On Mon, 11 Jul 2022 21:03:28 +0100 Joao Martins wrote: > On 7/11/22 16:31, Joao Martins wrote: > > On 7/11/22 15:52, Joao Martins wrote: > >> On 7/11/22 13:56, Igor Mammedov wrote: > >>> On Fri, 1 Jul 2022 17:10:13 +0100 > >>> Joao Martins wrote: > >>> > diff --git a/hw/i386/pc.c b/h

[PATCH] MAINTAINERS: Add myself as Guest Agent reviewer

Signed-off-by: Konstantin Kostiuk --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 450abd0252..b1e73d99f3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2880,6 +2880,7 @@ T: git https://repo.or.cz/qemu/armbru.git qapi-next QEMU Guest Agent M:

Re: [PATCH v6 03/10] i386/pc: pass pci_hole64_size to pc_memory_init()

On 7/11/22 23:17, B wrote: > Am 11. Juli 2022 10:01:49 UTC schrieb Joao Martins > : >> On 7/9/22 21:51, B wrote: >>> Am 1. Juli 2022 16:10:07 UTC schrieb Joao Martins >>> : Use the pre-initialized pci-host qdev and fetch the pci-hole64-size into pc_memory_init() newly added argument. >>

Re: [PATCH v4 0/2] qga: add command 'guest-get-cpustats'

Queued, thanks. On Thu, Jul 7, 2022 at 4:01 AM zhenwei pi wrote: > v3 -> v4: > - Separate qapi script change from qga. > > v2 -> v3: > - Rename 'GuestOsType' to 'GuestCpuStatsType'. > - Add 'linux' into polluted_words, rename 'linuxos' to 'linux'. Remove > 'windows' from 'GuestCpuStatsType', b

Re: [PATCH 6/9] error-report: add a callback to overwrite error_vprintf

Hi On Thu, Jul 7, 2022 at 10:05 PM Marc-André Lureau < marcandre.lur...@gmail.com> wrote: > Hi > > On Thu, Jul 7, 2022 at 4:18 PM Markus Armbruster > wrote: > >> marcandre.lur...@redhat.com writes: >> >> > From: Marc-André Lureau >> > >> > error_vprintf() is implemented in monitor.c, which over

Re: [PATCH v2] memory: prevent dma-reentracy issues

On Tue, Jun 21, 2022 at 11:53:06AM -0400, Alexander Bulekov wrote: > On 220621 1630, Peter Maydell wrote: > > On Thu, 9 Jun 2022 at 14:59, Alexander Bulekov wrote: > > > diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h > > > index 44dacfa224..ab1ad0f7a8 100644 > > > --- a/include/hw/pci/pc

[PATCH v2 00/15] Preliminary patches for subproject split

From: Marc-André Lureau Hi, Here is another subset of the large "subproject(qga)"" series I intend to send soon after (https://gitlab.com/marcandre.lureau/qemu/-/commits/qga). Thanks v2: - drop error_init() callbacks, use static library symbol override instead - include a few patches from th

[PATCH v2 04/15] error-report: introduce overridable error_is_detailed()

From: Marc-André Lureau Remove the direct dependency from error-report to monitor code. This will allow to move error-report to a subproject. Signed-off-by: Marc-André Lureau --- include/qemu/error-report.h | 2 ++ softmmu/vl.c| 5 + stubs/error-is-detailed.c | 7 +++

[PATCH v2 03/15] error-report: simplify print_loc()

From: Marc-André Lureau Pass the program name as "prefix" argument to print_loc() if printing with "details". This allows to get rid of monitor_cur() call in print_loc(). Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster --- util/error-report.c | 8 1 file changed, 4 in

[PATCH v2 01/15] error-report: misc comment fix

From: Marc-André Lureau Missed in commit beeb175c0d "util/qemu-error: Rename error_print_loc() to be more generic". Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster --- util/error-report.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/error-report.c b

[PATCH v2 02/15] error-report: introduce "detailed" variable

From: Marc-André Lureau Let's use a more explicit variable "detailed" instead of calling monitor_cur() multiple times. Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster --- util/error-report.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/util/error-re

[PATCH v2 06/15] qapi: move QEMU-specific dispatch code in monitor

From: Marc-André Lureau Make QMP-dispatch code free from QEMU-specific OOB dispatch/async coroutine handling. This will allow to move the base code to qemu-common, and clear other users from potential mis-ususe (QGA doesn't have OOB or coroutine). To do that, introduce an optional callback QmpDi

[PATCH v2 05/15] stubs: remove needless error_vprintf_unless_qmp()

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- stubs/error-printf.c | 5 - 1 file changed, 5 deletions(-) diff --git a/stubs/error-printf.c b/stubs/error-printf.c index 0e326d801059..1afa0f62ca26 100644 --- a/stubs/error-printf.c +++ b/stubs/error-printf.c @@ -16,8 +16,3 @@ i

Re: [RFC PATCH v9 04/23] vhost: Get vring base from vq, not svq

On Tue, Jul 12, 2022 at 9:42 AM Jason Wang wrote: > > > 在 2022/7/8 18:10, Eugenio Perez Martin 写道: > > On Fri, Jul 8, 2022 at 11:12 AM Jason Wang wrote: > >> On Thu, Jul 7, 2022 at 2:40 AM Eugenio Pérez wrote: > >>> The used idx used to match with this, but it will not match from the > >>> momen

[PATCH v2 07/15] scripts/qapi-gen: add -i option

From: Marc-André Lureau Replace hard-coded "qemu/osdep.h" include with a qapi-gen option to specify the headers to include. This will allow to substitute QEMU osdep.h with glib.h for example, for projects with different global headers. For historical reasons, we can keep the default as "qemu/osd

[PATCH v2 09/15] util: move 256-by-128 division helpers to int128

From: Marc-André Lureau Break a cyclic dependency between int128 and host-utils. Signed-off-by: Marc-André Lureau --- include/qemu/host-utils.h | 3 - include/qemu/int128.h | 3 + util/host-utils.c | 180 -- util/int128.c | 180 ++

Re: [PATCH 2/3] hw/misc: Add mmio-debug-exit device

On Tue, 2022-07-12 at 10:42 +0530, Richard Henderson wrote: > On 7/12/22 00:26, Ilya Leoshkevich wrote: > > System tests on x86 use isa-debug-exit device in order to signal > > success or failure to the test runner. Unfortunately it's not > > easily > > usable on other architectures, since a guest

[PATCH v2 08/15] scripts/qapi: add required system includes to visitor

From: Marc-André Lureau The generated visitor code includes abort() & assert(), we shouldn't rely on the global "-i" headers to include the necessary system headers. Signed-off-by: Marc-André Lureau --- scripts/qapi/visit.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/qapi/vi

[PATCH v2 12/15] qemu-common: move glib-compat.h

From: Marc-André Lureau qemu-common will have compatible dependency requirements with QEMU. Since qemu-common won't have a toplevel qemu/osdep.h which would include various system headers, include stdbool.h (bool is used for some declarations here). Replace getenv() with g_getenv() to avoid ext

[PATCH v2 14/15] mtest2make.py: teach suite name that are just "PROJECT"

From: Marc-André Lureau A subproject test may be simply in the "PROJECT" suite (such as "qemu-common" with the following patches) Signed-off-by: Marc-André Lureau --- scripts/mtest2make.py | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/scripts/mtest2make.py b/script

[PATCH v2 10/15] qemu-common: introduce a common subproject

From: Marc-André Lureau Add a new meson subproject to provide common code and scripts for QEMU and tools. Initially, it will offer QAPI/QMP code generation and common utilities. libvhost-user & libvduse will make use of the subproject to avoid having include/ links to common headers. The other

[PATCH v2 13/15] qemu-common: move error-report

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- .../qemu-common/include}/qemu/error-report.h | 2 ++ .../qemu-common/src}/error-is-detailed.c | 1 - .../qemu-common/src}/error-report.c | 4 +++- .../qemu-common/src/error-vprintf.c | 5 ++--- stubs/meso

[COMMITTED 2/3] iotests: fix copy-before-write for macOS and FreeBSD

From: Vladimir Sementsov-Ogievskiy strerror() represents ETIMEDOUT a bit different in Linux and macOS / FreeBSD. Let's support the latter too. Fixes: 9d05a87b77 ("iotests: copy-before-write: add cases for cbw-timeout option") Signed-off-by: Vladimir Sementsov-Ogievskiy Tested-by: Thomas Huth

[PATCH v2 11/15] qemu-common: move scripts/qapi

From: Marc-André Lureau This is just moving qapi-gen.py and related subdir to qemu-common, to ease review and proceed step by step. The following patches will move related necessary code, tests etc. Signed-off-by: Marc-André Lureau --- docs/conf.py | 2 +- mes

Re: [PATCH v6 09/10] i386/pc: relocate 4g start to 1T where applicable

On 7/12/22 10:06, Igor Mammedov wrote: > On Mon, 11 Jul 2022 21:03:28 +0100 > Joao Martins wrote: > >> On 7/11/22 16:31, Joao Martins wrote: >>> On 7/11/22 15:52, Joao Martins wrote: On 7/11/22 13:56, Igor Mammedov wrote: > On Fri, 1 Jul 2022 17:10:13 +0100 > Joao Martins wrote

Re: [RFC PATCH v9 20/23] vdpa: Buffer CVQ support on shadow virtqueue

On Tue, Jul 12, 2022 at 9:18 AM Jason Wang wrote: > > > 在 2022/7/7 02:40, Eugenio Pérez 写道: > > Introduce the control virtqueue support for vDPA shadow virtqueue. This > > is needed for advanced networking features like multiqueue. > > > > Virtio-net control VQ will copy the descriptors to qemu's

[COMMITTED 0/3] build fixes

This is a collection of fixes required to get CI back to green. Given that 2 of 3 apply to cirrus, I had to push them to staging to even try them. Since it worked, I've now pushed them to master. r~ Richard Henderson (1): gitlab-ci/cirrus: Update freebsd to python 3.9 packages Vladimir Seme

[PATCH v2 15/15] qemu-common: add error-report test

From: Marc-André Lureau Add new tests to check the behaviour of error reporting functions. Signed-off-by: Marc-André Lureau --- .../qemu-common/tests/test-error-report.c | 120 ++ subprojects/qemu-common/meson.build | 2 + subprojects/qemu-common/tests/meson.bui

[COMMITTED 1/3] gitlab-ci/cirrus: Update freebsd to python 3.9 packages

FreeBSD has stopped shipping python 3.8, causing our cirrus builds to fail immediately. Upstream lcitool has an update to address this, but has also reorganized its source tree so additional changes are required for 'make lcitool-update'. In the meantime, fix the build. Signed-off-by: Richard He

Re: [PATCH v3 3/3] aspeed: Add fby35-bmc slot GPIO's

On 7/12/22 04:32, Peter Delevoryas wrote: Signed-off-by: Peter Delevoryas Reviewed-by: Cédric Le Goater Thanks, C. --- hw/arm/aspeed.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index 6fe9b13548..0ce9a42c2b 1006

Re: [COMMITTED 0/3] build fixes

On Tue, Jul 12, 2022 at 03:28:58PM +0530, Richard Henderson wrote: > This is a collection of fixes required to get CI back to green. > Given that 2 of 3 apply to cirrus, I had to push them to staging to > even try them. Since it worked, I've now pushed them to master. FWIW, it is possible to test

[COMMITTED 3/3] iotests/copy-before-write: specify required_fmts

From: Vladimir Sementsov-Ogievskiy Declare that we need copy-before-write filter to avoid failure when filter is not whitelisted. Signed-off-by: Vladimir Sementsov-Ogievskiy Tested-by: Thomas Huth Message-Id: <20220706170834.242277-1-vsement...@yandex-team.ru> Signed-off-by: Richard Henderson

Re: [PATCH] gtk: Add show_tabs=on|off command line option.

On 12.07.22 09:35, Felix Queißner wrote: Heya! On 27.06.22 18:44, Felix xq Queißner wrote: The patch adds "show_tabs" command line option for GTK ui similar to "grab_on_hover". This option allows tabbed view mode to not have to be enabled by hand at each start of the VM. On 30.06.22 16:09, H

Re: [PATCH 5/5] target/loongarch/op_helper: Fix coverity cond_at_most error

On 7/12/22 13:31, Xiaojuan Yang wrote: The boundary size of cpucfg array should be 0 to 20. So, using index bigger than 20 to access cpucfg[] must be forbidden. Fix coverity CID: 1489760 Signed-off-by: Xiaojuan Yang --- target/loongarch/op_helper.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v6 09/10] i386/pc: relocate 4g start to 1T where applicable

On 7/12/22 11:01, Joao Martins wrote: > On 7/12/22 10:06, Igor Mammedov wrote: >> On Mon, 11 Jul 2022 21:03:28 +0100 >> Joao Martins wrote: >>> On 7/11/22 16:31, Joao Martins wrote: On 7/11/22 15:52, Joao Martins wrote: > On 7/11/22 13:56, Igor Mammedov wrote: >> On Fri, 1 Jul 20

Re: [PATCH 2/3] hw/misc: Add mmio-debug-exit device

On 12.07.22 11:52, Ilya Leoshkevich wrote: > On Tue, 2022-07-12 at 10:42 +0530, Richard Henderson wrote: >> On 7/12/22 00:26, Ilya Leoshkevich wrote: >>> System tests on x86 use isa-debug-exit device in order to signal >>> success or failure to the test runner. Unfortunately it's not >>> easily >>>

Re: [PATCH 2/5] hw/intc/loongarch_pch_pic: Fix coverity errors in update irq

On 7/12/22 13:31, Xiaojuan Yang wrote: Fix coverity errors: 1. In find_first_bit function, the 'size' argument need 'unsigned long' type, so we add the suffix 'UL' on 'size' argument when use the function. 2. In expression 1ULL << irq, left shifting by more than 63 bits has undefined behavior. An

Re: [COMMITTED 0/3] build fixes

On 7/12/22 15:43, Daniel P. Berrangé wrote: On Tue, Jul 12, 2022 at 03:28:58PM +0530, Richard Henderson wrote: This is a collection of fixes required to get CI back to green. Given that 2 of 3 apply to cirrus, I had to push them to staging to even try them. Since it worked, I've now pushed them

Re: [PATCH 2/3] hw/misc: Add mmio-debug-exit device

On 12.07.22 11:52, Ilya Leoshkevich wrote: > On Tue, 2022-07-12 at 10:42 +0530, Richard Henderson wrote: >> On 7/12/22 00:26, Ilya Leoshkevich wrote: >>> System tests on x86 use isa-debug-exit device in order to signal >>> success or failure to the test runner. Unfortunately it's not >>> easily >>>

Re: [PATCH 1/5] target/loongarch/cpu: Fix cpu_class_by_name function

On 7/12/22 13:31, Xiaojuan Yang wrote: In loongarch_cpu_class_by_name(char *cpu_model) function, the argument cpu_model already has the suffix '-loongarch-cpu', so we should remove the LOONGARCH_CPU_TYPE_NAME(cpu_model) macro. Signed-off-by: Xiaojuan Yang --- target/loongarch/cpu.c | 5 +

Re: [COMMITTED 0/3] build fixes

On Tue, Jul 12, 2022 at 03:56:54PM +0530, Richard Henderson wrote: > On 7/12/22 15:43, Daniel P. Berrangé wrote: > > On Tue, Jul 12, 2022 at 03:28:58PM +0530, Richard Henderson wrote: > > > This is a collection of fixes required to get CI back to green. > > > Given that 2 of 3 apply to cirrus, I ha

[RFC PATCH] docs/devel: fix description of OBJECT_DECLARE_SIMPLE_TYPE

Since 30b5707c26 (qom: Remove module_obj_name parameter from OBJECT_DECLARE* macros) we don't need the additional two parameters. Fix the documentation. Signed-off-by: Alex Bennée --- docs/devel/qom.rst | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/devel/qom.rst b/do

Re: [PATCH 3/5] target/loongarch/cpu: Fix coverity errors about excp_names

On 7/12/22 13:31, Xiaojuan Yang wrote: Fix out-of-bounds errors when access excp_names[] array. the valid boundary size of excp_names should be 0 to ARRAY_SIZE(excp_names)-1. However, the general code do not consider the max boundary. Fix coverity CID: 1489758 Signed-off-by: Xiaojuan Yang ---

Re: [PATCH v3 1/3] qtest/aspeed_gpio: Add input pin modification test

On 7/12/22 04:32, Peter Delevoryas wrote: Verify the current behavior, which is that input pins can be modified by guest OS register writes. Signed-off-by: Peter Delevoryas Reviewed-by: Cédric Le Goater Thanks, C. --- tests/qtest/aspeed_gpio-test.c | 27 +++ 1

Re: [PATCH 4/5] target/loongarch/tlb_helper: Fix coverity integer overflow error

On 7/12/22 13:31, Xiaojuan Yang wrote: Replace '1' with '1UL' to fix unintentional integer overflow errors in tlb_helper file. Fix coverity CID: 1489759 1489762 Signed-off-by: Xiaojuan Yang --- target/loongarch/tlb_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --g

Re: [PATCH 2/3] hw/misc: Add mmio-debug-exit device

On Tue, 2022-07-12 at 12:08 +0200, David Hildenbrand wrote: > On 12.07.22 11:52, Ilya Leoshkevich wrote: > > On Tue, 2022-07-12 at 10:42 +0530, Richard Henderson wrote: > > > On 7/12/22 00:26, Ilya Leoshkevich wrote: > > > > System tests on x86 use isa-debug-exit device in order to > > > > signal >

Re: [RFC PATCH] docs/devel: fix description of OBJECT_DECLARE_SIMPLE_TYPE

On 7/12/22 16:01, Alex Bennée wrote: Since 30b5707c26 (qom: Remove module_obj_name parameter from OBJECT_DECLARE* macros) we don't need the additional two parameters. Fix the documentation. Signed-off-by: Alex Bennée --- docs/devel/qom.rst | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(

[PATCH v2 2/2] vhost-user: Support vhost_dev_start

The motivation of adding vhost-user vhost_dev_start support is to improve backend configuration speed and reduce live migration VM downtime. Today VQ configuration is issued one by one. For virtio net with multi-queue support, backend needs to update RSS (Receive side scaling) on every rx queue en

[PATCH v2 1/2] vhost: Change the sequence of device start

This patch is part of adding vhost-user vhost_dev_start support. The motivation is to improve backend configuration speed and reduce live migration VM downtime. Moving the device start routines after finishing all the necessary device and VQ configuration, further aligning to the virtio specificat

[PATCH v2 0/2] vhost-user: Support vhost_dev_start

The motivation of adding vhost-user vhost_dev_start support is to improve backend configuration speed and reduce live migration VM downtime. Today VQ configuration is issued one by one. For virtio net with multi-queue support, backend needs to update RSS (Receive side scaling) on every rx queue en

Re: [RISU PATCH v4 22/29] ppc64: Use uint64_t to represent double

On 08/07/2022 12:46, Richard Henderson wrote: We want to do exact bitwise comparisons of the data, not be held hostage to IEEE comparisons and NaNs. Signed-off-by: Richard Henderson --- risu_reginfo_ppc64.h | 3 ++- risu_reginfo_ppc64.c | 29 + 2 files changed,

Re: [RISU PATCH v4 26/29] ppc64: Clean up reginfo handling

On 08/07/2022 12:46, Richard Henderson wrote: Several of the gp_reg[] elements are not relevant -- e.g. orig r3, which is related to system calls. Omit those from the original reginfo_init(), so that any differences are automatically hidden. Do not only compare bit 4 of CCR -- this register is

Re: [PATCH v6 09/10] i386/pc: relocate 4g start to 1T where applicable

On 7/12/22 11:01, Joao Martins wrote: > On 7/12/22 10:06, Igor Mammedov wrote: >> On Mon, 11 Jul 2022 21:03:28 +0100 >> Joao Martins wrote: >>> On 7/11/22 16:31, Joao Martins wrote: On 7/11/22 15:52, Joao Martins wrote: > On 7/11/22 13:56, Igor Mammedov wrote: >> On Fri, 1 Jul 20

Re: [PATCH 0/2] gitlab-ci: msys2 improvements

Hi On Tue, Jul 12, 2022 at 10:10 AM Richard Henderson wrote: > > On 7/12/22 09:24, Richard Henderson wrote: > > On 7/11/22 13:26, marcandre.lur...@redhat.com wrote: > >> From: Marc-André Lureau > >> > >> Hi > >> > >> This is a small series to attempt to debug "Intermittent meson failures on > >>

Re: [PATCH 0/3] qemu/qsd: Unlink absolute PID file path

Ping On 09.06.22 14:26, Hanna Reitz wrote: Hi, QEMU (the system emulator) and the storage daemon (QSD) write their PID to the given file when you specify --pidfile. They keep the path around and register exit handlers (QEMU uses an exit notifier, QSD an atexit() function) to unlink this file w

Re: [PATCH v6 12/13] qemu-sockets: update socket_uri() to be consistent with socket_parse()

* Laurent Vivier (lviv...@redhat.com) wrote: > Remove 'tcp:' prefix for inet type (because inet can be 'tcp' or 'udp' > and socket_parse() doesn't recognize it), the format is 'host:port'. I don't think I understand why tests/qtest/migration-test.c test_precopy_common is happy with this; it does:

  1   2   3   4   >