Re: [PATCH v2 8/8] aspeed: Add AST2600 (BMC) to fby35

2022-06-28 Thread Cédric Le Goater
On 6/24/22 02:37, Peter Delevoryas wrote: You can test booting the BMC with both '-device loader' and '-drive file'. This is necessary because of how the fb-openbmc boot sequence works (jump to 0x2000 after U-Boot SPL). wget https://github.com/facebook/openbmc/releases/download/openbm

[PULL 52/60] semihosting: Remove qemu_semihosting_console_outs

2022-06-28 Thread Richard Henderson
This function has been replaced by *_write. Reviewed-by: Luc Michel Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- include/semihosting/console.h | 13 -- linux-user/semihost.c | 17 semihosting/console.c | 49 -

[PULL 07/60] semihosting: Simplify softmmu_lock_user_string

2022-06-28 Thread Richard Henderson
We are not currently bounding the search to the 1024 bytes that we allocated, possibly overrunning the buffer. Use softmmu_strlen_user to find the length and allocate the correct size from the beginning. Reviewed-by: Alex Bennée Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- s

[PULL 45/60] semihosting: Create qemu_semihosting_console_write

2022-06-28 Thread Richard Henderson
Will replace qemu_semihosting_console_{outs,outc}, but we need more plumbing first. Reviewed-by: Luc Michel Signed-off-by: Richard Henderson --- include/semihosting/console.h | 12 linux-user/semihost.c | 5 + semihosting/console.c | 9 + 3 files chang

Re: [PATCH v2 7/8] aspeed: Make aspeed_board_init_flashes public

2022-06-28 Thread Cédric Le Goater
On 6/24/22 02:37, Peter Delevoryas wrote: Signed-off-by: Peter Delevoryas Reviewed-by: Cédric Le Goater Thanks, C. --- hw/arm/aspeed.c | 25 - hw/arm/aspeed_soc.c | 26 ++ include/hw/arm/aspeed_soc.h | 2 ++ 3 file

[PULL 54/60] target/m68k: Eliminate m68k_semi_is_fseek

2022-06-28 Thread Richard Henderson
Reorg m68k_semi_return_* to gdb_syscall_complete_cb. Use the 32-bit version normally, and the 64-bit version for HOSTED_LSEEK. Reviewed-by: Laurent Vivier Signed-off-by: Richard Henderson --- target/m68k/m68k-semi.c | 55 + 1 file changed, 23 insertions(+

[PULL 46/60] semihosting: Add GuestFDConsole

2022-06-28 Thread Richard Henderson
Add a GuestFDType for connecting to the semihosting console. Hook up to read, write, isatty, and fstat syscalls. Note that the arm-specific syscall flen cannot be applied to the console, because the console is not a descriptor exposed to the guest. Reviewed-by: Luc Michel Reviewed-by: Alex Benné

[PULL 08/60] semihosting: Split out guestfd.c

2022-06-28 Thread Richard Henderson
In arm-compat-semi.c, we have more advanced treatment of guest file descriptors than we do in other implementations. Split out GuestFD and related functions to a new file so that they can be shared. Reviewed-by: Alex Bennée Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- config

Re: [PATCH v2 3/4] hw/nvme: add support for ratified TP4084

2022-06-28 Thread Klaus Jensen
On Jun 27 13:47, Niklas Cassel wrote: > TP4084 adds a new mode, CC.CRIME, that can be used to mark a namespace > as ready independently from the controller. > > When CC.CRIME is 0 (default), things behave as before, all namespaces > are ready when CSTS.RDY gets set to 1. > > When CC.CRIME is 1, t

[PULL 58/60] target/mips: Drop pread and pwrite syscalls from semihosting

2022-06-28 Thread Richard Henderson
We don't implement it with _WIN32 hosts, and the syscalls are missing from the gdb remote file i/o interface. Since we can't implement them universally, drop them. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/mips/tcg/sysemu/mips-semi.c | 39 ++

[PULL 48/60] semihosting: Use console_in_gf for SYS_READC

2022-06-28 Thread Richard Henderson
Reviewed-by: Luc Michel Signed-off-by: Richard Henderson --- semihosting/arm-compat-semi.c | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/semihosting/arm-compat-semi.c b/semihosting/arm-compat-semi.c index fdb143ace8..9d4d6d2812 100644 --- a/semi

[PULL 11/60] semihosting: Clean up common_semi_flen_cb

2022-06-28 Thread Richard Henderson
Do not read from the gdb struct stat buffer if the callback is reporting an error. Use common_semi_cb to finish returning results. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- semihosting/arm-compat-semi.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions

[PULL 60/60] target/nios2: Move nios2-semi.c to nios2_softmmu_ss

2022-06-28 Thread Richard Henderson
Semihosting is not enabled for nios2-linux-user. Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/nios2/nios2-semi.c | 5 - target/nios2/meson.build | 4 ++-- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/target/ni

[PULL 57/60] target/mips: Add UHI errno values

2022-06-28 Thread Richard Henderson
>From the Unified Hosting Interface, MD01069 Reference Manual, version 1.1.6, 06 July 2015. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/mips/tcg/sysemu/mips-semi.c | 40 ++ 1 file changed, 40 insertions(+) diff --git a/target/mips

Re: [PATCH v2 2/4] hw/nvme: store a pointer to the NvmeSubsystem in the NvmeNamespace

2022-06-28 Thread Klaus Jensen
On Jun 27 13:47, Niklas Cassel wrote: > Each NvmeNamespace can be used by serveral controllers, > but a NvmeNamespace can at most belong to a single NvmeSubsystem. > Store a pointer to the NvmeSubsystem, if the namespace was realized > with a NvmeSubsystem. > > This will be used by a follow up pat

[PULL 15/60] semihosting: Remove GDB_O_BINARY

2022-06-28 Thread Richard Henderson
The value is zero, and gdb always opens files in binary mode. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- semihosting/arm-compat-semi.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/semihosting/arm-compat-semi.c b/semihosting/arm-compat-semi

Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests

2022-06-28 Thread Ani Sinha
On Tue, Jun 28, 2022 at 11:36 AM Michael S. Tsirkin wrote: > > On Tue, Jun 28, 2022 at 10:27:38AM +0530, Ani Sinha wrote: > > On Tue, Jun 28, 2022 at 3:56 AM Michael S. Tsirkin wrote: > > > > > > On Mon, Jun 27, 2022 at 12:58:55PM +0530, Ani Sinha wrote: > > > > The README file is added describin

[PULL 16/60] include/exec: Move gdb open flags to gdbstub.h

2022-06-28 Thread Richard Henderson
There were 3 copies of these flags. Place them in the file with gdb_do_syscall, with which they belong. Reviewed-by: Alex Bennée Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- include/exec/gdbstub.h| 9 + semihosting/arm-compat-semi.c | 7 --- target/m68k/

Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests

2022-06-28 Thread Michael S. Tsirkin
On Tue, Jun 28, 2022 at 10:27:38AM +0530, Ani Sinha wrote: > On Tue, Jun 28, 2022 at 3:56 AM Michael S. Tsirkin wrote: > > > > On Mon, Jun 27, 2022 at 12:58:55PM +0530, Ani Sinha wrote: > > > The README file is added describing the directory structure and the > > > purpose > > > of every file it

Re: [PATCH 07/14] aspeed: Add PECI controller

2022-06-28 Thread Cédric Le Goater
On 6/27/22 21:54, Peter Delevoryas wrote: Could we have some short intro ? :) Signed-off-by: Peter Delevoryas --- hw/arm/aspeed_ast10x0.c | 11 ++ hw/misc/aspeed_peci.c | 225 ++ hw/misc/meson.build | 3 +- include/hw/arm/aspeed_s

[PULL 20/60] semihosting: Use struct gdb_stat in common_semi_flen_cb

2022-06-28 Thread Richard Henderson
Load the entire 64-bit size value. While we're at it, use offsetof instead of an integer constant. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- semihosting/arm-compat-semi.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/semihosting/arm-co

Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests

2022-06-28 Thread Michael S. Tsirkin
On Tue, Jun 28, 2022 at 12:06:31PM +0530, Ani Sinha wrote: > On Tue, Jun 28, 2022 at 11:50 AM Michael S. Tsirkin wrote: > > > > On Tue, Jun 28, 2022 at 11:46:13AM +0530, Ani Sinha wrote: > > > On Tue, Jun 28, 2022 at 11:36 AM Michael S. Tsirkin > > > wrote: > > > > > > > > On Tue, Jun 28, 2022 a

Re: [PATCH v2 4/4] hw/nvme: add new never_ready parameter to test the DNR bit

2022-06-28 Thread Klaus Jensen
On Jun 27 13:47, Niklas Cassel wrote: > Since we verify that "ready_delay" parameter has to be smaller than CRWMT, > we know that the namespace will always become ready. > Therefore the "Namespace Not Ready" status code will never have the DNR > bit set. > > Add a new parameter "never_ready" that

[PULL 22/60] semihosting: Split common_semi_flen_buf per target

2022-06-28 Thread Richard Henderson
We already have some larger ifdef blocks for ARM and RISCV; split out common_semi_stack_bottom per target. Reviewed-by: Peter Maydell Reviewed-by: Alistair Francis Signed-off-by: Richard Henderson --- semihosting/arm-compat-semi.c | 44 +-- 1 file changed, 21 in

Re: [PATCH 08/14] hw/misc: Add fby35-cpld

2022-06-28 Thread Cédric Le Goater
On 6/27/22 21:55, Peter Delevoryas wrote: Signed-off-by: Peter Delevoryas some intro ? --- hw/misc/fby35_cpld.c | 137 +++ hw/misc/meson.build | 3 +- 2 files changed, 139 insertions(+), 1 deletion(-) create mode 100644 hw/misc/fby35_cpld.c

Re: [RFC v3 1/5] block: add block layer APIs resembling Linux ZonedBlockDevice ioctls.

2022-06-28 Thread Stefan Hajnoczi
On Mon, Jun 27, 2022 at 08:19:13AM +0800, Sam Li wrote: > diff --git a/block/block-backend.c b/block/block-backend.c > index e0e1aff4b1..786f964d02 100644 > --- a/block/block-backend.c > +++ b/block/block-backend.c > @@ -1810,6 +1810,62 @@ int blk_flush(BlockBackend *blk) > return ret; > } >

Re: [RFC PATCH] qemu-options: bring the kernel and image options together

2022-06-28 Thread Cédric Le Goater
On 6/23/22 12:21, Alex Bennée wrote: Cédric Le Goater writes: On 6/22/22 16:50, Alex Bennée wrote: How to control the booting of QEMU is often a source of confusion for users. Bring the options that control this together in the manual pages and add some verbiage to describe when each option

Re: [PATCH 09/14] pmbus: Reset out buf after switching pages

2022-06-28 Thread Cédric Le Goater
On 6/27/22 21:55, Peter Delevoryas wrote: Signed-off-by: Peter Delevoryas is that a bug ? --- hw/i2c/pmbus_device.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c index 62885fa6a1..efddc36fd9 100644 --- a/hw/i2c/pmbus_device.c +++ b/hw/i

[PULL 25/60] semihosting: Use env more often in do_common_semihosting

2022-06-28 Thread Richard Henderson
We've already loaded cs->env_ptr into a local variable; use it. Since env is unconditionally used, we don't need a dummy use. Reviewed-by: Luc Michel Signed-off-by: Richard Henderson --- semihosting/arm-compat-semi.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/sem

Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests

2022-06-28 Thread Ani Sinha
On Tue, Jun 28, 2022 at 11:50 AM Michael S. Tsirkin wrote: > > On Tue, Jun 28, 2022 at 11:46:13AM +0530, Ani Sinha wrote: > > On Tue, Jun 28, 2022 at 11:36 AM Michael S. Tsirkin wrote: > > > > > > On Tue, Jun 28, 2022 at 10:27:38AM +0530, Ani Sinha wrote: > > > > On Tue, Jun 28, 2022 at 3:56 AM M

Re: [PATCH v2 8/8] aspeed: Add AST2600 (BMC) to fby35

2022-06-28 Thread Peter Delevoryas
> On Jun 27, 2022, at 10:01 PM, Cédric Le Goater wrote: > > On 6/24/22 02:37, Peter Delevoryas wrote: >> You can test booting the BMC with both '-device loader' and '-drive >> file'. This is necessary because of how the fb-openbmc boot sequence >> works (jump to 0x2000 after U-Boot SPL). >>

[PULL 26/60] semihosting: Move GET_ARG/SET_ARG earlier in the file

2022-06-28 Thread Richard Henderson
Moving this to be useful for another function besides do_common_semihosting. Reviewed-by: Alex Bennée Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- semihosting/arm-compat-semi.c | 48 +-- 1 file changed, 24 insertions(+), 24 deletions(-) diff

Re: [PATCH 07/14] aspeed: Add PECI controller

2022-06-28 Thread Peter Delevoryas
> On Jun 27, 2022, at 11:47 PM, Cédric Le Goater wrote: > > On 6/27/22 21:54, Peter Delevoryas wrote: > > Could we have some short intro ? :) Yes, definitely, I’ll resubmit with some more details. > >> Signed-off-by: Peter Delevoryas >> --- >> hw/arm/aspeed_ast10x0.c | 11 ++ >> hw

Can legacy vga memory base address be defined different with architectures

2022-06-28 Thread maobibo
Hi Philippe, In file include/hw/pci/pci.h, the macro QEMU_PCI_VGA_MEM_BASE is defined as 0xa, which represents legacy VGA memory base address. I want to know whether it should be the same for all architectures, or does this vga mmio space exist on arm64/riscv physical machines with pci

Re: [PATCH 04/14] aspeed: i2c: Fix DMA len write-enable bit handling

2022-06-28 Thread Cédric Le Goater
On 6/27/22 21:54, Peter Delevoryas wrote: I noticed i2c rx transfers were getting shortened to "1" on Zephyr. It seems to be because the Zephyr i2c driver sets the RX DMA len with the RX field write-enable bit set (bit 31) to avoid a read-modify-write. [1] /* 0x1C : I2CM Master DMA Transfer Leng

[PULL 27/60] semihosting: Split out semihost_sys_open

2022-06-28 Thread Richard Henderson
Split out the non-ARM specific portions of SYS_OPEN to a reusable function. This handles gdb and host file i/o. Add helpers to validate the length of the filename string. Prepare for usage by other semihosting by allowing the filename length parameter to be 0, and calling strlen. Reviewed-by: Lu

Re: [PATCH 14/14] aspeed: Add I2C new register DMA slave mode support

2022-06-28 Thread Cédric Le Goater
On 6/28/22 00:27, Peter Delevoryas wrote: Signed-off-by: Peter Delevoryas Some Intro would be welcome. Please move the patch after Klaus patches. Thanks, C. --- hw/i2c/aspeed_i2c.c | 133 include/hw/i2c/aspeed_i2c.h | 3 + 2 files change

[PULL 33/60] semihosting: Split out semihost_sys_isatty

2022-06-28 Thread Richard Henderson
Split out the non-ARM specific portions of SYS_ISTTY to a reusable function. This handles all GuestFD. Add a common_semi_istty_cb helper to translate the Posix error return, 0+ENOTTY, to the Arm semihosting not-a-file success result. Reviewed-by: Luc Michel Signed-off-by: Richard Henderson ---

Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests

2022-06-28 Thread Ani Sinha
On Tue, Jun 28, 2022 at 12:20 PM Michael S. Tsirkin wrote: > > On Tue, Jun 28, 2022 at 12:06:31PM +0530, Ani Sinha wrote: > > On Tue, Jun 28, 2022 at 11:50 AM Michael S. Tsirkin wrote: > > > > > > On Tue, Jun 28, 2022 at 11:46:13AM +0530, Ani Sinha wrote: > > > > On Tue, Jun 28, 2022 at 11:36 AM

venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

2022-06-28 Thread Thomas Huth
On 28/06/2022 08.57, Ani Sinha wrote: On Tue, Jun 28, 2022 at 12:20 PM Michael S. Tsirkin wrote: On Tue, Jun 28, 2022 at 12:06:31PM +0530, Ani Sinha wrote: On Tue, Jun 28, 2022 at 11:50 AM Michael S. Tsirkin wrote: On Tue, Jun 28, 2022 at 11:46:13AM +0530, Ani Sinha wrote: On Tue, Jun 28,

Re: [PATCH 14/14] aspeed: Add I2C new register DMA slave mode support

2022-06-28 Thread Peter Delevoryas
> On Jun 28, 2022, at 12:02 AM, Cédric Le Goater wrote: > > On 6/28/22 00:27, Peter Delevoryas wrote: >> Signed-off-by: Peter Delevoryas > > Some Intro would be welcome. Please move the patch after Klaus patches. Yes, I’ll describe the state machine flow. That’s my bad. And I’ll move it to t

[PULL 37/60] semihosting: Split out semihost_sys_system

2022-06-28 Thread Richard Henderson
Split out the non-ARM specific portions of SYS_SYSTEM to a reusable function. Reviewed-by: Luc Michel Signed-off-by: Richard Henderson --- include/semihosting/syscalls.h | 3 +++ semihosting/arm-compat-semi.c | 12 +- semihosting/syscalls.c | 40 +++

Re: [PATCH 05/14] aspeed: i2c: Fix R_I2CD_FUN_CTRL reference

2022-06-28 Thread Cédric Le Goater
On 6/27/22 21:54, Peter Delevoryas wrote: Very minor, doesn't effect functionality, but this is supposed to be R_I2CC_FUN_CTRL (new-mode, not old-mode). Fixes: ba2cccd64e9 ("aspeed: i2c: Add new mode support") Signed-off-by: Peter Delevoryas --- Can you move this patch at beginning of the se

Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests

2022-06-28 Thread Ani Sinha
+danPb who pointed me to the TAP stuff. Maybe he has some good ideas on this. On Tue, Jun 28, 2022 at 12:27 PM Ani Sinha wrote: > > On Tue, Jun 28, 2022 at 12:20 PM Michael S. Tsirkin wrote: > > > > On Tue, Jun 28, 2022 at 12:06:31PM +0530, Ani Sinha wrote: > > > On Tue, Jun 28, 2022 at 11:50 AM

Re: [PATCH 09/14] pmbus: Reset out buf after switching pages

2022-06-28 Thread Peter Delevoryas
> On Jun 27, 2022, at 11:51 PM, Cédric Le Goater wrote: > > On 6/27/22 21:55, Peter Delevoryas wrote: >> Signed-off-by: Peter Delevoryas > > is that a bug ? I believe so yes, although I don’t really have any experience with real pmbus devices. But, I would assume that when you’re switching p

[PULL 39/60] semihosting: Create semihost_sys_gettimeofday

2022-06-28 Thread Richard Henderson
This syscall will be used by m68k and nios2 semihosting. Reviewed-by: Luc Michel Signed-off-by: Richard Henderson --- include/semihosting/syscalls.h | 3 +++ semihosting/syscalls.c | 42 ++ 2 files changed, 45 insertions(+) diff --git a/include/semihost

Re: [PATCH 12/14] hw/misc: Add intel-me

2022-06-28 Thread Peter Delevoryas
> On Jun 27, 2022, at 11:58 PM, Cédric Le Goater wrote: > > On 6/28/22 00:27, Peter Delevoryas wrote: >> Signed-off-by: Peter Delevoryas > > Intro ? Yep, will do > > I would rather have 2 patches, one for the slave model and one adding > a device to the machine. Got it, I’ll split it. >

Re: [PATCH 00/14] aspeed: Add I2C new register DMA slave mode support

2022-06-28 Thread Cédric Le Goater
On 6/27/22 21:54, Peter Delevoryas wrote: Hey everyone, I'm sending a big patch series for this, but only the last commit is really intended to be accepted right now. I'm just including the rest of them because it depends on them for testing. Klaus's changes include the multi-master stuff in hw

Re: [PATCH 00/14] aspeed: Add I2C new register DMA slave mode support

2022-06-28 Thread Peter Delevoryas
> On Jun 28, 2022, at 12:05 AM, Cédric Le Goater wrote: > > On 6/27/22 21:54, Peter Delevoryas wrote: >> Hey everyone, >> I'm sending a big patch series for this, but only the last commit is really >> intended to be accepted right now. I'm just including the rest of them >> because it depends o

[PULL 43/60] semihosting: Expand qemu_semihosting_console_inc to read

2022-06-28 Thread Richard Henderson
Allow more than one character to be read at one time. Will be used by m68k and nios2 semihosting for stdio. Reviewed-by: Luc Michel Signed-off-by: Richard Henderson --- include/semihosting/console.h | 12 +++- linux-user/semihost.c | 10 ++ semihosting/arm-compat-semi.c

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

2022-06-28 Thread Thomas Huth
On 28/06/2022 09.10, Michael S. Tsirkin wrote: On Tue, Jun 28, 2022 at 09:03:33AM +0200, Thomas Huth wrote: No problem with that. So that's venv. But do we need pip and pulling packages from the net during testing? We do that too. See requirements.txt in tests/ Following two are downloaded: av

Re: [PATCH 05/14] aspeed: i2c: Fix R_I2CD_FUN_CTRL reference

2022-06-28 Thread Peter Delevoryas
> On Jun 28, 2022, at 12:01 AM, Cédric Le Goater wrote: > > On 6/27/22 21:54, Peter Delevoryas wrote: >> Very minor, doesn't effect functionality, but this is supposed to be >> R_I2CC_FUN_CTRL (new-mode, not old-mode). >> Fixes: ba2cccd64e9 ("aspeed: i2c: Add new mode support") >> Signed-off-by

[PULL 44/60] semihosting: Cleanup chardev init

2022-06-28 Thread Richard Henderson
Rename qemu_semihosting_connect_chardevs to qemu_semihosting_chardev_init; pass the result directly to qemu_semihosting_console_init. Store the chardev in SemihostingConsole instead of SemihostingConfig, which lets us drop semihosting_get_chardev. Reviewed-by: Luc Michel Signed-off-by: Richard H

Re: [PATCH v4 3/7] iotests: add copy-before-write: on-cbw-error tests

2022-06-28 Thread Vladimir Sementsov-Ogievskiy
I had a long and not fun debugging session through gitlab pipelines with this:) The problem is that pure QEMUMachine doesn't work on arm in gitlab. And we have to specify at least machine. And we don't want qtest, as described in commit message. So, the following fix helps: On 4/7/22 16:27,

Re: [PATCH 09/12] acpi/tests/bits: add acpi and smbios python tests that uses biosbits

2022-06-28 Thread Ani Sinha
On Tue, Jun 28, 2022 at 12:50 PM Thomas Huth wrote: > > On 27/06/2022 09.28, Ani Sinha wrote: > > This change adds python based qtest framework that can be used to run > > qtests from within a virtual environment. A bash script creates the virtual > > environment and then runs the python based tes

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

2022-06-28 Thread Michael S. Tsirkin
On Tue, Jun 28, 2022 at 09:03:33AM +0200, Thomas Huth wrote: > > > > > > > No problem with that. So that's venv. But do we need pip and > > > > > > > pulling > > > > > > > packages from the net during testing? > > > > > > > > > > > > We do that too. See requirements.txt in tests/ > > > > > > Foll

[PULL 47/60] semihosting: Create qemu_semihosting_guestfd_init

2022-06-28 Thread Richard Henderson
For arm-compat, initialize console_{in,out}_gf; otherwise, initialize stdio file descriptors. This will go some way to cleaning up arm-compat, and will allow other semihosting to use normal stdio. Reviewed-by: Luc Michel Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- include/se

Re: [PATCH 09/12] acpi/tests/bits: add acpi and smbios python tests that uses biosbits

2022-06-28 Thread Thomas Huth
On 27/06/2022 09.28, Ani Sinha wrote: This change adds python based qtest framework that can be used to run qtests from within a virtual environment. A bash script creates the virtual environment and then runs the python based tests from within that environment. All dependent python packages are

Re: [PATCH 09/12] acpi/tests/bits: add acpi and smbios python tests that uses biosbits

2022-06-28 Thread Thomas Huth
On 28/06/2022 09.26, Ani Sinha wrote: On Tue, Jun 28, 2022 at 12:50 PM Thomas Huth wrote: On 27/06/2022 09.28, Ani Sinha wrote: This change adds python based qtest framework that can be used to run qtests from within a virtual environment. A bash script creates the virtual environment and the

[PULL 49/60] semihosting: Use console_out_gf for SYS_WRITEC

2022-06-28 Thread Richard Henderson
Reviewed-by: Luc Michel Signed-off-by: Richard Henderson --- semihosting/arm-compat-semi.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/semihosting/arm-compat-semi.c b/semihosting/arm-compat-semi.c index 9d4d6d2812..d61b773f98 100644 --- a/semihosting

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

2022-06-28 Thread Daniel P . Berrangé
On Tue, Jun 28, 2022 at 09:25:35AM +0200, Thomas Huth wrote: > On 28/06/2022 09.10, Michael S. Tsirkin wrote: > > On Tue, Jun 28, 2022 at 09:03:33AM +0200, Thomas Huth wrote: > > > > > > > > > No problem with that. So that's venv. But do we need pip and > > > > > > > > > pulling > > > > > > > > >

Re: [PATCH 04/12] acpi/tests/bits: initial commit of test scripts that are run by biosbits

2022-06-28 Thread Thomas Huth
On 27/06/2022 09.28, Ani Sinha wrote: This is initial commit of cpuid, acpi and smbios python test scripts for biosbits to execute. No change has been made to them from the original code written by the biosbits author Josh Triplett. They are required to be installed into the bits iso file and the

Re: [PATCH v7 10/18] jobs: rename static functions called with job_mutex held

2022-06-28 Thread Emanuele Giuseppe Esposito
Am 22/06/2022 um 20:38 schrieb Vladimir Sementsov-Ogievskiy: > On 6/22/22 17:26, Emanuele Giuseppe Esposito wrote: >> >> >> Am 21/06/2022 um 19:26 schrieb Vladimir Sementsov-Ogievskiy: >>> On 6/16/22 16:18, Emanuele Giuseppe Esposito wrote: With the*nop*  job_lock/unlock placed, rename the

[PULL 50/60] semihosting: Remove qemu_semihosting_console_outc

2022-06-28 Thread Richard Henderson
This function has been replaced by *_write. Reviewed-by: Luc Michel Signed-off-by: Richard Henderson --- include/semihosting/console.h | 13 - linux-user/semihost.c | 16 semihosting/console.c | 18 -- 3 files changed, 47 deletions(-)

Re: [RFC v3 1/5] block: add block layer APIs resembling Linux ZonedBlockDevice ioctls.

2022-06-28 Thread Sam Li
Stefan Hajnoczi 于2022年6月28日周二 14:52写道: > > On Mon, Jun 27, 2022 at 08:19:13AM +0800, Sam Li wrote: > > diff --git a/block/block-backend.c b/block/block-backend.c > > index e0e1aff4b1..786f964d02 100644 > > --- a/block/block-backend.c > > +++ b/block/block-backend.c > > @@ -1810,6 +1810,62 @@ int b

[PULL 55/60] target/m68k: Make semihosting system only

2022-06-28 Thread Richard Henderson
While we had a call to do_m68k_semihosting in linux-user, it wasn't actually reachable. We don't include DISAS_INSN(halt) as an instruction unless system mode. Reviewed-by: Laurent Vivier Signed-off-by: Richard Henderson --- linux-user/m68k/cpu_loop.c | 5 - target/m68k/m68k-semi.c| 3

Re: [PULL 22/33] migration: remove the QEMUFileOps 'get_buffer' callback

2022-06-28 Thread Daniel P . Berrangé
On Mon, Jun 27, 2022 at 04:32:00PM -0400, Peter Xu wrote: > On Mon, Jun 27, 2022 at 04:03:09PM +0100, Daniel P. Berrangé wrote: > > On Wed, Jun 22, 2022 at 03:34:52PM -0400, Peter Xu wrote: > > > On Wed, Jun 22, 2022 at 07:39:06PM +0100, Dr. David Alan Gilbert (git) > > > wrote: > > > > diff --git

Re: [PATCH v4 6/7] block/copy-before-write: implement cbw-timeout option

2022-06-28 Thread Vladimir Sementsov-Ogievskiy
While debugging my "[PULL 00/10] Block jobs & NBD patches", I found that we have bdrv_dec_in_flight() and bdrv_inc_in_flight(). So, this should be fixed: On 4/7/22 16:27, Vladimir Sementsov-Ogievskiy wrote: In some scenarios, when copy-before-write operations lasts too long time, it's better t

Re: [RFC v3 2/5] qemu-io: add zoned block device operations.

2022-06-28 Thread Stefan Hajnoczi
On Mon, Jun 27, 2022 at 08:19:14AM +0800, Sam Li wrote: > diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c > index 2f0d8ac25a..3f2592b9f5 100644 > --- a/qemu-io-cmds.c > +++ b/qemu-io-cmds.c > @@ -1706,6 +1706,122 @@ static const cmdinfo_t flush_cmd = { > .oneline= "flush all in-core file stat

[PULL 59/60] target/nios2: Eliminate nios2_semi_is_lseek

2022-06-28 Thread Richard Henderson
Reorg nios2_semi_return_* to gdb_syscall_complete_cb. Use the 32-bit version normally, and the 64-bit version for HOSTED_LSEEK. Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/nios2/nios2-semi.c | 59 +++

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

2022-06-28 Thread Ani Sinha
On Tue, Jun 28, 2022 at 12:55 PM Thomas Huth wrote: > > On 28/06/2022 09.10, Michael S. Tsirkin wrote: > > On Tue, Jun 28, 2022 at 09:03:33AM +0200, Thomas Huth wrote: > No problem with that. So that's venv. But do we need pip and pulling > packages from the net during testing? >

Re: [PATCH v1 2/2] migration/multifd: Warn user when zerocopy not working

2022-06-28 Thread Daniel P . Berrangé
On Mon, Jun 27, 2022 at 10:09:09PM -0300, Leonardo Bras wrote: > Some errors, like the lack of Scatter-Gather support by the network > interface(NETIF_F_SG) may cause sendmsg(...,MSG_ZEROCOPY) to fail on using > zero-copy, which causes it to fall back to the default copying mechanism. How common i

Re: [RFC v3 5/5] qemu-iotests: add zone operation tests.

2022-06-28 Thread Stefan Hajnoczi
On Mon, Jun 27, 2022 at 08:19:17AM +0800, Sam Li wrote: > diff --git a/tests/qemu-iotests/tests/zoned.sh > b/tests/qemu-iotests/tests/zoned.sh > new file mode 100755 > index 00..262c0b5427 > --- /dev/null > +++ b/tests/qemu-iotests/tests/zoned.sh > @@ -0,0 +1,49 @@ > +#!/usr/bin/env bash >

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

2022-06-28 Thread Ani Sinha
On Tue, Jun 28, 2022 at 1:19 PM Daniel P. Berrangé wrote: > > On Tue, Jun 28, 2022 at 09:25:35AM +0200, Thomas Huth wrote: > > On 28/06/2022 09.10, Michael S. Tsirkin wrote: > > > On Tue, Jun 28, 2022 at 09:03:33AM +0200, Thomas Huth wrote: > > > > > > > > > > No problem with that. So that's venv.

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

2022-06-28 Thread Thomas Huth
On 28/06/2022 09.49, Ani Sinha wrote: On Tue, Jun 28, 2022 at 12:55 PM Thomas Huth wrote: On 28/06/2022 09.10, Michael S. Tsirkin wrote: On Tue, Jun 28, 2022 at 09:03:33AM +0200, Thomas Huth wrote: No problem with that. So that's venv. But do we need pip and pulling packages from the net dur

Re: [PATCH v2 1/4] hw/nvme: claim NVMe 2.0 compliance

2022-06-28 Thread Klaus Jensen
On Jun 27 10:59, Christoph Hellwig wrote: > On Mon, Jun 27, 2022 at 01:47:28PM +0200, Niklas Cassel via wrote: > > CRMS.CRWMS bit shall be set to 1 on controllers compliant with versions > > later than NVMe 1.4. > > > > The first version later than NVMe 1.4 is NVMe 2.0 > > > > Let's claim complia

Re: Can legacy vga memory base address be defined different with architectures

2022-06-28 Thread Richard Henderson
On 6/28/22 12:12, maobibo wrote: Hi Philippe, In file include/hw/pci/pci.h, the macro QEMU_PCI_VGA_MEM_BASE is defined as 0xa, which represents legacy VGA memory base address. I want to know whether it should be the same for all architectures, or does this vga mmio space exist on arm

Re: [PATCH 00/12] Introduce new acpi/smbios qtests using biosbits

2022-06-28 Thread Daniel P . Berrangé
On Mon, Jun 27, 2022 at 12:58:44PM +0530, Ani Sinha wrote: > Biosbits is a software written by Josh Triplett that can be downloaded by > visiting https://biosbits.org/. The github codebase can be found here: > https://github.com/biosbits/bits/tree/master. It is a software that exercizes > the bios

[PATCH qemu v3] ppc: Define SETFIELD for the ppc target

2022-06-28 Thread Alexey Kardashevskiy
It keeps repeating, move it to the header. This uses __builtin_ffsll() to allow using the macros in #define. This is not using the QEMU's FIELD macros as this would require changing all such macros found in skiboot (the PPC PowerNV firmware). Signed-off-by: Alexey Kardashevskiy --- Changes: v3:

Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests

2022-06-28 Thread Michael S. Tsirkin
On Tue, Jun 28, 2022 at 11:46:13AM +0530, Ani Sinha wrote: > On Tue, Jun 28, 2022 at 11:36 AM Michael S. Tsirkin wrote: > > > > On Tue, Jun 28, 2022 at 10:27:38AM +0530, Ani Sinha wrote: > > > On Tue, Jun 28, 2022 at 3:56 AM Michael S. Tsirkin > > > wrote: > > > > > > > > On Mon, Jun 27, 2022 at

Re: [PULL 00/12] virtio: fixes

2022-06-28 Thread Richard Henderson
On 6/28/22 10:12, Michael S. Tsirkin wrote: The following changes since commit 097ccbbbaf2681df1e65542e5b7d2b2d0c66e2bc: Merge tag 'qemu-sparc-20220626' of https://github.com/mcayland/qemu into staging (2022-06-27 05:21:05 +0530) are available in the Git repository at: git://git.kernel.

Re: [PATCH 0/9] Preliminary patches for subproject split

2022-06-28 Thread Marc-André Lureau
Hi Markus On Thu, Jun 16, 2022 at 4:48 PM wrote: > From: Marc-André Lureau > > Hi, > > Here is another subset of the large "subproject(qga)"" series I intend to > send > soon after (https://gitlab.com/marcandre.lureau/qemu/-/commits/qga). > > Thanks > > Marc-André Lureau (9): > monitor: make

Re: [PULL 00/60] semihosting patch queue

2022-06-28 Thread Richard Henderson
ository at: https://gitlab.com/rth7680/qemu.git tags/pull-semi-20220628 for you to fetch changes up to ca97e0ef99045ce650b842f3bc8c89d76daaafae: target/nios2: Move nios2-semi.c to nios2_softmmu_ss (2022-06-28 10:18:57 +0530) S

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

2022-06-28 Thread Daniel P . Berrangé
On Tue, Jun 28, 2022 at 01:21:35PM +0530, Ani Sinha wrote: > On Tue, Jun 28, 2022 at 1:19 PM Daniel P. Berrangé > wrote: > > > > On Tue, Jun 28, 2022 at 09:25:35AM +0200, Thomas Huth wrote: > > > On 28/06/2022 09.10, Michael S. Tsirkin wrote: > > > > On Tue, Jun 28, 2022 at 09:03:33AM +0200, Thom

Re: [RFC v3 3/5] file-posix: introduce get_sysfs_long_val for zoned device information.

2022-06-28 Thread Stefan Hajnoczi
On Mon, Jun 27, 2022 at 08:19:15AM +0800, Sam Li wrote: > Use sysfs attribute files to get the zoned device information in case > that ioctl() commands of zone management interface won't work. It can > return long type of value like chunk_sectors, zoned_append_max_bytes, > max_open_zones, max_activ

Re: [PATCH] util: Return void on iova_tree_remove

2022-06-28 Thread Laurent Vivier
Le 27/04/2022 à 17:49, Eugenio Pérez a écrit : It always returns IOVA_OK so nobody uses it. Acked-by: Jason Wang Reviewed-by: Peter Xu Signed-off-by: Eugenio Pérez --- include/qemu/iova-tree.h | 4 +--- util/iova-tree.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) d

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

2022-06-28 Thread Thomas Huth
On 28/06/2022 10.23, Daniel P. Berrangé wrote: On Tue, Jun 28, 2022 at 01:21:35PM +0530, Ani Sinha wrote: On Tue, Jun 28, 2022 at 1:19 PM Daniel P. Berrangé wrote: On Tue, Jun 28, 2022 at 09:25:35AM +0200, Thomas Huth wrote: On 28/06/2022 09.10, Michael S. Tsirkin wrote: On Tue, Jun 28, 202

Re: [PATCH v1] vga: avoid crash if no default vga card

2022-06-28 Thread Laurent Vivier
Le 03/05/2022 à 17:39, Thomas Huth a écrit : On 03/05/2022 11.17, Guo Zhi wrote: QEMU in some arch will crash when executing -vga help command, because there is no default vga model.  Add check to this case and avoid crash. Signed-off-by: Guo Zhi ---   softmmu/vl.c | 3 ++-   1 file changed, 2

Re: [RFC 00/18] vfio: Adopt iommufd

2022-06-28 Thread Eric Auger
Hi Shameer, On 6/28/22 10:14, Shameerali Kolothum Thodi wrote: > >> -Original Message- >> From: Yi Liu [mailto:yi.l@intel.com] >> Sent: 18 May 2022 15:01 >> To: zhangfei@foxmail.com; Jason Gunthorpe ; >> Zhangfei Gao >> Cc: eric.au...@redhat.com; Alex Williamson ; >> Shameerali Ko

Re: venv for python qtest bits? (was: Re: [PATCH 11/12] acpi/tests/bits: add README file for bits qtests)

2022-06-28 Thread Ani Sinha
On Tue, Jun 28, 2022 at 14:05 Ani Sinha wrote: > On Tue, Jun 28, 2022 at 1:58 PM Thomas Huth wrote: > > > > On 28/06/2022 10.23, Daniel P. Berrangé wrote: > > > On Tue, Jun 28, 2022 at 01:21:35PM +0530, Ani Sinha wrote: > > >> On Tue, Jun 28, 2022 at 1:19 PM Daniel P. Berrangé < > berra...@redha

Re: [PATCH] qom/object: Remove circular include dependency

2022-06-28 Thread Laurent Vivier
Le 09/05/2022 à 10:46, Philippe Mathieu-Daudé a écrit : From: Philippe Mathieu-Daudé "qom/object.h" doesn't need to include itself. Signed-off-by: Philippe Mathieu-Daudé --- include/qom/object.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/qom/object.h b/include/qom/object.h

Re: [PATCH 12/14] hw/misc: Add intel-me

2022-06-28 Thread Cédric Le Goater
On 6/28/22 00:27, Peter Delevoryas wrote: Signed-off-by: Peter Delevoryas Intro ? I would rather have 2 patches, one for the slave model and one adding a device to the machine. Please replace the printf with trace events. Thanks, C. --- hw/arm/aspeed.c | 1 + hw/misc/intel_me.

Re: [PATCH 1/2] Trivial: 3 char repeat typos

2022-06-28 Thread Laurent Vivier
Le 14/06/2022 à 12:40, Dr. David Alan Gilbert (git) a écrit : From: "Dr. David Alan Gilbert" Inspired by Julia Lawall's fixing of Linux kernel comments, I looked at qemu, although I did it manually. Signed-off-by: Dr. David Alan Gilbert --- hw/intc/openpic.c| 2 +- hw/net/i

Re: [RFC v3 2/5] qemu-io: add zoned block device operations.

2022-06-28 Thread Sam Li
Stefan Hajnoczi 于2022年6月28日周二 16:20写道: > > On Mon, Jun 27, 2022 at 08:19:14AM +0800, Sam Li wrote: > > diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c > > index 2f0d8ac25a..3f2592b9f5 100644 > > --- a/qemu-io-cmds.c > > +++ b/qemu-io-cmds.c > > @@ -1706,6 +1706,122 @@ static const cmdinfo_t flush_cmd

Re: [PATCH 08/14] hw/misc: Add fby35-cpld

2022-06-28 Thread Peter Delevoryas
> On Jun 27, 2022, at 11:50 PM, Cédric Le Goater wrote: > > On 6/27/22 21:55, Peter Delevoryas wrote: >> Signed-off-by: Peter Delevoryas > > > some intro ? Will do. > >> --- >> hw/misc/fby35_cpld.c | 137 +++ >> hw/misc/meson.build | 3 +- >> 2

Re: [RFC v3 1/5] block: add block layer APIs resembling Linux ZonedBlockDevice ioctls.

2022-06-28 Thread Damien Le Moal
On 6/28/22 17:05, Sam Li wrote: > Stefan Hajnoczi 于2022年6月28日周二 14:52写道: >> >> On Mon, Jun 27, 2022 at 08:19:13AM +0800, Sam Li wrote: >>> diff --git a/block/block-backend.c b/block/block-backend.c >>> index e0e1aff4b1..786f964d02 100644 >>> --- a/block/block-backend.c >>> +++ b/block/block-backen

Re: [PATCH 04/14] aspeed: i2c: Fix DMA len write-enable bit handling

2022-06-28 Thread Peter Delevoryas
> On Jun 28, 2022, at 12:01 AM, Cédric Le Goater wrote: > > On 6/27/22 21:54, Peter Delevoryas wrote: >> I noticed i2c rx transfers were getting shortened to "1" on Zephyr. It >> seems to be because the Zephyr i2c driver sets the RX DMA len with the >> RX field write-enable bit set (bit 31) to

Re: [PATCH 2/2] trivial typos: namesapce

2022-06-28 Thread Laurent Vivier
Le 14/06/2022 à 12:40, Dr. David Alan Gilbert (git) a écrit : From: "Dr. David Alan Gilbert" 'namespace' is misspelled in a bunch of places. Signed-off-by: Dr. David Alan Gilbert --- hw/9pfs/9p-xattr-user.c | 8 hw/acpi/nvdimm.c| 2 +- hw/nvme/ctrl.c | 2 +- 3 f

Re: [PATCH] MAINTAINERS: Add softmmu/runstate.c to "Main loop"

2022-06-28 Thread Laurent Vivier
Le 15/06/2022 à 14:23, Markus Armbruster a écrit : Signed-off-by: Markus Armbruster --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4cf6174f9f..4c921c07db 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2745,6 +2745,7 @@ F: softmmu/cpu-thrott

Re: [RFC v3 2/5] qemu-io: add zoned block device operations.

2022-06-28 Thread Damien Le Moal
On 6/28/22 16:56, Stefan Hajnoczi wrote: > On Mon, Jun 27, 2022 at 08:19:14AM +0800, Sam Li wrote: >> diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c >> index 2f0d8ac25a..3f2592b9f5 100644 >> --- a/qemu-io-cmds.c >> +++ b/qemu-io-cmds.c >> @@ -1706,6 +1706,122 @@ static const cmdinfo_t flush_cmd = { >

  1   2   3   4   >