[PATCH 0/2] pc-bios/s390-ccw: Two fixes for the virtio initialization

2022-06-23 Thread Thomas Huth
Two minor fixes for the virtio initialization that I spotted while looking at the code. These currently do not fix any problem (since QEMU is quite forgiving here when doing things wrong), but we should anyway try to follow the virtio specification here. Thomas Huth (2): pc-bios/s390-ccw/virtio:

[PATCH 2/2] pc-bios/s390-ccw/virtio: Read device config after feature negotiation

2022-06-23 Thread Thomas Huth
Feature negotiation should be done first, since some fields in the config area can depend on the negotiated features and thus should rather be read afterwards. Signed-off-by: Thomas Huth --- pc-bios/s390-ccw/virtio.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/pc-b

[PATCH 1/2] pc-bios/s390-ccw/virtio: Set missing status bits while initializing

2022-06-23 Thread Thomas Huth
According chapter "3.1.1 Driver Requirements: Device Initialization" of the Virtio specification (v1.1), a driver for a device has to set the ACKNOWLEDGE and DRIVER bits in the status field after resetting the device. The s390-ccw bios skipped these steps so far and seems like QEMU never cared. Any

Re: [PATCH v2 2/7] semihosting: add the semihosting_exit_request function

2022-06-23 Thread Luc Michel
On 20:09 Wed 22 Jun , Peter Maydell wrote: > On Tue, 21 Jun 2022 at 13:59, Luc Michel wrote: > > > > Add the semihosting_exit_request function to be used by targets when > > handling an `exit' semihosted syscall. This function calls gdb_exit to > > close existing GDB connections, and qemu_syst

[PATCH qemu] spapr/ddw: Implement 64bit query extension

2022-06-23 Thread Alexey Kardashevskiy
PAPR 2.8 (2018) defines an extension to return 64bit value for the largest TCE block in "ibm,query-pe-dma-window". Recent Linux kernels support this already. This adds the extension and supports the older format. This advertises a bigger window for the new format as the biggest window with 2M pag

Re: [PATCH 1/2] pc-bios/s390-ccw/virtio: Set missing status bits while initializing

2022-06-23 Thread Christian Borntraeger
Am 23.06.22 um 09:11 schrieb Thomas Huth: According chapter "3.1.1 Driver Requirements: Device Initialization" of the Virtio specification (v1.1), a driver for a device has to set the ACKNOWLEDGE and DRIVER bits in the status field after resetting the device. The s390-ccw bios skipped these steps

Re: [PATCH 8/9] scripts/qapi-gen: add -i option

2022-06-23 Thread Marc-André Lureau
Hi On Tue, Jun 21, 2022 at 6:14 PM Markus Armbruster wrote: > > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > Replace hard-coded "qemu/osdep.h" include with a qapi-gen option to > > specify the headers to include. This will allow to substitute QEMU > > osdep.h with g

Re: [PATCH 1/2] pc-bios/s390-ccw/virtio: Set missing status bits while initializing

2022-06-23 Thread Cornelia Huck
On Thu, Jun 23 2022, Thomas Huth wrote: > According chapter "3.1.1 Driver Requirements: Device Initialization" > of the Virtio specification (v1.1), a driver for a device has to set > the ACKNOWLEDGE and DRIVER bits in the status field after resetting > the device. The s390-ccw bios skipped these

Re: [PULL 22/33] migration: remove the QEMUFileOps 'get_buffer' callback

2022-06-23 Thread Daniel P . Berrangé
On Wed, Jun 22, 2022 at 03:34:52PM -0400, Peter Xu wrote: > On Wed, Jun 22, 2022 at 07:39:06PM +0100, Dr. David Alan Gilbert (git) wrote: > > diff --git a/migration/qemu-file.c b/migration/qemu-file.c > > index 74f919de67..e206b05550 100644 > > --- a/migration/qemu-file.c > > +++ b/migration/qemu-f

Re: [PATCH v2] virtio-iommu: Fix the partial copy of probe request

2022-06-23 Thread Jean-Philippe Brucker
On Thu, Jun 23, 2022 at 01:40:58AM +, Duan, Zhenzhong wrote: > > > >-Original Message- > >From: Jean-Philippe Brucker > >Sent: Wednesday, June 22, 2022 9:58 PM > >To: Eric Auger > >Cc: Duan, Zhenzhong ; qemu- > >de...@nongnu.org; m...@redhat.com > >Subject: Re: [PATCH v2] virtio-iom

Re: [PATCH v3] virtio-iommu: Fix the partial copy of probe request

2022-06-23 Thread Jean-Philippe Brucker
On Thu, Jun 23, 2022 at 10:31:52AM +0800, Zhenzhong Duan wrote: > The structure of probe request doesn't include the tail, this leads > to a few field missed to be copied. Currently this isn't an issue as > those missed field belong to reserved field, just in case reserved > field will be used in t

Re: [PATCH 2/2] pc-bios/s390-ccw/virtio: Read device config after feature negotiation

2022-06-23 Thread Cornelia Huck
On Thu, Jun 23 2022, Thomas Huth wrote: > Feature negotiation should be done first, since some fields in the > config area can depend on the negotiated features and thus should > rather be read afterwards. I suppose we don't negotiate any features that might affect the size of the config space?

Re: [PULL 22/33] migration: remove the QEMUFileOps 'get_buffer' callback

2022-06-23 Thread Daniel P . Berrangé
On Wed, Jun 22, 2022 at 04:13:39PM -0400, Peter Xu wrote: > On Wed, Jun 22, 2022 at 03:34:52PM -0400, Peter Xu wrote: > > On Wed, Jun 22, 2022 at 07:39:06PM +0100, Dr. David Alan Gilbert (git) > > wrote: > > > diff --git a/migration/qemu-file.c b/migration/qemu-file.c > > > index 74f919de67..e206b

Re: [PATCH v3] virtio-iommu: Fix the partial copy of probe request

2022-06-23 Thread Eric Auger
Hi Duan, On 6/23/22 04:31, Zhenzhong Duan wrote: > The structure of probe request doesn't include the tail, this leads > to a few field missed to be copied. Currently this isn't an issue as > those missed field belong to reserved field, just in case reserved > field will be used in the future. > >

[PATCH v19 07/13] target/loongarch: remove badaddr from CPULoongArch

2022-06-23 Thread Song Gao
We can use CSR_BADV to replace badaddr. Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson --- target/loongarch/cpu.h | 2 -- target/loongarch/gdbstub.c | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/target/loongarch/cpu.h b/target/lo

[PATCH v19 03/13] linux-user: Add LoongArch elf support

2022-06-23 Thread Song Gao
Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- linux-user/elfload.c| 91 + linux-user/loongarch64/target_elf.h | 12 2 files changed, 103 insertions(+) create mode 100

[PATCH v19 09/13] target/loongarch: Fix helper_asrtle_d/asrtgt_d raise wrong exception

2022-06-23 Thread Song Gao
Raise EXCCODE_BCE instead of EXCCODE_ADEM for helper_asrtle_d/asrtgt_d. Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson --- target/loongarch/cpu.c | 2 ++ target/loongarch/op_helper.c | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --g

[PATCH v19 02/13] linux-user: Add LoongArch signal support

2022-06-23 Thread Song Gao
Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang --- linux-user/loongarch64/signal.c| 331 + linux-user/loongarch64/target_signal.h | 13 + 2 files changed, 344 insertions(+) create mode 100644 linux-user/loongarch64/signal.c create mode 100644 linux-user/l

[PATCH v19 13/13] target/loongarch: Update README

2022-06-23 Thread Song Gao
Add linux-user emulation introduction Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson --- target/loongarch/README | 39 +-- 1 file changed, 37 insertions(+), 2 deletions(-) diff --git a/target/loongarch/README b/target/lo

[PATCH v19 01/13] linux-user: Add LoongArch generic header files

2022-06-23 Thread Song Gao
This includes: - sockbits.h - target_errno_defs.h - target_fcntl.h - termbits.h - target_resource.h - target_structs.h Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: WANG Xuerui --- linux-user/loongarch64/s

[PATCH v19 08/13] target/loongarch: Fix missing update CSR_BADV

2022-06-23 Thread Song Gao
loongarch_cpu_do_interrupt() should update CSR_BADV for some EXCCODE. Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson --- target/loongarch/cpu.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/target/loongarch/cpu.c b/target/lo

[PATCH v19 06/13] scripts: add loongarch64 binfmt config

2022-06-23 Thread Song Gao
Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson --- scripts/qemu-binfmt-conf.sh | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh index 9cb723f443..1f4e2cd19d 100755 --- a/script

[PATCH v19 11/13] target/loongarch: Adjust functions and structure to support user-mode

2022-06-23 Thread Song Gao
Some functions and member of the structure are different with softmmu-mode So we need adjust them to support user-mode. Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson --- target/loongarch/cpu.c| 21 ++- target/loongarch/cpu.h

[PATCH v19 00/13] Add LoongArch linux-user emulation support

2022-06-23 Thread Song Gao
Hi All, This series adds support linux-user emulation. As the LoongArch kernel had merged into 5.19-rc1, you can see the latest kernel at https://kernel.org Need review patch: 0002-linux-user-Add-LoongArch-signal-support.patch V19: - Update signal.c, add fpu info, fpu_context and end info t

[PATCH v19 05/13] linux-user: Add LoongArch cpu_loop support

2022-06-23 Thread Song Gao
Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson --- linux-user/loongarch64/cpu_loop.c | 96 + linux-user/loongarch64/target_cpu.h | 34 ++ 2 files changed, 130 insertions(+) create mode 100644 linux-user/loongarch64/cpu_

Re: [PATCH v7 10/18] jobs: rename static functions called with job_mutex held

2022-06-23 Thread Emanuele Giuseppe Esposito
Am 22/06/2022 um 20:38 schrieb Vladimir Sementsov-Ogievskiy: > On 6/22/22 17:26, Emanuele Giuseppe Esposito wrote: >> >> >> Am 21/06/2022 um 19:26 schrieb Vladimir Sementsov-Ogievskiy: >>> On 6/16/22 16:18, Emanuele Giuseppe Esposito wrote: With the*nop*  job_lock/unlock placed, rename the

[PATCH v19 04/13] linux-user: Add LoongArch syscall support

2022-06-23 Thread Song Gao
Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- linux-user/loongarch64/syscall_nr.h | 312 linux-user/loongarch64/target_syscall.h | 48 linux-user/syscall_defs.h | 6

Re: [PULL 00/33] migration queue

2022-06-23 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (git) (dgilb...@redhat.com) wrote: > From: "Dr. David Alan Gilbert" > > The following changes since commit 2b049d2c8dc01de750410f8f1a4eac498c04c723: > > Merge tag 'pull-aspeed-20220622' of https://github.com/legoater/qemu into > staging (2022-06-22 07:27:06 -0700) >

Re: [PULL 22/33] migration: remove the QEMUFileOps 'get_buffer' callback

2022-06-23 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Wed, Jun 22, 2022 at 03:34:52PM -0400, Peter Xu wrote: > > On Wed, Jun 22, 2022 at 07:39:06PM +0100, Dr. David Alan Gilbert (git) > > wrote: > > > diff --git a/migration/qemu-file.c b/migration/qemu-file.c > > > index 74f919de67..e206b05550 10

[PATCH v19 12/13] default-configs: Add loongarch linux-user support

2022-06-23 Thread Song Gao
This patch adds loongarch64 linux-user default configs file. Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson Reviewed-by: WANG Xuerui --- configs/targets/loongarch64-linux-user.mak | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 configs/targets

[PATCH v19 10/13] target/loongarch: remove unused include hw/loader.h

2022-06-23 Thread Song Gao
Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson --- target/loongarch/cpu.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target/loongarch/cpu.c b/target/loongarch/cpu.c index 0013582a3a..bf163a8dce 100644 --- a/target/loongarch/cpu.c +++ b/target/loongar

Re: AIX 7.2 guest, Windows 10 host, networking, qemu 6.0.50.

2022-06-23 Thread Cédric Le Goater
Hello Paul, On 6/23/22 03:05, Paul Dembry wrote: Hi Daniel, It works! Using your -netdev and -device and https://www.jazakallah.info/post/how-to-setup-network-for-ibm-aix-vm-access-in-qemu with the addition of "ip route add 192.168.122.99 gw 192.168.122.1" Excellent ! Could you try with a

[PULL 05/33] io: add a QIOChannelNull equivalent to /dev/null

2022-06-23 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé This is for code which needs a portable equivalent to a QIOChannelFile connected to /dev/null. Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Signed-off-by: Dr. David Alan Gilbert --- include/io/channel-null.h | 55

[PULL 00/33] migration queue

2022-06-23 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The following changes since commit 2b049d2c8dc01de750410f8f1a4eac498c04c723: Merge tag 'pull-aspeed-20220622' of https://github.com/legoater/qemu into staging (2022-06-22 07:27:06 -0700) are available in the Git repository at: https://gitlab.com/dagrh/qemu.g

[PULL 03/33] QIOChannelSocket: Fix zero-copy send so socket flush works

2022-06-23 Thread Dr. David Alan Gilbert (git)
From: Leonardo Bras Somewhere between v6 and v7 the of the zero-copy-send patchset a crucial part of the flushing mechanism got missing: incrementing zero_copy_queued. Without that, the flushing interface becomes a no-op, and there is no guarantee the buffer is really sent. This can go as bad a

[PULL 06/33] migration: switch to use QIOChannelNull for dummy channel

2022-06-23 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé This removes one further custom impl of QEMUFile, in favour of a QIOChannel based impl. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Signed-off-by: Dr. David Alan Gilbert --- migration/ram.c | 7 +

[PULL 07/33] migration: remove unreachble RDMA code in save_hook impl

2022-06-23 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé The QEMUFile 'save_hook' callback has a 'size_t size' parameter. The RDMA impl of this has logic that takes different actions depending on whether the value is zero or non-zero. It has commented out logic that would have taken further actions if the value was negative.

[PULL 14/33] migration: convert savevm to use QIOChannelBlock for VMState

2022-06-23 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé With this change, all QEMUFile usage is backed by QIOChannel at last. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Signed-off-by: Dr. David Alan Gilbert dgilbert: Wrap long lines ---

[PULL 10/33] migration: rename qemu_ftell to qemu_file_total_transferred

2022-06-23 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé The name 'ftell' gives the misleading impression that the QEMUFile objects are seekable. This is not the case, as in general we just have an opaque stream. The users of this method are only interested in the total bytes processed. This switches to a new name that reflects

[PULL 01/33] migration: Remove RDMA_UNREGISTRATION_EXAMPLE

2022-06-23 Thread Dr. David Alan Gilbert (git)
From: Juan Quintela Nobody has ever showed up to unregister individual pages, and another set of patches written by Daniel P. Berrangé just remove qemu_rdma_signal_unregister() function needed here. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Dr. David Alan

[PULL 17/33] migration: introduce new constructors for QEMUFile

2022-06-23 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé Prepare for the elimination of QEMUFileOps by introducing a pair of new constructors. This lets us distinguish between an input and output file object explicitly rather than via the existance of specific callbacks. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Dani

[PULL 02/33] QIOChannelSocket: Introduce assert and reduce ifdefs to improve readability

2022-06-23 Thread Dr. David Alan Gilbert (git)
From: Leonardo Bras During implementation of MSG_ZEROCOPY feature, a lot of #ifdefs were introduced, particularly at qio_channel_socket_writev(). Rewrite some of those changes so it's easier to read. Also, introduce an assert to help detect incorrect zero-copy usage is when it's disabled on bui

[PULL 15/33] migration: stop passing 'opaque' parameter to QEMUFile hooks

2022-06-23 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé The only user of the hooks is RDMA which provides a QIOChannel backed impl of QEMUFile. It can thus use the qemu_file_get_ioc() method. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Signe

[PULL 04/33] migration: Change zero_copy_send from migration parameter to migration capability

2022-06-23 Thread Dr. David Alan Gilbert (git)
From: Leonardo Bras When originally implemented, zero_copy_send was designed as a Migration paramenter. But taking into account how is that supposed to work, and how the difference between a capability and a parameter, it only makes sense that zero-copy-send would work better as a capability. T

[PULL 08/33] migration: rename rate limiting fields in QEMUFile

2022-06-23 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé This renames the following QEMUFile fields * bytes_xfer -> rate_limit_used * xfer_limit -> rate_limit_max The intent is to make it clear that 'bytes_xfer' is specifically related to rate limiting of data and applies to data queued, which need not have been transferred

[PULL 18/33] migration: remove unused QEMUFileGetFD typedef / qemu_get_fd method

2022-06-23 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Signed-off-by: Dr. David Alan Gilbert --- migration/qemu-file.h | 5 - 1 file changed, 5 deletions(-) diff --git a/migration/qemu-file.

[PULL 19/33] migration: remove the QEMUFileOps 'shut_down' callback

2022-06-23 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé This directly implements the shutdown logic using QIOChannel APIs. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Signed-off-by: Dr. David Alan Gilbert --- migration/qemu-file-channel.c

[PULL 20/33] migration: remove the QEMUFileOps 'set_blocking' callback

2022-06-23 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé This directly implements the set_blocking logic using QIOChannel APIs. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Signed-off-by: Dr. David Alan Gilbert --- migration/qemu-file-channe

[PULL 11/33] migration: rename qemu_update_position to qemu_file_credit_transfer

2022-06-23 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé The qemu_update_position method name gives the misleading impression that it is changing the current file offset. Most of the files are just streams, however, so there's no concept of a file offset in the general case. What this method is actually used for is to report o

[PULL 21/33] migration: remove the QEMUFileOps 'close' callback

2022-06-23 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé This directly implements the close logic using QIOChannel APIs. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Signed-off-by: Dr. David Alan Gilbert --- migration/qemu-file-channel.c | 1

[PULL 32/33] softmmu/dirtylimit: Implement dirty page rate limit

2022-06-23 Thread Dr. David Alan Gilbert (git)
From: Hyman Huang(黄勇) Implement dirtyrate calculation periodically basing on dirty-ring and throttle virtual CPU until it reachs the quota dirty page rate given by user. Introduce qmp commands "set-vcpu-dirty-limit", "cancel-vcpu-dirty-limit", "query-vcpu-dirty-limit" to enable, disable, query d

[PULL 25/33] migration: remove the QEMUFileOps abstraction

2022-06-23 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé Now that all QEMUFile callbacks are removed, the entire concept can be deleted. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Signed-off-by: Dr. David Alan Gilbert --- migration/channel

[PULL 13/33] migration: introduce a QIOChannel impl for BlockDriverState VMState

2022-06-23 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé Introduce a QIOChannelBlock class that exposes the BlockDriverState VMState region for I/O. This is kept in the migration/ directory rather than io/, to avoid a mutual dependancy between block/ <-> io/ directories. Also the VMState should only be used by the migration co

[PULL 23/33] migration: remove the QEMUFileOps 'writev_buffer' callback

2022-06-23 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé This directly implements the writev_buffer logic using QIOChannel APIs. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Signed-off-by: Dr. David Alan Gilbert --- migration/qemu-file-chann

[PULL 26/33] accel/kvm/kvm-all: Refactor per-vcpu dirty ring reaping

2022-06-23 Thread Dr. David Alan Gilbert (git)
From: Hyman Huang(黄勇) Add a non-required argument 'CPUState' to kvm_dirty_ring_reap so that it can cover single vcpu dirty-ring-reaping scenario. Signed-off-by: Hyman Huang(黄勇) Reviewed-by: Peter Xu Message-Id: Signed-off-by: Dr. David Alan Gilbert --- accel/kvm/kvm-all.c | 23

[PULL 27/33] cpus: Introduce cpu_list_generation_id

2022-06-23 Thread Dr. David Alan Gilbert (git)
From: Hyman Huang(黄勇) Introduce cpu_list_generation_id to track cpu list generation so that cpu hotplug/unplug can be detected during measurement of dirty page rate. cpu_list_generation_id could be used to detect changes of cpu list, which is prepared for dirty page rate measurement. Signed-off

[PULL 09/33] migration: rename 'pos' field in QEMUFile to 'bytes_processed'

2022-06-23 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé The field name 'pos' gives the misleading impression that the QEMUFile objects are seekable. This is not the case, as in general we just have an opaque stream. The users of this method are only interested in the total bytes processed. This switches to a new name that refl

[PULL 22/33] migration: remove the QEMUFileOps 'get_buffer' callback

2022-06-23 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé This directly implements the get_buffer logic using QIOChannel APIs. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Signed-off-by: Dr. David Alan Gilbert dgilbert: Fixup len = *-*EIO as

[PULL 30/33] accel/kvm/kvm-all: Introduce kvm_dirty_ring_size function

2022-06-23 Thread Dr. David Alan Gilbert (git)
From: Hyman Huang(黄勇) Introduce kvm_dirty_ring_size util function to help calculate dirty ring ful time. Signed-off-by: Hyman Huang(黄勇) Acked-by: Peter Xu Message-Id: Signed-off-by: Dr. David Alan Gilbert dgilbert: Fixed up excess #endif --- accel/kvm/kvm-all.c| 5 + accel/stubs/

[PULL 16/33] migration: hardcode assumption that QEMUFile is backed with QIOChannel

2022-06-23 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé The only callers of qemu_fopen_ops pass 'true' for the 'has_ioc' parameter, so hardcode this assumption in QEMUFile, by passing in the QIOChannel object as a non-opaque parameter. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan Q

[PULL 29/33] softmmu/dirtylimit: Implement vCPU dirtyrate calculation periodically

2022-06-23 Thread Dr. David Alan Gilbert (git)
From: Hyman Huang(黄勇) Introduce the third method GLOBAL_DIRTY_LIMIT of dirty tracking for calculate dirtyrate periodly for dirty page rate limit. Add dirtylimit.c to implement dirtyrate calculation periodly, which will be used for dirty page rate limit. Add dirtylimit.h to export util functions

[PULL 12/33] migration: rename qemu_file_update_transfer to qemu_file_acct_rate_limit

2022-06-23 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé The qemu_file_update_transfer name doesn't give a clear guide on what its purpose is, and how it differs from the qemu_file_credit_transfer method. The latter is specifically for accumulating for total migration traffic, while the former is specifically for accounting in

[PULL 24/33] migration: remove the QEMUFileOps 'get_return_path' callback

2022-06-23 Thread Dr. David Alan Gilbert (git)
From: Daniel P. Berrangé This directly implements the get_return_path logic using QIOChannel APIs. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Signed-off-by: Dr. David Alan Gilbert --- migration/qemu-file-cha

Re: [PATCH 2/2] pc-bios/s390-ccw/virtio: Read device config after feature negotiation

2022-06-23 Thread Cornelia Huck
On Thu, Jun 23 2022, Thomas Huth wrote: > On 23/06/2022 10.44, Cornelia Huck wrote: >> On Thu, Jun 23 2022, Thomas Huth wrote: >> >>> Feature negotiation should be done first, since some fields in the >>> config area can depend on the negotiated features and thus should >>> rather be read after

[PULL 33/33] tests: Add dirty page rate limit test

2022-06-23 Thread Dr. David Alan Gilbert (git)
From: Hyman Huang(黄勇) Add dirty page rate limit test if kernel support dirty ring. The following qmp commands are covered by this test case: "calc-dirty-rate", "query-dirty-rate", "set-vcpu-dirty-limit", "cancel-vcpu-dirty-limit" and "query-vcpu-dirty-limit". Signed-off-by: Hyman Huang(黄勇) Ack

[PULL 28/33] migration/dirtyrate: Refactor dirty page rate calculation

2022-06-23 Thread Dr. David Alan Gilbert (git)
From: Hyman Huang(黄勇) abstract out dirty log change logic into function global_dirty_log_change. abstract out dirty page rate calculation logic via dirty-ring into function vcpu_calculate_dirtyrate. abstract out mathematical dirty page rate calculation into do_calculate_dirtyrate, decouple it f

[PULL 31/33] softmmu/dirtylimit: Implement virtual CPU throttle

2022-06-23 Thread Dr. David Alan Gilbert (git)
From: Hyman Huang(黄勇) Setup a negative feedback system when vCPU thread handling KVM_EXIT_DIRTY_RING_FULL exit by introducing throttle_us_per_full field in struct CPUState. Sleep throttle_us_per_full microseconds to throttle vCPU if dirtylimit is in service. Signed-off-by: Hyman Huang(黄勇) Revie

Re: [PATCH 0/9] Add Qualcomm BMC machines

2022-06-23 Thread Graeme Gregory
On Thu, Jun 23, 2022 at 08:48:49AM +0200, Cédric Le Goater wrote: > On 6/23/22 07:25, Joel Stanley wrote: > > On Wed, 22 Jun 2022 at 17:29, Jae Hyun Yoo wrote: > > > > > > Hello, > > > > > > I'm sending a series to add Qualcomm BMC machines that are equipped with > > > Aspeed AST2600 SoC. Also,

Re: [PATCH v2] virtio-iommu: Fix the partial copy of probe request

2022-06-23 Thread Eric Auger
On 6/23/22 10:41, Jean-Philippe Brucker wrote: > On Thu, Jun 23, 2022 at 01:40:58AM +, Duan, Zhenzhong wrote: >> >>> -Original Message- >>> From: Jean-Philippe Brucker >>> Sent: Wednesday, June 22, 2022 9:58 PM >>> To: Eric Auger >>> Cc: Duan, Zhenzhong ; qemu- >>> de...@nongnu.org

Re: [RFC PATCH] qemu-options: bring the kernel and image options together

2022-06-23 Thread Alex Bennée
Cédric Le Goater writes: > On 6/22/22 16:50, Alex Bennée wrote: >> How to control the booting of QEMU is often a source of confusion for >> users. Bring the options that control this together in the manual >> pages and add some verbiage to describe when each option is >> appropriate. >> Signed-

Re: [PATCH 2/2] pc-bios/s390-ccw/virtio: Read device config after feature negotiation

2022-06-23 Thread Thomas Huth
On 23/06/2022 10.44, Cornelia Huck wrote: On Thu, Jun 23 2022, Thomas Huth wrote: Feature negotiation should be done first, since some fields in the config area can depend on the negotiated features and thus should rather be read afterwards. I suppose we don't negotiate any features that mig

Re: [PATCH v3 23/51] target/arm: Implement SME RDSVL, ADDSVL, ADDSPL

2022-06-23 Thread Peter Maydell
On Wed, 22 Jun 2022 at 01:58, Richard Henderson wrote: > > On 6/21/22 10:23, Peter Maydell wrote: > >> +static bool trans_RDSVL(DisasContext *s, arg_RDSVL *a) > >> +{ > >> +if (!dc_isar_feature(aa64_sme, s)) { > >> +return false; > >> +} > >> +if (sme_enabled_check(s)) { > >> +

Re: [PATCH v7 10/18] jobs: rename static functions called with job_mutex held

2022-06-23 Thread Vladimir Sementsov-Ogievskiy
On 6/23/22 12:08, Emanuele Giuseppe Esposito wrote: Am 22/06/2022 um 20:38 schrieb Vladimir Sementsov-Ogievskiy: On 6/22/22 17:26, Emanuele Giuseppe Esposito wrote: Am 21/06/2022 um 19:26 schrieb Vladimir Sementsov-Ogievskiy: On 6/16/22 16:18, Emanuele Giuseppe Esposito wrote: With the*no

Re: [PATCH v7 10/18] jobs: rename static functions called with job_mutex held

2022-06-23 Thread Emanuele Giuseppe Esposito
Am 23/06/2022 um 13:10 schrieb Vladimir Sementsov-Ogievskiy: > On 6/23/22 12:08, Emanuele Giuseppe Esposito wrote: >> >> >> Am 22/06/2022 um 20:38 schrieb Vladimir Sementsov-Ogievskiy: >>> On 6/22/22 17:26, Emanuele Giuseppe Esposito wrote: Am 21/06/2022 um 19:26 schrieb Vladimir

Re: [PATCH v3 25/51] target/arm: Implement SME MOVA

2022-06-23 Thread Peter Maydell
On Mon, 20 Jun 2022 at 19:20, Richard Henderson wrote: > > We can reuse the SVE functions for implementing moves to/from > horizontal tile slices, but we need new ones for moves to/from > vertical tile slices. > > Signed-off-by: Richard Henderson > --- > target/arm/helper-sme.h| 11 >

Re: [PATCH] hmat acpi: Don't require initiator value in -numa when hmat=on

2022-06-23 Thread Jonathan Cameron via
On Tue, 21 Jun 2022 12:49:09 +0200 Brice Goglin wrote: > Le 20/06/2022 à 18:05, Igor Mammedov a écrit : > > On Mon, 20 Jun 2022 17:24:18 +0200 > > Brice Goglin wrote: > > > >> Le 20/06/2022 à 15:27, Igor Mammedov a écrit Machine (2966MB total) + > >> Package P#0 > NUMANode P#2 (979

Re: [PATCH v3 26/51] target/arm: Implement SME LD1, ST1

2022-06-23 Thread Peter Maydell
On Mon, 20 Jun 2022 at 19:13, Richard Henderson wrote: > > We cannot reuse the SVE functions for LD[1-4] and ST[1-4], > because those functions accept only a Zreg register number. > For SME, we want to pass a pointer into ZA storage. > > Signed-off-by: Richard Henderson > --- > target/arm/helper

Re: [PATCH v3 27/51] target/arm: Export unpredicated ld/st from translate-sve.c

2022-06-23 Thread Peter Maydell
On Mon, 20 Jun 2022 at 19:12, Richard Henderson wrote: > > Add a TCGv_ptr base argument, which will be cpu_env for SVE. > We will reuse this for SME save and restore array insns. > > Signed-off-by: Richard Henderson > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v3 28/51] target/arm: Implement SME LDR, STR

2022-06-23 Thread Peter Maydell
On Mon, 20 Jun 2022 at 19:24, Richard Henderson wrote: > > We can reuse the SVE functions for LDR and STR, passing in the > base of the ZA vector and a zero offset. > > Signed-off-by: Richard Henderson > --- > target/arm/sme.decode | 7 +++ > target/arm/translate-sme.c | 23 +++

Re: [PATCH v7 10/18] jobs: rename static functions called with job_mutex held

2022-06-23 Thread Vladimir Sementsov-Ogievskiy
On 6/23/22 14:19, Emanuele Giuseppe Esposito wrote: Am 23/06/2022 um 13:10 schrieb Vladimir Sementsov-Ogievskiy: On 6/23/22 12:08, Emanuele Giuseppe Esposito wrote: Am 22/06/2022 um 20:38 schrieb Vladimir Sementsov-Ogievskiy: On 6/22/22 17:26, Emanuele Giuseppe Esposito wrote: Am 21/06/202

Re: [PATCH v3 29/51] target/arm: Implement SME ADDHA, ADDVA

2022-06-23 Thread Peter Maydell
On Mon, 20 Jun 2022 at 19:09, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/helper-sme.h| 5 +++ > target/arm/sme.decode | 11 + > target/arm/sme_helper.c| 90 ++ > target/arm/translate-sme.c | 30 ++

Re: [RFC PATCH] linux-user: un-parent OBJECT(cpu) when closing thread

2022-06-23 Thread Laurent Vivier
On 21/06/2022 20:17, Laurent Vivier wrote: Le 10/06/2022 à 16:38, Alex Bennée a écrit : While forcing the CPU to unrealize by hand does trigger the clean-up code we never fully free resources because refcount never reaches zero. This is because QOM automatically added objects without an explicit

Re: [PATCH 01/14] sysbus: Remove sysbus_mmio_unmap

2022-06-23 Thread Peter Maydell
On Thu, 23 Jun 2022 at 11:59, Peter Delevoryas wrote: > > Cedric removed usage of this function in a previous commit. > > Fixes: 981b1c6266c6 ("spapr/xive: rework the mapping the KVM memory regions") > Signed-off-by: Peter Delevoryas We only added this function for the XIVE in the first place so

Re: [PATCH 02/14] sysbus: Remove sysbus_address_space

2022-06-23 Thread Peter Maydell
On Thu, 23 Jun 2022 at 11:56, Peter Delevoryas wrote: > > sysbus_address_space returns the address space associated with a > SysBusDevice. > > That address space is always the global singleton "system_memory", which > is retrieved through get_system_memory(). > > This abstraction isn't very useful

Re: [PATCH 04/14] sysbus: Add sysbus_mmio_map_in

2022-06-23 Thread Peter Maydell
On Thu, 23 Jun 2022 at 11:56, Peter Delevoryas wrote: > > Signed-off-by: Peter Delevoryas > --- > hw/core/sysbus.c| 6 ++ > include/hw/sysbus.h | 2 ++ > 2 files changed, 8 insertions(+) > > diff --git a/hw/core/sysbus.c b/hw/core/sysbus.c > index cb4d6bae9d..7b63ec3fed 100644 > --- a/hw

Re: [PATCH 06/14] aspeed: Add system-memory QOM link to SoC

2022-06-23 Thread Peter Maydell
On Thu, 23 Jun 2022 at 12:31, Peter Delevoryas wrote: > > Right now it's just defined as the regular global system memory. If we > migrate all the SoC code to use this property instead of directly calling > get_system_memory(), then we can restrict the memory container for the SoC, > which will be

Re: [RFC PATCH] qemu-options: bring the kernel and image options together

2022-06-23 Thread Peter Maydell
On Wed, 22 Jun 2022 at 15:53, Alex Bennée wrote: > > How to control the booting of QEMU is often a source of confusion for > users. Bring the options that control this together in the manual > pages and add some verbiage to describe when each option is > appropriate. https://stackoverflow.com/a/5

Re: [RFC PATCH v3 04/11] qapi: net: add stream and dgram netdevs

2022-06-23 Thread Markus Armbruster
Laurent Vivier writes: > On 22/06/2022 13:47, Markus Armbruster wrote: >> Laurent Vivier writes: >> >>> On 21/06/2022 10:49, Markus Armbruster wrote: Laurent Vivier writes: > On 20/06/2022 17:21, Markus Armbruster wrote: >> Laurent Vivier writes: >> >>> Copied from s

[PATCH v2] fuzz: only use generic-fuzz targets on oss-fuzz

2022-06-23 Thread Alexander Bulekov
The non-generic-fuzz targets often time-out, or run out of memory. Additionally, they create unreproducible bug-reports. It is possible that this is resulting in failing coverage-reports on OSS-Fuzz. In the future, these test-cases should be fixed, or removed. Reviewed-by: Darren Kenny Signed-off

Re: [PATCH 11/14] aspeed: Switch to create_unimplemented_device_in

2022-06-23 Thread Peter Maydell
On Thu, 23 Jun 2022 at 13:04, Peter Delevoryas wrote: > > Signed-off-by: Peter Delevoryas > --- > hw/arm/aspeed_ast10x0.c | 10 -- > hw/arm/aspeed_ast2600.c | 19 ++- > hw/arm/aspeed_soc.c | 9 + > 3 files changed, 19 insertions(+), 19 deletions(-) > > diff -

Re: [PATCH 08/14] aspeed: Replace direct get_system_memory() calls

2022-06-23 Thread Peter Maydell
On Thu, 23 Jun 2022 at 13:37, Peter Delevoryas wrote: > > Note: sysbus_mmio_map(), sysbus_mmio_map_overlap(), and others are still > using get_system_memory indirectly. > > Signed-off-by: Peter Delevoryas > --- > hw/arm/aspeed.c | 8 > hw/arm/aspeed_ast10x0.c | 5 ++--- > hw/arm

Re: [PATCH 2/5] cpus-common: Add run_on_cpu2()

2022-06-23 Thread Peter Maydell
On Fri, 17 Jun 2022 at 15:57, Peter Xu wrote: > > This version of run_on_cpu() allows to take an Error** to detect errors. > > Signed-off-by: Peter Xu > --- > cpus-common.c | 27 +++ > include/hw/core/cpu.h | 26 ++ > softmmu/cpus.c

Re: [PATCH 5/5] KVM: Hook kvm_arch_put_registers() errors to the caller

2022-06-23 Thread Peter Maydell
On Fri, 17 Jun 2022 at 15:53, Peter Xu wrote: > > Leverage the new mechanism to pass over errors to upper stack for > kvm_arch_put_registers() when called for the post_init() accel hook. > > Signed-off-by: Peter Xu > --- > accel/kvm/kvm-all.c | 13 ++--- > accel/kvm/kvm-cpus.h | 2 +- >

[PATCH kvm-unit-tests] MAINTAINERS: Change drew's email address

2022-06-23 Thread Andrew Jones
As a side effect of leaving Red Hat I won't be able to use my Red Hat email address anymore. I'm also changing the name of my gitlab group. Signed-off-by: Andrew Jones Signed-off-by: Andrew Jones --- MAINTAINERS | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/MAINTAINE

Re: [PATCH 9/9] scripts/qapi: add required system includes to visitor

2022-06-23 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > The generated visitor code includes abort() & assert(), we shouldn't > rely on the global "-i" headers to include the necessary system headers. Suggest ", even though the default qemu/osdep.h always does. > > Signed-off-by: Marc-

Re: [PATCH v7 8/8] s390x/s390-virtio-ccw: add zpcii-disable machine property

2022-06-23 Thread Pierre Morel
On 6/22/22 17:20, Matthew Rosato wrote: On 6/22/22 4:50 AM, Pierre Morel wrote: On 6/6/22 22:36, Matthew Rosato wrote: The zpcii-disable machine property can be used to force-disable the use of zPCI interpretation facilities for a VM.  By default, this setting will be off for machine 7.1 a

Re: [PATCH 1/2] pc-bios/s390-ccw/virtio: Set missing status bits while initializing

2022-06-23 Thread Eric Farman
On Thu, 2022-06-23 at 09:11 +0200, Thomas Huth wrote: > According chapter "3.1.1 Driver Requirements: Device Initialization" > of the Virtio specification (v1.1), a driver for a device has to set > the ACKNOWLEDGE and DRIVER bits in the status field after resetting > the device. The s390-ccw bios s

Re: [PATCH kvm-unit-tests] MAINTAINERS: Change drew's email address

2022-06-23 Thread Alex Bennée
Andrew Jones writes: > As a side effect of leaving Red Hat I won't be able to use my Red Hat > email address anymore. I'm also changing the name of my gitlab group. > > Signed-off-by: Andrew Jones > Signed-off-by: Andrew Jones Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH 9/9] hw/arm/aspeed: firework: add I2C MUXes for VR channels

2022-06-23 Thread Jae Hyun Yoo
Hello Joel, On 6/22/2022 10:27 PM, Joel Stanley wrote: On Wed, 22 Jun 2022 at 17:29, Jae Hyun Yoo wrote: Add 2-level cascaded I2C MUXes for SOC VR channels into the Firework machine. Signed-off-by: Jae Hyun Yoo --- hw/arm/aspeed.c | 30 +++--- 1 file changed, 19 i

Re: [PATCH 3/9] hw/arm/aspeed: qcom-dc-scm-v1: add block backed FRU device

2022-06-23 Thread Jae Hyun Yoo
On 6/22/2022 10:28 PM, Joel Stanley wrote: On Wed, 22 Jun 2022 at 17:29, Jae Hyun Yoo wrote: From: Graeme Gregory The FRU device uses the index 0 device on bus IF_NONE. -drive file=$FRU,format=raw,if=none file must match FRU size of 128k Signed-off-by: Graeme Gregory --- hw/arm/aspeed.

  1   2   3   >