[PULL 04/10] virtio/vhost-user: Fix wrong vhost notifier GPtrArray size

2022-06-16 Thread Michael S. Tsirkin
From: Yajun Wu In fetch_or_create_notifier, idx begins with 0. So the GPtrArray size should be idx + 1 and g_ptr_array_set_size should be called with idx + 1. This wrong GPtrArray size causes fetch_or_create_notifier return an invalid address. Passing this invalid pointer to vhost_user_host_noti

[PULL 05/10] virtio-iommu: Add bypass mode support to assigned device

2022-06-16 Thread Michael S. Tsirkin
From: Zhenzhong Duan Currently assigned devices can not work in virtio-iommu bypass mode. Guest driver fails to probe the device due to DMA failure. And the reason is because of lacking GPA -> HPA mappings when VM is created. Add a root container memory region to hold both bypass memory region a

[PULL 07/10] virtio-iommu: Add an assert check in translate routine

2022-06-16 Thread Michael S. Tsirkin
From: Zhenzhong Duan With address space switch supported, dma access translation only happen after endpoint is attached to a non-bypass domain. Signed-off-by: Zhenzhong Duan Message-Id: <20220613061010.2674054-4-zhenzhong.d...@intel.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S

[PULL 09/10] vhost: also check queue state in the vhost_dev_set_log error routine

2022-06-16 Thread Michael S. Tsirkin
From: Ni Xun When check queue state in the vhost_dev_set_log routine, it miss the error routine check, this patch also check queue state in error case. Fixes: 1e5a050f5798 ("check queue state in the vhost_dev_set_log routine") Signed-off-by: Ni Xun Reviewed-by: Zhigang Lu Message-Id: Reviewe

[PULL 08/10] crypto: Introduce RSA algorithm

2022-06-16 Thread Michael S. Tsirkin
From: zhenwei pi There are two parts in this patch: 1, support akcipher service by cryptodev-builtin driver 2, virtio-crypto driver supports akcipher service In principle, we should separate this into two patches, to avoid compiling error, merge them into one. Then virtio-crypto gets request fr

[PULL 10/10] acpi/erst: fix fallthrough code upon validation failure

2022-06-16 Thread Michael S. Tsirkin
From: Ani Sinha At any step when any validation fail in check_erst_backend_storage(), there is no need to continue further through other validation checks. Further, by continuing even when record_size is 0, we run the risk of triggering a divide by zero error if we continued with other validation

Re: [PATCH 1/4] Modifying ‘migrate’ qmp command to add multi-FD socket on particular source and destination pair

2022-06-16 Thread Dr. David Alan Gilbert
* Het Gala (het.g...@nutanix.com) wrote: > i) Modified the format of the qemu monitor command : 'migrate' by adding a > list, >each element in the list consists of multi-FD connection parameters: source >and destination uris and of the number of multi-fd channels between each > pair. > >

Re: [PATCH 0/4] Multiple interface support on top of Multi-FD

2022-06-16 Thread Daniel P . Berrangé
On Thu, Jun 16, 2022 at 03:44:09PM +0530, manish.mishra wrote: > > On 16/06/22 1:46 pm, Daniel P. Berrangé wrote: > > On Wed, Jun 15, 2022 at 08:14:26PM +0100, Dr. David Alan Gilbert wrote: > > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > > On Fri, Jun 10, 2022 at 05:58:31PM +0530, ma

Re: [PATCH 3/4] Establishing connection between any non-default source and destination pair

2022-06-16 Thread Daniel P . Berrangé
On Thu, Jun 09, 2022 at 07:33:04AM +, Het Gala wrote: > i) Binding of the socket to source ip address and port on the non-default >interface has been implemented for multi-FD connection, which was not >necessary earlier because the binding was on the default interface itself. > > ii) C

[PATCH] net/vmnet: use availability check at runtime

2022-06-16 Thread Joelle van Dyne
MAC_OS_X_VERSION_MIN_REQUIRED is set at compile time so this means that when we target an older macOS version, it disables the newer features. With a runtime check, we can selectively disable newer API features. Signed-off-by: Joelle van Dyne --- net/vmnet-host.c| 70 +---

Re: [PULL 0/7] 9p queue 2022-06-16

2022-06-16 Thread Richard Henderson
https://github.com/cschoenebeck/qemu.git tags/pull-9p-20220616 for you to fetch changes up to 0e43495d3b4a50fc5e22f7b71261fdd5b56fdfcb: tests/9pfs: check fid being unaffected in fs_walk_2nd_nonexistent (2022-06-16 12:44:52 +0200)

Re: [PATCH 5/9] error-report: introduce ErrorReportDetailedFunc

2022-06-16 Thread Warner Losh
On Thu, Jun 16, 2022 at 6:41 AM wrote: > From: Marc-André Lureau > > Remove monitor dependency from error printing code, by allowing programs > to set a callback for when to use "detailed" reporting or not. > > Signed-off-by: Marc-André Lureau > --- > include/qemu/error-report.h | 4 +

Re: [PATCH 2/4] Adding multi-interface support for multi-FD on destination side

2022-06-16 Thread Dr. David Alan Gilbert
* Het Gala (het.g...@nutanix.com) wrote: > i) Modified the format of qemu monitor command: ‘migrate-incoming’ by adding >a list, each element in the list is to open listeners with a given number >of multiFD channels. > > ii) Qemu starts with -incoming flag defer and -multi-fd-incoming defe

Re: [PATCH qemu] ppc/spapr: Implement H_WATCHDOG

2022-06-16 Thread Daniel Henrique Barboza
Hey, As you might have seen in the kernel thread I was unable to test the implementation. The code errors out down there: On 6/8/22 00:01, Alexey Kardashevskiy wrote: The new PAPR 2.12 defines a watchdog facility managed via the new H_WATCHDOG hypercall. This adds H_WATCHDOG support which a

Re: [PATCH 4/4] Adding support for multi-FD connections dynamically

2022-06-16 Thread Dr. David Alan Gilbert
* Het Gala (het.g...@nutanix.com) wrote: > i) Dynamically decide appropriate source and destination ip pairs for the >corresponding multi-FD channel to be connected. > > ii) Removed the support for setting the number of multi-fd channels from qmp > commands. As now all multiFD parameters w

Re: misaligned-pointer-use libslirp/src/tcp_input.c

2022-06-16 Thread Alexander Bulekov
On 220616 0930, Patrick Venture wrote: > On Thu, Jun 16, 2022 at 6:31 AM Alexander Bulekov wrote: > > > Is this an --enable-sanitizers build? The virtual-device fuzzer catches > > > > Yeah - it should be reproducible with a sanitizers build from HEAD -- I can > try to get a manual instance going

Re: [Qemu-devel] [PATCH v1] virtio-scsi: Send "REPORTED LUNS CHANGED" sense data upon a disk hotplug.

2022-06-16 Thread Venu Busireddy
Ping? On 2022-05-31 15:22:37 -0500, Venu Busireddy wrote: > When a disk is hotplugged, QEMU reports a VIRTIO_SCSI_EVT_RESET_RESCAN > event, but does not send the "REPORTED LUNS CHANGED" sense data. This > does not conform to Section 5.6.6.3 of the VirtIO specification, which > states "Events wil

Re: [PULL 00/10] virtio,pc,pci: fixes,cleanups,features

2022-06-16 Thread Richard Henderson
On 6/16/22 09:57, Michael S. Tsirkin wrote: The following changes since commit def6fd6c9ce9e00a30cdd0066e0fde206b3f3d2f: Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2022-06-16 07:13:04 -0700) are available in the Git repository at: git://git.kernel.org/pub/

Re: [PATCH 0/2] linux-aio: fix unbalanced plugged counter in laio_io_unplug()

2022-06-16 Thread Mark Mielke
Thank you for finding this and fixing it. This issue has been giving us grief for months, and this patch appears to resolve the problem. In our case, it seemed to have much greater severity with the RHEL / CentOS 7.x Linux 3.10 kernel when tied to SolidFire iSCSI based storage. This caused it to e

Re: [PATCH] target/riscv/pmp: guard against PMP ranges with a negative size

2022-06-16 Thread Alistair Francis
On Thu, Jun 16, 2022 at 10:20 PM Nicolas Pitre wrote: > > On Thu, 16 Jun 2022, Alistair Francis wrote: > > > On Thu, Jun 16, 2022 at 7:12 AM Nicolas Pitre wrote: > > > > > > For a TOR entry to match, the stard address must be lower than the end > > > address. Normally this is always the case, but

Re: [PATCH] target/riscv/pmp: guard against PMP ranges with a negative size

2022-06-16 Thread Alistair Francis
On Thu, Jun 16, 2022 at 7:12 AM Nicolas Pitre wrote: > > For a TOR entry to match, the stard address must be lower than the end > address. Normally this is always the case, but correct code might still > run into the following scenario: > > Initial state: > > pmpaddr3 = 0x2000 pmp3cf

Re: [RFC PATCH v8 00/21] Net Control VQ support with asid in vDPA SVQ

2022-06-16 Thread Jason Wang
On Wed, Jun 15, 2022 at 6:03 PM Eugenio Perez Martin wrote: > > On Wed, Jun 15, 2022 at 5:04 AM Jason Wang wrote: > > > > On Tue, Jun 14, 2022 at 5:32 PM Eugenio Perez Martin > > wrote: > > > > > > On Tue, Jun 14, 2022 at 10:20 AM Jason Wang wrote: > > > > > > > > On Tue, Jun 14, 2022 at 4:14 P

Re: New "IndustryStandard" fw_cfg?

2022-06-16 Thread Xiaoyao Li
On 6/16/2022 4:28 PM, Gerd Hoffmann wrote: Hi, After re-read and re-think, I think the problem is better to state as: we need an interface for QEMU to tell OVMF how much memory it needs to accept, from [Minimum to All]. So for the case that user wants to boot an partial-enabled confidential

Re: [PATCH qemu] ppc/spapr: Implement H_WATCHDOG

2022-06-16 Thread Alexey Kardashevskiy
On 6/17/22 04:42, Daniel Henrique Barboza wrote: Hey, As you might have seen in the kernel thread I was unable to test the implementation. The code errors out down there: On 6/8/22 00:01, Alexey Kardashevskiy wrote: The new PAPR 2.12 defines a watchdog facility managed via the new H_WATC

[PATCH] virtio-iommu: Fix the partial copy of probe request

2022-06-16 Thread Zhenzhong Duan
The structure of probe request doesn't include the tail, this lead to a few field is missed to be copied. Currently this isn't an issue as those missed field belong to reserved field, just in case reserved field will be used in the future. By this chance, also remove a few useless code. Signed-of

Re: [PATCH] virtio-iommu: Fix the partial copy of probe request

2022-06-16 Thread Michael S. Tsirkin
On Fri, Jun 17, 2022 at 11:43:48AM +0800, Zhenzhong Duan wrote: > The structure of probe request doesn't include the tail, this lead to > a few field is missed to be copied. Currently this isn't an issue as > those missed field belong to reserved field, just in case reserved > field will be used in

RE: [PATCH] virtio-iommu: Fix the partial copy of probe request

2022-06-16 Thread Duan, Zhenzhong
>-Original Message- >From: Michael S. Tsirkin >Sent: Friday, June 17, 2022 1:31 PM >To: Duan, Zhenzhong >Cc: qemu-devel@nongnu.org; eric.au...@redhat.com >Subject: Re: [PATCH] virtio-iommu: Fix the partial copy of probe request > >On Fri, Jun 17, 2022 at 11:43:48AM +0800, Zhenzhong Dua

[PATCH qemu v2 0/2] ppc/spapr: Implement H_WATCHDOG

2022-06-16 Thread Alexey Kardashevskiy
This implements H_WATCHDOG. More detailed comments are in the patches. This is based on sha1 96c343cc774b Joel Stanley "linux-user: Add PowerPC ISA 3.1 and MMA to hwcap". Please comment. Thanks. Alexey Kardashevskiy (2): ppc: Define SETFIELD for the ppc target ppc/spapr: Implement H_WATCHD

[PATCH qemu v2 2/2] ppc/spapr: Implement H_WATCHDOG

2022-06-16 Thread Alexey Kardashevskiy
The new PAPR 2.12 defines a watchdog facility managed via the new H_WATCHDOG hypercall. This adds H_WATCHDOG support which a proposed driver for pseries uses: https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=303120 This was tested by running QEMU with a debug kernel and command line

[PATCH qemu v2 1/2] ppc: Define SETFIELD for the ppc target

2022-06-16 Thread Alexey Kardashevskiy
It keeps repeating, move it to the header. This uses __builtin_ctzl() to allow using the macros in #define. Signed-off-by: Alexey Kardashevskiy --- include/hw/pci-host/pnv_phb3_regs.h | 16 target/ppc/cpu.h| 5 + hw/intc/pnv_xive.c | 20

[PATCH v2] virtio-iommu: Fix the partial copy of probe request

2022-06-16 Thread Zhenzhong Duan
The structure of probe request doesn't include the tail, this leads to a few field missed to be copied. Currently this isn't an issue as those missed field belong to reserved field, just in case reserved field will be used in the future. Fixes: 1733eebb9e75b ("virtio-iommu: Implement RESV_MEM prob

Re: [PATCH] hw/nvme: clear aen mask on reset

2022-06-16 Thread Klaus Jensen
On May 12 11:30, Klaus Jensen wrote: > From: Klaus Jensen > > The internally maintained AEN mask is not cleared on reset. Fix this. > > Signed-off-by: Klaus Jensen > --- > hw/nvme/ctrl.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c > index 1e6e0fcad

<    1   2   3