Re: [PATCH v12 13/14] vfio-user: handle device interrupts

2022-06-14 Thread Stefan Hajnoczi
On Mon, Jun 13, 2022 at 04:26:33PM -0400, Jagannathan Raman wrote: > Forward remote device's interrupts to the guest > > Signed-off-by: Elena Ufimtseva > Signed-off-by: John G Johnson > Signed-off-by: Jagannathan Raman > --- > include/hw/pci/msi.h | 1 + > include/hw/pci/msix.h

Re: [PATCH v12 00/14] vfio-user server in QEMU

2022-06-14 Thread Stefan Hajnoczi
On Mon, Jun 13, 2022 at 04:26:20PM -0400, Jagannathan Raman wrote: > This is v12 of the server side changes to enable vfio-user in QEMU. > > Thanks so much for reviewing this series and sharing your feedback. > > We made the following changes in this series: > [PATCH v12 13/14] vfio-user: handle

Re: [PATCH v2 1/2] hw: m25p80: add WP# pin and SRWD bit for write protection

2022-06-14 Thread Cédric Le Goater
Hello Dan On 6/14/22 07:45, Dan Zhang wrote: Just find out how to use mutt to reply all in the thread. repeat the previous comments. Add STATE_HIZ to handle decode_new_command aborting gracefully. On Thu, Jun 09, 2022 at 08:06:00PM +, Peter Delevoryas wrote: On Jun 9, 2022, at 12:22 PM,

Re: [PATCH 1/2] hw/nvme: Implement shadow doorbell buffer support

2022-06-14 Thread Jinhao Fan
> On Jun 14, 2022, at 5:15 AM, Keith Busch wrote: > > > @@ -6538,9 +6544,25 @@ static void nvme_process_db(NvmeCtrl *n, hwaddr addr, > int val) > > trace_pci_nvme_mmio_doorbell_sq(sq->sqid, new_tail); > > -if (!sq->db_addr) { > sq->tail = new_tail; > +if (sq

Re: [PATCH v6 0/8] KVM: mm: fd-based approach for supporting KVM guest private memory

2022-06-14 Thread Chao Peng
On Thu, Jun 09, 2022 at 08:29:06PM +, Sean Christopherson wrote: > On Wed, Jun 08, 2022, Vishal Annapurve wrote: > > ... > > > With this patch series, it's actually even not possible for userspace VMM > > > to allocate private page by a direct write, it's basically unmapped from > > > there. If

Re: [PATCH v2 1/1] nbd: trace long NBD operations

2022-06-14 Thread Vladimir Sementsov-Ogievskiy
On 5/30/22 13:39, Denis V. Lunev wrote: At the moment there are 2 sources of lengthy operations if configured: * open connection, which could retry inside and * reconnect of already opened connection These operations could be quite lengthy and cumbersome to catch thus it would be quite natural to

Re: [PATCH 1/1] block: use 'unsigned' for in_flight field on driver state

2022-06-14 Thread Vladimir Sementsov-Ogievskiy
On 5/30/22 13:39, Denis V. Lunev wrote: This patch makes in_flight field 'unsigned' for BDRVNBDState and MirrorBlockJob. This matches the definition of this field on BDS and is generically correct - we should never get negative value here. Signed-off-by: Denis V. Lunev CC: John Snow CC: Vladimir

Re: [RFC PATCH v8 00/21] Net Control VQ support with asid in vDPA SVQ

2022-06-14 Thread Eugenio Perez Martin
On Tue, Jun 14, 2022 at 10:02 AM Jason Wang wrote: > > On Tue, Jun 14, 2022 at 12:32 AM Eugenio Perez Martin > wrote: > > > > On Wed, Jun 8, 2022 at 9:28 PM Eugenio Perez Martin > > wrote: > > > > > > On Wed, Jun 8, 2022 at 7:51 AM Jason Wang wrote: > > > > > > > > > > > > 在 2022/5/20 03:12, E

Re: [RFC PATCH v8 00/21] Net Control VQ support with asid in vDPA SVQ

2022-06-14 Thread Jason Wang
On Tue, Jun 14, 2022 at 12:32 AM Eugenio Perez Martin wrote: > > On Wed, Jun 8, 2022 at 9:28 PM Eugenio Perez Martin > wrote: > > > > On Wed, Jun 8, 2022 at 7:51 AM Jason Wang wrote: > > > > > > > > > 在 2022/5/20 03:12, Eugenio Pérez 写道: > > > > Control virtqueue is used by networking device fo

Re: [RFC PATCH v8 00/21] Net Control VQ support with asid in vDPA SVQ

2022-06-14 Thread Jason Wang
On Tue, Jun 14, 2022 at 4:14 PM Eugenio Perez Martin wrote: > > On Tue, Jun 14, 2022 at 10:02 AM Jason Wang wrote: > > > > On Tue, Jun 14, 2022 at 12:32 AM Eugenio Perez Martin > > wrote: > > > > > > On Wed, Jun 8, 2022 at 9:28 PM Eugenio Perez Martin > > > wrote: > > > > > > > > On Wed, Jun 8

[PATCH] target/ppc: cpu_init: Clean up stop state on cpu reset

2022-06-14 Thread Frederic Barrat
The 'resume_as_sreset' attribute of a cpu can be set when a thread is entering a stop state on ppc books. It causes the thread to be re-routed to vector 0x100 when woken up by an exception. So it must be cleaned on reset or a thread might be re-routed unexpectedly after a reset, when it was not in

Re: [PATCH v1 3/7] gitlab-ci: Fix the build-cfi-aarch64 and build-cfi-ppc64-s390x jobs

2022-06-14 Thread Daniel P . Berrangé
On Tue, Jun 14, 2022 at 06:30:47AM +0200, Thomas Huth wrote: > On 13/06/2022 23.46, Richard Henderson wrote: > > On 6/13/22 10:12, Alex Bennée wrote: > > > From: Thomas Huth > > > > > > The job definitions recently got a second "variables:" section by > > > accident and thus are failing now if on

Re: [PATCH v2 1/2] QIOChannelSocket: Reduce ifdefs to improve readability

2022-06-14 Thread Daniel P . Berrangé
On Mon, Jun 13, 2022 at 06:21:18PM -0300, Leonardo Bras Soares Passos wrote: > On Fri, Jun 10, 2022 at 5:25 AM Daniel P. Berrangé > wrote: > > > > [...] > > > Ok, so if it is checked earlier then we merely need an assert. > > > > if (flags & QIO_CHANNEL_WRITE_FLAG_ZERO_COPY) { > > #ifdef

Re: [PATCH v3 2/2] QIOChannelSocket: Fix zero-copy send so socket flush works

2022-06-14 Thread Daniel P . Berrangé
On Tue, Jun 14, 2022 at 02:17:26AM -0300, Leonardo Bras wrote: > Somewhere between v6 and v7 the of the zero-copy-send patchset a crucial > part of the flushing mechanism got missing: incrementing zero_copy_queued. > > Without that, the flushing interface becomes a no-op, and there is no > guarant

Re: [PATCH v3 1/2] QIOChannelSocket: Introduce assert and reduce ifdefs to improve readability

2022-06-14 Thread Daniel P . Berrangé
On Tue, Jun 14, 2022 at 02:17:25AM -0300, Leonardo Bras wrote: > During implementation of MSG_ZEROCOPY feature, a lot of #ifdefs were > introduced, particularly at qio_channel_socket_writev(). > > Rewrite some of those changes so it's easier to read. > > Also, introduce an assert to help detect i

Re: [PATCH RFC 1/2] arm/kvm: enable MTE if available

2022-06-14 Thread Cornelia Huck
On Fri, Jun 10 2022, Eric Auger wrote: > Hi Connie, > On 5/12/22 15:11, Cornelia Huck wrote: >> We need to disable migration, as we do not yet have a way to migrate >> the tags as well. > > This patch does much more than adding a migration blocker ;-) you may > describe the new cpu option and how

Re: [PATCH v2] docs: add PCIe root bus for VGA compat guideline

2022-06-14 Thread Gerd Hoffmann
On Mon, Jun 13, 2022 at 03:47:04PM +0200, Laszlo Ersek wrote: > On 06/12/22 19:32, Kevin Locke wrote: > > PCI Express devices which use legacy VGA compatibility should be placed > > on the Root Complex. This simplifies ioport access to VGA registers, > > which requires use of a special exception b

Re: [PATCH 1/5] tests/qemu-iotests: hotfix for 307, 223 output

2022-06-14 Thread Daniel P . Berrangé
On Mon, Jun 13, 2022 at 09:50:40PM -0400, John Snow wrote: > Fixes: 58a6fdcc CC'ing Eric given the above commit hash > Signed-off-by: John Snow > --- > tests/qemu-iotests/223.out | 4 ++-- > tests/qemu-iotests/307.out | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) Tested-by: Dani

Re: [PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag

2022-06-14 Thread Igor Mammedov
On Mon, 13 Jun 2022 16:09:53 +0100 Stefan Hajnoczi wrote: > On Mon, Jun 13, 2022 at 05:01:10PM +0200, Julia Suvorova wrote: > > On Tue, May 31, 2022 at 5:32 PM Stefan Hajnoczi > > wrote: > > > > > > On Tue, May 31, 2022 at 04:51:47PM +0200, Julia Suvorova wrote: > > > > In the ACPI specific

Re: [PATCH 2/5] tests/qemu-iotests: skip 108 when FUSE is not loaded

2022-06-14 Thread Daniel P . Berrangé
On Tue, Jun 14, 2022 at 06:46:35AM +0200, Thomas Huth wrote: > On 14/06/2022 03.50, John Snow wrote: > > In certain container environments we may not have FUSE at all, so skip > > the test in this circumstance too. > > > > Signed-off-by: John Snow > > --- > > tests/qemu-iotests/108 | 6 ++ >

[PATCH v16 0/9] Add LoongArch linux-user emulation support

2022-06-14 Thread Song Gao
Hi All, This series add support linux-user emulation. As the LoongArch kernel had merged into 5.19-rc1, you can see the latest kernel at https://kernel.org Need review patches: 0002-linux-user-Add-LoongArch-signal-support.patch 0007-target-loongarch-Adjust-functions-and-structure-to-s.patch

[PATCH v16 8/9] default-configs: Add loongarch linux-user support

2022-06-14 Thread Song Gao
This patch adds loongarch64 linux-user default configs file. Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson Reviewed-by: WANG Xuerui --- configs/targets/loongarch64-linux-user.mak | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 configs/targets

[PATCH v16 5/9] linux-user: Add LoongArch cpu_loop support

2022-06-14 Thread Song Gao
Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson --- linux-user/loongarch64/cpu_loop.c | 96 + linux-user/loongarch64/target_cpu.h | 34 ++ 2 files changed, 130 insertions(+) create mode 100644 linux-user/loongarch64/cpu_

[PATCH v16 6/9] scripts: add loongarch64 binfmt config

2022-06-14 Thread Song Gao
Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson --- scripts/qemu-binfmt-conf.sh | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh index 9cb723f443..1f4e2cd19d 100755 --- a/script

[PATCH v16 3/9] linux-user: Add LoongArch elf support

2022-06-14 Thread Song Gao
Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- linux-user/elfload.c| 54 + linux-user/loongarch64/target_elf.h | 12 +++ 2 files changed, 66 insertions(+) create mode 1

[PATCH v16 1/9] linux-user: Add LoongArch generic header files

2022-06-14 Thread Song Gao
This includes: - sockbits.h - target_errno_defs.h - target_fcntl.h - termbits.h - target_resource.h - target_structs.h Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: WANG Xuerui --- linux-user/loongarch64/s

Re: [PATCH 05/11] ppc/pnv: make pnv_ics_get() use the chip8->phbs[] array

2022-06-14 Thread Frederic Barrat
On 13/06/2022 17:44, Daniel Henrique Barboza wrote: The function is working today by getting all the child objects of the chip, interacting with each of them to check whether the child is a PHB, and then doing what needs to be done. We have all the chip PHBs in the phbs[] array so interacting

[PATCH v16 7/9] target/loongarch: Adjust functions and structure to support user-mode

2022-06-14 Thread Song Gao
Some functions and member of the structure are different with softmmu-mode So we need adjust them to support user-mode. Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang --- linux-user/elfload.c | 2 +- target/loongarch/cpu.c| 35

[PATCH v16 2/9] linux-user: Add LoongArch signal support

2022-06-14 Thread Song Gao
Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang --- linux-user/loongarch64/signal.c| 283 + linux-user/loongarch64/target_signal.h | 13 ++ 2 files changed, 296 insertions(+) create mode 100644 linux-user/loongarch64/signal.c create mode 100644 linux-user/

[PATCH v16 4/9] linux-user: Add LoongArch syscall support

2022-06-14 Thread Song Gao
Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- linux-user/loongarch64/syscall_nr.h | 312 linux-user/loongarch64/target_syscall.h | 48 linux-user/syscall_defs.h | 10

Re: [PATCH 01/11] ppc/pnv: move root port attach to pnv_phb4_realize()

2022-06-14 Thread Frederic Barrat
On 13/06/2022 17:44, Daniel Henrique Barboza wrote: Creating a root port is something related to the PHB, not the PEC. It also makes the logic more in line with what pnv-phb3 does. Signed-off-by: Daniel Henrique Barboza --- LGTM, Reviewed-by: Frederic Barrat Fred hw/pci-host/pnv_p

Re: [PATCH 4/5] tests/vm: switch CentOS 8 to CentOS 8 Stream

2022-06-14 Thread Daniel P . Berrangé
On Mon, Jun 13, 2022 at 09:50:43PM -0400, John Snow wrote: > The old CentOS image didn't work anymore because it was already EOL at > the beginning of 2022. > > Signed-off-by: John Snow > --- > tests/vm/centos | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/test

[PATCH v16 9/9] target/loongarch: Update README

2022-06-14 Thread Song Gao
Add linux-user emulation introduction Signed-off-by: Song Gao Signed-off-by: Xiaojuan Yang --- target/loongarch/README | 39 +-- 1 file changed, 37 insertions(+), 2 deletions(-) diff --git a/target/loongarch/README b/target/loongarch/README index 4dcd0f1682.

Re: [PATCH 06/11] ppc/pnv: make pnv_ics_resend() use chip8->phbs[]

2022-06-14 Thread Frederic Barrat
On 13/06/2022 17:44, Daniel Henrique Barboza wrote: pnv_ics_resend() is scrolling through all the child objects of the chip to search for the PHBs. It's faster and simpler to just use the phbs[] array. pnv_ics_resend_child() was folded into pnv_ics_resend() since it's too simple to justify it

Re: [PATCH 03/11] ppc/pnv: use dev->parent_bus->parent to get the PHB

2022-06-14 Thread Frederic Barrat
On 13/06/2022 17:44, Daniel Henrique Barboza wrote: It is not advisable to execute an object_dynamic_cast() to poke into bus->qbus.parent and follow it up with a C cast into the PnvPHB type we think we got. A better way is to access the PnvPHB object via a QOM macro accessing the existing par

Re: [PATCH 02/11] ppc/pnv: attach phb3/phb4 root ports in QOM tree

2022-06-14 Thread Frederic Barrat
On 13/06/2022 17:44, Daniel Henrique Barboza wrote: At this moment we leave the pnv-phb3(4)-root-port unattached in QOM: /unattached (container) (...) /device[2] (pnv-phb3-root-port) /bus master container[0] (memory-region) /bus master[0] (memory-region) /pci_brid

Re: [PATCH 07/11] ppc/pnv: make pnv_chip_power8_pic_print_info() use chip8->phbs[]

2022-06-14 Thread Frederic Barrat
On 13/06/2022 17:44, Daniel Henrique Barboza wrote: It's inneficient to scroll all child objects when we have all PHBs available in chip8->phbs[]. pnv_chip_power8_pic_print_info_child() ended up folded into pic_print_info() for simplicity. Signed-off-by: Daniel Henrique Barboza --- Revie

Re: [PATCH 04/11] ppc/pnv: use dev instead of pci->qdev in root_port_realize()

2022-06-14 Thread Frederic Barrat
On 13/06/2022 17:44, Daniel Henrique Barboza wrote: We already have access to the 'dev' object. Signed-off-by: Daniel Henrique Barboza --- Reviewed-by: Frederic Barrat Fred hw/pci-host/pnv_phb3.c | 4 ++-- hw/pci-host/pnv_phb4.c | 5 ++--- 2 files changed, 4 insertions(+), 5 de

Re: [PULL 00/16] Kraxel 20220613 patches

2022-06-14 Thread Gerd Hoffmann
On Mon, Jun 13, 2022 at 08:52:21AM -0700, Richard Henderson wrote: > On 6/13/22 04:36, Gerd Hoffmann wrote: > > The following changes since commit dcb40541ebca7ec98a14d461593b3cd7282b4fac: > > > >Merge tag 'mips-20220611' of https://github.com/philmd/qemu into staging > > (2022-06-11 21:13:27

Re: [RFC PATCH v8 00/21] Net Control VQ support with asid in vDPA SVQ

2022-06-14 Thread Eugenio Perez Martin
On Tue, Jun 14, 2022 at 10:20 AM Jason Wang wrote: > > On Tue, Jun 14, 2022 at 4:14 PM Eugenio Perez Martin > wrote: > > > > On Tue, Jun 14, 2022 at 10:02 AM Jason Wang wrote: > > > > > > On Tue, Jun 14, 2022 at 12:32 AM Eugenio Perez Martin > > > wrote: > > > > > > > > On Wed, Jun 8, 2022 at 9

Re: [PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag

2022-06-14 Thread David Hildenbrand
On 14.06.22 10:54, Igor Mammedov wrote: > On Mon, 13 Jun 2022 16:09:53 +0100 > Stefan Hajnoczi wrote: > >> On Mon, Jun 13, 2022 at 05:01:10PM +0200, Julia Suvorova wrote: >>> On Tue, May 31, 2022 at 5:32 PM Stefan Hajnoczi >>> wrote: On Tue, May 31, 2022 at 04:51:47PM +0200, Julia S

Re: [PATCH 05/11] ppc/pnv: make pnv_ics_get() use the chip8->phbs[] array

2022-06-14 Thread Cédric Le Goater
On 6/13/22 17:44, Daniel Henrique Barboza wrote: The function is working today by getting all the child objects of the chip, interacting with each of them to check whether the child is a PHB, and then doing what needs to be done. We have all the chip PHBs in the phbs[] array so interacting with

Re: [PULL 00/16] Kraxel 20220613 patches

2022-06-14 Thread Daniel P . Berrangé
On Tue, Jun 14, 2022 at 11:40:38AM +0200, Gerd Hoffmann wrote: > On Mon, Jun 13, 2022 at 08:52:21AM -0700, Richard Henderson wrote: > > On 6/13/22 04:36, Gerd Hoffmann wrote: > > > The following changes since commit > > > dcb40541ebca7ec98a14d461593b3cd7282b4fac: > > > > > >Merge tag 'mips-20

Re: [PATCH 02/11] ppc/pnv: attach phb3/phb4 root ports in QOM tree

2022-06-14 Thread Cédric Le Goater
On 6/14/22 11:09, Frederic Barrat wrote: On 13/06/2022 17:44, Daniel Henrique Barboza wrote: At this moment we leave the pnv-phb3(4)-root-port unattached in QOM:    /unattached (container) (...) /device[2] (pnv-phb3-root-port)    /bus master container[0] (memory-region)    /bus m

Re: [PATCH 08/11] ppc/pnv: turn chip8->phbs[] into a PnvPHB3* array

2022-06-14 Thread Frederic Barrat
On 13/06/2022 17:44, Daniel Henrique Barboza wrote: When enabling user created PHBs (a change reverted by commit 9c10d86fee) we were handling PHBs created by default versus by the user in different manners. The only difference between these PHBs is that one will have a valid phb3->chip that is

Re: [PATCH 06/11] ppc/pnv: make pnv_ics_resend() use chip8->phbs[]

2022-06-14 Thread Cédric Le Goater
On 6/14/22 11:24, Frederic Barrat wrote: On 13/06/2022 17:44, Daniel Henrique Barboza wrote: pnv_ics_resend() is scrolling through all the child objects of the chip to search for the PHBs. It's faster and simpler to just use the phbs[] array. pnv_ics_resend_child() was folded into pnv_ics_res

Re: [PATCH 10/11] ppc/pnv: move PHB3 initialization to realize time

2022-06-14 Thread Frederic Barrat
On 13/06/2022 17:44, Daniel Henrique Barboza wrote: There's nothing special that is being done in pnv_chip_power8_instance_init() that can't be done during pnv_chip_power8_realize(). Move the PHB creating and phbs[] assignment to power8_realize(). We also need to assign a proper phb->chip par

[PULL 02/10] block/copy-before-write: add on-cbw-error open parameter

2022-06-14 Thread Vladimir Sementsov-Ogievskiy
From: Vladimir Sementsov-Ogievskiy Currently, behavior on copy-before-write operation failure is simple: report error to the guest. Let's implement alternative behavior: break the whole copy-before-write process (and corresponding backup job or NBD client) but keep guest working. It's needed if

[PULL 05/10] block/block-copy: block_copy(): add timeout_ns parameter

2022-06-14 Thread Vladimir Sementsov-Ogievskiy
From: Vladimir Sementsov-Ogievskiy Add possibility to limit block_copy() call in time. To be used in the next commit. As timed-out block_copy() call will continue in background anyway (we can't immediately cancel IO operation), it's important also give user a possibility to pass a callback, to d

[PULL 01/10] block/copy-before-write: refactor option parsing

2022-06-14 Thread Vladimir Sementsov-Ogievskiy
From: Vladimir Sementsov-Ogievskiy We are going to add one more option of enum type. Let's refactor option parsing so that we can simply work with BlockdevOptionsCbw object. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Hanna Reitz Signed-off-by: Vladimir Sementsov-Ogievskiy --- b

[PULL 06/10] block/copy-before-write: implement cbw-timeout option

2022-06-14 Thread Vladimir Sementsov-Ogievskiy
From: Vladimir Sementsov-Ogievskiy In some scenarios, when copy-before-write operations lasts too long time, it's better to cancel it. Most useful would be to use the new option together with on-cbw-error=break-snapshot: this way if cbw operation takes too long time we'll just cancel backup proc

[PULL 00/10] Block jobs & NBD patches

2022-06-14 Thread Vladimir Sementsov-Ogievskiy
The following changes since commit debd0753663bc89c86f5462a53268f2e3f680f60: Merge tag 'pull-testing-next-140622-1' of https://github.com/stsquad/qemu into staging (2022-06-13 21:10:57 -0700) are available in the Git repository at: https://gitlab.com/vsementsov/qemu.git tags/pull-block-2022

[PULL 08/10] nbd: trace long NBD operations

2022-06-14 Thread Vladimir Sementsov-Ogievskiy
From: "Denis V. Lunev" At the moment there are 2 sources of lengthy operations if configured: * open connection, which could retry inside and * reconnect of already opened connection These operations could be quite lengthy and cumbersome to catch thus it would be quite natural to add trace points

[PULL 04/10] util: add qemu-co-timeout

2022-06-14 Thread Vladimir Sementsov-Ogievskiy
From: Vladimir Sementsov-Ogievskiy Add new API, to make a time limited call of the coroutine. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Hanna Reitz Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/qemu/coroutine.h | 13 ++ util/meson.build | 1 + util/qemu-

[PATCH 1/2] Trivial: 3 char repeat typos

2022-06-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Inspired by Julia Lawall's fixing of Linux kernel comments, I looked at qemu, although I did it manually. Signed-off-by: Dr. David Alan Gilbert --- hw/intc/openpic.c| 2 +- hw/net/imx_fec.c | 2 +- hw/pci/pcie_aer.c

[PULL 07/10] iotests: copy-before-write: add cases for cbw-timeout option

2022-06-14 Thread Vladimir Sementsov-Ogievskiy
From: Vladimir Sementsov-Ogievskiy Add two simple test-cases: timeout failure with break-snapshot-on-cbw-error behavior and similar with break-guest-write-on-cbw-error behavior. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Hanna Reitz Signed-off-by: Vladimir Sementsov-Ogievskiy --

[PATCH 2/2] trivial typos: namesapce

2022-06-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" 'namespace' is misspelled in a bunch of places. Signed-off-by: Dr. David Alan Gilbert --- hw/9pfs/9p-xattr-user.c | 8 hw/acpi/nvdimm.c| 2 +- hw/nvme/ctrl.c | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/9pfs/

[PULL 03/10] iotests: add copy-before-write: on-cbw-error tests

2022-06-14 Thread Vladimir Sementsov-Ogievskiy
From: Vladimir Sementsov-Ogievskiy Add tests for new option of copy-before-write filter: on-cbw-error. Note that we use QEMUMachine instead of VM class, because in further commit we'll want to use throttling which doesn't work with -accel qtest used by VM. We also touch pylintrc to not break io

[PULL 09/10] block: use 'unsigned' for in_flight field on driver state

2022-06-14 Thread Vladimir Sementsov-Ogievskiy
From: "Denis V. Lunev" This patch makes in_flight field 'unsigned' for BDRVNBDState and MirrorBlockJob. This matches the definition of this field on BDS and is generically correct - we should never get negative value here. Signed-off-by: Denis V. Lunev CC: John Snow CC: Vladimir Sementsov-Ogie

[PULL 10/10] MAINTAINERS: update Vladimir's address and repositories

2022-06-14 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- MAINTAINERS | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 0df25ed4b0..9e37bfe279 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2538,7 +2538,7 @@ F: scsi/* Block Jobs

[PATCH 0/2] Two sets of trivials

2022-06-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" I've sent the 3 char set last month, but have updated it a little; I cleaned up a comment style that was already broken so checkpatch is happy. The 'namesapce' is a new patch; it's amazing how many places make the same typo! Dave Dr. David Alan Gilbert (2): Tri

Re: [PATCH v2 07/11] vfio/migration: Implement VFIO migration protocol v2

2022-06-14 Thread Joao Martins
On 5/30/22 18:07, Avihai Horon wrote: > +static int vfio_save_complete_precopy(QEMUFile *f, void *opaque) > +{ > +VFIODevice *vbasedev = opaque; > +enum vfio_device_mig_state recover_state; > +int ret; > + > +/* We reach here with device state STOP or STOP_COPY only */ > +recove

[PATCH 2/2] tap: initialize TAPState->enabled according to the actual state of queue

2022-06-14 Thread Andrey Ryabinin
Currently TAPState->enabled initialized as true. If fd was passed to qemu in a disabled state it will cause an assert at the attempt to detach queue in virtio_net_set_queues(): virtio_net_set_queues() : r = peer_detach() -> tap_disable(): if (s->enab

[PATCH 0/2] Make local migration with TAP network device possible

2022-06-14 Thread Andrey Ryabinin
Hi These couple patches aims to make possible local migration (within one host) on the same TAP device used by source and destination QEMU The scenario looks like this 1. Create TAP devices and pass file descriptors to source QEMU 2. Launch destination QEMU (-incoming defer) and pass same desc

[PATCH 1/2] chardev: don't set O_NONBLOCK on SCM_RIGHTS file descriptors.

2022-06-14 Thread Andrey Ryabinin
This reverts commit 9b938c7262e4 ("chardev: clear O_NONBLOCK on SCM_RIGHTS file descriptors"). File descriptor passed to QEMU via 'getfd' QMP command always changed to blocking mode. Instead of that, change blocking mode by QEMU file descriptors users when necessary, e.g. like migration. We need

Re: [PATCH 0/2] Make local migration with TAP network device possible

2022-06-14 Thread Daniel P . Berrangé
On Tue, Jun 14, 2022 at 02:18:41PM +0300, Andrey Ryabinin wrote: > Hi > > These couple patches aims to make possible local migration (within one host) > on the same TAP device used by source and destination QEMU > > The scenario looks like this > 1. Create TAP devices and pass file descriptors

Re: [PATCH 01/11] ppc/pnv: move root port attach to pnv_phb4_realize()

2022-06-14 Thread Cédric Le Goater
On 6/13/22 17:44, Daniel Henrique Barboza wrote: Creating a root port is something related to the PHB, not the PEC. It also makes the logic more in line with what pnv-phb3 does. Signed-off-by: Daniel Henrique Barboza Reviewed-by: Cédric Le Goater So the root port is back where it was. Coul

Re: [PATCH 02/11] ppc/pnv: attach phb3/phb4 root ports in QOM tree

2022-06-14 Thread Cédric Le Goater
On 6/13/22 17:44, Daniel Henrique Barboza wrote: At this moment we leave the pnv-phb3(4)-root-port unattached in QOM: /unattached (container) (...) /device[2] (pnv-phb3-root-port) /bus master container[0] (memory-region) /bus master[0] (memory-region) /pci_bridge_io[

Re: [PATCH 03/11] ppc/pnv: use dev->parent_bus->parent to get the PHB

2022-06-14 Thread Cédric Le Goater
On 6/13/22 17:44, Daniel Henrique Barboza wrote: It is not advisable to execute an object_dynamic_cast() to poke into bus->qbus.parent and follow it up with a C cast into the PnvPHB type we think we got. A better way is to access the PnvPHB object via a QOM macro accessing the existing parent li

Re: [PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag

2022-06-14 Thread Julia Suvorova
On Tue, Jun 14, 2022 at 11:50 AM David Hildenbrand wrote: > > On 14.06.22 10:54, Igor Mammedov wrote: > > On Mon, 13 Jun 2022 16:09:53 +0100 > > Stefan Hajnoczi wrote: > > > >> On Mon, Jun 13, 2022 at 05:01:10PM +0200, Julia Suvorova wrote: > >>> On Tue, May 31, 2022 at 5:32 PM Stefan Hajnoczi

Re: [PULL 00/16] Kraxel 20220613 patches

2022-06-14 Thread Gerd Hoffmann
> > Hmm, build worked here and CI passed too. > > > > I think this is one of those cases where the build directory must be > > deleted because one subdirectory is replaced by a compatibility > > symlink. > > Except 'configure' deals with that, as it explicitly rm -rf's the > symlink target: > >

[PULL 01/15] ui/gtk-gl-area: implement GL context destruction

2022-06-14 Thread Gerd Hoffmann
From: Volker Rümelin The counterpart function for gd_gl_area_create_context() is currently empty. Implement the gd_gl_area_destroy_context() function to avoid GL context leaks. Signed-off-by: Volker Rümelin Message-Id: <20220605085131.7711-1-vr_q...@t-online.de> Signed-off-by: Gerd Hoffmann --

[PULL 03/15] ui/cocoa: Fix poweroff request code

2022-06-14 Thread Gerd Hoffmann
From: Akihiko Odaki Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20220529082508.89097-1-akihiko.od...@gmail.com> Signed-off-by: Gerd Hoffmann --- ui/cocoa.m | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index

[PULL 00/15] Kraxel 20220614 patches

2022-06-14 Thread Gerd Hoffmann
The following changes since commit debd0753663bc89c86f5462a53268f2e3f680f60: Merge tag 'pull-testing-next-140622-1' of https://github.com/stsquad/qemu into staging (2022-06-13 21:10:57 -0700) are available in the Git repository at: git://git.kraxel.org/qemu tags/kraxel-202

[PULL 07/15] docs: Add CanoKey documentation

2022-06-14 Thread Gerd Hoffmann
From: "Hongren (Zenithal) Zheng" Signed-off-by: Hongren (Zenithal) Zheng Message-Id: Signed-off-by: Gerd Hoffmann --- docs/system/device-emulation.rst | 1 + docs/system/devices/canokey.rst | 168 +++ 2 files changed, 169 insertions(+) create mode 100644 docs/s

[PULL 09/15] MAINTAINERS: add myself as CanoKey maintainer

2022-06-14 Thread Gerd Hoffmann
From: "Hongren (Zenithal) Zheng" Signed-off-by: Hongren (Zenithal) Zheng Message-Id: Signed-off-by: Gerd Hoffmann --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0df25ed4b0a3..4cf6174f9f37 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @

[PULL 10/15] hw/usb/hcd-ehci: fix writeback order

2022-06-14 Thread Gerd Hoffmann
From: Arnout Engelen The 'active' bit passes control over a qTD between the guest and the controller: set to 1 by guest to enable execution by the controller, and the controller sets it to '0' to hand back control to the guest. ehci_state_writeback write two dwords to main memory using DMA: the

[PULL 04/15] hw/usb: Add CanoKey Implementation

2022-06-14 Thread Gerd Hoffmann
From: "Hongren (Zenithal) Zheng" This commit added a new emulated device called CanoKey to QEMU. CanoKey implements platform independent features in canokey-core https://github.com/canokeys/canokey-core, and leaves the USB implementation to the platform. In this commit the USB part was implemen

[PULL 15/15] virtio-gpu: Respect UI refresh rate for EDID

2022-06-14 Thread Gerd Hoffmann
From: Akihiko Odaki Signed-off-by: Akihiko Odaki Message-Id: <20220226115516.59830-4-akihiko.od...@gmail.com> Signed-off-by: Gerd Hoffmann --- include/hw/virtio/virtio-gpu.h | 1 + hw/display/virtio-gpu-base.c | 1 + hw/display/virtio-gpu.c| 1 + 3 files changed, 3 insertions(+) dif

[PULL 06/15] meson: Add CanoKey

2022-06-14 Thread Gerd Hoffmann
From: "Hongren (Zenithal) Zheng" Signed-off-by: Hongren (Zenithal) Zheng Message-Id: Signed-off-by: Gerd Hoffmann --- meson_options.txt | 2 ++ hw/usb/Kconfig| 5 + hw/usb/meson.build| 5 + meson.build | 6 ++ scripts/meson

[PULL 13/15] ui/console: Do not return a value with ui_info

2022-06-14 Thread Gerd Hoffmann
From: Akihiko Odaki The returned value is not used and misleading. Signed-off-by: Akihiko Odaki Message-Id: <20220226115516.59830-2-akihiko.od...@gmail.com> Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 2 +- hw/display/virtio-gpu-base.c | 6 +++--- hw/display/virtio-vga.c

[PULL 08/15] docs/system/devices/usb: Add CanoKey to USB devices examples

2022-06-14 Thread Gerd Hoffmann
From: "Hongren (Zenithal) Zheng" Signed-off-by: Hongren (Zenithal) Zheng Message-Id: Signed-off-by: Gerd Hoffmann --- docs/system/devices/usb.rst | 4 1 file changed, 4 insertions(+) diff --git a/docs/system/devices/usb.rst b/docs/system/devices/usb.rst index afb7d6c2268d..872d9167589b

[PULL 05/15] hw/usb/canokey: Add trace events

2022-06-14 Thread Gerd Hoffmann
From: "Hongren (Zenithal) Zheng" Signed-off-by: Hongren (Zenithal) Zheng Message-Id: Signed-off-by: Gerd Hoffmann --- hw/usb/canokey.c| 13 + hw/usb/trace-events | 16 2 files changed, 29 insertions(+) diff --git a/hw/usb/canokey.c b/hw/usb/canokey.c index 6c

Re: [PULL 00/16] Kraxel 20220613 patches

2022-06-14 Thread Gerd Hoffmann
On Mon, Jun 13, 2022 at 08:52:21AM -0700, Richard Henderson wrote: > On 6/13/22 04:36, Gerd Hoffmann wrote: > > The following changes since commit dcb40541ebca7ec98a14d461593b3cd7282b4fac: > > > >Merge tag 'mips-20220611' of https://github.com/philmd/qemu into staging > > (2022-06-11 21:13:27

[PULL 12/15] virtio-gpu: update done only on the scanout associated with rect

2022-06-14 Thread Gerd Hoffmann
From: Dongwon Kim It only needs to update the scanouts containing the rect area coming with the resource-flush request from the guest. Cc: Gerd Hoffmann Cc: Vivek Kasireddy Signed-off-by: Dongwon Kim Message-Id: <20220505214030.4261-1-dongwon@intel.com> Signed-off-by: Gerd Hoffmann ---

[PULL 11/15] usbredir: avoid queuing hello packet on snapshot restore

2022-06-14 Thread Gerd Hoffmann
From: Joelle van Dyne When launching QEMU with "-loadvm", usbredir_create_parser() should avoid setting up the hello packet (just as with "-incoming". On the latest version of libusbredir, usbredirparser_unserialize() will return error if the parser is not "pristine." Signed-off-by: Joelle van D

Re: [PATCH] target/ppc: cpu_init: Clean up stop state on cpu reset

2022-06-14 Thread Fabiano Rosas
Frederic Barrat writes: > The 'resume_as_sreset' attribute of a cpu can be set when a thread is > entering a stop state on ppc books. It causes the thread to be > re-routed to vector 0x100 when woken up by an exception. So it must be > cleaned on reset or a thread might be re-routed unexpectedly

[PULL 02/15] ui/gtk-gl-area: create the requested GL context version

2022-06-14 Thread Gerd Hoffmann
From: Volker Rümelin Since about 2018 virglrenderer (commit fa835b0f88 "vrend: don't hardcode context version") tries to open the highest available GL context version. This is done by creating the known GL context versions from the highest to the lowest until (*create_gl_context) returns a contex

[PULL 14/15] ui: Deliver refresh rate via QemuUIInfo

2022-06-14 Thread Gerd Hoffmann
From: Akihiko Odaki This change adds a new member, refresh_rate to QemuUIInfo in include/ui/console.h. It represents the refresh rate of the physical display backend, and it is more appropriate than GUI update interval as the refresh rate which the emulated device reports: - sdl may set GUI updat

Re: [External] [PATCH v13 3/8] QIOChannelSocket: Implement io_writev zero copy flag & io_flush for CONFIG_LINUX

2022-06-14 Thread chuang xu
On 2022/5/13 下午2:28, Leonardo Bras wrote: @@ -557,15 +578,31 @@ static ssize_t qio_channel_socket_writev(QIOChannel *ioc, memcpy(CMSG_DATA(cmsg), fds, fdsize); } +#ifdef QEMU_MSG_ZEROCOPY +if (flags & QIO_CHANNEL_WRITE_FLAG_ZERO_COPY) { +sflags = MSG_ZEROCOPY; +

Re: [PATCH 1/2] Trivial: 3 char repeat typos

2022-06-14 Thread Daniel Henrique Barboza
On 6/14/22 07:40, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" Inspired by Julia Lawall's fixing of Linux kernel comments, I looked at qemu, although I did it manually. Signed-off-by: Dr. David Alan Gilbert --- Reviewed-by: Daniel Henrique Barboza hw/intc/openp

Re: [PATCH 2/2] docs: build-platforms: Clarify stance on minor releases and backports

2022-06-14 Thread Andrea Bolognani
On Wed, May 04, 2022 at 09:23:28AM +0100, Daniel P. Berrangé wrote: > On Wed, May 04, 2022 at 01:01:03AM -0700, Andrea Bolognani wrote: > > On Wed, Apr 20, 2022 at 09:18:47AM -0700, Andrea Bolognani wrote: > > > On Wed, Apr 20, 2022 at 05:15:08PM +0100, Daniel P. Berrangé wrote: > > > > On Wed, Apr

Re: [PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag

2022-06-14 Thread Igor Mammedov
On Tue, 14 Jun 2022 11:50:43 +0200 David Hildenbrand wrote: > On 14.06.22 10:54, Igor Mammedov wrote: > > On Mon, 13 Jun 2022 16:09:53 +0100 > > Stefan Hajnoczi wrote: > > > >> On Mon, Jun 13, 2022 at 05:01:10PM +0200, Julia Suvorova wrote: > >>> On Tue, May 31, 2022 at 5:32 PM Stefan Hajno

Re: [PATCH 01/11] ppc/pnv: move root port attach to pnv_phb4_realize()

2022-06-14 Thread Daniel Henrique Barboza
On 6/14/22 09:02, Cédric Le Goater wrote: On 6/13/22 17:44, Daniel Henrique Barboza wrote: Creating a root port is something related to the PHB, not the PEC. It also makes the logic more in line with what pnv-phb3 does. Signed-off-by: Daniel Henrique Barboza Reviewed-by: Cédric Le Goater

Re: [External] [PATCH v13 3/8] QIOChannelSocket: Implement io_writev zero copy flag & io_flush for CONFIG_LINUX

2022-06-14 Thread Dr. David Alan Gilbert
* chuang xu (xuchuangxc...@bytedance.com) wrote: > > On 2022/5/13 下午2:28, Leonardo Bras wrote: > > @@ -557,15 +578,31 @@ static ssize_t qio_channel_socket_writev(QIOChannel > > *ioc, > > memcpy(CMSG_DATA(cmsg), fds, fdsize); > > } > > +#ifdef QEMU_MSG_ZEROCOPY > > +if (flags &

Re: [PATCH 2/5] tests/qemu-iotests: skip 108 when FUSE is not loaded

2022-06-14 Thread John Snow
On Tue, Jun 14, 2022 at 4:59 AM Daniel P. Berrangé wrote: > > On Tue, Jun 14, 2022 at 06:46:35AM +0200, Thomas Huth wrote: > > On 14/06/2022 03.50, John Snow wrote: > > > In certain container environments we may not have FUSE at all, so skip > > > the test in this circumstance too. > > > > > > Sig

Re: [PATCH v12 00/14] vfio-user server in QEMU

2022-06-14 Thread Jag Raman
> On Jun 14, 2022, at 3:06 AM, Stefan Hajnoczi wrote: > > On Mon, Jun 13, 2022 at 04:26:20PM -0400, Jagannathan Raman wrote: >> This is v12 of the server side changes to enable vfio-user in QEMU. >> >> Thanks so much for reviewing this series and sharing your feedback. >> >> We made the foll

[PATCH] configure: cleanup -fno-pie detection

2022-06-14 Thread Paolo Bonzini
Place it only inside the 'if test "$pie" = "no"' conditional. Signed-off-by: Paolo Bonzini --- configure | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/configure b/configure index f3dcbd10c3..e2b64334b5 100755 --- a/configure +++ b/configure @@ -1346,13 +1346,6

Re: [PATCH 3/5] tests/vm: use 'cp' instead of 'ln' for temporary vm images

2022-06-14 Thread John Snow
On Tue, Jun 14, 2022 at 12:40 AM Thomas Huth wrote: > > On 14/06/2022 03.50, John Snow wrote: > > If the initial setup fails, you've permanently altered the state of the > > downloaded image in an unknowable way. Use 'cp' like our other test > > setup scripts do. > > > > Signed-off-by: John Snow

Re: [PATCH 4/5] tests/vm: switch CentOS 8 to CentOS 8 Stream

2022-06-14 Thread John Snow
On Tue, Jun 14, 2022 at 5:09 AM Daniel P. Berrangé wrote: > > On Mon, Jun 13, 2022 at 09:50:43PM -0400, John Snow wrote: > > The old CentOS image didn't work anymore because it was already EOL at > > the beginning of 2022. > > > > Signed-off-by: John Snow > > --- > > tests/vm/centos | 8

  1   2   >