Re: [PATCH v9 08/12] target/hexagon: import flex/bison to docker files

2022-05-25 Thread Anton Johansson via
On 5/25/22 22:16, Richard Henderson wrote: No: * one patch to update libvirt-ci and does nothing else. * one patch to update yml template. * one patch to refresh. Just like you enumerated before. r~ Ah, right! Thanks for clarifying. Should I keep all 3 patches in this series? -- Anton J

Re: [PULL 00/15] aspeed queue

2022-05-25 Thread Richard Henderson
https://github.com/legoater/qemu/ tags/pull-aspeed-20220525 for you to fetch changes up to 52bcd997800fab67d57bea6d93e368f6f7a93b24: hw/arm/aspeed: Add i2c devices for AST2600 EVB (2022-05-25 16:22:37 +0200) aspeed queue: * Aspeed

[RFC 0/1] i2c/aspeed: Add slave device handling in new register mode

2022-05-25 Thread Peter Delevoryas
The AST2600/AST1030 new register mode patches[1] and the I2C slave device patches[2] will be really useful, but we still need DMA slave device handling in the new register mode too for the use-cases I'm thinking of (OpenBIC Zephyr kernel using Aspeed SDK drivers[3]). My test images are on Github[4

[RFC 1/1] i2c/aspeed: Add slave device handling in new register mode

2022-05-25 Thread Peter Delevoryas
Signed-off-by: Peter Delevoryas --- hw/i2c/aspeed_i2c.c | 118 ++-- include/hw/i2c/aspeed_i2c.h | 14 +++-- 2 files changed, 124 insertions(+), 8 deletions(-) diff --git a/hw/i2c/aspeed_i2c.c b/hw/i2c/aspeed_i2c.c index 3f2dbe46df..01af647e0c 100644 --- a

Re: [PATCH 0/3] recover hardware corrupted page by virtio balloon

2022-05-25 Thread Jue Wang
Some points to consider: The injected MCE has _done_ the damages to guest workload. Recovering the guest poisoned memory doesn't help with the already happened guest workload memory corruption / loss / interruption due to injected MCEs. The hypervisor _must_ emulate poisons identified in guest ph

Re: [PATCH v9 08/12] target/hexagon: import flex/bison to docker files

2022-05-25 Thread Richard Henderson
On 5/25/22 13:27, Anton Johansson wrote: On 5/25/22 22:16, Richard Henderson wrote: No: * one patch to update libvirt-ci and does nothing else. * one patch to update yml template. * one patch to refresh. Just like you enumerated before. r~ Ah, right! Thanks for clarifying. Should I keep

Re: [PATCH v4 09/17] target/m68k: Fix stack frame for EXCP_ILLEGAL

2022-05-25 Thread Laurent Vivier
Le 30/04/2022 à 19:53, Richard Henderson a écrit : According to the M68040 Users Manual, section 8.4.3, Four word This is in section 8.4.1 Reviewed-by: Laurent Vivier stack frame (format 0), includes Illegal Instruction. Use the correct frame format, which does not use the ADDR argument.

Re: [PATCH 0/2] i386: fixup number of logical CPUs when host-cache-info=on

2022-05-25 Thread Alejandro Jimenez
On 5/25/2022 3:56 PM, Moger, Babu wrote: On 5/24/22 18:23, Alejandro Jimenez wrote: On 5/24/2022 3:48 PM, Moger, Babu wrote: On 5/24/22 10:19, Igor Mammedov wrote: On Tue, 24 May 2022 11:10:18 -0400 Igor Mammedov wrote: CCing AMD folks as that might be of interest to them I am trying

Re: [PATCH v4 10/17] target/m68k: Implement TRAPcc

2022-05-25 Thread Laurent Vivier
Le 30/04/2022 à 19:53, Richard Henderson a écrit : Resolves: https://gitlab.com/qemu-project/qemu/-/issues/754 Signed-off-by: Richard Henderson --- target/m68k/cpu.h | 2 ++ linux-user/m68k/cpu_loop.c | 1 + target/m68k/cpu.c | 1 + target/m68k/op_helper.c| 6 +

Re: [PATCH v4 11/17] target/m68k: Implement TPF in terms of TRAPcc

2022-05-25 Thread Laurent Vivier
Le 30/04/2022 à 19:53, Richard Henderson a écrit : TPF stands for "trap false", and is a long-form nop for ColdFire. Re-use the immediate consumption code from trapcc; the insn will already expand to a nop because of the TCG_COND_NEVER test within do_trapcc. Signed-off-by: Richard Henderson ---

Re: [PATCH v4 12/17] target/m68k: Implement TRAPV

2022-05-25 Thread Laurent Vivier
Le 30/04/2022 à 19:53, Richard Henderson a écrit : Signed-off-by: Richard Henderson --- target/m68k/translate.c | 9 + 1 file changed, 9 insertions(+) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index bb5ed1b7b1..0cd7ef89e3 100644 --- a/target/m68k/translate.c +++

Re: [PATCH v4 13/17] target/m68k: Implement FTRAPcc

2022-05-25 Thread Laurent Vivier
Le 30/04/2022 à 19:53, Richard Henderson a écrit : Signed-off-by: Richard Henderson --- target/m68k/translate.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index 0cd7ef89e3..a3141d7f77 100644 --- a/targe

Re: [PATCH v4 14/17] tests/tcg/m68k: Add trap.c

2022-05-25 Thread Laurent Vivier
Le 30/04/2022 à 19:53, Richard Henderson a écrit : Test various trap instructions: chk, div, trap, trapv, trapcc, ftrapcc, and the signals and addresses that we expect from them. Signed-off-by: Richard Henderson --- tests/tcg/m68k/trap.c | 129 + test

Re: [PATCH v4 17/17] target/m68k: Mark helper_raise_exception as noreturn

2022-05-25 Thread Laurent Vivier
Le 30/04/2022 à 19:53, Richard Henderson a écrit : Also mark raise_exception_ra and raise_exception, lest we generate a warning about helper_raise_exception returning. Signed-off-by: Richard Henderson --- target/m68k/helper.h| 2 +- target/m68k/op_helper.c | 5 +++-- 2 files changed, 4

Re: [PATCH v4 08/17] target/m68k: Fix address argument for EXCP_TRACE

2022-05-25 Thread Laurent Vivier
Le 30/04/2022 à 19:53, Richard Henderson a écrit : According to the M68040 Users Manual, section 8.4.3, Six word stack frame (format 2), Trace (and others) is supposed to record the next insn in PC and the address of the trapping instruction in ADDRESS. Create gen_raise_exception_format2 to reco

Re: [PATCH v2 01/11] scsi-disk: add FORMAT UNIT command

2022-05-25 Thread Laurent Vivier
Le 24/04/2022 à 18:49, Mark Cave-Ayland a écrit : When initialising a drive ready to install MacOS, Apple HD SC Setup first attempts to format the drive. Add a simple FORMAT UNIT command which simply returns success to allow the format to succeed. Signed-off-by: Mark Cave-Ayland --- hw/scsi

Re: [PULL 00/17] Misc patches for 2022-05-25

2022-05-25 Thread Richard Henderson
On 5/25/22 12:28, Paolo Bonzini wrote: The following changes since commit 3757b0d08b399c609954cf57f273b1167e5d7a8d: Merge tag 'pull-request-2022-05-18' of https://gitlab.com/thuth/qemu into staging (2022-05-20 08:04:30 -0700) are available in the Git repository at: https://gitlab.com/bo

Re: [PATCH v4 10/17] target/m68k: Implement TRAPcc

2022-05-25 Thread Richard Henderson
On 5/25/22 14:40, Laurent Vivier wrote: +DISAS_INSN(trapcc) +{ +    DisasCompare c; + +    /* Consume and discard the immediate operand. */ +    switch (extract32(insn, 0, 3)) { +    case 2: /* trapcc.w */ +    (void)read_im16(env, s); +    break; +    case 3: /* trapcc.l */ +    (voi

Re: [PATCH v2 15/15] tests/qtest: enable tests for virtio-gpio

2022-05-25 Thread Alex Bennée
Stefan Hajnoczi writes: > [[PGP Signed Part:Undecided]] > On Tue, May 24, 2022 at 04:40:56PM +0100, Alex Bennée wrote: >> We don't have a virtio-gpio implementation in QEMU and only >> support a vhost-user backend. The QEMU side of the code is minimal so >> it should be enough to instantiate th

[PATCH 1/9] python: update for mypy 0.950

2022-05-25 Thread John Snow
typeshed (included in mypy) recently updated to improve the typing for WriteTransport objects. I was working around this, but now there's a version where I shouldn't work around it. Unfortunately this creates some minor ugliness if I want to support both pre- and post-0.950 versions. For now, for

[PATCH 0/9] tests, python: prepare to expand usage of test venv

2022-05-25 Thread John Snow
GitLab CI: https://gitlab.com/jsnow/qemu/-/pipelines/548326343 This series collects some of the uncontroversial elements that serve as pre-requisites for a later series that seeks to generate a testing venv by default. This series makes the following material changes: - Install the 'qemu' packag

[PATCH 5/9] tests: add quiet-venv-pip macro

2022-05-25 Thread John Snow
Factor out the "test venv pip" macro; rewrite the "check-venv" rule to be a little more compact. Replace the "PIP" pseudo-command output with "VENVPIP" to make it 1% more clear that we are talking about using pip to install something into a venv. Signed-off-by: John Snow --- tests/Makefile.inclu

[PATCH 2/9] tests: add "TESTS_PYTHON" variable to Makefile

2022-05-25 Thread John Snow
This is a convenience feature: $(PYTHON) points to the Python executable we were instructed to use by the configure script. We use that Python to create a virtual environment with the "check-venv" target in tests/Makefile.include. $(TESTS_PYTHON) points to the Python executable belonging to the vi

[PATCH 7/9] tests: use tests/venv to run basevm.py-based scripts

2022-05-25 Thread John Snow
This patch co-opts the virtual environment being used by avocado tests to also run the basevm.py tests. This is being done in preparation for for the qemu.qmp package being removed from qemu.git. As part of the change, remove any sys.path() hacks and treat "qemu" as a normal third-party import. S

[PATCH 4/9] tests: silence pip upgrade warnings during venv creation

2022-05-25 Thread John Snow
Turn off the nag warning coaxing us to upgrade pip. It's not really that interesting to see in CI logs, and as long as nothing is broken -- nothing is broken. Signed-off-by: John Snow --- tests/Makefile.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefil

[PATCH 3/9] tests: use python3 as the python executable name

2022-05-25 Thread John Snow
Use "python3" instead of "python" as per PEP0394: https://peps.python.org/pep-0394/ This should always be defined (in a venv, at least!), matching the preferred python shebang of "#!/usr/bin/env python3". Signed-off-by: John Snow --- tests/Makefile.include | 2 +- 1 file changed, 1 insertion(+)

[PATCH 6/9] tests: install "qemu" namespace package into venv

2022-05-25 Thread John Snow
This patch adds the "qemu" namespace package to the $build/tests/venv directory. It does so in "editable" mode, which means that changes to the source python directory will actively be reflected by the venv. This patch also then removes any sys.path hacking from the avocado test scripts directly.

[PATCH 9/9] tests: run 'device-crash-test' from tests/venv

2022-05-25 Thread John Snow
Remove the sys.path hacking from device-crash-test, and add in a little user-friendly message for anyone who was used to running this script directly from the source tree. Modify the GitLab job recipes to create the tests/venv first, then run device-crash-test from that venv. Signed-off-by: John

[PATCH 8/9] tests: add python3-venv to debian10.docker

2022-05-25 Thread John Snow
This is needed to be able to add a venv-building step to 'make check'; the clang-user job in particular needs this to be able to run check-unit. Signed-off-by: John Snow --- tests/docker/dockerfiles/debian10.docker | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/docker/dockerfiles/debi

Re: [PATCH v4 10/17] target/m68k: Implement TRAPcc

2022-05-25 Thread Laurent Vivier
Le 26/05/2022 à 00:26, Richard Henderson a écrit : On 5/25/22 14:40, Laurent Vivier wrote: +DISAS_INSN(trapcc) +{ +    DisasCompare c; + +    /* Consume and discard the immediate operand. */ +    switch (extract32(insn, 0, 3)) { +    case 2: /* trapcc.w */ +    (void)read_im16(env, s); +

[PATCH] iotests: fix source directory location

2022-05-25 Thread John Snow
If you invoke the check script from outside of the tests/qemu-iotests directory, the directories initialized as source_iotests and build_iotests will be incorrect. We can use the location of the source file itself to be more accurate. Signed-off-by: John Snow Reviewed-by: Paolo Bonzini --- tes

Re: [PATCH v4 1/3] hw/intc: Move mtimer/mtimecmp to aclint

2022-05-25 Thread Alistair Francis
On Sat, May 14, 2022 at 4:37 AM Atish Patra wrote: > > Historically, The mtime/mtimecmp has been part of the CPU because > they are per hart entities. However, they actually belong to aclint > which is a MMIO device. > > Move them to the ACLINT device. This also emulates the real hardware > more c

[PATCH 0/1] hw: m25p80: add W# pin and SRWD bit for write protection

2022-05-25 Thread Iris Chen
From: Iris Chen Hey everyone, My patch adds the W# pin and SRWD bit which work together to control the status register write ability. Accordingly, when W# is low and SRWD bit is high, hardware protection mode (HPM) is initiated. All other cases result in software protection. Acceptance test

[PATCH 1/1] hw: m25p80: add W# pin and SRWD bit for write protection

2022-05-25 Thread Iris Chen
From: Iris Chen Add the W# pin and SRWD bit which control the status register write ability. Signed-off-by: Iris Chen --- hw/block/m25p80.c | 72 +++ tests/qtest/aspeed_smc-test.c | 62 ++ 2 files changed, 134 insertions(+

Re: [PATCH v4 3/3] i386: Add notify VM exit support

2022-05-25 Thread Chenyi Qiang
On 5/25/2022 11:43 AM, Yuan Yao wrote: On Tue, May 24, 2022 at 10:03:02PM +0800, Chenyi Qiang wrote: There are cases that malicious virtual machine can cause CPU stuck (due to event windows don't open up), e.g., infinite loop in microcode when nested #AC (CVE-2015-5307). No event window means

Re: [RFC PATCH v4 16/36] i386/tdvf: Introduce function to parse TDVF metadata

2022-05-25 Thread Xiaoyao Li
On 5/24/2022 3:02 PM, Gerd Hoffmann wrote: Hi, +static int tdvf_parse_section_entry(const TdvfSectionEntry *src, + TdxFirmwareEntry *entry) +/* sanity check */ That is what the whole function is doing. So rename it to tdvf_check_section_entry to

Re: [PATCH v17 6/8] softmmu/dirtylimit: Implement virtual CPU throttle

2022-05-25 Thread Jason Wang
On Wed, May 25, 2022 at 11:56 PM Peter Xu wrote: > > On Wed, May 25, 2022 at 11:38:26PM +0800, Hyman Huang wrote: > > > 2. Also this algorithm only control or limits dirty rate by guest > > > writes. There can be some memory dirtying done by virtio based devices > > > which is accounted only at qe

Re: [RFC PATCH v4 18/36] i386/tdx: Skip BIOS shadowing setup

2022-05-25 Thread Xiaoyao Li
On 5/24/2022 3:08 PM, Gerd Hoffmann wrote: On Thu, May 12, 2022 at 11:17:45AM +0800, Xiaoyao Li wrote: TDX guest cannot go to real mode, so just skip the setup of isa-bios. Does isa-bios setup cause any actual problems? (same question for patch #19). It causes mem_region split and mem_slot d

Re: [RFC PATCH v4 20/36] i386/tdx: Register a machine_init_done callback for TD

2022-05-25 Thread Xiaoyao Li
On 5/24/2022 3:09 PM, Gerd Hoffmann wrote: On Thu, May 12, 2022 at 11:17:47AM +0800, Xiaoyao Li wrote: Before a TD can run, it needs to - setup/configure TD HOB list; - initialize TDVF into TD's private memory; - initialize TD vcpu state; Register a machine_init_done callback to all those

Re: [RFC PATCH v4 13/36] i386/tdx: Validate TD attributes

2022-05-25 Thread Xiaoyao Li
On 5/24/2022 4:29 PM, Gerd Hoffmann wrote: On Tue, May 24, 2022 at 04:11:56PM +0800, Xiaoyao Li wrote: On 5/24/2022 2:59 PM, Gerd Hoffmann wrote: On Tue, May 24, 2022 at 12:19:51PM +0800, Xiaoyao Li wrote: On 5/23/2022 5:39 PM, Gerd Hoffmann wrote: So, how is this supposed to work? Patch #2

[PATCH] virtio/vhost-user: Fix wrong vhost notifier GPtrArray size

2022-05-25 Thread Yajun Wu
In fetch_or_create_notifier, idx begins with 0. So the GPtrArray size should be idx + 1 and g_ptr_array_set_size should be called with idx + 1. This wrong GPtrArray size causes fetch_or_create_notifier return an invalid address. Passing this invalid pointer to vhost_user_host_notifier_remove cause

Re: [PATCH v4 2/3] target/riscv: Add stimecmp support

2022-05-25 Thread Alistair Francis
On Sat, May 14, 2022 at 4:39 AM Atish Patra wrote: > > stimecmp allows the supervisor mode to update stimecmp CSR directly > to program the next timer interrupt. This CSR is part of the Sstc > extension which was ratified recently. > > Signed-off-by: Atish Patra > --- > target/riscv/cpu.c

<    1   2   3