Re: [PATCH v2 07/74] semihosting: Split out guestfd.c

On Tue, 3 May 2022 at 21:02, Richard Henderson wrote: > > In arm-compat-semi.c, we have more advanced treatment of > guest file descriptors than we do in other implementations. > Split out GuestFD and related functions to a new file so > that they can be shared. > > Signed-off-by: Richard Henderso

Re: [PATCH v6 resend 3/4] vdpa: add vdpa-dev support

On Sat, May 14, 2022 at 12:11:06PM +0800, Longpeng(Mike) wrote: From: Longpeng Supports vdpa-dev, we can use the deivce directly: -M microvm -m 512m -smp 2 -kernel ... -initrd ... -device \ vhost-vdpa-device,vhostdev=/dev/vhost-vdpa-x Signed-off-by: Longpeng --- hw/virtio/Kconfig

[PATCH 15/35] acpi: ich9-smb: add support for AcpiDevAmlIf interface

wire AcpiDevAmlIf interface to build ich9-smb and its slave devices AML. It will be used by followup patches to switch from creating AML in ad-hoc way to a more systematic one that will scan present devices and ask them to provide their AML code like it's done with ISA devices. This patch is a par

Re: Getting rid of the last bits of QEMU's 'ad-hoc CI' for merges

On 5/16/22 15:55, Peter Maydell wrote: On Mon, 16 May 2022 at 14:51, Cédric Le Goater wrote: On 5/16/22 14:43, Peter Maydell wrote: I think we can get away with just dropping ppc64be -- we have coverage for it as a cross-compile setup, and hopefully the s390x CI runner will catch the various

[PATCH 01/35] acpi: add interface to build device specific AML

There is already ISADeviceClass::build_aml() callback which builds device specific AML blob for some ISA devices. To extend the same idea to other devices, add TYPE_ACPI_DEV_AML_IF Interface that will provide a more generic callback which will be used not only for ISA but other devices. It will all

[PATCH 18/35] tests: acpi: white-list to be re-factored pc/q35 DSDT

Signed-off-by: Igor Mammedov --- tests/qtest/bios-tables-test-allowed-diff.h | 31 + 1 file changed, 31 insertions(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index dfb8523c8b..d95f4b25c4 100644 --- a/tests/qtest/

Re: Getting rid of the last bits of QEMU's 'ad-hoc CI' for merges

On Mon, May 16, 2022 at 03:35:25PM +0100, Peter Maydell wrote: > On Mon, 16 May 2022 at 15:30, Thomas Huth wrote: > > > > On 16/05/2022 14.43, Peter Maydell wrote: > > > For the BSDs, the ad-hoc CI is just running the tests/vm > > > "make vm-build-netbsd" etc. Is there some way we can get > > > co

Re: [PATCH v5 13/21] migration: Postcopy recover with preempt enabled

On 16/05/22 7:41 pm, Peter Xu wrote: Hi, Manish, On Mon, May 16, 2022 at 07:01:35PM +0530, manish.mishra wrote: On 26/04/22 5:08 am, Peter Xu wrote: LGTM, Peter, I wanted to give review-tag for this and ealier patch too. I am new to qemu review process so not sure how give review-tag, did not

[PATCH 00/35] pc/q35: refactor ISA and SMBUS AML generation

Series is excerpt form larger refactoring that does the same for PCI devices, but it's too large at this point, so I've split off a relatively self-contained ISA/SMBUS patches into a smaller separate series, and PCI refactoring will follow up on top of this series using the same AcpiDevAmlIf inte

[PATCH 02/35] acpi: make isa_build_aml() support AcpiDevAmlIf interface

To allow incremental conversion from ISADeviceClass::build_aml to AcpiDevAmlIf, add support for the later without removing the former. Once conversion is complete, another commit will drop ISADeviceClass::build_aml related code. Signed-off-by: Igor Mammedov --- hw/isa/isa-bus.c | 5 + 1 file

[PATCH 25/35] tests: acpi: update expected blobs

@@ -145,6 +145,23 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPC", 0x0001) { Name (_ADR, 0x001F) // _ADR: Address OperationRegion (PIRQ, PCI_Config, 0x60, 0x0C) +Device (SMC) +{ +Name (_HID, EisaId ("APP000

Re: [PATCH 2/2] hw: aspeed: Init all UART's with serial devices

On Fri, 13 May 2022 at 22:09, Peter Delevoryas wrote > I was actually intentionally skipping that. If serial_hd(i) > doesn’t exist, the function will return NULL. > > Chardev *serial_hd(int i) > { > assert(i >= 0); > if (i < num_serial_hds) { > return serial_hds[i]; > } >

[PATCH 04/35] acpi: parallel port: replace ISADeviceClass::build_aml with AcpiDevAmlIfClass:build_dev_aml

Signed-off-by: Igor Mammedov --- hw/char/parallel.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/hw/char/parallel.c b/hw/char/parallel.c index f735a6cd7f..1c9ca47820 100644 --- a/hw/char/parallel.c +++ b/hw/char/parallel.c @@ -28,7 +28,7 @@ #include "qemu/mo

[PATCH 03/35] acpi: fdc-isa: replace ISADeviceClass::build_aml with AcpiDevAmlIfClass:build_dev_aml

Signed-off-by: Igor Mammedov --- hw/block/fdc-isa.c | 16 ++-- hw/i386/acpi-build.c | 1 - 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/hw/block/fdc-isa.c b/hw/block/fdc-isa.c index fa20450747..fee1ca68a8 100644 --- a/hw/block/fdc-isa.c +++ b/hw/block/fdc-isa.c @

[PATCH 32/35] acpi: pc/q35: remove not needed 'if' condition on pci bus

Signed-off-by: Igor Mammedov --- hw/i386/acpi-build.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 85a7313cad..414b9240b2 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -1748,16 +1748,10 @@ build_

[PATCH 2/3] capstone: Allow version 3.0.5 again

According to https://lore.kernel.org/qemu-devel/20200921174118.39352-1-richard.hender...@linaro.org/ there was an issue with Capstone 3 from Ubuntu 18. Now that we removed support for Ubuntu 18.04, that issue should hopefully not bite us anymore. Compiling with version 3.0.5 seems to work fine

[PATCH 05/35] acpi: serial-is: replace ISADeviceClass::build_aml with AcpiDevAmlIfClass:build_dev_aml

Signed-off-by: Igor Mammedov --- hw/char/serial-isa.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/hw/char/serial-isa.c b/hw/char/serial-isa.c index 7a7ed239cd..141a6cb168 100644 --- a/hw/char/serial-isa.c +++ b/hw/char/serial-isa.c @@ -27,7 +27,7 @@ #includ

[PATCH 06/35] acpi: mc146818rtc: replace ISADeviceClass::build_aml with AcpiDevAmlIfClass:build_dev_aml

Signed-off-by: Igor Mammedov --- hw/rtc/mc146818rtc.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/hw/rtc/mc146818rtc.c b/hw/rtc/mc146818rtc.c index f235c2ddbe..ef9765bb8f 100644 --- a/hw/rtc/mc146818rtc.c +++ b/hw/rtc/mc146818rtc.c @@ -26,7 +26,7 @@ #includ

[PATCH 13/35] ipmi: acpi: use relative path to resource source

smbus-ipmi AML description needs to specify a path to its parent node in _CRS. The rest of IPMI inplementations (ISA based) do not need path at all. Instead of passing through a full path use relative path to point to smbus-ipmi's parent node, it will let follow up patches to create IPMI device AML

[PULL 12/17] QIOChannelSocket: Implement io_writev zero copy flag & io_flush for CONFIG_LINUX

From: Leonardo Bras For CONFIG_LINUX, implement the new zero copy flag and the optional callback io_flush on QIOChannelSocket, but enables it only when MSG_ZEROCOPY feature is available in the host kernel, which is checked on qio_channel_socket_connect_sync() qio_channel_socket_flush() was imple

[PATCH 08/35] isa-bus: drop no longer used ISADeviceClass::build_aml

Signed-off-by: Igor Mammedov --- include/hw/isa/isa.h | 1 - hw/isa/isa-bus.c | 12 +--- 2 files changed, 1 insertion(+), 12 deletions(-) diff --git a/include/hw/isa/isa.h b/include/hw/isa/isa.h index 034d706ba1..5c5a3d43a7 100644 --- a/include/hw/isa/isa.h +++ b/include/hw/isa/isa.

[PATCH 14/35] tests: acpi: update expected DSDT.ipmismbus blob

expected AML change: Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings { I2cSerialBusV2 (0x, ControllerInitiated, 0x000186A0, - AddressingMode7Bit, "\\_SB.PCI0.SMB0", + AddressingMode7Bit, "^", 0x00, Res

[PATCH 10/35] tests: acpi: q35: add test for smbus-ipmi device

expected new device node: Device (MI1) { Name (_HID, EisaId ("IPI0001")) // _HID: Hardware ID Name (_STR, "ipmi_smbus") // _STR: Description String Name (_UID, One) // _UID: Unique ID Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings

Re: [PATCH v2 08/74] semihosting: Generalize GuestFDFeatureFile

On Tue, 3 May 2022 at 21:08, Richard Henderson wrote: > > Rather than hard-coding the buffer from which we deliver data, > pass it in on initialization. This decouples the feature from > ARM semihosting. > > Signed-off-by: Richard Henderson > --- Reviewed-by: Peter Maydell thanks -- PMM

[PATCH 12/35] tests: acpi: whitelist DSDT.ipmismbus expected blob

Signed-off-by: Igor Mammedov --- tests/qtest/bios-tables-test-allowed-diff.h | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index dfb8523c8b..b4687d1cc8 100644 --- a/tests/qtest/bios-tables-test-allowe

Re: [PATCH] ptimer: Rename PTIMER_POLICY_DEFAULT to PTIMER_POLICY_LEGACY

On 5/16/22 03:30, Peter Maydell wrote: The traditional ptimer behaviour includes a collection of weird edge case behaviours. In 2016 we improved the ptimer implementation to fix these and generally make the behaviour more flexible, with ptimers opting in to the new behaviour by passing an approp

[PATCH 23/35] tests: acpi: add applesmc testcase

Signed-off-by: Igor Mammedov --- tests/qtest/bios-tables-test.c | 12 1 file changed, 12 insertions(+) diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c index 615cbdaf17..b7be634d23 100644 --- a/tests/qtest/bios-tables-test.c +++ b/tests/qtest/bios-tables-

Re: [PATCH v5 15/21] migration: Parameter x-postcopy-preempt-break-huge

On 26/04/22 5:08 am, Peter Xu wrote: Add a parameter that can conditionally disable the "break sending huge page" behavior in postcopy preemption. By default it's enabled. It should only be used for debugging purposes, and we should never remove the "x-" prefix. Signed-off-by: Peter Xu Revie

[PATCH v2 4/7] artist: Fix vertical X11 cursor position in HP-UX

Drop the hard-coded value of 1146 lines which seems to work with HP-UX 11, but not with HP-UX 10. Instead encode the screen height in byte 0 of active_lines_low and byte 3 of misc_video as it's expected by the Xorg X11 graphics driver. This potentially allows for higher vertical screen resolutions

[PATCH 20/35] acpi: q35: isa bridge: use AcpiDevAmlIf interface to build ISA device descriptors

replaces adhoc build_isa_devices_aml() with generic AcpiDevAmlIf way to build bridge AML including all devices that are attached to its ISA bus. Later when PCI is converted to AcpiDevAmlIf, build_q35_isa_bridge() will also be dropped since PCI parts itself will take care of building device prologu

[PULL 05/23] qdev-properties: Add a new macro with bitmask check for uint64_t property

From: Yang Weijiang The DEFINE_PROP_UINT64_CHECKMASK maro applies certain mask check agaist user-supplied property value, reject the value if it violates the bitmask. Co-developed-by: Like Xu Signed-off-by: Like Xu Signed-off-by: Yang Weijiang Message-Id: <20220215195258.29149-2-weijiang.y...

[PATCH v2 5/7] artist: Allow to turn cursor on or off

Bit 0x80 in the cursor_cntrl register specifies if the cursor should be visible. Prevent rendering the cursor if it's invisible. Signed-off-by: Helge Deller Acked-by: Mark Cave-Ayland --- hw/display/artist.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/hw/display/artist.c

[PATCH 21/35] tests: acpi: update expected blobs

Expected AML change: ISA devices under separate _SB.PCI0.ISA scope are moved directly under Device(ISA) node. Example from PC machine, and q35 have similar changes: { Name (_ADR, 0x0001) // _ADR: Address OperationRegion (P40C, PCI_Config, 0x60, 0x04) -

Re: [PATCH v5 00/21] migration: Postcopy Preemption

On 26/04/22 5:08 am, Peter Xu wrote: This is v5 of postcopy preempt series. It can also be found here: https://github.com/xzpeter/qemu/tree/postcopy-preempt RFC: https://lore.kernel.org/qemu-devel/20220119080929.39485-1-pet...@redhat.com V1: https://lore.kernel.org/qemu-devel/20220216062

[PULL 06/23] target/i386: Add lbr-fmt vPMU option to support guest LBR

From: Yang Weijiang The Last Branch Recording (LBR) is a performance monitor unit (PMU) feature on Intel processors which records a running trace of the most recent branches taken by the processor in the LBR stack. This option indicates the LBR format to enable for guest perf. The LBR feature is

[PATCH 24/35] acpi: applesmc: use AcpiDevAmlIfClass:build_dev_aml to provide device's AML

.. and clean up not longer needed conditionals in DSTD build code. applesmc AML will be fetched and included when ISA bridge will build its own AML code (incl. attached devices). Expected AML change: the device under separate _SB.PCI0.ISA scope is moved directly under Device(ISA) node. Signed-o

[PATCH 27/35] tests: acpi: add pvpanic-isa: testcase

Signed-off-by: Igor Mammedov --- tests/qtest/bios-tables-test.c | 12 1 file changed, 12 insertions(+) diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c index b7be634d23..ecbb4dab5a 100644 --- a/tests/qtest/bios-tables-test.c +++ b/tests/qtest/bios-tables-

[PATCH 07/35] acpi: pckbd: replace ISADeviceClass::build_aml with AcpiDevAmlIfClass:build_dev_aml

Signed-off-by: Igor Mammedov --- hw/input/pckbd.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/hw/input/pckbd.c b/hw/input/pckbd.c index 4efdf75620..45c40fe3f3 100644 --- a/hw/input/pckbd.c +++ b/hw/input/pckbd.c @@ -29,7 +29,7 @@ #include "qapi/error.h" #i

[PATCH 31/35] acpi: pc/q35: tpm-tis: fix TPM device scope

tpm-tis, is not a PCI device but ISA one, move it under ISA scope to fix incorrect placement. Fixes: 24cf5413aa0 (acpi: Make TPM 2.0 with TIS available as MSFT0101) Signed-off-by: Igor Mammedov --- hw/i386/acpi-build.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/i386

[PULL 15/23] rng: make opened property read-only

The ``opened=on`` option in the command line or QMP ``object-add`` either had no effect (if ``opened`` was the last option) or caused errors. The property is therefore useless and was deprecated in 6.0; make it read-only now. Signed-off-by: Paolo Bonzini --- backends/rng.c | 18

[PATCH 29/35] tests: acpi: update expected DSDT.pvpanic-isa blob

@@ -145,6 +145,37 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPC", 0x0001) { Name (_ADR, 0x001F) // _ADR: Address OperationRegion (PIRQ, PCI_Config, 0x60, 0x0C) +Device (PEVT) +{ +Name (_HID, "QEMU0001") /

[PULL 17/23] soundhw: extract soundhw help to a separate function

Signed-off-by: Paolo Bonzini --- hw/audio/soundhw.c | 33 +++-- include/hw/audio/soundhw.h | 1 + 2 files changed, 20 insertions(+), 14 deletions(-) diff --git a/hw/audio/soundhw.c b/hw/audio/soundhw.c index 097501fee1..0fb64bdc8f 100644 --- a/hw/audio/soundh

[PATCH 11/35] tests: acpi: update expected blob DSDT.ipmismbus

basic q35 DSDT with an extra device node: Device (MI1) { Name (_HID, EisaId ("IPI0001")) // _HID: Hardware ID Name (_STR, "ipmi_smbus") // _STR: Description String Name (_UID, One) // _UID: Unique ID Name (_CRS, ResourceTemplate () // _CRS: Current Resourc

[PATCH 33/35] acpi: tpm-tis: use AcpiDevAmlIfClass:build_dev_aml to provide device's AML

.. and clean up not longer needed conditionals in DSTD build code tpm-tis AML will be fetched and included when ISA bridge will build its own AML code (including attached devices). Expected AML change: the device under separate _SB.PCI0.ISA scope is moved directly under Device(ISA) node.

[PATCH 30/35] tests: acpi: white-list DSDT.tis.tpm2/DSDT.tis.tpm12 expected blobs

Signed-off-by: Igor Mammedov --- tests/qtest/bios-tables-test-allowed-diff.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index dfb8523c8b..7b3bf9a207 100644 --- a/tests/qtest/bios-tables-test-allo

[PATCH 16/35] acpi: ipmi: use AcpiDevAmlIf interface to build IPMI device descriptors

convert ad-hoc way we use to generate AML for ISA/SMB IPMI devices to a generic approach (i.e. make devices provide its own AML blobs like it is done with other ISA devices (ex. KBD)) Signed-off-by: Igor Mammedov --- include/hw/acpi/ipmi.h | 9 ++-- hw/acpi/ipmi-stub.c| 2 +- hw/acpi/i

[PATCH 35/35] x86: acpi-build: do not include hw/isa/isa.h directly

the last remaining dependency on ISA in acpi-build.c is iapc_boot_arch_8042() which pulls in in isa.h in its own header hw/input/i8042.h. Clean up not longer needed direct inclusion of isa.h in acpi-build.c Signed-off-by: Igor Mammedov --- hw/i386/acpi-build.c | 1 - 1 file changed, 1 deletion(-

[PULL 22/23] configure: remove another dead variable

Signed-off-by: Paolo Bonzini --- configure | 1 - 1 file changed, 1 deletion(-) diff --git a/configure b/configure index c8b5b99532..dda25f05bf 100755 --- a/configure +++ b/configure @@ -1992,7 +1992,6 @@ fi if test "$static" = "yes" ; then echo "CONFIG_STATIC=y" >> $config_host_mak fi -qem

Re: [PULL 00/16] migration queue

On Mon, May 16, 2022 at 11:09:23AM +0100, Daniel P. Berrangé wrote: > On Mon, May 16, 2022 at 10:40:15AM +0100, Daniel P. Berrangé wrote: > > On Mon, May 16, 2022 at 09:51:12AM +0100, Stefan Hajnoczi wrote: > > > On Wed, May 11, 2022 at 12:40:07AM -0300, Leonardo Bras Soares Passos > > > wrote: >

[PATCH 19/35] acpi: pc: isa bridge: use AcpiDevAmlIf interface to build ISA device descriptors

replaces ad-hoc build_isa_devices_aml() with generic AcpiDevAmlIf way to build bridge AML including all devices that are attached to its ISA bus. Later when PCI is converted to AcpiDevAmlIf, build_piix4_isa_bridge() will also be dropped since PCI parts itself will take care of building device prol

Re: [PATCH] vhost-user-scsi: avoid unlink(NULL) with fd passing

On Thu, May 12, 2022 at 04:57:13PM +0100, Peter Maydell wrote: > On Wed, 27 Apr 2022 at 11:04, Stefan Hajnoczi wrote: > > > > Commit 747421e949fc1eb3ba66b5fcccdb7ba051918241 ("Implements Backend > > Program conventions for vhost-user-scsi") introduced fd-passing support > > as part of implementing

[PULL 05/17] tests: convert XBZRLE migration test to use common helper

From: Daniel P. Berrangé Most of the XBZRLE migration test logic is common with the rest of the precopy tests, so it can use the helper with just one small tweak. Reviewed-by: Peter Xu Signed-off-by: Daniel P. Berrangé Message-Id: <20220426160048.812266-6-berra...@redhat.com> Signed-off-by: Dr

Re: [PATCH v2 09/74] semihosting: Return void from do_common_semihosting

On Tue, 3 May 2022 at 20:58, Richard Henderson wrote: > > Perform the cleanup in the FIXME comment in common_semi_gdb_syscall. > Do not modify guest registers until the syscall is complete, > which in the gdbstub case is asynchronous. > > In the synchronous non-gdbstub case, use common_semi_set_re

[PATCH 17/35] q35: acpi: drop not needed PCMachineClass::do_not_add_smb_acpi

by default we do not version ACPI AML as it's considered a part of firmware. Drop do_not_add_smb_acpi that blocked SMBUS AML description on 3.1 and older machine types without providing justification. Signed-off-by: Igor Mammedov --- we can keep this bit if anyone can prove/report adverse effect

[PULL 04/17] tests: add migration tests of TLS with x509 credentials

From: Daniel P. Berrangé This validates that we correctly handle migration success and failure scenarios when using TLS with x509 certificates. There are quite a few different scenarios that matter in relation to hostname validation. Signed-off-by: Daniel P. Berrangé Message-Id: <20220426160048

Re: [PATCH v5 13/21] migration: Postcopy recover with preempt enabled

On Mon, May 16, 2022 at 08:21:23PM +0530, manish.mishra wrote: > > On 16/05/22 7:41 pm, Peter Xu wrote: > > Hi, Manish, > > > > On Mon, May 16, 2022 at 07:01:35PM +0530, manish.mishra wrote: > > > On 26/04/22 5:08 am, Peter Xu wrote: > > > LGTM, > > > Peter, I wanted to give review-tag for this a

[PATCH 09/35] tests: acpi: add and whitelist DSDT.ipmismbus expected blob

.. which will be used by follow up smbus-ipmi test-case Signed-off-by: Igor Mammedov --- tests/qtest/bios-tables-test-allowed-diff.h | 1 + tests/data/acpi/q35/DSDT.ipmismbus | 0 2 files changed, 1 insertion(+) create mode 100644 tests/data/acpi/q35/DSDT.ipmismbus diff --git a/tests/

[PULL 00/17] migration queue

From: "Dr. David Alan Gilbert" The following changes since commit 10c2a0c5e7d48e590d945c017b5b8af5b4c89a3c: Merge tag 'or1k-pull-request-20220515' of https://github.com/stffrdhrn/qemu into staging (2022-05-15 16:56:27 -0700) are available in the Git repository at: https://gitlab.com/dagrh

[PULL 15/17] multifd: multifd_send_sync_main now returns negative on error

From: Leonardo Bras Even though multifd_send_sync_main() currently emits error_reports, it's callers don't really check it before continuing. Change multifd_send_sync_main() to return -1 on error and 0 on success. Also change all it's callers to make use of this change and possibly fail earlier.

Re: [PATCH v2 0/5] hw: aspeed: Init all UART's with serial devices

> On May 16, 2022, at 12:18 AM, Cédric Le Goater wrote: > > On 5/16/22 08:23, Peter Delevoryas wrote: >> v2: >> - Rebased on Cedric's irq proposal. [1] >> - Added "Introduce common UART init function" patch >> - Added "Add uarts_num SoC attribute" patch >> - Rewrote last commit's message for cl

[PULL 01/17] tests: fix encoding of IP addresses in x509 certs

From: Daniel P. Berrangé We need to encode just the address bytes, not the whole struct sockaddr data. Add a test case to validate that we're matching on SAN IP addresses correctly. Signed-off-by: Daniel P. Berrangé Message-Id: <20220426160048.812266-2-berra...@redhat.com> Reviewed-by: Dr. Davi

[PATCH 22/35] tests: acpi: add and white-list DSDT.applesmc expected blob

Signed-off-by: Igor Mammedov --- tests/qtest/bios-tables-test-allowed-diff.h | 1 + tests/data/acpi/q35/DSDT.applesmc | 0 2 files changed, 1 insertion(+) create mode 100644 tests/data/acpi/q35/DSDT.applesmc diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-

Re: [PATCH 2/3] capstone: Allow version 3.0.5 again

On Mon, 16 May 2022 at 16:43, Thomas Huth wrote: > > According to > > > https://lore.kernel.org/qemu-devel/20200921174118.39352-1-richard.hender...@linaro.org/ > > there was an issue with Capstone 3 from Ubuntu 18. Now that we removed > support for Ubuntu 18.04, that issue should hopefully not b

[PATCH 26/35] tests: acpi: white-lists expected DSDT.pvpanic-isa blob

Signed-off-by: Igor Mammedov --- tests/qtest/bios-tables-test-allowed-diff.h | 1 + tests/data/acpi/q35/DSDT.pvpanic-isa| 0 2 files changed, 1 insertion(+) create mode 100644 tests/data/acpi/q35/DSDT.pvpanic-isa diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bi

[PULL 02/17] tests: add more helper macros for creating TLS x509 certs

From: Daniel P. Berrangé These macros are more suited to the general consumers of certs in the test suite, where we don't need to exercise every single possible permutation. Signed-off-by: Daniel P. Berrangé Message-Id: <20220426160048.812266-3-berra...@redhat.com> Reviewed-by: Eric Blake Sign

[PULL 00/23] Misc QEMU patches for 2022-05-16

The following changes since commit 48de9b0916ef60d5a6bd6ca9288832deff8ee1ee: Merge tag 'linux-headers-v5.18-rc6' of https://gitlab.com/alex.williamson/qemu into staging (2022-05-13 09:45:17 -0700) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream

[PATCH 28/35] acpi: pvpanic-isa: use AcpiDevAmlIfClass:build_dev_aml to provide device's AML

.. and clean up not longer needed conditionals in DSTD build code pvpanic-isa AML will be fetched and included when ISA bridge will build its own AML code (including attached devices). Expected AML change: the device under separate _SB.PCI0.ISA scope is moved directly under Device(ISA) node.

Re: [PATCH v2] vhost-user-scsi: avoid unlink(NULL) with fd passing

On Mon, 16 May 2022 at 16:57, Stefan Hajnoczi wrote: > > Commit 747421e949fc1eb3ba66b5fcccdb7ba051918241 ("Implements Backend > Program conventions for vhost-user-scsi") introduced fd-passing support > as part of implementing the vhost-user backend program conventions. > > When fd passing is used

[PULL 01/23] WHPX: fixed TPR/CR8 translation issues affecting VM debugging

From: Ivan Shcherbakov This patch fixes the following error that would occur when trying to resume a WHPX-accelerated VM from a breakpoint: qemu: WHPX: Failed to set interrupt state registers, hr=c0350005 The error arises from an incorrect CR8 value being passed to WHvSetVirtualProcessorReg

[PULL 07/17] tests: add multifd migration tests of TLS with PSK credentials

From: Daniel P. Berrangé This validates that we correctly handle multifd migration success and failure scenarios when using TLS with pre shared keys. Signed-off-by: Daniel P. Berrangé Message-Id: <20220426160048.812266-8-berra...@redhat.com> Reviewed-by: Eric Blake Signed-off-by: Dr. David Ala

[PULL 09/17] tests: ensure migration status isn't reported as failed

From: Daniel P. Berrangé Various methods in the migration test call 'query_migrate' to fetch the current status and then access a particular field. Almost all of these cases expect the migration to be in a non-failed state. In the case of 'wait_for_migration_pass' in particular, if the status is

[PATCH 34/35] tests: acpi: update expected DSDT.tis.tpm2/DSDT.tis.tpm12 blobs

expected move of tmp-tis device description directly under Device(ISA) node. for tpm-tis 2.0: @@ -145,6 +145,189 @@ DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPC", 0x0001) { Name (_ADR, 0x001F) // _ADR: Address OperationRegion (PIRQ, PCI_

[PULL 08/23] target/i386: Enable support for XSAVES based features

From: Yang Weijiang There're some new features, including Arch LBR, depending on XSAVES/XRSTORS support, the new instructions will save/restore data based on feature bits enabled in XCR0 | XSS. This patch adds the basic support for related CPUID enumeration and meanwhile changes the name from FEA

Re: [PATCH v5 13/21] migration: Postcopy recover with preempt enabled

On 16/05/22 8:21 pm, manish.mishra wrote: On 16/05/22 7:41 pm, Peter Xu wrote: Hi, Manish, On Mon, May 16, 2022 at 07:01:35PM +0530, manish.mishra wrote: On 26/04/22 5:08 am, Peter Xu wrote: LGTM, Peter, I wanted to give review-tag for this and ealier patch too. I am new to qemu review proc

[PULL 13/23] target/i386: Support Arch LBR in CPUID enumeration

From: Yang Weijiang If CPUID.(EAX=07H, ECX=0):EDX[19] is set to 1, the processor supports Architectural LBRs. In this case, CPUID leaf 01CH indicates details of the Architectural LBRs capabilities. XSAVE support for Architectural LBRs is enumerated in CPUID.(EAX=0DH, ECX=0FH). Signed-off-by: Yan

[PULL 16/17] multifd: Send header packet without flags if zero-copy-send is enabled

From: Leonardo Bras Since d48c3a0445 ("multifd: Use a single writev on the send side"), sending the header packet and the memory pages happens in the same writev, which can potentially make the migration faster. Using channel-socket as example, this works well with the default copying mechanism

[PULL 03/17] tests: add migration tests of TLS with PSK credentials

From: Daniel P. Berrangé This validates that we correctly handle migration success and failure scenarios when using TLS with pre shared keys. Signed-off-by: Daniel P. Berrangé Message-Id: <20220426160048.812266-4-berra...@redhat.com> Reviewed-by: Eric Blake Signed-off-by: Dr. David Alan Gilber

[PULL 17/17] multifd: Implement zero copy write in multifd migration (multifd-zero-copy)

From: Leonardo Bras Implement zero copy send on nocomp_send_write(), by making use of QIOChannel writev + flags & flush interface. Change multifd_send_sync_main() so flush_zero_copy() can be called after each iteration in order to make sure all dirty pages are sent before a new iteration is star

[PULL 20/23] introduce -audio as a replacement for -soundhw

-audio is used like "-audio pa,model=sb16". It is almost as simple as -soundhw, but it reuses the -audiodev parsing machinery and attaches an audiodev to the newly-created device. The main 'feature' is that it knows about adding the codec device for model=intel-hda, and adding the audiodev to the

[PULL 06/17] tests: convert multifd migration tests to use common helper

From: Daniel P. Berrangé Most of the multifd migration test logic is common with the rest of the precopy tests, so it can use the helper without difficulty. The only exception of the multifd cancellation test which tries to run multiple migrations in a row. Reviewed-by: Peter Xu Signed-off-by:

[PULL 04/23] i386/cpu: Remove the deprecated cpu model 'Icelake-Client'

From: Robert Hoo Icelake, is the codename for Intel 3rd generation Xeon Scalable server processors. There isn't ever client variants. This "Icelake-Client" CPU model was added wrongly and imaginarily. It has been deprecated since v5.2, now it's time to remove it completely from code. Signed-off

Re: [PATCH 2/3] capstone: Allow version 3.0.5 again

On 5/16/22 08:46, Peter Maydell wrote: On Mon, 16 May 2022 at 16:43, Thomas Huth wrote: According to https://lore.kernel.org/qemu-devel/20200921174118.39352-1-richard.hender...@linaro.org/ there was an issue with Capstone 3 from Ubuntu 18. Now that we removed support for Ubuntu 18.04, tha

Re: Getting rid of the last bits of QEMU's 'ad-hoc CI' for merges

On Mon, May 16, 2022 at 04:50:29PM +0200, Cédric Le Goater wrote: > On 5/16/22 15:55, Peter Maydell wrote: > > On Mon, 16 May 2022 at 14:51, Cédric Le Goater wrote: > > > > > > On 5/16/22 14:43, Peter Maydell wrote: > > > > I think we can get away with just dropping ppc64be -- we have > > > > cov

Re: [PULL 00/11] QAPI patches patches for 2022-05-16

On 5/16/22 00:35, Markus Armbruster wrote: The following changes since commit 10c2a0c5e7d48e590d945c017b5b8af5b4c89a3c: Merge tag 'or1k-pull-request-20220515' of https://github.com/stffrdhrn/qemu into staging (2022-05-15 16:56:27 -0700) are available in the Git repository at: git://repo

[PULL 08/17] tests: add multifd migration tests of TLS with x509 credentials

From: Daniel P. Berrangé This validates that we correctly handle multifd migration success and failure scenarios when using TLS with x509 certificates. There are quite a few different scenarios that matter in relation to hostname validation, but we skip a couple as we can assume that the non-mult

[PULL 07/23] target/i386: Add kvm_get_one_msr helper

From: Yang Weijiang When try to get one msr from KVM, I found there's no such kind of existing interface while kvm_put_one_msr() is there. So here comes the patch. It'll remove redundant preparation code before finally call KVM_GET_MSRS IOCTL. No functional change intended. Signed-off-by: Yang

[PULL 10/17] meson.build: Fix docker-test-build@alpine when including linux/errqueue.h

From: Leonardo Bras A build error happens in alpine CI when linux/errqueue.h is included in io/channel-socket.c, due to redefining of 'struct __kernel_timespec': === ninja: job failed: [...] In file included from /usr/include/linux/errqueue.h:6, from ../io/channel-socket.c:29: /

[PULL 09/23] target/i386: Add XSAVES support for Arch LBR

From: Yang Weijiang Define Arch LBR bit in XSS and save/restore structure for XSAVE area size calculation. Signed-off-by: Yang Weijiang Message-Id: <20220215195258.29149-6-weijiang.y...@intel.com> Signed-off-by: Paolo Bonzini --- target/i386/cpu.c | 6 +- target/i386/cpu.h | 23 +

[PATCH 0/5] machine.py fix for ppc64 tests + avocado changes

Hello, This series fixes a problem I'm having when running avocado tests in an IBM Power9 ppc64 host, without firmware modifications that breaks the default machine options of a pseries guest running KVM, and with --disable-tcg. The problem is described in detail in patch 02. The proposed fix con

[PATCH 1/5] avocado/empty_cpu_model.py: use machine:none tag

Using tags=machine:none will do two things: it will avoid the need to passing '-machine none' via self.vm.add_args() and it will set the self.machine attribute of the parent QEMUSystemTest class (via its setUp() method). We'll be relying on self.machine being set apropriately for an upcoming fix.

[PULL 11/17] QIOChannel: Add flags on io_writev and introduce io_flush callback

From: Leonardo Bras Add flags to io_writev and introduce io_flush as optional callback to QIOChannelClass, allowing the implementation of zero copy writes by subclasses. How to use them: - Write data using qio_channel_writev*(...,QIO_CHANNEL_WRITE_FLAG_ZERO_COPY), - Wait write completion with qi

[PULL 12/23] target/i386: introduce helper to access supported CPUID

Signed-off-by: Paolo Bonzini --- target/i386/cpu.c | 41 + 1 file changed, 25 insertions(+), 16 deletions(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 1816c37852..dcc770ecea 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -4944,6 +

Re: [PATCH v5 14/21] migration: Create the postcopy preempt channel asynchronously

On Mon, May 16, 2022 at 08:32:01PM +0530, manish.mishra wrote: > Reviewed-by: Manish Mishra > > This also looks good to me, sorry if i mis-understood and this is not correct > way to add review tag. This is, and I'll collect it when I repost. :) Thanks, -- Peter Xu

[PATCH 5/5] avocado/virtio-gpu.py: use tags=machine:pc

Using tags=machine:pc will do two things: it will avoid the need to passing '-machine pc' via self.vm.add_args() and it will set the self.machine attribute of the parent QEMUSystemTest class (via its setUp() method). Signed-off-by: Daniel Henrique Barboza --- tests/avocado/virtio-gpu.py | 6

[PULL 13/17] migration: Add zero-copy-send parameter for QMP/HMP for Linux

From: Leonardo Bras Add property that allows zero-copy migration of memory pages on the sending side, and also includes a helper function migrate_use_zero_copy_send() to check if it's enabled. No code is introduced to actually do the migration, but it allow future implementations to enable/disab

[PULL 16/23] soundhw: remove ability to create multiple soundcards

The usefulness of enabling a dozen soundcards is dubious. Simplify the code by allowing a single instance of -soundhw, with no support for parsing either comma-separated values or 'soundhw all'. Signed-off-by: Paolo Bonzini --- hw/audio/soundhw.c | 88 +--

[PULL 18/23] soundhw: unify initialization for ISA and PCI soundhw

Use qdev_new instead of distinguishing isa_create_simple/pci_create_simple. Signed-off-by: Paolo Bonzini --- hw/audio/soundhw.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/hw/audio/soundhw.c b/hw/audio/soundhw.c index 0fb64bdc8f..a1558dab3a 100644

[PATCH 4/5] avocado/boot_linux.py: avocado tag fixes in BootLinuxAarch64

BootLinuxAarch64 is already setting machine:virt in the avocado tags, meaning that we don't need to add '-machine virt' via add_args(). It's also adding an extra '-machine gic-version=2' parameter via an avocado tag, which is not ideal because: - it prevents self.machine from QEMUSystemTest to be

[PULL 14/17] migration: Add migrate_use_tls() helper

From: Leonardo Bras A lot of places check parameters.tls_creds in order to evaluate if TLS is in use, and sometimes call migrate_get_current() just for that test. Add new helper function migrate_use_tls() in order to simplify testing for TLS usage. Signed-off-by: Leonardo Bras Reviewed-by: Jua

[PULL 19/23] soundhw: move help handling to vl.c

This will allow processing "-audio model=help" even if the backend part of the option is missing. Signed-off-by: Paolo Bonzini --- hw/audio/soundhw.c | 24 +--- softmmu/vl.c | 4 2 files changed, 13 insertions(+), 15 deletions(-) diff --git a/hw/audio/soundhw.c b

<    1   2   3   4   5   >