Re: [PATCH v2] hw: m25p80: allow write_enable latch get/set

2022-05-12 Thread Peter Delevoryas
> On May 11, 2022, at 10:25 PM, Cédric Le Goater wrote: > > Hello Iris, > > [ Fixing Thomas email ] > > On 5/12/22 02:54, Iris Chen via wrote: >> The write_enable latch property is not currently exposed. >> This commit makes it a modifiable property using get/set methods. >> Signed-off-by: Ir

[PATCH] hw/riscv: virt: Avoid double FDT platform node

2022-05-12 Thread Dylan Reid
When starting the virt machine with `-machine virt,aia=aplic-imsic`, both the imsic and aplic init code will add platform fdt nodes by calling `platform_bus_add_all_fdt_nodes`. This leads to an error at startup: ``` qemu_fdt_add_subnode: Failed to create subnode /platform@400: FDT_ERR_EXISTS ``

[PATCH 5/6] hw/virtio: Replace g_memdup() by g_memdup2()

2022-05-12 Thread Eugenio Pérez
From: Philippe Mathieu-Daudé Per https://discourse.gnome.org/t/port-your-module-from-g-memdup-to-g-memdup2-now/5538 The old API took the size of the memory to duplicate as a guint, whereas most memory functions take memory sizes as a gsize. This made it easy to accidentally pass a gsize t

Re: [PULL V3 08/15] vhost: Shadow virtqueue buffers forwarding

2022-05-12 Thread Eugenio Perez Martin
On Thu, May 12, 2022 at 5:48 PM Peter Maydell wrote: > > On Tue, 15 Mar 2022 at 06:14, Jason Wang wrote: > > > > From: Eugenio Pérez > > > > Initial version of shadow virtqueue that actually forward buffers. There > > is no iommu support at the moment, and that will be addressed in future > > pa

Re: [RFC PATCH v4 23/36] i386/tdx: Setup the TD HOB list

2022-05-12 Thread Isaku Yamahata
On Thu, May 12, 2022 at 11:17:50AM +0800, Xiaoyao Li wrote: > The TD HOB list is used to pass the information from VMM to TDVF. The TD > HOB must include PHIT HOB and Resource Descriptor HOB. More details can > be found in TDVF specification and PI specification. > > Build the TD HOB in TDX's ma

Re: [PATCH 2/9] vfio: Fix compilation errors caused by VFIO migration v1 deprecation

2022-05-12 Thread Jason Gunthorpe
On Thu, May 12, 2022 at 11:57:10AM -0600, Alex Williamson wrote: > > @@ -767,9 +767,10 @@ static void vfio_migration_state_notifier(Notifier > > *notifier, void *data) > > case MIGRATION_STATUS_CANCELLED: > > case MIGRATION_STATUS_FAILED: > > bytes_transferred = 0; > > -

Re: [PATCH v5 17/21] migration: Export tls-[creds|hostname|authz] params to cmdline too

2022-05-12 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > It's useful for specifying tls credentials all in the cmdline (along with > the -object tls-creds-*), especially for debugging purpose. > > The trick here is we must remember to not free these fields again in the > finalize() function of migration object, ot

Re: [PATCH v5 17/21] migration: Export tls-[creds|hostname|authz] params to cmdline too

2022-05-12 Thread Daniel P . Berrangé
On Thu, May 12, 2022 at 07:03:13PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > It's useful for specifying tls credentials all in the cmdline (along with > > the -object tls-creds-*), especially for debugging purpose. > > > > The trick here is we must remember t

Re: [RFC PATCH v4 14/36] i386/tdx: Implement user specified tsc frequency

2022-05-12 Thread Isaku Yamahata
On Thu, May 12, 2022 at 11:17:41AM +0800, Xiaoyao Li wrote: > Reuse "-cpu,tsc-frequency=" to get user wanted tsc frequency and pass it > to KVM_TDX_INIT_VM. > > Besides, sanity check the tsc frequency to be in the legal range and > legal granularity (required by TDX module). Just to make it sur

[RFC PATCH 2/2] target/ppc: Rely on do_float_check_status for VSX_MADD invalid excepts

2022-05-12 Thread Víctor Colombo
Make necessary changes for Multiply-Add instructions to use the proposed reworked exceptions handling in do_float_check_status. This should allow for cleaner code, not requiring the helper to check multiple exceptions in its body. Signed-off-by: Víctor Colombo --- target/ppc/fpu_helper.c | 5 --

Re: [PATCH v3 0/9] VDIV/VMOD Implementation

2022-05-12 Thread Lucas Mateus Martins Araujo e Castro
ping On 20/04/2022 16:40, Lucas Mateus Castro(alqotel) wrote: From: "Lucas Mateus Castro (alqotel)" This patch series is an implementation of the vector divide, vector divide extended and vector modulo instructions from PowerISA 3.1 The first patch are Matheus' patch, used here since the divs2

[RFC PATCH 0/2] target/ppc: Propose rework in fp exception handling

2022-05-12 Thread Víctor Colombo
Hello everyone! I would like to propose a rework on the fpscr exceptions in fpu_helper.c. Today, we have: do_float_check_status() dealing with Overflow, Underflow, and Inexact; and other helpers for the invalid exceptions (like float_invalid_op_vximz(), float_invalid_op_vxisi()), including some sp

[RFC PATCH 1/2] target/ppc: Add invalid imz, isi and snan to do_float_check_status()

2022-05-12 Thread Víctor Colombo
Make do_float_check_status also handle some invalid exceptions: imz, isi and snan. The idea is to try to concentrate the handling of all fp exceptions in do_float_check_status. For this RFC, move only the 3 exceptions stated above. I chose to create new '*_defer' helpers to propose a gradual tran

Re: [PATCH v5 17/21] migration: Export tls-[creds|hostname|authz] params to cmdline too

2022-05-12 Thread Peter Xu
On Thu, May 12, 2022 at 08:05:45PM +0100, Daniel P. Berrangé wrote: > > > @@ -4372,12 +4375,9 @@ static void migration_class_init(ObjectClass > > > *klass, void *data) > > > static void migration_instance_finalize(Object *obj) > > > { > > > MigrationState *ms = MIGRATION_OBJ(obj); > > > -

Re: [PATCH 2/9] vfio: Fix compilation errors caused by VFIO migration v1 deprecation

2022-05-12 Thread Alex Williamson
On Thu, 12 May 2022 15:25:32 -0300 Jason Gunthorpe wrote: > On Thu, May 12, 2022 at 11:57:10AM -0600, Alex Williamson wrote: > > > @@ -767,9 +767,10 @@ static void vfio_migration_state_notifier(Notifier > > > *notifier, void *data) > > > case MIGRATION_STATUS_CANCELLED: > > > case MIGR

Re: [PULL 00/27] Misc patches for 2022-05-12

2022-05-12 Thread Richard Henderson
On 5/12/22 10:24, Paolo Bonzini wrote: The following changes since commit ec11dc41eec5142b4776db1296972c6323ba5847: Merge tag 'pull-misc-2022-05-11' of git://repo.or.cz/qemu/armbru into staging (2022-05-11 09:00:26 -0700) are available in the Git repository at: https://gitlab.com/bonzin

Re: [RFC PATCH 1/2] target/ppc: Add invalid imz, isi and snan to do_float_check_status()

2022-05-12 Thread Richard Henderson
On 5/12/22 12:42, Víctor Colombo wrote: Make do_float_check_status also handle some invalid exceptions: imz, isi and snan. The idea is to try to concentrate the handling of all fp exceptions in do_float_check_status. For this RFC, move only the 3 exceptions stated above. I chose to create new '

Re: [PATCH 2/9] vfio: Fix compilation errors caused by VFIO migration v1 deprecation

2022-05-12 Thread Jason Gunthorpe
On Thu, May 12, 2022 at 03:11:40PM -0600, Alex Williamson wrote: > On Thu, 12 May 2022 15:25:32 -0300 > Jason Gunthorpe wrote: > > > On Thu, May 12, 2022 at 11:57:10AM -0600, Alex Williamson wrote: > > > > @@ -767,9 +767,10 @@ static void vfio_migration_state_notifier(Notifier > > > > *notifier,

[PATCH 0/7] Implement bdrv_{pread, pwrite, pwrite_sync, pwrite_zeroes}() using generated_co_wrapper

2022-05-12 Thread Alberto Faria
Start by making the interfaces of analogous non-coroutine and coroutine functions consistent with each other, then implement the non-coroutine ones using generated_co_wrapper. For the bdrv_pwrite_sync() case, also add the missing bdrv_co_pwrite_sync() function. Alberto Faria (7): block: Add a '

[PATCH 3/7] block: Make bdrv_{pread,pwrite}() return 0 on success

2022-05-12 Thread Alberto Faria
They currently return the value of their 'bytes' parameter on success. Make them return 0 instead, for consistency with other I/O functions and in preparation to implement them using generated_co_wrapper. This also makes it clear that short reads/writes are not possible. The few callers that rely

[PATCH 2/7] block: Change bdrv_{pread, pwrite, pwrite_sync}() param order

2022-05-12 Thread Alberto Faria
Swap 'buf' and 'bytes' around for consistency with bdrv_co_{pread,pwrite}(), and in preparation to implement these functions using generated_co_wrapper. Callers were updated using this Coccinelle script: @@ expression child, offset, buf, bytes, flags; @@ - bdrv_pread(child, offset, buf, b

[PATCH 1/7] block: Add a 'flags' param to bdrv_{pread, pwrite, pwrite_sync}()

2022-05-12 Thread Alberto Faria
For consistency with other I/O functions, and in preparation to implement them using generated_co_wrapper. Callers were updated using this Coccinelle script: @@ expression child, offset, buf, bytes; @@ - bdrv_pread(child, offset, buf, bytes) + bdrv_pread(child, offset, buf, bytes, 0)

[PATCH 5/7] block: Make 'bytes' param of bdrv_co_{pread, pwrite, preadv, pwritev}() an int64_t

2022-05-12 Thread Alberto Faria
For consistency with other I/O functions, and in preparation to implement bdrv_{pread,pwrite}() using generated_co_wrapper. unsigned int fits in int64_t, so all callers remain correct. Signed-off-by: Alberto Faria --- block/coroutines.h | 4 ++-- include/block/block_int-io.h | 4 ++--

[PATCH 7/7] block: Add bdrv_co_pwrite_sync()

2022-05-12 Thread Alberto Faria
Also convert bdrv_pwrite_sync() to being implemented using generated_co_wrapper. Signed-off-by: Alberto Faria --- block/io.c | 5 +++-- include/block/block-io.h | 8 ++-- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/block/io.c b/block/io.c index ecd1c2a53c..19

[PATCH 6/7] block: Implement bdrv_{pread, pwrite, pwrite_zeroes}() using generated_co_wrapper

2022-05-12 Thread Alberto Faria
Signed-off-by: Alberto Faria --- block/io.c | 41 include/block/block-io.h | 15 +-- 2 files changed, 9 insertions(+), 47 deletions(-) diff --git a/block/io.c b/block/io.c index 78a289192e..ecd1c2a53c 100644 --- a/block/io.c +++

[PATCH 4/7] block: Make bdrv_co_pwrite() take a const buffer

2022-05-12 Thread Alberto Faria
It does not mutate the buffer. Signed-off-by: Alberto Faria --- include/block/block_int-io.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/block/block_int-io.h b/include/block/block_int-io.h index bb454200e5..d4d3bed783 100644 --- a/include/block/block_int-io.h +++

[RFC PATCH 4/9] tests: silence pip upgrade warnings during venv creation

2022-05-12 Thread John Snow
Turn off the nag warning coaxing us to upgrade pip. It's not really that interesting to see in CI logs, and as long as nothing is broken -- nothing is broken. Signed-off-by: John Snow --- tests/Makefile.include | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/Makef

[RFC PATCH 0/9] tests: run python tests under the build/tests/venv environment

2022-05-12 Thread John Snow
RFC: This is a very early, crude attempt at switching over to an external Python package dependency for QMP. This series does not actually make the switch in and of itself, but instead just switches to the paradigm of using a venv in general to install the QEMU python packages instead of using PYTH

[RFC PATCH 5/9] tests: use tests/venv to run basevm.py-based scripts

2022-05-12 Thread John Snow
This patch co-opts the virtual environment being used by avocado tests to also run the basevm.py tests. This is being done in preparation for for the qemu.qmp package being removed from qemu.git. As part of the change, remove any sys.path() hacks and treat "qemu" as a normal third-party import. S

[RFC PATCH 1/9] python: update for mypy 0.950

2022-05-12 Thread John Snow
typeshed (included in mypy) recently updated to improve the typing for WriteTransport objects. I was working around this, but now there's a version where I shouldn't work around it. Unfortunately this creates some minor ugliness if I want to support both pre- and post-0.950 versions. For now, for

[RFC PATCH 6/9] tests: add check-venv as a dependency of check and check-block

2022-05-12 Thread John Snow
This patch is being front-loaded before iotests actually relies on the tests/venv being created in order to preserve bisectability. Problems I am aware of here (There are a lot, sorry): - I am not sure the right place to express this dependency, so I did it in tests/Makefile.include. It seems t

[RFC PATCH 2/9] tests: add "TESTS_PYTHON" variable to Makefile

2022-05-12 Thread John Snow
This is a convenience feature: $(PYTHON) points to the Python executable we were instructed to use by the configure script. We use that Python to create a virtual environment with the "check-venv" target in tests/Makefile.include. $(TESTS_PYTHON) points to the Python executable belonging to the vi

[RFC PATCH 8/9] iotests: fix source directory location

2022-05-12 Thread John Snow
If you invoke the check script from outside of the tests/qemu-iotests directory, the directories initialized as source_iotests and build_iotests will be incorrect. We can use the location of the source file itself to be more accurate. (I don't know if this is actually *used*, but what was there w

[RFC PATCH 3/9] tests: install "qemu" namespace package into venv

2022-05-12 Thread John Snow
This patch adds the "qemu" namespace package to the $build/tests/venv directory. It does so in "editable" mode, which means that changes to the source python directory will actively be reflected by the venv. This patch also then removes any sys.path hacking from the avocado test scripts directly.

[RFC PATCH 7/9] tests: add check-venv to build-tcg-disabled CI recipe

2022-05-12 Thread John Snow
Signed-off-by: John Snow --- .gitlab-ci.d/buildtest.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml index 0aea7ab84c2..5c6201847f1 100644 --- a/.gitlab-ci.d/buildtest.yml +++ b/.gitlab-ci.d/buildtest.yml @@ -245,6 +245,7 @@ build-tcg

[RFC PATCH 9/9] iotests: use tests/venv for running tests

2022-05-12 Thread John Snow
Essentially, this: (A) adjusts the python binary to be the one found in the venv (which is a symlink to the python binary chosen at configure time) (B) adds a new VIRTUAL_ENV export variable (C) changes PATH to front-load the venv binary directory. If the venv directory isn't found, raise a fri

Re: [RFC PATCH v4 09/36] KVM: Introduce kvm_arch_pre_create_vcpu()

2022-05-12 Thread Xiaoyao Li
On 5/13/2022 1:50 AM, Isaku Yamahata wrote: On Thu, May 12, 2022 at 11:17:36AM +0800, Xiaoyao Li wrote: Introduce kvm_arch_pre_create_vcpu(), to perform arch-dependent work prior to create any vcpu. This is for i386 TDX because it needs call TDX_INIT_VM before creating any vcpu. Because "11/

[PATCH] hw: aspeed_soc: Initialize all UART's with serial devices

2022-05-12 Thread Peter Delevoryas
Usually, QEMU users just provide one serial device on the command line, either through "-nographic" or "-serial stdio -display none", or just using VNC and popping up a window. We try to match what the user expects, which is to connect the first (and usually only) serial device to the UART a board

Re: [RFC PATCH v4 10/36] i386/kvm: Move architectural CPUID leaf generation to separate helper

2022-05-12 Thread Xiaoyao Li
On 5/13/2022 1:48 AM, Isaku Yamahata wrote: On Thu, May 12, 2022 at 11:17:37AM +0800, Xiaoyao Li wrote: diff --git a/target/i386/kvm/kvm_i386.h b/target/i386/kvm/kvm_i386.h index b434feaa6b1d..5c7972f617e8 100644 --- a/target/i386/kvm/kvm_i386.h +++ b/target/i386/kvm/kvm_i386.h @@ -24,6 +24,10

Re: [RFC PATCH v4 24/36] i386/tdx: Add TDVF memory via KVM_TDX_INIT_MEM_REGION

2022-05-12 Thread Xiaoyao Li
On 5/13/2022 2:34 AM, Isaku Yamahata wrote: On Thu, May 12, 2022 at 11:17:51AM +0800, Xiaoyao Li wrote: From: Isaku Yamahata TDVF firmware (CODE and VARS) needs to be added/copied to TD's private memory via KVM_TDX_INIT_MEM_REGION, as well as TD HOB and TEMP memory. Signed-off-by: Isaku Yam

Re: [RFC PATCH v4 14/36] i386/tdx: Implement user specified tsc frequency

2022-05-12 Thread Xiaoyao Li
On 5/13/2022 2:04 AM, Isaku Yamahata wrote: On Thu, May 12, 2022 at 11:17:41AM +0800, Xiaoyao Li wrote: Reuse "-cpu,tsc-frequency=" to get user wanted tsc frequency and pass it to KVM_TDX_INIT_VM. Besides, sanity check the tsc frequency to be in the legal range and legal granularity (required

Re: [PATCH 2/2] coroutine: Revert to constant batch size

2022-05-12 Thread 成川 弘樹
I'm not sure how much testing is expected for "Tested-by". If just checking my perspective is enough, yes. But I did not check that this patch fixes the problem of excessive resource consumption. On 2022/05/12 21:50, Philippe Mathieu-Daudé wrote: Hi Hiroki, On Thu, May 12, 2022 at 8:57 AM 成

Re: [PATCH] hw: aspeed_soc: Initialize all UART's with serial devices

2022-05-12 Thread Peter Delevoryas
> On May 12, 2022, at 5:37 PM, Peter Delevoryas wrote: > > Usually, QEMU users just provide one serial device on the command line, > either through "-nographic" or "-serial stdio -display none", or just using > VNC and popping up a window. We try to match what the user expects, which is > to c

Re: [PATCH qemu v3 00/10] Add mask agnostic behavior for rvv instructions

2022-05-12 Thread Weiwei Li
在 2022/5/12 下午4:55, ~eopxd 写道: According to v-spec, mask agnostic behavior can be either kept as undisturbed or set elements' bits to all 1s. To distinguish the difference of mask policies, QEMU should be able to simulate the mask agnostic behavior as "set mask elements' bits to all 1s". There

Re: [PATCH v3 3/3] target/riscv: Add vstimecmp support

2022-05-12 Thread Atish Kumar Patra
On Wed, May 11, 2022 at 9:48 PM Anup Patel wrote: > > On Tue, May 10, 2022 at 3:03 AM Atish Patra wrote: > > > > vstimecmp CSR allows the guest OS or to program the next guest timer > > interrupt directly. Thus, hypervisor no longer need to inject the > > timer interrupt to the guest if vstimecmp

Re: [PATCH v5 3/4] vdpa: add vdpa-dev support

2022-05-12 Thread longpeng2--- via
在 2022/5/12 22:36, Stefano Garzarella 写道: On Thu, May 12, 2022 at 02:21:02PM +0800, Longpeng(Mike) wrote: From: Longpeng Supports vdpa-dev, we can use the deivce directly: -M microvm -m 512m -smp 2 -kernel ... -initrd ... -device \ vhost-vdpa-device,vhostdev=/dev/vhost-vdpa-x Signed-off-b

Re: [PATCH v5 2/4] virtio: get class_id and pci device id by the virtio id

2022-05-12 Thread longpeng2--- via
在 2022/5/12 14:56, Michael S. Tsirkin 写道: On Thu, May 12, 2022 at 02:21:01PM +0800, Longpeng(Mike) wrote: From: Longpeng Add helpers to get the "Transitional PCI Device ID" and "class_id" of the device specified by the "Virtio Device ID". These helpers will be used to build the generic vDP

Re: Re: [PATCH v5 1/9] virtio-crypto: header update

2022-05-12 Thread zhenwei pi
Hi, Daniel Something I do in my local branch(for the v6 series): - [PATCH v5 1/9] virtio-crypto: header update - [PATCH v5 3/9] crypto: Introduce akcipher crypto class Add 'Reviewed-by: Daniel P. Berrangé ' - [PATCH v5 4/9] crypto: add ASN.1 DER decoder - [PATCH v5 7/9] test/crypto: Add test s

[PATCH 0/2] hw: aspeed: Init all UART's with serial devices

2022-05-12 Thread Peter Delevoryas
CC'ing Zev and OpenBMC since this was motivated by a problem Zev had there: https://lore.kernel.org/openbmc/ynzgnwjkydmuu...@hatter.bewilderbeest.net/ This series adds all the missing UART's in the Aspeed chips, and initializes them all with serial devices (even if there is no peer character devi

[PATCH 2/2] hw: aspeed: Init all UART's with serial devices

2022-05-12 Thread Peter Delevoryas
Usually, QEMU users just provide one serial device on the command line, either through "-nographic" or "-serial stdio -display none", or just using VNC and popping up a window. We try to match what the user expects, which is to connect the first (and usually only) serial device to the UART a board

[PATCH 1/2] hw: aspeed: Add missing UART's

2022-05-12 Thread Peter Delevoryas
This adds the missing UART memory and IRQ mappings for the AST2400, AST2500, AST2600, and AST1030. This also includes the new UART interfaces added in the AST2600 and AST1030 from UART6 to UART13. The addresses and interrupt numbers for these two later chips are identical. Signed-off-by: Peter De

Re: [PATCH 1/2] hw: aspeed: Add missing UART's

2022-05-12 Thread Cédric Le Goater
On 5/13/22 06:02, Peter Delevoryas wrote: This adds the missing UART memory and IRQ mappings for the AST2400, AST2500, AST2600, and AST1030. This also includes the new UART interfaces added in the AST2600 and AST1030 from UART6 to UART13. The addresses and interrupt numbers for these two later c

Re: [PATCH 2/2] hw: aspeed: Init all UART's with serial devices

2022-05-12 Thread Cédric Le Goater
On 5/13/22 06:02, Peter Delevoryas wrote: Usually, QEMU users just provide one serial device on the command line, either through "-nographic" or "-serial stdio -display none", or just using VNC and popping up a window. We try to match what the user expects, which is to connect the first (and usua

sbsa board boot with neoverse-n1

2022-05-12 Thread Itaru Kitayama
Richard, I'm wondering what options you use to bring up sbsa board with neoverse-n1 as I am only able to do it with cortex-a57, no other CPU types works. Itaru.

Re: [PATCH v22 0/8] support dirty restraint on vCPU

2022-05-12 Thread 虚拟化-黄勇
Whose review is still needed?  Or is this ready? ---There is no review in the the process. Two month ago,  David has tried to queue this patch and reported a test failure, i fix this by add a test

Re: [PULL 00/16] migration queue

2022-05-12 Thread Leonardo Bras Soares Passos
On Wed, May 11, 2022 at 5:55 AM Dr. David Alan Gilbert wrote: > > * Leonardo Bras Soares Passos (leob...@redhat.com) wrote: > > From a previous thread: > > > > On Thu, Apr 28, 2022 at 1:20 PM Dr. David Alan Gilbert > > wrote: > > > > > > Leo: > > > Unfortunately this is failing a couple of CI t

[PATCH v13 0/8] MSG_ZEROCOPY + multifd

2022-05-12 Thread Leonardo Bras
This patch series intends to enable MSG_ZEROCOPY in QIOChannel, and make use of it for multifd migration performance improvement, by reducing cpu usage. Patch #1 conditionally disables liburing in systems where linux/errqueue.h conflict with liburing/compat.h (__kernel_timespec redefine) Patch #2

Re: [PATCH v8 07/12] target/riscv: Support mcycle/minstret write operation

2022-05-12 Thread Frank Chang
On Thu, May 12, 2022 at 6:01 AM Atish Patra wrote: > From: Atish Patra > > mcycle/minstret are actually WARL registers and can be written with any > given value. With SBI PMU extension, it will be used to store a initial > value provided from supervisor OS. The Qemu also need prohibit the counte

[PATCH v13 5/8] migration: Add migrate_use_tls() helper

2022-05-12 Thread Leonardo Bras
A lot of places check parameters.tls_creds in order to evaluate if TLS is in use, and sometimes call migrate_get_current() just for that test. Add new helper function migrate_use_tls() in order to simplify testing for TLS usage. Signed-off-by: Leonardo Bras Reviewed-by: Juan Quintela Reviewed-b

[PATCH v13 1/8] meson.build: Fix docker-test-build@alpine when including linux/errqueue.h

2022-05-12 Thread Leonardo Bras
A build error happens in alpine CI when linux/errqueue.h is included in io/channel-socket.c, due to redefining of 'struct __kernel_timespec': === ninja: job failed: [...] In file included from /usr/include/linux/errqueue.h:6, from ../io/channel-socket.c:29: /usr/include/linux/time

[PATCH v13 2/8] QIOChannel: Add flags on io_writev and introduce io_flush callback

2022-05-12 Thread Leonardo Bras
Add flags to io_writev and introduce io_flush as optional callback to QIOChannelClass, allowing the implementation of zero copy writes by subclasses. How to use them: - Write data using qio_channel_writev*(...,QIO_CHANNEL_WRITE_FLAG_ZERO_COPY), - Wait write completion with qio_channel_flush(). No

[PATCH v3] hw: m25p80: allow write_enable latch get/set

2022-05-12 Thread Iris Chen via
The write_enable latch property is not currently exposed. This commit makes it a modifiable property. Signed-off-by: Iris Chen --- v3: Addressed comments by Peter and Cedric. v2: Ran ./scripts/checkpatch.pl on the patch and added a description. Fixed comments regarding DEFINE_PROP_BOOL. hw/blo

[PATCH v13 7/8] multifd: Send header packet without flags if zero-copy-send is enabled

2022-05-12 Thread Leonardo Bras
Since d48c3a0445 ("multifd: Use a single writev on the send side"), sending the header packet and the memory pages happens in the same writev, which can potentially make the migration faster. Using channel-socket as example, this works well with the default copying mechanism of sendmsg(), but with

[PATCH v13 3/8] QIOChannelSocket: Implement io_writev zero copy flag & io_flush for CONFIG_LINUX

2022-05-12 Thread Leonardo Bras
For CONFIG_LINUX, implement the new zero copy flag and the optional callback io_flush on QIOChannelSocket, but enables it only when MSG_ZEROCOPY feature is available in the host kernel, which is checked on qio_channel_socket_connect_sync() qio_channel_socket_flush() was implemented by counting how

[PATCH v3] docs/about: Update the support statement for Windows

2022-05-12 Thread Thomas Huth
Our support statement for Windows currently talks about "Vista / Server 2008" - which is related to the API of Windows, and this is not easy to understand for the non-technical users. Additionally, glib sets the _WIN32_WINNT macro to 0x0601 already, which indicates the Windows 7 API, so QEMU effect

[PATCH v13 4/8] migration: Add zero-copy-send parameter for QMP/HMP for Linux

2022-05-12 Thread Leonardo Bras
Add property that allows zero-copy migration of memory pages on the sending side, and also includes a helper function migrate_use_zero_copy_send() to check if it's enabled. No code is introduced to actually do the migration, but it allow future implementations to enable/disable this feature. On n

<    1   2   3