Re: [PATCH] docs/about: Update the support statement for Windows

2022-05-12 Thread Thomas Huth
On 05/05/2022 17.09, Daniel P. Berrangé wrote: On Thu, May 05, 2022 at 04:12:11PM +0200, Thomas Huth wrote: On 05/05/2022 13.55, Daniel P. Berrangé wrote: On Thu, May 05, 2022 at 09:14:57AM +0100, Daniel P. Berrangé wrote: On Thu, May 05, 2022 at 09:48:41AM +0200, Thomas Huth wrote: Our suppo

[PATCH v2] docs/about: Update the support statement for Windows

2022-05-12 Thread Thomas Huth
Our support statement for Windows currently talks about "Vista / Server 2008" - which is related to the API of Windows, and this is not easy to understand for the non-technical users. Additionally, glib sets the _WIN32_WINNT macro to 0x0601 already, which indicates the Windows 7 API, so QEMU effect

Re: [PATCH] util: NUMA aware memory preallocation

2022-05-12 Thread Paolo Bonzini
On 5/11/22 18:54, Daniel P. Berrangé wrote: On Wed, May 11, 2022 at 01:07:47PM +0200, Paolo Bonzini wrote: On 5/11/22 12:10, Daniel P. Berrangé wrote: I expect creating/deleting I/O threads is cheap in comparison to the work done for preallocation. If libvirt is using -preconfig and object-add

Re: [PATCH] vhost-backend: do not depend on CONFIG_VHOST_VSOCK

2022-05-12 Thread Stefano Garzarella
On Wed, May 11, 2022 at 09:43:28AM +0200, Paolo Bonzini wrote: The vsock callbacks .vhost_vsock_set_guest_cid and .vhost_vsock_set_running are the only ones to be conditional on #ifdef CONFIG_VHOST_VSOCK. This is different from any other device-dependent callbacks like .vhost_scsi_set_endpoint,

[RFC PATCH v2 4/8] net: stream: Don't ignore EINVAL on netdev socket connection

2022-05-12 Thread Laurent Vivier
From: Stefano Brivio Other errors are treated as failure by net_stream_client_init(), but if connect() returns EINVAL, we'll fail silently. Remove the related exception. Signed-off-by: Stefano Brivio [lvivier: applied to net/stream.c] Signed-off-by: Laurent Vivier --- net/stream.c | 3 +-- 1

[RFC PATCH v2 7/8] net: dgram: move mcast specific code from net_socket_fd_init_dgram()

2022-05-12 Thread Laurent Vivier
It is less complex to manage special cases directly in net_dgram_mcast_init() and net_dgram_udp_init(). Signed-off-by: Laurent Vivier --- net/dgram.c | 143 +++- 1 file changed, 73 insertions(+), 70 deletions(-) diff --git a/net/dgram.c b/net/dgra

[RFC PATCH v2 3/8] qapi: net: add stream and dgram netdevs

2022-05-12 Thread Laurent Vivier
Copied from socket netdev file and modified to use SocketAddress to be able to introduce new features like unix socket. "udp" and "mcast" are squashed into dgram netdev, multicast is detected according to the IP address type. "listen" and "connect" modes are managed by stream netdev. An optional p

[RFC PATCH v2 5/8] net: stream: add unix socket

2022-05-12 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- net/stream.c | 106 +++ 1 file changed, 99 insertions(+), 7 deletions(-) diff --git a/net/stream.c b/net/stream.c index 12fc26b9f4c7..dca50508ed84 100644 --- a/net/stream.c +++ b/net/stream.c @@ -234,7 +234,7 @@ st

[RFC PATCH v2 2/8] qapi: net: introduce a way to bypass qemu_opts_parse_noisily()

2022-05-12 Thread Laurent Vivier
As qemu_opts_parse_noisily() flattens the QAPI structures ("type" field of Netdev structure can collides with "type" field of SocketAddress), we introduce a way to bypass qemu_opts_parse_noisily() and use directly visit_type_Netdev() to parse the backend parameters. Signed-off-by: Laurent Vivier

[RFC PATCH v2 0/8] qapi: net: add unix socket type support to netdev backend

2022-05-12 Thread Laurent Vivier
"-netdev socket" only supports inet sockets. It's not a complex task to add support for unix sockets, but the socket netdev parameters are not defined to manage well unix socket parameters. As discussed in: "socket.c added support for unix domain socket datagram transport" https://lore.kern

[RFC PATCH v2 8/8] net: dgram: add unix socket

2022-05-12 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- net/dgram.c | 65 ++--- 1 file changed, 62 insertions(+), 3 deletions(-) diff --git a/net/dgram.c b/net/dgram.c index c0cf0410792e..9f20bdbc163c 100644 --- a/net/dgram.c +++ b/net/dgram.c @@ -85,8 +85,15 @@ static

[RFC PATCH v2 6/8] net: dgram: make dgram_dst generic

2022-05-12 Thread Laurent Vivier
dgram_dst is a sockaddr_in structure. To be able to use it with unix socket, use a pointer to a generic sockaddr structure. Signed-off-by: Laurent Vivier --- net/dgram.c | 76 +++-- 1 file changed, 45 insertions(+), 31 deletions(-) diff --git a/ne

Re: [PATCH] util: NUMA aware memory preallocation

2022-05-12 Thread Daniel P . Berrangé
On Thu, May 12, 2022 at 09:41:29AM +0200, Paolo Bonzini wrote: > On 5/11/22 18:54, Daniel P. Berrangé wrote: > > On Wed, May 11, 2022 at 01:07:47PM +0200, Paolo Bonzini wrote: > > > On 5/11/22 12:10, Daniel P. Berrangé wrote: > > > > I expect creating/deleting I/O threads is cheap in comparison to

[RFC PATCH v2 1/8] net: introduce convert_host_port()

2022-05-12 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- include/qemu/sockets.h | 2 ++ net/net.c | 62 ++ 2 files changed, 34 insertions(+), 30 deletions(-) diff --git a/include/qemu/sockets.h b/include/qemu/sockets.h index 038faa157f59..47194b9732f8 100644 --- a/

[PATCH qemu v17 03/16] target/riscv: rvv: Rename ambiguous esz

2022-05-12 Thread ~eopxd
From: eopXD No functional change intended in this commit. Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li Reviewed-by: Alistair Francis --- target/riscv/vector_helper.c | 76 ++-- 1 file changed, 38 insertions(+), 38 deletions(-) diff

Re: [PATCH 3/3] ui: Remove deprecated options "-sdl" and "-curses"

2022-05-12 Thread Daniel P . Berrangé
On Wed, May 11, 2022 at 07:51:47PM +0200, Thomas Huth wrote: > We have "-sdl" and "-curses", but no "-gtk" and no "-cocoa" ... > these old-style options are rather confusing than helpful nowadays. > Now that the deprecation period is over, let's remove them, so we > get a cleaner interface (where "

Re: [PATCH 1/3] ui: Remove deprecated parameters of the "-display sdl" option

2022-05-12 Thread Daniel P . Berrangé
On Wed, May 11, 2022 at 07:51:45PM +0200, Thomas Huth wrote: > These parameters are in the way for further refactoring (since they > use an underscore in the name which is forbidden in QAPI), so let's > remove these now that their deprecation period is over. > > Signed-off-by: Thomas Huth > --- >

[PATCH qemu v17 08/16] target/riscv: rvv: Add tail agnostic for vector integer shift instructions

2022-05-12 Thread ~eopxd
From: eopXD Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li Acked-by: Alistair Francis --- target/riscv/insn_trans/trans_rvv.c.inc | 3 ++- target/riscv/vector_helper.c| 11 +++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/target

[PATCH qemu v17 04/16] target/riscv: rvv: Early exit when vstart >= vl

2022-05-12 Thread ~eopxd
From: eopXD According to v-spec (section 5.4): When vstart ≥ vl, there are no body elements, and no elements are updated in any destination vector register group, including that no tail elements are updated with agnostic values. vmsbf.m, vmsif.m, vmsof.m, viota.m, vcompress instructions themselv

Re: [PATCH 2/3] ui: Switch "-display sdl" to use the QAPI parser

2022-05-12 Thread Daniel P . Berrangé
On Wed, May 11, 2022 at 07:51:46PM +0200, Thomas Huth wrote: > The "-display sdl" option still uses a hand-crafted parser for its > parameters since some of them used underscores which is forbidden > in QAPI. Now that the problematic parameters have been removed, we can > switch to use the QAPI par

Re: [PATCH] qapi: make machine type deprecation a warning

2022-05-12 Thread Paolo Bonzini
On 5/11/22 20:44, Markus Armbruster wrote: Paolo Bonzini writes: Signed-off-by: Paolo Bonzini --- softmmu/vl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/softmmu/vl.c b/softmmu/vl.c index c2919579fd..fbef0f5c5f 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c @@ -3723,

[PATCH qemu v17 00/16] Add tail agnostic behavior for rvv instructions

2022-05-12 Thread ~eopxd
According to v-spec, tail agnostic behavior can be either kept as undisturbed or set elements' bits to all 1s. To distinguish the difference of tail policies, QEMU should be able to simulate the tail agnostic behavior as "set tail elements' bits to all 1s". An option 'rvv_ta_all_1s' is added to ena

[PATCH qemu v17 06/16] target/riscv: rvv: Add tail agnostic for vector load / store instructions

2022-05-12 Thread ~eopxd
From: eopXD Destination register of unit-stride mask load and store instructions are always written with a tail-agnostic policy. A vector segment load / store instruction may contain fractional lmul with nf * lmul > 1. The rest of the elements in the last register should be treated as tail eleme

[PATCH qemu v17 05/16] target/riscv: rvv: Add tail agnostic for vv instructions

2022-05-12 Thread ~eopxd
From: eopXD According to v-spec, tail agnostic behavior can be either kept as undisturbed or set elements' bits to all 1s. To distinguish the difference of tail policies, QEMU should be able to simulate the tail agnostic behavior as "set tail elements' bits to all 1s". There are multiple possibi

[PATCH qemu v17 02/16] target/riscv: rvv: Prune redundant access_type parameter passed

2022-05-12 Thread ~eopxd
From: eopXD No functional change intended in this commit. Signed-off-by: eop Chen --- target/riscv/vector_helper.c | 35 --- 1 file changed, 16 insertions(+), 19 deletions(-) diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c index 85dd611

[PATCH qemu v17 07/16] target/riscv: rvv: Add tail agnostic for vx, vvm, vxm instructions

2022-05-12 Thread ~eopxd
From: eopXD `vmadc` and `vmsbc` produces a mask value, they always operate with a tail agnostic policy. Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li Acked-by: Alistair Francis --- target/riscv/insn_trans/trans_rvv.c.inc | 13 +- target/riscv/internals.h

[PATCH qemu v17 01/16] target/riscv: rvv: Prune redundant ESZ, DSZ parameter passed

2022-05-12 Thread ~eopxd
From: eopXD No functional change intended in this commit. Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li Reviewed-by: Alistair Francis --- target/riscv/vector_helper.c | 1132 +- 1 file changed, 565 insertions(+), 567 deletions(-) di

[PATCH qemu v17 09/16] target/riscv: rvv: Add tail agnostic for vector integer comparison instructions

2022-05-12 Thread ~eopxd
From: eopXD Compares write mask registers, and so always operate under a tail- agnostic policy. Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li Acked-by: Alistair Francis --- target/riscv/vector_helper.c | 18 ++ 1 file changed, 18 insertions(+) diff

[PATCH qemu v17 14/16] target/riscv: rvv: Add tail agnostic for vector mask instructions

2022-05-12 Thread ~eopxd
From: eopXD The tail elements in the destination mask register are updated under a tail-agnostic policy. Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li Acked-by: Alistair Francis --- target/riscv/insn_trans/trans_rvv.c.inc | 6 + target/riscv/vector_helper.c

[PATCH qemu v17 16/16] target/riscv: rvv: Add option 'rvv_ta_all_1s' to enable optional tail agnostic behavior

2022-05-12 Thread ~eopxd
From: eopXD According to v-spec, tail agnostic behavior can be either kept as undisturbed or set elements' bits to all 1s. To distinguish the difference of tail policies, QEMU should be able to simulate the tail agnostic behavior as "set tail elements' bits to all 1s". There are multiple possibi

[PATCH qemu v17 13/16] target/riscv: rvv: Add tail agnostic for vector reduction instructions

2022-05-12 Thread ~eopxd
From: eopXD Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li Acked-by: Alistair Francis --- target/riscv/vector_helper.c | 20 1 file changed, 20 insertions(+) diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c index 7dcb51b6

[PATCH qemu v17 15/16] target/riscv: rvv: Add tail agnostic for vector permutation instructions

2022-05-12 Thread ~eopxd
From: eopXD Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li Acked-by: Alistair Francis --- target/riscv/insn_trans/trans_rvv.c.inc | 7 +++-- target/riscv/vector_helper.c| 40 + 2 files changed, 45 insertions(+), 2 deletions(-) di

[PATCH qemu v17 10/16] target/riscv: rvv: Add tail agnostic for vector integer merge and move instructions

2022-05-12 Thread ~eopxd
From: eopXD Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li Acked-by: Alistair Francis --- target/riscv/insn_trans/trans_rvv.c.inc | 12 target/riscv/vector_helper.c| 20 2 files changed, 28 insertions(+), 4 deletions(-)

Re: [PATCH RESEND] qga: add guest-get-diskstats command for Linux guests

2022-05-12 Thread Daniel P . Berrangé
On Thu, May 12, 2022 at 09:19:30AM +0800, luzhipeng wrote: > Add a new 'guest-get-diskstats' command for report disk io statistics > for Linux guests. This can be usefull for getting io flow or handling > IO fault, no need to enter guests. > > Signed-off-by: luzhipeng > --- > qga/commands-posix.

[PATCH qemu v17 12/16] target/riscv: rvv: Add tail agnostic for vector floating-point instructions

2022-05-12 Thread ~eopxd
From: eopXD Compares write mask registers, and so always operate under a tail- agnostic policy. Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li Acked-by: Alistair Francis --- target/riscv/insn_trans/trans_rvv.c.inc | 17 + target/riscv/vector_helper.c| 4

[PATCH qemu v17 11/16] target/riscv: rvv: Add tail agnostic for vector fix-point arithmetic instructions

2022-05-12 Thread ~eopxd
From: eopXD Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li Acked-by: Alistair Francis --- target/riscv/vector_helper.c | 220 ++- 1 file changed, 114 insertions(+), 106 deletions(-) diff --git a/target/riscv/vector_helper.c b/target/r

Re: [RFC PATCH v2 4/8] net: stream: Don't ignore EINVAL on netdev socket connection

2022-05-12 Thread Daniel P . Berrangé
On Thu, May 12, 2022 at 10:09:28AM +0200, Laurent Vivier wrote: > From: Stefano Brivio > > Other errors are treated as failure by net_stream_client_init(), > but if connect() returns EINVAL, we'll fail silently. Remove the > related exception. > > Signed-off-by: Stefano Brivio > [lvivier: appli

[PATCH qemu v3 01/10] target/riscv: rvv: Add mask agnostic for vv instructions

2022-05-12 Thread ~eopxd
From: Yueh-Ting (eop) Chen According to v-spec, mask agnostic behavior can be either kept as undisturbed or set elements' bits to all 1s. To distinguish the difference of mask policies, QEMU should be able to simulate the mask agnostic behavior as "set mask elements' bits to all 1s". There are m

Re: [PATCH v2] docs/about: Update the support statement for Windows

2022-05-12 Thread Daniel P . Berrangé
On Thu, May 12, 2022 at 09:39:29AM +0200, Thomas Huth wrote: > Our support statement for Windows currently talks about "Vista / Server > 2008" - which is related to the API of Windows, and this is not easy > to understand for the non-technical users. Additionally, glib sets the > _WIN32_WINNT macro

[PATCH qemu v3 03/10] target/riscv: rvv: Add mask agnostic for vx instructions

2022-05-12 Thread ~eopxd
From: Yueh-Ting (eop) Chen Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li --- target/riscv/insn_trans/trans_rvv.c.inc | 2 ++ target/riscv/vector_helper.c| 3 +++ 2 files changed, 5 insertions(+) diff --git a/target/riscv/insn_trans/trans_rvv.c.inc b/tar

[PATCH qemu v3 06/10] target/riscv: rvv: Add mask agnostic for vector fix-point arithmetic instructions

2022-05-12 Thread ~eopxd
From: Yueh-Ting (eop) Chen Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li --- target/riscv/vector_helper.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c inde

Re: [PATCH 0/2] s390x: kvm: Honor storage keys during emulation

2022-05-12 Thread Thomas Huth
On 10/05/2022 15.43, Cornelia Huck wrote: On Tue, May 10 2022, Janis Schoetterl-Glausch wrote: On 5/9/22 10:06, Cornelia Huck wrote: On Fri, May 06 2022, Janis Schoetterl-Glausch wrote: Make use of the storage key support of the MEMOP ioctl, if available, in order to support storage key ch

[PATCH qemu v3 00/10] Add mask agnostic behavior for rvv instructions

2022-05-12 Thread ~eopxd
According to v-spec, mask agnostic behavior can be either kept as undisturbed or set elements' bits to all 1s. To distinguish the difference of mask policies, QEMU should be able to simulate the mask agnostic behavior as "set mask elements' bits to all 1s". There are multiple possibility for agnos

[PATCH qemu v3 10/10] target/riscv: rvv: Add option 'rvv_ma_all_1s' to enable optional mask agnostic behavior

2022-05-12 Thread ~eopxd
From: eopXD According to v-spec, mask agnostic behavior can be either kept as undisturbed or set elements' bits to all 1s. To distinguish the difference of mask policies, QEMU should be able to simulate the mask agnostic behavior as "set mask elements' bits to all 1s". There are multiple possibi

[PATCH qemu v3 02/10] target/riscv: rvv: Add mask agnostic for vector load / store instructions

2022-05-12 Thread ~eopxd
From: Yueh-Ting (eop) Chen Signed-off-by: eop Chen Reviewed-by: Frank Chang --- target/riscv/insn_trans/trans_rvv.c.inc | 9 +++ target/riscv/vector_helper.c| 35 + 2 files changed, 33 insertions(+), 11 deletions(-) diff --git a/target/riscv/insn_trans

[PATCH qemu v3 09/10] target/riscv: rvv: Add mask agnostic for vector permutation instructions

2022-05-12 Thread ~eopxd
From: Yueh-Ting (eop) Chen Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li --- target/riscv/insn_trans/trans_rvv.c.inc | 1 + target/riscv/vector_helper.c| 26 +++-- 2 files changed, 25 insertions(+), 2 deletions(-) diff --git a/target

Re: [PATCH] Remove Ubuntu 18.04 support from the repository

2022-05-12 Thread Philippe Mathieu-Daudé via
On Wed, May 11, 2022 at 1:15 PM Thomas Huth wrote: > On 11/05/2022 13.13, Philippe Mathieu-Daudé wrote: > > On Wed, May 11, 2022 at 1:03 PM Thomas Huth wrote: > >> On 11/05/2022 12.46, Philippe Mathieu-Daudé wrote: > >>>On Wed, May 11, 2022 at 11:30 AM Daniel P. Berrangé > >>> wrote: >

[PATCH qemu v3 07/10] target/riscv: rvv: Add mask agnostic for vector floating-point instructions

2022-05-12 Thread ~eopxd
From: Yueh-Ting (eop) Chen Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li --- target/riscv/insn_trans/trans_rvv.c.inc | 12 target/riscv/vector_helper.c| 26 + 2 files changed, 38 insertions(+) diff --git a/target/risc

[PATCH qemu v3 04/10] target/riscv: rvv: Add mask agnostic for vector integer shift instructions

2022-05-12 Thread ~eopxd
From: Yueh-Ting (eop) Chen Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li --- target/riscv/insn_trans/trans_rvv.c.inc | 1 + target/riscv/vector_helper.c| 7 +++ 2 files changed, 8 insertions(+) diff --git a/target/riscv/insn_trans/trans_rvv.c.inc b/

[PATCH qemu v3 05/10] target/riscv: rvv: Add mask agnostic for vector integer comparison instructions

2022-05-12 Thread ~eopxd
From: Yueh-Ting (eop) Chen Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li --- target/riscv/insn_trans/trans_rvv.c.inc | 1 + target/riscv/vector_helper.c| 10 ++ 2 files changed, 11 insertions(+) diff --git a/target/riscv/insn_trans/trans_rvv.c.i

Re: [PATCH] Remove Ubuntu 18.04 support from the repository

2022-05-12 Thread Daniel P . Berrangé
On Thu, May 12, 2022 at 11:14:45AM +0200, Philippe Mathieu-Daudé wrote: > On Wed, May 11, 2022 at 1:15 PM Thomas Huth wrote: > > On 11/05/2022 13.13, Philippe Mathieu-Daudé wrote: > > > On Wed, May 11, 2022 at 1:03 PM Thomas Huth wrote: > > >> On 11/05/2022 12.46, Philippe Mathieu-Daudé wrote: >

Re: [PATCH 0/5] gicv3: Use right number of prio bits for the CPU

2022-05-12 Thread Peter Maydell
On Sat, 7 May 2022 at 12:35, Richard Henderson wrote: > > On 5/6/22 11:21, Peter Maydell wrote: > > This patchset fills in an odd inconsistency in our GICv3 emulation > > that I noticed while I was doing the GICv4 work. At the moment we > > allow the CPU to specify the number of bits of virtual pr

[PATCH qemu v3 08/10] target/riscv: rvv: Add mask agnostic for vector mask instructions

2022-05-12 Thread ~eopxd
From: Yueh-Ting (eop) Chen Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li --- target/riscv/insn_trans/trans_rvv.c.inc | 3 +++ target/riscv/vector_helper.c| 11 +++ 2 files changed, 14 insertions(+) diff --git a/target/riscv/insn_trans/trans_rvv.

Re: [PATCH] qapi: make machine type deprecation a warning

2022-05-12 Thread Markus Armbruster
Paolo Bonzini writes: > On 5/11/22 20:44, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> Signed-off-by: Paolo Bonzini >>> --- >>> softmmu/vl.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/softmmu/vl.c b/softmmu/vl.c >>> index c2919579fd..fbef0f5c5

Re: [RFC 00/18] vfio: Adopt iommufd

2022-05-12 Thread zhangfei....@foxmail.com
Hi, Yi On 2022/5/11 下午10:17, zhangfei@foxmail.com wrote: On 2022/5/10 下午10:08, Yi Liu wrote: On 2022/5/10 20:45, Jason Gunthorpe wrote: On Tue, May 10, 2022 at 08:35:00PM +0800, Zhangfei Gao wrote: Thanks Yi and Eric, Then will wait for the updated iommufd kernel for the PCI MMIO regi

Re: [PATCH v2 0/5] hw/nvme: fix namespace identifiers

2022-05-12 Thread Klaus Jensen
On Apr 29 10:33, Klaus Jensen wrote: > From: Klaus Jensen > > The namespace identifiers reported by the controller is kind of a mess. > See [1,2]. > > This series should fix this for both the `-device nvme,drive=...` and > `-device nvme-ns,...` cases. > > [1]: https://lore.kernel.org/linux-nv

Re: [PATCH 2/2] coroutine: Revert to constant batch size

2022-05-12 Thread Kevin Wolf
Am 12.05.2022 um 08:56 hat 成川 弘樹 geschrieben: > Thank you for your fix. > > I confirmed that after applying this patch, my intended performance > improvement by 4c41c69e is still kept in our environment. This is good news. Thank you for testing the patch! Kevin

[PATCH] hw/nvme: clear aen mask on reset

2022-05-12 Thread Klaus Jensen
From: Klaus Jensen The internally maintained AEN mask is not cleared on reset. Fix this. Signed-off-by: Klaus Jensen --- hw/nvme/ctrl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c index 1e6e0fcad918..4c8200dfb859 100644 --- a/hw/nvme/ctrl.c +++ b/hw/nvme

Re: [PATCH v5 7/9] test/crypto: Add test suite for crypto akcipher

2022-05-12 Thread Daniel P . Berrangé
On Thu, Apr 28, 2022 at 09:59:41PM +0800, zhenwei pi wrote: > From: Lei He > > Add unit test and benchmark test for crypto akcipher. > > Signed-off-by: lei he > Signed-off-by: zhenwei pi > Reviewed-by: Daniel P. Berrangé > --- > tests/bench/benchmark-crypto-akcipher.c | 157 ++ > tests/b

Re: [PATCH v5 4/9] crypto: add ASN.1 DER decoder

2022-05-12 Thread Daniel P . Berrangé
On Thu, Apr 28, 2022 at 09:59:38PM +0800, zhenwei pi wrote: > From: Lei He > > Add an ANS.1 DER decoder which is used to parse asymmetric > cipher keys > > Signed-off-by: zhenwei pi > Signed-off-by: lei he > --- > crypto/der.c | 190 +++ > crypto/der.h

Re: [PATCH v5 3/9] crypto: Introduce akcipher crypto class

2022-05-12 Thread Daniel P . Berrangé
On Thu, Apr 28, 2022 at 09:59:37PM +0800, zhenwei pi wrote: > Introduce new akcipher crypto class 'QCryptoAkCIpher', which supports > basic asymmetric operations: encrypt, decrypt, sign and verify. > > Suggested by Daniel P. Berrangé, also add autoptr cleanup for the new > class. Thanks to Daniel!

[PATCH] Fix aarch64 debug register names.

2022-05-12 Thread Chris Howard
From 5de17d5aacb9cf21de4c9736b227b0498c607709 Mon Sep 17 00:00:00 2001 From: CHRIS HOWARD Date: Thu, 12 May 2022 11:35:17 +0200 Subject: [PATCH] Fix aarch64 debug register names. Signed-off-by: CHRIS HOWARD --- target/arm/helper.c | 16 1 file changed, 12 insertions(+), 4 delet

Re: [PATCH v5 1/9] virtio-crypto: header update

2022-05-12 Thread Daniel P . Berrangé
On Thu, Apr 28, 2022 at 09:59:35PM +0800, zhenwei pi wrote: > Update header from linux, support akcipher service. > > Reviewed-by: Gonglei > Signed-off-by: lei he > Signed-off-by: zhenwei pi > --- > .../standard-headers/linux/virtio_crypto.h| 82 ++- > 1 file changed, 81 in

Re: [PATCH] Remove Ubuntu 18.04 support from the repository

2022-05-12 Thread Philippe Mathieu-Daudé via
On Thu, May 12, 2022 at 11:21 AM Daniel P. Berrangé wrote: > On Thu, May 12, 2022 at 11:14:45AM +0200, Philippe Mathieu-Daudé wrote: > > On Wed, May 11, 2022 at 1:15 PM Thomas Huth wrote: > > > On 11/05/2022 13.13, Philippe Mathieu-Daudé wrote: > > > > On Wed, May 11, 2022 at 1:03 PM Thomas Huth

[PULL 0/2] Update linux-headers to v5.18-rc6

2022-05-12 Thread Thomas Huth
Hi! The following changes since commit ec11dc41eec5142b4776db1296972c6323ba5847: Merge tag 'pull-misc-2022-05-11' of git://repo.or.cz/qemu/armbru into staging (2022-05-11 09:00:26 -0700) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull-request-2022-05-12

[PULL 2/2] vfio: tolerate migration protocol v1 uapi renames

2022-05-12 Thread Thomas Huth
From: Matthew Rosato The v1 uapi is deprecated and will be replaced by v2 at some point; this patch just tolerates the renaming of uapi fields to reflect v1 / deprecated status. Signed-off-by: Matthew Rosato Message-Id: <20220404181726.60291-3-mjros...@linux.ibm.com> Signed-off-by: Thomas Huth

Re: [PATCH] iotests/testrunner: Flush after run_test()

2022-05-12 Thread Kevin Wolf
Am 06.05.2022 um 15:42 hat Hanna Reitz geschrieben: > When stdout is not a terminal, the buffer may not be flushed at each end > of line, so we should flush after each test is done. This is especially > apparent when run by check-block, in two ways: > > First, when running make check-block -jX wi

[PATCH v2] block/gluster: correctly set max_pdiscard

2022-05-12 Thread Fabian Ebner
On 64-bit platforms, SIZE_MAX is too large for max_pdiscard, which is int64_t, and the following assertion would be triggered: qemu-system-x86_64: ../block/io.c:3166: bdrv_co_pdiscard: Assertion `max_pdiscard >= bs->bl.request_alignment' failed. Fixes: 0c8022876f ("block: use int64_t instead of in

Re: [PATCH 0/2] ci: improve debuggability of I/O tests

2022-05-12 Thread Kevin Wolf
Am 09.05.2022 um 14:41 hat Daniel P. Berrangé geschrieben: > Currently with the TAP harness we see essentially no useful information > about the I/O tests execution. To pick a random job: > > https://gitlab.com/qemu-project/qemu/-/jobs/2429330423 > > All that we get is this: > > 184/204 qemu

[PATCH v2 0/3] thread-pool: fix performance regression

2022-05-12 Thread Paolo Bonzini
Together, these two patches fix the performance regression induced by QemuSemaphore; individually they don't though. The third patch is a small cleanup on top, that was enabled by the recent introduction of min_threads/max_threads knobs for the thread pool. 6.2: iops: min=58051, max=62

[PULL 1/2] linux-headers: Update headers to v5.18-rc6

2022-05-12 Thread Thomas Huth
Several other upcoming patch series will need this update. Signed-off-by: Thomas Huth --- .../linux/input-event-codes.h | 25 +- .../standard-headers/linux/virtio_config.h| 6 + .../standard-headers/linux/virtio_crypto.h| 82 +++- linux-headers/asm-arm64/kvm.h

[PATCH v2 1/3] thread-pool: optimize scheduling of completion bottom half

2022-05-12 Thread Paolo Bonzini
The completion bottom half was scheduled within the pool->lock critical section. That actually results in worse performance, because the worker thread can run its own small critical section and go to sleep before the bottom half starts running. Note that this simple change does not produce an imp

Re: [PATCH] qapi: make machine type deprecation a warning

2022-05-12 Thread Markus Armbruster
Commit message nitpick: not sure this is "qapi:". The commit that introduced "Machine type ... is deprecated" (08fe68244eb) used "hw/i386:". We commonly use "vl:", "softmmu:", and "softmmu/vl:" for this file.

[PATCH v2 3/3] thread-pool: remove stopping variable

2022-05-12 Thread Paolo Bonzini
Just setting the max threads to 0 is enough to stop all workers. Signed-off-by: Paolo Bonzini --- util/thread-pool.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/util/thread-pool.c b/util/thread-pool.c index da189d9338..392c7d7843 100644 --- a/util/thread-pool.c +++ b

[PATCH v2 0/3] thread-pool: fix performance regression

2022-05-12 Thread Paolo Bonzini
Together, these two patches fix the performance regression induced by QemuSemaphore; individually they don't though. The third patch is a small cleanup on top, that was enabled by the recent introduction of min_threads/max_threads knobs for the thread pool. 6.2: iops: min=58051, max=62

Re: [PATCH-for-6.2 0/2] hw/block/fdc: Fix CVE-2021-3507

2022-05-12 Thread Kevin Wolf
Am 03.05.2022 um 18:21 hat Jon Maloy geschrieben: > > > On 5/3/22 05:59, Kevin Wolf wrote: > > Am 23.03.2022 um 03:25 hat John Snow geschrieben: > > > On Fri, Mar 18, 2022 at 2:50 PM Thomas Huth wrote: > > > > On 10/03/2022 18.53, Jon Maloy wrote: > > > > > On 3/10/22 12:14, Thomas Huth wrote: >

[PATCH v2 2/3] thread-pool: replace semaphore with condition variable

2022-05-12 Thread Paolo Bonzini
Since commit f9fc8932b1 ("thread-posix: remove the posix semaphore support", 2022-04-06) QemuSemaphore has its own mutex and condition variable; this adds unnecessary overhead on I/O with small block sizes. Check the QTAILQ directly instead of adding the indirection of a semaphore's count. Using

Re: [PATCH 1/1] Add Zihintpause support

2022-05-12 Thread Heiko Stübner
Am Dienstag, 10. Mai 2022, 08:42:31 CEST schrieb Dao Lu: > Added support for RISC-V PAUSE instruction from Zihintpause extension, enabeld > by default. > > Signed-off-by: Dao Lu This patch with your fixup applied to it and of course a matching kernel: Tested-by: Heiko Stuebner > --- > targe

Re: [PATCH v4 0/2] nbd: MULTI_CONN for shared writable exports

2022-05-12 Thread Kevin Wolf
Am 12.05.2022 um 02:49 hat Eric Blake geschrieben: > v3 was here: > https://lists.gnu.org/archive/html/qemu-devel/2022-03/msg03701.html > with additional review here: > https://lists.gnu.org/archive/html/qemu-devel/2022-05/msg00166.html Thanks, applied to the block branch. Kevin

Re: [PATCH v2 8/8] qapi: Stop using whitespace for alignment in comments

2022-05-12 Thread Markus Armbruster
Eric Blake writes: > On Tue, May 03, 2022 at 09:37:37AM +0200, Andrea Bolognani wrote: >> Perfectly aligned things look pretty, but keeping them that >> way as the schema evolves requires churn, and in some cases >> newly-added lines are not aligned properly. >> >> Overall, trying to align thing

Re: [PATCH 0/6] hppa: Artist graphics driver fixes for HP-UX

2022-05-12 Thread Helge Deller
Please review below patch as well. I'd like to include it in the series when I send a v2 version of the series. Thanks, Helge From: Helge Deller Date: Thu, 12 May 2022 13:40:39 +0200 Subject: [PATCH] artist: Fix X cursor position calculation in X11 The X cursor postion can be calculated based

Re: [PATCH 2/3] ui: Switch "-display sdl" to use the QAPI parser

2022-05-12 Thread Markus Armbruster
Thomas Huth writes: > The "-display sdl" option still uses a hand-crafted parser for its > parameters since some of them used underscores which is forbidden > in QAPI. Kind of. QAPI indeed requires lower-case-with-hyphens for such names, but there is an exception mechanism for names with upper

Re: [PATCH] qapi: make machine type deprecation a warning

2022-05-12 Thread Paolo Bonzini
On 5/12/22 12:46, Markus Armbruster wrote: Commit message nitpick: not sure this is "qapi:". The commit that introduced "Machine type ... is deprecated" (08fe68244eb) used "hw/i386:". We commonly use "vl:", "softmmu:", and "softmmu/vl:" for this file. Will do. I wonder if I should already pr

Re: [PATCH] target/openrisc: Do not reset delay slot flag on early tb exit

2022-05-12 Thread Stafford Horne
On Wed, May 11, 2022 at 07:11:20PM -0700, Richard Henderson wrote: > On 5/11/22 15:34, Stafford Horne wrote: > > In this case I don't see how the tb->flag would be updated, ooh, I guess it > > would have been set earlier when the TB was generated. Maybe that is what > > I am > > missing. > > Cor

Re: [RFC PATCH qemu] spapr/docs: Add a few words about x-vof

2022-05-12 Thread Cédric Le Goater
On 5/12/22 05:10, Alexey Kardashevskiy wrote: On 5/12/22 06:42, Daniel Henrique Barboza wrote: On 5/6/22 02:51, Alexey Kardashevskiy wrote: The alternative small firmware needs a few words of what it can and absolutely cannot do; this adds those words. Signed-off-by: Alexey Kardashevskiy

Re: [PATCH 2/2] coroutine: Revert to constant batch size

2022-05-12 Thread Philippe Mathieu-Daudé via
Hi Hiroki, On Thu, May 12, 2022 at 8:57 AM 成川 弘樹 wrote: > > Thank you for your fix. > > I confirmed that after applying this patch, my intended performance > improvement by 4c41c69e is still kept in our environment. Is that equivalent to a formal Tested-by: Hiroki Narukawa tag? > On 2022/05/11

Re: [PATCH] qapi: make machine type deprecation a warning

2022-05-12 Thread Daniel P . Berrangé
On Thu, May 12, 2022 at 02:24:35PM +0200, Paolo Bonzini wrote: > On 5/12/22 12:46, Markus Armbruster wrote: > > Commit message nitpick: not sure this is "qapi:". The commit that > > introduced "Machine type ... is deprecated" (08fe68244eb) used > > "hw/i386:". We commonly use "vl:", "softmmu:", a

Re: [PATCH v5 10/10] test: tpm-tis: Add Sysbus TPM-TIS device test

2022-05-12 Thread Peter Maydell
On Thu, 5 Mar 2020 at 16:52, Eric Auger wrote: > > The tests themselves are the same as the ISA device ones. > Only the main() changes as the "tpm-tis-device" device gets > instantiated. Also the base address of the device is not > 0xFED4 anymore but matches the base address of the > ARM virt

[PATCH RFC 0/2] arm: enable MTE for QEMU + kvm

2022-05-12 Thread Cornelia Huck
This series enables MTE for kvm guests, if the kernel supports it. Lightly tested while running under the simulator (the arm64/mte/ kselftests pass... if you wait patiently :) A new cpu property "mte" (defaulting to on if possible) is introduced; for tcg, you still need to enable mte at the machin

[PATCH RFC 1/2] arm/kvm: enable MTE if available

2022-05-12 Thread Cornelia Huck
We need to disable migration, as we do not yet have a way to migrate the tags as well. Signed-off-by: Cornelia Huck --- target/arm/cpu.c | 18 -- target/arm/cpu.h | 4 +++ target/arm/cpu64.c | 78 target/arm/kvm64.c | 5 +++ targ

[PATCH RFC 2/2] qtests/arm: add some mte tests

2022-05-12 Thread Cornelia Huck
Signed-off-by: Cornelia Huck --- tests/qtest/arm-cpu-features.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/tests/qtest/arm-cpu-features.c b/tests/qtest/arm-cpu-features.c index 5a145273860c..c0be645b1fb0 100644 --- a/tests/qtest/arm-cpu-features.c +++ b/t

Re: [RFC PATCH qemu] spapr/docs: Add a few words about x-vof

2022-05-12 Thread Daniel Henrique Barboza
On 5/12/22 00:10, Alexey Kardashevskiy wrote: On 5/12/22 06:42, Daniel Henrique Barboza wrote: On 5/6/22 02:51, Alexey Kardashevskiy wrote: The alternative small firmware needs a few words of what it can and absolutely cannot do; this adds those words. Signed-off-by: Alexey Kardashevski

Re: [PATCH v6 00/13] Migration: Transmit and detect zero pages in the multifd threads

2022-05-12 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > In this version: > - document what protects each field in MultiFDRecv/SendParams > - calcule page_size once when we start the migration, and store it in > a field > - Same for page_count. > - rebase to latest > - minor improvements here and there > -

Re: [PULL 2/2] vfio: tolerate migration protocol v1 uapi renames

2022-05-12 Thread Avihai Horon
On 5/12/2022 1:29 PM, Thomas Huth wrote: External email: Use caution opening links or attachments From: Matthew Rosato The v1 uapi is deprecated and will be replaced by v2 at some point; this patch just tolerates the renaming of uapi fields to reflect v1 / deprecated status. Signed-off-by:

Re: [PULL 0/2] Update linux-headers to v5.18-rc6

2022-05-12 Thread Thomas Huth
On 12/05/2022 12.29, Thomas Huth wrote: Hi! The following changes since commit ec11dc41eec5142b4776db1296972c6323ba5847: Merge tag 'pull-misc-2022-05-11' of git://repo.or.cz/qemu/armbru into staging (2022-05-11 09:00:26 -0700) are available in the Git repository at: https://gitlab.co

Re: [PULL 2/2] vfio: tolerate migration protocol v1 uapi renames

2022-05-12 Thread Thomas Huth
On 12/05/2022 15.53, Avihai Horon wrote: On 5/12/2022 1:29 PM, Thomas Huth wrote: External email: Use caution opening links or attachments From: Matthew Rosato The v1 uapi is deprecated and will be replaced by v2 at some point; this patch just tolerates the renaming of uapi fields to reflec

Re: [PATCH] vmxcap: add tertiary execution controls

2022-05-12 Thread Vitaly Kuznetsov
Paolo Bonzini writes: > Signed-off-by: Paolo Bonzini > --- > scripts/kvm/vmxcap | 17 + > 1 file changed, 17 insertions(+) > > diff --git a/scripts/kvm/vmxcap b/scripts/kvm/vmxcap > index f140040104..ce27f5e635 100755 > --- a/scripts/kvm/vmxcap > +++ b/scripts/kvm/vmxcap > @@ -2

Re: [PATCH] qemu-iotests: inline common.config into common.rc

2022-05-12 Thread Kevin Wolf
Am 05.05.2022 um 11:47 hat Paolo Bonzini geschrieben: > common.rc has some complicated logic to find the common.config that > dates back to xfstests and is completely unnecessary now. Just include > the contents of the file. > > Signed-off-by: Paolo Bonzini Thanks, applied to the block branch.

Re: [PATCH v2] docs/about: Update the support statement for Windows

2022-05-12 Thread Thomas Huth
On 12/05/2022 10.37, Daniel P. Berrangé wrote: On Thu, May 12, 2022 at 09:39:29AM +0200, Thomas Huth wrote: Our support statement for Windows currently talks about "Vista / Server 2008" - which is related to the API of Windows, and this is not easy to understand for the non-technical users. Addi

Re: [PATCH v5 3/4] vdpa: add vdpa-dev support

2022-05-12 Thread Stefano Garzarella
On Thu, May 12, 2022 at 02:21:02PM +0800, Longpeng(Mike) wrote: From: Longpeng Supports vdpa-dev, we can use the deivce directly: -M microvm -m 512m -smp 2 -kernel ... -initrd ... -device \ vhost-vdpa-device,vhostdev=/dev/vhost-vdpa-x Signed-off-by: Longpeng --- hw/virtio/Kconfig

  1   2   3   >