Re: [PATCH v5 1/1] virtio: fix the condition for iommu_platform not supported

2022-04-27 Thread Jason Wang
On Wed, Apr 27, 2022 at 8:25 PM Chenyi Qiang wrote: > > > > On 4/22/2022 3:11 PM, Chenyi Qiang wrote: > > > > > > On 2/7/2022 7:28 PM, Halil Pasic wrote: > >> The commit 04ceb61a40 ("virtio: Fail if iommu_platform is requested, but > >> unsupported") claims to fail the device hotplug when iommu_pl

RE: [RFC 00/18] vfio: Adopt iommufd

2022-04-27 Thread Tian, Kevin
> From: Alex Williamson > Sent: Wednesday, April 27, 2022 12:22 AM > > > > > > My expectation would be that libvirt uses: > > > > > > -object iommufd,id=iommufd0,fd=NNN > > > -device vfio-pci,fd=MMM,iommufd=iommufd0 > > > > > > Whereas simple QEMU command line would be: > > > > > > -object iomm

[PATCH qemu v11 03/15] target/riscv: rvv: Early exit when vstart >= vl

2022-04-27 Thread ~eopxd
From: eopXD According to v-spec (section 5.4): When vstart ≥ vl, there are no body elements, and no elements are updated in any destination vector register group, including that no tail elements are updated with agnostic values. vmsbf.m, vmsif.m, vmsof.m, viota.m, vcompress instructions themselv

[PATCH qemu v11 00/15] Add tail agnostic behavior for rvv instructions

2022-04-27 Thread ~eopxd
According to v-spec, tail agnostic behavior can be either kept as undisturbed or set elements' bits to all 1s. To distinguish the difference of tail policies, QEMU should be able to simulate the tail agnostic behavior as "set tail elements' bits to all 1s". An option 'rvv_ta_all_1s' is added to ena

[PATCH qemu v11 02/15] target/riscv: rvv: Rename ambiguous esz

2022-04-27 Thread ~eopxd
From: eopXD No functional change intended in this commit. Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li Reviewed-by: Alistair Francis --- target/riscv/vector_helper.c | 76 ++-- 1 file changed, 38 insertions(+), 38 deletions(-) diff

[PATCH qemu v11 04/15] target/riscv: rvv: Add tail agnostic for vv instructions

2022-04-27 Thread ~eopxd
From: eopXD According to v-spec, tail agnostic behavior can be either kept as undisturbed or set elements' bits to all 1s. To distinguish the difference of tail policies, QEMU should be able to simulate the tail agnostic behavior as "set tail elements' bits to all 1s". There are multiple possibi

[PATCH qemu v11 01/15] target/riscv: rvv: Prune redundant ESZ, DSZ parameter passed

2022-04-27 Thread ~eopxd
From: eopXD No functional change intended in this commit. Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li Reviewed-by: Alistair Francis --- target/riscv/vector_helper.c | 1132 +- 1 file changed, 565 insertions(+), 567 deletions(-) dif

[PATCH qemu v11 14/15] target/riscv: rvv: Add tail agnostic for vector permutation instructions

2022-04-27 Thread ~eopxd
From: eopXD Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li --- target/riscv/insn_trans/trans_rvv.c.inc | 22 ++ target/riscv/vector_helper.c| 40 + 2 files changed, 62 insertions(+) diff --git a/target/riscv/insn_trans/t

[PATCH qemu v11 05/15] target/riscv: rvv: Add tail agnostic for vector load / store instructions

2022-04-27 Thread ~eopxd
From: eopXD Destination register of unit-stride mask load and store instructions are always written with a tail-agnostic policy. Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li --- target/riscv/insn_trans/trans_rvv.c.inc | 11 ++ target/riscv/translate.c

[PATCH qemu v11 10/15] target/riscv: rvv: Add tail agnostic for vector fix-point arithmetic instructions

2022-04-27 Thread ~eopxd
From: eopXD Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li --- target/riscv/vector_helper.c | 220 ++- 1 file changed, 114 insertions(+), 106 deletions(-) diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c index f7

[PATCH qemu v11 07/15] target/riscv: rvv: Add tail agnostic for vector integer shift instructions

2022-04-27 Thread ~eopxd
From: eopXD Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li --- target/riscv/insn_trans/trans_rvv.c.inc | 11 +++ target/riscv/vector_helper.c| 11 +++ 2 files changed, 22 insertions(+) diff --git a/target/riscv/insn_trans/trans_rvv.c.inc b

[PATCH qemu v11 08/15] target/riscv: rvv: Add tail agnostic for vector integer comparison instructions

2022-04-27 Thread ~eopxd
From: eopXD Compares write mask registers, and so always operate under a tail- agnostic policy. Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li --- target/riscv/vector_helper.c | 21 + 1 file changed, 21 insertions(+) diff --git a/target/riscv/vect

[PATCH qemu v11 09/15] target/riscv: rvv: Add tail agnostic for vector integer merge and move instructions

2022-04-27 Thread ~eopxd
From: eopXD Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li --- target/riscv/insn_trans/trans_rvv.c.inc | 44 + target/riscv/vector_helper.c| 20 +++ 2 files changed, 64 insertions(+) diff --git a/target/riscv/insn_trans/tran

[PATCH qemu v11 12/15] target/riscv: rvv: Add tail agnostic for vector reduction instructions

2022-04-27 Thread ~eopxd
From: eopXD Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li --- target/riscv/vector_helper.c | 20 1 file changed, 20 insertions(+) diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c index 21e20d47e5..e0fd0e62b3 100644 --- a/t

[PATCH qemu v11 06/15] target/riscv: rvv: Add tail agnostic for vx, vvm, vxm instructions

2022-04-27 Thread ~eopxd
From: eopXD `vmadc` and `vmsbc` produces a mask value, they always operate with a tail agnostic policy. Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li --- target/riscv/insn_trans/trans_rvv.c.inc | 29 +++ target/riscv/internals.h| 5 +- target/riscv

[PATCH qemu v11 11/15] target/riscv: rvv: Add tail agnostic for vector floating-point instructions

2022-04-27 Thread ~eopxd
From: eopXD Compares write mask registers, and so always operate under a tail- agnostic policy. Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li --- target/riscv/insn_trans/trans_rvv.c.inc | 15 + target/riscv/vector_helper.c| 443 +---

[PATCH qemu v11 13/15] target/riscv: rvv: Add tail agnostic for vector mask instructions

2022-04-27 Thread ~eopxd
From: eopXD The tail elements in the destination mask register are updated under a tail-agnostic policy. Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li --- target/riscv/insn_trans/trans_rvv.c.inc | 6 + target/riscv/vector_helper.c| 30 +++

[PATCH qemu v11 15/15] target/riscv: rvv: Add option 'rvv_ta_all_1s' to enable optional tail agnostic behavior

2022-04-27 Thread ~eopxd
From: eopXD According to v-spec, tail agnostic behavior can be either kept as undisturbed or set elements' bits to all 1s. To distinguish the difference of tail policies, QEMU should be able to simulate the tail agnostic behavior as "set tail elements' bits to all 1s". There are multiple possibi

Re: [RFC PATCH v3 1/5] ppc64: Add semihosting support

2022-04-27 Thread Nicholas Piggin
Excerpts from Nicholas Piggin's message of April 21, 2022 12:04 pm: > Excerpts from Leandro Lupori's message of April 21, 2022 4:09 am: >> On 4/18/22 17:22, Cédric Le Goater wrote: >>> On 4/18/22 21:10, Leandro Lupori wrote: Add semihosting support for PPC64. This implementation is based

Re: [PATCH qemu v11 01/15] target/riscv: rvv: Prune redundant ESZ, DSZ parameter passed

2022-04-27 Thread Weiwei Li
在 2022/3/14 下午3:38, ~eopxd 写道: From: eopXD No functional change intended in this commit. Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li Sorry. My fault. I miss a space when I send Reviewed-by. Maybe you can update this in the next version with other changes. Rev

Re: [PATCH v5 1/1] virtio: fix the condition for iommu_platform not supported

2022-04-27 Thread Michael S. Tsirkin
On Thu, Apr 28, 2022 at 11:01:10AM +0800, Jason Wang wrote: > On Wed, Apr 27, 2022 at 8:25 PM Chenyi Qiang wrote: > > > > > > > > On 4/22/2022 3:11 PM, Chenyi Qiang wrote: > > > > > > > > > On 2/7/2022 7:28 PM, Halil Pasic wrote: > > >> The commit 04ceb61a40 ("virtio: Fail if iommu_platform is req

Re: [PATCH qemu] spapr_pci: Disable IRQFD resampling on XIVE

2022-04-27 Thread Alexey Kardashevskiy
On 4/27/22 17:36, Cédric Le Goater wrote: Hello Alexey, On 4/27/22 06:36, Alexey Kardashevskiy wrote: VFIO-PCI has an "KVM_IRQFD_FLAG_RESAMPLE" optimization for INTx EOI handling when KVM can unmask PCI INTx (level triggered interrupt) without switching to the userspace (==QEMU). Unfortunat

Re: serial hang in qemu-system-ppc64 -M pseries

2022-04-27 Thread Rob Landley
On 4/27/22 10:27, Thomas Huth wrote: > On 26/04/2022 12.26, Rob Landley wrote: >> When I cut and paste 80-ish characters of text into the Linux serial >> console, it >> reads 16 characters and stops. When I hit space, it reads another 16 >> characters, >> and if I keep at it will eventually catch

Re: [PATCH v5 1/1] virtio: fix the condition for iommu_platform not supported

2022-04-27 Thread Jason Wang
On Thu, Apr 28, 2022 at 12:57 PM Michael S. Tsirkin wrote: > > On Thu, Apr 28, 2022 at 11:01:10AM +0800, Jason Wang wrote: > > On Wed, Apr 27, 2022 at 8:25 PM Chenyi Qiang wrote: > > > > > > > > > > > > On 4/22/2022 3:11 PM, Chenyi Qiang wrote: > > > > > > > > > > > > On 2/7/2022 7:28 PM, Halil P

Re: [PATCH v5 1/1] virtio: fix the condition for iommu_platform not supported

2022-04-27 Thread Michael S. Tsirkin
On Thu, Apr 28, 2022 at 01:52:46PM +0800, Jason Wang wrote: > On Thu, Apr 28, 2022 at 12:57 PM Michael S. Tsirkin wrote: > > > > On Thu, Apr 28, 2022 at 11:01:10AM +0800, Jason Wang wrote: > > > On Wed, Apr 27, 2022 at 8:25 PM Chenyi Qiang > > > wrote: > > > > > > > > > > > > > > > > On 4/22/202

Re: serial hang in qemu-system-ppc64 -M pseries

2022-04-27 Thread Rob Landley
On 4/28/22 00:41, Rob Landley wrote: > On 4/27/22 10:27, Thomas Huth wrote: >> On 26/04/2022 12.26, Rob Landley wrote: >>> When I cut and paste 80-ish characters of text into the Linux serial >>> console, it >>> reads 16 characters and stops. When I hit space, it reads another 16 >>> character

Re: [PATCH qemu] spapr_pci: Disable IRQFD resampling on XIVE

2022-04-27 Thread Cédric Le Goater
On 4/28/22 07:32, Alexey Kardashevskiy wrote: On 4/27/22 17:36, Cédric Le Goater wrote: Hello Alexey, On 4/27/22 06:36, Alexey Kardashevskiy wrote: VFIO-PCI has an "KVM_IRQFD_FLAG_RESAMPLE" optimization for INTx EOI handling when KVM can unmask PCI INTx (level triggered interrupt) without sw

Re: [PATCH v2] WHPX: support for xcr0

2022-04-27 Thread Paolo Bonzini
Queued, thanks. (It only took 30 months; thanks to Ivan Shcherbakov for bringing it to my attention). Paolo

[PATCH qemu v12 02/15] target/riscv: rvv: Rename ambiguous esz

2022-04-27 Thread ~eopxd
From: eopXD No functional change intended in this commit. Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li Reviewed-by: Alistair Francis --- target/riscv/vector_helper.c | 76 ++-- 1 file changed, 38 insertions(+), 38 deletions(-) diff

[PATCH qemu v12 03/15] target/riscv: rvv: Early exit when vstart >= vl

2022-04-27 Thread ~eopxd
From: eopXD According to v-spec (section 5.4): When vstart ≥ vl, there are no body elements, and no elements are updated in any destination vector register group, including that no tail elements are updated with agnostic values. vmsbf.m, vmsif.m, vmsof.m, viota.m, vcompress instructions themselv

[PATCH qemu v12 08/15] target/riscv: rvv: Add tail agnostic for vector integer comparison instructions

2022-04-27 Thread ~eopxd
From: eopXD Compares write mask registers, and so always operate under a tail- agnostic policy. Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li --- target/riscv/vector_helper.c | 21 + 1 file changed, 21 insertions(+) diff --git a/target/riscv/vec

[PATCH qemu v12 00/15] Add tail agnostic behavior for rvv instructions

2022-04-27 Thread ~eopxd
According to v-spec, tail agnostic behavior can be either kept as undisturbed or set elements' bits to all 1s. To distinguish the difference of tail policies, QEMU should be able to simulate the tail agnostic behavior as "set tail elements' bits to all 1s". An option 'rvv_ta_all_1s' is added to ena

[PATCH qemu v12 07/15] target/riscv: rvv: Add tail agnostic for vector integer shift instructions

2022-04-27 Thread ~eopxd
From: eopXD Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li --- target/riscv/insn_trans/trans_rvv.c.inc | 11 +++ target/riscv/vector_helper.c| 11 +++ 2 files changed, 22 insertions(+) diff --git a/target/riscv/insn_trans/trans_rvv.c.inc

[PATCH qemu v12 15/15] target/riscv: rvv: Add option 'rvv_ta_all_1s' to enable optional tail agnostic behavior

2022-04-27 Thread ~eopxd
From: eopXD According to v-spec, tail agnostic behavior can be either kept as undisturbed or set elements' bits to all 1s. To distinguish the difference of tail policies, QEMU should be able to simulate the tail agnostic behavior as "set tail elements' bits to all 1s". There are multiple possibi

[PATCH qemu v12 04/15] target/riscv: rvv: Add tail agnostic for vv instructions

2022-04-27 Thread ~eopxd
From: eopXD According to v-spec, tail agnostic behavior can be either kept as undisturbed or set elements' bits to all 1s. To distinguish the difference of tail policies, QEMU should be able to simulate the tail agnostic behavior as "set tail elements' bits to all 1s". There are multiple possibi

[PATCH qemu v12 10/15] target/riscv: rvv: Add tail agnostic for vector fix-point arithmetic instructions

2022-04-27 Thread ~eopxd
From: eopXD Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li --- target/riscv/vector_helper.c | 220 ++- 1 file changed, 114 insertions(+), 106 deletions(-) diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c index f

[PATCH qemu v12 05/15] target/riscv: rvv: Add tail agnostic for vector load / store instructions

2022-04-27 Thread ~eopxd
From: eopXD Destination register of unit-stride mask load and store instructions are always written with a tail-agnostic policy. Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li --- target/riscv/insn_trans/trans_rvv.c.inc | 11 ++ target/riscv/translate.c

[PATCH qemu v12 11/15] target/riscv: rvv: Add tail agnostic for vector floating-point instructions

2022-04-27 Thread ~eopxd
From: eopXD Compares write mask registers, and so always operate under a tail- agnostic policy. Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li --- target/riscv/insn_trans/trans_rvv.c.inc | 15 + target/riscv/vector_helper.c| 443 +---

[PATCH qemu v12 09/15] target/riscv: rvv: Add tail agnostic for vector integer merge and move instructions

2022-04-27 Thread ~eopxd
From: eopXD Signed-off-by: eop Chen Reviewed-by: Frank Chang Reviewed-by: Weiwei Li --- target/riscv/insn_trans/trans_rvv.c.inc | 44 + target/riscv/vector_helper.c| 20 +++ 2 files changed, 64 insertions(+) diff --git a/target/riscv/insn_trans/tra

Re: [PATCH v2 01/42] i386: pcmpestr 64-bit sign extension bug

2022-04-27 Thread Paolo Bonzini
On 4/25/22 00:01, Paul Brook wrote: The abs1 function in ops_sse.h only works sorrectly when the result fits in a signed int. This is fine most of the time because we're only dealing with byte sized values. However pcmp_elen helper function uses abs1 to calculate the absolute value of a cpu regi

Re: [RFC PATCH 0/7] VSX MMA Implementation

2022-04-27 Thread Cédric Le Goater
Hello, On 4/27/22 08:21, Joel Stanley wrote: On Tue, 26 Apr 2022 at 12:51, Lucas Mateus Castro(alqotel) wrote: From: "Lucas Mateus Castro (alqotel)" This patch series is an RFC of the Matrix-Multiply Assist (MMA) instructions implementation from the PowerISA 3.1 These and the VDIV/VMOD imp

Re: [PATCH 2/2] acpi/nvdimm: Fix aml_or() and aml_and() in if clause

2022-04-27 Thread Igor Mammedov
On Tue, 12 Apr 2022 14:57:53 +0800 Robert Hoo wrote: > It should be some typo originally, where in If condition, using bitwise > and/or, rather than logical and/or. > > The resulting change in AML code: > > If (((Local6 == Zero) | (Arg0 != Local0))) > ==> > If (((Local6 == Zero) || (Arg0 != L

Re: [PATCH qemu] spapr_pci: Disable IRQFD resampling on XIVE

2022-04-27 Thread Cédric Le Goater
Hello Alexey, On 4/27/22 06:36, Alexey Kardashevskiy wrote: VFIO-PCI has an "KVM_IRQFD_FLAG_RESAMPLE" optimization for INTx EOI handling when KVM can unmask PCI INTx (level triggered interrupt) without switching to the userspace (==QEMU). Unfortunately XIVE does not support level interrupts,

Re: [PATCH v2 01/26] Use QEMU_SANITIZE_THREAD

2022-04-27 Thread Marc-André Lureau
Hi On Wed, Apr 27, 2022 at 12:43 AM Richard Henderson wrote: > > On 4/26/22 02:26, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Signed-off-by: Marc-André Lureau > > Reviewed-by: Daniel P. Berrangé > > --- > > include/qemu/atomic.h| 8 +---

Re: [PATCH v2 12/26] qga: replace pipe() with g_unix_open_pipe(CLOEXEC)

2022-04-27 Thread Marc-André Lureau
Hi On Wed, Apr 27, 2022 at 5:08 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 4/26/22 02:27, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Suggested-by: Daniel P. Berrangé > > Signed-off-by: Marc-André Lureau > > --- > > qga/commands-posix.c | 2 +-

Re: [PATCH 0/7] vhost-vdpa multiqueue fixes

2022-04-27 Thread Si-Wei Liu
On 4/26/2022 9:28 PM, Jason Wang wrote: 在 2022/3/30 14:33, Si-Wei Liu 写道: Hi, This patch series attempt to fix a few issues in vhost-vdpa multiqueue functionality. Patch #1 is the formal submission for RFC patch in: https://urldefense.com/v3/__https://lore.kernel.org/qemu-devel/c3e931ee-

[PATCH v2 0/5] vhost-vdpa multiqueue fixes

2022-04-27 Thread Si-Wei Liu
Hi, This patch series attempt to fix a few issues in vhost-vdpa multiqueue functionality. Patch #1 and #2 are the formal submission for RFC patch in: https://lore.kernel.org/qemu-devel/c3e931ee-1a1b-9c2f-2f59-cb4395c23...@oracle.com/ Patch #3 through #5 are obviously small bug fixes. Please fin

[PATCH v2 1/5] virtio-net: setup vhost_dev and notifiers for cvq only when feature is negotiated

2022-04-27 Thread Si-Wei Liu
When the control virtqueue feature is absent or not negotiated, vhost_net_start() still tries to set up vhost_dev and install vhost notifiers for the control virtqueue, which results in erroneous ioctl calls with incorrect queue index sending down to driver. Do that only when needed. Fixes: 22288f

[PATCH v2 2/5] virtio-net: align ctrl_vq index for non-mq guest for vhost_vdpa

2022-04-27 Thread Si-Wei Liu
With MQ enabled vdpa device and non-MQ supporting guest e.g. booting vdpa with mq=on over OVMF of single vqp, below assert failure is seen: ../hw/virtio/vhost-vdpa.c:560: vhost_vdpa_get_vq_index: Assertion `idx >= dev->vq_index && idx < dev->vq_index + dev->nvqs' failed. 0 0x7f8ce3ff3387 in

[PATCH v2 5/5] vhost-vdpa: backend feature should set only once

2022-04-27 Thread Si-Wei Liu
The vhost_vdpa_one_time_request() branch in vhost_vdpa_set_backend_cap() incorrectly sends down ioctls on vhost_dev with non-zero index. This may end up with multiple VHOST_SET_BACKEND_FEATURES ioctl calls sent down on the vhost-vdpa fd that is shared between all these vhost_dev's. To fix it, send

[PATCH v2 4/5] vhost-net: fix improper cleanup in vhost_net_start

2022-04-27 Thread Si-Wei Liu
vhost_net_start() missed a corresponding stop_one() upon error from vhost_set_vring_enable(). While at it, make the error handling for err_start more robust. No real issue was found due to this though. Signed-off-by: Si-Wei Liu Acked-by: Jason Wang --- hw/net/vhost_net.c | 4 +++- 1 file change

[PATCH v2 3/5] vhost-vdpa: fix improper cleanup in net_init_vhost_vdpa

2022-04-27 Thread Si-Wei Liu
... such that no memory leaks on dangling net clients in case of error. Signed-off-by: Si-Wei Liu Acked-by: Jason Wang --- net/vhost-vdpa.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index 1e9fe47..df1e69e 100644 --- a/net/vhost-vd

Re: [PATCH 0/7] vhost-vdpa multiqueue fixes

2022-04-27 Thread Jason Wang
On Wed, Apr 27, 2022 at 4:30 PM Si-Wei Liu wrote: > > > > On 4/26/2022 9:28 PM, Jason Wang wrote: > > > > 在 2022/3/30 14:33, Si-Wei Liu 写道: > >> Hi, > >> > >> This patch series attempt to fix a few issues in vhost-vdpa > >> multiqueue functionality. > >> > >> Patch #1 is the formal submission for

Re: [PATCH] 9pfs: local: Do not follow symlink in _nofollow

2022-04-27 Thread Christian Schoenebeck
On Mittwoch, 27. April 2022 04:45:45 CEST Akihiko Odaki wrote: > Signed-off-by: Akihiko Odaki > --- > hw/9pfs/9p-local.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/9pfs/9p-local.c b/hw/9pfs/9p-local.c > index d42ce6d8b82..def8afdb4d6 100644 > --- a/hw/9pfs/9p-loc

Re: [PATCH v10 7/7] multifd: Implement zero copy write in multifd migration (multifd-zero-copy)

2022-04-27 Thread Daniel P . Berrangé
On Tue, Apr 26, 2022 at 08:06:56PM -0300, Leonardo Bras wrote: > Implement zero copy send on nocomp_send_write(), by making use of QIOChannel > writev + flags & flush interface. > > Change multifd_send_sync_main() so flush_zero_copy() can be called > after each iteration in order to make sure all

Re: [PATCH] hw/crypto: add Allwinner sun4i-ss crypto device

2022-04-27 Thread Daniel P . Berrangé
On Wed, Apr 27, 2022 at 10:34:24AM +0200, LABBE Corentin wrote: > Le Mon, Apr 25, 2022 at 03:29:32PM +0100, Daniel P. Berrangé a écrit : > > On Mon, Apr 25, 2022 at 03:03:11PM +0200, LABBE Corentin wrote: > > > diff --git a/crypto/hash-nettle.c b/crypto/hash-nettle.c > > > index 1ca1a41062..b9342b4

Re: [PATCH] hw/crypto: add Allwinner sun4i-ss crypto device

2022-04-27 Thread LABBE Corentin
Le Mon, Apr 25, 2022 at 03:29:32PM +0100, Daniel P. Berrangé a écrit : > On Mon, Apr 25, 2022 at 03:03:11PM +0200, LABBE Corentin wrote: > > diff --git a/crypto/hash-nettle.c b/crypto/hash-nettle.c > > index 1ca1a41062..b9342b4fe1 100644 > > --- a/crypto/hash-nettle.c > > +++ b/crypto/hash-nettle.c

Re: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition support form COLO to PRELAUNCH

2022-04-27 Thread Jason Wang
On Fri, Apr 1, 2022 at 11:59 AM Zhang Chen wrote: > > If the checkpoint occurs when the guest finishes restarting > but has not started running, the runstate_set() may reject > the transition from COLO to PRELAUNCH with the crash log: > > {"timestamp": {"seconds": 1593484591, "microseconds": 26605

Re: [PATCH v10 6/7] multifd: Send header packet without flags if zero-copy-send is enabled

2022-04-27 Thread Daniel P . Berrangé
On Tue, Apr 26, 2022 at 08:06:55PM -0300, Leonardo Bras wrote: > Since d48c3a0445 ("multifd: Use a single writev on the send side"), > sending the header packet and the memory pages happens in the same > writev, which can potentially make the migration faster. > > Using channel-socket as example,

RE: Backtrace stopped: previous frame identical to this frame (corrupt stack?) , even with fresh qemu and linux build

2022-04-27 Thread Chan Kim
Hi, all I just found that when the linux kernel saves the current x29 and x30 at the new stack bottom, (it usually does that when entering a function) The stored x30 value (lr register) has it top 16bits altered to some strange value. So if I fix those top 16bits to 0x in the stack, and

[PATCH v2] target/arm: Disable cryptographic instructions when neon is disabled

2022-04-27 Thread Damien Hedde
As of now, cryptographic instructions ISAR fields are never cleared so we can end up with a cpu with cryptographic instructions but no floating-point/neon instructions which is not a possible configuration according to ARM specifications. In QEMU, we have 3 kinds of cpus regarding cryptographic in

Re: [PATCH 0/7] vhost-vdpa multiqueue fixes

2022-04-27 Thread Si-Wei Liu
On 4/27/2022 1:38 AM, Jason Wang wrote: On Wed, Apr 27, 2022 at 4:30 PM Si-Wei Liu wrote: On 4/26/2022 9:28 PM, Jason Wang wrote: 在 2022/3/30 14:33, Si-Wei Liu 写道: Hi, This patch series attempt to fix a few issues in vhost-vdpa multiqueue functionality. Patch #1 is the formal submissio

Re: [PATCH v2 07/42] Enforce VEX encoding restrictions

2022-04-27 Thread Paolo Bonzini
On 4/25/22 00:01, Paul Brook wrote: +/* If a VEX prefix is used then it must have V=b */ +#define CHECK_AVX_V0(s) do { \ +CHECK_AVX(s); \ +if ((s->prefix & PREFIX_VEX) && (s->vex_v != 0)) \ +goto illegal_op; \ +} while (0) + What do you think about #define CHECK_AVX(s,

Re: [PATCH 1/8] qmp: Support for querying stats

2022-04-27 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > From: Mark Kanda > > Introduce QMP support for querying stats. Provide a framework for adding new > stats and support for the following commands: > > - query-stats > Returns a list of all stats per target type (only VM and vCPU to start), with > add

Re: [PATCH v2 17/26] Replace fcntl(0_NONBLOCK) with g_unix_set_fd_nonblocking()

2022-04-27 Thread Marc-André Lureau
Hi On Wed, Apr 27, 2022 at 5:15 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 4/26/22 02:27, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Suggested-by: Daniel P. Berrangé > > Signed-off-by: Marc-André Lureau > > --- > > net/tap-bsd.c

RE: Backtrace stopped: previous frame identical to this frame (corrupt stack?) , even with fresh qemu and linux build

2022-04-27 Thread Chan Kim
Hi folks, Sorry for many emails. I just found out by turning CONFIG_ARM64_PTR_AUTH off in armv8.3 when building linux, I can avoid this problem. (I noticed the instruction ‘pacia’ in the function assembly code) Thank you. Chan Kim From: Chan Kim Sent: Wednesday, April 27, 2022 6:05 PM T

RE: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition support form COLO to PRELAUNCH

2022-04-27 Thread Zhang, Chen
> -Original Message- > From: Jason Wang > Sent: Wednesday, April 27, 2022 4:57 PM > To: Zhang, Chen > Cc: Li Zhijian ; qemu-dev de...@nongnu.org>; Like Xu > Subject: Re: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition > support form COLO to PRELAUNCH > > On Fri, Apr 1, 2022

<    1   2   3