Re: [PULL 0/6] Kraxel 20220425 patches

2022-04-26 Thread Gerd Hoffmann
On Mon, Apr 25, 2022 at 10:21:00AM -0700, Richard Henderson wrote: > On 4/24/22 23:10, Gerd Hoffmann wrote: > > The following changes since commit a74782936dc6e979ce371dabda4b1c05624ea87f: > > > >Merge tag 'pull-migration-20220421a' of https://gitlab.com/dagrh/qemu > > into staging (2022-04-2

Re: [PATCH v2] error-report: fix g_date_time_format assertion

2022-04-26 Thread Paolo Bonzini
Queued, thanks. Paolo

Re: [qemu.qmp PATCH 04/12] update project URLs

2022-04-26 Thread Daniel P . Berrangé
On Mon, Apr 25, 2022 at 02:19:27PM -0400, John Snow wrote: > On Mon, Apr 25, 2022, 6:56 AM Daniel P. Berrangé > wrote: > > > On Fri, Apr 22, 2022 at 02:49:32PM -0400, John Snow wrote: > > > Point to this library's URLs instead of the entire project's. > > > > > > Signed-off-by: John Snow > > > -

Re: [PULL 0/6] Kraxel 20220425 patches

2022-04-26 Thread Thomas Huth
On 26/04/2022 09.15, Gerd Hoffmann wrote: On Mon, Apr 25, 2022 at 10:21:00AM -0700, Richard Henderson wrote: On 4/24/22 23:10, Gerd Hoffmann wrote: The following changes since commit a74782936dc6e979ce371dabda4b1c05624ea87f: Merge tag 'pull-migration-20220421a' of https://gitlab.com/dagrh/

Re: [PULL 0/6] Kraxel 20220425 patches

2022-04-26 Thread Daniel P . Berrangé
On Tue, Apr 26, 2022 at 09:15:50AM +0200, Gerd Hoffmann wrote: > On Mon, Apr 25, 2022 at 10:21:00AM -0700, Richard Henderson wrote: > > On 4/24/22 23:10, Gerd Hoffmann wrote: > > > The following changes since commit > > > a74782936dc6e979ce371dabda4b1c05624ea87f: > > > > > >Merge tag 'pull-mi

Re: [PATCH v9 5/7] multifd: multifd_send_sync_main now returns negative on error

2022-04-26 Thread Daniel P . Berrangé
On Mon, Apr 25, 2022 at 06:50:54PM -0300, Leonardo Bras wrote: > Even though multifd_send_sync_main() currently emits error_reports, it's > callers don't really check it before continuing. > > Change multifd_send_sync_main() to return -1 on error and 0 on success. > Also change all it's callers to

Re: [PATCH v9 6/7] multifd: Send header packet without flags if zero-copy-send is enabled

2022-04-26 Thread Daniel P . Berrangé
On Mon, Apr 25, 2022 at 06:50:55PM -0300, Leonardo Bras wrote: > Since d48c3a0445 ("multifd: Use a single writev on the send side"), > sending the header packet and the memory pages happens in the same > writev, which can potentially make the migration faster. > > Using channel-socket as example,

Re: [qemu.qmp PATCH 04/12] update project URLs

2022-04-26 Thread Kashyap Chamarthy
On Tue, Apr 26, 2022 at 08:55:38AM +0100, Daniel P. Berrangé wrote: > On Mon, Apr 25, 2022 at 02:19:27PM -0400, John Snow wrote: > > On Mon, Apr 25, 2022, 6:56 AM Daniel P. Berrangé > > wrote: > > > > > On Fri, Apr 22, 2022 at 02:49:32PM -0400, John Snow wrote: > > > > Point to this library's URL

RE: [RFC 00/18] vfio: Adopt iommufd

2022-04-26 Thread Tian, Kevin
> From: Alex Williamson > Sent: Monday, April 25, 2022 10:38 PM > > On Mon, 25 Apr 2022 11:10:14 +0100 > Daniel P. Berrangé wrote: > > > On Fri, Apr 22, 2022 at 04:09:43PM -0600, Alex Williamson wrote: > > > [Cc +libvirt folks] > > > > > > On Thu, 14 Apr 2022 03:46:52 -0700 > > > Yi Liu wrote:

RE: [RFC 00/18] vfio: Adopt iommufd

2022-04-26 Thread Tian, Kevin
> From: Eric Auger > Sent: Tuesday, April 26, 2022 3:55 AM > > Hi Kevin, > > On 4/18/22 10:49 AM, Tian, Kevin wrote: > >> From: Liu, Yi L > >> Sent: Thursday, April 14, 2022 6:47 PM > >> > >> This series qomifies the VFIOContainer object which acts as a base class > > what does 'qomify' mean? I

Re: [PATCH qemu 1/9] target/riscv: rvv: Add mask agnostic for vv instructions

2022-04-26 Thread Weiwei Li
在 2022/3/17 下午3:26, ~eopxd 写道: From: Yueh-Ting (eop) Chen This is the first commit regarding the mask agnostic behavior. Added option 'rvv_ma_all_1s' to enable the behavior, the option is default to false. Signed-off-by: eop Chen Reviewed-by: Frank Chang --- target/riscv/cpu.c

[RFC PATCH v2 7/8] graph-lock: implement WITH_GRAPH_RDLOCK_GUARD and GRAPH_RDLOCK_GUARD macros

2022-04-26 Thread Emanuele Giuseppe Esposito
Similar to the implementation in lockable.h, implement macros to automatically take and release the rdlock. Create the empty GraphLockable struct only to use it as a type for G_DEFINE_AUTOPTR_CLEANUP_FUNC. Signed-off-by: Emanuele Giuseppe Esposito --- include/block/graph-lock.h | 30

[RFC PATCH v2 2/8] coroutine-lock: release lock when restarting all coroutines

2022-04-26 Thread Emanuele Giuseppe Esposito
Current implementation of qemu_co_queue_do_restart does not releases the lock before calling aio_co_wake. Most of the time this is fine, but if the coroutine acquires the lock again then we have a deadlock. Instead of duplicating code, use qemu_co_enter_next_impl, since it implements exactly the s

[RFC PATCH v2 1/8] aio_wait_kick: add missing memory barrier

2022-04-26 Thread Emanuele Giuseppe Esposito
It seems that aio_wait_kick always required a memory barrier or atomic operation in the caller, but almost nobody actually took care of doing it. Let's put the barrier in the function instead. Signed-off-by: Emanuele Giuseppe Esposito --- util/aio-wait.c | 3 ++- 1 file changed, 2 insertions(+)

[RFC PATCH v2 6/8] block: assert that graph read and writes are performed correctly

2022-04-26 Thread Emanuele Giuseppe Esposito
Remove the old assert_bdrv_graph_writable, and replace it with the new version using graph-lock API. See the function documentation for more information. Signed-off-by: Emanuele Giuseppe Esposito --- block.c| 8 block/graph-lock.c | 1

[RFC PATCH v2 0/8] Removal of AioContext lock, bs->parents and ->children: new rwlock

2022-04-26 Thread Emanuele Giuseppe Esposito
This is a new attempt to replace the need to take the AioContext lock to protect graph modifications. In particular, we aim to remove (or better, substitute) the AioContext around bdrv_replace_child_noperm, since this function changes BlockDriverState's ->parents and ->children lists. In the previ

[RFC PATCH v2 4/8] async: register/unregister aiocontext in graph lock list

2022-04-26 Thread Emanuele Giuseppe Esposito
Add/remove the AioContext in aio_context_list in graph-lock.c only when it is being effectively created/destroyed. Signed-off-by: Emanuele Giuseppe Esposito --- util/async.c | 4 util/meson.build | 1 + 2 files changed, 5 insertions(+) diff --git a/util/async.c b/util/async.c index 2ea

[RFC PATCH v2 3/8] block: introduce a lock to protect graph operations

2022-04-26 Thread Emanuele Giuseppe Esposito
block layer graph operations are always run under BQL in the main loop. This is proved by the assertion qemu_in_main_thread() and its wrapper macro GLOBAL_STATE_CODE. However, there are also concurrent coroutines running in other iothreads that always try to traverse the graph. Currently this is pr

Re: [PATCH 01/18] hw/audio: Remove -soundhw support

2022-04-26 Thread Stefan Hajnoczi
On Mon, Apr 25, 2022 at 10:21:44AM +0200, Martin Kletzander wrote: > One thing I am not sure about is whether to keep the aliases of ac97 and > es1370 in the qdev_alias_table. > > Signed-off-by: Martin Kletzander > --- > docs/about/deprecated.rst | 9 - > docs/about/removed

[RFC PATCH v2 5/8] block.c: wrlock in bdrv_replace_child_noperm

2022-04-26 Thread Emanuele Giuseppe Esposito
The only problem here is ->attach and ->detach callbacks could call bdrv_{un}apply_subtree_drain(), which itself will use a rdlock to navigate through all nodes. To avoid deadlocks, take the lock only outside the drains, and if we need to both attach and detach, do it in a single critical section.

[RFC PATCH v2 8/8] mirror: protect drains in coroutine with rdlock

2022-04-26 Thread Emanuele Giuseppe Esposito
Drain performed in coroutine schedules a bh in the main loop. However, drain itself still is a read, and we need to signal the writer that we are going through the graph. Signed-off-by: Emanuele Giuseppe Esposito --- block/mirror.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/block/

Re: [PATCH 00/18] RFC: Remove deprecated audio features

2022-04-26 Thread Stefan Hajnoczi
On Mon, Apr 25, 2022 at 10:21:43AM +0200, Martin Kletzander wrote: > I wanted to deal with https://bugzilla.redhat.com/2043498 and I got a > suggesstion that removing deprecated features could actually make it > easier to propagate the error. In the end (last patch) it turns out the > error is sti

Re: [PATCH v2 25/43] target/loongarch: Add LoongArch CSR instruction

2022-04-26 Thread yangxiaojuan
Hi, Richard On 2022/4/26 上午6:55, Richard Henderson wrote: On 4/25/22 02:10, Xiaojuan Yang wrote: +static void output_r_csr(DisasContext *ctx, arg_r_csr *a, + const char *mnemonic) +{ +    output(ctx, mnemonic, "r%d, %d # %s", a->rd, a->csr, csr_names[a->csr]); +} + +st

[PATCH v2 00/26] Misc cleanups

2022-04-26 Thread marcandre . lureau
From: Marc-André Lureau Hi, v2: - add patches to replace pipe() with g_unix_open_pipe() - add patch "Replace fcntl(0_NONBLOCK) with g_unix_set_fd_nonblocking()" - add patches to cleanup qemu_*block() usage (see "util: rename qemu_*block() socket functions" commit message) - fix lost braces dur

[PATCH v2 01/26] Use QEMU_SANITIZE_THREAD

2022-04-26 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- include/qemu/atomic.h| 8 +--- subprojects/libvhost-user/include/compiler.h | 1 + 2 files changed, 6 insertions(+), 3 deletions(-) create mode 12 subprojects/libvhost-

[PATCH v2 02/26] Use QEMU_SANITIZE_ADDRESS

2022-04-26 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- tests/qtest/fdc-test.c| 2 +- util/coroutine-ucontext.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qtest/fdc-test.c b/tests/qtest/fdc-test.c index 4aa72f36431f..0b3c2c0d523f 100644 --- a/tests/qte

[PATCH v2 04/26] util/win32: simplify qemu_get_local_state_dir()

2022-04-26 Thread marcandre . lureau
From: Marc-André Lureau SHGetFolderPath() is a deprecated API: https://docs.microsoft.com/en-us/windows/win32/api/shlobj_core/nf-shlobj_core-shgetfolderpatha It is a wrapper for SHGetKnownFolderPath() and CSIDL_COMMON_PATH is mapped to FOLDERID_ProgramData: https://docs.microsoft.com/en-us/windo

[PATCH v2 03/26] include: move qemu_*_exec_dir() to cutils

2022-04-26 Thread marcandre . lureau
From: Marc-André Lureau The function is required by get_relocated_path() (already in cutils), and used by qemu-ga and may be generally useful. Signed-off-by: Marc-André Lureau --- include/qemu/cutils.h| 7 ++ include/qemu/osdep.h | 8 -- qemu-io.c

[PATCH v2 06/26] libqtest: split QMP part in libqmp

2022-04-26 Thread marcandre . lureau
From: Marc-André Lureau This will help moving QAPI/QMP in a common subproject. Signed-off-by: Marc-André Lureau Acked-by: Thomas Huth --- tests/qtest/libqmp.h | 50 +++ tests/qtest/libqtest.h | 29 +--- tests/qtest/libqmp.c | 233 +

[PATCH v2 07/26] tests: make libqmp buildable for win32

2022-04-26 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- tests/qtest/libqmp.h | 2 ++ tests/qtest/libqmp.c | 37 +++-- 2 files changed, 33 insertions(+), 6 deletions(-) diff --git a/tests/qtest/libqmp.h b/tests/qtest/libqmp.h index 94aa97328a17..772f18b73ba

[PATCH v2 08/26] Use g_unix_set_fd_nonblocking()

2022-04-26 Thread marcandre . lureau
From: Marc-André Lureau API available since glib 2.30. It also preserves errno. Signed-off-by: Marc-André Lureau --- hw/misc/ivshmem.c | 2 +- util/event_notifier-posix.c | 6 ++ util/main-loop.c| 2 +- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/hw

[PATCH v2 11/26] util: replace pipe()+cloexec with g_unix_open_pipe()

2022-04-26 Thread marcandre . lureau
From: Marc-André Lureau Suggested-by: Daniel P. Berrangé Signed-off-by: Marc-André Lureau --- util/compatfd.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/util/compatfd.c b/util/compatfd.c index 55b6e0b7fb27..147e39e2c62b 100644 --- a/util/compatfd.c +++ b/util/compa

[PATCH v2 05/26] tests: move libqtest.h back under qtest/

2022-04-26 Thread marcandre . lureau
From: Marc-André Lureau Since commit a2ce7dbd917 ("meson: convert tests/qtest to meson"), libqtest.h is under libqos/ directory, while libqtest.c is still in qtest/. Move back to its original location to avoid mixing with libqos/. Suggested-by: Thomas Huth Signed-off-by: Marc-André Lureau Revi

[PATCH v2 09/26] block: move fcntl_setfl()

2022-04-26 Thread marcandre . lureau
From: Marc-André Lureau It is only used by block/file-posix.c, move it there. Signed-off-by: Marc-André Lureau --- include/sysemu/os-posix.h | 2 -- block/file-posix.c| 15 +++ util/oslib-posix.c| 15 --- 3 files changed, 15 insertions(+), 17 deletions(

[PATCH v2 17/26] Replace fcntl(0_NONBLOCK) with g_unix_set_fd_nonblocking()

2022-04-26 Thread marcandre . lureau
From: Marc-André Lureau Suggested-by: Daniel P. Berrangé Signed-off-by: Marc-André Lureau --- net/tap-bsd.c | 4 ++-- net/tap-linux.c| 2 +- net/tap-solaris.c | 2 +- tests/qtest/fuzz/virtio_net_fuzz.c | 2 +- tests/unit/test-iov.c

[PATCH v2 13/26] tests: replace pipe() with g_unix_open_pipe(CLOEXEC)

2022-04-26 Thread marcandre . lureau
From: Marc-André Lureau Suggested-by: Daniel P. Berrangé Signed-off-by: Marc-André Lureau --- tests/qtest/ivshmem-test.c| 5 +++-- tests/unit/test-io-channel-file.c | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/qtest/ivshmem-test.c b/tests/qtest/ivshmem-t

[PATCH v2 10/26] Replace qemu_pipe() with g_unix_open_pipe()

2022-04-26 Thread marcandre . lureau
From: Marc-André Lureau GLib g_unix_open_pipe() is essentially like qemu_pipe(), available since 2.30. Signed-off-by: Marc-André Lureau --- include/qemu/osdep.h| 4 qemu-nbd.c | 5 +++-- util/event_notifier-posix.c | 2 +- util/oslib-posix.c | 22 -

[PATCH v2 12/26] qga: replace pipe() with g_unix_open_pipe(CLOEXEC)

2022-04-26 Thread marcandre . lureau
From: Marc-André Lureau Suggested-by: Daniel P. Berrangé Signed-off-by: Marc-André Lureau --- qga/commands-posix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 77f4672ca2c9..094487c2c395 100644 --- a/qga/commands-posix.c

[PATCH v2 20/26] io: replace qemu_set{_non}block()

2022-04-26 Thread marcandre . lureau
From: Marc-André Lureau Those calls are non-socket fd, or are POSIX-specific. Use the dedicated GLib API. (qemu_set_nonblock() is for socket-like) Signed-off-by: Marc-André Lureau --- io/channel-command.c | 16 +--- io/channel-file.c| 13 + 2 files changed, 18 inser

[PATCH v2 19/26] chardev: replace qemu_set_nonblock()

2022-04-26 Thread marcandre . lureau
From: Marc-André Lureau Those calls are either for non-socket fd, or are POSIX-specific. Use the dedicated GLib API. (qemu_set_nonblock() is for socket-like) Signed-off-by: Marc-André Lureau --- chardev/char-fd.c | 4 ++-- chardev/char-pty.c| 5 - chardev/char-serial.c | 5 - c

[PATCH v2 14/26] os-posix: replace pipe()+cloexec with g_unix_open_pipe(CLOEXEC)

2022-04-26 Thread marcandre . lureau
From: Marc-André Lureau Suggested-by: Daniel P. Berrangé Signed-off-by: Marc-André Lureau --- os-posix.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/os-posix.c b/os-posix.c index faf6e6978b9f..52526c2e3f76 100644 --- a/os-posix.c +++ b/os-posix.c @@ -223,7 +223,7 @@ v

[PATCH v2 15/26] virtiofsd: replace pipe() with g_unix_open_pipe(CLOEXEC)

2022-04-26 Thread marcandre . lureau
From: Marc-André Lureau Suggested-by: Daniel P. Berrangé Signed-off-by: Marc-André Lureau --- tools/virtiofsd/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virtiofsd/helper.c b/tools/virtiofsd/helper.c index f8981e5bdf1a..f5f66f292c70 100644 --- a/tools/vir

[PATCH v2 18/26] io: make qio_channel_command_new_pid() static

2022-04-26 Thread marcandre . lureau
From: Marc-André Lureau The function isn't used outside of qio_channel_command_new_spawn(), which is !win32-specific. Signed-off-by: Marc-André Lureau --- include/io/channel-command.h | 25 - io/channel-command.c | 26 ++ 2 files changed,

[PATCH v2 22/26] hw: replace qemu_set_nonblock()

2022-04-26 Thread marcandre . lureau
From: Marc-André Lureau Those calls are non-socket fd, or are POSIX-specific. Use the dedicated GLib API. (qemu_set_nonblock() is for socket-like) Signed-off-by: Marc-André Lureau --- hw/input/virtio-input-host.c | 5 - hw/virtio/vhost-vsock.c | 11 +++ 2 files changed, 11 in

[PATCH v2 21/26] qga: replace qemu_set_nonblock()

2022-04-26 Thread marcandre . lureau
From: Marc-André Lureau The call is POSIX-specific. Use the dedicated GLib API. Signed-off-by: Marc-André Lureau --- qga/commands-posix.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 094487c2c395..78f2f210015d 100644

[PATCH v2 16/26] io: replace pipe() with g_unix_open_pipe(CLOEXEC)

2022-04-26 Thread marcandre . lureau
From: Marc-André Lureau Suggested-by: Daniel P. Berrangé Signed-off-by: Marc-André Lureau --- io/channel-command.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/io/channel-command.c b/io/channel-command.c index 338da73ade56..539685ea8340 100644 --- a/io/channel-comman

[PATCH v2 24/26] net: replace qemu_set_nonblock()

2022-04-26 Thread marcandre . lureau
From: Marc-André Lureau Those calls are POSIX-specific. Use the dedicated GLib API. (qemu_set_nonblock() is for socket-like) Signed-off-by: Marc-André Lureau --- net/tap.c | 33 +++-- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/net/tap.c b/net/ta

[PATCH v2 23/26] ui: replace qemu_set_nonblock()

2022-04-26 Thread marcandre . lureau
From: Marc-André Lureau The call is POSIX-specific. Use the dedicated GLib API. Signed-off-by: Marc-André Lureau --- ui/input-linux.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ui/input-linux.c b/ui/input-linux.c index 05c0c988199a..e572a2e905b9 100644 --- a/ui/inp

[PATCH v2 25/26] tests: replace qemu_set_nonblock()

2022-04-26 Thread marcandre . lureau
From: Marc-André Lureau The call is POSIX-specific. Use the dedicated GLib API. Signed-off-by: Marc-André Lureau --- tests/qtest/vhost-user-test.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/qtest/vhost-user-test.c b/tests/qtest/vhost-user-test.c index ee30f547

[PATCH v2 26/26] util: rename qemu_*block() socket functions

2022-04-26 Thread marcandre . lureau
From: Marc-André Lureau The qemu_*block() functions are meant to be be used with sockets (the win32 implementation expects SOCKET) Over time, those functions where used with Win32 SOCKET or file-descriptors interchangeably. But for portability, they must only be used with socket-like file-descri

Re: [PATCH v3 35/60] target/arm: Handle cpreg registration for missing EL

2022-04-26 Thread Peter Maydell
On Fri, 22 Apr 2022 at 11:57, Peter Maydell wrote: > Just because > the architecture usually defines that an _EL2 register is > RES0 if EL2 is not present doesn't mean that it does so for > every register or that it guarantees that it will continue > to do so in future. (For instance I found ZCR_E

Re: [PATCH v8 45/68] target/nios2: Split out helpers for gen_i_math_logic

2022-04-26 Thread Peter Maydell
On Fri, 22 Apr 2022 at 18:34, Richard Henderson wrote: > > Do as little work as possible within the macro. > Split out helper functions and pass in arguments instead. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v8 44/68] target/nios2: Split out helpers for gen_i_cmpxx

2022-04-26 Thread Peter Maydell
On Fri, 22 Apr 2022 at 18:29, Richard Henderson wrote: > > Do as little work as possible within the macro. > Split out helper functions and pass in arguments instead. > > Signed-off-by: Richard Henderson > --- > target/nios2/translate.c | 34 +++--- > 1 file changed,

Re: [PATCH v2 07/26] tests: make libqmp buildable for win32

2022-04-26 Thread Thomas Huth
On 26/04/2022 11.26, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- tests/qtest/libqmp.h | 2 ++ tests/qtest/libqmp.c | 37 +++-- 2 files changed, 33 insertions(+), 6 deletions(-) diff --git a/tests/qtest/li

RE: [RFC 00/18] vfio: Adopt iommufd

2022-04-26 Thread Shameerali Kolothum Thodi via
> -Original Message- > From: Yi Liu [mailto:yi.l@intel.com] > Sent: 14 April 2022 11:47 > To: alex.william...@redhat.com; coh...@redhat.com; > qemu-devel@nongnu.org > Cc: da...@gibson.dropbear.id.au; th...@redhat.com; far...@linux.ibm.com; > mjros...@linux.ibm.com; akrow...@linux.ibm

[PATCH] target/riscv: add scalar crypto related extenstion strings to isa_string

2022-04-26 Thread Weiwei Li
- add zbk* and zk* strings to isa_edata_arr Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- target/riscv/cpu.c | 13 + 1 file changed, 13 insertions(+) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index dff4606585..ccacdee215 100644 --- a/target/riscv/cpu.c +++ b

[PATCH] ppc/xive: Save/restore state of the External interrupt

2022-04-26 Thread Frederic Barrat
When pulling an OS context from a vcpu, we should lower the External interrupt if it is pending. Otherwise, it may be delivered in the hypervisor context, which is unexpected. It can lead to an infinite loop where the hypervisor catches the External exception, looks for an interrupt, doesn't find a

Re: [PATCH v8 46/68] target/nios2: Split out helpers for gen_r_math_logic

2022-04-26 Thread Peter Maydell
On Fri, 22 Apr 2022 at 18:40, Richard Henderson wrote: > > Split the macro in two, one for reg/imm and one for reg/reg. > Do as little work as possible within the macros; split out > helper functions and pass in arguments instead. > > Signed-off-by: Richard Henderson > --- > target/nios2/transla

Re: [PATCH v8 47/68] target/nios2: Split out helpers for gen_rr_mul_high

2022-04-26 Thread Peter Maydell
On Fri, 22 Apr 2022 at 18:44, Richard Henderson wrote: > > Rename the macro from gen_r_mul, because these are the multiply > variants that produce a high-part result. Do as little work as > possible within the macro; split out helper functions and pass > in arguments instead. > > Signed-off-by: R

Re: [PATCH v2 07/26] tests: make libqmp buildable for win32

2022-04-26 Thread Marc-André Lureau
Hi On Tue, Apr 26, 2022 at 1:32 PM Thomas Huth wrote: > > On 26/04/2022 11.26, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Signed-off-by: Marc-André Lureau > > --- > > tests/qtest/libqmp.h | 2 ++ > > tests/qtest/libqmp.c | 37 +++--

Re: [PATCH v8 48/68] target/nios2: Split out helpers for gen_rr_shift

2022-04-26 Thread Peter Maydell
On Fri, 22 Apr 2022 at 18:47, Richard Henderson wrote: > > Do as little work as possible within the macro. > Split out helper functions and pass in arguments instead. > > Signed-off-by: Richard Henderson > --- > target/nios2/translate.c | 35 --- > 1 file changed,

Re: [PATCH v2 07/26] tests: make libqmp buildable for win32

2022-04-26 Thread Thomas Huth
On 26/04/2022 12.25, Marc-André Lureau wrote: Hi On Tue, Apr 26, 2022 at 1:32 PM Thomas Huth wrote: On 26/04/2022 11.26, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- tests/qtest/libqmp.h | 2 ++ tests/qtest/libqmp.c | 37 +++

Re: [PATCH for-7.1] target/mips: Remove stale TODO file

2022-04-26 Thread Laurent Vivier
Le 12/04/2022 à 13:38, Thomas Huth a écrit : The last change to this file has been done in 2012, so it seems like this is not really used anymore, and the content is likely very out of date now. Signed-off-by: Thomas Huth --- target/mips/TODO | 51 -

Re: [RFC 15/18] vfio/iommufd: Implement iommufd backend

2022-04-26 Thread Yi Liu
Hi Jason, On 2022/4/22 22:58, Jason Gunthorpe wrote: On Thu, Apr 14, 2022 at 03:47:07AM -0700, Yi Liu wrote: +static int vfio_get_devicefd(const char *sysfs_path, Error **errp) +{ +long int vfio_id = -1, ret = -ENOTTY; +char *path, *tmp = NULL; +DIR *dir; +struct dirent *dent;

serial hang in qemu-system-ppc64 -M pseries

2022-04-26 Thread Rob Landley
When I cut and paste 80-ish characters of text into the Linux serial console, it reads 16 characters and stops. When I hit space, it reads another 16 characters, and if I keep at it will eventually catch up without losing data. If I type, every character shows up immediately. (On other qemu target

Re: [PATCH v8 67/68] tests/tcg/nios2: Add semihosting multiarch tests

2022-04-26 Thread Peter Maydell
On Fri, 22 Apr 2022 at 18:53, Richard Henderson wrote: > > Add runtime supporting the nios2-semi.c interface. > Execute the hello and memory multiarch tests. > > Cc: Alex Bennée > Signed-off-by: Richard Henderson > Message-Id: <20220421151735.31996-64-richard.hender...@linaro.org> > --- > tests

Re: [PATCH v2 26/26] util: rename qemu_*block() socket functions

2022-04-26 Thread Marc-André Lureau
Hi On Tue, Apr 26, 2022 at 1:30 PM wrote: > > From: Marc-André Lureau > > The qemu_*block() functions are meant to be be used with sockets (the > win32 implementation expects SOCKET) > > Over time, those functions where used with Win32 SOCKET or > file-descriptors interchangeably. But for portab

Re: [PATCH] docs: Replace Qemu -> QEMU

2022-04-26 Thread Laurent Vivier
Le 22/04/2022 à 10:30, Stefan Weil a écrit : Signed-off-by: Stefan Weil --- docs/pcie_sriov.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/pcie_sriov.txt b/docs/pcie_sriov.txt index f5e891e1d4..11158dbf88 100644 --- a/docs/pcie_sriov.txt +++ b/docs/pcie_sri

Re: [PATCH v6 0/3] util/thread-pool: Expose minimun and maximum size

2022-04-26 Thread Stefan Hajnoczi
On Mon, Apr 25, 2022 at 09:57:20AM +0200, Nicolas Saenz Julienne wrote: > As discussed on the previous RFC[1] the thread-pool's dynamic thread > management doesn't play well with real-time and latency sensitive > systems. This series introduces a set of controls that'll permit > achieving more dete

Re: [PATCH v2 05/26] tests: move libqtest.h back under qtest/

2022-04-26 Thread Stefan Berger
On 4/26/22 05:26, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Since commit a2ce7dbd917 ("meson: convert tests/qtest to meson"), libqtest.h is under libqos/ directory, while libqtest.c is still in qtest/. Move back to its original location to avoid mixing with libqos/. Suggest

Re: [PATCH v4 2/8] crypto-akcipher: Introduce akcipher types to qapi

2022-04-26 Thread Daniel P . Berrangé
On Mon, Apr 11, 2022 at 06:43:21PM +0800, zhenwei pi wrote: > From: Lei He > > Introduce akcipher types, also include RSA related types. > > Signed-off-by: Lei He > Signed-off-by: zhenwei pi > --- > qapi/crypto.json | 64 > 1 file changed, 64 i

Re: [PATCH] i386/cpu: Remove the deprecated cpu model 'Icelake-Client'

2022-04-26 Thread Igor Mammedov
On Fri, 15 Apr 2022 15:07:33 +0800 Robert Hoo wrote: > On Thu, 2022-03-24 at 09:22 +0100, Igor Mammedov wrote: > > On Mon, 14 Mar 2022 16:50:59 +0800 > > Robert Hoo wrote: > > > > > Icelake, is the codename for Intel 3rd generation Xeon Scalable > > > server > > > processors. There isn't ever

Re: [PATCH] hw/pvrdma: Some cosmetic fixes

2022-04-26 Thread Laurent Vivier
Le 05/04/2022 à 12:25, Marcel Apfelbaum a écrit : On Sun, Apr 3, 2022 at 12:00 PM Yuval Shaia wrote: Signed-off-by: Yuval Shaia --- hw/rdma/vmw/pvrdma_main.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c i

RE: [RFC 15/18] vfio/iommufd: Implement iommufd backend

2022-04-26 Thread Tian, Kevin
> From: Liu, Yi L > Sent: Tuesday, April 26, 2022 5:55 PM > On 2022/4/22 22:58, Jason Gunthorpe wrote: > > On Thu, Apr 14, 2022 at 03:47:07AM -0700, Yi Liu wrote: > > > >> + > >> +/* try to attach to an existing container in this space */ > >> +QLIST_FOREACH(bcontainer, &space->containers,

Re: [PATCH] vdpa: Add missing tracing to batch mapping functions

2022-04-26 Thread Laurent Vivier
Le 05/04/2022 à 08:36, Eugenio Pérez a écrit : These functions were not traced properly. Signed-off-by: Eugenio Pérez --- hw/virtio/vhost-vdpa.c | 2 ++ hw/virtio/trace-events | 2 ++ 2 files changed, 4 insertions(+) diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c index 8adf7c

[PULL 0/9] Kraxel 20220426 patches

2022-04-26 Thread Gerd Hoffmann
The following changes since commit a74782936dc6e979ce371dabda4b1c05624ea87f: Merge tag 'pull-migration-20220421a' of https://gitlab.com/dagrh/qemu into staging (2022-04-21 18:48:18 -0700) are available in the Git repository at: git://git.kraxel.org/qemu tags/kraxel-20220426-pu

[PULL 2/9] Replacing CONFIG_VNC_PNG with CONFIG_PNG

2022-04-26 Thread Gerd Hoffmann
From: Kshitij Suri Libpng is only detected if VNC is enabled currently. This patch adds a generalised png option in the meson build which is aimed to replace use of CONFIG_VNC_PNG with CONFIG_PNG. Signed-off-by: Kshitij Suri Reviewed-by: Daniel P. Berrangé Message-Id: <20220408071336.99839-2-

[PULL 3/9] Added parameter to take screenshot with screendump as PNG

2022-04-26 Thread Gerd Hoffmann
From: Kshitij Suri Currently screendump only supports PPM format, which is un-compressed. Added a "format" parameter to QMP and HMP screendump command to support PNG image capture using libpng. QMP example usage: { "execute": "screendump", "arguments": { "filename": "/tmp/image", "format":"png"

[PULL 7/9] i386: move bios load error message

2022-04-26 Thread Gerd Hoffmann
Switch to usual goto-end-of-function error handling style. No functional change. Signed-off-by: Gerd Hoffmann Tested-by: Xiaoyao Li Reviewed-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé Acked-by: Michael S. Tsirkin Message-Id: <20220425135051.551037-2-kra...@redhat.com> --- hw/

Re: [PATCH] docs: Replace HomeBrew -> Homebrew

2022-04-26 Thread Laurent Vivier
Le 22/04/2022 à 10:34, Stefan Weil a écrit : The official spelling does not use camel case. Signed-off-by: Stefan Weil --- docs/about/build-platforms.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/about/build-platforms.rst b/docs/about/build-platforms.rst in

[PULL 6/9] avocado/vnc: add test_change_listen

2022-04-26 Thread Gerd Hoffmann
From: Vladimir Sementsov-Ogievskiy Add simple test-case for new display-update qmp command. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Daniel P. Berrangé Message-Id: <20220401143936.356460-4-vsement...@openvz.org> Signed-off-by: Gerd Hoffmann --- tests/avocado/vnc.py | 63 +

Re: [PATCH v4 3/8] crypto: Introduce akcipher crypto class

2022-04-26 Thread Daniel P . Berrangé
On Mon, Apr 11, 2022 at 06:43:22PM +0800, zhenwei pi wrote: > Support basic asymmetric operations: encrypt, decrypt, sign and > verify. > > Co-developed-by: lei he > Signed-off-by: lei he > Signed-off-by: zhenwei pi > --- > crypto/akcipher.c | 102 + > crypto/ak

[PULL 5/9] qapi/ui: add 'display-update' command for changing listen address

2022-04-26 Thread Gerd Hoffmann
From: Vladimir Sementsov-Ogievskiy Add possibility to change addresses where VNC server listens for new connections. Prior to 6.0 this functionality was available through 'change' qmp command which was deleted. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Daniel P. Berrangé Message

[PULL 9/9] i386: firmware parsing and sev setup for -bios loaded firmware

2022-04-26 Thread Gerd Hoffmann
Don't register firmware as rom, not needed (see comment). Add x86_firmware_configure() call for proper sev initialization. Signed-off-by: Gerd Hoffmann Tested-by: Xiaoyao Li Reviewed-by: Daniel P. Berrangé Tested-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé Acked-by: Michael S.

[PULL 4/9] ui/vnc: refactor arrays of addresses to SocketAddressList

2022-04-26 Thread Gerd Hoffmann
From: Vladimir Sementsov-Ogievskiy Let's use SocketAddressList instead of dynamic arrays. Benefits: - Automatic cleanup: don't need specific freeing function and drop some gotos. - Less indirection: no triple asterix anymore! - Prepare for the following commit, which will reuse new interfac

[PULL 1/9] hw/display/vmware_vga: do not discard screen updates

2022-04-26 Thread Gerd Hoffmann
From: Carwyn Ellis In certain circumstances, typically when there is lots changing on the screen, updates will be discarded resulting in garbled output. This change simplifies the traversal of the display update FIFO queue when applying updates. We just track the queue length and iterate up to t

Re: [RFC PATCH v1 0/8] qapi: add generator for Golang interface

2022-04-26 Thread Markus Armbruster
Victor Toso writes: > Hi, > > Happy 1st April. Not a joke :) /* ugh, took me too long to send */ > > This series is about adding a generator in scripts/qapi to produce > Go data structures that can be used to communicate with QEMU over > QMP. > > > * Why Go? > > There are quite a few Go projects

[PULL 8/9] i386: factor out x86_firmware_configure()

2022-04-26 Thread Gerd Hoffmann
move sev firmware setup to separate function so it can be used from other code paths. No functional change. Signed-off-by: Gerd Hoffmann Tested-by: Xiaoyao Li Reviewed-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé Acked-by: Michael S. Tsirkin Message-Id: <20220425135051.551037-3

Re: [PATCH v4 4/8] crypto: add ASN.1 decoder

2022-04-26 Thread Daniel P . Berrangé
On Mon, Apr 11, 2022 at 06:43:23PM +0800, zhenwei pi wrote: > From: Lei He > > Add an ANS.1 decoder which is used to parse asymmetric > cipher keys > > Signed-off-by: zhenwei pi > Signed-off-by: Lei He > --- > crypto/asn1_decoder.c | 161 ++ > crypto/asn1_decoder.h

Re: [RFC 00/18] vfio: Adopt iommufd

2022-04-26 Thread Eric Auger
Hi Shameer, On 4/26/22 11:47 AM, Shameerali Kolothum Thodi wrote: > >> -Original Message- >> From: Yi Liu [mailto:yi.l@intel.com] >> Sent: 14 April 2022 11:47 >> To: alex.william...@redhat.com; coh...@redhat.com; >> qemu-devel@nongnu.org >> Cc: da...@gibson.dropbear.id.au; th...@redhat

Re: [PATCH v4 5/8] crypto: Implement RSA algorithm by hogweed

2022-04-26 Thread Daniel P . Berrangé
On Mon, Apr 11, 2022 at 06:43:24PM +0800, zhenwei pi wrote: > From: Lei He > > Implement RSA algorithm by hogweed from nettle. Thus QEMU supports > a 'real' RSA backend to handle request from guest side. It's > important to test RSA offload case without OS & hardware requirement. > > Signed-off-

Re: [PATCH v4 6/8] crypto: Implement RSA algorithm by gcrypt

2022-04-26 Thread Daniel P . Berrangé
On Mon, Apr 11, 2022 at 06:43:25PM +0800, zhenwei pi wrote: > From: Lei He > > Added gcryt implementation of RSA algorithm, RSA algorithm > implemented by gcrypt has a higher priority than nettle because > it supports raw padding. > > Signed-off-by: Lei He > --- > crypto/akcipher-gcrypt.c.inc

Re: [PATCH v4 7/8] tests/crypto: Add test suite for crypto akcipher

2022-04-26 Thread Daniel P . Berrangé
On Mon, Apr 11, 2022 at 06:43:26PM +0800, zhenwei pi wrote: > From: lei he > > Add unit test and benchmark test for crypto akcipher. > > Signed-off-by: lei he > Signed-off-by: zhenwei pi > --- > tests/bench/benchmark-crypto-akcipher.c | 161 ++ > tests/bench/meson.build |

Re: [PATCH for-7.1 00/10] BCDA and mffscdrn implementations

2022-04-26 Thread Víctor Colombo
On 18/04/2022 13:38, Víctor Colombo wrote: Set of patches containing implementations for some instructions that were missing before. Also, moves some related instructions to decodetree Matheus Ferst (4): target/ppc: Add flag for ISA v2.06 BCDA instructions target/ppc: implement addg6s t

Re: [RFC 00/18] vfio: Adopt iommufd

2022-04-26 Thread Jason Gunthorpe
On Tue, Apr 26, 2022 at 08:37:41AM +, Tian, Kevin wrote: > Based on current plan there is probably a transition window between the > point where the first vfio device type (vfio-pci) gaining iommufd support > and the point where all vfio types supporting iommufd. I am still hoping to do all

Re: [PATCH] ppc/xive: Save/restore state of the External interrupt

2022-04-26 Thread Cédric Le Goater
Hello Frederic, On 4/26/22 12:11, Frederic Barrat wrote: When pulling an OS context from a vcpu, we should lower the External interrupt if it is pending. Otherwise, it may be delivered in the hypervisor context, which is unexpected. It can lead to an infinite loop where the hypervisor catches th

Re: [PATCH v2 2/5] 9pfs: fix qemu_mknodat(S_IFSOCK) on macOS

2022-04-26 Thread Greg Kurz
On Tue, 26 Apr 2022 12:57:37 +0900 Akihiko Odaki wrote: > On 2022/04/25 3:45, Christian Schoenebeck wrote: > > +} > > +err = chmod(addr.sun_path, mode); > > I'm not sure if it is fine to have a time window between bind() and > chmod(). Do you have some rationale? >

RE: [RFC 00/18] vfio: Adopt iommufd

2022-04-26 Thread Shameerali Kolothum Thodi via
> -Original Message- > From: Eric Auger [mailto:eric.au...@redhat.com] > Sent: 26 April 2022 12:45 > To: Shameerali Kolothum Thodi ; Yi > Liu ; alex.william...@redhat.com; coh...@redhat.com; > qemu-devel@nongnu.org > Cc: da...@gibson.dropbear.id.au; th...@redhat.com; far...@linux.ibm.com;

[PULL 1/5] hw/pvrdma: Some cosmetic fixes

2022-04-26 Thread Laurent Vivier
From: Yuval Shaia Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum Message-Id: <20220403095837.2378-1-yuval.shaia...@gmail.com> Signed-off-by: Laurent Vivier --- hw/rdma/vmw/pvrdma_main.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/rdma/vmw/pvrdma_m

[PATCH] target/arm: Disable cryptographic instructions when neon is disabled

2022-04-26 Thread Damien Hedde
As of now, cryptographic instructions ISAR fields are never cleared so we can end up with a cpu with cryptographic instructions but no floating-point/neon instructions which is impossible according to ARM specifications. In QEMU, we have 3 kinds of cpus regarding cryptographic instructions: + no s

  1   2   3   4   5   >