Re: [PATCH v2 1/4] kvm: Dynamically adjust the rate of dirty ring reaper thread

2022-04-02 Thread Hyman Huang
在 2022/3/28 9:32, wuc...@chinatelecom.cn 写道: From: Chongyun Wu Dynamically adjust the dirty ring collection thread to reduce the occurrence of ring full, thereby reducing the impact on customers, improving the efficiency of dirty page collection, and thus improving the migration efficiency.

RE: [PATCH V2 4/4] intel-iommu: PASID support

2022-04-02 Thread Tian, Kevin
> From: Jason Wang > Sent: Wednesday, March 30, 2022 4:32 PM > > On Wed, Mar 30, 2022 at 4:02 PM Tian, Kevin wrote: > > > > > From: Jason Wang > > > Sent: Tuesday, March 29, 2022 12:49 PM > > > > > > On Mon, Mar 28, 2022 at 3:03 PM Tian, Kevin > wrote: > > > > > > > > > From: Jason Wang > > >

Re: [PATCH v2 2/4] kvm: Dirty ring autoconverge optmization for kvm_cpu_synchronize_kick_all

2022-04-02 Thread Hyman Huang
在 2022/3/28 9:32, wuc...@chinatelecom.cn 写道: From: Chongyun Wu Dirty ring feature need call kvm_cpu_synchronize_kick_all to flush hardware buffers into KVMslots, but when aucoverge run kvm_cpu_synchronize_kick_all calling will become more and more time consuming. This will significantly redu

RE: [PATCH V2 4/4] intel-iommu: PASID support

2022-04-02 Thread Tian, Kevin
> From: Jason Wang > Sent: Wednesday, March 30, 2022 4:32 PM > > > > > > > > > > If there is certain fault > > > > triggered by a request with PASID, we do want to report this > information > > > > upward. > > > > > > I tend to do it increasingly on top of this series (anyhow at least > > > RID2P

Re: [PATCH v2 3/4] kvm: Introduce a dirty rate calculation method based on dirty ring

2022-04-02 Thread Hyman Huang
在 2022/3/28 9:32, wuc...@chinatelecom.cn 写道: From: Chongyun Wu A new structure KVMDirtyRingDirtyCounter is introduced in KVMDirtyRingReaper to record the number of dirty pages within a period of time. When kvm_dirty_ring_mark_page collects dirty pages, if it finds that the current dirty pag

Re: [PATCH v2 1/4] kvm: Dynamically adjust the rate of dirty ring reaper thread

2022-04-02 Thread Chongyun Wu
on 4/2/2022 3:04 PM, Hyman Huang wrote: 在 2022/3/28 9:32, wuc...@chinatelecom.cn 写道: From: Chongyun Wu Dynamically adjust the dirty ring collection thread to reduce the occurrence of ring full, thereby reducing the impact on customers, improving the efficiency of dirty page collection, and t

RE: [PATCH V2 1/4] intel-iommu: don't warn guest errors when getting rid2pasid entry

2022-04-02 Thread Tian, Kevin
> From: Jason Wang > Sent: Wednesday, March 30, 2022 4:37 PM > On Wed, Mar 30, 2022 at 4:16 PM Tian, Kevin wrote: > > > > > From: Jason Wang > > > Sent: Tuesday, March 29, 2022 12:52 PM > > > > > > > >>> > > > >>> Currently the implementation of vtd_ce_get_rid2pasid_entry() is also > > > >>> pro

Re: [PULL 0/6] target-arm queue

2022-04-02 Thread Peter Maydell
On Fri, 1 Apr 2022 at 16:01, Peter Maydell wrote: > > Some small arm bug fixes for rc3. > > -- PMM > > The following changes since commit 9b617b1bb4056e60b39be4c33be20c10928a6a5c: > > Merge tag 'trivial-branch-for-7.0-pull-request' of > https://gitlab.com/laurent_vivier/qemu into staging (2022-

Re: [PATCH] target/s390x: Fix the accumulation of ccm in op_icm

2022-04-02 Thread Thomas Huth
On 01/04/2022 21.36, Richard Henderson wrote: Coverity rightly reports that 0xff << pos can overflow. This would affect the ICMH instruction. Fixes: Coverity CID 1487161 Signed-off-by: Richard Henderson --- target/s390x/tcg/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

Re: [PATCH v2 3/4] kvm: Introduce a dirty rate calculation method based on dirty ring

2022-04-02 Thread Chongyun Wu
on 4/2/2022 3:28 PM, Hyman Huang wrote: 在 2022/3/28 9:32, wuc...@chinatelecom.cn 写道: From: Chongyun Wu A new structure KVMDirtyRingDirtyCounter is introduced in KVMDirtyRingReaper to record the number of dirty pages within a period of time. When kvm_dirty_ring_mark_page collects dirty pag

Re: [PATCH 1/2] gdbstub: Set current_cpu for memory read write

2022-04-02 Thread Bin Meng
On Tue, Mar 29, 2022 at 12:43 PM Bin Meng wrote: > > On Mon, Mar 28, 2022 at 5:10 PM Peter Maydell > wrote: > > > > On Mon, 28 Mar 2022 at 03:10, Bin Meng wrote: > > > IMHO it's too bad to just ignore this bug forever. > > > > > > This is a valid use case. It's not about whether we intentionall

Re: [PATCH] target/s390x: Fix the accumulation of ccm in op_icm

2022-04-02 Thread Richard Henderson
On 4/2/22 02:38, Thomas Huth wrote: On 01/04/2022 21.36, Richard Henderson wrote: Coverity rightly reports that 0xff << pos can overflow. This would affect the ICMH instruction. Fixes: Coverity CID 1487161 Signed-off-by: Richard Henderson ---   target/s390x/tcg/translate.c | 2 +-   1 file chan

[PATCH] nubus: fix memory leak in nubus_bridge_init()

2022-04-02 Thread Laurent Vivier
Move qbus_init() to a realize function. Leak detected by valgrind: QTEST_QEMU_BINARY="valgrind --leak-check=full \ --show-leak-kinds=definite ./qemu-system-m68k" \ tests/qtest/device-introspect-test \ -p /m68k/device/introspect/concrete/defaults/none ... ==606164== 6 bytes in 1 blocks

Re: [PATCH] nubus: fix memory leak in nubus_bridge_init()

2022-04-02 Thread Mark Cave-Ayland
On 02/04/2022 16:47, Laurent Vivier wrote: Move qbus_init() to a realize function. Leak detected by valgrind: QTEST_QEMU_BINARY="valgrind --leak-check=full \ --show-leak-kinds=definite ./qemu-system-m68k" \ tests/qtest/device-introspect-test \ -p /m68k/device/introspect/concrete/de

Re: [PULL 0/6] Misc fixes for 7.0

2022-04-02 Thread Peter Maydell
On Fri, 1 Apr 2022 at 16:23, Thomas Huth wrote: > > The following changes since commit 9b617b1bb4056e60b39be4c33be20c10928a6a5c: > > Merge tag 'trivial-branch-for-7.0-pull-request' of > https://gitlab.com/laurent_vivier/qemu into staging (2022-04-01 10:23:27 > +0100) > > are available in the G

[PATCH] hw/arm/aspeed: fix AST2500/AST2600 EVB fmc model

2022-04-02 Thread Jae Hyun Yoo
Current fmc model of AST2500 EVB and AST2600 EVB can't emulate quad mode properly so fix them using equivalent mx25l25635e and mx66u51235f respectively. These default settings still can be overridden using the 'fmc-model' command line option. Reported-by: Graeme Gregory Signed-off-by: Jae Hyun Y

Re: [PATCH] hw/arm/aspeed: fix AST2500/AST2600 EVB fmc model

2022-04-02 Thread Cédric Le Goater
On 4/2/22 20:44, Jae Hyun Yoo wrote: Current fmc model of AST2500 EVB and AST2600 EVB can't emulate quad mode properly so fix them using equivalent mx25l25635e and mx66u51235f respectively. These default settings still can be overridden using the 'fmc-model' command line option. Reported-by: Gr

[PATCH] docs/system/devices/can.rst: correct links to CTU CAN FD IP core documentation.

2022-04-02 Thread Pavel Pisa
Signed-off-by: Pavel Pisa --- docs/system/devices/can.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/system/devices/can.rst b/docs/system/devices/can.rst index 16d72c3ac3..fe37af8223 100644 --- a/docs/system/devices/can.rst +++ b/docs/system/devices/can.rst @@