Re: [PATCH v2 0/4] Dirty ring and auto converge optimization

Chongyun, On Mon, Mar 28, 2022 at 09:32:10AM +0800, wuc...@chinatelecom.cn wrote: > From: Chongyun Wu > > v2: > -patch 1: remove patch_1 > > v1: > -rebase to qemu/master > > Overview > > This series of patches is to optimize the performance of > online migration using dirty ring a

[PATCH 2/3] softfloat: Use FloatRelation within partsN_compare

As the return type is FloatRelation, it's clearer to use the type for 'cmp' within the function. Signed-off-by: Richard Henderson --- fpu/softfloat-parts.c.inc | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/fpu/softfloat-parts.c.inc b/fpu/softfloat-parts.c.inc in

[PATCH 0/3] softfloat: FloatRelation cleanups

Make consistent use of FloatRelation throughout the implementation of the float compare functions. I don't yet know if this actually solves Coverity issues, but they all look a bit cleaner, I think. r~ Richard Henderson (3): softfloat: Fix declaration of partsN_compare softfloat: Use FloatRe

Re: [PATCH v5 3/4] hw/intc/exynos4210: replace 'qemu_split_irq' in combiner and gic

On 3/24/22 19:15, Zongyuan Li wrote: Signed-off-by: Zongyuan Li --- hw/arm/exynos4210.c | 26 +++ hw/intc/exynos4210_combiner.c | 81 +++ hw/intc/exynos4210_gic.c | 36 +--- include/hw/arm/exynos4210.h | 11 ++--- incl

[PATCH 1/3] softfloat: Fix declaration of partsN_compare

The declaration used 'int', while the definition used 'FloatRelation'. This should have resulted in a compiler error, but mysteriously didn't. Signed-off-by: Richard Henderson --- fpu/softfloat.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fpu/softfloat.c b/fpu/so

[PATCH v14 1/8] virtio: drop name parameter for virtio_init()

This patch drops the name parameter for the virtio_init function. The pair between the numeric device ID and the string device ID (name) of a virtio device already exists, but not in a way that lets us map between them. This patch lets us do this and removes the need for the name parameter in the

[PATCH 3/3] softfloat: Use FloatRelation for fracN_cmp

Since the caller, partsN_compare, is now exclusively using FloatRelation, it's clearer to use it here too. Signed-off-by: Richard Henderson --- fpu/softfloat.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/fpu/softfloat.c b/fpu/softfloat.c index 7e62fcf414..9f2

Re: [PATCH v2 5/7] block/block-copy: block_copy(): add timeout_ns parameter

On 01.04.22 15:16, Hanna Reitz wrote: On 01.04.22 11:19, Vladimir Sementsov-Ogievskiy wrote: Add possibility to limit block_copy() call in time. To be used in the next commit. Signed-off-by: Vladimir Sementsov-Ogievskiy ---   block/block-copy.c | 26 +++---   block/c

[PATCH v14 2/8] virtio: add vhost support for virtio devices

This patch adds a get_vhost() callback function for VirtIODevices that returns the device's corresponding vhost_dev structure, if the vhost device is running. This patch also adds a vhost_started flag for VirtIODevices. Previously, a VirtIODevice wouldn't be able to tell if its corresponding vhost

[PATCH v14 0/8] hmp,qmp: Add commands to introspect virtio devices

This series introduces new QMP/HMP commands to dump the status of a virtio device at different levels. [Jonah: Rebasing from previous patchset from Feb. 10 (v13). Original patches are by Laurent Vivier from May 2020. Rebase from v13 to v14 includes moving the definition of 'gpu_map' to virtio-

Re: [PATCH v2 6/7] block/copy-before-write: implement cbw-timeout option

On 01.04.22 11:19, Vladimir Sementsov-Ogievskiy wrote: In some scenarios, when copy-before-write operations lasts too long time, it's better to cancel it. Most useful would be to use the new option together with on-cbw-error=break-snapshot: this way if cbw operation takes too long time we'll jus

[PATCH v14 4/8] qmp: add QMP command x-query-virtio-status

From: Laurent Vivier This new command shows the status of a VirtIODevice, including its corresponding vhost device's status (if active). Next patch will improve output by decoding feature bits, including vhost device's feature bits (backend, protocol, acked, and features). Also will decode statu

[PATCH v14 5/8] qmp: decode feature & status bits in virtio-status

From: Laurent Vivier Display feature names instead of bitmaps for host, guest, and backend for VirtIODevices. Display status names instead of bitmaps for VirtIODevices. Display feature names instead of bitmaps for backend, protocol, acked, and features (hdev->features) for vhost devices. Decod

Re: [PATCH v2 6/7] block/copy-before-write: implement cbw-timeout option

On 01.04.22 15:24, Hanna Reitz wrote: On 01.04.22 11:19, Vladimir Sementsov-Ogievskiy wrote: In some scenarios, when copy-before-write operations lasts too long time, it's better to cancel it. Most useful would be to use the new option together with on-cbw-error=break-snapshot: this way if cbw

[PATCH v14 7/8] qmp: add QMP command x-query-virtio-queue-element

From: Laurent Vivier This new command shows the information of a VirtQueue element. [Note: Up until v10 of this patch series, virtio.json had many (15+) enums defined (e.g. decoded device features, statuses, etc.). In v10 most of these enums were removed and replaced with string literals. By

Re: [PATCH v5 3/4] hw/intc/exynos4210: replace 'qemu_split_irq' in combiner and gic

On Thu, 24 Mar 2022 at 18:16, Zongyuan Li wrote: > > Signed-off-by: Zongyuan Li > --- > hw/arm/exynos4210.c | 26 +++ > hw/intc/exynos4210_combiner.c | 81 +++ > hw/intc/exynos4210_gic.c | 36 +--- > include/hw/arm/exynos4210.h

[PATCH v14 3/8] qmp: add QMP command x-query-virtio

From: Laurent Vivier This new command lists all the instances of VirtIODevices with their canonical QOM path and name. [Jonah: @virtio_list duplicates information that already exists in the QOM composition tree. However, extracting necessary information from this tree seems to be a bit convolu

Re: [PATCH v2 3/7] iotests: add copy-before-write: on-cbw-error tests

On 01.04.22 11:19, Vladimir Sementsov-Ogievskiy wrote: Add tests for new option of copy-before-write filter: on-cbw-error. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/tests/copy-before-write| 128 ++ .../qemu-iotests/tests/copy-before-write.out |

[PATCH v14 6/8] qmp: add QMP commands for virtio/vhost queue-status

From: Laurent Vivier These new commands show the internal status of a VirtIODevice's VirtQueue and a vhost device's vhost_virtqueue (if active). Signed-off-by: Jonah Palmer --- hw/virtio/virtio-stub.c | 14 +++ hw/virtio/virtio.c | 103 qapi/virtio.json| 252

Re: [PATCH v2 7/7] iotests: copy-before-write: add cases for cbw-timeout option

On 01.04.22 11:19, Vladimir Sementsov-Ogievskiy wrote: Add two simple test-cases: timeout failure with break-snapshot-on-cbw-error behavior and similar with break-guest-write-on-cbw-error behavior. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/tests/copy-before-write|

Re: [PATCH V2 4/4] intel-iommu: PASID support

On 2022/3/29 12:54, Jason Wang wrote: 在 2022/3/28 下午4:45, Yi Liu 写道: On 2022/3/21 13:54, Jason Wang wrote: This patch introduce ECAP_PASID via "x-pasid-mode". Based on the existing support for scalable mode, we need to implement the following missing parts: 1) tag VTDAddressSpace with PA

[PATCH v14 8/8] hmp: add virtio commands

From: Laurent Vivier This patch implements the HMP versions of the virtio QMP commands. [Jonah: Fixed virtio hmp command output format (e.g. use PRI types).] Signed-off-by: Jonah Palmer --- hmp-commands-info.hx | 70 ++ include/monitor/hmp.h | 5 + monitor/hmp-cmds.c| 311

Re: [PATCH v5 0/9] Add support for AST1030 SoC

Hello Jamin, On 4/1/22 11:23, Jamin Lin wrote: Hi Cedric, Joel and Andrew First all, thanks for all your kindly support and review. We are so glad that QEMU v7.1 will support AST1030 model. QEMU 7.1 is for after the summer. 1. The ast1030 and ast2600 HACE controller are identical. Steven

Re: [PATCH 1/3] softfloat: Fix declaration of partsN_compare

On Fri, 1 Apr 2022 at 14:22, Richard Henderson wrote: > > The declaration used 'int', while the definition used 'FloatRelation'. > This should have resulted in a compiler error, but mysteriously didn't. > > Signed-off-by: Richard Henderson > --- > fpu/softfloat.c | 8 > 1 file changed,

Re: [PATCH 3/3] softfloat: Use FloatRelation for fracN_cmp

On Fri, 1 Apr 2022 at 14:22, Richard Henderson wrote: > > Since the caller, partsN_compare, is now exclusively > using FloatRelation, it's clearer to use it here too. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v8 04/46] hw/cxl/device: Introduce a CXL device (8.2.8)

On Thu, 31 Mar 2022 22:13:20 + Adam Manzanares wrote: > On Wed, Mar 30, 2022 at 06:48:48PM +0100, Jonathan Cameron wrote: > > On Tue, 29 Mar 2022 18:13:59 + > > Adam Manzanares wrote: > > > > > On Fri, Mar 18, 2022 at 03:05:53PM +, Jonathan Cameron wrote: > > > > From: Ben Widaw

Re: [PATCH v2 1/2] qcow2: Improve refcount structure rebuilding

On 30.03.22 16:32, Eric Blake wrote: On Tue, Mar 29, 2022 at 11:19:16AM +0200, Hanna Reitz wrote: When rebuilding the refcount structures (when qemu-img check -r found errors with refcount = 0, but reference count > 0), the new refcount table defaults to being put at the image file end[1]. Ther

Re: [PULL 06/29] softfloat: Move compare_floats to softfloat-parts.c.inc

On 3/31/22 12:06, Peter Maydell wrote: PS: while you're there, there are also a bunch of new TCG related issues where it alleges array indexes being out of bounds. I suspect these are false positives, but it's probably faster for you to analyse them. (I have a feeling Coverity can get confused an

Re: [PATCH 2/3] softfloat: Use FloatRelation within partsN_compare

On Fri, 1 Apr 2022 at 14:22, Richard Henderson wrote: > > As the return type is FloatRelation, it's clearer to > use the type for 'cmp' within the function. > > Signed-off-by: Richard Henderson > --- > fpu/softfloat-parts.c.inc | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-)

Re: [PATCH v2 6/7] block/copy-before-write: implement cbw-timeout option

01.04.2022 16:28, Hanna Reitz wrote: On 01.04.22 15:24, Hanna Reitz wrote: On 01.04.22 11:19, Vladimir Sementsov-Ogievskiy wrote: In some scenarios, when copy-before-write operations lasts too long time, it's better to cancel it. Most useful would be to use the new option together with on-cbw-

Re: [PATCH v2 2/2] iotests/108: Test new refcount rebuild algorithm

On 30.03.22 17:07, Eric Blake wrote: On Tue, Mar 29, 2022 at 11:19:17AM +0200, Hanna Reitz wrote: One clear problem with how qcow2's refcount structure rebuild algorithm used to be before "qcow2: Improve refcount structure rebuilding" was that it is prone to failure for qcow2 images on block dev

Re: [PATCH v2 7/7] iotests: copy-before-write: add cases for cbw-timeout option

01.04.2022 16:36, Hanna Reitz wrote: On 01.04.22 11:19, Vladimir Sementsov-Ogievskiy wrote: Add two simple test-cases: timeout failure with break-snapshot-on-cbw-error behavior and similar with break-guest-write-on-cbw-error behavior. Signed-off-by: Vladimir Sementsov-Ogievskiy ---   tests/qem

Re: [PULL 0/4] Trivial branch for 7.0 patches

as python > interpreter (2022-03-31 21:32:49 +0200) > > ---- > Trivial branch pull request 20220401 > > Fix sh4 linux-user build on Alpine > and some trivial updates > Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/7.0 for any user-visible changes. -- PMM

[PATCH 02/17] tests/docker: remove test targets

Signed-off-by: Paolo Bonzini Message-Id: <20220328140240.40798-3-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- tests/docker/Makefile.include | 20 +--- tests/docker/dockerfiles/empty.docker | 8 2 files changed, 1 insertion(+), 27 deletions(-) delete mo

[PATCH 06/17] tests/docker: remove unnecessary filtering of $(DOCKER_IMAGES)

Now that DOCKER_IMAGES is only defined after DOCKER_VIRTUAL_IMAGES is complete, there is no need to re-filter DOCKER_IMAGES against it. Signed-off-by: Paolo Bonzini Message-Id: <20220328140240.40798-7-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- tests/docker/Makefile.include | 2 +- 1

[PATCH 00/17] tests/docker and tests/tcg cleanup and diet

The first eight patches simplify and clean up a bit the tests/docker/Makefile.include file. The rest adjust tests/Makefile.include to invoke the tests/tcg Makefiles directly, without going through Makefile.qemu and Makefile.prereqs. All information is gathered at configure time, and the config*.m

[PATCH 03/17] tests/docker: remove dead variable

Signed-off-by: Paolo Bonzini Reviewed-by: Alex Bennée Message-Id: <20220328140240.40798-4-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- tests/docker/Makefile.include | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index 06

[PATCH 08/17] tests/docker: do not duplicate rules for hexagon-cross

The commands for docker-image-debian-hexagon-cross are the same as those in debian-toolchain-run, just with a nonstandard path to build-toolchain.sh. Reuse the definition by renaming the debian-hexagon-cross.docker.d directory. Signed-off-by: Paolo Bonzini --- tests/docker/Makefile.include

[PATCH 01/17] tests/docker: remove dead code for linux-user containers

debian-powerpc-user-cross was the only linux-user powered cross builder and it was removed in commit 80394ccf21 ("tests/docker: remove debian-powerpc-user-cross", 2019-09-26). Remove all the infrastructure around it since it is now unused. Signed-off-by: Paolo Bonzini Reviewed-by: Alex Bennée Me

[PATCH 09/17] tests/tcg: add compiler test variables when using containers

Even for container-based cross compilation use $(CROSS_CC_HAS_*) variables. This makes the TCG test makefiles oblivious of whether the compiler is invoked through a container or not. Signed-off-by: Paolo Bonzini Reviewed-by: Alex Bennée Message-Id: <20220328140240.40798-9-pbonz...@redhat.com> Si

[PATCH 05/17] tests/docker: inline variable definitions or move close to use

Variables that are defined with ":=" are handled imperatively, so moving them closer to the first use ensures that all the assignments prior to the first use are taken into account. Signed-off-by: Paolo Bonzini Message-Id: <20220328140240.40798-6-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini

[PATCH 04/17] tests/docker: remove unnecessary default definitions

The definition of DOCKER_IMAGES and DOCKER_TESTS copes already with an empty value of $(IMAGES) and $(TESTS), no need to force them to "%" if undefined. Signed-off-by: Paolo Bonzini Message-Id: <20220328140240.40798-5-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- tests/docker/Makefile.i

[PATCH 12/17] tests/tcg: prepare Makefile.prereqs at configure time

List the dependencies of the build-tcg-tests-* and run-tcg-tests-* targets in a Makefile fragment, without going through Makefile.prereqs's "parsing" of config-*.mak. Signed-off-by: Paolo Bonzini Message-Id: <20220328140240.40798-12-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- tests/Ma

[PATCH 15/17] tests/tcg: isolate from QEMU's config-host.mak

Do not include variables for the QEMU's own compiler, as they are not necessarily related to the cross compiler used for tests/tcg. Signed-off-by: Paolo Bonzini --- configure | 3 +-- tests/tcg/Makefile.target | 3 +-- tests/tcg/configure.sh| 5 + 3 files changed, 7 inser

[PATCH 11/17] tests/tcg: remove CONFIG_USER_ONLY from config-target.mak

Just check the target name instead. Signed-off-by: Paolo Bonzini Message-Id: <20220328140240.40798-11-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- tests/tcg/Makefile.target | 8 tests/tcg/configure.sh| 12 +++- 2 files changed, 7 insertions(+), 13 deletions(-) di

[PATCH 07/17] tests/docker: simplify docker-TEST@IMAGE targets

No need to go through the shell when we already have the test and images at the point where the targets are declared. Signed-off-by: Paolo Bonzini Message-Id: <20220328140240.40798-8-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- tests/docker/Makefile.include | 12 ++-- 1 file ch

[PATCH 2/2] bsd-user: correct notion of return value

Fix EFAULT at startup. Signed-off-by: Maya Rashish --- bsd-user/netbsd/target_os_stack.h | 2 +- bsd-user/openbsd/target_os_stack.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/bsd-user/netbsd/target_os_stack.h b/bsd-user/netbsd/target_os_stack.h index 503279c1a9..f3c

[PATCH 14/17] tests/tcg: invoke Makefile.target directly from QEMU's makefile

Build the "docker.py cc" invocation directly in tests/tcg/configure.sh, and remove the Makefile.qemu wrapper around Makefile.target. The config-*.mak files now include the actual variables used when building the tests, rather than the CROSS_* variables that Makefile.qemu used to "translate". This

[PATCH 13/17] tests/tcg: list test targets in Makefile.prereqs

Omit the rules altogether for targets that do not have a compiler. Makefile.qemu now is only invoked if the tests are actually built/run. Signed-off-by: Paolo Bonzini Message-Id: <20220328140240.40798-13-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 14 +++-

[PATCH 10/17] tests/tcg: remove CONFIG_LINUX_USER from config-target.mak

Just check the target name instead. Signed-off-by: Paolo Bonzini Message-Id: <20220328140240.40798-10-pbonz...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini --- tests/tcg/configure.sh | 2 -- tests/tcg/multiarch/Makefile.target | 2 +- tests/tcg/x86_

[PATCH 16/17] tests/docker: remove SKIP_DOCKER_BUILD

It is now unused. Signed-off-by: Paolo Bonzini Message-Id: <20220328140240.40798-15-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- tests/docker/Makefile.include | 12 +--- tests/docker/docker.py| 57 --- 2 files changed, 1 insertion(+), 68 dele

Re: [PATCH v2 4/7] util: add qemu-co-timeout

01.04.2022 16:13, Hanna Reitz wrote: On 01.04.22 11:19, Vladimir Sementsov-Ogievskiy wrote: Add new API, to make a time limited call of the coroutine. Signed-off-by: Vladimir Sementsov-Ogievskiy ---   include/qemu/coroutine.h | 13 ++   util/meson.build |  1 +   util/qemu-co-timeout

[PATCH 17/17] tests/tcg: fix non-static build

If linking with -static fails at configure time, -static should not be used at build time either. Do not include BUILD_STATIC in $config_target_mak. Signed-off-by: Paolo Bonzini Message-Id: <20220328140240.40798-16-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- tests/tcg/configure.sh |

[PATCH 1/2] bsd-user: Add missing semicolon

Signed-off-by: Maya Rashish --- bsd-user/netbsd/target_os_siginfo.h | 2 +- bsd-user/openbsd/target_os_siginfo.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/bsd-user/netbsd/target_os_siginfo.h b/bsd-user/netbsd/target_os_siginfo.h index 667c19cc7c..36c2323cbe 100644 -

Re: [PULL 06/22] hw/nvram: Introduce Xilinx battery-backed ram

On Thu, 30 Sept 2021 at 16:12, Peter Maydell wrote: > > From: Tong Ho > > This device is present in Versal and ZynqMP product > families to store a 256-bit encryption key. Hi; Coverity points out a bug in this change (CID 1487233): > +static void bbram_bdrv_error(XlnxBBRam *s, int rc, gchar *de

[PATCH v5 1/3] ui/vnc: refactor arrays of addresses to SocketAddressList

Let's use SocketAddressList instead of dynamic arrays. Benefits: - Automatic cleanup: don't need specific freeing function and drop some gotos. - Less indirection: no triple asterix anymore! - Prepare for the following commit, which will reuse new interface of vnc_display_listen(). Signed

[PATCH v5 2/3] qapi/ui: add 'display-update' command for changing listen address

Add possibility to change addresses where VNC server listens for new connections. Prior to 6.0 this functionality was available through 'change' qmp command which was deleted. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Daniel P. Berrangé --- docs/about/removed-features.rst | 3 +-

[PATCH v5 0/3] qapi/ui: change vnc addresses

v5: tiny tweaks, add r-bs Recently our customer requested a possibility to change VNC listen port dynamically. Happily in Rhel7-based Qemu we already have this possibility: through deprecated "change" qmp command. But since 6.0 "change" qmp command was removed, with recommendation to use change-

[PATCH v5 3/3] avocado/vnc: add test_change_listen

Add simple test-case for new display-update qmp command. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Daniel P. Berrangé --- tests/avocado/vnc.py | 63 1 file changed, 63 insertions(+) diff --git a/tests/avocado/vnc.py b/tests/avocado/vn

Re: [PATCH v5 00/13] KVM: mm: fd-based approach for supporting KVM guest private memory

On Thursday 31 Mar 2022 at 09:04:56 (-0700), Andy Lutomirski wrote: > On Wed, Mar 30, 2022, at 10:58 AM, Sean Christopherson wrote: > > On Wed, Mar 30, 2022, Quentin Perret wrote: > >> On Wednesday 30 Mar 2022 at 09:58:27 (+0100), Steven Price wrote: > >> > On 29/03/2022 18:01, Quentin Perret wrote

[PULL 4/6] target/arm: Determine final stage 2 output PA space based on original IPA

From: Idan Horowitz As per the AArch64.S2Walk() pseudo-code in the ARMv8 ARM, the final decision as to the output address's PA space based on the SA/SW/NSA/NSW bits needs to take the input IPA's PA space into account, and not the PA space of the result of the stage 2 walk itself. Signed-off-by:

[PULL 0/6] target-arm queue

ository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20220401 for you to fetch changes up to a5b1e1ab662aa6dc42d5a913080fccbb8bf82e9b: target/arm: Don't use DISAS_NORETURN in STXP !HAVE_CMPXCHG128 codegen (2022-04-01

[PULL 5/6] MAINTAINERS: change Fred Konrad's email address

From: Frederic Konrad frederic.kon...@adacore.com and kon...@adacore.com will stop working starting 2022-04-01. Use my personal email instead. Signed-off-by: Frederic Konrad Reviewed-by: Fabien Chouteau > Reviewed-by: Philippe Mathieu-Daudé Message-id: 1648643217-15811-1-git-send-email-freder

[PULL 3/6] target/arm: Take VSTCR.SW, VTCR.NSW into account in final stage 2 walk

From: Idan Horowitz As per the AArch64.SS2InitialTTWState() psuedo-code in the ARMv8 ARM the initial PA space used for stage 2 table walks is assigned based on the SW and NSW bits of the VSTCR and VTCR registers. This was already implemented for the recursive stage 2 page table walks in S1_ptw_tr

[PULL 1/6] target/arm: Fix MTE access checks for disabled SEL2

From: Idan Horowitz While not mentioned anywhere in the actual specification text, the HCR_EL2.ATA bit is treated as '1' when EL2 is disabled at the current security state. This can be observed in the psuedo-code implementation of AArch64.AllocationTagAccessIsEnabled(). Signed-off-by: Idan Horow

[PULL 2/6] target/arm: Check VSTCR.SW when assigning the stage 2 output PA space

From: Idan Horowitz As per the AArch64.SS2OutputPASpace() psuedo-code in the ARMv8 ARM when the PA space of the IPA is non secure, the output PA space is secure if and only if all of the bits VTCR., VSTCR. are not set. Signed-off-by: Idan Horowitz Reviewed-by: Richard Henderson Message-id: 202

[PULL 6/6] target/arm: Don't use DISAS_NORETURN in STXP !HAVE_CMPXCHG128 codegen

In gen_store_exclusive(), if the host does not have a cmpxchg128 primitive then we generate bad code for STXP for storing two 64-bit values. We generate a call to the exit_atomic helper, which never returns, and set is_jmp to DISAS_NORETURN. However, this is forgetting that we have already emitte

Re: [PATCH v4 10/11] tests/tcg/s390x: Tests for Vector Enhancements Facility 2

vrr is almost a perfect match (it is for this, larger than imm4 would need to be split). .long : this would be uglier. use enough to be filled with nops after ? or use a 32b and 16b instead if it's in .text it should make no difference. On Fri, Apr 1, 2022 at 2:42 AM Christian Borntraeger wrote

Re: [PATCH v3 0/3] block/dirty-bitmaps: fix and improve bitmap merge

On 01.04.22 12:08, Vladimir Sementsov-Ogievskiy wrote: v3: rebase on master, one patch is already merged. Vladimir Sementsov-Ogievskiy (3): block: block_dirty_bitmap_merge(): fix error path block: improve block_dirty_bitmap_merge(): don't allocate extra bitmap block: simplify handling o

[PULL 0/6] Misc fixes for 7.0

The following changes since commit 9b617b1bb4056e60b39be4c33be20c10928a6a5c: Merge tag 'trivial-branch-for-7.0-pull-request' of https://gitlab.com/laurent_vivier/qemu into staging (2022-04-01 10:23:27 +0100) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull

[PULL 1/6] misc: Fixes MAINTAINERS's path .github/workflows/lockdown.yml

From: Yonggang Luo Signed-off-by: Yonggang Luo Message-Id: <20220323080755.156-4-luoyongg...@gmail.com> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index cc364afef7

[PULL 6/6] trace: fix compilation with lttng-ust >= 2.13

From: Marc-André Lureau On Fedora 36, with lttng-ust 2.13.1, compilation fails with: In file included from trace/trace-ust-all.h:49085, from trace/trace-ust-all.c:13: /usr/include/lttng/tracepoint-event.h:67:10: error: #include expects "FILENAME" or 67 | #include LTTNG_UST_

[PULL 2/6] target/s390x: Fix determination of overflow condition code after addition

binUXStoSsacT.bin Description: Binary data

[PULL 3/6] target/s390x: Fix determination of overflow condition code after subtraction

bina_MI2Na3ly.bin Description: Binary data

[PULL 5/6] 9p: move P9_XATTR_SIZE_MAX from 9p.h to 9p.c

binQXAZYq898R.bin Description: Binary data

Re: [PATCH 2/3] i386: factor out x86_firmware_configure()

On 4/1/2022 6:36 PM, Philippe Mathieu-Daudé wrote: On 1/4/22 07:28, Xiaoyao Li wrote: On 4/1/2022 1:08 PM, Gerd Hoffmann wrote:    if (sev_enabled()) { ^^^ Can we remove the SEV check ... +    pc_system_parse_ovmf_flash(ptr, size); + +    if (sev_enabled

[PULL 4/6] meson.build: Fix dependency of page-vary-common.c to config-poison.h

binieFV4N6em2.bin Description: Binary data

Re: [PATCH v4 10/11] tests/tcg/s390x: Tests for Vector Enhancements Facility 2

Am 01.04.22 um 17:02 schrieb David Miller: vrr is almost a perfect match (it is for this, larger than imm4 would need to be split). .long : this would be uglier. use enough to be filled with nops after ? or use a 32b and 16b instead if it's in .text it should make no difference. I will let Ric

Re: use of uninitialized variable involving visit_type_uint32() and friends

On 4/1/22 15:11, Markus Armbruster wrote: If it can do really serious interprocedural analysis, it _might_ be able to see through the visitor constructor and know that the "value = *obj" is not initialized (e.g. "all callers of object_property_set use an input visitor"). I doubt that honestly, b

Re: [RFC PATCH 1/2] spapr: Report correct GTSE support via ov5

"Aneesh Kumar K.V" writes: > David Gibson writes: > >> On Mon, Mar 14, 2022 at 07:10:10PM -0300, Fabiano Rosas wrote: >>> David Gibson writes: >>> >>> > On Tue, Mar 08, 2022 at 10:23:59PM -0300, Fabiano Rosas wrote: >>> > > ... > >>> To satisfy TCG we could keep a spapr capability as ON and us

Re: [PATCH v2 5/7] block/block-copy: block_copy(): add timeout_ns parameter

01.04.2022 16:16, Hanna Reitz wrote: On 01.04.22 11:19, Vladimir Sementsov-Ogievskiy wrote: Add possibility to limit block_copy() call in time. To be used in the next commit. Signed-off-by: Vladimir Sementsov-Ogievskiy ---   block/block-copy.c | 26 +++---   block/co

Re: who's maintaining amd_iommu.c these days?

On Fri, 1 Apr 2022 at 17:11, Wei Huang wrote: > > > > On 3/31/22 21:09, Jason Wang wrote: > > On Fri, Apr 1, 2022 at 2:30 AM Peter Xu wrote: > >> > >> On Thu, Mar 31, 2022 at 05:01:52PM +0100, Peter Maydell wrote: > >>> (4) The claimed bit layout of the event structure doesn't > >>> match up with

Re: [PULL 0/2] riscv-to-apply queue

:08 +0100) > > are available in the Git repository at: > > g...@github.com:alistair23/qemu.git tags/pull-riscv-to-apply-20220401 > > for you to fetch changes up to 8ff8ac63298611c8373b294ec936475b1a33f63f: > > target/riscv: rvv: Add missing early exit condition for

Re: [qemu.qmp PATCH 09/13] [FIXME] move PACKAGE.rst to README.rst and update

On Wed, Mar 30, 2022 at 02:24:20PM -0400, John Snow wrote: > The README here will reflect both what is shown on GitLab and on the > PyPI landing page. Update it accordingly, and freshen it up. > > FIXME: Update URLs when pushing to the production repo. > > Suggested-by: Kashyap Chamarthy > Signe

Re: who's maintaining amd_iommu.c these days?

On 3/31/22 21:09, Jason Wang wrote: On Fri, Apr 1, 2022 at 2:30 AM Peter Xu wrote: On Thu, Mar 31, 2022 at 05:01:52PM +0100, Peter Maydell wrote: Coverity points out some problems with hw/i386/amd_iommu.c's event logging code -- specifically, CID 1487115 1487116 1487190 1487200 1487232 148

Re: [qemu.qmp PATCH 05/13] update project description

On Wed, Mar 30, 2022 at 02:24:16PM -0400, John Snow wrote: > Signed-off-by: John Snow > --- > setup.cfg | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/setup.cfg b/setup.cfg > index f06f944..c21f2ce 100644 > --- a/setup.cfg > +++ b/setup.cfg > @@ -7,7 +7,7 @@ maintainer

Re: [qemu.qmp PATCH 07/13] add a couple new trove classifiers

On Wed, Mar 30, 2022 at 02:24:18PM -0400, John Snow wrote: > Signed-off-by: John Snow > --- > setup.cfg | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/setup.cfg b/setup.cfg > index 776f4f1..44f913d 100644 > --- a/setup.cfg > +++ b/setup.cfg > @@ -14,6 +14,7 @@ long_description = file

Re: [qemu.qmp PATCH 02/13] fork qemu.qmp from qemu.git

On Wed, Mar 30, 2022 at 02:24:13PM -0400, John Snow wrote: > Split python/ from qemu.git, using these commands: > > > git subtree split -P python/ -b python-split-v3 > > mkdir ~/src/tmp > > cd ~/src/tmp > > git clone --no-local --branch python-split-v3 --single-branch ~/src/qemu > > cd qemu > > gi

Re: who's maintaining amd_iommu.c these days?

On 4/1/22 11:14, Peter Maydell wrote: On Fri, 1 Apr 2022 at 17:11, Wei Huang wrote: On 3/31/22 21:09, Jason Wang wrote: On Fri, Apr 1, 2022 at 2:30 AM Peter Xu wrote: On Thu, Mar 31, 2022 at 05:01:52PM +0100, Peter Maydell wrote: (4) The claimed bit layout of the event structure does

[PATCH] accel/tcg: Assert mmu_idx in range before use in cputlb

Coverity reports out-of-bound accesses within cputlb.c. This should be a false positive due to how the index is decoded from MemOpIdx. To be fair, nothing is checking the correct bounds during encoding either. Assert index in range before use, both to catch user errors and to pacify static analys

[PATCH] accel/tcg: Remove ATOMIC_MMU_IDX

The last use of this macro was removed in f3e182b10013 ("accel/tcg: Push trace info building into atomic_common.c.inc") Signed-off-by: Richard Henderson --- accel/tcg/cputlb.c| 1 - accel/tcg/user-exec.c | 1 - 2 files changed, 2 deletions(-) diff --git a/accel/tcg/cputlb.c b/accel/tcg/cput

Re: [PATCH v5 00/13] KVM: mm: fd-based approach for supporting KVM guest private memory

On Fri, Apr 01, 2022, Quentin Perret wrote: > The typical flow is as follows: > > - the host asks the hypervisor to run a guest; > > - the hypervisor does the context switch, which includes switching >stage-2 page-tables; > > - initially the guest has an empty stage-2 (we don't require >

Re: [qemu.qmp PATCH 09/13] [FIXME] move PACKAGE.rst to README.rst and update

On Fri, Apr 1, 2022, 12:40 PM Kashyap Chamarthy wrote: > On Wed, Mar 30, 2022 at 02:24:20PM -0400, John Snow wrote: > > The README here will reflect both what is shown on GitLab and on the > > PyPI landing page. Update it accordingly, and freshen it up. > > > > FIXME: Update URLs when pushing to

Re: [PATCH] accel/tcg: Remove ATOMIC_MMU_IDX

On Fri, 1 Apr 2022 at 18:11, Richard Henderson wrote: > > The last use of this macro was removed in f3e182b10013 > ("accel/tcg: Push trace info building into atomic_common.c.inc") > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v5 00/13] KVM: mm: fd-based approach for supporting KVM guest private memory

On Friday 01 Apr 2022 at 17:14:21 (+), Sean Christopherson wrote: > On Fri, Apr 01, 2022, Quentin Perret wrote: > > The typical flow is as follows: > > > > - the host asks the hypervisor to run a guest; > > > > - the hypervisor does the context switch, which includes switching > >stage-

Re: [PATCH 1/3] softfloat: Fix declaration of partsN_compare

On 4/1/22 07:22, Richard Henderson wrote: The declaration used 'int', while the definition used 'FloatRelation'. This should have resulted in a compiler error, but mysteriously didn't. Bah, of course there's no error -- this is C not C++. The enumeration has values -1 ... 2, which means that t

Re: [PATCH 1/3] softfloat: Fix declaration of partsN_compare

On Fri, 1 Apr 2022 at 19:08, Richard Henderson wrote: > > On 4/1/22 07:22, Richard Henderson wrote: > > The declaration used 'int', while the definition used 'FloatRelation'. > > This should have resulted in a compiler error, but mysteriously didn't. > > Bah, of course there's no error -- this is

Re: [PATCH v5 00/13] KVM: mm: fd-based approach for supporting KVM guest private memory

On Fri, Apr 01, 2022, Quentin Perret wrote: > On Friday 01 Apr 2022 at 17:14:21 (+), Sean Christopherson wrote: > > On Fri, Apr 01, 2022, Quentin Perret wrote: > > I assume there is a scenario where a page can be converted from > > shared=>private? > > If so, is there a use case where that hap

[PATCH] target/i386: Suppress coverity warning on fsave/frstor

Coverity warns that 14 << data32 may overflow with respect to the target_ulong to which it is subsequently added. We know this wasn't true because data32 is in [1,2], but the suggested fix is perfectly fine. Fixes: Coverity CID 1487135, 1487256 Signed-off-by: Richard Henderson --- target/i386/tc

[PATCH] plugins: Assert mmu_idx in range before use in qemu_plugin_get_hwaddr

Coverity reports out-of-bound accesses here. This should be a false positive due to how the index is decoded from MemOpIdx. Fixes: Coverity CID 1487201 Signed-off-by: Richard Henderson --- plugins/api.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/plugins/api.c b/plugins/api.c index 7b

<    1   2   3   >