Re: qemu iotest 161 and make check

2022-03-31 Thread Christian Borntraeger
Am 21.02.22 um 11:27 schrieb Christian Borntraeger: Am 10.02.22 um 18:44 schrieb Vladimir Sementsov-Ogievskiy: 10.02.2022 20:13, Thomas Huth wrote: On 10/02/2022 15.51, Christian Borntraeger wrote: Am 10.02.22 um 15:47 schrieb Vladimir Sementsov-Ogievskiy: 10.02.2022 10:57, Christian Bo

[PATCH v4 1/3] aspeed/hace: Support HMAC Key Buffer register.

2022-03-31 Thread Steven Lee
Support HACE28: Hash HMAC Key Buffer Base Address Register. Signed-off-by: Troy Lee Signed-off-by: Steven Lee --- hw/misc/aspeed_hace.c | 7 +++ include/hw/misc/aspeed_hace.h | 1 + 2 files changed, 8 insertions(+) diff --git a/hw/misc/aspeed_hace.c b/hw/misc/aspeed_hace.c index 10

[PATCH v4 2/3] aspeed/hace: Support AST2600 HACE

2022-03-31 Thread Steven Lee
The aspeed ast2600 accumulative mode is described in datasheet ast2600v10.pdf section 25.6.4: 1. Allocating and initiating accumulative hash digest write buffer with initial state. * Since QEMU crypto/hash api doesn't provide the API to set initial state of hash library, and the init

[PATCH v4 0/3] aspeed/hace: Support AST2600 HACE

2022-03-31 Thread Steven Lee
This patch series implements ast2600 hace engine with accumulative mode and unit test against to it. Verified with following models - AST2600 with OpenBmc VERSION_ID=2.12.0-dev-660-g4c7b3e692-dirty - check hash verification in uboot and check whether qemu crashed during openbmc web gui login

Re: [PATCH-for-7.1] hw/tpm/tpm_tis: Avoid eventual read overrun

2022-03-31 Thread Marc-André Lureau
Hi On Thu, Mar 31, 2022 at 4:02 AM Philippe Mathieu-Daudé < philippe.mathieu.da...@gmail.com> wrote: > From: Philippe Mathieu-Daudé > > The TPMState structure hold an array of TPM_TIS_NUM_LOCALITIES > TPMLocality loc[], having TPM_TIS_NUM_LOCALITIES defined as '5'. > > tpm_tis_locality_from_addr

[PATCH v4 3/3] tests/qtest: Add test for Aspeed HACE accumulative mode

2022-03-31 Thread Steven Lee
This add two addition test cases for accumulative mode under sg enabled. The input vector was manually craft with "abc" + bit 1 + padding zeros + L. The padding length depends on algorithm, i.e. SHA512 (1024 bit), SHA256 (512 bit). The result was calculated by command line sha512sum/sha256sum uti

Re: [PATCH 7/7] vhost-vdpa: backend feature should set only once

2022-03-31 Thread Eugenio Perez Martin
On Thu, Mar 31, 2022 at 1:03 AM Si-Wei Liu wrote: > > > > On 3/30/2022 12:01 PM, Eugenio Perez Martin wrote: > > On Wed, Mar 30, 2022 at 8:33 AM Si-Wei Liu wrote: > >> The vhost_vdpa_one_time_request() branch in > >> vhost_vdpa_set_backend_cap() incorrectly sends down > >> iotls on vhost_dev with

Re: [PATCH] 9p: move limits.h include from 9p.c to 9p.h

2022-03-31 Thread Peter Maydell
On Wed, 30 Mar 2022 at 22:55, Will Cohen wrote: > > On Wed, Mar 30, 2022 at 5:31 PM Peter Maydell > wrote: >> Is it possible to do this with a meson.build check for whatever >> host property we're relying on here rather than with a >> "which OS is this?" ifdef ? > > > To confirm -- the game plan

[PATCH v2 1/9] aspeed/adc: Add AST1030 support

2022-03-31 Thread Jamin Lin
From: Steven Lee Per ast1030_v7.pdf, AST1030 ADC engine is identical to AST2600's ADC. Signed-off-by: Troy Lee Signed-off-by: Jamin Lin Signed-off-by: Steven Lee Reviewed-by: Cédric Le Goater --- hw/adc/aspeed_adc.c | 16 include/hw/adc/aspeed_adc.h | 1 + 2 files

[PATCH v2 3/9] aspeed/wdt: Fix ast2500/ast2600 default reload value.

2022-03-31 Thread Jamin Lin
From: Steven Lee Per ast2500_2520_datasheet_v1.8 and ast2600v11.pdf, the default value of WDT00 and WDT04 is 0x014FB180 for ast2500/ast2600. Add default_status and default_reload_value attributes for storing counter status and reload value as they are different from ast2400. Signed-off-by: Troy

[PATCH v2 6/9] aspeed/scu: Add AST1030 support

2022-03-31 Thread Jamin Lin
From: Steven Lee Per ast1030_v07.pdf, AST1030 SOC doesn't have SCU300, the pclk divider selection is defined in SCU310[11:8]. Add a get_apb_freq function and a class init handler for ast1030. Signed-off-by: Troy Lee Signed-off-by: Jamin Lin Signed-off-by: Steven Lee Reviewed-by: Cédric Le Goa

[PATCH v2 0/9] Add support for AST1030 SoC

2022-03-31 Thread Jamin Lin
Changes from v2: - replace aspeed_ast1030.c with aspeed_ast10xx.c for minibmc SOCs family support - Add "ast1030-evb" machine in aspeed.c and removes aspeed_minibmc.c Changes from v1: The patch series supports ADC, SCU, SMC, TIMER, and WDT for AST1030 SoC. Add avocado test case for "ast1030-evb" m

[PATCH v2 2/9] aspeed/smc: Add AST1030 support

2022-03-31 Thread Jamin Lin
From: Steven Lee AST1030 spi controller's address decoding unit is 1MB that is identical to ast2600, but fmc address decoding unit is 512kb. Introduce seg_to_reg and reg_to_seg handlers for ast1030 fmc controller. In addition, add ast1030 fmc, spi1, and spi2 class init handler. Signed-off-by: Tr

[PATCH v2 4/9] aspeed/wdt: Add AST1030 support

2022-03-31 Thread Jamin Lin
From: Steven Lee AST1030 wdt controller is similiar to AST2600's wdt, but it has extra registers. Introduce ast1030 object class and increse the number of regs(offset) of ast1030 model. Signed-off-by: Troy Lee Signed-off-by: Jamin Lin Signed-off-by: Steven Lee Reviewed-by: Cédric Le Goater -

[PATCH v2 5/9] aspeed/timer: Add AST1030 support.

2022-03-31 Thread Jamin Lin
From: Steven Lee ast1030 tmc(timer controller) is identical to ast2600 tmc. Signed-off-by: Troy Lee Signed-off-by: Jamin Lin Signed-off-by: Steven Lee Reviewed-by: Cédric Le Goater --- hw/timer/aspeed_timer.c | 17 + include/hw/timer/aspeed_timer.h | 1 + 2 files ch

Re: qemu iotest 161 and make check

2022-03-31 Thread Christian Borntraeger
Am 31.03.22 um 09:44 schrieb Christian Borntraeger: Am 21.02.22 um 11:27 schrieb Christian Borntraeger: Am 10.02.22 um 18:44 schrieb Vladimir Sementsov-Ogievskiy: 10.02.2022 20:13, Thomas Huth wrote: On 10/02/2022 15.51, Christian Borntraeger wrote: Am 10.02.22 um 15:47 schrieb Vladim

[PATCH v2 8/9] aspeed: Add an AST1030 eval board

2022-03-31 Thread Jamin Lin
The image should be supplied with ELF binary. $ qemu-system-arm -M ast1030-evb -kernel zephyr.elf -nographic Signed-off-by: Troy Lee Signed-off-by: Jamin Lin Signed-off-by: Steven Lee --- hw/arm/aspeed.c | 111 include/hw/arm/aspeed.h | 21

[PATCH v2 7/9] aspeed/soc : Add AST1030 support

2022-03-31 Thread Jamin Lin
From: Steven Lee The embedded core of AST1030 SoC is ARM Coretex M4. It is hard to be integrated in the common Aspeed Soc framework. We introduce a new ast1030 class with instance_init and realize handlers. Signed-off-by: Troy Lee Signed-off-by: Jamin Lin Signed-off-by: Steven Lee --- hw/arm

[PATCH 2/3] i386: factor out x86_firmware_configure()

2022-03-31 Thread Gerd Hoffmann
move sev firmware setup to separate function so it can be used from other code paths. No functional change. Signed-off-by: Gerd Hoffmann Tested-by: Xiaoyao Li --- include/hw/i386/x86.h | 3 +++ hw/i386/pc_sysfw.c| 36 ++-- 2 files changed, 25 insertions(+),

Re: [PATCH] target/arm: Fix MTE access checks for disabled SEL2

2022-03-31 Thread Peter Maydell
On Mon, 28 Mar 2022 at 19:04, Richard Henderson wrote: > > On 3/28/22 11:31, Idan Horowitz wrote: > > While not mentioned anywhere in the actual specification text, the > > HCR_EL2.ATA bit is treated as '1' when EL2 is disabled at the current > > security state. This can be observed in the psuedo-

[PATCH v2 9/9] test/avocado/machine_aspeed.py: Add ast1030 test case

2022-03-31 Thread Jamin Lin
Add test case to test "ast1030-evb" machine with zephyr os Signed-off-by: Troy Lee Signed-off-by: Jamin Lin Signed-off-by: Steven Lee Reviewed-by: Cédric Le Goater --- tests/avocado/machine_aspeed.py | 36 + 1 file changed, 36 insertions(+) create mode 100644

Re: [PATCH 2/2] softmmu/physmem: fix dirty memory bitmap memleak

2022-03-31 Thread David Hildenbrand
On 25.03.22 16:40, Andrey Ryabinin wrote: > The sequence of ram_block_add()/qemu_ram_free()/ram_block_add() > function calls leads to leaking some memory. > > ram_block_add() calls dirty_memory_extend() to allocate bitmap blocks > for new memory. These blocks only grow but never shrink. So the > q

[PATCH 3/3] i386: firmware parsing and sev setup for -bios loaded firmware

2022-03-31 Thread Gerd Hoffmann
Don't register firmware as rom, not needed (see comment). Add x86_firmware_configure() call for proper sev initialization. Signed-off-by: Gerd Hoffmann Tested-by: Xiaoyao Li --- hw/i386/x86.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/hw/i386/

[PATCH 1/3] i386: move bios load error message

2022-03-31 Thread Gerd Hoffmann
Switch to usual goto-end-of-function error handling style. No functional change. Signed-off-by: Gerd Hoffmann Tested-by: Xiaoyao Li --- hw/i386/x86.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/i386/x86.c b/hw/i386/x86.c index 4cf107baea34..b2e801a8720e 10064

Re: [PATCH 1/7] virtio-net: align ctrl_vq index for non-mq guest for vhost_vdpa

2022-03-31 Thread Jason Wang
On Wed, Mar 30, 2022 at 11:48 PM Si-Wei Liu wrote: > > > > On 3/30/2022 2:00 AM, Jason Wang wrote: > > On Wed, Mar 30, 2022 at 2:33 PM Si-Wei Liu wrote: > >> With MQ enabled vdpa device and non-MQ supporting guest e.g. > >> booting vdpa with mq=on over OVMF of single vqp, below assert > >> failur

[PATCH 0/3] i386: firmware parsing and sev setup for -bios loaded firmware

2022-03-31 Thread Gerd Hoffmann
Gerd Hoffmann (3): i386: move bios load error message i386: factor out x86_firmware_configure() i386: firmware parsing and sev setup for -bios loaded firmware include/hw/i386/x86.h | 3 +++ hw/i386/pc_sysfw.c| 36 ++-- hw/i386/x86.c | 32 ++

Re: [PATCH 3/3] target/arm: Determine final stage 2 output PA space based on original IPA

2022-03-31 Thread Peter Maydell
On Tue, 29 Mar 2022 at 20:09, Richard Henderson wrote: > > On 3/27/22 03:34, Idan Horowitz wrote: > > As per the AArch64.S2Walk() psuedo-code in the ARMv8 ARM, the final > > decision as to the output address's PA space based on the SA/SW/NSA/NSA > > bits needs to take the input IPA's PA space into

Re: [PATCH 4/7] virtio: don't read pending event on host notifier if disabled

2022-03-31 Thread Jason Wang
On Thu, Mar 31, 2022 at 12:41 AM Si-Wei Liu wrote: > > > > On 3/30/2022 2:14 AM, Jason Wang wrote: > > On Wed, Mar 30, 2022 at 2:33 PM Si-Wei Liu wrote: > >> Previous commit prevents vhost-user and vhost-vdpa from using > >> userland vq handler via disable_ioeventfd_handler. The same > >> needs t

Re: [PATCH for-7.0?] tcg/aarch64: Use 'ull' suffix to force 64-bit constant

2022-03-31 Thread Peter Maydell
On Wed, 30 Mar 2022 at 00:49, Richard Henderson wrote: > > Typo used only 'ul' suffix, which is still 32-bits for windows host. > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/947 > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.c.inc | 4 ++-- > 1 file changed, 2 in

Re: [RFC PATCH v3 17/36] pflash_cfi01/tdx: Introduce ram_mode of pflash for TDVF

2022-03-31 Thread Xiaoyao Li
On 3/22/2022 5:27 PM, Daniel P. Berrangé wrote: ... IMHO the AmdSev build for OVMF gets this right by entirely disabling the split OVMF_CODE.fd vs OVMF_VARS.fd, and just having a single OVMF.fd file that is exposed read-only to the guest. This is further represented in $QEMU.git/docs/interop/fir

Re: [PATCH 0/3] Bug fixes related to secure 2 stage translation

2022-03-31 Thread Peter Maydell
On Sun, 27 Mar 2022 at 10:34, Idan Horowitz wrote: > > > Idan Horowitz (3): > target/arm: Check VSTCR.SW when assigning the stage 2 output PA space > target/arm: Take VSTCR.SW, VTCR.NSW into account in final stage 2 walk > target/arm: Determine final stage 2 output PA space based on original

[Bug 1967248] [NEW] qemu: uncaught target signal 5 (Trace/breakpoint trap)

2022-03-31 Thread Jolyon
Public bug reported: I'm getting core dumped when running the attached hello binary in qemu, but when using Gdb to remote-debug the program, it exited normally. will appreciate if you can help look into this qemu issue. And I found that QEMU's 32-bit arm linux-user mode doesn't correctly turn gue

Re: [PATCH v3 2/9] dump: Remove the sh_info variable

2022-03-31 Thread Marc-André Lureau
Hi On Wed, Mar 30, 2022 at 4:48 PM Janosch Frank wrote: > There's no need to have phdr_num and sh_info at the same time. We can > make phdr_num 32 bit and set PN_XNUM when we write the header if > phdr_num >= PN_XNUM. > I am not fond of this change tbh, mixing variables, casting a u32 to u16..

Re: [PATCH] MAINTAINERS: change Fred Konrad's email address

2022-03-31 Thread Peter Maydell
On Wed, 30 Mar 2022 at 13:31, Frederic Konrad wrote: > > frederic.kon...@adacore.com and kon...@adacore.com will stop working starting > 2022-04-01. > > Use my personal email instead. > > Signed-off-by: Frederic Konrad I'll take this via target-arm.next since I'm putting a pullreq together at th

Re: [PATCH v3 1/9] dump: Use ERRP_GUARD()

2022-03-31 Thread Marc-André Lureau
Hi On Wed, Mar 30, 2022 at 4:42 PM Janosch Frank wrote: > Let's move to the new way of handling errors before changing the dump > code. This patch has mostly been generated by the coccinelle script > scripts/coccinelle/errp-guard.cocci. > > Signed-off-by: Janosch Frank > Reviewed-by: Richard He

Re: [PATCH v3] vdpa: reset the backend device in the end of vhost_net_stop()

2022-03-31 Thread Jason Wang
On Thu, Mar 31, 2022 at 1:20 PM <08005...@163.com> wrote: Hi: For some reason, I see the patch as an attachment. Thanks

Re: [RFC PATCH v3 17/36] pflash_cfi01/tdx: Introduce ram_mode of pflash for TDVF

2022-03-31 Thread Daniel P . Berrangé
On Thu, Mar 31, 2022 at 04:51:27PM +0800, Xiaoyao Li wrote: > On 3/22/2022 5:27 PM, Daniel P. Berrangé wrote: > ... > > IMHO the AmdSev build for OVMF gets this right by entirely disabling > > the split OVMF_CODE.fd vs OVMF_VARS.fd, and just having a single > > OVMF.fd file that is exposed read-onl

Re: [PATCH 7/7] vhost-vdpa: backend feature should set only once

2022-03-31 Thread Jason Wang
在 2022/3/31 下午4:02, Eugenio Perez Martin 写道: On Thu, Mar 31, 2022 at 1:03 AM Si-Wei Liu wrote: On 3/30/2022 12:01 PM, Eugenio Perez Martin wrote: On Wed, Mar 30, 2022 at 8:33 AM Si-Wei Liu wrote: The vhost_vdpa_one_time_request() branch in vhost_vdpa_set_backend_cap() incorrectly sends d

[Bug 1967248] Re: qemu: uncaught target signal 5 (Trace/breakpoint trap)

2022-03-31 Thread Jolyon
It seem to can not upload a binary? ** Description changed: - I'm getting core dumped when running the attached a.out_err binary in - qemu, but when using Gdb to remote-debug the program, it exited - normally. will appreciate if you can help look into this qemu issue. + I'm getting core dumped wh

Re: [PATCH v3 6/9] dump: Introduce dump_is_64bit() helper function

2022-03-31 Thread Marc-André Lureau
On Wed, Mar 30, 2022 at 4:44 PM Janosch Frank wrote: > Checking d_class in dump_info leads to lengthy conditionals so let's > shorten things a bit by introducing a helper function. > > Signed-off-by: Janosch Frank > Reviewed-by: Richard Henderson > Reviewed-by: Marc-André Lureau > --- > d

Re: [PATCH v3 9/9] dump: Consolidate elf note function

2022-03-31 Thread Marc-André Lureau
On Wed, Mar 30, 2022 at 4:37 PM Janosch Frank wrote: > Just like with the other write functions let's move the 32/64 bit elf > handling to a function to improve readability. > > Signed-off-by: Janosch Frank > Reviewed-by: Marc-André Lureau > --- > dump/dump.c | 18 +++--- > 1 fi

Re: [PATCH v3 3/9] dump: Introduce shdr_num to decrease complexity

2022-03-31 Thread Marc-André Lureau
On Wed, Mar 30, 2022 at 4:45 PM Janosch Frank wrote: > Let's move from a boolean to a int variable which will later enable us > to store the number of sections that are in the dump file. > > Signed-off-by: Janosch Frank > Reviewed-by: Richard Henderson > Reviewed-by: Marc-André Lureau > ---

Re: [PATCH v3 8/9] dump: Cleanup dump_begin write functions

2022-03-31 Thread Marc-André Lureau
On Wed, Mar 30, 2022 at 4:52 PM Janosch Frank wrote: > There's no need to have a gigantic if in there let's move the elf > 32/64 bit logic into the section, segment or note code. > > Signed-off-by: Janosch Frank > Reviewed-by: Richard Henderson > Reviewed-by: Marc-André Lureau > --- > dump

Re: [PATCH v3] vdpa: reset the backend device in the end of vhost_net_stop()

2022-03-31 Thread Maxime Coquelin
Hi, On 3/31/22 10:55, Jason Wang wrote: On Thu, Mar 31, 2022 at 1:20 PM <08005...@163.com> wrote: Hi: For some reason, I see the patch as an attachment. We are starting to see this more and more since yesterday on DPDK mailing list. It seems like an issue with mimecast, when the From: tag is

Re: [PATCH v3 7/9] dump: Consolidate phdr note writes

2022-03-31 Thread Marc-André Lureau
On Wed, Mar 30, 2022 at 4:49 PM Janosch Frank wrote: > There's no need to have two write functions. Let's rather have two > functions that set the data for elf 32/64 and then write it in a > common function. > > Signed-off-by: Janosch Frank > Reviewed-by: Richard Henderson > Reviewed-by: Marc-

Re: [PATCH v3 4/9] dump: Remove the section if when calculating the memory offset

2022-03-31 Thread Marc-André Lureau
On Wed, Mar 30, 2022 at 4:48 PM Janosch Frank wrote: > When s->shdr_num is 0 we'll add 0 bytes of section headers which is > equivalent to not adding section headers but with the multiplication > we can remove a if/else. > > Signed-off-by: Janosch Frank > Reviewed-by: Richard Henderson > Revie

[PATCH RESEND v3] vdpa: reset the backend device in the end of vhost_net_stop()

2022-03-31 Thread qiudayu
From: Michael Qiu Currently, when VM poweroff, it will trigger vdpa device(such as mlx bluefield2 VF) reset many times(with 1 datapath queue pair and one control queue, triggered 3 times), this leads to below issue: vhost VQ 2 ring restore failed: -22: Invalid argument (22) This because in vhos

[Bug 1967248] Re: qemu: uncaught target signal 5 (Trace/breakpoint trap)

2022-03-31 Thread Peter Maydell
This bug tracker is no longer being used by the QEMU project. It looks like you found our new tracker, though: https://gitlab.com/qemu- project/qemu/-/issues/952 ** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #952 https://gitlab.com/qemu-project/qemu/-/issues/952 ** Changed in: qem

Re: [PATCH 7/7] vhost-vdpa: backend feature should set only once

2022-03-31 Thread Eugenio Perez Martin
On Thu, Mar 31, 2022 at 10:54 AM Jason Wang wrote: > > > 在 2022/3/31 下午4:02, Eugenio Perez Martin 写道: > > On Thu, Mar 31, 2022 at 1:03 AM Si-Wei Liu wrote: > >> > >> > >> On 3/30/2022 12:01 PM, Eugenio Perez Martin wrote: > >>> On Wed, Mar 30, 2022 at 8:33 AM Si-Wei Liu wrote: > The vhost_v

Re: [PATCH v3] vdpa: reset the backend device in the end of vhost_net_stop()

2022-03-31 Thread Michael Qiu
Hi, all To avoid tigger the issue of mimecast, I will re-post the V3 patch use the mail address "Michael Qiu " as a workaround. Thanks, Michael On 2022/3/31 17:12, Maxime Coquelin wrote: Hi, On 3/31/22 10:55, Jason Wang wrote: On Thu, Mar 31, 2022 at 1:20 PM <08005...@163.com> wrote: Hi:

Re: [PATCH v3 2/9] dump: Remove the sh_info variable

2022-03-31 Thread Janosch Frank
On 3/31/22 10:58, Marc-André Lureau wrote: Hi On Wed, Mar 30, 2022 at 4:48 PM Janosch Frank wrote: There's no need to have phdr_num and sh_info at the same time. We can make phdr_num 32 bit and set PN_XNUM when we write the header if phdr_num >= PN_XNUM. I am not fond of this change tbh, m

Re: [PATCH v7 12/17] vfio-user: IOMMU support for remote device

2022-03-31 Thread Stefan Hajnoczi
On Wed, Mar 30, 2022 at 01:13:03PM -0400, Peter Xu wrote: > On Wed, Mar 30, 2022 at 05:08:24PM +0100, Stefan Hajnoczi wrote: > > On Wed, Mar 30, 2022 at 08:53:16AM -0400, Peter Xu wrote: > > > On Wed, Mar 30, 2022 at 11:04:24AM +0100, Stefan Hajnoczi wrote: > > > > This makes me wonder whether ther

Re: [PATCH v3 1/9] dump: Use ERRP_GUARD()

2022-03-31 Thread Janosch Frank
On 3/31/22 10:59, Marc-André Lureau wrote: Hi On Wed, Mar 30, 2022 at 4:42 PM Janosch Frank wrote: Let's move to the new way of handling errors before changing the dump code. This patch has mostly been generated by the coccinelle script scripts/coccinelle/errp-guard.cocci. Signed-off-by: Jan

Re: [PULL v4 15/47] intel_iommu: support snoop control

2022-03-31 Thread Peter Maydell
On Mon, 7 Mar 2022 at 22:45, Michael S. Tsirkin wrote: > > From: Jason Wang > > SC is required for some kernel features like vhost-vDPA. So this patch > implements basic SC feature. The idea is pretty simple, for software > emulated DMA it would be always coherent. In this case we can simple > ad

Re: [RFC PATCH] tests/qtest: attempt to enable tests for virtio-gpio (!working)

2022-03-31 Thread Alex Bennée
(expanding the CC list for help, anyone have a better idea about how vhost-user qtests should work/see obvious issues with this patch?) Alex Bennée writes: > We don't have a virtio-gpio implementation in QEMU and only > support a vhost-user backend. The QEMU side of the code is minimal so > it

Re: [RFC PATCH 0/5] Removal of AioContext lock, bs->parents and ->children: proof of concept

2022-03-31 Thread Paolo Bonzini
On 3/30/22 18:02, Paolo Bonzini wrote: On 3/30/22 12:53, Hanna Reitz wrote: Seems a good compromise between drains and rwlock. What do you think? Well, sounds complicated.  So I’m asking myself whether this would be noticeably better than just an RwLock for graph modifications, like the glo

Re: [PATCH 0/2] virtio: Add vhost-user-gpio device's support

2022-03-31 Thread Alex Bennée
"Michael S. Tsirkin" writes: > On Fri, Feb 04, 2022 at 01:52:47PM +, Alex Bennée wrote: >> >> "Michael S. Tsirkin" writes: >> >> > On Wed, Jan 12, 2022 at 05:04:57PM +0530, Viresh Kumar wrote: >> >> Hello, >> >> >> >> This patchset adds vhost-user-gpio device's support in Qemu. The supp

Re: qemu iotest 161 and make check

2022-03-31 Thread Li Zhang
On 3/31/22 09:44, Christian Borntraeger wrote: Am 21.02.22 um 11:27 schrieb Christian Borntraeger: Am 10.02.22 um 18:44 schrieb Vladimir Sementsov-Ogievskiy: 10.02.2022 20:13, Thomas Huth wrote: On 10/02/2022 15.51, Christian Borntraeger wrote: Am 10.02.22 um 15:47 schrieb Vladimir Semen

Re: [Qemu-devel] [PULL 5/7] hw: convert the escc device to keycodemapdb

2022-03-31 Thread Peter Maydell
On Mon, 29 Jan 2018 at 10:24, Gerd Hoffmann wrote: > > From: "Daniel P. Berrange" > > Replace the qcode_to_keycode table with automatically > generated tables. > > Missing entries in qcode_to_keycode now fixed: > > - Q_KEY_CODE_KP_COMMA -> 0x2d > > Signed-off-by: Daniel P. Berrange > Message-id

Re: [Qemu-devel] [PULL 5/7] hw: convert the escc device to keycodemapdb

2022-03-31 Thread Daniel P . Berrangé
On Thu, Mar 31, 2022 at 11:03:49AM +0100, Peter Maydell wrote: > On Mon, 29 Jan 2018 at 10:24, Gerd Hoffmann wrote: > > > > From: "Daniel P. Berrange" > > > > Replace the qcode_to_keycode table with automatically > > generated tables. > > > > Missing entries in qcode_to_keycode now fixed: > > > >

Re: [PATCH v3 1/9] dump: Use ERRP_GUARD()

2022-03-31 Thread Marc-André Lureau
On Thu, Mar 31, 2022 at 1:48 PM Janosch Frank wrote: > On 3/31/22 10:59, Marc-André Lureau wrote: > > Hi > > > > On Wed, Mar 30, 2022 at 4:42 PM Janosch Frank > wrote: > > > >> Let's move to the new way of handling errors before changing the dump > >> code. This patch has mostly been generated b

Re: [PATCH 5/5] machine: remove temporary inline functions

2022-03-31 Thread Philippe Mathieu-Daudé
On 30/3/22 18:12, Damien Hedde wrote: Now we have renamed all call to these old functions, we can delete the temporary inline we've defined. Signed-off-by: Damien Hedde --- include/hw/boards.h | 10 -- 1 file changed, 10 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 4/5] rename machine_class_allow_dynamic_sysbus_dev

2022-03-31 Thread Philippe Mathieu-Daudé
On 30/3/22 18:12, Damien Hedde wrote: All callsite are updated to the new function name "machine_class_allow_dynamic_device" Signed-off-by: Damien Hedde --- hw/arm/virt.c | 10 +- hw/i386/microvm.c | 2 +- hw/i386/pc_piix.c | 4 ++-- hw/i386/pc_q

Re: [PATCH RESEND v3] vdpa: reset the backend device in the end of vhost_net_stop()

2022-03-31 Thread Michael Qiu
Hi, Jason Does it work this time? On 2022/3/31 17:25, qiud...@archeros.com wrote: From: Michael Qiu Currently, when VM poweroff, it will trigger vdpa device(such as mlx bluefield2 VF) reset many times(with 1 datapath queue pair and one control queue, triggered 3 times), this leads to below is

Re: [PATCH 2/5] machine: update machine allowed list related functions/fields

2022-03-31 Thread Philippe Mathieu-Daudé
On 30/3/22 18:12, Damien Hedde wrote: The list will now accept any device (not only sysbus devices) so we rename the related code and documentation. Create some temporary inline functions with old names until we've udpated callsites as well. Signed-off-by: Damien Hedde --- include/hw/boards.

Re: [PATCH] 9p: move limits.h include from 9p.c to 9p.h

2022-03-31 Thread Christian Schoenebeck
On Mittwoch, 30. März 2022 23:17:02 CEST Will Cohen wrote: > On Wed, Mar 30, 2022 at 4:24 PM Philippe Mathieu-Daudé < > > philippe.mathieu.da...@gmail.com> wrote: > > Hi, > > > > On 30/3/22 20:19, Will Cohen wrote: > > > As noted by https://gitlab.com/qemu-project/qemu/-/issues/950, within > > >

Re: [PATCH 1/5] qdev: add uc_requires_machine_allowance flag

2022-03-31 Thread Philippe Mathieu-Daudé
On 30/3/22 18:12, Damien Hedde wrote: This flag will be used in device_add to check if the device needs special allowance from the machine model. It will replace the current check based only on the device being a TYPE_SYB_BUS_DEVICE. Signed-off-by: Damien Hedde --- include/hw/qdev-core.h | 6

Re: [PATCH-for-7.1] hw/tpm/tpm_tis: Avoid eventual read overrun

2022-03-31 Thread Philippe Mathieu-Daudé
On 31/3/22 09:50, Marc-André Lureau wrote: Hi On Thu, Mar 31, 2022 at 4:02 AM Philippe Mathieu-Daudé > wrote: From: Philippe Mathieu-Daudé mailto:f4...@amsat.org>> The TPMState structure hold an array of TPM_TIS_NUM_LOCALITIES TPMLocality

Re: iotest40 problem

2022-03-31 Thread Li Zhang
On 3/31/22 08:10, Hanna Reitz wrote: On 29.03.22 18:49, Li Zhang wrote: Update what I observed. It seems that aqmp is not stable when running test cases. So I revert the patches as the following, iotest40/41 test cases work well. Thanks for bisecting.  I haven’t seen this problem before, so

Re: [PATCH v3 00/14] Fix some qapi examples and a TODO section

2022-03-31 Thread Markus Armbruster
Victor Toso writes: > Hi, > > I've being using the examples as unit tests and found a few that > doesn't work out-of-the-box, might be inteded in order to be less > verbose in the qapi documentation but nevertheless I'm sending this > out in case you want to cherry-pick them. All queued, thanks!

Re: [PATCH] schemas: add missing vim modeline

2022-03-31 Thread Markus Armbruster
Victor Toso writes: > This is the last qapi schema that is missing the modeline. > Fixes 7e7237cd2b "schemas: add missing vim modeline" > > Signed-off-by: Victor Toso Queued, thanks!

Re: [PULL 06/29] softfloat: Move compare_floats to softfloat-parts.c.inc

2022-03-31 Thread Peter Maydell
On Thu, 3 Jun 2021 at 22:49, Richard Henderson wrote: > > Rename to parts$N_compare. Rename all of the intermediate > functions to ftype_do_compare. Rename the hard-float functions > to ftype_hs_compare. Convert float128 to FloatParts128. > > Reviewed-by: Alex Bennée > Signed-off-by: Richard H

Re: [PATCH 1/5] qdev: add uc_requires_machine_allowance flag

2022-03-31 Thread Damien Hedde
On 3/31/22 12:21, Philippe Mathieu-Daudé wrote: On 30/3/22 18:12, Damien Hedde wrote: This flag will be used in device_add to check if the device needs special allowance from the machine model. It will replace the current check based only on the device being a TYPE_SYB_BUS_DEVICE. Signed-of

[PULL 03/15] qapi: fix example of BLOCK_IMAGE_CORRUPTED event

2022-03-31 Thread Markus Armbruster
binOYXXZ1BG1s.bin Description: Binary data

[PULL 14/15] qapi: fix example of ACPI_DEVICE_OST event

2022-03-31 Thread Markus Armbruster
binE7lJ1buWwH.bin Description: Binary data

[PULL 01/15] schemas: add missing vim modeline

2022-03-31 Thread Markus Armbruster
binyfPtRJFSh7.bin Description: Binary data

[PULL 13/15] qapi: ui examples: add missing @websocket member

2022-03-31 Thread Markus Armbruster
binT_iJDcVndM.bin Description: Binary data

[PULL 15/15] qapi: fix example of dump-guest-memory

2022-03-31 Thread Markus Armbruster
bin3O0Yb_M1zn.bin Description: Binary data

[PULL 05/15] qapi: fix example of BLOCK_JOB_PENDING event

2022-03-31 Thread Markus Armbruster
binY5zSG8L6jm.bin Description: Binary data

[PULL 02/15] qapi: BlockExportRemoveMode: move comments to TODO

2022-03-31 Thread Markus Armbruster
binflH9hd0dKy.bin Description: Binary data

[PULL 04/15] qapi: fix example of BLOCK_IO_ERROR event

2022-03-31 Thread Markus Armbruster
bin2TfTfCesYe.bin Description: Binary data

[PULL 10/15] qapi: fix examples: SHUTDOWN and RESET events

2022-03-31 Thread Markus Armbruster
binVZUQTU4Fzb.bin Description: Binary data

[PULL 06/15] qapi: fix example of DUMP_COMPLETED event

2022-03-31 Thread Markus Armbruster
bin8q3eDG1hgL.bin Description: Binary data

[PULL 00/15] QAPI patches patches for 2022-03-31

2022-03-31 Thread Markus Armbruster
I double-checked these patches affect *only* generated documentation. Safe enough for 7.0, I think. But I'm quite content to hold on to them until after the release, if that's preferred. The following changes since commit aea6e471085f39ada1ccd637043c3ee3dfd88750: Update version for v7.0.0-rc2

Re: [PATCH v2 8/9] aspeed: Add an AST1030 eval board

2022-03-31 Thread Cédric Le Goater
Hello Jamin, On 3/31/22 10:15, Jamin Lin wrote: The image should be supplied with ELF binary. $ qemu-system-arm -M ast1030-evb -kernel zephyr.elf -nographic Signed-off-by: Troy Lee Signed-off-by: Jamin Lin Signed-off-by: Steven Lee --- hw/arm/aspeed.c | 111

[PULL 12/15] qapi: fix example of MEMORY_FAILURE

2022-03-31 Thread Markus Armbruster
bin0bnvQZJ01p.bin Description: Binary data

[PULL 09/15] qapi: fix example of FAILOVER_NEGOTIATED event

2022-03-31 Thread Markus Armbruster
binKEDfeHfwWQ.bin Description: Binary data

[PULL 07/15] qapi: fix example of MEMORY_DEVICE_SIZE_CHANGE event

2022-03-31 Thread Markus Armbruster
bin1HkdLM1LBG.bin Description: Binary data

[PULL 08/15] qapi: fix example of UNPLUG_PRIMARY event

2022-03-31 Thread Markus Armbruster
bin5l3G4LwEhW.bin Description: Binary data

Re: [PATCH v2 7/9] aspeed/soc : Add AST1030 support

2022-03-31 Thread Cédric Le Goater
On 3/31/22 10:15, Jamin Lin wrote: From: Steven Lee The embedded core of AST1030 SoC is ARM Coretex M4. It is hard to be integrated in the common Aspeed Soc framework. We introduce a new ast1030 class with instance_init and realize handlers. Signed-off-by: Troy Lee Signed-off-by: Jamin Lin S

[PULL 11/15] qapi: run-state examples: add missing @timestamp

2022-03-31 Thread Markus Armbruster
binjwPzksTVvX.bin Description: Binary data

Re: [PATCH] 9p: move limits.h include from 9p.c to 9p.h

2022-03-31 Thread Christian Schoenebeck
On Donnerstag, 31. März 2022 10:03:35 CEST Peter Maydell wrote: > On Wed, 30 Mar 2022 at 22:55, Will Cohen wrote: > > On Wed, Mar 30, 2022 at 5:31 PM Peter Maydell wrote: > >> Is it possible to do this with a meson.build check for whatever > >> host property we're relying on here rather than wit

Re: [PATCH experiment 00/16] C++20 coroutine backend

2022-03-31 Thread Markus Armbruster
Hanna Reitz writes: > On 17.03.22 16:11, Paolo Bonzini wrote: >> On 3/16/22 13:32, Stefan Hajnoczi wrote: >>> You can define rules and a way to enforce a subset of C++, but I think >>> over time the code will be C++. A policy that is complicated discourages >>> contributors. >>> >>> For these rea

Re: [PATCH v1 3/9] mem: appropriate handling getting mem region

2022-03-31 Thread Igor Mammedov
On Tue, 29 Mar 2022 00:15:33 +0300 Maxim Davydov wrote: > Attempt to get memory region if the device doesn't have hostmem may not be > an error. This can be happen immediately after initialization (getting > value without default one). Above statement begs for expanded explanation Pls rephrase a

Re: [PATCH v1 2/9] pci: add null-pointer check

2022-03-31 Thread Igor Mammedov
On Tue, 29 Mar 2022 00:15:32 +0300 Maxim Davydov wrote: > Call pci_bus_get_w64_range can fail with the segmentation fault. For > example, this can happen during attempt to get pci-hole64-end >" immediately after initialization" this too vague, pls provide a better description and is possible a

Re: [PATCH v1 0/9] Machine type compatible properties

2022-03-31 Thread Igor Mammedov
On Tue, 29 Mar 2022 00:15:30 +0300 Maxim Davydov wrote: > We need to be able to check machine type after its definition. It's > necessary when using complicated inheritance of compatible features. For > instance, this tool can help to find bugs in the machine type definition > if the name of the

Re: [PATCH experiment 00/16] C++20 coroutine backend

2022-03-31 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, Mar 15, 2022 at 03:50:26PM +0100, Kevin Wolf wrote: [...] >> ...using C++ in coroutine code means that all of the block layer would >> suddenly become C++ and would be most affected by this effect. I'm not >> sure if that's something I would like to see, at

[PATCH v2 3/5] qdev-monitor: use the new user_creatable_requires_machine_allowance

2022-03-31 Thread Damien Hedde
Instead of checking if the device is a sysbus device, just check the newly added flag in device class. Signed-off-by: Damien Hedde --- v2: update the flag name --- softmmu/qdev-monitor.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/softmmu/qdev-monitor.c b/softmmu

Re: [PATCH 2/4] virtio-ccw: move vhost_ccw_scsi to a separate file

2022-03-31 Thread Halil Pasic
On Mon, 28 Mar 2022 16:30:17 +0200 Paolo Bonzini wrote: > Remove unecessary use of #ifdef CONFIG_VHOST_SCSI, instead just use a > separate file and a separate rule in meson.build. > > Signed-off-by: Paolo Bonzini Reviewed-by: Halil Pasic

[PATCH v2 2/5] machine: update machine allowed list related functions/fields

2022-03-31 Thread Damien Hedde
The list will now accept any device (not only sysbus devices) so we rename the related code and documentation. Create some temporary inline functions with old names until we've udpated callsites as well. Signed-off-by: Damien Hedde Reviewed-by: Philippe Mathieu-Daudé --- include/hw/boards.h |

  1   2   3   4   >