On Fri, Mar 04, 2022 at 11:51:19AM +0100, Gerd Hoffmann wrote:
> On Sat, Feb 12, 2022 at 09:29:47PM +0800, Hongren (Zenithal) Zheng wrote:
> > Hi,
> >
> > Is there any further feedback on this patch set.
>
> Sorry for the looong delay, I'm rather busy with edk2.
Fully understandable. There is al
On 3/22/22 03:51, Jamin Lin wrote:
From: Steven Lee
Per ast2500_2520_datasheet_v1.8 and ast2600v11.pdf, the default value of
WDT00 and WDT04 is 0x014FB180 for ast2500/ast2600.
Add default_status and default_reload_value attributes for storing
counter status and reload value as they are differen
On 3/22/22 03:51, Jamin Lin wrote:
From: Steven Lee
Per ast1030_v7.pdf, AST1030 ADC engine is identical to AST2600's ADC.
Signed-off-by: Troy Lee
Signed-off-by: Jamin Lin
Signed-off-by: Steven Lee
Reviewed-by: Cédric Le Goater
Thanks,
C.
---
hw/adc/aspeed_adc.c | 16 +
On 3/22/22 03:51, Jamin Lin wrote:
From: Steven Lee
ast1030 tmc(timer controller) is identical to ast2600 tmc.
Signed-off-by: Troy Lee
Signed-off-by: Jamin Lin
Signed-off-by: Steven Lee
Reviewed-by: Cédric Le Goater
Thanks,
C.
---
hw/timer/aspeed_timer.c | 17 +
From: Philippe Mathieu-Daudé
Since commit 0439c5a462 ("block/block-backend.c: assertions for
block-backend") QEMU crashes when using Cocoa on Darwin hosts.
Example on macOS:
$ qemu-system-i386
Assertion failed: (qemu_in_main_thread()), function blk_all_next, file
block-backend.c, line 552.
On 21/3/22 23:08, Akihiko Odaki wrote:
On 2022/03/21 23:55, Philippe Mathieu-Daudé wrote:
From: Philippe Mathieu-Daudé
Since commit 0439c5a462 ("block/block-backend.c: assertions for
block-backend") QEMU crashes on Darwin hosts, example on macOS:
$ qemu-system-i386
Assertion failed: (qe
On 21/03/2022 13.59, Peter Maydell wrote:
On Mon, 21 Mar 2022 at 12:11, BALATON Zoltan wrote:
On Mon, 21 Mar 2022, Peter Maydell wrote:
On Mon, 21 Mar 2022 at 10:31, Thomas Huth wrote:
FYI, I'm seeing a memory leak in via_isa_realize() when building
QEMU with sanitizers enabled or when runn
Libpng is only detected if VNC is enabled currently. This patch adds a
generalised png option in the meson build which is aimed to replace use of
CONFIG_VNC_PNG with CONFIG_PNG.
Signed-off-by: Kshitij Suri
---
meson.build| 9 -
meson_options.txt | 4 ++--
ui/vnc-enc-tight.c |
Currently screendump only supports PPM format, which is un-compressed and not
standard. Added a "format" parameter to qemu monitor screendump capabilites
to support PNG image capture using libpng. The param was added in QAPI schema
of screendump present in ui.json along with png_save() function whi
On 21/03/2022 20:35, Peter Maydell wrote:
On Mon, 21 Mar 2022 at 18:55, Cédric Le Goater wrote:
I introduced quite a few of these calls,
hw/ppc/pnv_lpc.c:irqs = qemu_allocate_irqs(handler, lpc, ISA_NUM_IRQS);
hw/ppc/pnv_psi.c:psi->qirqs = qemu_allocate_irqs(ics_set_irq, ics,
On 2022/03/22 16:54, Philippe Mathieu-Daudé wrote:
From: Philippe Mathieu-Daudé
Since commit 0439c5a462 ("block/block-backend.c: assertions for
block-backend") QEMU crashes when using Cocoa on Darwin hosts.
Example on macOS:
$ qemu-system-i386
Assertion failed: (qemu_in_main_thread()),
Hi all,
Does anyone know the difference between PCIDeviceClass realize()/exit() vs. QOM
realize() and finalize()? The reason for asking is that I recently got bitten by
using a standard QOM pattern to configure a PCI device which didn't work because it
was dependent upon setup that was done in
On 22.03.22 01:04, David Miller wrote:
> Signed-off-by: David Miller
> Signed-off-by: Richard Henderson
Reviewed-by: David Hildenbrand
--
Thanks,
David / dhildenb
On 3/22/22 08:54, Philippe Mathieu-Daudé wrote:
From: Philippe Mathieu-Daudé
Since commit 0439c5a462 ("block/block-backend.c: assertions for
block-backend") QEMU crashes when using Cocoa on Darwin hosts.
Example on macOS:
$ qemu-system-i386
Assertion failed: (qemu_in_main_thread()), fun
On 15/03/2022 09:09, Alex Williamson wrote:
[Cc +Alexey]
On Fri, 11 Mar 2022 12:35:45 -0600 (CST)
Timothy Pearson wrote:
All,
I've been struggling for some time with what is looking like a
potential bug in QEMU/KVM on the POWER9 platform. It appears that in
XIVE mode, when the in-kernel
On 22.03.22 01:04, David Miller wrote:
> Signed-off-by: David Miller
> Signed-off-by: Richard Henderson
> ---
Reviewed-by: David Hildenbrand
--
Thanks,
David / dhildenb
On 22/03/2022 09.23, Mark Cave-Ayland wrote:
[...]
but the main blocker for me was not being able to test all the different PPC
machine configurations.
I think the best you can do is to run the avocado tests:
make check-venv
./tests/venv/bin/avocado run -t arch:ppc64 tests/avocado/
./tests/
[...]
>
> +static DisasJumpType op_vlbr(DisasContext *s, DisasOps *o)
> +{
> +const uint8_t es = get_field(s, m3);
> +TCGv_i64 t0, t1;
> +
> +if (es < ES_16 || es > ES_128) {
> +gen_program_exception(s, PGM_SPECIFICATION);
> +return DISAS_NORETURN;
> +}
> +
> +
On 22.03.22 01:04, David Miller wrote:
> From: Richard Henderson
>
Please add the Fixes line as well:
Fixes: 0e0a5b49ad58 ("s390x/tcg: Implement VECTOR STORE WITH LENGTH")
> Signed-off-by: Richard Henderson
> Reviewed-by: David Miller
> Reviewed-by: David Hildenbrand
> ---
> target/s390x/
On 22.03.22 01:04, David Miller wrote:
> Signed-off-by: David Miller
> Signed-off-by: Richard Henderson
> ---
> target/s390x/gen-features.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c
> index 22846121c4..499a3b10a8 100644
On 3/22/22 09:37, Thomas Huth wrote:
On 22/03/2022 09.23, Mark Cave-Ayland wrote:
[...]
but the main blocker for me was not being able to test all the different PPC
machine configurations.
I think the best you can do is to run the avocado tests:
make check-venv
./tests/venv/bin/avocado r
On Wed, Mar 16, 2022 at 04:57:39PM +0100, Peter Krempa wrote:
> On Tue, Mar 08, 2022 at 12:34:38 +0100, Paolo Bonzini wrote:
> > From: Yang Zhong
> >
> > Kernel allocates 4K xstate buffer by default. For XSAVE features
> > which require large state component (e.g. AMX), Linux kernel
> > dynamical
On 22.03.22 01:04, David Miller wrote:
> Signed-off-by: David Miller
> Signed-off-by: Richard Henderson
Checkpatch complains about three things:
ERROR: space prohibited between function name and open parenthesis '('
#262: FILE: tests/tcg/s390x/vxeh2_vlstr.c:115:
+vler (&vd, &vs, ES16); vts
On Thu, Mar 17, 2022 at 09:58:49PM +0800, Xiaoyao Li wrote:
> Add sept-ve-disable property for tdx-guest object. It's used to
> configure bit 28 of TD attributes.
What is this?
> --- a/qapi/qom.json
> +++ b/qapi/qom.json
> @@ -792,10 +792,13 @@
> #
> # @attributes: TDX guest's attributes (defau
On 22/3/22 09:32, Paolo Bonzini wrote:
On 3/22/22 08:54, Philippe Mathieu-Daudé wrote:
From: Philippe Mathieu-Daudé
Since commit 0439c5a462 ("block/block-backend.c: assertions for
block-backend") QEMU crashes when using Cocoa on Darwin hosts.
Example on macOS:
$ qemu-system-i386
Assert
Hi,
> > If you don't need a pflash device, don't use it: simply map your nvram
> > region as ram in your machine. No need to clutter the pflash model like
> > that.
Using the pflash device for something which isn't actually flash looks a
bit silly indeed.
>
> I know it's dirty to hack the pfl
On Tue, 22 Mar 2022 at 09:20, Philippe Mathieu-Daudé
wrote:
>
> On 22/3/22 09:32, Paolo Bonzini wrote:
> > For now, it fixes the regression and makes the Cocoa build much more
> > similar to the others. There is an easy way to fix the -runas
> > regression, by moving the code up to the call of -s
On Tue, Mar 22, 2022 at 10:21:41AM +0100, Gerd Hoffmann wrote:
> Hi,
>
> > > If you don't need a pflash device, don't use it: simply map your nvram
> > > region as ram in your machine. No need to clutter the pflash model like
> > > that.
>
> Using the pflash device for something which isn't act
On 22/3/22 09:32, Paolo Bonzini wrote:
On 3/22/22 08:54, Philippe Mathieu-Daudé wrote:
From: Philippe Mathieu-Daudé
Since commit 0439c5a462 ("block/block-backend.c: assertions for
block-backend") QEMU crashes when using Cocoa on Darwin hosts.
Example on macOS:
$ qemu-system-i386
Assert
On Mon, Mar 21, 2022 at 04:54:51PM +0800, Xiaoyao Li wrote:
> On 3/18/2022 10:07 PM, Philippe Mathieu-Daudé wrote:
> > Hi,
> >
> > On 17/3/22 14:58, Xiaoyao Li wrote:
> > > TDX VM needs to boot with Trust Domain Virtual Firmware (TDVF). Unlike
> > > that OVMF is mapped as rom device, TDVF needs to
On 21.03.22 09:31, Stefano Garzarella wrote:
On Sat, Mar 19, 2022 at 04:15:33PM +0100, Peter Lieven wrote:
Am 18.03.2022 um 17:47 schrieb Stefano Garzarella
:
On Fri, Mar 18, 2022 at 04:48:18PM +0100, Peter Lieven wrote:
Am 18.03.2022 um 09:25 schrieb Stefano Garzarella
:
On Thu, Ma
On Tue, Mar 22, 2022 at 08:18:44AM +, Kshitij Suri wrote:
> Libpng is only detected if VNC is enabled currently. This patch adds a
> generalised png option in the meson build which is aimed to replace use of
> CONFIG_VNC_PNG with CONFIG_PNG.
>
> Signed-off-by: Kshitij Suri
> ---
> meson.buil
On 21.03.22 21:16, John Snow wrote:
V5 hotfix:
- Quote the subprocess.CompletedProcess[str] type annotations,
Python 3.6 chokes on them at runtime :(
- Reduce line length in the text decoration fn,
even though check-patch still doesn't like it.
- Reflow docstring for qemu_img.*
V5
On 16/3/22 07:10, Akihiko Odaki wrote:
The unused variables when FLOAT_MIXENG is defined caused warnings on
Apple clang version 13.1.6 (clang-1316.0.21.2).
Signed-off-by: Akihiko Odaki
---
audio/mixeng.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
FWIW this patch is alrea
Paolo Bonzini writes:
> Check that conflicts among array alternates are detected correctly.
>
> Signed-off-by: Paolo Bonzini
> ---
> tests/qapi-schema/alternate-conflict-lists.err | 2 ++
> tests/qapi-schema/alternate-conflict-lists.json | 6 +
> tests/qapi-schema/alternate-conflict-lists.
On Tue, Mar 22, 2022 at 08:18:45AM +, Kshitij Suri wrote:
> Currently screendump only supports PPM format, which is un-compressed and not
> standard. Added a "format" parameter to qemu monitor screendump capabilites
> to support PNG image capture using libpng. The param was added in QAPI schema
Ping
On 02.03.22 13:45, Hanna Reitz wrote:
Hi,
v1 cover letter:
https://lists.nongnu.org/archive/html/qemu-devel/2022-02/msg04592.html
We have two tests (as far as I know) that use compression_type=zstd for
qcow2 but do not check whether that is actually supported. Thomas
reported this for 0
Paolo Bonzini writes:
> Signed-off-by: Paolo Bonzini
> ---
> tests/qapi-schema/qapi-schema-test.json | 1 +
> tests/qapi-schema/qapi-schema-test.out | 4 +++
> tests/unit/test-qobject-input-visitor.c | 43 +
> 3 files changed, 48 insertions(+)
>
> diff --git a/tests/q
On 18.03.22 13:53, Hanna Reitz wrote:
Hi,
Commit e3296cc796aeaf (“block: print the server key type and fingerprint
on failure”) improved the verbosity of our ssh block driver's error
messages for fingerprint mismatches. However, iotest 207, which tests
such errors, has not been adjusted accordi
Paolo Bonzini writes:
> Detect array types as alternate branches, and turn the JSON list into
> a QAPISchemaArrayType. Array types in an alternate are represented with
> QTYPE_QLIST in the type field.
>
> Signed-off-by: Paolo Bonzini
I double-checked the generated code; it looks good to me.
T
CPUClass::memory_rw_debug() holds a callback for GDB memory access.
If not provided, cpu_memory_rw_debug() is used by the GDB stub.
Drop avr_cpu_memory_rw_debug() which does nothing special.
Signed-off-by: Bin Meng
---
target/avr/cpu.h| 2 --
target/avr/cpu.c| 1 -
target/avr/helper.c |
On 22/03/22 3:12 pm, Daniel P. Berrangé wrote:
On Tue, Mar 22, 2022 at 08:18:44AM +, Kshitij Suri wrote:
Libpng is only detected if VNC is enabled currently. This patch adds a
generalised png option in the meson build which is aimed to replace use of
CONFIG_VNC_PNG with CONFIG_PNG.
Signed
On 02/03/2022 13.45, Hanna Reitz wrote:
Hi,
v1 cover letter:
https://lists.nongnu.org/archive/html/qemu-devel/2022-02/msg04592.html
We have two tests (as far as I know) that use compression_type=zstd for
qcow2 but do not check whether that is actually supported. Thomas
reported this for 065,
On 22/03/22 3:17 pm, Daniel P. Berrangé wrote:
On Tue, Mar 22, 2022 at 08:18:45AM +, Kshitij Suri wrote:
Currently screendump only supports PPM format, which is un-compressed and not
standard. Added a "format" parameter to qemu monitor screendump capabilites
to support PNG image capture us
Le 15/03/2022 à 09:43, Richard Henderson a écrit :
On alpha, the sigset argument for sigsuspend is in a register.
When we drop that into memory that happens in host-endianness,
but target_to_host_old_sigset will treat it as target-endianness.
Signed-off-by: Richard Henderson
---
linux-user/sy
Le 15/03/2022 à 09:43, Richard Henderson a écrit :
Two new functions: process_sigsuspend_mask and finish_sigsuspend_mask.
Move the size check and copy-from-user code.
Signed-off-by: Richard Henderson
---
linux-user/signal-common.h | 26 +
linux-user/signal.c|
Daniel P. Berrangé writes:
> On Tue, Mar 22, 2022 at 08:18:45AM +, Kshitij Suri wrote:
>> Currently screendump only supports PPM format, which is un-compressed and not
>> standard. Added a "format" parameter to qemu monitor screendump capabilites
>> to support PNG image capture using libpng.
On 22/3/22 10:50, Bin Meng wrote:
CPUClass::memory_rw_debug() holds a callback for GDB memory access.
If not provided, cpu_memory_rw_debug() is used by the GDB stub.
Drop avr_cpu_memory_rw_debug() which does nothing special.
Signed-off-by: Bin Meng
---
target/avr/cpu.h| 2 --
target/avr
On Mon, 21 Mar 2022 at 16:48, Paolo Bonzini wrote:
>
> The following changes since commit e2fb7d8aa218256793df99571d16f92074258447:
>
> Merge tag 'dbus-pull-request' of gitlab.com:marcandre.lureau/qemu into
> staging (2022-03-15 16:28:50 +)
>
> are available in the Git repository at:
>
>
On 22/03/22 3:45 pm, Markus Armbruster wrote:
Daniel P. Berrangé writes:
On Tue, Mar 22, 2022 at 08:18:45AM +, Kshitij Suri wrote:
Currently screendump only supports PPM format, which is un-compressed and not
standard. Added a "format" parameter to qemu monitor screendump capabilites
to
In commit 84d43d2e82da we rearranged the logging of errors in
process_mapc(), and inadvertently dropped the trailing newlines
from the log messages. Restore them.
Fixes: 84d43d2e82da ("hw/intc/arm_gicv3_its: In MAPC with V=0, don't check
rdbase field")
Signed-off-by: Peter Maydell
---
hw/intc/a
On 22/03/2022 09.53, David Hildenbrand wrote:
On 22.03.22 01:04, David Miller wrote:
[...]
diff --git a/tests/tcg/s390x/Makefile.target b/tests/tcg/s390x/Makefile.target
index 8c9b6a13ce..921a056dd1 100644
--- a/tests/tcg/s390x/Makefile.target
+++ b/tests/tcg/s390x/Makefile.target
@@ -16,6 +16,
Hi,
> > Just using -bios OVMF.fd might work too. Daniel tried that recently for
> > sev, but ran into problems with wiring up ovmf metadata parsing for
> > -bios. Don't remember the details though.
>
> It was related to the BIOS shadowing, whereby QEMU loads it at one
> address, and then when
On 14/3/22 22:33, Andreas K. Hüttel wrote:
This information is given by the EF_MIPS_ABI2 (0x20) bit in the
e_flags field of the ELF header (a 4-byte value at offset 0x24 for
the here applicable ELFCLASS32).
See-also: https://www.mail-archive.com/qemu-devel@nongnu.org/msg732572.html
This is com
On 22/3/22 11:28, Peter Maydell wrote:
In commit 84d43d2e82da we rearranged the logging of errors in
process_mapc(), and inadvertently dropped the trailing newlines
from the log messages. Restore them.
Fixes: 84d43d2e82da ("hw/intc/arm_gicv3_its: In MAPC with V=0, don't check rdbase
field")
Sig
Hi,
> > I'd suggest to run the patch series through the qemu gitlab CI
> > before sending out v5.
>
> I have gone through qemu gitlab CI and the result is in
> https://gitlab.com/ZenithalHourlyRate/qemu/-/pipelines/497317417
> Except check-dco and check-patch (I only generate Signed-off-by line
Libpng is only detected if VNC is enabled currently. This patch adds a
generalised png option in the meson build which is aimed to replace use of
CONFIG_VNC_PNG with CONFIG_PNG.
Signed-off-by: Kshitij Suri
Reviewed-by: Daniel P. Berrangé
---
meson.build| 9 -
meson_options.txt
Currently screendump only supports PPM format, which is un-compressed and not
standard. Added a "format" parameter to qemu monitor screendump capabilites
to support PNG image capture using libpng. The param was added in QAPI schema
of screendump present in ui.json along with png_save() function whi
22.03.2022 12:48, Hanna Reitz wrote:
Ping
On 02.03.22 13:45, Hanna Reitz wrote:
Hi,
v1 cover letter:
https://lists.nongnu.org/archive/html/qemu-devel/2022-02/msg04592.html
We have two tests (as far as I know) that use compression_type=zstd for
qcow2 but do not check whether that is actually
On Tue, Mar 22, 2022 at 11:35:18AM +0100, Gerd Hoffmann wrote:
> Hi,
>
> > > Just using -bios OVMF.fd might work too. Daniel tried that recently for
> > > sev, but ran into problems with wiring up ovmf metadata parsing for
> > > -bios. Don't remember the details though.
> >
> > It was related
On 2022/03/22 18:35, Philippe Mathieu-Daudé wrote:
On 22/3/22 09:32, Paolo Bonzini wrote:
On 3/22/22 08:54, Philippe Mathieu-Daudé wrote:
From: Philippe Mathieu-Daudé
Since commit 0439c5a462 ("block/block-backend.c: assertions for
block-backend") QEMU crashes when using Cocoa on Darwin hosts.
On Tue, 15 Mar 2022 15:41:56 +0100
Markus Armbruster wrote:
> g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer,
> for two reasons. One, it catches multiplication overflowing size_t.
> Two, it returns T * rather than void *, which lets the compiler catch
> more type errors.
>
We don't include the "msa5" feature in the "qemu" model because it
generates a warning. The PoP states:
"The message-security-assist extension 5 requires
the secure-hash-algorithm (SHA-512) capabilities of
the message-security-assist extension 2 as a prereq-
uisite. (March, 2015)"
As SHA-512 won'
Before we were able to bump up the qemu CPU model to a z13, we included
some experimental features during development in the "max" model only.
Nowadays, the "max" model corresponds exactly to the "qemu" CPU model
of the latest QEMU machine under TCG.
Let's remove all the special casing, effectivel
Let's simplify the "max" CPU model and just make it correspond to the
"qemu" CPU model of the latest QEMU machine from now on. This gets rid of
a warning we print when starting QEMU with "-cpu max".
Cc: Cornelia Huck
Cc: Thomas Huth
Cc: Richard Henderson
Cc: Daniel P. Berrangé
David Hildenbra
Le 15/03/2022 à 09:43, Richard Henderson a écrit :
Unblocked signals are never delivered, because we
didn't record the new mask for process_pending_signals.
Handle this with the same mechanism as sigsuspend.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/834
Signed-off-by: Richard Hende
Le 15/03/2022 à 09:43, Richard Henderson a écrit :
Unblocked signals are never delivered, because we
didn't record the new mask for process_pending_signals.
Handle this with the same mechanism as sigsuspend.
Signed-off-by: Richard Henderson
---
linux-user/syscall.c | 22 +++---
Le 15/03/2022 à 09:43, Richard Henderson a écrit :
Unblocked signals are never delivered, because we
didn't record the new mask for process_pending_signals.
Handle this with the same mechanism as sigsuspend.
Signed-off-by: Richard Henderson
---
linux-user/syscall.c | 24 +++---
Le 22/03/2022 à 10:58, Laurent Vivier a écrit :
Le 15/03/2022 à 09:43, Richard Henderson a écrit :
On alpha, the sigset argument for sigsuspend is in a register.
When we drop that into memory that happens in host-endianness,
but target_to_host_old_sigset will treat it as target-endianness.
Sign
Le 15/03/2022 à 09:43, Richard Henderson a écrit :
Split out some helpers from sigsuspend.
Reuse them for pselect, epoll_pwait, ppoll.
Fix an alpha buglet found on the way.
r~
Richard Henderson (5):
linux-user/alpha: Fix sigsuspend for big-endian hosts
linux-user: Split out helpers for si
Le 10/03/2022 à 20:21, Patrick Venture a écrit :
From: Fergus Henderson
Signed-off-by: Fergus Henderson
Signed-off-by: Patrick Venture
---
linux-user/elfload.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index 9628a38361..
Le 14/03/2022 à 05:43, Richard Henderson a écrit :
This fallback syscall was stubbed out.
It would only matter for emulating pre-armv6.
Signed-off-by: Richard Henderson
---
linux-user/arm/cpu_loop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/arm/cpu_loop.c
Le 14/03/2022 à 05:43, Richard Henderson a écrit :
The existing implementation using start/end_exclusive
does not provide atomicity across processes.
Signed-off-by: Richard Henderson
---
linux-user/arm/cpu_loop.c | 85 +++
1 file changed, 60 insertions(+),
Le 15/03/2022 à 19:31, Richard Henderson a écrit :
On 3/15/22 11:18, Peter Maydell wrote:
-segv:
- end_exclusive();
- /* We get the PC of the entry address - which is as good as anything,
- on a real kernel what you get depends on which mode it uses. */
This comment about the PC th
From: laokz
Some qemu-iotests(040 etc) use PCI disk to do test. Without the
mapping, RISC-V flavor use spike as default machine which has no
PCI bus, causing test failure.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/894
Signed-off-by: Kai Zhang
Message-Id:
Reviewed-by: Alistair Fr
From: Stefano Garzarella
Commit d24f80234b ("block/rbd: increase dynamically the image size")
added a workaround to support growing images (eg. qcow2), resizing
the image before write operations that exceed the current size.
We recently added support for write zeroes and without the
workaround w
From: John Snow
qemu_img() returning zero ought to be the rule, not the
exception. Remove all explicit checks against the condition in
preparation for making non-zero returns an Exception.
Signed-off-by: John Snow
Reviewed-by: Eric Blake
Reviewed-by: Hanna Reitz
Message-Id: <20220321201618.90
The following changes since commit 330724977b10f5b92610817e8b7d1dfed122df87:
Merge tag 'pull-misc-2022-03-21' of git://repo.or.cz/qemu/armbru into staging
(2022-03-21 17:46:40 +)
are available in the Git repository at:
https://gitlab.com/hreitz/qemu.git tags/pull-block-2022-03-22
for y
From: Thomas Huth
These two spots have been missed in commit 9086c7639822 ("Rework the
checks and spots using GNU sed") - they need GNU sed, too, since they
are using the "+" address form.
Signed-off-by: Thomas Huth
Message-Id: <20220309101626.637836-1-th...@redhat.com>
Reviewed-by: Eric Blake
From: John Snow
Fortify compare_images() to be more discerning about the status codes it
receives. If qemu_img() returns an exit code that implies it didn't
actually perform the comparison, treat that as an exceptional
circumstance and force the caller to be aware of the peril.
If a negative tes
From: Thomas Huth
Quoting the TAP specification: "The plan tells how many tests will be
run [...]. It’s a check that the test file hasn’t stopped prematurely."
That's a good idea of course, so let's support that in the iotest
testrunner, too.
Signed-off-by: Thomas Huth
Message-Id: <202202230958
From: John Snow
This adds an Exception that extends the Python stdlib
subprocess.CalledProcessError.
The difference is that the str() method of this exception also adds the
stdout/stderr logs. In effect, if this exception goes unhandled, Python
will print the output in a visually distinct wrappe
From: Thomas Huth
If there is a failing iotest, the output is currently not logged to
the console anymore. To get this working again, we need to run the
meson test runner with "--print-errorlogs" (and without "--verbose"
due to a current meson bug that will be fixed here:
https://github.com/meson
From: John Snow
re-write qemu_img() as a function that will by default raise a
VerboseProcessException (extended from CalledProcessException) on
non-zero return codes. This will produce a stack trace that will show
the command line arguments and return code from the failed process run.
Users tha
From: John Snow
Similar to other recent changes: use the qemu_img() invocation that
supports throwing loud, nasty exceptions when it fails for surprising
reasons.
(Why would "--help" ever fail? I don't know, but eliminating *all* calls
to qemu-img that do not go through qemu_img() is my goal, so
From: John Snow
qemu_img_json() is a new helper built on top of qemu_img() that tries to
pull a valid JSON document out of the stdout stream.
In the event that the return code is negative (the program crashed), or
the code is greater than zero and did not produce valid JSON output, the
VerbosePr
From: John Snow
>>> print(add_visual_margin(msg, width=72, name="Commit Message"))
┏━ Commit Message ━━
┃ add_visual_margin() takes a chunk of text and wraps it in a visual
┃ container that force-wraps to a specified width. An optional title
┃ l
From: John Snow
qemu_img_pipe() discards the return code from qemu-img in favor of
returning just its output. Some tests using this function don't save,
log, or check the output either, though, which is unsafe.
Replace all of these calls with a checked version.
Tests affected are 194, 202, 203,
From: John Snow
This removes two more usages of qemu_img_pipe() and replaces them with
calls to qemu_img(), which provides better diagnostic information on
failure.
Signed-off-by: John Snow
Reviewed-by: Hanna Reitz
Message-Id: <20220321201618.903471-10-js...@redhat.com>
Signed-off-by: Hanna Re
From: John Snow
Admittedly a mostly lateral move, but qemu_img() is essentially the
replacement for qemu_img_pipe_and_status(). It will give slightly better
diagnostics on crash.
Signed-off-by: John Snow
Reviewed-by: Hanna Reitz
Message-Id: <20220321201618.903471-16-js...@redhat.com>
Signed-of
From: John Snow
As part of moving all python iotest invocations of qemu-img onto a
single qemu_img() implementation, remove a few lingering uses of
qemu_img_pipe() from outside of iotests.py itself.
Several cases here rely on the knowledge that qemu_img_pipe() suppresses
*all* output on a succes
From: John Snow
qemu_img_json() gives better diagnostic information on failure.
Signed-off-by: John Snow
Reviewed-by: Hanna Reitz
Message-Id: <20220321201618.903471-8-js...@redhat.com>
Signed-off-by: Hanna Reitz
---
tests/qemu-iotests/iotests.py | 8
1 file changed, 4 insertions(+),
From: John Snow
With the exceptional 'create' calls removed in the prior commit, change
qemu_img_log() and img_info_log() to call qemu_img() directly
instead.
For now, allow these calls to qemu-img to return non-zero on the basis
that any unusual output will be logged anyway. The very next commi
From: John Snow
Add a `check: bool = True` parameter to both functions and make their
qemu_img() invocations raise on error by default.
users of img_info_log:
206, 207, 210, 211, 212, 213, 237, 242, 266, 274, 302
users of qemu_img_log:
044, 209, 274, 302, 304
iotests 242 and 266 need to use ch
Allow filters for VM.run_job(), and pass the filters given to
VM.blockdev_create() to it.
(Use this opportunity to annotate VM.run_job()'s parameter types;
unfortunately, for the filter, I could not come up with anything better
than Callable[[Any], Any] that would pass mypy's scrutiny.)
At one po
From: John Snow
Add qemu_img_info() by analogy with qemu_img_measure() and
qemu_img_check(). Modify image_size() to use this function instead to
take advantage of the better diagnostic information on failure provided
(ultimately) by qemu_img().
Signed-off-by: John Snow
Reviewed-by: Hanna Reitz
From: John Snow
qemu_img_log() calls into qemu_img_pipe(), which always removes output
for 'create' commands on success anyway. Replace all of these calls to
the simpler qemu_img_create(...) which doesn't log, but raises a
detailed exception object on failure instead.
Blank lines are removed fro
From: John Snow
Add a qemu_img_map() function by analogy with qemu_img_measure(),
qemu_img_check(), and qemu_img_info() that all return JSON information.
Replace calls to qemu_img_pipe('map', '--output=json', ...) with this
new function, which provides better diagnostic information on failure.
On 21/3/22 23:08, Philippe Mathieu-Daudé wrote:
On 21/3/22 23:04, Philippe Mathieu-Daudé wrote:
On 21/3/22 15:14, Mark Kanda wrote:
Create KVM and HVF specific destory_vcpu_thread() routines to free
Typo "destroy"
env->xsave_buf.
vCPU hotunplug related leak reported by Valgrind:
==132362=
Commit e3296cc796aeaf319f3ed4e064ec309baf5e4da4 made the ssh block
driver's error message for fingerprint mismatches more verbose, so it
now prints the actual host key fingerprint and the key type.
iotest 207 tests such errors, but was not amended to filter that
fingerprint (which is host-specific
1 - 100 of 276 matches
Mail list logo
