Re: [PULL 0/8] s390x and misc fixes

On 15/03/2022 20.30, Peter Maydell wrote: On Tue, 15 Mar 2022 at 18:58, Peter Maydell wrote: On Tue, 15 Mar 2022 at 11:20, Thomas Huth wrote: Hi Peter! The following changes since commit 352998df1c53b366413690d95b35f76d0721ebed: Merge tag 'i2c-20220314' of https://github.com/philmd/q

Re: [PATCH] softmmu/physmem: Use qemu_madvise

On 16.03.22 05:04, Andrew Deason wrote: > We have a thin wrapper around madvise, called qemu_madvise, which > provides consistent behavior for the !CONFIG_MADVISE case, and works > around some platform-specific quirks (some platforms only provide > posix_madvise, and some don't offer all 'advise' t

Re: [PATCH v4 2/2] target/riscv: Enable Zicbo[m,z,p] instructions

On Wed, Feb 16, 2022 at 9:18 PM Christoph Muellner wrote: > > The RISC-V base cache management operation ISA extension has been > ratified. This patch adds support for the defined instructions. > > The cmo.prefetch instructions are nops for QEMU (no emulation of the memory > hierarchy, no illegal

[PULL v2 0/7] s390x and misc fixes

Hi Peter! The following changes since commit d6f229f9a0592c4d5beb0a5c4e024231c27680d3: Update version for v7.0.0-rc0 release (2022-03-15 23:07:40 +) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull-request-2022-03-15v2 for you to fetch changes up to

Re: [PATCH v1 5/8] mailmap/gitdm: more fixes for bad tags and authors

Alex Bennée writes: > I was running some historical tags for the last 10 years and got the > following warnings: > > git log --use-mailmap --numstat --since "June 2010" | ~/src/gitdm.git/gitdm > -n -l 5 > alar...@ddci.com is an author name, probably not what you want > bad utf-8 ('utf-8' co

Re: [PATCH v3 2/3] hw/i386/acpi-build: Avoid 'sun' identifier

On Tue, Mar 15, 2022 at 10:52:26PM -0500, Andrew Deason wrote: > On Solaris, 'sun' is #define'd to 1, which causes errors if a variable > is named 'sun'. Slightly change the name of the var for the Slot User > Number so we can build on Solaris. > > Reviewed-by: Ani Sinha > Signed-off-by: Andrew D

Re: [PATCH v3 0/3] Fixes for building on Solaris 11.4.42 CBE

On Tue, Mar 15, 2022 at 10:52:24PM -0500, Andrew Deason wrote: > With these minor fixes, I can build qemu on Solaris 11.4.42 CBE > (Oracle's new rolling release thing), using '--disable-rdma > --enable-modules --disable-dbus-display --target-list=x86_64-softmmu'. > I'm just interested in the guest

Re: [PATCH 1/4] target/i386: Fix sanity check on max APIC ID / X2APIC enablement

On Mon, 14 Mar 2022 14:25:41 + David Woodhouse wrote: > The check on x86ms->apic_id_limit in pc_machine_done() had two problems. > > Firstly, we need KVM to support the X2APIC API in order to allow IRQ > delivery to APICs >= 255. So we need to call/check kvm_enable_x2apic(), > which was done

Re: [PATCH v2 04/10] block.c: bdrv_replace_child_noperm: first remove the child, and then call ->detach()

Unfortunately this patch is not safe: theoretically ->detach can call bdrv_unapply_subtree_drain, and if it polls, will can call a bh that for example reads the graph, finding it in an inconsistent state, since it is between the two writes QLIST_REMOVE(child, next_parent); and QLIST_REMOVE(child, n

Re: [PATCH v2 05/10] block.c: bdrv_replace_child_noperm: first call ->attach(), and then add child

Unfortunately this patch is not safe: theoretically ->attach can call bdrv_apply_subtree_drain, and if it polls, will can call a bh that for example reads the graph, finding it in an inconsistent state, since it is between the two writes QLIST_INSERT_HEAD(&bs->children, child, next); and QLIST_INSE

Re: [PATCH] softmmu/physmem: Use qemu_madvise

On Wed, 16 Mar 2022 at 07:53, David Hildenbrand wrote: > > On 16.03.22 05:04, Andrew Deason wrote: > > We have a thin wrapper around madvise, called qemu_madvise, which > > provides consistent behavior for the !CONFIG_MADVISE case, and works > > around some platform-specific quirks (some platforms

[PATCH v2] MAINTAINERS: change Vladimir's email address

Old vsement...@virtuozzo.com is not accessible anymore. Signed-off-by: Vladimir Sementsov-Ogievskiy --- v2: @ya.ru mailbox works bad with mailing lists and git send-email command, @mail.ru works normally. Probably, I'll have to change the email again in the near future. May be not. But I think

Re: [PATCH] softmmu/physmem: Use qemu_madvise

* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Wed, 16 Mar 2022 at 07:53, David Hildenbrand wrote: > > > > On 16.03.22 05:04, Andrew Deason wrote: > > > We have a thin wrapper around madvise, called qemu_madvise, which > > > provides consistent behavior for the !CONFIG_MADVISE case, and wo

Re: [PATCH 2/4] intel_iommu: Support IR-only mode without DMA translation

On Mon, 2022-03-14 at 18:27 -0400, Michael S. Tsirkin wrote: > On Mon, Mar 14, 2022 at 03:45:47PM +, David Woodhouse wrote: > > It's the opposite of a feature — it's turning the feature *off* ;) > > Right. Still - do you believe it's appropriate in soft freeze > and if yes why? > Not sure I

[PATCH 00/27] Misc fixes and cleanups for 7.0?

From: Marc-André Lureau Hi, Various clean-up and fixes patches that might be worth it for 7.0. Some of the patches have been posted and reviewed before. Marc-André Lureau (27): m68k/nios2-semi: fix gettimeofday() result check meson: remove bsd_oses meson: use chardev_ss dependencies mes

[PATCH 01/27] m68k/nios2-semi: fix gettimeofday() result check

From: Marc-André Lureau gettimeofday() returns 0 for success. Signed-off-by: Marc-André Lureau Reviewed-by: Laurent Vivier Reviewed-by: Richard Henderson --- target/m68k/m68k-semi.c | 2 +- target/nios2/nios2-semi.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tar

[PATCH 06/27] Drop qemu_foo() socket API wrapper

From: Marc-André Lureau The socket API wrappers were initially introduced in commit 00aa0040 ("Wrap recv to avoid warnings"), but made redundant with commit a2d96af4 ("osdep: add wrappers for socket functions") which fixes the win32 declarations and thus removed the earlier warnings. Signed-off-

[PATCH 03/27] meson: use chardev_ss dependencies

From: Marc-André Lureau chardev subsystem/library doesn't use gnutls. Use the dedicated chardev_ss.dependencies() instead. Signed-off-by: Marc-André Lureau --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 784e91753630..f20712cb

[PATCH 04/27] meson: add util dependency for oslib-posix on freebsd

From: Marc-André Lureau kinfo_getproc() requires it. Signed-off-by: Marc-André Lureau --- util/meson.build | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/util/meson.build b/util/meson.build index f6ee74ad0c85..bb0b010662d7 100644 --- a/util/meson.build +++ b/util/meso

[PATCH 07/27] Replace GCC_FMT_ATTR with G_GNUC_PRINTF

From: Marc-André Lureau One less qemu-specific macro. It also helps to make some headers/units only depend on glib, and thus moved in standalone projects eventually. Signed-off-by: Marc-André Lureau --- audio/audio.h | 4 +-- block/qcow2.h |

Re: [PATCH 1/4] target/i386: Fix sanity check on max APIC ID / X2APIC enablement

On Wed, 2022-03-16 at 10:04 +0100, Igor Mammedov wrote: > Well, I retested with the latest upstream kernel (both guest and host), > and adding kvm_enable_x2apic() is not sufficient as guest according > to your patches in kernel caps max APICID at 255 unless kvm-msi-ext-dest-id > is enabled. And att

[PATCH 09/27] compiler.h: replace QEMU_SENTINEL with G_GNUC_NULL_TERMINATED

From: Marc-André Lureau One less qemu-specific macro. It also helps to make some headers/units only depend on glib, and thus moved in standalone projects eventually. Signed-off-by: Marc-André Lureau Reviewed-by: Richard Henderson --- include/qemu/compiler.h| 2 -- include/qom/object.h

[PATCH 11/27] osdep: poison HOST_WORDS_BIGENDIAN

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Suggested-by: Richard Henderson --- include/qemu/osdep.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h index 322103aadbdc..7175ee53a217 100644 --- a/include/qemu/osdep.h +++ b/inclu

[PATCH 08/27] compiler.h: replace QEMU_WARN_UNUSED_RESULT with G_GNUC_WARN_UNUSED_RESULT

From: Marc-André Lureau One less qemu-specific macro. It also helps to make some headers/units only depend on glib, and thus moved in standalone projects eventually. Signed-off-by: Marc-André Lureau Reviewed-by: Richard Henderson --- include/qemu-common.h | 2 +- include/qemu/compiler.h

[PATCH 10/27] Replace config-time define HOST_WORDS_BIGENDIAN

From: Marc-André Lureau Replace a config-time define with a compile time condition define (compatible with clang and gcc) that must be declared prior to its usage. This avoids having a global configure time define, but also prevents from bad usage, if the config header wasn't included before. Th

[PATCH 14/27] scripts/modinfo-collect: remove unused/dead code

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- scripts/modinfo-collect.py | 5 - 1 file changed, 5 deletions(-) diff --git a/scripts/modinfo-collect.py b/scripts/modinfo-collect.py index 61b90688c6dc..4e7584df6676 100755 --- a/scripts/modinfo-collect.py +++ b/scripts/modinfo-

[PATCH 12/27] Simplify HOST_LONG_BITS

From: Marc-André Lureau Simplify the macro, not depending on headers defines, but compiler predefined __SIZEOF__POINTER__ only. Available since gcc 4.3 and clang 2.8. Signed-off-by: Marc-André Lureau Acked-by: Richard Henderson --- include/qemu/osdep.h | 8 +--- 1 file changed, 1 inserti

[PATCH 13/27] Move HOST_LONG_BITS to compiler.h

From: Marc-André Lureau This will help to make common code independent. Signed-off-by: Marc-André Lureau Reviewed-by: Richard Henderson --- include/qemu/compiler.h | 3 +++ include/qemu/osdep.h| 3 --- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/qemu/compiler.h

[PATCH 15/27] util: remove needless includes

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Richard Henderson --- util/cutils.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/util/cutils.c b/util/cutils.c index c9b91e7535a8..53346138c970 100644 --- a/util/cutils.c +++ b/util/cutils.c @@ -27,8 +27,6 @@ #inclu

[PATCH 17/27] qapi: remove needless include

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Richard Henderson --- qapi/qmp-dispatch.c | 1 - 1 file changed, 1 deletion(-) diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c index d378bccac73b..0990873ec8ec 100644 --- a/qapi/qmp-dispatch.c +++ b/qapi/qmp-dispatch

[PATCH 16/27] util: remove the net/net.h dependency

From: Marc-André Lureau Move qemu_ether_ntoa() which is only needed in net/. Signed-off-by: Marc-André Lureau Reviewed-by: Richard Henderson Reviewed-by: Peter Maydell --- include/qemu-common.h | 1 - net/announce.c| 13 + util/cutils.c | 14 -- 3 fil

[PATCH 19/27] meson: fix CONFIG_ATOMIC128 check

From: Marc-André Lureau The current testing code isn't correct and matching QEMU usage: testfile.c: In function 'main': testfile.c:5:11: error: incorrect number of arguments to function '__atomic_load' 5 | y = __atomic_load(&x, 0); | ^ testfile.c:6:7: error

[PATCH 21/27] qga: remove bswap.h include

From: Marc-André Lureau Apparently not needed anymore. Signed-off-by: Marc-André Lureau --- qga/main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/qga/main.c b/qga/main.c index 15fd3a4149f4..b9dd19918e47 100644 --- a/qga/main.c +++ b/qga/main.c @@ -27,7 +27,6 @@ #include "qapi/qmp/qerr

[PATCH 20/27] qapi: remove needless include

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- qapi/string-output-visitor.c | 1 - 1 file changed, 1 deletion(-) diff --git a/qapi/string-output-visitor.c b/qapi/string-output-visitor.c index 5506c933deef..71ddc92b7b98 100644 --- a/qapi/string-output-visitor.c +++ b/qapi/string-o

[PATCH 25/27] include/qapi: add g_autoptr support for qobject types

From: Marc-André Lureau Add small inline wrappers for qobject_unref() calls, which is a macro. Signed-off-by: Marc-André Lureau --- include/qapi/qmp/qbool.h | 6 ++ include/qapi/qmp/qdict.h | 6 ++ include/qapi/qmp/qlist.h | 8 +++- include/qapi/qmp/qnull.h | 6 ++ incl

[PATCH 26/27] tests: replace free_all() usage with g_auto

From: Marc-André Lureau Use more idiomatic glib/auto-style code. Signed-off-by: Marc-André Lureau --- tests/unit/check-qobject.c | 127 - 1 file changed, 40 insertions(+), 87 deletions(-) diff --git a/tests/unit/check-qobject.c b/tests/unit/check-qobject.c

[PATCH 22/27] error-report: replace error progname with glib functions

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- include/qemu/error-report.h | 2 -- qemu-io.c| 10 +- softmmu/vl.c | 2 +- storage-daemon/qemu-storage-daemon.c | 2 +- trace/control.c | 2

[PATCH 27/27] qapi: remove needless include

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- qapi/qapi-forward-visitor.c | 1 - 1 file changed, 1 deletion(-) diff --git a/qapi/qapi-forward-visitor.c b/qapi/qapi-forward-visitor.c index 4ea7e0bec3f5..e36d9bc9ba7e 100644 --- a/qapi/qapi-forward-visitor.c +++ b/qapi/qapi-forward

[PATCH 23/27] tests: remove needless include

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- tests/unit/check-qobject.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/unit/check-qobject.c b/tests/unit/check-qobject.c index c1713d15af4e..c3d50e99949a 100644 --- a/tests/unit/check-qobject.c +++ b/tests/unit/check-qobj

[PATCH 24/27] Remove trailing ; after G_DEFINE_AUTO macro

From: Marc-André Lureau The macro doesn't need it. Signed-off-by: Marc-André Lureau --- configure| 2 +- nbd/server.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 9e9b85147a5f..6d9cb23ac562 100755 --- a/configure +++ b/configure @@ -224

Re: [PATCH 1/4] target/i386: Fix sanity check on max APIC ID / X2APIC enablement

On Wed, Mar 16, 2022 at 09:37:07AM +, David Woodhouse wrote: > On Wed, 2022-03-16 at 10:04 +0100, Igor Mammedov wrote: > > Well, I retested with the latest upstream kernel (both guest and host), > > and adding kvm_enable_x2apic() is not sufficient as guest according > > to your patches in kerne

Re: [PATCH 10/27] Replace config-time define HOST_WORDS_BIGENDIAN

On 16/03/2022 10.53, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Replace a config-time define with a compile time condition define (compatible with clang and gcc) that must be declared prior to its usage. This avoids having a global configure time define, but also prevents from b

Re: [PATCH] softmmu/physmem: Use qemu_madvise

On 16.03.22 10:37, Dr. David Alan Gilbert wrote: > * Peter Maydell (peter.mayd...@linaro.org) wrote: >> On Wed, 16 Mar 2022 at 07:53, David Hildenbrand wrote: >>> >>> On 16.03.22 05:04, Andrew Deason wrote: We have a thin wrapper around madvise, called qemu_madvise, which provides consis

[PATCH 02/27] meson: remove bsd_oses

From: Marc-André Lureau It is unused. Signed-off-by: Marc-André Lureau --- meson.build | 1 - 1 file changed, 1 deletion(-) diff --git a/meson.build b/meson.build index bae62efc9c33..784e91753630 100644 --- a/meson.build +++ b/meson.build @@ -44,7 +44,6 @@ config_host_data = configuration_dat

[PATCH 05/27] char: move qemu_openpty_raw from util/ to char/

From: Marc-André Lureau It is only needed by char-pty. Fix the code style while at it. Signed-off-by: Marc-André Lureau --- include/qemu-common.h | 2 - chardev/char-pty.c| 111 + util/qemu-openpty.c | 139 -- cha

[PATCH 18/27] meson: move int128 checks from configure

From: Marc-André Lureau (note: the test isn't working as intended, the next patches fixes it) Signed-off-by: Marc-André Lureau Reviewed-by: Richard Henderson --- configure | 47 --- meson.build | 39 +++ 2 files

[RFC PATCH] python: add qmp-send program to send raw qmp commands to qemu

It takes an input file containing raw qmp commands (concatenated json dicts) and send all commands one by one to a qmp server. When one command fails, it exits. As a convenience, it can also wrap the qemu process to avoid having to start qemu in background. When wrapping qemu, the program returns

Re: [PATCH 1/4] target/i386: Fix sanity check on max APIC ID / X2APIC enablement

On Wed, Mar 16, 2022 at 10:37:49AM +, David Woodhouse wrote: > On Wed, 2022-03-16 at 05:56 -0400, Michael S. Tsirkin wrote: > > On Wed, Mar 16, 2022 at 09:37:07AM +, David Woodhouse wrote: > > > Yep, that's the guest operating system's choice. Not a qemu problem. > > > > > > Even if you ha

Re: [PATCH 1/4] target/i386: Fix sanity check on max APIC ID / X2APIC enablement

On Wed, 2022-03-16 at 05:56 -0400, Michael S. Tsirkin wrote: > On Wed, Mar 16, 2022 at 09:37:07AM +, David Woodhouse wrote: > > Yep, that's the guest operating system's choice. Not a qemu problem. > > > > Even if you have the split IRQ chip, if you boot a guest without kvm- > > msi-ext-dest-id

Re: Time to introduce a migration protocol negotiation (Re: [PATCH v2 00/25] migration: Postcopy Preemption)

On Wed, Mar 16, 2022 at 11:30:59AM +0800, Peter Xu wrote: > On Tue, Mar 15, 2022 at 11:15:41AM +, Daniel P. Berrangé wrote: > > > I still remember you mentioned the upper layer softwares can have > > > assumption on using only 1 pair of socket for migration, I think that > > > makes > > > post

Re: [RFC PATCH] python: add qmp-send program to send raw qmp commands to qemu

On Wed, Mar 16, 2022 at 10:54:55AM +0100, Damien Hedde wrote: > It takes an input file containing raw qmp commands (concatenated json > dicts) and send all commands one by one to a qmp server. When one > command fails, it exits. > > As a convenience, it can also wrap the qemu process to avoid havi

Re: Time to introduce a migration protocol negotiation (Re: [PATCH v2 00/25] migration: Postcopy Preemption)

On Wed, Mar 16, 2022 at 09:59:28AM +, Daniel P. Berrangé wrote: > On Wed, Mar 16, 2022 at 11:30:59AM +0800, Peter Xu wrote: > > On Tue, Mar 15, 2022 at 11:15:41AM +, Daniel P. Berrangé wrote: > > > > I still remember you mentioned the upper layer softwares can have > > > > assumption on usi

Re: Time to introduce a migration protocol negotiation (Re: [PATCH v2 00/25] migration: Postcopy Preemption)

On Wed, Mar 16, 2022 at 06:40:08PM +0800, Peter Xu wrote: > On Wed, Mar 16, 2022 at 09:59:28AM +, Daniel P. Berrangé wrote: > > On Wed, Mar 16, 2022 at 11:30:59AM +0800, Peter Xu wrote: > > > On Tue, Mar 15, 2022 at 11:15:41AM +, Daniel P. Berrangé wrote: > > > > > I still remember you ment

Re: [PATCH] 9pfs: fix inode sequencing in 'synth' driver

On Mon, 14 Mar 2022 19:58:11 +0100 Christian Schoenebeck wrote: > The 'synth' driver's root node and the 'synth' driver's first > subdirectory node falsely share the same inode number (zero), which > makes it impossible for 9p clients (i.e. 9p test cases) to distinguish > root node and first subd

Re: [PATCH v3 0/4] HyperV: Synthetic Debugging device

Queued, thanks. Paolo

Re: [PATCH 10/27] Replace config-time define HOST_WORDS_BIGENDIAN

On Wed, 16 Mar 2022 11:28:59 +0100 Thomas Huth wrote: > On 16/03/2022 10.53, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Replace a config-time define with a compile time condition > > define (compatible with clang and gcc) that must be declared prior to > > its usage.

Re: [PATCH 10/27] Replace config-time define HOST_WORDS_BIGENDIAN

Hi On Wed, Mar 16, 2022 at 3:16 PM Halil Pasic wrote: > > On Wed, 16 Mar 2022 11:28:59 +0100 > Thomas Huth wrote: > > > On 16/03/2022 10.53, marcandre.lur...@redhat.com wrote: > > > From: Marc-André Lureau > > > > > > Replace a config-time define with a compile time condition > > > define (comp

Re: [PATCH 10/27] Replace config-time define HOST_WORDS_BIGENDIAN

On 16/03/2022 12.15, Halil Pasic wrote: On Wed, 16 Mar 2022 11:28:59 +0100 Thomas Huth wrote: On 16/03/2022 10.53, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Replace a config-time define with a compile time condition define (compatible with clang and gcc) that must be declar

Re: [PATCH 1/4] target/i386: Fix sanity check on max APIC ID / X2APIC enablement

On Wed, 16 Mar 2022 06:47:48 -0400 "Michael S. Tsirkin" wrote: > On Wed, Mar 16, 2022 at 10:37:49AM +, David Woodhouse wrote: > > On Wed, 2022-03-16 at 05:56 -0400, Michael S. Tsirkin wrote: > > > On Wed, Mar 16, 2022 at 09:37:07AM +, David Woodhouse wrote: > > > > Yep, that's the gue

Re: [PATCH v20 8/9] migration-test: Export migration-test util funtions

在 2022/3/16 12:09, Peter Xu 写道: On Wed, Mar 16, 2022 at 10:21:38AM +0800, huang...@chinatelecom.cn wrote: +void cleanup(const char *filename) +{ +g_autofree char *path = g_strdup_printf("%s/%s", tmpfs, filename); + +unlink(path); +} If to move most of these tmpfs helpers out anyway,

Re: [PATCH 10/27] Replace config-time define HOST_WORDS_BIGENDIAN

On Wed, 16 Mar 2022 13:53:07 +0400 marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Replace a config-time define with a compile time condition > define (compatible with clang and gcc) that must be declared prior to > its usage. This avoids having a global configure time define, b

Re: [PATCH 1/2] target/arm: Log M-profile vector table accesses

Peter Maydell writes: > Currently the CPU_LOG_INT logging misses some useful information > about loads from the vector table. Add logging where we load vector > table entries. This is particularly helpful for cases where the user > has accidentally not put a vector table in their image at all

Re: [PATCH v2] tests/avocado: starts PhoneServer upfront

Beraldo Leal writes: > Race conditions can happen with the current code, because the port that > was available might not be anymore by the time the server is started. > > By setting the port to 0, PhoneServer it will use the OS default > behavior to get a free port, then we save this informatio

Re: [PATCH 2/2] target/arm: Log fault address for M-profile faults

Peter Maydell writes: > For M-profile, the fault address is not always exposed to the guest > in a fault register (for instance the BFAR bus fault address register > is only updated for bus faults on data accesses, not instruction > accesses). Currently we log the address only if we're putting

Re: [PATCH 17/27] qapi: remove needless include

marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > Reviewed-by: Richard Henderson > --- > qapi/qmp-dispatch.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c > index d378bccac73b..0990873ec8ec 1

Re: [PATCH 07/27] Replace GCC_FMT_ATTR with G_GNUC_PRINTF

On Wed, Mar 16, 2022 at 01:52:48PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > One less qemu-specific macro. It also helps to make some headers/units > only depend on glib, and thus moved in standalone projects eventually. > > Signed-off-by: Marc-André Lureau I chec

Re: [PATCH 20/27] qapi: remove needless include

marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > qapi/string-output-visitor.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/qapi/string-output-visitor.c b/qapi/string-output-visitor.c > index 5506c933deef..71ddc92b7b98 100644 >

Re: [PATCH 22/27] error-report: replace error progname with glib functions

I'd prefer error: Use GLib to remember the program name marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster

Re: [PULL 0/8] s390x and misc fixes

On 3/15/22 19:58, Peter Maydell wrote: On Tue, 15 Mar 2022 at 11:20, Thomas Huth wrote: Hi Peter! The following changes since commit 352998df1c53b366413690d95b35f76d0721ebed: Merge tag 'i2c-20220314' of https://github.com/philmd/qemu into staging (2022-03-14 14:39:33 +) are availa

Re: [PATCH v2 4/6] vduse-blk: implements vduse-blk export

On Tue, Mar 15, 2022 at 07:52:03PM +0800, Yongji Xie wrote: > On Tue, Mar 15, 2022 at 7:08 PM Stefan Hajnoczi wrote: > > > > On Tue, Feb 15, 2022 at 06:59:41PM +0800, Xie Yongji wrote: > > > This implements a VDUSE block backends based on > > > the libvduse library. We can use it to export the BDS

Re: [PULL 0/8] s390x and misc fixes

On 3/15/22 20:30, Peter Maydell wrote: coredata.CoreData File "/Users/pm215/src/qemu-for-merges/meson/mesonbuild/coredata.py", line 1003, in load obj = pickle.load(f) File "/Users/pm215/src/qemu-for-merges/meson/mesonbuild/mesonlib/universal.py", line 2076, in __setstate__ self._

Re: [PATCH 23/27] tests: remove needless include

marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > tests/unit/check-qobject.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tests/unit/check-qobject.c b/tests/unit/check-qobject.c > index c1713d15af4e..c3d50e99949a 100644 > --- a

Re: [PATCH v2 1/6] block: Support passing NULL ops to blk_set_dev_ops()

On Tue, Mar 15, 2022 at 03:30:22PM -0400, John Snow wrote: > On Tue, Mar 15, 2022 at 4:47 AM Stefan Hajnoczi wrote: > > > > On Mon, Mar 14, 2022 at 03:09:35PM -0400, John Snow wrote: > > > On Mon, Mar 14, 2022 at 1:23 PM Stefan Hajnoczi > > > wrote: > > > > > > > > On Tue, Feb 15, 2022 at 06:59:

Re: [PULL 0/8] s390x and misc fixes

On 3/15/22 19:58, Peter Maydell wrote: This results in every "Linking" step on my macos box producing the warning: ld: warning: directory not found for option '-Lns/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/12.0.0' This was reported already back in January

Re: [PATCH experiment 00/16] C++20 coroutine backend

On Tue, Mar 15, 2022 at 06:29:50PM +0100, Paolo Bonzini wrote: > On 3/15/22 15:24, Peter Maydell wrote: > > On Tue, 15 Mar 2022 at 14:09, Stefan Hajnoczi wrote: > > > Also, once C++ is available people will > > > start submitting C++ patches simply because they are more comfortable > > > with C++

Re: [PATCH 25/27] include/qapi: add g_autoptr support for qobject types

marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Add small inline wrappers for qobject_unref() calls, which is a macro. > > Signed-off-by: Marc-André Lureau > --- > include/qapi/qmp/qbool.h | 6 ++ > include/qapi/qmp/qdict.h | 6 ++ > include/qapi/qmp/qlist.h | 8

Re: [PULL v2 0/7] s390x and misc fixes

On Wed, 16 Mar 2022 at 08:14, Thomas Huth wrote: > > Hi Peter! > > The following changes since commit d6f229f9a0592c4d5beb0a5c4e024231c27680d3: > > Update version for v7.0.0-rc0 release (2022-03-15 23:07:40 +) > > are available in the Git repository at: > > https://gitlab.com/thuth/qemu.g

[PATCH-for-7.0] qga/vss-win32: fix compilation with clang++

Compiling with clang++ of msys2 toolchain clang64 leads to an error on initializing 'char*' variable nul with a 'const char*' value Signed-off-by: Helge Konetzka --- Compiling with clang++ of msys2 toolchain clang64 leads to [1445/1747] Compiling C++ object qga/vss-win32/qga-vss.dll.p/install.c

Re: [PATCH 27/27] qapi: remove needless include

marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > qapi/qapi-forward-visitor.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/qapi/qapi-forward-visitor.c b/qapi/qapi-forward-visitor.c > index 4ea7e0bec3f5..e36d9bc9ba7e 100644 > --

Re: [PATCH 25/27] include/qapi: add g_autoptr support for qobject types

Hi On Wed, Mar 16, 2022 at 4:31 PM Markus Armbruster wrote: > > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > Add small inline wrappers for qobject_unref() calls, which is a macro. > > > > Signed-off-by: Marc-André Lureau > > --- > > include/qapi/qmp/qbool.h | 6 +

[PATCH] docs/tcg-plugins: document QEMU_PLUGIN behaviour

QEMU plugins can be loaded via command line arguments or via the QEMU_PLUGIN environment variable. Currently, only the first method is documented. Let's document QEMU_PLUGIN. Signed-off-by: Christoph Muellner --- docs/devel/tcg-plugins.rst | 4 1 file changed, 4 insertions(+) diff --git a/

Re: [PATCH experiment 00/16] C++20 coroutine backend

On Wed, Mar 16, 2022 at 12:08:33AM +0100, Paolo Bonzini wrote: > On 3/15/22 16:55, Daniel P. Berrangé wrote: > > Expecting maintainers to enforce a subset during code review feels > > like it would be a tedious burden, that will inevitably let stuff > > through because humans are fallible, especial

Re: [PATCH 26/27] tests: replace free_all() usage with g_auto

marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Use more idiomatic glib/auto-style code. > > Signed-off-by: Marc-André Lureau This is a bit of an improvement, but by its own, it's a rather weak justification for the previous patch. Do you have more uses of g_autoptr in the pi

Re: [PULL 21/50] block/block-backend.c: assertions for block-backend

Hi, On 4/3/22 17:46, Kevin Wolf wrote: From: Emanuele Giuseppe Esposito All the global state (GS) API functions will check that qemu_in_main_thread() returns true. If not, it means that the safety of BQL cannot be guaranteed, and they need to be moved to I/O. I'm getting this crash: $ qemu-

Re: [PULL 21/50] block/block-backend.c: assertions for block-backend

On 16/3/22 13:44, Philippe Mathieu-Daudé wrote: Hi, On 4/3/22 17:46, Kevin Wolf wrote: From: Emanuele Giuseppe Esposito All the global state (GS) API functions will check that qemu_in_main_thread() returns true. If not, it means that the safety of BQL cannot be guaranteed, and they need to be

Re: [PATCH-for-7.0] qga/vss-win32: fix compilation with clang++

On 16/3/22 13:31, Helge Konetzka wrote: Compiling with clang++ of msys2 toolchain clang64 leads to an error on initializing 'char*' variable nul with a 'const char*' value Can you include the error message in the description? I.e.: ''' This fixes: qga/vss-win32/install.cpp:49:24: error: cann

Re: [PATCH 0/2] target/arm: Improve M-profile exception logging

On 15/3/22 21:43, Peter Maydell wrote: Our current logging for M-profile exceptions has a couple of holes which are particularly confusing for the case of an exception taken immediately out of reset: * we don't log the initial PC/SP loaded from the vector table * we don't log the PC we load f

Re: [PATCH 25/27] include/qapi: add g_autoptr support for qobject types

Marc-André Lureau writes: > Hi > > On Wed, Mar 16, 2022 at 4:31 PM Markus Armbruster wrote: >> >> marcandre.lur...@redhat.com writes: >> >> > From: Marc-André Lureau >> > >> > Add small inline wrappers for qobject_unref() calls, which is a macro. >> > >> > Signed-off-by: Marc-André Lureau >> >

Re: [PATCH 26/27] tests: replace free_all() usage with g_auto

Hi On Wed, Mar 16, 2022 at 4:33 PM Markus Armbruster wrote: > > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > Use more idiomatic glib/auto-style code. > > > > Signed-off-by: Marc-André Lureau > > This is a bit of an improvement, but by its own, it's a rather weak > j

Re: [PATCH-for-7.0] qga/vss-win32: fix compilation with clang++

On Wed, Mar 16, 2022 at 4:41 PM Helge Konetzka wrote: > Compiling with clang++ of msys2 toolchain clang64 leads to an error > on initializing 'char*' variable nul with a 'const char*' value > > Signed-off-by: Helge Konetzka > Reviewed-by: Marc-André Lureau > --- > Compiling with clang++ of m

Re: [PATCH 10/27] Replace config-time define HOST_WORDS_BIGENDIAN

On 16/3/22 10:53, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Replace a config-time define with a compile time condition define (compatible with clang and gcc) that must be declared prior to its usage. This avoids having a global configure time define, but also prevents from bad

[PATCH v21 2/9] cpus: Introduce cpu_list_generation_id

From: Hyman Huang(黄勇) Introduce cpu_list_generation_id to track cpu list generation so that cpu hotplug/unplug can be detected during measurement of dirty page rate. cpu_list_generation_id could be used to detect changes of cpu list, which is prepared for dirty page rate measurement. Signed-off

Re: [PULL 21/50] block/block-backend.c: assertions for block-backend

Hi Philippe, How did you trigger this? What is the call stack? >From a first look, all callers of blk_all_next also call GLOBAL_STATE_CODE, except qmp_* functions. That would be useful to understand if we need to change the function assertion and classification, or the caller is breaking some inv

Re: [PATCH 26/27] tests: replace free_all() usage with g_auto

Marc-André Lureau writes: > Hi > > On Wed, Mar 16, 2022 at 4:33 PM Markus Armbruster wrote: >> >> marcandre.lur...@redhat.com writes: >> >> > From: Marc-André Lureau >> > >> > Use more idiomatic glib/auto-style code. >> > >> > Signed-off-by: Marc-André Lureau >> >> This is a bit of an improvem

Re: [PATCH v2] target/riscv: write back unmodified value for csrrc/csrrs with rs1 is not x0 but holding zero

On Fri, Mar 11, 2022 at 5:46 PM Weiwei Li wrote: > > For csrrs and csrrc, if rs1 specifies a register other than x0, holding > a zero value, the instruction will still attempt to write the unmodified > value back to the csr and will cause side effects > > v2: > * change to explictly pass "bool wri

Re: [PATCH experiment 00/16] C++20 coroutine backend

On Wed, Mar 16, 2022 at 12:32:48PM +, Stefan Hajnoczi wrote: > On Tue, Mar 15, 2022 at 06:29:50PM +0100, Paolo Bonzini wrote: > > On 3/15/22 15:24, Peter Maydell wrote: > > > On Tue, 15 Mar 2022 at 14:09, Stefan Hajnoczi wrote: > > > > Also, once C++ is available people will > > > > start subm

[PATCH v21 7/9] softmmu/dirtylimit: Implement dirty page rate limit

From: Hyman Huang(黄勇) Implement dirtyrate calculation periodically basing on dirty-ring and throttle virtual CPU until it reachs the quota dirty page rate given by user. Introduce qmp commands "set-vcpu-dirty-limit", "cancel-vcpu-dirty-limit", "query-vcpu-dirty-limit" to enable, disable, query d

Re: [PATCH] audio/mixeng: Do not declare unused variables

On 16/3/22 07:10, Akihiko Odaki wrote: The unused variables when FLOAT_MIXENG is defined caused warnings on Apple clang version 13.1.6 (clang-1316.0.21.2). Signed-off-by: Akihiko Odaki --- audio/mixeng.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Philippe Ma

[PATCH v21 9/9] tests: Add dirty page rate limit test

From: Hyman Huang(黄勇) Add dirty page rate limit test if kernel support dirty ring, create a standalone file to implement the test case. The following qmp commands are covered by this test case: "calc-dirty-rate", "query-dirty-rate", "set-vcpu-dirty-limit", "cancel-vcpu-dirty-limit" and "query-vc

[PATCH v21 1/9] accel/kvm/kvm-all: Refactor per-vcpu dirty ring reaping

From: Hyman Huang(黄勇) Add a non-required argument 'CPUState' to kvm_dirty_ring_reap so that it can cover single vcpu dirty-ring-reaping scenario. Signed-off-by: Hyman Huang(黄勇) Reviewed-by: Peter Xu --- accel/kvm/kvm-all.c | 23 +-- 1 file changed, 13 insertions(+), 10 del

  1   2   3   >