Re: [PATCH 20/20] tests: Add postcopy preempt test

2022-02-22 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Two tests are added: a normal postcopy preempt test, and a recovery test. Yes, this is difficult; without hugepages the tests are limited; did you see if this test actually causes pages to go down the fast path? Reviewed-by: Dr. David Alan Gilbert > Sig

Re: [PATCH RFC 4/4] rtc: Have event RTC_CHANGE identify the RTC by QOM path

2022-02-22 Thread Philippe Mathieu-Daudé
Hi Markus, On 22/2/22 13:02, Markus Armbruster wrote: Event RTC_CHANGE is "emitted when the guest changes the RTC time" (and the RTC supports the event). What if there's more than one RTC? w.r.t. RTC, a machine having multiple RTC devices is silly... Assuming one wants to emulate that; shoul

Re: [PULL v3 00/29] Misc mostly build system patches for 2022-02-15

2022-02-22 Thread Peter Maydell
On Mon, 21 Feb 2022 at 10:39, Paolo Bonzini wrote: > > The following changes since commit ad38520bdeb2b1e0b487db317f29119e94c1c88d: > > Merge remote-tracking branch > 'remotes/stefanha-gitlab/tags/block-pull-request' into staging (2022-02-15 > 19:30:33 +) > > are available in the Git repos

Re: [PATCH RFC 4/4] rtc: Have event RTC_CHANGE identify the RTC by QOM path

2022-02-22 Thread Peter Maydell
On Tue, 22 Feb 2022 at 12:56, Philippe Mathieu-Daudé wrote: > On 22/2/22 13:02, Markus Armbruster wrote: > > Event RTC_CHANGE is "emitted when the guest changes the RTC time" (and > > the RTC supports the event). What if there's more than one RTC? > > w.r.t. RTC, a machine having multiple RTC dev

Re: [PATCH v4 4/4] cpus: use coroutine TLS macros for iothread_locked

2022-02-22 Thread Stefan Hajnoczi
On Mon, Feb 21, 2022 at 04:09:06PM +0100, Philippe Mathieu-Daudé wrote: > On 21/2/22 15:29, Stefan Hajnoczi wrote: > > qemu_mutex_iothread_locked() may be used from coroutines. Standard > > __thread variables cannot be used by coroutines. Use the coroutine TLS > > macros instead. > > > > Signed-of

Re: [PULL v2 5/5] 9pfs: Fix segfault in do_readdir_many caused by struct dirent overread

2022-02-22 Thread Peter Maydell
On Thu, 17 Feb 2022 at 16:43, Christian Schoenebeck wrote: > diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h > index d1660d67fa..ce12f64853 100644 > --- a/include/qemu/osdep.h > +++ b/include/qemu/osdep.h > @@ -805,6 +805,19 @@ static inline int platform_does_not_support_system(const > c

Re: [PATCH v4 1/4] tls: add macros for coroutine-safe TLS variables

2022-02-22 Thread Stefan Hajnoczi
On Mon, Feb 21, 2022 at 03:16:22PM +, Peter Maydell wrote: > On Mon, 21 Feb 2022 at 14:29, Stefan Hajnoczi wrote: > > > > Compiler optimizations can cache TLS values across coroutine yield > > points, resulting in stale values from the previous thread when a > > coroutine is re-entered by a ne

[PATCH] vl: Fixup mismatching ram size

2022-02-22 Thread lichun
There is a mismatch between 'memory-backend' and '-m 0'(implicitly). Signed-off-by: lichun <706701...@qq.com> --- softmmu/vl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/softmmu/vl.c b/softmmu/vl.c index 1fe028800f..70eb2e53e9 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c @@ -2110,6 +21

Re: [PULL v2 5/5] 9pfs: Fix segfault in do_readdir_many caused by struct dirent overread

2022-02-22 Thread Christian Schoenebeck
On Dienstag, 22. Februar 2022 14:21:52 CET Peter Maydell wrote: > On Thu, 17 Feb 2022 at 16:43, Christian Schoenebeck > > wrote: > > diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h > > index d1660d67fa..ce12f64853 100644 > > --- a/include/qemu/osdep.h > > +++ b/include/qemu/osdep.h > > @

[PATCH v5 0/4] tls: add macros for coroutine-safe TLS variables

2022-02-22 Thread Stefan Hajnoczi
v5: - Added explicit "#include "qemu/coroutine-tls.h" in patch 4 [Philippe] - Updated patch 1 commit description and comments to describe the current noinline plus asm volatile approach [Peter] v4: - Dropped '[RFC]'. - Dropped inline asm for now. -fPIC versions of the code are missing and I hit

[PATCH v5 2/4] util/async: replace __thread with QEMU TLS macros

2022-02-22 Thread Stefan Hajnoczi
QEMU TLS macros must be used to make TLS variables safe with coroutines. Signed-off-by: Stefan Hajnoczi --- util/async.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/util/async.c b/util/async.c index 08d25feef5..2ea1172f3e 100644 --- a/util/async.c +++ b/util/

[PATCH v5 4/4] cpus: use coroutine TLS macros for iothread_locked

2022-02-22 Thread Stefan Hajnoczi
qemu_mutex_iothread_locked() may be used from coroutines. Standard __thread variables cannot be used by coroutines. Use the coroutine TLS macros instead. Signed-off-by: Stefan Hajnoczi --- softmmu/cpus.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/softmmu/cpus.c

[PATCH v5 3/4] rcu: use coroutine TLS macros

2022-02-22 Thread Stefan Hajnoczi
RCU may be used from coroutines. Standard __thread variables cannot be used by coroutines. Use the coroutine TLS macros instead. Signed-off-by: Stefan Hajnoczi --- include/qemu/rcu.h | 7 --- tests/unit/rcutorture.c| 10 +- tests/unit/test-rcu-list.c | 4 ++-- util/rcu.

[PATCH v5 1/4] tls: add macros for coroutine-safe TLS variables

2022-02-22 Thread Stefan Hajnoczi
Compiler optimizations can cache TLS values across coroutine yield points, resulting in stale values from the previous thread when a coroutine is re-entered by a new thread. Serge Guelton developed an __attribute__((noinline)) wrapper and tested it with clang and gcc. I formatted his idea accordin

[Bug 1772165] Re: arm raspi2/raspi3 emulation has no USB support

2022-02-22 Thread Carlo Bramini
I'm also trying to run QEMU for emulating Raspberry PI, but I'm still unable to make working external USB devices like keyboard and mouse. Unlike previous users, I'm not using a linux distro but Microsoft Windows 10 instead. I'm using the precompiled 64bit executables downloaded from https://qem

[PATCH resend 0/2] kvm/msi: do explicit commit when adding msi routes

2022-02-22 Thread Longpeng(Mike)
From: Longpeng This patchset moves the call to kvm_irqchip_commit_routes() out of kvm_irqchip_add_msi_route(). An optimization of vfio migration [1] depends on this changes. [1] https://lists.gnu.org/archive/html/qemu-devel/2021-11/msg00968.html Longpeng (Mike) (2): kvm-irqchip: introduce new

[PATCH resend 1/2] kvm-irqchip: introduce new API to support route change

2022-02-22 Thread Longpeng(Mike)
From: Longpeng Paolo suggested adding the new API to support route changes [1]. We should invoke kvm_irqchip_begin_route_changes() before changing the routes, increasing the KVMRouteChange.changes if the routes are changed, and commit the changes at last. [1] https://lists.gnu.org/archive/html

[PATCH resend 2/2] kvm/msi: do explicit commit when adding msi routes

2022-02-22 Thread Longpeng(Mike)
From: Longpeng We invoke the kvm_irqchip_commit_routes() for each addition to MSI route table, which is not efficient if we are adding lots of routes in some cases. This patch lets callers invoke the kvm_irqchip_commit_routes(), so the callers can decide how to optimize. [1] https://lists.gnu.o

Re: [PATCH v8 09/11] 9p: darwin: Implement compatibility for mknodat

2022-02-22 Thread Christian Schoenebeck
On Sonntag, 20. Februar 2022 17:50:54 CET Will Cohen wrote: > From: Keno Fischer > > Darwin does not support mknodat. However, to avoid race conditions > with later setting the permissions, we must avoid using mknod on > the full path instead. We could try to fchdir, but that would cause > proble

[PATCH v4 01/47] target/ppc: Introduce TRANS*FLAGS macros

2022-02-22 Thread matheus . ferst
From: Luis Pires New macros that add FLAGS and FLAGS2 checking were added for both TRANS and TRANS64. Reviewed-by: Richard Henderson Signed-off-by: Luis Pires [ferst: - TRANS_FLAGS2 instead of TRANS_FLAGS_E - Use the new macros in load/store vector insns ] Signed-off-by: Matheus Ferst

[PATCH v4 03/47] target/ppc: Moved vector multiply high and low to decodetree

2022-02-22 Thread matheus . ferst
From: "Lucas Mateus Castro (alqotel)" Moved instructions vmulld, vmulhuw, vmulhsw, vmulhud and vmulhsd to decodetree Signed-off-by: Lucas Mateus Castro (alqotel) Signed-off-by: Matheus Ferst --- target/ppc/helper.h | 8 target/ppc/insn32.decode| 6 ++

[PATCH v4 11/47] target/ppc: Implement Vector Compare Equal Quadword

2022-02-22 Thread matheus . ferst
From: Matheus Ferst Implement the following PowerISA v3.1 instructions: vcmpequq: Vector Compare Equal Quadword Suggested-by: Richard Henderson Signed-off-by: Matheus Ferst --- v4: - Branchless implementation (rth) --- target/ppc/insn32.decode| 1 + target/ppc/translate/vmx-impl

[PATCH v4 10/47] target/ppc: Move Vector Compare Not Equal or Zero to decodetree

2022-02-22 Thread matheus . ferst
From: Matheus Ferst Signed-off-by: Matheus Ferst --- target/ppc/helper.h | 9 ++-- target/ppc/insn32.decode| 4 ++ target/ppc/int_helper.c | 50 +- target/ppc/translate/vmx-impl.c.inc | 66 +++-- target/ppc/tr

[PATCH v4 00/47] target/ppc: PowerISA Vector/VSX instruction batch

2022-02-22 Thread matheus . ferst
From: Matheus Ferst This patch series implements 5 missing instructions from PowerISA v3.0 and 56 new instructions from PowerISA v3.1, moving 87 other instructions to decodetree along the way. Patches without review: 2-5, 7, 9-12, 14-16, 18-36, 38-47. This series can also be found at: https://g

[PATCH v4 05/47] target/ppc: Implement vmsumcud instruction

2022-02-22 Thread matheus . ferst
From: Víctor Colombo Based on [1] by Lijun Pan , which was never merged into master. [1]: https://lists.gnu.org/archive/html/qemu-ppc/2020-07/msg00419.html Signed-off-by: Víctor Colombo Signed-off-by: Matheus Ferst --- Changes in v4: Fixed dead move into tmp1 --- target/ppc/insn32.decode

[PATCH v4 12/47] target/ppc: Implement Vector Compare Greater Than Quadword

2022-02-22 Thread matheus . ferst
From: Matheus Ferst Implement the following PowerISA v3.1 instructions: vcmpgtsq: Vector Compare Greater Than Signed Quadword vcmpgtuq: Vector Compare Greater Than Unsigned Quadword Signed-off-by: Matheus Ferst --- v4: - Branchless implementation (rth) --- target/ppc/insn32.decode

[PATCH v4 16/47] target/ppc: implement vclrrb

2022-02-22 Thread matheus . ferst
From: Matheus Ferst Signed-off-by: Matheus Ferst --- target/ppc/insn32.decode| 1 + target/ppc/translate/vmx-impl.c.inc | 32 + 2 files changed, 25 insertions(+), 8 deletions(-) diff --git a/target/ppc/insn32.decode b/target/ppc/insn32.decode index 31cd

[PATCH v4 04/47] target/ppc: vmulh* instructions without helpers

2022-02-22 Thread matheus . ferst
From: "Lucas Mateus Castro (alqotel)" Changed vmulhuw, vmulhud, vmulhsw, vmulhsd to not use helpers. Signed-off-by: Lucas Mateus Castro (alqotel) Signed-off-by: Matheus Ferst --- Changes in v4: Changed from gvec to i64, this resulted in a better performance on a Power host for all 4 instructio

[PATCH v4 02/47] target/ppc: moved vector even and odd multiplication to decodetree

2022-02-22 Thread matheus . ferst
From: "Lucas Mateus Castro (alqotel)" Moved the instructions vmulesb, vmulosb, vmuleub, vmuloub, vmulesh, vmulosh, vmuleuh, vmulouh, vmulesw, vmulosw, muleuw and vmulouw from legacy to decodetree. Implemented the instructions vmulesd, vmulosd, vmuleud, vmuloud. Signed-off-by: Lucas Mateus Castro

[PATCH v4 14/47] target/ppc: implement vstri[bh][lr]

2022-02-22 Thread matheus . ferst
From: Matheus Ferst Signed-off-by: Matheus Ferst --- v4: - vstri helpers return CR field (rth) --- target/ppc/helper.h | 4 target/ppc/insn32.decode| 10 ++ target/ppc/int_helper.c | 28 +++ target/ppc/translate/vmx-

[PATCH v4 22/47] target/ppc: implement vsraq

2022-02-22 Thread matheus . ferst
From: Matheus Ferst Signed-off-by: Matheus Ferst --- v4: - New in v4. --- target/ppc/insn32.decode| 1 + target/ppc/translate/vmx-impl.c.inc | 17 + 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/target/ppc/insn32.decode b/target/ppc/insn32.decode

[PATCH v4 08/47] target/ppc: Implement vextsd2q

2022-02-22 Thread matheus . ferst
From: Lucas Coutinho Reviewed-by: Richard Henderson Signed-off-by: Lucas Coutinho Signed-off-by: Matheus Ferst --- target/ppc/insn32.decode| 1 + target/ppc/translate/vmx-impl.c.inc | 18 ++ 2 files changed, 19 insertions(+) diff --git a/target/ppc/insn32.decode

[PATCH v4 07/47] target/ppc: Move vexts[bhw]2[wd] to decodetree

2022-02-22 Thread matheus . ferst
From: Lucas Coutinho Move the following instructions to decodetree: vextsb2w: Vector Extend Sign Byte To Word vextsh2w: Vector Extend Sign Halfword To Word vextsb2d: Vector Extend Sign Byte To Doubleword vextsh2d: Vector Extend Sign Halfword To Doubleword vextsw2d: Vector Extend Sign Word To Doub

[PATCH v4 17/47] target/ppc: implement vcntmb[bhwd]

2022-02-22 Thread matheus . ferst
From: Matheus Ferst Reviewed-by: Richard Henderson Signed-off-by: Matheus Ferst --- target/ppc/insn32.decode| 8 target/ppc/translate/vmx-impl.c.inc | 32 + 2 files changed, 40 insertions(+) diff --git a/target/ppc/insn32.decode b/target/ppc/i

[PATCH v4 25/47] target/ppc: implement vrlq

2022-02-22 Thread matheus . ferst
From: Matheus Ferst Signed-off-by: Matheus Ferst --- v4: - New in v4. --- target/ppc/insn32.decode| 1 + target/ppc/translate/vmx-impl.c.inc | 49 + 2 files changed, 50 insertions(+) diff --git a/target/ppc/insn32.decode b/target/ppc/insn32.decode ind

[PATCH v4 06/47] target/ppc: Implement vmsumudm instruction

2022-02-22 Thread matheus . ferst
From: Víctor Colombo Based on [1] by Lijun Pan , which was never merged into master. [1]: https://lists.gnu.org/archive/html/qemu-ppc/2020-07/msg00419.html Reviewed-by: Richard Henderson Signed-off-by: Víctor Colombo Signed-off-by: Matheus Ferst --- target/ppc/insn32.decode| 1

Re: [PATCH] hw/acpi: Set memory regions to native endian as a work around

2022-02-22 Thread Michael S. Tsirkin
On Wed, Jan 19, 2022 at 04:19:14AM -0500, Michael S. Tsirkin wrote: > On Sat, Nov 13, 2021 at 07:47:20PM +0100, BALATON Zoltan wrote: > > On Mon, 8 Nov 2021, BALATON Zoltan wrote: > > > On Mon, 8 Nov 2021, Paolo Bonzini wrote: > > > > On 11/8/21 15:30, Paolo Bonzini wrote: > > > > > On 11/8/21 14:0

[PATCH v4 09/47] target/ppc: Move Vector Compare Equal/Not Equal/Greater Than to decodetree

2022-02-22 Thread matheus . ferst
From: Matheus Ferst Signed-off-by: Matheus Ferst --- target/ppc/helper.h | 30 -- target/ppc/insn32.decode| 24 target/ppc/int_helper.c | 54 - target/ppc/translate/vmx-impl.c.inc | 89 - target

[PATCH v4 20/47] target/ppc: implement vslq

2022-02-22 Thread matheus . ferst
From: Matheus Ferst Signed-off-by: Matheus Ferst --- v4: - New in v4. --- target/ppc/insn32.decode| 1 + target/ppc/translate/vmx-impl.c.inc | 40 + 2 files changed, 41 insertions(+) diff --git a/target/ppc/insn32.decode b/target/ppc/insn32.decode ind

[PATCH v4 30/47] target/ppc: Implement xxpermx instruction

2022-02-22 Thread matheus . ferst
From: Matheus Ferst Signed-off-by: Matheus Ferst --- target/ppc/helper.h | 1 + target/ppc/insn64.decode| 8 target/ppc/int_helper.c | 20 target/ppc/translate/vsx-impl.c.inc | 22 ++ 4 files changed, 51

Re: [PATCH v2] iotests: Write test output to TEST_DIR

2022-02-22 Thread Vladimir Sementsov-Ogievskiy
21.02.2022 20:29, Hanna Reitz wrote: Drop the use of OUTPUT_DIR (test/qemu-iotests under the build directory), and instead write test output files (.out.bad, .notrun, and .casenotrun) to TEST_DIR. With this, the same test can be run concurrently without the separate instances interfering, becaus

[PATCH v4 19/47] target/ppc: move vs[lr][a][bhwd] to decodetree

2022-02-22 Thread matheus . ferst
From: Matheus Ferst Signed-off-by: Matheus Ferst --- v4: - New in v4. --- target/ppc/insn32.decode| 17 target/ppc/translate/vmx-impl.c.inc | 41 +++-- target/ppc/translate/vmx-ops.c.inc | 13 + 3 files changed, 45 insertions(+), 26 de

[PATCH v4 34/47] target/ppc: move xs[n]madd[am][ds]p/xs[n]msub[am][ds]p to decodetree

2022-02-22 Thread matheus . ferst
From: Matheus Ferst Signed-off-by: Matheus Ferst --- target/ppc/fpu_helper.c | 23 ++-- target/ppc/helper.h | 16 - target/ppc/insn32.decode| 22 target/ppc/translate/vsx-impl.c.inc | 56 - target/p

[PATCH v4 13/47] target/ppc: Implement Vector Compare Quadword

2022-02-22 Thread matheus . ferst
From: Matheus Ferst Implement the following PowerISA v3.1 instructions: vcmpsq: Vector Compare Signed Quadword vcmpuq: Vector Compare Unsigned Quadword Reviewed-by: Richard Henderson Signed-off-by: Matheus Ferst --- target/ppc/insn32.decode| 6 target/ppc/translate/vmx-impl.

[PATCH v4 21/47] target/ppc: implement vsrq

2022-02-22 Thread matheus . ferst
From: Matheus Ferst Signed-off-by: Matheus Ferst --- v4: - New in v4. --- target/ppc/insn32.decode| 1 + target/ppc/translate/vmx-impl.c.inc | 40 + 2 files changed, 31 insertions(+), 10 deletions(-) diff --git a/target/ppc/insn32.decode b/target/ppc/

[PATCH v4 15/47] target/ppc: implement vclrlb

2022-02-22 Thread matheus . ferst
From: Matheus Ferst Signed-off-by: Matheus Ferst --- v4: - Branchless implementation (rth) --- target/ppc/insn32.decode| 2 ++ target/ppc/translate/vmx-impl.c.inc | 40 + 2 files changed, 42 insertions(+) diff --git a/target/ppc/insn32.decode b/target/

[PATCH v4 26/47] target/ppc: Move vsel and vperm/vpermr to decodetree

2022-02-22 Thread matheus . ferst
From: Matheus Ferst Signed-off-by: Matheus Ferst --- target/ppc/helper.h | 5 +-- target/ppc/insn32.decode| 5 +++ target/ppc/int_helper.c | 13 +- target/ppc/translate/vmx-impl.c.inc | 69 ++--- target/ppc/translate/vmx-ops.

[PATCH v4 38/47] target/ppc: Refactor VSX_SCALAR_CMP_DP

2022-02-22 Thread matheus . ferst
From: Víctor Colombo Refactor VSX_SCALAR_CMP_DP, changing its name to VSX_SCALAR_CMP and prepare the helper to be used for quadword comparisons. Signed-off-by: Víctor Colombo Signed-off-by: Matheus Ferst --- target/ppc/fpu_helper.c | 31 ++- 1 file changed, 14 inse

[PATCH v4 23/47] target/ppc: move vrl[bhwd] to decodetree

2022-02-22 Thread matheus . ferst
From: Matheus Ferst Signed-off-by: Matheus Ferst --- v4: - New in v4. --- target/ppc/insn32.decode| 5 + target/ppc/translate/vmx-impl.c.inc | 13 + target/ppc/translate/vmx-ops.c.inc | 6 ++ 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/t

[PATCH v4 18/47] target/ppc: implement vgnb

2022-02-22 Thread matheus . ferst
From: Matheus Ferst Suggested-by: Richard Henderson Signed-off-by: Matheus Ferst --- v4: - Optimized implementation (rth) --- target/ppc/insn32.decode| 5 ++ target/ppc/translate/vmx-impl.c.inc | 135 2 files changed, 140 insertions(+) diff --git a/

[PATCH v4 43/47] target/ppc: Implement xs{max,min}cqp

2022-02-22 Thread matheus . ferst
From: Víctor Colombo Signed-off-by: Víctor Colombo Signed-off-by: Matheus Ferst --- target/ppc/fpu_helper.c | 2 ++ target/ppc/helper.h | 2 ++ target/ppc/insn32.decode| 3 +++ target/ppc/translate/vsx-impl.c.inc | 2 ++ 4 files changed, 9 insertions(+)

[PATCH v4 24/47] target/ppc: move vrl[bhwd]nm/vrl[bhwd]mi to decodetree

2022-02-22 Thread matheus . ferst
From: Matheus Ferst Signed-off-by: Matheus Ferst --- v4: - New in v4. --- target/ppc/helper.h | 8 +- target/ppc/insn32.decode| 6 ++ target/ppc/int_helper.c | 50 - target/ppc/translate/vmx-impl.c.inc | 152 ++-- ta

[PATCH v4 29/47] target/ppc: Move xxpermdi to decodetree

2022-02-22 Thread matheus . ferst
From: Matheus Ferst Signed-off-by: Matheus Ferst --- target/ppc/insn32.decode| 4 ++ target/ppc/translate/vsx-impl.c.inc | 71 + target/ppc/translate/vsx-ops.c.inc | 2 - 3 files changed, 36 insertions(+), 41 deletions(-) diff --git a/target/ppc/insn3

[PATCH v4 31/47] tcg/tcg-op-gvec.c: Introduce tcg_gen_gvec_4i

2022-02-22 Thread matheus . ferst
From: Matheus Ferst Following the implementation of tcg_gen_gvec_3i, add a four-vector and immediate operand expansion method. Signed-off-by: Matheus Ferst --- include/tcg/tcg-op-gvec.h | 22 ++ tcg/tcg-op-gvec.c | 146 ++ 2 files changed, 168 i

[PATCH v4 35/47] target/ppc: implement xs[n]maddqp[o]/xs[n]msubqp[o]

2022-02-22 Thread matheus . ferst
From: Matheus Ferst Implement the following PowerISA v3.0 instuctions: xsmaddqp[o]: VSX Scalar Multiply-Add Quad-Precision [using round to Odd] xsmsubqp[o]: VSX Scalar Multiply-Subtract Quad-Precision [using round to Odd] xsnmaddqp[o]: VSX Scalar Negative Multiply-Add Quad-Precision

[PATCH v4 44/47] target/ppc: Implement xvcvbf16spn and xvcvspbf16 instructions

2022-02-22 Thread matheus . ferst
From: Víctor Colombo Signed-off-by: Víctor Colombo Signed-off-by: Matheus Ferst --- target/ppc/fpu_helper.c | 21 +++ target/ppc/helper.h | 1 + target/ppc/insn32.decode| 11 +++--- target/ppc/translate/vsx-impl.c.inc | 31 ++

[PATCH v4 28/47] target/ppc: move xxperm/xxpermr to decodetree

2022-02-22 Thread matheus . ferst
From: Matheus Ferst Signed-off-by: Matheus Ferst --- target/ppc/fpu_helper.c | 21 --- target/ppc/helper.h | 2 -- target/ppc/insn32.decode| 5 target/ppc/translate/vsx-impl.c.inc | 42 +++-- target/ppc/translate

[PATCH v4 32/47] target/ppc: Implement xxeval

2022-02-22 Thread matheus . ferst
From: Matheus Ferst Signed-off-by: Matheus Ferst --- target/ppc/helper.h | 1 + target/ppc/insn64.decode| 8 ++ target/ppc/int_helper.c | 42 ++ target/ppc/translate/vsx-impl.c.inc | 121 4 files changed, 172 inse

Re: [PATCH 08/11] mos6522: add "info via" HMP command for debugging

2022-02-22 Thread Dr. David Alan Gilbert
* Mark Cave-Ayland (mark.cave-ayl...@ilande.co.uk) wrote: > On 21/02/2022 17:11, Daniel P. Berrangé wrote: > > > On Sun, Feb 20, 2022 at 05:18:33PM +, Mark Cave-Ayland wrote: > > > On 08/02/2022 13:10, Daniel P. Berrangé wrote: > > > > > > > On Tue, Feb 08, 2022 at 01:06:59PM +, Mark Cave

[PATCH v4 37/47] target/ppc: Remove xscmpnedp instruction

2022-02-22 Thread matheus . ferst
From: Víctor Colombo xscmpnedp was added in ISA v3.0 but removed in v3.0B. This patch removes this instruction as it was not in the final version of v3.0. Signed-off-by: Víctor Colombo Acked-by: Greg Kurz Reviewed-by: Cédric Le Goater Reviewed-by: Richard Henderson Signed-off-by: Matheus Fer

[PATCH v4 33/47] target/ppc: Implement xxgenpcv[bhwd]m instruction

2022-02-22 Thread matheus . ferst
From: Matheus Ferst Signed-off-by: Matheus Ferst --- target/ppc/helper.h | 4 ++ target/ppc/insn32.decode| 10 target/ppc/int_helper.c | 84 + target/ppc/translate/vsx-impl.c.inc | 29 ++ 4 files changed, 127 inse

[PATCH v4 36/47] target/ppc: Implement xvtlsbb instruction

2022-02-22 Thread matheus . ferst
From: Víctor Colombo Signed-off-by: Víctor Colombo Signed-off-by: Matheus Ferst --- target/ppc/insn32.decode| 7 ++ target/ppc/translate/vsx-impl.c.inc | 37 + 2 files changed, 44 insertions(+) diff --git a/target/ppc/insn32.decode b/target/ppc/ins

[PATCH v4 39/47] target/ppc: Implement xscmp{eq,ge,gt}qp

2022-02-22 Thread matheus . ferst
From: Víctor Colombo Signed-off-by: Víctor Colombo Signed-off-by: Matheus Ferst --- target/ppc/fpu_helper.c | 4 target/ppc/helper.h | 3 +++ target/ppc/insn32.decode| 3 +++ target/ppc/translate/vsx-impl.c.inc | 31 +

Re: [PATCH 1/2] iotests/065: Check for zstd support

2022-02-22 Thread Vladimir Sementsov-Ogievskiy
21.02.2022 20:08, Hanna Reitz wrote: Some test cases run in iotest 065 require zstd support. Skip them if qemu-img reports it not to be available. Reported-by: Thomas Huth Fixes: 12a936171d71f839dc907ff ("iotest 065: explicit compression type") Signed-off-by: Hanna Reitz --- tests/qemu-iote

Re: [PATCH v2] iotests: Write test output to TEST_DIR

2022-02-22 Thread Hanna Reitz
On 22.02.22 15:39, Vladimir Sementsov-Ogievskiy wrote: 21.02.2022 20:29, Hanna Reitz wrote: Drop the use of OUTPUT_DIR (test/qemu-iotests under the build directory), and instead write test output files (.out.bad, .notrun, and .casenotrun) to TEST_DIR. With this, the same test can be run concurr

[PATCH v4 40/47] target/ppc: Move xscmp{eq,ge,gt}dp to decodetree

2022-02-22 Thread matheus . ferst
From: Víctor Colombo Signed-off-by: Víctor Colombo Signed-off-by: Matheus Ferst --- target/ppc/fpu_helper.c | 7 +++ target/ppc/helper.h | 6 +++--- target/ppc/insn32.decode| 3 +++ target/ppc/translate/vsx-impl.c.inc | 28

[PATCH v4 42/47] target/ppc: Refactor VSX_MAX_MINC helper

2022-02-22 Thread matheus . ferst
From: Víctor Colombo Refactor xs{max,min}cdp VSX_MAX_MINC helper to prepare for xs{max,min}cqp implementation. Signed-off-by: Víctor Colombo Signed-off-by: Matheus Ferst --- target/ppc/fpu_helper.c | 23 +-- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/ta

Re: [PULL v2 5/5] 9pfs: Fix segfault in do_readdir_many caused by struct dirent overread

2022-02-22 Thread Greg Kurz
On Tue, 22 Feb 2022 14:54:17 +0100 Christian Schoenebeck wrote: > On Dienstag, 22. Februar 2022 14:21:52 CET Peter Maydell wrote: > > On Thu, 17 Feb 2022 at 16:43, Christian Schoenebeck > > > > wrote: > > > diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h > > > index d1660d67fa..ce12f64

[PATCH v4 41/47] target/ppc: Move xs{max, min}[cj]dp to use do_helper_XX3

2022-02-22 Thread matheus . ferst
From: Víctor Colombo Also, fixes these instructions not being capitalized. Signed-off-by: Víctor Colombo Signed-off-by: Matheus Ferst --- target/ppc/fpu_helper.c | 8 target/ppc/helper.h | 8 target/ppc/translate/vsx-impl.c.inc | 30

Re: [PATCH] block/curl.c: Check error return from curl_easy_setopt()

2022-02-22 Thread Hanna Reitz
On 21.02.22 20:45, Peter Maydell wrote: On Tue, 1 Feb 2022 at 11:25, Hanna Reitz wrote: On 28.01.22 17:55, Peter Maydell wrote: Coverity points out that we aren't checking the return value from curl_easy_setopt() for any of the calls to it we make in block/curl.c. Fixes: Coverity CID 1459336,

[PATCH v4 46/47] target/ppc: implement plxssp/pstxssp

2022-02-22 Thread matheus . ferst
From: Leandro Lupori Implement instructions plxssp/pstxssp and port lxssp/stxssp to decode tree. Signed-off-by: Matheus Ferst --- target/ppc/insn32.decode| 2 + target/ppc/insn64.decode| 6 ++ target/ppc/translate.c | 29 +++-- target/ppc/translate/vs

Re: [PATCH RFC 4/4] rtc: Have event RTC_CHANGE identify the RTC by QOM path

2022-02-22 Thread Philippe Mathieu-Daudé
On 22/2/22 16:04, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: Hi Markus, On 22/2/22 13:02, Markus Armbruster wrote: Event RTC_CHANGE is "emitted when the guest changes the RTC time" (and the RTC supports the event). What if there's more than one RTC? w.r.t. RTC, a machine havi

Re: [PATCH] schemas: fix: wrong field name 'data' in client snapshot msg examples

2022-02-22 Thread Markus Armbruster
Recommend to tweak the title to something like qapi/migration: Fix examples ... Fabian Holler writes: > The examples for the snapshot-* commands documented that arguments for document > the commands must be passed in a 'data' field. > This is wrong, passing them in a "data" field results

[PATCH v4 45/47] target/ppc: implement plxsd/pstxsd

2022-02-22 Thread matheus . ferst
From: Leandro Lupori Implement instructions plxsd/pstxsd and port lxsd/stxsd to decode tree. Signed-off-by: Matheus Ferst --- target/ppc/insn32.decode| 2 ++ target/ppc/insn64.decode| 10 ++ target/ppc/translate.c | 14 ++-- target/ppc/translate/vs

Re: Call for GSoC and Outreachy project ideas for summer 2022

2022-02-22 Thread Keith Busch
On Tue, Feb 22, 2022 at 09:48:06AM +, Stefan Hajnoczi wrote: > On Mon, 21 Feb 2022 at 12:00, Klaus Jensen wrote: > > > > Yes, I'll go ahead as mentor for this. > > > > @Keith, if you want to join in, let us know :) Thank you for setting this up, I would be happy assist with the cause! > > Su

[PATCH v2 1/2] block/curl.c: Set error message string if curl_init_state() fails

2022-02-22 Thread Peter Maydell
In curl_open(), the 'out' label assumes that the state->errmsg string has been set (either by curl_easy_perform() or by manually copying a string into it); however if curl_init_state() fails we will jump to that label without setting the string. Add the missing error string setup. (We can't be sp

Re: [PATCH] hw/mem/pc-dimm: Fix error message if no slots were defined some more

2022-02-22 Thread David Hildenbrand
On 22.02.22 16:22, Markus Armbruster wrote: > The error message added in commit 3ff333effa "pc-dimm: fix error > messages if no slots were defined" is misleading: > > $ qemu-system-x86_64 -object > memory-backend-file,id=mem1,size=1M,mem-path=1G.img -device > pc-dimm,id=dimm1,memdev=mem1 >

Re: [PATCH RFC 4/4] rtc: Have event RTC_CHANGE identify the RTC by QOM path

2022-02-22 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Hi Markus, > > On 22/2/22 13:02, Markus Armbruster wrote: >> Event RTC_CHANGE is "emitted when the guest changes the RTC time" (and >> the RTC supports the event). What if there's more than one RTC? > > w.r.t. RTC, a machine having multiple RTC devices is silly..

[PATCH v4 47/47] target/ppc: implement lxvr[bhwd]/stxvr[bhwd]x

2022-02-22 Thread matheus . ferst
From: Lucas Coutinho Implement the following PowerISA v3.1 instuctions: lxvrbx: Load VSX Vector Rightmost Byte Indexed X-form lxvrhx: Load VSX Vector Rightmost Halfword Indexed X-form lxvrwx: Load VSX Vector Rightmost Word Indexed X-form lxvrdx: Load VSX Vector Rightmost Doubleword Indexed X-form

[PATCH] schemas: fix: wrong field name 'data' in client snapshot msg examples

2022-02-22 Thread Fabian Holler
The examples for the snapshot-* commands documented that arguments for the commands must be passed in a 'data' field. This is wrong, passing them in a "data" field results in the error: {"error": {"class": "GenericError", "desc": "QMP input member 'data' is unexpected"}} A

[PATCH v2 2/2] block/curl.c: Check error return from curl_easy_setopt()

2022-02-22 Thread Peter Maydell
Coverity points out that we aren't checking the return value from curl_easy_setopt() for any of the calls to it we make in block/curl.c. Some of these options are documented as always succeeding (e.g. CURLOPT_VERBOSE) but others have documented failure cases (e.g. CURLOPT_URL). For consistency we

Re: [PATCH v2 9/9] hw/riscv: virt: Set the clock-frequency

2022-02-22 Thread Peter Maydell
On Tue, 21 Dec 2021 at 06:35, Alistair Francis wrote: > > On Mon, Dec 20, 2021 at 5:52 PM Bin Meng wrote: > > > > On Thu, Dec 16, 2021 at 12:55 PM Alistair Francis > > wrote: > > > > > > From: Alistair Francis > > > > > > As per the device tree specification let's set the clock-frequency for >

Re: [PATCH v2] iotests: Write test output to TEST_DIR

2022-02-22 Thread Vladimir Sementsov-Ogievskiy
22.02.2022 17:44, Hanna Reitz wrote: On 22.02.22 15:39, Vladimir Sementsov-Ogievskiy wrote: 21.02.2022 20:29, Hanna Reitz wrote: Drop the use of OUTPUT_DIR (test/qemu-iotests under the build directory), and instead write test output files (.out.bad, .notrun, and .casenotrun) to TEST_DIR. With

[PATCH v2 0/2] block/curl: check error return from curl_easy_setopt()

2022-02-22 Thread Peter Maydell
Coverity points out that we aren't checking the return value from curl_easy_setopt() for any of the calls to it we make in block/curl.c. Tested with 'make check' and with some basic smoke test command lines suggested by Dan: qemu-img info https://cloud.debian.org/images/cloud/buster/daily/lates

[PATCH] hw/mem/pc-dimm: Fix error message if no slots were defined some more

2022-02-22 Thread Markus Armbruster
The error message added in commit 3ff333effa "pc-dimm: fix error messages if no slots were defined" is misleading: $ qemu-system-x86_64 -object memory-backend-file,id=mem1,size=1M,mem-path=1G.img -device pc-dimm,id=dimm1,memdev=mem1 qemu-system-x86_64: -device pc-dimm,id=dimm1,memdev=mem

[PULL 1/7] configure: Disable capstone and slirp in the --without-default-features mode

2022-02-22 Thread Laurent Vivier
From: Thomas Huth For the users, it looks a little bit weird that capstone and slirp are not disabled automatically if they run the configure script with the "--without-default-features" option, so let's do that now. Note: fdt is *not* changed accordingly since this affects the targets that we ca

Re: [PATCH 0/4] vCPU hotunplug related memory leaks

2022-02-22 Thread Mark Kanda
Gentle ping - any thoughts on this series? Thanks/regards, -Mark On 1/26/2022 8:29 AM, Mark Kanda wrote: This series addresses a few vCPU hotunplug related leaks (found with Valgrind). Mark Kanda (4): softmmu/cpus: Free cpu->thread in cpu_remove_sync() softmmu/cpus: Free cpu->halt_cond i

[PATCH] Added parameter to take screenshot with screendump as PNG

2022-02-22 Thread Kshitij Suri
Currently screendump only supports PPM format, which is un-compressed and not standard. Added an "format" parameter to qemu monitor screendump capabilites to support PNG image capture using libpng. The param was added in QAPI schema of screendump present in ui.json along with png_save() function wh

Re: [PATCH 4/4] block: simplify handling of try to merge different sized bitmaps

2022-02-22 Thread Vladimir Sementsov-Ogievskiy
15.02.2022 20:53, Vladimir Sementsov-Ogievskiy wrote: diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c index d16b96ee62..9d803fcda3 100644 --- a/block/dirty-bitmap.c +++ b/block/dirty-bitmap.c @@ -309,10 +309,7 @@ BdrvDirtyBitmap *bdrv_reclaim_dirty_bitmap_locked(BdrvDirtyBitmap *parent,

Re: [PATCH RFC 4/4] rtc: Have event RTC_CHANGE identify the RTC by QOM path

2022-02-22 Thread Philippe Mathieu-Daudé
On 22/2/22 14:06, Peter Maydell wrote: On Tue, 22 Feb 2022 at 12:56, Philippe Mathieu-Daudé wrote: On 22/2/22 13:02, Markus Armbruster wrote: Event RTC_CHANGE is "emitted when the guest changes the RTC time" (and the RTC supports the event). What if there's more than one RTC? w.r.t. RTC, a

Re: proposed release schedule for QEMU 7.0

2022-02-22 Thread Peter Maydell
On Mon, 14 Feb 2022 at 17:09, Peter Maydell wrote: > > Here's my suggestion for release schedule dates for 7.0: > > 2021-12-14 Beginning of development phase > 2022-03-08 Soft feature freeze. Only bug fixes after this point. >All feature changes must be already in a sub maintainer >

Re: [RFC PATCH] gitlab: upgrade the job definition for s390x to 20.04

2022-02-22 Thread Cornelia Huck
On Mon, Feb 21 2022, Alex Bennée wrote: > The new s390x machine has more of everything including the OS. As > 18.04 will soon be going we might as well get onto something moderately > modern. > > Signed-off-by: Alex Bennée > Cc: Christian Borntraeger > Cc: Peter Maydell > --- > .gitlab-ci.d/c

Re: Analysis of slow distro boots in check-avocado (BootLinuxAarch64.test_virt_tcg*)

2022-02-22 Thread Alex Bennée
Alex Bennée writes: > Hi, > > TL;DR: > > - pc-bios/edk2-aarch64-code.fd should be rebuilt without debug Laszlo, Would it be possible to do a less debug enabled version of EDK2 on the next update to pc-bios/edk2-*? > > So my working theory is: > > - booting with EFI leaves a number stale

Re: [PATCH 2/2] iotests/303: Check for zstd support

2022-02-22 Thread Vladimir Sementsov-Ogievskiy
21.02.2022 20:08, Hanna Reitz wrote: 303 runs two test cases, one of which requires zstd support. Unfortunately, given that this is not a unittest-style test, we cannot easily skip that single case, and instead can only skip the whole test. (Alternatively, we could split this test into a zlib an

[PULL 2/7] target/avr: Correct AVRCPUClass docstring

2022-02-22 Thread Laurent Vivier
From: Philippe Mathieu-Daudé There is no 'vr' field in AVRCPUClass. Likely a copy/paste typo from CRISCPUClass ;) Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20220122001036.83267-1-f4...@amsat.org> Signed-off-by: Laurent Vivier --- target/avr/cpu-qom.h

[PULL 0/7] Trivial branch for 7.0 patches

2022-02-22 Thread Laurent Vivier
gs/trivial-branch-for-7.0-pull-request for you to fetch changes up to 1e2d555846226a9e5fb1052fe8ba6f30480f33a9: hid: Implement support for side and extra buttons (2022-02-22 17:15:36 +0100) Trivial branch pull reques

[PATCH v2 3/4] block: improve block_dirty_bitmap_merge(): don't allocate extra bitmap

2022-02-22 Thread Vladimir Sementsov-Ogievskiy
We don't need extra bitmap. All we need is to backup the original bitmap when we do first merge. So, drop extra temporary bitmap and work directly with target and backup. Still to keep old semantics, that on failure target is unchanged and user don't need to restore, we need a local_backup variabl

Re: [PATCH] hw/mem/pc-dimm: Fix error message if no slots were defined some more

2022-02-22 Thread Markus Armbruster
David Hildenbrand writes: > On 22.02.22 16:22, Markus Armbruster wrote: >> The error message added in commit 3ff333effa "pc-dimm: fix error >> messages if no slots were defined" is misleading: >> >> $ qemu-system-x86_64 -object >> memory-backend-file,id=mem1,size=1M,mem-path=1G.img -device

[PULL 5/7] qemu-options: fix incorrect description for '-drive index='

2022-02-22 Thread Laurent Vivier
From: Laurent Vivier qemu-options.hx contains grammar that a native English-speaking person would never use. Replace "This option defines where is connected the drive" by "This option defines where the drive is connected". Fixes: https://gitlab.com/qemu-project/qemu/-/issues/853 Signed-off-by:

[PULL 6/7] vdpa: Make ncs autofree

2022-02-22 Thread Laurent Vivier
From: Eugenio Pérez Simplifying memory management. Signed-off-by: Eugenio Pérez Acked-by: Jason Wang Reviewed-by: Stefano Garzarella Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20220214193415.1606752-2-epere...@redhat.com> Signed-off-by: Laurent Vivier --- net/vhost-vdpa.c | 5 ++---

<    1   2   3   4   >