Re: [PATCH v4 19/47] target/ppc: move vs[lr][a][bhwd] to decodetree

On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: From: Matheus Ferst Signed-off-by: Matheus Ferst --- v4: - New in v4. --- target/ppc/insn32.decode| 17 target/ppc/translate/vmx-impl.c.inc | 41 +++-- target/ppc/translate/vmx-ops.c.in

[PATCH v4 4/6] target/riscv: Add support for mconfigptr

RISC-V privileged specification v1.12 introduced a mconfigptr which will hold the physical address of a configuration data structure. As Qemu doesn't have a configuration data structure, is read as zero which is valid as per the priv spec. Reviewed-by: Alistair Francis Signed-off-by: Atish Patra

[PATCH v4 0/6] Privilege version update

RISC-V International (RVI) has ratified many RISC-V ISA extensions recently[1]. The privileged specification version is also upgraded to v1.12. It means certain CSRs introduced in v1.12 should only be accessible only if the priv specification version supported is equal or greater than v1.12. Doing

[PATCH v4 5/6] target/riscv: Add *envcfg* CSRs support

The RISC-V privileged specification v1.12 defines few execution environment configuration CSRs that can be used enable/disable extensions per privilege levels. Add the basic support for these CSRs. Signed-off-by: Atish Patra --- target/riscv/cpu.h | 5 ++ target/riscv/cpu_bits.h | 39 ++

[PATCH v4 2/6] target/riscv: Add the privileged spec version 1.12.0

Add the definition for ratified privileged specification version v1.12 Reviewed-by: Alistair Francis Signed-off-by: Atish Patra --- target/riscv/cpu.h | 1 + 1 file changed, 1 insertion(+) diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h index e5ff4c134c86..60b847141db2 100644 --- a/target

[PATCH v4 1/6] target/riscv: Define simpler privileged spec version numbering

Currently, the privileged specification version are defined in a complex manner for no benefit. Simplify it by changing it to a simple enum based on. Suggested-by: Richard Henderson Reviewed-by: Alistair Francis Signed-off-by: Atish Patra --- target/riscv/cpu.h | 7 +-- 1 file changed, 5

[PATCH v4 3/6] target/riscv: Introduce privilege version field in the CSR ops.

To allow/disallow the CSR access based on the privilege spec, a new field in the csr_ops is introduced. It also adds the privileged specification version (v1.12) for the CSRs introduced in the v1.12. This includes the new ratified extensions such as Vector, Hypervisor and secconfig CSR. However, it

Re: [PATCH v4 21/47] target/ppc: implement vsrq

On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: From: Matheus Ferst Signed-off-by: Matheus Ferst --- v4: - New in v4. --- target/ppc/insn32.decode| 1 + target/ppc/translate/vmx-impl.c.inc | 40 + 2 files changed, 31 insertions(+), 10 deleti

[PATCH v4 6/6] target/riscv: Enable privileged spec version 1.12

Virt machine uses privileged specification version 1.12 now. All other machine continue to use the default one defined for that machine unless changed to 1.12 by the user explicitly. This commit enforces the privilege version for csrs introduced in v1.12 or after. Reviewed-by: Alistair Francis S

Re: [PATCH v7 2/2] drivers/virt: vmgenid: add vm generation id driver

Hey again, On Tue, Feb 22, 2022 at 10:24 PM Jason A. Donenfeld wrote: > This thread seems to be long dead, but I couldn't figure out what > happened to the ideas in it. I'm specifically interested in this part: > > On Wed, Feb 24, 2021 at 9:48 AM Adrian Catangiu wrote: > > +static void vmgenid_a

Re: [PATCH v4 23/47] target/ppc: move vrl[bhwd] to decodetree

On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: From: Matheus Ferst Signed-off-by: Matheus Ferst --- v4: - New in v4. --- target/ppc/insn32.decode| 5 + target/ppc/translate/vmx-impl.c.inc | 13 + target/ppc/translate/vmx-ops.c.inc | 6 ++ 3 file

Re: [PATCH v4 20/47] target/ppc: implement vslq

On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: From: Matheus Ferst Signed-off-by: Matheus Ferst --- v4: - New in v4. --- target/ppc/insn32.decode| 1 + target/ppc/translate/vmx-impl.c.inc | 40 + 2 files changed, 41 insertions(+) diff --

Re: [PATCH v4 22/47] target/ppc: implement vsraq

On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: From: Matheus Ferst Signed-off-by: Matheus Ferst --- v4: - New in v4. --- target/ppc/insn32.decode| 1 + target/ppc/translate/vmx-impl.c.inc | 17 + 2 files changed, 14 insertions(+), 4 deletions(-) Re

Re: [PATCH v2] target/riscv: Add isa extenstion strings to the device tree

On Tue, Feb 15, 2022 at 7:19 PM Anup Patel wrote: > > On Wed, Feb 16, 2022 at 5:39 AM Atish Patra wrote: > > > > The Linux kernel parses the ISA extensions from "riscv,isa" DT > > property. It used to parse only the single letter base extensions > > until now. A generic ISA extension parsing fram

Re: [PATCH v4 24/47] target/ppc: move vrl[bhwd]nm/vrl[bhwd]mi to decodetree

On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: +static void gen_vrlnm_vec(unsigned vece, TCGv_vec vrt, TCGv_vec vra, + TCGv_vec vrb) +{ +TCGv_vec mask, n = tcg_temp_new_vec_matching(vrt); + +/* Create the mask */ +mask = do_vrl_mask_vec(vece, vrb); + +

Re: [PATCH v4 25/47] target/ppc: implement vrlq

On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: From: Matheus Ferst Signed-off-by: Matheus Ferst --- v4: - New in v4. --- target/ppc/insn32.decode| 1 + target/ppc/translate/vmx-impl.c.inc | 49 + 2 files changed, 50 insertions(+) ... +

Re: [PATCH v4 26/47] target/ppc: Move vsel and vperm/vpermr to decodetree

On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: From: Matheus Ferst Signed-off-by: Matheus Ferst --- target/ppc/helper.h | 5 +-- target/ppc/insn32.decode| 5 +++ target/ppc/int_helper.c | 13 +- target/ppc/translate/vmx-impl.c.inc | 69 +

[PATCH v3] target/riscv: Add isa extenstion strings to the device tree

The Linux kernel parses the ISA extensions from "riscv,isa" DT property. It used to parse only the single letter base extensions until now. A generic ISA extension parsing framework was proposed[1] recently that can parse multi-letter ISA extensions as well. Generate the extended ISA string by app

Re: [PATCH v4 27/47] target/ppc: Move xxsel to decodetree

On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: From: Matheus Ferst Signed-off-by: Matheus Ferst --- target/ppc/insn32.decode| 6 target/ppc/insn64.decode| 24 target/ppc/translate/vsx-impl.c.inc | 20 ++ target/ppc/translate

Re: [PATCH v4 29/47] target/ppc: Move xxpermdi to decodetree

On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: From: Matheus Ferst Signed-off-by: Matheus Ferst --- target/ppc/insn32.decode| 4 ++ target/ppc/translate/vsx-impl.c.inc | 71 + target/ppc/translate/vsx-ops.c.inc | 2 - 3 files changed, 36 in

Re: [PATCH v4 28/47] target/ppc: move xxperm/xxpermr to decodetree

On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: From: Matheus Ferst Signed-off-by: Matheus Ferst --- target/ppc/fpu_helper.c | 21 --- target/ppc/helper.h | 2 -- target/ppc/insn32.decode| 5 target/ppc/translate/vsx-impl.c.i

Re: [PATCH v4 30/47] target/ppc: Implement xxpermx instruction

On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: From: Matheus Ferst Signed-off-by: Matheus Ferst --- target/ppc/helper.h | 1 + target/ppc/insn64.decode| 8 target/ppc/int_helper.c | 20 target/ppc/translate/vsx-

Re: [PATCH v4 31/47] tcg/tcg-op-gvec.c: Introduce tcg_gen_gvec_4i

On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: From: Matheus Ferst Following the implementation of tcg_gen_gvec_3i, add a four-vector and immediate operand expansion method. Signed-off-by: Matheus Ferst --- include/tcg/tcg-op-gvec.h | 22 ++ tcg/tcg-op-gvec.c | 146 +

Re: [PATCH v4 32/47] target/ppc: Implement xxeval

On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: +tcg_gen_movi_i64(disj, 0); The init here means there's one more OR generated than necessary. Though perhaps it gets folded away... + +/* Iterate over set bits from the least to the most significant bit */ +while (imm) { +

Re: [PATCH v4 33/47] target/ppc: Implement xxgenpcv[bhwd]m instruction

On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: +#define XXGENPCV(NAME, SZ) \ +void helper_##NAME(ppc_vsr_t *t, ppc_vsr_t *b, target_ulong imm)\ +{ \ +ppc_vsr_t tmp = { .u64 = { 0, 0 } };

Re: [PATCH v4 34/47] target/ppc: move xs[n]madd[am][ds]p/xs[n]msub[am][ds]p to decodetree

On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: +static bool do_xsmadd(DisasContext *ctx, int tgt, int src1, int src2, int src3, +void (gen_helper)(TCGv_ptr, TCGv_ptr, TCGv_ptr, TCGv_ptr, TCGv_ptr)) Missing a * before gen_helper. Somewhat surprised this compiled... +static boo

Re: [PATCH v4 35/47] target/ppc: implement xs[n]maddqp[o]/xs[n]msubqp[o]

On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: From: Matheus Ferst Implement the following PowerISA v3.0 instuctions: xsmaddqp[o]: VSX Scalar Multiply-Add Quad-Precision [using round to Odd] xsmsubqp[o]: VSX Scalar Multiply-Subtract Quad-Precision [using round to Odd] xsnma

Re: [PATCH v4 36/47] target/ppc: Implement xvtlsbb instruction

On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: +tcg_gen_and_i64(tmp, mask, xb); +tcg_gen_movcond_i64(TCG_COND_EQ, all_true, tmp, +mask, all_true, zero); + +tcg_gen_andc_i64(tmp, mask, xb); +tcg_gen_movcond_i64(TCG_COND_EQ, all_fa

Re: [PATCH v4 38/47] target/ppc: Refactor VSX_SCALAR_CMP_DP

On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: From: Víctor Colombo Refactor VSX_SCALAR_CMP_DP, changing its name to VSX_SCALAR_CMP and prepare the helper to be used for quadword comparisons. Signed-off-by: Víctor Colombo Signed-off-by: Matheus Ferst --- target/ppc/fpu_helper.c | 3

Re: [PATCH v4 39/47] target/ppc: Implement xscmp{eq,ge,gt}qp

On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: From: Víctor Colombo Signed-off-by: Víctor Colombo Signed-off-by: Matheus Ferst --- target/ppc/fpu_helper.c | 4 target/ppc/helper.h | 3 +++ target/ppc/insn32.decode| 3 +++ target/ppc/tr

Re: [PATCH v4 40/47] target/ppc: Move xscmp{eq, ge, gt}dp to decodetree

On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: From: Víctor Colombo Signed-off-by: Víctor Colombo Signed-off-by: Matheus Ferst --- target/ppc/fpu_helper.c | 7 +++ target/ppc/helper.h | 6 +++--- target/ppc/insn32.decode| 3 +++ target/

Re: [PATCH v4 41/47] target/ppc: Move xs{max, min}[cj]dp to use do_helper_XX3

On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: From: Víctor Colombo Also, fixes these instructions not being capitalized. Signed-off-by: Víctor Colombo Signed-off-by: Matheus Ferst --- target/ppc/fpu_helper.c | 8 target/ppc/helper.h | 8 ---

Re: [PATCH v4 42/47] target/ppc: Refactor VSX_MAX_MINC helper

On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: -#define VSX_MAX_MINC(name, max) \ +#define VSX_MAX_MINC(name, op, tp, fld) \ void helper_##name(CPUPPCState *env,

Re: [PATCH v4 43/47] target/ppc: Implement xs{max,min}cqp

On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: From: Víctor Colombo Signed-off-by: Víctor Colombo Signed-off-by: Matheus Ferst --- target/ppc/fpu_helper.c | 2 ++ target/ppc/helper.h | 2 ++ target/ppc/insn32.decode| 3 +++ target/ppc/translat

Re: [PATCH v3] tests/qtest: add qtests for npcm7xx sdhci

On Mon, Feb 21, 2022 at 5:30 AM Peter Maydell wrote: > On Wed, 16 Feb 2022 at 17:30, Peter Maydell > wrote: > > > > On Tue, 8 Feb 2022 at 18:18, Patrick Venture wrote: > > > > > > From: Shengtan Mao > > > > > > Reviewed-by: Hao Wu > > > Reviewed-by: Chris Rauer > > > Signed-off-by: Shengtan

Re: [PATCH 18/31] vhost: Shadow virtqueue buffers forwarding

On Wed, Feb 23, 2022 at 3:01 AM Eugenio Perez Martin wrote: > > On Tue, Feb 8, 2022 at 9:11 AM Jason Wang wrote: > > > > > > 在 2022/2/2 上午1:08, Eugenio Perez Martin 写道: > > > On Sun, Jan 30, 2022 at 5:43 AM Jason Wang wrote: > > >> > > >> 在 2022/1/22 上午4:27, Eugenio Pérez 写道: > > >>> Initial ver

Re: [PATCH 18/31] vhost: Shadow virtqueue buffers forwarding

On Tue, Feb 22, 2022 at 4:56 PM Eugenio Perez Martin wrote: > > On Tue, Feb 22, 2022 at 8:26 AM Jason Wang wrote: > > > > > > 在 2022/2/21 下午4:15, Eugenio Perez Martin 写道: > > > On Mon, Feb 21, 2022 at 8:44 AM Jason Wang wrote: > > >> > > >> 在 2022/2/17 下午8:48, Eugenio Perez Martin 写道: > > >>> On

Re: [PATCH v4 44/47] target/ppc: Implement xvcvbf16spn and xvcvspbf16 instructions

On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: From: Víctor Colombo Signed-off-by: Víctor Colombo Signed-off-by: Matheus Ferst --- target/ppc/fpu_helper.c | 21 +++ target/ppc/helper.h | 1 + target/ppc/insn32.decode| 11 +++

Re: [PATCH v4 45/47] target/ppc: implement plxsd/pstxsd

On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: From: Leandro Lupori Implement instructions plxsd/pstxsd and port lxsd/stxsd to decode tree. Signed-off-by: Matheus Ferst --- target/ppc/insn32.decode| 2 ++ target/ppc/insn64.decode| 10 ++ target/ppc/trans

Re: [PATCH v4 46/47] target/ppc: implement plxssp/pstxssp

On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: From: Leandro Lupori Implement instructions plxssp/pstxssp and port lxssp/stxssp to decode tree. Signed-off-by: Matheus Ferst --- target/ppc/insn32.decode| 2 + target/ppc/insn64.decode| 6 ++ target/ppc/transl

Re: [PATCH v4 47/47] target/ppc: implement lxvr[bhwd]/stxvr[bhwd]x

On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: From: Lucas Coutinho Implement the following PowerISA v3.1 instuctions: lxvrbx: Load VSX Vector Rightmost Byte Indexed X-form lxvrhx: Load VSX Vector Rightmost Halfword Indexed X-form lxvrwx: Load VSX Vector Rightmost Word Indexed X-form lxv

Re: [PATCH 28/31] vdpa: Expose VHOST_F_LOG_ALL on SVQ

On Tue, Feb 22, 2022 at 4:06 PM Eugenio Perez Martin wrote: > > On Tue, Feb 22, 2022 at 8:41 AM Jason Wang wrote: > > > > > > 在 2022/2/17 下午4:22, Eugenio Perez Martin 写道: > > > On Thu, Feb 17, 2022 at 7:02 AM Jason Wang wrote: > > >> On Wed, Feb 16, 2022 at 11:54 PM Eugenio Perez Martin > > >>

Re: [PATCH v4 5/6] target/riscv: Add *envcfg* CSRs support

On Wed, Feb 23, 2022 at 8:09 AM Atish Patra wrote: > > The RISC-V privileged specification v1.12 defines few execution > environment configuration CSRs that can be used enable/disable > extensions per privilege levels. > > Add the basic support for these CSRs. > > Signed-off-by: Atish Patra Revi

Re: [PATCH v1 2/2] riscv: opentitan: Connect opentitan SPI Host

On Wed, Feb 23, 2022 at 7:45 AM Alistair Francis wrote: > > From: Wilfred Mallawa > > Conenct spi host[1/0] to opentitan. > > Signed-off-by: Wilfred Mallawa > --- > hw/riscv/opentitan.c | 42 > include/hw/riscv/opentitan.h | 16 -- > 2 fi

Re: [PATCH v4 5/6] target/riscv: Add *envcfg* CSRs support

On Wed, Feb 23, 2022 at 8:09 AM Atish Patra wrote: > > The RISC-V privileged specification v1.12 defines few execution > environment configuration CSRs that can be used enable/disable > extensions per privilege levels. > > Add the basic support for these CSRs. > > Signed-off-by: Atish Patra Do y

virtio-blk issue with vIOMMU

Hi Stefan: Recently I found intel vIOMMU gives the following warning when using virtio-blk: qemu-system-x86_64: vtd_iova_to_slpte: detected slpte permission error (iova=0x7ffde000, level=0x3, slpte=0x0, write=0) qemu-system-x86_64: vtd_iommu_translate: detected translation failure (dev=01:00

[PATCH 1/3] whpx: Fixed reporting of the CPU context to GDB for 64-bit

Hi All, We have been looking into kernel-debugging Linux VMs running on Windows with Hyper-V enabled (that forces the virtualization software to use WHPX), and it turned out, none of the major virtualization tools supports it properly. I've added the missing parts to QEMU and it looks pretty solid

[PATCH 2/3] whpx: Fixed incorrect CR8/TPR synchronization

This fixes the following error triggered when stopping and resuming a 64-bit Linux kernel via gdb: qemu-system-x86_64.exe: WHPX: Failed to set virtual processor context, hr=c0350005 The previous logic for synchronizing the values did not take into account that the lower 4 bits of the CR8 register

[PATCH 3/3] whpx: Added support for breakpoints and stepping

This adds support for breakpoints and stepping when debugging WHPX-accelerated guests with gdb. It enables reliable debugging of the Linux kernel in both single-CPU and SMP modes. Signed-off-by: Ivan Shcherbakov --- gdbstub.c| 10 + include/exec/gdbstub.h | 8

Re: [PATCH 13/20] migration: Move channel setup out of postcopy_try_recover()

On Tue, Feb 22, 2022 at 10:57:34AM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > We used to use postcopy_try_recover() to replace migration_incoming_setup() > > to > > setup incoming channels. That's fine for the old world, but in the new > > world > > there ca

Re: [PATCH v3] target/riscv: Add isa extenstion strings to the device tree

On Wed, Feb 23, 2022 at 4:09 AM Atish Patra wrote: > > The Linux kernel parses the ISA extensions from "riscv,isa" DT > property. It used to parse only the single letter base extensions > until now. A generic ISA extension parsing framework was proposed[1] > recently that can parse multi-letter IS

Re: [PATCH 18/20] migration: Postcopy preemption enablement

On Tue, Feb 22, 2022 at 10:52:23AM +, Dr. David Alan Gilbert wrote: > This does get a bit complicated, which worries me a bit; the code here > is already quite complicated. Right, it's the way I chose in this patchset on solving this problem. Not sure whether there's any better and easier way

Re: [PATCH v2 2/3] spapr: Add SPAPR_CAP_AIL_MODE_3 for AIL mode 3 support for H_SET_MODE hcall

Excerpts from David Gibson's message of February 17, 2022 10:17 am: > On Wed, Feb 16, 2022 at 04:39:02PM +1000, Nicholas Piggin wrote: >> The behaviour of the Address Translation Mode on Interrupt resource is >> not consistently supported by all CPU versions or all KVM versions: >> KVM-HV does not

Re: [PATCH 19/20] migration: Postcopy recover with preempt enabled

On Tue, Feb 22, 2022 at 11:32:10AM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > To allow postcopy recovery, the ram fast load (preempt-only) dest QEMU > > thread > > needs similar handling on fault tolerance. When ram_load_postcopy() fails, > > instead of stopp

Re: [PATCH 20/20] tests: Add postcopy preempt test

On Tue, Feb 22, 2022 at 12:51:59PM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > Two tests are added: a normal postcopy preempt test, and a recovery test. > > Yes, this is difficult; without hugepages the tests are limited; did you > see if this test actually cau

Re: [PATCH v2] qapi/migration: Fix examples document wrong field name for arguments

Fabian Holler writes: > The examples for the snapshot-* and calc-dirty-rate commands document > that arguments for the commands are passed in a 'data' field. > This is wrong, passing them in a "data" field results in > the error: > {"error": {"class": "GenericError", "desc": "QMP input member '

Re: [PATCH v2] scripts/qapi: minor delinting

Queued, thanks!

Re: [PATCH 17/31] vdpa: adapt vhost_ops callbacks to svq

On Tue, Feb 22, 2022 at 3:43 PM Eugenio Perez Martin wrote: > > On Tue, Feb 22, 2022 at 4:16 AM Jason Wang wrote: > > > > On Tue, Feb 22, 2022 at 1:23 AM Eugenio Perez Martin > > wrote: > > > > > > On Mon, Feb 21, 2022 at 8:15 AM Jason Wang wrote: > > > > > > > > > > > > 在 2022/2/18 上午1:13, Eug

Re: [PATCH 28/31] vdpa: Expose VHOST_F_LOG_ALL on SVQ

On Tue, Feb 22, 2022 at 8:41 AM Jason Wang wrote: > > > 在 2022/2/17 下午4:22, Eugenio Perez Martin 写道: > > On Thu, Feb 17, 2022 at 7:02 AM Jason Wang wrote: > >> On Wed, Feb 16, 2022 at 11:54 PM Eugenio Perez Martin > >> wrote: > >>> On Tue, Feb 8, 2022 at 9:25 AM Jason Wang wrote: > >

Re: [RFC PATCH] gitlab: upgrade the job definition for s390x to 20.04

Am 22.02.22 um 00:06 schrieb Alex Bennée: The new s390x machine has more of everything including the OS. As 18.04 will soon be going we might as well get onto something moderately modern. Signed-off-by: Alex Bennée Cc: Christian Borntraeger Cc: Peter Maydell Looks sane, Acked-by: Christi

Re: [RFC PATCH] gitlab: upgrade the job definition for s390x to 20.04

On 22/02/2022 00.06, Alex Bennée wrote: The new s390x machine has more of everything including the OS. As 18.04 will soon be going we might as well get onto something moderately modern. Signed-off-by: Alex Bennée Cc: Christian Borntraeger Cc: Peter Maydell --- .gitlab-ci.d/custom-runners.ym

Re: [PATCH 17/20] migration: Postcopy preemption preparation on channel creation

On Mon, Feb 21, 2022 at 06:39:36PM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > Create a new socket for postcopy to be prepared to send postcopy requested > > pages via this specific channel, so as to not get blocked by precopy pages. > > > > A new thread is als

Re: [PATCH RFCv2 2/4] i386/pc: relocate 4g start to 1T where applicable

On Mon, 21 Feb 2022 13:15:40 + "Dr. David Alan Gilbert" wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > On Tue, Feb 15, 2022 at 10:53:58AM +0100, Gerd Hoffmann wrote: > > > Hi, > > > > > > > I don't know what behavior should be if firmware tries to program > > > > PCI64

Re: [PATCH v1] aio-posix: fix build failure io_uring 2.2

On Mon, Feb 21, 2022 at 03:54:57PM +, Peter Maydell wrote: > On Mon, 21 Feb 2022 at 15:02, Stefan Hajnoczi wrote: > > So the QEMU add_poll_remove_sqe() function would do: > > > > io_uring_prep_poll_remove(sqe, (__u64)(uintptr_t)node); > > __u64 is a linux-kernel-ism -- we should use uint64_

Re: [PATCH v1] aio-posix: fix build failure io_uring 2.2

On Mon, Feb 21, 2022 at 04:43:55PM +, Wang, Haiyue wrote: > > -Original Message- > > From: Stefan Hajnoczi > > Sent: Monday, February 21, 2022 22:54 > > To: Wang, Haiyue > > Cc: qemu-devel@nongnu.org; Fam Zheng ; open list:Block I/O > > path > > Subject: Re: [PATCH v1] aio-posix: fi

Re: [PATCH] hw/virtio: vdpa: Fix leak of host-notifier memory-region

Michael, do you plan to merge this soon? This is a bugfix for a QEMU coredump. Thanks, Laurent On 11/02/2022 18:02, Laurent Vivier wrote: If call virtio_queue_set_host_notifier_mr fails, should free host-notifier memory-region. This problem can trigger a coredump with some vDPA drivers (mlx5

Re: [PATCH 18/31] vhost: Shadow virtqueue buffers forwarding

On Tue, Feb 22, 2022 at 8:26 AM Jason Wang wrote: > > > 在 2022/2/21 下午4:15, Eugenio Perez Martin 写道: > > On Mon, Feb 21, 2022 at 8:44 AM Jason Wang wrote: > >> > >> 在 2022/2/17 下午8:48, Eugenio Perez Martin 写道: > >>> On Tue, Feb 8, 2022 at 9:16 AM Jason Wang wrote: > 在 2022/2/1 下午7:25, Eugen

Re: [PATCH v2] aio-posix: fix build failure io_uring 2.2

On Tue, Feb 22, 2022 at 12:24:01AM +0800, Haiyue Wang wrote: > The io_uring fixed "Don't truncate addr fields to 32-bit on 32-bit": > https://git.kernel.dk/cgit/liburing/commit/?id=d84c29b19ed0b13619cff40141bb1fc3615b > > This leads to build failure: > ../util/fdmon-io_uring.c: In function ‘ad

[PATCH v2 2/3] sem-posix: use monotonic clock instead

Use CLOCK_MONOTONIC, so the timeout isn't affected by changes to the system time. It depends on the pthread_condattr_setclock(), while some systems(e.g. mac os) does not support it, so the behavior won't change in these systems. Signed-off-by: Longpeng(Mike) --- meson.build | 11 +++

[PATCH v2 1/3] sem-posix: remove the posix semaphore support

POSIX specifies an absolute time for sem_timedwait(), it would be affected if the system time is changing, but there is not a relative time or monotonic clock version of sem_timedwait, so we cannot gain from POSIX semaphore any more. An alternative way is to use sem_trywait + usleep, maybe we can

[PATCH v2 0/3] qemu-sem-posix: use monotonic clock instead

The qemu_sem_timedwait() uses system time as default, it would be affected by changes to the system time. In the real scenario, the time that goes faster or slower is a common case and the NTP service could help us to sync time periodically. This patchset uses monotonic clock instead of the realti

[PATCH v2 3/3] sem-posix: refactor qemu-sem with qemu-cond and qemu-mutex

Now, qemu-sem is based on the pthread_cond only, we can use qemu-cond and qemu-mutex to make the code neater and the mutex trace can be supported in qemu-sem naturally. Signed-off-by: Longpeng(Mike) --- include/qemu/thread-posix.h | 5 +-- util/qemu-thread-posix.c| 103 ++--

Re: [PATCH 0/5] qmp-shell modifications for non-interactive use

On Tue, Feb 22, 2022 at 08:57:03AM +0100, Damien Hedde wrote: > > > On 2/22/22 07:10, Markus Armbruster wrote: > > Damien Hedde writes: > > > > > Hi, > > > > > > The main idea of this series is to be a bit more user-friendly when > > > using qmp-shell in a non-interactive way: with an input re

Re: [PATCH v3 1/2] hw/i386: Improve bounds checking in OVMF table parsing

On Tue, Feb 22, 2022 at 07:19:05AM +, Dov Murik wrote: > When pc_system_parse_ovmf_flash() parses the optional GUIDed table in > the end of the OVMF flash memory area, the table length field is checked > for sizes that are too small, but doesn't error on sizes that are too > big (bigger than th

Re: [PATCH v3 2/2] hw/i386: Replace magic number with field length calculation

On Tue, Feb 22, 2022 at 07:19:06AM +, Dov Murik wrote: > Replce the literal magic number 48 with length calculation (32 bytes at > the end of the firmware after the table footer + 16 bytes of the OVMF > table footer GUID). > > No functional change intended. > > Signed-off-by: Dov Murik > ---

Re: [PATCH RFCv2 2/4] i386/pc: relocate 4g start to 1T where applicable

* Igor Mammedov (imamm...@redhat.com) wrote: > On Mon, 21 Feb 2022 13:15:40 + > "Dr. David Alan Gilbert" wrote: > > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > On Tue, Feb 15, 2022 at 10:53:58AM +0100, Gerd Hoffmann wrote: > > > > Hi, > > > > > > > > > I don't know what b

Re: [PATCH] hid: trivial change to support side and extra buttons

Gerd, if you acknowledge the patch I can merge it via the trivial branch. Thanks, Laurent Le 22/01/2022 à 10:57, Noah Bergbauer a écrit : ping https://patchew.org/QEMU/20211126140437.79745-1-n...@statshelix.com/ This patc

Re: [PATCH 0/5] qmp-shell modifications for non-interactive use

On 2/22/22 10:21, Daniel P. Berrangé wrote: On Tue, Feb 22, 2022 at 08:57:03AM +0100, Damien Hedde wrote: On 2/22/22 07:10, Markus Armbruster wrote: Damien Hedde writes: Hi, The main idea of this series is to be a bit more user-friendly when using qmp-shell in a non-interactive way: wi

Re: [PATCH v3 1/2] hw/i386: Improve bounds checking in OVMF table parsing

* Dov Murik (dovmu...@linux.ibm.com) wrote: > When pc_system_parse_ovmf_flash() parses the optional GUIDed table in > the end of the OVMF flash memory area, the table length field is checked > for sizes that are too small, but doesn't error on sizes that are too > big (bigger than the flash content

Re: [PATCH RFCv2 2/4] i386/pc: relocate 4g start to 1T where applicable

Hi, > > And the upstream code is now pretty much identical except for the > > default; note that for TCG you do need to keep to 40 I think. > > will TCG work with 40bits on host that supports less than that? When I understand things correctly the problem is that the phys-bits limit applies to

Re: Call for GSoC and Outreachy project ideas for summer 2022

On Mon, 21 Feb 2022 at 12:00, Klaus Jensen wrote: > > On Feb 21 09:51, Stefan Hajnoczi wrote: > > On Mon, 21 Feb 2022 at 06:14, Klaus Jensen wrote: > > > > > > On Jan 28 15:47, Stefan Hajnoczi wrote: > > > > Dear QEMU, KVM, and rust-vmm communities, > > > > QEMU will apply for Google Summer of Co

Re: [RFC PATCH] gitlab: upgrade the job definition for s390x to 20.04

On 22/2/22 00:06, Alex Bennée wrote: The new s390x machine has more of everything including the OS. As 18.04 will soon be going we might as well get onto something moderately modern. Signed-off-by: Alex Bennée Cc: Christian Borntraeger Cc: Peter Maydell --- .gitlab-ci.d/custom-runners.yml

Re: [PATCH 0/5] qmp-shell modifications for non-interactive use

Damien Hedde writes: > On 2/22/22 07:10, Markus Armbruster wrote: >> Damien Hedde writes: >> >>> Hi, >>> >>> The main idea of this series is to be a bit more user-friendly when >>> using qmp-shell in a non-interactive way: with an input redirection >>> from a file containing a list of commands.

Re: [PATCH v6 10/19] vfio-user: run vfio-user context

On Thu, Feb 17, 2022 at 02:48:57AM -0500, Jagannathan Raman wrote: > Setup a handler to run vfio-user context. The context is driven by > messages to the file descriptor associated with it - get the fd for > the context and hook up the handler with it > > Signed-off-by: Elena Ufimtseva > Signed-o

Re: [PATCH 17/20] migration: Postcopy preemption preparation on channel creation

* Peter Xu (pet...@redhat.com) wrote: > On Mon, Feb 21, 2022 at 06:39:36PM +, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > Create a new socket for postcopy to be prepared to send postcopy requested > > > pages via this specific channel, so as to not get blocked

[PATCH] pci: drop COMPAT_PROP_PCP for 2.0 machine types

COMPAT_PROP_PCP is 'on' by default and it's used for turning off PCP capability on PCIe slots for 2.0 machine types using compat machinery. Drop not needed compat glue as Q35 supports migration starting from 2.4 machine types. Signed-off-by: Igor Mammedov --- hw/i386/pc.c | 2 -- 1 file changed,

Re: [PATCH 0/5] qmp-shell modifications for non-interactive use

On Tue, Feb 22, 2022 at 10:38:09AM +0100, Damien Hedde wrote: > > > On 2/22/22 10:21, Daniel P. Berrangé wrote: > > On Tue, Feb 22, 2022 at 08:57:03AM +0100, Damien Hedde wrote: > > > > > > > > > On 2/22/22 07:10, Markus Armbruster wrote: > > > > Damien Hedde writes: > > > > > > > > > Hi, > >

Re: [PATCH] hid: trivial change to support side and extra buttons

On Tue, Feb 22, 2022 at 10:32:49AM +0100, Laurent Vivier wrote: > Gerd, > > if you acknowledge the patch I can merge it via the trivial branch. Acked-by: Gerd Hoffmann thanks, Gerd

Re: [PATCH v6 12/19] vfio-user: IOMMU support for remote device

On Thu, Feb 17, 2022 at 02:48:59AM -0500, Jagannathan Raman wrote: > +struct RemoteIommuElem { > +AddressSpace as; > +MemoryRegion mr; > +}; > + > +GHashTable *remote_iommu_elem_by_bdf; A mutable global hash table requires synchronization when device emulation runs in multiple threads.

Re: [PATCH] hid: Implement support for side and extra buttons

Le 26/11/2021 à 15:04, Noah Bergbauer a écrit : Simply set the respective bits and update the descriptor accordingly. Signed-off-by: Noah Bergbauer --- hw/input/hid.c | 2 ++ hw/usb/dev-hid.c | 6 +++--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/input/hid.c b/hw/in

Re: [PATCH 18/20] migration: Postcopy preemption enablement

* Peter Xu (pet...@redhat.com) wrote: > This patch enables postcopy-preempt feature. > > It contains two major changes to the migration logic: > > (1) Postcopy requests are now sent via a different socket from precopy > background migration stream, so as to be isolated from very high page >

Re: [PATCH 13/20] migration: Move channel setup out of postcopy_try_recover()

* Peter Xu (pet...@redhat.com) wrote: > We used to use postcopy_try_recover() to replace migration_incoming_setup() to > setup incoming channels. That's fine for the old world, but in the new world > there can be more than one channels that need setup. Better move the channel > setup out of it so

Re: [PATCH RFCv2 2/4] i386/pc: relocate 4g start to 1T where applicable

On 2/21/22 15:28, Joao Martins wrote: > On 2/21/22 06:58, Igor Mammedov wrote: >> On Fri, 18 Feb 2022 17:12:21 + >> Joao Martins wrote: >> >>> On 2/14/22 15:31, Igor Mammedov wrote: On Mon, 14 Feb 2022 15:05:00 + Joao Martins wrote: > On 2/14/22 14:53, Igor Mammedov wrote:

Re: [PATCH v6 14/19] vfio-user: handle PCI BAR accesses

On Thu, Feb 17, 2022 at 02:49:01AM -0500, Jagannathan Raman wrote: > Determine the BARs used by the PCI device and register handlers to > manage the access to the same. Hi Paolo, Please review this from the memory API perspective. vfu_object_bar_rw() reimplements MemoryRegion read/write because we

Re: [PATCH v6 11/19] vfio-user: handle PCI config space accesses

On Thu, Feb 17, 2022 at 02:48:58AM -0500, Jagannathan Raman wrote: > Define and register handlers for PCI config space accesses > > Signed-off-by: Elena Ufimtseva > Signed-off-by: John G Johnson > Signed-off-by: Jagannathan Raman > Reviewed-by: Stefan Hajnoczi > --- > hw/remote/vfio-user-obj.

Re: [PATCH v2 2/3] qapi: Document some missing details of RTC_CHANGE event

Peter Maydell writes: > The RTC_CHANGE event's documentation is missing some details: > * the offset argument is in units of seconds > * it isn't guaranteed that the RTC will implement the event > > Signed-off-by: Peter Maydell > --- > v1->v2: add the "RTC might not implement this" note > ---

Re: [PATCH 19/20] migration: Postcopy recover with preempt enabled

* Peter Xu (pet...@redhat.com) wrote: > To allow postcopy recovery, the ram fast load (preempt-only) dest QEMU thread > needs similar handling on fault tolerance. When ram_load_postcopy() fails, > instead of stopping the thread it halts with a semaphore, preparing to be > kicked again when recover

Re: [PATCH 0/2] qapi: Move RTC_CHANGE back out of target schema

Peter Maydell writes: > On Sat, 25 Sept 2021 at 08:44, Markus Armbruster wrote: >> >> Peter Maydell writes: >> >> > This patchset moves RTC_CHANGE back to misc.json, effectively >> > reverting commit 183e4281a30962, which moved the RTC_CHANGE event to >> > the target schema. That change was an

[PATCH RFC 4/4] rtc: Have event RTC_CHANGE identify the RTC by QOM path

Event RTC_CHANGE is "emitted when the guest changes the RTC time" (and the RTC supports the event). What if there's more than one RTC? Which one changed? New @qom-path identifies it. Signed-off-by: Markus Armbruster --- RFC because it's compile-tested only. Worthwhile? Let me know what you th

Re: [PATCH v2 0/2] hw/acpi: add indication for i8042 in IA-PC boot flags of the FADT table

On Mon, 21 Feb 2022, Liav Albani wrote: > This can allow the guest OS to determine more easily if i8042 controller > is present in the system or not, so it doesn't need to do probing of the > controller, but just initialize it immediately, before enumerating the > ACPI AML namespace. > > To all

<    1   2   3   4   >