[PATCH v2 2/4] block: block_dirty_bitmap_merge(): fix error path

2022-02-22 Thread Vladimir Sementsov-Ogievskiy
At the end we ignore failure of bdrv_merge_dirty_bitmap() and report success. And still set errp. That's wrong. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Nikita Lapshin --- block/monitor/bitmap-qmp-cmds.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/blo

[PULL 4/7] hw/nvram: use at24 macro

2022-02-22 Thread Laurent Vivier
From: Patrick Venture Use the macro for going from I2CSlave to EEPROMState. Signed-off-by: Patrick Venture Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20220119214329.2557049-1-vent...@google.com> Signed-off-by: Laurent Vivier --- hw/nvram/eeprom_at24c.c | 2 +- 1 file changed, 1 inserti

[PULL 3/7] target/rx: Remove unused ENV_OFFSET definition

2022-02-22 Thread Laurent Vivier
From: Philippe Mathieu-Daudé The last use of ENV_OFFSET was removed in 5e1401969b ("cpu: Move icount_decr to CPUNegativeOffsetState"); the commit of target/rx came in just afterward. Reviewed-by: Richard Henderson Reviewed-by: Yoshinori Sato Signed-off-by: Philippe Mathieu-Daudé Message-Id: <

[PATCH v2 4/4] block: simplify handling of try to merge different sized bitmaps

2022-02-22 Thread Vladimir Sementsov-Ogievskiy
We have too much logic to simply check that bitmaps are of the same size. Let's just define that hbitmap_merge() and bdrv_dirty_bitmap_merge_internal() require their argument bitmaps be of same size, this simplifies things. Let's look through the callers: For backup_init_bcs_bitmap() we already a

[PATCH v2 0/4] block/dirty-bitmaps: fix and improve bitmap merge

2022-02-22 Thread Vladimir Sementsov-Ogievskiy
v2: 01: take older patch which is better and has r-b 02: add Nikita's r-b 03: rewrite to keep original logic of no backup on failure path 04: fix comment, add missed "ret = true", keep Nikita's r-b Vladimir Sementsov-Ogievskiy (4): block/dirty-bitmap: bdrv_merge_dirty_bitmap(): add return value

[PATCH v4 27/47] target/ppc: Move xxsel to decodetree

2022-02-22 Thread matheus . ferst
From: Matheus Ferst Signed-off-by: Matheus Ferst --- target/ppc/insn32.decode| 6 target/ppc/insn64.decode| 24 target/ppc/translate/vsx-impl.c.inc | 20 ++ target/ppc/translate/vsx-ops.c.inc | 43 - 4 files

[PATCH v2 1/4] block/dirty-bitmap: bdrv_merge_dirty_bitmap(): add return value

2022-02-22 Thread Vladimir Sementsov-Ogievskiy
That simplifies handling failure in existing code and in further new usage of bdrv_merge_dirty_bitmap(). Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Hanna Reitz --- include/block/dirty-bitmap.h| 2 +- block/dirty-bitmap.c| 9 +++-- block/monitor/bitmap-qmp-cmds.

[PATCH v2] qapi/migration: Fix examples document wrong field name for arguments

2022-02-22 Thread Fabian Holler
The examples for the snapshot-* and calc-dirty-rate commands document that arguments for the commands are passed in a 'data' field. This is wrong, passing them in a "data" field results in the error: {"error": {"class": "GenericError", "desc": "QMP input member 'data' is un

Re: [PATCH 0/2] Adds designware i2c module and adds it to virt arm

2022-02-22 Thread Corey Minyard
On Mon, Feb 21, 2022 at 09:47:27AM -0800, Chris Rauer wrote: > Hi Phil, > > > What about using virtio-gpio & bitbang I2C? > > > > - virtio-gpio > > https://lore.kernel.org/qemu-devel/20201127182917.2387-5-i...@metux.net/ > > > > - bitbang I2C already in: hw/i2c/bitbang_i2c.c > Sorry for the delay.

Re: Analysis of slow distro boots in check-avocado (BootLinuxAarch64.test_virt_tcg*)

2022-02-22 Thread Daniel P . Berrangé
On Tue, Feb 22, 2022 at 04:17:23PM +, Alex Bennée wrote: > > Alex Bennée writes: > > > Hi, > > > > TL;DR: > > > > - pc-bios/edk2-aarch64-code.fd should be rebuilt without debug > > Laszlo, > > Would it be possible to do a less debug enabled version of EDK2 on the > next update to pc-bios

[PATCH 0/2] ui/cocoa: updateUIInfo threading, autorelease pools

2022-02-22 Thread Peter Maydell
This patchset was originally provoked by Akihiko Odaki noting that we have some unnecessary creation and deletion of autorelease pools in the Cocoa UI code. Patch 2 deletes them; but to get there we need to do a bit of cleanup of the updateUIInfo support, which wasn't considering threads. Tested o

[PATCH 1/2] ui/cocoa.m: Fix updateUIInfo threading issues

2022-02-22 Thread Peter Maydell
The updateUIInfo method makes Cocoa API calls. It also calls back into QEMU functions like dpy_set_ui_info(). To do this safely, we need to follow two rules: * Cocoa API calls are made on the Cocoa UI thread * When calling back into QEMU we must hold the iothread lock Fix the places where we g

[PATCH 2/2] ui/cocoa.m: Remove unnecessary NSAutoreleasePools

2022-02-22 Thread Peter Maydell
In commit 6e657e64cdc478 in 2013 we added some autorelease pools to deal with complaints from macOS when we made calls into Cocoa from threads that didn't have automatically created autorelease pools. Later on, macOS got stricter about forbidding cross-thread Cocoa calls, and in commit 5588840ff778

Re: [PATCH 1/2] ui/cocoa.m: Fix updateUIInfo threading issues

2022-02-22 Thread Akihiko Odaki
On Wed, Feb 23, 2022 at 2:06 AM Peter Maydell wrote: > > The updateUIInfo method makes Cocoa API calls. It also calls back > into QEMU functions like dpy_set_ui_info(). To do this safely, we > need to follow two rules: > * Cocoa API calls are made on the Cocoa UI thread > * When calling back i

Re: [PATCH 1/4] softmmu/cpus: Free cpu->thread in cpu_remove_sync()

2022-02-22 Thread Philippe Mathieu-Daudé
On 26/1/22 15:29, Mark Kanda wrote: vCPU hotunplug related leak reported by Valgrind: ==377357== 8 bytes in 1 blocks are definitely lost in loss record 1,029 of 8,471 ==377357==at 0x4C3ADBB: calloc (vg_replace_malloc.c:1117) ==377357==by 0x65C14CD: g_malloc0 (in /usr/lib64/libglib-2.0.so

Re: [PATCH 1/2] ui/cocoa.m: Fix updateUIInfo threading issues

2022-02-22 Thread Peter Maydell
On Tue, 22 Feb 2022 at 17:13, Akihiko Odaki wrote: > > On Wed, Feb 23, 2022 at 2:06 AM Peter Maydell > wrote: > > diff --git a/ui/cocoa.m b/ui/cocoa.m > > index a8f1cdaf926..f8d3d8ad7a6 100644 > > --- a/ui/cocoa.m > > +++ b/ui/cocoa.m > > @@ -522,8 +522,9 @@ QemuCocoaView *cocoaView; > > }

Re: Analysis of slow distro boots in check-avocado (BootLinuxAarch64.test_virt_tcg*)

2022-02-22 Thread Philippe Mathieu-Daudé
+Igor/MST for UEFI tests. On 22/2/22 17:38, Daniel P. Berrangé wrote: On Tue, Feb 22, 2022 at 04:17:23PM +, Alex Bennée wrote: Alex Bennée writes: Hi, TL;DR: - pc-bios/edk2-aarch64-code.fd should be rebuilt without debug Laszlo, Would it be possible to do a less debug enabled ve

Re: [PATCH] configure: Support empty prefixes

2022-02-22 Thread Joshua Seaton
Hi Paolo, Thanks for the quick response (and apologies about my delayed one). My project has automated scripts to build a number of other tools. The way we conventionally go about it is ``` path/to/configure '--prefix=' ... make make install DEST_DIR=$destdir ``` We currently build an earlier v5

Re: Analysis of slow distro boots in check-avocado (BootLinuxAarch64.test_virt_tcg*)

2022-02-22 Thread Peter Maydell
On Tue, 22 Feb 2022 at 17:33, Philippe Mathieu-Daudé wrote: > > +Igor/MST for UEFI tests. > > On 22/2/22 17:38, Daniel P. Berrangé wrote: > > On Tue, Feb 22, 2022 at 04:17:23PM +, Alex Bennée wrote: > >> > >> Alex Bennée writes: > >> > >>> Hi, > >>> > >>> TL;DR: > >>> > >>>- pc-bios/edk2-

[PATCH 03/22] hw/input/pckbd: QOM'ify IRQ numbers

2022-02-22 Thread Bernhard Beschow
Exposing the IRQ numbers as a QOM properties not only allows them to be configurable but also to be printed by standard QOM mechanisms. This allows isabus_dev_print() to be retired eventually. Signed-off-by: Bernhard Beschow --- hw/input/pckbd.c | 13 + 1 file changed, 9 insertions(+

[PATCH 02/22] hw/rtc/m48t59-isa: QOM'ify IRQ number

2022-02-22 Thread Bernhard Beschow
Exposing the IRQ number as a QOM property not only allows it to be configurable but also to be printed by standard QOM mechanisms. This allows isabus_dev_print() to be retired eventually. Signed-off-by: Bernhard Beschow --- hw/rtc/m48t59-isa.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletio

[PATCH 00/22] isa: Resolve unneeded IRQ attributes from ISADevice

2022-02-22 Thread Bernhard Beschow
The IRQ attributes of ISADevice are hardcoded to support up to two IRQs per device which creates an artificial limit. By not having the attributes in the first place, this limitation can be avoided altogether. The IRQ attributes are mostly used for printing ('info qtree') and there is one user, hw

[PATCH 10/22] hw/block/fdc-isa: Disuse isa_init_irq()

2022-02-22 Thread Bernhard Beschow
isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/block/fdc-isa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/fdc-isa.c b/hw/

[PATCH 01/22] hw/rtc/mc146818rtc: QOM'ify IRQ number

2022-02-22 Thread Bernhard Beschow
Exposing the IRQ number as a QOM property not only allows it to be configurable but also to be printed by standard QOM mechanisms. This allows isabus_dev_print() to be retired eventually. Signed-off-by: Bernhard Beschow --- hw/isa/piix4.c | 2 +- hw/rtc/mc146818rtc.c | 8 ++

[PATCH 07/22] hw/audio/cs4231a: Disuse isa_init_irq()

2022-02-22 Thread Bernhard Beschow
isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/audio/cs4231a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/audio/cs4231a.c b/hw/

[PATCH 11/22] hw/char/parallel: Disuse isa_init_irq()

2022-02-22 Thread Bernhard Beschow
isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/char/parallel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/char/parallel.c b/hw/

[PATCH 06/22] isa: Drop unused attributes from ISADevice

2022-02-22 Thread Bernhard Beschow
Now that the last users of ISADevice::isairq[] have been resolved during the previous commits, it can be removed for good. Signed-off-by: Bernhard Beschow --- hw/isa/isa-bus.c | 13 - include/hw/isa/isa.h | 2 -- 2 files changed, 15 deletions(-) diff --git a/hw/isa/isa-bus.c b/

[PATCH 08/22] hw/audio/gus: Disuse isa_init_irq()

2022-02-22 Thread Bernhard Beschow
isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/audio/gus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/audio/gus.c b/hw/audio/gu

[PATCH 04/22] hw/isa/isa-bus: Remove isabus_dev_print()

2022-02-22 Thread Bernhard Beschow
All isabus_dev_print() did was to print up to two IRQ numbers per device. This is redundant if the IRQ numbers are present as QOM properties (see e.g. the modified tests/qemu-iotests/172.out). Now that the last devices relying on isabus_dev_print() had their IRQ numbers QOM'ified, the contribution

[PATCH 12/22] hw/char/serial-isa: Disuse isa_init_irq()

2022-02-22 Thread Bernhard Beschow
isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/char/serial-isa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/char/serial-isa.c b

[PATCH 13/22] hw/ide/isa: Disuse isa_init_irq()

2022-02-22 Thread Bernhard Beschow
isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/ide/isa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ide/isa.c b/hw/ide/isa.c in

[PATCH 20/22] hw/tpm/tpm_tis_isa: Disuse isa_init_irq()

2022-02-22 Thread Bernhard Beschow
isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/tpm/tpm_tis_isa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/tpm/tpm_tis_isa.c b

[PATCH 05/22] hw/ppc/pnv: Determine ns16550's IRQ number from QOM property

2022-02-22 Thread Bernhard Beschow
Determine the IRQ number in the same way as for isa-ipmi-bt. This resolves the last usage of ISADevice::isairq[] which allows it to be removed. Signed-off-by: Bernhard Beschow --- hw/ppc/pnv.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c ind

[PATCH 09/22] hw/audio/sb16: Disuse isa_init_irq()

2022-02-22 Thread Bernhard Beschow
isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/audio/sb16.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/audio/sb16.c b/hw/audio/

[PATCH 16/22] hw/ipmi/isa_ipmi_kcs: Disuse isa_init_irq()

2022-02-22 Thread Bernhard Beschow
isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/ipmi/isa_ipmi_kcs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ipmi/isa_ipmi_kcs

[PATCH 14/22] hw/input/pckbd: Disuse isa_init_irq()

2022-02-22 Thread Bernhard Beschow
isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/input/pckbd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/input/pckbd.c b/hw/

[PATCH 15/22] hw/ipmi/isa_ipmi_bt: Disuse isa_init_irq()

2022-02-22 Thread Bernhard Beschow
isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/ipmi/isa_ipmi_bt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ipmi/isa_ipmi_bt.c

[PATCH 18/22] hw/net/ne2000-isa: Disuse isa_init_irq()

2022-02-22 Thread Bernhard Beschow
isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/net/ne2000-isa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/ne2000-isa.c b/h

[PATCH 22/22] isa: Remove unused isa_init_irq()

2022-02-22 Thread Bernhard Beschow
isa_init_irq() had become a trivial one-line wrapper for isa_get_irq(). The previous commits resolved all usages in favor of isa_get_irq(). isa_init_irq() can therefore be removed. Signed-off-by: Bernhard Beschow --- hw/isa/isa-bus.c | 5 - include/hw/isa/isa.h | 1 - 2 files changed, 6

[PATCH 17/22] hw/isa/piix4: Disuse isa_init_irq()

2022-02-22 Thread Bernhard Beschow
isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/isa/piix4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/isa/piix4.c b/hw/isa/piix

Re: [PATCH 02/22] hw/rtc/m48t59-isa: QOM'ify IRQ number

2022-02-22 Thread Bernhard Beschow
Am 22. Februar 2022 17:47:56 UTC schrieb Peter Maydell : >On Tue, 22 Feb 2022 at 17:41, Bernhard Beschow wrote: >> >> Exposing the IRQ number as a QOM property not only allows it to be >> configurable but also to be printed by standard QOM mechanisms. This allows >> isabus_dev_print() to be retir

[PATCH 19/22] hw/rtc/m48t59-isa: Disuse isa_init_irq()

2022-02-22 Thread Bernhard Beschow
isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/rtc/m48t59-isa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/rtc/m48t59-isa.c b/h

[PATCH 21/22] hw/isa/isa-bus: Disuse isa_init_irq()

2022-02-22 Thread Bernhard Beschow
isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/isa/isa-bus.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/isa/isa-bus.c b/hw/is

Re: [PATCH 02/22] hw/rtc/m48t59-isa: QOM'ify IRQ number

2022-02-22 Thread Peter Maydell
On Tue, 22 Feb 2022 at 17:41, Bernhard Beschow wrote: > > Exposing the IRQ number as a QOM property not only allows it to be > configurable but also to be printed by standard QOM mechanisms. This allows > isabus_dev_print() to be retired eventually. > > Signed-off-by: Bernhard Beschow > --- > hw

Re: Analysis of slow distro boots in check-avocado (BootLinuxAarch64.test_virt_tcg*)

2022-02-22 Thread Philippe Mathieu-Daudé
+Beraldo On 22/2/22 18:37, Peter Maydell wrote: On Tue, 22 Feb 2022 at 17:33, Philippe Mathieu-Daudé wrote: +Igor/MST for UEFI tests. On 22/2/22 17:38, Daniel P. Berrangé wrote: On Tue, Feb 22, 2022 at 04:17:23PM +, Alex Bennée wrote: Alex Bennée writes: Hi, TL;DR: - pc-bios/

Re: [PATCH v4 02/47] target/ppc: moved vector even and odd multiplication to decodetree

2022-02-22 Thread Richard Henderson
On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: From: "Lucas Mateus Castro (alqotel)" Moved the instructions vmulesb, vmulosb, vmuleub, vmuloub, vmulesh, vmulosh, vmuleuh, vmulouh, vmulesw, vmulosw, muleuw and vmulouw from legacy to decodetree. Implemented the instructions vmulesd, vmulos

Re: [PATCH v4 04/47] target/ppc: vmulh* instructions without helpers

2022-02-22 Thread Richard Henderson
On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: From: "Lucas Mateus Castro (alqotel)" Changed vmulhuw, vmulhud, vmulhsw, vmulhsd to not use helpers. Signed-off-by: Lucas Mateus Castro (alqotel) Signed-off-by: Matheus Ferst --- Changes in v4: Changed from gvec to i64, this resulted in

Re: [PATCH v4 03/47] target/ppc: Moved vector multiply high and low to decodetree

2022-02-22 Thread Richard Henderson
On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: From: "Lucas Mateus Castro (alqotel)" Moved instructions vmulld, vmulhuw, vmulhsw, vmulhud and vmulhsd to decodetree Signed-off-by: Lucas Mateus Castro (alqotel) Signed-off-by: Matheus Ferst --- target/ppc/helper.h | 8 ++

Re: [PATCH v4 05/47] target/ppc: Implement vmsumcud instruction

2022-02-22 Thread Richard Henderson
On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: From: Víctor Colombo Based on [1] by Lijun Pan, which was never merged into master. [1]:https://lists.gnu.org/archive/html/qemu-ppc/2020-07/msg00419.html Signed-off-by: Víctor Colombo Signed-off-by: Matheus Ferst --- Changes in v4: Fixed

Re: [PATCH v4 07/47] target/ppc: Move vexts[bhw]2[wd] to decodetree

2022-02-22 Thread Richard Henderson
On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: +static void gen_vexts_i64(TCGv_i64 t, TCGv_i64 b, int64_t s) +{ +tcg_gen_shli_i64(t, b, s); +tcg_gen_sari_i64(t, t, s); +} + +static void gen_vexts_i32(TCGv_i32 t, TCGv_i32 b, int32_t s) +{ +tcg_gen_shli_i32(t, b, s); +tcg_ge

Re: [PATCH v4 09/47] target/ppc: Move Vector Compare Equal/Not Equal/Greater Than to decodetree

2022-02-22 Thread Richard Henderson
On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: From: Matheus Ferst Signed-off-by: Matheus Ferst --- target/ppc/helper.h | 30 -- target/ppc/insn32.decode| 24 target/ppc/int_helper.c | 54 - target/ppc/translat

Re: [PATCH 18/31] vhost: Shadow virtqueue buffers forwarding

2022-02-22 Thread Eugenio Perez Martin
On Tue, Feb 8, 2022 at 9:11 AM Jason Wang wrote: > > > 在 2022/2/2 上午1:08, Eugenio Perez Martin 写道: > > On Sun, Jan 30, 2022 at 5:43 AM Jason Wang wrote: > >> > >> 在 2022/1/22 上午4:27, Eugenio Pérez 写道: > >>> Initial version of shadow virtqueue that actually forward buffers. There > >>> is no iommu

Re: [PATCH v4 10/47] target/ppc: Move Vector Compare Not Equal or Zero to decodetree

2022-02-22 Thread Richard Henderson
On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: From: Matheus Ferst Signed-off-by: Matheus Ferst --- target/ppc/helper.h | 9 ++-- target/ppc/insn32.decode| 4 ++ target/ppc/int_helper.c | 50 +- target/ppc/translate/vmx-i

Re: [PATCH v4 11/47] target/ppc: Implement Vector Compare Equal Quadword

2022-02-22 Thread Richard Henderson
On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: From: Matheus Ferst Implement the following PowerISA v3.1 instructions: vcmpequq: Vector Compare Equal Quadword Suggested-by: Richard Henderson Signed-off-by: Matheus Ferst --- v4: - Branchless implementation (rth) --- target/ppc/insn32

Re: [PATCH v4 12/47] target/ppc: Implement Vector Compare Greater Than Quadword

2022-02-22 Thread Richard Henderson
On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: From: Matheus Ferst Implement the following PowerISA v3.1 instructions: vcmpgtsq: Vector Compare Greater Than Signed Quadword vcmpgtuq: Vector Compare Greater Than Unsigned Quadword Signed-off-by: Matheus Ferst --- v4: - Branchless implem

Re: [PATCH v6 01/19] configure, meson: override C compiler for cmake

2022-02-22 Thread Jag Raman
> On Feb 20, 2022, at 3:27 AM, Paolo Bonzini wrote: > > On 2/18/22 15:49, Jag Raman wrote: >> Concerning the generated files, I see the following in >> CMakeMesonToolchainFile.cmake: >> Without patch: set(CMAKE_C_COMPILER "/opt/rh/devtoolset-9/root/usr/bin/cc" >> "-m64" "-mcx16”) >> With patc

Re: [PATCH v4 14/47] target/ppc: implement vstri[bh][lr]

2022-02-22 Thread Richard Henderson
On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: From: Matheus Ferst Signed-off-by: Matheus Ferst --- v4: - vstri helpers return CR field (rth) --- target/ppc/helper.h | 4 target/ppc/insn32.decode| 10 ++ target/ppc/int_helper.c

Re: [PATCH v4 15/47] target/ppc: implement vclrlb

2022-02-22 Thread Richard Henderson
On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: +static bool trans_VCLRLB(DisasContext *ctx, arg_VX *a) +{ +TCGv_i64 rb, mh, ml, tmp, + ones = tcg_constant_i64(-1), + zero = tcg_constant_i64(0); + +rb = tcg_temp_new_i64(); +mh = tcg_temp_new_i64(); +

Re: [PATCH v4 16/47] target/ppc: implement vclrrb

2022-02-22 Thread Richard Henderson
On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: From: Matheus Ferst Signed-off-by: Matheus Ferst --- target/ppc/insn32.decode| 1 + target/ppc/translate/vmx-impl.c.inc | 32 + 2 files changed, 25 insertions(+), 8 deletions(-) Reviewed-by: Ric

[PATCH v2 00/22] isa: Resolve unneeded IRQ attributes from ISADevice

2022-02-22 Thread Bernhard Beschow
v2: The newly QOM'ified devices now report an error to the user in their realize functions if the configured IRQ number is greater than 15. v1: The IRQ attributes of ISADevice are hardcoded to support up to two IRQs per device which creates an artificial limit. By not having the attributes in the

[PATCH v2 04/22] hw/isa/isa-bus: Remove isabus_dev_print()

2022-02-22 Thread Bernhard Beschow
All isabus_dev_print() did was to print up to two IRQ numbers per device. This is redundant if the IRQ numbers are present as QOM properties (see e.g. the modified tests/qemu-iotests/172.out). Now that the last devices relying on isabus_dev_print() had their IRQ numbers QOM'ified, the contribution

[PATCH v2 01/22] hw/rtc/mc146818rtc: QOM'ify IRQ number

2022-02-22 Thread Bernhard Beschow
Exposing the IRQ number as a QOM property not only allows it to be configurable but also to be printed by standard QOM mechanisms. This allows isabus_dev_print() to be retired eventually. Signed-off-by: Bernhard Beschow --- hw/isa/piix4.c | 2 +- hw/rtc/mc146818rtc.c | 13

[PATCH v2 03/22] hw/input/pckbd: QOM'ify IRQ numbers

2022-02-22 Thread Bernhard Beschow
Exposing the IRQ numbers as a QOM properties not only allows them to be configurable but also to be printed by standard QOM mechanisms. This allows isabus_dev_print() to be retired eventually. Signed-off-by: Bernhard Beschow --- hw/input/pckbd.c | 26 ++ 1 file changed, 2

[PATCH v2 09/22] hw/audio/sb16: Disuse isa_init_irq()

2022-02-22 Thread Bernhard Beschow
isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/audio/sb16.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/audio/sb16.c b/hw/audio/

[PATCH v2 15/22] hw/ipmi/isa_ipmi_bt: Disuse isa_init_irq()

2022-02-22 Thread Bernhard Beschow
isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/ipmi/isa_ipmi_bt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ipmi/isa_ipmi_bt.c

[PATCH v2 02/22] hw/rtc/m48t59-isa: QOM'ify IRQ number

2022-02-22 Thread Bernhard Beschow
Exposing the IRQ number as a QOM property not only allows it to be configurable but also to be printed by standard QOM mechanisms. This allows isabus_dev_print() to be retired eventually. Signed-off-by: Bernhard Beschow --- hw/rtc/m48t59-isa.c | 9 - 1 file changed, 8 insertions(+), 1 de

[PATCH v2 08/22] hw/audio/gus: Disuse isa_init_irq()

2022-02-22 Thread Bernhard Beschow
isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/audio/gus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/audio/gus.c b/hw/audio/gu

[PATCH v2 07/22] hw/audio/cs4231a: Disuse isa_init_irq()

2022-02-22 Thread Bernhard Beschow
isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/audio/cs4231a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/audio/cs4231a.c b/hw/

[PATCH v2 05/22] hw/ppc/pnv: Determine ns16550's IRQ number from QOM property

2022-02-22 Thread Bernhard Beschow
Determine the IRQ number in the same way as for isa-ipmi-bt. This resolves the last usage of ISADevice::isairq[] which allows it to be removed. Signed-off-by: Bernhard Beschow --- hw/ppc/pnv.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c ind

[PATCH v2 11/22] hw/char/parallel: Disuse isa_init_irq()

2022-02-22 Thread Bernhard Beschow
isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/char/parallel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/char/parallel.c b/hw/

[PATCH v2 21/22] hw/isa/isa-bus: Disuse isa_init_irq()

2022-02-22 Thread Bernhard Beschow
isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/isa/isa-bus.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/isa/isa-bus.c b/hw/is

[PATCH v2 06/22] isa: Drop unused attributes from ISADevice

2022-02-22 Thread Bernhard Beschow
Now that the last users of ISADevice::isairq[] have been resolved during the previous commits, it can be removed for good. Signed-off-by: Bernhard Beschow --- hw/isa/isa-bus.c | 13 - include/hw/isa/isa.h | 2 -- 2 files changed, 15 deletions(-) diff --git a/hw/isa/isa-bus.c b/

[PATCH v2 14/22] hw/input/pckbd: Disuse isa_init_irq()

2022-02-22 Thread Bernhard Beschow
isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/input/pckbd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/input/pckbd.c b/hw/

[PATCH 4/8] meson: drop the .fa library suffix

2022-02-22 Thread marcandre . lureau
From: Marc-André Lureau The .fa suffix was a temporary hack introduced in commit 1f0a1d8a51 ("build-sys hack: link with whole .fa archives") when the build system was mixed between meson & makefiles. It is no longer needed. Signed-off-by: Marc-André Lureau --- docs/devel/build-system.rst|

[PATCH v2 19/22] hw/rtc/m48t59-isa: Disuse isa_init_irq()

2022-02-22 Thread Bernhard Beschow
isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/rtc/m48t59-isa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/rtc/m48t59-isa.c b/h

[PATCH v2 12/22] hw/char/serial-isa: Disuse isa_init_irq()

2022-02-22 Thread Bernhard Beschow
isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/char/serial-isa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/char/serial-isa.c b

[PATCH v2 10/22] hw/block/fdc-isa: Disuse isa_init_irq()

2022-02-22 Thread Bernhard Beschow
isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/block/fdc-isa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/fdc-isa.c b/hw/

[PATCH 6/8] char: move qemu_openpty_raw from util/ to char/

2022-02-22 Thread marcandre . lureau
From: Marc-André Lureau It is only needed by char-pty. Signed-off-by: Marc-André Lureau --- include/qemu-common.h | 2 - chardev/char-pty.c| 104 +++ util/qemu-openpty.c | 139 -- chardev/meson.build | 4 +- util/m

[PATCH v2 17/22] hw/isa/piix4: Disuse isa_init_irq()

2022-02-22 Thread Bernhard Beschow
isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/isa/piix4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/isa/piix4.c b/hw/isa/piix

[PATCH v2 18/22] hw/net/ne2000-isa: Disuse isa_init_irq()

2022-02-22 Thread Bernhard Beschow
isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/net/ne2000-isa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/ne2000-isa.c b/h

[PATCH v2 20/22] hw/tpm/tpm_tis_isa: Disuse isa_init_irq()

2022-02-22 Thread Bernhard Beschow
isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/tpm/tpm_tis_isa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/tpm/tpm_tis_isa.c b

[PATCH 8/8] Replace GCC_FMT_ATTR with G_GNUC_PRINTF

2022-02-22 Thread marcandre . lureau
From: Marc-André Lureau One less qemu-specific macro. It also helps to make some headers/units only depend on glib, and thus moved in standalone projects eventually. Signed-off-by: Marc-André Lureau --- audio/audio.h | 4 +-- block/qcow2.h |

[PATCH v2 13/22] hw/ide/isa: Disuse isa_init_irq()

2022-02-22 Thread Bernhard Beschow
isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/ide/isa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ide/isa.c b/hw/ide/isa.c in

[PATCH v2 16/22] hw/ipmi/isa_ipmi_kcs: Disuse isa_init_irq()

2022-02-22 Thread Bernhard Beschow
isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow --- hw/ipmi/isa_ipmi_kcs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ipmi/isa_ipmi_kcs

[PATCH 0/8] Misc build fixes and cleanups

2022-02-22 Thread marcandre . lureau
From: Marc-André Lureau Hi, A small collection of patches gleaned while working on different things. Marc-André Lureau (8): meson: fix generic location of vss headers qga/vss-win32: check old VSS SDK headers qga/vss: update informative message about MinGW meson: drop the .fa library suf

[PATCH v2 22/22] isa: Remove unused isa_init_irq()

2022-02-22 Thread Bernhard Beschow
isa_init_irq() had become a trivial one-line wrapper for isa_get_irq(). The previous commits resolved all usages in favor of isa_get_irq(). isa_init_irq() can therefore be removed. Signed-off-by: Bernhard Beschow --- hw/isa/isa-bus.c | 5 - include/hw/isa/isa.h | 1 - 2 files changed, 6

[PATCH 2/8] qga/vss-win32: check old VSS SDK headers

2022-02-22 Thread marcandre . lureau
From: Marc-André Lureau The VssCoordinator & VssAdmin interfaces have been moved to vsadmin.h in the Windows SDK. Signed-off-by: Marc-André Lureau --- meson.build| 3 +++ qga/vss-win32/vss-common.h | 3 ++- qga/vss-win32/install.cpp | 4 qga/vss-win32/provider.cpp | 4 +++

[PATCH 5/8] meson: use chardev_ss dependencies

2022-02-22 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 40abe86767e8..b1d2fcecbdcf 100644 --- a/meson.build +++ b/meson.build @@ -3000,7 +3000,7 @@ libqmp = static_library('qmp',

[PATCH 1/8] meson: fix generic location of vss headers

2022-02-22 Thread marcandre . lureau
From: Marc-André Lureau This is a left-over, despite requesting the change before the merge. Fixes: commit 8821a389 ("configure, meson: replace VSS SDK checks and options with --enable-vss-sdk") Signed-off-by: Marc-André Lureau --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[PATCH 3/8] qga/vss: update informative message about MinGW

2022-02-22 Thread marcandre . lureau
From: Marc-André Lureau The headers are now all available in MinGW master branch. (commit 13390dbbf885f and earlier) aiming for 10.0. Signed-off-by: Marc-André Lureau --- qga/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/meson.build b/qga/meson.build index

[PATCH 7/8] Drop qemu_foo() socket API wrapper

2022-02-22 Thread marcandre . lureau
From: Marc-André Lureau The socket API wrappers were initially introduced in commit 00aa0040 ("Wrap recv to avoid warnings"), but made redundatant with commit a2d96af4 ("osdep: add wrappers for socket functions") which fixes the win32 declarations and thus removed the earlier warnings. Signed-of

Re: [PATCH v2 20/22] hw/tpm/tpm_tis_isa: Disuse isa_init_irq()

2022-02-22 Thread Stefan Berger
On 2/22/22 14:34, Bernhard Beschow wrote: isa_init_irq() has become a trivial one-line wrapper for isa_get_irq(). Use the original instead such that isa_init_irq() can be removed eventually. Signed-off-by: Bernhard Beschow Reviewed-by: Stefan Berger --- hw/tpm/tpm_tis_isa.c | 2 +- 1

Re: [PULL 00/25] qtest patches and misc header clean-ups

2022-02-22 Thread Peter Maydell
On Mon, 21 Feb 2022 at 12:00, Thomas Huth wrote: > > Hi! > > The following changes since commit e670f6d825d4dee248b311197fd4048469d6772b: > > Merge remote-tracking branch 'remotes/legoater/tags/pull-ppc-20220218' into > staging (2022-02-20 15:05:41 +) > > are available in the Git repositor

Re: [PATCH v3 3/6] target/riscv: Introduce privilege version field in the CSR ops.

2022-02-22 Thread Atish Patra
On Mon, Feb 21, 2022 at 1:42 PM Alistair Francis wrote: > > On Sun, Feb 6, 2022 at 7:19 PM Atish Patra wrote: > > > > To allow/disallow the CSR access based on the privilege spec, a new field > > in the csr_ops is introduced. It also adds the privileged specification > > version (v1.12) for the C

Re: [PATCH v7 2/2] drivers/virt: vmgenid: add vm generation id driver

2022-02-22 Thread Jason A. Donenfeld
Hi Adrian, This thread seems to be long dead, but I couldn't figure out what happened to the ideas in it. I'm specifically interested in this part: On Wed, Feb 24, 2021 at 9:48 AM Adrian Catangiu wrote: > +static void vmgenid_acpi_notify(struct acpi_device *device, u32 event) > +{ > + uuid

Re: [PATCH 7/8] Drop qemu_foo() socket API wrapper

2022-02-22 Thread Philippe Mathieu-Daudé
On 22/2/22 20:40, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau The socket API wrappers were initially introduced in commit 00aa0040 ("Wrap recv to avoid warnings"), but made redundatant with commit a2d96af4 ("osdep: add wrappers for socket functions") which fixes the win32 declara

Re: [PATCH v2 1/2] block/curl.c: Set error message string if curl_init_state() fails

2022-02-22 Thread Philippe Mathieu-Daudé
On 22/2/22 16:23, Peter Maydell wrote: In curl_open(), the 'out' label assumes that the state->errmsg string has been set (either by curl_easy_perform() or by manually copying a string into it); however if curl_init_state() fails we will jump to that label without setting the string. Add the mis

[PATCH v1 1/2] hw/ssi: Add Ibex SPI device model

2022-02-22 Thread Alistair Francis
From: Wilfred Mallawa Adds the SPI_HOST device model for ibex. The device specification is as per [1]. The model has been tested on opentitan with spi_host unit tests written for TockOS. [1] https://docs.opentitan.org/hw/ip/spi_host/doc/ Signed-off-by: Wilfred Mallawa --- hw/ssi/ibex_spi_host

[PATCH v1 2/2] riscv: opentitan: Connect opentitan SPI Host

2022-02-22 Thread Alistair Francis
From: Wilfred Mallawa Conenct spi host[1/0] to opentitan. Signed-off-by: Wilfred Mallawa --- hw/riscv/opentitan.c | 42 include/hw/riscv/opentitan.h | 16 -- 2 files changed, 52 insertions(+), 6 deletions(-) diff --git a/hw/riscv/openti

Re: [PATCH v4 18/47] target/ppc: implement vgnb

2022-02-22 Thread Richard Henderson
On 2/22/22 04:36, matheus.fe...@eldorado.org.br wrote: From: Matheus Ferst Suggested-by: Richard Henderson Signed-off-by: Matheus Ferst --- v4: - Optimized implementation (rth) --- target/ppc/insn32.decode| 5 ++ target/ppc/translate/vmx-impl.c.inc | 135 ++

  1   2   3   4   >