Re: [PATCH 09/31] vhost-vdpa: Take into account SVQ in vhost_vdpa_set_vring_call

2022-02-21 Thread Eugenio Perez Martin
On Mon, Feb 21, 2022 at 8:39 AM Jason Wang wrote: > > > 在 2022/2/18 下午8:35, Eugenio Perez Martin 写道: > > On Tue, Feb 8, 2022 at 4:23 AM Jason Wang wrote: > >> > >> 在 2022/1/31 下午11:34, Eugenio Perez Martin 写道: > >>> On Sat, Jan 29, 2022 at 9:06 AM Jason Wang wrote: > 在 2022/1/22 上午4:27, Eug

Re: [PATCH v2] ide: Increment BB in-flight counter for TRIM BH

2022-02-21 Thread Hanna Reitz
On 17.02.22 22:02, John Snow wrote: On Tue, Feb 15, 2022 at 12:14 PM Hanna Reitz wrote: Ping (I can take it too, if you’d like, John, but you’re listed as the only maintainer for hw/ide, so... Just say the word, though!) Sorry, I sent you a mail off-list at the time where I said you were fr

Re: [PATCH] tests/vm: Update haiku test vm to R1/Beta3

2022-02-21 Thread Thomas Huth
On 16/02/2022 19.12, Alexander von Gluck IV wrote: February 16, 2022 10:26 AM, "Thomas Huth" wrote: On 16/02/2022 16.42, Alexander von Gluck IV wrote: --- tests/vm/haiku.x86_64 | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/vm/haiku.x86_64 b/tests/vm/haiku.x86

Re: [PATCH 18/31] vhost: Shadow virtqueue buffers forwarding

2022-02-21 Thread Eugenio Perez Martin
On Mon, Feb 21, 2022 at 8:44 AM Jason Wang wrote: > > > 在 2022/2/17 下午8:48, Eugenio Perez Martin 写道: > > On Tue, Feb 8, 2022 at 9:16 AM Jason Wang wrote: > >> > >> 在 2022/2/1 下午7:25, Eugenio Perez Martin 写道: > >>> On Sun, Jan 30, 2022 at 7:47 AM Jason Wang wrote: > 在 2022/1/22 上午4:27, Eugen

Re: [PATCH] linux-headers: update to 5.17

2022-02-21 Thread Cornelia Huck
On Thu, Feb 17 2022, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > include/standard-headers/asm-x86/kvm_para.h | 1 + > include/standard-headers/drm/drm_fourcc.h | 11 ++ > include/standard-headers/linux/ethtool.h | 1 + > include/standard-headers/linux/fuse.h

[PATCH] configure: Disable capstone and slirp in the --without-default-features mode

2022-02-21 Thread Thomas Huth
For the users, it looks a little bit weird that capstone and slirp are not disabled automatically if they run the configure script with the "--without-default-features" option, so let's do that now. Note: fdt is *not* changed accordingly since this affects the targets that we can build, so disablin

Re: [PATCH v3 4/4] tests/qtest/virtio-iommu-test: Check bypass config

2022-02-21 Thread Thomas Huth
On 14/02/2022 13.43, Jean-Philippe Brucker wrote: The bypass config field should be initialized to 1 by default. Reviewed-by: Eric Auger Signed-off-by: Jean-Philippe Brucker --- tests/qtest/virtio-iommu-test.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/qtest/virtio-iommu-te

Re: [PATCH 0/7] tests/qtest: add some tests for virtio-net failover (part 2)

2022-02-21 Thread Thomas Huth
On 15/02/2022 10.20, Laurent Vivier wrote: Ping ? Sorry for the delay, queued to my testing-next branch now: https://gitlab.com/thuth/qemu/-/commits/testing-next Thomas On 03/02/2022 15:15, Laurent Vivier wrote: This series adds more qtest test cases to test virtio-net failover feature.

[PULL 01/26] MAINTAINERS: Adding myself as a reviewer of some components

2022-02-21 Thread Peter Maydell
From: Ani Sinha Added myself as a reviewer of vmgenid, unimplemented device and empty slot. Signed-off-by: Ani Sinha Reviewed-by: Philippe Mathieu-Daudé Message-id: 20220131122001.1476101-1-...@anisinha.ca Signed-off-by: Peter Maydell --- MAINTAINERS | 3 +++ 1 file changed, 3 insertions(+)

[PULL 02/26] tests/qtest: add qtests for npcm7xx sdhci

2022-02-21 Thread Peter Maydell
From: Shengtan Mao Reviewed-by: Hao Wu Reviewed-by: Chris Rauer Signed-off-by: Shengtan Mao Signed-off-by: Patrick Venture Message-id: 20220208181843.4003568-1-vent...@google.com Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- tests/qtest/npcm7xx_sdhci-test.c | 215

[PULL 00/26] target-arm queue

2022-02-21 Thread Peter Maydell
.git tags/pull-target-arm-20220221 for you to fetch changes up to d6333e2543fa41aed4d33f77c808168373e39bff: ui/cocoa: Fix the leak of qemu_console_get_label (2022-02-21 09:12:18 +) arm, cocoa and misc: * MAINTAINERS file updat

[PULL 18/26] include: Move QEMU_MAP_* constants to mmap-alloc.h

2022-02-21 Thread Peter Maydell
The QEMU_MAP_* constants are used only as arguments to the qemu_ram_mmap() function. Move them to mmap-alloc.h, where that function's prototype is defined. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-id: 20220208200856.3558249-4-peter

[PULL 07/26] target/arm: Move '-cpu host' code to cpu64.c

2022-02-21 Thread Peter Maydell
Now that KVM has dropped AArch32 host support, the 'host' CPU type is always AArch64, and we can move it to cpu64.c. This move will allow us to share code between it and '-cpu max', which should behave the same as '-cpu host' when using KVM or HVF. Signed-off-by: Peter Maydell Reviewed-by: Phili

[PULL 03/26] hvf: arm: Use macros for sysreg shift/masking

2022-02-21 Thread Peter Maydell
From: Alexander Graf We are parsing the syndrome field for sysregs in multiple places across the hvf code, but repeat shift/mask operations with hard coded constants every time. This is an error prone approach and makes it harder to reason about the correctness of these operations. Let's introdu

[PULL 11/26] target/arm: Fix '-cpu max' for HVF

2022-02-21 Thread Peter Maydell
Currently when using hvf we mishandle '-cpu max': we fall through to the TCG version of its initfn, which then sets a lot of feature bits that the real host CPU doesn't have. The hvf accelerator code then exposes these bogus ID register values to the guest because it doesn't check that the host rea

[PULL 21/26] MAINTAINERS: Add Akihiko Odaki to macOS-relateds

2022-02-21 Thread Peter Maydell
From: Akihiko Odaki Signed-off-by: Akihiko Odaki Reviewed-by: Christian Schoenebeck Reviewed-by: Philippe Mathieu-Daudé Message-id: 20220213021215.1974-1-akihiko.od...@gmail.com Signed-off-by: Peter Maydell --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/M

[PULL 05/26] Mark remaining global TypeInfo instances as const

2022-02-21 Thread Peter Maydell
From: Bernhard Beschow More than 1k of TypeInfo instances are already marked as const. Mark the remaining ones, too. This commit was created with: git grep -z -l 'static TypeInfo' -- '*.c' | \ xargs -0 sed -i 's/static TypeInfo/static const TypeInfo/' Signed-off-by: Bernhard Beschow Review

[PULL 13/26] Kconfig: Add I2C_DEVICES device group

2022-02-21 Thread Peter Maydell
Currently there is no way for a board model's Kconfig stanza to say "I have an i2c bus which the user can plug an i2c device into, build all the free-standing i2c devices". The Kconfig mechanism for this is the "device group". Add an I2C_DEVICES group along the same lines as the existing PCI_DEVICE

[PULL 04/26] hvf: arm: Handle unknown ID registers as RES0

2022-02-21 Thread Peter Maydell
From: Alexander Graf Recent Linux versions added support to read ID_AA64ISAR2_EL1. On M1, those reads trap into QEMU which handles them as faults. However, AArch64 ID registers should always read as RES0. Let's handle them accordingly. This fixes booting Linux 5.17 guests. Cc: qemu-sta...@nong

[PULL 14/26] Kconfig: Add 'imply I2C_DEVICES' on boards with available i2c bus

2022-02-21 Thread Peter Maydell
For arm boards with an i2c bus which a user could reasonably want to plug arbitrary devices, add 'imply I2C_DEVICES' to the Kconfig stanza. Signed-off-by: Peter Maydell Acked-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Hao Wu Message-id: 20220208155911.3408455-3-peter.ma

Re: Call for GSoC and Outreachy project ideas for summer 2022

2022-02-21 Thread Michal Prívozník
On 2/19/22 14:46, Stefan Hajnoczi wrote: > On Fri, 18 Feb 2022 at 16:03, Paolo Bonzini wrote: >> >> On 2/18/22 12:39, Michal Prívozník wrote: >>> On 2/17/22 18:52, Paolo Bonzini wrote: I would like to co-mentor one or more projects about adding more statistics to Mark Kanda's newly-born

[PULL 06/26] checkpatch: Ensure that TypeInfos are const

2022-02-21 Thread Peter Maydell
From: Bernhard Beschow Now that all static TypeInfo instances are declared const, prevent that new non-const instances are created. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé Message-id: 20220117145805.173070-3-shen...@gmail.com Signed-off-by: Peter Maydell --- scrip

[PULL 09/26] target/arm: Make KVM -cpu max exactly like -cpu host

2022-02-21 Thread Peter Maydell
Currently for KVM the intention is that '-cpu max' and '-cpu host' are the same thing, but because we did this with two separate pieces of code they have got a little bit out of sync. Specifically, 'max' has a 'sve-max-vq' property, and 'host' does not. Bring the two together by having the initfn

[PATCH] hw/arm/mps2-tz.c: Update AN547 documentation URL

2022-02-21 Thread Peter Maydell
The AN547 application note URL has changed: update our comment accordingly. (Rev B is still downloadable from the old URL, but there is a new Rev C of the document now.) Signed-off-by: Peter Maydell --- hw/arm/mps2-tz.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/m

[PULL 08/26] target/arm: Use aarch64_cpu_register() for 'host' CPU type

2022-02-21 Thread Peter Maydell
Use the aarch64_cpu_register() machinery to register the 'host' CPU type. This doesn't gain us anything functionally, but it does mean that the code for initializing it looks more like that for the other CPU types, in that its initfn then doesn't need to call arm_cpu_post_init() (because aarch64_c

[PULL 10/26] target/arm: Unindent unnecessary else-clause

2022-02-21 Thread Peter Maydell
Now that the if() branch of the condition in aarch64_max_initfn() returns early, we don't need to keep the rest of the code in the function inside an else block. Remove the else, unindenting that code. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Andrew Jones Re

[PULL 15/26] hw/arm/armv7m: Handle disconnected clock inputs

2022-02-21 Thread Peter Maydell
In the armv7m object, handle clock inputs that aren't connected. This is always an error for 'cpuclk'. For 'refclk' it is OK for this to be disconnected, but we need to handle it by not trying to connect a sourceless-clock to the systick device. This fixes a bug where on the mps2-an521 and similar

[PULL 12/26] target/arm: Support PAuth extension for hvf

2022-02-21 Thread Peter Maydell
Currently we don't allow guests under hvf to use the PAuth extension, because we didn't have any special code to handle that, and therefore in arm_cpu_pauth_finalize() we will sanitize the ID_AA64ISAR1 value the guest sees to clear the PAuth related fields. Add support for this in the same way tha

[PULL 26/26] ui/cocoa: Fix the leak of qemu_console_get_label

2022-02-21 Thread Peter Maydell
From: Akihiko Odaki Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daudé Message-id: 20220215080307.69550-14-f4...@amsat.org Message-Id: <20220213021329.2066-1-akihiko.od...@gmail.com> [PMD: Use g_autofree, suggested by Zoltan BALATON] Signed-off-by: Philippe Mathieu-Daudé Signed-o

Re: Call for GSoC and Outreachy project ideas for summer 2022

2022-02-21 Thread Stefan Hajnoczi
On Mon, 21 Feb 2022 at 06:14, Klaus Jensen wrote: > > On Jan 28 15:47, Stefan Hajnoczi wrote: > > Dear QEMU, KVM, and rust-vmm communities, > > QEMU will apply for Google Summer of Code 2022 > > (https://summerofcode.withgoogle.com/) and has been accepted into > > Outreachy May-August 2022 (https:

[PULL 19/26] include: Move qemu_[id]cache_* declarations to new qemu/cacheinfo.h

2022-02-21 Thread Peter Maydell
The qemu_icache_linesize, qemu_icache_linesize_log, qemu_dcache_linesize, and qemu_dcache_linesize_log variables are not used in many files. Move them out of osdep.h to a new qemu/cacheinfo.h, and document them. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richa

[PULL 24/26] ui/cocoa: Remove allowedFileTypes restriction in SavePanel

2022-02-21 Thread Peter Maydell
From: Philippe Mathieu-Daudé setAllowedFileTypes is deprecated in macOS 12. Per Akihiko Odaki [*]: An image file, which is being chosen by the panel, can be a raw file and have a variety of file extensions and many are not covered by the provided list (e.g. "udf"). Other platforms like

[PULL 16/26] include: Move qemu_madvise() and related #defines to new qemu/madvise.h

2022-02-21 Thread Peter Maydell
The function qemu_madvise() and the QEMU_MADV_* constants associated with it are used in only 10 files. Move them out of osdep.h to a new qemu/madvise.h header that is included where it is needed. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson M

[PULL 22/26] hw/timer: fix a9gtimer vmstate

2022-02-21 Thread Peter Maydell
From: Pavel Dovgalyuk A9 gtimer includes global control field and number of per-cpu fields. But only per-cpu ones are migrated. This patch adds a subsection for global control field migration. Signed-off-by: Pavel Dovgalyuk Message-id: 164422345976.2186660.1104517592452494510.stgit@pasha-ThinkP

[PULL 25/26] ui/cocoa: Do not alert even without block devices

2022-02-21 Thread Peter Maydell
From: Akihiko Odaki Signed-off-by: Akihiko Odaki Message-id: 20220215080307.69550-13-f4...@amsat.org Message-Id: <20220213021418.2155-1-akihiko.od...@gmail.com> Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Peter Maydell --- ui/cocoa.m | 5 - 1 file changed, 5 deletions(-) diff --

[PULL 17/26] include: Move qemu_mprotect_*() to new qemu/mprotect.h

2022-02-21 Thread Peter Maydell
The qemu_mprotect_*() family of functions are used in very few files; move them from osdep.h to a new qemu/mprotect.h. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-id: 20220208200856.3558249-3-peter.mayd...@linaro.org --- include/qemu/

[PULL 20/26] include: Move hardware version declarations to new qemu/hw-version.h

2022-02-21 Thread Peter Maydell
The "hardware version" machinery (qemu_set_hw_version(), qemu_hw_version(), and the QEMU_HW_VERSION define) is used by fewer than 10 files. Move it out from osdep.h into a new qemu/hw-version.h. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Mes

Re: Call for GSoC and Outreachy project ideas for summer 2022

2022-02-21 Thread Stefan Hajnoczi
On Fri, 18 Feb 2022 at 21:05, Alexander Bulekov wrote: > > On 220128 1547, Stefan Hajnoczi wrote: > > Dear QEMU, KVM, and rust-vmm communities, > > QEMU will apply for Google Summer of Code 2022 > > (https://summerofcode.withgoogle.com/) and has been accepted into > > Outreachy May-August 2022 (ht

[PULL 23/26] hw/arm: add initial mori-bmc board

2022-02-21 Thread Peter Maydell
From: Patrick Venture This is the BMC attached to the OpenBMC Mori board. Signed-off-by: Patrick Venture Reviewed-by: Chris Rauer Reviewed-by: Ilkyun Choi Message-id: 20220208233104.284425-1-vent...@google.com Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- docs/system/arm/nuvo

[RFC 1/2] sem-posix: remove the posix semaphore support

2022-02-21 Thread Longpeng(Mike)
POSIX specifies an absolute time for sem_timedwait(), it would be affected if the system time is changing, but there is not a relative time or monotonic clock version of sem_timedwait, so we cannot gain from POSIX semaphore anymore. An alternative way is to use sem_trywait + usleep, maybe we can r

[RFC 2/2] sem-posix: use monotonic clock instead

2022-02-21 Thread Longpeng(Mike)
Use CLOCK_MONOTONIC, so the timeout isn't affected by changes to the system time. It depends on the pthread_condattr_setclock(), while some systems(e.g. mac os) do not support it, the behavior won't change in these systems. Signed-off-by: Longpeng(Mike) --- include/qemu/thread-posix.h | 1 + m

[RFC 0/2] qemu-sem-posix: use monotonic clock instead

2022-02-21 Thread Longpeng(Mike)
The qemu_sem_timedwait() uses system time as default, it would be affected by changes to the system time. In the real scenario, the time that goes faster or slower is a common case and the NTP service could help us to sync time periodically. This patchset uses monotonic clock instead of the realti

Re: [PATCH] configure: Disable capstone and slirp in the --without-default-features mode

2022-02-21 Thread Samuel Thibault
Thomas Huth, le lun. 21 févr. 2022 10:06:47 +0100, a ecrit: > For the users, it looks a little bit weird that capstone and slirp are > not disabled automatically if they run the configure script with the > "--without-default-features" option, so let's do that now. > Note: fdt is *not* changed accor

[PATCH] tests/avocado/machine_s390_ccw_virtio: Adapt test to new default resolution

2022-02-21 Thread Thomas Huth
QEMU's default screen resolution recently changed to 1280x800, so the resolution in the screen shot header changed of course, too. Reported-by: Peter Maydell Fixes: de72c4b7cd ("edid: set default resolution to 1280x800 (WXGA)") Signed-off-by: Thomas Huth --- tests/avocado/machine_s390_ccw_virti

Re: qemu iotest 161 and make check

2022-02-21 Thread Christian Borntraeger
Am 10.02.22 um 18:44 schrieb Vladimir Sementsov-Ogievskiy: 10.02.2022 20:13, Thomas Huth wrote: On 10/02/2022 15.51, Christian Borntraeger wrote: Am 10.02.22 um 15:47 schrieb Vladimir Sementsov-Ogievskiy: 10.02.2022 10:57, Christian Borntraeger wrote: Hello, I do see spurious failures of

Re: [PATCH 1/5] hw/riscv/riscv_hart: free the harts array when the object is finalized

2022-02-21 Thread Damien Hedde
On 2/18/22 18:46, Peter Maydell wrote: On Fri, 18 Feb 2022 at 17:39, Damien Hedde wrote: You're right. I was confused when re-writing the message. This leaks happen on init -> realize-failure -> finalize Because the array is allocated, then every cpu is initialized (and an error failure may h

[PULL 08/29] configure, meson: move AF_ALG test to meson

2022-02-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure | 36 --- crypto/meson.build| 4 +++- meson.build | 16 +++- meson_options.txt | 2 ++ scripts/meson-buildoptions.sh | 3 +++ 5 files changed, 23

[PULL v3 00/29] Misc mostly build system patches for 2022-02-15

2022-02-21 Thread Paolo Bonzini
The following changes since commit ad38520bdeb2b1e0b487db317f29119e94c1c88d: Merge remote-tracking branch 'remotes/stefanha-gitlab/tags/block-pull-request' into staging (2022-02-15 19:30:33 +) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream

Re: [PATCH] tests/avocado/machine_s390_ccw_virtio: Adapt test to new default resolution

2022-02-21 Thread Daniel P . Berrangé
On Mon, Feb 21, 2022 at 11:19:33AM +0100, Thomas Huth wrote: > QEMU's default screen resolution recently changed to 1280x800, so the > resolution in the screen shot header changed of course, too. > > Reported-by: Peter Maydell > Fixes: de72c4b7cd ("edid: set default resolution to 1280x800 (WXGA)"

Re: [RFC 1/2] sem-posix: remove the posix semaphore support

2022-02-21 Thread Daniel P . Berrangé
On Mon, Feb 21, 2022 at 05:56:16PM +0800, Longpeng(Mike) via wrote: > POSIX specifies an absolute time for sem_timedwait(), it would be > affected if the system time is changing, but there is not a relative > time or monotonic clock version of sem_timedwait, so we cannot gain > from POSIX semaphore

Re: [PATCH 1/2] hw/isa: add function to check for existence of device by its type

2022-02-21 Thread Ani Sinha
On Mon, Feb 21, 2022 at 12:57 AM Liav Albani wrote: This patch has no description. Please provide a description. > > Signed-off-by: Liav Albani > --- > hw/isa/isa-bus.c | 17 + > include/hw/isa/isa.h | 1 + > 2 files changed, 18 insertions(+) > > diff --git a/hw/isa/isa-bu

Re: Call for GSoC and Outreachy project ideas for summer 2022

2022-02-21 Thread Paolo Bonzini
On 2/21/22 10:36, Michal Prívozník wrote: Indeed. Libvirt's participating on its own since 2016, IIRC. Since we're still in org acceptance phase we have some time to decide this, actually. We can do the final decision after participating orgs are announced. My gut feeling says that it's going to

Re: [RFC 0/2] qemu-sem-posix: use monotonic clock instead

2022-02-21 Thread Paolo Bonzini
On 2/21/22 10:56, Longpeng(Mike) via wrote: The qemu_sem_timedwait() uses system time as default, it would be affected by changes to the system time. In the real scenario, the time that goes faster or slower is a common case and the NTP service could help us to sync time periodically. This patch

Re: [PATCH] configure: Disable capstone and slirp in the --without-default-features mode

2022-02-21 Thread Paolo Bonzini
On 2/21/22 10:06, Thomas Huth wrote: For the users, it looks a little bit weird that capstone and slirp are not disabled automatically if they run the configure script with the "--without-default-features" option, so let's do that now. Note: fdt is*not* changed accordingly since this affects the

Re: [PATCH v2 2/2] hw/ide: add ich6 ide controller device emulation

2022-02-21 Thread Gerd Hoffmann
Hi, > > ICH6 and ICH7 IDE controllers are quite the same as far as I know. I > > could change it, but then one could argue that the name ich6-ide seems > > like "ich9-ide", so not sure if we can really go on this path. > > I think we don't actually have ich9-ide, we only have piix3, piix4 and a

Re: initiating reboot/shutdown for a microvm machine?

2022-02-21 Thread Gerd Hoffmann
On Sat, Feb 19, 2022 at 02:50:34PM +0300, Michael Tokarev wrote: > Hi! > > In the ol'good days, I used Ctrl-Alt-Delete sequence to initiate a guest > shutdown. But with microvm, guest does not see this event anymore. > What is the good way to tell a guest vm to shut down from the outside, > beside

Re: [RFC 2/2] sem-posix: use monotonic clock instead

2022-02-21 Thread Paolo Bonzini
On 2/21/22 10:56, Longpeng(Mike) via wrote: +long now_nsec; +#ifdef CONFIG_PTHREAD_CONDATTR_SETCLOCK +struct timespec now; +clock_gettime(CLOCK_MONOTONIC, &now); +now_sec = now.tv_sec; +now_nsec = now.tv_nsec; +#else struct timeval tv; gettimeofday(&tv, NULL); -

[PULL 00/25] qtest patches and misc header clean-ups

2022-02-21 Thread Thomas Huth
Hi! The following changes since commit e670f6d825d4dee248b311197fd4048469d6772b: Merge remote-tracking branch 'remotes/legoater/tags/pull-ppc-20220218' into staging (2022-02-20 15:05:41 +) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull-request-2022

[PULL 03/25] erst: drop cast to long long

2022-02-21 Thread Thomas Huth
From: "Michael S. Tsirkin" The way to print uint64_t is with PRIx64, not with a cast to long long. Message-Id: <20220206093547.1282513-1-...@redhat.com> Signed-off-by: Michael S. Tsirkin Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- tests/qtest/

[PULL 01/25] tests/x86: Use 'pc' machine type for old hardware tests

2022-02-21 Thread Thomas Huth
From: "Dr. David Alan Gilbert" For tests that rely on old hardware, e.g. floppies or IDE drives, explicitly select the 'pc' machine type. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Thomas Huth Acked-by: Michael S. Tsirkin Message-Id: <20220215162537.605030-2-dgilb...@redhat.com> Signe

[PULL 10/25] tests/qtest: failover: check migration with failover off

2022-02-21 Thread Thomas Huth
From: Laurent Vivier If failover is off, the primary device is not plugged and the migration is done only with the standby device. On destination, the primary device must not be plugged. Signed-off-by: Laurent Vivier Message-Id: <20220203141537.972317-6-lviv...@redhat.com> Signed-off-by: Thoma

Re: Call for GSoC and Outreachy project ideas for summer 2022

2022-02-21 Thread Klaus Jensen
On Feb 21 09:51, Stefan Hajnoczi wrote: > On Mon, 21 Feb 2022 at 06:14, Klaus Jensen wrote: > > > > On Jan 28 15:47, Stefan Hajnoczi wrote: > > > Dear QEMU, KVM, and rust-vmm communities, > > > QEMU will apply for Google Summer of Code 2022 > > > (https://summerofcode.withgoogle.com/) and has been

[PULL 05/25] tests/qtest/ide-test: Remove bad retry_isa test

2022-02-21 Thread Thomas Huth
The retry_isa test is not doing what it was intended for: The test_retry_flush() function ignores the machine parameter completely and thus this test does not get run with the "isapc" machine. Moreover, in the course of time, the test_retry_flush() has been changed to depend on PCI-related function

[PULL 02/25] tests/x86: Use 'pc' machine type for hotplug tests

2022-02-21 Thread Thomas Huth
From: "Dr. David Alan Gilbert" Hotplug tests need a bridge setting up on q35, for now keep them on 'pc'. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Thomas Huth Message-Id: <20220215162537.605030-3-dgilb...@redhat.com> Signed-off-by: Thomas Huth --- tests/qtest/device-plug-test.c | 20

[PULL 04/25] tests/qtest/vhost-user-test.c: Use vhostforce=on

2022-02-21 Thread Thomas Huth
From: Eric Auger -netdev vhost-user,vhostforce is deprecated and vhostforce=on should be used instead. Signed-off-by: Eric Auger Reviewed-by: Thomas Huth Message-Id: <20220210145254.157790-2-eric.au...@redhat.com> Signed-off-by: Thomas Huth --- tests/qtest/vhost-user-test.c | 2 +- 1 file ch

[PULL 06/25] tests/qtest: failover: clean up pathname of tests

2022-02-21 Thread Thomas Huth
From: Laurent Vivier clearly indentify parameters, hotplug and migration tests Signed-off-by: Laurent Vivier Message-Id: <20220203141537.972317-2-lviv...@redhat.com> Signed-off-by: Thomas Huth --- tests/qtest/virtio-net-failover.c | 21 + 1 file changed, 13 insertions(+),

[PULL 12/25] tests/qtest: failover: migration abort test with failover off

2022-02-21 Thread Thomas Huth
From: Laurent Vivier Test abort during active migration when failover is disabled from QEMU or from guest side. Signed-off-by: Laurent Vivier Message-Id: <20220203141537.972317-8-lviv...@redhat.com> Signed-off-by: Thomas Huth --- tests/qtest/virtio-net-failover.c | 180 +++

[PULL 15/25] hw/remote: Add missing include

2022-02-21 Thread Thomas Huth
From: Philippe Mathieu-Daudé Currently "qemu/error-report.h" is implicitly included, however if headers in include/ get refactored, we get: hw/remote/proxy-memory-listener.c: In function ‘proxy_memory_listener_commit’: hw/remote/proxy-memory-listener.c:183:9: error: implicit declaration of

[PULL 07/25] tests/qtest: failover: use a macro for check_one_card()

2022-02-21 Thread Thomas Huth
From: Laurent Vivier This allows g_assert() to correctly report the line number of the error in the test case. Signed-off-by: Laurent Vivier Message-Id: <20220203141537.972317-3-lviv...@redhat.com> Signed-off-by: Thomas Huth --- tests/qtest/virtio-net-failover.c | 47 ++---

[PULL 16/25] hw/acpi/memory_hotplug: Remove unused 'hw/acpi/pc-hotplug.h' header

2022-02-21 Thread Thomas Huth
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Igor Mammedov Message-Id: <20220207082756.82600-4-f4...@amsat.org> Signed-off-by: Thomas Huth --- hw/acpi/memory_hotplug.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/acpi

[PULL 20/25] target: Add missing "qemu/timer.h" include

2022-02-21 Thread Thomas Huth
From: Philippe Mathieu-Daudé timer_new_ns(), cpu_get_host_ticks() and NANOSECONDS_PER_SECOND are declared in "qemu/timer.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Message-Id: <20220207082756.82600-8-f4...@a

[PULL 08/25] tests/qtest: failover: check the feature is correctly provided

2022-02-21 Thread Thomas Huth
From: Laurent Vivier Check QEMU provides the VIRTIO_NET_F_STANDBY if failover is on, and doesn't if failover is off Signed-off-by: Laurent Vivier Message-Id: <20220203141537.972317-4-lviv...@redhat.com> Signed-off-by: Thomas Huth --- tests/qtest/virtio-net-failover.c | 139 ++-

[PULL 21/25] linux-user: Add missing "qemu/timer.h" include

2022-02-21 Thread Thomas Huth
From: Philippe Mathieu-Daudé "qemu/timer.h" declares cpu_get_host_ticks(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Message-Id: <20220207082756.82600-9-f4...@amsat.org> Signed-off-by: Thomas Huth --- linux-user/i386/cpu_loop.c | 1 + linu

[PULL 11/25] tests/qtest: failover: test migration if the guest doesn't support failover

2022-02-21 Thread Thomas Huth
From: Laurent Vivier The primary device is not plugged and the migration is done only with the standby device Signed-off-by: Laurent Vivier Message-Id: <20220203141537.972317-7-lviv...@redhat.com> Signed-off-by: Thomas Huth --- tests/qtest/virtio-net-failover.c | 142 +

[PULL 22/25] softmmu/runstate: Clean headers

2022-02-21 Thread Thomas Huth
From: Philippe Mathieu-Daudé Add the missing 'qemu/log.h' header and remove the unused 'exec/exec-all.h' one. Reviewed-by: Richard Henderson Reviewed-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20220207075426.81934-14-f4...@amsat.org> Signed-off-by: Thomas Huth ---

[PULL 09/25] tests/qtest: failover: check missing guest feature

2022-02-21 Thread Thomas Huth
From: Laurent Vivier If QEMU provides the VIRTIO_NET_F_STANDBY feature but the guest doesn't the primary device must be kept hidden Signed-off-by: Laurent Vivier Message-Id: <20220203141537.972317-5-lviv...@redhat.com> Signed-off-by: Thomas Huth --- tests/qtest/virtio-net-failover.c | 33

[PULL 14/25] hw/tpm: Clean includes

2022-02-21 Thread Thomas Huth
From: Philippe Mathieu-Daudé "tpm_ppi.h" only requires to include "exec/memory.h" to get the MemoryRegion declaration. tpm_ppi.c requires "hw/qdev-core.h" to use the DEVICE() macro, tpm_crb.c is the only source file requiring "exec/address-spaces.h". Signed-off-by: Philippe Mathieu-Daudé Revie

Re: [PATCH 08/11] mos6522: add "info via" HMP command for debugging

2022-02-21 Thread Philippe Mathieu-Daudé
+Thomas On 20/2/22 18:18, Mark Cave-Ayland wrote: On 08/02/2022 13:10, Daniel P. Berrangé wrote: On Tue, Feb 08, 2022 at 01:06:59PM +, Mark Cave-Ayland wrote: On 08/02/2022 12:49, Daniel P. Berrangé wrote: I was under the impression that monitor_register_hmp_info_hrt() does all the magi

[PULL 23/25] exec/exec-all: Move 'qemu/log.h' include in units requiring it

2022-02-21 Thread Thomas Huth
From: Philippe Mathieu-Daudé Many files use "qemu/log.h" declarations but neglect to include it (they inherit it via "exec/exec-all.h"). "exec/exec-all.h" is a core component and shouldn't be used that way. Move the "qemu/log.h" inclusion locally to each unit requiring it. Signed-off-by: Philipp

[PULL 24/25] hw/m68k/mcf: Add missing 'exec/hwaddr.h' header

2022-02-21 Thread Thomas Huth
From: Philippe Mathieu-Daudé hwaddr type is defined in "exec/hwaddr.h". Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20220209215446.58402-3-f4...@amsat.org> Reviewed-by: Richard Henderson Signed-off-by: Thomas Huth --- include/hw/m68k/mcf.h | 1 + 1 file changed, 1 insertion(+) diff -

[PULL 13/25] scripts: Remove the old switch-timer-api script

2022-02-21 Thread Thomas Huth
This script has been useful for the timer API rewrite in 2013, but it is of no use anymore today. Let's remove it now. Message-Id: <20220124102001.35930-1-th...@redhat.com> Signed-off-by: Thomas Huth --- scripts/switch-timer-api | 178 --- 1 file changed, 178

[PULL 25/25] hw/tricore: Remove unused and incorrect header

2022-02-21 Thread Thomas Huth
From: Philippe Mathieu-Daudé TriCore boards certainly don't need the ARM loader API :) Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20220214183144.27402-4-f4...@amsat.org> Signed-off-by: Thomas Huth --- include/hw/tricore/triboar

Re: [PATCH v2 0/9] exec: Remove 'qemu/log.h' from 'exec-all.h'

2022-02-21 Thread Thomas Huth
On 07/02/2022 09.27, Philippe Mathieu-Daudé via wrote: Yet another noisy/boring refactor, but it will allow us to better split exec/ includes as being target-agnostic/specific (the next series). Since v1: - Remove unrelated "hw/s390x/virtio: missing 'cpu.h'" (thuth) - Reword some commit descript

Re: [PULL 00/25] qtest patches and misc header clean-ups

2022-02-21 Thread Philippe Mathieu-Daudé
On 21/2/22 12:59, Thomas Huth wrote: * Improve virtio-net failover test * Some small fixes for the qtests * Misc header cleanups by Philippe Philippe Mathieu-Daud

[PULL 17/25] qtest: Add missing 'hw/qdev-core.h' include

2022-02-21 Thread Thomas Huth
From: Philippe Mathieu-Daudé Add "hw/qdev-core.h" to avoid when refactoring include/: softmmu/qtest.c:404:9: error: use of undeclared identifier 'NamedGPIOList' NamedGPIOList *ngl; ^ Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Richard Henderso

Re: [PATCH] tests/avocado/machine_s390_ccw_virtio: Adapt test to new default resolution

2022-02-21 Thread Philippe Mathieu-Daudé
On 21/2/22 11:19, Thomas Huth wrote: QEMU's default screen resolution recently changed to 1280x800, so the resolution in the screen shot header changed of course, too. Reported-by: Peter Maydell Fixes: de72c4b7cd ("edid: set default resolution to 1280x800 (WXGA)") Signed-off-by: Thomas Huth --

Re: [PATCH] tests/avocado/machine_s390_ccw_virtio: Adapt test to new default resolution

2022-02-21 Thread Halil Pasic
On Mon, 21 Feb 2022 11:19:33 +0100 Thomas Huth wrote: > QEMU's default screen resolution recently changed to 1280x800, so the > resolution in the screen shot header changed of course, too. > > Reported-by: Peter Maydell > Fixes: de72c4b7cd ("edid: set default resolution to 1280x800 (WXGA)") > S

[PULL 19/25] core/ptimers: Remove unnecessary 'sysemu/cpus.h' include

2022-02-21 Thread Thomas Huth
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Message-Id: <20220207082756.82600-7-f4...@amsat.org> Signed-off-by: Thomas Huth --- hw/core/ptimer.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/core/ptimer.c

[PATCH 2/2] hw/misc/pvpanic: Use standard headers instead

2022-02-21 Thread zhenwei pi
QEMU side has already imported pvpanic.h from linux, remove bit definitions from include/hw/misc/pvpanic.h, and use include/standard-headers/linux/pvpanic.h instead. Also minor changes for PVPANIC_CRASHLOADED -> PVPANIC_CRASH_LOADED. Signed-off-by: zhenwei pi --- hw/misc/pvpanic-isa.c | 4 ++

[PULL 18/25] exec/ramblock: Add missing includes

2022-02-21 Thread Thomas Huth
From: Philippe Mathieu-Daudé "exec/ramblock.h" requires "qemu/rcu.h" for the definition of rcu_head, and "exec/ramlist.h" for the definition of RAMBlockNotifier. Add them to avoid when when refactoring include/: include/exec/ramblock.h:26:21: error: field has incomplete type 'struct rcu_head'

Re: [PATCH v2 2/8] x86: Add AMX XTILECFG and XTILEDATA components

2022-02-21 Thread David Edmondson
On Wednesday, 2022-02-16 at 22:04:28 -08, Yang Zhong wrote: > From: Jing Liu > > The AMX TILECFG register and the TMMx tile data registers are > saved/restored via XSAVE, respectively in state component 17 > (64 bytes) and state component 18 (8192 bytes). > > Add AMX feature bits to x86_ext_save_

Re: [PATCH] hw/arm/mps2-tz.c: Update AN547 documentation URL

2022-02-21 Thread Philippe Mathieu-Daudé
On 21/2/22 10:41, Peter Maydell wrote: The AN547 application note URL has changed: update our comment accordingly. (Rev B is still downloadable from the old URL, but there is a new Rev C of the document now.) Signed-off-by: Peter Maydell --- hw/arm/mps2-tz.c | 2 +- 1 file changed, 1 inserti

Re: [PATCH v2 1/8] x86: Fix the 64-byte boundary enumeration for extended state

2022-02-21 Thread David Edmondson
On Wednesday, 2022-02-16 at 22:04:27 -08, Yang Zhong wrote: > From: Jing Liu > > The extended state subleaves (EAX=0Dh, ECX=n, n>1).ECX[1] > indicate whether the extended state component locates > on the next 64-byte boundary following the preceding state > component when the compacted format of

[PATCH 1/2] headers: Add pvpanic.h

2022-02-21 Thread zhenwei pi
Since 2020, linux kernel started to export pvpanic.h. Import the latest version from linux into QEMU. Signed-off-by: zhenwei pi --- include/standard-headers/linux/pvpanic.h | 9 + scripts/update-linux-headers.sh | 3 ++- 2 files changed, 11 insertions(+), 1 deletion(-) create m

Re: [PATCH v3] tests/qtest: add qtests for npcm7xx sdhci

2022-02-21 Thread Peter Maydell
On Wed, 16 Feb 2022 at 17:30, Peter Maydell wrote: > > On Tue, 8 Feb 2022 at 18:18, Patrick Venture wrote: > > > > From: Shengtan Mao > > > > Reviewed-by: Hao Wu > > Reviewed-by: Chris Rauer > > Signed-off-by: Shengtan Mao > > Signed-off-by: Patrick Venture > > --- > > > > Applied to target-

Re: [PATCH v2 4/8] x86: Add XFD faulting bit for state components

2022-02-21 Thread David Edmondson
On Wednesday, 2022-02-16 at 22:04:30 -08, Yang Zhong wrote: > From: Jing Liu > > Intel introduces XFD faulting mechanism for extended > XSAVE features to dynamically enable the features in > runtime. If CPUID (EAX=0Dh, ECX=n, n>1).ECX[2] is set > as 1, it indicates support for XFD faulting of thi

Re: [PATCH RFCv2 2/4] i386/pc: relocate 4g start to 1T where applicable

2022-02-21 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Tue, Feb 15, 2022 at 10:53:58AM +0100, Gerd Hoffmann wrote: > > Hi, > > > > > I don't know what behavior should be if firmware tries to program > > > PCI64 hole beyond supported phys-bits. > > > > Well, you are basically f*cked. > > > > Un

Re: [PATCH v2 6/8] x86: add support for KVM_CAP_XSAVE2 and AMX state migration

2022-02-21 Thread David Edmondson
On Wednesday, 2022-02-16 at 22:04:32 -08, Yang Zhong wrote: > From: Jing Liu > > When dynamic xfeatures (e.g. AMX) are used by the guest, the xsave > area would be larger than 4KB. KVM_GET_XSAVE2 and KVM_SET_XSAVE > under KVM_CAP_XSAVE2 works with a xsave buffer larger than 4KB. > Always use the

Re: [PATCH 2/2] hw/misc/pvpanic: Use standard headers instead

2022-02-21 Thread Philippe Mathieu-Daudé
On 21/2/22 13:27, zhenwei pi wrote: QEMU side has already imported pvpanic.h from linux, remove bit definitions from include/hw/misc/pvpanic.h, and use include/standard-headers/linux/pvpanic.h instead. Also minor changes for PVPANIC_CRASHLOADED -> PVPANIC_CRASH_LOADED. It seems to fail to build

[PATCH] iotests: Write test output to TEST_DIR

2022-02-21 Thread Hanna Reitz
Drop the use of OUTPUT_DIR (test/qemu-iotests under the build directory), and instead write test output files (.out.bad, .notrun, and .casenotrun) to TEST_DIR. With this, the same test can be run concurrently without the separate instances interfering, because they will need separate TEST_DIRs any

  1   2   3   >