[RFC PATCH 3/4] audio: Rename coreaudio extension to use Objective-C compiler

The coreaudio library includes Objective-C declarations (using the caret '^' symbol to declare block references [*]). When building with a C compiler we get: [175/839] Compiling C object libcommon.fa.p/audio_coreaudio.c.o In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX

Re: [PATCH 2/2] target/ppc/kvm: Use KVM_CAP_PPC_AIL_MODE_3 to determine cap-ail-mode-3 support

Nicholas Piggin writes: > Excerpts from Fabiano Rosas's message of February 14, 2022 11:13 pm: >> Nicholas Piggin writes: >> >>> Use KVM_CAP_PPC_AIL_MODE_3 to determine cap-ail-mode-3 support for KVM >>> guests. Keep the fallback heuristic for KVM hosts that pre-date this >>> CAP. >>> >>> This

Re: [RFC PATCH 4/4] ui/cocoa: Ignore 'initializer overrides' warnings

On Tue, 15 Feb 2022 at 12:13, Philippe Mathieu-Daudé via wrote: > > We globally ignore the 'initializer overrides' warnings in C code > since commit c1556a812a ("configure: Disable (clang) > initializer-overrides warnings"). Unfortunately the ${gcc_flags} > variable is not propagated to Objective-

[PATCH] block: fix preallocate filter: don't do unaligned preallocate requests

There is a bug in handling BDRV_REQ_NO_WAIT flag: we still may wait in wait_serialising_requests() if request is unaligned. And this is possible for the only user of this flag (preallocate filter) if underlying file is unaligned to its request_alignment on start. So, we have to fix preallocate fil

Re: [RFC PATCH 0/4] buildsys: More fixes to use GCC on macOS

On Tue, Feb 15, 2022 at 9:06 PM Philippe Mathieu-Daudé wrote: > > Few fixes to be able to use GCC extensions which are not > available on Clang. > > Philippe Mathieu-Daudé (4): > osdep: Avoid using Clang-specific __builtin_available() > osdep: Un-inline qemu_thread_jit_execute/write > audio:

Re: [PATCH 2/4] osdep: Un-inline qemu_thread_jit_execute/write

On Tue, Feb 15, 2022 at 9:06 PM Philippe Mathieu-Daudé wrote: > > qemu_thread_jit_execute() and qemu_thread_jit_write() call > pthread_jit_write_protect_np() which is declared in "pthread.h". > Since we don't want all C files to preprocess unused headers, > avoid adding yet another header here and

Re: [RFC PATCH 4/4] ui/cocoa: Ignore 'initializer overrides' warnings

On Dienstag, 15. Februar 2022 13:06:25 CET Philippe Mathieu-Daudé via wrote: > We globally ignore the 'initializer overrides' warnings in C code > since commit c1556a812a ("configure: Disable (clang) > initializer-overrides warnings"). Unfortunately the ${gcc_flags} > variable is not propagated to

Re: [RFC PATCH 4/4] ui/cocoa: Ignore 'initializer overrides' warnings

On 15/2/22 14:19, Akihiko Odaki wrote: On Tue, Feb 15, 2022 at 9:35 PM Peter Maydell wrote: On Tue, 15 Feb 2022 at 12:13, Philippe Mathieu-Daudé via wrote: We globally ignore the 'initializer overrides' warnings in C code since commit c1556a812a ("configure: Disable (clang) initializer-over

Re: qdev instance_init vs realize split

On 2/15/22 12:32, Peter Maydell wrote: On Tue, 15 Feb 2022 at 10:32, Damien Hedde wrote: I'm wondering if there are rules or convention about what we put in the instance_init() vs realize() for simple devices ? (For complex ones we generally have no choice to put everything in realize()) For

Re: [RFC PATCH 0/4] buildsys: More fixes to use GCC on macOS

On 15/2/22 14:06, Akihiko Odaki wrote: On Tue, Feb 15, 2022 at 9:06 PM Philippe Mathieu-Daudé wrote: Few fixes to be able to use GCC extensions which are not available on Clang. Philippe Mathieu-Daudé (4): osdep: Avoid using Clang-specific __builtin_available() osdep: Un-inline qemu_thr

Re: [RFC PATCH 4/4] ui/cocoa: Ignore 'initializer overrides' warnings

On Tue, Feb 15, 2022 at 9:35 PM Peter Maydell wrote: > > On Tue, 15 Feb 2022 at 12:13, Philippe Mathieu-Daudé via > wrote: > > > > We globally ignore the 'initializer overrides' warnings in C code > > since commit c1556a812a ("configure: Disable (clang) > > initializer-overrides warnings"). Unfor

Re: [PATCH 1/6] tests/qemu-iotests: Improve the check for GNU sed

On 11/02/2022 17.48, Thomas Huth wrote: On 11/02/2022 17.14, Eric Blake wrote: On Tue, Feb 08, 2022 at 03:52:19PM +0100, Thomas Huth wrote: The current code with $SED has been introduced almost three years ago already...    Can’t we just do `alias sed=gsed`? Maybe ... but let's ask Philippe

[PATCH] tests/qemu-iotests: Rework the checks and spots using GNU sed

Instead of failing the iotests if GNU sed is not available (or skipping them completely in the check-block.sh script), it would be better to simply skip the bash-based tests that rely on GNU sed, so that the other tests could still be run. Thus we now explicitely use "gsed" (either as direct progra

Re: [PATCH 2/4] osdep: Un-inline qemu_thread_jit_execute/write

On 15/2/22 14:09, Akihiko Odaki wrote: On Tue, Feb 15, 2022 at 9:06 PM Philippe Mathieu-Daudé wrote: qemu_thread_jit_execute() and qemu_thread_jit_write() call pthread_jit_write_protect_np() which is declared in "pthread.h". Since we don't want all C files to preprocess unused headers, avoid a

Re: [RFC PATCH 3/4] audio: Rename coreaudio extension to use Objective-C compiler

On Dienstag, 15. Februar 2022 13:06:24 CET Philippe Mathieu-Daudé via wrote: > The coreaudio library includes Objective-C declarations (using the > caret '^' symbol to declare block references [*]). When building > with a C compiler we get: > > [175/839] Compiling C object libcommon.fa.p/audio_c

Re: qdev instance_init vs realize split

On Tue, 15 Feb 2022 at 13:21, Damien Hedde wrote: > Are you saying that: if an operation like a mmio/irq definition is done > in realize(), in theory, we should have the unrealize() counterpart ? I'm saying that at the moment we have two categories of device: * ones which are intended to be plug

Re: [RFC PATCH 4/4] ui/cocoa: Ignore 'initializer overrides' warnings

On Tue, 15 Feb 2022 at 13:18, Christian Schoenebeck wrote: > > On Dienstag, 15. Februar 2022 13:06:25 CET Philippe Mathieu-Daudé via wrote: > > We globally ignore the 'initializer overrides' warnings in C code > > since commit c1556a812a ("configure: Disable (clang) > > initializer-overrides warni

RE: [RFC v4 08/21] vfio-user: define socket receive functions

> -Original Message- > From: Qemu-devel bounces+thanos.makatos=nutanix@nongnu.org> On Behalf Of John > Johnson > Sent: 12 January 2022 00:44 > To: qemu-devel@nongnu.org > Subject: [RFC v4 08/21] vfio-user: define socket receive functions > > Add infrastructure needed to receive incomi

[qemu-web PATCH] Announce Outreachy 2022 May-August

Add a blog post inviting Outreachy applicants. QEMU has funding to participate in the Outreachy internship program (https://www.outreachy.org/) again this summer. We need to let people know about this so we get applicants! Signed-off-by: Stefan Hajnoczi --- _posts/2022-02-16-outreach-2022.md | 3

Re: [PATCH 0/6] ui/dbus: Share one listener for a console

Hi On Tue, Feb 15, 2022 at 7:09 AM Akihiko Odaki wrote: > > > On 2022/02/15 4:49, Marc-André Lureau wrote: > > Hi > > > > On Mon, Feb 14, 2022 at 5:15 PM Akihiko Odaki > > wrote: > > > > On Mon, Feb 14, 2022 at 9:07 PM Marc-André Lureau > > mailto:marcand

Re: [PULL 0/8] Net patches

On Mon, 14 Feb 2022 at 04:00, Jason Wang wrote: > > The following changes since commit 48033ad678ae2def43bf0d543a2c4c3d2a93feaf: > > Merge remote-tracking branch > 'remotes/vsementsov/tags/pull-nbd-2022-02-09-v2' into staging (2022-02-12 > 22:04:07 +) > > are available in the git repositor

Re: [PATCH 1/6] tests/qemu-iotests: Improve the check for GNU sed

On Tue, Feb 15, 2022 at 02:28:24PM +0100, Thomas Huth wrote: > On 11/02/2022 17.48, Thomas Huth wrote: > > On 11/02/2022 17.14, Eric Blake wrote: > > > On Tue, Feb 08, 2022 at 03:52:19PM +0100, Thomas Huth wrote: > > > > > > The current code with $SED has been introduced almost three years > > > >

[PATCH 2/3] iotests: Allow using QMP with the QSD

Add a parameter to optionally open a QMP connection when creating a QemuStorageDaemon instance. Signed-off-by: Hanna Reitz --- tests/qemu-iotests/iotests.py | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qem

[PATCH 0/3] block: Make bdrv_refresh_limits() non-recursive

Hi, Most bdrv_refresh_limits() callers do not drain the subtree of the node whose limits are refreshed, so concurrent I/O requests to child nodes can occur (if the node is in an I/O thread). bdrv_refresh_limits() is recursive, so such requests can happen to a node whose limits are being refreshed

Re: [RFC PATCH 4/4] ui/cocoa: Ignore 'initializer overrides' warnings

On 15/2/22 14:45, Peter Maydell wrote: On Tue, 15 Feb 2022 at 13:18, Christian Schoenebeck wrote: On Dienstag, 15. Februar 2022 13:06:25 CET Philippe Mathieu-Daudé via wrote: We globally ignore the 'initializer overrides' warnings in C code since commit c1556a812a ("configure: Disable (clang)

[PATCH 1/3] block: Make bdrv_refresh_limits() non-recursive

bdrv_refresh_limits() recurses down to the node's children. That does not seem necessary: When we refresh limits on some node, and then recurse down and were to change one of its children's BlockLimits, then that would mean we noticed the changed limits by pure chance. The fact that we refresh th

[PATCH 3/3] iotests/graph-changes-while-io: New test

Test the following scenario: 1. Some block node (null-co) attached to a user (here: NBD server) that performs I/O and keeps the node in an I/O thread 2. Repeatedly run blockdev-add/blockdev-del to add/remove an overlay to/from that node Each blockdev-add triggers bdrv_refresh_limits(), and b

Re: [RFC PATCH 4/4] ui/cocoa: Ignore 'initializer overrides' warnings

On Dienstag, 15. Februar 2022 14:45:00 CET Peter Maydell wrote: > On Tue, 15 Feb 2022 at 13:18, Christian Schoenebeck > > wrote: > > On Dienstag, 15. Februar 2022 13:06:25 CET Philippe Mathieu-Daudé via wrote: > > > We globally ignore the 'initializer overrides' warnings in C code > > > since co

Possible end of Ubuntu LTS 18.04 as a build target in 7.1 ?

Per our platform support policy https://www.qemu.org/docs/master/about/build-platforms.html "The project aims to support the most recent major version at all times. Support for the previous major version will be dropped 2 years after the new major version is released or when the vendor

Re: [RFC PATCH 4/4] ui/cocoa: Ignore 'initializer overrides' warnings

On Tue, 15 Feb 2022 at 14:11, Christian Schoenebeck wrote: > > On Dienstag, 15. Februar 2022 14:45:00 CET Peter Maydell wrote: > > I think this won't zero-initialize, because this is a function > > level variable, not a global or static, but maybe ObjectiveC > > rules differ from C here? (Besides,

Re: Holding RISCV CPUs in reset

Thanks for the info Peter. I will look into the ARM implementation. Cheers, Vy On Tue, 15 Feb 2022, 4:49 pm Peter Maydell, wrote: > On Tue, 15 Feb 2022 at 10:30, vysakh pillai > wrote: > > > > Hi, > > In an SMP system like the sifive_u machine which has a RISCV e_cpu as > hart0 and a set of

RE: [RFC v4 08/21] vfio-user: define socket receive functions

> > +/* > > + * Receive and process one incoming message. > > + * > > + * For replies, find matching outgoing request and wake any waiters. > > + * For requests, queue in incoming list and run request BH. > > + */ > > +static int vfio_user_recv_one(VFIOProxy *proxy) > > +{ > > +VFIOUserMsg *msg

RE: [RFC v4 20/21] vfio-user: migration support

> -Original Message- > From: John Johnson > Sent: 14 February 2022 18:50 > To: Thanos Makatos > Cc: qemu-devel@nongnu.org > Subject: Re: [RFC v4 20/21] vfio-user: migration support > > > > > On Feb 11, 2022, at 5:31 AM, Thanos Makatos > wrote: > > > > > >> -Original Message- >

[PATCH v4 3/3] kvm: Support for querying fd-based stats

Add support for querying fd-based KVM stats - as introduced by Linux kernel commit: cb082bfab59a ("KVM: stats: Add fd-based API to read binary stats data") Signed-off-by: Mark Kanda --- accel/kvm/kvm-all.c | 393 qapi/stats.json | 2 +- 2 files

[PATCH v4 2/3] hmp: Support for querying stats

Leverage the QMP support for querying stats. The interface supports similar arguments as the QMP interface. Wildcard char (*) is accepted for names and stats target. Examples (with fd-based KVM stats): - Display all stats (qemu) info stats vm provider: kvm max_mmu_page_hash_collisions (peak

[PATCH v4 1/3] qmp: Support for querying stats

Introduce QMP support for querying stats. Provide a framework for adding new stats and support for the following commands: - query-stats Returns a list of all stats per target type (only VM and vCPU to start), with additional options for specifying stat names, vCPU qom paths, and providers. - que

Re: [PATCH 2/2] Allow VIRTIO_F_IN_ORDER to be negotiated for vdpa devices

On Tue, Feb 15, 2022 at 8:23 AM Gautam Dawar wrote: > > This patch adds the ability to negotiate VIRTIO_F_IN_ORDER bit > for vhost-vdpa backend when the underlying device supports this > feature. > This would aid in reaping performance benefits with HW devices > that implement this feature. At the

[PATCH] docs/acpi/erst: add device id for ACPI ERST device in pci-ids.txt

Adding device ID for ERST device in pci-ids.txt. It was missed when ERST related patches were reviewed. CC: Eric DeVolder Signed-off-by: Ani Sinha --- docs/specs/pci-ids.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/specs/pci-ids.txt b/docs/specs/pci-ids.txt index 5e407a6f32..dd6

[PATCH] hw/acpi/erst: clean up unused IS_UEFI_CPER_RECORD macro

This change is cosmetic. IS_UEFI_CPER_RECORD macro definition that was added as a part of the ERST implementation seems to be unused. Remove it. CC: Eric DeVolder Signed-off-by: Ani Sinha --- hw/acpi/erst.c | 5 - 1 file changed, 5 deletions(-) diff --git a/hw/acpi/erst.c b/hw/acpi/erst.c

Re: [RFC PATCH 0/9] Net Control VQ support in vDPA SVQ

On Mon, Feb 14, 2022 at 8:38 PM Eugenio Pérez wrote: > > Control virtqueue is used by networking device for accepting various > commands from the driver. It's a must to support multiqueue and other > configurations. > > Shadow VirtQueue (SVQ) [1] already makes possible migration of virtqueue > sta

Re: [PATCH 8/9] target/ppc: Introduce a vhyp framework for nested HV support

Nicholas Piggin writes: > Introduce virtual hypervisor methods that can support a "Nested KVM HV" > implementation using the bare metal 2-level radix MMU, and using HV > exceptions to return from H_ENTER_NESTED (rather than cause interrupts). > > HV exceptions can now be raised in the TCG spapr m

Re: [PATCH 9/9] spapr: implement nested-hv capability for the virtual hypervisor

Nicholas Piggin writes: > This implements the Nested KVM HV hcall API for spapr under TCG. > > The L2 is switched in when the H_ENTER_NESTED hcall is made, and the > L1 is switched back in returned from the hcall when a HV exception > is sent to the vhyp. Register state is copied in and out accor

Re: [PATCH 1/6] tests/qemu-iotests: Improve the check for GNU sed

On 15/02/2022 14.51, Daniel P. Berrangé wrote: On Tue, Feb 15, 2022 at 02:28:24PM +0100, Thomas Huth wrote: On 11/02/2022 17.48, Thomas Huth wrote: On 11/02/2022 17.14, Eric Blake wrote: On Tue, Feb 08, 2022 at 03:52:19PM +0100, Thomas Huth wrote: The current code with $SED has been introduce

Re: [PATCH] target/riscv: Add isa extenstion strings to the device tree

Am Dienstag, 15. Februar 2022, 10:05:30 CET schrieb Atish Patra: > Append the available ISA extensions to the "riscv,isa" string if it > is enabled so that kernel can process it. > > Signed-off-by: Atish Patra > --- > target/riscv/cpu.c | 23 ++- > 1 file changed, 22 insertio

[PATCH 0/3] x86: Switch over to q35 as the default machine type

From: "Dr. David Alan Gilbert" We've been using q35 heavily for a while now and it generally works quite nicely; downstream in RH we prefer it as our default, and I wanted to see what people think of making it the default. The only pain really is that it requires some more setup for hotplug; so

[PATCH 1/3] tests/x86: Use 'pc' machine type for old hardware tests

From: "Dr. David Alan Gilbert" For tests that rely on old hardware, e.g. floppies or IDE drives, explicitly select the 'pc' machine type. Signed-off-by: Dr. David Alan Gilbert --- tests/qtest/fdc-test.c| 2 +- tests/qtest/hd-geo-test.c | 12 +--- tests/qtest/i440fx-test.c | 2 +-

[PATCH 3/3] x86: Switch to q35 as the default machine type

From: "Dr. David Alan Gilbert" The 'q35' machine type series has been around for a few years now, and is getting heavily used downstream without many problems; lets flip to using it as the default. While it is of course newer and shinier than it's old i440fx cousin, the main reasons are: * PC

[PATCH 2/3] tests/x86: Use 'pc' machine type for hotplug tests

From: "Dr. David Alan Gilbert" Hotplug tests need a bridge setting up on q35, for now keep them on 'pc'. Signed-off-by: Dr. David Alan Gilbert --- tests/qtest/device-plug-test.c | 20 +-- tests/qtest/drive_del-test.c | 35 +- tests/qtest/hd-geo

[PATCH 0/3] x86: Switch over to q35 as the default machine type

From: "Dr. David Alan Gilbert" We've been using q35 heavily for a while now and it generally works quite nicely; downstream in RH we prefer it as our default, and I wanted to see what people think of making it the default. The only pain really is that it requires some more setup for hotplug; so

[PATCH 1/3] tests/x86: Use 'pc' machine type for old hardware tests

From: "Dr. David Alan Gilbert" For tests that rely on old hardware, e.g. floppies or IDE drives, explicitly select the 'pc' machine type. Signed-off-by: Dr. David Alan Gilbert --- tests/qtest/fdc-test.c| 2 +- tests/qtest/hd-geo-test.c | 12 +--- tests/qtest/i440fx-test.c | 2 +-

[PATCH 2/3] tests/x86: Use 'pc' machine type for hotplug tests

From: "Dr. David Alan Gilbert" Hotplug tests need a bridge setting up on q35, for now keep them on 'pc'. Signed-off-by: Dr. David Alan Gilbert --- tests/qtest/device-plug-test.c | 20 +-- tests/qtest/drive_del-test.c | 35 +- tests/qtest/hd-geo

[PATCH 3/3] x86: Switch to q35 as the default machine type

From: "Dr. David Alan Gilbert" The 'q35' machine type series has been around for a few years now, and is getting heavily used downstream without many problems; lets flip to using it as the default. While it is of course newer and shinier than it's old i440fx cousin, the main reasons are: * PC

Re: [PATCH v6 11/15] ui/cocoa: Add Services menu

On Tue, Feb 15, 2022 at 3:04 AM Philippe Mathieu-Daudé wrote: > From: Akihiko Odaki > > Services menu functionality of Cocoa is described at: > > https://developer.apple.com/design/human-interface-guidelines/macos/extensions/services/ > > Signed-off-by: Akihiko Odaki > Reviewed-by: Philippe Mat

Re: [PATCH v11 4/4] target/ppc: trigger PERFM EBBs from power8-pmu.c

On 2/11/22 19:33, Daniel Henrique Barboza wrote: This patch adds the EBB exception support that are triggered by Performance Monitor alerts. This happens when a Performance Monitor alert occurs and MMCR0_EBE, BESCR_PME and BESCR_GE are set. fire_PMC_interrupt() will execute a new ebb_perfm_excp(

Re: qdev instance_init vs realize split

On 2/15/22 14:35, Peter Maydell wrote: On Tue, 15 Feb 2022 at 13:21, Damien Hedde wrote: Are you saying that: if an operation like a mmio/irq definition is done in realize(), in theory, we should have the unrealize() counterpart ? I'm saying that at the moment we have two categories of devi

Re: Possible end of Ubuntu LTS 18.04 as a build target in 7.1 ?

On 15/02/2022 15.08, Daniel P. Berrangé wrote: Per our platform support policy https://www.qemu.org/docs/master/about/build-platforms.html "The project aims to support the most recent major version at all times. Support for the previous major version will be dropped 2 years after

Re: [PATCH] hw/i386/pc_piix: Mark the machine types from version 1.4 to 1.7 as deprecated

On 17/01/2022 20.16, Thomas Huth wrote: The list of machine types grows larger and larger each release ... and it is unlikely that many people still use the very old ones for live migration. QEMU v1.7 has been released more than 8 years ago, so most people should have updated their machines to a

[PATCH v2 4/8] configure: Disable out-of-line atomic operations on Aarch64

GCC 10.1 introduced the -moutline-atomics option on Aarch64. This options is enabled by default, and triggers a link failure: Undefined symbols for architecture arm64: "___aarch64_cas1_acq_rel", referenced from: _qmp_migrate_recover in migration_migration.c.o _cpu_atomic_cmpx

[PATCH v2 3/8] meson: Resolve the entitlement.sh script once for good

Commit 235b523dba ("meson: Use find_program() to resolve the entitlement.sh script") didn't correctly fixed the issue, as the script is still resolved for each target. Move the check earlier, before processing each target. Signed-off-by: Philippe Mathieu-Daudé --- meson.build | 5 - 1 file c

[PATCH v2 1/8] osdep: Avoid using Clang-specific __builtin_available()

Remove the Clang specific __builtin_available() to allow building with GCC, otherwise we get: include/qemu/osdep.h: In function 'qemu_thread_jit_write': include/qemu/osdep.h:787:9: warning: implicit declaration of function '__builtin_available'; did you mean '__builtin_scalbl'? [-Wimplicit-f

[PATCH v2 8/8] ui/cocoa: Constify qkeycode translation arrays

Reported-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- ui/cocoa.m | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 30702d31a5..7a3a610212 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -651,7 +651,7 @@ QemuCocoaView *cocoaView;

[PATCH v2 0/8] buildsys: More fixes to use GCC on macOS

Few fixes to be able to use GCC extensions which are not available on Clang. Since RFC: - Split Clang __builtin_available() patch - Do not un-inline qemu_thread_jit_execute/write - Do not use #pragma diagnostic - Demote ui/cocoa key arrays to static const - Lookup scripts/entitlement.sh script onc

Re: [PULL 18/38] Remove unnecessary minimum_version_id_old fields

On Thu, 27 Jan 2022 at 15:14, Juan Quintela wrote: > > From: Peter Maydell > > The migration code will not look at a VMStateDescription's > minimum_version_id_old field unless that VMSD has set the > load_state_old field to something non-NULL. (The purpose of > minimum_version_id_old is to speci

Re: [PATCH v2] ide: Increment BB in-flight counter for TRIM BH

Ping (I can take it too, if you’d like, John, but you’re listed as the only maintainer for hw/ide, so...  Just say the word, though!) On 20.01.22 15:22, Hanna Reitz wrote: When we still have an AIOCB registered for DMA operations, we try to settle the respective operation by draining the Bloc

[PATCH v2 2/8] osdep: Ignore 'unguarded-availability-new' warnings on macOS Catalina

When building with GCC on macOS Catalina we get 2254 times: include/qemu/osdep.h:780:5: warning: 'pthread_jit_write_protect_np' is only available on macOS 11.0 or newer [-Wunguarded-availability-new] pthread_jit_write_protect_np(true); ^~~~ Fix by using a st

[PATCH v2 5/8] meson: Log QEMU_CXXFLAGS content in summary

Signed-off-by: Philippe Mathieu-Daudé --- meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/meson.build b/meson.build index 287be51ff2..215c253683 100644 --- a/meson.build +++ b/meson.build @@ -3305,6 +3305,7 @@ if link_args.length() > 0 summary_info += {'LDFLAGS': ' '.jo

[PATCH v2] nbd/server: Allow MULTI_CONN for shared writable exports

According to the NBD spec, a server advertising NBD_FLAG_CAN_MULTI_CONN promises that multiple client connections will not see any cache inconsistencies: when properly separated by a single flush, actions performed by one client will be visible to another client, regardless of which client did the

[PATCH v2 6/8] configure: Pass filtered QEMU_OBJCFLAGS to meson

Filter unsupported Objective-C options, to avoid 'unknown-warning-option' warnings when using Clang: [34/373] Compiling Objective-C object libcommon.fa.p/audio_coreaudio.m.o warning: unknown warning option '-Wold-style-declaration'; did you mean '-Wout-of-line-declaration'? [-Wunknown-warning

Re: [PATCH v2 3/6] hw/misc: Add a model of the Xilinx ZynqMP CRF

On Thu, 3 Feb 2022 at 14:01, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > Add a model of the Xilinx ZynqMP CRF. At the moment this > is mostly a stub model. > +static const VMStateDescription vmstate_crf = { > +.name = TYPE_XLNX_ZYNQMP_CRF, > +.version_id = 1, > +.minim

[PATCH v2 7/8] audio: Rename coreaudio extension to use Objective-C compiler

The coreaudio library includes Objective-C declarations (using the caret '^' symbol to declare block references [*]). When building with a C compiler we get: [175/839] Compiling C object libcommon.fa.p/audio_coreaudio.c.o In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX

[PATCH v4 0/3] Support fd-based KVM stats

This patchset adds QEMU support for querying fd-based KVM stats. The kernel support was introduced by: cb082bfab59a ("KVM: stats: Add fd-based API to read binary stats data") v4: - revise and cleanup the API [Daniel, Paolo] - filtering for multiple providers [Daniel] - cache KVM stat descriptors

Re: [PATCH v5 3/3] virtiofsd: Add support for FUSE_SYNCFS request without announce_submounts

On Tue, Feb 15, 2022 at 10:18:03AM +0100, Greg Kurz wrote: > On Mon, 14 Feb 2022 14:09:47 -0500 > Vivek Goyal wrote: > > > On Mon, Feb 14, 2022 at 01:56:08PM -0500, Vivek Goyal wrote: > > > On Mon, Feb 14, 2022 at 01:27:22PM -0500, Vivek Goyal wrote: > > > > On Mon, Feb 14, 2022 at 02:58:20PM +01

Re: [PATCH 8/9] target/ppc: Introduce a vhyp framework for nested HV support

On 2/15/22 04:16, Nicholas Piggin wrote: Introduce virtual hypervisor methods that can support a "Nested KVM HV" implementation using the bare metal 2-level radix MMU, and using HV exceptions to return from H_ENTER_NESTED (rather than cause interrupts). HV exceptions can now be raised in the TCG

Re: [PULL 18/38] Remove unnecessary minimum_version_id_old fields

On 2/15/22 18:13, Peter Maydell wrote: On Thu, 27 Jan 2022 at 15:14, Juan Quintela wrote: From: Peter Maydell The migration code will not look at a VMStateDescription's minimum_version_id_old field unless that VMSD has set the load_state_old field to something non-NULL. (The purpose of mini

Re: [PATCH v11 4/4] target/ppc: trigger PERFM EBBs from power8-pmu.c

On 2/15/22 13:37, Cédric Le Goater wrote: On 2/11/22 19:33, Daniel Henrique Barboza wrote: This patch adds the EBB exception support that are triggered by Performance Monitor alerts. This happens when a Performance Monitor alert occurs and MMCR0_EBE, BESCR_PME and BESCR_GE are set. fire_PMC_

Re: [PULL 0/4] Python patches

On Tue, Feb 8, 2022 at 9:40 AM Peter Maydell wrote: > > On Thu, 3 Feb 2022 at 23:22, John Snow wrote: > > > > On Thu, Feb 3, 2022 at 11:52 AM Peter Maydell > > wrote: > > > > > > On Thu, 3 Feb 2022 at 16:38, John Snow wrote: > > > > > > > On Thu, Feb 3, 2022, 11:20 AM Peter Maydell > > > > w

Re: [PATCH v2 00/14] target: Use ArchCPU & CPUArchState as abstract interface to target CPU

Hi Philippe, What's the idea behind these 2 types: ArchCPU and CPUArchState ? I don't understand why we'll need them. Thanks, Damien On 2/14/22 19:31, Philippe Mathieu-Daudé via wrote: Missing review: 10, 13, 14 Since v1: - Include Hexagon OBJECT_DECLARE_TYPE() patch - Add missing includes to

[PATCH 0/4] block/dirty-bitmaps: fix and improve bitmap merge

Hi all! Here are some good refactoring and fix of bitmap merge paths. Vladimir Sementsov-Ogievskiy (4): block: bdrv_merge_dirty_bitmap: add return value block: block_dirty_bitmap_merge(): fix error path block: improve block_dirty_bitmap_merge(): don't allocate extra bitmap block: simplify

[PATCH 1/4] block: bdrv_merge_dirty_bitmap: add return value

Add return value to bdrv_merge_dirty_bitmap() and use it to reduce error propagation. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/dirty-bitmap.h| 2 +- block/dirty-bitmap.c| 6 -- block/monitor/bitmap-qmp-cmds.c | 5 + 3 files changed, 6 insertions(+), 7

[PATCH 2/4] block: block_dirty_bitmap_merge(): fix error path

At the end we ignore failure of bdrv_merge_dirty_bitmap() and report success. And still set errp. That's wrong. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/monitor/bitmap-qmp-cmds.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/block/monitor/bitmap-qmp-cmds.c

[PATCH 4/4] block: simplify handling of try to merge different sized bitmaps

We have too much logic to simply check that bitmaps are of the same size. Let's just define that hbitmap_merge() and bdrv_dirty_bitmap_merge_internal() require their argument bitmaps be of same size, this simplifies things. Let's look through the callers: For backup_init_bcs_bitmap() we already a

[PATCH 3/4] block: improve block_dirty_bitmap_merge(): don't allocate extra bitmap

We don't need extra bitmap. All we need is to backup the original bitmap when we do first merge. So, drop extra temporary bitmap and work directly with target and backup. Note that block_dirty_bitmap_merge() semantics changed: on failure target may be modified now, and caller should call block_dir

[PATCH] migration: Remove load_state_old and minimum_version_id_old

There are no longer any VMStateDescription structs in the tree which use the load_state_old support for custom handling of incoming migration from very old QEMU. Remove the mechanism entirely. This includes removing one stray useless setting of minimum_version_id_old in a VMStateDescription with

Re: [PULL 18/38] Remove unnecessary minimum_version_id_old fields

On Tue, 15 Feb 2022 at 17:34, Cédric Le Goater wrote: > > On 2/15/22 18:13, Peter Maydell wrote: > > No, as the commit message notes, it deliberately did not change > > that one vmstate, because at the time of writing the patch > > that was the one vmstate that really was still using > > load_stat

Re: [PULL 0/4] Python patches

On Tue, 15 Feb 2022 at 17:46, John Snow wrote: > Just so I don't leave this thread hanging, I filed a GitLab issue and > I'm working on it, but this one isn't as quick to solve as the other. > > https://gitlab.com/qemu-project/qemu/-/issues/874 Is there anything particular to NetBSD that means it

Re: [PATCH 3/3] x86: Switch to q35 as the default machine type

On Tue, Feb 15, 2022 at 04:25:33PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The 'q35' machine type series has been around for a few years now, and > is getting heavily used downstream without many problems; lets flip > to using it as the default. I don't t

[PATCH v6 1/1] virtiofsd: Add basic support for FUSE_SYNCFS request

Honor the expected behavior of syncfs() to synchronously flush all data and metadata to disk on linux systems. If virtiofsd is started with '-o announce_submounts', the client is expected to send a FUSE_SYNCFS request for each individual submount. In this case, we just create a new file descriptor

Re: [RFC 0/8] ioregionfd introduction

On Mon, Feb 14, 2022 at 02:52:29PM +, Stefan Hajnoczi wrote: > On Mon, Feb 07, 2022 at 11:22:14PM -0800, Elena Ufimtseva wrote: > > This patchset is an RFC version for the ioregionfd implementation > > in QEMU. The kernel patches are to be posted with some fixes as a v4. > > > > For this imple

Re: [RFC 4/8] ioregionfd: Introduce IORegionDFObject type

On Mon, Feb 14, 2022 at 02:37:21PM +, Stefan Hajnoczi wrote: > On Mon, Feb 07, 2022 at 11:22:18PM -0800, Elena Ufimtseva wrote: > > Signed-off-by: Elena Ufimtseva > > --- > > meson.build| 15 ++- > > qapi/qom.json | 32 +- > > include/hw/remote/ioreg

[PATCH v6 0/1] virtiofsd: Add support for FUSE_SYNCFS request

FUSE_SYNCFS allows the client to flush the host page cache. v6: - drop ! announce_submounts part for now, only the root inode is synced in this case v5: - split announce_submounts and ! announce_submounts to separate patches for easier review (but could be squashed together) - tra

Re: [RFC 4/8] ioregionfd: Introduce IORegionDFObject type

On Fri, Feb 11, 2022 at 02:46:47PM +0100, Markus Armbruster wrote: > Elena Ufimtseva writes: > > > Signed-off-by: Elena Ufimtseva > > [...] > > > diff --git a/qapi/qom.json b/qapi/qom.json > > index eeb5395ff3..439fb94c93 100644 > > --- a/qapi/qom.json > > +++ b/qapi/qom.json > > @@ -689,6 +68

Re: [PATCH 3/3] x86: Switch to q35 as the default machine type

* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Tue, Feb 15, 2022 at 04:25:33PM +, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > The 'q35' machine type series has been around for a few years now, and > > is getting heavily used downstream without many p

Re: [PATCH 9/9] spapr: implement nested-hv capability for the virtual hypervisor

On 2/15/22 04:16, Nicholas Piggin wrote: This implements the Nested KVM HV hcall API for spapr under TCG. The L2 is switched in when the H_ENTER_NESTED hcall is made, and the L1 is switched back in returned from the hcall when a HV exception is sent to the vhyp. Register state is copied in and o

Re: [PATCH 0/9] ppc: nested KVM HV for spapr virtual hypervisor

On 2/15/22 04:16, Nicholas Piggin wrote: Here is the rollup of patches in much better shape since the RFC. I include the 2 first ones unchanged from independent submission just to be clear that this series requires them. Thanks Cedric and Fabiano for wading through my poor quality RFC code, very

Re: "make check-acceptance" takes way too long

Peter Maydell writes: > "make check-acceptance" takes way way too long. I just did a run > on an arm-and-aarch64-targets-only debug build and it took over > half an hour, and this despite it skipping or cancelling 26 out > of 58 tests! > > I think that ~10 minutes runtime is reasonable. 30 is n

Re: [PATCH 0/9] ppc: nested KVM HV for spapr virtual hypervisor

On 2/15/22 15:33, Cédric Le Goater wrote: On 2/15/22 04:16, Nicholas Piggin wrote: Here is the rollup of patches in much better shape since the RFC. I include the 2 first ones unchanged from independent submission just to be clear that this series requires them. Thanks Cedric and Fabiano for

Re: [PATCH] migration: Remove load_state_old and minimum_version_id_old

On 15/2/22 18:57, Peter Maydell wrote: There are no longer any VMStateDescription structs in the tree which use the load_state_old support for custom handling of incoming migration from very old QEMU. Remove the mechanism entirely. This includes removing one stray useless setting of minimum_ver

Re: [PATCH 2/9] spapr: prevent hdec timer being set up under virtual hypervisor

On 2/15/22 04:16, Nicholas Piggin wrote: The spapr virtual hypervisor does not require the hdecr timer. Remove it. Signed-off-by: Nicholas Piggin Reviewed-by: Cédric Le Goater Thanks, C. --- hw/ppc/ppc.c| 2 +- hw/ppc/spapr_cpu_core.c | 6 +++--- 2 files changed, 4 insert

Re: [PATCH 3/9] ppc: allow the hdecr timer to be created/destroyed

On 2/15/22 04:16, Nicholas Piggin wrote: Machines which don't emulate the HDEC facility are able to use the timer for something else. Provide functions to start and stop the hdecr timer. Signed-off-by: Nicholas Piggin --- hw/ppc/ppc.c | 20 include/hw/ppc/ppc.h |

Re: [PULL 0/4] Python patches

On Tue, Feb 15, 2022 at 1:01 PM Peter Maydell wrote: > > On Tue, 15 Feb 2022 at 17:46, John Snow wrote: > > Just so I don't leave this thread hanging, I filed a GitLab issue and > > I'm working on it, but this one isn't as quick to solve as the other. > > > > https://gitlab.com/qemu-project/qemu/

<    1   2   3   4   >