Re: [PATCH] spapr: prevent hdec timer being set up under virtual hypervisor

2022-02-14 Thread Daniel Henrique Barboza
On 2/14/22 09:31, Nicholas Piggin wrote: The spapr virtual hypervisor does not require the hdecr timer. Remove it. Signed-off-by: Nicholas Piggin --- Reviewed-by: Daniel Henrique Barboza hw/ppc/ppc.c| 2 +- hw/ppc/spapr_cpu_core.c | 6 +++--- 2 files changed, 4 insertion

Re: [PATCH] ui/cocoa: Do not alert even without block devices

2022-02-14 Thread Akihiko Odaki
On Mon, Feb 14, 2022 at 9:31 PM Philippe Mathieu-Daudé wrote: > Is this menu updated when removable blkdev are hot-plugged from > the monitor or QMP? Actually no.

Re: [PATCH RFCv2 1/4] hw/i386: add 4g boundary start to X86MachineState

2022-02-14 Thread Joao Martins
On 2/14/22 13:19, Igor Mammedov wrote: > On Mon, 7 Feb 2022 20:24:19 + > Joao Martins wrote: >> static void x86_machine_class_init(ObjectClass *oc, void *data) >> diff --git a/include/hw/i386/x86.h b/include/hw/i386/x86.h >> index a145a303703f..2de7ec046b75 100644 >> --- a/include/hw/i386/x8

Re: [PATCH RFCv2 3/4] i386/pc: warn if phys-bits is too low

2022-02-14 Thread Joao Martins
On 2/14/22 13:15, David Edmondson wrote: > On Monday, 2022-02-07 at 20:24:21 GMT, Joao Martins wrote: > >> Default phys-bits on Qemu is TCG_PHYS_BITS (40) which is enough >> to address 1Tb (0xff ). On AMD platforms, if a >> ram-above-4g relocation happens and the CPU wasn't configured >>

Re: [PATCH RFCv2 1/4] hw/i386: add 4g boundary start to X86MachineState

2022-02-14 Thread Igor Mammedov
On Mon, 7 Feb 2022 20:24:19 + Joao Martins wrote: > Rather than hardcoding the 4G boundary everywhere, introduce a > X86MachineState property @above_4g_mem_start and use it > accordingly. > > This is in preparation for relocating ram-above-4g to be > dynamically start at 1T on AMD platforms

Re: [PATCH] spapr: prevent hdec timer being set up under virtual hypervisor

2022-02-14 Thread Fabiano Rosas
Nicholas Piggin writes: > The spapr virtual hypervisor does not require the hdecr timer. Why is that? Is this not needed for an emulated powernv running KVM guests? > Remove it. > > Signed-off-by: Nicholas Piggin > --- > hw/ppc/ppc.c| 2 +- > hw/ppc/spapr_cpu_core.c | 6 +++--- >

Re: [PATCH] target/ppc: raise HV interrupts for partition table entry problems

2022-02-14 Thread Fabiano Rosas
Nicholas Piggin writes: > Invalid or missing partition table entry exceptions should cause HV > interrupts. HDSISR is set to bad MMU config, which is consistent with > the ISA and experimentally matches what POWER9 generates. > > Signed-off-by: Nicholas Piggin Reviewed-by: Fabiano Rosas > ---

Re: [PATCH] scripts/qapi: minor delinting

2022-02-14 Thread Markus Armbruster
John Snow writes: > On Fri, Feb 11, 2022 at 12:11 PM John Snow wrote: >> >> On Fri, Feb 11, 2022 at 6:58 AM Markus Armbruster wrote: [...] >> > Several of the names in scripts/qapi/pylintrc's good-names don't >> > actually occur in the code. >> > >> > Could I persuade you to replace it with s

[PATCH] accel/tcg/cpu-exec: fix precise single-stepping after interrupt

2022-02-14 Thread Luc Michel
In some cases, cpu->exit_request can be false after handling the interrupt, leading to another TB being executed instead of returning to the main loop. Fix this by returning true unconditionally when in single-step mode. Fixes: ba3c35d9c4026361fd380b269dc6def9510b7166 Signed-off-by: Luc Michel

Re: [PATCH v6 10/10] virtiofsd: Add an option to enable/disable security label

2022-02-14 Thread Dr. David Alan Gilbert
* Vivek Goyal (vgo...@redhat.com) wrote: > Provide an option "-o security_label/no_security_label" to enable/disable > security label functionality. By default these are turned off. > > If enabled, server will indicate to client that it is capable of handling > one security label during file creat

Re: [PATCH] ui/cocoa: Do not alert even without block devices

2022-02-14 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 13/2/22 03:14, Akihiko Odaki wrote: >> Signed-off-by: Akihiko Odaki >> --- >> ui/cocoa.m | 5 - >> 1 file changed, 5 deletions(-) >> diff --git a/ui/cocoa.m b/ui/cocoa.m >> index ac18e14ce01..271a2676026 100644 >> --- a/ui/cocoa.m >> +++ b/ui/cocoa.m >>

Re: Call for GSoC and Outreachy project ideas for summer 2022

2022-02-14 Thread Alex Bennée
Stefan Hajnoczi writes: > Dear QEMU, KVM, and rust-vmm communities, > QEMU will apply for Google Summer of Code 2022 > (https://summerofcode.withgoogle.com/) and has been accepted into > Outreachy May-August 2022 (https://www.outreachy.org/). You can now > submit internship project ideas for QE

[PATCH] ppc/spapr: Advertise StoreEOI for POWER10 compat guests

2022-02-14 Thread Cédric Le Goater
When an interrupt has been handled, the OS notifies the interrupt controller with a EOI sequence. On a POWER9 and POWER10 systems using the XIVE interrupt controller, this can be done with a load or a store operation on the ESB interrupt management page of the interrupt. The StoreEOI operation has

Re: Call for GSoC and Outreachy project ideas for summer 2022

2022-02-14 Thread Stefan Hajnoczi
On Mon, 14 Feb 2022 at 07:11, Jason Wang wrote: > > On Fri, Jan 28, 2022 at 11:47 PM Stefan Hajnoczi wrote: > > > > Dear QEMU, KVM, and rust-vmm communities, > > QEMU will apply for Google Summer of Code 2022 > > (https://summerofcode.withgoogle.com/) and has been accepted into > > Outreachy May-

Re: Call for GSoC and Outreachy project ideas for summer 2022

2022-02-14 Thread Stefan Hajnoczi
On Wed, 9 Feb 2022 at 14:50, Alexander Graf wrote: > On 28.01.22 16:47, Stefan Hajnoczi wrote: > > Dear QEMU, KVM, and rust-vmm communities, > > QEMU will apply for Google Summer of Code 2022 > > (https://summerofcode.withgoogle.com/) and has been accepted into > > Outreachy May-August 2022 (https

[PATCH v3 0/3] hw/smbios: fix table memory corruption with large memory vms

2022-02-14 Thread Ani Sinha
This patchset tries to address the issue raised in https://bugzilla.redhat.com/show_bug.cgi?id=2023977 . Patch 2 and patch 3 are dependent on patch 1. Patch 1 makes some code cleanup to make thing more readable and also is a preparatory patch for patches 2 and 3. Patch 2 is the actual fix. Patch 3

Re: Adding a handshake to qemu-guest-agent

2022-02-14 Thread Markus Armbruster
Cc: the qemu-ga maintainer John Snow writes: > [Moving our discussion upstream, because it stopped being brief and simple.] Motivation: qemu-ga doesn't do capability negotiation as specified in docs/interop/qmp-spec.txt. Reminder: qmp-spec.txt specifies the server shall send a greeting contain

Re: Call for GSoC and Outreachy project ideas for summer 2022

2022-02-14 Thread Stefan Hajnoczi
On Mon, 14 Feb 2022 at 13:42, Alex Bennée wrote: > > > Stefan Hajnoczi writes: > > > Dear QEMU, KVM, and rust-vmm communities, > > QEMU will apply for Google Summer of Code 2022 > > (https://summerofcode.withgoogle.com/) and has been accepted into > > Outreachy May-August 2022 (https://www.outrea

Re: [RFC] thread-pool: Add option to fix the pool size

2022-02-14 Thread Kevin Wolf
Am 14.02.2022 um 14:10 hat Stefan Hajnoczi geschrieben: > On Mon, Feb 14, 2022 at 12:38:22PM +0100, Kevin Wolf wrote: > > Am 14.02.2022 um 11:09 hat Stefan Hajnoczi geschrieben: > > > On Fri, Feb 11, 2022 at 12:32:57PM +0100, Kevin Wolf wrote: > > > > Am 03.02.2022 um 15:19 hat Stefan Hajnoczi gesc

[PATCH v3 2/3] hw/smbios: fix table memory corruption with large memory vms

2022-02-14 Thread Ani Sinha
The current smbios table implementation splits the main memory in 16 GiB (DIMM like) chunks. With the current smbios table assignment code, we can have only 512 such chunks before the 16 bit handle numbers in the header for tables 17 and 19 conflict. A guest with more than 8 TiB of memory will hit

Re: [RFC 3/8] ioregionfd: introduce memory API functions

2022-02-14 Thread Stefan Hajnoczi
On Mon, Feb 07, 2022 at 11:22:17PM -0800, Elena Ufimtseva wrote: > @@ -2434,6 +2569,42 @@ void memory_region_clear_flush_coalesced(MemoryRegion > *mr) > > static bool userspace_eventfd_warning; > > +void memory_region_add_ioregionfd(MemoryRegion *mr, > + hwadd

Re: [PATCH v6 10/10] virtiofsd: Add an option to enable/disable security label

2022-02-14 Thread Vivek Goyal
On Mon, Feb 14, 2022 at 01:32:38PM +, Dr. David Alan Gilbert wrote: > * Vivek Goyal (vgo...@redhat.com) wrote: > > Provide an option "-o security_label/no_security_label" to enable/disable > > security label functionality. By default these are turned off. > > > > If enabled, server will indica

[PATCH v3 3/3] hw/smbios: add assertion to ensure handles of tables 19 and 32 do not collide

2022-02-14 Thread Ani Sinha
Since change b3cddba9c14b034 ("hw/smbios: fix table memory corruption with large memory vms") we reserve additional space between handle numbers of tables 17 and 19 for large VMs. This may cause table 19 to collide with table 32 in their handle numbers for those large VMs. This change adds an asse

Re: [PATCH v2 0/3] hw/smbios: fix table memory corruption with large memory vms

2022-02-14 Thread Michael S. Tsirkin
On Mon, Feb 07, 2022 at 05:01:26PM +0530, Ani Sinha wrote: > This patchset tries to address the issue raised in > https://bugzilla.redhat.com/show_bug.cgi?id=2023977 . > > Patch 2 and patch 3 are dependent on patch 1. > Patch 1 makes some code cleanup to make thing more readable and also is > a

[PATCH v3 1/3] hw/smbios: code cleanup - use macro definitions for table header handles

2022-02-14 Thread Ani Sinha
This is a minor cleanup. Using macro definitions makes the code more readable. It is at once clear which tables use which handle numbers in their header. It also makes it easy to calculate the gaps between the numbers and update them if needed. Reviewed-by: Igor Mammedov Signed-off-by: Ani Sinha

Re: [PATCH v1 11/11] tests/tcg: add vectorised sha512 versions

2022-02-14 Thread Matheus K. Ferst
On 11/02/2022 13:03, Alex Bennée wrote: This builds vectorised versions of sha512 to exercise the vector code: - aarch64 (AdvSimd) - i386 (SSE) - s390x (MVX) - ppc64 (vector) Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20220202191242.652607-5-alex.ben...

Re: [PATCH] trace: Split address space and slot id in trace_kvm_set_user_memory()

2022-02-14 Thread Xiaoyao Li
kindly ping. On 1/4/2022 10:35 AM, Xiaoyao Li wrote: The upper 16 bits of kvm_userspace_memory_region::slot are address space id. Parse it separately in trace_kvm_set_user_memory(). Signed-off-by: Xiaoyao Li --- accel/kvm/kvm-all.c| 5 +++-- accel/kvm/trace-events | 2 +- 2 files chang

Re: 9 TiB vm memory creation

2022-02-14 Thread David Hildenbrand
On 14.02.22 13:36, Igor Mammedov wrote: > On Mon, 14 Feb 2022 10:54:22 +0530 (IST) > Ani Sinha wrote: > >> Hi Igor: >> >> I failed to spawn a 9 Tib VM. The max I could do was a 2 TiB vm on my >> system with the following commandline before either the system >> destabilized or the OOM killed kille

Re: [PATCH v2] scripts/qapi: minor delinting

2022-02-14 Thread Markus Armbruster
John Snow writes: > Get isort and pylint tools passing again. > > Signed-off-by: John Snow > --- > scripts/qapi/commands.py | 2 +- > scripts/qapi/pylintrc| 15 +-- > scripts/qapi/types.py| 6 +- > scripts/qapi/visit.py| 6 +- > 4 files changed, 16 insertions(

Re: [PATCH v2] Deprecate C virtiofsd

2022-02-14 Thread Vivek Goyal
On Mon, Feb 14, 2022 at 11:30:03AM +, Dr. David Alan Gilbert wrote: > * Richard W.M. Jones (rjo...@redhat.com) wrote: > > On Thu, Feb 10, 2022 at 05:47:14PM +, Dr. David Alan Gilbert (git) > > wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > There's a nice new Rust implementation

Re: [PATCH RFCv2 2/4] i386/pc: relocate 4g start to 1T where applicable

2022-02-14 Thread Igor Mammedov
On Mon, 7 Feb 2022 20:24:20 + Joao Martins wrote: > It is assumed that the whole GPA space is available to be DMA > addressable, within a given address space limit, expect for a > tiny region before the 4G. Since Linux v5.4, VFIO validates > whether the selected GPA is indeed valid i.e. not

Re: [RFC PATCH 3/3] spapr: implement nested-hv support for the TCG virtual hypervisor

2022-02-14 Thread Fabiano Rosas
Nicholas Piggin writes: > This implements the nested-hv hcall API for spapr under TCG. > It's still a bit rough around the edges, concept seems to work. > > Some HV exceptions can be raised now in the TCG spapr machine when > running a nested guest. The main ones are the lev==1 syscall, the > hde

[PATCH v5 0/3] virtiofsd: Add support for FUSE_SYNCFS request

2022-02-14 Thread Greg Kurz
FUSE_SYNCFS allows the client to flush the host page cache. v5: - split announce_submounts and ! announce_submounts to separate patches for easier review (but could be squashed together) - track submounts directly in lo_inode structure following the same logic as FUSE_ATTR_SUBMOUNT

Re: [PATCH RFCv2 3/4] i386/pc: warn if phys-bits is too low

2022-02-14 Thread Igor Mammedov
On Mon, 7 Feb 2022 20:24:21 + Joao Martins wrote: > Default phys-bits on Qemu is TCG_PHYS_BITS (40) which is enough > to address 1Tb (0xff ). On AMD platforms, if a > ram-above-4g relocation happens and the CPU wasn't configured > with a big enough phys-bits, warn the user. There is

Re: [RFC 0/8] ioregionfd introduction

2022-02-14 Thread Stefan Hajnoczi
On Mon, Feb 07, 2022 at 11:22:14PM -0800, Elena Ufimtseva wrote: > This patchset is an RFC version for the ioregionfd implementation > in QEMU. The kernel patches are to be posted with some fixes as a v4. > > For this implementation version 3 of the posted kernel patches was user: > https://lore.k

[PATCH v5 1/3] virtiofsd: Add support for FUSE_SYNCFS request with announce_submounts

2022-02-14 Thread Greg Kurz
Honor the expected behavior of syncfs() to synchronously flush all data and metadata to disk on linux systems. If virtiofsd is started with '-o announce_submounts', the client is expected to send a FUSE_SYNCFS request for each individual submount. In this case, we just create a new file descriptor

Re: SecureBoot and PCI passthrough with kernel lockdown in place (on Xen)

2022-02-14 Thread Jan Beulich
On 14.02.2022 16:02, Dario Faggioli wrote: > We have run into an issue when trying to use PCI passthrough for a Xen > VM running on an host where dom0 kernel is 5.14.21 (but we think it > could be any kernel > 5.4) and SecureBoot is enabled. > > The error we get, when (for instance) trying to atta

[PATCH v5 2/3] virtiofsd: Track submounts

2022-02-14 Thread Greg Kurz
If Support for FUSE_SYNCFS requires the server to track submounts that may exist under the shared directory. lo_do_lookup() already knows how to detect them : it is a directory with a different device ID or mount ID than its parent. Use the same logic and record the information under the lo_inode

Re: [RFC 4/8] ioregionfd: Introduce IORegionDFObject type

2022-02-14 Thread Stefan Hajnoczi
On Mon, Feb 07, 2022 at 11:22:18PM -0800, Elena Ufimtseva wrote: > Signed-off-by: Elena Ufimtseva > --- > meson.build| 15 ++- > qapi/qom.json | 32 +- > include/hw/remote/ioregionfd.h | 40 +++ > hw/remote/ioregionfd.c | 196 +++

[PATCH v5 3/3] virtiofsd: Add support for FUSE_SYNCFS request without announce_submounts

2022-02-14 Thread Greg Kurz
This adds the missing bits to support FUSE_SYNCFS in the case submounts aren't announced to the client. Iterate over all inodes and call syncfs() on the ones marked as submounts. Since syncfs() can block for an indefinite time, we cannot call it with lo->mutex held as it would prevent the server t

Re: [PATCH RFCv2 2/4] i386/pc: relocate 4g start to 1T where applicable

2022-02-14 Thread Joao Martins
On 2/14/22 14:53, Igor Mammedov wrote: > On Mon, 7 Feb 2022 20:24:20 + > Joao Martins wrote: > >> It is assumed that the whole GPA space is available to be DMA >> addressable, within a given address space limit, expect for a >> tiny region before the 4G. Since Linux v5.4, VFIO validates >

Re: [PATCH v1 11/11] tests/tcg: add vectorised sha512 versions

2022-02-14 Thread Alex Bennée
"Matheus K. Ferst" writes: > On 11/02/2022 13:03, Alex Bennée wrote: >> This builds vectorised versions of sha512 to exercise the vector code: >>- aarch64 (AdvSimd) >>- i386 (SSE) >>- s390x (MVX) >>- ppc64 (vector) >> Signed-off-by: Alex Bennée >> Reviewed-by: Richard Henderson

Re: [Virtio-fs] [PATCH v5 1/3] virtiofsd: Add support for FUSE_SYNCFS request with announce_submounts

2022-02-14 Thread German Maglione
On Mon, Feb 14, 2022 at 3:00 PM Greg Kurz wrote: > Honor the expected behavior of syncfs() to synchronously flush all data > and metadata to disk on linux systems. > > If virtiofsd is started with '-o announce_submounts', the client is > expected to send a FUSE_SYNCFS request for each individual

SecureBoot and PCI passthrough with kernel lockdown in place (on Xen)

2022-02-14 Thread Dario Faggioli
Hello, We have run into an issue when trying to use PCI passthrough for a Xen VM running on an host where dom0 kernel is 5.14.21 (but we think it could be any kernel > 5.4) and SecureBoot is enabled. The error we get, when (for instance) trying to attach a device to an (HVM) VM, on such system is

Re: [PATCH 5/6] test-bdrv-drain.c: remove test_detach_by_parent_cb()

2022-02-14 Thread Kevin Wolf
Am 14.02.2022 um 12:42 hat Paolo Bonzini geschrieben: > On 2/11/22 16:38, Kevin Wolf wrote: > > The callback of an I/O function isn't I/O, though. It is code_after_ > > the I/O has completed. If this doesn't work any more, it feels like this > > is a bug. > > The issue is that the I/O has *not* co

Re: [PULL 0/5] 9p queue 2022-02-10

2022-02-14 Thread Vitaly Chikunov
Christian, On Mon, Feb 14, 2022 at 12:44:48PM +0100, Christian Schoenebeck wrote: > On Montag, 14. Februar 2022 11:36:53 CET Greg Kurz wrote: > > The synth backend should be fixed to honor d_reclen, or > > at least to allocate with g_new0(). > > Yes, I overlooked that this is not initialized with

Re: SecureBoot and PCI passthrough with kernel lockdown in place (on Xen)

2022-02-14 Thread marma...@invisiblethingslab.com
On Mon, Feb 14, 2022 at 03:25:31PM +, Andrew Cooper wrote: > On 14/02/2022 15:02, Dario Faggioli wrote: > > Hello, > > > > We have run into an issue when trying to use PCI passthrough for a Xen > > VM running on an host where dom0 kernel is 5.14.21 (but we think it > > could be any kernel > 5.4

Re: [PATCH RFCv2 3/4] i386/pc: warn if phys-bits is too low

2022-02-14 Thread Igor Mammedov
On Mon, 14 Feb 2022 15:18:43 + Joao Martins wrote: > On 2/14/22 15:03, Igor Mammedov wrote: > > On Mon, 7 Feb 2022 20:24:21 + > > Joao Martins wrote: > > > >> Default phys-bits on Qemu is TCG_PHYS_BITS (40) which is enough > >> to address 1Tb (0xff ). On AMD platforms, if a

Re: [PATCH v1 0/2] i386: Make PIT and PIC the property of common x86 base machine type

2022-02-14 Thread Xiaoyao Li
ping. On 1/11/2022 3:35 PM, Xiaoyao Li wrote: For PIT, it's straightforward to merge microvm::pit and pc_machine::pit_enabled into x86ms::pit For PIC, move microvm::pic to x86ms:pic, which gives PC machine the ability to dis-/en-able PIC and it's the preparation for future TDX support. Xiaoyao

Re: [PATCH RFCv2 2/4] i386/pc: relocate 4g start to 1T where applicable

2022-02-14 Thread Igor Mammedov
On Mon, 14 Feb 2022 15:05:00 + Joao Martins wrote: > On 2/14/22 14:53, Igor Mammedov wrote: > > On Mon, 7 Feb 2022 20:24:20 + > > Joao Martins wrote: > > > >> It is assumed that the whole GPA space is available to be DMA > >> addressable, within a given address space limit, expect fo

Re: 9 TiB vm memory creation

2022-02-14 Thread Igor Mammedov
On Mon, 14 Feb 2022 15:37:53 +0100 David Hildenbrand wrote: > On 14.02.22 13:36, Igor Mammedov wrote: > > On Mon, 14 Feb 2022 10:54:22 +0530 (IST) > > Ani Sinha wrote: > > > >> Hi Igor: > >> > >> I failed to spawn a 9 Tib VM. The max I could do was a 2 TiB vm on my > >> system with the follow

Re: [PATCH v2 0/3] hw/smbios: fix table memory corruption with large memory vms

2022-02-14 Thread Ani Sinha
On Mon, Feb 14, 2022 at 20:04 Michael S. Tsirkin wrote: > > On Mon, Feb 07, 2022 at 05:01:26PM +0530, Ani Sinha wrote: > > This patchset tries to address the issue raised in > > https://bugzilla.redhat.com/show_bug.cgi?id=2023977 . > > > > Patch 2 and patch 3 are dependent on patch 1. > > Patch 1

Re: [Virtio-fs] [PATCH v5 1/3] virtiofsd: Add support for FUSE_SYNCFS request with announce_submounts

2022-02-14 Thread Greg Kurz
On Mon, 14 Feb 2022 16:43:15 +0100 German Maglione wrote: > On Mon, Feb 14, 2022 at 3:00 PM Greg Kurz wrote: > > > Honor the expected behavior of syncfs() to synchronously flush all data > > and metadata to disk on linux systems. > > > > If virtiofsd is started with '-o announce_submounts', the

Re: [PATCH RFCv2 3/4] i386/pc: warn if phys-bits is too low

2022-02-14 Thread Joao Martins
On 2/14/22 15:03, Igor Mammedov wrote: > On Mon, 7 Feb 2022 20:24:21 + > Joao Martins wrote: > >> Default phys-bits on Qemu is TCG_PHYS_BITS (40) which is enough >> to address 1Tb (0xff ). On AMD platforms, if a >> ram-above-4g relocation happens and the CPU wasn't configured >> wit

Re: [PULL 00/42] ppc queue

2022-02-14 Thread Peter Maydell
On Thu, 10 Feb 2022 at 13:00, Cédric Le Goater wrote: > > The following changes since commit 0a301624c2f4ced3331ffd5bce85b4274fe132af: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20220208' into staging (2022-02-08 > 11:40:08 +) > > are available in the Git rep

Re: [PATCH v5 2/3] virtiofsd: Track submounts

2022-02-14 Thread Greg Kurz
On Mon, 14 Feb 2022 14:58:19 +0100 Greg Kurz wrote: > If > Support for FUSE_SYNCFS requires the server to track submounts > > that may exist under the shared directory. lo_do_lookup() already knows > how to detect them : it is a directory with a different device ID or > mount ID than its parent.

Re: [PATCH RFCv2 3/4] i386/pc: warn if phys-bits is too low

2022-02-14 Thread Joao Martins
On 2/14/22 15:41, Igor Mammedov wrote: > On Mon, 14 Feb 2022 15:18:43 + > Joao Martins wrote: >> On 2/14/22 15:03, Igor Mammedov wrote: >>> On Mon, 7 Feb 2022 20:24:21 + >>> Joao Martins wrote: diff --git a/hw/i386/pc.c b/hw/i386/pc.c index b060aedd38f3..f8712eb8427e 100644 >>>

Re: 9 TiB vm memory creation

2022-02-14 Thread David Hildenbrand
>>> >>> With KVM enabled it bails out with: >>>qemu-system-x86_64: kvm_set_user_memory_region: >>> KVM_SET_USER_MEMORY_REGION failed, slot=1, start=0x1, >>> size=0x8ff4000: Invalid argument >>> >>> all of that on a host with 32G of RAM/no swap. >>> >>> >> >> #define KVM_MEM_MAX

proposed release schedule for QEMU 7.0

2022-02-14 Thread Peter Maydell
Here's my suggestion for release schedule dates for 7.0: 2021-12-14 Beginning of development phase 2022-03-08 Soft feature freeze. Only bug fixes after this point. All feature changes must be already in a sub maintainer tree and all pull requests from submaintainers must have

Re: proposed release schedule for QEMU 7.0

2022-02-14 Thread Peter Maydell
On Mon, 14 Feb 2022 at 17:09, Peter Maydell wrote: > > Here's my suggestion for release schedule dates for 7.0: > > 2021-12-14 Beginning of development phase > 2022-03-08 Soft feature freeze. Only bug fixes after this point. >All feature changes must be already in a sub maintainer >

Re: [PATCH v4 0/1] Patch to adjust coroutine pool size adaptively

2022-02-14 Thread Stefan Hajnoczi
On Mon, Feb 14, 2022 at 08:53:01PM +0900, Hiroki Narukawa wrote: > Resending with correct commit message > > Resending patch with decreasing coroutine pool size on device remove > > We encountered random disk IO performance drop since qemu-5.0.0, and this > patch fixes it. > > Commit message in

Re: [PATCH v3 1/1] util: adjust coroutine pool size to virtio block queue

2022-02-14 Thread Stefan Hajnoczi
On Mon, Feb 14, 2022 at 11:54:34AM +, Hiroki Narukawa wrote: > > Coroutine pool size was 64 from long ago, and the basis was organized in the > > commit message in c740ad92. > > Sorry, I noticed that commit ID mentioning here was incorrect. > The correct one is 4d68e86b. > > https://gitlab.co

Re: [PATCH v3 0/4] virtio-iommu: Support VIRTIO_IOMMU_F_BYPASS_CONFIG

2022-02-14 Thread Cornelia Huck
On Mon, Feb 14 2022, Jean-Philippe Brucker wrote: > Replace the VIRTIO_IOMMU_F_BYPASS feature with > VIRTIO_IOMMU_F_BYPASS_CONFIG, which enables a config space bit to switch > global bypass on and off. > > Add a boot-bypass option, which defaults to 'on' to be in line with > other vIOMMUs and to

Re: [PATCH v11 3/4] target/ppc: add PPC_INTERRUPT_EBB and EBB exceptions

2022-02-14 Thread Cédric Le Goater
On 2/11/22 19:33, Daniel Henrique Barboza wrote: PPC_INTERRUPT_EBB is a new interrupt that will be used to deliver EBB exceptions that had to be postponed because the thread wasn't in problem state at the time the event-based branch was supposed to occur. ISA 3.1 also defines two EBB exceptions:

Re: [PATCH 5/6] test-bdrv-drain.c: remove test_detach_by_parent_cb()

2022-02-14 Thread Paolo Bonzini
On 2/14/22 16:28, Kevin Wolf wrote: The BlockBackend could safely return false from blk_root_drained_poll() while requests are still in their callbacks (if they do anything that touches a node, they would increase in_flight again), it just doesn't do it yet. It's only blk_drain(_all)() that would

Re: [PULL 0/5] 9p queue 2022-02-10

2022-02-14 Thread Christian Schoenebeck
On Montag, 14. Februar 2022 15:43:51 CET Vitaly Chikunov wrote: > Christian, > > On Mon, Feb 14, 2022 at 12:44:48PM +0100, Christian Schoenebeck wrote: > > On Montag, 14. Februar 2022 11:36:53 CET Greg Kurz wrote: > > > The synth backend should be fixed to honor d_reclen, or > > > at least to allo

[PULL 0/3] Block patches

2022-02-14 Thread Stefan Hajnoczi
The following changes since commit cc5ce8b8b6be83e5fe3b668dbd061ad97c534e3f: Merge remote-tracking branch 'remotes/legoater/tags/pull-ppc-20220210' into staging (2022-02-13 20:33:28 +) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/block-pull-request

Re: [PATCH v11 3/4] target/ppc: add PPC_INTERRUPT_EBB and EBB exceptions

2022-02-14 Thread Daniel Henrique Barboza
On 2/14/22 14:34, Cédric Le Goater wrote: On 2/11/22 19:33, Daniel Henrique Barboza wrote: PPC_INTERRUPT_EBB is a new interrupt that will be used to deliver EBB exceptions that had to be postponed because the thread wasn't in problem state at the time the event-based branch was supposed to oc

Re: [PATCH] spapr: prevent hdec timer being set up under virtual hypervisor

2022-02-14 Thread Cédric Le Goater
On 2/14/22 14:32, Fabiano Rosas wrote: Nicholas Piggin writes: The spapr virtual hypervisor does not require the hdecr timer. Why is that? Is this not needed for an emulated powernv running KVM guests? It is now also running in the QEMU pseries machine (L0) when a nested is running. That's

Re: [PATCH v5 3/3] virtiofsd: Add support for FUSE_SYNCFS request without announce_submounts

2022-02-14 Thread Vivek Goyal
On Mon, Feb 14, 2022 at 02:58:20PM +0100, Greg Kurz wrote: > This adds the missing bits to support FUSE_SYNCFS in the case submounts > aren't announced to the client. > > Iterate over all inodes and call syncfs() on the ones marked as submounts. > Since syncfs() can block for an indefinite time, w

[PATCH v2 00/14] target: Use ArchCPU & CPUArchState as abstract interface to target CPU

2022-02-14 Thread Philippe Mathieu-Daudé via
Missing review: 10, 13, 14 Since v1: - Include Hexagon OBJECT_DECLARE_TYPE() patch - Add missing includes to Hexagon - Introduce OBJECT_DECLARE_CPU_TYPE() macro - Use OBJECT_DECLARE_CPU_TYPE() Kind of respin of the "exec: Move translation declarations to 'translate-all.h'" series, but without mod

[PATCH v2 02/14] hw/m68k/mcf: Add missing 'exec/hwaddr.h' header

2022-02-14 Thread Philippe Mathieu-Daudé via
hwaddr type is defined in "exec/hwaddr.h". Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- include/hw/m68k/mcf.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/hw/m68k/mcf.h b/include/hw/m68k/mcf.h index decf17ce42..8cbd587bbf 1006

[PATCH v2 03/14] hw/tricore: Remove unused and incorrect header

2022-02-14 Thread Philippe Mathieu-Daudé via
TriCore boards certainly don't need the ARM loader API :) Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- include/hw/tricore/triboard.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/hw/tricore/triboard.h b/include/hw/tricore/triboa

Re: [RFC PATCH 3/3] spapr: implement nested-hv support for the TCG virtual hypervisor

2022-02-14 Thread Cédric Le Goater
On 2/10/22 07:53, Nicholas Piggin wrote: This implements the nested-hv hcall API for spapr under TCG. It's still a bit rough around the edges, concept seems to work. Some HV exceptions can be raised now in the TCG spapr machine when running a nested guest. The main ones are the lev==1 syscall, t

[PATCH v2 01/14] meson: Display libfdt as disabled when system emulation is disabled

2022-02-14 Thread Philippe Mathieu-Daudé via
When configuring QEMU with --disable-system, meson keeps showing libfdt as "auto". Mark it as disabled instead. Acked-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daudé --- meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index df

[PATCH v2 04/14] exec/cpu_ldst: Include 'cpu.h' to get target_ulong definition

2022-02-14 Thread Philippe Mathieu-Daudé via
Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- include/exec/cpu_ldst.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/exec/cpu_ldst.h b/include/exec/cpu_ldst.h index da987fe8ad..6adacf8928 100644 --- a/include/exec/cpu_ldst.h +++ b/include/exec/cpu_ldst.h @

[PATCH v2 08/14] Hexagon (target/hexagon) convert to OBJECT_DECLARE_TYPE

2022-02-14 Thread Philippe Mathieu-Daudé via
From: Taylor Simpson Suggested-by: Richard Henderson Signed-off-by: Taylor Simpson Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20220211033034.21107-1-tsimp...@quicinc.com> [PMD: Add missing "qom/object.h" include] Signed-off-by: Philippe Mathieu-Daudé ---

[PATCH v2 06/14] target/i386/cpu: Ensure accelerators set CPU addressble physical bits

2022-02-14 Thread Philippe Mathieu-Daudé via
The only accelerator allowed to use zero as default value is TCG. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/i386/cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index aa9e636800..16523a78d9 100644 --- a/target

[PATCH v2 05/14] cpu: Add missing 'exec/exec-all.h' and 'qemu/accel.h' headers

2022-02-14 Thread Philippe Mathieu-Daudé via
cpu.c requires "exec/exec-all.h" to call tlb_flush() and "qemu/accel.h" to call accel_cpu_realizefn(). Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- cpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cpu.c b/cpu.c index d5d4cbf8cb..d564886149 100644 --- a/cpu

[PATCH v2 07/14] target/i386/tcg/sysemu: Include missing 'exec/exec-all.h' header

2022-02-14 Thread Philippe Mathieu-Daudé via
excp_helper.c requires "exec/exec-all.h" for tlb_set_page_with_attrs() and misc_helper.c for tlb_flush(). Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/i386/tcg/sysemu/excp_helper.c | 1 + target/i386/tcg/sysemu/misc_helper.c | 1 + 2 files changed, 2 insertion

[PATCH v2 14/14] target: Use ArchCPU as interface to target CPU

2022-02-14 Thread Philippe Mathieu-Daudé via
ArchCPU is our interface with target-specific code. Use it as a forward-declared opaque pointer (abstract type), having its structure defined by each target. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/core/cpu.h | 4 ++-- include/qemu/typedefs.h | 1 + target/alpha/cpu.h | 2 +-

[PATCH v2 09/14] target: Include missing 'cpu.h'

2022-02-14 Thread Philippe Mathieu-Daudé via
These target-specific files use the target-specific CPU state but lack to include "cpu.h"; i.e.: ../target/riscv/pmp.h:61:23: error: unknown type name 'CPURISCVState' void pmpcfg_csr_write(CPURISCVState *env, uint32_t reg_index, ^ ../target/nios2/mmu.h:43:18:

[PATCH v2 12/14] target: Use CPUArchState as interface to target-specific CPU state

2022-02-14 Thread Philippe Mathieu-Daudé via
While CPUState is our interface with generic code, CPUArchState is our interface with target-specific code. Use CPUArchState as an abstract type, defined by each target. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- include/exec/poison.h | 2 -- include/hw/core/cpu.

[PATCH v2 13/14] target: Introduce and use OBJECT_DECLARE_CPU_TYPE() macro

2022-02-14 Thread Philippe Mathieu-Daudé via
Replace the boilerplate code to declare CPU QOM types and macros, and forward-declare the CPU instance type. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/core/cpu.h | 18 ++ target/alpha/cpu-qom.h | 3 +-- target/alpha/cpu.h | 2 -- target/arm/cpu-qo

[PATCH v2 10/14] target/hexagon: Add missing 'hw/core/cpu.h' include

2022-02-14 Thread Philippe Mathieu-Daudé via
HexagonCPU field parent_class is of type CPUClass, which is declared in "hw/core/cpu.h". Signed-off-by: Philippe Mathieu-Daudé --- target/hexagon/cpu.h | 1 + 1 file changed, 1 insertion(+) diff --git a/target/hexagon/cpu.h b/target/hexagon/cpu.h index 096aa2deb6..76cd1d5021 100644 --- a/target

[PATCH v5 02/16] configure: Allow passing extra Objective C compiler flags

2022-02-14 Thread Philippe Mathieu-Daudé via
We can pass C/CPP/LD flags via CFLAGS/CXXFLAGS/LDFLAGS environment variables, or via configure --extra-cflags / --extra-cxxflags / --extra-ldflags options. Provide similar behavior for Objective C: use existing flags from $OBJCFLAGS, or passed via --extra-objcflags. Signed-off-by: Philippe Mathieu

[PATCH v2 11/14] target: Use forward declared type instead of structure type

2022-02-14 Thread Philippe Mathieu-Daudé via
The CPU / CPU state are forward declared. $ git grep -E 'struct [A-Za-z]+CPU\ \*' target/arm/hvf_arm.h:16:void hvf_arm_set_cpu_features_from_host(struct ARMCPU *cpu); target/openrisc/cpu.h:234:int (*cpu_openrisc_map_address_code)(struct OpenRISCCPU *cpu, target/openrisc/cpu.h:238:

[PATCH v5 00/16] host: Support macOS 12

2022-02-14 Thread Philippe Mathieu-Daudé via
Few patches to be able to build QEMU on macOS 12 (Monterey). This basically consists of adapting deprecated APIs. CI job added to avoid bitrotting. Since v4: - Use MAC_OS_X_VERSION_MIN_REQUIRED definition (Akihiko) - Include patches from Akihiko Since v3: - Fix --enable-modules - Ignore #pragma

[PATCH v5 03/16] tests/fp/berkeley-testfloat-3: Ignore ignored #pragma directives

2022-02-14 Thread Philippe Mathieu-Daudé via
Since we already use -Wno-unknown-pragmas, we can also use -Wno-ignored-pragmas. This silences hundred of warnings using clang 13 on macOS Monterey: [409/771] Compiling C object tests/fp/libtestfloat.a.p/berkeley-testfloat-3_source_test_az_f128_rx.c.o ../tests/fp/berkeley-testfloat-3/source/t

[PATCH v5 06/16] hvf: Enable RDTSCP support

2022-02-14 Thread Philippe Mathieu-Daudé via
From: Cameron Esfahani Pass through RDPID and RDTSCP support in CPUID if host supports it. Correctly detect if CPU_BASED_TSC_OFFSET and CPU_BASED2_RDTSCP would be supported in primary and secondary processor-based VM-execution controls. Enable RDTSCP in secondary processor controls if RDTSCP sup

[PATCH v5 07/16] hvf: Make hvf_get_segments() / hvf_put_segments() local

2022-02-14 Thread Philippe Mathieu-Daudé via
Both hvf_get_segments/hvf_put_segments() functions are only used within x86hvf.c: do not declare them as public API. Reviewed-by: Roman Bolshakov Tested-by: Roman Bolshakov Signed-off-by: Philippe Mathieu-Daudé --- target/i386/hvf/x86hvf.c | 4 ++-- target/i386/hvf/x86hvf.h | 2 -- 2 files cha

[PATCH v5 04/16] hvf: Use standard CR0 and CR4 register definitions

2022-02-14 Thread Philippe Mathieu-Daudé via
From: Cameron Esfahani No need to have our own definitions of these registers. Signed-off-by: Cameron Esfahani Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé --- target/i386/hvf/vmx.h | 17 + target/i386/hvf/x86.c | 6 +++--- target/i386/

[PATCH v5 08/16] hvf: Remove deprecated hv_vcpu_flush() calls

2022-02-14 Thread Philippe Mathieu-Daudé via
When building on macOS 11 [*], we get: In file included from ../target/i386/hvf/hvf.c:59: ../target/i386/hvf/vmx.h:174:5: error: 'hv_vcpu_flush' is deprecated: first deprecated in macOS 11.0 - This API has no effect and always returns HV_UNSUPPORTED [-Werror,-Wdeprecated-declarations]

Re: [PATCH] hw/ide: implement ich6 ide controller support

2022-02-14 Thread Liav Albani
Hello BALATON, Thank you for helping keeping this patch noticeable to everyone :) I tried to reach out to John via a private email last Saturday (two days ago) so I don't "spam" the mailing list for no good reason. It might be that I should actually refrain from doing so and talk to the mainta

[PATCH v5 16/16] gitlab-ci: Support macOS 12 via cirrus-run

2022-02-14 Thread Philippe Mathieu-Daudé via
Add support for macOS 12 build on Cirrus-CI, similarly to commit 0e103a65ba1 ("gitlab: support for ... macOS 11 via cirrus-run"), but with the following differences: - Enable modules (configure --enable-modules) - Do not run softfloat3 tests (make check-softfloat) - Run Aarch64 qtests instead of

[PATCH v5 05/16] hvf: Fix OOB write in RDTSCP instruction decode

2022-02-14 Thread Philippe Mathieu-Daudé via
From: Cameron Esfahani A guest could craft a specific stream of instructions that will have QEMU write 0xF9 to inappropriate locations in memory. Add additional asserts to check for this. Generate a #UD if there are more than 14 prefix bytes. Found by Julian Stecklina Signed-off-by: Cameron

[PATCH v5 12/16] ui/cocoa: Remove allowedFileTypes restriction in SavePanel

2022-02-14 Thread Philippe Mathieu-Daudé via
setAllowedFileTypes is deprecated in macOS 12. Per Akihiko Odaki [*]: An image file, which is being chosen by the panel, can be a raw file and have a variety of file extensions and many are not covered by the provided list (e.g. "udf"). Other platforms like GTK can provide an option to op

Re: [RFC v4 20/21] vfio-user: migration support

2022-02-14 Thread John Johnson
> On Feb 11, 2022, at 5:31 AM, Thanos Makatos > wrote: > > >> -Original Message- >> From: Qemu-devel > bounces+thanos.makatos=nutanix@nongnu.org> On Behalf Of John >> Johnson >> Sent: 12 January 2022 00:44 >> To: qemu-devel@nongnu.org >> Subject: [RFC v4 20/21] vfio-user: migratio

Re: [PATCH v5 3/3] virtiofsd: Add support for FUSE_SYNCFS request without announce_submounts

2022-02-14 Thread Vivek Goyal
On Mon, Feb 14, 2022 at 01:27:22PM -0500, Vivek Goyal wrote: > On Mon, Feb 14, 2022 at 02:58:20PM +0100, Greg Kurz wrote: > > This adds the missing bits to support FUSE_SYNCFS in the case submounts > > aren't announced to the client. > > > > Iterate over all inodes and call syncfs() on the ones ma

[RFC PATCH 2/9] vdpa: Extract get geatures part from vhost_vdpa_get_max_queue_pairs

2022-02-14 Thread Eugenio Pérez
To know the device features is also needed for CVQ SVQ. Extract from vhost_vdpa_get_max_queue_pairs so we can reuse it. Report errno in case of failure getting them while we're at it. Signed-off-by: Eugenio Pérez --- net/vhost-vdpa.c | 30 -- 1 file changed, 20 inser

<    1   2   3   >