Re: [PATCH] target/ppc: Fix radix logging

2022-02-09 Thread Cédric Le Goater
On 2/3/22 15:21, Cédric Le Goater wrote: ppc_radix64_partition_scoped_xlate() logs the host page protection bits variable but it is uninitialized since it is set later in ppc_radix64_check_prot(). Remove the Fixes: Coverity CID 1468942 Signed-off-by: Cédric Le Goater Applied to ppc-7.0 (with

Re: [PATCH 00/11] target/ppc: powerpc_excp improvements [BookE] (6/n)

2022-02-09 Thread Cédric Le Goater
On 1/28/22 23:40, Fabiano Rosas wrote: This series handles the BookE exception code. Tested the following machines/CPUs: == bamboo == 440ep, 460ex, 440-xilinx-w-dfpu == sam460ex == 440ep, 460ex, 440-xilinx-w-dfpu == mpc8544ds == e500v1, e500v2 == ppce500 == e500mc, e5500, e6500 About the re

Re: [PATCH 00/11] target/ppc: powerpc_excp improvements [6xx] (7/n)

2022-02-09 Thread Cédric Le Goater
On 2/3/22 21:09, Fabiano Rosas wrote: This series handles the 6xx family: 603, 604, G2, G2LE, MPC5xx and MPC8xx. There is a patch upfront to move them all into the same POWERPC_EXCP_6xx, but otherwise the rest of the series is pretty much the same as I have done for the other CPUs. This was tes

Re: [PATCH] target/ppc: Remove 440x4 CPU

2022-02-09 Thread Cédric Le Goater
On 1/28/22 23:16, Fabiano Rosas wrote: This CPU was partially removed due to lack of support in 2017 by commit aef7796057 ("ppc: remove non implemented cpu models"). Signed-off-by: Fabiano Rosas Applied to ppc-7.0. Thanks, C.

Re: [PATCH qemu] spapr/vof: Install rom and nvram binaries

2022-02-09 Thread Cédric Le Goater
On 2/8/22 11:37, Alexey Kardashevskiy wrote: This installs VOF-related binaries (the firmware and the preformatted NVRAM) as those were left out when the VOF was submitted initially. Fixes: fc8c745d5015 ("spapr: Implement Open Firmware client interface") Signed-off-by: Alexey Kardashevskiy ---

Re: [PATCH] target/ppc: Remove PowerPC 601 CPUs

2022-02-09 Thread Cédric Le Goater
On 2/3/22 15:27, Cédric Le Goater wrote: The PowerPC 601 processor is the first generation of processors to implement the PowerPC architecture. It was designed as a bridge processor and also could execute most of the instructions of the previous POWER architecture. It was found on the first Macs

Re: [PATCH v2 00/10] target/ppc: powerpc_excp improvements [7xx] (8/n)

2022-02-09 Thread Cédric Le Goater
On 2/4/22 18:34, Fabiano Rosas wrote: This series handles the 7xx family: 740, 745, 750, 750cl, 750cx, 750fx, 750gx and 755. changes from v1: - add back sc 1 support for pegasos2. I have opened an issue to track this: https://gitlab.com/qemu-project/qemu/-/issues/859 v1: https://lists.nongn

Re: [PATCH] target/ppc: Change VSX instructions behavior to fill with zeros

2022-02-09 Thread Cédric Le Goater
On 2/4/22 19:19, Víctor Colombo wrote: ISA v3.1 changed some VSX instructions behavior by changing what the other words/doubleword in the result should contain when the result is only one word/doubleword. e.g. xsmaxdp operates on doubleword 0 and saves the result also in doubleword 0. Before, the

Re: [PATCH] hw/arm/armv7m: Handle disconnected clock inputs

2022-02-09 Thread Philippe Mathieu-Daudé via
On 8/2/22 18:16, Peter Maydell wrote: In the armv7m object, handle clock inputs that aren't connected. This is always an error for 'cpuclk'. For 'refclk' it is OK for this to be disconnected, but we need to handle it by not trying to connect a sourceless-clock to the systick device. This fixes a

Re: [PATCH] docs: rstfy confidential guest documentation

2022-02-09 Thread Cédric Le Goater
On 2/4/22 17:12, Cornelia Huck wrote: Also rstfy the documentation for AMD SEV, and link it. The documentation for PEF had been merged into the pseries doc, fix the reference. Signed-off-by: Cornelia Huck Applied to ppc-7.0. Thanks, C.

Re: [PATCH v5 0/2] Enable legacy LBR support for guest

2022-02-09 Thread Like Xu
Hi Weijiang, On 23/1/2022 12:11 am, Yang Weijiang wrote: KVM legacy LBR patches have been merged in kernel 5.12, this patchset is to expose the feature to guest from the perf capability MSR. Qemu can add LBR format in cpu option to achieve it, e.g., -cpu host,lbr-fmt=0x5, Some older Intel CPUs

Re: [PATCH 5/5] include: Move hardware version declarations to new qemu/hw-version.h

2022-02-09 Thread Philippe Mathieu-Daudé via
On 8/2/22 21:08, Peter Maydell wrote: The "hardware version" machinery (qemu_set_hw_version(), qemu_hw_version(), and the QEMU_HW_VERSION define) is used by fewer than 10 files. Move it out from osdep.h into a new qemu/hw-version.h. Signed-off-by: Peter Maydell --- include/qemu/hw-version.h

Re: [PATCH 0/5] include: Trim some fat from osdep.h

2022-02-09 Thread Philippe Mathieu-Daudé via
On 8/2/22 21:08, Peter Maydell wrote: The osdep.h header is included by every C file we compile, so it helps build times to keep it small. (As the comment at the top of the file notes, in an ideal world this header would contain only things that everybody needs and things where we need to apply a

Re: [PATCH 5/5] include: Move hardware version declarations to new qemu/hw-version.h

2022-02-09 Thread Peter Maydell
On Wed, 9 Feb 2022 at 09:20, Philippe Mathieu-Daudé wrote: > > On 8/2/22 21:08, Peter Maydell wrote: > > The "hardware version" machinery (qemu_set_hw_version(), > > qemu_hw_version(), and the QEMU_HW_VERSION define) is used by fewer > > than 10 files. Move it out from osdep.h into a new > > qemu

Re: [PATCH v2] Use long endian options for ppc64

2022-02-09 Thread Greg Kurz
On Tue, 8 Feb 2022 14:47:19 +0100 Greg Kurz wrote: > On Mon, 31 Jan 2022 10:17:14 +0100 > Miroslav Rezanina wrote: > > > GCC options pairs -mlittle/-mlittle-endian and -mbig/-mbig-endian are > > equivalent on ppc64 architecture. However, Clang supports only long > > version of the options. > >

Re: [PATCH] Add --with-branding-prefix and QEMU_BRANDING_PREFIX

2022-02-09 Thread Stefan Hajnoczi
On Tue, Feb 08, 2022 at 10:39:18PM +0200, Liviu Ionescu wrote: > > > > On 8 Feb 2022, at 21:58, Peter Maydell wrote: > > > > I've cc'd some people who might have an opinion on whether this > > something we want to add upstream. (Patch/thread below for context.) > > Sure. For a better understan

Re: [PATCH 5/5] include: Move hardware version declarations to new qemu/hw-version.h

2022-02-09 Thread Philippe Mathieu-Daudé via
On 9/2/22 10:25, Peter Maydell wrote: On Wed, 9 Feb 2022 at 09:20, Philippe Mathieu-Daudé wrote: On 8/2/22 21:08, Peter Maydell wrote: The "hardware version" machinery (qemu_set_hw_version(), qemu_hw_version(), and the QEMU_HW_VERSION define) is used by fewer than 10 files. Move it out from

Re: [PATCH v4 1/2] tpm: CRB: Use ram_device for "tpm-crb-cmd" region

2022-02-09 Thread Eric Auger
Hi Dave, On 2/8/22 6:03 PM, Dr. David Alan Gilbert wrote: > * Eric Auger (eric.au...@redhat.com) wrote: >> Representing the CRB cmd/response buffer as a standard >> RAM region causes some trouble when the device is used >> with VFIO. Indeed VFIO attempts to DMA_MAP this region >> as usual RAM but

Re: [PATCH] Add --with-branding-prefix and QEMU_BRANDING_PREFIX

2022-02-09 Thread Liviu Ionescu
> On 9 Feb 2022, at 11:57, Stefan Hajnoczi wrote: > > > Is the existing ./configure --with-pkgversion= option not enough? My understanding of --with-pkgversion=, based on the fact that in QEMU this string is appended to the version, was that it is a suffix that describes a specific version

[PATCH v2 2/8] tests/qemu-iotests: Improve the check for GNU sed

2022-02-09 Thread Thomas Huth
Instead of failing the iotests if GNU sed is not available (or skipping them completely in the check-block.sh script), it would be better to simply skip the bash-based tests, so that the python-based tests could still be run. Thus add the check for BusyBox sed to common.rc and mark the tests as "no

[PATCH v2 4/8] tests/qemu-iotests: Allow to run "./check -n" from the source directory, too

2022-02-09 Thread Thomas Huth
For better integration of the iotests into the meson build system, it would be very helpful to get the list of the tests in the "auto" group during the "configure" step already. However, "check -n -g auto" currently only works if the binaries have already been built. To fix this, skip the check for

[PATCH v2 0/8] Improve integration of iotests in the meson test harness

2022-02-09 Thread Thomas Huth
Though "make check-block" is currently already run via the meson test runner, it still looks like an oddball in the output of "make check" since the tests are still run separately via the check-block.sh script. It would be nicer if the iotests would show up like the other tests suites. For this we

[PATCH v2 6/8] tests: Do not treat the iotests as separate meson test target anymore

2022-02-09 Thread Thomas Huth
Now that we add the single iotests directly in meson.build, we do not have to separate the block suite from the other suits anymore. Signed-off-by: Thomas Huth --- meson.build| 6 +++--- scripts/mtest2make.py | 4 tests/Makefile.include | 9 + 3 files changed, 4 inserti

Re: [PATCH v4 1/2] tpm: CRB: Use ram_device for "tpm-crb-cmd" region

2022-02-09 Thread Eric Auger
Hi Peter, On 2/8/22 6:14 PM, Peter Maydell wrote: > On Tue, 8 Feb 2022 at 16:36, Alex Williamson > wrote: >> On Tue, 8 Feb 2022 16:01:48 + >> Peter Maydell wrote: >>> Well, it can if it likes, but "this is a RAM-backed MemoryRegion" >>> doesn't imply "this is really guest actual RAM RAM", s

[PATCH v2 3/8] tests/qemu-iotests/meson.build: Improve the indentation

2022-02-09 Thread Thomas Huth
By using subdir_done(), we can get rid of one level of indentation in this file. This will make it easier to add more conditions to skip the iotests in future patches. Reviewed-by: Hanna Reitz Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- tests/qemu-iotests/meson.build | 6

[PATCH v2 1/8] tests/qemu-iotests/testrunner: Allow parallel test invocations

2022-02-09 Thread Thomas Huth
If multiple tests run in parallel, they must use unique file names for the test output. Suggested-by: Hanna Reitz Signed-off-by: Thomas Huth --- tests/qemu-iotests/testrunner.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/testrunner.py b/tests/qemu-iot

[PATCH v2 7/8] tests/qemu-iotests/testrunner: Print diff to stderr in TAP mode

2022-02-09 Thread Thomas Huth
When running in TAP mode, stdout is reserved for the TAP protocol. To see the "diff" of the failed test, we have to print it to stderr instead. Signed-off-by: Thomas Huth --- tests/qemu-iotests/testrunner.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotes

[PATCH v2 8/8] tests: Remove check-block.sh

2022-02-09 Thread Thomas Huth
Now that the iotests are added by the meson.build file already, we do not need the check-block.sh wrapper script anymore. Signed-off-by: Thomas Huth --- tests/check-block.sh | 73 1 file changed, 73 deletions(-) delete mode 100755 tests/check-block.s

[PATCH v2 5/8] tests/qemu-iotests/meson.build: Call the 'check' script directly

2022-02-09 Thread Thomas Huth
We can get a nicer progress indication if we add the iotests individually via the 'check' script instead of going through the check-block.sh wrapper. For this, we have to add some of the sanity checks that have originally been done in the tests/check-block.sh script (whether "bash" is available or

Re: [PATCH 0/6] target/arm: -cpu host/max KVM and HVF fixes

2022-02-09 Thread Andrew Jones
On Fri, Feb 04, 2022 at 04:55:00PM +, Peter Maydell wrote: > This patchset fixes various minor bugs in KVM and HVF > -cpu host and -cpu max: > > (1) KVM -cpu max was incorrectly adding a 'sve-max-vq' property > that wouldn't work and which doesn't exist in KVM -cpu host > > (2) HVF -cpu max w

[PATCH 2/5] crypto: distinguish between main loop and I/O in block_crypto_amend_options_generic_luks

2022-02-09 Thread Emanuele Giuseppe Esposito
block_crypto_amend_options_generic_luks uses the block layer permission API, therefore it should be called with the BQL held. However, the same function is being called by two BlockDriver callbacks: bdrv_amend_options (under BQL) and bdrv_co_amend (I/O). The latter is I/O because it is invoked by

[PATCH 5/5] block: move BQL logic of bdrv_co_invalidate_cache in bdrv_activate

2022-02-09 Thread Emanuele Giuseppe Esposito
Split bdrv_co_invalidate cache in two: the Global State (under BQL) code that takes care of permissions and running GS callbacks, and leave only the I/O code (->bdrv_co_invalidate_cache) running in the I/O coroutine. The only side effect is that bdrv_co_invalidate_cache is not recursive anymore, a

[PATCH 0/5] block layer: permission API refactoring in preparation

2022-02-09 Thread Emanuele Giuseppe Esposito
This serie aims to refactoring and fixing permission API related bugs that came up in the serie "block layer: split block APIs in global state and I/O". In that serie, we are splitting all block layer headers in Global State (GS) APIs, holding always the BQL and running in the main loop, and I/O ru

[PATCH 3/5] block: introduce bdrv_activate

2022-02-09 Thread Emanuele Giuseppe Esposito
This function is currently just a wrapper for bdrv_invalidate_cache(), but in future will contain the code of bdrv_co_invalidate_cache() that has to always be protected by BQL, and leave the rest in the I/O coroutine. Replace all bdrv_invalidate_cache() invokations with bdrv_activate(). Signed-of

[PATCH 1/5] crypto: perform permission checks under BQL

2022-02-09 Thread Emanuele Giuseppe Esposito
Move the permission API calls into driver-specific callbacks that always run under BQL. In this case, bdrv_crypto_luks needs to perform permission checks before and after qcrypto_block_amend_options(). The problem is that the caller, block_crypto_amend_options_generic_luks(), can also run in I/O fr

Re: [RFC 0/8] ioregionfd introduction

2022-02-09 Thread Stefan Hajnoczi
On Mon, Feb 07, 2022 at 11:22:14PM -0800, Elena Ufimtseva wrote: > This patchset is an RFC version for the ioregionfd implementation > in QEMU. The kernel patches are to be posted with some fixes as a v4. Hi Elena, I will review this on Monday. Thanks! Stefan signature.asc Description: PGP sign

Re: [PATCH 0/3] hw: aspeed_gpio: Model new interface for the AST2600

2022-02-09 Thread Andrew Jeffery
On Tue, 8 Feb 2022, at 01:34, Andrew Jeffery wrote: > Hello, > > This series adds support for a new register interface supported by the > Aspeed GPIO controller, present in at least the AST2600. > > The new interface is a single register implementing an indirect command > protocol that allows us

[PATCH] tools/virtiofsd: Add rseq syscall to the seccomp allowlist

2022-02-09 Thread christian . ehrhardt
From: Christian Ehrhardt The virtiofsd currently crashes when used with glibc 2.35. That is due to the rseq system call being added to every thread creation [1][2]. [1]: https://www.efficios.com/blog/2019/02/08/linux-restartable-sequences/ [2]: https://sourceware.org/pipermail/libc-alpha/2022-Fe

[PATCH 4/5] block: rename bdrv_invalidate_cache_all, blk_invalidate_cache and test_sync_op_invalidate_cache

2022-02-09 Thread Emanuele Giuseppe Esposito
Following the bdrv_activate renaming, change also the name of the respective callers. bdrv_invalidate_cache_all -> bdrv_activate_all blk_invalidate_cache -> blk_activate test_sync_op_invalidate_cache -> test_sync_op_activate No functional change intended. Signed-off-by: Emanuele Giuseppe Esposit

[RFC PATCH] tcg/optimize: only read val after const check

2022-02-09 Thread Alex Bennée
valgrind pointed out that arg_info()->val can be undefined which will be the case if the arguments are not constant. The ordering of the checks will have ensured we never relied on an undefined value but for the sake of completeness re-order the code to be clear. Signed-off-by: Alex Bennée --- t

Re: [PATCH v2 2/4] virtio-iommu: Default to bypass during boot

2022-02-09 Thread Cornelia Huck
On Tue, Feb 08 2022, "Michael S. Tsirkin" wrote: > On Tue, Feb 08, 2022 at 06:42:57PM +0100, Cornelia Huck wrote: >> On Thu, Jan 27 2022, Jean-Philippe Brucker wrote: >> >> > @@ -988,9 +1025,9 @@ static void virtio_iommu_device_realize(DeviceState >> > *dev, Error **errp) >> > virtio_add_

[RFC PATCH] linux-user: trap internal SIGABRT's

2022-02-09 Thread Alex Bennée
linux-user wants to trap all signals in case they are related to the guest. This however results in less than helpful core dumps when the error is internal to QEMU. We can detect when an assert failure is in progress by examining __glib_assert_msg and fall through to cpu_abort() which will pretty p

Re: [PATCH] ui/cocoa: Set UI information

2022-02-09 Thread Akihiko Odaki
On Wed, Feb 9, 2022 at 3:07 AM Peter Maydell wrote: > > On Sat, 5 Feb 2022 at 02:06, Akihiko Odaki wrote: > > > > On Sat, Feb 5, 2022 at 1:19 AM Peter Maydell > > wrote > > > > (1) A question for Akihiko: > > > Are all the cocoa calls we make in updateUIInfo safe to > > > make from a non-UI thr

Re: [PATCH] ui/cocoa: Add clipboard support

2022-02-09 Thread Akihiko Odaki
On Wed, Feb 9, 2022 at 2:54 AM Peter Maydell wrote: > > On Wed, 16 Jun 2021 at 15:20, Akihiko Odaki wrote: > > > > Signed-off-by: Akihiko Odaki > > Hi Akihiko -- I have a similar question here to the other > patch about doing things not on the Cocoa UI thread... > > > +static void cocoa_clipboar

Re: [PATCH v2 2/4] virtio-iommu: Default to bypass during boot

2022-02-09 Thread Eric Auger
Hi, On 2/9/22 12:10 PM, Cornelia Huck wrote: > On Tue, Feb 08 2022, "Michael S. Tsirkin" wrote: > >> On Tue, Feb 08, 2022 at 06:42:57PM +0100, Cornelia Huck wrote: >>> On Thu, Jan 27 2022, Jean-Philippe Brucker wrote: >>> @@ -988,9 +1025,9 @@ static void virtio_iommu_device_realize(DeviceSt

Re: [PATCH] Add --with-branding-prefix and QEMU_BRANDING_PREFIX

2022-02-09 Thread Peter Maydell
On Wed, 9 Feb 2022 at 10:13, Liviu Ionescu wrote: > > On 9 Feb 2022, at 11:57, Stefan Hajnoczi wrote: > > > > > > Is the existing ./configure --with-pkgversion= option not enough? > > My understanding of --with-pkgversion=, based on the fact that in QEMU this > string is appended to the version,

Re: [RFC PATCH] linux-user: trap internal SIGABRT's

2022-02-09 Thread Peter Maydell
On Wed, 9 Feb 2022 at 11:35, Alex Bennée wrote: > linux-user wants to trap all signals in case they are related to the > guest. This however results in less than helpful core dumps when the > error is internal to QEMU. We can detect when an assert failure is in > progress by examining __glib_asser

Re: [RFC PATCH] tcg/optimize: only read val after const check

2022-02-09 Thread Philippe Mathieu-Daudé via
On 9/2/22 12:21, Alex Bennée wrote: valgrind pointed out that arg_info()->val can be undefined which will be the case if the arguments are not constant. The ordering of the checks will have ensured we never relied on an undefined value but for the sake of completeness re-order the code to be clea

Re: [PATCH] Add --with-branding-prefix and QEMU_BRANDING_PREFIX

2022-02-09 Thread Liviu Ionescu
> On 9 Feb 2022, at 13:30, Peter Maydell wrote: > > gcc doesn't prepend the pkgversion string to the greeting. ... > ... and 'gcc --version' prints the version as: > gcc (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0 Right, strictly speaking, GCC prints the program name, then the greeting message, the

Re: [PATCH] Add --with-branding-prefix and QEMU_BRANDING_PREFIX

2022-02-09 Thread Daniel P . Berrangé
On Wed, Feb 09, 2022 at 12:13:02PM +0200, Liviu Ionescu wrote: > > > > On 9 Feb 2022, at 11:57, Stefan Hajnoczi wrote: > > > > > > Is the existing ./configure --with-pkgversion= option not enough? > > My understanding of --with-pkgversion=, based on the fact that in QEMU this > string is app

Re: [RFC PATCH 0/3] tests/tcg/ppc64le: fix the build of TCG tests with Clang

2022-02-09 Thread Cédric Le Goater
Hello Matheus, [ Adding Miroslav ] On 2/8/22 21:31, matheus.fe...@eldorado.org.br wrote: From: Matheus Ferst Based-on: https://lists.gnu.org/archive/html/qemu-devel/2022-01/msg06506.html As the configuration scripts used -mbig and -mlittle, building PPC tests with Clang was silently skipped.

Re: [PATCH v4] 9pfs: Fix segfault in do_readdir_many caused by struct dirent overread

2022-02-09 Thread Christian Schoenebeck
On Sonntag, 6. Februar 2022 02:34:19 CET Vitaly Chikunov wrote: > `struct dirent' returned from readdir(3) could be shorter (or longer) > than `sizeof(struct dirent)', thus memcpy of sizeof length will overread > into unallocated page causing SIGSEGV. Example stack trace: > > #0 0x559ebe

Re: [PATCH] MAINTAINERS: python - remove ehabkost and add bleal

2022-02-09 Thread Beraldo Leal
On Mon, Feb 07, 2022 at 07:05:25PM -0500, John Snow wrote: > Eduardo Habkost has left Red Hat and has other daily responsibilities to > attend to. In order to stop spamming him on every series, remove him as > "Reviewer" for the python/ library dir and add Beraldo Leal instead. > > For the "python

Re: [PATCH v10 3/3] target/ppc: EBB exception implementation

2022-02-09 Thread Daniel Henrique Barboza
On 2/8/22 20:20, Fabiano Rosas wrote: Daniel Henrique Barboza writes: This patch adds the EBB exception support that are triggered by Performance Monitor alerts. This happens when a Performance Monitor alert occurs and MMCR0_EBE, BESCR_PME and BESCR_GE are set. A 'ebb_excp_enabled' helper

[PATCH v3 1/2] hvf: arm: Use macros for sysreg shift/masking

2022-02-09 Thread Alexander Graf
We are parsing the syndrome field for sysregs in multiple places across the hvf code, but repeat shift/mask operations with hard coded constants every time. This is an error prone approach and makes it harder to reason about the correctness of these operations. Let's introduce macros that allow us

Re: [PATCH 0/6] target/arm: -cpu host/max KVM and HVF fixes

2022-02-09 Thread Alexander Graf
On 04.02.22 17:55, Peter Maydell wrote: This patchset fixes various minor bugs in KVM and HVF -cpu host and -cpu max: (1) KVM -cpu max was incorrectly adding a 'sve-max-vq' property that wouldn't work and which doesn't exist in KVM -cpu host (2) HVF -cpu max was using all the TCG ID fields an

[PATCH 1/1] virtio: fix feature negotiation for ACCESS_PLATFORM

2022-02-09 Thread Halil Pasic
Unlike most virtio features ACCESS_PLATFORM is considered mandatory by QEMU, i.e. the driver must accept it if offered by the device. The virtio specification says that the driver SHOULD accept the ACCESS_PLATFORM feature if offered, and that the device MAY fail to operate if ACCESS_PLATFORM was of

[PATCH v3 2/2] hvf: arm: Handle unknown ID registers as RES0

2022-02-09 Thread Alexander Graf
Recent Linux versions added support to read ID_AA64ISAR2_EL1. On M1, those reads trap into QEMU which handles them as faults. However, AArch64 ID registers should always read as RES0. Let's handle them accordingly. This fixes booting Linux 5.17 guests. Cc: qemu-sta...@nongnu.org Reported-by: Iva

downstream extensions

2022-02-09 Thread Vladimir Sementsov-Ogievskiy
Hi all! We declare a kind of __com.redhat_drive-mirror syntax for downstream extensions of QAPI. That's inconvenient: Assume I want to merge now my keep-dirty option for Qcow2 driver "[PATCH v2 0/2] qcow2: add keep-dirty open option" to our downstream. To avoid possible conflicts with upstre

Re: [PATCH] tools/virtiofsd: Add rseq syscall to the seccomp allowlist

2022-02-09 Thread Dr. David Alan Gilbert
* christian.ehrha...@canonical.com (christian.ehrha...@canonical.com) wrote: > From: Christian Ehrhardt > > The virtiofsd currently crashes when used with glibc 2.35. > That is due to the rseq system call being added to every thread > creation [1][2]. > > [1]: https://www.efficios.com/blog/2019/

Re: [PATCH] Python: discourage direct setup.py install

2022-02-09 Thread Beraldo Leal
On Mon, Feb 07, 2022 at 04:30:39PM -0500, John Snow wrote: > When invoking setup.py directly, the default behavior for 'install' is > to run the bdist_egg installation hook, which is ... actually deprecated > by setuptools. It doesn't seem to work quite right anymore. > > By contrast, 'pip install

Re: [PATCH v2 2/4] virtio-iommu: Default to bypass during boot

2022-02-09 Thread Cornelia Huck
On Wed, Feb 09 2022, Eric Auger wrote: > Hi, > > On 2/9/22 12:10 PM, Cornelia Huck wrote: >> On Tue, Feb 08 2022, "Michael S. Tsirkin" wrote: >> >>> On Tue, Feb 08, 2022 at 06:42:57PM +0100, Cornelia Huck wrote: On Thu, Jan 27 2022, Jean-Philippe Brucker wrote: > @@ -988,9 +

Re: [RFC PATCH] linux-user: trap internal SIGABRT's

2022-02-09 Thread Alex Bennée
Peter Maydell writes: > On Wed, 9 Feb 2022 at 11:35, Alex Bennée wrote: >> linux-user wants to trap all signals in case they are related to the >> guest. This however results in less than helpful core dumps when the >> error is internal to QEMU. We can detect when an assert failure is in >> pr

Re: [PATCH v5 09/11] 9p: darwin: Implement compatibility for mknodat

2022-02-09 Thread Akihiko Odaki
On Wed, Feb 9, 2022 at 7:57 AM Will Cohen wrote: > > On Tue, Feb 8, 2022 at 2:49 PM Christian Schoenebeck > wrote: >> >> On Dienstag, 8. Februar 2022 19:28:21 CET Christian Schoenebeck wrote: >> > On Dienstag, 8. Februar 2022 19:04:31 CET Will Cohen wrote: >> > > On Tue, Feb 8, 2022 at 11:19 AM

Re: [RFC PATCH] linux-user: trap internal SIGABRT's

2022-02-09 Thread Peter Maydell
On Wed, 9 Feb 2022 at 13:23, Alex Bennée wrote: > > > Peter Maydell writes: > > > On Wed, 9 Feb 2022 at 11:35, Alex Bennée wrote: > >> linux-user wants to trap all signals in case they are related to the > >> guest. This however results in less than helpful core dumps when the > >> error is inte

Re: [PATCH v8 2/3] qapi/monitor: refactor set/expire_password with enums

2022-02-09 Thread Markus Armbruster
Fabian Ebner writes: > From: Stefan Reiter > > 'protocol' and 'connected' are better suited as enums than as strings, > make use of that. No functional change intended. > > Suggested-by: Markus Armbruster > Signed-off-by: Stefan Reiter > [FE: update "Since: " from 6.2 to 7.0 > put 'keep'

Re: [PATCH] Python: discourage direct setup.py install

2022-02-09 Thread Peter Maydell
On Mon, 7 Feb 2022 at 21:34, John Snow wrote: > > When invoking setup.py directly, the default behavior for 'install' is > to run the bdist_egg installation hook, which is ... actually deprecated > by setuptools. It doesn't seem to work quite right anymore. > > By contrast, 'pip install' will invo

[PULL 5/7] iotests/281: Test lingering timers

2022-02-09 Thread Vladimir Sementsov-Ogievskiy
From: Hanna Reitz Prior to "block/nbd: Delete reconnect delay timer when done" and "block/nbd: Delete open timer when done", both of those timers would remain scheduled even after successfully (re-)connecting to the server, and they would not even be deleted when the BDS is deleted. This test co

[PULL 1/7] block/nbd: Delete reconnect delay timer when done

2022-02-09 Thread Vladimir Sementsov-Ogievskiy
From: Hanna Reitz We start the reconnect delay timer to cancel the reconnection attempt after a while. Once nbd_co_do_establish_connection() has returned, this attempt is over, and we no longer need the timer. Delete it before returning from nbd_reconnect_attempt(), so that it does not persist

[PULL 0/7] nbd: handle AioContext change correctly

2022-02-09 Thread Vladimir Sementsov-Ogievskiy
The following changes since commit 0a301624c2f4ced3331ffd5bce85b4274fe132af: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20220208' into staging (2022-02-08 11:40:08 +) are available in the Git repository at: https://src.openvz.org/scm/~vsementsov/qemu.git tags/pu

[PULL 2/7] block/nbd: Delete open timer when done

2022-02-09 Thread Vladimir Sementsov-Ogievskiy
From: Hanna Reitz We start the open timer to cancel the connection attempt after a while. Once nbd_do_establish_connection() has returned, the attempt is over, and we no longer need the timer. Delete it before returning from nbd_open(), so that it does not persist for longer. It has no use afte

Re: [PATCH 5/5] include: Move hardware version declarations to new qemu/hw-version.h

2022-02-09 Thread Peter Maydell
On Wed, 9 Feb 2022 at 10:10, Philippe Mathieu-Daudé wrote: > On 9/2/22 10:25, Peter Maydell wrote: > > On Wed, 9 Feb 2022 at 09:20, Philippe Mathieu-Daudé wrote: > > I'm not completely convinced that (a) we have a clear idea of > > what of our APIs are legacy and what are not or (b) that we could

[PULL 24/28] tests/plugins: add instruction matching to libinsn.so

2022-02-09 Thread Alex Bennée
This adds simple instruction matching to the libinsn.so plugin which is useful for examining the execution distance between instructions. For example to track how often we flush in ARM due to TLB updates: -plugin ./tests/plugin/libinsn.so,match=tlbi which leads to output like this: 0xffc

[PULL 6/7] block/nbd: Move s->ioc on AioContext change

2022-02-09 Thread Vladimir Sementsov-Ogievskiy
From: Hanna Reitz s->ioc must always be attached to the NBD node's AioContext. If that context changes, s->ioc must be attached to the new context. Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2033626 Reviewed-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Hanna Reitz --- block/nbd.

[PULL 01/28] tests/Makefile.include: clean-up old code

2022-02-09 Thread Alex Bennée
This is no longer needed since a2ce7dbd91 ("meson: convert tests/qtest to meson", 2020-08-21) Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20220204204335.1689602-2-alex.ben...@linaro.org> diff --git a/tests/Makefile.include b/tests/Makefile.include index 9157a57b1

[PULL 08/28] drop libxml2 checks since libxml is not actually used (for parallels)

2022-02-09 Thread Alex Bennée
From: Michael Tokarev For a long time, we assumed that libxml2 is necessary for parallels block format support (block/parallels*). However, this format actually does not use libxml [*]. Since this is the only user of libxml2 in whole QEMU tree, we can drop all libxml2 checks and dependencies too.

[PULL 7/7] iotests/281: Let NBD connection yield in iothread

2022-02-09 Thread Vladimir Sementsov-Ogievskiy
From: Hanna Reitz Put an NBD block device into an I/O thread, and then read data from it, hoping that the NBD connection will yield during that read. When it does, the coroutine must be reentered in the block device's I/O thread, which will only happen if the NBD block driver attaches the connec

[PULL 02/28] tests/qtest: enable more vhost-user tests by default

2022-02-09 Thread Alex Bennée
If this starts causing failures again we should probably fix that. Signed-off-by: Alex Bennée Tested-by: Thomas Huth Message-Id: <20220204204335.1689602-3-alex.ben...@linaro.org> diff --git a/tests/qtest/vhost-user-test.c b/tests/qtest/vhost-user-test.c index 3d6337fb5c..2a4568cd7d 100644 --- a

[PULL 21/28] plugins: add helper functions for coverage plugins

2022-02-09 Thread Alex Bennée
From: Ivanov Arkady Which provide information about: - start_code. - end_code. - entry. - path to the executable binary. Signed-off-by: Ivanov Arkady Message-Id: <163491883461.304355.8210754161847179432.stgit@pc-System-Product-Name> [AJB: reword title, better descriptions, defaults, rm export,

[PULL 06/28] gitmodules: Correct libvirt-ci submodule URL

2022-02-09 Thread Alex Bennée
From: Philippe Mathieu-Daudé Correct the libvirt-ci repository URL to avoid this warning when cloning / refreshing the submodule: warning: redirecting to https://gitlab.com/libvirt/libvirt-ci.git/ Fixes: 4ebb040f1fd ("tests: integrate lcitool for generating build env manifests") Reviewed-by:

[PULL 4/7] iotests.py: Add QemuStorageDaemon class

2022-02-09 Thread Vladimir Sementsov-Ogievskiy
From: Hanna Reitz This is a rather simple class that allows creating a QSD instance running in the background and stopping it when no longer needed. The __del__ handler is a safety net for when something goes so wrong in a test that e.g. the tearDown() method is not called (e.g. setUp() launches

Re: [PATCH v5 09/11] 9p: darwin: Implement compatibility for mknodat

2022-02-09 Thread Christian Schoenebeck
On Dienstag, 8. Februar 2022 23:57:32 CET Will Cohen wrote: > > On a second thought: this case a bit special. Are we worried that > > pthread_fchdir_np() is "not yet" available on macOS, or "no longer" > > available. > > Probably both, right? > > > > So maybe it would make sense to replace the API

[PULL 26/28] plugins: move reset of plugin data to tb_start

2022-02-09 Thread Alex Bennée
We can't always guarantee we get to the end of a translator loop. Although this can happen for a variety of reasons it does happen more often on x86 system emulation when an instruction spans across to an un-faulted page. This caused confusion of the instruction tracking data resulting in apparent

[PULL 03/28] Makefile: also remove .gcno files when cleaning

2022-02-09 Thread Alex Bennée
Left over .gcno files from old builds can really confuse gcov and the user expects a clean slate after "make clean". Make clean mean clean. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20220204204335.1689602-4-alex.ben...@linaro.org>

Re: [PATCH v8 1/3] monitor/hmp: add support for flag argument with value

2022-02-09 Thread Markus Armbruster
Fabian Ebner writes: > From: Stefan Reiter > > Adds support for the "-xV" parameter type, where "-x" denotes a flag > name and the "V" suffix indicates that this flag is supposed to take > an arbitrary string parameter. > > These parameters are always optional, the entry in the qdict will be > o

[PULL 13/28] gitlab: fall back to commit hash in qemu-setup filename

2022-02-09 Thread Alex Bennée
From: Stefan Hajnoczi Personal repos may not have release tags (v6.0.0, v6.1.0, etc) and this causes cross_system_build_job to fail when pretty-printing a unique qemu-setup-*.exe name: version="$(git describe --match v[0-9]*)"; ^^ fails ^^^ mv -v qemu-setup*.exe

[PULL 00/28] testing and plugin updates

2022-02-09 Thread Alex Bennée
The following changes since commit 0a301624c2f4ced3331ffd5bce85b4274fe132af: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20220208' into staging (2022-02-08 11:40:08 +) are available in the Git repository at: https://github.com/stsquad/qemu.git tags/pull-testing-a

[PULL 3/7] block/nbd: Assert there are no timers when closed

2022-02-09 Thread Vladimir Sementsov-Ogievskiy
From: Hanna Reitz Our two timers must not remain armed beyond nbd_clear_bdrvstate(), or they will access freed data when they fire. This patch is separate from the patches that actually fix the issue (HEAD^^ and HEAD^) so that you can run the associated regression iotest (281) on a configuration

[PULL 11/28] tests/lcitool: Install libibumad to cover RDMA on Debian based distros

2022-02-09 Thread Alex Bennée
From: Philippe Mathieu-Daudé On Debian we also need libibumad to enable RDMA: $ ../configure --enable-rdma ERROR: OpenFabrics librdmacm/libibverbs/libibumad not present. Your options: (1) Fast: Install infiniband packages (devel) from your distro. (2) Cleane

[PULL 07/28] tests/lcitool: Include local qemu.yml when refreshing cirrus-ci files

2022-02-09 Thread Alex Bennée
From: Philippe Mathieu-Daudé The script only include the local qemu.yml for Dockerfiles. Since we want to keep the Cirrus-CI generated files in sync, also use the --data-dir option in generate_cirrus(). Fixes: c45a540f4bd (".gitlab-ci.d/cirrus: auto-generate variables with lcitool") Reported-by:

Re: Call for GSoC and Outreachy project ideas for summer 2022

2022-02-09 Thread Alexander Graf
On 28.01.22 16:47, Stefan Hajnoczi wrote: Dear QEMU, KVM, and rust-vmm communities, QEMU will apply for Google Summer of Code 2022 (https://summerofcode.withgoogle.com/) and has been accepted into Outreachy May-August 2022 (https://www.outreachy.org/). You can now submit internship project ideas

[PULL 17/28] docs: remove references to TCG tracing

2022-02-09 Thread Alex Bennée
Users wanting this sort of functionality should turn to TCG plugins instead. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Cc: Luis Vilanova Cc: Stefan Hajnoczi Message-Id: <20220204204335.1689602-18-alex.ben...@linaro.org> diff --git a/docs/about/removed-features.rst b/docs/about

[PULL 16/28] tests/tcg/sh4: disable another unreliable test

2022-02-09 Thread Alex Bennée
Given the other failures it looks like general thread handling on sh4 is sketchy. It fails more often on CI than on my developer machine though. See https://gitlab.com/qemu-project/qemu/-/issues/856 for more details. Signed-off-by: Alex Bennée Cc: Yoshinori Sato Cc: Laurent Vivier Tested-by: Ph

[PULL 20/28] tracing: excise the tcg related from tracetool

2022-02-09 Thread Alex Bennée
Now we have no TCG trace events and no longer handle them in the code we can remove the handling from the tracetool to generate them. vcpu tracing is still available although the existing syscall event is an exercise in redundancy (plugins and -strace can also get the information). Signed-off-by:

Re: [PATCH v5 09/11] 9p: darwin: Implement compatibility for mknodat

2022-02-09 Thread Christian Schoenebeck
On Mittwoch, 9. Februar 2022 14:33:25 CET Akihiko Odaki wrote: > > I like the idea of switching it to __attribute__((weak)). I should note > > that I'm not sure that I can actually fully test this out since I'm > > getting stuck with the linker noting my undefined fake function during > > the build

[PULL 04/28] .gitignore: add .gcov pattern

2022-02-09 Thread Alex Bennée
The gcovr tool is very messy and can leave a lot of crap in the source tree even when using build directories. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20220204204335.1689602-5-alex.ben...@linaro.org> diff --git a/.gitignore b/.

[PULL 18/28] tracing: remove TCG memory access tracing

2022-02-09 Thread Alex Bennée
If you really want to trace all memory operations TCG plugins gives you a more flexible interface for doing so. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Cc: Luis Vilanova Cc: Stefan Hajnoczi Message-Id: <20220204204335.1689602-19-alex.ben..

Re: [PATCH v8 3/3] qapi/monitor: allow VNC display id in set/expire_password

2022-02-09 Thread Markus Armbruster
Fabian Ebner writes: > From: Stefan Reiter > > It is possible to specify more than one VNC server on the command line, > either with an explicit ID or the auto-generated ones à la "default", > "vnc2", "vnc3", ... > > It is not possible to change the password on one of these extra VNC > displays

Re: [Virtio-fs] [PATCH v5 0/9] virtiofsd: Add support for file security context at file creation

2022-02-09 Thread Vivek Goyal
On Wed, Feb 09, 2022 at 11:24:29AM +0100, German Maglione wrote: > On Tue, Feb 8, 2022 at 11:44 PM Daniel P. Berrangé > wrote: > > > On Mon, Feb 07, 2022 at 04:19:38PM -0500, Vivek Goyal wrote: > > > On Mon, Feb 07, 2022 at 01:05:16PM +, Daniel P. Berrangé wrote: > > > > On Wed, Feb 02, 2022

[PULL 22/28] contrib/plugins: add a drcov plugin

2022-02-09 Thread Alex Bennée
From: Ivanov Arkady This patch adds the ability to generate files in drcov format. Primary goal this script is to have coverage logfiles thatwork in Lighthouse. Signed-off-by: Ivanov Arkady Message-Id: <163491884553.304355.13246023070235438959.stgit@pc-System-Product-Name> [AJB: use g_ptr_arra

  1   2   3   >