[PATCH v6 3/8] tcg/sparc: Add scratch argument to tcg_out_movi_int

2022-02-08 Thread Richard Henderson
This will allow us to control exactly what scratch register is used for loading the constant. Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c.inc | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/tcg/sparc/tcg-target.c.inc b/tcg/sparc/tcg-target.c.in

Re: [PATCH v9 00/23] QEMU RISC-V AIA support

2022-02-08 Thread Anup Patel
On Tue, Feb 8, 2022 at 12:27 PM Alistair Francis wrote: > > On Tue, Feb 8, 2022 at 2:16 PM Alistair Francis wrote: > > > > On Sat, Feb 5, 2022 at 3:47 AM Anup Patel wrote: > > > > > > From: Anup Patel > > > > > > The advanced interrupt architecture (AIA) extends the per-HART local > > > interru

[PATCH 4/5] linux-user: Move sparc/host-signal.h to sparc64/host-signal.h

2022-02-08 Thread Richard Henderson
We do not support sparc32 as a host, so there's no point in sparc64 redirecting to sparc. Signed-off-by: Richard Henderson --- linux-user/include/host/sparc/host-signal.h | 71 --- linux-user/include/host/sparc64/host-signal.h | 64 - 2 files changed, 63 inserti

[PATCH v6 6/8] tcg/sparc: Use the constant pool for 64-bit constants

2022-02-08 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c.inc | 15 +++ 1 file changed, 15 insertions(+) diff --git a/tcg/sparc/tcg-target.c.inc b/tcg/sparc/tcg-target.c.inc index ae809c9941..21b0dd6734 100644 --- a/tcg/sparc/tcg-target.c.inc +++ b/tcg/s

[PATCH v6 7/8] tcg/sparc: Add tcg_out_jmpl_const for better tail calls

2022-02-08 Thread Richard Henderson
Due to mapping changes, we now rarely place the code_gen_buffer near the main executable. Which means that direct calls will now rarely be in range. So, always use indirect calls for tail calls, which allows us to avoid clobbering %o7, and therefore we need not save and restore it. Reviewed-by:

Re: [PATCH 4/5] vduse-blk: Add vduse-blk resize support

2022-02-08 Thread Yongji Xie
On Mon, Feb 7, 2022 at 10:18 PM Stefan Hajnoczi wrote: > > On Tue, Jan 25, 2022 at 09:17:59PM +0800, Xie Yongji wrote: > > To support block resize, this uses vduse_dev_update_config() > > to update the capacity field in configuration space and inject > > config interrupt on the block resize callba

Re: [PATCH v12 1/5] accel/kvm/kvm-all: refactor per-vcpu dirty ring reaping

2022-02-08 Thread Peter Xu
On Mon, Jan 24, 2022 at 10:10:36PM +0800, huang...@chinatelecom.cn wrote: > @@ -2956,7 +2959,7 @@ int kvm_cpu_exec(CPUState *cpu) > */ > trace_kvm_dirty_ring_full(cpu->cpu_index); > qemu_mutex_lock_iothread(); > -kvm_dirty_ring_reap(kvm_state); >

Re: [PATCH 08/11] mos6522: add "info via" HMP command for debugging

2022-02-08 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 7/2/22 20:34, Peter Maydell wrote: >> On Thu, 27 Jan 2022 at 21:03, Mark Cave-Ayland >> wrote: >>> >>> This displays detailed information about the device registers and timers to >>> aid >>> debugging problems with timers and interrupts. >>> >>> Signed-off-by

[RFC 1/8] ioregionfd: introduce a syscall and memory API

2022-02-08 Thread Elena Ufimtseva
Signed-off-by: Elena Ufimtseva --- include/exec/memory.h | 50 +++ include/sysemu/kvm.h | 15 + linux-headers/linux/kvm.h | 25 accel/kvm/kvm-all.c | 132 ++ accel/stubs/kvm-stub.c| 1 + 5 files changed, 223 inse

[PATCH 0/5] linux-user: Fixes for sparc64 host

2022-02-08 Thread Richard Henderson
Brown bag time, since both of these problems are my fault, and I ostensibly tested them. Ho hum. Anyway, this brings linux-test back to working. r~ Richard Henderson (5): common-user/host/sparc64: Fix safe_syscall_base linux-user: Introduce host_signal_mask linux-user: Introduce host_si

[RFC 2/8] multiprocess: place RemoteObject definition in a header file

2022-02-08 Thread Elena Ufimtseva
This will be needed later. No functional changes. Signed-off-by: Elena Ufimtseva --- include/hw/remote/remote.h | 28 hw/remote/remote-obj.c | 16 +--- MAINTAINERS| 1 + 3 files changed, 30 insertions(+), 15 deletions(-) create mode

Re: [PATCH v12 2/5] migration/dirtyrate: refactor dirty page rate calculation

2022-02-08 Thread Peter Xu
On Mon, Jan 24, 2022 at 10:10:37PM +0800, huang...@chinatelecom.cn wrote: > diff --git a/cpus-common.c b/cpus-common.c > index 6e73d3e..63159d6 100644 > --- a/cpus-common.c > +++ b/cpus-common.c > @@ -73,6 +73,7 @@ static int cpu_get_free_index(void) > } > > CPUTailQ cpus = QTAILQ_HEAD_INITIALI

[RFC 7/8] multiprocess: add ioregionfd memory region in proxy

2022-02-08 Thread Elena Ufimtseva
Signed-off-by: Elena Ufimtseva --- include/hw/remote/proxy.h | 1 + hw/remote/proxy.c | 66 --- 2 files changed, 63 insertions(+), 4 deletions(-) diff --git a/include/hw/remote/proxy.h b/include/hw/remote/proxy.h index 741def71f1..9efef0b935 100644 --

Re: [PATCH 28/31] vdpa: Expose VHOST_F_LOG_ALL on SVQ

2022-02-08 Thread Jason Wang
在 2022/2/1 下午7:45, Eugenio Perez Martin 写道: On Sun, Jan 30, 2022 at 7:50 AM Jason Wang wrote: 在 2022/1/22 上午4:27, Eugenio Pérez 写道: SVQ is able to log the dirty bits by itself, so let's use it to not block migration. Also, ignore set and clear of VHOST_F_LOG_ALL on set_features if SVQ is e

[PATCH 1/5] common-user/host/sparc64: Fix safe_syscall_base

2022-02-08 Thread Richard Henderson
Use the "retl" instead of "ret" instruction alias, since we do not allocate a register window in this function. Fix the offset to the first stacked parameter, which lies beyond the register window save area. Fixes: 95c021dac835 ("linux-user/host/sparc64: Add safe-syscall.inc.S") Signed-off-by: Ri

[RFC 0/8] ioregionfd introduction

2022-02-08 Thread Elena Ufimtseva
This patchset is an RFC version for the ioregionfd implementation in QEMU. The kernel patches are to be posted with some fixes as a v4. For this implementation version 3 of the posted kernel patches was user: https://lore.kernel.org/kvm/cover.1613828726.git.eafanas...@gmail.com/ The future versio

[PATCH 3/5] linux-user: Introduce host_sigcontext

2022-02-08 Thread Richard Henderson
Do not directly access ucontext_t as the third signal parameter. This is preparation for a sparc64 fix. Signed-off-by: Richard Henderson --- linux-user/include/host/aarch64/host-signal.h | 13 - linux-user/include/host/alpha/host-signal.h | 11 +++ linux-user/includ

Re: [PATCH v2] hw/smbios: fix memory corruption for large guests due to handle overlap

2022-02-08 Thread Igor Mammedov
On Mon, 7 Feb 2022 20:42:35 +0530 (IST) Ani Sinha wrote: > > > > So question is it is worth to have legacy SMBIOS code and introduce a > > new handle layout + memory_region re-sizable SMBIOS tables like we did > > with ACPI ones. > > > > That way we we will be free to change SMBIOS tables at will

[PATCH v6 0/8] tcg/sparc: Unaligned access for user-only

2022-02-08 Thread Richard Henderson
Changes from v5: * Use tcg_out_movi_imm13 from tcg_out_addsub2_i64. * Split out tcg_out_movi_imm32 to avoid recursion. * Reinstate the assert vs TCG_REG_T2 in tcg_out_movi. Changes from v4: * Remove assert from tcg_out_movi; rely on the one in tcg_out_movi_int (pmm). * Finish conversion

[RFC 8/8] multiprocess: handle ioregionfd commands

2022-02-08 Thread Elena Ufimtseva
Signed-off-by: Elena Ufimtseva --- include/hw/remote/ioregionfd.h | 2 + include/hw/remote/remote.h | 2 + linux-headers/ioregionfd.h | 30 + hw/remote/ioregionfd.c | 111 + hw/remote/remote-obj.c | 44 + 5 files ch

Re: [PATCH 00/31] vDPA shadow virtqueue

2022-02-08 Thread Jason Wang
在 2022/1/31 下午5:15, Eugenio Perez Martin 写道: On Fri, Jan 28, 2022 at 7:02 AM Jason Wang wrote: 在 2022/1/22 上午4:27, Eugenio Pérez 写道: This series enables shadow virtqueue (SVQ) for vhost-vdpa devices. This is intended as a new method of tracking the memory the devices touch during a migratio

Re: [PATCH 18/31] vhost: Shadow virtqueue buffers forwarding

2022-02-08 Thread Jason Wang
在 2022/2/2 上午1:08, Eugenio Perez Martin 写道: On Sun, Jan 30, 2022 at 5:43 AM Jason Wang wrote: 在 2022/1/22 上午4:27, Eugenio Pérez 写道: Initial version of shadow virtqueue that actually forward buffers. There is no iommu support at the moment, and that will be addressed in future patches of thi

[PATCH v6 4/8] tcg/sparc: Improve code gen for shifted 32-bit constants

2022-02-08 Thread Richard Henderson
We had code for checking for 13 and 21-bit shifted constants, but we can do better and allow 32-bit shifted constants. This is still 2 insns shorter than the full 64-bit sequence. Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- tcg/sparc/tcg-

[PATCH v6 5/8] tcg/sparc: Convert patch_reloc to return bool

2022-02-08 Thread Richard Henderson
Since 7ecd02a06f8, if patch_reloc fails we restart translation with a smaller TB. Sparc had its function signature changed, but not the logic. Replace assert with return false. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c.inc | 8 ++-- 1 file chan

Re: [PATCH v4 02/12] mm/memfd: Introduce MFD_INACCESSIBLE flag

2022-02-08 Thread David Hildenbrand
On 07.02.22 19:51, Vlastimil Babka wrote: > On 1/18/22 14:21, Chao Peng wrote: >> Introduce a new memfd_create() flag indicating the content of the >> created memfd is inaccessible from userspace. It does this by force >> setting F_SEAL_INACCESSIBLE seal when the file is created. It also set >> F_S

Re: [PATCH 22/31] vhost: Add VhostIOVATree

2022-02-08 Thread Jason Wang
在 2022/2/2 上午1:27, Eugenio Perez Martin 写道: On Sun, Jan 30, 2022 at 6:21 AM Jason Wang wrote: 在 2022/1/22 上午4:27, Eugenio Pérez 写道: This tree is able to look for a translated address from an IOVA address. At first glance it is similar to util/iova-tree. However, SVQ working on devices with

[PATCH v6 8/8] tcg/sparc: Support unaligned access for user-only

2022-02-08 Thread Richard Henderson
This is kinda sorta the opposite of the other tcg hosts, where we get (normal) alignment checks for free with host SIGBUS and need to add code to support unaligned accesses. This inline code expansion is somewhat large, but it takes quite a few instructions to make a function call to a helper anyw

Re: [PATCH 2/5] libvduse: Add VDUSE (vDPA Device in Userspace) library

2022-02-08 Thread Stefan Hajnoczi
On Tue, Feb 08, 2022 at 02:42:41PM +0800, Yongji Xie wrote: > On Mon, Feb 7, 2022 at 10:01 PM Stefan Hajnoczi wrote: > > > > On Tue, Jan 25, 2022 at 09:17:57PM +0800, Xie Yongji wrote: > > > +int vduse_dev_handler(VduseDev *dev) > > > +{ > > > +struct vduse_dev_request req; > > > +struct v

[RFC 3/8] ioregionfd: introduce memory API functions

2022-02-08 Thread Elena Ufimtseva
Similar to ioeventfd, introduce the ioregionfd functions to add and delete ioregionfds. Signed-off-by: Elena Ufimtseva --- softmmu/memory.c | 207 +++ 1 file changed, 207 insertions(+) diff --git a/softmmu/memory.c b/softmmu/memory.c index 7340e19ff5.

Re: [PATCH 5/5] libvduse: Add support for reconnecting

2022-02-08 Thread Stefan Hajnoczi
On Tue, Feb 08, 2022 at 03:35:27PM +0800, Yongji Xie wrote: > On Mon, Feb 7, 2022 at 10:39 PM Stefan Hajnoczi wrote: > > > > On Tue, Jan 25, 2022 at 09:18:00PM +0800, Xie Yongji wrote: > > > +static void *vduse_log_get(const char *dir, const char *name, size_t > > > size) > > > +{ > > > +void

Re: [PATCH v3] i386/cpu: Remove the deprecated cpu model 'Icelake-Client'

2022-02-08 Thread Robert Hoo
Hi, Can we remove the deprecated 'Icelake-Client' CPU model now? if so, I can rebase patch to latest and resend. Thanks. On Sat, 2021-05-08 at 11:16 +0800, Robert Hoo wrote: > Hi, > > Ping... > > Thanks. > > On Thu, 2021-04-29 at 09:35 +0800, Robert Hoo wrote: > > As it's been marked deprecat

[RFC 4/8] ioregionfd: Introduce IORegionDFObject type

2022-02-08 Thread Elena Ufimtseva
Signed-off-by: Elena Ufimtseva --- meson.build| 15 ++- qapi/qom.json | 32 +- include/hw/remote/ioregionfd.h | 40 +++ hw/remote/ioregionfd.c | 196 + Kconfig.host | 3 + MAINTAINERS

Re: [PATCH] memory: Fix qemu crash on starting dirty log twice with stopped VM

2022-02-08 Thread Paolo Bonzini
On 2/7/22 11:36, Peter Xu wrote: Yeah I can do. Though the latter "if (!flags)" check will also start to allow nesting of memory_global_dirty_log_start(), and it'll make this assert useless: assert(!(global_dirty_tracking & flags)); I'll probably drop it too, then. Curious: do we have an

Re: [PATCH v2 0/5] Misc OHCI clean ups

2022-02-08 Thread BALATON Zoltan
On Tue, 25 Jan 2022, BALATON Zoltan wrote: v2 - Fixed checkpatch errors Hello, Ping? Regards, BALATON Zoltan I have these patches from last October when we've looked at what causes problems with mac99 and USB. We've found the main problem is likely not allowing pending packets per endpoint

[RFC 6/8] multiprocess: add MPQEMU_CMD_BAR_INFO

2022-02-08 Thread Elena Ufimtseva
This command is used to request the bar type info from remote device. Signed-off-by: Elena Ufimtseva --- include/hw/remote/ioregionfd.h | 2 ++ include/hw/remote/machine.h | 1 + include/hw/remote/mpqemu-link.h | 2 ++ hw/remote/ioregionfd.c | 28 hw/rem

Re: [PATCH 18/31] vhost: Shadow virtqueue buffers forwarding

2022-02-08 Thread Jason Wang
在 2022/2/1 下午7:25, Eugenio Perez Martin 写道: On Sun, Jan 30, 2022 at 7:47 AM Jason Wang wrote: 在 2022/1/22 上午4:27, Eugenio Pérez 写道: @@ -272,6 +590,28 @@ void vhost_svq_set_svq_kick_fd(VhostShadowVirtqueue *svq, int svq_kick_fd) void vhost_svq_stop(VhostShadowVirtqueue *svq) {

[RFC 5/8] multiprocess: prepare ioregionfds for remote device

2022-02-08 Thread Elena Ufimtseva
Signed-off-by: Elena Ufimtseva --- include/hw/remote/ioregionfd.h | 1 + include/hw/remote/remote.h | 1 + hw/remote/ioregionfd.c | 26 ++ hw/remote/remote-obj.c | 93 ++ 4 files changed, 121 insertions(+) diff --git a/include/hw/remo

Re: [PATCH 5/5] libvduse: Add support for reconnecting

2022-02-08 Thread Yongji Xie
On Mon, Feb 7, 2022 at 10:39 PM Stefan Hajnoczi wrote: > > On Tue, Jan 25, 2022 at 09:18:00PM +0800, Xie Yongji wrote: > > To support reconnecting after restart or crash, VDUSE backend > > might need to resubmit inflight I/Os. This stores the metadata > > such as the index of inflight I/O's descri

Re: [PATCH 04/31] vdpa: Add vhost_svq_set_svq_kick_fd

2022-02-08 Thread Jason Wang
在 2022/1/31 下午6:18, Eugenio Perez Martin 写道: On Fri, Jan 28, 2022 at 7:29 AM Jason Wang wrote: 在 2022/1/22 上午4:27, Eugenio Pérez 写道: This function allows the vhost-vdpa backend to override kick_fd. Signed-off-by: Eugenio Pérez --- hw/virtio/vhost-shadow-virtqueue.h | 1 + hw/virtio/

Re: [PATCH RFC 07/15] migration: Introduce postcopy channels on dest node

2022-02-08 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Thu, Feb 03, 2022 at 03:08:39PM +, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > Postcopy handles huge pages in a special way that currently we can only > > > have > > > one "channel" to transfer the page. > > > > > >

Re: [PATCH v3 0/2] python: a few improvements to qmp-shell

2022-02-08 Thread Daniel P . Berrangé
On Mon, Feb 07, 2022 at 04:05:47PM -0500, John Snow wrote: > On Fri, Jan 28, 2022 at 11:12 AM Daniel P. Berrangé > wrote: > > > > This makes the qmp-shell program a little more pleasant to use when you > > are just trying to spawn a throw-away QEMU process to query some info > > from. > > > > Fir

Re: [PATCH 5/5] libvduse: Add support for reconnecting

2022-02-08 Thread Yongji Xie
On Tue, Feb 8, 2022 at 4:09 PM Stefan Hajnoczi wrote: > > On Tue, Feb 08, 2022 at 03:35:27PM +0800, Yongji Xie wrote: > > On Mon, Feb 7, 2022 at 10:39 PM Stefan Hajnoczi wrote: > > > > > > On Tue, Jan 25, 2022 at 09:18:00PM +0800, Xie Yongji wrote: > > > > +static void *vduse_log_get(const char *

Re: [PATCH RFC 07/15] migration: Introduce postcopy channels on dest node

2022-02-08 Thread Peter Xu
On Tue, Feb 08, 2022 at 09:43:49AM +, Dr. David Alan Gilbert wrote: > > It'll be cleaned up later here: > > > > loadvm_postcopy_handle_listen > > postcopy_ram_incoming_setup > > postcopy_temp_pages_setup > > postcopy_ram_incoming_cleanup <-- if fail above, go here > >

[PATCH v2] migration/rdma: set the REUSEADDR option for destination

2022-02-08 Thread Jack Wang
We hit following error during testing RDMA transport: in case of migration error, mgmt daemon pick one migration port, incoming rdma:[::]:8089: RDMA ERROR: Error: could not rdma_bind_addr Then try another -incoming rdma:[::]:8103, sometime it worked, sometimes need another try with other ports num

Re: [PATCH 23/31] vdpa: Add custom IOTLB translations to SVQ

2022-02-08 Thread Jason Wang
在 2022/2/1 上午3:11, Eugenio Perez Martin 写道: +return false; +} + +/* + * Map->iova chunk size is ignored. What to do if descriptor + * (addr, size) does not fit is delegated to the device. + */ I think we need at least check the size and fail

Re: [PATCH v12 4/5] softmmu/dirtylimit: implement virtual CPU throttle

2022-02-08 Thread Peter Xu
On Mon, Jan 24, 2022 at 10:10:39PM +0800, huang...@chinatelecom.cn wrote: > From: Hyman Huang(黄勇) > > Setup a negative feedback system when vCPU thread > handling KVM_EXIT_DIRTY_RING_FULL exit by introducing > throttle_us_per_full field in struct CPUState. Sleep > throttle_us_per_full microsecond

Re: [PATCH v12 1/5] accel/kvm/kvm-all: refactor per-vcpu dirty ring reaping

2022-02-08 Thread Hyman Huang
在 2022/2/8 15:20, Peter Xu 写道: On Mon, Jan 24, 2022 at 10:10:36PM +0800, huang...@chinatelecom.cn wrote: @@ -2956,7 +2959,7 @@ int kvm_cpu_exec(CPUState *cpu) */ trace_kvm_dirty_ring_full(cpu->cpu_index); qemu_mutex_lock_iothread(); -kvm_

[PATCH 2/6] tests/qemu-iotests/meson.build: Improve the indentation

2022-02-08 Thread Thomas Huth
By using subdir_done(), we can get rid of one level of indentation in this file. This will make it easier to add more conditions to skip the iotests in future patches. Signed-off-by: Thomas Huth --- tests/qemu-iotests/meson.build | 61 ++ 1 file changed, 32 insert

[PATCH 5/6] tests: Do not treat the iotests as separate meson test target anymore

2022-02-08 Thread Thomas Huth
Now that we add the single iotests directly in meson.build, we do not have to separate the block suite from the other suites anymore. Signed-off-by: Thomas Huth --- meson.build| 6 +++--- scripts/mtest2make.py | 4 tests/Makefile.include | 9 + 3 files changed, 4 insert

Re: [PATCH v12 2/5] migration/dirtyrate: refactor dirty page rate calculation

2022-02-08 Thread Hyman Huang
在 2022/2/8 16:18, Peter Xu 写道: On Mon, Jan 24, 2022 at 10:10:37PM +0800, huang...@chinatelecom.cn wrote: diff --git a/cpus-common.c b/cpus-common.c index 6e73d3e..63159d6 100644 --- a/cpus-common.c +++ b/cpus-common.c @@ -73,6 +73,7 @@ static int cpu_get_free_index(void) } CPUTailQ cpu

[PATCH 3/6] tests/qemu-iotests: Allow to run "./check -n" from the source directory, too

2022-02-08 Thread Thomas Huth
For better integration of the iotests into the meson build system, it would be very helpful to get the list of the tests in the "auto" group during the "configure" step already. However, "check -n -g auto" currently only works if the binaries have already been built. Re-order the code in the "check

Re: [PATCH 1/4] target/ppc: Remove powerpc_excp_legacy

2022-02-08 Thread Cédric Le Goater
On 2/7/22 19:30, Fabiano Rosas wrote: Now that all CPU families have their own separate exception dispatching code we can remove powerpc_excp_legacy. Signed-off-by: Fabiano Rosas Super :) Reviewed-by: Cédric Le Goater Thanks, C. --- target/ppc/excp_helper.c | 477 +

Re: [PATCH v5 0/9] virtiofsd: Add support for file security context at file creation

2022-02-08 Thread Daniel P . Berrangé
On Mon, Feb 07, 2022 at 04:19:38PM -0500, Vivek Goyal wrote: > On Mon, Feb 07, 2022 at 01:05:16PM +, Daniel P. Berrangé wrote: > > On Wed, Feb 02, 2022 at 02:39:26PM -0500, Vivek Goyal wrote: > > > Hi, > > > > > > This is V5 of the patches. I posted V4 here. > > > > > > https://listman.redhat

Re: target/arm: cp15.dacr migration

2022-02-08 Thread Peter Maydell
On Tue, 8 Feb 2022 at 04:56, Pavel Dovgalyuk wrote: > > On 07.02.2022 16:44, Peter Maydell wrote: > > On Mon, 7 Feb 2022 at 12:13, Pavel Dovgalyuk > > wrote: > >> > >> I recently encountered a problem with cp15.dacr register. > >> It has _s and _ns versions. During the migration only dacr_ns is

Re: [PATCH 2/4] target/ppc: powerpc_excp: Move common code to the caller function

2022-02-08 Thread Cédric Le Goater
On 2/7/22 19:30, Fabiano Rosas wrote: Make the cpu-specific powerpc_excp_* functions a bit simpler by moving the bounds check and logging to powerpc_excp. Signed-off-by: Fabiano Rosas Reviewed-by: Cédric Le Goater Thanks, C. --- target/ppc/excp_helper.c | 57 +++

Re: [PATCH v5 11/11] 9p: darwin: Adjust assumption on virtio-9p-test

2022-02-08 Thread Greg Kurz
On Mon, 7 Feb 2022 17:40:24 -0500 Will Cohen wrote: > The previous test depended on the assumption that P9_DOTL_AT_REMOVEDIR > and AT_REMOVEDIR have the same value. > > While this is true on Linux, it is not true everywhere, and leads to an > incorrect test failure on unlink_at, noticed when ad

Re: [PATCH 06/31] vhost: Route guest->host notification through shadow virtqueue

2022-02-08 Thread Jason Wang
在 2022/1/31 下午7:33, Eugenio Perez Martin 写道: On Fri, Jan 28, 2022 at 7:57 AM Jason Wang wrote: 在 2022/1/22 上午4:27, Eugenio Pérez 写道: At this moment no buffer forwarding will be performed in SVQ mode: Qemu just forward the guest's kicks to the device. This commit also set up SVQs in the vhos

Re: [PATCH] hvf: arm: Handle ID_AA64ISAR2_EL1 reads

2022-02-08 Thread Peter Maydell
On Mon, 7 Feb 2022 at 22:52, Alexander Graf wrote: > > Recent Linux versions added support to read ID_AA64ISAR2_EL1. On M1, > those reads trap into QEMU which handles them as faults. > > However, according to the ARMv8 spec (issue D17783), reads on this > register in older ARMv8 revisions should b

Re: [PATCH 5/6] tests: Do not treat the iotests as separate meson test target anymore

2022-02-08 Thread Peter Maydell
On Tue, 8 Feb 2022 at 10:18, Thomas Huth wrote: > > Now that we add the single iotests directly in meson.build, we do > not have to separate the block suite from the other suites anymore. > > Signed-off-by: Thomas Huth > --- > meson.build| 6 +++--- > scripts/mtest2make.py | 4

[PATCH qemu] spapr/vof: Install rom and nvram binaries

2022-02-08 Thread Alexey Kardashevskiy
This installs VOF-related binaries (the firmware and the preformatted NVRAM) as those were left out when the VOF was submitted initially. Fixes: fc8c745d5015 ("spapr: Implement Open Firmware client interface") Signed-off-by: Alexey Kardashevskiy --- pc-bios/meson.build | 2 ++ 1 file changed, 2

[PATCH 0/6] Improve integration of iotests in the meson test harness

2022-02-08 Thread Thomas Huth
Though "make check-block" is currently already run via the meson test runner, it still looks like an oddball in the output of "make check" since the tests are still run separately via the check-block.sh script. It would be nicer if the iotests would show up like the other tests suites. For this we

[PATCH 1/6] tests/qemu-iotests: Improve the check for GNU sed

2022-02-08 Thread Thomas Huth
Instead of failing the iotests if GNU sed is not available (or skipping them completely in the check-block.sh script), it would be better to simply skip the bash-based tests, so that the python-based tests could still be run. Thus add the check for BusyBox sed to common.rc and mark the tests as "no

Re: [PATCH 2/5] linux-user: Introduce host_signal_mask

2022-02-08 Thread Philippe Mathieu-Daudé via
On 8/2/22 08:12, Richard Henderson wrote: Do not directly access the uc_sigmask member. This is preparation for a sparc64 fix. Signed-off-by: Richard Henderson --- linux-user/include/host/aarch64/host-signal.h | 5 + linux-user/include/host/alpha/host-signal.h| 5 + linux-use

[PATCH 6/6] tests: Remove check-block.sh

2022-02-08 Thread Thomas Huth
Now that the iotests are added by the meson.build file already, we do not need the check-block.sh wrapper script anymore. Signed-off-by: Thomas Huth --- tests/check-block.sh | 73 1 file changed, 73 deletions(-) delete mode 100755 tests/check-block.s

[PATCH 4/6] tests/qemu-iotests/meson.build: Call the 'check' script directly

2022-02-08 Thread Thomas Huth
We can get a nicer progress indication if we add the iotests individually via the 'check' script instead of going through the check-block.sh wrapper. For this, we have to add some of the sanity checks that have originally been done in the tests/check-block.sh script (whether "bash" is available or

Re: [PATCH v6 02/33] include/block/block: split header into I/O and global state API

2022-02-08 Thread Emanuele Giuseppe Esposito
On 07/02/2022 17:53, Kevin Wolf wrote: > Am 01.02.2022 um 11:30 hat Paolo Bonzini geschrieben: >> On 2/1/22 10:45, Emanuele Giuseppe Esposito wrote: That said, even if they are a different category, I think it makes sense to leave them in the same header file as I/O functions, because

Re: [PATCH v6 5/8] tcg/sparc: Convert patch_reloc to return bool

2022-02-08 Thread Philippe Mathieu-Daudé via
On 8/2/22 08:17, Richard Henderson wrote: Since 7ecd02a06f8, if patch_reloc fails we restart translation with a smaller TB. Sparc had its function signature changed, "SPARC"? but not the logic. Replace assert with return false. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson

Re: [PATCH v2 1/2] hw/misc: Supporting AST2600 HACE accumulative mode

2022-02-08 Thread Joel Stanley
Hello Troy, On Wed, 12 Jan 2022 at 08:10, Troy Lee wrote: > > Accumulative mode will supply a initial state and append padding bit at > the end of hash stream. However, the crypto library will padding those > bit automatically, so ripped it off from iov array. > > The aspeed ast2600 acculumative

[PATCH v2] hvf: arm: Handle unknown ID registers as RES0

2022-02-08 Thread Alexander Graf
Recent Linux versions added support to read ID_AA64ISAR2_EL1. On M1, those reads trap into QEMU which handles them as faults. However, AArch64 ID registers should always read as RES0. Let's handle them accordingly. This fixes booting Linux 5.17 guests. Cc: qemu-sta...@nongnu.org Reported-by: Iva

Re: [PATCH 08/11] mos6522: add "info via" HMP command for debugging

2022-02-08 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Philippe Mathieu-Daudé writes: > > > On 7/2/22 20:34, Peter Maydell wrote: > >> On Thu, 27 Jan 2022 at 21:03, Mark Cave-Ayland > >> wrote: > >>> > >>> This displays detailed information about the device registers and timers > >>> to aid > >>> deb

Re: [PATCH 3/5] linux-user: Introduce host_sigcontext

2022-02-08 Thread Peter Maydell
On Tue, 8 Feb 2022 at 08:57, Richard Henderson wrote: > > Do not directly access ucontext_t as the third signal parameter. > This is preparation for a sparc64 fix. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v6 13/33] include/block/blockjob.h: global state API

2022-02-08 Thread Emanuele Giuseppe Esposito
On 07/02/2022 18:26, Kevin Wolf wrote: > Am 21.01.2022 um 18:05 hat Emanuele Giuseppe Esposito geschrieben: >> blockjob functions run always under the BQL lock. >> >> Signed-off-by: Emanuele Giuseppe Esposito >> Reviewed-by: Stefan Hajnoczi >> --- >> include/block/blockjob.h | 9 + >>

Re: [PATCH 4/5] linux-user: Move sparc/host-signal.h to sparc64/host-signal.h

2022-02-08 Thread Philippe Mathieu-Daudé via
On 8/2/22 08:12, Richard Henderson wrote: We do not support sparc32 as a host, so there's no point in sparc64 redirecting to sparc. Signed-off-by: Richard Henderson --- linux-user/include/host/sparc/host-signal.h | 71 --- linux-user/include/host/sparc64/host-signal.h | 64

Re: [PATCH v2] migration/rdma: set the REUSEADDR option for destination

2022-02-08 Thread Dr. David Alan Gilbert
* Jack Wang (jinpu.w...@ionos.com) wrote: > We hit following error during testing RDMA transport: > in case of migration error, mgmt daemon pick one migration port, > incoming rdma:[::]:8089: RDMA ERROR: Error: could not rdma_bind_addr > > Then try another -incoming rdma:[::]:8103, sometime it wor

Re: [PATCH v6 1/8] tcg/sparc: Use tcg_out_movi_imm13 in tcg_out_addsub2_i64

2022-02-08 Thread Richard Henderson
On 2/8/22 21:40, Peter Maydell wrote: On Tue, 8 Feb 2022 at 07:17, Richard Henderson wrote: When BH is constant, it is constrained to 10 bits for use in MOVCC. Where does this happen? I assumed it was going to be done by the constraint encodings, but tcg_out_addsub2_i64() is called for the a

Re: [PATCH v5 09/11] 9p: darwin: Implement compatibility for mknodat

2022-02-08 Thread Philippe Mathieu-Daudé via
On 7/2/22 23:40, Will Cohen wrote: From: Keno Fischer Darwin does not support mknodat. However, to avoid race conditions with later setting the permissions, we must avoid using mknod on the full path instead. We could try to fchdir, but that would cause problems if multiple threads try to call

Re: [PATCH 3/5] linux-user: Introduce host_sigcontext

2022-02-08 Thread Philippe Mathieu-Daudé via
On 8/2/22 08:12, Richard Henderson wrote: Do not directly access ucontext_t as the third signal parameter. This is preparation for a sparc64 fix. Signed-off-by: Richard Henderson --- linux-user/include/host/aarch64/host-signal.h | 13 - linux-user/include/host/alpha/host-sign

Re: [PATCH 5/5] linux-user/include/host/sparc64: Fix host_sigcontext

2022-02-08 Thread Peter Maydell
On Tue, 8 Feb 2022 at 07:46, Richard Henderson wrote: > > Sparc64 is unique on linux in *not* passing ucontext_t as > the third argument to a SA_SIGINFO handler. It passes the > old struct sigcontext instead.t log Stray bit of text at the end of the commit message here. > > Fixes: 8b5bd461935b

Re: [PATCH 20/27] qga/vss-win32: use widl if available

2022-02-08 Thread Konstantin Kostiuk
Signed-off-by: Konstantin Kostiuk On Thu, Feb 3, 2022 at 8:08 PM Paolo Bonzini wrote: > From: Marc-André Lureau > > widl from mingw64-tools and wine can compile a TLB file. > > Signed-off-by: Marc-André Lureau > Signed-off-by: Paolo Bonzini > --- > qga/vss-win32/meson.build | 9 ++--- >

Re: [PATCH v6 1/8] tcg/sparc: Use tcg_out_movi_imm13 in tcg_out_addsub2_i64

2022-02-08 Thread Peter Maydell
On Tue, 8 Feb 2022 at 07:17, Richard Henderson wrote: > > When BH is constant, it is constrained to 10 bits for use in MOVCC. Where does this happen? I assumed it was going to be done by the constraint encodings, but tcg_out_addsub2_i64() is called for the add2_i64 and sub2_i64 ops, which get

Re: [PATCH v2] migration/rdma: set the REUSEADDR option for destination

2022-02-08 Thread Pankaj Gupta
> We hit following error during testing RDMA transport: > in case of migration error, mgmt daemon pick one migration port, > incoming rdma:[::]:8089: RDMA ERROR: Error: could not rdma_bind_addr > > Then try another -incoming rdma:[::]:8103, sometime it worked, > sometimes need another try with othe

Re: [PATCH v2] memory: Fix qemu crash on starting dirty log twice with stopped VM

2022-02-08 Thread Paolo Bonzini
On 2/7/22 13:30, Peter Xu wrote: QEMU can now easily crash with two continuous migration carried out: (qemu) migrate -d exec:cat>out (qemu) migrate_cancel (qemu) migrate -d exec:cat>out [crash] ../softmmu/memory.c:2782: memory_global_dirty_log_start: Assertion `!(global_dirty_tracking & flags)'

Re: [PATCH v6 2/8] tcg/sparc: Split out tcg_out_movi_imm32

2022-02-08 Thread Peter Maydell
On Tue, 8 Feb 2022 at 07:17, Richard Henderson wrote: > > Handle 32-bit constants with a separate function, so that > tcg_out_movi_int does not need to recurse. This slightly > rearranges the order of tests for small constants, but > produces the same output. > > Signed-off-by: Richard Henderson

Re: [PATCH 23/27] meson: do not make qga/vss-win32/meson.build conditional on C++ presence

2022-02-08 Thread Konstantin Kostiuk
Reviewed-by: Konstantin Kostiuk On Tue, Feb 8, 2022 at 1:14 PM Konstantin Kostiuk wrote: > Signed-off-by: Konstantin Kostiuk > > On Thu, Feb 3, 2022 at 8:14 PM Paolo Bonzini wrote: > >> From: Marc-André Lureau >> >> C++ presence is checked by the qga/ directory, so it can be assumed >> when

Re: [PATCH v6 31/33] include/qemu/job.h: introduce job->pre_run() and use it in amend

2022-02-08 Thread Emanuele Giuseppe Esposito
On 07/02/2022 19:14, Kevin Wolf wrote: > Am 21.01.2022 um 18:05 hat Emanuele Giuseppe Esposito geschrieben: >> Introduce .pre_run() job callback. This cb will run in job_start, >> before the coroutine is created and runs run() in the job aiocontext. >> >> Therefore, .pre_run() always runs in the

Re: [PATCH RFC 09/15] migration: Add postcopy_thread_create()

2022-02-08 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Thu, Feb 03, 2022 at 03:19:48PM +, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > Postcopy create threads. A common manner is we init a sem and use it to > > > sync > > > with the thread. Namely, we have fault_thread_se

Re: [PATCH v12 4/5] softmmu/dirtylimit: implement virtual CPU throttle

2022-02-08 Thread Hyman Huang
在 2022/2/8 16:59, Peter Xu 写道: On Mon, Jan 24, 2022 at 10:10:39PM +0800, huang...@chinatelecom.cn wrote: From: Hyman Huang(黄勇) Setup a negative feedback system when vCPU thread handling KVM_EXIT_DIRTY_RING_FULL exit by introducing throttle_us_per_full field in struct CPUState. Sleep throttl

Re: [PATCH 5/6] tests: Do not treat the iotests as separate meson test target anymore

2022-02-08 Thread Thomas Huth
On 08/02/2022 11.26, Peter Maydell wrote: On Tue, 8 Feb 2022 at 10:18, Thomas Huth wrote: Now that we add the single iotests directly in meson.build, we do not have to separate the block suite from the other suites anymore. Signed-off-by: Thomas Huth --- meson.build| 6 +++---

Re: [PATCH 23/27] meson: do not make qga/vss-win32/meson.build conditional on C++ presence

2022-02-08 Thread Konstantin Kostiuk
Signed-off-by: Konstantin Kostiuk On Thu, Feb 3, 2022 at 8:14 PM Paolo Bonzini wrote: > From: Marc-André Lureau > > C++ presence is checked by the qga/ directory, so it can be assumed > when building VSS module. > > Signed-off-by: Marc-André Lureau > Signed-off-by: Paolo Bonzini > --- > qga

Re: [PATCH v6 3/8] tcg/sparc: Add scratch argument to tcg_out_movi_int

2022-02-08 Thread Peter Maydell
On Tue, 8 Feb 2022 at 07:17, Richard Henderson wrote: > > This will allow us to control exactly what scratch register is > used for loading the constant. > > Signed-off-by: Richard Henderson > --- > tcg/sparc/tcg-target.c.inc | 15 +-- > 1 file changed, 9 insertions(+), 6 deletions(-

Re: [PATCH 25/27] meson: require dynamic linking for VSS support

2022-02-08 Thread Konstantin Kostiuk
Reviewed-by: Konstantin Kostiuk On Fri, Feb 4, 2022 at 7:23 AM Philippe Mathieu-Daudé via < qemu-devel@nongnu.org> wrote: > On 3/2/22 18:33, Paolo Bonzini wrote: > > From: Marc-André Lureau > > > > The glib_dynamic detection does not work because the dependency is > > overridden in the main mes

Re: [PATCH 4/5] linux-user: Move sparc/host-signal.h to sparc64/host-signal.h

2022-02-08 Thread Richard Henderson
On 2/8/22 22:01, Peter Maydell wrote: On Tue, 8 Feb 2022 at 08:17, Richard Henderson wrote: We do not support sparc32 as a host, so there's no point in sparc64 redirecting to sparc. Where do we enforce that ? I couldn't see anything in configure or meson.build that forbids linux-user with a

Re: [PATCH 2/6] tests/qemu-iotests/meson.build: Improve the indentation

2022-02-08 Thread Philippe Mathieu-Daudé via
On 8/2/22 11:13, Thomas Huth wrote: By using subdir_done(), we can get rid of one level of indentation in this file. This will make it easier to add more conditions to skip the iotests in future patches. Signed-off-by: Thomas Huth --- tests/qemu-iotests/meson.build | 61 ++

Re: [PATCH 24/27] qga/vss-win32: require widl/midl, remove pre-built TLB file

2022-02-08 Thread Konstantin Kostiuk
Reviewed-by: Konstantin Kostiuk On Fri, Feb 4, 2022 at 7:20 AM Philippe Mathieu-Daudé via < qemu-devel@nongnu.org> wrote: > On 3/2/22 18:33, Paolo Bonzini wrote: > > From: Marc-André Lureau > > > > There are no good reason anymore to keep a pre-built file in the > repository. > > > > Signed-off

Re: [PATCH RFC 14/15] migration: Postcopy preemption on separate channel

2022-02-08 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Thu, Feb 03, 2022 at 05:45:32PM +, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > This patch enables postcopy-preempt feature. > > > > > > It contains two major changes to the migration logic: > > > > > > (1) Postcopy

Re: [PATCH 26/27] meson, configure: move ntddscsi API check to meson

2022-02-08 Thread Konstantin Kostiuk
Reviewed-by: Konstantin Kostiuk On Tue, Feb 8, 2022 at 1:15 PM Konstantin Kostiuk wrote: > Signed-off-by: Konstantin Kostiuk > > On Thu, Feb 3, 2022 at 8:03 PM Paolo Bonzini wrote: > >> From: Marc-André Lureau >> >> Signed-off-by: Marc-André Lureau >> Signed-off-by: Paolo Bonzini >> --- >>

Re: [PATCH 2/5] linux-user: Introduce host_signal_mask

2022-02-08 Thread Peter Maydell
On Tue, 8 Feb 2022 at 08:03, Richard Henderson wrote: > > Do not directly access the uc_sigmask member. > This is preparation for a sparc64 fix. > > Signed-off-by: Richard Henderson > --- > linux-user/include/host/aarch64/host-signal.h | 5 + > linux-user/include/host/alpha/host-signal.h

Re: [PATCH 21/27] qga/vss: use standard windows headers location

2022-02-08 Thread Konstantin Kostiuk
Reviewed-by: Konstantin Kostiuk On Fri, Feb 4, 2022 at 7:18 AM Philippe Mathieu-Daudé via < qemu-devel@nongnu.org> wrote: > On 3/2/22 18:33, Paolo Bonzini wrote: > > From: Marc-André Lureau > > > > Stop using special paths with outdated headers from an old SDK. > > > > Instead, use standard inc

Re: [PATCH 5/6] tests: Do not treat the iotests as separate meson test target anymore

2022-02-08 Thread Peter Maydell
On Tue, 8 Feb 2022 at 11:16, Thomas Huth wrote: > > On 08/02/2022 11.26, Peter Maydell wrote: > > What is the mechanism for this in the new meson setup ? > > cat meson-logs/testlog.txt > > ... I guess we should either dump that to stdout Yes, it needs to actually appear in the stdout for CI jobs,

Re: [PATCH 4/5] linux-user: Move sparc/host-signal.h to sparc64/host-signal.h

2022-02-08 Thread Peter Maydell
On Tue, 8 Feb 2022 at 08:17, Richard Henderson wrote: > > We do not support sparc32 as a host, so there's no point in > sparc64 redirecting to sparc. Where do we enforce that ? I couldn't see anything in configure or meson.build that forbids linux-user with a 32-bit sparc host, but I probably mis

  1   2   3   4   >