On 01/10/22 13:09, Xiaoyao Li wrote:
> On 1/10/2022 7:01 PM, Gerd Hoffmann wrote:
If you go without pflash, then you likely will not have a
standards-conformant UEFI variable store. (Unless you reimplement
the variable arch protocols in edk2 on top of something else than
the Fau
On Tue, 11 Jan 2022 at 07:01, Laurent Vivier wrote:
>
> Le 10/01/2022 à 20:17, Peter Maydell a écrit :
> > The clang in Ubuntu 18.04 (10.0.0-4ubuntu1) produces a warning
> > on the code added in commit f5ef0e518d03 where we use a
> > shifted expression in a boolean context:
> >
> > ../../linux-use
Hi Akihiko
On Tue, Jan 11, 2022 at 7:30 AM Akihiko Odaki wrote:
>
> Hi,
>
> I found this brings an inconsistency and a flaw to scanout semantics and
> think the inconsistency should be fixed or this should be reverted
> before the next release comes up.
>
> The inconsistency is in the handling of
Hello Troy,
+
+memory_region_init_io(&s->iomem, OBJECT(s), &aspeed_i3c_ops, s,
+TYPE_ASPEED_I3C, ASPEED_I3C_NR_REGS << 2);
+
+sysbus_init_mmio(sbd, &s->iomem);
I would add a container region containing all the regions :
memory_region_init(&s->iomem_container, OBJEC
The clang in Ubuntu 18.04 (10.0.0-4ubuntu1) produces a warning
on the code added in commit f5ef0e518d03 where we use a
shifted expression in a boolean context:
../../linux-user/elfload.c:2423:16: error: converting the result of '<<' to a
boolean always evaluates to true [-Werror,-Wtautological-co
On Tue, 11 Jan 2022 at 07:09, Zhang Chen wrote:
>
> To record screencast, AVAssetWriter APIs were called for each
> cocoa_update call.
>
> Commands for start/stop recording were added to View menu.
This seems a bit of an odd feature -- why doesn't the OS just
permit screen recording of any applic
On Tue, Dec 14, 2021 at 2:33 AM Eric DeVolder wrote:
>
> Ani, an inline response below.
> Thanks!
> eric
>
> On 12/10/21 08:09, Ani Sinha wrote:
> > On Thu, Dec 9, 2021 at 11:24 PM Eric DeVolder
> > wrote:
> >>
> >> Ani, inline responses below. eric
> >>
> >> On 12/9/21 00:29, Ani Sinha wrote:
>
On 1/10/22 19:15, Fabiano Rosas wrote:
This is the first series of the exception model-specific changes. I
intend to keep this same structure for the rest of the exception
models.
== preparation ==
First few patches are cleanups specific to this model. This comes
first because I'm using some of
This series of patch introduce a dummy implemenation of aspeed i3c
model, and it provide just enough information for guest machine.
However, the driver probing is still failed, but it will not cause
kernel panic.
v3:
- Remove unused AspeedI3CClass
- Refine memory region
- Refine register reset
- R
Aspeed 2600 SDK enables I3C support by default. The I3C driver will try
to reset the device controller and setup through device address table
register. This dummy model response these register with default value
listed on ast2600v10 datasheet chapter 54.2. If the device address
table register do
v3:
- Remove unrelated changes to SPI2 address
- Remove controller irq line
v2: Rebase to mainline QEMU
Signed-off-by: Troy Lee
---
hw/arm/aspeed_ast2600.c | 16
include/hw/arm/aspeed_soc.h | 3 +++
2 files changed, 19 insertions(+)
diff --git a/hw/arm/aspeed_ast2600.c b/
Le 11/01/2022 à 09:29, Peter Maydell a écrit :
The clang in Ubuntu 18.04 (10.0.0-4ubuntu1) produces a warning
on the code added in commit f5ef0e518d03 where we use a
shifted expression in a boolean context:
../../linux-user/elfload.c:2423:16: error: converting the result of '<<' to a
boolean al
Hi Jean, Michael,
On 9/30/21 8:50 PM, Jean-Philippe Brucker wrote:
> Replace the VIRTIO_IOMMU_F_BYPASS feature with
> VIRTIO_IOMMU_F_BYPASS_CONFIG, which enables a config space bit to switch
> global bypass on and off.
>
> Add a boot-bypass option, which defaults to 'on' to be in line with
> other
>From: "Cédric Le Goater" c...@kaod.org
>To: "ma...@locati.it" ma...@locati.it, bala...@eik.bme.hu
>Cc: faro...@linux.ibm.com, qemu-devel@nongnu.org, qemu-...@nongnu.org,
>danielhb...@gmail.com
>Date: Mon, 10 Jan 2022 09:04:39 +0100
>Subject: Re: [PATCH] target/ppc: Fix e6500 boot
>
>Hello Mario,
On 1/11/22 09:45, Troy Lee wrote:
Aspeed 2600 SDK enables I3C support by default. The I3C driver will try
to reset the device controller and setup through device address table
register. This dummy model response these register with default value
listed on ast2600v10 datasheet chapter 54.2. If
Am 10.01.22 um 15:18 schrieb Stefano Garzarella:
> On Mon, Jan 10, 2022 at 12:41:54PM +0100, Peter Lieven wrote:
>> librbd had a bug until early 2022 that affected all versions of ceph that
>> supported fast-diff. This bug results in reporting of incorrect offsets
>> if the offset parameter to rbd_
On Tue, Jan 11, 2022 at 11:27:58AM +0800, Yanan Wang wrote:
> The pointer assignment "const char *p = path;" in function
> qemu_fdt_add_path is unnecessary. Let's remove it and just
> use the "path" passed in. No functional change.
>
> Suggested-by: Richard Henderson
> Signed-off-by: Yanan Wang
On Mon, Jan 10, 2022 at 07:43:06PM +, Raphael Norwitz wrote:
> On Mon, Jan 10, 2022 at 04:36:34AM -0500, Michael S. Tsirkin wrote:
> > On Thu, Jan 06, 2022 at 06:47:26AM +, Raphael Norwitz wrote:
> > > Signed-off-by: Raphael Norwitz
> >
> >
> > Raphael any chance you can add a bit more t
On 1/11/22 09:45, Troy Lee wrote:
v3:
- Remove unrelated changes to SPI2 address
- Remove controller irq line
v2: Rebase to mainline QEMU
Signed-off-by: Troy Lee
Reviewed-by: Cédric Le Goater
You should consider updating the documentation :
https://qemu.readthedocs.io/en/latest/system/a
Coroutine pool size was 64 from long ago, and the basis was organized in the
commit message in c740ad92.
At that time, virtio-blk queue-size and num-queue were not configuable, and
equivalent values were 128 and 1.
Coroutine pool size 64 was fine then.
Later queue-size and num-queue got config
Resending patch with fixing atomic access method to use qatomic_read().
We encountered random disk IO performance drop since qemu-5.0.0, and this patch
fixes it.
Commit message in c740ad92 implied to adjust coroutine pool size adaptively, so
I tried to implement this.
Could you review this pat
On 1/11/22 09:45, Troy Lee wrote:
This series of patch introduce a dummy implemenation of aspeed i3c
model, and it provide just enough information for guest machine.
However, the driver probing is still failed, but it will not cause
kernel panic.
v3:
- Remove unused AspeedI3CClass
- Refine memor
> On Thu, Jan 06, 2022 at 05:20:57PM +0900, Hiroki Narukawa wrote:
>
> Phil, thanks for notifying me.
>
> > Coroutine pool size was 64 from long ago, and the basis was organized in
> > the commit message in c740ad92.
> >
> > At that time, virtio-blk queue-size and num-queue were not configuable
On 1/11/22 01:55, Daniel Henrique Barboza wrote:
Moving all phb4 properties setup to stk_realize() keeps this logic in
a single place instead of having it scattered between stk_realize() and
pec_realize().
'phb->index' can be retrieved using stack->stack_no and
pnv_phb4_pec_get_phb_id(), depreca
On Mon, Jan 10, 2022 at 05:56:25PM +, John Levon wrote:
> On Thu, Jan 06, 2022 at 01:35:32PM +, Stefan Hajnoczi wrote:
>
> > > > >> +static void vfu_object_attach_ctx(void *opaque)
> > > > >> +{
> > > > >> +VfuObject *o = opaque;
> > > > >> +GPollFD pfds[1];
> > > > >> +int ret
On 1/11/22 01:55, Daniel Henrique Barboza wrote:
The 'stack->phb_regs_mr' PHB4 passthrough XSCOM initialization relies on
'stack->phb' being not NULL. Moving 'stack->phb_regs_mr' region_init()
and add_subregion() to phb4_realize() time is a natural thing to do
since it's strictly PHB related.
Th
On 1/11/22 01:55, Daniel Henrique Barboza wrote:
At this moment, stack->phb is the plain PnvPHB4 device itself instead of
a pointer to the device. This will present a problem when adding user
creatable devices because we can't deal with this struct and the
realize() callback from the user creatab
On 1/11/22 01:55, Daniel Henrique Barboza wrote:
This patch introduces pnv-phb4 user creatable devices that are created
in a similar manner as pnv-phb3 devices, allowing the user to interact
with the PHBs directly instead of creating PCI Express Controllers that
will create a certain amount of PH
On 1/11/22 01:55, Daniel Henrique Barboza wrote:
Its only callers are inside pnv_phb4.c.
Signed-off-by: Daniel Henrique Barboza
Reviewed-by: Cédric Le Goater
Thanks,
C.
---
hw/pci-host/pnv_phb4.c | 52 +-
include/hw/pci-host/pnv_phb4.h | 1 -
On Mon, 10 Jan 2022 at 15:01, Paolo Bonzini wrote:
>
> The following changes since commit afe33262585565b64df706c62b4b0f6e0ad30c71:
>
> Merge tag 'pull-riscv-to-apply-20220108' of github.com:alistair23/qemu into
> staging (2022-01-07 22:09:24 -0800)
>
> are available in the Git repository at:
>
Hi Eric,
On Tue, Jan 11, 2022 at 10:02:12AM +0100, Eric Auger wrote:
> Hi Jean, Michael,
>
> On 9/30/21 8:50 PM, Jean-Philippe Brucker wrote:
> > Replace the VIRTIO_IOMMU_F_BYPASS feature with
> > VIRTIO_IOMMU_F_BYPASS_CONFIG, which enables a config space bit to switch
> > global bypass on and of
From: "Dr. David Alan Gilbert"
Add the missing VMSTATE_END_OF_LIST to vmstate_muldiv
Fixes: 99abcbc7600 ("clock: Provide builtin multiplier/divider")
Signed-off-by: Dr. David Alan Gilbert
---
hw/core/clock-vmstate.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/core/clock-vmstate.c b/
Hi,
Just checking in, this call is scheduled for today, 3pm CEST, right?
Here is the KVM call calendar:
https://www.google.com/calendar/embed?src=dG9iMXRqcXAzN3Y4ZXZwNzRoMHE4a3BqcXNAZ3JvdXAuY2FsZW5kYXIuZ29vZ2xlLmNvbQ
On 1/6/22 12:23, Daniel P. Berrangé wrote:
> No one objected, so I think we can
That is my understanding…
See you there!
Cheers
Mark.
> On 11 Jan 2022, at 11:20, Philippe Mathieu-Daudé wrote:
>
> Hi,
>
> Just checking in, this call is scheduled for today, 3pm CEST, right?
>
> Here is the KVM call calendar:
> https://www.google.com/calendar/embed?src=dG9iMXRqcXAzN3Y4ZXZw
On 1/11/22 06:56, Cédric Le Goater wrote:
On 1/11/22 01:55, Daniel Henrique Barboza wrote:
This patch introduces pnv-phb4 user creatable devices that are created
in a similar manner as pnv-phb3 devices, allowing the user to interact
with the PHBs directly instead of creating PCI Express Contr
On Tue, Jan 11, 2022 at 11:20:54AM +0100, Philippe Mathieu-Daudé wrote:
> Hi,
>
> Just checking in, this call is scheduled for today, 3pm CEST, right?
>
> Here is the KVM call calendar:
> https://www.google.com/calendar/embed?src=dG9iMXRqcXAzN3Y4ZXZwNzRoMHE4a3BqcXNAZ3JvdXAuY2FsZW5kYXIuZ29vZ2xlLmN
On Tue, 11 Jan 2022 at 10:19, Dr. David Alan Gilbert (git)
wrote:
>
> From: "Dr. David Alan Gilbert"
>
> Add the missing VMSTATE_END_OF_LIST to vmstate_muldiv
>
> Fixes: 99abcbc7600 ("clock: Provide builtin multiplier/divider")
> Signed-off-by: Dr. David Alan Gilbert
> ---
> hw/core/clock-vmsta
Hi Jean,
On 1/11/22 11:13 AM, Jean-Philippe Brucker wrote:
> Hi Eric,
>
> On Tue, Jan 11, 2022 at 10:02:12AM +0100, Eric Auger wrote:
>> Hi Jean, Michael,
>>
>> On 9/30/21 8:50 PM, Jean-Philippe Brucker wrote:
>>> Replace the VIRTIO_IOMMU_F_BYPASS feature with
>>> VIRTIO_IOMMU_F_BYPASS_CONFIG, whi
On 1/7/22 01:17, Richard Henderson wrote:
> On 1/4/22 12:54 AM, Philippe Mathieu-Daudé wrote:
>> +if have_system or have_tools
> ...
>> if have_system
>> + stub_ss.add(files('fw_cfg.c'))
>
> Disconnect in tests?
(I assume s/tests/stubs/).
fw_cfg-interface.c exposes the fw_cfg QOM interface, w
A device of USB video class usually uses larger desc structure, so
use larger buffer to avoid failure. (dev-video.c is ready)
Allocating memory dynamically by g_malloc of the orignal version of
this change, Philippe suggested just using the stack. Test the two
versions of qemu binary, the size of
On Tue, Jan 11, 2022 at 03:35:27PM +0800, Xiaoyao Li wrote:
> Both pc and microvm have pit property individually. Let's just make it
> the property of common x86 base machine type.
>
> Signed-off-by: Xiaoyao Li
> ---
> hw/i386/microvm.c | 27 +--
> hw/i386/pc.c
On Tue, Jan 11, 2022 at 03:35:28PM +0800, Xiaoyao Li wrote:
> Legacy PIC (8259) cannot be supported for TDX guests since TDX module
> doesn't allow directly interrupt injection. Using posted interrupts
> for the PIC is not a viable option as the guest BIOS/kernel will not
> do EOI for PIC IRQs, i.
On Wed, Dec 15, 2021 at 04:31:26PM +0100, Kevin Wolf wrote:
> Am 15.12.2021 um 12:28 hat Stefan Hajnoczi geschrieben:
> > On Tue, Dec 14, 2021 at 03:59:49PM +0100, Kevin Wolf wrote:
> > > Am 14.12.2021 um 15:35 hat Stefan Hajnoczi geschrieben:
> > > > The BlockBackend root child can change when aio
Hi Peter,
On Tue, Jan 11, 2022 at 10:10:16AM +0100, Peter Lieven wrote:
Hi Stefano,
thanks for the feedback. Please note that you also need the other patch
or you will sooner or later run into another assertion as soon as rbd
snapshots are involved.
Yep, I tested with the entire series app
On Sat, 8 Jan 2022 at 06:33, Richard Henderson
wrote:
>
> Support for unaligned accesses is difficult for pre-v6 hosts.
> While debian still builds for armv4, we cannot use a compile
> time test, so test the architecture at runtime and error out.
>
> Signed-off-by: Richard Henderson
Reviewed-by:
On Sat, 8 Jan 2022 at 06:33, Richard Henderson
wrote:
>
> This is now always true, since we require armv6.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Peter Maydell
thanks
-- PMM
On Sat, 8 Jan 2022 at 06:33, Richard Henderson
wrote:
>
> This is now always true, since we require armv6.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Peter Maydell
thanks
-- PMM
On Sat, 8 Jan 2022 at 06:33, Richard Henderson
wrote:
>
> We will shortly allow the use of unaligned memory accesses,
> and these require proper alignment. Use get_alignment_bits
> to verify and remove USING_SOFTMMU.
>
> Signed-off-by: Richard Henderson
> ---
> tcg/arm/tcg-target.c.inc | 22 +++
On Mon, 10 Jan 2022 at 21:04, Michael S. Tsirkin wrote:
>
> Changes from v1:
> added tags to commit logs.
>
> The following changes since commit ca745d2277496464b54fd832c15c45d0227325bb:
>
> tests: acpi: Add updated TPM related tables (2022-01-07 19:30:13 -0500)
>
> are available in the Git repo
On Mon, 10 Jan 2022 at 19:20, Philippe Mathieu-Daudé wrote:
>
> On 1/10/22 17:02, Peter Maydell wrote:
> > On Sat, 8 Jan 2022 at 21:59, Philippe Mathieu-Daudé wrote:
> >>
> >> Hi Richard,
> >>
> >> This is the SD/MMC PR that ought to be sent previously.
> >>
> >> The following changes since commi
On Sat, 8 Jan 2022 at 06:33, Richard Henderson
wrote:
>
> From armv6, the architecture supports unaligned accesses.
> All we need to do is perform the correct alignment check
> in tcg_out_tlb_read.
>
> Signed-off-by: Richard Henderson
> ---
> tcg/arm/tcg-target.c.inc | 39 ++-
On Sat, 8 Jan 2022 at 06:33, Richard Henderson
wrote:
>
> Reserve a register for the guest_base using aarch64 for reference.
> By doing so, we do not have to recompute it for every memory load.
>
> Signed-off-by: Richard Henderson
> ---
> tcg/arm/tcg-target.c.inc | 39 +++
We're missing an unlock in case installing the signal handler failed.
Fortunately, we barely see this error in real life.
Fixes: a960d6642d39 ("util/oslib-posix: Support concurrent os_mem_prealloc()
invocation")
Fixes: CID 1468941
Cc: Paolo Bonzini
Cc: Michael S. Tsirkin
Cc: Pankaj Gupta
Cc: D
Orginal qemu commit hash: de3f5223fa4cf8bfc5e3fe1fd495ddf468edcdf7
In util/fdmon-epoll.c, function fdmon_epoll_update, variable "old_node"
maybe NULL with the condition, while it is directly used in the statement and
may lead to null pointer dereferencen problem.
Variable "r" in the condition is
On Sat, 8 Jan 2022 at 06:33, Richard Henderson
wrote:
>
> Signed-off-by: Richard Henderson
> ---
> +static void tcg_out_test_alignment(TCGContext *s, bool is_ld, TCGReg addrlo,
> + TCGReg addrhi, unsigned a_bits)
> @@ -1709,6 +1778,10 @@ static void tcg_out_qem
On Tue, 11 Jan 2022 at 10:19, Dr. David Alan Gilbert (git)
wrote:
>
> From: "Dr. David Alan Gilbert"
>
> Add the missing VMSTATE_END_OF_LIST to vmstate_muldiv
>
> Fixes: 99abcbc7600 ("clock: Provide builtin multiplier/divider")
> Signed-off-by: Dr. David Alan Gilbert
> ---
> hw/core/clock-vmsta
On 1/11/22 11:49, zhenwei pi wrote:
> A device of USB video class usually uses larger desc structure, so
> use larger buffer to avoid failure. (dev-video.c is ready)
>
> Allocating memory dynamically by g_malloc of the orignal version of
> this change, Philippe suggested just using the stack. Test
On Tue, 11 Jan 2022 at 10:54, zhenwei pi wrote:
>
> A device of USB video class usually uses larger desc structure, so
> use larger buffer to avoid failure. (dev-video.c is ready)
>
> Allocating memory dynamically by g_malloc of the orignal version of
> this change, Philippe suggested just using t
On Tue, Jan 11, 2022 at 12:21:42PM +, Peter Maydell wrote:
> On Tue, 11 Jan 2022 at 10:54, zhenwei pi wrote:
> >
> > A device of USB video class usually uses larger desc structure, so
> > use larger buffer to avoid failure. (dev-video.c is ready)
> >
> > Allocating memory dynamically by g_mall
On 1/11/22 8:25 PM, Daniel P. Berrangé wrote:
On Tue, Jan 11, 2022 at 12:21:42PM +, Peter Maydell wrote:
On Tue, 11 Jan 2022 at 10:54, zhenwei pi wrote:
A device of USB video class usually uses larger desc structure, so
use larger buffer to avoid failure. (dev-video.c is ready)
Alloca
On Montag, 10. Januar 2022 22:05:43 CET Christian Schoenebeck wrote:
> On Montag, 10. Januar 2022 21:39:28 CET Akihiko Odaki wrote:
> > On 2022/01/11 5:22, Christian Schoenebeck wrote:
> > > On Montag, 10. Januar 2022 20:01:40 CET Akihiko Odaki wrote:
> > >> On 2022/01/11 3:46, Christian Schoenebec
On Mon, Dec 27, 2021 at 10:27:33PM +0800, zhenwei pi wrote:
> A device of USB video class usually uses larger desc structure, so
> use larger buffer to avoid failure.
>
> Signed-off-by: zhenwei pi
> ---
> hw/usb/desc.c | 15 ---
> hw/usb/desc.h | 1 +
> 2 files changed, 9 insertions
On Tue, Jan 11, 2022 at 08:27:35PM +0800, zhenwei pi wrote:
>
>
> On 1/11/22 8:25 PM, Daniel P. Berrangé wrote:
> > On Tue, Jan 11, 2022 at 12:21:42PM +, Peter Maydell wrote:
> > > On Tue, 11 Jan 2022 at 10:54, zhenwei pi wrote:
> > > >
> > > > A device of USB video class usually uses large
On 1/11/22 8:38 PM, Daniel P. Berrangé wrote:
On Tue, Jan 11, 2022 at 08:27:35PM +0800, zhenwei pi wrote:
On 1/11/22 8:25 PM, Daniel P. Berrangé wrote:
On Tue, Jan 11, 2022 at 12:21:42PM +, Peter Maydell wrote:
On Tue, 11 Jan 2022 at 10:54, zhenwei pi wrote:
A device of USB video clas
The goto is not needed at all.
Signed-off-by: Juan Quintela
---
migration/ram.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index fa49d22e69..422c6bce28 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -1341,12 +1341,11 @
For fd-based shared memory, MAP_NORESERVE is only effective for hugetlb,
otherwise it's ignored. Older Linux versions that didn't support
reservation of huge pages ignored MAP_NORESERVE completely.
The first client to mmap a hugetlb fd without MAP_NORESERVE will
trigger reservation of huge pages f
So printing it as %d is wrong. Notice that for the channel id, that
is an uint8_t, but I changed it anyways for consistency.
Signed-off-by: Juan Quintela
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Peter Xu
---
migration/multifd-zlib.c | 20 ++--
migration/multifd-zstd.c
We only need last_stage in two places and we are passing it all
around. Just add a field to RAMState that passes it.
Signed-off-by: Juan Quintela
Reviewed-by: Peter Xu
---
Repeat subject (philmd suggestion)
---
migration/ram.c | 41 ++---
1 file changed, 1
On 2022/01/11 17:23, Marc-André Lureau wrote:
Hi Akihiko
On Tue, Jan 11, 2022 at 7:30 AM Akihiko Odaki wrote:
Hi,
I found this brings an inconsistency and a flaw to scanout semantics and
think the inconsistency should be fixed or this should be reverted
before the next release comes up.
Remove the mask in the call to ram_release_pages(). Nothing else does
it, and if the offset has that bits set, we have a lot of trouble.
Signed-off-by: Juan Quintela
---
migration/ram.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
ind
Remove the pages argument. And s/pages/page/
Signed-off-by: Juan Quintela
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Peter Xu
--
- Use 1LL instead of casts (philmd)
- Change the whole 1ULL for TARGET_PAGE_SIZE
Signed-off-by: Juan Quintela
---
migration/ram.c | 8
1 file chan
Hi
Changes since v2:
- rebase
- address comments
- use TARGET_PAGE_SIZE and remove casts
- remove TARGET_PAGE_MASK from compression code.
Nothing else use them. And if offsets are not aligned,
we are in big trouble.
Please, review.
Changes since v1:
- Add reviewed tags for reviewed patches
Everything use now iov's.
Signed-off-by: Juan Quintela
---
migration/multifd.h | 2 --
migration/multifd-zlib.c | 17 -
migration/multifd-zstd.c | 17 -
migration/multifd.c | 20 ++--
4 files changed, 2 insertions(+), 54 deletions(-)
di
On Dienstag, 11. Januar 2022 13:35:05 CET Christian Schoenebeck wrote:
> Curiousity was stronger: the original clang behaviour was as I explained:
> https://github.com/llvm-mirror/clang/commit/0a0d2b179085a52c10402feebeb6db8b
> 4d96a140#diff-97c4322e86bf436b7f79f4fcafc4b7beb092da08c5c23f294f98b5bb0
So we can remove the MultiFDPages.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
migration/multifd.h | 4 ++--
migration/multifd-zlib.c | 2 +-
migration/multifd-zstd.c | 2 +-
migration/multifd.c | 7 ++-
4 files changed, 6 insertions(+), 9 deletions(-)
di
We always need to call it when we find a zero page, so put it in a
single place.
Signed-off-by: Juan Quintela
Reviewed-by: Peter Xu
---
migration/ram.c | 21 ++---
1 file changed, 10 insertions(+), 11 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 422c6bce28.
On 1/11/22 13:27, zhenwei pi wrote:
> On 1/11/22 8:25 PM, Daniel P. Berrangé wrote:
>> On Tue, Jan 11, 2022 at 12:21:42PM +, Peter Maydell wrote:
>>> On Tue, 11 Jan 2022 at 10:54, zhenwei pi
>>> wrote:
A device of USB video class usually uses larger desc structure, so
use larger
On 11.01.22 13:39, David Hildenbrand wrote:
> For fd-based shared memory, MAP_NORESERVE is only effective for hugetlb,
> otherwise it's ignored. Older Linux versions that didn't support
> reservation of huge pages ignored MAP_NORESERVE completely.
>
> The first client to mmap a hugetlb fd without
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
migration/multifd-zstd.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/migration/multifd-zstd.c b/migration/multifd-zstd.c
index 97c08367d0..bd393aee0d 100644
--- a/migration/multifd-zstd.c
+++ b/m
David Gibson writes:
> On Mon, Jan 10, 2022 at 03:15:46PM -0300, Fabiano Rosas wrote:
>> There's no sc 1.
>>
>> We also only used env->nip because of the vhyp code, so change to
>> 'vector' now.
>
> I don't think this is right. The point with the env->nip change is
> changing the PC as it appea
On 1/11/22 11:19, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert"
>
> Add the missing VMSTATE_END_OF_LIST to vmstate_muldiv
>
> Fixes: 99abcbc7600 ("clock: Provide builtin multiplier/divider")
Doh I missed this too :(
Reviewed-by: Philippe Mathieu-Daudé
> Signed-off-by:
> We're missing an unlock in case installing the signal handler failed.
> Fortunately, we barely see this error in real life.
>
> Fixes: a960d6642d39 ("util/oslib-posix: Support concurrent os_mem_prealloc()
> invocation")
> Fixes: CID 1468941
> Cc: Paolo Bonzini
> Cc: Michael S. Tsirkin
> Cc: Pa
Until now, we wrote the packet header with write(), and the rest of the
pages with writev(). Just increase the size of the iovec and do a
single writev().
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
migration/multifd.c | 20
1 file changed, 8 inser
Hi
In this version
- Rebase to latest
- Address all comments from previous versions
- code cleanup
Please review.
[v2]
This is a rebase against last master.
And the reason for resend is to configure properly git-publish and
hope this time that git-publish send all the patches.
Please, review.
This patch introduces pnv-phb4 user creatable devices that are created
in a similar manner as pnv-phb3 devices, allowing the user to interact
with the PHBs directly instead of creating PCI Express Controllers that
will create a certain amount of PHBs per controller index.
We accomplish this by doi
On 1/5/22 08:25, zhenwei pi wrote:
>
> On 1/4/22 11:22 PM, Philippe Mathieu-Daudé wrote:
>> On 27/12/21 15:27, zhenwei pi wrote:
>>> A device of USB video class usually uses larger desc structure, so
>>> use larger buffer to avoid failure.
>>>
>>> Signed-off-by: zhenwei pi
>>> ---
>>> hw/usb/de
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
migration/multifd.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/migration/multifd.c b/migration/multifd.c
index 1d4885e1a0..e5b1fa5015 100644
--- a/migration/multifd.c
+++ b/migration/multifd.c
@
On Thu, 6 Jan 2022 14:33:16 -0800
Patrick Venture wrote:
> This parameter is to be used in the processor_id lower 32-bit entry in
I'd call it processor_id_lo throughout the patch
or if you prefer to keep current name, then make it support full QWORD
as spec says.
> the type 4 table. The upper
Remove the pages argument. And s/pages/page/
Signed-off-by: Juan Quintela
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Peter Xu
--
- Use 1LL instead of casts (philmd)
- Change the whole 1ULL for TARGET_PAGE_SIZE
Signed-off-by: Juan Quintela
---
migration/ram.c | 8
1 file chan
So printing it as %d is wrong. Notice that for the channel id, that
is an uint8_t, but I changed it anyways for consistency.
Signed-off-by: Juan Quintela
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Peter Xu
---
migration/multifd-zlib.c | 20 ++--
migration/multifd-zstd.c
We are only sending normal pages through multifd channels.
Later on this series, we are going to also send zero pages.
We are going to dectect if a page is zero or non zero in the multifd
channel thread, not on the main thread.
So we receive an array of pages page->offset[N]
And we will end with:
Remove the mask in the call to ram_release_pages(). Nothing else does
it, and if the offset has that bits set, we have a lot of trouble.
Signed-off-by: Juan Quintela
---
migration/ram.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
ind
We only need last_stage in two places and we are passing it all
around. Just add a field to RAMState that passes it.
Signed-off-by: Juan Quintela
Reviewed-by: Peter Xu
---
Repeat subject (philmd suggestion)
---
migration/ram.c | 41 ++---
1 file changed, 1
Signed-off-by: Juan Quintela
---
migration/migration.h | 3 +++
hw/core/machine.c | 4 +++-
migration/migration.c | 11 +++
3 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/migration/migration.h b/migration/migration.h
index 8130b703eb..638cd89b6c 100644
--- a/migratio
We always need to call it when we find a zero page, so put it in a
single place.
Signed-off-by: Juan Quintela
Reviewed-by: Peter Xu
---
migration/ram.c | 21 ++---
1 file changed, 10 insertions(+), 11 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 422c6bce28.
The goto is not needed at all.
Signed-off-by: Juan Quintela
---
migration/ram.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index fa49d22e69..422c6bce28 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -1341,12 +1341,11 @
On Tue, Jan 11, 2022 at 02:11:14PM +0100, Philippe Mathieu-Daudé wrote:
> Hi Alex,
>
> I am getting this failure for the x64-freebsd-*-build jobs [1, 2]:
>
> pkg: No packages available to install matching 'lttng-ust' have been
> found in the repositories
It was being installed fine on FreeBSD 13
It happens that there are functions to calculate the worst possible
compression size for a packet. Use them.
Suggested-by: Dr. David Alan Gilbert
Signed-off-by: Juan Quintela
---
migration/multifd-zlib.c | 4 ++--
migration/multifd-zstd.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions
So we use multifd to transmit zero pages.
Signed-off-by: Juan Quintela
---
migration/ram.c | 32 +++-
1 file changed, 31 insertions(+), 1 deletion(-)
diff --git a/migration/ram.c b/migration/ram.c
index 3536778e19..bdc7cec4cd 100644
--- a/migration/ram.c
+++ b/migrat
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
migration/multifd-zlib.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/migration/multifd-zlib.c b/migration/multifd-zlib.c
index a2fec4d01d..71480c82bb 100644
--- a/migration/multifd-zlib.c
+++ b/m
1 - 100 of 308 matches
Mail list logo
