Re: [PATCH for-7.0] hw/i386/pc: Add missing property descriptions

2022-01-05 Thread Thomas Huth
On 06/12/2021 14.42, Thomas Huth wrote: When running "qemu-system-x86_64 -M pc,help" I noticed that some properties were still missing their description. Add them now so that users get at least a slightly better idea what they are all about. Signed-off-by: Thomas Huth --- hw/i386/pc.c | 8 +++

Re: [PATCH v3 kvm/queue 14/16] KVM: Handle page fault for private memory

2022-01-05 Thread Yan Zhao
On Wed, Jan 05, 2022 at 02:28:10PM +0800, Chao Peng wrote: > On Tue, Jan 04, 2022 at 06:06:12PM +0800, Yan Zhao wrote: > > On Tue, Jan 04, 2022 at 05:10:08PM +0800, Chao Peng wrote: <...> > > Thanks. So QEMU will re-generate memslots and set KVM_MEM_PRIVATE > > accordingly? Will it involve slot de

RE: [RFC 02/10] vhost: add 3 commands for vhost-vdpa

2022-01-05 Thread longpeng2--- via
> -Original Message- > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Wednesday, January 5, 2022 3:54 PM > To: Michael S. Tsirkin > Cc: Longpeng (Mike, Cloud Infrastructure Service Product Dept.) > ; Stefan Hajnoczi ; Stefano > Garzarella ; Cornelia Huck ; pbonzini > ; Gonglei (Ar

Re: [PATCH qemu] s390x/css: fix PMCW invalid mask

2022-01-05 Thread Thomas Huth
On 16/12/2021 14.16, Nico Boehr wrote: Previously, we required bits 5, 6 and 7 to be zero (0x07 == 0b111). But, as per the principles of operation, bit 5 is ignored in MSCH and bits 0, 1, 6 and 7 need to be zero. As both PMCW_FLAGS_MASK_INVALID and ioinst_schib_valid() are only used by ioinst_ha

[PATCH 2/2] i386: Hyper-V Enlightened MSR bitmap feature

2022-01-05 Thread Vitaly Kuznetsov
The newly introduced enlightenment allow L0 (KVM) and L1 (Hyper-V) hypervisors to collaborate to avoid unnecessary updates to L2 MSR-Bitmap upon vmexits. Signed-off-by: Vitaly Kuznetsov --- docs/hyperv.txt| 10 ++ target/i386/cpu.c | 2 ++ target/i386/cpu.h

[PATCH 0/2] i386: Add support for Hyper-V Enlightened MSR-Bitmap feature

2022-01-05 Thread Vitaly Kuznetsov
The new nested specific enlightenment speeds up L2 vmexits by avoiding unnecessary updates to L2 MSR-Bitmap. Support for both VMX and SVM is coming to KVM: https://lore.kernel.org/kvm/20211129094704.326635-1-vkuzn...@redhat.com/ https://lore.kernel.org/kvm/20211220152139.418372-1-vkuzn...@redhat.co

Re: [PATCH v2] FreeBSD: Upgrade to 12.3 release

2022-01-05 Thread Alex Bennée
Brad Smith writes: > FreeBSD: Upgrade to 12.3 release > > Note, since libtasn1 was fixed in 12.3 [*], this commit re-enables GnuTLS. > > [*] https://gitlab.com/gnutls/libtasn1/-/merge_requests/71 > > > Signed-off-by: Brad Smith > Tested-by: Thomas Huth > Reviewed-by: Warner Losh Queued to t

[PATCH 1/2] i386: Use hv_build_cpuid_leaf() for HV_CPUID_NESTED_FEATURES

2022-01-05 Thread Vitaly Kuznetsov
Previously, HV_CPUID_NESTED_FEATURES.EAX CPUID leaf was handled differently as it was only used to encode the supported eVMCS version range. In fact, there are also feature (e.g. Enlightened MSR-Bitmap) bits there. In preparation to adding these features, move HV_CPUID_NESTED_FEATURES leaf handling

Re: [PATCH v2] FreeBSD: Upgrade to 12.3 release

2022-01-05 Thread Daniel P . Berrangé
On Tue, Jan 04, 2022 at 09:28:16PM -0500, Brad Smith wrote: > FreeBSD: Upgrade to 12.3 release > > Note, since libtasn1 was fixed in 12.3 [*], this commit re-enables GnuTLS. > > [*] https://gitlab.com/gnutls/libtasn1/-/merge_requests/71 > > > Signed-off-by: Brad Smith > Tested-by: Thomas Huth

Re: [RFC 02/10] vhost: add 3 commands for vhost-vdpa

2022-01-05 Thread Jason Wang
On Wed, Jan 5, 2022 at 4:37 PM Longpeng (Mike, Cloud Infrastructure Service Product Dept.) wrote: > > > > > -Original Message- > > From: Jason Wang [mailto:jasow...@redhat.com] > > Sent: Wednesday, January 5, 2022 3:54 PM > > To: Michael S. Tsirkin > > Cc: Longpeng (Mike, Cloud Infrastruc

Re: [PATCH] docs/can: convert to restructuredText

2022-01-05 Thread Thomas Huth
On 17/12/2021 22.21, oxr...@gmx.us wrote: From: Lucas Ramage Hi! Thanks for your patch! This looks like a good idea, but I think there are some minor issues which should be fixed... First: Please check your mailer setup. The mail has been sent via @gmx.us, but the Signed-off-by uses @inf

Re: [RFC 02/10] vhost: add 3 commands for vhost-vdpa

2022-01-05 Thread Michael S. Tsirkin
On Wed, Jan 05, 2022 at 03:54:13PM +0800, Jason Wang wrote: > On Wed, Jan 5, 2022 at 3:02 PM Michael S. Tsirkin wrote: > > > > On Wed, Jan 05, 2022 at 12:35:53PM +0800, Jason Wang wrote: > > > On Wed, Jan 5, 2022 at 8:59 AM Longpeng(Mike) > > > wrote: > > > > > > > > From: Longpeng > > > > > >

Re: [RFC 02/10] vhost: add 3 commands for vhost-vdpa

2022-01-05 Thread Jason Wang
On Wed, Jan 5, 2022 at 5:12 PM Michael S. Tsirkin wrote: > > On Wed, Jan 05, 2022 at 03:54:13PM +0800, Jason Wang wrote: > > On Wed, Jan 5, 2022 at 3:02 PM Michael S. Tsirkin wrote: > > > > > > On Wed, Jan 05, 2022 at 12:35:53PM +0800, Jason Wang wrote: > > > > On Wed, Jan 5, 2022 at 8:59 AM Long

Re: [PATCH v3 3/5] hw/arm/virt: Honor highmem setting when computing the memory map

2022-01-05 Thread Eric Auger
Hi Marc, On 12/27/21 10:16 PM, Marc Zyngier wrote: > Even when the VM is configured with highmem=off, the highest_gpa > field includes devices that are above the 4GiB limit. > Similarily, nothing seem to check that the memory is within > the limit set by the highmem=off option. > > This leads to f

Re: [PATCH v5 00/18] tests/docker: start using libvirt-ci's "lcitool" for dockerfiles

2022-01-05 Thread Alex Bennée
Daniel P. Berrangé writes: > Currently the tests/docker/dockerfiles/*Dockerfile recipes are all hand > written by contributors. There is a common design pattern, but the set > of packages listed for installation leaves alot to be desired Queued to testing/next, thanks. -- Alex Bennée

Re: [PATCH v3 3/5] hw/arm/virt: Honor highmem setting when computing the memory map

2022-01-05 Thread Eric Auger
Hi Marc, On 1/5/22 10:22 AM, Eric Auger wrote: > Hi Marc, > > On 12/27/21 10:16 PM, Marc Zyngier wrote: >> Even when the VM is configured with highmem=off, the highest_gpa >> field includes devices that are above the 4GiB limit. >> Similarily, nothing seem to check that the memory is within >> th

Re: [PATCH v2 1/5] hw/arm/virt: Key enablement of highmem PCIe on highmem_ecam

2022-01-05 Thread Eric Auger
Hi Marc, On 1/4/22 11:15 PM, Marc Zyngier wrote: > Hi Eric, > > On Tue, 04 Jan 2022 15:31:33 +, > Eric Auger wrote: >> Hi Marc, >> >> On 12/27/21 4:53 PM, Marc Zyngier wrote: >>> Hi Eric, >>> >>> Picking this up again after a stupidly long time... >>> >>> On Mon, 04 Oct 2021 13:00:21 +0100, >

Re: [PATCH] gitlab-ci: Enable docs in the centos job

2022-01-05 Thread Alex Bennée
Thomas Huth writes: > We just ran into a problem that the docs don't build on RHEL8 / CentOS 8 > anymore. Seems like these distros are using one of the oldest Sphinx > versions that we still have to support. Thus enable the docs build in > the CI on CentOS so that such bugs don't slip in so eas

Re: [PATCH] docker: include bison in debian-tricore-cross

2022-01-05 Thread Alex Bennée
Paolo Bonzini writes: > Binutils sometimes fail to build if bison is not installed: > > /bin/sh ./ylwrap `test -f arparse.y || echo ./`arparse.y y.tab.c arparse.c > y.tab.h arparse.h y.output arparse.output -- -d > ./ylwrap: 109: ./ylwrap: -d: not found > > (the correct invocation of ylwr

Re: [PATCH] linux-user: Remove the deprecated ppc64abi32 target

2022-01-05 Thread Alex Bennée
Thomas Huth writes: > It's likely broken, and nobody cared for picking it up again > during the deprecation phase, so let's remove this now. > > Since this is the last entry in deprecated_targets_list, remove > the related code in the configure script, too. > > Signed-off-by: Thomas Huth Queu

Re: [RFC 03/10] vdpa: add the infrastructure of vdpa-dev

2022-01-05 Thread Stefan Hajnoczi
On Wed, Jan 05, 2022 at 08:58:53AM +0800, Longpeng(Mike) wrote: > +static const VirtioPCIDeviceTypeInfo vhost_vdpa_device_pci_info = { > +.base_name = TYPE_VHOST_VDPA_DEVICE_PCI, > +.generic_name= "vhost-vdpa-device-pci", > +.transitional_name = "vhost-vd

[PATCH 1/2] target/ppc: Add popcntb instruction to POWER5+ processors

2022-01-05 Thread Cédric Le Goater
popcntb instruction was added in ISA v2.02. Add support for POWER5+ processors since they implement ISA v2.03. PPC970 CPUs implement v2.01 and do not support popcntb. Signed-off-by: Cédric Le Goater --- target/ppc/cpu_init.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/ppc/cpu_ini

[PATCH] MAINTAINERS: Add entry for QEMU Guest Agent Windows components

2022-01-05 Thread Kostiantyn Kostiuk
Signed-off-by: Kostiantyn Kostiuk --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index f871d759fd..1f255ec874 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2729,6 +2729,14 @@ F: scripts/qemu-guest-agent/ F: tests/unit/test-qga.c T: git htt

[PATCH 0/2] spapr: Fix support of POWER5+ processors

2022-01-05 Thread Cédric Le Goater
Hello, Grab the images under : https://github.com/legoater/qemu-ppc-boot/tree/main/buildroot/qemu_ppc64_pseries_p5p-2021.11-730-g4f325ce788-20220104 and run with : qemu-system-ppc64 -M pseries -cpu POWER5+ -m 1G -smp 2 -kernel ./vmlinux -append "root=/dev/sda" -drive file=./rootfs.ext2,i

[PATCH 2/2] spapr: Fix support of POWER5+ processors

2022-01-05 Thread Cédric Le Goater
POWER5+ (ISA v2.03) processors are supported by the pseries machine but they do not have Altivec instructions. Do not advertise support for it in the DT. To be noted that this test is in contradiction with the assert in cap_vsx_apply(). Signed-off-by: Cédric Le Goater --- hw/ppc/spapr.c | 10 ++

Re: [RFC 04/10] vdpa-dev: implement the instance_init/class_init interface

2022-01-05 Thread Stefan Hajnoczi
On Wed, Jan 05, 2022 at 08:58:54AM +0800, Longpeng(Mike) wrote: > From: Longpeng > > Implements the .instance_init and the .class_init interface. > > Signed-off-by: Longpeng > --- > hw/virtio/vdpa-dev-pci.c | 80 +++- > hw/virtio/vdpa-dev.c | 68

Re: [PATCH v2] FreeBSD: Upgrade to 12.3 release

2022-01-05 Thread Philippe Mathieu-Daudé
On 1/5/22 03:28, Brad Smith wrote: > FreeBSD: Upgrade to 12.3 release > > Note, since libtasn1 was fixed in 12.3 [*], this commit re-enables GnuTLS. > > [*] https://gitlab.com/gnutls/libtasn1/-/merge_requests/71 > > > Signed-off-by: Brad Smith > Tested-by: Thomas Huth > Reviewed-by: Warner Lo

Re: [PATCH] common-user: Really fix i386 calls to safe_syscall_set_errno_tail

2022-01-05 Thread Philippe Mathieu-Daudé
On 1/5/22 06:23, Richard Henderson wrote: > Brown bag time: offset 0 from esp is the return address, > offset 4 is the first argument. > > Fixes: d7478d4229f0 ("common-user: Fix tail calls to > safe_syscall_set_errno_tail") > Signed-off-by: Richard Henderson > --- > > Ho hum. I'm disappointed

Re: [PATCH v4 1/2] linux-user: add sched_getattr support

2022-01-05 Thread Laurent Vivier
Le 05/01/2022 à 05:18, Tonis Tiigi a écrit : These syscalls are not exposed by glibc. The struct type need to be redefined as it can't be included directly before https://lkml.org/lkml/2020/5/28/810 . sched_attr type can grow in future kernel versions. When client sends values that QEMU does not

Re: [PATCH v4 2/2] linux-user: call set/getscheduler set/getparam directly

2022-01-05 Thread Laurent Vivier
Le 05/01/2022 à 05:18, Tonis Tiigi a écrit : There seems to be difference in syscall and libc definition of these methods and therefore musl does not implement them (1e21e78bf7). Call syscall directly to ensure the behavior of the libc of user application, not the libc that was used to build QEMU

Re: [PATCH v4 1/2] linux-user: add sched_getattr support

2022-01-05 Thread Laurent Vivier
Le 05/01/2022 à 05:18, Tonis Tiigi a écrit : These syscalls are not exposed by glibc. The struct type need to be redefined as it can't be included directly before https://lkml.org/lkml/2020/5/28/810 . sched_attr type can grow in future kernel versions. When client sends values that QEMU does not

Re: [PATCH v4 2/2] linux-user: call set/getscheduler set/getparam directly

2022-01-05 Thread Laurent Vivier
Le 05/01/2022 à 05:18, Tonis Tiigi a écrit : There seems to be difference in syscall and libc definition of these methods and therefore musl does not implement them (1e21e78bf7). Call syscall directly to ensure the behavior of the libc of user application, not the libc that was used to build QEMU

Re: [PATCH] gitlab-ci: Enable docs in the centos job

2022-01-05 Thread Thomas Huth
On 05/01/2022 10.44, Alex Bennée wrote: Thomas Huth writes: We just ran into a problem that the docs don't build on RHEL8 / CentOS 8 anymore. Seems like these distros are using one of the oldest Sphinx versions that we still have to support. Thus enable the docs build in the CI on CentOS so t

Re: [RFC 05/10] vdpa-dev: implement the realize interface

2022-01-05 Thread Stefan Hajnoczi
On Wed, Jan 05, 2022 at 08:58:55AM +0800, Longpeng(Mike) wrote: > From: Longpeng > > Implements the .realize interface. > > Signed-off-by: Longpeng > --- > hw/virtio/vdpa-dev.c | 114 +++ > include/hw/virtio/vdpa-dev.h | 8 +++ > 2 files changed, 122 i

Re: [RFC 00/10] add generic vDPA device support

2022-01-05 Thread Stefan Hajnoczi
On Wed, Jan 05, 2022 at 08:58:50AM +0800, Longpeng(Mike) wrote: > From: Longpeng > > Hi guys, > > This patchset tries to support the generic vDPA device, the previous > disscussion can be found here [1]. > > With the generic vDPA device, QEMU won't need to touch the device > types any more, suc

Re: [PATCH] linux-user/syscall.c: fix missed flag for shared memory in open_self_maps

2022-01-05 Thread Laurent Vivier
Le 27/12/2021 à 13:50, Andrey Kazmin a écrit : The possible variants for region type in /proc/self/maps are either private "p" or shared "s". In the current implementation, we mark shared regions as "-". It could break memory mapping parsers such as included into ASan/HWASan sanitizers. Signed-o

Re: [PATCH] linux-user/signal: Map exit signals in SIGCHLD siginfo_t

2022-01-05 Thread Laurent Vivier
Le 23/10/2021 à 21:59, Matthias Schiffer a écrit : When converting a siginfo_t from waitid(), the interpretation of si_status depends on the value of si_code: For CLD_EXITED, it is an exit code and should be copied verbatim. For other codes, it is a signal number (possibly with additional high bi

Re: [PATCH 2/3] linux-user: netlink: Add IFLA_VFINFO_LIST

2022-01-05 Thread Laurent Vivier
Le 19/12/2021 à 16:45, Laurent Vivier a écrit : # QEMU_LOG=unimp ip a Unknown host QEMU_IFLA type: 22 Signed-off-by: Laurent Vivier --- linux-user/fd-trans.c | 174 ++ 1 file changed, 174 insertions(+) diff --git a/linux-user/fd-trans.c b/linux-

Re: [PATCH v2 1/7] linux-user/nios2: Properly emulate EXCP_TRAP

2022-01-05 Thread Laurent Vivier
Le 21/12/2021 à 03:50, Richard Henderson a écrit : The real kernel has to load the instruction and extract the imm5 field; for qemu, modify the translator to do this. The use of R_AT for this in cpu_loop was a bug. Handle the other trap numbers as per the kernel's trap_table. Reviewed-by: Alex

Re: [PATCH v2 2/7] linux-user/nios2: Fixes for signal frame setup

2022-01-05 Thread Laurent Vivier
Le 21/12/2021 à 03:50, Richard Henderson a écrit : Do not confuse host and guest addresses. Lock and unlock the target_rt_sigframe structure in setup_rt_sigframe. Since rt_setup_ucontext always returns 0, drop the return value entirely. This eliminates the only write to the err variable in set

Re: [PATCH v2 6/7] linux-user/nios2: Fix sigmask in setup_rt_frame

2022-01-05 Thread Laurent Vivier
Le 21/12/2021 à 03:50, Richard Henderson a écrit : Do not cast the signal mask elements; trust __put_user. Reviewed-by: Laurent Vivier Signed-off-by: Richard Henderson --- linux-user/nios2/signal.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/linux-user/nios2/signal

[PATCH] docs/system/ppc: Merge the PEF information into the pseries page

2022-01-05 Thread Thomas Huth
The Protected Execution Facility is only available with the pseries machine, so let's merge the old ASCII text into the new RST file now. Signed-off-by: Thomas Huth --- docs/papr-pef.txt | 30 -- docs/system/ppc/pseries.rst | 33 +

Re: [PATCH v2 3/7] linux-user/elfload: Rename ARM_COMMPAGE to HI_COMMPAGE

2022-01-05 Thread Laurent Vivier
Le 21/12/2021 à 03:50, Richard Henderson a écrit : Arm will no longer be the only target requiring a commpage, but it will continue to be the only target placing the page at the high end of the address space. Reviewed-by: Laurent Vivier Signed-off-by: Richard Henderson --- linux-user/elfload

Re: [PATCH] linux-user/syscall.c: malloc to g_try_malloc

2022-01-05 Thread Laurent Vivier
Le 04/01/2022 à 15:38, Ahmed Abouzied a écrit : Use g_try_malloc instead of malloc to alocate the target ifconfig. Also replace the corresponding free with g_free. Signed-off-by: Ahmed Abouzied --- Hello, I noticed that there was a `malloc` call in this file. It seems that it was added by the

Re: [PATCH v2 7/7] linux-user/nios2: Use set_sigmask in do_rt_sigreturn

2022-01-05 Thread Laurent Vivier
Le 21/12/2021 à 03:50, Richard Henderson a écrit : Using do_sigprocmask directly was incorrect, as it will leave the signal blocked by the outer layers of linux-user. Reviewed-by: Laurent Vivier Signed-off-by: Richard Henderson --- linux-user/nios2/signal.c | 2 +- linux-user/signal.c

Re: [PATCH v2 4/7] linux-user/nios2: Map a real kuser page

2022-01-05 Thread Laurent Vivier
Le 21/12/2021 à 03:50, Richard Henderson a écrit : The first word of page1 is data, so the whole thing can't be implemented with emulation of addresses. Use init_guest_commpage for the allocation. Hijack trap number 16 to implement cmpxchg. Signed-off-by: Richard Henderson --- linux-user/elf

Re: [PATCH 3/3] linux-user: netlink: update IFLA_BRPORT entries

2022-01-05 Thread Laurent Vivier
Le 19/12/2021 à 16:45, Laurent Vivier a écrit : add IFLA_BRPORT_MCAST_EHT_HOSTS_LIMIT and IFLA_BRPORT_MCAST_EHT_HOSTS_CNT # QEMU_LOG=unimp ip a Unknown QEMU_IFLA_BRPORT type 37 Unknown QEMU_IFLA_BRPORT type 38 Signed-off-by: Laurent Vivier --- linux-user/fd-trans.c | 4 1 file

RE: [PATCH v4 07/14] vfio-user: run vfio-user context

2022-01-05 Thread Thanos Makatos
> -Original Message- > From: Jag Raman > Sent: 17 December 2021 18:00 > To: Stefan Hajnoczi ; John Levon > ; Thanos Makatos > Cc: qemu-devel ; Alex Williamson > ; Marc-André Lureau > ; Philippe Mathieu-Daudé > ; pbonz...@redhat.com; alex.ben...@linaro.org; > th...@redhat.com; cr...@redh

Re: [PATCH v2 5/7] linux-user/nios2: Fix EA vs PC confusion

2022-01-05 Thread Laurent Vivier
Le 21/12/2021 à 03:50, Richard Henderson a écrit : The real kernel will talk about the user PC as EA, because that's where the hardware will have copied it, and where it expects to put it to then use ERET. But qemu does not emulate all of the exception stuff while emulating user-only. Manipulate

Re: [PATCH 1/3] linux-user: netlink: update IFLA entries

2022-01-05 Thread Laurent Vivier
Le 19/12/2021 à 16:45, Laurent Vivier a écrit : Add IFLA_PHYS_PORT_ID, IFLA_PARENT_DEV_NAME, IFLA_PARENT_DEV_BUS_NAME # QEMU_LOG=unimp ip a Unknown host QEMU_IFLA type: 56 Unknown host QEMU_IFLA type: 57 Unknown host QEMU_IFLA type: 34 Signed-off-by: Laurent Vivier --- linux-user

Re: [RFC 01/10] virtio: get class_id and pci device id by the virtio id

2022-01-05 Thread Cornelia Huck
On Wed, Jan 05 2022, "Longpeng(Mike)" wrote: > From: Longpeng > > Add helpers to get the "Transitional PCI Device ID" and "class_id" of the > deivce which is specificed by the "Virtio Device ID". > > These helpers will be used to build the generic vDPA device later. > > Signed-off-by: Longpeng

[PATCH] MAINTAINERS: Improve the PowerPC machines section

2022-01-05 Thread Thomas Huth
Add some documentation files to the corresponding machine sections and mention the machine names in the section titles where it is not so obvious (e.g. that "taihu" is a 405 machine). Signed-off-by: Thomas Huth --- MAINTAINERS | 12 1 file changed, 8 insertions(+), 4 deletions(-) d

Re: [RFC 1/5] libvhost-user: Add vu_rem_mem_reg input validation

2022-01-05 Thread Stefan Hajnoczi
On Wed, Dec 15, 2021 at 10:29:48PM +, Raphael Norwitz wrote: > Signed-off-by: Raphael Norwitz > --- > subprojects/libvhost-user/libvhost-user.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/subprojects/libvhost-user/libvhost-user.c > b/subprojects/libvhost-user/libvhost-use

Re: [RFC 2/5] libvhost-user: Add vu_add_mem_reg input validation

2022-01-05 Thread Stefan Hajnoczi
On Wed, Dec 15, 2021 at 10:29:51PM +, Raphael Norwitz wrote: > Signed-off-by: Raphael Norwitz > --- > subprojects/libvhost-user/libvhost-user.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/subprojects/libvhost-user/libvhost-user.c > b/subprojects/libvhost-user/libvhost-use

Re: [RFC 3/5] libvhost-user: Simplify VHOST_USER_REM_MEM_REG

2022-01-05 Thread Stefan Hajnoczi
On Wed, Dec 15, 2021 at 10:29:52PM +, Raphael Norwitz wrote: > From: David Hildenbrand > > Let's avoid having to manually copy all elements. Copy only the ones > necessary to close the hole and perform the operation in-place without > a second array. > > Signed-off-by: David Hildenbrand > S

Re: [RFC 4/5] libvhost-user: prevent over-running max RAM slots

2022-01-05 Thread Stefan Hajnoczi
On Wed, Dec 15, 2021 at 10:29:54PM +, Raphael Norwitz wrote: > When VHOST_USER_PROTOCOL_F_CONFIGURE_MEM_SLOTS support was added to > libvhost-user, no guardrails were added to protect against QEMU > attempting to hot-add too many RAM slots to a VM with a libvhost-user > based backed attached. >

[PATCH] ide: Explicitly poll for BHs on cancel

2022-01-05 Thread Hanna Reitz
When we still have an AIOCB registered for DMA operations, we try to settle the respective operation by draining the BlockBackend associated with the IDE device. However, this assumes that every DMA operation is associated with some I/O operation on the BlockBackend, and so settling the latter wil

Re: [RFC 06/10] vdpa-dev: implement the unrealize interface

2022-01-05 Thread Stefano Garzarella
On Wed, Jan 05, 2022 at 08:58:56AM +0800, Longpeng(Mike) wrote: From: Longpeng Implements the .unrealize interface. Signed-off-by: Longpeng --- hw/virtio/vdpa-dev.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/hw/virtio/vdpa-dev.c b/hw/virtio/vdpa-

Re: [RFC 5/5] libvhost-user: handle removal of identical regions

2022-01-05 Thread Stefan Hajnoczi
On Wed, Dec 15, 2021 at 10:29:55PM +, Raphael Norwitz wrote: > diff --git a/subprojects/libvhost-user/libvhost-user.c > b/subprojects/libvhost-user/libvhost-user.c > index 74a9980194..2f465a4f0e 100644 > --- a/subprojects/libvhost-user/libvhost-user.c > +++ b/subprojects/libvhost-user/libvhost

Re: [RFC 04/10] vdpa-dev: implement the instance_init/class_init interface

2022-01-05 Thread Stefano Garzarella
On Wed, Jan 05, 2022 at 08:58:54AM +0800, Longpeng(Mike) wrote: From: Longpeng Implements the .instance_init and the .class_init interface. Signed-off-by: Longpeng --- hw/virtio/vdpa-dev-pci.c | 80 +++- hw/virtio/vdpa-dev.c | 68

[PATCH] docs: reSTify virtio-balloon-stats documentation and move to docs/interop

2022-01-05 Thread Thomas Huth
The virtio-balloon-stats documentation might be useful for people that are implementing software that talks to QEMU via QMP, so this should reside in the docs/interop/ directory. While we're at it, also convert the file to restructured text and mention it in the MAINTAINERS file. Signed-off-by: Th

Re: [PATCH] optionrom: Turn off -fcf-protection

2022-01-05 Thread Stefano Garzarella
CCing Paolo On Mon, Jan 03, 2022 at 10:01:12AM +0100, Björn Töpel wrote: Ubuntu GCC enables -fcf-protection globally, which is not supported for x86 16-bit (realmode). This causes the build to fail. This commit turns off that option. Signed-off-by: Björn Töpel --- pc-bios/optionrom/Makefile |

Re: [PATCH 5/6] docs/qdev-device-use: Add CanoKey to QDEV devices examples

2022-01-05 Thread Thomas Huth
On 23/12/2021 18.17, Hongren (Zenithal) Zheng wrote: Signed-off-by: Hongren (Zenithal) Zheng --- docs/qdev-device-use.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/qdev-device-use.txt b/docs/qdev-device-use.txt index 2408889334..278fb66c0a 100644 --- a/docs/qdev-device-use.txt

Re: [RFC 02/10] vhost: add 3 commands for vhost-vdpa

2022-01-05 Thread Michael S. Tsirkin
On Wed, Jan 05, 2022 at 05:09:07PM +0800, Jason Wang wrote: > On Wed, Jan 5, 2022 at 4:37 PM Longpeng (Mike, Cloud Infrastructure > Service Product Dept.) wrote: > > > > > > > > > -Original Message- > > > From: Jason Wang [mailto:jasow...@redhat.com] > > > Sent: Wednesday, January 5, 2022

Re: [PATCH] docs/sphinx: fix compatibility with sphinx < 1.8

2022-01-05 Thread Alex Bennée
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > SphinxDirective was added with sphinx 1.8 (2018-09-13). > > Reported-by: Thomas Huth > Signed-off-by: Marc-André Lureau Queued to testing/next (as I need it for Thomas's API updates), thanks. -- Alex Bennée

[PULL 0/8] Misc patches (tests, docs, compat machines)

2022-01-05 Thread Thomas Huth
Hi! The following changes since commit fb084237a3b78b20fd9d888dffd673b6656ea3be: common-user: Really fix i386 calls to safe_syscall_set_errno_tail (2022-01-04 21:14:23 -0800) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull-request-2022-01-05 for you to

[PULL 1/8] hw: Add compat machines for 7.0

2022-01-05 Thread Thomas Huth
From: Cornelia Huck Add 7.0 machine types for arm/i440fx/q35/s390x/spapr. Signed-off-by: Cornelia Huck Reviewed-by: Juan Quintela Reviewed-by: Andrew Jones Reviewed-by: Daniel P. Berrangé Reviewed-by: Christian Borntraeger Acked-by: Cédric Le Goater Message-Id: <20211217143948.289995-1-coh

[PULL 3/8] tests/qtest/hd-geo-test: Check for the lsi53c895a controller before using it

2022-01-05 Thread Thomas Huth
The lsi53c895a SCSI controller might have been disabled in the target binary, so let's check for its availability first before using it. Message-Id: <20211222153600.976588-1-th...@redhat.com> Signed-off-by: Thomas Huth --- tests/qtest/hd-geo-test.c | 8 +--- 1 file changed, 5 insertions(+),

[PULL 5/8] qemu-options: Remove the deprecated -no-quit option

2022-01-05 Thread Thomas Huth
This option was just a wrapper around the -display ...,window-close=off parameter, and the name "no-quit" is rather confusing compared to "window-close" (since there are still other means to quit the emulator), so let's remove this now. Message-Id: <20211215082417.180735-1-th...@redhat.com> Acked-

[PATCH 1/1] softmmu: fix device deletion events with -device JSON syntax

2022-01-05 Thread Daniel P . Berrangé
The -device JSON syntax impl leaks a reference on the created DeviceState instance. As a result when you hot-unplug the device, the device_finalize method won't be called and thus it will fail to emit the required DEVICE_DELETED event. A 'json-cli' feature was previously added against the 'device_

[PULL 2/8] tests/qtest/test-x86-cpuid-compat: Check for machines before using them

2022-01-05 Thread Thomas Huth
The user might have disabled the pc-i440fx machine type (or it's older versions, like done in downstream RHEL) in the QEMU binary, so let's better check whether the machine types are available before using them. Message-Id: <20211222153923.1000420-1-th...@redhat.com> Reviewed-by: Igor Mammedov Si

[PULL 4/8] tests/unit/test-util-sockets: Use g_file_open_tmp() to create temp file

2022-01-05 Thread Thomas Huth
From: Philippe Mathieu-Daudé Similarly to commit e63ed64c6d1 ("tests/qtest/virtio-net-failover: Use g_file_open_tmp() to create temporary file"), avoid calling g_test_rand_int() before g_test_init(): use g_file_open_tmp(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Me

[PATCH 0/1] Fix -device JSON support wrt hotplug

2022-01-05 Thread Daniel P . Berrangé
Libvirt switched to using -device JSON support, but we discovered in testing that it is broken for hotplug, never sending DEVICE_DELETED events. This is caused by a subtle refcount leak. Daniel P. Berrangé (1): softmmu: fix device deletion events with -device JSON syntax qapi/qdev.json

[PULL 7/8] gitlab-ci: Enable docs in the centos job

2022-01-05 Thread Thomas Huth
We just ran into a problem that the docs don't build on RHEL8 / CentOS 8 anymore. Seems like these distros are using one of the oldest Sphinx versions that we still have to support. Thus enable the docs build in the CI on CentOS so that such bugs don't slip in so easily again. Message-Id: <2022010

[PULL 6/8] docs/sphinx: fix compatibility with sphinx < 1.8

2022-01-05 Thread Thomas Huth
From: Marc-André Lureau SphinxDirective was added with sphinx 1.8 (2018-09-13). Reported-by: Thomas Huth Signed-off-by: Marc-André Lureau Tested-by: Thomas Huth Message-Id: <20220104074649.1712440-1-marcandre.lur...@redhat.com> Signed-off-by: Thomas Huth --- docs/sphinx/fakedbusdoc.py | 4 +

RE: [PATCH v2 1/5] RISC-V: larger and more consistent register set for 'info registers'

2022-01-05 Thread Schwarz, Konrad
> -Original Message- > From: Richard Henderson > Sent: Tuesday, January 4, 2022 21:57 > Subject: Re: [PATCH v2 1/5] RISC-V: larger and more consistent register set > for 'info registers' > > On 1/4/22 7:51 AM, Konrad Schwarz wrote: > > static const int dump_csrs[] = { > > + > >

[PULL 8/8] docs/tools/qemu-trace-stap.rst: Do not hard-code the QEMU binary name

2022-01-05 Thread Thomas Huth
In downstream, we want to use a different name for the QEMU binary, and some people might also use the docs for non-x86 binaries, that's why we already created the |qemu_system| placeholder in the past. Use it now in the stap trace doc, too. Message-Id: <20220104103319.179870-1-th...@redhat.com> R

Re: [PATCH] MAINTAINERS: Improve the PowerPC machines section

2022-01-05 Thread Daniel Henrique Barboza
On 1/5/22 07:48, Thomas Huth wrote: Add some documentation files to the corresponding machine sections and mention the machine names in the section titles where it is not so obvious (e.g. that "taihu" is a 405 machine). Signed-off-by: Thomas Huth --- Reviewed-by: Daniel Henrique Barboza

Re: [PATCH 1/1] softmmu: fix device deletion events with -device JSON syntax

2022-01-05 Thread Thomas Huth
On 05/01/2022 13.38, Daniel P. Berrangé wrote: The -device JSON syntax impl leaks a reference on the created DeviceState instance. As a result when you hot-unplug the device, the device_finalize method won't be called and thus it will fail to emit the required DEVICE_DELETED event. A 'json-cli'

Re: [PATCH] docs/system/ppc: Merge the PEF information into the pseries page

2022-01-05 Thread Daniel Henrique Barboza
On 1/5/22 07:32, Thomas Huth wrote: The Protected Execution Facility is only available with the pseries machine, so let's merge the old ASCII text into the new RST file now. Signed-off-by: Thomas Huth --- Well observed. Thanks for fixing it. Reviewed-by: Daniel Henrique Barboza doc

RE: [PATCH v2 3/5] RISC-V: 'info gmem' to show hypervisor guest -> physical address translations

2022-01-05 Thread Schwarz, Konrad
> -Original Message- > From: Alistair Francis > Sent: Tuesday, January 4, 2022 23:03 > On Wed, Jan 5, 2022 at 1:55 AM Konrad Schwarz > wrote: > > > > This is analog to the existing 'info mem' command and is implemented > > using the same machinery. > > hmp-commands-info.hx | 16

RE: [PATCH v2 4/5] RISC-V: Typed CSRs in gdbserver

2022-01-05 Thread Schwarz, Konrad
Hi, > -Original Message- > From: Alistair Francis > Sent: Tuesday, January 4, 2022 23:12 > To: Schwarz, Konrad (T CED SES-DE) > Subject: Re: [PATCH v2 4/5] RISC-V: Typed CSRs in gdbserver > > On Wed, Jan 5, 2022 at 1:56 AM Konrad Schwarz > wrote: > > diff --git a/target/riscv/csr.c b/t

Re: [PATCH 1/2] target/ppc: Add popcntb instruction to POWER5+ processors

2022-01-05 Thread Fabiano Rosas
Cédric Le Goater writes: > popcntb instruction was added in ISA v2.02. Add support for POWER5+ > processors since they implement ISA v2.03. > > PPC970 CPUs implement v2.01 and do not support popcntb. > > Signed-off-by: Cédric Le Goater Reviewed-by: Fabiano Rosas

Re: [PATCH 2/2] spapr: Fix support of POWER5+ processors

2022-01-05 Thread Fabiano Rosas
Cédric Le Goater writes: > POWER5+ (ISA v2.03) processors are supported by the pseries machine > but they do not have Altivec instructions. Do not advertise support > for it in the DT. > > To be noted that this test is in contradiction with the assert in > cap_vsx_apply(). > > Signed-off-by: Cédr

[PATCH v1 05/34] ci: explicitly skip I/O tests on alpine

2022-01-05 Thread Alex Bennée
From: Daniel P. Berrangé The block I/O tests don't work on Alpine because their alternative libc impl emits different strings for errnos, which breaks the expected output matching. e.g. === IO: pattern 102 wrote 512/512 bytes at offset 512 512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/

[PATCH v1 02/34] spice: Update QXLInterface for spice >= 0.15.0

2022-01-05 Thread Alex Bennée
From: John Snow spice updated the spelling (and arguments) of "attache_worker" in 0.15.0. Update QEMU to match, preventing -Wdeprecated-declarations compilations from reporting build errors. See also: https://gitlab.freedesktop.org/spice/spice/-/commit/974692bda1e77af92b71ed43b022439448492cb9 R

[PATCH v1 01/34] ui: avoid compiler warnings from unused clipboard info variable

2022-01-05 Thread Alex Bennée
From: Daniel P. Berrangé With latest clang 13.0.0 we get ../ui/clipboard.c:47:34: error: variable 'old' set but not used [-Werror,-Wunused-but-set-variable] g_autoptr(QemuClipboardInfo) old = NULL; ^ The compiler can't tell that we only declared this variab

[PATCH v1 00/34] testing/next and other misc fixes

2022-01-05 Thread Alex Bennée
Hi, Happy New Year QEMU developers. To get our new year off to a quick start here are a bunch of testing and testing adjacent updates. There are some miscellaneous updates touching linux-user, ARM virt, and various other minor code tweaks and cleanups. If maintainers want to take via their own tre

[PATCH v1 06/34] tests/docker: switch fedora image to release 35

2022-01-05 Thread Alex Bennée
From: Daniel P. Berrangé The Fedora 33 release is shortly end of life. Switch to the newest Fedora 35 to maximise lifespan until we need to update again. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé Signed-off-by: Alex Bennée Message

[PATCH v1 11/34] tests/docker: auto-generate ubuntu2004.docker with lcitool

2022-01-05 Thread Alex Bennée
From: Daniel P. Berrangé This commit is best examined using the "-b" option to diff. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé Signed-off-by: Alex Bennée Message-Id: <20211215141949.3512719-12-berra...@redhat.com> --- tests/docker/dockerfiles/ubuntu2004.docker | 2

[PATCH v1 03/34] meson: require liburing >= 0.3

2022-01-05 Thread Alex Bennée
From: Daniel P. Berrangé openSUSE Leap 15.2 ships with liburing == 0.2 against which QEMU fails to build. ../util/fdmon-io_uring.c: In function ‘fdmon_io_uring_need_wait’: ../util/fdmon-io_uring.c:305:9: error: implicit declaration of function ‘io_uring_sq_ready’; did you mean ‘io_uring_cq_read

[PATCH v1 27/34] tests/avocado: add :avocado: tags for some tests

2022-01-05 Thread Alex Bennée
This stops a bunch of tests failing because of a lack of "./qemu-system-x86-64" in a build directory where you have configured only one non-default target. I suspect what we really need is: :avocado: tags=arch:host to be properly multi-arch safe. Signed-off-by: Alex Bennée --- tests/avocad

[PATCH v1 07/34] tests: integrate lcitool for generating build env manifests

2022-01-05 Thread Alex Bennée
From: Daniel P. Berrangé This introduces https://gitlab.com/libvirt/libvirt-ci as a git submodule at tests/lcitool/libvirt-ci The 'lcitool' program within this submodule will be used to automatically generate build environment manifests from a definition of requirements in tests/lcitool/proj

[PATCH v1 28/34] tests/tcg/multiarch: Read fp flags before printf

2022-01-05 Thread Alex Bennée
From: Richard Henderson We need to read the floating-point flags before printf may do other floating-point operations which may affect the flags. Hexagon reference files regenerated by Taylor Simpson. Signed-off-by: Taylor Simpson Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu

[PATCH v1 09/34] tests/docker: auto-generate fedora.docker with lcitool

2022-01-05 Thread Alex Bennée
From: Daniel P. Berrangé This commit is best examined using the "-b" option to diff. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé Signed-off-by: Alex Bennée Message-Id: <20211215141949.3512719-10-berra...@redhat.com> --- tests/docker/dockerfiles/fedora.docker | 260 +

Re: [PATCH] ide: Explicitly poll for BHs on cancel

2022-01-05 Thread Hanna Reitz
On 05.01.22 12:13, Hanna Reitz wrote: [...] Perhaps for a lack of being aware of all the kinds of tests we have, I found it impossible to write a reproducer in any of our current test frameworks: From how I understand the issue, to reproduce it, you need to issue a TRIM request and immediately

[PATCH v1 33/34] docker: include bison in debian-tricore-cross

2022-01-05 Thread Alex Bennée
From: Paolo Bonzini Binutils sometimes fail to build if bison is not installed: /bin/sh ./ylwrap `test -f arparse.y || echo ./`arparse.y y.tab.c arparse.c y.tab.h arparse.h y.output arparse.output -- -d ./ylwrap: 109: ./ylwrap: -d: not found (the correct invocation of ylwrap would have "b

[PATCH v1 12/34] tests/docker: auto-generate opensuse-leap.docker with lcitool

2022-01-05 Thread Alex Bennée
From: Daniel P. Berrangé This commit is best examined using the "-b" option to diff. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé Signed-off-by: Alex Bennée Message-Id: <20211215141949.3512719-13-berra...@redhat.com> --- tests/docker/dockerfiles/opensuse-leap.docker

[PATCH v1 32/34] gitlab-ci: Enable docs in the centos job

2022-01-05 Thread Alex Bennée
From: Thomas Huth We just ran into a problem that the docs don't build on RHEL8 / CentOS 8 anymore. Seems like these distros are using one of the oldest Sphinx versions that we still have to support. Thus enable the docs build in the CI on CentOS so that such bugs don't slip in so easily again.

[PATCH v1 34/34] linux-user: Remove the deprecated ppc64abi32 target

2022-01-05 Thread Alex Bennée
From: Thomas Huth It's likely broken, and nobody cared for picking it up again during the deprecation phase, so let's remove this now. Since this is the last entry in deprecated_targets_list, remove the related code in the configure script, too. Signed-off-by: Thomas Huth Reviewed-by: Richard

  1   2   3   >