On Wed, Dec 15, 2021 at 10:35:32AM -0500, Jagannathan Raman wrote:
> Define and register handlers for PCI config space accesses
>
> Signed-off-by: Elena Ufimtseva
> Signed-off-by: John G Johnson
> Signed-off-by: Jagannathan Raman
> ---
> hw/remote/vfio-user-obj.c | 45 +
15.12.2021 22:39, John Snow wrote:
With the old library gone, there's nothing duplicated in the tree, so
the warning suppression can be removed.
Signed-off-by: John Snow
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
15.12.2021 22:39, John Snow wrote:
Now that we are fully switched over to the new QMP library, move it back
over the old namespace. This is being done primarily so that we may
upload this package simply as "qemu.qmp" without introducing confusion
over whether or not "aqmp" is a new protocol or no
On Thu, Dec 16, 2021 at 11:30:20AM +, Stefan Hajnoczi wrote:
> > +ret = vfu_setup_region(o->vfu_ctx, VFU_PCI_DEV_CFG_REGION_IDX,
> > + pci_config_size(o->pci_dev),
> > &vfu_object_cfg_access,
> > + VFU_REGION_FLAG_RW | VFU_REGION_FLAG_AL
Am 15.12.2021 um 13:11 hat Emanuele Giuseppe Esposito geschrieben:
> These patches are taken from my old patches and feedback of
> my series "block layer: split block APIs in global state and I/O".
>
> The reason for a separate series is that the original one is
> already too long, and these patch
On 12/15/21 11:02 PM, Cédric Le Goater wrote:
Fails testing:
/home/gitlab-runner/builds/yKcZqVC9/0/qemu-project/qemu/docs/specs/ppc-spapr-hcalls.rst:101:Block
quote ends without a blank line; unexpected unindent.
I didn't see it under :
https://gitlab.com/legoater/qemu/-/pipelines/4298522
On 12/16/21 3:28 AM, Peter Maydell wrote:
On Thu, 16 Dec 2021 at 09:58, Jean-Philippe Brucker
wrote:
On Wed, Dec 15, 2021 at 04:59:10PM -0800, Richard Henderson wrote:
On 12/15/21 2:40 AM, Peter Maydell wrote:
From: Jean-Philippe Brucker
Add two test cases for VIOT, one on the q35 machine
On Wed, Dec 15, 2021 at 02:39:15PM -0500, John Snow wrote:
> asyncio can complain *very* loudly if you forget to back out of things
> gracefully before the garbage collector starts destroying objects that
> contain live references to asyncio Tasks.
>
> The usual fix is just to remember to call aqm
When examining a report of poor migration behaviour, it would often be
useful to understand how much data was transferred in different phases
of the migration process.
For example, if the downtime limit is exceeded, to know how much data
was transferred during the downtime.
RFC because the name "
...and use it.
Signed-off-by: David Edmondson
---
migration/ram.c | 23 ++-
migration/ram.h | 1 +
2 files changed, 15 insertions(+), 9 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 57efa67f20..48ef2819f6 100644
--- a/migration/ram.c
+++ b/migration/ram.
Provide information on the number of bytes copied in the pre-copy,
downtime and post-copy phases of migration.
Signed-off-by: David Edmondson
---
migration/migration.c | 3 +++
migration/ram.c | 7 +++
monitor/hmp-cmds.c| 12
qapi/migration.json | 4 +++-
4 files
This is the continuation of part 1 (dma_memory API):
https://www.mail-archive.com/qemu-devel@nongnu.org/msg820359.html
This series update the dma_buf API.
Based on "hw: Let the DMA API take a MemTxAttrs argument"
Based-on: <20210702092439.989969-1-phi...@redhat.com>
Philippe Mathieu-Daudé (8):
Let devices specify transaction attributes when calling
dma_buf_write().
Keep the default MEMTXATTRS_UNSPECIFIED in the few callers.
Signed-off-by: Philippe Mathieu-Daudé
---
include/sysemu/dma.h | 2 +-
hw/ide/ahci.c | 6 --
hw/nvme/ctrl.c| 3 ++-
hw/scsi/megasas.c | 2
DMA operations are run on any kind of buffer, not arrays of
uint8_t. Convert dma_buf_read/dma_buf_write functions to take
a void pointer argument and save us pointless casts to uint8_t *.
Remove this pointless casts in the megasas device model.
Signed-off-by: Philippe Mathieu-Daudé
---
include/
DMA operations are run on any kind of buffer, not arrays of
uint8_t. Convert dma_buf_rw() to take a void pointer argument
to save us pointless casts to uint8_t *.
Signed-off-by: Philippe Mathieu-Daudé
---
softmmu/dma-helpers.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a
Let devices specify transaction attributes when calling pci_dma_rw().
Keep the default MEMTXATTRS_UNSPECIFIED in the few callers.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/pci/pci.h | 10 ++
hw/audio/intel-hda.c | 3 ++-
hw/scsi/esp-pci.c| 2 +-
3 files changed, 9 inser
Since the previous commit, dma_buf_rw() returns a MemTxResult
type. Do not discard it, return it to the caller.
Since both dma_buf_read/dma_buf_write functions were previously
returning the QEMUSGList size not consumed, add an extra argument
where the unconsummed size can be stored.
Update the fe
Let devices specify transaction attributes when calling dma_buf_rw().
Keep the default MEMTXATTRS_UNSPECIFIED in the 2 callers.
Signed-off-by: Philippe Mathieu-Daudé
---
softmmu/dma-helpers.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/softmmu/dma-helpers.c b
Let devices specify transaction attributes when calling
dma_buf_read().
Keep the default MEMTXATTRS_UNSPECIFIED in the few callers.
Signed-off-by: Philippe Mathieu-Daudé
---
include/sysemu/dma.h | 2 +-
hw/ide/ahci.c | 4 ++--
hw/nvme/ctrl.c| 2 +-
hw/scsi/megasas.c | 24
dma_memory_rw() returns a MemTxResult type. Do not discard
it, return it to the caller.
Since dma_buf_rw() was previously returning the QEMUSGList
size not consumed, add an extra argument where this size
can be stored.
Update the 2 callers.
Signed-off-by: Philippe Mathieu-Daudé
---
softmmu/dma
On Wed, Dec 15, 2021 at 02:39:16PM -0500, John Snow wrote:
> This exception can be injected into any await statement. If we are
> canceled via timeout, we want to clear the pending execution record on
> our way out.
>
> Signed-off-by: John Snow
> ---
> python/qemu/aqmp/qmp_client.py | 8 ++--
We are going to move this code, so fix its style first to avoid:
ERROR: spaces required around that '/' (ctx:VxV)
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/musicpal.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/hw/arm/musicpal.c b/hw/arm/musicpal.
The Marvell 88W8618 network device is hidden in the Musicpal
machine. Move it into a new unit file under the hw/net/ directory.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/net/mv88w8618_eth.h | 12 +
hw/arm/musicpal.c | 380 +--
hw/net/mv88w8618
On 12/16/21 13:35, Philippe Mathieu-Daudé wrote:
> Since the previous commit, dma_buf_rw() returns a MemTxResult
> type. Do not discard it, return it to the caller.
>
> Since both dma_buf_read/dma_buf_write functions were previously
> returning the QEMUSGList size not consumed, add an extra argume
This series simply extract the MV88W8618 device from the ARM
machine in hw/arm/ and move it to hw/net/.
Since v1:
- update (c) notice
Philippe Mathieu-Daudé (2):
hw/arm/musicpal: Fix coding style of code related to MV88W8618 device
hw/net: Move MV88W8618 network device out of hw/arm/ director
On Thu, Dec 16, 2021 at 11:28:04AM +, Peter Maydell wrote:
> On Thu, 16 Dec 2021 at 09:58, Jean-Philippe Brucker
> wrote:
> >
> > On Wed, Dec 15, 2021 at 04:59:10PM -0800, Richard Henderson wrote:
> > > On 12/15/21 2:40 AM, Peter Maydell wrote:
> > > > From: Jean-Philippe Brucker
> > > >
> >
On Wed, Dec 15, 2021 at 02:39:18PM -0500, John Snow wrote:
> It's a commonly needed definition, it can be re-exported by the root.
>
> Signed-off-by: John Snow
> ---
> python/qemu/aqmp/__init__.py | 10 +-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/python/qemu/aqm
Since v5:
- Adapt test class names (Yanan Wang)
Since v4:
- Rebase (skipping merged patches)
- Renamed tests (Yanan Wang)
Since v2:
- Restore 'dies_supported' field in test_with_dies (Yanan)
- Add R-b tags
- QOM-ify the TYPE_MACHINE classes
Supersedes: <2025145900.2531865-1-phi...@redhat.com
Split the 'generic' test in two tests: 'valid' and 'invalid'.
This will allow us to remove the hack which modifies the
MachineClass internal state.
Reviewed-by: Richard Henderson
Reviewed-by: Yanan Wang
Signed-off-by: Philippe Mathieu-Daudé
---
tests/unit/test-smp-parse.c | 21
Keep the common TYPE_MACHINE class initialization in
machine_base_class_init(), make it abstract, and move
the non-common code to a new class: "smp-generic-valid".
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
---
tests/unit/test-smp-parse.c | 19 +++
1 fi
We can simply use a local variable (and pass its pointer) instead
of a pointer to a compound literal.
Reviewed-by: Andrew Jones
Reviewed-by: Richard Henderson
Reviewed-by: Yanan Wang
Tested-by: Yanan Wang
Signed-off-by: Philippe Mathieu-Daudé
---
tests/unit/test-smp-parse.c | 66
On 11/21/21 13:24, Yanan Wang wrote:
> Wrap the CPU target specific parameters together into a single
> variable, so that we don't need to update the other lines but
> a single line when new topology parameters are introduced.
Where new params are introduced? Not in this series apparently.
> No f
Declare structures const when we don't need to modify
them at runtime.
Reviewed-by: Andrew Jones
Reviewed-by: Richard Henderson
Reviewed-by: Yanan Wang
Tested-by: Yanan Wang
Signed-off-by: Philippe Mathieu-Daudé
---
tests/unit/test-smp-parse.c | 12 ++--
1 file changed, 6 insertions(
Use g_test_add_data_func() instead of g_test_add_func() so we can
pass the machine type to the tests (we will soon have different
machine types).
Reviewed-by: Richard Henderson
Reviewed-by: Yanan Wang
Signed-off-by: Philippe Mathieu-Daudé
---
tests/unit/test-smp-parse.c | 18 --
All methods related to MachineState are prefixed with "machine_".
smp_parse() does not need to be an exception. Rename it and
const'ify the SMPConfiguration argument, since it doesn't need
to be modified.
Reviewed-by: Andrew Jones
Reviewed-by: Richard Henderson
Reviewed-by: Yanan Wang
Tested-by
On Wed, Dec 15, 2021 at 02:39:21PM -0500, John Snow wrote:
> Signed-off-by: John Snow
> ---
> python/qemu/qmp/qemu_ga_client.py | 22 +++---
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/python/qemu/qmp/qemu_ga_client.py
> b/python/qemu/qmp/qemu_ga_client.
Avoid modifying the MachineClass internals by adding the
'smp-generic-invalid' machine, which inherits from TYPE_MACHINE.
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
---
tests/unit/test-smp-parse.c | 25 -
1 file changed, 16 insertions(+), 9 dele
On Wed, Dec 15, 2021 at 10:35:33AM -0500, Jagannathan Raman wrote:
> Define and register callbacks to manage the RAM regions used for
> device DMA
>
> Signed-off-by: Elena Ufimtseva
> Signed-off-by: John G Johnson
> Signed-off-by: Jagannathan Raman
> Reviewed-by: Stefan Hajnoczi
> ---
> hw/re
Avoid modifying the MachineClass internals by adding the
'smp-with-dies' machine, which inherits from TYPE_MACHINE.
Reviewed-by: Richard Henderson
Reviewed-by: Yanan Wang
Tested-by: Yanan Wang
Signed-off-by: Philippe Mathieu-Daudé
---
tests/unit/test-smp-parse.c | 22 +++---
1
On Wed, Dec 15, 2021 at 02:39:25PM -0500, John Snow wrote:
> Signed-off-by: John Snow
> ---
> python/README.rst | 2 +-
> python/qemu/{qmp => aqmp}/qmp_shell.py | 0
> python/setup.cfg | 2 +-
> scripts/qmp/qmp-shell | 2 +-
> 4 files ch
On Wed, Dec 15, 2021 at 02:39:22PM -0500, John Snow wrote:
> Signed-off-by: John Snow
> ---
> python/qemu/qmp/qom.py| 5 +++--
> python/qemu/qmp/qom_common.py | 3 ++-
> python/qemu/qmp/qom_fuse.py | 11 ++-
> 3 files changed, 11 insertions(+), 8 deletions(-)
>
> diff --git a
On Wed, Dec 15, 2021 at 02:39:28PM -0500, John Snow wrote:
> Signed-off-by: John Snow
> ---
> scripts/cpu-x86-uarch-abi.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/cpu-x86-uarch-abi.py b/scripts/cpu-x86-uarch-abi.py
> index 8963d90f0b..c262d2f027 10064
Previously, we required bits 5, 6 and 7 to be zero (0x07 == 0b111). But,
as per the principles of operation, bit 5 is ignored in MSCH and bits 0,
1, 6 and 7 need to be zero.
As both PMCW_FLAGS_MASK_INVALID and ioinst_schib_valid() are only used
by ioinst_handle_msch(), adjust the mask accordingly.
On Wed, Dec 15, 2021 at 02:39:26PM -0500, John Snow wrote:
> Remove the QEMU_PYTHON_LEGACY_QMP environment variable, making the
> switch permanent. Update Exceptions and import paths as necessary.
>
> Signed-off-by: John Snow
> ---
> python/qemu/machine/machine.py | 18 +++---
> pyth
On Wed, Dec 15, 2021 at 02:39:30PM -0500, John Snow wrote:
> For this commit, we only need to remove accommodations for the
> synchronous QMP library.
>
> Signed-off-by: John Snow
> ---
> scripts/simplebench/bench_block_job.py | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff -
On Wed, Dec 15, 2021 at 02:39:29PM -0500, John Snow wrote:
> Creating an instance of qemu.aqmp.ExecuteError is too involved here, so
> just drop the specificity down to a generic AQMPError.
>
> Signed-off-by: John Snow
> ---
> scripts/render_block_graph.py | 8 +++-
> 1 file changed, 3 inser
On Wed, Dec 15, 2021 at 02:39:31PM -0500, John Snow wrote:
> Signed-off-by: John Snow
>
> ---
>
> Note: I still need to adjust the logging. The problem now is that the
> logging messages include the PID of the test process, so they need to be
> filtered out. I'll investigate that for a follow-up
On 2021/12/16 21:20, Philippe Mathieu-Daudé wrote:
Avoid modifying the MachineClass internals by adding the
'smp-generic-invalid' machine, which inherits from TYPE_MACHINE.
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
---
tests/unit/test-smp-parse.c | 25 +++
On 2021/12/16 21:20, Philippe Mathieu-Daudé wrote:
Keep the common TYPE_MACHINE class initialization in
machine_base_class_init(), make it abstract, and move
the non-common code to a new class: "smp-generic-valid".
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
---
te
On Wed, Dec 15, 2021 at 02:39:32PM -0500, John Snow wrote:
> Simply import the type defition from the new location.
>
> Signed-off-by: John Snow
> ---
> tests/qemu-iotests/iotests.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/iotests.py b/tests/q
On 14.12.21 20:48, Emanuele Giuseppe Esposito wrote:
On 10/12/2021 18:43, Hanna Reitz wrote:
On 24.11.21 07:43, Emanuele Giuseppe Esposito wrote:
We want to be sure that the functions that write the child and
parent list of a bs are under BQL and drain.
BQL prevents from concurrent writings
On 15.12.21 11:13, Emanuele Giuseppe Esposito wrote:
On 15/12/2021 09:57, Emanuele Giuseppe Esposito wrote:
On 10/12/2021 15:38, Hanna Reitz wrote:
On 24.11.21 07:43, Emanuele Giuseppe Esposito wrote:
Fuse logic can be classified as I/O, so there is no BQL held
during its execution. And ye
Hi,
On 2021/12/16 21:23, Philippe Mathieu-Daudé wrote:
On 11/21/21 13:24, Yanan Wang wrote:
Wrap the CPU target specific parameters together into a single
variable, so that we don't need to update the other lines but
a single line when new topology parameters are introduced.
Where new params a
On Wed, Dec 15, 2021 at 02:39:34PM -0500, John Snow wrote:
> Shift these definitions over from the qmp package to the async qmp
> package.
>
> Signed-off-by: John Snow
> ---
> python/qemu/aqmp/aqmp_tui.py | 2 +-
> python/qemu/aqmp/legacy.py | 30 ++
> python/qemu/
On Wed, Dec 15, 2021 at 10:35:34AM -0500, Jagannathan Raman wrote:
> +static ssize_t vfu_object_bar_rw(PCIDevice *pci_dev, hwaddr addr, size_t
> count,
> + char * const buf, const bool is_write,
> + bool is_io)
> +{
> +AddressSpac
Philippe Mathieu-Daudé writes:
> When experimenting raising GLIB_VERSION_MIN_REQUIRED to 2.68
> (Fedora 34 provides GLib 2.68.1) we get:
>
> hw/virtio/virtio-crypto.c:245:24: error: 'g_memdup' is deprecated: Use
> 'g_memdup2' instead [-Werror,-Wdeprecated-declarations]
> ...
>
> g_memdup()
From: Matheus Ferst
The values can be passed with registers to the inline assembler and
moved to/from the VSR with mtvsrd/mfvsrd.
Signed-off-by: Matheus Ferst
---
tests/tcg/ppc64le/non_signalling_xscv.c | 27 +
1 file changed, 14 insertions(+), 13 deletions(-)
diff --g
On Wed, Dec 15, 2021 at 02:39:36PM -0500, John Snow wrote:
> Copy the docstrings out of qemu.qmp, adjusting them as necessary to
> more accurately reflect the current state of this class.
>
> Signed-off-by: John Snow
> ---
> python/qemu/aqmp/legacy.py | 110 ++---
On Wed, Dec 15, 2021 at 02:39:37PM -0500, John Snow wrote:
> Thank you for your service!
>
> Signed-off-by: John Snow
> ---
> python/PACKAGE.rst | 4 +-
> python/README.rst | 2 +-
> python/qemu/qmp/README.rst | 9 -
> python/qemu/qmp/__init__.py | 396 -
On Wed, Dec 15, 2021 at 02:39:35PM -0500, John Snow wrote:
> After this patch, qemu.aqmp.legacy.QEMUMonitorProtocol no longer
> inherits from qemu.qmp.QEMUMonitorProtocol. To do this, several
> inherited methods need to be explicitly re-defined.
>
> Signed-off-by: John Snow
> ---
> python/qemu/a
On Wed, Dec 15, 2021 at 02:39:38PM -0500, John Snow wrote:
> With the old library gone, there's nothing duplicated in the tree, so
> the warning suppression can be removed.
>
> Signed-off-by: John Snow
> ---
> python/setup.cfg | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/python/setup
On Wed, Dec 15, 2021 at 10:35:35AM -0500, Jagannathan Raman wrote:
> Assign separate address space for each device in the remote processes.
If I understand correctly this isn't really an IOMMU. It's abusing the
IOMMU APIs to create isolated address spaces for each device. This way
memory regions a
The pgb_find_hole function goes to the trouble of taking account of
both mmap_min_addr and any offset we've applied to decide the starting
address of a potential hole. This is especially important for
emulating 32bit ARM in a 32bit build as we have applied the offset to
ensure there will be space t
On 24.11.21 07:43, Emanuele Giuseppe Esposito wrote:
According to the assertions put in the previous patch, we should
first drain and then modify the ->children list. In this way
we prevent other iothreads to read the list while it is being
updated.
In this case, moving the drain won't cause any
On 12/16/21 3:15 AM, Pierre Morel wrote:
On 12/7/21 22:04, Matthew Rosato wrote:
Let's use the reserved pool of simulated PCI groups to allow intercept
devices to have separate groups from interpreted devices as some group
values may be different. If we run out of simulated PCI groups,
subseq
On 24.11.21 07:43, Emanuele Giuseppe Esposito wrote:
All the global state (GS) API functions will check that
qemu_in_main_thread() returns true. If not, it means
that the safety of BQL cannot be guaranteed, and
they need to be moved to I/O.
Signed-off-by: Emanuele Giuseppe Esposito
---
block.
On 12/16/21 11:24, Markus Armbruster wrote:
Not really, in particular the startup has been mostly reworked already
and I disagree that it is messy. softmmu/vl.c is messy, sure: it has
N different command line parser for command line options, magic
related to default devices, and complicated orde
On 12/16/21 10:10, Philippe Mathieu-Daudé wrote:
On 12/16/21 09:51, Paolo Bonzini wrote:
The only difference between the two, as far as either configure or
Meson are concerned, is in the multilib flags passed to the compiler.
For QEMU, this fixes the handling of TYPE_OLDDEVT in
include/exec/use
On Thu, Dec 16, 2021 at 04:28:29PM +0100, Paolo Bonzini wrote:
> On 12/16/21 11:24, Markus Armbruster wrote:
> > > Not really, in particular the startup has been mostly reworked already
> > > and I disagree that it is messy. softmmu/vl.c is messy, sure: it has
> > > N different command line parser
On 12/16/21 04:36, Philippe Mathieu-Daudé wrote:
Hi Jon,
On 10/21/21 18:10, Jon Maloy wrote:
The fact that the MMIO handler is not re-entrant causes an infinite
loop under certain conditions:
Guest write to TDT -> Loopback -> RX (DMA to TDT) -> TX
We now eliminate the effect of this probl
On Wed, Dec 15, 2021 at 10:35:36AM -0500, Jagannathan Raman wrote:
> @@ -62,6 +66,9 @@ void remote_iohub_set_irq(void *opaque, int pirq, int level)
> QEMU_LOCK_GUARD(&iohub->irq_level_lock[pirq]);
>
> if (level) {
> +if (iohub->intx_notify) {
> +iohub->intx_notify(pi
> On 16 Dec 2021, at 16:40, Daniel P. Berrangé wrote:
>
> On Thu, Dec 16, 2021 at 04:28:29PM +0100, Paolo Bonzini wrote:
>> On 12/16/21 11:24, Markus Armbruster wrote:
Not really, in particular the startup has been mostly reworked already
and I disagree that it is messy. softmmu/vl.
On Thu, Dec 16, 2021 at 11:47:40AM +, John Levon wrote:
> On Thu, Dec 16, 2021 at 11:30:20AM +, Stefan Hajnoczi wrote:
>
> > > +ret = vfu_setup_region(o->vfu_ctx, VFU_PCI_DEV_CFG_REGION_IDX,
> > > + pci_config_size(o->pci_dev),
> > > &vfu_object_cfg_access,
>
Hi all;
My team has a working PECI bus/device in Qemu, but we only have internal
board specifications that enable it. We'd like to upstream it as soon
as possible, but obviously we can't enable testing for it without an
upstream board that uses it. We only have it attached to Nuvoton 7xx
present
On 16/12/2021 15:57, Hanna Reitz wrote:
On 24.11.21 07:43, Emanuele Giuseppe Esposito wrote:
According to the assertions put in the previous patch, we should
first drain and then modify the ->children list. In this way
we prevent other iothreads to read the list while it is being
updated.
In
On 24.11.21 07:44, Emanuele Giuseppe Esposito wrote:
Following the assertion derived from the API split,
propagate the assertion also in the static functions.
Signed-off-by: Emanuele Giuseppe Esposito
---
block.c | 45 -
1 file changed, 44 insertio
On Thu, Dec 16, 2021 at 12:38:34PM +0200, Dov Murik wrote:
>
>
> On 14/12/2021 20:39, Daniel P. Berrangé wrote:
> > On Tue, Dec 14, 2021 at 01:59:10PM +, Dov Murik wrote:
> >> Add a section explaining how the Guest Owner should calculate the
> >> expected guest launch measurement for SEV and
On 16.12.21 17:05, Emanuele Giuseppe Esposito wrote:
On 16/12/2021 15:57, Hanna Reitz wrote:
On 24.11.21 07:43, Emanuele Giuseppe Esposito wrote:
According to the assertions put in the previous patch, we should
first drain and then modify the ->children list. In this way
we prevent other ioth
On Thu, Dec 16, 2021 at 05:00:55PM +0100, Mark Burton wrote:
>
>
> > On 16 Dec 2021, at 16:40, Daniel P. Berrangé wrote:
> >
> > On Thu, Dec 16, 2021 at 04:28:29PM +0100, Paolo Bonzini wrote:
> >> On 12/16/21 11:24, Markus Armbruster wrote:
> Not really, in particular the startup has been
On Thu, Nov 04, 2021 at 10:53:21AM -0400, Emanuele Giuseppe Esposito wrote:
> job mutex will be used to protect the job struct elements and list,
> replacing AioContext locks.
>
> Right now use a shared lock for all jobs, in order to keep things
> simple. Once the AioContext lock is gone, we can i
On Thu, Dec 16, 2021 at 5:41 AM Daniel P. Berrangé
wrote:
> On Wed, Dec 15, 2021 at 04:06:10PM -0500, John Snow wrote:
> > Hi, this series is part of an effort to publish the qemu.qmp package on
> > PyPI. It is the second of three series to complete this work:
> >
> > (1) Switch the new Async
On Thu, Nov 04, 2021 at 10:53:22AM -0400, Emanuele Giuseppe Esposito wrote:
> Categorize the fields in struct Job to understand which ones
> need to be protected by the job mutex and which don't.
>
> Signed-off-by: Emanuele Giuseppe Esposito
> ---
> include/qemu/job.h | 57 ++
On Thu, Dec 16, 2021 at 5:51 AM Daniel P. Berrangé
wrote:
> On Wed, Dec 15, 2021 at 02:39:14PM -0500, John Snow wrote:
> > GitLab: https://gitlab.com/jsnow/qemu/-/commits/python-qmp-legacy-switch
> > CI: https://gitlab.com/jsnow/qemu/-/pipelines/430491195
> >
> > Hi, this series is part of an eff
>>
>> Totally agree on this (of course).
>>
>> Thats why I’m here - I care about the people who care about emulation :-)
>>
>> In general, what we are working on is exactly the ability to service the
>> ‘complex’ emulation use case. No CLI, nor single ‘config’ file will be good
>> enough,
On Thu, Dec 16, 2021 at 5:43 AM Daniel P. Berrangé
wrote:
> On Wed, Dec 15, 2021 at 04:06:13PM -0500, John Snow wrote:
> > I'm the primary author of this particular component; update the metadata
> > accordingly.
> >
> > Signed-off-by: John Snow
> > ---
> > setup.cfg | 4 +++-
> > 1 file change
On 12/16/21 1:44 AM, Thomas Huth wrote:
Hi!
The following changes since commit e630bc7ec9dda656a452ed28cac4d1e9ed605d71:
Merge tag 'pull-block-2021-12-15' of git://repo.or.cz/qemu/armbru into
staging (2021-12-15 12:14:44 -0800)
are available in the Git repository at:
https://gitlab.c
On 16/12/2021 17:08, Hanna Reitz wrote:
On 24.11.21 07:44, Emanuele Giuseppe Esposito wrote:
Following the assertion derived from the API split,
propagate the assertion also in the static functions.
Signed-off-by: Emanuele Giuseppe Esposito
---
block.c | 45 +++
On Thu, Nov 04, 2021 at 10:53:23AM -0400, Emanuele Giuseppe Esposito wrote:
> /** Returns whether the job is ready to be completed. */
> bool job_is_ready(Job *job);
>
> +/** Same as job_is_ready(), but assumes job_lock is held. */
> +bool job_is_ready_locked(Job *job);
What I see here is that
On Thu, Nov 04, 2021 at 10:53:24AM -0400, Emanuele Giuseppe Esposito wrote:
> All these functions assume that the lock is not held, and acquire
> it internally.
>
> These functions will be useful when job_lock is globally applied,
> as they will allow callers to access the job struct fields
> with
On Thu, Nov 04, 2021 at 10:53:26AM -0400, Emanuele Giuseppe Esposito wrote:
> job_event_* functions can all be static, as they are not used
> outside job.c.
>
> Signed-off-by: Emanuele Giuseppe Esposito
> ---
> include/qemu/job.h | 6 --
> job.c | 12 ++--
> 2 files cha
On Thu, Dec 16, 2021 at 5:09 AM Vladimir Sementsov-Ogievskiy <
vsement...@virtuozzo.com> wrote:
> 15.12.2021 22:39, John Snow wrote:
> > This is in preparation for renaming qemu.aqmp to qemu.qmp. I should have
> > done this from this from the very beginning, but it's a convenient time
> > to make
On Thu, Dec 16, 2021 at 4:31 AM Vladimir Sementsov-Ogievskiy <
vsement...@virtuozzo.com> wrote:
> 15.12.2021 22:39, John Snow wrote:
> > asyncio can complain *very* loudly if you forget to back out of things
> > gracefully before the garbage collector starts destroying objects that
> > contain liv
16.12.2021 19:48, Stefan Hajnoczi wrote:
On Thu, Nov 04, 2021 at 10:53:23AM -0400, Emanuele Giuseppe Esposito wrote:
/** Returns whether the job is ready to be completed. */
bool job_is_ready(Job *job);
+/** Same as job_is_ready(), but assumes job_lock is held. */
+bool job_is_ready_lock
On 12/15/21 13:09, Alex Bennée wrote:
Generally a guest needs an external source of randomness to properly
enable things like address space randomisation. However in a trusted
boot environment where the firmware will cryptographically verify
components having random data in the DTB will cause ver
On Thu, Dec 16, 2021 at 4:51 AM Vladimir Sementsov-Ogievskiy <
vsement...@virtuozzo.com> wrote:
> 15.12.2021 22:39, John Snow wrote:
> > This exception can be injected into any await statement. If we are
> > canceled via timeout, we want to clear the pending execution record on
> > our way out.
>
On Thu, Dec 16, 2021 at 7:39 AM Beraldo Leal wrote:
> On Wed, Dec 15, 2021 at 02:39:16PM -0500, John Snow wrote:
> > This exception can be injected into any await statement. If we are
> > canceled via timeout, we want to clear the pending execution record on
> > our way out.
> >
> > Signed-off-by
On Thu, 2021-12-16 at 08:03 -0800, Patrick Venture wrote:
> Hi all;
>
> My team has a working PECI bus/device in Qemu, but we only have internal board
> specifications that enable it. We'd like to upstream it as soon as possible,
> but obviously we can't enable testing for it without an upstream
On 10/13/21 23:40, Cédric Le Goater wrote:
From: Nicholas Piggin
This implements a machine check injection framework and defines a
'mce' monitor command for ppc.
Signed-off-by: Nicholas Piggin
[ clg: - moved definition under "hw/ppc/mce.h"
- renamed to PPCMceInjection
- simpli
On Thu, Dec 16, 2021 at 5:19 AM Daniel P. Berrangé
wrote:
> On Wed, Dec 15, 2021 at 02:39:17PM -0500, John Snow wrote:
> > Copy the remaining type definitions from QMP into the qemu.aqmp.legacy
> > module. Now, most users don't need to import anything else but
> > qemu.aqmp.legacy.
>
> I'm probab
On Thu, Dec 16, 2021 at 5:14 AM Vladimir Sementsov-Ogievskiy <
vsement...@virtuozzo.com> wrote:
> I had to search a bit through the history to check this )
>
> The commit ccd3b3b8112b670f "qemu-option: warn for short-form boolean
> options" may be noted here.
>
> And may be subject changed to "don
101 - 200 of 373 matches
Mail list logo