On 12/7/21 22:04, Matthew Rosato wrote:
When using the IOAT assist via interpretation, we should advertise what
the host driver supports, not QEMU.
Signed-off-by: Matthew Rosato
---
hw/s390x/s390-pci-vfio.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/hw/s390x/
From: Eric Auger
Endianess is not properly handled when populating
the returned config. Use the cpu_to_le* primitives
for each separate field. Also, while at it, trace
the domain range start.
Reported-by: Thomas Huth
Signed-off-by: Eric Auger
Reviewed-by: Jean-Philippe Brucker
Message-Id: <20
From: Eric Auger
in old times the domain range was defined by a domain_bits le32.
This was then converted into a domain_range struct. During the
upgrade the original value of '32' (bits) has been kept while
the end field now is the max value of the domain id (UINT32_MAX).
Fix that and also use UI
Hi,
Reviewed-by: Petr Vorel
Although it's probably too late, as I see patch with PULL [1].
Kind regards,
Petr
[1]
https://lore.kernel.org/qemu-devel/20211215073402.144286-10-th...@redhat.com/
huang...@chinatelecom.cn writes:
> From: Hyman Huang(黄勇)
>
> Implement dirtyrate calculation periodically basing on
> dirty-ring and throttle virtual CPU until it reachs the quota
> dirty page rate given by user.
>
> Introduce qmp commands "vcpu-dirty-limit", "query-vcpu-dirty-limit"
> to enable,
在 2021/12/15 15:15, Markus Armbruster 写道:
huang...@chinatelecom.cn writes:
From: Hyman Huang(黄勇)
Setup a negative feedback system when vCPU thread
handling KVM_EXIT_DIRTY_RING_FULL exit by introducing
throttle_us_per_full field in struct CPUState. Sleep
throttle_us_per_full microseconds to
Gitlab also provides runners with Windows, we can use them to
test compilation with MSYS2, in both, 64-bit and 32-bit.
However, it takes quite a long time to set up the VM, so to stay
in a reasonable time frame, we can only compile and check one
target here.
Message-Id: <2025140623.104116-1-t
On 12/7/21 22:04, Matthew Rosato wrote:
Note: The first 3 patches of this series are included as pre-reqs, but
should be pulled via a separate series. Also, patch 5 is needed to
support 5.16+ linux header-sync and was already done by Paolo but not
merged yet so is thus included here as well.
在 2021/12/15 15:37, Markus Armbruster 写道:
huang...@chinatelecom.cn writes:
From: Hyman Huang(黄勇)
Implement dirtyrate calculation periodically basing on
dirty-ring and throttle virtual CPU until it reachs the quota
dirty page rate given by user.
Introduce qmp commands "vcpu-dirty-limit", "
On 12/7/21 22:04, Matthew Rosato wrote:
Use the associated vfio feature ioctl to enable interpretation for devices
when requested. As part of this process, we must use the host function
handle rather than a QEMU-generated one -- this is provided as part of the
ioctl payload.
Signed-off-by: M
Hello Richard!
On Tue, 14 Dec 2021 13:13:57 -0800
Richard Henderson wrote:
> On 12/14/21 1:12 PM, Richard Henderson wrote:
> > On 12/14/21 1:26 AM, Nikita Shubin wrote:
> >> - if (!pmp_get_num_rules(env) && (prev_priv != PRV_M)) {
> >> + if (riscv_feature(env, RISCV_FEATURE_PMP) &&
> >>
This option was just a wrapper around the -display ...,window-close=off
parameter, and the name "no-quit" is rather confusing compared to
"window-close" (since there are still other means to quit the emulator),
so let's remove this now.
Signed-off-by: Thomas Huth
---
docs/about/deprecated.rst
On Wed, Dec 15, 2021 at 03:56:55PM +0800, Hyman Huang wrote:
> > > +{ 'command': 'vcpu-dirty-limit',
> > > + 'data': { 'enable': 'bool',
> > > +'*cpu-index': 'uint64',
> > > +'*dirty-rate': 'uint64'} }
> >
> > Drop @enable, please.
> >
> > If @dirty-rate is present, set t
在 2021/12/15 16:09, Peter Xu 写道:
On Wed, Dec 15, 2021 at 03:56:55PM +0800, Hyman Huang wrote:
+{ 'command': 'vcpu-dirty-limit',
+ 'data': { 'enable': 'bool',
+'*cpu-index': 'uint64',
+'*dirty-rate': 'uint64'} }
Drop @enable, please.
If @dirty-rate is present, set t
It's likely broken, and nobody cared for picking it up again
during the deprecation phase, so let's remove this now.
Since this is the last entry in deprecated_targets_list, remove
the related code in the configure script, too.
Signed-off-by: Thomas Huth
---
.gitlab-ci.d/buildtest.yml
On 10/12/2021 15:38, Hanna Reitz wrote:
On 24.11.21 07:43, Emanuele Giuseppe Esposito wrote:
Fuse logic can be classified as I/O, so there is no BQL held
during its execution. And yet, it uses blk_{get/set}_perm
functions, that are classified as BQL and clearly require
the BQL lock. Since the
On 12/15/21 09:24, Thomas Huth wrote:
> This option was just a wrapper around the -display ...,window-close=off
> parameter, and the name "no-quit" is rather confusing compared to
> "window-close" (since there are still other means to quit the emulator),
> so let's remove this now.
>
> Signed-off-
On Tue, Dec 14, 2021 at 07:50:48PM +, Alex Bennée wrote:
> As --enable-profiler isn't defended in CI we missed this breakage.
> Move the qmp handler into accel/tcg so we have access to the helpers
> we need. While we are at it ensure we gate the feature on CONFIG_TCG.
>
> Signed-off-by: Alex B
Thomas Huth writes:
> This option was just a wrapper around the -display ...,window-close=off
> parameter, and the name "no-quit" is rather confusing compared to
> "window-close" (since there are still other means to quit the emulator),
> so let's remove this now.
>
> Signed-off-by: Thomas Huth
On 14/12/2021 15:35, Kevin Wolf wrote:
Am 30.11.2021 um 10:46 hat Emanuele Giuseppe Esposito geschrieben:
drive_add is only used in softmmu/vl.c, so it can be a static
function there, and drive_def is only a particular use case of
qemu_opts_parse_noisily, so it can be inlined.
Also remove dr
On Tue, Dec 14, 2021 at 06:00:38PM -0600, Michael Roth wrote:
> Hi everyone,
>
> The following new patches are queued for QEMU stable v6.1.1:
>
> https://gitlab.com/qemu-project/qemu/-/commits/stable-6.1-staging/
FYI, this branch doesn't appear to have been pushed.
> Patch freeze is 2021-12-2
On 15/12/2021 10.11, Markus Armbruster wrote:
Thomas Huth writes:
This option was just a wrapper around the -display ...,window-close=off
parameter, and the name "no-quit" is rather confusing compared to
"window-close" (since there are still other means to quit the emulator),
so let's remove t
Daniel P. Berrangé writes:
> On Tue, Dec 14, 2021 at 07:50:48PM +, Alex Bennée wrote:
>> As --enable-profiler isn't defended in CI we missed this breakage.
>> Move the qmp handler into accel/tcg so we have access to the helpers
>> we need. While we are at it ensure we gate the feature on CO
On Wed, Dec 15, 2021 at 08:18:53AM +, Amir Gonnen wrote:
> Before sending a patch, I would like to check if it's of interest to the
> community.
>
> My goal is to simulate a mixed architecture system.
> Today QEMU strongly assumes that the simulated system is a *single
> architecture*.
> Cha
Am 15.12.2021 um 10:19 hat Emanuele Giuseppe Esposito geschrieben:
>
>
> On 14/12/2021 15:35, Kevin Wolf wrote:
> > Am 30.11.2021 um 10:46 hat Emanuele Giuseppe Esposito geschrieben:
> > > drive_add is only used in softmmu/vl.c, so it can be a static
> > > function there, and drive_def is only a
On Wed, Dec 15, 2021 at 11:18:05AM +0800, Jason Wang wrote:
> On Tue, Dec 14, 2021 at 9:11 PM Stefan Hajnoczi wrote:
> >
> > On Tue, Dec 14, 2021 at 10:22:53AM +0800, Jason Wang wrote:
> > > On Mon, Dec 13, 2021 at 11:14 PM Stefan Hajnoczi
> > > wrote:
> > > >
> > > > On Mon, Dec 13, 2021 at 10:
On Wed, 15 Dec 2021 at 08:18, Amir Gonnen wrote:
> My goal is to simulate a mixed architecture system.
>
> Today QEMU strongly assumes that the simulated system is a *single
> architecture*.
> Changing this assumption and supporting mixed architecture in QEMU proved to
> be
> non-trivial and may
On 15/12/2021 09:57, Emanuele Giuseppe Esposito wrote:
On 10/12/2021 15:38, Hanna Reitz wrote:
On 24.11.21 07:43, Emanuele Giuseppe Esposito wrote:
Fuse logic can be classified as I/O, so there is no BQL held
during its execution. And yet, it uses blk_{get/set}_perm
functions, that are cla
在 2021/12/15 16:29, Hyman Huang 写道:
在 2021/12/15 16:09, Peter Xu 写道:
On Wed, Dec 15, 2021 at 03:56:55PM +0800, Hyman Huang wrote:
+{ 'command': 'vcpu-dirty-limit',
+ 'data': { 'enable': 'bool',
+ '*cpu-index': 'uint64',
+ '*dirty-rate': 'uint64'} }
Drop @enable, pl
On Wed, Dec 15, 2021 at 10:10:35AM +, Peter Maydell wrote:
> On Wed, 15 Dec 2021 at 08:18, Amir Gonnen wrote:
> > My goal is to simulate a mixed architecture system.
> >
> > Today QEMU strongly assumes that the simulated system is a *single
> > architecture*.
> > Changing this assumption and
On 11/24/21 14:33, Philippe Mathieu-Daudé wrote:
> On 11/24/21 14:01, Daniel P. Berrangé wrote:
>> With latest clang 13.0.0 we get
>>
>> ../ui/clipboard.c:47:34: error: variable 'old' set but not used
>> [-Werror,-Wunused-but-set-variable]
>> g_autoptr(QemuClipboardInfo) old = NULL;
>>
On 12/7/21 21:40, John Snow wrote:
> spice updated the spelling (and arguments) of "attache_worker" in
> 0.15.0. Update QEMU to match, preventing -Wdeprecated-declarations
> compilations from reporting build errors.
>
> See also:
> https://gitlab.freedesktop.org/spice/spice/-/commit/974692bda1e77a
Hi Laurent,
This patch is reviewed, can it go via your trivial tree?
On 12/5/21 23:41, Philippe Mathieu-Daudé wrote:
> TYPE_AVR_CPU inherits TYPE_CPU, which itself inherits TYPE_DEVICE.
> TYPE_DEVICE instances are realized using qdev_realize(), we don't
> need to access QOM internal values.
>
>
Ping?
On 11/22/21 11:51, Philippe Mathieu-Daudé wrote:
> While both MII_ANAR_TX / MII_ANLPAR_TX have the same value,
> the ANAR and ANLPAR registers are different, so technically
> the ANLPAR register have to use the MII_ANLPAR_TX definition.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw
ping?
On 12/1/21 23:32, Philippe Mathieu-Daudé wrote:
> If the 'i8042' property is not set, mouse events handled by
> vmmouse_mouse_event() end calling i8042_isa_mouse_fake_event()
> with a NULL argument, resulting in ps2_mouse_fake_event() being
> called with invalid PS2MouseState pointer. Fix by
Hi Laurent,
This patch is reviewed, can it go via your trivial tree?
On 11/22/21 11:47, Philippe Mathieu-Daudé wrote:
> Commit 739e95f5741 ("scsi: Replace scsi_bus_new() with
> scsi_bus_init(), scsi_bus_init_named()") forgot to rename
> scsi_bus_init() in the function documentation string.
>
> S
Cc'ing Peter for documentation review.
On 11/22/21 11:48, Philippe Mathieu-Daudé wrote:
> Mention in aux_bus_init() docstring that the AUXBus
> is not simply initialized, it is also allocated.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> include/hw/misc/auxbus.h | 12 +++-
> 1 file
ping?
On 12/13/21 13:32, Philippe Mathieu-Daudé wrote:
> Too late for 6.2 now, so Cc'ing qemu-trivial (series reviewed).
>
> On 11/19/21 21:11, Philippe Mathieu-Daudé wrote:
>> Fix issue #521 reported by Alex some months ago:
>> https://gitlab.com/qemu-project/qemu/-/issues/521
>>
>> Philippe Mat
Ping?
On 11/19/21 10:16, Philippe Mathieu-Daudé wrote:
> Replace Qemu -> QEMU.
>
> Supersedes: <2028143401.4101497-1-phi...@redhat.com>
>
> Philippe Mathieu-Daudé (3):
> docs: Spell QEMU all caps
> misc: Spell QEMU all caps
> qga: Spell QEMU all caps
>
> docs/devel/modules.rst
From: Zhang Chen
Optimize COLO primary start path from:
MIGRATION_STATUS_XXX --> MIGRATION_STATUS_ACTIVE --> MIGRATION_STATUS_COLO -->
MIGRATION_STATUS_COMPLETED
To:
MIGRATION_STATUS_XXX --> MIGRATION_STATUS_COLO --> MIGRATION_STATUS_COMPLETED
No need to start primary COLO through "MIGRATION_STA
On Wed, Dec 15, 2021 at 09:45:56AM +, Stefan Hajnoczi wrote:
> On Wed, Dec 15, 2021 at 08:18:53AM +, Amir Gonnen wrote:
> > Before sending a patch, I would like to check if it's of interest to the
> > community.
> >
> > My goal is to simulate a mixed architecture system.
> > Today QEMU st
From: Zhang Chen
Previous operation(like vm_start and replication_start_all) will consume
extra time before update the timer, so reduce time in this patch.
Signed-off-by: Zhang Chen
Reviewed-by: Juan Quintela
Signed-off-by: Juan Quintela
---
migration/colo.c | 5 ++---
1 file changed, 2 inse
It just calls buffer_is_zero(). Just change the callers.
Signed-off-by: Juan Quintela
Reviewed-by: Richard Henderson
Reviewed-by: Marc-André Lureau
---
dump/dump.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/dump/dump.c b/dump/dump.c
index 662d0a62cd..a84d8b1
From: "Rao, Lei"
The code to acquire bitmap_mutex is added in the commit of
"63268c4970a5f126cc9af75f3ccb8057abef5ec0". There is no
need to acquire bitmap_mutex in colo_flush_ram_cache(). This
is because the colo_flush_ram_cache only be called on the COLO
secondary VM, which is the destination si
From: "Rao, Lei"
When the PVM guest poweroff, the COLO thread may wait a semaphore
in colo_process_checkpoint().So, we should wake up the COLO thread
before migration shutdown.
Signed-off-by: Lei Rao
Reviewed-by: Zhang Chen
Reviewed-by: Juan Quintela
Signed-off-by: Juan Quintela
---
include
It just calls buffer_is_zero(). Just change the callers.
Signed-off-by: Juan Quintela
Reviewed-by: Richard Henderson
---
migration/ram.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 2c688f5bbb..57efa67f20 100644
--- a/migr
We are dividing by page_size to multiply again in the only use.
Once there, improve the comments.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
migration/multifd-zlib.c | 13 -
migration/multifd-zstd.c | 13 -
2 files changed, 8 insertions(+), 18 d
The following changes since commit 76b56fdfc9fa43ec6e5986aee33f108c6c6a511e:
Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu into
staging (2021-12-14 12:46:18 -0800)
are available in the Git repository at:
https://gitlab.com/juan.quintela/qemu.git tags/migration-20211214-
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
migration/migration.c | 7 ---
migration/multifd.c | 7 ---
migration/savevm.c| 5 +++--
3 files changed, 11 insertions(+), 8 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index 2c1edb2c
We will need to split it later in zero_num (number of zero pages) and
normal_num (number of normal pages). This name is better.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
migration/multifd.h | 2 +-
migration/multifd.c | 38 +++---
2 f
We were using the iov directly, but we will need this info on the
following patch.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
migration/multifd.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/migration/multifd.c b/migration/multifd.c
index 55d99a8232..0533da154
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
migration/multifd.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/migration/multifd.c b/migration/multifd.c
index cdeffdc4c5..ce7101cf9d 100644
--- a/migration/multifd.c
+++ b/migration/multifd.c
@@ -629
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
migration/multifd-zlib.c | 2 ++
migration/multifd-zstd.c | 2 ++
migration/multifd.c | 1 +
3 files changed, 5 insertions(+)
diff --git a/migration/multifd-zlib.c b/migration/multifd-zlib.c
index 3fc7813b44..d0437cce2a 1
From: "Rao, Lei"
There is no need to put some trace code in the critical section.
So, moving it behind qemu_mutex_unlock_iothread() can reduce the
lock time.
Signed-off-by: Lei Rao
Reviewed-by: Juan Quintela
Signed-off-by: Juan Quintela
---
migration/colo.c | 6 +++---
1 file changed, 3 inse
From: Li Zhang
When doing live migration with multifd channels 8, 16 or larger number,
the guest hangs in the presence of the network errors such as missing TCP ACKs.
At sender's side:
The main thread is blocked on qemu_thread_join, migration_fd_cleanup
is called because one thread fails on qio_
ping?
On 11/18/21 15:57, Philippe Mathieu-Daudé wrote:
> Various changes in docs/devel/style.rst to improve its
> rST rendering (around C types/qualifiers/functions).
>
> Since v1:
> - Addressed Darren Kenny comments on function names
>
> Based-on: <2028144317.4106651-1-phi...@redhat.com>
>
It is already there as p->pages->num.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
migration/multifd.h | 2 +-
migration/multifd-zlib.c | 7 +++
migration/multifd-zstd.c | 7 +++
migration/multifd.c | 9 +++--
4 files changed, 10 insertions(+), 15 d
ping?
On 11/17/21 18:48, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> scripts/gensyscalls.sh | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/gensyscalls.sh b/scripts/gensyscalls.sh
> index 8fb450e3c96..aee5cc64a15 100755
> ---
It is already there as p->pages->num.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
migration/multifd.h | 2 +-
migration/multifd-zlib.c | 9 -
migration/multifd-zstd.c | 7 +++
migration/multifd.c | 7 +++
4 files changed, 11 insertions(+), 14 d
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
migration/multifd-zlib.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/migration/multifd-zlib.c b/migration/multifd-zlib.c
index e85ef8824d..da6201704c 100644
--- a/migration/multifd-zlib
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
migration/multifd-zstd.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/migration/multifd-zstd.c b/migration/multifd-zstd.c
index a8b104f4ee..2d5b61106c 100644
--- a/migration/multifd
ping for review?
On 11/16/21 20:39, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/net/rocker/rocker.h | 5 -
> 1 file changed, 5 deletions(-)
>
> diff --git a/hw/net/rocker/rocker.h b/hw/net/rocker/rocker.h
> index 412fa44d017..d22bbd2bf80 100644
> --- a/h
On 15/12/2021 11:00, Kevin Wolf wrote:
Am 15.12.2021 um 10:19 hat Emanuele Giuseppe Esposito geschrieben:
On 14/12/2021 15:35, Kevin Wolf wrote:
Am 30.11.2021 um 10:46 hat Emanuele Giuseppe Esposito geschrieben:
drive_add is only used in softmmu/vl.c, so it can be a static
function there,
Hi Laurent,
This patch is reviewed, can it go via your trivial tree?
On 11/16/21 20:39, Philippe Mathieu-Daudé wrote:
> QEMU coding style mandates to not use Linux kernel internal
> types for scalars types. Replace __u32 by uint32_t.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> target/i38
Hi Laurent,
This patch is reviewed, can it go via your trivial tree?
On 11/17/21 18:45, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> qemu-keymap.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/qemu-keymap.c b/qemu-keymap.c
> index 536e8f2385d..4095b6
able in the Git repository at:
https://git.linaro.org/people/pmaydell/qemu-arm.git
tags/pull-target-arm-20211215
for you to fetch changes up to aed176558806674d030a8305d989d4e6a5073359:
tests/acpi: add expected blob for VIOT test on virt machine (2021-12-15
From: Alex Bennée
While trying to debug a GIC ITS failure I saw some guest errors that
had poor formatting as well as leaving me confused as to what failed.
As most of the checks aren't possible without a valid dte split that
check apart and then check the other conditions in steps. This avoids
u
From: Richard Henderson
Create arm_check_ss_active and arm_check_kernelpage.
Reverse the order of the tests. While it doesn't matter in practice,
because only user-only has a kernel page and user-only never sets
ss_active, ss_active has priority over execution exceptions and it
is best to keep
ping.
On 11/16/21 22:09, Philippe Mathieu-Daudé wrote:
> Linux Hexagon port doesn't define a specific 'struct stat'
> but uses the generic one (see Linux commit 6103ec56c65c [*]
> "asm-generic: add generic ABI headers" which predates the
> introduction of the Hexagon port).
>
> Remove the target
From: Joel Stanley
This is the latest URL for the OpenBMC CI. The old URL still works, but
redirects.
Reviewed-by: Cédric Le Goater
Signed-off-by: Joel Stanley
Message-id: 2027065752.330632-3-j...@jms.id.au
Signed-off-by: Peter Maydell
---
docs/system/arm/aspeed.rst | 2 +-
1 file change
From: Joel Stanley
Add X11, FP5280G2, G220A, Rainier and Fuji. Mention that Swift will be
removed in v7.0.
Signed-off-by: Joel Stanley
Reviewed-by: Cédric Le Goater
Message-id: 2027065752.330632-2-j...@jms.id.au
Signed-off-by: Peter Maydell
---
docs/system/arm/aspeed.rst | 7 ++-
1 f
From: Richard Henderson
We will reuse this section of arm_deliver_fault for
raising pc alignment faults.
Signed-off-by: Richard Henderson
Reviewed-by: Peter Maydell
Signed-off-by: Peter Maydell
---
target/arm/tlb_helper.c | 45 +
1 file changed, 28 ins
ping for review?
On 11/16/21 18:26, Philippe Mathieu-Daudé wrote:
> Use the pci_intx() helper instead of open-coding it.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> Based-on: <2026170133.724751-3-fbar...@linux.ibm.com>
> ---
> hw/net/vmxnet3.c | 2 +-
> hw/remote/iohub.c | 6 ++
>
From: Olivier Hériveaux
Fix issue where the data register may be overwritten by next character
reception before being read and returned.
Signed-off-by: Olivier Hériveaux
Reviewed-by: Peter Maydell
Reviewed-by: Alistair Francis
Message-id: 20211128120723.4053-1-olivier.herive...@ledger.fr
Sign
From: Joel Stanley
A common use case for the ASPEED machine is to boot a Linux kernel.
Provide a full example command line.
Reviewed-by: Cédric Le Goater
Signed-off-by: Joel Stanley
Message-id: 2027065752.330632-4-j...@jms.id.au
Signed-off-by: Peter Maydell
---
docs/system/arm/aspeed.rst
From: Richard Henderson
The size of the code covered by a TranslationBlock cannot be 0;
this is checked via assert in tb_gen_code.
Signed-off-by: Richard Henderson
Reviewed-by: Peter Maydell
Signed-off-by: Peter Maydell
---
target/arm/translate-a64.c | 1 +
1 file changed, 1 insertion(+)
di
From: Joel Stanley
Move it to the supported list.
Signed-off-by: Joel Stanley
Message-id: 2027065752.330632-5-j...@jms.id.au
Signed-off-by: Peter Maydell
---
docs/system/arm/aspeed.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/system/arm/aspeed.rst b/docs/sy
In the SSE decode function gen_sse(), we combine a byte
'b' and a value 'b1' which can be [0..3], and switch on them:
b |= (b1 << 8);
switch (b) {
...
default:
unknown_op:
gen_unknown_opcode(env, s);
return;
}
In three cases inside this switch, we were then also che
From: Philippe Mathieu-Daudé
gicv3_set_gicv3state() is used by arm_gicv3_common.c in
arm_gicv3_common_realize(). Since we want to restrict
arm_gicv3_cpuif.c to TCG, extract gicv3_set_gicv3state()
to a new file. Add this file to the meson 'specific'
source set, since it needs access to "cpu.h".
S
From: Richard Henderson
Signed-off-by: Richard Henderson
Reviewed-by: Peter Maydell
Signed-off-by: Peter Maydell
---
target/arm/translate.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/target/arm/translate.c b/target/arm/translate.c
index c721b2ce42c..1
A lot of C files in hw/arm include qemu-common.h when they don't
need anything from it. Drop the include lines.
omap1.c, pxa2xx.c and strongarm.c retain the include because they
use it for the prototype of qemu_get_timedate().
Signed-off-by: Peter Maydell
Reviewed-by: Richard Henderson
Reviewed
The qemu-common.h header is not supposed to be included from any
other header files, only from .c files (as documented in a comment at
the start of it).
include/hw/i386/x86.h and include/hw/i386/microvm.h break this rule.
In fact, the include is not required at all, so we can just drop it
from bot
From: Richard Henderson
Signed-off-by: Richard Henderson
Reviewed-by: Peter Maydell
Signed-off-by: Peter Maydell
---
target/arm/translate.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/target/arm/translate.c b/target/arm/translate.c
index 98f59259284..c721b2ce4
From: Jean-Philippe Brucker
Add two test cases for VIOT, one on the q35 machine and the other on
virt. To test complex topologies the q35 test has two PCIe buses that
bypass the IOMMU (and are therefore not described by VIOT), and two
buses that are translated by virtio-iommu.
Reviewed-by: Eric
From: Richard Henderson
Signed-off-by: Richard Henderson
Reviewed-by: Peter Maydell
Signed-off-by: Peter Maydell
---
target/arm/translate-a64.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
index cec672f2296.
The qemu-common.h header is not supposed to be included from any
other header files, only from .c files (as documented in a comment at
the start of it).
Nothing actually relies on target/rx/cpu.h including it, so we can
just drop the include.
Signed-off-by: Peter Maydell
Reviewed-by: Richard Hen
Hi Laurent,
This patch is reviewed/acked, can it go via your trivial tree?
On 11/9/21 15:45, Philippe Mathieu-Daudé wrote:
> When using the MinGW toolchain, we use the .exe suffix for the
> executable name. We also need to use it for the symlinks in the
> build directory.
>
> Signed-off-by: Phil
From: Richard Henderson
Misaligned thumb PC is architecturally impossible.
Assert is better than proceeding, in case we've missed
something somewhere.
Expand a comment about aligning the pc in gdbstub.
Fail an incoming migrate if a thumb pc is misaligned.
Reviewed-by: Peter Maydell
Signed-off-
From: Patrick Venture
The rx_active boolean change to true should always trigger a try_read
call that flushes the queue.
Signed-off-by: Patrick Venture
Reviewed-by: Philippe Mathieu-Daudé
Message-id: 20211203221002.1719306-1-vent...@google.com
Signed-off-by: Peter Maydell
---
hw/net/npcm7xx_
The qemu-common.h header is not supposed to be included from any
other header files, only from .c files (as documented in a comment at
the start of it).
Move the include to linux-user/hexagon/cpu_loop.c, which needs it for
the declaration of cpu_exec_step_atomic().
Signed-off-by: Peter Maydell
R
From: Richard Henderson
For A64, any input to an indirect branch can cause this.
For A32, many indirect branch paths force the branch to be aligned,
but BXWritePC does not. This includes the BX instruction but also
other interworking changes to PC. Prior to v8, this case is UNDEFINED.
With v8,
The calculation of the length of TLB range invalidate operations
in tlbi_aa64_range_get_length() is incorrect in two ways:
* the NUM field is 5 bits, but we read only 4 bits
* we miscalculate the page_shift value, because of an
off-by-one error:
TG 0b00 is invalid
TG 0b01 is 4K granule
From: Jean-Philippe Brucker
When a virtio-iommu is instantiated, describe it using the ACPI VIOT
table.
Acked-by: Igor Mammedov
Reviewed-by: Eric Auger
Signed-off-by: Jean-Philippe Brucker
Message-id: 20211210170415.583179-2-jean-phili...@linaro.org
Signed-off-by: Peter Maydell
---
hw/arm/v
From: Jean-Philippe Brucker
virtio-iommu is now supported with ACPI VIOT as well as device tree.
Remove the restriction that prevents from instantiating a virtio-iommu
device under ACPI.
Acked-by: Igor Mammedov
Reviewed-by: Eric Auger
Signed-off-by: Jean-Philippe Brucker
Message-id: 202112101
From: Richard Henderson
Both single-step and pc alignment faults have priority over
breakpoint exceptions.
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
Signed-off-by: Peter Maydell
---
target/arm/debug_helper.c | 23 +++
1 file changed, 23 insertions(+)
di
On 12/15/21 09:49, Thomas Huth wrote:
> It's likely broken, and nobody cared for picking it up again
> during the deprecation phase, so let's remove this now.
>
> Since this is the last entry in deprecated_targets_list, remove
> the related code in the configure script, too.
Can we keep that part
From: Philippe Mathieu-Daudé
The TYPE_ARM_GICV3 device is an emulated one. When using
KVM, it is recommended to use the TYPE_KVM_ARM_GICV3 device
(which uses in-kernel support).
When using --with-devices-FOO, it is possible to build a
binary with a specific set of devices. When this binary is
r
From: Jean-Philippe Brucker
Create empty data files and allow updates for the upcoming VIOT tests.
Acked-by: Igor Mammedov
Reviewed-by: Eric Auger
Signed-off-by: Jean-Philippe Brucker
Message-id: 20211210170415.583179-6-jean-phili...@linaro.org
Signed-off-by: Peter Maydell
---
tests/qtest/b
From: Jean-Philippe Brucker
We do not support instantiating multiple IOMMUs. Before adding a
virtio-iommu, check that no other IOMMU is present. This will detect
both "iommu=smmuv3" machine parameter and another virtio-iommu instance.
Fixes: 70e89132c9 ("hw/arm/virt: Add the virtio-iommu device
From: Richard Henderson
Reviewed-by: Peter Maydell
Signed-off-by: Richard Henderson
Signed-off-by: Peter Maydell
---
tests/tcg/aarch64/pcalign-a64.c | 37 +
tests/tcg/arm/pcalign-a32.c | 46 +++
tests/tcg/aarch64/Makefile.target | 4
1 - 100 of 550 matches
Mail list logo
