Re: [PATCH] intel-iommu: ignore SNP bit in scalable mode

2021-11-24 Thread Peter Xu
On Wed, Nov 24, 2021 at 02:03:09PM +0800, Jason Wang wrote: > When booting with scalable mode, I hit this error: > > qemu-system-x86_64: vtd_iova_to_slpte: detected splte reserve non-zero > iova=0xf002, level=0x1slpte=0x102681803) > qemu-system-x86_64: vtd_iommu_translate: detected translatio

Re: [PATCH v2 00/15] hw/nvme: SR-IOV with Virtualization Enhancements

2021-11-24 Thread Klaus Jensen
Hi Lukasz, I've been through this. I have a couple of review comments, but overall looks good for inclusion in nvme-next. Would be nice to get this in early in the cycle so it can mature there for 7.0. I'd like that we mark this support experimental, so we can easily do some changes to how parame

Re: [PATCH v2 12/15] hw/nvme: Initialize capability structures for primary/secondary controllers

2021-11-24 Thread Klaus Jensen
On Nov 16 16:34, Łukasz Gieryk wrote: > With four new properties: > - sriov_v{i,q}_flexible, > - sriov_max_v{i,q}_per_vf, > one can configure the number of available flexible resources, as well as > the limits. The primary and secondary controller capability structures > are initialized according

[qemu-web PATCH v3] Add Sponsors page

2021-11-24 Thread Philippe Mathieu-Daudé
Add a page listing QEMU sponsors. For now, only mention Fosshost which requested to be listed: https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg05381.html Cc: Thomas Markey Resolves: https://gitlab.com/qemu-project/qemu-web/-/issues/2 Signed-off-by: Philippe Mathieu-Daudé --- Since v2:

Re: [PATCH 2/2] ivshmem-test.c: enable test_ivshmem_server for ppc64 arch

2021-11-24 Thread Thomas Huth
On 23/11/2021 22.19, Daniel Henrique Barboza wrote: This test, if enabled by hand, was failing when the ivhsmem device was being declared as DEVICE_NATIVE_ENDIAN with the following error: /ppc64/ivshmem/pair: OK /ppc64/ivshmem/server: ** ERROR:/home/danielhb/qemu/tests/qtest/ivshmem-test.c:367:t

Re: [PATCH] virtio-balloon: correct used length

2021-11-24 Thread Jason Wang
On Wed, Nov 24, 2021 at 3:03 PM Michael S. Tsirkin wrote: > > On Wed, Nov 24, 2021 at 12:32:55PM +0800, Jason Wang wrote: > > Spec said: > > > > "and len the total of bytes written into the buffer." > > > > For inflateq, deflateq and statsq, we don't process in_sg so the used > > length should be

Re: [PATCH v2 13/15] hw/nvme: Add support for the Virtualization Management command

2021-11-24 Thread Klaus Jensen
On Nov 16 16:34, Łukasz Gieryk wrote: > With the new Virtualization Management command one can: > - assign flexible resources (queues, interrupts) to primary and >secondary controllers, > - toggle the online/offline state of given controller. > > Signed-off-by: Łukasz Gieryk > --- > hw/nvm

Re: [qemu-web PATCH v3] Add Sponsors page

2021-11-24 Thread Alistair Francis
On Wed, Nov 24, 2021 at 6:05 PM Philippe Mathieu-Daudé wrote: > > Add a page listing QEMU sponsors. > > For now, only mention Fosshost which requested to be listed: > https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg05381.html > > Cc: Thomas Markey > Resolves: https://gitlab.com/qemu-proj

[PATCH v2] microvm: use MachineState->dumpdtb

2021-11-24 Thread Gerd Hoffmann
There already is a machine property to dump the device tree for debugging purposes, and the helper function qemu_fdt_dumpdtb() implementing the dumping. Make microvm use it for consistency. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé --- hw/i386/microvm-dt.c | 9 +

Re: [PATCH] virtio-balloon: correct used length

2021-11-24 Thread Michael S. Tsirkin
On Wed, Nov 24, 2021 at 03:58:22PM +0800, Jason Wang wrote: > On Wed, Nov 24, 2021 at 3:03 PM Michael S. Tsirkin wrote: > > > > On Wed, Nov 24, 2021 at 12:32:55PM +0800, Jason Wang wrote: > > > Spec said: > > > > > > "and len the total of bytes written into the buffer." > > > > > > For inflateq, d

Re: [PATCH] intel-iommu: ignore SNP bit in scalable mode

2021-11-24 Thread Jason Wang
On Wed, Nov 24, 2021 at 3:57 PM Peter Xu wrote: > > On Wed, Nov 24, 2021 at 02:03:09PM +0800, Jason Wang wrote: > > When booting with scalable mode, I hit this error: > > > > qemu-system-x86_64: vtd_iova_to_slpte: detected splte reserve non-zero > > iova=0xf002, level=0x1slpte=0x102681803) >

Re: [PATCH] virtio-balloon: correct used length

2021-11-24 Thread Jason Wang
On Wed, Nov 24, 2021 at 4:28 PM Jason Wang wrote: > > On Wed, Nov 24, 2021 at 4:25 PM Michael S. Tsirkin wrote: > > > > On Wed, Nov 24, 2021 at 03:58:22PM +0800, Jason Wang wrote: > > > On Wed, Nov 24, 2021 at 3:03 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Wed, Nov 24, 2021 at 12:32

Re: [PATCH] virtio-balloon: correct used length

2021-11-24 Thread Jason Wang
On Wed, Nov 24, 2021 at 4:25 PM Michael S. Tsirkin wrote: > > On Wed, Nov 24, 2021 at 03:58:22PM +0800, Jason Wang wrote: > > On Wed, Nov 24, 2021 at 3:03 PM Michael S. Tsirkin wrote: > > > > > > On Wed, Nov 24, 2021 at 12:32:55PM +0800, Jason Wang wrote: > > > > Spec said: > > > > > > > > "and l

Re: [PATCH-for-6.2] qom/object: Ignore global properties with empty name

2021-11-24 Thread Igor Mammedov
On Fri, 19 Nov 2021 12:32:29 +0100 Philippe Mathieu-Daudé wrote: > When using -global, properties might have empty name/value. > > This fixes this legitimate use case: > > $ qemu-system-x86_64 -global driver=isa-fdc > qemu-system-x86_64: ../../devel/qemu/qapi/string-input-visitor.c:394: >

Re: [PATCH] intel-iommu: ignore SNP bit in scalable mode

2021-11-24 Thread Peter Xu
On Wed, Nov 24, 2021 at 04:28:52PM +0800, Jason Wang wrote: > On Wed, Nov 24, 2021 at 3:57 PM Peter Xu wrote: > > > > On Wed, Nov 24, 2021 at 02:03:09PM +0800, Jason Wang wrote: > > > When booting with scalable mode, I hit this error: > > > > > > qemu-system-x86_64: vtd_iova_to_slpte: detected spl

Re: [PATCH] intel-iommu: ignore SNP bit in scalable mode

2021-11-24 Thread Jason Wang
On Wed, Nov 24, 2021 at 4:52 PM Peter Xu wrote: > > On Wed, Nov 24, 2021 at 04:28:52PM +0800, Jason Wang wrote: > > On Wed, Nov 24, 2021 at 3:57 PM Peter Xu wrote: > > > > > > On Wed, Nov 24, 2021 at 02:03:09PM +0800, Jason Wang wrote: > > > > When booting with scalable mode, I hit this error: >

Re: [qemu-web PATCH v3] Add Sponsors page

2021-11-24 Thread Daniel P . Berrangé
On Wed, Nov 24, 2021 at 09:05:19AM +0100, Philippe Mathieu-Daudé wrote: > Add a page listing QEMU sponsors. > > For now, only mention Fosshost which requested to be listed: > https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg05381.html > > Cc: Thomas Markey > Resolves: https://gitlab.com/

[PATCH] qga: replace "blacklist" with "blocklist"

2021-11-24 Thread marcandre . lureau
From: Marc-André Lureau Let's use a more neutral language for that option. "blacklist" is still silently accepted for compatibility reasons. Signed-off-by: Marc-André Lureau --- docs/interop/qemu-ga.rst | 4 ++-- qga/guest-agent-core.h | 2 +- qga/commands-posix.c | 14 ++---

Re: [PATCH] virtio-balloon: correct used length

2021-11-24 Thread Michael S. Tsirkin
On Wed, Nov 24, 2021 at 04:32:06PM +0800, Jason Wang wrote: > On Wed, Nov 24, 2021 at 4:28 PM Jason Wang wrote: > > > > On Wed, Nov 24, 2021 at 4:25 PM Michael S. Tsirkin wrote: > > > > > > On Wed, Nov 24, 2021 at 03:58:22PM +0800, Jason Wang wrote: > > > > On Wed, Nov 24, 2021 at 3:03 PM Michael

Re: [PATCH 35/35] test/tcg/ppc64le: Add float reference files

2021-11-24 Thread Cédric Le Goater
On 11/22/21 14:14, Richard Henderson wrote: On 11/22/21 2:04 PM, Cédric Le Goater wrote: But this alone of course causes other "failures", because we've got some incorrect reference files. Looks fine. Will you send this patch independently ? Yes. The patchset doesn't seem to break anythin

Re: [PATCH 0/2] change IVSHMEM endianess to LITTLE_ENDIAN

2021-11-24 Thread Daniel Henrique Barboza
On 11/23/21 20:22, Cédric Le Goater wrote: On 11/23/21 22:19, Daniel Henrique Barboza wrote: Hi, This small series fixes an issue reported in Gitlab [1] that affects PowerPC big-endian and little-endian and probably all other big-endians in the wild that might use 'ivshmem'. It's not clear

Re: [PATCH v1 2/7] accel/tcg: suppress IRQ check for special TBs

2021-11-24 Thread Richard Henderson
On 11/23/21 9:57 PM, Alex Bennée wrote: Generally when we set cpu->cflags_next_tb it is because we want to carefully control the execution of the next TB. Currently there is a race that causes cflags_next_tb to get ignored if an IRQ is processed before we execute any actual instructions. To avoi

Re: [PATCH] intel-iommu: ignore SNP bit in scalable mode

2021-11-24 Thread Peter Xu
On Wed, Nov 24, 2021 at 05:01:42PM +0800, Jason Wang wrote: > > > > > -static bool vtd_slpte_nonzero_rsvd(uint64_t slpte, uint32_t level) > > > > > +static bool vtd_slpte_nonzero_rsvd(IntelIOMMUState *s, > > > > > + uint64_t slpte, uint32_t level) > > > > > { > >

Re: [PATCH] qga: replace "blacklist" with "blocklist"

2021-11-24 Thread Daniel P . Berrangé
On Wed, Nov 24, 2021 at 01:09:37PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Let's use a more neutral language for that option. > > "blacklist" is still silently accepted for compatibility reasons. > > Signed-off-by: Marc-André Lureau > --- > docs/interop/qemu-ga

Re: [PATCH 35/35] test/tcg/ppc64le: Add float reference files

2021-11-24 Thread Richard Henderson
On 11/24/21 10:17 AM, Cédric Le Goater wrote: I do now. That was not an easy task. All seem fine with a x86/RH9 but I am having issues building the images on power9/ubuntu21.10. centos8 fails with :   #6 41.69 Error: Unable to find a match: libpmem-devel spice-server-devel and some others with

[PATCH for-7.0 v2 0/2] change ivshmem endianness to LITTLE_ENDIAN

2021-11-24 Thread Daniel Henrique Barboza
Hi, This small series fixes an issue reported in Gitlab [1] that affects PowerPC big-endian and little-endian and probably all other big-endians in the wild that might use 'ivshmem'. It's not clear to me who is the maintainer/responsible for this device (MAINTAINERS doesn't seem to have any 'ivhs

[PATCH for-7.0 v2 2/2] ivshmem-test.c: enable test_ivshmem_server for ppc64 arch

2021-11-24 Thread Daniel Henrique Barboza
This test, if enabled by hand, was failing when the ivhsmem device was being declared as DEVICE_NATIVE_ENDIAN with the following error: /ppc64/ivshmem/pair: OK /ppc64/ivshmem/server: ** ERROR:/home/danielhb/qemu/tests/qtest/ivshmem-test.c:367:test_ivshmem_server: assertion failed (ret != 0): (0 !=

[PATCH for-7.0 v2 1/2] ivshmem.c: change endianness to LITTLE_ENDIAN

2021-11-24 Thread Daniel Henrique Barboza
The ivshmem device, as with most PCI devices, uses little endian byte order. However, the endianness of its mmio_ops is marked as DEVICE_NATIVE_ENDIAN. This presents not only the usual problems with big endian hosts but also with PowerPC little endian hosts as well, since the Power architecture in

Re: [PATCH] intel-iommu: ignore SNP bit in scalable mode

2021-11-24 Thread Jason Wang
On Wed, Nov 24, 2021 at 5:23 PM Peter Xu wrote: > > On Wed, Nov 24, 2021 at 05:01:42PM +0800, Jason Wang wrote: > > > > > > -static bool vtd_slpte_nonzero_rsvd(uint64_t slpte, uint32_t level) > > > > > > +static bool vtd_slpte_nonzero_rsvd(IntelIOMMUState *s, > > > > > > +

Re: [PATCH v1 3/7] tests/avocado: fix tcg_plugin mem access count test

2021-11-24 Thread Richard Henderson
On 11/23/21 9:57 PM, Alex Bennée wrote: When we cleaned up argument handling the test was missed. Fixes: 5ae589faad ("tests/plugins/mem: introduce "track" arg and make args not positional") Signed-off-by: Alex Bennée --- tests/avocado/tcg_plugins.py | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v11 19/26] linux-user: Add LoongArch signal support

2021-11-24 Thread Richard Henderson
On 11/24/21 8:50 AM, gaosong wrote: No, sc_reserved does not match. uint8   sc_reserved[4096] __attribute__((aligned(16))); Yes. BTW, should we set scr[0-3] as 0 ? I think so. The LoongArch Reference Manual, Volume 3: Virtualization and Binary Translation Extensions, v1.00, is empty.

Re: [qemu-web PATCH v3] Add Sponsors page

2021-11-24 Thread Richard Henderson
On 11/24/21 9:05 AM, Philippe Mathieu-Daudé wrote: Add a page listing QEMU sponsors. For now, only mention Fosshost which requested to be listed: This... https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg05381.html Cc: Thomas Markey Resolves: https://gitlab.com/qemu-project/qemu-web

Re: [PATCH v2] microvm: use MachineState->dumpdtb

2021-11-24 Thread Igor Mammedov
On Wed, 24 Nov 2021 09:16:37 +0100 Gerd Hoffmann wrote: > There already is a machine property to dump the device tree for > debugging purposes, and the helper function qemu_fdt_dumpdtb() > implementing the dumping. Make microvm use it for consistency. > > Signed-off-by: Gerd Hoffmann > Reviewe

[PATCH v2 00/23] Migration: Transmit and detect zero pages in the multifd threads

2021-11-24 Thread Juan Quintela
Hi This is a rebase against last master. And the reason for resend is to configure properly git-publish and hope this time that git-publish send all the patches. Please, review. [v1] Since Friday version: - More cleanups on the code - Remove repeated calls to qemu_target_page_size() - Establish

[PATCH v2 03/23] multifd: Rename used field to num

2021-11-24 Thread Juan Quintela
We will need to split it later in zero_num (number of zero pages) and normal_num (number of normal pages). This name is better. Signed-off-by: Juan Quintela --- migration/multifd.h | 2 +- migration/multifd.c | 38 +++--- 2 files changed, 20 insertions(+), 20 de

[PATCH v2 05/23] multifd: The variable is only used inside the loop

2021-11-24 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/multifd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/migration/multifd.c b/migration/multifd.c index cdeffdc4c5..ce7101cf9d 100644 --- a/migration/multifd.c +++ b/migration/multifd.c @@ -629,7 +629,6 @@ static void *multifd_sen

[PATCH v2 11/23] multifd: Move iov from pages to params

2021-11-24 Thread Juan Quintela
This will allow us to reduce the number of system calls on the next patch. Signed-off-by: Juan Quintela --- migration/multifd.h | 8 ++-- migration/multifd.c | 34 -- 2 files changed, 30 insertions(+), 12 deletions(-) diff --git a/migration/multifd.h b/migra

[PATCH v2 01/23] multifd: Delete useless operation

2021-11-24 Thread Juan Quintela
We are divining by page_size to multiply again in the only use. Once there, impreve the comments. Signed-off-by: Juan Quintela --- migration/multifd-zlib.c | 13 - migration/multifd-zstd.c | 13 - 2 files changed, 8 insertions(+), 18 deletions(-) diff --git a/migration/m

[PATCH v2 04/23] multifd: Add missing documention

2021-11-24 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/multifd-zlib.c | 2 ++ migration/multifd-zstd.c | 2 ++ migration/multifd.c | 1 + 3 files changed, 5 insertions(+) diff --git a/migration/multifd-zlib.c b/migration/multifd-zlib.c index 3fc7813b44..d0437cce2a 100644 --- a/migration/multifd-zlib.c

[PATCH v2 07/23] multifd: remove used parameter from send_recv_pages() method

2021-11-24 Thread Juan Quintela
It is already there as p->pages->num. Signed-off-by: Juan Quintela --- migration/multifd.h | 2 +- migration/multifd-zlib.c | 9 - migration/multifd-zstd.c | 7 +++ migration/multifd.c | 7 +++ 4 files changed, 11 insertions(+), 14 deletions(-) diff --git a/migration/m

[PATCH v2 13/23] multifd: Make zstd use iov's

2021-11-24 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/multifd-zstd.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/migration/multifd-zstd.c b/migration/multifd-zstd.c index 2d5b61106c..259277dc42 100644 --- a/migration/multifd-zstd.c +++ b/migration/multifd-zstd.c @@ -154,6 +15

[PATCH v2 10/23] multifd: Make zlib compression method not use iovs

2021-11-24 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/multifd-zlib.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/migration/multifd-zlib.c b/migration/multifd-zlib.c index e85ef8824d..da6201704c 100644 --- a/migration/multifd-zlib.c +++ b/migration/multifd-zlib.c @@

[PATCH v2 06/23] multifd: remove used parameter from send_prepare() method

2021-11-24 Thread Juan Quintela
It is already there as p->pages->num. Signed-off-by: Juan Quintela --- migration/multifd.h | 2 +- migration/multifd-zlib.c | 7 +++ migration/multifd-zstd.c | 7 +++ migration/multifd.c | 9 +++-- 4 files changed, 10 insertions(+), 15 deletions(-) diff --git a/migration/m

[PATCH v2 02/23] migration: Never call twice qemu_target_page_size()

2021-11-24 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/migration.c | 7 --- migration/multifd.c | 7 --- migration/savevm.c| 5 +++-- 3 files changed, 11 insertions(+), 8 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index 2c1edb2cb9..3de11ae921 100644 --- a/migration

[PATCH v2 12/23] multifd: Make zlib use iov's

2021-11-24 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/multifd-zlib.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/migration/multifd-zlib.c b/migration/multifd-zlib.c index da6201704c..478a4af115 100644 --- a/migration/multifd-zlib.c +++ b/migration/multifd-zlib.c @@ -143,6 +14

Re: [PATCH 00/23] Migration: Transmit and detect zero pages in the multifd threads

2021-11-24 Thread Juan Quintela
Juan Quintela wrote: > Hi Nack myself. For some reasons my mail server decided to only sent part of the series. Sorry, Juan. > > Since Friday version: > - More cleanups on the code > - Remove repeated calls to qemu_target_page_size() > - Establish normal pages and zero pages > - detect zero p

Re: [PATCH v2 00/23] Migration: Transmit and detect zero pages in the multifd threads

2021-11-24 Thread Juan Quintela
Juan Quintela wrote: > Hi > > This is a rebase against last master. > > And the reason for resend is to configure properly git-publish and > hope this time that git-publish send all the patches. > > Please, review. And here we are, mail server disturbance again. Nack.

[PATCH v2 09/23] multifd: Make zstd compression method not use iovs

2021-11-24 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/multifd-zstd.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/migration/multifd-zstd.c b/migration/multifd-zstd.c index a8b104f4ee..2d5b61106c 100644 --- a/migration/multifd-zstd.c +++ b/migration/multifd-zstd.

[PATCH v2 14/23] multifd: Remove send_write() method

2021-11-24 Thread Juan Quintela
Everything use now iov's. Signed-off-by: Juan Quintela --- migration/multifd.h | 2 -- migration/multifd-zlib.c | 17 - migration/multifd-zstd.c | 17 - migration/multifd.c | 20 ++-- 4 files changed, 2 insertions(+), 54 deletions(-) di

[PATCH v2 08/23] multifd: Fill offset and block for reception

2021-11-24 Thread Juan Quintela
We were using the iov directly, but we will need this info on the following patch. Signed-off-by: Juan Quintela --- migration/multifd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/migration/multifd.c b/migration/multifd.c index 55d99a8232..0533da154a 100644 --- a/migration/multifd.c ++

[PATCH v3 00/23] Migration: Transmit and detect zero pages in the multifd threads

2021-11-24 Thread Juan Quintela
Hi Trying with a different server. As it used to happen, when I sent everything only to me, everything worked. Sorry folks. [v2] This is a rebase against last master. And the reason for resend is to configure properly git-publish and hope this time that git-publish send all the patches. Please

[PATCH v3 01/23] multifd: Delete useless operation

2021-11-24 Thread Juan Quintela
We are divining by page_size to multiply again in the only use. Once there, impreve the comments. Signed-off-by: Juan Quintela --- migration/multifd-zlib.c | 13 - migration/multifd-zstd.c | 13 - 2 files changed, 8 insertions(+), 18 deletions(-) diff --git a/migration/m

[PATCH v3 06/23] multifd: remove used parameter from send_prepare() method

2021-11-24 Thread Juan Quintela
It is already there as p->pages->num. Signed-off-by: Juan Quintela --- migration/multifd.h | 2 +- migration/multifd-zlib.c | 7 +++ migration/multifd-zstd.c | 7 +++ migration/multifd.c | 9 +++-- 4 files changed, 10 insertions(+), 15 deletions(-) diff --git a/migration/m

[PATCH v3 11/23] multifd: Move iov from pages to params

2021-11-24 Thread Juan Quintela
This will allow us to reduce the number of system calls on the next patch. Signed-off-by: Juan Quintela --- migration/multifd.h | 8 ++-- migration/multifd.c | 34 -- 2 files changed, 30 insertions(+), 12 deletions(-) diff --git a/migration/multifd.h b/migra

[PATCH v3 09/23] multifd: Make zstd compression method not use iovs

2021-11-24 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/multifd-zstd.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/migration/multifd-zstd.c b/migration/multifd-zstd.c index a8b104f4ee..2d5b61106c 100644 --- a/migration/multifd-zstd.c +++ b/migration/multifd-zstd.

[PATCH v3 08/23] multifd: Fill offset and block for reception

2021-11-24 Thread Juan Quintela
We were using the iov directly, but we will need this info on the following patch. Signed-off-by: Juan Quintela --- migration/multifd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/migration/multifd.c b/migration/multifd.c index 55d99a8232..0533da154a 100644 --- a/migration/multifd.c ++

[PATCH v3 02/23] migration: Never call twice qemu_target_page_size()

2021-11-24 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/migration.c | 7 --- migration/multifd.c | 7 --- migration/savevm.c| 5 +++-- 3 files changed, 11 insertions(+), 8 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index 2c1edb2cb9..3de11ae921 100644 --- a/migration

[PATCH v3 07/23] multifd: remove used parameter from send_recv_pages() method

2021-11-24 Thread Juan Quintela
It is already there as p->pages->num. Signed-off-by: Juan Quintela --- migration/multifd.h | 2 +- migration/multifd-zlib.c | 9 - migration/multifd-zstd.c | 7 +++ migration/multifd.c | 7 +++ 4 files changed, 11 insertions(+), 14 deletions(-) diff --git a/migration/m

[PATCH v3 12/23] multifd: Make zlib use iov's

2021-11-24 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/multifd-zlib.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/migration/multifd-zlib.c b/migration/multifd-zlib.c index da6201704c..478a4af115 100644 --- a/migration/multifd-zlib.c +++ b/migration/multifd-zlib.c @@ -143,6 +14

[PATCH v3 19/23] multifd: recv side only needs the RAMBlock host address

2021-11-24 Thread Juan Quintela
So we can remove the MultiFDPages. Signed-off-by: Juan Quintela --- migration/multifd.h | 4 ++-- migration/multifd-zlib.c | 2 +- migration/multifd-zstd.c | 2 +- migration/multifd.c | 7 ++- 4 files changed, 6 insertions(+), 9 deletions(-) diff --git a/migration/multifd.h b/migr

[PATCH v3 13/23] multifd: Make zstd use iov's

2021-11-24 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/multifd-zstd.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/migration/multifd-zstd.c b/migration/multifd-zstd.c index 2d5b61106c..259277dc42 100644 --- a/migration/multifd-zstd.c +++ b/migration/multifd-zstd.c @@ -154,6 +15

[PATCH v3 21/23] multifd: Support for zero pages transmission

2021-11-24 Thread Juan Quintela
This patch adds counters and similar. Logic will be added on the following patch. Signed-off-by: Juan Quintela --- migration/multifd.h| 13 - migration/multifd.c| 22 +++--- migration/trace-events | 2 +- 3 files changed, 32 insertions(+), 5 deletions(-) di

[PATCH v3 05/23] multifd: The variable is only used inside the loop

2021-11-24 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/multifd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/migration/multifd.c b/migration/multifd.c index cdeffdc4c5..ce7101cf9d 100644 --- a/migration/multifd.c +++ b/migration/multifd.c @@ -629,7 +629,6 @@ static void *multifd_sen

[PATCH v3 15/23] multifd: Use a single writev on the send side

2021-11-24 Thread Juan Quintela
Until now, we wrote the packet header with write(), and the rest of the pages with writev(). Just increase the size of the iovec and do a single writev(). Signed-off-by: Juan Quintela --- migration/multifd.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git

[PATCH v3 04/23] multifd: Add missing documention

2021-11-24 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/multifd-zlib.c | 2 ++ migration/multifd-zstd.c | 2 ++ migration/multifd.c | 1 + 3 files changed, 5 insertions(+) diff --git a/migration/multifd-zlib.c b/migration/multifd-zlib.c index 3fc7813b44..d0437cce2a 100644 --- a/migration/multifd-zlib.c

Re: [PATCH] intel-iommu: ignore SNP bit in scalable mode

2021-11-24 Thread Peter Xu
On Wed, Nov 24, 2021 at 05:35:18PM +0800, Jason Wang wrote: > On Wed, Nov 24, 2021 at 5:23 PM Peter Xu wrote: > > > > On Wed, Nov 24, 2021 at 05:01:42PM +0800, Jason Wang wrote: > > > > > > > -static bool vtd_slpte_nonzero_rsvd(uint64_t slpte, uint32_t > > > > > > > level) > > > > > > > +static b

[PATCH v3 14/23] multifd: Remove send_write() method

2021-11-24 Thread Juan Quintela
Everything use now iov's. Signed-off-by: Juan Quintela --- migration/multifd.h | 2 -- migration/multifd-zlib.c | 17 - migration/multifd-zstd.c | 17 - migration/multifd.c | 20 ++-- 4 files changed, 2 insertions(+), 54 deletions(-) di

[PATCH v3 01/10] hw/misc: Add a model of Versal's PMC SLCR

2021-11-24 Thread Francisco Iglesias
Add a model of Versal's PMC SLCR (system-level control registers). Signed-off-by: Francisco Iglesias Signed-off-by: Edgar E. Iglesias Acked-by: Edgar E. Iglesias --- hw/misc/meson.build|5 +- hw/misc/xlnx-versal-pmc-iou-slcr.c | 1445

[PATCH v3 03/23] multifd: Rename used field to num

2021-11-24 Thread Juan Quintela
We will need to split it later in zero_num (number of zero pages) and normal_num (number of normal pages). This name is better. Signed-off-by: Juan Quintela --- migration/multifd.h | 2 +- migration/multifd.c | 38 +++--- 2 files changed, 20 insertions(+), 20 de

[PATCH v3 04/10] hw/dma: Add the DMA control interface

2021-11-24 Thread Francisco Iglesias
Add an interface for controlling DMA models that are reused with other models. This allows a controlling model to start transfers through the DMA while reusing the DMA's handling of transfer state and completion signaling. Signed-off-by: Francisco Iglesias Reviewed-by: Edgar E. Iglesias --- hw/

[PATCH v3 10/23] multifd: Make zlib compression method not use iovs

2021-11-24 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/multifd-zlib.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/migration/multifd-zlib.c b/migration/multifd-zlib.c index e85ef8824d..da6201704c 100644 --- a/migration/multifd-zlib.c +++ b/migration/multifd-zlib.c @@

[PATCH v3 20/23] multifd: Rename pages_used to normal_pages

2021-11-24 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/multifd.h | 3 ++- migration/multifd.c | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/migration/multifd.h b/migration/multifd.h index ab32baebd7..39e55d7f05 100644 --- a/migration/multifd.h +++ b/migration/multifd.h @@ -44,7 +44

[PATCH v3 08/10] hw/block/m25p80: Add support for Micron Xccela flash mt35xu01g

2021-11-24 Thread Francisco Iglesias
Add support for Micron Xccela flash mt35xu01g. Signed-off-by: Francisco Iglesias Reviewed-by: Edgar E. Iglesias --- hw/block/m25p80.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index b77503dc84..c6bf3c6bfa 100644 --- a/hw/block/m25p80.c +++ b/hw/

[PATCH v3 22/23] multifd: Zero pages transmission

2021-11-24 Thread Juan Quintela
This implements the zero page dection and handling. Signed-off-by: Juan Quintela --- migration/multifd.c | 33 +++-- 1 file changed, 31 insertions(+), 2 deletions(-) diff --git a/migration/multifd.c b/migration/multifd.c index 2e4dffd6c6..5c1fc70ce3 100644 --- a/migr

[PATCH v3 16/23] multifd: Unfold "used" variable by its value

2021-11-24 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/multifd.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/migration/multifd.c b/migration/multifd.c index 65676d56fd..6983ba3e7c 100644 --- a/migration/multifd.c +++ b/migration/multifd.c @@ -1059,7 +1059,6 @@ static void *mul

[PATCH v3 05/10] hw/dma/xlnx_csu_dma: Implement the DMA control interface

2021-11-24 Thread Francisco Iglesias
Implement the DMA control interface for allowing control of DMA operations from inside models that contain instances of (and reuse) the Xilinx CSU DMA. Signed-off-by: Francisco Iglesias Reviewed-by: Edgar E. Iglesias --- hw/dma/xlnx_csu_dma.c | 32 inclu

[PATCH v3 23/23] migration: Use multifd before we check for the zero page

2021-11-24 Thread Juan Quintela
So we use multifd to transmit zero pages. Signed-off-by: Juan Quintela --- migration/ram.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 57efa67f20..3ae094f653 100644 --- a/migration/ram.c +++ b/migration/ram.

[PATCH v3 17/23] multifd: Use normal pages array on the send side

2021-11-24 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/multifd.h | 8 ++-- migration/multifd-zlib.c | 6 +++--- migration/multifd-zstd.c | 6 +++--- migration/multifd.c | 30 +++--- migration/trace-events | 4 ++-- 5 files changed, 33 insertions(+), 21 deletions(-)

[PATCH v3 03/10] include/hw/dma/xlnx_csu_dma: Add in missing includes in the header

2021-11-24 Thread Francisco Iglesias
Add in the missing includes in the header for being able to build the DMA model when reusing it. Signed-off-by: Francisco Iglesias --- include/hw/dma/xlnx_csu_dma.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/hw/dma/xlnx_csu_dma.h b/include/hw/dma/xlnx_csu_dma.h index 9e9dc5

[PATCH v3 18/23] multifd: Use normal pages array on the recv side

2021-11-24 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/multifd.h | 8 +-- migration/multifd-zlib.c | 8 +++ migration/multifd-zstd.c | 6 +++--- migration/multifd.c | 45 ++-- 4 files changed, 33 insertions(+), 34 deletions(-) diff --git a/migration/m

[qemu-web PATCH v4] Add Sponsors page

2021-11-24 Thread Philippe Mathieu-Daudé
Add a page listing QEMU sponsors. For now, only mention Fosshost which requested to be listed: https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg05381.html Cc: Thomas Markey Resolves: https://gitlab.com/qemu-project/qemu-web/-/issues/2 Reviewed-by: Stefan Hajnoczi Reviewed-by: Daniel P.

[PATCH v3 07/10] hw/arm/xlnx-versal: Connect the OSPI flash memory controller model

2021-11-24 Thread Francisco Iglesias
Connect the OSPI flash memory controller model (including the source and destination DMA). Signed-off-by: Francisco Iglesias Reviewed-by: Edgar E. Iglesias --- hw/arm/xlnx-versal.c | 87 include/hw/arm/xlnx-versal.h | 20 ++ 2 files c

Re: [qemu-web PATCH v3] Add Sponsors page

2021-11-24 Thread Stefan Hajnoczi
On Wed, Nov 24, 2021 at 09:05:19AM +0100, Philippe Mathieu-Daudé wrote: > Add a page listing QEMU sponsors. > > For now, only mention Fosshost which requested to be listed: > https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg05381.html I don't know if Azure Cloud, PLCT, CIP United, and ARM

Re: [PATCH v11 19/26] linux-user: Add LoongArch signal support

2021-11-24 Thread gaosong
Hi Richard, On 2021/11/20 下午6:33, Richard Henderson wrote: +{ +    int i; + +    __put_user(env->pc, &sc->sc_pc); + +    __put_user(0, &sc->sc_gpr[0]); +    for (i = 1; i < 32; ++i) { +    __put_user(env->gpr[i], &sc->sc_gpr[i]); +    } + +    for (i = 0; i < 32; ++i) { +    __put_user(en

Re: [PATCH v2 03/10] include/hw/dma/xlnx_csu_dma: Include ptimer.h and stream.h in the header

2021-11-24 Thread Francisco Iglesias
Hi Philippe, On [2021 Nov 23] Tue 11:45:45, Philippe Mathieu-Daudé wrote: > On 11/23/21 11:34, Francisco Iglesias wrote: > > Include ptimer.h and stream.h in the header for being able to build and > > reuse the DMA model (the first usage of StreamSink, StreamCanPushNotifyFn > > and ptimer_state is

[PATCH v3 00/10] Xilinx Versal's PMC SLCR and OSPI support

2021-11-24 Thread Francisco Iglesias
Hi, This series attempts to add support for Xilinx Versal's PMC SLCR (system-level control registers) and OSPI flash memory controller to Xilinx Versal virt machine. The series start with adding a model of Versal's PMC SLCR and connecting the model to the Versal virt machine. The series then adds

[PATCH v3 02/10] hw/arm/xlnx-versal: Connect Versal's PMC SLCR

2021-11-24 Thread Francisco Iglesias
Connect Versal's PMC SLCR (system-level control registers) model. Signed-off-by: Francisco Iglesias Reviewed-by: Edgar E. Iglesias --- hw/arm/xlnx-versal.c | 18 ++ include/hw/arm/xlnx-versal.h | 6 ++ 2 files changed, 24 insertions(+) diff --git a/hw/arm/xlnx-vers

Re: [PATCH v11 19/26] linux-user: Add LoongArch signal support

2021-11-24 Thread Richard Henderson
On 11/24/21 11:22 AM, gaosong wrote: I see that  kernel  define  the fcc used type uint64_t,   and  used movgr2cf/movcf2gr save and restore the fcc0-fcc7. but  qemu define  fcc0-fcc7 as  bool cf[8] at target/loongarch/cpu.h,   how qemu can save/restore fcc,  Do you have any idea? Does we can

[PATCH v3 06/10] hw/ssi: Add a model of Xilinx Versal's OSPI flash memory controller

2021-11-24 Thread Francisco Iglesias
Add a model of Xilinx Versal's OSPI flash memory controller. Signed-off-by: Francisco Iglesias Reviewed-by: Edgar E. Iglesias --- hw/ssi/meson.build|1 + hw/ssi/xlnx-versal-ospi.c | 1892 + include/hw/ssi/xlnx-versal-ospi.h | 86

[PATCH v3 10/10] MAINTAINERS: Add an entry for Xilinx Versal OSPI

2021-11-24 Thread Francisco Iglesias
List myself as maintainer for the Xilinx Versal OSPI controller. Signed-off-by: Francisco Iglesias Reviewed-by: Edgar E. Iglesias --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index d3879aa3c1..8c2b01a282 100644 --- a/MAINTAINERS +++ b/MAINT

[PATCH v3 09/10] hw/arm/xlnx-versal-virt: Connect mt35xu01g flashes to the OSPI

2021-11-24 Thread Francisco Iglesias
Connect Micron Xccela mt35xu01g flashes to the OSPI flash memory controller. Signed-off-by: Francisco Iglesias Reviewed-by: Edgar E. Iglesias --- hw/arm/xlnx-versal-virt.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/hw/arm/xlnx-versal-virt.c b/hw/arm/xlnx-versal

Re: [PATCH v1 1/7] softmmu: fix watchpoint-interrupt races

2021-11-24 Thread Alex Bennée
Richard Henderson writes: > On 11/23/21 9:57 PM, Alex Bennée wrote: >> From: Pavel Dovgalyuk >> Watchpoint may be processed in two phases. First one is detecting >> the instruction with target memory access. And the second one is >> executing only one instruction and setting the debug interrup

Re: [PATCH v3 00/23] Migration: Transmit and detect zero pages in the multifd threads

2021-11-24 Thread Peter Xu
On Wed, Nov 24, 2021 at 11:05:54AM +0100, Juan Quintela wrote: > Hi > > Trying with a different server. > As it used to happen, when I sent everything only to me, everything worked. > > Sorry folks. > > [v2] > This is a rebase against last master. > > And the reason for resend is to configure p

Re: How to enable virgl in headless mode?

2021-11-24 Thread Gerd Hoffmann
qemu -display egl-headless take care, Gerd

Re: [PATCH for-7.0 v2 1/2] ivshmem.c: change endianness to LITTLE_ENDIAN

2021-11-24 Thread Philippe Mathieu-Daudé
On 11/24/21 10:29, Daniel Henrique Barboza wrote: > The ivshmem device, as with most PCI devices, uses little endian byte > order. However, the endianness of its mmio_ops is marked as > DEVICE_NATIVE_ENDIAN. This presents not only the usual problems with big > endian hosts but also with PowerPC lit

Re: [PATCH for-7.0 v2 2/2] ivshmem-test.c: enable test_ivshmem_server for ppc64 arch

2021-11-24 Thread Philippe Mathieu-Daudé
On 11/24/21 10:29, Daniel Henrique Barboza wrote: > This test, if enabled by hand, was failing when the ivhsmem device was > being declared as DEVICE_NATIVE_ENDIAN with the following error: > > /ppc64/ivshmem/pair: OK > /ppc64/ivshmem/server: > ** > ERROR:/home/danielhb/qemu/tests/qtest/ivshmem-te

Re: [qemu-web PATCH v3] Add Sponsors page

2021-11-24 Thread Philippe Mathieu-Daudé
On 11/24/21 10:42, Richard Henderson wrote: > On 11/24/21 9:05 AM, Philippe Mathieu-Daudé wrote: >> Add a page listing QEMU sponsors. >> >> For now, only mention Fosshost which requested to be listed: > > This... > >> https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg05381.html >> >> Cc: T

Re: [qemu-web PATCH v3] Add Sponsors page

2021-11-24 Thread Philippe Mathieu-Daudé
On 11/24/21 11:11, Stefan Hajnoczi wrote: > On Wed, Nov 24, 2021 at 09:05:19AM +0100, Philippe Mathieu-Daudé wrote: >> Add a page listing QEMU sponsors. >> >> For now, only mention Fosshost which requested to be listed: >> https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg05381.html > > I d

Re: [PATCH for-7.0 v2 1/2] ivshmem.c: change endianness to LITTLE_ENDIAN

2021-11-24 Thread Daniel Henrique Barboza
On 11/24/21 08:28, Philippe Mathieu-Daudé wrote: On 11/24/21 10:29, Daniel Henrique Barboza wrote: The ivshmem device, as with most PCI devices, uses little endian byte order. However, the endianness of its mmio_ops is marked as DEVICE_NATIVE_ENDIAN. This presents not only the usual problems

Re: [PATCH v1 2/7] accel/tcg: suppress IRQ check for special TBs

2021-11-24 Thread Alex Bennée
Richard Henderson writes: > On 11/23/21 9:57 PM, Alex Bennée wrote: >> Generally when we set cpu->cflags_next_tb it is because we want to >> carefully control the execution of the next TB. Currently there is a >> race that causes cflags_next_tb to get ignored if an IRQ is processed >> before we

  1   2   3   4   >