[PULL 4/8] ui/vnc-clipboard: fix adding notifier twice

2021-11-22 Thread Gerd Hoffmann
From: Vladimir Sementsov-Ogievskiy vnc_server_cut_text_caps() is not guaranteed to be called only once. If it called twice, we finally call notifier_list_add() twice with same element. Which leads to loopback QLIST. So, on next notifier_list_notify() we'll loop forever and QEMU stuck. So, let's

[PULL 8/8] microvm: check g_file_set_contents() return value

2021-11-22 Thread Gerd Hoffmann
Fixes: CID 1465239 Signed-off-by: Gerd Hoffmann Message-Id: <20211108130718.840216-3-kra...@redhat.com> --- hw/i386/microvm-dt.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/i386/microvm-dt.c b/hw/i386/microvm-dt.c index a6a59a6e12cd..9c3c4995b41d 100644 --- a/hw/i38

[PULL 6/8] hw/i386/microvm: Reduce annoying debug message in dt_setup_microvm()

2021-11-22 Thread Gerd Hoffmann
From: Philippe Mathieu-Daudé Fixes: f5918a99283 ("microvm: add device tree support.") Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Sergio Lopez Reviewed-by: Darren Kenny Message-Id: <2027174331.1715144-1-phi...@redhat.com> Signed-off-by: Gerd Hoffmann --- hw/i386/microvm-dt.c | 4 +

Re: [PATCH] Fix CPUID_Fn8000001E_EBX for AMD

2021-11-22 Thread Jade Cheng
Sorry for this really late response due to some personal stuff. Thanks to Eduardo for clarifying, and yes, this fix is to make the bits 7:0 in Fn8000_001E_EBX be physical core_id per package/socket, instead for what used to be physical core_id per die. When topo for vm is like: sockets=1, dies=8, c

Re: [PATCH 1/2] docs: Fix botched rST conversion of 'submitting-a-patch.rst'

2021-11-22 Thread Kashyap Chamarthy
On Mon, Nov 22, 2021 at 01:36:53PM +0100, Thomas Huth wrote: > On 22/11/2021 13.19, Kashyap Chamarthy wrote: [...] > > I kept that because an explicit reminder about spell-check is useful; > > it's easy to forget. Another option is to retain the line, but replace > > "See also:" with "And:". No

Re: [PATCH 35/35] test/tcg/ppc64le: Add float reference files

2021-11-22 Thread Cédric Le Goater
On 11/22/21 12:16, Richard Henderson wrote: On 11/22/21 10:43 AM, Richard Henderson wrote: On 11/21/21 6:47 PM, Cédric Le Goater wrote: I am getting an error with this test. See below. ...   ### Rounding to nearest   from single: f32(-nan:0xffa0) -  to double: f64(-nan:0x00fff4000

[PATCH for-6.2 0/2] linux-user: Create a common rewind_if_in_safe_syscall

2021-11-22 Thread Richard Henderson
This is a re-packaging of two of Warner's patches that fix a build issue on aarch64 using musl: https://lore.kernel.org/qemu-devel/20211108194230.1836262-1-raj.k...@gmail.com/ r~ Warner Losh (2): linux-user: Add host_signal_set_pc to set pc in mcontext linux-user/signal.c: Create a common

[PATCH for-6.2 1/2] linux-user: Add host_signal_set_pc to set pc in mcontext

2021-11-22 Thread Richard Henderson
From: Warner Losh Add a new function host_signal_set_pc to set the next pc in an mcontext. The caller should ensure this is a valid PC for execution. Signed-off-by: Warner Losh Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <2023045603.60391-2-...@bsdimp.co

Re: [PATCH 35/35] test/tcg/ppc64le: Add float reference files

2021-11-22 Thread Richard Henderson
On 11/22/21 2:04 PM, Cédric Le Goater wrote: But this alone of course causes other "failures", because we've got some incorrect reference files. Looks fine. Will you send this patch independently ? Yes. The patchset doesn't seem to break anything. You may not have docker cross-compilers e

[PATCH for-6.2 2/2] linux-user/signal.c: Create a common rewind_if_in_safe_syscall

2021-11-22 Thread Richard Henderson
From: Warner Losh All instances of rewind_if_in_safe_syscall are the same, differing only in how the instruction point is fetched from the ucontext and the size of the registers. Use host_signal_pc and new host_signal_set_pc interfaces to fetch the pointer to the PC and adjust if needed. Delete a

Re: [RFC PATCH-for-6.2 v3] qdev-monitor: Only allow full --global .= option

2021-11-22 Thread Daniel P . Berrangé
On Sat, Nov 20, 2021 at 07:53:20AM +0100, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > > > When not all fields of the --global option are provided, > > QEMU might crash: > > > > $ qemu-system-x86_64 -global driver=isa-fdc > > qemu-system-x86_64: ../../devel/qemu/qapi/string-inp

Re: [PATCH 1/2] docs: Fix botched rST conversion of 'submitting-a-patch.rst'

2021-11-22 Thread Peter Maydell
On Mon, 22 Nov 2021 at 12:37, Thomas Huth wrote: > What about simply replacing it with a new sentence below the bullet list, > saying: > > "Please also use a spell checker like `codespell > https://github.com/codespell-project/codespell` with your patches" How many regular contributors actually d

Re: [PATCH 1/2] docs: Fix botched rST conversion of 'submitting-a-patch.rst'

2021-11-22 Thread Thomas Huth
On 22/11/2021 14.25, Peter Maydell wrote: On Mon, 22 Nov 2021 at 12:37, Thomas Huth wrote: What about simply replacing it with a new sentence below the bullet list, saying: "Please also use a spell checker like `codespell https://github.com/codespell-project/codespell` with your patches" How

Re: [RFC v2 PATCH 01/13] mm/shmem: Introduce F_SEAL_GUEST

2021-11-22 Thread Jason Gunthorpe
On Mon, Nov 22, 2021 at 10:26:12AM +0100, David Hildenbrand wrote: > I do wonder if we want to support sharing such memfds between processes > in all cases ... we most certainly don't want to be able to share > encrypted memory between VMs (I heard that the kernel has to forbid > that). It would m

Re: [PATCH 1/2] docs: Fix botched rST conversion of 'submitting-a-patch.rst'

2021-11-22 Thread Daniel P . Berrangé
On Mon, Nov 22, 2021 at 02:30:10PM +0100, Thomas Huth wrote: > On 22/11/2021 14.25, Peter Maydell wrote: > > On Mon, 22 Nov 2021 at 12:37, Thomas Huth wrote: > > > What about simply replacing it with a new sentence below the bullet list, > > > saying: > > > > > > "Please also use a spell checker

Re: [RFC v2 PATCH 01/13] mm/shmem: Introduce F_SEAL_GUEST

2021-11-22 Thread David Hildenbrand
On 22.11.21 14:31, Jason Gunthorpe wrote: > On Mon, Nov 22, 2021 at 10:26:12AM +0100, David Hildenbrand wrote: > >> I do wonder if we want to support sharing such memfds between processes >> in all cases ... we most certainly don't want to be able to share >> encrypted memory between VMs (I heard

Re: [PATCH 1/2] docs: Fix botched rST conversion of 'submitting-a-patch.rst'

2021-11-22 Thread Thomas Huth
On 22/11/2021 14.33, Daniel P. Berrangé wrote: On Mon, Nov 22, 2021 at 02:30:10PM +0100, Thomas Huth wrote: On 22/11/2021 14.25, Peter Maydell wrote: On Mon, 22 Nov 2021 at 12:37, Thomas Huth wrote: What about simply replacing it with a new sentence below the bullet list, saying: "Please als

Re: [PATCH] vfio/migration: Improve to read/write full migration region per chunk

2021-11-22 Thread Alex Williamson
On Mon, 22 Nov 2021 09:40:56 +0200 Yishai Hadas wrote: > Gentle ping for review, CCing more people who may be involved. I'll wait for comments from others, but since we're already in the 6.2 freeze and vfio migration is still experimental (and I'm on PTO this week), I expect this to be queued wh

[PULL 1/1] Revert "arm: tcg: Adhere to SMCCC 1.3 section 5.2"

2021-11-22 Thread Peter Maydell
This reverts commit 9fcd15b9193e819b6cc2fd0a45e3506148812bb4. This change turns out to cause regressions, for instance on the imx6ul boards as described here: https://lore.kernel.org/qemu-devel/c8b89685-7490-328b-51a3-48711c140...@tribudubois.net/ The primary cause of that regression is that the

[PULL 0/1] target-arm queue

2021-11-22 Thread Peter Maydell
: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20211122 for you to fetch changes up to 4825eaae4fdd56fba0febdfbdd7bf9684ae3ee0d: Revert "arm: tcg: Adhere to SMCCC 1.3 section 5.2" (2021-11-22 13:41:48 +) ---

Re: [PATCH 1/2] docs: Fix botched rST conversion of 'submitting-a-patch.rst'

2021-11-22 Thread Peter Maydell
On Mon, 22 Nov 2021 at 13:30, Thomas Huth wrote: > > On 22/11/2021 14.25, Peter Maydell wrote: > > On Mon, 22 Nov 2021 at 12:37, Thomas Huth wrote: > >> What about simply replacing it with a new sentence below the bullet list, > >> saying: > >> > >> "Please also use a spell checker like `codespel

Re: [RFC v2 PATCH 01/13] mm/shmem: Introduce F_SEAL_GUEST

2021-11-22 Thread Kirill A. Shutemov
On Fri, Nov 19, 2021 at 02:51:11PM +0100, David Hildenbrand wrote: > On 19.11.21 14:47, Chao Peng wrote: > > From: "Kirill A. Shutemov" > > > > The new seal type provides semantics required for KVM guest private > > memory support. A file descriptor with the seal set is going to be used > > as so

Re: [RFC v2 PATCH 01/13] mm/shmem: Introduce F_SEAL_GUEST

2021-11-22 Thread Jason Gunthorpe
On Mon, Nov 22, 2021 at 02:35:49PM +0100, David Hildenbrand wrote: > On 22.11.21 14:31, Jason Gunthorpe wrote: > > On Mon, Nov 22, 2021 at 10:26:12AM +0100, David Hildenbrand wrote: > > > >> I do wonder if we want to support sharing such memfds between processes > >> in all cases ... we most certa

[PULL 2/2] nbd/server: Simplify zero and trim

2021-11-22 Thread Eric Blake
Now that the block layer supports 64-bit operations (see commit 2800637a and friends, new to v6.2), we no longer have to self-fragment requests larger than 2G, reverting the workaround added in 890cbccb08 ("nbd: Fix large trim/zero requests", v5.1.0). Signed-off-by: Eric Blake Message-Id: <202111

[PULL 0/2] NBD patches for 6.2-rc2, 2021-11-22

2021-11-22 Thread Eric Blake
The following changes since commit 49aaac3548bc5a4632a14de939d5312b28dc1ba2: Merge tag 'linux-user-for-6.2-pull-request' of git://github.com/vivier/qemu into staging (2021-11-22 10:33:13 +0100) are available in the Git repository at: https://repo.or.cz/qemu/ericb.git tags/pull-nbd-2021-11-2

[PULL 1/2] nbd/server: Don't complain on certain client disconnects

2021-11-22 Thread Eric Blake
When a client disconnects abruptly, but did not have any pending requests (for example, when using nbdsh without calling h.shutdown), we used to output the following message: $ qemu-nbd -f raw file $ nbdsh -u 'nbd://localhost:10809' -c 'h.trim(1,0)' qemu-nbd: Disconnect client, due to: Failed to r

Re: [PATCH 1/2] docs: Fix botched rST conversion of 'submitting-a-patch.rst'

2021-11-22 Thread Thomas Huth
On 22/11/2021 14.53, Peter Maydell wrote: On Mon, 22 Nov 2021 at 13:30, Thomas Huth wrote: On 22/11/2021 14.25, Peter Maydell wrote: On Mon, 22 Nov 2021 at 12:37, Thomas Huth wrote: What about simply replacing it with a new sentence below the bullet list, saying: "Please also use a spell c

Re: [PATCH for-6.2] qapi/machine.json: Fix incorrect description for die-id

2021-11-22 Thread Eric Blake
On Mon, Nov 22, 2021 at 11:26:51AM +0800, Yanan Wang wrote: > In terms of scope, die-id should mean "the die number within > socket the CPU belongs to" instead of "the die number within > node/board the CPU belongs to". Fix it to avoid confusing > the Doc reader. > > Fixes: 176d2cda0d ("i386/cpu:

Re: [RFC v2 PATCH 13/13] KVM: Enable memfd based page invalidation/fallocate

2021-11-22 Thread Kirill A. Shutemov
On Fri, Nov 19, 2021 at 09:47:39PM +0800, Chao Peng wrote: > Since the memory backing store does not get notified when VM is > destroyed so need check if VM is still live in these callbacks. > > Signed-off-by: Yu Zhang > Signed-off-by: Chao Peng > --- > virt/kvm/memfd.c | 22 +++

[PATCH] linux-user: implement more loop ioctls

2021-11-22 Thread Andreas Schwab
LOOP_CONFIGURE is now used by losetup, and it cannot cope with ENOSYS. Signed-off-by: Andreas Schwab --- linux-user/ioctls.h| 4 linux-user/linux_loop.h| 2 ++ linux-user/syscall_defs.h | 4 linux-user/syscall_types.h | 6 ++ 4 files changed, 16 insertions(+) diff --g

Re: [RFC PATCH-for-6.2 v3] qdev-monitor: Only allow full --global .= option

2021-11-22 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Sat, Nov 20, 2021 at 07:53:20AM +0100, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >> > When not all fields of the --global option are provided, >> > QEMU might crash: >> > >> > $ qemu-system-x86_64 -global driver=isa-fdc >> > qemu-system-x8

[PULL 0/6] Documentation updates

2021-11-22 Thread Thomas Huth
Hi Richard! The following changes since commit c5fbdd60cf1fb52f01bdfe342b6fa65d5343e1b1: Merge tag 'qemu-sparc-20211121' of git://github.com/mcayland/qemu into staging (2021-11-21 14:12:25 +0100) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull-request-2

[PULL 1/6] docs: Fix botched rST conversion of 'submitting-a-patch.rst'

2021-11-22 Thread Thomas Huth
From: Kashyap Chamarthy I completely botched up the merged[0] rST conversion of this document by accidentally dropping entire hunks (!) of text. :-( I made it very hard for reviewers to spot it, as the omitted text was buried deep in the document. To fix my hatchet job, I reconverted the "Submi

[PULL 4/6] docs: Drop deprecated 'props' from object-add

2021-11-22 Thread Thomas Huth
From: "Rao, Lei" In commit 5024340745 "qapi/qom: Drop deprecated 'props' from object-add" (v6.0.0), we also should update documents. Signed-off-by: Lei Rao Message-Id: <1637567387-28250-1-git-send-email-lei@intel.com> Reviewed-by: Markus Armbruster Signed-off-by: Thomas Huth --- docs/COL

[PULL 5/6] docs: Use double quotes instead of single quotes for COLO

2021-11-22 Thread Thomas Huth
From: "Rao, Lei" Signed-off-by: Lei Rao Message-Id: <1637567387-28250-2-git-send-email-lei@intel.com> Reviewed-by: Markus Armbruster Signed-off-by: Thomas Huth --- docs/COLO-FT.txt | 106 ++--- docs/block-replication.txt | 52 +-

[PULL 2/6] docs: List more commit-message tags in "submitting-a-patch"

2021-11-22 Thread Thomas Huth
From: Kashyap Chamarthy Add some more examples of commonly used commit-message tags. (Thanks: Alex Bennée) Signed-off-by: Kashyap Chamarthy Message-Id: <2029193118.949698-3-kcham...@redhat.com> Reviewed-by: Eric Blake Signed-off-by: Thomas Huth --- docs/devel/submitting-a-patch.rst | 4

[PULL 6/6] docs: Render binary names as monospaced text

2021-11-22 Thread Thomas Huth
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Message-Id: <2028192744.64325-1-phi...@redhat.com> Reviewed-by: Darren Kenny Signed-off-by: Thomas Huth --- docs/about/removed-features.rst| 8 docs/devel/build-system.rst| 6 +++--- docs/dev

[PULL 3/6] Fix some typos in documentation (found by codespell)

2021-11-22 Thread Thomas Huth
From: Stefan Weil Signed-off-by: Stefan Weil Message-Id: <2027210702.1393570-1...@weilnetz.de> Reviewed-by: Philippe Mathieu-Daudé [thuth: "what's" --> "what is" as suggested by philmd] Signed-off-by: Thomas Huth --- docs/devel/multi-process.rst| 2 +- docs/devel/qgraph.rst

Re: [PATCH 1/2] docs: Fix botched rST conversion of 'submitting-a-patch.rst'

2021-11-22 Thread Kashyap Chamarthy
On Mon, Nov 22, 2021 at 03:01:58PM +0100, Thomas Huth wrote: > On 22/11/2021 14.53, Peter Maydell wrote: [...] > > I don't think we should be recommending to new contributors that > > they do things that established contributors generally do not do. > > The document has enough "things you should

Re: [PATCH-for-6.2 0/2] hw/block/fdc: Fix CVE-2021-3507

2021-11-22 Thread Philippe Mathieu-Daudé
ping for 6.2? On 11/18/21 12:57, Philippe Mathieu-Daudé wrote: > Trivial fix for CVE-2021-3507. > > Philippe Mathieu-Daudé (2): > hw/block/fdc: Prevent end-of-track overrun (CVE-2021-3507) > tests/qtest/fdc-test: Add a regression test for CVE-2021-3507 > > hw/block/fdc.c | 8 ++

Re: [PATCH-for-6.2 v3 0/2] hw/block/fdc: Fix CVE-2021-20196

2021-11-22 Thread Philippe Mathieu-Daudé
ping for 6.2? > Alexander Bulekov (1): > tests/qtest/fdc-test: Add a regression test for CVE-2021-20196 > > Philippe Mathieu-Daudé (1): > hw/block/fdc: Kludge missing floppy drive to fix CVE-2021-20196 > > hw/block/fdc.c | 14 +- > tests/qtest/fdc-test.c | 21 +++

Re: [RFC v2 PATCH 01/13] mm/shmem: Introduce F_SEAL_GUEST

2021-11-22 Thread David Hildenbrand
On 22.11.21 15:01, Jason Gunthorpe wrote: > On Mon, Nov 22, 2021 at 02:35:49PM +0100, David Hildenbrand wrote: >> On 22.11.21 14:31, Jason Gunthorpe wrote: >>> On Mon, Nov 22, 2021 at 10:26:12AM +0100, David Hildenbrand wrote: >>> I do wonder if we want to support sharing such memfds between p

Re: [PATCH for-6.2 2/2] linux-user/signal.c: Create a common rewind_if_in_safe_syscall

2021-11-22 Thread Warner Losh
On Mon, Nov 22, 2021 at 6:12 AM Richard Henderson < richard.hender...@linaro.org> wrote: > From: Warner Losh > > All instances of rewind_if_in_safe_syscall are the same, differing only > in how the instruction point is fetched from the ucontext and the size > of the registers. Use host_signal_pc

Re: [PATCH for-6.2 1/2] linux-user: Add host_signal_set_pc to set pc in mcontext

2021-11-22 Thread Warner Losh
On Mon, Nov 22, 2021 at 6:12 AM Richard Henderson < richard.hender...@linaro.org> wrote: > From: Warner Losh > > Add a new function host_signal_set_pc to set the next pc in an > mcontext. The caller should ensure this is a valid PC for execution. > > Signed-off-by: Warner Losh > Reviewed-by: Phi

Re: [PATCH v5 04/17] common-user: Move syscall error detection into safe_syscall_base

2021-11-22 Thread Peter Maydell
On Mon, 22 Nov 2021 at 12:21, Richard Henderson wrote: > > On 11/22/21 12:55 PM, Peter Maydell wrote: > >> + /* > >> + * The syscall calling convention isn't the same as the C one: > > > > Looks like the indent here is wrong ? > > Irritatingly, these files are a mix of tabs/spaces.

Re: [PATCH] s390x/ipl: support extended kernel command line size

2021-11-22 Thread Marc Hartmayer
David Hildenbrand writes: > On 22.11.21 12:29, Marc Hartmayer wrote: >> In the past s390 used a fixed command line length of 896 bytes. This has >> changed >> with the Linux commit 5ecb2da660ab ("s390: support command lines longer than >> 896 >> bytes"). There is now a parm area indicating the

Re: [PATCH-for-7.0 1/5] hw/display: Rename VGA_ISA_MM -> VGA_MMIO

2021-11-22 Thread Thomas Huth
On 19/11/2021 18.11, Philippe Mathieu-Daudé wrote: There is no ISA bus part in the MMIO VGA device, so rename: * hw/display/vga-isa-mm.c -> hw/display/vga-mmio.c * CONFIG_VGA_ISA_MM -> CONFIG_VGA_MMIO * ISAVGAMMState -> VGAMmioState * isa_vga_mm_init() -> vga_mmio_init() Signed-off-

Re: [PATCH-for-7.0 2/5] hw/display/vga-mmio: Inline vga_mm_init()

2021-11-22 Thread Thomas Huth
On 19/11/2021 18.11, Philippe Mathieu-Daudé wrote: Inline vga_mm_init() in vga_mmio_init() to simplify the next patch review. Kind of. Signed-off-by: Philippe Mathieu-Daudé --- hw/display/vga-mmio.c | 27 ++- 1 file changed, 10 insertions(+), 17 deletions(-) diff --g

Re: [RFC v2 PATCH 01/13] mm/shmem: Introduce F_SEAL_GUEST

2021-11-22 Thread Jason Gunthorpe
On Mon, Nov 22, 2021 at 03:57:17PM +0100, David Hildenbrand wrote: > On 22.11.21 15:01, Jason Gunthorpe wrote: > > On Mon, Nov 22, 2021 at 02:35:49PM +0100, David Hildenbrand wrote: > >> On 22.11.21 14:31, Jason Gunthorpe wrote: > >>> On Mon, Nov 22, 2021 at 10:26:12AM +0100, David Hildenbrand wrot

Re: [RFC v2 PATCH 01/13] mm/shmem: Introduce F_SEAL_GUEST

2021-11-22 Thread David Hildenbrand
On 22.11.21 16:09, Jason Gunthorpe wrote: > On Mon, Nov 22, 2021 at 03:57:17PM +0100, David Hildenbrand wrote: >> On 22.11.21 15:01, Jason Gunthorpe wrote: >>> On Mon, Nov 22, 2021 at 02:35:49PM +0100, David Hildenbrand wrote: On 22.11.21 14:31, Jason Gunthorpe wrote: > On Mon, Nov 22, 202

Re: [PATCH] linux-user: implement more loop ioctls

2021-11-22 Thread Laurent Vivier
Le 22/11/2021 à 15:18, Andreas Schwab a écrit : LOOP_CONFIGURE is now used by losetup, and it cannot cope with ENOSYS. Signed-off-by: Andreas Schwab --- linux-user/ioctls.h| 4 linux-user/linux_loop.h| 2 ++ linux-user/syscall_defs.h | 4 linux-user/syscall_types.h |

Re: [PULL 0/8] Fixes 20211122 patches

2021-11-22 Thread Richard Henderson
kraxel.org/qemu tags/fixes-20211122-pull-request for you to fetch changes up to b9e5628ca5d42994cc6f82752d9bf0bc98f51f64: microvm: check g_file_set_contents() return value (2021-11-22 11:14:28 +0100) fixes for 6.2: microvm, u

Re: [PATCH for-6.2 0/2] linux-user: Create a common rewind_if_in_safe_syscall

2021-11-22 Thread Laurent Vivier
Hi, Le 22/11/2021 à 14:11, Richard Henderson a écrit : This is a re-packaging of two of Warner's patches that fix a build issue on aarch64 using musl: https://lore.kernel.org/qemu-devel/20211108194230.1836262-1-raj.k...@gmail.com/ r~ Warner Losh (2): linux-user: Add host_signal_set_pc to

Re: [PATCH for-6.2 0/2] linux-user: Create a common rewind_if_in_safe_syscall

2021-11-22 Thread Richard Henderson
On 11/22/21 4:43 PM, Laurent Vivier wrote: Hi, Le 22/11/2021 à 14:11, Richard Henderson a écrit : This is a re-packaging of two of Warner's patches that fix a build issue on aarch64 using musl: https://lore.kernel.org/qemu-devel/20211108194230.1836262-1-raj.k...@gmail.com/ r~ Warner Losh (

[PATCH v2] linux-user: implement more loop ioctls

2021-11-22 Thread Andreas Schwab
LOOP_CONFIGURE is now used by losetup, and it cannot cope with ENOSYS. Signed-off-by: Andreas Schwab --- v2: fix s/loop_configure/loop_config/ typo linux-user/ioctls.h| 4 linux-user/linux_loop.h| 2 ++ linux-user/syscall_defs.h | 4 linux-user/syscall_types.h | 6 ++

Re: [PATCH v2] linux-user: implement more loop ioctls

2021-11-22 Thread Laurent Vivier
Le 22/11/2021 à 16:56, Andreas Schwab a écrit : LOOP_CONFIGURE is now used by losetup, and it cannot cope with ENOSYS. Signed-off-by: Andreas Schwab --- v2: fix s/loop_configure/loop_config/ typo linux-user/ioctls.h| 4 linux-user/linux_loop.h| 2 ++ linux-user/syscall_def

Re: [PATCH for-6.2 0/2] linux-user: Create a common rewind_if_in_safe_syscall

2021-11-22 Thread Laurent Vivier
Le 22/11/2021 à 16:50, Richard Henderson a écrit : On 11/22/21 4:43 PM, Laurent Vivier wrote: Hi, Le 22/11/2021 à 14:11, Richard Henderson a écrit : This is a re-packaging of two of Warner's patches that fix a build issue on aarch64 using musl: https://lore.kernel.org/qemu-devel/2021110819423

Re: [PATCH v4 20/32] nbd/client-connection: implement connection retry

2021-11-22 Thread Eric Blake
Reviving this thread, as a good as place as any for my question: On Thu, Jun 10, 2021 at 01:07:50PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Add an option for a thread to retry connection until succeeds. We'll > use nbd/client-connection both for reconnect and for initial connection > in nbd_o

Re: [PATCH v1 0/9] hw/mos6522: VIA timer emulation fixes and improvements

2021-11-22 Thread Peter Maydell
On Sat, 20 Nov 2021 at 23:40, Finn Thain wrote: > Anyway, thanks for taking the time to write. A competent reviewer has to > do much more than that, but I'm not paying for competence so I suppose I'm > asking too much. Please dial back the aggressive tone here, Finn: this kind of thing is way out

[PATCH for-6.2] hw/intc/arm_gicv3_its: Revert version increments in vmstate_its

2021-11-22 Thread Eric Auger
Commit 18f6290a6a ("hw/intc: GICv3 ITS initial framework") incremented version_id and minimum_version_id fields of VMStateDescription vmstate_its. This breaks the migration between 6.2 and 6.1 with the following message: qemu-system-aarch64: savevm: unsupported version 1 for 'arm_gicv3_its' v0 qem

Re: [PATCH v4 20/32] nbd/client-connection: implement connection retry

2021-11-22 Thread Vladimir Sementsov-Ogievskiy
22.11.2021 19:30, Eric Blake wrote: Reviving this thread, as a good as place as any for my question: On Thu, Jun 10, 2021 at 01:07:50PM +0300, Vladimir Sementsov-Ogievskiy wrote: Add an option for a thread to retry connection until succeeds. We'll use nbd/client-connection both for reconnect an

Re: [PATCH v3 3/3] cpus-common: implement dirty limit on vCPU

2021-11-22 Thread Hyman
在 2021/11/22 19:26, Markus Armbruster 写道: Hyman Huang writes: 在 2021/11/22 17:10, Markus Armbruster 写道: Hyman Huang writes: =E5=9C=A8 2021/11/22 15:35, Markus Armbruster =E5=86=99=E9=81=93: huang...@chinatelecom.cn writes: From: Hyman Huang(=E9=BB=84=E5=8B=87) implement dirtyrate c

Re: [PATCH for-6.2] hw/intc/arm_gicv3_its: Revert version increments in vmstate_its

2021-11-22 Thread Peter Maydell
On Mon, 22 Nov 2021 at 17:10, Eric Auger wrote: > > Commit 18f6290a6a ("hw/intc: GICv3 ITS initial framework") > incremented version_id and minimum_version_id fields of > VMStateDescription vmstate_its. This breaks the migration between > 6.2 and 6.1 with the following message: > > qemu-system-aar

Re: [PULL 0/1] target-arm queue

2021-11-22 Thread Peter Maydell
> into staging (2021-11-22 10:33:13 +0100) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20211122 > > for you to fetch changes up to 4825eaae4fdd56fba0febdfbdd7bf9684ae3ee0d: > > Revert

Re: [PULL 0/1] target-arm queue

2021-11-22 Thread Richard Henderson
ivier/qemu into staging (2021-11-22 10:33:13 +0100) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20211122 for you to fetch changes up to 4825eaae4fdd56fba0febdfbdd7bf9684ae3ee0d: Revert "arm: tcg: Adhere to SMCCC

[PULL 0/1] target-arm queue

2021-11-22 Thread Peter Maydell
Apologies for sending two pullreqs today; Eric's patch came in a few hours after I sent the first one but it's definitely a release-critical fix. -- PMM The following changes since commit 89d2f9e4c63799f7f03e9180c63b7dc45fc2a04a: Merge tag 'pull-target-arm-20211122' of ht

[PULL 1/1] hw/intc/arm_gicv3_its: Revert version increments in vmstate_its

2021-11-22 Thread Peter Maydell
From: Eric Auger Commit 18f6290a6a ("hw/intc: GICv3 ITS initial framework") incremented version_id and minimum_version_id fields of VMStateDescription vmstate_its. This breaks the migration between 6.2 and 6.1 with the following message: qemu-system-aarch64: savevm: unsupported version 1 for 'ar

[PATCH] MAINTAINERS: Remove me as a reviewer for the build and test/avocado

2021-11-22 Thread Willian Rampazzo
Remove me as a reviewer for the Build and test automation and the Integration Testing with the Avocado Framework and add Beraldo Leal. Signed-off-by: Willian Rampazzo --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index d3879aa3c

Re: [PATCH] MAINTAINERS: Remove me as a reviewer for the build and test/avocado

2021-11-22 Thread Beraldo Leal
On Mon, Nov 22, 2021 at 04:11:24PM -0300, Willian Rampazzo wrote: > Remove me as a reviewer for the Build and test automation and the > Integration Testing with the Avocado Framework and add Beraldo > Leal. > > Signed-off-by: Willian Rampazzo > --- > MAINTAINERS | 4 ++-- > 1 file changed, 2 ins

Re: [NOTFORMERGE PATCH 5/5] tests/avocado: Test NetBSD 9.2 on the Jazz Magnum machine

2021-11-22 Thread Willian Rampazzo
On Fri, Nov 19, 2021 at 2:29 PM Philippe Mathieu-Daudé wrote: > > Test NetBSD 9.2 on the Jazz Magnum machine. As the firmware is not > redistributable, it has to be extracted from the floppy configuration > disk coming with a Mips Magnum 4000 system, then the NTPROM_BIN_PATH > environment variable

Re: [PATCH for-6.2] hw/intc/arm_gicv3_its: Revert version increments in vmstate_its

2021-11-22 Thread Eric Auger
Hi Peter, On 11/22/21 7:04 PM, Peter Maydell wrote: > On Mon, 22 Nov 2021 at 17:10, Eric Auger wrote: >> Commit 18f6290a6a ("hw/intc: GICv3 ITS initial framework") >> incremented version_id and minimum_version_id fields of >> VMStateDescription vmstate_its. This breaks the migration between >> 6.

Re: [PATCH] MAINTAINERS: Remove me as a reviewer for the build and test/avocado

2021-11-22 Thread Alex Bennée
Willian Rampazzo writes: > Remove me as a reviewer for the Build and test automation and the > Integration Testing with the Avocado Framework and add Beraldo > Leal. Queued to for-6.2/tcg-gdb-plugin-fixes, thanks. -- Alex Bennée

Re: [PATCH v4 20/32] nbd/client-connection: implement connection retry

2021-11-22 Thread Eric Blake
On Mon, Nov 22, 2021 at 08:17:34PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 22.11.2021 19:30, Eric Blake wrote: > > Reviving this thread, as a good as place as any for my question: > > > > But I can't > > find anywhere in the code base that ensures that on a reconnect, the > > new server su

Re: [PULL 0/2] NBD patches for 6.2-rc2, 2021-11-22

2021-11-22 Thread Richard Henderson
On 11/22/21 3:02 PM, Eric Blake wrote: The following changes since commit 49aaac3548bc5a4632a14de939d5312b28dc1ba2: Merge tag 'linux-user-for-6.2-pull-request' of git://github.com/vivier/qemu into staging (2021-11-22 10:33:13 +0100) are available in the Git repository at: https://repo.o

[RFC PATCH] s390: kvm: reduce frequency of CPU syncs of diag318 info

2021-11-22 Thread Collin Walling
DIAGNOSE 0318 is invoked only once during IPL. As such, the diag318 info will only change once initially and during resets. Let's only sync the register to convey the info to KVM if and only if the diag318 info has changed. Only set the dirty bit flag for diag318 whenever it must be updated. The m

Re: [PATCH v1 0/9] hw/mos6522: VIA timer emulation fixes and improvements

2021-11-22 Thread Finn Thain
On Mon, 22 Nov 2021, Peter Maydell wrote: > On Sat, 20 Nov 2021 at 23:40, Finn Thain wrote: > > Anyway, thanks for taking the time to write. A competent reviewer has to > > do much more than that, but I'm not paying for competence so I suppose I'm > > asking too much. > > Please dial back the ag

Re: [RFC PATCH] s390: kvm: reduce frequency of CPU syncs of diag318 info

2021-11-22 Thread Collin Walling
On 11/22/21 17:33, Collin Walling wrote: > DIAGNOSE 0318 is invoked only once during IPL. As such, the > diag318 info will only change once initially and during resets. > Let's only sync the register to convey the info to KVM if and > only if the diag318 info has changed. Only set the dirty bit > f

Re: [PATCH v5 1/6] QIOChannel: Add io_writev_zerocopy & io_flush_zerocopy callbacks

2021-11-22 Thread Leonardo Bras Soares Passos
Hello Daniel, Thanks for the feedback! On Fri, Nov 12, 2021 at 7:13 AM Daniel P. Berrangé wrote: > > On Fri, Nov 12, 2021 at 02:10:36AM -0300, Leonardo Bras wrote: > > -int qio_channel_writev_all(QIOChannel *ioc, > > - const struct iovec *iov, > > -

Re: [PATCH v1] virtio-mem: Don't skip alignment checks when warning about block size

2021-11-22 Thread Michael S. Tsirkin
On Mon, Nov 22, 2021 at 01:01:51PM +0100, David Hildenbrand wrote: > On 12.10.21 09:27, Michael S. Tsirkin wrote: > > On Mon, Oct 11, 2021 at 07:33:05PM +0200, David Hildenbrand wrote: > >> If we warn about the block size being smaller than the default, we skip > >> some alignment checks. > >> > >>

Re: [PULL 0/6] Documentation updates

2021-11-22 Thread Richard Henderson
On 11/22/21 3:43 PM, Thomas Huth wrote: Hi Richard! The following changes since commit c5fbdd60cf1fb52f01bdfe342b6fa65d5343e1b1: Merge tag 'qemu-sparc-20211121' of git://github.com/mcayland/qemu into staging (2021-11-21 14:12:25 +0100) are available in the Git repository at: https://

Re: [RFC v2 PATCH 13/13] KVM: Enable memfd based page invalidation/fallocate

2021-11-22 Thread Chao Peng
On Mon, Nov 22, 2021 at 05:16:47PM +0300, Kirill A. Shutemov wrote: > On Fri, Nov 19, 2021 at 09:47:39PM +0800, Chao Peng wrote: > > Since the memory backing store does not get notified when VM is > > destroyed so need check if VM is still live in these callbacks. > > > > Signed-off-by: Yu Zhang

[PULL 0/7] Python patches

2021-11-22 Thread John Snow
The following changes since commit 89d2f9e4c63799f7f03e9180c63b7dc45fc2a04a: Merge tag 'pull-target-arm-20211122' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2021-11-22 16:35:54 +0100) are available in the Git repository at: https://gitlab.com/jsnow/qem

[PULL 2/7] python/machine: remove _remove_monitor_sockfile property

2021-11-22 Thread John Snow
It doesn't matter if it was the user or the class itself that specified where the sockfile should be created; the fact is that if we are using a sockfile here, we created it and we can clean it up. Signed-off-by: John Snow Reviewed-by: Willian Rampazzo Message-id: 2028204620.1897674-3-js...@

[PULL 1/7] python/machine: add @sock_dir property

2021-11-22 Thread John Snow
Analogous to temp_dir and log_dir, add a sock_dir property that defaults to @temp_dir -- instead of base_temp_dir -- when the user hasn't overridden the sock dir value in the initializer. This gives us a much more unique directory to put sockfiles in by default. Signed-off-by: John Snow Reviewed

[PULL 3/7] python/machine: add instance disambiguator to default nickname

2021-11-22 Thread John Snow
If you create two instances of QEMUMachine(), they'll both create the same nickname by default -- which is not that helpful. Luckily, they'll both create unique temporary directories ... but due to user configuration, they may share logging and sockfile directories, meaning two instances can colli

[PULL 4/7] python/machine: move more variable initializations to _pre_launch

2021-11-22 Thread John Snow
No need to clear them only to set them later. Signed-off-by: John Snow Reviewed-by: Willian Rampazzo Message-id: 2028204620.1897674-5-js...@redhat.com Signed-off-by: John Snow --- python/qemu/machine/machine.py | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --

[PULL 6/7] scripts/device-crash-test: Use a QMP timeout

2021-11-22 Thread John Snow
Despite all the previous fixes, it's still possible for device-crash-test to wedge itself in the case that QEMU terminates *so quickly* that it doesn't even begin a connection attempt to our QMP client. Python will just joyfully wait ad infinitum for a connection that will now never arrive. The re

[PULL 5/7] python/machine: handle "fast" QEMU terminations

2021-11-22 Thread John Snow
In the case that the QEMU process actually launches -- but then dies so quickly that we can't establish a QMP connection to it -- QEMUMachine currently calls _post_shutdown() assuming that it never launched the VM process. This isn't true, though: it "merely" may have failed to establish a QMP con

[PULL 7/7] python/aqmp: fix send_fd_scm for python 3.6.x

2021-11-22 Thread John Snow
3.6 doesn't play keepaway with the socket object, so we don't need to go fishing for it on this version. In fact, so long as 'sendmsg' is still available, it's probably preferable to just use that method and only go fishing for forbidden details when we absolutely have to. Reported-by: Thomas Huth

Re: [PATCH v5 3/6] QIOChannelSocket: Implement io_writev_zerocopy & io_flush_zerocopy for CONFIG_LINUX

2021-11-22 Thread Leonardo Bras Soares Passos
Hello Daniel, On Fri, Nov 12, 2021 at 7:54 AM Daniel P. Berrangé wrote: [...] > > @@ -561,12 +577,15 @@ static ssize_t > > qio_channel_socket_writev_flags(QIOChannel *ioc, > > retry: > > ret = sendmsg(sioc->fd, &msg, flags); > > if (ret <= 0) { > > -if (errno == EAGAIN) { > >

Re: [PATCH v5 2/6] QIOChannelSocket: Add flags parameter for writing

2021-11-22 Thread Leonardo Bras Soares Passos
Hello Daniel, Thanks for reviewing! Best regards, Leo On Fri, Nov 12, 2021 at 7:15 AM Daniel P. Berrangé wrote: > > On Fri, Nov 12, 2021 at 02:10:37AM -0300, Leonardo Bras wrote: > > Change qio_channel_socket_writev() in order to accept flags, so its possible > > to selectively make use of sendm

Re: [qemu-web PATCH v2] Add Sponsors page

2021-11-22 Thread Alistair Francis
On Fri, Nov 19, 2021 at 12:12 AM Philippe Mathieu-Daudé wrote: > > Cc'ing Alistair regarding the RISC-V foundation help: > https://www.cnx-software.com/2021/05/03/the-risc-v-foundation-to-give-away-1000-risc-v-development-boards/ Thanks! We have access to RISC-V boards for QEMU tests from the PL

Re: [PATCH v5 03/18] qemu/int128: addition of div/rem 128-bit operations

2021-11-22 Thread Alistair Francis
On Sat, Nov 13, 2021 at 1:06 AM Frédéric Pétrot wrote: > > Addition of div and rem on 128-bit integers, using the 128/64->128 divu and > 64x64->128 mulu in host-utils. > These operations will be used within div/rem helpers in the 128-bit riscv > target. > > Signed-off-by: Frédéric Pétrot > Co-aut

Re: [PATCH v5 05/18] target/riscv: separation of bitwise logic and arithmetic helpers

2021-11-22 Thread Alistair Francis
On Sat, Nov 13, 2021 at 1:11 AM Frédéric Pétrot wrote: > > Introduction of a gen_logic function for bitwise logic to implement > instructions in which not propagation of information occurs between bits and > use of this function on the bitwise instructions. > > Signed-off-by: Frédéric Pétrot > Co

Re: [PATCH v5 06/18] target/riscv: array for the 64 upper bits of 128-bit registers

2021-11-22 Thread Alistair Francis
On Sat, Nov 13, 2021 at 1:07 AM Frédéric Pétrot wrote: > > The upper 64-bit of the 128-bit registers have now a place inside > the cpu state structure, and are created as globals for future use. > > Signed-off-by: Frédéric Pétrot > Co-authored-by: Fabien Portas > --- > target/riscv/cpu.h

Re: [PATCH v1 01/12] update-linux-headers: Add asm-riscv/kvm.h

2021-11-22 Thread Alistair Francis
On Sat, Nov 20, 2021 at 5:51 PM Yifei Jiang wrote: > > Add asm-riscv/kvm.h for RISC-V KVM, and update linux/kvm.h > > Signed-off-by: Yifei Jiang > Signed-off-by: Mingwang Li Acked-by: Alistair Francis Alistair > --- > linux-headers/asm-riscv/kvm.h | 128 ++ >

Re: [PATCH v5 08/18] target/riscv: moving some insns close to similar insns

2021-11-22 Thread Alistair Francis
On Sat, Nov 13, 2021 at 1:17 AM Frédéric Pétrot wrote: > > lwu and ld are functionally close to the other loads, but were after the > stores in the source file. > Similarly, xor was away from or and and by two arithmetic functions, while > the immediate versions were nicely put together. > This pa

Re: [RFC PATCH] s390: kvm: reduce frequency of CPU syncs of diag318 info

2021-11-22 Thread Christian Borntraeger
Am 22.11.21 um 23:33 schrieb Collin Walling: DIAGNOSE 0318 is invoked only once during IPL. As such, the diag318 info will only change once initially and during resets. Let's only sync the register to convey the info to KVM if and only if the diag318 info has changed. Only set the dirty bit fla

Re: [PATCH v5 04/18] target/riscv: additional macros to check instruction support

2021-11-22 Thread Alistair Francis
On Sat, Nov 13, 2021 at 1:08 AM Frédéric Pétrot wrote: > > Given that the 128-bit version of the riscv spec adds new instructions, and > that some instructions that were previously only available in 64-bit mode > are now available for both 64-bit and 128-bit, we added new macros to check > for the

Re: [PATCH v2 1/5] target/riscv: Check PMP rules num before propagation

2021-11-22 Thread Alistair Francis
On Mon, Nov 22, 2021 at 9:15 PM LIU Zhiwei wrote: > > When an address is in [0-4K) and no pmp rule configured, the tlb_size will > be set to 1. > > This is caused by pmp_get_tlb_size return a value 1. > > if (pmp_sa >= tlb_sa && pmp_ea <= tlb_ea) { > return pmp_ea - pmp_sa + 1; > } > > Here pm

<    1   2   3   >