Re: [PATCH v2 13/13] blockdev: Drop unused drive_get_next()

2021-11-18 Thread Hanna Reitz
On 17.11.21 17:34, Markus Armbruster wrote: drive_get_next() is basically a bad idea. It returns the "next" block backend of a certain interface type. "Next" means bus=0,unit=N, where subsequent calls count N up from zero, per interface type. This lets you define unit numbers implicitly by exe

Re: [PATCH] block/vvfat.c fix leak when failure occurs

2021-11-18 Thread Hanna Reitz
On 16.11.21 13:57, Daniella Lee wrote: Function vvfat_open called function enable_write_target and init_directories, and these functions malloc new memory for BDRVVVFATState::qcow_filename, BDRVVVFATState::used_clusters, and BDRVVVFATState::cluster_buff. When the specified folder does not exist

Re: [PATCH] docs: Introducing pseries documentation.

2021-11-18 Thread Cédric Le Goater
+ * Multi processor support for many Power processors generations: POWER5+, + POWER7, POWER7+, POWER8, POWER8NVL, Power9, and Power10 (there is no support + for POWER6 processors). I wouldn't trust the POWER5+ cpu emulation with pseries; only POWER7 and later has been tested at all. Actu

Re: [PATCH] docs: Introducing pseries documentation.

2021-11-18 Thread Cédric Le Goater
Hello Leonardo, On 11/17/21 21:14, lagar...@linux.ibm.com wrote: From: Leonardo Garcia The purpose of this document is to substitute the content currently available in the QEMU wiki at [0]. This initial version does contain some additional content as well. Whenever this documentation gets upst

Re: [PATCH] docs: Minor updates on the powernv documentation.

2021-11-18 Thread Cédric Le Goater
On 11/17/21 21:16, lagar...@linux.ibm.com wrote: From: Leonardo Garcia Signed-off-by: Leonardo Garcia --- docs/system/ppc/powernv.rst | 56 +++-- 1 file changed, 29 insertions(+), 27 deletions(-) diff --git a/docs/system/ppc/powernv.rst b/docs/system/ppc/pow

Re: [PATCH v3] failover: fix unplug pending detection

2021-11-18 Thread Laurent Vivier
On 18/10/2021 10:27, Michael S. Tsirkin wrote: On Mon, Oct 18, 2021 at 09:19:16AM +0200, Laurent Vivier wrote: Hi, I don't understand if there are some issues Gerd did identify some issues, you felt they aren't related to the patch and need to be addressed separately. Gerd posted patches tha

Re: [PATCH v1 1/3] migration/dirtyrate: implement vCPU dirtyrate calculation periodically

2021-11-18 Thread Juan Quintela
huang...@chinatelecom.cn wrote: > From: Hyman Huang(黄勇) > > introduce the third method GLOBAL_DIRTY_RESTRAINT of dirty > tracking for calculate dirtyrate periodly for dirty restraint. > > implement thread for calculate dirtyrate periodly, which will > be used for dirty restraint. > > add dirtyrest

Re: [PATCH v4 08/25] block: introduce assert_bdrv_graph_writable

2021-11-18 Thread Emanuele Giuseppe Esposito
On 12/11/2021 15:40, Hanna Reitz wrote: On 25.10.21 12:17, Emanuele Giuseppe Esposito wrote: We want to be sure that the functions that write the child and parent list of a bs are under BQL and drain. BQL prevents from concurrent writings from the GS API, while drains protect from I/O. TODO:

[PATCH for-6.2 0/2] esp: add fix for reset before transfer

2021-11-18 Thread Mark Cave-Ayland
This is the fix for Gitlab issue #724 discovered by fuzzing which I think is worth including in 6.2 for 2 reasons: firstly the fix is to zero out an extra field during chip reset which normally only occurs during driver initialisation and durring IO timeouts, and secondly the bug causes a stale SCS

[PATCH for-6.2 2/2] qtest/am53c974-test: add test for reset before transfer

2021-11-18 Thread Mark Cave-Ayland
Based upon the qtest reproducer posted to Gitlab issue #724 at https://gitlab.com/qemu-project/qemu/-/issues/724. Signed-off-by: Mark Cave-Ayland --- tests/qtest/am53c974-test.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/tests/qtest/am53c974-test.c b/test

[PATCH for-6.2 1/2] esp: ensure that async_len is reset to 0 during esp_hard_reset()

2021-11-18 Thread Mark Cave-Ayland
If a reset command is sent after data has been transferred into the SCSI buffer ensure that async_len is reset to 0. Otherwise a subsequent TI command assumes the SCSI buffer contains data to be transferred to the device causing it to dereference the stale async_buf pointer. Signed-off-by: Mark Ca

Re: [PATCH v3] failover: fix unplug pending detection

2021-11-18 Thread Ani Sinha
On Thu, Nov 18, 2021 at 2:45 PM Laurent Vivier wrote: > > On 18/10/2021 10:27, Michael S. Tsirkin wrote: > > On Mon, Oct 18, 2021 at 09:19:16AM +0200, Laurent Vivier wrote: > >> Hi, > >> > >> I don't understand if there are some issues > > > > Gerd did identify some issues, you felt they aren't re

Re: [PULL 0/1] VFIO fixes 2021-11-17 (for v6.2)

2021-11-18 Thread Richard Henderson
On 11/17/21 8:17 PM, Alex Williamson wrote: The following changes since commit 3bb87484e77d22cf4e580a78856529c982195d32: Merge tag 'pull-request-2021-11-17' of https://gitlab.com/thuth/qemu into staging (2021-11-17 12:35:51 +0100) are available in the Git repository at: git://github.com

Re: [PATCH for-6.2 2/2] qtest/am53c974-test: add test for reset before transfer

2021-11-18 Thread Thomas Huth
On 18/11/2021 11.03, Mark Cave-Ayland wrote: Based upon the qtest reproducer posted to Gitlab issue #724 at https://gitlab.com/qemu-project/qemu/-/issues/724. Signed-off-by: Mark Cave-Ayland --- tests/qtest/am53c974-test.c | 30 ++ 1 file changed, 30 insertions(+)

Re: [PATCH v4 08/25] block: introduce assert_bdrv_graph_writable

2021-11-18 Thread Emanuele Giuseppe Esposito
On 18/11/2021 10:55, Emanuele Giuseppe Esposito wrote: On 12/11/2021 15:40, Hanna Reitz wrote: On 25.10.21 12:17, Emanuele Giuseppe Esposito wrote: We want to be sure that the functions that write the child and parent list of a bs are under BQL and drain. BQL prevents from concurrent writi

Re: [PATCH v2] hw/arm/virt: Expose empty NUMA nodes through ACPI

2021-11-18 Thread Jonathan Cameron
On Wed, 17 Nov 2021 19:08:28 +0100 David Hildenbrand wrote: > On 17.11.21 15:30, Jonathan Cameron wrote: > > On Tue, 16 Nov 2021 12:11:29 +0100 > > David Hildenbrand wrote: > > > > Examples include exposing HBM or PMEM to the VM. Just like on real HW, > this memory is exposed v

Re: [PATCH v2 for-6.2] meson.build: Support ncurses on MacOS and OpenBSD

2021-11-18 Thread Daniel P . Berrangé
On Wed, Nov 17, 2021 at 09:53:55PM +0100, Stefan Weil wrote: > MacOS provides header files for curses 5.7 with support > for wide characters, but requires _XOPEN_SOURCE_EXTENDED=1 > to activate that. > > By default those old header files are used even if there > is a newer Homebrew installation of

Re: [qemu-web PATCH] remove deployment phase from CI

2021-11-18 Thread Daniel P . Berrangé
On Thu, Nov 18, 2021 at 08:47:01AM +0100, Paolo Bonzini wrote: > qemu.org is now served via a reverse proxy from qemu-project.gitlab.io; it > does > not need anymore the rsync step to the QEMU project's shell server. > Remove it from the CI. > > Signed-off-by: Paolo Bonzini > --- > .gitlab-ci.y

Re: [PATCH-for-6.2 v2 1/2] hw/block/fdc: Kludge missing floppy drive to fix CVE-2021-20196

2021-11-18 Thread Darren Kenny
Hi Philippe, A small nit below, but otherwise looks good. On Thursday, 2021-11-18 at 00:24:21 +01, Philippe Mathieu-Daudé wrote: > Guest might select another drive on the bus by setting the > DRIVE_SEL bit of the DIGITAL OUTPUT REGISTER (DOR). > The current controller model doesn't expect a Block

Re: [PATCH-for-6.2] hw/i386/microvm: Reduce annoying debug message in dt_setup_microvm()

2021-11-18 Thread Darren Kenny
On Wednesday, 2021-11-17 at 18:43:31 +01, Philippe Mathieu-Daudé wrote: > Fixes: f5918a99283 ("microvm: add device tree support.") > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Darren Kenny > --- > hw/i386/microvm-dt.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff

Re: [qemu-web PATCH] update links to the SubmitAPatch wiki page

2021-11-18 Thread Daniel P . Berrangé
On Thu, Nov 18, 2021 at 08:47:02AM +0100, Paolo Bonzini wrote: > The page is now part of the documentation, but it also has a redirect > in the qemu.org web server to provide a stable URL. Use it instead > of linking out to wiki.qemu.org. > > Signed-off-by: Paolo Bonzini > --- > CONTRIBUTING.md

Re: [PATCH-for-6.2 v2 0/2] hw/block/fdc: Fix CVE-2021-20196

2021-11-18 Thread Darren Kenny
Hi Philippe, Apart from a nit on patch 1, all looks good, so: Reviewed-by: Darren Kenny Thanks, Darren. On Thursday, 2021-11-18 at 00:24:20 +01, Philippe Mathieu-Daudé wrote: > I'm not sure what happened to v1 from Prasad, so since we are > at rc2 I took a simpler approach to fix this CVE: cr

Re: [PATCH-for-6.2] hw/i386/microvm: Reduce annoying debug message in dt_setup_microvm()

2021-11-18 Thread Sergio Lopez
On Wed, Nov 17, 2021 at 06:43:31PM +0100, Philippe Mathieu-Daudé wrote: > Fixes: f5918a99283 ("microvm: add device tree support.") > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/i386/microvm-dt.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Sergio Lopez > diff --

Re: [PATCH-for-6.2? 1/3] docs/devel/style: Improve GLib functions rST rendering

2021-11-18 Thread Darren Kenny
Hi Philippe, There are some inconsistencies in the use of '()' when referring to functions or macros below... On Tuesday, 2021-11-16 at 16:13:15 +01, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > docs/devel/style.rst | 31 --- > 1 file

Re: [PATCH-for-6.2? 3/3] docs/devel/style: Improve types/qualifiers rST rendering

2021-11-18 Thread Darren Kenny
Hi Philippe, A couple here too w.r.t. function/macros... On Tuesday, 2021-11-16 at 16:13:17 +01, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > docs/devel/style.rst | 111 ++- > 1 file changed, 56 insertions(+), 55 deletions

Re: [PATCH v2] hw/arm/virt: Expose empty NUMA nodes through ACPI

2021-11-18 Thread David Hildenbrand
On 18.11.21 11:28, Jonathan Cameron wrote: > On Wed, 17 Nov 2021 19:08:28 +0100 > David Hildenbrand wrote: > >> On 17.11.21 15:30, Jonathan Cameron wrote: >>> On Tue, 16 Nov 2021 12:11:29 +0100 >>> David Hildenbrand wrote: >>> >> >> Examples include exposing HBM or PMEM to the VM. Jus

Re: [PATCH v2 1/3] icount: preserve cflags when custom tb is about to execute

2021-11-18 Thread Pavel Dovgalyuk
On 17.11.2021 12:47, Alex Bennée wrote: Pavel Dovgalyuk writes: When debugging with the watchpoints, qemu may need to create TB with single instruction. This is achieved by setting cpu->cflags_next_tb. But when this block is about to execute, it may be interrupted by another thread. In this c

Re: [PATCH v1 0/9] hw/mos6522: VIA timer emulation fixes and improvements

2021-11-18 Thread Mark Cave-Ayland
On 17/11/2021 03:03, Finn Thain wrote: On Fri, 24 Sep 2021, I wrote: This is a patch series for QEMU that I started last year. The aim was to try to get a monotonic clocksource for Linux/m68k guests. That hasn't been achieved yet (for q800 machines). I'm submitting the patch series because,

Re: [PATCH v2] hw/arm/virt: Expose empty NUMA nodes through ACPI

2021-11-18 Thread Jonathan Cameron
On Thu, 18 Nov 2021 12:06:27 +0100 David Hildenbrand wrote: > On 18.11.21 11:28, Jonathan Cameron wrote: > > On Wed, 17 Nov 2021 19:08:28 +0100 > > David Hildenbrand wrote: > > > >> On 17.11.21 15:30, Jonathan Cameron wrote: > >>> On Tue, 16 Nov 2021 12:11:29 +0100 > >>> David Hildenbrand

Re: [PATCH for-6.2 1/2] esp: ensure that async_len is reset to 0 during esp_hard_reset()

2021-11-18 Thread Philippe Mathieu-Daudé
On 11/18/21 11:03, Mark Cave-Ayland wrote: > If a reset command is sent after data has been transferred into the SCSI > buffer > ensure that async_len is reset to 0. Otherwise a subsequent TI command assumes > the SCSI buffer contains data to be transferred to the device causing it to > dereferenc

Re: [PATCH-for-6.2 v2 1/2] hw/block/fdc: Kludge missing floppy drive to fix CVE-2021-20196

2021-11-18 Thread Philippe Mathieu-Daudé
On 11/18/21 11:44, Darren Kenny wrote: > Hi Philippe, > > A small nit below, but otherwise looks good. > > On Thursday, 2021-11-18 at 00:24:21 +01, Philippe Mathieu-Daudé wrote: >> Guest might select another drive on the bus by setting the >> DRIVE_SEL bit of the DIGITAL OUTPUT REGISTER (DOR). >>

[PATCH-for-6.2 0/2] hw/block/fdc: Fix CVE-2021-3507

2021-11-18 Thread Philippe Mathieu-Daudé
Trivial fix for CVE-2021-3507. Philippe Mathieu-Daudé (2): hw/block/fdc: Prevent end-of-track overrun (CVE-2021-3507) tests/qtest/fdc-test: Add a regression test for CVE-2021-3507 hw/block/fdc.c | 8 tests/qtest/fdc-test.c | 20 2 files changed, 28 inse

[PATCH-for-6.2 1/2] hw/block/fdc: Prevent end-of-track overrun (CVE-2021-3507)

2021-11-18 Thread Philippe Mathieu-Daudé
Per the 82078 datasheet, if the end-of-track (EOT byte in the FIFO) is more than the number of sectors per side, the command is terminated unsuccessfully: * 5.2.5 DATA TRANSFER TERMINATION The 82078 supports terminal count explicitly through the TC pin and implicitly through the underrun/over

[PATCH-for-6.2 2/2] tests/qtest/fdc-test: Add a regression test for CVE-2021-3507

2021-11-18 Thread Philippe Mathieu-Daudé
Add the reproducer from https://gitlab.com/qemu-project/qemu/-/issues/339 Without the previous commit, when running 'make check-qtest-i386' with QEMU configured with '--enable-sanitizers' we get: ==4028352==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x61962a00 at pc 0x5626d03

Re: [PATCH v2 1/2] qemu-options: define -spice only #ifdef CONFIG_SPICE

2021-11-18 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Fixes: > https://bugzilla.redhat.com/show_bug.cgi?id=1982600 > > Signed-off-by: Marc-André Lureau > --- > softmmu/vl.c| 2 ++ > qemu-options.hx | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/softmmu/vl.c b/softmm

[PATCH-for-6.2 v3 0/2] hw/block/fdc: Fix CVE-2021-20196

2021-11-18 Thread Philippe Mathieu-Daudé
I'm not sure what happened to v1 from Prasad, so since we are at rc2 I took a simpler approach to fix this CVE: create an empty drive to satisfy the BlockBackend API calls. Added Alexander's reproducer along. Since v2: - Reword comment (Darren) - Add Darren R-b tag v2: https://lore.kernel.org/q

[PATCH-for-6.2 v3 1/2] hw/block/fdc: Kludge missing floppy drive to fix CVE-2021-20196

2021-11-18 Thread Philippe Mathieu-Daudé
Guest might select another drive on the bus by setting the DRIVE_SEL bit of the DIGITAL OUTPUT REGISTER (DOR). The current controller model doesn't expect a BlockBackend to be NULL. A simple way to fix CVE-2021-20196 is to create an empty BlockBackend when it is missing. All further accesses will b

[PATCH-for-6.2 v3 2/2] tests/qtest/fdc-test: Add a regression test for CVE-2021-20196

2021-11-18 Thread Philippe Mathieu-Daudé
From: Alexander Bulekov Without the previous commit, when running 'make check-qtest-i386' with QEMU configured with '--enable-sanitizers' we get: AddressSanitizer:DEADLYSIGNAL = ==287878==ERROR: AddressSanitizer: SEGV on unkno

Re: [PATCH-for-6.2? 1/3] docs/devel/style: Improve GLib functions rST rendering

2021-11-18 Thread Philippe Mathieu-Daudé
On 11/18/21 11:58, Darren Kenny wrote: > Hi Philippe, > > There are some inconsistencies in the use of '()' when referring to > functions or macros below... Daniel, if you agree with Darren comments I can respin addressing them. > On Tuesday, 2021-11-16 at 16:13:15 +01, Philippe Mathieu-Daudé wr

Re: [PATCH v3 0/6] SEV: add kernel-hashes=on for measured -kernel launch

2021-11-18 Thread Dov Murik
Pinging again -- Daniel said this should be added to 6.2. Is there anything I should do? Thanks, -Dov On 14/11/2021 20:02, Dov Murik wrote: > Paolo, > > Can you please add this series (already reviewed) to the fixes in 6.2? > > Thanks, > -Dov > > > On 11/11/2021 12:00, Dov Murik wrote: >> To

[qemu-web PATCH v2] Add Sponsors page

2021-11-18 Thread Philippe Mathieu-Daudé
Add a page listing QEMU sponsors. For now, only mention Fosshost which requested to be listed: https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg05381.html Cc: Thomas Markey Resolves: https://gitlab.com/qemu-project/qemu-web/-/issues/2 Signed-off-by: Philippe Mathieu-Daudé --- Since v1:

Re: [PATCH-for-6.2] net: vmxnet3: validate configuration values during activate (CVE-2021-20203)

2021-11-18 Thread Philippe Mathieu-Daudé
ping? On 10/18/21 11:09, P J P wrote: > On Monday, 18 October, 2021, 12:20:55 pm IST, Thomas Huth > wrote: > On 30/01/2021 14.16, P J P wrote: >>> diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c >>> index eff299f629..4a910ca971 100644 >>> --- a/hw/net/vmxnet3.c >>> +++ b/hw/net/vmxnet3.c >>> @@

Re: [PATCH v4 19/25] block_int-common.h: split function pointers in BlockDriver

2021-11-18 Thread Emanuele Giuseppe Esposito
On 15/11/2021 13:00, Hanna Reitz wrote: + +    /* + * I/O API functions. These functions are thread-safe. + * + * See include/block/block-io.h for more information about + * the I/O API. + */ + +    int coroutine_fn (*bdrv_co_create)(BlockdevCreateOptions *opts, +  

Re: [qemu-web PATCH v2] Add Sponsors page

2021-11-18 Thread Thomas Huth
On 18/11/2021 13.29, Philippe Mathieu-Daudé wrote: Add a page listing QEMU sponsors. For now, only mention Fosshost which requested to be listed: https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg05381.html ... +QEMU has sponsors! + +For continuous integration and testing, hardware is p

Re: [PATCH-for-6.2? 1/3] docs/devel/style: Improve GLib functions rST rendering

2021-11-18 Thread Daniel P . Berrangé
On Thu, Nov 18, 2021 at 01:12:26PM +0100, Philippe Mathieu-Daudé wrote: > On 11/18/21 11:58, Darren Kenny wrote: > > Hi Philippe, > > > > There are some inconsistencies in the use of '()' when referring to > > functions or macros below... > > Daniel, if you agree with Darren comments I can respin

Re: [PATCH v3 0/6] SEV: add kernel-hashes=on for measured -kernel launch

2021-11-18 Thread Daniel P . Berrangé
On Thu, Nov 18, 2021 at 02:21:09PM +0200, Dov Murik wrote: > Pinging again -- Daniel said this should be added to 6.2. > > Is there anything I should do? I'm going to take care of sending a PULL to relieve Paolo's workload. Regards, Daniel -- |: https://berrange.com -o-https://www.fli

Re: does drive_get_next(IF_NONE) make sense?

2021-11-18 Thread Alistair Francis
On Tue, Nov 16, 2021 at 2:10 AM Thomas Huth wrote: > > On 15/11/2021 08.12, Alistair Francis wrote: > > On Mon, Nov 15, 2021 at 3:32 PM Markus Armbruster wrote: > >> > >> Peter Maydell writes: > >> > >>> On Fri, 12 Nov 2021 at 13:34, Markus Armbruster wrote: > > Thomas Huth writes: >

Re: [PATCH v3 0/6] SEV: add kernel-hashes=on for measured -kernel launch

2021-11-18 Thread Dov Murik
On 18/11/2021 15:02, Daniel P. Berrangé wrote: > On Thu, Nov 18, 2021 at 02:21:09PM +0200, Dov Murik wrote: >> Pinging again -- Daniel said this should be added to 6.2. >> >> Is there anything I should do? > > I'm going to take care of sending a PULL to relieve Paolo's > workload. > Thanks Da

Re: does drive_get_next(IF_NONE) make sense?

2021-11-18 Thread Peter Maydell
On Thu, 18 Nov 2021 at 13:04, Alistair Francis wrote: > > On Tue, Nov 16, 2021 at 2:10 AM Thomas Huth wrote: > > What kind of device is that OTP exactly? If it is some kind of non-serial > > flash device, maybe you could simply use IF_PFLASH instead? > > It just says "one time programmable memory

[PATCH v2 0/3] Fix mtfsf, mtfsfi and mtfsb1 bug

2021-11-18 Thread Lucas Mateus Castro (alqotel)
The instructions mtfsf, mtfsfi and mtfsb1, when called, fail to set the FI bit (bit 46 in the FPSCR) and can set to 1 the reserved bit 52 of the FPSCR, as reported in https://gitlab.com/qemu-project/qemu/-/issues/266 (although the bug report is only for mtfsf, the bug applies to mtfsfi and mtfsb1 a

[PATCH v2 1/3] target/ppc: Fixed call to deferred exception

2021-11-18 Thread Lucas Mateus Castro (alqotel)
mtfsf, mtfsfi and mtfsb1 instructions call helper_float_check_status after updating the value of FPSCR, but helper_float_check_status checks fp_status and fp_status isn't updated based on FPSCR and since the value of fp_status is reset earlier in the instruction, it's always 0. Because of this hel

[PATCH v2 2/3] target/ppc: ppc_store_fpscr doesn't update bit 52

2021-11-18 Thread Lucas Mateus Castro (alqotel)
This commit fixes the difference reported in the bug in the reserved bit 52, it does this by adding this bit to the mask of bits to not be directly altered in the ppc_store_fpscr function (the hardware used to compare to QEMU was a Power9). Although this is a difference reported in the bug, since

[PATCH v2 3/3] test/tcg/ppc64le: test mtfsf

2021-11-18 Thread Lucas Mateus Castro (alqotel)
Added tests for the mtfsf to check if FI bit of FPSCR is being set and if exception calls are being made correctly. Signed-off-by: Lucas Mateus Castro (alqotel) --- tests/tcg/ppc64/Makefile.target | 1 + tests/tcg/ppc64le/Makefile.target | 1 + tests/tcg/ppc64le/mtfsf.c | 56

[PULL 0/6 for-6.2] AMD SEV patches

2021-11-18 Thread Daniel P . Berrangé
The following changes since commit 0055ecca84cb948c935224b4f7ca1ceb26209790: Merge tag 'vfio-fixes-2027.0' of git://github.com/awilliam/qemu-vfio into staging (2021-11-18 09:39:47 +0100) are available in the Git repository at: https://gitlab.com/berrange/qemu tags/sev-hashes-pull-reques

[PULL 3/6] target/i386/sev: Rephrase error message when no hashes table in guest firmware

2021-11-18 Thread Daniel P . Berrangé
From: Dov Murik Signed-off-by: Dov Murik Acked-by: Brijesh Singh Signed-off-by: Daniel P. Berrangé --- target/i386/sev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/i386/sev.c b/target/i386/sev.c index e3abbeef68..6ff196f7ad 100644 --- a/target/i386/sev.c +++

[PULL 2/6] target/i386/sev: Add kernel hashes only if sev-guest.kernel-hashes=on

2021-11-18 Thread Daniel P . Berrangé
From: Dov Murik Commit cff03145ed3c ("sev/i386: Introduce sev_add_kernel_loader_hashes for measured linux boot", 2021-09-30) introduced measured direct boot with -kernel, using an OVMF-designated hashes table which QEMU fills. However, if OVMF doesn't designate such an area, QEMU would completel

[PATCH v3 0/5] tests/qtest: add some tests for virtio-net failover

2021-11-18 Thread Laurent Vivier
This series adds a qtest entry to test virtio-net failover feature. We check following error cases: - check missing id on device with failover_pair_id triggers an error - check a primary device plugged on a bus that doesn't support hotplug triggers an error We check the status of the machine b

[PULL 4/6] target/i386/sev: Fail when invalid hashes table area detected

2021-11-18 Thread Daniel P . Berrangé
From: Dov Murik Commit cff03145ed3c ("sev/i386: Introduce sev_add_kernel_loader_hashes for measured linux boot", 2021-09-30) introduced measured direct boot with -kernel, using an OVMF-designated hashes table which QEMU fills. However, no checks are performed on the validity of the hashes area d

Re: [qemu-web PATCH v2] Add Sponsors page

2021-11-18 Thread Paolo Bonzini
On 11/18/21 13:29, Philippe Mathieu-Daudé wrote: Add a page listing QEMU sponsors. For now, only mention Fosshost which requested to be listed: https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg05381.html Cc: Thomas Markey Resolves: https://gitlab.com/qemu-project/qemu-web/-/issues/2 Si

[PATCH v3 2/5] tests/qtest: add some tests for virtio-net failover

2021-11-18 Thread Laurent Vivier
Add test cases to test several error cases that must be generated by invalid failover configuration. Add a combination of coldplug and hotplug test cases to be sure the primary is correctly managed according the presence or not of the STANDBY feature. Signed-off-by: Laurent Vivier --- tests/qte

[PULL 1/6] qapi/qom, target/i386: sev-guest: Introduce kernel-hashes=on|off option

2021-11-18 Thread Daniel P . Berrangé
From: Dov Murik Introduce new boolean 'kernel-hashes' option on the sev-guest object. It will be used to to decide whether to add the hashes of kernel/initrd/cmdline to SEV guest memory when booting with -kernel. The default value is 'off'. Signed-off-by: Dov Murik Acked-by: Brijesh Singh Sign

Re: [qemu-web PATCH v2] Add Sponsors page

2021-11-18 Thread Philippe Mathieu-Daudé
+project maintainers On 11/18/21 13:54, Thomas Huth wrote: > On 18/11/2021 13.29, Philippe Mathieu-Daudé wrote: >> Add a page listing QEMU sponsors. >> >> For now, only mention Fosshost which requested to be listed: >> https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg05381.html > ... >> +Q

[PULL 5/6] target/i386/sev: Perform padding calculations at compile-time

2021-11-18 Thread Daniel P . Berrangé
From: Dov Murik In sev_add_kernel_loader_hashes, the sizes of structs are known at compile-time, so calculate needed padding at compile-time. No functional change intended. Signed-off-by: Dov Murik Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Philippe Mathieu-Daudé Acked-by: Brijesh Sing

Re: [qemu-web PATCH v2] Add Sponsors page

2021-11-18 Thread Philippe Mathieu-Daudé
On 11/18/21 14:41, Paolo Bonzini wrote: > On 11/18/21 13:29, Philippe Mathieu-Daudé wrote: >> Add a page listing QEMU sponsors. >> >> For now, only mention Fosshost which requested to be listed: >> https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg05381.html >> >> Cc: Thomas Markey >> Resol

[PATCH v3 1/5] qtest/libqos: add a function to initialize secondary PCI buses

2021-11-18 Thread Laurent Vivier
Scan the PCI devices to find bridge and set PCI_SECONDARY_BUS and PCI_SUBORDINATE_BUS (algorithm from seabios) Signed-off-by: Laurent Vivier --- include/hw/pci/pci_bridge.h | 8 +++ tests/qtest/libqos/pci.c| 118 tests/qtest/libqos/pci.h| 1 + 3 f

Re: [PATCH v3 0/6] SEV: add kernel-hashes=on for measured -kernel launch

2021-11-18 Thread Paolo Bonzini
On 11/18/21 14:02, Daniel P. Berrangé wrote: On Thu, Nov 18, 2021 at 02:21:09PM +0200, Dov Murik wrote: Pinging again -- Daniel said this should be added to 6.2. Is there anything I should do? I'm going to take care of sending a PULL to relieve Paolo's workload. Apologies, I ignored the ser

[PATCH v3 3/5] failover: fix unplug pending detection

2021-11-18 Thread Laurent Vivier
Failover needs to detect the end of the PCI unplug to start migration after the VFIO card has been unplugged. To do that, a flag is set in pcie_cap_slot_unplug_request_cb() and reset in pcie_unplug_device(). But since 17858a169508 ("hw/acpi/ich9: Set ACPI PCI hot-plug as default on Q35") we h

[PATCH v3 4/5] libqtest: add a function to use a timeout when waiting for an event

2021-11-18 Thread Laurent Vivier
To be able to check we _don't_ receive a given event, we need to be able to stop to wait for it after a given amount of time. To do that, introduce a timeout value in qtest_qmp_eventwait(). The new version of the function is qtest_qmp_eventwait_timeout(), that uses the new function qtest_qmp_recei

Re: [PATCH v4 00/25] block layer: split block APIs in global state and I/O

2021-11-18 Thread Paolo Bonzini
On 11/15/21 17:03, Hanna Reitz wrote: I only really see four solutions for this: (1) We somehow make the amend job run in the main context under the BQL and have it prevent all concurrent I/O access (seems bad) (2) We can make the permission functions part of the I/O path (seems wrong and prob

[PULL 6/6] target/i386/sev: Replace qemu_map_ram_ptr with address_space_map

2021-11-18 Thread Daniel P . Berrangé
From: Dov Murik Use address_space_map/unmap and check for errors. Signed-off-by: Dov Murik Acked-by: Brijesh Singh [Two lines wrapped for length - Daniel] Signed-off-by: Daniel P. Berrangé --- target/i386/sev.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff -

Re: [PATCH v4 00/25] block layer: split block APIs in global state and I/O

2021-11-18 Thread Paolo Bonzini
On 11/15/21 17:03, Hanna Reitz wrote: and second fuse_do_truncate(), which calls blk_set_perm(). Here it seems that a non-growable export is still growable as long as nobody is watching. :) Is this the desired behavior? Paolo

[PATCH v3 5/5] tests/libqtest: update virtio-net failover test

2021-11-18 Thread Laurent Vivier
Update the migration test to check we correctly wait the end of the card unplug before doing the migration. Signed-off-by: Laurent Vivier --- tests/qtest/virtio-net-failover.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/tests/qtest/virtio-net-failover.c

Re: [qemu-web PATCH v2] Add Sponsors page

2021-11-18 Thread Philippe Mathieu-Daudé
On 11/18/21 14:59, Daniel P. Berrangé wrote: > On Thu, Nov 18, 2021 at 01:54:38PM +0100, Thomas Huth wrote: >> On 18/11/2021 13.29, Philippe Mathieu-Daudé wrote: >>> Add a page listing QEMU sponsors. >>> >>> For now, only mention Fosshost which requested to be listed: >>> https://lists.gnu.org/arch

Re: [qemu-web PATCH v2] Add Sponsors page

2021-11-18 Thread Daniel P . Berrangé
On Thu, Nov 18, 2021 at 01:54:38PM +0100, Thomas Huth wrote: > On 18/11/2021 13.29, Philippe Mathieu-Daudé wrote: > > Add a page listing QEMU sponsors. > > > > For now, only mention Fosshost which requested to be listed: > > https://lists.gnu.org/archive/html/qemu-devel/2021-06/msg05381.html > ...

Re: [qemu-web PATCH v2] Add Sponsors page

2021-11-18 Thread Philippe Mathieu-Daudé
Cc'ing Alistair regarding the RISC-V foundation help: https://www.cnx-software.com/2021/05/03/the-risc-v-foundation-to-give-away-1000-risc-v-development-boards/ On 11/18/21 13:29, Philippe Mathieu-Daudé wrote: > Add a page listing QEMU sponsors. > > For now, only mention Fosshost which requested

Re: [PATCH v2 1/2] qemu-options: define -spice only #ifdef CONFIG_SPICE

2021-11-18 Thread Marc-André Lureau
Hi On Thu, Nov 18, 2021 at 3:58 PM Markus Armbruster wrote: > > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > Fixes: > > https://bugzilla.redhat.com/show_bug.cgi?id=1982600 > > > > Signed-off-by: Marc-André Lureau > > --- > > softmmu/vl.c| 2 ++ > > qemu-options

[PATCH-for-6.2?] docs: Spell QEMU all caps

2021-11-18 Thread Philippe Mathieu-Daudé
Replace Qemu -> QEMU. Signed-off-by: Philippe Mathieu-Daudé --- docs/devel/modules.rst| 2 +- docs/devel/multi-thread-tcg.rst | 2 +- docs/devel/style.rst | 2 +- docs/devel/ui.rst | 4 ++-- docs/interop/nbd.txt | 6

[PATCH 0/3] block: misc fixes & improvements for SSH block driver key fingerprints

2021-11-18 Thread Daniel P . Berrangé
* The docs were pointing people towards the obsolete and insecure MD5 fingerprint config instead of preferred sha256 * The sha256 fingerprint handling wasn't wired up into the legacy CLI parsing code * Finger print check failures were hard to diagnose due to limited info reported on err

[PATCH 1/3] block: better document SSH host key fingerprint checking

2021-11-18 Thread Daniel P . Berrangé
The docs still illustrate host key fingerprint checking using the old md5 hashes which are considered insecure and obsolete. Change it to illustrate using a sha256 hash. Also show how to extract the hash value from the known_hosts file. Signed-off-by: Daniel P. Berrangé --- docs/system/qemu-bloc

[PATCH 2/3] block: support sha256 fingerprint with pre-blockdev options

2021-11-18 Thread Daniel P . Berrangé
When support for sha256 fingerprint checking was aded in commit bf783261f0aee6e81af3916bff7606d71ccdc153 Author: Daniel P. Berrangé Date: Tue Jun 22 12:51:56 2021 +0100 block/ssh: add support for sha256 host key fingerprints it was only made to work with -blockdev. Getting it workin

[PATCH 3/3] block: print the server key type and fingerprint on failure

2021-11-18 Thread Daniel P . Berrangé
When validating the server key fingerprint fails, it is difficult for the user to know what they got wrong. The fingerprint accepted by QEMU is received in a different format than openssh displays. There can also be keys for multiple different ciphers in known_hosts. It may not be obvious which cip

Re: [PATCH v2 12/13] hw/arm/aspeed: Replace drive_get_next() by drive_get()

2021-11-18 Thread Cédric Le Goater
On 11/17/21 17:34, Markus Armbruster wrote: drive_get_next() is basically a bad idea. It returns the "next" block backend of a certain interface type. "Next" means bus=0,unit=N, where subsequent calls count N up from zero, per interface type. This lets you define unit numbers implicitly by exe

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

2021-11-18 Thread Cédric Le Goater
No need to rebase if Alexey sends his pullreq once v6.2 is out. Yeah. We might do that Alexey. No hurries. Thanks, C.

[PATCH-for-6.2?] docs: Render binary names as monospaced text

2021-11-18 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- docs/about/removed-features.rst| 8 docs/devel/build-system.rst| 6 +++--- docs/devel/multi-process.rst | 6 +++--- docs/devel/testing.rst | 8 docs/image-fuzzer.txt | 6

Re: [PATCH 1/3] ppc/pnv: Tune the POWER9 PCIe Host bridge model

2021-11-18 Thread Cédric Le Goater
On 11/16/21 18:01, Frederic Barrat wrote: The PHB v4 found on POWER9 doesn't request any LSI, so let's clear the Interrupt Pin register in the config space so that the model matches the hardware. If we don't, then we inherit from the default pcie root bridge, which requests a LSI. And because we

Re: [PATCH 2/3] pci: Export the pci_intx() function

2021-11-18 Thread Cédric Le Goater
On 11/16/21 18:01, Frederic Barrat wrote: Move the pci_intx() definition to the PCI header file, so that it can be called from other PCI files. It is used by the next patch. Signed-off-by: Frederic Barrat Reviewed-by: Cédric Le Goater Thanks, C. --- hw/pci/pci.c | 5 - i

Re: [PATCH v2 10/13] hw/arm/xlnx-zcu102: Replace drive_get_next() by drive_get()

2021-11-18 Thread Edgar E. Iglesias
On Wed, Nov 17, 2021 at 05:34:06PM +0100, Markus Armbruster wrote: > drive_get_next() is basically a bad idea. It returns the "next" block > backend of a certain interface type. "Next" means bus=0,unit=N, where > subsequent calls count N up from zero, per interface type. > > This lets you define

Re: [PATCH v2 11/13] hw/arm/xilinx_zynq: Replace drive_get_next() by drive_get()

2021-11-18 Thread Edgar E. Iglesias
On Wed, Nov 17, 2021 at 05:34:07PM +0100, Markus Armbruster wrote: > drive_get_next() is basically a bad idea. It returns the "next" block > backend of a certain interface type. "Next" means bus=0,unit=N, where > subsequent calls count N up from zero, per interface type. > > This lets you define

Re: [PATCH 3/3] pcie_aer: Don't trigger a LSI if none are defined

2021-11-18 Thread Cédric Le Goater
On 11/16/21 18:01, Frederic Barrat wrote: Skip triggering an LSI when the AER root error status is updated if no LSI is defined for the device. We can have a root bridge with no LSI, MSI and MSI-X defined, for example on POWER systems. Signed-off-by: Frederic Barrat --- Reviewed-by: Cédric L

Re: [PATCH] block/vvfat.c fix leak when failure occurs

2021-11-18 Thread Hanna Reitz
On 18.11.21 10:33, Daniella Lee wrote: Thanks for your reply and your suggestion is useful. This is my first submission, and I will pay attention to these issues in the future. There are many other places you mentioned need to be modified, do I need to resubmit the patch, or you want to modify

Re: [PATCH v2 09/13] hw/microblaze: Replace drive_get_next() by drive_get()

2021-11-18 Thread Edgar E. Iglesias
On Wed, Nov 17, 2021 at 05:34:05PM +0100, Markus Armbruster wrote: > drive_get_next() is basically a bad idea. It returns the "next" block > backend of a certain interface type. "Next" means bus=0,unit=N, where > subsequent calls count N up from zero, per interface type. > > This lets you define

Re: [PATCH v2 08/13] hw/arm/xlnx-versal-virt: Replace drive_get_next() by drive_get()

2021-11-18 Thread Edgar E. Iglesias
On Wed, Nov 17, 2021 at 05:34:04PM +0100, Markus Armbruster wrote: > drive_get_next() is basically a bad idea. It returns the "next" block > backend of a certain interface type. "Next" means bus=0,unit=N, where > subsequent calls count N up from zero, per interface type. > > This lets you define

[PATCH-for-6.2? v2 1/5] docs/devel/style: Render C types as monospaced text

2021-11-18 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- docs/devel/style.rst | 59 ++-- 1 file changed, 30 insertions(+), 29 deletions(-) diff --git a/docs/devel/style.rst b/docs/devel/style.rst index e00af62e763..3e519dc6ade 100644 --- a/docs/devel/style.rst +++ b/docs

[PATCH-for-6.2? v2 4/5] docs/devel/style: Render C function names as monospaced text

2021-11-18 Thread Philippe Mathieu-Daudé
Add trailing parenthesis to functions and render them as monospaced text. Signed-off-by: Philippe Mathieu-Daudé --- docs/devel/style.rst | 66 +++- 1 file changed, 34 insertions(+), 32 deletions(-) diff --git a/docs/devel/style.rst b/docs/devel/style.rst

[PATCH-for-6.2? v2 0/5] docs/devel/style: Improve rST rendering

2021-11-18 Thread Philippe Mathieu-Daudé
Various changes in docs/devel/style.rst to improve its rST rendering (around C types/qualifiers/functions). Since v1: - Addressed Darren Kenny comments on function names Based-on: <2028144317.4106651-1-phi...@redhat.com> Philippe Mathieu-Daudé (5): docs/devel/style: Render C types as monos

[PATCH-for-6.2? v2 2/5] docs/devel/style: Improve Error** functions rST rendering

2021-11-18 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- docs/devel/style.rst | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/docs/devel/style.rst b/docs/devel/style.rst index 3e519dc6ade..1a23021bc3e 100644 --- a/docs/devel/style.rst +++ b/docs/devel/style.r

[PATCH-for-6.2? v2 5/5] docs/devel/style: Misc rST rendering improvements

2021-11-18 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- docs/devel/style.rst | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/docs/devel/style.rst b/docs/devel/style.rst index 0397971e528..1db50b70544 100644 --- a/docs/devel/style.rst +++ b/docs/devel/style.rst @

[PATCH-for-6.2? v2 3/5] docs/devel/style: Improve string format rST rendering

2021-11-18 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- docs/devel/style.rst | 41 + 1 file changed, 21 insertions(+), 20 deletions(-) diff --git a/docs/devel/style.rst b/docs/devel/style.rst index 1a23021bc3e..a7487d867e6 100644 --- a/docs/devel/style.rst +++ b/docs/de

Re: [PATCH-for-6.2 1/2] hw/misc/bcm2835_property: Fix framebuffer with recent RPi kernels

2021-11-18 Thread Philippe Mathieu-Daudé
On 10/17/21 09:48, Benjamin Herrenschmidt wrote: > The framebuffer driver fails to initialize with recent Raspberry Pi > kernels, such as the ones shipped in the current RaspiOS images > (with the out of tree bcm2708_fb.c driver) > > The reason is that this driver uses a new firmware call to query

Re: [PATCH v4 08/25] block: introduce assert_bdrv_graph_writable

2021-11-18 Thread Hanna Reitz
On 18.11.21 10:55, Emanuele Giuseppe Esposito wrote: On 12/11/2021 15:40, Hanna Reitz wrote: On 25.10.21 12:17, Emanuele Giuseppe Esposito wrote: We want to be sure that the functions that write the child and parent list of a bs are under BQL and drain. BQL prevents from concurrent writings f

  1   2   3   >