On 11/12/21 3:58 PM, Frédéric Pétrot wrote:
Adding defines to handle signed 64-bit and unsigned 128-bit quantities in
memory accesses.
Signed-off-by: Frédéric Pétrot
---
include/exec/memop.h | 7 +++
1 file changed, 7 insertions(+)
Reviewed-by: Richard Henderson
r~
From: Marc-André Lureau
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1982600
Signed-off-by: Marc-André Lureau
---
softmmu/vl.c| 2 ++
qemu-options.hx | 2 ++
2 files changed, 4 insertions(+)
diff --git a/softmmu/vl.c b/softmmu/vl.c
index 1159a64bce4e..385465fbeb6d 100644
--- a/softm
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
softmmu/vl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/softmmu/vl.c b/softmmu/vl.c
index 385465fbeb6d..c584836c231e 100644
--- a/softmmu/vl.c
+++ b/softmmu/vl.c
@@ -1957,7 +1957,7 @@ static void qemu_create_e
From: Marc-André Lureau
Hi,
This is v2 of "[PATCH] qemu-options.hx: remove -spice options from --help",
after Markus comment on patch title.
Marc-André Lureau (2):
qemu-options: define -spice only #ifdef CONFIG_SPICE
vl: typo fix in a comment
softmmu/vl.c| 4 +++-
qemu-options.hx | 2
PING
thanks, Wind Yu
Hi Lureau,
You say that hot-add failare is reasonable after hot-remove? I think it is a
clear issue.
>Hi
On Sat, Nov 6, 2021 at 10:41 PM <787738...@qq.com> wrote:
>
> We have found that qemu cannot plug in the previously unplugged device.
> start qe
On 11/12/21 3:58 PM, Frédéric Pétrot wrote:
+/* Compute only 64-bit addresses to use the address translation mechanism */
+static bool gen_load_i128(DisasContext *ctx, arg_lb *a, MemOp memop)
+{
+TCGv src1l = get_gpr(ctx, a->rs1, EXT_NONE);
+TCGv destl = dest_gpr(ctx, a->rd);
+TCGv de
On 11/12/21 3:58 PM, Frédéric Pétrot wrote:
The 128-bit bitwise instructions do not need any function prototype change
as the functions can be applied independently on the lower and upper part of
the registers.
Signed-off-by: Frédéric Pétrot
Co-authored-by: Fabien Portas
---
target/riscv/trans
On 11/15/21 4:59 AM, gaosong wrote:
'The width of the immediate is a detail of the format' means:
&fmt_rdrjimm rd rj imm
@fmt_rdrjimm .. imm:12 rj:5 rd:5 &fmt_rdrjimm
@fmt_rdrjimm14 imm:14 rj:5 rd:5 &fmt_rdrjimm
@fmt_rdrjimm16 ...
v1 -> v0:
* move monitor cleanup to the very end of qemu cleanup [Paolo]
The goal is to notify management layer about device destruction on qemu
shutdown.
Without this series DEVICE_DELETED event may not be sent because of stuck tasks
in the rcu thread. The rcu tasks may stuck on qemu shutdown b
This is needed to keep sending DEVICE_DELETED events on qemu cleanup.
The event may happen in the rcu thread and we're going to flush the rcu queue
explicitly before qemu exiting in the next patch. So move the monitor
destruction to the very end of qemu cleanup to be able to send all the events.
S
The device destruction may superimpose over qemu shutdown.
In this case some management layer, requested a device unplug and
waiting for DEVICE_DELETED event, may never get this event.
This happens because device_finalize() may never be called on qemu shutdown
for some devices using address_space_
To ease maintenance, add the custom-runners/ directory and
split custom-runners.yml in 3 files, all included by the
current custom-runners.yml:
- ubuntu-18.04-s390x.yml
- ubuntu-20.04-aarch64.yml
- centos-stream-8-x86_64.yml
Signed-off-by: Philippe Mathieu-Daudé
---
Based-on: <2021160501.8
On 11/15/21 09:03, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Marc-André Lureau (2):
> qemu-options: define -spice only #ifdef CONFIG_SPICE
> vl: typo fix in a comment
Reviewed-by: Philippe Mathieu-Daudé
On Mon, Nov 15, 2021 at 12:52:00PM +0800, yadong...@intel.com wrote:
From: Yadong Qi
Add new virtio feature: VIRTIO_BLK_F_SECDISCARD.
Add new virtio command: VIRTIO_BLK_T_SECDISCARD.
Has a proposal been sent out yet to virtio-comment mailing list for
discussing these specification changes?
On Fri, 12 Nov 2021, Igor Mammedov wrote:
> On Thu, 11 Nov 2021 08:55:24 +0530 (IST)
> Ani Sinha wrote:
>
> > On Wed, 10 Nov 2021, Igor Mammedov wrote:
> >
> > > Mark property as experimental/internal adding 'x-' prefix.
> > >
> > > Property was introduced in 6.1 and it should have provided
>
On Wed, 10 Nov 2021, Igor Mammedov wrote:
> From: Julia Suvorova
>
> To solve issues [1-2] the Hot Plug Capable bit in PCIe Slots will be
> turned on, while the switch to ACPI Hot-plug will be done in the
> DSDT table.
>
> Introducing 'x-keep-native-hpc' property disables the HPC bit only
> in
On 11/12/21 03:28, wangyanan (Y) wrote:
> On 2021/11/11 18:03, Philippe Mathieu-Daudé wrote:
>> If the MachineClass::name pointer is not explicitly set, it is NULL.
>> Per the C standard, passing a NULL pointer to printf "%s" format is
>> undefined. Some implementations display it as 'NULL', other
On 11/12/21 03:04, wangyanan (Y) wrote:
> On 2021/11/11 18:03, Philippe Mathieu-Daudé wrote:
>> There is a single MachineClass object, registered with
>> type_register_static(&smp_machine_info). Since the same
>> object is used multiple times (an MachineState object
>> is instantiated in both test_
пн, 15 нояб. 2021 г. в 07:53, Jason Wang :
> On Fri, Nov 12, 2021 at 5:14 PM Vladislav Yaroshchuk
> wrote:
> >
> > macOS provides networking API for VMs called 'vmnet.framework':
> > https://developer.apple.com/documentation/vmnet
> >
> > We can provide its support as the new QEMU network backend
On Sun, 14 Nov 2021 at 17:41, Alexander Graf wrote:
>
>
>
> > Am 14.11.2021 um 18:20 schrieb Peter Maydell :
> > This is tricky, because we use the cpu->isar values to determine whether
> > we should be emulating things. So this change means we now create an
> > inconsistent CPU which in some ways
On Tue, 17 Nov 2020 at 23:38, Linus Walleij wrote:
>
> On Tue, Oct 13, 2020 at 11:22 AM Dave Martin wrote:
>
> > > case F_SETFD:
> > > err = 0;
> > > set_close_on_exec(fd, arg & FD_CLOEXEC);
> > > + if (arg & FD_32BIT_MODE)
> > > +
On Mon, Nov 15, 2021 at 12:52:00PM +0800, yadong...@intel.com wrote:
> From: Yadong Qi
>
> Add new virtio feature: VIRTIO_BLK_F_SECDISCARD.
> Add new virtio command: VIRTIO_BLK_T_SECDISCARD.
>
> This feature is disabled by default, it will check the backend
> bs->open_flags & BDRV_O_SECDISCARD,
On Fri, Nov 12, 2021 at 12:15:28PM +0100, Gerd Hoffmann wrote:
> On Thu, Nov 11, 2021 at 10:39:59AM -0500, Michael S. Tsirkin wrote:
> > On Thu, Nov 11, 2021 at 01:09:05PM +0100, Gerd Hoffmann wrote:
> > > Hi,
> > >
> > > > When the acpihp driver is used the linux kernel will just call the aml
>
Am 26.10.21 um 16:53 schrieb Peter Lieven:
Am 25.10.21 um 14:58 schrieb Kevin Wolf:
Am 25.10.2021 um 13:39 hat Peter Lieven geschrieben:
Am 16.09.21 um 14:34 schrieb Peter Lieven:
Am 09.07.21 um 12:21 schrieb Kevin Wolf:
Am 08.07.2021 um 20:23 hat Peter Lieven geschrieben:
Am 08.07.2021 um 1
On Mon, Oct 11, 2021 at 02:05:01PM +0200, Gerd Hoffmann wrote:
> Refuse to push the attention button in case the guest is busy with some
> hotplug operation (as indicated by the power indicator blinking).
>
> Signed-off-by: Gerd Hoffmann
Can't we do better and press the button later after
indica
On 15.11.21 11:46, Peter Maydell wrote:
On Sun, 14 Nov 2021 at 17:41, Alexander Graf wrote:
Am 14.11.2021 um 18:20 schrieb Peter Maydell :
This is tricky, because we use the cpu->isar values to determine whether
we should be emulating things. So this change means we now create an
inconsist
On Thu, Nov 11, 2021 at 06:54:03PM +0100, Christian Schoenebeck wrote:
> On Donnerstag, 11. November 2021 17:31:52 CET Stefan Hajnoczi wrote:
> > On Wed, Nov 10, 2021 at 04:53:33PM +0100, Christian Schoenebeck wrote:
> > > On Mittwoch, 10. November 2021 16:14:19 CET Stefan Hajnoczi wrote:
> > > > O
On 25.10.21 12:17, Emanuele Giuseppe Esposito wrote:
Similar to the header split, also the function pointers in BlockDriver
can be split in I/O and global state.
Signed-off-by: Emanuele Giuseppe Esposito
Reviewed-by: Stefan Hajnoczi
---
include/block/block_int-common.h | 458
+/*
+ * I/O API functions. These functions are thread-safe, and therefore
+ * can run in any thread as long as the thread has called
+ * aio_context_acquire/release().
+ */
+
+int bdrv_replace_child_bs(BdrvChild *child, BlockDriverState *new_bs,
+ Error **errp);
Why is t
Alexander Graf writes:
> On 15.11.21 11:46, Peter Maydell wrote:
>> On Sun, 14 Nov 2021 at 17:41, Alexander Graf wrote:
>>>
>>>
Am 14.11.2021 um 18:20 schrieb Peter Maydell :
This is tricky, because we use the cpu->isar values to determine whether
we should be emulating things.
@@ -5958,6 +6043,7 @@ const char *bdrv_get_parent_name(const
BlockDriverState *bs)
/* TODO check what callers really want: bs->node_name or blk_name() */
const char *bdrv_get_device_name(const BlockDriverState *bs)
{
+ assert(qemu_in_main_thread());
return bdrv_get_parent_name(bs
On 11/13/21 08:52, Markus Armbruster wrote:
I'm not asking what to do "if it hurts", or "if you want a cold-plugged
device". I'm asking whether there's a reason for ever wanting hot plug
instead of cold plug. Or in other words, what can hot plug possibly
gain us over cold plug?
As far as I kno
Am 15.11.2021 um 05:51 hat yadong...@intel.com geschrieben:
> From: Yadong Qi
>
> Add a new option "secdiscard" for block drive. Parse it and
> record it in bs->open_flags as bit(BDRV_O_SECDISCARD).
>
> Add a new BDRV_REQ_SECDISCARD bit for secure discard request
> from virtual device.
>
> For
On 25.10.21 12:17, Emanuele Giuseppe Esposito wrote:
Signed-off-by: Emanuele Giuseppe Esposito
Reviewed-by: Stefan Hajnoczi
---
block.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/block.c b/block.c
index 94bff5c757..40c4729b8d 100644
--- a/block.c
+++ b/block.c
[
On 11/1/21 17:04, Peter Maydell wrote:
On Thu, 23 Sept 2021 at 14:29, Peter Maydell wrote:
On Mon, 20 Sept 2021 at 13:25, Eric Auger wrote:
The PL031 currently is not able to report guest RTC change to the QMP
monitor as opposed to mc146818 or spapr RTCs. This patch adds the call
to qapi_ev
On 15.11.21 13:08, Alex Bennée wrote:
Alexander Graf writes:
On 15.11.21 11:46, Peter Maydell wrote:
On Sun, 14 Nov 2021 at 17:41, Alexander Graf wrote:
Am 14.11.2021 um 18:20 schrieb Peter Maydell :
This is tricky, because we use the cpu->isar values to determine whether
we should be e
drive_get_next() is basically a bad idea. It returns the "next" block
backend of a certain interface type. "Next" means bus=0,unit=N, where
subsequent calls count N up from zero, per interface type.
This lets you define unit numbers implicitly by execution order. If the
order changes, or new ca
ssi_sd_realize() creates an "sd-card" device. This is inappropriate,
and marked FIXME.
Move it to the boards that create these devices. Prior art: commit
eb4f566bbb for device "generic-sdhci", and commit 26c607b86b for
device "pl181".
Signed-off-by: Markus Armbruster
---
hw/arm/stellaris.c |
This is RFC because I'm unsure about the removal of
/* Reason: init() method uses drive_get_next() */
dc->user_creatable = false;
in PATCH 1. Both users appear to wire up some GPIO. If that's
necessary for the thing to work, we should just replace the comment.
Aside: there may be devic
On 12.11.21 17:10, Vladimir Sementsov-Ogievskiy wrote:
11.11.2021 15:08, Hanna Reitz wrote:
In most of the block layer, especially when traversing down from other
BlockDriverStates, we assume that BdrvChild.bs can never be NULL. When
it becomes NULL, it is expected that the corresponding BdrvCh
Am 03.11.2021 um 23:01 hat Hao Wu geschrieben:
> We made 3 changes to the at24c_eeprom_init function in
> npcm7xx_boards.c:
>
> 1. We allow the function to take a I2CBus* as parameter. This allows
>us to attach an EEPROM device behind an I2C mux which is not
>possible with the old method.
Am 15.11.2021 um 06:31 hat Markus Armbruster geschrieben:
> Peter Maydell writes:
>
> > On Fri, 12 Nov 2021 at 13:34, Markus Armbruster wrote:
> >>
> >> Thomas Huth writes:
> >>
> >> > On 03/11/2021 09.41, Markus Armbruster wrote:
> >> >> Peter Maydell writes:
> >> >>
> >> >>> Does it make sen
On Fri, 12 Nov 2021 16:37:20 +0100
Cornelia Huck wrote:
> On Fri, Nov 12 2021, Halil Pasic wrote:
>
> > Legacy vs modern should be detected via transport specific means. We
> > can't wait till feature negotiation is done. Let us introduce
> > virtio_force_modern() as a means for the transport c
On Mon, 15 Nov 2021 at 13:24, Kevin Wolf wrote:
> Same question as for Hao Wu's series: Wouldn't the proper solution be to
> add a drive property to the machine type?
>
> If you can't use -blockdev, it's not done right.
Is there an example of "doing it right" for built-in-to-the-machine
devices?
On Mon, 15 Nov 2021 at 12:55, Markus Armbruster wrote:
>
> drive_get_next() is basically a bad idea. It returns the "next" block
> backend of a certain interface type. "Next" means bus=0,unit=N, where
> subsequent calls count N up from zero, per interface type.
>
> This lets you define unit numb
On Mon, 15 Nov 2021 at 12:56, Markus Armbruster wrote:
>
> ssi_sd_realize() creates an "sd-card" device. This is inappropriate,
> and marked FIXME.
>
> Move it to the boards that create these devices. Prior art: commit
> eb4f566bbb for device "generic-sdhci", and commit 26c607b86b for
> device "
Peter Maydell writes:
> On Mon, 15 Nov 2021 at 12:55, Markus Armbruster wrote:
>>
>> drive_get_next() is basically a bad idea. It returns the "next" block
>> backend of a certain interface type. "Next" means bus=0,unit=N, where
>> subsequent calls count N up from zero, per interface type.
>>
>
Peter Maydell writes:
> On Mon, 15 Nov 2021 at 12:56, Markus Armbruster wrote:
>>
>> ssi_sd_realize() creates an "sd-card" device. This is inappropriate,
>> and marked FIXME.
>>
>> Move it to the boards that create these devices. Prior art: commit
>> eb4f566bbb for device "generic-sdhci", and
On 12.11.21 17:25, Vladimir Sementsov-Ogievskiy wrote:
11.11.2021 15:08, Hanna Reitz wrote:
See the comment for why this is necessary.
Signed-off-by: Hanna Reitz
---
tests/qemu-iotests/030 | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/030
On 11/15/21 13:55, Markus Armbruster wrote:
> drive_get_next() is basically a bad idea. It returns the "next" block
> backend of a certain interface type. "Next" means bus=0,unit=N, where
> subsequent calls count N up from zero, per interface type.
>
> This lets you define unit numbers implicitl
On Mon, 15 Nov 2021 at 12:55, Markus Armbruster wrote:
>
> This is RFC because I'm unsure about the removal of
>
> /* Reason: init() method uses drive_get_next() */
> dc->user_creatable = false;
>
> in PATCH 1. Both users appear to wire up some GPIO. If that's
> necessary for the thing t
Gitlab also provides runners with Windows, we can use them to
test compilation with MSYS2, in both, 64-bit and 32-bit.
However, it takes quite a long time to set up the VM, so to
stay in the 1h time frame, we can only compile and check one
target here.
Signed-off-by: Thomas Huth
---
"make check
On Mon, Nov 15, 2021 at 12:51:59PM +0800, yadong...@intel.com wrote:
> From: Yadong Qi
>
> Add a new option "secdiscard" for block drive. Parse it and
> record it in bs->open_flags as bit(BDRV_O_SECDISCARD).
>
> Add a new BDRV_REQ_SECDISCARD bit for secure discard request
> from virtual device.
On 15.11.21 13:48, Hanna Reitz wrote:
On 25.10.21 12:17, Emanuele Giuseppe Esposito wrote:
Signed-off-by: Emanuele Giuseppe Esposito
Reviewed-by: Stefan Hajnoczi
---
block.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/block.c b/block.c
index 94bff5c757..40c4729b8d
Philippe Mathieu-Daudé writes:
> To ease maintenance, add the custom-runners/ directory and
> split custom-runners.yml in 3 files, all included by the
> current custom-runners.yml:
> - ubuntu-18.04-s390x.yml
> - ubuntu-20.04-aarch64.yml
> - centos-stream-8-x86_64.yml
>
> Signed-off-by: Phili
On Mon, Nov 15, 2021 at 12:52:00PM +0800, yadong...@intel.com wrote:
The Linux block layer shares the DISCARD queue limits with SECDISCARD.
That's different from BLKZEROOUT (QEMU's WRITE_ZEROES). This is a Linux
implementation detail but I guess virtio-blk can share the DISCARD
limits with SECDISC
While it is useful to run these images using TCG their performance
will not be anything like the native guests. Don't do it by default.
Fixes: https://gitlab.com/qemu-project/qemu/-/issues/393
Signed-off-by: Alex Bennée
---
tests/vm/Makefile.include | 17 +
1 file changed, 13 ins
Making the list alphabetical makes it easier to find the config option
you are looking for.
Signed-off-by: Alex Bennée
---
tests/vm/Makefile.include | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/tests/vm/Makefile.include b/tests/vm/Makefile.include
index f3a3a1
Hi,
Here is the current state of my for-6.2/misc fixes tree. Currently the
following are unreviewed:
- tests/vm: don't build using TCG by default
- tests/vm: sort the special variable list
- tests/docker: force NOUSER=1 for base images
Alex Bennée (3):
tests/docker: force NOUSER=1 for base
From: Cleber Rosa
This introduces three different parts of a job designed to run
on a custom runner managed by Red Hat. The goals include:
a) propose a model for other organizations that want to onboard
their own runners, with their specific platforms, build
configuration and tests.
From: Paolo Bonzini
dlopen is never used after it is sought via cc.find_library, because
plugins use gmodule instead; remove the test.
Signed-off-by: Paolo Bonzini
Reviewed-by: Thomas Huth
Message-Id: <2020092454.30916-1-pbonz...@redhat.com>
Signed-off-by: Alex Bennée
---
meson.build
As base images are often used to build further images like toolchains
ensure we don't add the local user by accident. The local user should
only exist on local images and not anything that gets pushed up to the
public registry.
Reported-by: Richard Henderson
Signed-off-by: Alex Bennée
Message-Id
On 15/11/2021 10.56, Philippe Mathieu-Daudé wrote:
To ease maintenance, add the custom-runners/ directory and
split custom-runners.yml in 3 files, all included by the
current custom-runners.yml:
- ubuntu-18.04-s390x.yml
- ubuntu-20.04-aarch64.yml
- centos-stream-8-x86_64.yml
Signed-off-by:
From: Philippe Mathieu-Daudé
To ease maintenance, add the custom-runners/ directory and
split custom-runners.yml in 3 files, all included by the
current custom-runners.yml:
- ubuntu-18.04-s390x.yml
- ubuntu-20.04-aarch64.yml
- centos-stream-8-x86_64.yml
Signed-off-by: Philippe Mathieu-Daudé
On Wed, 10 Nov 2021 14:48:40 -0500
Vivek Goyal wrote:
> Hi Greg,
>
> I don't see FUSE_SYNCFS support in virtiofsd. I see that kernel
> patches got merged. Did you post another version of patches?
>
Hi Vivek,
Unfortunately no and I'm really not sure I can get time to do
so. Sorry for that...
Ping^4. Who is collecting target/i386 patches these days ?
-- PMM
On Mon, 1 Nov 2021 at 16:18, Peter Maydell wrote:
>
> Ping^3, now 2 months after patch posted and reviewed...
>
> -- PMM
>
> On Mon, 27 Sept 2021 at 11:03, Peter Maydell wrote:
> >
> > Ping^2 !
> >
> > thanks
> > -- PMM
> >
> > O
On 11/15/21 15:22, Alex Bennée wrote:
>
> Philippe Mathieu-Daudé writes:
>
>> To ease maintenance, add the custom-runners/ directory and
>> split custom-runners.yml in 3 files, all included by the
>> current custom-runners.yml:
>> - ubuntu-18.04-s390x.yml
>> - ubuntu-20.04-aarch64.yml
>> - ce
On 25.10.21 12:17, Emanuele Giuseppe Esposito wrote:
Signed-off-by: Emanuele Giuseppe Esposito
Reviewed-by: Stefan Hajnoczi
---
include/block/block_int-common.h | 51
1 file changed, 32 insertions(+), 19 deletions(-)
diff --git a/include/block/block_int-comm
On Thu, Nov 11, 2021 at 02:08:54PM +0100, Gerd Hoffmann wrote:
> This allows to power off pci devices. In "off" state the devices will
> not be visible. No pci config space access, no pci bar access, no dma.
>
> Default state is "on", so this patch (alone) should not change behavior.
>
> Use ca
On 25.10.21 12:17, Emanuele Giuseppe Esposito wrote:
Signed-off-by: Emanuele Giuseppe Esposito
Reviewed-by: Stefan Hajnoczi
---
block.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/block.c b/block.c
index 40c4729b8d..da80e89ad4 100644
--- a/block.c
+++ b/block.c
[...]
Am 13.11.2021 um 09:14 hat Markus Armbruster geschrieben:
> Nominating for qemu-trivial.
I'm sending a pull request anyway, so I'm merging it.
Kevin
> Markus Armbruster writes:
>
> > Philippe Mathieu-Daudé writes:
> >
> >> Cc'ing Markus
> >>
> >> On 11/2/21 17:33, Stefan Hajnoczi wrote:
> >>>
On Mon, Nov 15, 2021 at 06:29:18AM -0500, Michael S. Tsirkin wrote:
> On Mon, Oct 11, 2021 at 02:05:01PM +0200, Gerd Hoffmann wrote:
> > Refuse to push the attention button in case the guest is busy with some
> > hotplug operation (as indicated by the power indicator blinking).
> >
> > Signed-off-
On Thu, Nov 11, 2021 at 02:08:54PM +0100, Gerd Hoffmann wrote:
> This allows to power off pci devices. In "off" state the devices will
> not be visible. No pci config space access, no pci bar access, no dma.
>
> Default state is "on", so this patch (alone) should not change behavior.
>
> Use ca
From: Hanna Reitz
bdrv_cor_filter_drop() modifies the block graph. That means that other
parties can also modify the block graph before it returns. Therefore,
we cannot assume that the result of a graph traversal we did before
remains valid afterwards.
We should thus fetch `base` and `unfilter
From: Hanna Reitz
The children list is specific to BDS parents. We should not modify it
in the general children modification code, but let BDS parents deal with
it in their .attach() and .detach() methods.
This also has the advantage that a BdrvChild is removed from the
children list before its
The following changes since commit 42f6c9179be4401974dd3a75ee72defd16b5092d:
Merge tag 'pull-ppc-2022' of https://github.com/legoater/qemu into
staging (2021-11-12 12:28:25 +0100)
are available in the Git repository at:
git://repo.or.cz/qemu/kevin.git tags/for-upstream
for you to fetch
From: Hanna Reitz
See the comment for why this is necessary.
Signed-off-by: Hanna Reitz
Message-Id: <2021120829.81329-11-hre...@redhat.com>
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/030 | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotes
From: Hanna Reitz
bdrv_attach_child_common_abort() restores the parent's AioContext. To
do so, the child (which was supposed to be attached, but is now detached
again by this abort handler) is added to the ignore list for the
AioContext changing functions.
However, since we modify a BDS's child
From: Hanna Reitz
Now that bdrv_remove_empty_child() no longer removes the child from the
parent's children list but only checks that it is not in such a list, it
is only a wrapper around bdrv_child_free() that checks that the child is
empty and unused. That should apply to all children that we
From: Hanna Reitz
As of a future commit, bdrv_replace_child_noperm() will clear the
indirect BdrvChild pointer passed to it if the new child BDS is NULL.
bdrv_replace_child_tran() will want to let it do that, but revert this
change in its abort handler. For that, we need to have it receive a
Bdr
At the end of a reopen, we already call bdrv_refresh_limits(), which
should update bs->request_alignment according to the new file
descriptor. However, raw_probe_alignment() relies on s->needs_alignment
and just uses 1 if it isn't set. We neglected to update this field, so
starting with cache=write
While introducing a non-QemuOpts code path for device creation for JSON
-device, we noticed that QMP device_add doesn't check its input
correctly (accepting arguments that should have been rejected), and that
users may be relying on this behaviour (libvirt did until it was fixed
recently).
Let's u
Split the 'generic' test in two tests: 'valid' and 'invalid'.
This will allow us to remove the hack which modifies the
MachineClass internal state.
Signed-off-by: Philippe Mathieu-Daudé
---
tests/unit/test-smp-parse.c | 22 +++---
1 file changed, 19 insertions(+), 3 deletions(-)
From: Hanna Reitz
bdrv_replace_child_noperm() modifies BdrvChild.bs, and can potentially
set it to NULL. That is dangerous, because BDS parents generally assume
that their children's .bs pointer is never NULL. We therefore want to
let bdrv_replace_child_noperm() set the corresponding BdrvChild
Declare structures const when we don't need to modify
them at runtime.
Reviewed-by: Andrew Jones
Reviewed-by: Richard Henderson
Reviewed-by: Yanan Wang
Tested-by: Yanan Wang
Signed-off-by: Philippe Mathieu-Daudé
---
tests/unit/test-smp-parse.c | 12 ++--
1 file changed, 6 insertions(
From: Hanna Reitz
As of a future patch, bdrv_replace_child_tran() will take a BdrvChild **
pointer. Prepare for that by getting such a pointer and using it where
applicable, and (dereferenced) as a parameter for
bdrv_replace_child_tran().
Signed-off-by: Hanna Reitz
Message-Id: <2021120829.
If the MachineClass::name pointer is not explicitly set, it is NULL.
Per the C standard, passing a NULL pointer to printf "%s" format is
undefined. Some implementations display it as 'NULL', other as 'null'.
Since we are comparing the formatted output, we need a stable value.
The easiest is to expl
smp_machine_class_init() is the actual TypeInfo::class_init().
Declare it as such in smp_machine_info, and avoid to call it
manually in each test. Move smp_machine_info definition just
before we register the type to avoid a forward declaration.
Reviewed-by: Andrew Jones
Reviewed-by: Richard Hende
Use g_test_add_data_func() instead of g_test_add_func() so we can
pass the machine type to the tests (we will soon have different
machine types).
Signed-off-by: Philippe Mathieu-Daudé
---
tests/unit/test-smp-parse.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff
Avoid modifying the MachineClass internals by adding the
'smp-with-dies' machine, which inherits from TYPE_MACHINE.
Signed-off-by: Philippe Mathieu-Daudé
---
tests/unit/test-smp-parse.c | 22 +++---
1 file changed, 15 insertions(+), 7 deletions(-)
diff --git a/tests/unit/test-sm
From: Stefan Hajnoczi
Reported by Coverity (CID 1465222).
Fixes: 4a1d937796de0fecd8b22d7dbebf87f38e8282fd ("softmmu/qdev-monitor: add
error handling in qdev_set_id")
Cc: Damien Hedde
Cc: Kevin Wolf
Cc: Michael S. Tsirkin
Signed-off-by: Stefan Hajnoczi
Message-Id: <20211102163342.31162-1-ste
All methods related to MachineState are prefixed with "machine_".
smp_parse() does not need to be an exception. Rename it and
const'ify the SMPConfiguration argument, since it doesn't need
to be modified.
Reviewed-by: Andrew Jones
Reviewed-by: Richard Henderson
Reviewed-by: Yanan Wang
Tested-by
On 11/15/21 15:33, Thomas Huth wrote:
> On 15/11/2021 10.56, Philippe Mathieu-Daudé wrote:
>> To ease maintenance, add the custom-runners/ directory and
>> split custom-runners.yml in 3 files, all included by the
>> current custom-runners.yml:
>> - ubuntu-18.04-s390x.yml
>> - ubuntu-20.04-aarch
We can simply use a local variable (and pass its pointer) instead
of a pointer to a compound literal.
Reviewed-by: Andrew Jones
Reviewed-by: Richard Henderson
Reviewed-by: Yanan Wang
Tested-by: Yanan Wang
Signed-off-by: Philippe Mathieu-Daudé
---
tests/unit/test-smp-parse.c | 66
From: Hanna Reitz
In most of the block layer, especially when traversing down from other
BlockDriverStates, we assume that BdrvChild.bs can never be NULL. When
it becomes NULL, it is expected that the corresponding BdrvChild pointer
also becomes NULL and the BdrvChild object is freed.
Therefore
On Montag, 15. November 2021 12:54:32 CET Stefan Hajnoczi wrote:
> On Thu, Nov 11, 2021 at 06:54:03PM +0100, Christian Schoenebeck wrote:
> > On Donnerstag, 11. November 2021 17:31:52 CET Stefan Hajnoczi wrote:
> > > On Wed, Nov 10, 2021 at 04:53:33PM +0100, Christian Schoenebeck wrote:
> > > > On
From: Hanna Reitz
Invoke the transaction drivers' .clean() methods only after all
.commit() or .abort() handlers are done.
This makes it easier to have nested transactions where the top-level
transactions pass objects to lower transactions that the latter can
still use throughout their commit/ab
On 25.10.21 12:17, Emanuele Giuseppe Esposito wrote:
The job API will be handled separately in another serie.
Signed-off-by: Emanuele Giuseppe Esposito
Reviewed-by: Stefan Hajnoczi
---
include/qemu/job.h | 16
1 file changed, 16 insertions(+)
diff --git a/include/qemu/job.
Am 15.11.2021 um 14:31 hat Peter Maydell geschrieben:
> On Mon, 15 Nov 2021 at 13:24, Kevin Wolf wrote:
> > Same question as for Hao Wu's series: Wouldn't the proper solution be to
> > add a drive property to the machine type?
> >
> > If you can't use -blockdev, it's not done right.
>
> Is there
Missing review: patches #4 to #8 (new)
Yet another approach to fix test-smp-parse. v2 from Yanan Wang:
https://lore.kernel.org/qemu-devel/2021024429.10568-1-wangyana...@huawei.com/
Here we use the QOM class_init() to avoid having to deal with
object_unref() and deinit().
Since v3:
- Restore
1 - 100 of 191 matches
Mail list logo
