Re: [RFC 3/6] target/riscv: rvk: add flag support for Zk/Zkn/Zknd/Zknd/Zkne/Zknh/Zks/Zksed/Zksh/Zkr

在 2021/11/3 上午9:21, Richard Henderson 写道: On 11/2/21 9:06 PM, liweiwei wrote: 在 2021/11/3 上午1:56, Richard Henderson 写道: On 11/1/21 11:11 PM, liweiwei wrote: +    if (cpu->cfg.ext_zk) { +    cpu->cfg.ext_zbkb = true; +    cpu->cfg.ext_zbkc = true; +    cpu->cfg.ex

[PATCH] qdev-monitor: Fix use after free on duplicate device ID error

Fixes: 4a1d937796de0fecd8b22d7dbebf87f38e8282fd Reported-by: Coverity CID 1465223 Signed-off-by: Markus Armbruster --- softmmu/qdev-monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/softmmu/qdev-monitor.c b/softmmu/qdev-monitor.c index e49d9773d2..14c1fb76c5 100644 ---

Re: [PATCH v2 1/1] vhost: Fix last queue index of devices with no cvq

On Wed, Nov 3, 2021 at 3:50 AM Jason Wang wrote: > > On Tue, Nov 2, 2021 at 7:41 PM Eugenio Pérez wrote: > > > > The -1 assumes that all devices with no cvq have an spare vq allocated > > for them, but with no offer of VIRTIO_NET_F_CTRL_VQ. This is an invalid > > device by the standard, so just s

Re: [RFC PATCH v5 23/26] util: Add iova_tree_alloc

On Wed, Nov 3, 2021 at 4:10 AM Jason Wang wrote: > > On Tue, Nov 2, 2021 at 4:29 PM Eugenio Perez Martin > wrote: > > > > On Tue, Nov 2, 2021 at 7:35 AM Jason Wang wrote: > > > > > > > > > 在 2021/10/30 上午2:35, Eugenio Pérez 写道: > > > > This iova tree function allows it to look for a hole in all

Re: [PATCH] qdev-monitor: Fix use after free on duplicate device ID error

On Wed, Nov 3, 2021 at 11:39 AM Markus Armbruster wrote: > Fixes: 4a1d937796de0fecd8b22d7dbebf87f38e8282fd > Reported-by: Coverity CID 1465223 > Signed-off-by: Markus Armbruster > --- > softmmu/qdev-monitor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/softmmu/qdev-

Re: [RFC PATCH v5 21/26] vhost: Add vhost_svq_valid_guest_features to shadow vq

On Wed, Nov 3, 2021 at 4:18 AM Jason Wang wrote: > > On Tue, Nov 2, 2021 at 4:10 PM Eugenio Perez Martin > wrote: > > > > On Tue, Nov 2, 2021 at 6:26 AM Jason Wang wrote: > > > > > > On Sat, Oct 30, 2021 at 2:44 AM Eugenio Pérez wrote: > > > > > > > > This allows it to test if the guest has ak

Re: [PATCH] hw/qdev-core: Add compatibility for (non)-transitional devs

On 1/11/2021 23:26, Michael S. Tsirkin wrote: On Tue, Oct 12, 2021 at 10:24:28AM +0200, Jean-Louis Dupond wrote: hw_compat modes only take into account their base name. But if a device is created with (non)-transitional, then the compat values are not used, causing migrating issues. This commit

Re: [PATCH] hw/qdev-core: Add compatibility for (non)-transitional devs

On Wed, Nov 03, 2021 at 08:51:42AM +0100, Jean-Louis Dupond wrote: > On 1/11/2021 23:26, Michael S. Tsirkin wrote: > > On Tue, Oct 12, 2021 at 10:24:28AM +0200, Jean-Louis Dupond wrote: > > > hw_compat modes only take into account their base name. > > > But if a device is created with (non)-transit

Re: more bogus meson warnings

On Tue, Nov 2, 2021 at 2:38 PM Peter Maydell wrote: > I tried my static-system build config today; meson bogus > complaints include: > > WARNING: Static library 'pulse' not found for dependency 'libpulse', > may not be statically linked > WARNING: Static library 'pulsecommon-11.1' not found for de

Re: [PATCH] qmp: Stabilize preconfig

Daniel P. Berrangé writes: > On Mon, Nov 01, 2021 at 03:37:58PM +0100, Michal Prívozník wrote: >> On 10/25/21 2:19 PM, Markus Armbruster wrote: >> > Michal Privoznik writes: >> > >> >> The -preconfig option and exit-preconfig command are around for >> >> quite some time now. However, they are s

Re: [PATCH v2] hmp: Add shortcut to stop command to match cont

Le 01/11/2021 à 23:56, BALATON Zoltan a écrit : Ping? This is really simple addition that sholdn't take long to review. On Sat, 30 Oct 2021, BALATON Zoltan wrote: Some commands such as quit or cont have one letter alternatives but stop is missing that. Add stop|s to match cont|c for consistency

[qemu-web PATCH] remove deployment phase from CI

qemu.org is now served via a reverse proxy from qemu-project.gitlab.io; it does not need anymore the rsync step to the QEMU project\s shell server. Remove it from the CI. Signed-off-by: Paolo Bonzini --- .gitlab-ci.yml | 24 1 file changed, 24 deletions(-) diff --git a/

[PATCH v5 2/6] vfio: move re-enabling INTX out of the common helper

Move re-enabling INTX out, and the callers should decide to re-enable it or not. Signed-off-by: Longpeng(Mike) --- hw/vfio/pci.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index dd30806..d5e542b 100644 --- a/hw/vfio/pci.c

[PATCH v5 4/6] kvm: irqchip: extract kvm_irqchip_add_deferred_msi_route

Extract a common helper that add MSI route for specific vector but does not commit immediately. Signed-off-by: Longpeng(Mike) --- accel/kvm/kvm-all.c | 15 +-- include/sysemu/kvm.h | 6 ++ 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/accel/kvm/kvm-all.c b/acc

[PATCH v5 5/6] Revert "vfio: Avoid disabling and enabling vectors repeatedly in VFIO migration"

Commit ecebe53fe993 ("vfio: Avoid disabling and enabling vectors repeatedly in VFIO migration") avoids inefficiently disabling and enabling vectors repeatedly and lets the unmasked vectors be enabled one by one. But we want to batch multiple routes and defer the commit, and only commit once outsid

[PATCH v5 0/6] optimize the downtime for vfio migration

Hi guys, In vfio migration resume phase, the cost would increase if the vfio device has more unmasked vectors. We try to optimize it in this series. You can see the commit message in PATCH 6 for details. Patch 1-3 are simple cleanups and fixup. Patch 4-5 are the preparations for the optimizat

[PATCH v5 1/6] vfio: simplify the conditional statements in vfio_msi_enable

It's unnecessary to test against the specific return value of VFIO_DEVICE_SET_IRQS, since any positive return is an error indicating the number of vectors we should retry with. Signed-off-by: Longpeng(Mike) --- hw/vfio/pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH v5 3/6] vfio: simplify the failure path in vfio_msi_enable

Use vfio_msi_disable_common to simplify the error handling in vfio_msi_enable. Signed-off-by: Longpeng(Mike) --- hw/vfio/pci.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index d5e542b..1ff84e6 100644 --- a/hw/vfio/pci.c +++

[PATCH v5 6/6] vfio: defer to commit kvm irq routing when enable msi/msix

In migration resume phase, all unmasked msix vectors need to be setup when loading the VF state. However, the setup operation would take longer if the VM has more VFs and each VF has more unmasked vectors. The hot spot is kvm_irqchip_commit_routes, it'll scan and update all irqfds that are already

Re: [PATCH v5 00/26] fdt: Make OF_BOARD a boolean option

> From: Simon Glass > Date: Tue, 2 Nov 2021 19:20:51 -0600 > > Hi Mark, > > On Wed, 27 Oct 2021 at 16:30, Mark Kettenis wrote: > > > > > From: Simon Glass > > > Date: Wed, 27 Oct 2021 12:23:21 -0600 > > > > > > Hi François, > > > > > > On Wed, 27 Oct 2021 at 09:14, François Ozog > > > wrote:

Re: does drive_get_next(IF_NONE) make sense?

Peter Maydell writes: > Does it make sense for a device/board to do drive_get_next(IF_NONE) ? Short answer: hell, no! ;) Long answer below. > At the moment we have exactly one user of this, which is > hw/misc/sifive_u_otp.c. This is a model of a one-time-programmable > fuse, and the drive is

Re: [PATCH 4/4] icount: preserve cflags when custom tb is about to execute

On 28.10.2021 22:26, Richard Henderson wrote: On 10/28/21 4:48 AM, Pavel Dovgalyuk wrote: +    if (cpu->cflags_next_tb == -1 +    && (!use_icount || !(tb->cflags & CF_USE_ICOUNT) +    || cpu_neg(cpu)->icount_decr.u16.low >= tb->icount)) { +    /* + * i

[PULL 08/11] Removed the qemu_fclose() in colo_process_incoming_thread

From: "Rao, Lei" After the live migration, the related fd will be cleanup in migration_incoming_state_destroy(). So, the qemu_close() in colo_process_incoming_thread is not necessary. Signed-off-by: Lei Rao Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/colo.c | 5

[PULL 01/11] migration: provide an error message to migration_cancel()

From: Laurent Vivier This avoids to call migrate_get_current() in the caller function whereas migration_cancel() already needs the pointer to the current migration state. Signed-off-by: Laurent Vivier Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/migration.h | 2 +- m

[PULL 11/11] Optimized the function of fill_connection_key.

From: "Rao, Lei" Remove some unnecessary code to improve the performance of the filter-rewriter module. Signed-off-by: Lei Rao Reviewed-by: Zhang Chen Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- net/colo.h| 6 +++--- net/colo-compare.c| 2 +- net/colo.c

[PULL 10/11] colo: Don't dump colo cache if dump-guest-core=off

From: Lukas Straub One might set dump-guest-core=off to make coredumps smaller and still allow to debug many qemu bugs. Extend this option to the colo cache. Signed-off-by: Lukas Straub Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/ram.c | 6 ++ 1 file changed, 6

[PULL 02/11] migration: initialise compression_counters for a new migration

From: yuxiating If the compression migration fails or is canceled, the query for the value of compression_counters during the next compression migration is wrong. Signed-off-by: yuxiating Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/migration.c | 3 ++- 1 file change

[PULL 09/11] Changed the last-mode to none of first start COLO

From: "Rao, Lei" When we first stated the COLO, the last-mode is as follows: { "execute": "query-colo-status" } {"return": {"last-mode": "primary", "mode": "primary", "reason": "none"}} The last-mode is unreasonable. After the patch, will be changed to the following: { "execute": "query-colo-sta

[PULL 00/11] Migration 20211102 patches

The following changes since commit 741bdeb1d5a4024a2c54c6abb2de493a27b61953: Merge remote-tracking branch 'remotes/kwolf/tags/for-upstream' into staging (2021-11-03 00:32:56 -0400) are available in the Git repository at: https://github.com/juanquintela/qemu.git tags/migration-20211102-pull-

[PULL 07/11] colo: fixed 'Segmentation fault' when the simplex mode PVM poweroff

From: "Rao, Lei" The GDB statck is as follows: Program terminated with signal SIGSEGV, Segmentation fault. 0 object_class_dynamic_cast (class=0x55c8f5d2bf50, typename=0x55c8f2f7379e "qio-channel") at qom/object.c:832 if (type->class->interfaces && [Current thread is 1 (Thread 0x7f756e9

[PULL 05/11] Fixed qemu crash when guest power off in COLO mode

From: "Rao, Lei" This patch fixes the following: qemu-system-x86_64: invalid runstate transition: 'shutdown' -> 'running' Aborted (core dumped) The gdb bt as following: 0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50 1 0x7faa3d613859 in __GI_abort () at abort.c:79 2

[PULL 03/11] migration: Zero migration compression counters

Based on previous patch from yuxiating Signed-off-by: Juan Quintela --- migration/savevm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/migration/savevm.c b/migration/savevm.c index 7b7b64bd13..d59e976d50 100644 --- a/migration/savevm.c +++ b/migration/savevm.c @@ -1567,6 +1567,7 @@ stat

Re: [PATCH v3] Optimized the function of fill_connection_key.

"Rao, Lei" wrote: > From: "Rao, Lei" > > Remove some unnecessary code to improve the performance of > the filter-rewriter module. > > Signed-off-by: Lei Rao > Reviewed-by: Zhang Chen > Reviewed-by: Juan Quintela Queued, thanks.

[PATCH] Fix virtio-net-pci* "vectors" compat

From: Eduardo Habkost hw_compat_5_2 has an issue: it affects only "virtio-net-pci" but not "virtio-net-pci-transitional" and "virtio-net-pci-non-transitional". The solution is to use the "virtio-net-pci-base" type in compat_props. Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1999141 S

[PULL 06/11] Fixed SVM hang when do failover before PVM crash

From: "Rao, Lei" This patch fixed as follows: Thread 1 (Thread 0x7f34ee738d80 (LWP 11212)): #0 __pthread_clockjoin_ex (threadid=139847152957184, thread_return=0x7f30b1febf30, clockid=, abstime=, block=) at pthread_join_common.c:145 #1 0x563401998e36 in qemu_thread_join (thread=0

[PULL 04/11] Some minor optimizations for COLO

From: "Rao, Lei" Signed-off-by: Lei Rao Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/colo.c | 2 +- net/colo-compare.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/migration/colo.c b/migration/colo.c ind

Re: [qemu-web PATCH] remove deployment phase from CI

On 03/11/2021 09.14, Paolo Bonzini wrote: qemu.org is now served via a reverse proxy from qemu-project.gitlab.io; it does not need anymore the rsync step to the QEMU project\s shell server. Remove it from the CI. Signed-off-by: Paolo Bonzini --- .gitlab-ci.yml | 24

Re: [PATCH v2 5/7] hw/nvram: Update at24c EEPROM init function in NPCM7xx boards

On 01/11/2021 18.47, Hao Wu wrote: On Mon, Nov 1, 2021 at 10:41 AM Peter Maydell > wrote: On Thu, 21 Oct 2021 at 19:40, Hao Wu mailto:wuhao...@google.com>> wrote: > > We made 3 changes to the at24c_eeprom_init function in > npcm7xx_boards.c:

Re: does drive_get_next(IF_NONE) make sense?

On 03/11/2021 09.41, Markus Armbruster wrote: Peter Maydell writes: Does it make sense for a device/board to do drive_get_next(IF_NONE) ? Short answer: hell, no! ;) Would it make sense to add an "assert(type != IF_NONE)" to drive_get() to avoid such mistakes in the future? Thomas

Re: [PATCH] qdev-monitor: Fix use after free on duplicate device ID error

On 11/3/21 08:38, Markus Armbruster wrote: Fixes: 4a1d937796de0fecd8b22d7dbebf87f38e8282fd Reported-by: Coverity CID 1465223 Signed-off-by: Markus Armbruster Reviewed-by: Damien Hedde Thanks, Damien --- softmmu/qdev-monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH] qmp: Stabilize preconfig

On Wed, Nov 03, 2021 at 09:02:49AM +0100, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Mon, Nov 01, 2021 at 03:37:58PM +0100, Michal Prívozník wrote: > >> On 10/25/21 2:19 PM, Markus Armbruster wrote: > >> > Michal Privoznik writes: > >> > > >> >> The -preconfig option and exi

Re: [PATCH] qdev-monitor: Fix use after free on duplicate device ID error

Am 03.11.2021 um 08:38 hat Markus Armbruster geschrieben: > Fixes: 4a1d937796de0fecd8b22d7dbebf87f38e8282fd > Reported-by: Coverity CID 1465223 > Signed-off-by: Markus Armbruster Stefan already sent a patch yesterday: https://lists.gnu.org/archive/html/qemu-devel/2021-11/msg00759.html Message-Id

Re: [PATCH] Fix virtio-net-pci* "vectors" compat

On Wed, Nov 03 2021, Jean-Louis Dupond wrote: > From: Eduardo Habkost > > hw_compat_5_2 has an issue: it affects only "virtio-net-pci" > but not "virtio-net-pci-transitional" and > "virtio-net-pci-non-transitional". The solution is to use the > "virtio-net-pci-base" type in compat_props. > > Bu

Re: [PATCH] softmmu/qdev-monitor: fix use-after-free in qdev_set_id()

Cc'ing Markus On 11/2/21 17:33, Stefan Hajnoczi wrote: > Reported by Coverity (CID 1465222). > > Fixes: 4a1d937796de0fecd8b22d7dbebf87f38e8282fd ("softmmu/qdev-monitor: add > error handling in qdev_set_id") > Cc: Damien Hedde > Cc: Kevin Wolf > Cc: Michael S. Tsirkin > Signed-off-by: Stefan H

Re: [qemu-web PATCH] remove deployment phase from CI

On Wed, Nov 03, 2021 at 09:14:59AM +0100, Paolo Bonzini wrote: > qemu.org is now served via a reverse proxy from qemu-project.gitlab.io; it > does > not need anymore the rsync step to the QEMU project\s shell server. *project's -- Andrea Bolognani / Red Hat / Virtualization

[PATCH v3 0/2] vhost: Fix last queue index of devices with no cvq

The -1 assumes that all devices with no cvq have an spare vq allocated for them, but with no offer of VIRTIO_NET_F_CTRL_VQ. This is an invalid device by the standard, so just stick to the right number of device models. This is not a problem to vhost-net, but it is to vhost-vdpa, which device model

Re: [PATCH] softmmu/qdev-monitor: fix use-after-free in qdev_set_id()

Philippe Mathieu-Daudé writes: > Cc'ing Markus > > On 11/2/21 17:33, Stefan Hajnoczi wrote: >> Reported by Coverity (CID 1465222). >> >> Fixes: 4a1d937796de0fecd8b22d7dbebf87f38e8282fd ("softmmu/qdev-monitor: add >> error handling in qdev_set_id") >> Cc: Damien Hedde >> Cc: Kevin Wolf >> Cc:

[PATCH v3 2/2] vhost: Fix last vq queue index of devices with no cvq

The -1 assumes that last index counts all vhost device models as having two queues, but they count only the ones that models the data queues. Because of that, the right change in last_index is to actually add the cvq, not to remove the missing one. This is not a problem to vhost-net, but it is to

[PATCH v3 1/2] vhost: Rename last_index to last_vq_index

The doc of this field points out that last_index is the last vq index. Since last_index can cause confusion if seen out of context, renaming to last_vq_index, aligning with vq_index. Signed-off-by: Eugenio Pérez --- include/hw/virtio/vhost.h | 2 +- hw/net/vhost_net.c| 4 ++-- hw/virtio/

Re: [PATCH v3 2/3] hw/smbios: Use qapi for SmbiosEntryPointType

Eduardo Habkost writes: > This prepares for exposing the SMBIOS entry point type as a > machine property on x86. > > Based on a patch from Daniel P. Berrangé. > > Signed-off-by: Daniel P. Berrangé > Signed-off-by: Eduardo Habkost > --- [...] > diff --git a/qapi/machine.json b/qapi/machine.jso

Re: [PATCH v2 7/7] hw/arm: Add ID for NPCM7XX SMBus

Philippe Mathieu-Daudé writes: > +Markus/Eduardo > > On 11/1/21 18:33, Peter Maydell wrote: >> On Thu, 21 Oct 2021 at 19:40, Hao Wu wrote: >>> >>> The ID can be used to indicate SMBus modules when adding >>> dynamic devices to them. >>> >>> Signed-off-by: Hao Wu >>> --- >>> hw/arm/npcm7xx.c |

[PATCH] Fix virtio-net-pci* "vectors" compat

From: Eduardo Habkost hw_compat_5_2 has an issue: it affects only "virtio-net-pci" but not "virtio-net-pci-transitional" and "virtio-net-pci-non-transitional". The solution is to use the "virtio-net-pci-base" type in compat_props. Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1999141 S

[PATCH] hw/m68k: Fix typo in SPDX tag

Fix 'Identifer' -> 'Identifier' typo. Cc: Laurent Vivier Fixes: 8c6df16ff60 ("hw/char: add goldfish-tty") Fixes: 87855593903 ("hw/intc: add goldfish-pic") Fixes: 2fde99ee312 ("m68k: add an interrupt controller") Fixes: 0791bc02b8f ("m68k: add a system controller") Fixes: e1cecdca559 ("m68k: add V

Re: [PATCH v3 2/2] vhost: Fix last vq queue index of devices with no cvq

Eugenio Pérez wrote: > The -1 assumes that last index counts all vhost device models as having > two queues, but they count only the ones that models the data queues. > > Because of that, the right change in last_index is to actually add the > cvq, not to remove the missing one. > > This is not a

Re: [PATCH v3 1/2] vhost: Rename last_index to last_vq_index

Eugenio Pérez wrote: > The doc of this field points out that last_index is the last vq index. > Since last_index can cause confusion if seen out of context, renaming > to last_vq_index, aligning with vq_index. > > Signed-off-by: Eugenio Pérez Reviewed-by: Juan Quintela

Re: [PATCH v2 0/3] virtio: increase VIRTQUEUE_MAX_SIZE to 32k

On Mon, Nov 01, 2021 at 09:29:26PM +0100, Christian Schoenebeck wrote: > On Donnerstag, 28. Oktober 2021 11:00:48 CET Stefan Hajnoczi wrote: > > On Mon, Oct 25, 2021 at 05:03:25PM +0200, Christian Schoenebeck wrote: > > > On Montag, 25. Oktober 2021 12:30:41 CEST Stefan Hajnoczi wrote: > > > > On T

[PATCH v2] Fix virtio-net-pci* "vectors" compat

From: Eduardo Habkost hw_compat_5_2 has an issue: it affects only "virtio-net-pci" but not "virtio-net-pci-transitional" and "virtio-net-pci-non-transitional". The solution is to use the "virtio-net-pci-base" type in compat_props. Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1999141 S

Re: [PATCH] hw/arm/virt: Allow additions to the generated device tree

Peter Maydell writes: > On Mon, 27 Sept 2021 at 16:18, Simon Glass wrote: >> On Mon, 27 Sept 2021 at 02:48, Peter Maydell >> wrote: >> > So what is missing in the QEMU-provided DTB that it needs? >> >> Quite a lot. Here are some examples: >> >> U-Boot has limited pre-relocation memory so tri

Re: [PULL 00/10] Misc 20211102 patches

On 11/2/21 12:26 PM, Gerd Hoffmann wrote: The following changes since commit 8cb41fda78c7ebde0dd248c6afe1d336efb0de50: Merge remote-tracking branch 'remotes/philmd/tags/machine-20211101' into staging (2021-11-02 05:53:45 -0400) are available in the Git repository at: git://git.kraxel.or

Re: [PATCH 12/15] hw/nvme: Initialize capability structures for primary/secondary controllers

On Oct 7 18:24, Lukasz Maniak wrote: > From: Łukasz Gieryk > > With two new properties (sriov_max_vi_per_vf, sriov_max_vq_per_vf) one > can configure the maximum number of virtual queues and interrupts > assignable to a single virtual device. The primary and secondary > controller capability str

Re: [PATCH] migration: RDMA registrations interval optimization

* Zhiwei Jiang (elish.ji...@ucloud.cn) wrote: > RDMA migration very hard to complete when VM run mysql > benchmark on 1G host hugepage.I think the time between > ram_control_before_iterate(f, RAM_CONTROL_ROUND) and > after_iterate is too large when 1G host pagesize,so 1M > buffer size match with ml

Re: [PATCH 10/15] hw/nvme: Make max_ioqpairs and msix_qsize configurable in runtime

On Oct 21 15:40, Łukasz Gieryk wrote: > On Wed, Oct 20, 2021 at 09:06:06PM +0200, Klaus Jensen wrote: > > On Oct 7 18:24, Lukasz Maniak wrote: > > > From: Łukasz Gieryk > > > > > > The Nvme device defines two properties: max_ioqpairs, msix_qsize. Having > > > them as constants is problematic for

Re: [PATCH] hw/m68k: Fix typo in SPDX tag

On 11/3/21 6:53 AM, Philippe Mathieu-Daudé wrote: Fix 'Identifer' -> 'Identifier' typo. Cc: Laurent Vivier Fixes: 8c6df16ff60 ("hw/char: add goldfish-tty") Fixes: 87855593903 ("hw/intc: add goldfish-pic") Fixes: 2fde99ee312 ("m68k: add an interrupt controller") Fixes: 0791bc02b8f ("m68k: add a s

Re: more bogus meson warnings

On Wed, 3 Nov 2021 at 08:01, Paolo Bonzini wrote: > > On Tue, Nov 2, 2021 at 2:38 PM Peter Maydell wrote: > > I tried my static-system build config today; meson bogus > > complaints include: > > > > WARNING: Static library 'pulse' not found for dependency 'libpulse', > > may not be statically lin

Re: [PATCH v3 00/17] iotests: support zstd

02.11.2021 15:29, Kevin Wolf wrote: Am 17.09.2021 um 20:06 hat Vladimir Sementsov-Ogievskiy geschrieben: 17.09.2021 17:49, Hanna Reitz wrote: On 15.09.21 16:45, Hanna Reitz wrote: On 14.09.21 12:25, Vladimir Sementsov-Ogievskiy wrote: These series makes tests pass with     IMGOPTS='compress

Re: [PATCH] hw/m68k: Fix typo in SPDX tag

Le 03/11/2021 à 11:53, Philippe Mathieu-Daudé a écrit : Fix 'Identifer' -> 'Identifier' typo. Cc: Laurent Vivier Fixes: 8c6df16ff60 ("hw/char: add goldfish-tty") Fixes: 87855593903 ("hw/intc: add goldfish-pic") Fixes: 2fde99ee312 ("m68k: add an interrupt controller") Fixes: 0791bc02b8f ("m68k:

Re: [PATCH] hw/arm/virt: Allow additions to the generated device tree

Hi, Thanks Alex to patch me in. I'd like to present another perspective on the motivation as I can't really comment on the actual "how". On real Arm boards, firmware is often assembled into a FIP. That FIP can contain quite a good deal of things, including an NT_FW_CONFIG, NonTrusted_FirmWare_CO

[PATCH v3 0/3] qapi & doc: deprecate drive-backup

Hi all! See 03 commit message for details. 01-02 are preparation docs update. v3: wording fix-ups and improvements suggested by Kashyap v2: add a lot of documentation changes v1 was "[PATCH] qapi: deprecate drive-backup" Note, that this series lack deprecating drive-backup transaction action. T

[PATCH v3 1/3] docs/block-replication: use blockdev-backup

We are going to deprecate drive-backup, so don't mention it here. Moreover, blockdev-backup seems more correct in the context. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow --- docs/block-replication.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v3 3/3] qapi: deprecate drive-backup

Modern way is using blockdev-add + blockdev-backup, which provides a lot more control on how target is opened. As example of drive-backup problems consider the following: User of drive-backup expects that target will be opened in the same cache and aio mode as source. Corresponding logic is in dr

[PATCH v3 2/3] docs/interop/bitmaps: use blockdev-backup

We are going to deprecate drive-backup, so use modern interface here. In examples where target image creation is shown, show blockdev-add as well. If target creation omitted, omit blockdev-add as well. Reviewed-by: Kashyap Chamarthy Signed-off-by: Vladimir Sementsov-Ogievskiy --- docs/interop/b

Re: [PULL 00/18] HMP-to-QMP info command patches

On 11/2/21 1:56 PM, Daniel P. Berrangé wrote: The following changes since commit 91e8394415f9bc9cd81c02bfafe02012855d4f98: Merge remote-tracking branch 'remotes/juanquintela/tags/migration-20211031-pull-request' into staging (2021-11-02 10:07:27 -0400) are available in the Git repository a

Re: more bogus meson warnings

On 11/3/21 13:19, Peter Maydell wrote: This is not my experience. I find that: * test in configure: configure doesn't enable the thing * test in meson: meson produces a WARNING, but goes ahead anyway, and then the final link fails So, in general, you _already_ have an improvement over w

Re: [PATCH v4 5/5] block: Deprecate transaction type drive-backup

27.10.2021 08:22, Markus Armbruster wrote: John Snow writes: On Mon, Oct 25, 2021 at 12:24 AM Markus Armbruster wrote: Several moons ago, Vladimir posted Subject: [PATCH v2 3/3] qapi: deprecate drive-backup Date: Wed, 5 May 2021 16:58:03 +0300 Message-Id: <20210505135803.67

Re: [PATCH v4 5/5] block: Deprecate transaction type drive-backup

25.10.2021 07:24, Markus Armbruster wrote: Several moons ago, Vladimir posted Subject: [PATCH v2 3/3] qapi: deprecate drive-backup Date: Wed, 5 May 2021 16:58:03 +0300 Message-Id:<20210505135803.67896-4-vsement...@virtuozzo.com> https://lists.gnu.org/archive/html/qemu-devel/

Re: [PULL 28/30] Hexagon HVX (tests/tcg/hexagon) hvx_misc test

Taylor Simpson writes: >> -Original Message- >> From: Alex Bennée >> Sent: Tuesday, November 2, 2021 11:42 AM >> To: Taylor Simpson >> Cc: Richard Henderson ; Philippe Mathieu- >> Daudé ; qemu-devel@nongnu.org; >> peter.mayd...@linaro.org >> Subject: Re: [PULL 28/30] Hexagon HVX (test

Re: [PATCH v3 03/19] docs/devel: document expectations for QAPI data modelling for QMP

On Thu, Oct 28, 2021 at 04:24:31PM +0100, Daniel P. Berrangé wrote: > On Thu, Oct 28, 2021 at 04:31:40PM +0200, Markus Armbruster wrote: > > This clashes with my "[PATCH v2 0/9] Configurable policy for handling > > unstable interfaces", which replaces "you must give unstable stuff names > > startin

[PATCH v3 00/23] linux-user: Clean up siginfo_t handling

Changes from v2: * Rebase on master. - force_sig_fault is in, - force_sigsegv_for_addr is obviated by cpu_loop_exit_sigsegv, - openrisc RANGE and FPE exception abort are upstream. Patches lacking review: 07-linux-user-hppa-Set-FPE_CONDTRAP-for-COND.patch 15-target-mips-Extract-br

[PATCH v3 01/23] linux-user/alpha: Set TRAP_UNK for bugchk and unknown gentrap

These si_codes were changed in 535906c684fca, for linux 4.17. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- linux-user/syscall_defs.h | 1 + linux-user/alpha/cpu_loop.c | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/linux-user/syscall_defs.h b/linux

[PATCH v3 13/23] linux-user/mips: Improve do_break

Rename to do_tr_or_bp, as per the kernel function. Add a 'trap' argument, akin to the kernel's si_code, but clearer. The return value is always 0, so change the return value to void. Use force_sig and force_sig_fault. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- linu

[PATCH v3 04/23] linux-user/cris: Use force_sig_fault

Use the new function instead of setting up a target_siginfo_t and calling queue_signal. Fill in the missing PC for SIGTRAP. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- linux-user/cris/cpu_loop.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git

[PATCH v3 03/23] linux-user/alpha: Use force_sig_fault

Use the new function instead of setting up a target_siginfo_t and calling queue_signal. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- linux-user/alpha/cpu_loop.c | 61 - 1 file changed, 19 insertions(+), 42 deletions(-) diff --git a/linux-u

[PATCH v3 02/23] linux-user/alpha: Set FPE_FLTUNK for gentrap ROPRAND

This si_code was changed in 4cc13e4f6d441, for linux 4.17. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- linux-user/alpha/cpu_loop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/alpha/cpu_loop.c b/linux-user/alpha/cpu_loop.c index b039369198..

[PATCH v3 05/23] linux-user/hppa: Use force_sig_fault

Use the new function instead of setting up a target_siginfo_t and calling queue_signal. Fill in the missing PC for SIGTRAP and missing si_code for SIGBUS. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- linux-user/hppa/cpu_loop.c | 18 +++--- 1 file changed, 3 inser

Re: [PATCH 0/3] SEV: fixes for -kernel launch with incompatible OVMF

* Brijesh Singh (brijesh.si...@amd.com) wrote: > > > On 11/2/21 8:22 AM, Dov Murik wrote: > > > > > > On 02/11/2021 12:52, Brijesh Singh wrote: > > > Hi Dov, > > > > > > Overall the patch looks good, only question I have is that now we are > > > enforce qemu to hash the kernel, initrd and cmdl

[PATCH v3 07/23] linux-user/hppa: Set FPE_CONDTRAP for COND

This si_code was changed in 75abf64287cab, for linux 4.17. Signed-off-by: Richard Henderson --- linux-user/syscall_defs.h | 1 + linux-user/hppa/cpu_loop.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h index 55ccc6ae03..f9efbffe0c 1

[PATCH v3 06/23] linux-user/hppa: Use the proper si_code for PRIV_OPR, PRIV_REG, OVERFLOW

These si_codes have been properly set by the kernel since the beginning. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- linux-user/hppa/cpu_loop.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/linux-user/hppa/cpu_loop.c b/linux-user/hppa/cpu_loo

[PATCH v3 09/23] linux-user/i386: Use force_sig, force_sig_fault

Replace the local gen_signal with the generic functions that match how the kernel raises signals. Fill in the missing PC for SIGTRAP. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- linux-user/i386/cpu_loop.c | 47 +++--- 1 file changed, 18 insert

[PATCH v3 21/23] linux-user/sh4: Use force_sig_fault

Use the new function instead of setting up a target_siginfo_t and calling queue_signal. Fill in the missing PC for SIGTRAP. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- linux-user/sh4/cpu_loop.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/linux-us

[PATCH v3 12/23] linux-user/microblaze: Fix SIGFPE si_codes

Fix a typo for ESR_EC_DIVZERO, which is integral not floating-point. Fix the if ladder for decoding floating-point exceptions. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- linux-user/microblaze/cpu_loop.c | 20 +++- 1 file changed, 15 insertions(+), 5 deletion

[PATCH v3 16/23] target/mips: Extract trap code into env->error_code

Simplify cpu_loop by doing all of the decode in translate. Signed-off-by: Richard Henderson --- linux-user/mips/cpu_loop.c| 41 +-- target/mips/tcg/translate.c | 24 ++--- target/mips/tcg/micromips_translate.c.inc | 4 +-- target/mips/tc

[PATCH v3 08/23] linux-user/i386: Split out maybe_handle_vm86_trap

Reduce the number of ifdefs within cpu_loop(). Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- linux-user/i386/cpu_loop.c | 31 +++ 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/linux-user/i386/cpu_loop.c b/linux-user/i386/cpu_loop.c

[PATCH v3 22/23] linux-user/sparc: Use force_sig_fault

Use the new function instead of setting up a target_siginfo_t and calling queue_signal. Fill in the missing PC for SIGTRAP. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- linux-user/sparc/cpu_loop.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --g

[PATCH v3 10/23] linux-user/m68k: Use force_sig_fault

Use the new function instead of setting up a target_siginfo_t and calling queue_signal. Fill in the missing PC for SIGTRAP. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- linux-user/m68k/cpu_loop.c | 24 1 file changed, 4 insertions(+), 20 deletions(-)

[PATCH v3 15/23] target/mips: Extract break code into env->error_code

Simplify cpu_loop by doing all of the decode in translate. This fixes a bug in that cpu_loop was not handling the different layout of the R6 version of break16. This fixes a bug in that cpu_loop extracted the wrong bits for the mips16e break16 instruction. Signed-off-by: Richard Henderson ---

[PATCH v3 17/23] linux-user/openrisc: Use force_sig_fault

Use the new function instead of setting up a target_siginfo_t and calling queue_signal. Fill in the missing PC for SIGTRAP. Signed-off-by: Richard Henderson --- linux-user/openrisc/cpu_loop.c | 18 +++--- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/linux-user/openr

[PATCH v3 11/23] linux-user/microblaze: Use force_sig_fault

Use the new function instead of setting up a target_siginfo_t and calling queue_signal. Fill in the missing PC for SIGTRAP. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- linux-user/microblaze/cpu_loop.c | 61 +--- 1 file changed, 25 insertions(+), 3

[PATCH v3 14/23] linux-user/mips: Use force_sig_fault

Use the new function instead of setting up a target_siginfo_t and calling queue_signal. Fill in the missing PC for SIGTRAP and SIGFPE; use force_sig (SI_KERNEL) for EXCP_DSPDIS. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- linux-user/mips/cpu_loop.c | 38 +

[PATCH v3 18/23] linux-user/ppc: Use force_sig_fault

Use the new function instead of setting up a target_siginfo_t and calling queue_signal. Fill in the missing PC for SIGTRAP. The fault address for POWERPC_EXCP_ISI is nip exactly, not nip - 4. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- linux-user/ppc/cpu_loop.c | 136 ++

[PATCH v3 20/23] linux-user/s390x: Use force_sig_fault

Use the new function instead of setting up a target_siginfo_t and calling queue_signal. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- linux-user/s390x/cpu_loop.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/linux-user/s390x/cpu_loop.c b/linux-user/

  1   2   3   4   >