Re: [PATCH v2 3/5] qom: object_child_foreach_recursive_type()

2021-10-28 Thread David Hildenbrand
On 28.10.21 06:31, Peter Xu wrote: > Add this sister helper besides object_child_foreach_recursive() to loop over > child objects only if the object can be casted to a specific type. > > Suggested-by: Michael S. Tsirkin > Signed-off-by: Peter Xu > --- > include/qom/object.h | 20 +++

Re: [PATCH v2 4/5] pci: Add pci_for_each_root_bus()

2021-10-28 Thread David Hildenbrand
On 28.10.21 06:31, Peter Xu wrote: > Add a helper to loop over each root bus of the system, either the default root > bus or extended buses like pxb-pcie. > > There're three places that can be rewritten with the pci_for_each_root_bus() > helper that we just introduced. De-dup the code. > > Signe

Re: [PATCH v2 5/5] pc/q35: Add pre-plug hook for x86-iommu

2021-10-28 Thread David Hildenbrand
On 28.10.21 06:31, Peter Xu wrote: > Add a pre-plug hook for x86-iommu, so that we can detect vfio-pci devices > before realizing the vIOMMU device. > > When the guest contains both the x86 vIOMMU and vfio-pci devices, the user > needs to specify the x86 vIOMMU before the vfio-pci devices. The re

Re: [PATCH v8 0/8] hmp, qmp: Add commands to introspect virtio devices

2021-10-28 Thread Jonah Palmer
On 10/27/21 07:55, Daniel P. Berrangé wrote: On Wed, Oct 27, 2021 at 07:41:41AM -0400, Jonah Palmer wrote: This series introduces new QMP/HMP commands to dump the status of a virtio device at different levels. [Jonah: Rebasing previous patchset from Oct. 5 (v7). Original patches are from Lau

Re: [PATCH v8 5/8] qmp: decode feature & status bits in virtio-status

2021-10-28 Thread Jonah Palmer
On 10/27/21 08:18, Laurent Vivier wrote: On 27/10/2021 13:59, David Hildenbrand wrote: On 27.10.21 13:41, Jonah Palmer wrote: From: Laurent Vivier Display feature names instead of bitmaps for host, guest, and backend for VirtIODevice. Display status names instead of bitmaps for VirtIODevice.

Re: [PATCH v8 5/8] qmp: decode feature & status bits in virtio-status

2021-10-28 Thread David Hildenbrand
On 28.10.21 09:56, Jonah Palmer wrote: > On 10/27/21 08:18, Laurent Vivier wrote: >> On 27/10/2021 13:59, David Hildenbrand wrote: >>> On 27.10.21 13:41, Jonah Palmer wrote: From: Laurent Vivier Display feature names instead of bitmaps for host, guest, and backend for VirtIODev

Re: MMIO/PIO dispatch file descriptors (ioregionfd) design discussion

2021-10-28 Thread Stefan Hajnoczi
On Wed, Oct 27, 2021 at 01:22:28PM +0100, John Levon wrote: > On Wed, Oct 27, 2021 at 11:15:35AM +0100, Stefan Hajnoczi wrote: > > > > > I like this approach as well. > > > > As you have mentioned, the device emulation code with first approach > > > > does have to how to handle the region accesses

Re: [PATCH v2 5/5] pc/q35: Add pre-plug hook for x86-iommu

2021-10-28 Thread Peter Xu
On Thu, Oct 28, 2021 at 09:17:35AM +0200, David Hildenbrand wrote: > On 28.10.21 06:31, Peter Xu wrote: > > Add a pre-plug hook for x86-iommu, so that we can detect vfio-pci devices > > before realizing the vIOMMU device. > > > > When the guest contains both the x86 vIOMMU and vfio-pci devices, th

Re: [PATCH 00/16] fdt: Make OF_BOARD a boolean option

2021-10-28 Thread François Ozog
Hi Simon, Le jeu. 28 oct. 2021 à 04:51, Simon Glass a écrit : > Hi Ilias, > > On Tue, 26 Oct 2021 at 00:46, Ilias Apalodimas > wrote: > > > > Hi Simon, > > > > A bit late to the party, sorry! > > (Did you remember the beer? I am replying to this but I don't think it > is all that helpful for me

Re: [PULL 16/18] target/riscv: change the api for RVF/RVD fmin/fmax

2021-10-28 Thread Frank Chang
On Thu, Oct 28, 2021 at 12:45 PM Alistair Francis < alistair.fran...@opensource.wdc.com> wrote: > From: Chih-Min Chao > > The sNaN propagation behavior has been changed since > cd20cee7 in https://github.com/riscv/riscv-isa-manual. > > Signed-off-by: Chih-Min Chao > Signed-off-by: Frank Chang >

Re: [PATCH 1/9] qapi: New special feature flag "unstable"

2021-10-28 Thread Markus Armbruster
Kevin Wolf writes: > Am 26.10.2021 um 11:37 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Am 25.10.2021 um 07:25 hat Markus Armbruster geschrieben: >> >> By convention, names starting with "x-" are experimental. The parts >> >> of external interfaces so named may be withdraw

Re: [PATCH v4 1/2] sev/i386: Introduce sev_add_kernel_loader_hashes for measured linux boot

2021-10-28 Thread Dov Murik
On 27/10/2021 22:43, Brijesh Singh wrote: > Hi Dov, > > Sorry for coming a bit late on it but I am seeing another issue with > this patch. The hash build logic looks for a SEV_HASH_TABLE_RV_GUID in > the GUID list. If found, it uses the base address to store the hash'es. > Looking at the OVMF,

Re: [PATCH v2] vhost-vdpa: Set discarding of RAM broken when initializing the backend

2021-10-28 Thread Stefano Garzarella
On Wed, Oct 27, 2021 at 03:03:24PM +0200, David Hildenbrand wrote: Similar to VFIO, vDPA will go ahead an map+pin all guest memory. Memory that used to be discarded will get re-populated and if we discard+re-access memory after mapping+pinning, the pages mapped into the vDPA IOMMU will go out of

Re: [PATCH v2 0/3] virtio: increase VIRTQUEUE_MAX_SIZE to 32k

2021-10-28 Thread Stefan Hajnoczi
On Mon, Oct 25, 2021 at 05:03:25PM +0200, Christian Schoenebeck wrote: > On Montag, 25. Oktober 2021 12:30:41 CEST Stefan Hajnoczi wrote: > > On Thu, Oct 21, 2021 at 05:39:28PM +0200, Christian Schoenebeck wrote: > > > On Freitag, 8. Oktober 2021 18:08:48 CEST Christian Schoenebeck wrote: > > > > O

Re: [PATCH v8 0/8] hmp, qmp: Add commands to introspect virtio devices

2021-10-28 Thread Dr. David Alan Gilbert
* Jonah Palmer (jonah.pal...@oracle.com) wrote: > > On 10/27/21 07:55, Daniel P. Berrangé wrote: > > On Wed, Oct 27, 2021 at 07:41:41AM -0400, Jonah Palmer wrote: > > > This series introduces new QMP/HMP commands to dump the status of a > > > virtio device at different levels. > > > > > > [Jonah:

[PATCH V5 0/3] net/filter: Optimize filters vnet_hdr support

2021-10-28 Thread Zhang Chen
This series make filters and colo-compare module support vnet_hdr by default. And also support -device non-virtio-net(like e1000.) at the same time. It can adapt -device automatically to avoid wrong setting between different filters when enable/disable virtio-net-pci. Optimize the filter transfer

[PATCH V5 1/3] net/filter: Optimize transfer protocol for filter-mirror/redirector

2021-10-28 Thread Zhang Chen
Make the vnet header a necessary part of filter transfer protocol. It make other modules(like another filter-redirector,colo-compare...) know how to parse net packet correctly. If local device is not the virtio-net-pci, vnet_hdr_len will be 0. Signed-off-by: Zhang Chen --- net/filter-mirror.c |

[PATCH V5 2/3] net/filter: Optimize transfer protocol for filter-rewriter

2021-10-28 Thread Zhang Chen
Make the vnet header a necessary part of filter transfer protocol. Signed-off-by: Zhang Chen --- net/filter-rewriter.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/net/filter-rewriter.c b/net/filter-rewriter.c index cb3a96cde1..70fa71583a 100644 --- a/net/filter-rewr

[PATCH V5 3/3] net/colo-compare.c: Optimize transfer protocol for colo-compare

2021-10-28 Thread Zhang Chen
Enable vnet_hdr in payload by default. Make it easier to find module communication configuration errors. Signed-off-by: Zhang Chen --- net/colo-compare.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/net/colo-compare.c b/net/colo-compare.c index b1

Re: [PATCH v5 2/8] python/machine: Handle QMP errors on close more meticulously

2021-10-28 Thread Kevin Wolf
Am 27.10.2021 um 19:49 hat John Snow geschrieben: > This reply is long, sorry. And after writing half of a very long reply myself, I noticed that I was just very confused, so sorry for making you write a long text for no real reason (well, at least for my first point - for the second one, your exp

Re: [PATCH v2 2/4] qemu-img: make --block-size optional for compare --stat

2021-10-28 Thread Vladimir Sementsov-Ogievskiy
26.10.2021 11:07, Hanna Reitz wrote: On 21.10.21 12:12, Vladimir Sementsov-Ogievskiy wrote: Let's detect block-size automatically if not specified by user:   If both files define cluster-size, use minimum to be more precise.   If both files don't specify cluster-size, use default of 64K   If on

[PATCH v3 3/4] qemu-img: add --shallow option for qemu-img compare

2021-10-28 Thread Vladimir Sementsov-Ogievskiy
Allow compare only top images of backing chains. This is useful to compare images with same backing file or to compare incremental images from the chain of incremental backups with "--stat" option. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Hanna Reitz --- docs/tools/qemu-img.rst

[PATCH v2 7/9] qapi: Generalize enum member policy checking

2021-10-28 Thread Markus Armbruster
The code to check enumeration value policy can see special feature flag 'deprecated' in QEnumLookup member flags[value]. I want to make feature flag 'unstable' visible there as well, so I can add policy for it. Instead of extending flags[], replace it by @special_features (a bitset of QapiSpecial

[PATCH v3 1/4] qemu-img: implement compare --stat

2021-10-28 Thread Vladimir Sementsov-Ogievskiy
With new option qemu-img compare will not stop at first mismatch, but instead calculate statistics: how many clusters with different data, how many clusters with equal data, how many clusters were unallocated but become data and so on. We compare images chunk by chunk. Chunk size depends on what b

[PATCH v2 6/9] qapi: Generalize command policy checking

2021-10-28 Thread Markus Armbruster
The code to check command policy can see special feature flag 'deprecated' as command flag QCO_DEPRECATED. I want to make feature flag 'unstable' visible there as well, so I can add policy for it. To let me make it visible, add member @special_features (a bitset of QapiSpecialFeature) to QmpComma

[PATCH v3 0/4] qemu-img compare --stat

2021-10-28 Thread Vladimir Sementsov-Ogievskiy
Hi all! Recently we faced the following task: Customer comes and say: incremental backup images are too fat. Does you incremental backup works correct? What to answer? We should check something. At least check that incremental images doesn't store same data twice. And we don't have a tool for it

[PATCH v2 9/9] qapi: Extend -compat to set policy for unstable interfaces

2021-10-28 Thread Markus Armbruster
New option parameters unstable-input and unstable-output set policy for unstable interfaces just like deprecated-input and deprecated-output set policy for deprecated interfaces (see commit 6dd75472d5 "qemu-options: New -compat to set policy for deprecated interfaces"). This is intended for testin

[PATCH v3 4/4] iotests: add qemu-img-compare-stat test

2021-10-28 Thread Vladimir Sementsov-Ogievskiy
Test new feature qemu-img compare --stat. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Hanna Reitz --- .../qemu-iotests/tests/qemu-img-compare-stat | 88 +++ .../tests/qemu-img-compare-stat.out | 106 ++ 2 files changed, 194 insertions(+) cre

[PATCH v3 2/4] qemu-img: make --block-size optional for compare --stat

2021-10-28 Thread Vladimir Sementsov-Ogievskiy
Let's detect block-size automatically if not specified by user: If both files define cluster-size, use minimum to be more precise. If both files don't specify cluster-size, use default of 64K If only one file specify cluster-size, just use it. Signed-off-by: Vladimir Sementsov-Ogievskiy ---

[PATCH v2 4/9] qapi: Tools for sets of special feature flags in generated code

2021-10-28 Thread Markus Armbruster
New enum QapiSpecialFeature enumerates the special feature flags. New helper gen_special_features() returns code to represent a collection of special feature flags as a bitset. The next few commits will put them to use. Signed-off-by: Markus Armbruster Reviewed-by: John Snow --- include/qapi/

[PATCH v2 8/9] qapi: Factor out compat_policy_input_ok()

2021-10-28 Thread Markus Armbruster
The code to check policy for handling deprecated input is triplicated. Factor it out into compat_policy_input_ok() before I mess with it in the next commit. Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé --- include/qapi/compat-policy.h | 7 + qapi/qapi-visit-core.c

[PATCH v2 3/9] qapi: Eliminate QCO_NO_OPTIONS for a slight simplification

2021-10-28 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Juan Quintela Reviewed-by: John Snow --- include/qapi/qmp/dispatch.h | 1 - monitor/misc.c | 3 +-- scripts/qapi/commands.py| 5 + 3 files changed, 2 insertions(+), 7 deletions(-) diff --git a/include/qapi/qmp/dispatch.h b/incl

Re: [PATCH v2 11/15] iotests: split linters.py out from 297

2021-10-28 Thread Hanna Reitz
On 26.10.21 20:30, John Snow wrote: On Tue, Oct 26, 2021 at 6:51 AM Hanna Reitz wrote: On 19.10.21 16:49, John Snow wrote: > Now, 297 is just the iotests-specific incantations and linters.py is as > minimal as I can think to make it. The only remaining element in here

[PATCH v2 5/9] qapi: Generalize struct member policy checking

2021-10-28 Thread Markus Armbruster
The generated visitor functions call visit_deprecated_accept() and visit_deprecated() when visiting a struct member with special feature flag 'deprecated'. This makes the feature flag visible to the actual visitors. I want to make feature flag 'unstable' visible there as well, so I can add policy

[PATCH v2 1/9] qapi: New special feature flag "unstable"

2021-10-28 Thread Markus Armbruster
By convention, names starting with "x-" are experimental. The parts of external interfaces so named may be withdrawn or changed incompatibly in future releases. The naming convention makes unstable interfaces easy to recognize. Promoting something from experimental to stable involves a name chang

[PATCH v2 2/9] qapi: Mark unstable QMP parts with feature 'unstable'

2021-10-28 Thread Markus Armbruster
Add special feature 'unstable' everywhere the name starts with 'x-', except for InputBarrierProperties member x-origin and MemoryBackendProperties member x-use-canonical-path-for-ramblock-id, because these two are actually stable. Signed-off-by: Markus Armbruster Reviewed-by: Juan Quintela Acked

[PATCH v2 0/9] Configurable policy for handling unstable interfaces

2021-10-28 Thread Markus Armbruster
Option -compat lets you configure what to do when deprecated interfaces get used. This series extends this to unstable interfaces. Works the same way. Intended for testing users of the management interfaces. It is experimental. To make it possible, I replace the "x-" naming convention by specia

Re: [PATCH v2 12/15] iotests/linters: Add entry point for linting via Python CI

2021-10-28 Thread Hanna Reitz
On 26.10.21 21:45, John Snow wrote: On Tue, Oct 26, 2021 at 2:36 PM John Snow wrote: On Tue, Oct 26, 2021 at 6:57 AM Hanna Reitz wrote: On 19.10.21 16:49, John Snow wrote: > We need at least a tiny little shim here to join test file discovery > with tes

Re: [PATCH v5 0/8] Switch iotests to using Async QMP

2021-10-28 Thread Kevin Wolf
Am 26.10.2021 um 19:56 hat John Snow geschrieben: > GitLab: https://gitlab.com/jsnow/qemu/-/commits/python-aqmp-iotest-wrapper > CI: https://gitlab.com/jsnow/qemu/-/pipelines/395925703 > > Hiya, > > This series continues where the last two AQMP series left off and adds a > synchronous 'legacy' wr

Re: [PATCH v2 10/32] target/mips: Convert MSA BIT instruction format to decodetree

2021-10-28 Thread Philippe Mathieu-Daudé
On 10/27/21 23:20, Richard Henderson wrote: > On 10/27/21 11:07 AM, Philippe Mathieu-Daudé wrote: >> +static bool trans_msa_bit(DisasContext *ctx, arg_msa_bit *a, >> +  gen_helper_p *gen_msa_bit) >>  { >> +    if (a->df < 0) { >> +    return false; >> } > > Thi

Re: [PULL 16/18] target/riscv: change the api for RVF/RVD fmin/fmax

2021-10-28 Thread Alistair Francis
On Thu, Oct 28, 2021 at 6:22 PM Frank Chang wrote: > > On Thu, Oct 28, 2021 at 12:45 PM Alistair Francis > wrote: >> >> From: Chih-Min Chao >> >> The sNaN propagation behavior has been changed since >> cd20cee7 in https://github.com/riscv/riscv-isa-manual. >> >> Signed-off-by: Chih-Min Chao >>

Re: [PATCH v2] hw/arm/virt: Expose empty NUMA nodes through ACPI

2021-10-28 Thread Gavin Shan
On 10/28/21 2:40 AM, Igor Mammedov wrote: On Wed, 27 Oct 2021 13:29:58 +0800 Gavin Shan wrote: The empty NUMA nodes, where no memory resides, aren't exposed through ACPI SRAT table. It's not user preferred behaviour because the corresponding memory node devices are missed from the guest kernel

Re: [PATCH v2 11/32] target/mips: Convert MSA SHF opcode to decodetree

2021-10-28 Thread Philippe Mathieu-Daudé
On Wed, Oct 27, 2021 at 11:21 PM Richard Henderson wrote: > On 10/27/21 11:07 AM, Philippe Mathieu-Daudé wrote: > > +static bool trans_SHF(DisasContext *ctx, arg_msa_i8 *a) > > +{ > > +if (a->df == DF_DOUBLE) { > > +gen_reserved_instruction(ctx); > > +return true; > > +} >

[PATCH 3/4] softmmu: fix for "after access" watchpoints

2021-10-28 Thread Pavel Dovgalyuk
Watchpoints that should fire after the memory access break an execution of the current block, try to translate current instruction into the separate block, which then causes debug interrupt. But cpu_interrupt can't be called in such block when icount is enabled, because interrupts muse be allowed e

[PATCH 4/4] icount: preserve cflags when custom tb is about to execute

2021-10-28 Thread Pavel Dovgalyuk
When debugging with the watchpoints, qemu may need to create TB with single instruction. This is achieved by setting cpu->cflags_next_tb. But when this block is about to execute, it may be interrupted by another thread. In this case cflags will be lost and next executed TB will not be the special o

[PATCH 1/4] softmmu: fix watchpoint processing in icount mode

2021-10-28 Thread Pavel Dovgalyuk
Watchpoint processing code restores vCPU state twice: in tb_check_watchpoint and in cpu_loop_exit_restore/cpu_restore_state. Normally it does not affect anything, but in icount mode instruction counter is incremented twice and becomes incorrect. This patch eliminates unneeded CPU state restore. Si

Re: [PATCH v3 0/2] hw/core/machine: Add an unit test for smp_parse

2021-10-28 Thread wangyanan (Y)
Hi, Does this short series have a chance to get on the train for 6.2 before the closely coming soft-feature freeze? It would be very nice to have a test finally, since all the previous work on -smp code has been completed and merged, IMO. 😉 Regards, Yanan On 2021/10/26 11:46, Yanan Wang wrote:

[PATCH 0/4] Some watchpoint-related patches

2021-10-28 Thread Pavel Dovgalyuk
The series includes several watchpoint-related patches. --- Pavel Dovgalyuk (4): softmmu: fix watchpoint processing in icount mode softmmu: remove useless condition in watchpoint check softmmu: fix for "after access" watchpoints icount: preserve cflags when custom tb is ab

[PATCH 2/4] softmmu: remove useless condition in watchpoint check

2021-10-28 Thread Pavel Dovgalyuk
cpu_check_watchpoint function checks cpu->watchpoint_hit at the entry. But then it also does the same in the middle of the function, while this field can't change. That is why this patch removes this useless condition. Signed-off-by: Pavel Dovgalyuk --- softmmu/physmem.c | 41 +

Re: [PULL 0/8] 9p queue 2021-10-27

2021-10-28 Thread Christian Schoenebeck
On Mittwoch, 27. Oktober 2021 20:44:52 CEST Richard Henderson wrote: > On 10/27/21 10:29 AM, Christian Schoenebeck wrote: > > On Mittwoch, 27. Oktober 2021 18:48:10 CEST Philippe Mathieu-Daudé wrote: > >> On 10/27/21 18:21, Christian Schoenebeck wrote: > >>> On Mittwoch, 27. Oktober 2021 17:36:03 C

Re: Deprecate the ppc405 boards in QEMU? (was: [PATCH v3 4/7] MAINTAINERS: Orphan obscure ppc platforms)

2021-10-28 Thread Luis Machado
On 10/20/21 10:16 AM, LEROY Christophe wrote: Le 20/10/2021 à 14:43, Cédric Le Goater a écrit : On 10/20/21 13:42, BALATON Zoltan wrote: On Wed, 20 Oct 2021, Philippe Mathieu-Daudé wrote: On 10/5/21 14:29, Thomas Huth wrote: On 05/10/2021 14.20, BALATON Zoltan wrote: On Tue, 5 Oct 2021,

Re: [RFC PATCH v2] hw/nvme:Adding Support for namespace management

2021-10-28 Thread Lukasz Maniak
On Thu, Aug 19, 2021 at 06:39:57PM +0530, Naveen Nagar wrote: > From: Naveen > > This patch supports namespace management : create and delete operations. > > Since v1: > - Modified and moved nvme_ns_identify_common in ns.c file > - Added check for CSI field in NS management > - Indentation fix

Re: [PATCH v5 1/2] vhost-user: fix VirtQ notifier cleanup

2021-10-28 Thread Xueming(Steven) Li
On Tue, 2021-10-19 at 06:52 -0400, Michael S. Tsirkin wrote: > On Tue, Oct 19, 2021 at 03:57:42PM +0800, Xueming Li wrote: > > When vhost-user device cleanup and unmmap notifier address, VM cpu > > you mean cleanup is executed and un-mmaps ... > > > thread that writing the notifier failed > > th

Re: [PATCH v2 18/32] target/mips: Convert MSA 3RF instruction format to decodetree (DF_HALF)

2021-10-28 Thread Philippe Mathieu-Daudé
On 10/27/21 23:53, Richard Henderson wrote: > On 10/27/21 11:07 AM, Philippe Mathieu-Daudé wrote: >> +@3rf    .. df:1 wt:5ws:5  wd:5 ..  &msa_r > > Add DF_HALF to df during decode? Yet another tip, thanks :)

Re: [PATCH v2 21/32] target/mips: Convert MSA 3R instruction format to decodetree (part 2/4)

2021-10-28 Thread Philippe Mathieu-Daudé
On 10/28/21 00:02, Richard Henderson wrote: > On 10/27/21 11:07 AM, Philippe Mathieu-Daudé wrote: >> Convert 3-register operations to decodetree. >> >> Per the Encoding of Operation Field for 3R Instruction Format' >> (Table 3.25), these instructions are not defined for the BYTE >> format. Therefor

Re: [PULL 16/18] target/riscv: change the api for RVF/RVD fmin/fmax

2021-10-28 Thread Richard Henderson
On 10/28/21 4:30 AM, Alistair Francis wrote: On Thu, Oct 28, 2021 at 6:22 PM Frank Chang wrote: On Thu, Oct 28, 2021 at 12:45 PM Alistair Francis wrote: From: Chih-Min Chao The sNaN propagation behavior has been changed since cd20cee7 in https://github.com/riscv/riscv-isa-manual. Signed

[PATCH 0/2] Replace custom test harness with "meson test"

2021-10-28 Thread Paolo Bonzini
Hi all, Starting with Meson 0.57, "meson test" has all features of QEMU's makefile-based harness and more. In particular, some features that were added to reach feature parity are: * print reproducer command line for each failed test right below the test * keep the output of multiple (non-TAP)

[PATCH 2/2] build: use "meson test" as the test harness

2021-10-28 Thread Paolo Bonzini
"meson test" starting with version 0.57 is just as capable and easy to use as QEMU's own TAP driver. All existing options for "make check" work. The only required code change involves how to mark "slow" tests. The rules for .tap output are replaced by JUnit XML; GitLab is able to parse that outp

[PATCH 1/2] meson: bump submodule to 0.59.3

2021-10-28 Thread Paolo Bonzini
This gains some bugfixes, especially: - it fixes the introspection of array options. While technically we still support Meson 0.58.2, this issue only appears when adding a new option and not if the user is just building QEMU. In the relatively rare case of a contributor using --meson to point to

Re: [PATCH v3 03/19] docs/devel: document expectations for QAPI data modelling for QMP

2021-10-28 Thread Markus Armbruster
This clashes with my "[PATCH v2 0/9] Configurable policy for handling unstable interfaces", which replaces "you must give unstable stuff names starting with 'x-'" by "you must give unstable stuff feature flag 'unstable' (and may give it a name starting with 'x-')".

Re: [PATCH 00/16] fdt: Make OF_BOARD a boolean option

2021-10-28 Thread Simon Glass
Hi François, On Thu, 28 Oct 2021 at 02:21, François Ozog wrote: > > Hi Simon, > > Le jeu. 28 oct. 2021 à 04:51, Simon Glass a écrit : >> >> Hi Ilias, >> >> On Tue, 26 Oct 2021 at 00:46, Ilias Apalodimas >> wrote: >> > >> > Hi Simon, >> > >> > A bit late to the party, sorry! >> >> (Did you remem

Re: [PATCH] nbd/server: Advertise MULTI_CONN for shared writable exports

2021-10-28 Thread Kevin Wolf
Am 27.08.2021 um 17:09 hat Eric Blake geschrieben: > According to the NBD spec, a server advertising > NBD_FLAG_CAN_MULTI_CONN promises that multiple client connections will > not see any cache inconsistencies: when properly separated by a single > flush, actions performed by one client will be vis

Re: [PATCH 00/16] fdt: Make OF_BOARD a boolean option

2021-10-28 Thread Tom Rini
On Thu, Oct 28, 2021 at 12:00:44AM +0200, François Ozog wrote: > Hi Tom > > Le mer. 27 oct. 2021 à 21:06, Tom Rini a écrit : > > > On Wed, Oct 27, 2021 at 06:02:19PM +0200, François Ozog wrote: > > > Hi Mark, > > > > > > On Wed, 27 Oct 2021 at 17:10, Mark Kettenis > > wrote: > > > > > > > > Fro

Re: [PATCH v3 0/2] hw/core/machine: Add an unit test for smp_parse

2021-10-28 Thread Philippe Mathieu-Daudé
On 10/26/21 05:46, Yanan Wang wrote: > Hi, > > This is v3 which introduces an unit test for generic smp_parse. > > We have had enough discussions about what kind of SMP configurations > by the user should be considered valid and what should be invalid. > Since we have finished optimizing the SMP

Re: [PATCH v3 04/19] docs/devel: add example of command returning unstructured text

2021-10-28 Thread Markus Armbruster
Daniel P. Berrangé writes: > This illustrates how to add a QMP command returning unstructured text, > following the guidelines added in the previous patch. The example uses > a simplified version of 'info roms'. > > Signed-off-by: Daniel P. Berrangé > --- > docs/devel/writing-monitor-commands.r

Re: [PATCH v3 05/19] docs/devel: document expectations for HMP commands in the future

2021-10-28 Thread Markus Armbruster
Daniel P. Berrangé writes: > We no longer wish to have commands implemented in HMP only. All commands > should start with a QMP implementation and the HMP merely be a shim > around this. To reduce the burden of implementing QMP commands where > there is low expectation of machine usage, requireme

Re: [PATCH v5 0/8] Switch iotests to using Async QMP

2021-10-28 Thread John Snow
On Thu, Oct 28, 2021 at 6:37 AM Kevin Wolf wrote: > Am 26.10.2021 um 19:56 hat John Snow geschrieben: > > GitLab: > https://gitlab.com/jsnow/qemu/-/commits/python-aqmp-iotest-wrapper > > CI: https://gitlab.com/jsnow/qemu/-/pipelines/395925703 > > > > Hiya, > > > > This series continues where the

Re: [PATCH 00/16] fdt: Make OF_BOARD a boolean option

2021-10-28 Thread François Ozog
Hi Simon Le jeu. 28 oct. 2021 à 16:30, Simon Glass a écrit : > Hi François, > > On Thu, 28 Oct 2021 at 02:21, François Ozog > wrote: > > > > Hi Simon, > > > > Le jeu. 28 oct. 2021 à 04:51, Simon Glass a écrit : > >> > >> Hi Ilias, > >> > >> On Tue, 26 Oct 2021 at 00:46, Ilias Apalodimas > >>

Possible reward for fuzzer bug fixes? Secure Open Source Rewards Program

2021-10-28 Thread Alexander Bulekov
Recently a pilot for the Secure Open Source Rewards program was announced [1]. Currently this program is run by the Linux Foundation and sponsored by the Google Open Source Security Team. The page mentions that patches for issues discovered by OSS-Fuzz may be eligible for rewards. This seems like

Re: [PULL 00/56] tcg patch queue

2021-10-28 Thread Richard Henderson
On 10/27/21 7:40 PM, Richard Henderson wrote: The following changes since commit c52d69e7dbaaed0ffdef8125e79218672c30161d: Merge remote-tracking branch 'remotes/cschoenebeck/tags/pull-9p-20211027' into staging (2021-10-27 11:45:18 -0700) are available in the Git repository at: https://g

Re: [PATCH v2 5/5] pc/q35: Add pre-plug hook for x86-iommu

2021-10-28 Thread Alex Williamson
On Thu, 28 Oct 2021 12:31:29 +0800 Peter Xu wrote: > Add a pre-plug hook for x86-iommu, so that we can detect vfio-pci devices > before realizing the vIOMMU device. > > When the guest contains both the x86 vIOMMU and vfio-pci devices, the user > needs to specify the x86 vIOMMU before the vfio-pc

[PATCH 0/4] hw/core: Restrict qdev-hotplug to sysemu

2021-10-28 Thread Philippe Mathieu-Daudé
Restrict various hw/core/ files to sysemu, add stubs for qdev-hotplug. Philippe Mathieu-Daudé (4): hw/core: Restrict sysemu specific files hw/core: Declare meson source set hw/core: Extract hotplug-related functions to qdev-hotplug.c hw/core: Restrict hotplug to system emulation meson.bu

[PATCH 4/4] hw/core: Restrict hotplug to system emulation

2021-10-28 Thread Philippe Mathieu-Daudé
Restrict hotplug to system emulation, add stubs for the other uses. Signed-off-by: Philippe Mathieu-Daudé --- hw/core/hotplug-stubs.c | 34 ++ hw/core/meson.build | 12 ++-- 2 files changed, 44 insertions(+), 2 deletions(-) create mode 100644 hw/core/

[PATCH 3/4] hw/core: Extract hotplug-related functions to qdev-hotplug.c

2021-10-28 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/core/qdev-hotplug.c | 73 ++ hw/core/qdev.c | 60 -- hw/core/meson.build| 1 + 3 files changed, 74 insertions(+), 60 deletions(-) create mode 100644 hw/core/qdev-hotp

Re: [PATCH 03/24] bsd-user/arm/target_arch_cpu.c: Target specific TLS routines

2021-10-28 Thread Richard Henderson
On 10/19/21 9:44 AM, Warner Losh wrote: Target specific TLS routines to get and set the TLS values. Signed-off-by: Klye Evans Signed-off-by: Stacey Son Signed-off-by: Warner Losh --- bsd-user/arm/target_arch.h | 28 bsd-user/arm/target_arch_cpu.c | 39

[PATCH v4 0/2] hw/core/machine: Add an unit test for smp_parse

2021-10-28 Thread Philippe Mathieu-Daudé
Respin of Yanan Wang v3, based on "hw/core: Restrict qdev-hotplug to sysemu" Based-on: 20211028150521.1973821-1-phi...@redhat.com https://lore.kernel.org/qemu-devel/20211028150521.1973821-1-phi...@redhat.com git-backport-diff: Key: [] : patches are identical [] : number of functional diff

Re: [PATCH 02/24] bsd-user/arm/target_syscall.h: Add copyright and update name

2021-10-28 Thread Richard Henderson
On 10/19/21 9:44 AM, Warner Losh wrote: The preferred name for the 32-bit arm is now armv7. Update the name to reflect that. In addition, add Stacey's copyright to this file and update the include guards to the new convention. Signed-off-by: Stacey Son Signed-off-by: Warner Losh --- bsd-user/a

[PATCH 1/4] hw/core: Restrict sysemu specific files

2021-10-28 Thread Philippe Mathieu-Daudé
All these files don't make sense for tools and user emulation, restrict them to system emulation. Signed-off-by: Philippe Mathieu-Daudé --- hw/core/meson.build | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/hw/core/meson.build b/hw/core/meson.build index 1

[PATCH 2/4] hw/core: Declare meson source set

2021-10-28 Thread Philippe Mathieu-Daudé
As we want to be able to conditionally add files to the hw/core file list, use a source set. Signed-off-by: Philippe Mathieu-Daudé --- meson.build | 4 +++- hw/core/meson.build | 4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/meson.build b/meson.build index 2c5b53

[PATCH v4 1/2] hw/core/machine: Split out the smp parsing code

2021-10-28 Thread Philippe Mathieu-Daudé
From: Yanan Wang We are going to introduce an unit test for the parser smp_parse() in hw/core/machine.c, but now machine.c is only built in softmmu. In order to solve the build dependency on the smp parsing code and avoid building unrelated stuff for the unit tests, move the tested code from mac

Re: [PATCH 04/24] bsd-user/arm/target_arch_cpu.h: CPU Loop definitions

2021-10-28 Thread Richard Henderson
On 10/19/21 9:44 AM, Warner Losh wrote: +cpsr_write(env, regs->uregs[16], 0x, CPSRWriteRaw); This looks a bit suspicious. Over in linux-user we use cpsr_write(env, regs->uregs[16], CPSR_USER | CPSR_EXEC, CPSRWriteByInstr); Are you setting something special in pt

Re: [PATCH 01/24] bsd-user/arm/target_arch_sysarch.h: Use consistent include guards

2021-10-28 Thread Richard Henderson
On 10/19/21 9:44 AM, Warner Losh wrote: As part of upstreaming, the include guards have been made more consistent. Update this file to use the new guards. Signed-off-by: Warner Losh --- bsd-user/arm/target_arch_sysarch.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-b

Re: [PATCH 05/24] bsd-user/arm/target_arch_cpu.h: Implement target_cpu_clone_regs

2021-10-28 Thread Richard Henderson
On 10/19/21 9:44 AM, Warner Losh wrote: Implement target_cpu_clone_regs to clone the resister state on a fork. Signed-off-by: Stacey Son Signed-off-by: Warner Losh --- bsd-user/arm/target_arch_cpu.h | 8 1 file changed, 8 insertions(+) Reviewed-by: Richard Henderson r~

[PATCH v4 2/2] tests/unit: Add an unit test for smp parsing

2021-10-28 Thread Philippe Mathieu-Daudé
From: Yanan Wang Now that we have a generic parser smp_parse(), let's add an unit test for the code. All possible valid/invalid SMP configurations that the user can specify are covered. Signed-off-by: Yanan Wang Reviewed-by: Andrew Jones Tested-by: Philippe Mathieu-Daudé Message-Id: <20211026

Re: [PATCH 06/24] bsd-user/arm/target_arch_cpu.h: Dummy target_cpu_loop implementation

2021-10-28 Thread Richard Henderson
On 10/19/21 9:44 AM, Warner Losh wrote: Add a boiler plate CPU loop that does nothing except return an error for all traps. Signed-off-by: Sean Bruno Signed-off-by: Stacey Son Signed-off-by: Warner Losh --- bsd-user/arm/target_arch_cpu.h | 22 ++ 1 file changed, 22 inserti

Re: [PATCH v3] migration/rdma: Fix out of order wrid

2021-10-28 Thread Dr. David Alan Gilbert
* Li Zhijian (lizhij...@cn.fujitsu.com) wrote: Apologies for taking so long. > destination: > ../qemu/build/qemu-system-x86_64 -enable-kvm -netdev > tap,id=hn0,script=/etc/qemu-ifup,downscript=/etc/qemu-ifdown -device > e1000,netdev=hn0,mac=50:52:54:00:11:22 -boot c -drive > if=none,file=./Fed

Re: [PATCH 07/24] bsd-user/arm/target_arch_cpu.h: Implment trivial EXCP exceptions

2021-10-28 Thread Richard Henderson
On 10/19/21 9:44 AM, Warner Losh wrote: +case EXCP_DEBUG: +{ + +info.si_signo = TARGET_SIGTRAP; +info.si_errno = 0; +info.si_code = TARGET_TRAP_BRKPT; +queue_signal(env, info.si_signo, &info); +} Usu

Re: [PATCH v3 03/19] docs/devel: document expectations for QAPI data modelling for QMP

2021-10-28 Thread Daniel P . Berrangé
On Thu, Oct 28, 2021 at 04:31:40PM +0200, Markus Armbruster wrote: > This clashes with my "[PATCH v2 0/9] Configurable policy for handling > unstable interfaces", which replaces "you must give unstable stuff names > starting with 'x-'" by "you must give unstable stuff feature flag > 'unstable' (and

Re: [PATCH 08/24] bsd-user/arm/target_arch_cpu.h: Implement data abort exceptions

2021-10-28 Thread Richard Henderson
On 10/19/21 9:44 AM, Warner Losh wrote: Implement EXCP_PREFETCH_ABORT AND EXCP_DATA_ABORT. Both of these data exceptions cause a SIGSEGV. Signed-off-by: Klye Evans Signed-off-by: Olivier Houchard Signed-off-by: Stacey Son Signed-off-by: Warner Losh --- bsd-user/arm/target_arch_cpu.h | 11 +

Re: [PATCH v3 04/19] docs/devel: add example of command returning unstructured text

2021-10-28 Thread Daniel P . Berrangé
On Thu, Oct 28, 2021 at 04:47:14PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > This illustrates how to add a QMP command returning unstructured text, > > following the guidelines added in the previous patch. The example uses > > a simplified version of 'info roms'. > > > >

Re: [PATCH 09/24] bsd-user/arm/target_arch_cpu.h: Implement system call dispatch

2021-10-28 Thread Richard Henderson
On 10/19/21 9:44 AM, Warner Losh wrote: +env->eabi = 1; /* FreeBSD is eabi only now */ Surely this should be set target_cpu_init. Even then it'd be just for completeness. This is the kind of thing that shouldn't have escaped linux-user, as it's otherwise unused. Otherwise,

Re: [PATCH v5 2/8] python/machine: Handle QMP errors on close more meticulously

2021-10-28 Thread John Snow
On Thu, Oct 28, 2021, 6:01 AM Kevin Wolf wrote: > Am 27.10.2021 um 19:49 hat John Snow geschrieben: > > This reply is long, sorry. > > And after writing half of a very long reply myself, I noticed that I was > just very confused, so sorry for making you write a long text for no > real reason (wel

Re: [PATCH v2 5/5] pc/q35: Add pre-plug hook for x86-iommu

2021-10-28 Thread Peter Xu
On Thu, Oct 28, 2021 at 08:52:42AM -0600, Alex Williamson wrote: > > +void x86_iommu_pre_plug(X86IOMMUState *iommu, Error **errp) > > +{ > > +bool ambiguous = false; > > +Object *object; > > + > > +object = object_resolve_path_type("", TYPE_VFIO_PCI, &ambiguous); > > +if (object ||

Re: [PATCH 11/24] bsd-user/arm/target_arch_vmparam.h: Parameters for arm address space

2021-10-28 Thread Richard Henderson
On 10/19/21 9:44 AM, Warner Losh wrote: Various parameters describing the layout of the ARM address space. In addition, define routines to get the stack pointer and to set the second return value. Signed-off-by: Stacey Son Signed-off-by: Klye Evans Signed-off-by: Warner Losh --- bsd-user/arm/t

Re: [PATCH 10/24] bsd-user/arm/target_arch_reg.h: Implement core dump register copying

2021-10-28 Thread Richard Henderson
On 10/19/21 9:44 AM, Warner Losh wrote: Implement the register copying routines to extract registers from the cpu for core dump generation. Signed-off-by: Stacey Son Signed-off-by: Warner Losh Reviewed-by: Richard Henderson +static inline void target_copy_regs(target_reg_t *regs, const CP

Re: [PATCH 12/24] bsd-user/arm/target_arch_sigtramp.h: Signal Trampoline for arm

2021-10-28 Thread Richard Henderson
On 10/19/21 9:44 AM, Warner Losh wrote: +/* + * The code has to load r7 manually rather than using + * "ldr r7, =SYS_return to make sure the size of the + * code is correct. + */ This comment was applicable to the original freebsd asm source; it has no bearing on the hex in

RE: [PATCH v6 07/12] target/hexagon: prepare input for the idef-parser

2021-10-28 Thread Taylor Simpson
> From: Anton Johansson > Sent: Monday, October 18, 2021 6:23 AM > To: Taylor Simpson ; Alessandro Di Federico > ; qemu-devel@nongnu.org > Cc: Brian Cain ; bab...@rev.ng; ni...@rev.ng; > richard.hender...@linaro.org; Alessandro Di Federico > Subject: Re: [PATCH v6 07/12] target/hexagon: prep

Re: [PATCH 00/16] fdt: Make OF_BOARD a boolean option

2021-10-28 Thread Simon Glass
Hi François, On Thu, 28 Oct 2021 at 08:50, François Ozog wrote: > > Hi Simon > > Le jeu. 28 oct. 2021 à 16:30, Simon Glass a écrit : >> >> Hi François, >> >> On Thu, 28 Oct 2021 at 02:21, François Ozog wrote: >> > >> > Hi Simon, >> > >> > Le jeu. 28 oct. 2021 à 04:51, Simon Glass a écrit : >>

Re: [PATCH v4 14/25] include/systemu/blockdev.h: global state API

2021-10-28 Thread Stefan Hajnoczi
On Mon, Oct 25, 2021 at 06:17:24AM -0400, Emanuele Giuseppe Esposito wrote: > blockdev functions run always under the BQL lock. > > Signed-off-by: Emanuele Giuseppe Esposito > --- > include/sysemu/blockdev.h | 18 ++ > 1 file changed, 14 insertions(+), 4 deletions(-) Reviewed-by

RE: [PATCH v6 08/12] target/hexagon: import lexer for idef-parser

2021-10-28 Thread Taylor Simpson
> From: Anton Johansson > Sent: Monday, October 18, 2021 6:37 AM > To: Taylor Simpson ; Alessandro Di Federico > ; qemu-devel@nongnu.org > Cc: Brian Cain ; bab...@rev.ng; ni...@rev.ng; > richard.hender...@linaro.org; Alessandro Di Federico > Subject: Re: [PATCH v6 08/12] target/hexagon: impo

  1   2   3   4   >