Re: [PATCH v3 9/9] bsd-user/mmap.c: assert that target_mprotect cannot fail

2021-10-14 Thread Kyle Evans
On Fri, Oct 8, 2021 at 4:31 PM Warner Losh wrote: > > Similar to the equivalent linux-user change 86abac06c14. All error > conditions that target_mprotect checks are also checked by target_mmap. > EACCESS cannot happen because we are just removing PROT_WRITE. ENOMEM > should not happen because we

Re: [PATCH v3 3/9] bsd-user/mmap.c: MAP_ symbols are defined, so no need for ifdefs

2021-10-14 Thread Kyle Evans
On Fri, Oct 8, 2021 at 4:24 PM Warner Losh wrote: > > All these MAP_ symbols are always defined on supported FreeBSD versions > (12.2 and newer), so remove the #ifdefs since they aren't needed. > > Signed-off-by: Warner Losh > Reviewed-by: Philippe Mathieu-Daudé > Acked-by: Richard Henderson >

Re: [PATCH v3 4/9] bsd-user/mmap.c: mmap return ENOMEM on overflow

2021-10-14 Thread Kyle Evans
On Fri, Oct 8, 2021 at 4:27 PM Warner Losh wrote: > > mmap should return ENOMEM on len overflow rather than EINVAL. Return > EINVAL when len == 0 and ENOMEM when the rounded to a page length is 0. > Found by make check-tcg. > > Signed-off-by: Warner Losh > Reviewed-by: Richard Henderson > Review

Re: [PATCH 0/5] trace: inroduce qmp: trace namespace

2021-10-14 Thread Vladimir Sementsov-Ogievskiy
12.10.2021 14:49, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: Hi all! We have handle_qmp_command and qmp_command_repond trace points to trace qmp commands. They are very useful to debug problems involving management tools like libvirt. But tracing all qmp commands is too mu

[PATCH v2 0/6] virtiofsd: Add support for file security context at creation

2021-10-14 Thread Vivek Goyal
Hi, This is v2 of patches. I posted v1 here. https://lore.kernel.org/qemu-devel/20210924194854.919414-1-vgo...@redhat.com/ Posted corresponding kernel patches here. https://lore.kernel.org/linux-fsdevel/20211012180624.447474-1-vgo...@redhat.com/ changes since v1: - Modified patches to handle

[PATCH v2 2/6] virtiofsd, fuse_lowlevel.c: Add capability to parse security context

2021-10-14 Thread Vivek Goyal
Add capability to enable and parse security context as sent by client and put into fuse_req. Filesystems now can get security context from request and set it on files during creation. Signed-off-by: Vivek Goyal --- tools/virtiofsd/fuse_common.h | 5 ++ tools/virtiofsd/fuse_i.h| 7 +++

[PATCH v2 4/6] virtiofsd: Create new file with fscreate set

2021-10-14 Thread Vivek Goyal
This patch adds support to set /proc/thread-self/attr/fscreate before file creation. It is set to a value as sent by client. This will allow for atomic creation of security context on files w.r.t file creation. This is primarily useful when either there is no SELinux enabled on host or host and gu

Re: [PATCH v3 1/2] numa: Require distance map when empty node exists

2021-10-14 Thread Igor Mammedov
On Wed, 13 Oct 2021 14:28:40 +0200 Andrew Jones wrote: > On Wed, Oct 13, 2021 at 02:11:25PM +0200, Andrew Jones wrote: > > On Wed, Oct 13, 2021 at 01:53:46PM +0200, Igor Mammedov wrote: > > > On Wed, 13 Oct 2021 13:35:44 +0200 > > > Andrew Jones wrote: > > > > > > > On Wed, Oct 13, 2021 at

[PATCH v2 1/6] fuse: Header file changes for FUSE_SECURITY_CTX

2021-10-14 Thread Vivek Goyal
These are just header file changes which should show up in qemu if corresponding kernel changes get merged. Signed-off-by: Vivek Goyal --- include/standard-headers/linux/fuse.h | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/include/standard-headers/linux/

Re: [PATCH v2 03/15] bsd-user/strace.list: Remove support for FreeBSD versions older than 12.0

2021-10-14 Thread Kyle Evans
On Fri, Oct 8, 2021 at 6:15 PM Warner Losh wrote: > > Signed-off-by: Warner Losh > Reviewed-by: Richard Henderson > --- > bsd-user/freebsd/strace.list | 11 --- > 1 file changed, 11 deletions(-) > > diff --git a/bsd-user/freebsd/strace.list b/bsd-user/freebsd/strace.list > index b01b5f3

[PATCH v2 3/6] virtiofsd: Move core file creation code in separate function

2021-10-14 Thread Vivek Goyal
Move core file creation bits in a separate function. Soon this is going to get more complex as file creation need to set security context also. And there will be multiple modes of file creation in next patch. Signed-off-by: Vivek Goyal --- tools/virtiofsd/passthrough_ll.c | 36 ++

Re: [PATCH 00/16] fdt: Make OF_BOARD a boolean option

2021-10-14 Thread Tom Rini
On Thu, Oct 14, 2021 at 09:17:52AM -0600, Simon Glass wrote: > Hi Tom, > > On Thu, 14 Oct 2021 at 08:56, Tom Rini wrote: > > > > On Wed, Oct 13, 2021 at 12:06:02PM -0600, Simon Glass wrote: > > > Hi François, > > > > > > On Wed, 13 Oct 2021 at 11:35, François Ozog > > > wrote: > > > > > > > > H

Re: Is the ppc440 "bamboo" board in QEMU still of any use?

2021-10-14 Thread Greg Kurz
On Thu, 14 Oct 2021 17:26:53 +0200 Philippe Mathieu-Daudé wrote: > On 10/14/21 13:29, Cédric Le Goater wrote: > > On 10/14/21 12:34, Christophe Leroy wrote: > > >> I have the following change in QEMU to be able to run the bamboo, > >> found it some time ago via google (can't remember where): > >

[PATCH v2 5/6] virtiofsd: Create new file using O_TMPFILE and set security context

2021-10-14 Thread Vivek Goyal
If guest and host policies can't work with each other, then guest security context (selinux label) needs to be set into an xattr. Say remap guest security.selinux xattr to trusted.virtiofs.security.selinux. That means setting "fscreate" is not going to help as that's ony useful for security.selinu

Re: [PATCH 00/16] fdt: Make OF_BOARD a boolean option

2021-10-14 Thread Simon Glass
Hi Tom, On Thu, 14 Oct 2021 at 08:56, Tom Rini wrote: > > On Wed, Oct 13, 2021 at 12:06:02PM -0600, Simon Glass wrote: > > Hi François, > > > > On Wed, 13 Oct 2021 at 11:35, François Ozog > > wrote: > > > > > > Hi Simon > > > > > > Le mer. 13 oct. 2021 à 16:49, Simon Glass a écrit : > > >> > >

Re: Is the ppc440 "bamboo" board in QEMU still of any use?

2021-10-14 Thread Thomas Huth
On 14/10/2021 17.26, Philippe Mathieu-Daudé wrote: On 10/14/21 13:29, Cédric Le Goater wrote: On 10/14/21 12:34, Christophe Leroy wrote: I have the following change in QEMU to be able to run the bamboo, found it some time ago via google (can't remember where): diff --git a/hw/ppc/ppc4xx_pci.

Re: [PATCH v2 02/15] bsd-user/target_os-user.h: Remove support for FreeBSD older than 12.0

2021-10-14 Thread Kyle Evans
On Fri, Oct 8, 2021 at 6:15 PM Warner Losh wrote: > > Signed-off-by: Warner Losh > Reviewed-by: Richard Henderson > --- > bsd-user/freebsd/target_os_user.h | 100 +- > 1 file changed, 1 insertion(+), 99 deletions(-) > > diff --git a/bsd-user/freebsd/target_os_user.h

Re: [PATCH v2 09/13] target/riscv: Replace DisasContext.w with DisasContext.ol

2021-10-14 Thread Richard Henderson
On 10/14/21 1:57 AM, Frédéric Pétrot wrote: diff --git a/target/riscv/translate.c b/target/riscv/translate.c index 5724a62bb0..6ab5c6aa58 100644 --- a/target/riscv/translate.c +++ b/target/riscv/translate.c @@ -67,7 +67,7 @@ typedef struct DisasContext { to any system register, which in

Re: [PATCH v1] libvhost-user: fix VHOST_USER_REM_MEM_REG not closing the fd

2021-10-14 Thread Raphael Norwitz
On Thu, Oct 14, 2021 at 09:06:51AM +0200, David Hildenbrand wrote: > On 14.10.21 07:29, Raphael Norwitz wrote: > > On Wed, Oct 13, 2021 at 11:51:24AM +0200, David Hildenbrand wrote: > >> On 13.10.21 11:48, Stefan Hajnoczi wrote: > >>> On Tue, Oct 12, 2021 at 08:38:32PM +0200, David Hildenbrand wrot

Re: [RFC PATCH v4 11/20] vhost: Route host->guest notification through shadow virtqueue

2021-10-14 Thread Eugenio Perez Martin
On Wed, Oct 13, 2021 at 5:49 AM Jason Wang wrote: > > > 在 2021/10/1 下午3:05, Eugenio Pérez 写道: > > This will make qemu aware of the device used buffers, allowing it to > > write the guest memory with its contents if needed. > > > > Since the use of vhost_virtqueue_start can unmasks and discard call

Re: [PATCH v2 03/13] target/riscv: Split misa.mxl and misa.ext

2021-10-14 Thread Richard Henderson
On 10/14/21 12:52 AM, LIU Zhiwei wrote: @@ -360,6 +357,7 @@ static void riscv_cpu_reset(DeviceState *dev)   mcc->parent_reset(dev);   #ifndef CONFIG_USER_ONLY +    env->misa_mxl = env->misa_mxl_max; As we have set misa_mxl in cpu_init_fn, why set it again here? I guess we could drop this

Re: Is the ppc440 "bamboo" board in QEMU still of any use?

2021-10-14 Thread Cédric Le Goater
On 10/14/21 17:26, Philippe Mathieu-Daudé wrote: On 10/14/21 13:29, Cédric Le Goater wrote: On 10/14/21 12:34, Christophe Leroy wrote: I have the following change in QEMU to be able to run the bamboo, found it some time ago via google (can't remember where): diff --git a/hw/ppc/ppc4xx_pci.c

Re: Is the ppc440 "bamboo" board in QEMU still of any use?

2021-10-14 Thread Philippe Mathieu-Daudé
On 10/14/21 13:29, Cédric Le Goater wrote: > On 10/14/21 12:34, Christophe Leroy wrote: >> I have the following change in QEMU to be able to run the bamboo, >> found it some time ago via google (can't remember where): >> >> diff --git a/hw/ppc/ppc4xx_pci.c b/hw/ppc/ppc4xx_pci.c >> index 8147ba6f94

Re: Is the ppc440 "bamboo" board in QEMU still of any use?

2021-10-14 Thread Mark Cave-Ayland
On 14/10/2021 16:37, Thomas Huth wrote: On 14/10/2021 17.26, Philippe Mathieu-Daudé wrote: On 10/14/21 13:29, Cédric Le Goater wrote: On 10/14/21 12:34, Christophe Leroy wrote: I have the following change in QEMU to be able to run the bamboo, found it some time ago via google (can't remembe

[PATCH v2 6/6] virtiofsd: Add an option to enable/disable security label

2021-10-14 Thread Vivek Goyal
Provide an option "-o security_label/no_security_label" to enable/disable security label functionality. By default these are turned off. If enabled, server will indicate to client that it is capable of handling one security label during file creation. Typically this is expected to be a SELinux lab

Re: [PATCH v3 1/2] numa: Require distance map when empty node exists

2021-10-14 Thread Andrew Jones
On Thu, Oct 14, 2021 at 05:14:17PM +0200, Igor Mammedov wrote: > On Wed, 13 Oct 2021 14:28:40 +0200 > Andrew Jones wrote: > > > On Wed, Oct 13, 2021 at 02:11:25PM +0200, Andrew Jones wrote: > > > On Wed, Oct 13, 2021 at 01:53:46PM +0200, Igor Mammedov wrote: > > > > On Wed, 13 Oct 2021 13:35:44

Re: [PATCH v2 05/13] target/riscv: Add MXL/SXL/UXL to TB_FLAGS

2021-10-14 Thread Richard Henderson
On 10/14/21 1:20 AM, LIU Zhiwei wrote: On 2021/10/14 上午4:50, Richard Henderson wrote: Begin adding support for switching XLEN at runtime.  Extract the effective XLEN from MISA and MSTATUS and store for use during translation. Signed-off-by: Richard Henderson --- v2: Force SXL and UXL to valid

Re: [PATCH v2 04/13] target/riscv: Replace riscv_cpu_is_32bit with riscv_cpu_mxl

2021-10-14 Thread Richard Henderson
On 10/14/21 12:08 AM, LIU Zhiwei wrote: On 2021/10/14 上午4:50, Richard Henderson wrote: Shortly, the set of supported XL will not be just 32 and 64, and representing that properly using the enumeration will be imperative. Two places, booting and gdb, intentionally use misa_mxl_max to emphasize

Re: [PATCH 00/16] fdt: Make OF_BOARD a boolean option

2021-10-14 Thread Andre Przywara
On Thu, 14 Oct 2021 09:17:52 -0600 Simon Glass wrote: > Hi Tom, > > On Thu, 14 Oct 2021 at 08:56, Tom Rini wrote: > > > > On Wed, Oct 13, 2021 at 12:06:02PM -0600, Simon Glass wrote: > > > Hi François, > > > > > > On Wed, 13 Oct 2021 at 11:35, François Ozog > > > wrote: > > > > > > > > Hi

Re: ping [PATCH] configure/optionrom: Fix MSYS2 multiboot.bin issue

2021-10-14 Thread Helge Konetzka
ping https://lore.kernel.org/qemu-devel/2b5ab039-8495-b55f-03f1-ecfd99690...@zapateado.de/T/#u https://patchew.org/QEMU/2b5ab039-8495-b55f-03f1-ecfd99690...@zapateado.de/ Am 15.09.21 um 12:56 schrieb Helge Konetzka: This patch enables native builds on MSYS2 with symlinks disabled. Signed-off

[PULL 02/26] audio: remove CONFIG_AUDIO_WIN_INT

2021-10-14 Thread Paolo Bonzini
Ever since winwaveaudio was removed in 2015, CONFIG_AUDIO_WIN_INT is only set if dsound is in use, so use CONFIG_AUDIO_DSOUND directly. Cc: Gerd Hoffman Cc: Volker Rümelin Reviewed-by: Marc-André Lureau Message-Id: <20211007130630.632028-3-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini ---

[PULL 01/26] configure: remove --oss-lib

2021-10-14 Thread Paolo Bonzini
OSS is a kernel API, so the option should not be needed. The library is used on NetBSD, where OSS is emulated, so keep the variable. Cc: Gerd Hoffman Cc: Volker Rümelin Reviewed-by: Marc-André Lureau Reviewed-by: Thomas Huth Message-Id: <20211007130630.632028-2-pbonz...@redhat.com> Signed-off

[PULL 00/26] Meson changes for 2021-10-14

2021-10-14 Thread Paolo Bonzini
The following changes since commit e5b2333f24ff207f08cf96e73d2e11438c985801: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20211013' into staging (2021-10-13 11:43:29 -0700) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for you to f

[PULL 07/26] configure, meson: move fuzzing configuration to Meson

2021-10-14 Thread Paolo Bonzini
Cc: Alexander Oleinik Reviewed-by: Alexander Bulekov Tested-by: Alexander Bulekov Message-Id: <20211007130829.632254-2-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- configure| 71 +++- meson.build | 51 +++

[PULL 04/26] meson: define symbols for all available audio drivers

2021-10-14 Thread Paolo Bonzini
All drivers are now built by default if the corresponding libraries are available, similar to how all other modules behave; --audio-drv-list only governs the default choice of the audio driver. Adjust the CONFIG_AUDIO_* preprocessor symbols so that they are based on library availability rather tha

[PULL 03/26] configure, meson: move audio driver detection to Meson

2021-10-14 Thread Paolo Bonzini
This brings a change that makes audio drivers more similar to all other modules. All drivers are built by default, while --audio-drv-list only governs the default choice of the audio driver. Meson options are added to disable the drivers, and the next patches will fix the help messages and comman

[PULL 09/26] trace: move configuration from configure to Meson

2021-10-14 Thread Paolo Bonzini
Cc: Stefan Hajnoczi Reviewed-by: Marc-André Lureau Message-Id: <20211007130829.632254-4-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- configure | 91 + docs/meson.build| 2 +- meson.build | 51 +

[PULL 05/26] configure: add command line options for audio drivers

2021-10-14 Thread Paolo Bonzini
Handle the choice of audio drivers the same as all other dependencies. Cc: Gerd Hoffman Cc: Volker Rümelin Reviewed-by: Marc-André Lureau Message-Id: <20211007130630.632028-6-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- configure | 39 ++- 1 file c

[PULL 06/26] kconfig: split CONFIG_SPARSE_MEM from fuzzing

2021-10-14 Thread Paolo Bonzini
Pass CONFIG_FUZZ via host_kconfig, and use it to select the sparse-mem device. Cc: Alexander Oleinik Reviewed-by: Alexander Bulekov Reviewed-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Tested-by: Alexander Bulekov Message-Id: <20211007130829.632254-1-pbonz...@redhat.com> Signed-

[PULL 13/26] meson: HAVE_GDB_BIN is not used by C code

2021-10-14 Thread Paolo Bonzini
It is only used by the TCG tests, remove it from config-host.h. Signed-off-by: Paolo Bonzini --- meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index ff19d54fc6..bdcedf2eef 100644 --- a/meson.build +++ b/meson.build @@ -1609,7 +1609,8

[PULL 10/26] configure, meson: move CONFIG_HOST_DSOSUF to Meson

2021-10-14 Thread Paolo Bonzini
This is just a constant string, there is no need to pass it in config-host.mak. Reviewed-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20211007130829.632254-5-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- configure | 6 -- meson.build | 10 +- 2

[PULL 15/26] configure, meson: move pthread_setname_np checks to Meson

2021-10-14 Thread Paolo Bonzini
This makes the pthreads check dead in configure, so remove it as well. Reviewed-by: Marc-André Lureau Message-Id: <20211007130829.632254-9-pbonz...@redhat.com> Reviewed-by: Thomas Huth Signed-off-by: Paolo Bonzini --- configure| 78 meso

[PULL 08/26] trace: simple: pass trace_file unmodified to config-host.h

2021-10-14 Thread Paolo Bonzini
Add the suffix directly in trace/simple.c, so that quoting is done properly by Meson. Cc: Stefan Hajnoczi Reviewed-by: Marc-André Lureau Message-Id: <20211007130829.632254-3-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- configure | 2 -- meson.build| 2 +- trace/simple.c | 2 +

[PULL 17/26] configure, meson: move vde detection to meson

2021-10-14 Thread Paolo Bonzini
Reviewed-by: Marc-André Lureau Message-Id: <20211007130829.632254-11-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- configure | 35 --- meson.build | 26 +++--- meson_options.txt | 2 ++ net/meson.build | 2 +- 4 files

[PULL 12/26] configure, meson: remove CONFIG_GCOV from config-host.mak

2021-10-14 Thread Paolo Bonzini
Reviewed-by: Marc-André Lureau Message-Id: <20211007130829.632254-7-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- configure | 3 --- meson.build | 1 + 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/configure b/configure index 648ba09f70..6efea3cfc6 100755 --- a/configur

[PULL 19/26] configure, meson: move Spice configure handling to meson

2021-10-14 Thread Paolo Bonzini
From: Marc-André Lureau Add meson feature options for Spice and Spice protocol, and move detection logic out of configure. Signed-off-by: Marc-André Lureau Message-Id: <20211007102453.978041-1-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini Message-Id: <20211007130829.632254-13-pbonz

[PULL 14/26] configure, meson: move remaining HAVE_* compiler tests to Meson

2021-10-14 Thread Paolo Bonzini
Remove some special cases by moving them to Meson. Reviewed-by: Marc-André Lureau Message-Id: <20211007130829.632254-8-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- configure | 37 - meson.build | 19 ++- 2 files changed, 18 insertio

[PULL 11/26] configure, meson: get HOST_WORDS_BIGENDIAN via the machine object

2021-10-14 Thread Paolo Bonzini
No need to pass it in config-host.mak. Reviewed-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20211007130829.632254-6-pbonz...@redhat.com> Reviewed-by: Thomas Huth Signed-off-by: Paolo Bonzini --- configure | 4 meson.build | 3 ++- 2 files changed, 2 insertion

[PULL 18/26] configure, meson: move netmap detection to meson

2021-10-14 Thread Paolo Bonzini
Message-Id: <20211007130829.632254-12-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- configure | 40 meson.build | 19 ++- meson_options.txt | 2 ++ net/meson.build | 4 +++- 4 files changed, 27 insertions(+), 38 de

[PULL 20/26] configure: remove obsolete Solaris ar check

2021-10-14 Thread Paolo Bonzini
Meson already has its own logic to find the "ar" binary, so remove the Solaris specific check. Reviewed-by: Marc-André Lureau Reviewed-by: Thomas Huth Message-Id: <20211007130829.632254-14-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- configure | 15 --- 1 file changed, 15

[PULL 24/26] configure: prepare for auto-generated option parsing

2021-10-14 Thread Paolo Bonzini
Prepare the configure script and Makefile for automatically generated help and parsing. Because we need to run the script to generate the full help, we cannot rely on the user supplying the path to a Python interpreter with --python; therefore, the introspection output is parsed into shell functio

[PULL 16/26] configure, meson: move libaio check to meson.build

2021-10-14 Thread Paolo Bonzini
Message-Id: <20211007130829.632254-10-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- block/meson.build | 2 +- configure | 31 --- meson.build | 10 -- meson_options.txt | 2 ++ stubs/meson.build | 4 +++- 5 files changed, 18 insertions(

[PULL 21/26] configure, meson: move more compiler checks to Meson

2021-10-14 Thread Paolo Bonzini
Reviewed-by: Marc-André Lureau Message-Id: <20211007130829.632254-15-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- configure| 91 meson.build | 44 +++ util/meson.build | 4 ++- 3 files changed, 47 inserti

[PULL 23/26] configure: accept "internal" for --enable-capstone/slirp/fdt

2021-10-14 Thread Paolo Bonzini
Options such as "--enable-capstone=git" do not make much sense when building from a tarball. Accept "internal" for consistency with the meson options. Reviewed-by: Marc-André Lureau Message-Id: <20211007130829.632254-17-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- configure | 6 +++---

[PULL 25/26] meson-buildoptions: include list of tracing backends

2021-10-14 Thread Paolo Bonzini
Manually patch the introspection data to include the tracing backends. This works around a deficiency in Meson that will be fixed by https://github.com/mesonbuild/meson/pull/9395. Signed-off-by: Paolo Bonzini --- scripts/meson-buildoptions.py | 16 1 file changed, 16 insertions(

[PULL 22/26] configure: remove deprecated --{enable, disable}-git-update

2021-10-14 Thread Paolo Bonzini
The options were deprecated in 6.0. That said, we do not really have a formal deprecation cycle for build-time changes, since they do not affect users. Reviewed-by: Marc-André Lureau Message-Id: <20211007130829.632254-16-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- configure | 8 -

Re: [RFC PATCH v4 11/20] vhost: Route host->guest notification through shadow virtqueue

2021-10-14 Thread Eugenio Perez Martin
On Wed, Oct 13, 2021 at 5:47 AM Jason Wang wrote: > > > 在 2021/10/1 下午3:05, Eugenio Pérez 写道: > > This will make qemu aware of the device used buffers, allowing it to > > write the guest memory with its contents if needed. > > > > Since the use of vhost_virtqueue_start can unmasks and discard call

[PULL 26/26] configure: automatically parse command line for meson -D options

2021-10-14 Thread Paolo Bonzini
Right now meson_options.txt lists about 90 options. Each option needs code in configure to parse it and pass the option down to Meson as a -D command-line argument; in addition the default must be duplicated between configure and meson_options.txt. This series tries to remove the code duplication

RE: [PATCH v3 00/22] target/ppc: DFP instructions using decodetree

2021-10-14 Thread Luis Fernando Fujita Pires
Ping? > -Original Message- > From: Luis Fernando Fujita Pires > Sent: segunda-feira, 20 de setembro de 2021 15:51 > To: Luis Fernando Fujita Pires ; qemu- > de...@nongnu.org; qemu-...@nongnu.org > Cc: da...@gibson.dropbear.id.au; gr...@kaod.org; > richard.hender...@linaro.org > Subject: R

Re: [PATCH v4 6/8] iotests/300: avoid abnormal shutdown race condition

2021-10-14 Thread Vladimir Sementsov-Ogievskiy
14.10.2021 00:57, John Snow wrote: Wait for the destination VM to close itself instead of racing to shut it down first, which produces different error log messages from AQMP depending on precisely when we tried to shut it down. (For example: We may try to issue 'quit' immediately prior to the ta

Re: [PATCH 1/9] tests/docker: Add debian-nios2-cross image

2021-10-14 Thread Richard Henderson
On 10/12/21 10:03 AM, Alex Bennée wrote: We need^H^H^H^H (might need, see bellow) a separate patch with: docker-image-debian10: NOUSER=1 to ensure the images we base our "handbuilt" compilers on don't include a potentially clashing uid (which should only be added for local builds). I think we

[PATCH v4 1/3] usb/uhci: Misc clean up

2021-10-14 Thread BALATON Zoltan
Fix a comment for coding style so subsequent patch will not get checkpatch error and simplify and shorten uhci_update_irq(). Signed-off-by: BALATON Zoltan --- hw/usb/hcd-uhci.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/hw/usb/hcd-uhci.c b/hw/usb/hcd-uhci.c index

[PATCH v4 0/3] hw/usb/vt82c686-uhci-pci: Use ISA instead of PCI interrupts

2021-10-14 Thread BALATON Zoltan
v4 splits up the single patch into a series BALATON Zoltan (3): usb/uhci: Misc clean up usb/uhci: Replace pci_set_irq with qemu_set_irq hw/usb/vt82c686-uhci-pci: Use ISA instead of PCI interrupts hw/usb/hcd-uhci.c | 11 +-- hw/usb/hcd-uhci.h | 2 +- hw/usb/vt82c6

[PATCH v4 2/3] usb/uhci: Replace pci_set_irq with qemu_set_irq

2021-10-14 Thread BALATON Zoltan
Instead of using pci_set_irq, store the irq in the device state and use it explicitly so variants having different interrupt handling can use their own. Signed-off-by: BALATON Zoltan --- hw/usb/hcd-uhci.c | 4 +++- hw/usb/hcd-uhci.h | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff

Re: [PATCH v4 1/3] usb/uhci: Misc clean up

2021-10-14 Thread Philippe Mathieu-Daudé
On 10/14/21 19:32, BALATON Zoltan wrote: > Fix a comment for coding style so subsequent patch will not get > checkpatch error and simplify and shorten uhci_update_irq(). > > Signed-off-by: BALATON Zoltan > --- > hw/usb/hcd-uhci.c | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) Re

[PATCH v4 3/3] hw/usb/vt82c686-uhci-pci: Use ISA instead of PCI interrupts

2021-10-14 Thread BALATON Zoltan
This device is part of a superio/ISA bridge chip and IRQs from it are routed to an ISA interrupt set by the Interrupt Line PCI config register. Implement this in a vt82c686-uhci-pci specific irq handler. Signed-off-by: BALATON Zoltan Reviewed-by: Jiaxun Yang --- hw/usb/vt82c686-uhci-pci.c | 12

Re: [PATCH v3] hw/usb/vt82c686-uhci-pci: Use ISA instead of PCI interrupts

2021-10-14 Thread BALATON Zoltan
On Thu, 14 Oct 2021, BALATON Zoltan wrote: On Thu, 14 Oct 2021, Gerd Hoffmann wrote: On Thu, Oct 14, 2021 at 12:22:58PM +0200, BALATON Zoltan wrote: On Thu, 14 Oct 2021, Gerd Hoffmann wrote: On Wed, Oct 13, 2021 at 02:13:09PM +0200, BALATON Zoltan wrote: This device is part of a superio/ISA b

Re: [PATCH 00/16] fdt: Make OF_BOARD a boolean option

2021-10-14 Thread François Ozog
Le jeu. 14 oct. 2021 à 18:24, Andre Przywara a écrit : > On Thu, 14 Oct 2021 09:17:52 -0600 > Simon Glass wrote: > > > Hi Tom, > > > > On Thu, 14 Oct 2021 at 08:56, Tom Rini wrote: > > > > > > On Wed, Oct 13, 2021 at 12:06:02PM -0600, Simon Glass wrote: > > > > Hi François, > > > > > > > > On W

Re: [RFC PATCH v4 15/20] vhost: Shadow virtqueue buffers forwarding

2021-10-14 Thread Eugenio Perez Martin
On Wed, Oct 13, 2021 at 6:31 AM Jason Wang wrote: > > > 在 2021/10/1 下午3:05, Eugenio Pérez 写道: > > Initial version of shadow virtqueue that actually forward buffers. There > > are no iommu support at the moment, and that will be addressed in future > > patches of this series. Since all vhost-vdpa d

Re: [PATCH 00/16] fdt: Make OF_BOARD a boolean option

2021-10-14 Thread François Ozog
Le jeu. 14 oct. 2021 à 17:28, Tom Rini a écrit : > On Thu, Oct 14, 2021 at 09:17:52AM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Thu, 14 Oct 2021 at 08:56, Tom Rini wrote: > > > > > > On Wed, Oct 13, 2021 at 12:06:02PM -0600, Simon Glass wrote: > > > > Hi François, > > > > > > > > On Wed,

Re: [PATCH 00/16] fdt: Make OF_BOARD a boolean option

2021-10-14 Thread François Ozog
Le mer. 13 oct. 2021 à 20:06, Simon Glass a écrit : > Hi François, > > On Wed, 13 Oct 2021 at 11:35, François Ozog > wrote: > > > > Hi Simon > > > > Le mer. 13 oct. 2021 à 16:49, Simon Glass a écrit : > >> > >> Hi Tom, Bin,François, > >> > >> On Tue, 12 Oct 2021 at 19:34, Tom Rini wrote: > >>

[PATCH] Fix %#08 misuses

2021-10-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Joe Perches pointed out on lkml [1] that the format special %# (which adds 0x) is included in the character count, i.e.: printf("0: %#08x\n0: %#08x\n", 0xabcdef01,1); gives: 0: 0xabcdef01 0: 0x01 rather than padding to the expected 8 data characters. It look

Re: [PULL 00/26] Meson changes for 2021-10-14

2021-10-14 Thread Richard Henderson
On 10/14/21 9:29 AM, Paolo Bonzini wrote: The following changes since commit e5b2333f24ff207f08cf96e73d2e11438c985801: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20211013' into staging (2021-10-13 11:43:29 -0700) are available in the Git repository at: https://gitlab.com/bo

Re: [PATCH] Fix %#08 misuses

2021-10-14 Thread Richard Henderson
On 10/14/21 11:52 AM, Dr. David Alan Gilbert (git) wrote: Although I'm tempted to think that perhaps we should just prefer '0x%08' which seems clearer. That's what I think we should prefer. r~

Re: [PATCH v7 04/10] ACPI ERST: support for ACPI ERST feature

2021-10-14 Thread Eric DeVolder
Ani, Inline responses below. eric On 10/7/21 20:29, Ani Sinha wrote: On Thu, 7 Oct 2021, Eric DeVolder wrote: This implements a PCI device for ACPI ERST. This implements the non-NVRAM "mode" of operation for ERST as it is supported by Linux and Windows. Signed-off-by: Eric DeVolder ---

Re: [PATCH v7 10/10] ACPI ERST: step 6 of bios-tables-test.c

2021-10-14 Thread Eric DeVolder
Ani, responses below. eric On 10/7/21 20:12, Ani Sinha wrote: On Thu, 7 Oct 2021, Eric DeVolder wrote: Following the guidelines in tests/qtest/bios-tables-test.c, this is step 6. Below is the disassembly of an ERST table, tests/data/acpi/pc/ERST. This is a PCI device and as such its base ad

[PATCH] microvm: add device tree support.

2021-10-14 Thread Gerd Hoffmann
Allows edk2 detect virtio-mmio devices and pcie ecam. See comment in hw/i386/microvm-dt.c for more details. Signed-off-by: Gerd Hoffmann --- hw/i386/microvm-dt.h | 8 + include/hw/i386/microvm.h | 4 + hw/i386/microvm-dt.c | 341 ++

Re: [PATCH v7 09/10] ACPI ERST: bios-tables-test.c steps 1 and 2

2021-10-14 Thread Eric DeVolder
On 10/7/21 20:17, Ani Sinha wrote: The ordering of the patches is wrong! (a) First, you need this patch so that the test framework will ignore changes to the table blobs that you specify here to explicitly ignore. (b) Then you need the patch that actually contains the test you wrote (patch 8

[PATCH v2] hw/elf_ops.h: switch to ssize_t for elf loader return type

2021-10-14 Thread Luc Michel
Until now, int was used as the return type for all the ELF loader related functions. The returned value is the sum of all loaded program headers "MemSize" fields. Because of the overflow check in elf_ops.h, trying to load an ELF bigger than INT_MAX will fail. Switch to ssize_t to remove this limit

[PATCH 1/6] ppc/pegasos2: Restrict memory to 2 gigabytes

2021-10-14 Thread BALATON Zoltan
The CHRP spec this board confirms to only allows 2 GiB of system memory below 4 GiB as the high 2 GiB is allocated to IO and system resources. To avoid problems with memory overlapping these areas restrict RAM to 2 GiB similar to mac_newworld. Signed-off-by: BALATON Zoltan --- hw/ppc/pegasos2.c

[PATCH 0/6] Misc pegasos2 patches

2021-10-14 Thread BALATON Zoltan
Some small clean ups and improvements for the pegasos2 machine. BALATON Zoltan (6): ppc/pegasos2: Restrict memory to 2 gigabytes ppc/pegasos2: Warn when using VOF but no kernel is specified ppc/pegasos2: Implement get-time-of-day RTAS function with VOF ppc/pegasos2: Access MV64361 register

[PATCH 3/6] ppc/pegasos2: Implement get-time-of-day RTAS function with VOF

2021-10-14 Thread BALATON Zoltan
This is needed for Linux to access RTC time. Signed-off-by: BALATON Zoltan --- hw/ppc/pegasos2.c | 25 + 1 file changed, 25 insertions(+) diff --git a/hw/ppc/pegasos2.c b/hw/ppc/pegasos2.c index a1dd1f6752..a9e3625f56 100644 --- a/hw/ppc/pegasos2.c +++ b/hw/ppc/pegasos2.

[PATCH 5/6] ppc/pegasos2: Add constants for PCI config addresses

2021-10-14 Thread BALATON Zoltan
Define a constant for PCI config addresses to make it clearer what these numbers are. Signed-off-by: BALATON Zoltan --- hw/ppc/pegasos2.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/ppc/pegasos2.c b/hw/ppc/pegasos2.c index a861bf16b8..39e96d323f 100644 --- a/hw/p

[PATCH 2/6] ppc/pegasos2: Warn when using VOF but no kernel is specified

2021-10-14 Thread BALATON Zoltan
Issue a warning when using VOF (which is the default) but no -kernel option given to let users know that it will likely fail as the guest has nothing to run. It is not a hard error because it may still be useful to start the machine without further options for testing or inspecting it from monitor

[PATCH 4/6] ppc/pegasos2: Access MV64361 registers via their memory region

2021-10-14 Thread BALATON Zoltan
Instead of relying on the mapped address of the MV64361 registers access them via their memory region. This is not a problem at reset time when these registers are mapped at the default address but the guest could change this later and then the RTAS calls accessing PCI config registers could fail.

[PATCH 6/6] ppc/pegasos2: Implement power-off RTAS function with VOF

2021-10-14 Thread BALATON Zoltan
This only helps Linux guests as only that seems to use it. Signed-off-by: BALATON Zoltan --- hw/ppc/pegasos2.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/hw/ppc/pegasos2.c b/hw/ppc/pegasos2.c index 39e96d323f..e427ac2fe0 100644 --- a/hw/ppc/pegasos2.c +++ b/hw/ppc/pegasos2.

Re: [PATCH v3 02/25] include/block/block: split header into I/O and global state API

2021-10-14 Thread Eric Blake
On Tue, Oct 12, 2021 at 04:48:43AM -0400, Emanuele Giuseppe Esposito wrote: > block.h currently contains a mix of functions: > some of them run under the BQL and modify the block layer graph, > others are instead thread-safe and perform I/O in iothreads. > It is not easy to understand which functio

Re: [PATCH 00/16] fdt: Make OF_BOARD a boolean option

2021-10-14 Thread Simon Glass
Hi François, On Thu, 14 Oct 2021 at 12:13, François Ozog wrote: > > > > Le mer. 13 oct. 2021 à 20:06, Simon Glass a écrit : >> >> Hi François, >> >> On Wed, 13 Oct 2021 at 11:35, François Ozog wrote: >> > >> > Hi Simon >> > >> > Le mer. 13 oct. 2021 à 16:49, Simon Glass a écrit : >> >> >> >> H

Re: [PATCH] Fix %#08 misuses

2021-10-14 Thread Stafford Horne
On Thu, Oct 14, 2021 at 12:33:06PM -0700, Richard Henderson wrote: > On 10/14/21 11:52 AM, Dr. David Alan Gilbert (git) wrote: > > Although I'm tempted to think that perhaps we should just > > prefer '0x%08' which seems clearer. > > That's what I think we should prefer. I agree, it's always more

[PATCH 0/4] Fix incorrect accesses to XER

2021-10-14 Thread matheus . ferst
From: Matheus Ferst This patch series fixes some uses of env->xer that were left behind when SO, OV, and CA bits were separated into other fields of CPUPPCState. At the time, all of them weren't in target-specific files/directories, which probably made it harder to track what needed to be changed

[PATCH 4/4] target/ppc: Fix XER access in monitor

2021-10-14 Thread matheus . ferst
From: Matheus Ferst We can't read env->xer directly, as it does not contain some bits of XER. Instead, we should have a callback that uses cpu_read_xer to read the complete register. Fixes: da91a00f191f ("target-ppc: Split out SO, OV, CA fields from XER") Signed-off-by: Matheus Ferst --- targe

[PATCH 3/4] linux-user: Fix XER access in ppc version of elf_core_copy_regs

2021-10-14 Thread matheus . ferst
From: Matheus Ferst env->xer doesn't hold some bits of XER, like OV and CA. To write the complete register in the core dump we should read XER value with cpu_read_xer. Reported-by: Lucas Mateus Castro (alqotel) Fixes: da91a00f191f ("target-ppc: Split out SO, OV, CA fields from XER") Signed-off-

[PATCH 1/4] linux-user/ppc: Fix XER access in save/restore_user_regs

2021-10-14 Thread matheus . ferst
From: Matheus Ferst We should use cpu_read_xer/cpu_write_xer to save/restore the complete register since some of its bits are in other fields of CPUPPCState. A test is added to prevent future regressions. Fixes: da91a00f191f ("target-ppc: Split out SO, OV, CA fields from XER") Signed-off-by: Mat

[PATCH 2/4] target/ppc: Fix XER access in gdbstub

2021-10-14 Thread matheus . ferst
From: Matheus Ferst The value of XER is split in multiple fields of CPUPPCState, like env->xer and env->so. To get/set the whole register from gdb, we should use cpu_read_xer/cpu_write_xer. Fixes: da91a00f191f ("target-ppc: Split out SO, OV, CA fields from XER") Signed-off-by: Matheus Ferst ---

[PATCH 0/7] tests: docker images for hexagon, nios2, microblaze

2021-10-14 Thread Richard Henderson
I've refined Brian's outline [1] into a proper patch. I've updated my nios2 docker toolchain build based on Alex's feedback, then added another toolchain build for microblaze. I'll keep the other nios2 changes in another patch set. r~ [1] https://lore.kernel.org/qemu-devel/sn6pr02mb42057f4736

[PATCH 4/7] gitlab-ci: Remove special casing for hexagon testing

2021-10-14 Thread Richard Henderson
Now that the hexagon container is using a pre-built toolchain, we do not need to make the build optional. Signed-off-by: Richard Henderson --- .gitlab-ci.d/buildtest.yml | 4 .gitlab-ci.d/container-cross.yml | 27 +++ 2 files changed, 3 insertions(+), 28 delet

[PATCH 7/7] tests/tcg: Enable container_cross_cc for microblaze

2021-10-14 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tests/tcg/configure.sh | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/tcg/configure.sh b/tests/tcg/configure.sh index 1f985ccfc0..149eeb15ff 100755 --- a/tests/tcg/configure.sh +++ b/tests/tcg/configure.sh @@ -55,6 +55,7 @@ fi : ${cross_cc_i3

[PATCH 1/7] tests/docker: Use apt build-dep in debian10

2021-10-14 Thread Richard Henderson
Replace the complex apt-get subshell with apt build-dep. Signed-off-by: Richard Henderson --- tests/docker/dockerfiles/debian10.docker | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tests/docker/dockerfiles/debian10.docker b/tests/docker/dockerfiles/debian10.docker

[PATCH 6/7] tests/docker: Add debian-microblaze-cross image

2021-10-14 Thread Richard Henderson
Build the entire cross tool chain from source. For this reason, default to caching. Signed-off-by: Richard Henderson --- tests/docker/Makefile.include | 6 ++ .../build-toolchain.sh| 88 +++ 2 files changed, 94 insertions(+) create mode 1

[PATCH 3/7] tests/docker: Update debian-hexagon-cross to a newer toolchain

2021-10-14 Thread Richard Henderson
From: Brian Cain The new dockerfile uses a complete toolchain built by CodeLinaro. Remove the special casing that was necessary when the dockerfile built the toolchain from source. Suggested-by: Brian Cain Signed-off-by: Richard Henderson --- tests/docker/Makefile.include | 2

<    1   2   3   4   >