Re: [PATCH RFC 00/15] virtio-mem: Expose device memory via separate memslots

2021-10-14 Thread David Hildenbrand
On 13.10.21 21:03, Dr. David Alan Gilbert wrote: > * David Hildenbrand (da...@redhat.com) wrote: >> Based-on: 20211011175346.15499-1-da...@redhat.com >> >> A virtio-mem device is represented by a single large RAM memory region >> backed by a single large mmap. >> >> Right now, we map that complete

Re: [PATCH v3 3/3] vdpa: Check for iova range at mappings changes

2021-10-14 Thread Jason Wang
On Thu, Oct 14, 2021 at 1:57 PM Eugenio Perez Martin wrote: > > On Thu, Oct 14, 2021 at 5:30 AM Jason Wang wrote: > > > > On Tue, Oct 12, 2021 at 10:07 PM Eugenio Pérez wrote: > > > > > > Check vdpa device range before updating memory regions so we don't add > > > any outside of it, and report t

Re: [PATCH 00/11] 9p: Add support for Darwin

2021-10-14 Thread Greg Kurz
Hi Will, It is strongly recommended that you Cc maintainers to increase the odds they notice your patches in the flood of qemu-devel. FYI I only noticed them because git-send-email Cc'd me thanks to the Reviewed-by: tags and my address didn't change in the meantime. I'm thus Cc'ing Christian who i

Re: [PATCH v1] libvhost-user: fix VHOST_USER_REM_MEM_REG not closing the fd

2021-10-14 Thread David Hildenbrand
On 14.10.21 07:29, Raphael Norwitz wrote: > On Wed, Oct 13, 2021 at 11:51:24AM +0200, David Hildenbrand wrote: >> On 13.10.21 11:48, Stefan Hajnoczi wrote: >>> On Tue, Oct 12, 2021 at 08:38:32PM +0200, David Hildenbrand wrote: We end up not closing the file descriptor, resulting in leaking one

Re: [PATCH v2 04/13] target/riscv: Replace riscv_cpu_is_32bit with riscv_cpu_mxl

2021-10-14 Thread LIU Zhiwei
On 2021/10/14 上午4:50, Richard Henderson wrote: Shortly, the set of supported XL will not be just 32 and 64, and representing that properly using the enumeration will be imperative. Two places, booting and gdb, intentionally use misa_mxl_max to emphasize the use of the reset value of misa.mxl,

Re: [PATCH v3 3/4] s390x: topology: CPU topology objects and structures

2021-10-14 Thread Thomas Huth
On 16/09/2021 15.50, Pierre Morel wrote: We use new objects to have a dynamic administration of the CPU topology. The highest level object in this implementation is the s390 book and in this first implementation of CPU topology for S390 we have a single book. The book is built as a SYSBUS bridge

Re: [PATCH v2] aspeed: Add support for the fp5280g2-bmc board

2021-10-14 Thread Cédric Le Goater
On 10/14/21 08:45, John Wang wrote: The fp5280g2-bmc is supported by OpenBMC, It's based on the following device tree https://github.com/openbmc/linux/blob/dev-5.10/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts Signed-off-by: John Wang Is a flash image available so that we can give this n

Re: [PATCH] monitor/qmp: fix race with clients disconnecting early

2021-10-14 Thread Markus Armbruster
Stefan Reiter writes: > On 10/12/21 11:27 AM, Markus Armbruster wrote: >> Stefan, any thoughts on this? >> > > Sorry, I didn't get to work on implementing this. Idea 3 does seem very > reasonable, though I suppose the question is what all should go into the > per-session state, and also how it i

Re: [PATCH v2] aspeed: Add support for the fp5280g2-bmc board

2021-10-14 Thread John Wang
Cédric Le Goater 于2021年10月14日周四 下午3:19写道: > > On 10/14/21 08:45, John Wang wrote: > > The fp5280g2-bmc is supported by OpenBMC, It's > > based on the following device tree > > > > https://github.com/openbmc/linux/blob/dev-5.10/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts > > > > Signed-off-by:

Re: [PATCH v4 2/2] monitor: refactor set/expire_password and allow VNC display id

2021-10-14 Thread Markus Armbruster
Stefan Reiter writes: > On 10/12/21 11:24 AM, Markus Armbruster wrote: >> Stefan Reiter writes: >> >>> It is possible to specify more than one VNC server on the command line, >>> either with an explicit ID or the auto-generated ones à "default", >>> "vnc2", "vnc3", ... >>> >>> It is not possibl

Re: [PATCH v2] aspeed: Add support for the fp5280g2-bmc board

2021-10-14 Thread Cédric Le Goater
On 10/14/21 09:36, John Wang wrote: Cédric Le Goater 于2021年10月14日周四 下午3:19写道: On 10/14/21 08:45, John Wang wrote: The fp5280g2-bmc is supported by OpenBMC, It's based on the following device tree https://github.com/openbmc/linux/blob/dev-5.10/arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts

Re: [PATCH v2 03/13] target/riscv: Split misa.mxl and misa.ext

2021-10-14 Thread LIU Zhiwei
On 2021/10/14 上午4:50, Richard Henderson wrote: The hw representation of misa.mxl is at the high bits of the misa csr. Representing this in the same way inside QEMU results in overly complex code trying to check that field. Signed-off-by: Richard Henderson --- v2: Reset misa.mxl. --- target

Re: [PATCH v3 3/3] vdpa: Check for iova range at mappings changes

2021-10-14 Thread Eugenio Perez Martin
On Thu, Oct 14, 2021 at 9:02 AM Jason Wang wrote: > > On Thu, Oct 14, 2021 at 1:57 PM Eugenio Perez Martin > wrote: > > > > On Thu, Oct 14, 2021 at 5:30 AM Jason Wang wrote: > > > > > > On Tue, Oct 12, 2021 at 10:07 PM Eugenio Pérez > > > wrote: > > > > > > > > Check vdpa device range before u

Re: [PATCH v3 2/4] s390x: kvm: topology: interception of PTF instruction

2021-10-14 Thread Pierre Morel
On 10/13/21 11:11, Thomas Huth wrote: On 13/10/2021 09.55, Pierre Morel wrote: On 10/13/21 09:25, Thomas Huth wrote: On 16/09/2021 15.50, Pierre Morel wrote: When the host supports the CPU topology facility, the PTF instruction with function code 2 is interpreted by the SIE, provided that

Re: [PATCH v2 05/13] target/riscv: Add MXL/SXL/UXL to TB_FLAGS

2021-10-14 Thread LIU Zhiwei
On 2021/10/14 上午4:50, Richard Henderson wrote: Begin adding support for switching XLEN at runtime. Extract the effective XLEN from MISA and MSTATUS and store for use during translation. Signed-off-by: Richard Henderson --- v2: Force SXL and UXL to valid values. --- target/riscv/cpu.h

Re: [PATCH v2] tests: qtest: Add virtio-iommu test

2021-10-14 Thread Eric Auger
Hi Thomas, On 10/14/21 7:58 AM, Thomas Huth wrote: > On 13/10/2021 21.50, Eric Auger wrote: >> Add the framework to test the virtio-iommu-pci device >> and tests exercising the attach/detach, map/unmap API. >> >> Signed-off-by: Eric Auger >> >> --- > ... >> +/** >> + * send_map - Send a map comma

Re: [PATCH v3 1/2] virtio-iommu: Remove the non transitional name

2021-10-14 Thread Jean-Philippe Brucker
On Wed, Oct 13, 2021 at 03:17:54PM -0400, Eric Auger wrote: > Remove the non transitional name for virtio iommu. Like other > devices introduced after 1.0 spec, the virtio-iommu does > not need it. > > Signed-off-by: Eric Auger > Reported-by: Andrea Bolognani > Reviewed-by: Cornelia Huck Revie

Re: [PATCH v3 2/2] virtio-iommu: Drop base_name and change generic_name

2021-10-14 Thread Jean-Philippe Brucker
On Wed, Oct 13, 2021 at 03:17:55PM -0400, Eric Auger wrote: > Drop base_name and turn generic_name into > "virtio-iommu-pci". This is more in line with > other modern-only devices. > > Signed-off-by: Eric Auger > Suggested-by: Cornelia Huck > Reviewed-by: Cornelia Huck Reviewed-by: Jean-Philip

Re: [PATCH v2 08/13] target/riscv: Replace is_32bit with get_xl/get_xlen

2021-10-14 Thread LIU Zhiwei
On 2021/10/14 上午4:50, Richard Henderson wrote: In preparation for RV128, replace a simple predicate with a more versatile test. Signed-off-by: Richard Henderson Reviewed-by: LIU Zhiwei Zhiwei --- target/riscv/translate.c | 32 +--- 1 file changed, 17 insertio

[PATCH v3] tests: qtest: Add virtio-iommu test

2021-10-14 Thread Eric Auger
Add the framework to test the virtio-iommu-pci device and tests exercising the attach/detach, map/unmap API. Signed-off-by: Eric Auger Acked-by: Thomas Huth --- This applies on top of jean-Philippe's [PATCH v4 00/11] virtio-iommu: Add ACPI support branch can be found at: https://github.com/eau

Re: [PATCH] hw/elf_ops.h: switch to ssize_t for elf loader return type

2021-10-14 Thread Stefano Garzarella
On Wed, Oct 06, 2021 at 09:28:39PM +0200, Luc Michel wrote: Until now, int was used as the return type for all the ELF loader related functions. The returned value is the sum of all loaded program headers "MemSize" fields. Because of the overflow check in elf_ops.h, trying to load an ELF bigger

Re: [PATCH v2 09/13] target/riscv: Replace DisasContext.w with DisasContext.ol

2021-10-14 Thread LIU Zhiwei
On 2021/10/14 上午4:51, Richard Henderson wrote: In preparation for RV128, consider more than just "w" for operand size modification. This will be used for the "d" insns from RV128 as well. Rename oper_len to get_olen to better match get_xlen. Signed-off-by: Richard Henderson --- target/ris

Re: [PATCH v1 0/9] migration/ram: Optimize for virtio-mem via RamDiscardManager

2021-10-14 Thread David Hildenbrand
On 13.10.21 19:35, Dr. David Alan Gilbert wrote: > * David Hildenbrand (da...@redhat.com) wrote: >> This series is fully reviewed by Peter and I hope we can get either more >> review feedback or get it merged via the migration tree soonish. Thanks. > > Yep, I think that's a full set now; we should

Re: [PATCH v1 0/9] migration/ram: Optimize for virtio-mem via RamDiscardManager

2021-10-14 Thread David Hildenbrand
On 13.10.21 19:35, Dr. David Alan Gilbert wrote: > * David Hildenbrand (da...@redhat.com) wrote: >> This series is fully reviewed by Peter and I hope we can get either more >> review feedback or get it merged via the migration tree soonish. Thanks. > > Yep, I think that's a full set now; we should

Re: [PATCH 1/2] qga-win: Detect OS based on Windows 10 by first build number

2021-10-14 Thread Marc-André Lureau
On Tue, Sep 14, 2021 at 4:18 PM Kostiantyn Kostiuk wrote: > Windows Server 2016, 2019, 2022 are based on Windows 10 and > have the same major and minor versions. So, the only way to > detect the proper version is to use the build number. > > Before this commit, the guest agent use the last build

Re: [PATCH] hw/elf_ops.h: switch to ssize_t for elf loader return type

2021-10-14 Thread Luc Michel
On 10:36 Thu 14 Oct , Stefano Garzarella wrote: > On Wed, Oct 06, 2021 at 09:28:39PM +0200, Luc Michel wrote: > >Until now, int was used as the return type for all the ELF > >loader related functions. The returned value is the sum of all loaded > >program headers "MemSize" fields. > > > >Becaus

Re: [PATCH v2 09/13] target/riscv: Replace DisasContext.w with DisasContext.ol

2021-10-14 Thread Frédéric Pétrot
Hi, Le 14/10/2021 à 10:40, LIU Zhiwei a écrit : > > On 2021/10/14 上午4:51, Richard Henderson wrote: >> In preparation for RV128, consider more than just "w" for >> operand size modification.  This will be used for the "d" >> insns from RV128 as well. >> >> Rename oper_len to get_olen to better matc

Re: [PATCH v3] hw/usb/vt82c686-uhci-pci: Use ISA instead of PCI interrupts

2021-10-14 Thread Gerd Hoffmann
On Wed, Oct 13, 2021 at 02:13:09PM +0200, BALATON Zoltan wrote: > This device is part of a superio/ISA bridge chip and IRQs from it are > routed to an ISA interrupt set by the Interrupt Line PCI config > register. Change uhci_update_irq() to allow this and implement it in > vt82c686-uhci-pci. Look

Re: [PATCH v3] hw/usb/vt82c686-uhci-pci: Use ISA instead of PCI interrupts

2021-10-14 Thread Gerd Hoffmann
Hi, > > if (s->masterbus) { > > USBPort *ports[NB_PORTS]; > > usb_uhci_common_realize() should be refactored making it PCI-agnostic. Not sure this is needed here. This seems to be more a platform-specific oddity in IRQ routing than a non-pci UHCI device. take care, Gerd

[PATCH 0/3] Postcopy migration: Add userfaultfd- user-mode-only capability

2021-10-14 Thread Lin Ma
Since kernel v5.11, Unprivileged user (without SYS_CAP_PTRACE capability) must pass UFFD_USER_MODE_ONLY to userfaultd in case unprivileged_userfaultfd sysctl knob is 0. Please refer to https://lwn.net/Articles/819834/ and the kernel commits: 37cd0575 userfaultfd: add UFFD_USER_MODE_ONLY d0d4730a us

[PATCH 1/3] migration: introduce postcopy-uffd-usermode-only capability

2021-10-14 Thread Lin Ma
The default value of unprivileged_userfaultfd sysctl knob was changed to 0 since kernel v5.11 by commit d0d4730a: userfaultfd: add user-mode only option to unprivileged_userfaultfd sysctl knob. In this mode, An unprivileged user (without SYS_CAP_PTRACE capability) must pass UFFD_USER_MODE_ONLY to

[PATCH 2/3] migration: postcopy-uffd-usermode-only documentation

2021-10-14 Thread Lin Ma
Signed-off-by: Lin Ma --- docs/devel/migration.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/docs/devel/migration.rst b/docs/devel/migration.rst index 2401253482..dfdd3f20b4 100644 --- a/docs/devel/migration.rst +++ b/docs/devel/migration.rst @@ -639,6 +639,15 @@ postcopy-block

[PATCH 3/3] tests: add postcopy-uffd-usermode-only capability into migration-test

2021-10-14 Thread Lin Ma
Signed-off-by: Lin Ma --- tests/qtest/migration-test.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index cc5e83d98a..0cd4f49bed 100644 --- a/tests/qtest/migration-test.c +++ b/tests/qtest/migration-tes

Is the ppc440 "bamboo" board in QEMU still of any use?

2021-10-14 Thread Thomas Huth
Hi, I tried to build a current Linux kernel for the "bamboo" board and use it in QEMU, but QEMU then quickly aborts with: pci.c:262: pci_bus_change_irq_level: Assertion `irq_num >= 0' failed. (or with a "DCR write error" if I try to use the cuImage instead). I googled a little bit and fo

Re: [PATCH 0/3] linux-aio: allow block devices to limit aio-max-batch

2021-10-14 Thread Stefano Garzarella
Kind ping :-) Thanks, Stefano On Thu, Sep 23, 2021 at 4:31 PM Stefano Garzarella wrote: > > Commit d7ddd0a161 ("linux-aio: limit the batch size using > `aio-max-batch` parameter") added a way to limit the batch size > of Linux AIO backend for the entire AIO context. > > The same AIO context can

Re: [PATCH v1 7/9] migration: Simplify alignment and alignment checks

2021-10-14 Thread Philippe Mathieu-Daudé
On 10/11/21 19:53, David Hildenbrand wrote: > Let's use QEMU_ALIGN_DOWN() and friends to make the code a bit easier to > read. > > Reviewed-by: Peter Xu > Signed-off-by: David Hildenbrand > --- > migration/migration.c| 6 +++--- > migration/postcopy-ram.c | 9 - > migration/ram.c

Re: [PATCH 1/9] tests/docker: Add debian-nios2-cross image

2021-10-14 Thread Alex Bennée
Richard Henderson writes: > On 10/12/21 10:03 AM, Alex Bennée wrote: >> We need to split this like in hexagon and have a second stage which does >> a: >>COPY --from=0 /usr/local /usr/local >> This will limit the size of the final image (and also avoid >> duplicting >> the UID in the hexagon

Re: [PATCH 1/2] tests/docker: Remove fedora-i386-cross from DOCKER_PARTIAL_IMAGES

2021-10-14 Thread Alex Bennée
Richard Henderson writes: > The image was upgraded to a full image in ee381b7fe146. > This makes it possible to use docker-test@image syntax > with this container. > > Cc: Thomas Huth > Cc: Alex Bennée > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH 2/9] linux-user/nios2: Properly emulate EXCP_TRAP

2021-10-14 Thread Alex Bennée
Richard Henderson writes: > The real kernel has to load the instruction and extract > the imm5 field; for qemu, modify the translator to do this. > > The use of R_AT for this in cpu_loop was a bug. Handle > the other trap numbers as per the kernel's trap_table. > > Signed-off-by: Richard Hende

Re: [PATCH v3 6/6] tests/qapi-schema: Test cases for aliases

2021-10-14 Thread Kevin Wolf
Am 13.10.2021 um 13:10 hat Markus Armbruster geschrieben: > Markus Armbruster writes: > > > Kevin Wolf writes: > > > >> Am 11.10.2021 um 09:44 hat Markus Armbruster geschrieben: > >>> Kevin Wolf writes: > >>> > >>> [...] > >>> > >>> > What I had in mind was using the schema to generate the ne

Re: [PATCH v1] libvhost-user: fix VHOST_USER_REM_MEM_REG skipping mmap_addr

2021-10-14 Thread Stefan Hajnoczi
On Thu, Oct 14, 2021 at 04:52:48AM +, Raphael Norwitz wrote: > On Wed, Oct 13, 2021 at 10:40:46AM +0100, Stefan Hajnoczi wrote: > > On Mon, Oct 11, 2021 at 10:10:47PM +0200, David Hildenbrand wrote: > > > We end up not copying the mmap_addr of all existing regions, resulting > > > in a SEGFAULT

Re: [PATCH 2/2] tests/docker: Fix fedora-i386-cross

2021-10-14 Thread Alex Bennée
Richard Henderson writes: > By using PKG_CONFIG_PATH instead of PKG_CONFIG_LIBDIR, > we were still including the 64-bit packages. Install > pcre-devel.i686 to fill a missing glib2 dependency. > > By using --extra-cflags instead of --cpu, we incorrectly > use the wrong probing during meson. > >

Re: [PATCH 3/9] linux-user/nios2: Fixes for signal frame setup

2021-10-14 Thread Alex Bennée
Richard Henderson writes: > Do not confuse host and guest addresses. Lock and unlock > the target_rt_sigframe structure in setup_rt_sigframe. > > Since rt_setup_ucontext always returns 0, drop the return > value entirely. This eliminates the only write to the err > variable in setup_rt_sigfra

Re: [PATCH v3 3/3] vdpa: Check for iova range at mappings changes

2021-10-14 Thread Jason Wang
On Thu, Oct 14, 2021 at 4:08 PM Eugenio Perez Martin wrote: > > On Thu, Oct 14, 2021 at 9:02 AM Jason Wang wrote: > > > > On Thu, Oct 14, 2021 at 1:57 PM Eugenio Perez Martin > > wrote: > > > > > > On Thu, Oct 14, 2021 at 5:30 AM Jason Wang wrote: > > > > > > > > On Tue, Oct 12, 2021 at 10:07 P

Re: [PATCH v3] hw/usb/vt82c686-uhci-pci: Use ISA instead of PCI interrupts

2021-10-14 Thread BALATON Zoltan
On Thu, 14 Oct 2021, Gerd Hoffmann wrote: On Wed, Oct 13, 2021 at 02:13:09PM +0200, BALATON Zoltan wrote: This device is part of a superio/ISA bridge chip and IRQs from it are routed to an ISA interrupt set by the Interrupt Line PCI config register. Change uhci_update_irq() to allow this and imp

Re: Is the ppc440 "bamboo" board in QEMU still of any use?

2021-10-14 Thread Christophe Leroy
Le 14/10/2021 à 11:31, Thomas Huth a écrit :  Hi, I tried to build a current Linux kernel for the "bamboo" board and use it in QEMU, but QEMU then quickly aborts with:  pci.c:262: pci_bus_change_irq_level: Assertion `irq_num >= 0' failed. (or with a "DCR write error" if I try to use th

Re: Is the ppc440 "bamboo" board in QEMU still of any use?

2021-10-14 Thread Christophe Leroy
Le 14/10/2021 à 12:34, Christophe Leroy a écrit : Le 14/10/2021 à 11:31, Thomas Huth a écrit :   Hi, I tried to build a current Linux kernel for the "bamboo" board and use it in QEMU, but QEMU then quickly aborts with:   pci.c:262: pci_bus_change_irq_level: Assertion `irq_num >= 0' fai

Re: [PATCH 00/11] 9p: Add support for Darwin

2021-10-14 Thread Will Cohen
Many thanks for all the clarifications — it’s my first time using git-send-email and first time with mailing-list-based devel workflows. Will adjust accordingly, work through gitlab, and eventually resend via git-publish as v2. On Thu, Oct 14, 2021 at 3:04 AM Greg Kurz wrote: > Hi Will, > > It i

Re: [PATCH v1] vsock: don't send messages when vsock device is not started

2021-10-14 Thread Stefano Garzarella
Please CC maintainers (MST in this case) On Fri, 2021-10-01 at 18:42 +, Jiang Wang wrote: > Added a check in vhost_vsock_common_send_transport_reset, > and only send messages on event queue when the vsock host > device is started. > > Suggested-by: Stefano Garzarella > Signed-off-by: Jiang W

Re: Is the ppc440 "bamboo" board in QEMU still of any use?

2021-10-14 Thread Cédric Le Goater
On 10/14/21 12:34, Christophe Leroy wrote: Le 14/10/2021 à 11:31, Thomas Huth a écrit :   Hi, I tried to build a current Linux kernel for the "bamboo" board and use it in QEMU, but QEMU then quickly aborts with:   pci.c:262: pci_bus_change_irq_level: Assertion `irq_num >= 0' failed. (or w

Re: Is the ppc440 "bamboo" board in QEMU still of any use?

2021-10-14 Thread Mark Cave-Ayland
On 14/10/2021 11:47, Christophe Leroy wrote: Le 14/10/2021 à 12:34, Christophe Leroy a écrit : Le 14/10/2021 à 11:31, Thomas Huth a écrit :   Hi, I tried to build a current Linux kernel for the "bamboo" board and use it in QEMU, but QEMU then quickly aborts with:   pci.c:262: pci_bus_ch

Re: [PATCH RFC 12/15] virtio-mem: Expose device memory via separate memslots

2021-10-14 Thread Dr. David Alan Gilbert
* David Hildenbrand (da...@redhat.com) wrote: > KVM nowadays supports a lot of memslots. We want to exploit that in > virtio-mem, exposing device memory via separate memslots to the guest > on demand, essentially reducing the total size of KVM slots > significantly (and thereby metadata in KVM and

Re: [PATCH v2] docs/specs/tpm: Clarify command line parameters for network migration

2021-10-14 Thread David Edmondson
On Wednesday, 2021-10-13 at 23:27:00 -04, Stefan Berger wrote: > Clarify the command line parameters for swtpm migration across the network > for the case of shared storage and non-shared storage. > > Signed-off-by: Stefan Berger > --- > docs/specs/tpm.rst | 3 ++- > 1 file changed, 2 insertions

[PATCH v3 1/3] tests/acpi: Get prepared for IORT E.b revision upgrade

2021-10-14 Thread Eric Auger
Ignore IORT till reference blob for E.b spec revision gets added. Signed-off-by: Eric Auger --- tests/qtest/bios-tables-test-allowed-diff.h | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index dfb8523

[PATCH v3 0/3] hw/arm/virt_acpi_build: Upgrate the IORT table up to revision E.b

2021-10-14 Thread Eric Auger
This series upgrades the ACPI IORT table up to the E.b specification revision. One of the goal of this upgrade is to allow the addition of RMR nodes along with the SMMUv3. The latest IORT specification (ARM DEN 0049E.b) can be found at IO Remapping Table - Platform Design Document https://develope

[PATCH v3 2/3] hw/arm/virt-acpi-build: IORT upgrade up to revision E.b

2021-10-14 Thread Eric Auger
Upgrade the IORT table from B to E.b specification revision (ARM DEN 0049E.b). The SMMUv3 and root complex node have additional fields. Also unique IORT node identifiers are introduced: they are generated in sequential order. They are not cross-referenced though. Signed-off-by: Eric Auger Review

[PATCH v3 3/3] tests/acpi: Generate reference blob for IORT rev E.b

2021-10-14 Thread Eric Auger
Re-generate reference blobs with rebuild-expected-aml.sh. Differences reported by "make check V=1" are listed below (IORT.numamem). Differences for other variants are similar. /* * Intel ACPI Component Architecture * AML/ASL+ Disassembler version 20180629 (64-bit version) * Copyright (c) 2

Re: [RFC PATCH v4 08/20] vhost: Route guest->host notification through shadow virtqueue

2021-10-14 Thread Eugenio Perez Martin
On Wed, Oct 13, 2021 at 5:27 AM Jason Wang wrote: > > > 在 2021/10/1 下午3:05, Eugenio Pérez 写道: > > Shadow virtqueue notifications forwarding is disabled when vhost_dev > > stops, so code flow follows usual cleanup. > > > > Also, host notifiers must be disabled at SVQ start, > > > Any reason for thi

Re: [PATCH 00/11] 9p: Add support for Darwin

2021-10-14 Thread Christian Schoenebeck
On Donnerstag, 14. Oktober 2021 12:48:55 CEST Will Cohen wrote: > Many thanks for all the clarifications — it’s my first time using > git-send-email and first time with mailing-list-based devel workflows. Will > adjust accordingly, work through gitlab, and eventually resend via > git-publish as v2.

Re: [RFC PATCH v4 05/20] vhost: Add x-vhost-enable-shadow-vq qmp

2021-10-14 Thread Eugenio Perez Martin
On Tue, Oct 12, 2021 at 3:46 PM Markus Armbruster wrote: > > Eugenio Perez Martin writes: > > > On Tue, Oct 12, 2021 at 7:18 AM Markus Armbruster wrote: > >> > >> Eugenio Pérez writes: > >> > >> > Command to enable shadow virtqueue. > >> > > >> > Signed-off-by: Eugenio Pérez > >> > --- > >> >

Re: [PATCH v3 3/4] s390x: topology: CPU topology objects and structures

2021-10-14 Thread Pierre Morel
On 10/14/21 09:16, Thomas Huth wrote: On 16/09/2021 15.50, Pierre Morel wrote: We use new objects to have a dynamic administration of the CPU topology. The highest level object in this implementation is the s390 book and in this first implementation of CPU topology for S390 we have a single b

Re: [PATCH v3 0/3] hw/arm/virt_acpi_build: Upgrate the IORT table up to revision E.b

2021-10-14 Thread Eric Auger
Hi, On 10/14/21 1:56 PM, Eric Auger wrote: > This series upgrades the ACPI IORT table up to the E.b > specification revision. One of the goal of this upgrade > is to allow the addition of RMR nodes along with the SMMUv3. while I have sent a separate RFC to expose RMR nodes along with SMMUv3 I mus

Re: [PATCH v3 0/3] hw/arm/virt_acpi_build: Upgrate the IORT table up to revision E.b

2021-10-14 Thread Michael S. Tsirkin
On Thu, Oct 14, 2021 at 01:56:40PM +0200, Eric Auger wrote: > This series upgrades the ACPI IORT table up to the E.b > specification revision. One of the goal of this upgrade > is to allow the addition of RMR nodes along with the SMMUv3. > > The latest IORT specification (ARM DEN 0049E.b) can be f

Re: [RFC PATCH v4 09/20] vdpa: Save call_fd in vhost-vdpa

2021-10-14 Thread Eugenio Perez Martin
On Wed, Oct 13, 2021 at 5:43 AM Jason Wang wrote: > > > 在 2021/10/1 下午3:05, Eugenio Pérez 写道: > > We need to know it to switch to Shadow VirtQueue. > > > > Signed-off-by: Eugenio Pérez > > --- > > include/hw/virtio/vhost-vdpa.h | 2 ++ > > hw/virtio/vhost-vdpa.c | 5 + > > 2 files

Re: [PATCH v3] tests: qtest: Add virtio-iommu test

2021-10-14 Thread Jean-Philippe Brucker
Hi Eric, On Thu, Oct 14, 2021 at 04:34:05AM -0400, Eric Auger wrote: > Add the framework to test the virtio-iommu-pci device > and tests exercising the attach/detach, map/unmap API. > > Signed-off-by: Eric Auger > Acked-by: Thomas Huth > > --- > > This applies on top of jean-Philippe's > [PAT

Re: [PATCH 00/11] 9p: Add support for Darwin

2021-10-14 Thread Will Cohen
Correct. It's been tested and functions when applied to QEMU master, with host running macOS Big Sur 11.6 (personal machine) using client 9p2000.L (taking a cue from the guest mounting instructions on https://wiki.qemu.org/Documentation/9psetup). On Thu, Oct 14, 2021 at 7:57 AM Christian Schoenebe

Re: [RFC PATCH v4 10/20] vhost-vdpa: Take into account SVQ in vhost_vdpa_set_vring_call

2021-10-14 Thread Eugenio Perez Martin
On Wed, Oct 13, 2021 at 5:43 AM Jason Wang wrote: > > > 在 2021/10/1 下午3:05, Eugenio Pérez 写道: > > Signed-off-by: Eugenio Pérez > > --- > > hw/virtio/vhost-vdpa.c | 17 ++--- > > 1 file changed, 14 insertions(+), 3 deletions(-) > > > > diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio

[PATCH] virtiofsd: Error on bad socket group name

2021-10-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Make the '--socket-group=' option fail if the group name is unknown: ./tools/virtiofsd/virtiofsd --socket-group=zaphod vhost socket: unable to find group 'zaphod' Reported-by: Xiaoling Gao Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/fuse_virt

Re: [PATCH 00/11] 9p: Add support for Darwin

2021-10-14 Thread Christian Schoenebeck
On Donnerstag, 14. Oktober 2021 14:22:19 CEST Will Cohen wrote: > Correct. It's been tested and functions when applied to QEMU master, with > host running macOS Big Sur 11.6 (personal machine) using client 9p2000.L > (taking a cue from the guest mounting instructions on > https://wiki.qemu.org/Docu

Re: Is the ppc440 "bamboo" board in QEMU still of any use?

2021-10-14 Thread BALATON Zoltan
On Thu, 14 Oct 2021, Mark Cave-Ayland wrote: On 14/10/2021 11:47, Christophe Leroy wrote: Le 14/10/2021 à 12:34, Christophe Leroy a écrit : Le 14/10/2021 à 11:31, Thomas Huth a écrit :   Hi, I tried to build a current Linux kernel for the "bamboo" board and use it in QEMU, but QEMU then qui

Re: [PATCH v3] hw/usb/vt82c686-uhci-pci: Use ISA instead of PCI interrupts

2021-10-14 Thread Gerd Hoffmann
On Thu, Oct 14, 2021 at 12:22:58PM +0200, BALATON Zoltan wrote: > On Thu, 14 Oct 2021, Gerd Hoffmann wrote: > > On Wed, Oct 13, 2021 at 02:13:09PM +0200, BALATON Zoltan wrote: > > > This device is part of a superio/ISA bridge chip and IRQs from it are > > > routed to an ISA interrupt set by the Int

Re: [PATCH v3] hw/usb/vt82c686-uhci-pci: Use ISA instead of PCI interrupts

2021-10-14 Thread BALATON Zoltan
On Thu, 14 Oct 2021, Gerd Hoffmann wrote: On Thu, Oct 14, 2021 at 12:22:58PM +0200, BALATON Zoltan wrote: On Thu, 14 Oct 2021, Gerd Hoffmann wrote: On Wed, Oct 13, 2021 at 02:13:09PM +0200, BALATON Zoltan wrote: This device is part of a superio/ISA bridge chip and IRQs from it are routed to an

Re: [PATCH 2/3] gdbstub: implement NOIRQ support for single step on KVM

2021-10-14 Thread Alex Bennée
Maxim Levitsky writes: > On Wed, 2021-10-13 at 16:50 +0100, Alex Bennée wrote: >> Maxim Levitsky writes: >> >> > Signed-off-by: Maxim Levitsky >> > --- >> > accel/kvm/kvm-all.c | 25 ++ >> > gdbstub.c| 60 >> > includ

Re: [PATCH RFC 12/15] virtio-mem: Expose device memory via separate memslots

2021-10-14 Thread David Hildenbrand
On 14.10.21 13:45, Dr. David Alan Gilbert wrote: > * David Hildenbrand (da...@redhat.com) wrote: >> KVM nowadays supports a lot of memslots. We want to exploit that in >> virtio-mem, exposing device memory via separate memslots to the guest >> on demand, essentially reducing the total size of KVM s

Re: [PATCH] failover: allow to pause the VM during the migration

2021-10-14 Thread Dr. David Alan Gilbert
* Laurent Vivier (lviv...@redhat.com) wrote: > If we want to save a snapshot of a VM to a file, we used to follow the > following steps: > > 1- stop the VM: >(qemu) stop > > 2- migrate the VM to a file: >(qemu) migrate "exec:cat > snapshot" > > 3- resume the VM: >(qemu) cont > > Aft

[PATCH v8 7/8] hw/arm/virt-acpi-build: Generate PPTT table

2021-10-14 Thread Yanan Wang
Generate PPTT table for Arm virt machines. Signed-off-by: Yanan Wang Reviewed-by: Andrew Jones --- hw/arm/virt-acpi-build.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index 6cec97352b..658a0a5d39 100644 --- a/hw

[PATCH v8 3/8] hw/arm/virt: Add cpu-map to device tree

2021-10-14 Thread Yanan Wang
From: Andrew Jones Support device tree CPU topology descriptions. In accordance with the Devicetree Specification, the Linux Doc "arm/cpus.yaml" requires that cpus and cpu nodes in the DT are present. And we have already met the requirement by generating /cpus/cpu@* nodes for members within ms->

[PATCH v8 5/8] hw/acpi/aml-build: Add PPTT table

2021-10-14 Thread Yanan Wang
From: Andrew Jones Add the Processor Properties Topology Table (PPTT) used to describe CPU topology information to ACPI guests. Note, a DT-boot Linux guest with a non-flat CPU topology will see socket and core IDs being sequential integers starting from zero, which is different from ACPI-boot Li

[PATCH v8 4/8] hw/acpi/aml-build: Add Processor hierarchy node structure

2021-10-14 Thread Yanan Wang
Add a generic API to build Processor hierarchy node structure (Type 0), which is strictly consistent with descriptions in ACPI 6.2: 5.2.29.1. This function will be used to build ACPI PPTT table for cpu topology. Co-developed-by: Ying Fang Co-developed-by: Henglong Fan Co-developed-by: Yanan Wan

Re: [PATCH 00/11] 9p: Add support for Darwin

2021-10-14 Thread Will Cohen
Correct, sorry for the imprecise language. The use case being contemplated is limited to Linux as the guest side, specifically for cross-platform tools where the macOS implementation consists of integrating a Linux VM via QEMU. NixOS (updater of the original patch, https://github.com/NixOS/nixpkgs

[PATCH v8 1/8] hw/arm/virt: Only describe cpu topology since virt-6.2

2021-10-14 Thread Yanan Wang
On existing older machine types, without cpu topology described in ACPI or DT, the guest will populate one by default. With the topology described, it will read the information and set up its topology as instructed, but that may not be the same as what was getting used by default. It's possible tha

[PATCH v8 6/8] tests/data/acpi/virt: Add an empty expected file for PPTT

2021-10-14 Thread Yanan Wang
Add a generic empty binary file for the new introduced PPTT table under tests/data/acpi/virt, and list it as files to be changed in tests/qtest/bios-tables-test-allowed-diff.h Signed-off-by: Yanan Wang --- tests/data/acpi/virt/PPTT | 0 tests/qtest/bios-tables-test-allowed-diff

Re: [PATCH 0/5] 9pfs: introduce P9Array

2021-10-14 Thread Christian Schoenebeck
On Freitag, 1. Oktober 2021 16:25:22 CEST Christian Schoenebeck wrote: > This is simply a refactored follow-up of the following previous series > ("introduce QArray"): > https://lists.gnu.org/archive/html/qemu-devel/2021-08/msg04530.html > > There was no consensus about a project wide "QArray" sha

[PATCH v8 2/8] device_tree: Add qemu_fdt_add_path

2021-10-14 Thread Yanan Wang
qemu_fdt_add_path() works like qemu_fdt_add_subnode(), except it also adds all missing subnodes from the given path. We'll use it in a coming patch where we will add cpu-map to the device tree. And we also tweak an error message of qemu_fdt_add_subnode(). Cc: David Gibson Cc: Alistair Francis C

[PATCH v8 0/8] hw/arm/virt: Introduce cpu topology support

2021-10-14 Thread Yanan Wang
Hi, This is the latest v8 with update in patch #6 and #8. Now only one generic reference file for PPTT is added in tests/data/acpi/virt. Machiel and Igor, please help to have a look, thanks! Description of this series: Once the view of an accurate virtual cpu topology is provided to guest, with a

[PATCH v8 8/8] tests/data/acpi/virt: Update the empty expected file for PPTT

2021-10-14 Thread Yanan Wang
Run ./tests/data/acpi/rebuild-expected-aml.sh from build directory to update PPTT binary. Also empty bios-tables-test-allowed-diff.h. Disassembled output of the updated new file: /* * Intel ACPI Component Architecture * AML/ASL+ Disassembler version 20180810 (64-bit version) * Copyright (c) 20

Re: [PATCH v3] hw/usb/vt82c686-uhci-pci: Use ISA instead of PCI interrupts

2021-10-14 Thread Philippe Mathieu-Daudé
On 10/14/21 11:12, Gerd Hoffmann wrote: > Hi, > >>> if (s->masterbus) { >>> USBPort *ports[NB_PORTS]; >> >> usb_uhci_common_realize() should be refactored making it PCI-agnostic. > > Not sure this is needed here. This seems to be more a platform-specific > oddity in IRQ routing t

Re: Approaches for same-on-same linux-user execve?

2021-10-14 Thread Assad Hashmi
> ARM's armie takes a different approach with the trap and emulate of > SIGILL instructions. This works well for the occasional "new" > instruction but will be less efficient overall if your instruction > stream is entirely novel. To clarify: earlier versions of armie did use the SIGILL trap-and-e

[PATCH v4 1/3] vdpa: Skip protected ram IOMMU mappings

2021-10-14 Thread Eugenio Pérez
Following the logic of commit 56918a126ae ("memory: Add RAM_PROTECTED flag to skip IOMMU mappings") with VFIO, skip memory sections inaccessible via normal mechanisms, including DMA. Signed-off-by: Eugenio Pérez Acked-by: Jason Wang --- hw/virtio/vhost-vdpa.c | 1 + 1 file changed, 1 insertion(

[PATCH v4 2/3] vdpa: Add vhost_vdpa_section_end

2021-10-14 Thread Eugenio Pérez
Abstract this operation, that will be reused when validating the region against the iova range that the device supports. Signed-off-by: Eugenio Pérez Acked-by: Jason Wang --- hw/virtio/vhost-vdpa.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/hw/vi

[PATCH v4 0/3] vdpa: Check iova range on memory regions ops

2021-10-14 Thread Eugenio Pérez
At this moment vdpa will not send memory regions bigger than 1<<63. However, actual iova range could be way more restrictive than that. Since we can obtain the range through vdpa ioctl call, just save it from the beginning of the operation and check against it. Changes from v3: * Change default v

[PATCH v4 3/3] vdpa: Check for iova range at mappings changes

2021-10-14 Thread Eugenio Pérez
Check vdpa device range before updating memory regions so we don't add any outside of it, and report the invalid change if any. Signed-off-by: Eugenio Pérez --- include/hw/virtio/vhost-vdpa.h | 2 ++ hw/virtio/vhost-vdpa.c | 62 +- hw/virtio/trace-events

Re: [RFC PATCH v4 12/20] virtio: Add vhost_shadow_vq_get_vring_addr

2021-10-14 Thread Eugenio Perez Martin
On Wed, Oct 13, 2021 at 5:54 AM Jason Wang wrote: > > > 在 2021/10/1 下午3:05, Eugenio Pérez 写道: > > It reports the shadow virtqueue address from qemu virtual address space > > > I think both the title and commit log needs to more tweaks. Looking at > the codes, what id does is actually introduce vri

Re: [PATCH v4 2/2] monitor: refactor set/expire_password and allow VNC display id

2021-10-14 Thread Stefan Reiter
On 10/14/21 9:14 AM, Markus Armbruster wrote: Stefan Reiter writes: On 10/12/21 11:24 AM, Markus Armbruster wrote: Stefan Reiter writes: It is possible to specify more than one VNC server on the command line, either with an explicit ID or the auto-generated ones à "default", "vnc2", "vnc3"

Re: [PATCH 00/16] fdt: Make OF_BOARD a boolean option

2021-10-14 Thread Tom Rini
On Wed, Oct 13, 2021 at 12:06:02PM -0600, Simon Glass wrote: > Hi François, > > On Wed, 13 Oct 2021 at 11:35, François Ozog wrote: > > > > Hi Simon > > > > Le mer. 13 oct. 2021 à 16:49, Simon Glass a écrit : > >> > >> Hi Tom, Bin,François, > >> > >> On Tue, 12 Oct 2021 at 19:34, Tom Rini wrote:

Re: [RFC PATCH v4 13/20] vdpa: Save host and guest features

2021-10-14 Thread Eugenio Perez Martin
On Wed, Oct 13, 2021 at 5:57 AM Jason Wang wrote: > > > 在 2021/10/1 下午3:05, Eugenio Pérez 写道: > > Those are needed for SVQ: Host ones are needed to check if SVQ knows > > how to talk with the device and for feature negotiation, and guest ones > > to know if SVQ can talk with it. > > > > Signed-off

Re: [RFC PATCH v4 15/20] vhost: Shadow virtqueue buffers forwarding

2021-10-14 Thread Eugenio Perez Martin
On Tue, Oct 12, 2021 at 3:48 PM Markus Armbruster wrote: > > Eugenio Perez Martin writes: > > > On Tue, Oct 12, 2021 at 7:21 AM Markus Armbruster wrote: > >> > >> Eugenio Pérez writes: > >> > >> > Initial version of shadow virtqueue that actually forward buffers. There > >> > are no iommu suppo

Re: [PATCH v3 1/9] bsd-user/mmap.c: Always zero MAP_ANONYMOUS memory in mmap_frag()

2021-10-14 Thread Kyle Evans
On Fri, Oct 8, 2021 at 4:24 PM Warner Losh wrote: > > From: Mikaël Urankar > > Similar to the equivalent linux-user commit e6deac9cf99 > > When mapping MAP_ANONYMOUS memory fragments, still need notice about to > set it zero, or it will cause issues. > > Signed-off-by: Mikaël Urankar > Signed-of

Re: [PATCH v3 2/9] bsd-user/mmap.c: check pread's return value to fix warnings with _FORTIFY_SOURCE

2021-10-14 Thread Kyle Evans
On Fri, Oct 8, 2021 at 4:24 PM Warner Losh wrote: > > From: Mikaël Urankar > > Simmilar to the equivalent linux-user: commit fb7e378cf9c, which added > checking to pread's return value. Update to current qemu standards with > {} around the if statement. > > Signed-off-by: Mikaël Urankar > Signed

Re: [PATCH v3 5/9] bsd-user/mmap.c: mmap prefer MAP_ANON for BSD

2021-10-14 Thread Kyle Evans
On Fri, Oct 8, 2021 at 4:24 PM Warner Losh wrote: > > MAP_ANON and MAP_ANONYMOUS are identical. Prefer MAP_ANON for BSD since > the file is now a confusing mix of the two. > > Signed-off-by: Warner Losh > Reviewed-by: Philippe Mathieu-Daudé > Reviewed-by: Richard Henderson > --- > bsd-user/mma

  1   2   3   4   >