Re: [PULL 03/20] nubus-device: expose separate super slot memory region

Le 02/10/2021 à 12:33, Peter Maydell a écrit : > On Wed, 29 Sept 2021 at 10:49, Laurent Vivier wrote: >> >> From: Mark Cave-Ayland >> >> According to "Designing Cards and Drivers for the Macintosh Family" each >> physical >> nubus slot can access 2 separate address ranges: a super slot memory re

[PATCH] docs: build-system: rename "default-configs" to "configs"

Commit 812b31d3f9 (configs: rename default-configs to configs and reorganise, 2021-07-07) did the rename. Reflect that update also in the documentation. Signed-off-by: Kashyap Chamarthy --- docs/devel/build-system.rst | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --gi

Re: [PATCH] docs: build-system: rename "default-configs" to "configs"

On 10/4/21 09:12, Kashyap Chamarthy wrote: > Commit 812b31d3f9 (configs: rename default-configs to configs and > reorganise, 2021-07-07) did the rename. > > Reflect that update also in the documentation. > > Signed-off-by: Kashyap Chamarthy > --- > docs/devel/build-system.rst | 12 ++--

Re: [PATCH v4 0/4] softmmu/memory_mapping: optimize dump/tpm for virtio-mem

On 02.10.21 11:55, Paolo Bonzini wrote: On 27/07/21 10:25, David Hildenbrand wrote: Minor fixes and cleanups, followed by an optimization for virtio-mem regarding guest dumps and tpm. virtio-mem logically plugs/unplugs memory within a sparse memory region and notifies via the RamDiscardMgr inte

Re: [PATCH v2 1/2] tcg: add dup_const_tl wrapper

On 10/3/21 23:42, Philipp Tomsich wrote: > dup_const always generates a uint64_t, which may exceed the size of a > target_long (generating warnings with recent-enough compilers). > > To ensure that we can use dup_const both for 64bit and 32bit targets, > this adds dup_const_tl, which either maps b

[PULL 05/26] linux-user/arm: Implement setup_sigtramp

From: Richard Henderson Mirror what the kernel does in arch/arm/kernel/signal.h, using the old sigframe struct in the rt sigframe struct. Update the trampoline code to match the kernel: this uses sp-relative accesses rather than pc-relative. Copy the code into frame->retcode from the trampoline

[PULL 02/26] linux-user/aarch64: Implement setup_sigtramp

From: Richard Henderson Create and record the rt signal trampoline. Use it when the guest does not use SA_RESTORER. Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-Id: <20210929130553.121567-3-richard.hender...@linaro.org> Signed-off-by:

Re: [PATCH v2 2/2] target/riscv: Use dup_const_tl in orc.b to legalise truncation of constant

On 10/3/21 23:42, Philipp Tomsich wrote: > We need to use the newly introduced dup_const_tl in orc.b to legalise > the truncation (to target_long) of the constant generated with dup_const. > > Signed-off-by: Philipp Tomsich > Reviewed-by: Richard Henderson > --- > > (no changes since v1) > >

[PULL 01/26] linux-user: Add infrastructure for a signal trampoline page

From: Richard Henderson Allocate a page to hold the signal trampoline(s). Invoke a guest-specific hook to fill in the contents of the page before marking it read-execute again. Reviewed-by: Max Filippov Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Signed-off-by: Richard Hend

[PULL 00/26] Linux user for 6.2 patches

x-user-for-6.2-pull-request for you to fetch changes up to efee71c8ca181d4f5b2211736b38a74a2a223375: tests/tcg/multiarch: Re-enable signals test for most guests (2021-10-01 12:03:48 +0200) Pull request linux-user 20211004 M

[PULL 03/26] linux-user/arm: Drop v1 signal frames

From: Richard Henderson Version 2 signal frames are used from 2.6.12 and since cbc14e6f286, we have set UNAME_MINIMUM_RELEASE to 2.6.32. Suggested-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-Id: <20210929130553.121567-4-richard.hender...@lina

[PULL 16/26] linux-user/nios2: Document non-use of setup_sigtramp

From: Richard Henderson Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20210929130553.121567-17-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/nios2/target_signal.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/linux-user/nios2/ta

[PULL 11/26] linux-user/x86_64: Raise SIGSEGV if SA_RESTORER not set

From: Richard Henderson This has been a fixme for some time. The effect of returning -EFAULT from the kernel code is to raise SIGSEGV. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20210929130553.121567-12-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier

[PULL 17/26] linux-user/openrisc: Implement setup_sigtramp

From: Richard Henderson Create and record the rt signal trampoline. Reviewed-by: Stafford Horne Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-Id: <20210929130553.121567-18-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/openrisc/sign

[PULL 14/26] linux-user/mips: Tidy install_sigtramp

From: Richard Henderson The return value is constant 0, and unused as well -- change to void. Drop inline marker. Change tramp type to uint32_t* for clarity. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-Id: <20210929130553.121567-15-richard.hender...@linaro.org

[PULL 26/26] tests/tcg/multiarch: Re-enable signals test for most guests

From: Richard Henderson With signal trampolines safely off the stack for all guests besides hppa, we can re-enable this test. It does show up a problem with sh4 (unrelated?), so leave that test disabled for now. Signed-off-by: Richard Henderson Message-Id: <20210929130553.121567-27-richard.hen

[PULL 19/26] linux-user/ppc: Implement setup_sigtramp

From: Richard Henderson Create and record the two signal trampolines. Cc: qemu-...@nongnu.org Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-Id: <20210929130553.121567-20-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/ppc/signal.c| 34

[PULL 04/26] linux-user/arm: Drop "_v2" from symbols in signal.c

From: Richard Henderson Since we no longer support "v1", there's no need to distinguish "v2". Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-Id: <20210929130553.121567-5-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/arm/signal.c | 11

[PULL 06/26] linux-user/alpha: Implement setup_sigtramp

From: Richard Henderson Create and record the two signal trampolines. Use them when the guest does not use ka_restorer. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-Id: <20210929130553.121567-7-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- li

[PULL 18/26] linux-user/ppc: Simplify encode_trampoline

From: Richard Henderson The sigret parameter is never 0, and even if it was the encoding of the LI instruction would still work. Reported-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-Id: <20210929130553.121567-19-richard.hender...@linaro.org>

[PULL 07/26] linux-user/cris: Implement setup_sigtramp

From: Richard Henderson Split out setup_sigreturn so that we can continue to initialize the words on the stack, as documented. However, use the off-stack trampoline. Cc: Edgar E. Iglesias Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-Id: <20210929130553.121567-8

Re: [RFC PATCH] hw/arm: fix the position of vcram for raspi

On 10/1/21 19:42, Alex Bennée wrote: > The previous calculation fell over when I tried to create a 8gb Pi 4 > because the values where only 32 bit. However the quirk of the Pi Typo 'where' -> 'were'? > hardware is the vcram can only appear in the first 1gb of address > space. This also limits whe

[PULL 15/26] linux-user/mips: Implement setup_sigtramp

From: Richard Henderson Create and record the two signal trampolines. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-Id: <20210929130553.121567-16-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/mips/signal.c | 34

[PULL 10/26] linux-user/i386: Implement setup_sigtramp

From: Richard Henderson Create and record the two signal trampolines. Use them when the guest does not use SA_RESTORER. Note that x86_64 does not use this code. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-Id: <20210929130553.121567-11-richard.hender...@linaro.o

Re: [PATCH v3 01/22] qapi/misc-target: Wrap long 'SEV Attestation Report' long lines

On 02/10/21 14:52, Philippe Mathieu-Daudé wrote: Wrap long lines before 70 characters for legibility. Suggested-by: Markus Armbruster Reviewed-by: Markus Armbruster Signed-off-by: Philippe Mathieu-Daudé --- qapi/misc-target.json | 17 ++--- 1 file changed, 10 insertions(+), 7 d

[PULL 09/26] linux-user/hppa: Document non-use of setup_sigtramp

From: Richard Henderson We cannot use a raw sigtramp page for hppa, but must wait for full vdso support. Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-Id: <20210929130553.121567-10-richard.hender...@linaro.org> Signed-off-by: Laurent Viv

[PULL 20/26] linux-user/riscv: Implement setup_sigtramp

From: Richard Henderson Create and record the rt signal trampoline. This fixes a bug wrt libgcc fallback unwinding. It expects the stack pointer to point to the siginfo_t, whereas we had inexplicably placed our private signal trampoline at the start of the signal frame instead of the end. Now

[PULL 21/26] linux-user/s390x: Implement setup_sigtramp

From: Richard Henderson Create and record the two signal trampolines. Use them when the guest does not use SA_RESTORER. Cc: qemu-s3...@nongnu.org Tested-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-Id: <20210929130553.121567-22-richard.hender...

Re: [PATCH v3 11/16] iotests/297: return error code from run_linters()

On 22.09.21 22:18, John Snow wrote: On Fri, Sep 17, 2021 at 7:00 AM Hanna Reitz > wrote: [...] As you say, run_linters() to me seems very iotests-specific still: It emits a specific output that is compared against a reference output. Fine for 297, but

[PULL 13/26] linux-user/microblaze: Implement setup_sigtramp

From: Richard Henderson Create and record the rt signal trampoline. Cc: Edgar E. Iglesias Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-Id: <20210929130553.121567-14-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/microblaze/signal.c

Re: [PATCH v3 02/22] qapi/misc-target: Group SEV QAPI definitions

On 02/10/21 14:52, Philippe Mathieu-Daudé wrote: There is already a section with various SEV commands / types, so move the SEV guest attestation together. Signed-off-by: Philippe Mathieu-Daudé --- qapi/misc-target.json | 80 +-- 1 file changed, 40 inse

[PULL 12/26] linux-user/m68k: Implement setup_sigtramp

From: Richard Henderson Create and record the two signal trampolines. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-Id: <20210929130553.121567-13-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/m68k/signal.c| 47 ++

[PULL 24/26] linux-user/xtensa: Implement setup_sigtramp

From: Richard Henderson Create and record the rt signal trampoline. Use it when the guest does not use SA_RESTORER. Reviewed-by: Max Filippov Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-Id: <20210929130553.121567-25-richard.hender...@linaro.org> Signed-off-by:

Re: [PATCH v3 10/22] target/i386/sev: sev_get_attestation_report use g_autofree

On 02/10/21 14:53, Philippe Mathieu-Daudé wrote: From: "Dr. David Alan Gilbert" Removes a whole bunch of g_free's and a goto. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Connor Kuehl Reviewed-by: Brijesh Singh Message-Id: <20210603113017.34922-1-dgilb...@redhat.com> Signed-off-by: Ph

[PULL 08/26] linux-user/hexagon: Implement setup_sigtramp

From: Richard Henderson Continue to initialize the words on the stack, as documented. However, use the off-stack trampoline. Reviewed-by: Taylor Simpson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-Id: <20210929130553.121567-9-richard.hender...@linaro.org> Sign

[PULL 25/26] linux-user: Remove default for TARGET_ARCH_HAS_SIGTRAMP_PAGE

From: Richard Henderson All targets now define TARGET_ARCH_HAS_SIGTRAMP_PAGE. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-Id: <20210929130553.121567-26-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/elfload.c | 4 1 file chang

Re: [PATCH v3 11/22] target/i386/sev: Restrict SEV to system emulation

On 02/10/21 14:53, Philippe Mathieu-Daudé wrote: SEV is irrelevant on user emulation, so restrict it to sysemu. Some stubs are still required because used in cpu.c by x86_register_cpudef_types(), so move the sysemu specific stubs to sev-sysemu-stub.c instead. This will allow us to simplify monito

Re: [PATCH v3 03/22] target/i386/kvm: Introduce i386_softmmu_kvm Meson source set

On 02/10/21 14:52, Philippe Mathieu-Daudé wrote: Introduce the i386_softmmu_kvm Meson source set to be able to add features dependent on CONFIG_KVM. Signed-off-by: Philippe Mathieu-Daudé --- target/i386/kvm/meson.build | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/

[PULL 23/26] linux-user/sparc: Implement setup_sigtramp

From: Richard Henderson Create and record the two signal trampolines. Use them when the guest does not use SA_RESTORER. Acked-by: Mark Cave-Ayland Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-Id: <20210929130553.121567-24-richard.hen

[PULL 22/26] linux-user/sh4: Implement setup_sigtramp

From: Richard Henderson Create and record the two signal trampolines. Use them when the guest does not use SA_RESTORER. Cc: Yoshinori Sato Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-Id: <20210929130553.121567-23-richard.hender...@linaro.org> Signed-off-by: La

Re: [PATCH v3 12/22] target/i386/sev: Declare system-specific functions in 'sev_i386.h'

On 02/10/21 14:53, Philippe Mathieu-Daudé wrote: While prefixed with sysemu, 'sysemu/sev.h' contains the architecture specific declarations. The system specific parts are declared in 'sev_i386.h'. While outside target/i386, 'sysemu/sev.h' contains some architecture specific declarations. Move

Re: [PATCH v4 0/2] x86/sev: Measured Linux SEV guest with kernel/initrd/cmdline

Queued, thanks. However, it would be nice to have a documentation of all our SEV firmware interfaces somewhere in docs/specs/. Paolo On Thu, Sep 30, 2021 at 7:49 AM Dov Murik wrote: > > Currently booting with -kernel/-initrd/-append is not supported in SEV > confidential guests, because the con

Re: [PATCH v3 04/22] target/i386/kvm: Restrict SEV stubs to x86 architecture

On 02/10/21 14:52, Philippe Mathieu-Daudé wrote: SEV is x86-specific, no need to add its stub to other architectures. Move the stub file to target/i386/kvm/. Signed-off-by: Philippe Mathieu-Daudé --- {accel => target/i386}/kvm/sev-stub.c | 0 accel/kvm/meson.build | 1 - tar

Re: [PATCH v3 07/16] iotests/297: Don't rely on distro-specific linter binaries

On 22.09.21 21:53, John Snow wrote: (This email just explains python packaging stuff. No action items in here. Skim away.) On Fri, Sep 17, 2021 at 5:43 AM Hanna Reitz > wrote: On 16.09.21 06:09, John Snow wrote: > 'pylint-3' is another Fedora-ism. Use "python

Re: [PATCH v3 05/22] target/i386/monitor: Return QMP error when SEV is disabled in build

On 02/10/21 14:53, Philippe Mathieu-Daudé wrote: If the management layer tries to inject a secret, it gets an empty response in case the binary built without SEV: { "execute": "sev-inject-launch-secret", "arguments": { "packet-header": "mypkt", "secret": "mypass", "gpa": 4294959104 }

Re: [PATCH v2 1/2] hw/adc: Add basic Aspeed ADC model

On 10/3/21 21:18, p...@fb.com wrote: From: Andrew Jeffery This model implements enough behaviour to do basic functionality tests such as device initialisation and read out of dummy sample values. The sample value generation strategy is similar to the STM ADC already in the tree. Signed-off-by:

Re: [PATCH v3 13/22] target/i386/sev: Remove stubs by using code elision

On 02/10/21 14:53, Philippe Mathieu-Daudé wrote: Only declare sev_enabled() and sev_es_enabled() when CONFIG_SEV is set, to allow the compiler to elide unused code. Remove unnecessary stubs. Signed-off-by: Philippe Mathieu-Daudé --- include/sysemu/sev.h| 14 +- target/i386/se

Re: [PATCH v3 14/22] target/i386/sev: Move qmp_query_sev_attestation_report() to sev.c

On 02/10/21 14:53, Philippe Mathieu-Daudé wrote: Move qmp_query_sev_attestation_report() from monitor.c to sev.c and make sev_get_attestation_report() static. We don't need the stub anymore, remove it. Signed-off-by: Philippe Mathieu-Daudé This was done on purpose, but I have no objection to

Re: [PATCH v3 07/22] target/i386/sev_i386.h: Remove unused headers

On 02/10/21 14:53, Philippe Mathieu-Daudé wrote: Declarations don't require these headers, remove them. Reviewed-by: Connor Kuehl Signed-off-by: Philippe Mathieu-Daudé --- target/i386/sev_i386.h | 4 target/i386/sev-stub.c | 1 + 2 files changed, 1 insertion(+), 4 deletions(-) diff -

Re: [PATCH v3 15/22] target/i386/sev: Move qmp_sev_inject_launch_secret() to sev.c

On 02/10/21 14:53, Philippe Mathieu-Daudé wrote: Move qmp_sev_inject_launch_secret() from monitor.c to sev.c and make sev_inject_launch_secret() static. We don't need the stub anymore, remove it. Signed-off-by: Philippe Mathieu-Daudé --- target/i386/monitor.c | 31

Re: [PATCH v3 22/22] MAINTAINERS: Cover AMD SEV files

On 02/10/21 14:53, Philippe Mathieu-Daudé wrote: Add an entry to list SEV-related files. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 50435b8d2f5..733a5201e76 100644 --- a/MAINTAINERS +++ b/MA

Re: [PATCH v3 06/22] target/i386/cpu: Add missing 'qapi/error.h' header

On 02/10/21 14:53, Philippe Mathieu-Daudé wrote: Commit 00b81053244 ("target-i386: Remove assert_no_error usage") forgot to add the "qapi/error.h" for &error_abort, add it now. Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Connor Kuehl Signed-off-by: Philippe Mathieu-Daudé --- target/i38

Re: [PATCH v3 08/22] target/i386/sev: Remove sev_get_me_mask()

On 02/10/21 14:53, Philippe Mathieu-Daudé wrote: Unused dead code makes review harder, so remove it. Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Connor Kuehl Signed-off-by: Philippe Mathieu-Daudé --- target/i386/sev_i386.h | 1 - target/i386/sev-stub.c | 5 - target/i386/sev.c

Re: [PATCH v3 18/22] target/i386/sev: Move qmp_query_sev() & hmp_info_sev() to sev.c

On 02/10/21 14:53, Philippe Mathieu-Daudé wrote: Move qmp_query_sev() & hmp_info_sev()() from monitor.c to sev.c and make sev_get_info() static. We don't need the stub anymore, remove it. Add a stub for hmp_info_sev(). Signed-off-by: Philippe Mathieu-Daudé --- target/i386/sev_i386.h|

Re: [PATCH v3 08/22] target/i386/sev: Remove sev_get_me_mask()

On 02/10/21 14:53, Philippe Mathieu-Daudé wrote: Unused dead code makes review harder, so remove it. Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Connor Kuehl Signed-off-by: Philippe Mathieu-Daudé --- target/i386/sev_i386.h | 1 - target/i386/sev-stub.c | 5 - target/i386/sev.c

[PULL 3/5] qemu-options: Add missing "sockets=2, maxcpus=2" to CLI "-smp 2"

From: Yanan Wang There is one numa config example in qemu-options.hx currently using "-smp 2" and assuming that there will be 2 sockets and 2 cpus totally. However now the actual calculation logic of missing sockets and cores is not immutable and is considered liable to change. Although we will g

Re: [PATCH v3 09/22] target/i386/sev: Mark unreachable code with g_assert_not_reached()

On 02/10/21 14:53, Philippe Mathieu-Daudé wrote: The unique sev_encrypt_flash() invocation (in pc_system_flash_map) is protected by the "if (sev_enabled())" check, so is not reacheable. Replace the abort() call in sev_es_save_reset_vector() by g_assert_not_reached() which meaning is clearer. Rev

[PULL 5/5] hw/remote/proxy: Categorize Wireless devices as 'Network' ones

From: Philippe Mathieu-Daudé QEMU doesn't distinct network devices per link layer (Ethernet, Wi-Fi, CAN, ...). Categorize PCI Wireless cards as Network devices. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Jagannathan Raman Message-Id: <20210926201926.1690896-1-f4...@amsat.org> Signed-of

Re: [PATCH v3 16/22] target/i386/sev: Move qmp_query_sev_capabilities() to sev.c

On 02/10/21 14:53, Philippe Mathieu-Daudé wrote: Move qmp_query_sev_capabilities() from monitor.c to sev.c and make sev_get_capabilities() static. We don't need the stub anymore, remove it. Signed-off-by: Philippe Mathieu-Daudé --- target/i386/sev_i386.h| 1 - target/i386/monitor.c

Re: [PATCH v3 14/16] iotests/linters: Add workaround for mypy bug #9852

On 22.09.21 22:38, John Snow wrote: On Wed, Sep 22, 2021 at 4:37 PM John Snow > wrote: On Fri, Sep 17, 2021 at 7:16 AM Hanna Reitz mailto:hre...@redhat.com>> wrote: Question is, when “can we use” mypy >= 0.920? Should we check the version string

[PULL 2/5] qemu-options: Tweak [, maxcpus=cpus] to [, maxcpus=maxcpus]

From: Yanan Wang In qemu-option.hx, there is "-smp [[cpus=]n][,maxcpus=cpus]..." in the DEF part, and "-smp [[cpus=]n][,maxcpus=maxcpus]..." in the RST part. Obviously the later is right, let's fix the previous one. Signed-off-by: Yanan Wang Reviewed-by: Damien Hedde Reviewed-by: Daniel P. Ber

Re: [PATCH] hw/misc: applesmc: use host osk as default on macs

On 02/10/21 22:24, Pedro Tôrres wrote: #define APPLESMC_DEFAULT_IOBASE0x300 @@ -332,7 +497,27 @@ static void applesmc_isa_realize(DeviceState *dev, Error **errp) s->iobase + APPLESMC_ERR_PORT); if (!s->osk || (strlen(s->osk) != 64)) { +#if defined(__APPLE_

Re: [PATCH v3 17/22] target/i386/sev: Move qmp_query_sev_launch_measure() to sev.c

On 02/10/21 14:53, Philippe Mathieu-Daudé wrote: Move qmp_query_sev_launch_measure() from monitor.c to sev.c and make sev_get_launch_measurement() static. We don't need the stub anymore, remove it. Signed-off-by: Philippe Mathieu-Daudé --- target/i386/sev_i386.h| 1 - target/i386/mo

[PULL 1/5] qemu-options: -chardev reconnect=seconds duplicated in help, tidy up

From: Markus Armbruster Fixes: 5dd1f02b4bc2f2c2ef3a2adfd8a412c8c8769085 Signed-off-by: Markus Armbruster Reviewed-by: Daniel P. Berrangé Message-Id: <20210928071449.1416022-1-arm...@redhat.com> Signed-off-by: Laurent Vivier --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletio

Re: [PATCH 01/12] macfb: handle errors that occur during realize

Le 02/10/2021 à 12:59, Mark Cave-Ayland a écrit : > Make sure any errors that occur within the macfb realize chain are detected > and handled correctly to prevent crashes and to ensure that error messages are > reported back to the user. > > Signed-off-by: Mark Cave-Ayland > --- > hw/display/mac

Re: [PATCH v3 19/22] monitor: Restrict 'info sev' to x86 targets

On 02/10/21 14:53, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- include/monitor/hmp-target.h | 1 + include/monitor/hmp.h | 1 - target/i386/sev-sysemu-stub.c | 2 +- target/i386/sev.c | 2 +- 4 files changed, 3 insertions(+), 3 deletions(-)

Re: [PATCH v3 14/16] iotests/linters: Add workaround for mypy bug #9852

On 22.09.21 22:37, John Snow wrote: On Fri, Sep 17, 2021 at 7:16 AM Hanna Reitz > wrote: On 16.09.21 06:09, John Snow wrote: > This one is insidious: if you use the invocation > "from {namespace} import {subpackage}" as mirror-top-perms does, > mypy w

Re: [PATCH 04/12] macfb: use memory_region_init_ram() in macfb_common_realize() for the framebuffer

Le 02/10/2021 à 12:59, Mark Cave-Ayland a écrit : > Currently macfb_common_realize() defines the framebuffer RAM memory region as > being non-migrateable but then immediately registers it for migration. Replace > memory_region_init_ram_nomigrate() with memory_region_init_ram() which is > clearer >

Re: [PATCH v3 00/22] target/i386/sev: Housekeeping SEV + measured Linux SEV guest

On 02/10/21 14:52, Philippe Mathieu-Daudé wrote: Hi, While testing James & Dov patch: https://www.mail-archive.com/qemu-devel@nongnu.org/msg810571.html I wasted some time trying to figure out how OVMF was supposed to behave until realizing the binary I was using was built without SEV support...

Re: [RFC PATCH 1/1] virtio: write back features before verify

On Mon, Oct 04, 2021 at 04:23:23AM +0200, Halil Pasic wrote: > On Sat, 2 Oct 2021 14:13:37 -0400 > "Michael S. Tsirkin" wrote: > > > > Anyone else have an idea? This is a nasty regression; we could revert the > > > patch, which would remove the symptoms and give us some time, but that > > > doesn

Re: [PATCH 05/12] macfb: add trace events for reading and writing the control registers

Le 02/10/2021 à 13:00, Mark Cave-Ayland a écrit : > Signed-off-by: Mark Cave-Ayland > --- > hw/display/macfb.c | 8 +++- > hw/display/trace-events | 4 > 2 files changed, 11 insertions(+), 1 deletion(-) > > diff --git a/hw/display/macfb.c b/hw/display/macfb.c > index e86f64..62

[PULL 0/5] Trivial branch for 6.2 patches

The following changes since commit 30bd1db58b09c12b68c35f041f919014b885482d: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2021-10-03 08:45:19 -0400) are available in the Git repository at: git://github.com/vivier/qemu.git tags/trivial-branch-for-6.2-pull-re

Re: [PATCH 1/1] hw: aspeed_gpio: Fix GPIO array indexing

On 9/28/21 05:43, p...@fb.com wrote: From: Peter Delevoryas The gpio array is declared as a dense array: qemu_irq gpios[ASPEED_GPIO_NR_PINS]; (AST2500 has 228, AST2400 has 216, AST2600 has 208) However, this array is used like a matrix of GPIO sets (e.g. gpio[NR_SETS][NR_PINS_PER_SET] = g

[PULL 4/5] target/sh4: Use lookup_symbol in sh4_tr_disas_log

From: Richard Henderson The correct thing to do has been present but commented out since the initial commit of the sh4 translator. Fixes: fdf9b3e831e Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210929130316.121330-1-richard.hender...@linaro.org> Signed-o

[PATCH] MAINTAINERS: Split HPPA TCG vs HPPA machines/hardware

Hardware emulated models don't belong to the TCG MAINTAINERS section. Move them to the 'HP-PARISC Machines' section. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 50435b8d2f5..002620c

Re: Moving QEMU downloads to GitLab Releases?

On Fri, Oct 01, 2021 at 09:39:13AM +0200, Philippe Mathieu-Daudé wrote: > On 9/30/21 15:40, Stefan Hajnoczi wrote: > > Hi Mike, > > QEMU downloads are currently hosted on qemu.org's Apache web server. > > Paolo and I were discussing ways to reduce qemu.org network traffic to > > save money and even

Re: [PATCH 03/12] macfb: fix overflow of color_palette array

Le 02/10/2021 à 12:59, Mark Cave-Ayland a écrit : > The palette_current index counter has a maximum size of 256 * 3 to cover a > full > color palette of 256 RGB entries. Linux assumes that the palette_current index > wraps back around to zero after writing 256 RGB entries so ensure that > palette_

Re: [PATCH 02/12] macfb: fix invalid object reference in macfb_common_realize()

Le 02/10/2021 à 12:59, Mark Cave-Ayland a écrit : > During realize memory_region_init_ram_nomigrate() is used to initialise the > RAM > memory region used for the framebuffer but the owner object reference is > incorrect since MacFbState is a typedef and not a QOM type. > > Change the memory regi

Re: [PATCH 06/12] macfb: implement mode sense to allow display type to be detected

Le 02/10/2021 à 13:00, Mark Cave-Ayland a écrit : > The MacOS toolbox ROM uses the monitor sense to detect the display type and > then > offer a fixed set of resolutions and colour depths accordingly. Implement the > monitor sense using information found in Apple Technical Note HW26: "Macintosh >

Re: Moving QEMU downloads to GitLab Releases?

On Fri, Oct 01, 2021 at 09:52:20AM +0100, Daniel P. Berrangé wrote: > On Fri, Oct 01, 2021 at 08:11:35AM +0100, Stefan Hajnoczi wrote: > > We need to keep the security of QEMU releases in mind. Mike Roth > > signs and publishes releases. Whoever facilitates or hosts the files > > should not be able

Re: [PATCH v3 2/3] hw/virtio: Acquire RCU read lock in virtqueue_packed_drop_all()

On Mon, Sep 06, 2021 at 12:43:17PM +0200, Philippe Mathieu-Daudé wrote: > vring_get_region_caches() must be called with the RCU read lock > acquired. virtqueue_packed_drop_all() does not, and uses the > 'caches' pointer. Fix that by using the RCU_READ_LOCK_GUARD() > macro. Is this a bug that has b

Re: [PATCH 03/15] python/aqmp: Return cleared events from EventListener.clear()

On 17.09.21 19:19, John Snow wrote: On Fri, Sep 17, 2021 at 8:36 AM Hanna Reitz > wrote: On 17.09.21 07:40, John Snow wrote: > This serves two purposes: > > (1) It is now possible to discern whether or not clear() removed any > event(s) from the q

Re: [PATCH v3 3/3] hw/virtio: Have virtqueue_get_avail_bytes() pass caches arg to callees

On Mon, Sep 06, 2021 at 12:43:18PM +0200, Philippe Mathieu-Daudé wrote: > Both virtqueue_packed_get_avail_bytes() and > virtqueue_split_get_avail_bytes() access the region cache, but > their caller also does. Simplify by having virtqueue_get_avail_bytes > calling both with RCU lock held, and passin

[PATCH 3/5] hexagon: use env keyword argument to pass PYTHONPATH

This feature is new in meson 0.57 and allows getting rid of the "env" wrapper. Signed-off-by: Paolo Bonzini --- target/hexagon/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/hexagon/meson.build b/target/hexagon/meson.build index 6fd9360b74..c6d858ffb2 10

Re: [PATCH v3 1/3] hw/virtio: Comment virtqueue_flush() must be called with RCU read lock

On Mon, Sep 27, 2021 at 01:29:46PM +0200, Cornelia Huck wrote: > On Mon, Sep 27 2021, Philippe Mathieu-Daudé wrote: > > > On 9/27/21 12:18, Cornelia Huck wrote: > >> On Mon, Sep 06 2021, Philippe Mathieu-Daudé wrote: > >> > >>> Reported-by: Stefano Garzarella > >>> Suggested-by: Stefan Hajnocz

Re: [PATCH 07/12] macfb: add qdev property to specify display type

Le 02/10/2021 à 13:00, Mark Cave-Ayland a écrit : > Since the available resolutions and colour depths are determined by the > attached > display type, add a qdev property to allow the display type to be specified. > > The main resolutions of interest are high resolution 1152x870 with 8-bit > col

[PATCH 4/4] MAINTAINERS: Agree to maintain nanoMIPS TCG frontend

As of this commit, the nanoMIPS toolchains haven't been merged in mainstream projects. However MediaTek provides a toolchain: https://github.com/MediaTek-Labs/nanomips-gnu-toolchain/releases/tag/nanoMIPS-2021.02-01 Since I now have spent more time with the ISA, I agree to maintain it along with th

[PATCH 0/4] MAINTAINERS: Sanitize 'MIPS TCG CPUs' section

Move various files unrelated to MIPS TCG frontend into new sections. Philippe Mathieu-Daudé (4): MAINTAINERS: Add MIPS general architecture support entry MAINTAINERS: Add entries to cover MIPS CPS / GIC hardware MAINTAINERS: Split MIPS TCG frontend vs MIPS machines/hardware MAINTAINERS: Ag

Re: [PATCH v3 2/3] hw/virtio: Acquire RCU read lock in virtqueue_packed_drop_all()

On 10/4/21 11:23, Stefan Hajnoczi wrote: > On Mon, Sep 06, 2021 at 12:43:17PM +0200, Philippe Mathieu-Daudé wrote: >> vring_get_region_caches() must be called with the RCU read lock >> acquired. virtqueue_packed_drop_all() does not, and uses the >> 'caches' pointer. Fix that by using the RCU_READ_L

[PATCH 1/4] MAINTAINERS: Add MIPS general architecture support entry

The architecture is covered in TCG (frontend and backend) and hardware models. Add a generic section matching the 'mips' word in patch subjects. Cc: Jiaxun Yang Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/MAINTA

[PATCH 2/4] MAINTAINERS: Add entries to cover MIPS CPS / GIC hardware

MIPS CPS and GIC models are unrelated to the TCG frontend. Move them as new sections under the 'Devices' group. Cc: Paul Burton Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/MAINTAINERS b/MAINTAI

[PATCH 5/5] meson: show library versions in the summary

Meson 0.57 allows passing external programs and dependency objects to summary(). Use this to show library versions and paths in the summary. Signed-off-by: Paolo Bonzini --- meson.build | 112 +--- 1 file changed, 54 insertions(+), 58 deletions(-)

[PATCH 0/5] Upgrade minimum Meson version to 0.58.2, recommended to 0.59.2

Now that 0.59.2 is out, we can show library versions in the summary. Since that feature is supported in 0.58.2 but broken in 0.59.{0,1}, allow --meson= to use 0.58.2 but default to the bundled submodule if the host has anything less than 0.59.2. Paolo Paolo Bonzini (5): meson: bump submodule to

[PATCH 3/4] MAINTAINERS: Split MIPS TCG frontend vs MIPS machines/hardware

Hardware emulated models don't belong to the TCG MAINTAINERS section. Move them to a new 'Overall MIPS Machines' section in the 'MIPS Machines' group. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS

[PATCH 1/5] meson: bump submodule to 0.59.2

The update to 0.57 has been delayed due to it causing warnings for some actual issues, but it brings in important bugfixes and new features. 0.58 also brings in a bugfix that is useful for modinfo. Important bugfixes: - 0.57: https://github.com/mesonbuild/meson/pull/7760, build: use PIE objects

Re: [PATCH 12/12] q800: wire macfb IRQ to separate video interrupt on VIA2

Le 02/10/2021 à 13:00, Mark Cave-Ayland a écrit : > Whilst the in-built Quadra 800 framebuffer exists within the Nubus address > space for slot 9, it has its own dedicated interrupt on VIA2. Force the > macfb device to occupy slot 9 in the q800 machine and wire its IRQ to the > separate video inter

Re: [PATCH 10/15] python/machine: Add support for AQMP backend

On 18.09.21 01:48, John Snow wrote: On Fri, Sep 17, 2021 at 10:16 AM Hanna Reitz > wrote: On 17.09.21 07:40, John Snow wrote: > To use the AQMP backend, Machine just needs to be a little more diligent > about what happens when closing a QMP connection

[PATCH 2/5] meson: switch minimum meson version to 0.58.2, minimum recommended to 0.59.2

Meson 0.58.2 does not need b_staticpic=$pie anymore, and has stabilized the keyval module. Remove the workaround and use a few replacements for features deprecated in the 0.57.0 release cycle. One feature that we would like to use is passing dependencies to summary. However, that was broken in 0

Re: [PATCH v3 14/22] target/i386/sev: Move qmp_query_sev_attestation_report() to sev.c

* Philippe Mathieu-Daudé (phi...@redhat.com) wrote: > Move qmp_query_sev_attestation_report() from monitor.c to sev.c > and make sev_get_attestation_report() static. We don't need the > stub anymore, remove it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/i386/sev_i386.h| 2

Re: [PATCH 12/15] iotests: Disable AQMP logging under non-debug modes

On 18.09.21 02:58, John Snow wrote: On Fri, Sep 17, 2021 at 10:30 AM Hanna Reitz > wrote: On 17.09.21 07:40, John Snow wrote: > Disable the aqmp logger, which likes to (at the moment) print out > intermediate warnings and errors that cause session termina

  1   2   3   >