[RFC PATCH v4 04/20] vhost: Make vhost_virtqueue_{start,stop} public

2021-10-01 Thread Eugenio Pérez
The easier way to reset vhost behavior after enabling shadow virtqueue is to call vhost_virtqueue_start. Also, vhost_virtqueue_stop provides the simmetrical call to it, and it will be used. Signed-off-by: Eugenio Pérez --- include/hw/virtio/vhost.h | 4 hw/virtio/vhost.c | 12 -

[RFC PATCH v4 07/20] vdpa: Register vdpa devices in a list

2021-10-01 Thread Eugenio Pérez
This way QMP command can iterate through them and find the devices it needs to enable shadow virtqueue in. Signed-off-by: Eugenio Pérez --- include/hw/virtio/vhost-vdpa.h | 2 ++ hw/virtio/vhost-vdpa.c | 5 + 2 files changed, 7 insertions(+) diff --git a/include/hw/virtio/vhost-vdpa

[RFC PATCH v4 03/20] virtio: Add virtio_queue_is_host_notifier_enabled

2021-10-01 Thread Eugenio Pérez
This allows shadow virtqueue code to assert the queue status before making changes. Signed-off-by: Eugenio Pérez --- include/hw/virtio/virtio.h | 1 + hw/virtio/virtio.c | 5 + 2 files changed, 6 insertions(+) diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h inde

[RFC PATCH v4 00/20] vDPA shadow virtqueue

2021-10-01 Thread Eugenio Pérez
This series enable shadow virtqueue (SVQ) for vhost-vdpa devices. This is intended as a new method of tracking the memory the devices touch during a migration process: Instead of relay on vhost device's dirty logging capability, SVQ intercepts the VQ dataplane forwarding the descriptors between VM

[RFC PATCH v4 05/20] vhost: Add x-vhost-enable-shadow-vq qmp

2021-10-01 Thread Eugenio Pérez
Command to enable shadow virtqueue. Signed-off-by: Eugenio Pérez --- qapi/net.json | 23 +++ hw/virtio/vhost-vdpa.c | 8 2 files changed, 31 insertions(+) diff --git a/qapi/net.json b/qapi/net.json index 7fab2e7cd8..a2c30fd455 100644 --- a/qapi/net.json ++

[RFC PATCH v4 09/20] vdpa: Save call_fd in vhost-vdpa

2021-10-01 Thread Eugenio Pérez
We need to know it to switch to Shadow VirtQueue. Signed-off-by: Eugenio Pérez --- include/hw/virtio/vhost-vdpa.h | 2 ++ hw/virtio/vhost-vdpa.c | 5 + 2 files changed, 7 insertions(+) diff --git a/include/hw/virtio/vhost-vdpa.h b/include/hw/virtio/vhost-vdpa.h index 48aae59d8e..fdd

[RFC PATCH v4 01/20] virtio: Add VIRTIO_F_QUEUE_STATE

2021-10-01 Thread Eugenio Pérez
virtio: Add VIRTIO_F_QUEUE_STATE Implementation of RFC of device state capability: https://lists.oasis-open.org/archives/virtio-comment/202012/msg5.html With this capability, vdpa device can reset it's index so it can start consuming from guest after disabling shadow virtqueue (SVQ), with sta

[RFC PATCH v4 02/20] virtio-net: Honor VIRTIO_CONFIG_S_DEVICE_STOPPED

2021-10-01 Thread Eugenio Pérez
So the guest can stop and start net device. It freely implements the RFC https://lists.oasis-open.org/archives/virtio-comment/202012/msg00027.html To stop (as "pause") the device is required to migrate status and vring addresses between device and SVQ. Once the device is stopped, the driver can re

[RFC PATCH v4 06/20] vhost: Add VhostShadowVirtqueue

2021-10-01 Thread Eugenio Pérez
Vhost shadow virtqueue (SVQ) is an intermediate jump for virtqueue notifications and buffers, allowing qemu to track them. While qemu is forwarding the buffers and virtqueue changes, is able to commit the memory it's being dirtied, the same way regular qemu's VirtIO devices do. This commit only ex

[RFC PATCH v4 10/20] vhost-vdpa: Take into account SVQ in vhost_vdpa_set_vring_call

2021-10-01 Thread Eugenio Pérez
Signed-off-by: Eugenio Pérez --- hw/virtio/vhost-vdpa.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c index 57a857444a..bc34de2439 100644 --- a/hw/virtio/vhost-vdpa.c +++ b/hw/virtio/vhost-vdpa.c @@ -649,16 +

[RFC PATCH v4 12/20] virtio: Add vhost_shadow_vq_get_vring_addr

2021-10-01 Thread Eugenio Pérez
It reports the shadow virtqueue address from qemu virtual address space Signed-off-by: Eugenio Pérez --- hw/virtio/vhost-shadow-virtqueue.h | 4 +++ hw/virtio/vhost-shadow-virtqueue.c | 50 ++ 2 files changed, 54 insertions(+) diff --git a/hw/virtio/vhost-shadow-vir

[RFC PATCH v4 08/20] vhost: Route guest->host notification through shadow virtqueue

2021-10-01 Thread Eugenio Pérez
Shadow virtqueue notifications forwarding is disabled when vhost_dev stops, so code flow follows usual cleanup. Also, host notifiers must be disabled at SVQ start, and they will not start if SVQ has been enabled when device is stopped. This is trivial to address, but it is left out for simplicity

Re: Moving QEMU downloads to GitLab Releases?

2021-10-01 Thread Stefan Hajnoczi
On Thu, Sep 30, 2021 at 03:57:49PM +, Eldon Stegall wrote: > Hello! > I'd be happy to help with this. I'm mostly a consumer of QEMU, but > greatly appreciate all the work this community has done, and was able > to contribute a little by helping with QEMU advent this past year. I > would be happ

[RFC PATCH v4 13/20] vdpa: Save host and guest features

2021-10-01 Thread Eugenio Pérez
Those are needed for SVQ: Host ones are needed to check if SVQ knows how to talk with the device and for feature negotiation, and guest ones to know if SVQ can talk with it. Signed-off-by: Eugenio Pérez --- include/hw/virtio/vhost-vdpa.h | 2 ++ hw/virtio/vhost-vdpa.c | 31 +

[RFC PATCH v4 17/20] vhost: Use VRING_AVAIL_F_NO_INTERRUPT at device call on shadow virtqueue

2021-10-01 Thread Eugenio Pérez
Signed-off-by: Eugenio Pérez --- hw/virtio/vhost-shadow-virtqueue.c | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/hw/virtio/vhost-shadow-virtqueue.c b/hw/virtio/vhost-shadow-virtqueue.c index 775f8d36a0..2fd0bab75d 100644 --- a/hw/virtio/vhost-shado

[RFC PATCH v4 11/20] vhost: Route host->guest notification through shadow virtqueue

2021-10-01 Thread Eugenio Pérez
This will make qemu aware of the device used buffers, allowing it to write the guest memory with its contents if needed. Since the use of vhost_virtqueue_start can unmasks and discard call events, vhost_virtqueue_start should be modified in one of these ways: * Split in two: One of them uses all l

[RFC PATCH v4 14/20] vhost: Add vhost_svq_valid_device_features to shadow vq

2021-10-01 Thread Eugenio Pérez
This allows it to test if the guest has aknowledge an invalid transport feature for SVQ. This will include packed vq layout, invalid descriptors or event idx at the moment we start forwarding buffers. We don't check for device features here since they will be re-negotiated again. This allows SVQ t

[RFC PATCH v4 19/20] vhost: Use a tree to store memory mappings

2021-10-01 Thread Eugenio Pérez
Track memory translations of devices with IOMMU (all vhost-vdpa devices at the moment). It does not work if device has restrictions in its iova range at the moment. Updates to tree are protected by BQL, each one always run from main event loop context. Signed-off-by: Eugenio Pérez --- include/h

[RFC PATCH v4 15/20] vhost: Shadow virtqueue buffers forwarding

2021-10-01 Thread Eugenio Pérez
Initial version of shadow virtqueue that actually forward buffers. There are no iommu support at the moment, and that will be addressed in future patches of this series. Since all vhost-vdpa devices uses forced IOMMU, this means that SVQ is not usable at this point of the series on any device. For

[RFC PATCH v4 16/20] vhost: Check for device VRING_USED_F_NO_NOTIFY at shadow virtqueue kick

2021-10-01 Thread Eugenio Pérez
Signed-off-by: Eugenio Pérez --- hw/virtio/vhost-shadow-virtqueue.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/hw/virtio/vhost-shadow-virtqueue.c b/hw/virtio/vhost-shadow-virtqueue.c index df7e6fa3ec..775f8d36a0 100644 --- a/hw/virtio/vhost-shadow-virtqueue.c

Re: Moving QEMU downloads to GitLab Releases?

2021-10-01 Thread Thomas Huth
On 30/09/2021 16.28, Stefan Hajnoczi wrote: On Thu, Sep 30, 2021 at 3:08 PM Stefan Hajnoczi wrote: Hi Mike, QEMU downloads are currently hosted on qemu.org's Apache web server. Paolo and I were discussing ways to reduce qemu.org network traffic to save money and eventually turn off the qemu.or

[RFC PATCH v4 20/20] vdpa: Add custom IOTLB translations to SVQ

2021-10-01 Thread Eugenio Pérez
Use translations added in VhostIOVATree in SVQ. Now every element needs to store the previous address also, so VirtQueue can consume the elements properly. This adds a little overhead per VQ element, having to allocate more memory to stash them. As a possible optimization, this allocation could be

[RFC PATCH v4 18/20] vhost: Add VhostIOVATree

2021-10-01 Thread Eugenio Pérez
This tree is able to look for a translated address from an IOVA address. At first glance is similar to util/iova-tree. However, SVQ working on devices with limited IOVA space need more capabilities, like allocating IOVA chunks or perform reverse translations (qemu addresses to iova). The allocati

Re: [PATCH] failover: allow to pause the VM during the migration

2021-10-01 Thread Peter Krempa
On Thu, Sep 30, 2021 at 16:17:44 -0400, Laine Stump wrote: > On 9/30/21 1:09 PM, Laurent Vivier wrote: > > If we want to save a snapshot of a VM to a file, we used to follow the > > following steps: > > > > 1- stop the VM: > > (qemu) stop > > > > 2- migrate the VM to a file: > > (qemu) mi

Re: Moving QEMU downloads to GitLab Releases?

2021-10-01 Thread Philippe Mathieu-Daudé
On 9/30/21 15:40, Stefan Hajnoczi wrote: > Hi Mike, > QEMU downloads are currently hosted on qemu.org's Apache web server. > Paolo and I were discussing ways to reduce qemu.org network traffic to > save money and eventually turn off the qemu.org server since there is no > full-time sysadmin for it.

Re: Running 297 from GitLab CI

2021-10-01 Thread Kevin Wolf
Am 30.09.2021 um 23:28 hat John Snow geschrieben: > Hiya, I was talking this over with Hanna in review to '[PATCH v3 00/16] > python/iotests: Run iotest linters during Python CI' [1] and I have some > doubt about what you'd personally like to see happen, here. > > In a nutshell, I split out 'linte

Re: TCG Floating Point Support (Work in Progress)

2021-10-01 Thread Alex Bennée
Matt writes: > Thank you Alex, for your quick and thoughtful response. > >> I've not reviewed the code as it is a rather large diff. For your proper >> submission could you please ensure that your patch series is broken up >> into discreet commits to aid review. > > Of course. > >> The phrase "

[PATCH v3] failover: fix unplug pending detection

2021-10-01 Thread Laurent Vivier
Failover needs to detect the end of the PCI unplug to start migration after the VFIO card has been unplugged. To do that, a flag is set in pcie_cap_slot_unplug_request_cb() and reset in pcie_unplug_device(). But since 17858a169508 ("hw/acpi/ich9: Set ACPI PCI hot-plug as default on Q35") we h

Deprecate the ppc405 boards in QEMU? (was: [PATCH v3 4/7] MAINTAINERS: Orphan obscure ppc platforms)

2021-10-01 Thread Thomas Huth
On 27/09/2021 06.48, David Gibson wrote: There are a nunber of old embedded ppc machine types which have been little changed and in "Odd Fixes" state for a long time. With both myself and Greg Kurz moving toward other areas, we no longer have the capacity to keep reviewing and maintaining even t

Re: Moving QEMU downloads to GitLab Releases?

2021-10-01 Thread Daniel P . Berrangé
On Fri, Oct 01, 2021 at 08:11:35AM +0100, Stefan Hajnoczi wrote: > We need to keep the security of QEMU releases in mind. Mike Roth > signs and publishes releases. Whoever facilitates or hosts the files > should not be able to modify the files after Mike has blessed them. One > way to do this is to

Re: [PATCH] failover: allow to pause the VM during the migration

2021-10-01 Thread Daniel P . Berrangé
On Thu, Sep 30, 2021 at 04:17:44PM -0400, Laine Stump wrote: > On 9/30/21 1:09 PM, Laurent Vivier wrote: > > If we want to save a snapshot of a VM to a file, we used to follow the > > following steps: > > > > 1- stop the VM: > > (qemu) stop > > > > 2- migrate the VM to a file: > > (qemu)

Re: [PATCH 3/3] dtc: Update to version 1.6.1

2021-10-01 Thread Daniel P . Berrangé
On Thu, Sep 30, 2021 at 09:10:12AM +0200, Thomas Huth wrote: > On 27/08/2021 14.09, Thomas Huth wrote: > > The dtc submodule is currently pointing to non-release commit. It's nicer > > if submodules point to release versions instead and since dtc 1.6.1 is > > available now, let's update to that ver

Re: [PATCH 1/3] hw/intc/arm_gicv3: Move checking of redist-region-count to arm_gicv3_common_realize

2021-10-01 Thread Peter Maydell
On Thu, 30 Sept 2021 at 22:54, Philippe Mathieu-Daudé wrote: > The pattern make me think gicv3_init_irqs_and_mmio() should be > refactored as a ARMGICv3CommonClass::init_irqs_and_mmio handler, > called in arm_gicv3_common_realize(). That won't work because the two subclasses want to call it with

Re: [PATCH 1/7] docs: name included files ".rst.inc"

2021-10-01 Thread Peter Maydell
On Fri, 1 Oct 2021 at 06:15, Markus Armbruster wrote: > > Emacs recognizes .rst, but doesn't recognize .rst.inc. Sure we want > file names that defeat common tooling? *.rst.inc is the standard convention we have for included rst file fragments: we already use it for 9 files in docs/. It also ma

Re: [PULL 00/22] target-arm queue

2021-10-01 Thread Peter Maydell
On Thu, 30 Sept 2021 at 16:12, Peter Maydell wrote: > > Nothing too exciting in this lot :-) > > The following changes since commit ba0fa56bc06e563de68d2a2bf3ddb0cfea1be4f9: > > Merge remote-tracking branch > 'remotes/vivier/tags/q800-for-6.2-pull-request' into staging (2021-09-29 > 21:20:49 +

Re: [PATCH v4 0/8] qapi: Add support for aliases

2021-10-01 Thread Kevin Wolf
Am 17.09.2021 um 18:13 hat Kevin Wolf geschrieben: > This series introduces alias definitions for QAPI object types (structs > and unions). > > This allows using the same QAPI type and visitor even when the syntax > has some variations between different external interfaces such as QMP > and the co

Re: [PATCH 3/3] dtc: Update to version 1.6.1

2021-10-01 Thread Peter Maydell
On Fri, 1 Oct 2021 at 10:10, Daniel P. Berrangé wrote: > > On Thu, Sep 30, 2021 at 09:10:12AM +0200, Thomas Huth wrote: > > On 27/08/2021 14.09, Thomas Huth wrote: > > > The dtc submodule is currently pointing to non-release commit. It's nicer > > > if submodules point to release versions instead

Re: Deprecate the ppc405 boards in QEMU? (was: [PATCH v3 4/7] MAINTAINERS: Orphan obscure ppc platforms)

2021-10-01 Thread Thomas Huth
On 01/10/2021 11.14, Christophe Leroy wrote: Le 01/10/2021 à 10:35, Thomas Huth a écrit : On 27/09/2021 06.48, David Gibson wrote: There are a nunber of old embedded ppc machine types which have been little changed and in "Odd Fixes" state for a long time.  With both myself and Greg Kurz movi

Re: [PATCH 3/3] dtc: Update to version 1.6.1

2021-10-01 Thread Daniel P . Berrangé
On Fri, Oct 01, 2021 at 10:37:51AM +0100, Peter Maydell wrote: > On Fri, 1 Oct 2021 at 10:10, Daniel P. Berrangé wrote: > > > > On Thu, Sep 30, 2021 at 09:10:12AM +0200, Thomas Huth wrote: > > > On 27/08/2021 14.09, Thomas Huth wrote: > > > > The dtc submodule is currently pointing to non-release

Re: [PATCH 3/3] dtc: Update to version 1.6.1

2021-10-01 Thread Peter Maydell
On Fri, 1 Oct 2021 at 10:44, Daniel P. Berrangé wrote: > On Fri, Oct 01, 2021 at 10:37:51AM +0100, Peter Maydell wrote: > > I agree in general, but (per the commit message here) our dtc > > submodule is currently pointing at some random not-a-release > > commit in upstream dtc. We should at least

Re: [PATCH 3/3] dtc: Update to version 1.6.1

2021-10-01 Thread Peter Maydell
On Fri, 1 Oct 2021 at 10:51, Peter Maydell wrote: > > On Fri, 1 Oct 2021 at 10:44, Daniel P. Berrangé wrote: > > On Fri, Oct 01, 2021 at 10:37:51AM +0100, Peter Maydell wrote: > > > I agree in general, but (per the commit message here) our dtc > > > submodule is currently pointing at some random

Re: [RFC PATCH] spapr/xive: Allocate vCPU IPIs from local context

2021-10-01 Thread Cédric Le Goater
Maybe it would be simpler to call xive_source_is_initialized() instead of xive_eas_is_valid() in cases like this, e.g. hcall code since it is shared between emulation and KVM ? Yes but we need a better check than : if (lisn < SPAPR_XIRQ_BASE) { return !!xive_get_field64(EAS_END_

Re: [PATCH v5 00/26] linux-user: Move signal trampolines to new page

2021-10-01 Thread Laurent Vivier
Le 29/09/2021 à 15:05, Richard Henderson a écrit : > Changes for v5: > * Fix arm thumb code copy. > * Re-enable signals test (except hppa & sh4). > > Changes for v4: > * Drop nios2 changes -- I still haven't built a full toolchain. > * Clean up arm changes. > * Minur i386 pointer type ch

Re: Moving QEMU downloads to GitLab Releases?

2021-10-01 Thread Gerd Hoffmann
Hi, > Maybe we should also discuss again whether we could decrease the size of the > release tarballs. Someone recently mentioned that we could e.g. remove the > edk2 sources from the tarballs - edk2 is licensed under a BSD-style license, > so we are not forced to ship its sources in our tarball

Re: [RFC PATCH] spapr/xive: Allocate vCPU IPIs from local context

2021-10-01 Thread Greg Kurz
On Fri, 1 Oct 2021 11:59:45 +0200 Cédric Le Goater wrote: > >>> Maybe it would be simpler to call xive_source_is_initialized() instead of > >>> xive_eas_is_valid() in cases like this, e.g. hcall code since it is shared > >>> between emulation and KVM ? > >> > >> Yes but we need a better check tha

Re: [PATCH v3] failover: fix unplug pending detection

2021-10-01 Thread Gerd Hoffmann
On Fri, Oct 01, 2021 at 10:25:02AM +0200, Laurent Vivier wrote: > Failover needs to detect the end of the PCI unplug to start migration > after the VFIO card has been unplugged. > > To do that, a flag is set in pcie_cap_slot_unplug_request_cb() and reset in > pcie_unplug_device(). > +/* > +

Re: [PATCH v3] failover: fix unplug pending detection

2021-10-01 Thread Daniel P . Berrangé
On Fri, Oct 01, 2021 at 12:45:14PM +0200, Gerd Hoffmann wrote: > On Fri, Oct 01, 2021 at 10:25:02AM +0200, Laurent Vivier wrote: > > Failover needs to detect the end of the PCI unplug to start migration > > after the VFIO card has been unplugged. > > > > To do that, a flag is set in pcie_cap_slot_

Re: [PATCH v3] failover: fix unplug pending detection

2021-10-01 Thread Laurent Vivier
On 01/10/2021 12:45, Gerd Hoffmann wrote: On Fri, Oct 01, 2021 at 10:25:02AM +0200, Laurent Vivier wrote: Failover needs to detect the end of the PCI unplug to start migration after the VFIO card has been unplugged. To do that, a flag is set in pcie_cap_slot_unplug_request_cb() and reset in pci

Re: [RFC PATCH] spapr/xive: Allocate vCPU IPIs from local context

2021-10-01 Thread Cédric Le Goater
On 10/1/21 12:38, Greg Kurz wrote: On Fri, 1 Oct 2021 11:59:45 +0200 Cédric Le Goater wrote: Maybe it would be simpler to call xive_source_is_initialized() instead of xive_eas_is_valid() in cases like this, e.g. hcall code since it is shared between emulation and KVM ? Yes but we need a bett

Re: Deprecate the ppc405 boards in QEMU? (was: [PATCH v3 4/7] MAINTAINERS: Orphan obscure ppc platforms)

2021-10-01 Thread Peter Maydell
On Fri, 1 Oct 2021 at 10:43, Thomas Huth wrote: > Nevertheless, as long as nobody has a hint where to find that > ppc405_rom.bin, I think both boards are pretty useless in QEMU (as far as I > can see, they do not work without the bios at all, so it's also not possible > to use a Linux image with t

virtio 4M limit

2021-10-01 Thread Christian Schoenebeck
Hi Michael, while testing the following kernel patches I realized there is currently a size limitation of 4 MB with virtio on QEMU side: https://lore.kernel.org/netdev/cover.1632327421.git.linux_...@crudebyte.com/ So with those kernel patches applied I can mount 9pfs on Linux guest with the 9p

Re: OHCI/usb pass through

2021-10-01 Thread BALATON Zoltan
Hello, On Fri, 1 Oct 2021, Gerd Hoffmann wrote: [...] /* Active packets. */ uint32_t old_ctl; USBPacket usb_packet; uint8_t usb_buf[8192]; uint32_t async_td; bool async_complete; void (*ohci_die)(struct OHCIState *ohci); } OHCIState; Then everything in hcd-ohci see

Re: [PATCH 3/3] dtc: Update to version 1.6.1

2021-10-01 Thread Thomas Huth
On 01/10/2021 11.44, Daniel P. Berrangé wrote: On Fri, Oct 01, 2021 at 10:37:51AM +0100, Peter Maydell wrote: On Fri, 1 Oct 2021 at 10:10, Daniel P. Berrangé wrote: On Thu, Sep 30, 2021 at 09:10:12AM +0200, Thomas Huth wrote: On 27/08/2021 14.09, Thomas Huth wrote: The dtc submodule is curr

Re: Deprecate the ppc405 boards in QEMU? (was: [PATCH v3 4/7] MAINTAINERS: Orphan obscure ppc platforms)

2021-10-01 Thread Thomas Huth
On 01/10/2021 13.12, Peter Maydell wrote: On Fri, 1 Oct 2021 at 10:43, Thomas Huth wrote: Nevertheless, as long as nobody has a hint where to find that ppc405_rom.bin, I think both boards are pretty useless in QEMU (as far as I can see, they do not work without the bios at all, so it's also not

Re: [PATCH 1/7] docs: name included files ".rst.inc"

2021-10-01 Thread Paolo Bonzini
On 01/10/21 07:14, Markus Armbruster wrote: Emacs recognizes .rst, but doesn't recognize .rst.inc. Sure we want file names that defeat common tooling? I don't do Emacs, but a patch for .editorconfig should rectify that. Paolo

[PATCH] hw/ppc: Deprecate the ref405ep and taihu machines and the 405 CPU models

2021-10-01 Thread Thomas Huth
These machines need a firmware image called 'ppc405_rom.bin', and nobody seems to have such a firmware image left for testing, so the machines are currently unusable. There used to be support in U-Boot, but it has been removed a couple of year ago already. Thus let's mark these boards and the 405 C

Re: [PATCH] hw/ppc: Deprecate the ref405ep and taihu machines and the 405 CPU models

2021-10-01 Thread Cédric Le Goater
On 10/1/21 14:19, Thomas Huth wrote: These machines need a firmware image called 'ppc405_rom.bin', and nobody seems to have such a firmware image left for testing, so the machines are currently unusable. There used to be support in U-Boot, but it has been removed a couple of year ago already. Thu

Re: OHCI/usb pass through

2021-10-01 Thread Gerd Hoffmann
Hi, > > > We can get the endpoint from a packet and from ohci so > > > I wonder if we can get the active packet from ep->queue (and how to do > > > that) > > > > I think ohci never looks beyond the active td so there should never be > > more than one packet on the list. > > OK, how to get the

Re: [PATCH] hw/ppc: Deprecate the ref405ep and taihu machines and the 405 CPU models

2021-10-01 Thread Peter Maydell
On Fri, 1 Oct 2021 at 13:22, Thomas Huth wrote: > > These machines need a firmware image called 'ppc405_rom.bin', and nobody > seems to have such a firmware image left for testing, so the machines are > currently unusable. There used to be support in U-Boot, but it has been > removed a couple of y

Re: [PATCH v3] failover: fix unplug pending detection

2021-10-01 Thread Gerd Hoffmann
Hi, > > So, in case the first time didn't work (for example due to the guest not > > listening because grub just doesn't do that), you can try a second time > > once the linux kernel is up'n'running. > > > > I suspect this patch will break that (didn't actually test though). > > I think the so

Re: Moving QEMU downloads to GitLab Releases?

2021-10-01 Thread Philippe Mathieu-Daudé
On 10/1/21 12:34, Gerd Hoffmann wrote:>> Maybe we should also discuss again whether we could decrease the size of the >> release tarballs. Someone recently mentioned that we could e.g. remove the >> edk2 sources from the tarballs - edk2 is licensed under a BSD-style license, >> so we are not forced

Re: [PATCH] hw/ppc: Deprecate the ref405ep and taihu machines and the 405 CPU models

2021-10-01 Thread Philippe Mathieu-Daudé
On 10/1/21 14:46, Peter Maydell wrote: > On Fri, 1 Oct 2021 at 13:22, Thomas Huth wrote: >> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst >> index 2f7db9a98d..27c03ef624 100644 >> --- a/docs/about/deprecated.rst >> +++ b/docs/about/deprecated.rst >> @@ -238,6 +238,11 @@ The `

Re: [PATCH] hw/ssi: imx_spi: Improve chip select handling

2021-10-01 Thread Guenter Roeck
On Sun, Sep 26, 2021 at 10:49:53AM +0800, Bin Meng wrote: > On Sat, Sep 18, 2021 at 12:19 PM Guenter Roeck wrote: > > > > On 9/17/21 8:09 PM, Cheng, Xuzhou wrote: > > >>> I got some free time in the past days to investigate this issue. > > >>> Guenter is right, the Linux imx-spi driver does not w

Re: [PATCH] hw/ppc: Deprecate the ref405ep and taihu machines and the 405 CPU models

2021-10-01 Thread Thomas Huth
On 01/10/2021 14.46, Peter Maydell wrote: On Fri, 1 Oct 2021 at 13:22, Thomas Huth wrote: These machines need a firmware image called 'ppc405_rom.bin', and nobody seems to have such a firmware image left for testing, so the machines are currently unusable. There used to be support in U-Boot, b

Re: Deprecate the ppc405 boards in QEMU? (was: [PATCH v3 4/7] MAINTAINERS: Orphan obscure ppc platforms)

2021-10-01 Thread Christophe Leroy
Le 01/10/2021 à 14:04, Thomas Huth a écrit : On 01/10/2021 13.12, Peter Maydell wrote: On Fri, 1 Oct 2021 at 10:43, Thomas Huth wrote: Nevertheless, as long as nobody has a hint where to find that ppc405_rom.bin, I think both boards are pretty useless in QEMU (as far as I can see, they do

Re: Deprecate the ppc405 boards in QEMU? (was: [PATCH v3 4/7] MAINTAINERS: Orphan obscure ppc platforms)

2021-10-01 Thread Christophe Leroy
Le 01/10/2021 à 10:35, Thomas Huth a écrit : On 27/09/2021 06.48, David Gibson wrote: There are a nunber of old embedded ppc machine types which have been little changed and in "Odd Fixes" state for a long time.  With both myself and Greg Kurz moving toward other areas, we no longer have the

Re: [PATCH] hw/ppc: Deprecate the ref405ep and taihu machines and the 405 CPU models

2021-10-01 Thread Daniel P . Berrangé
On Fri, Oct 01, 2021 at 03:01:08PM +0200, Thomas Huth wrote: > On 01/10/2021 14.46, Peter Maydell wrote: > > On Fri, 1 Oct 2021 at 13:22, Thomas Huth wrote: > > > > > > These machines need a firmware image called 'ppc405_rom.bin', and nobody > > > seems to have such a firmware image left for test

Re: Deprecate the ppc405 boards in QEMU? (was: [PATCH v3 4/7] MAINTAINERS: Orphan obscure ppc platforms)

2021-10-01 Thread Cédric Le Goater
On 10/1/21 15:04, Christophe Leroy wrote: Le 01/10/2021 à 14:04, Thomas Huth a écrit : On 01/10/2021 13.12, Peter Maydell wrote: On Fri, 1 Oct 2021 at 10:43, Thomas Huth wrote: Nevertheless, as long as nobody has a hint where to find that ppc405_rom.bin, I think both boards are pretty usele

Re: [PATCH v3] failover: fix unplug pending detection

2021-10-01 Thread Ani Sinha
On Fri, Oct 1, 2021 at 18:19 Gerd Hoffmann wrote: > Hi, > > > > So, in case the first time didn't work (for example due to the guest > not > > > listening because grub just doesn't do that), you can try a second time > > > once the linux kernel is up'n'running. > > > > > > I suspect this patch

Re: [PATCH] hw/ppc: Deprecate the ref405ep and taihu machines and the 405 CPU models

2021-10-01 Thread Peter Maydell
On Fri, 1 Oct 2021 at 14:01, Thomas Huth wrote: > > On 01/10/2021 14.46, Peter Maydell wrote: > > On Fri, 1 Oct 2021 at 13:22, Thomas Huth wrote: > >> > >> These machines need a firmware image called 'ppc405_rom.bin', and nobody > >> seems to have such a firmware image left for testing, so the ma

Re: Deprecate the ppc405 boards in QEMU? (was: [PATCH v3 4/7] MAINTAINERS: Orphan obscure ppc platforms)

2021-10-01 Thread Peter Maydell
On Fri, 1 Oct 2021 at 14:04, Christophe Leroy wrote: > I really would like to be able to use them to validate Linux Kernel > changes, hence looking for that missing BIOS. > > If we remove ppc405 from QEMU, we won't be able to do any regression > tests of Linux Kernel on those processors. Do you (

Re: [PATCH] hw/ppc: Deprecate the ref405ep and taihu machines and the 405 CPU models

2021-10-01 Thread BALATON Zoltan
On Fri, 1 Oct 2021, Peter Maydell wrote: On Fri, 1 Oct 2021 at 14:01, Thomas Huth wrote: On 01/10/2021 14.46, Peter Maydell wrote: On Fri, 1 Oct 2021 at 13:22, Thomas Huth wrote: These machines need a firmware image called 'ppc405_rom.bin', and nobody seems to have such a firmware image lef

Re: [PATCH v4 03/13] qapi/parser: fix unused check_args_section arguments

2021-10-01 Thread Markus Armbruster
John Snow writes: > Pylint informs us we're not using these arguments. Oops, it's > right. Correct the error message and remove the remaining unused > parameter. > > Fix test output now that the error message is improved. > Fixes: e151941d1b > > Signed-off-by: John Snow In v3, the blank line wa

Re: [PATCH v4 00/13] qapi: static typing conversion, pt5b

2021-10-01 Thread Markus Armbruster
John Snow writes: > Hello darkness my old friend; This is part five (b), and focuses on > QAPIDoc in parser.py. Series: Reviewed-by: Markus Armbruster

Re: Deprecate the ppc405 boards in QEMU? (was: [PATCH v3 4/7] MAINTAINERS: Orphan obscure ppc platforms)

2021-10-01 Thread Thomas Huth
On 01/10/2021 15.04, Christophe Leroy wrote: Le 01/10/2021 à 14:04, Thomas Huth a écrit : On 01/10/2021 13.12, Peter Maydell wrote: On Fri, 1 Oct 2021 at 10:43, Thomas Huth wrote: Nevertheless, as long as nobody has a hint where to find that ppc405_rom.bin, I think both boards are pretty us

[PATCH 0/5] 9pfs: introduce P9Array

2021-10-01 Thread Christian Schoenebeck
This is simply a refactored follow-up of the following previous series ("introduce QArray"): https://lists.gnu.org/archive/html/qemu-devel/2021-08/msg04530.html There was no consensus about a project wide "QArray" shared utility code, nor does there seem to be a need for a project wide code, so le

[PATCH 1/5] 9pfs: introduce P9Array

2021-10-01 Thread Christian Schoenebeck
Implements deep auto free of arrays while retaining common C-style squared bracket access. Main purpose of this API is to get rid of error prone individual array deallocation pathes in user code, i.e. turning something like this: void doSomething(size_t n) { Foo *foos = malloc(n * sizeof(F

[PATCH 3/5] 9pfs: make V9fsString usable via P9Array API

2021-10-01 Thread Christian Schoenebeck
Signed-off-by: Christian Schoenebeck --- fsdev/9p-marshal.c | 2 ++ fsdev/9p-marshal.h | 3 +++ 2 files changed, 5 insertions(+) diff --git a/fsdev/9p-marshal.c b/fsdev/9p-marshal.c index a01bba6908..51881fe220 100644 --- a/fsdev/9p-marshal.c +++ b/fsdev/9p-marshal.c @@ -18,6 +18,8 @@ #includ

[PATCH 5/5] 9pfs: use P9Array in v9fs_walk()

2021-10-01 Thread Christian Schoenebeck
Signed-off-by: Christian Schoenebeck --- hw/9pfs/9p.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c index e432c4c007..27c4b8ba78 100644 --- a/hw/9pfs/9p.c +++ b/hw/9pfs/9p.c @@ -1707,13 +1707,14 @@ static void coroutine_fn v9fs_

[PATCH 4/5] 9pfs: make V9fsPath usable via P9Array API

2021-10-01 Thread Christian Schoenebeck
Signed-off-by: Christian Schoenebeck --- fsdev/file-op-9p.h | 2 ++ hw/9pfs/9p.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/fsdev/file-op-9p.h b/fsdev/file-op-9p.h index 42f677cf38..8fd89f0447 100644 --- a/fsdev/file-op-9p.h +++ b/fsdev/file-op-9p.h @@ -18,6 +18,7 @@ #include

[PATCH 2/5] fsdev/p9array.h: check scalar type in P9ARRAY_NEW()

2021-10-01 Thread Christian Schoenebeck
Make sure at compile time that the scalar type of the array requested to be created via P9ARRAY_NEW() matches the scalar type of the passed auto reference variable (unique pointer). Suggested-by: Richard Henderson Signed-off-by: Christian Schoenebeck --- fsdev/p9array.h | 6 ++ 1 file chang

Re: [PATCH 09/11] qdev: Avoid QemuOpts in QMP device_add

2021-10-01 Thread Peter Krempa
On Fri, Sep 24, 2021 at 11:04:25 +0200, Kevin Wolf wrote: > Directly call qdev_device_add_from_qdict() for QMP device_add instead of > first going through QemuOpts and converting back to QDict. > > Note that this changes the behaviour of device_add, though in ways that > should be considered bug f

Re: [PATCH 1/5] 9pfs: introduce P9Array

2021-10-01 Thread Daniel P . Berrangé
On Fri, Oct 01, 2021 at 04:26:17PM +0200, Christian Schoenebeck wrote: > Implements deep auto free of arrays while retaining common C-style > squared bracket access. Main purpose of this API is to get rid of > error prone individual array deallocation pathes in user code, i.e. > turning something l

Re: [PATCH v3] failover: fix unplug pending detection

2021-10-01 Thread Ani Sinha
On Fri, 1 Oct 2021, Gerd Hoffmann wrote: > Hi, > > > > So, in case the first time didn't work (for example due to the guest not > > > listening because grub just doesn't do that), you can try a second time > > > once the linux kernel is up'n'running. > > > > > > I suspect this patch will brea

Re: [PATCH 1/5] 9pfs: introduce P9Array

2021-10-01 Thread Christian Schoenebeck
On Freitag, 1. Oktober 2021 17:16:47 CEST Daniel P. Berrangé wrote: > On Fri, Oct 01, 2021 at 04:26:17PM +0200, Christian Schoenebeck wrote: > > Implements deep auto free of arrays while retaining common C-style > > squared bracket access. Main purpose of this API is to get rid of > > error prone i

[PATCH v2] configure: Loosen GCC requirement from 7.5.0 to 7.4.0

2021-10-01 Thread nia
As discussed in issue 614, we're shipping GCC 7.4.0 as the system compiler in NetBSD 9, the most recent stable branch, and are still actively interested in QEMU on this platform. The differences between GCC 7.5.0 and 7.4.0 are trivial. Signed-off-by: Nia Alarie --- configure | 6 +++--- 1 file

Re: [PATCH v3 01/10] hw/acpi: Add VIOT table

2021-10-01 Thread Jean-Philippe Brucker
On Mon, Sep 20, 2021 at 10:06:09AM +0200, Igor Mammedov wrote: > > +/* > > + * Generate a VIOT table with one PCI-based virtio-iommu that manages PCI > > + * endpoints. > > We usually put a pointer to spec/revision and chapter in it > that describes being implemented table, so reviewer would > hav

[PATCH 2/2] tests/docker: Fix fedora-i386-cross

2021-10-01 Thread Richard Henderson
By using PKG_CONFIG_PATH instead of PKG_CONFIG_LIBDIR, we were still including the 64-bit packages. Install pcre-devel.i686 to fill a missing glib2 dependency. By using --extra-cflags instead of --cpu, we incorrectly use the wrong probing during meson. Cc: Alex Bennée Cc: Paolo Bonzini Cc: Dan

[PATCH 0/9] nios2: Enable cross compile and fix signals

2021-10-01 Thread Richard Henderson
Patches 2, 3, and 5 have appeared before. The patch for the kuser page has been updated to use the commpage infrastructure, which needed expanding just a bit to handle the page being at the beginning of the address space. Getting the toolchain built allowed the code to actually be tested, which s

[PATCH 3/9] linux-user/nios2: Fixes for signal frame setup

2021-10-01 Thread Richard Henderson
Do not confuse host and guest addresses. Lock and unlock the target_rt_sigframe structure in setup_rt_sigframe. Since rt_setup_ucontext always returns 0, drop the return value entirely. This eliminates the only write to the err variable in setup_rt_sigframe. Always copy the siginfo structure.

[PATCH 1/2] tests/docker: Remove fedora-i386-cross from DOCKER_PARTIAL_IMAGES

2021-10-01 Thread Richard Henderson
The image was upgraded to a full image in ee381b7fe146. This makes it possible to use docker-test@image syntax with this container. Cc: Thomas Huth Cc: Alex Bennée Signed-off-by: Richard Henderson --- tests/docker/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[PATCH 4/9] linux-user/elfload: Rename ARM_COMMPAGE to HI_COMMPAGE

2021-10-01 Thread Richard Henderson
Arm will no longer be the only target requiring a commpage, but it will continue to be the only target placing the page at the high end of the address space. Signed-off-by: Richard Henderson --- linux-user/elfload.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff -

[PATCH 2/9] linux-user/nios2: Properly emulate EXCP_TRAP

2021-10-01 Thread Richard Henderson
The real kernel has to load the instruction and extract the imm5 field; for qemu, modify the translator to do this. The use of R_AT for this in cpu_loop was a bug. Handle the other trap numbers as per the kernel's trap_table. Signed-off-by: Richard Henderson --- target/nios2/cpu.h |

[PATCH 5/9] linux-user/nios2: Map a real kuser page

2021-10-01 Thread Richard Henderson
The first word of page1 is data, so the whole thing can't be implemented with emulation of addresses. Use init_guest_commpage for the allocation. Hijack trap number 16 to implement cmpxchg. Signed-off-by: Richard Henderson --- linux-user/elfload.c| 50 +++

[PATCH 8/9] linux-user/nios2: Use set_sigmask in do_rt_sigreturn

2021-10-01 Thread Richard Henderson
Using do_sigprocmask directly was incorrect, as it will leave the signal blocked by the outer layers of linux-user. Signed-off-by: Richard Henderson --- linux-user/nios2/signal.c | 2 +- linux-user/signal.c | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/linux-user/ni

[PATCH 6/9] linux-user/nios2: Fix EA vs PC confusion

2021-10-01 Thread Richard Henderson
The real kernel will talk about the user PC as EA, because that's where the hardware will have copied it, and where it expects to put it to then use ERET. But qemu does not emulate all of the exception stuff while emulating user-only. Manipulate PC directly. This fixes signal entry and return, an

[PATCH 9/9] tests/tcg: Enable container_cross_cc for nios2

2021-10-01 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tests/tcg/configure.sh | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/tcg/configure.sh b/tests/tcg/configure.sh index 1f985ccfc0..62ca1e2cae 100755 --- a/tests/tcg/configure.sh +++ b/tests/tcg/configure.sh @@ -59,6 +59,7 @@ fi : $(cross_cc_mi

[PATCH 7/9] linux-user/nios2: Fix sigmask in setup_rt_frame

2021-10-01 Thread Richard Henderson
Do not cast the signal mask elements; trust __put_user. Signed-off-by: Richard Henderson --- linux-user/nios2/signal.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/linux-user/nios2/signal.c b/linux-user/nios2/signal.c index 20b65aa06e..80e3d42fc9 100644 --- a/linux-user/

Re: [PATCH v3 05/10] pc: Allow instantiating a virtio-iommu device

2021-10-01 Thread Jean-Philippe Brucker
On Mon, Sep 20, 2021 at 10:24:40AM +0200, Igor Mammedov wrote: > > +if (pcms->virtio_iommu && x86_iommu_get_default()) { > > +error_report("QEMU does not support multiple vIOMMUs for x86 > > yet."); > > +exit(EXIT_FAILURE); > > +} > > previous patch does similar check, doe

[PATCH 1/9] tests/docker: Add debian-nios2-cross image

2021-10-01 Thread Richard Henderson
Build the entire cross tool chain from source. For this reason, default to caching. Signed-off-by: Richard Henderson --- tests/docker/Makefile.include | 19 .../dockerfiles/debian-nios2-cross.docker | 34 +++ .../build-toolchain.sh| 97 +++

  1   2   >