Re: [PATCH 1/2] meson: introduce modules_arch

2021-09-17 Thread Gerd Hoffmann
Hi, > This variable keeps track of all modules enabled for a target > architecture. This will be used in modinfo to refine the > architectures that can really load the .so to avoid errors. I think this is the wrong approach. The reason why modules are not loading is typically *not* the archite

Re: [PATCH v9 00/16] machine: smp parsing fixes and improvement

2021-09-17 Thread wangyanan (Y)
ping... Hello maintainers, Is this series mature enough to be accepted? Now each one patch in this version has been Reviewd/Acked. Considering that I have another patchset on list that depends on this series, and AFAIK there is another s390 patch series caring about the SMP changes too, so I w

Re: [PATCH v9 07/16] qtest/numa-test: Use detailed -smp CLI in test_def_cpu_split

2021-09-17 Thread wangyanan (Y)
On 2021/9/10 16:17, Andrew Jones wrote: On Fri, Sep 10, 2021 at 03:30:16PM +0800, Yanan Wang wrote: Since commit 80d7835749 (qemu-options: rewrite help for -smp options), the preference of sockets/cores in -smp parsing is considered liable to change, and actually we are going to change it in a

Re: [PATCH RFC 00/13] hw/nvme: experimental user-creatable objects

2021-09-17 Thread Kevin Wolf
Am 17.09.2021 um 08:21 hat Klaus Jensen geschrieben: > On Sep 16 18:30, Klaus Jensen wrote: > > On Sep 16 14:41, Kevin Wolf wrote: > > > Am 14.09.2021 um 22:37 hat Klaus Jensen geschrieben: > > > > From: Klaus Jensen > > > > > > > > Hi, > > > > > > > > This is an attempt at adressing a bunch of

[PATCH v4 01/20] nubus-device: rename slot_nb variable to slot

2021-09-17 Thread Mark Cave-Ayland
This is in preparation for creating a qdev property of the same name. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé --- hw/nubus/nubus-device.c | 14 +++--- include/hw/nubus/nubus.h | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/nubus/n

[PATCH v4 00/20] nubus: bus, device, bridge, IRQ and address space improvements

2021-09-17 Thread Mark Cave-Ayland
This patchset is the next set of changes required to boot MacOS on the q800 machine. The main aim of these patches is to improve the Nubus support so that devices can be plugged into the Nubus from the command line i.e. -device nubus-macfb[,slot=num][,romfile=decl.rom] At the moment the onl

[PATCH v4 02/20] nubus-device: expose separate super slot memory region

2021-09-17 Thread Mark Cave-Ayland
According to "Designing Cards and Drivers for the Macintosh Family" each physical nubus slot can access 2 separate address ranges: a super slot memory region which is 256MB and a standard slot memory region which is 16MB. Currently a Nubus device uses the physical slot number to determine whethe

[PATCH v4 04/20] nubus: use bitmap to manage available slots

2021-09-17 Thread Mark Cave-Ayland
Convert nubus_device_realize() to use a bitmap to manage available slots to allow for future Nubus devices to be plugged into arbitrary slots from the command line. Update mac_nubus_bridge_init() to only allow slots 0x9 to 0xe on a Macintosh machines as documented in "Desigining Cards and Driver

[PATCH v4 19/20] q800: wire up nubus IRQs

2021-09-17 Thread Mark Cave-Ayland
Nubus IRQs are routed to the CPU through the VIA2 device so wire up the IRQs using gpios accordingly. Signed-off-by: Mark Cave-Ayland --- hw/m68k/q800.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/m68k/q800.c b/hw/m68k/q800.c index e34df1a829..fbc45a301f 100644 --- a/hw/m68k/q800

[PATCH v4 06/20] nubus: implement BusClass get_dev_path()

2021-09-17 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé --- hw/nubus/nubus-bus.c | 16 1 file changed, 16 insertions(+) diff --git a/hw/nubus/nubus-bus.c b/hw/nubus/nubus-bus.c index 141876b579..63e7d66b95 100644 --- a/hw/nubus/nubus-bus.c +++ b/hw/nubus/nubus-bus.c

[PATCH v4 03/20] nubus-device: add device slot parameter

2021-09-17 Thread Mark Cave-Ayland
This prepares for allowing Nubus devices to be placed in a specific slot instead of always being auto-allocated by the bus itself. Signed-off-by: Mark Cave-Ayland --- hw/nubus/nubus-device.c | 6 ++ include/hw/nubus/nubus.h | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git

[PATCH v4 05/20] nubus: move slot bitmap checks from NubusDevice realize() to BusClass check_address()

2021-09-17 Thread Mark Cave-Ayland
Allow Nubus to manage the slot allocations itself using the BusClass check_address() virtual function rather than managing this during NubusDevice realize(). Signed-off-by: Mark Cave-Ayland --- hw/nubus/nubus-bus.c| 37 + hw/nubus/nubus-device.c | 29

[PATCH v4 11/20] nubus-device: add romfile property for loading declaration ROMs

2021-09-17 Thread Mark Cave-Ayland
The declaration ROM is located at the top-most address of the standard slot space. Signed-off-by: Mark Cave-Ayland --- hw/nubus/nubus-device.c | 44 +++- include/hw/nubus/nubus.h | 6 ++ 2 files changed, 49 insertions(+), 1 deletion(-) diff --git a/hw/n

[PATCH v4 08/20] nubus: generate bus error when attempting to access empty slots

2021-09-17 Thread Mark Cave-Ayland
According to "Designing Cards and Drivers for the Macintosh Family" any attempt to access an unimplemented address location on Nubus generates a bus error. MacOS uses a custom bus error handler to detect empty Nubus slots, and with the current implementation assumes that all slots are occupied as

[PATCH v4 07/20] nubus: add trace-events for empty slot accesses

2021-09-17 Thread Mark Cave-Ayland
Increase the max_access_size to 4 bytes for empty Nubus slot and super slot accesses to allow tracing of the Nubus enumeration process by the guest OS. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé --- hw/nubus/nubus-bus.c | 10 +++--- hw/nubus/trace-events | 7 +

[PATCH v4 10/20] nubus-device: remove nubus_register_rom() and nubus_register_format_block()

2021-09-17 Thread Mark Cave-Ayland
Since there is no need to generate a dummy declaration ROM, remove both nubus_register_rom() and nubus_register_format_block(). These will shortly be replaced with a mechanism to optionally load a declaration ROM from disk to allow real images to be used within QEMU. Signed-off-by: Mark Cave-Aylan

[PATCH v4 12/20] nubus: move nubus to its own 32-bit address space

2021-09-17 Thread Mark Cave-Ayland
According to "Designing Cards and Drivers for the Macintosh Family" the Nubus has its own 32-bit address space based upon physical slot addressing. Move Nubus to its own 32-bit address space and then use memory region aliases to map available slot and super slot ranges into the q800 system address

[PATCH v4 09/20] macfb: don't register declaration ROM

2021-09-17 Thread Mark Cave-Ayland
The macfb device is an on-board framebuffer and so is initialised by the system declaration ROM included within the MacOS toolbox ROM. Signed-off-by: Mark Cave-Ayland --- hw/display/macfb.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/hw/display/macfb.c b/hw/display/macfb.c index d81

[PATCH v4 17/20] nubus-bridge: make slot_available_mask a qdev property

2021-09-17 Thread Mark Cave-Ayland
This is to allow Macintosh machines to further specify which slots are available since the number of addressable slots may not match the number of physical slots present in the machine. Signed-off-by: Mark Cave-Ayland --- hw/nubus/nubus-bridge.c | 7 +++ 1 file changed, 7 insertions(+) diff

[PATCH v4 13/20] nubus-bridge: introduce separate NubusBridge structure

2021-09-17 Thread Mark Cave-Ayland
This is to allow the Nubus bridge to store its own additional state. Also update the comment in the file header to reflect that nubus-bridge is not specific to the Macintosh. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé --- hw/nubus/nubus-bridge.c | 4 ++-- in

[PATCH v4 15/20] nubus: move NubusBus from mac-nubus-bridge to nubus-bridge

2021-09-17 Thread Mark Cave-Ayland
Now that Nubus has its own address space rather than mapping directly into the system bus, move the Nubus reference from MacNubusBridge to NubusBridge. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé --- hw/m68k/q800.c | 2 +- hw/nubus/mac-nubus-bridge.c

[PATCH v4 14/20] mac-nubus-bridge: rename MacNubusState to MacNubusBridge

2021-09-17 Thread Mark Cave-Ayland
This better reflects that the mac-nubus-bridge device is derived from the nubus-bridge device, and that the structure represents the state of the bridge device and not the Nubus itself. Also update the comment in the file header to reflect that mac-nubus-bridge is specific to the Macintosh. Signed

Re: [PATCH RFC 00/13] hw/nvme: experimental user-creatable objects

2021-09-17 Thread Klaus Jensen
On Sep 17 09:38, Kevin Wolf wrote: > Am 17.09.2021 um 08:21 hat Klaus Jensen geschrieben: > > On Sep 16 18:30, Klaus Jensen wrote: > > > On Sep 16 14:41, Kevin Wolf wrote: > > > > Am 14.09.2021 um 22:37 hat Klaus Jensen geschrieben: > > > > > From: Klaus Jensen > > > > > > > > > > Hi, > > > > >

[PATCH v4 16/20] nubus-bridge: embed the NubusBus object directly within nubus-bridge

2021-09-17 Thread Mark Cave-Ayland
Since nubus-bridge is a container for NubusBus then it should be embedded directly within the bridge device using qbus_create_inplace(). Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé --- hw/m68k/q800.c | 2 +- hw/nubus/mac-nubus-bridge.c | 7 --- hw/nubus/

[PATCH v4 18/20] nubus: add support for slot IRQs

2021-09-17 Thread Mark Cave-Ayland
Each Nubus slot has an IRQ line that can be used to request service from the CPU. Connect the IRQs to the Nubus bridge so that they can be wired up using qdev gpios accordingly, and introduce a new nubus_set_irq() function that can be used by Nubus devices to control the slot IRQ. Signed-off-by:

[PATCH v4 20/20] q800: configure nubus available slots for Quadra 800

2021-09-17 Thread Mark Cave-Ayland
Slot 0x9 is reserved for use by the in-built framebuffer whilst only slots 0xc, 0xd and 0xe physically exist on the Quadra 800. Signed-off-by: Mark Cave-Ayland --- hw/m68k/q800.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/m68k/q800.c b/hw/m68k/q800.c index fbc45a301f..63f427

[PATCH v6 02/21] target/loongarch: Add core definition

2021-09-17 Thread Song Gao
This patch add target state header, target definitions and initialization routines. Signed-off-by: Song Gao Signed-off-by: XiaoJuan Yang --- target/loongarch/cpu-param.h | 19 +++ target/loongarch/cpu.c | 285 +++ target/loongarch/cpu.h | 151

[PATCH v6 05/21] target/loongarch: Add fixed point shift instruction translation

2021-09-17 Thread Song Gao
This patch implement fixed point shift instruction translation. This includes: - SLL.W, SRL.W, SRA.W, ROTR.W - SLLI.W, SRLI.W, SRAI.W, ROTRI.W - SLL.D, SRL.D, SRA.D, ROTR.D - SLLI.D, SRLI.D, SRAI.D, ROTRI.D Signed-off-by: Song Gao Signed-off-by: XiaoJuan Yang Reviewed-by: Richard Henderson --

[PATCH v6 20/21] target/loongarch: 'make check-tcg' support

2021-09-17 Thread Song Gao
This patch support 'make check-tcg' after install cross-tools. Signed-off-by: Song Gao Signed-off-by: XiaoJuan Yang Reviewed-by: Richard Henderson --- tests/tcg/configure.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/tcg/configure.sh b/tests/tcg/configure.sh index 1f985cc..d8f67

[PATCH v6 00/21] Add LoongArch linux-user emulation support

2021-09-17 Thread Song Gao
Based-on: <20210822035537.283193-6-richard.hender...@linaro.org> Based-on: <20210618192951.125651-2-richard.hender...@linaro.org> Hi, The 'o32' code has been deleted at the latest kernel [1]. This series only support linux-user emulation. More about LoongArch at: https://github.com/loongson/

[PATCH v6 03/21] target/loongarch: Add main translation routines

2021-09-17 Thread Song Gao
This patch add main translation routines and basic functions for translation. Signed-off-by: Song Gao Signed-off-by: XiaoJuan Yang Reviewed-by: Richard Henderson --- target/loongarch/helper.h| 9 +++ target/loongarch/internals.h | 1 - target/loongarch/op_helper.c | 22 ++ target/

[PATCH v6 06/21] target/loongarch: Add fixed point bit instruction translation

2021-09-17 Thread Song Gao
This patch implement fixed point bit instruction translation. This includes: - EXT.W.{B/H} - CL{O/Z}.{W/D}, CT{O/Z}.{W/D} - BYTEPICK.{W/D} - REVB.{2H/4H/2W/D} - REVH.{2W/D} - BITREV.{4B/8B}, BITREV.{W/D} - BSTRINS.{W/D}, BSTRPICK.{W/D} - MASKEQZ, MASKNEZ Signed-off-by: Song Gao Signed-off-by: Xi

[PATCH v6 01/21] target/loongarch: Add README

2021-09-17 Thread Song Gao
This patch give an introduction to the LoongArch target. Signed-off-by: Song Gao Signed-off-by: XiaoJuan Yang --- MAINTAINERS | 5 target/loongarch/README | 76 + 2 files changed, 81 insertions(+) create mode 100644 target/loong

[PATCH v6 12/21] target/loongarch: Add floating point conversion instruction translation

2021-09-17 Thread Song Gao
This patch implement floating point conversion instruction translation. This includes: - FCVT.S.D, FCVT.D.S - FFINT.{S/D}.{W/L}, FTINT.{W/L}.{S/D} - FTINT{RM/RP/RZ/RNE}.{W/L}.{S/D} - FRINT.{S/D} Signed-off-by: Song Gao Signed-off-by: XiaoJuan Yang Reviewed-by: Richard Henderson --- target/loo

[PATCH v6 08/21] target/loongarch: Add fixed point atomic instruction translation

2021-09-17 Thread Song Gao
This patch implement fixed point atomic instruction translation. This includes: - LL.{W/D}, SC.{W/D} - AM{SWAP/ADD/AND/OR/XOR/MAX/MIN}[_DB].{W/D} - AM{MAX/MIN}[_DB].{WU/DU} Signed-off-by: Song Gao Signed-off-by: XiaoJuan Yang Reviewed-by: Richard Henderson --- target/loongarch/insn_trans/tran

[PATCH v6 04/21] target/loongarch: Add fixed point arithmetic instruction translation

2021-09-17 Thread Song Gao
This patch implement fixed point arithemtic instruction translation. This includes: - ADD.{W/D}, SUB.{W/D} - ADDI.{W/D}, ADDU16ID - ALSL.{W[U]/D} - LU12I.W, LU32I.D LU52I.D - SLT[U], SLT[U]I - PCADDI, PCADDU12I, PCADDU18I, PCALAU12I - AND, OR, NOR, XOR, ANDN, ORN - MUL.{W/D}, MULH.{W[U]/D[U]} - MU

[PATCH v6 13/21] target/loongarch: Add floating point move instruction translation

2021-09-17 Thread Song Gao
This patch implement floationg point move instruction translation. This includes: - FMOV.{S/D} - FSEL - MOVGR2FR.{W/D}, MOVGR2FRH.W - MOVFR2GR.{S/D}, MOVFRH2GR.S - MOVGR2FCSR, MOVFCSR2GR - MOVFR2CF, MOVCF2FR - MOVGR2CF, MOVCF2GR Signed-off-by: Song Gao Signed-off-by: XiaoJuan Yang Reviewed-by:

[PATCH v6 16/21] target/loongarch: Add disassembler

2021-09-17 Thread Song Gao
This patch add support for disassembling via option '-d in_asm'. Signed-off-by: Song Gao Signed-off-by: XiaoJuan Yang Acked-by: Richard Henderson --- MAINTAINERS |1 + disas/loongarch.c | 2511 +++ disas/meson.build |1

[PATCH v6 07/21] target/loongarch: Add fixed point load/store instruction translation

2021-09-17 Thread Song Gao
This patch implement fixed point load/store instruction translation. This includes: - LD.{B[U]/H[U]/W[U]/D}, ST.{B/H/W/D} - LDX.{B[U]/H[U]/W[U]/D}, STX.{B/H/W/D} - LDPTR.{W/D}, STPTR.{W/D} - PRELD - LD{GT/LE}.{B/H/W/D}, ST{GT/LE}.{B/H/W/D} - DBAR, IBAR Signed-off-by: Song Gao Signed-off-by: Xiao

[PATCH v6 15/21] target/loongarch: Add branch instruction translation

2021-09-17 Thread Song Gao
This patch implement branch instruction translation. This includes: - BEQ, BNE, BLT[U], BGE[U] - BEQZ, BNEZ - B - BL - JIRL - BCEQZ, BCNEZ Signed-off-by: Song Gao Signed-off-by: XiaoJuan Yang Reviewed-by: Richard Henderson --- target/loongarch/insn_trans/trans_branch.c | 85 ++

[PATCH v6 09/21] target/loongarch: Add fixed point extra instruction translation

2021-09-17 Thread Song Gao
This patch implement fixed point extra instruction translation. This includes: - CRC[C].W.{B/H/W/D}.W - SYSCALL - BREAK - ASRT{LE/GT}.D - RDTIME{L/H}.W, RDTIME.D - CPUCFG Signed-off-by: Song Gao Signed-off-by: XiaoJuan Yang Reviewed-by: Richard Henderson --- target/loongarch/helper.h

Re: [PATCH v2 0/8] i386: Assorted KVM PV and Hyper-V feature improvements

2021-09-17 Thread Vitaly Kuznetsov
Vitaly Kuznetsov writes: > This is a continuation of "[PATCH 0/3] i386/kvm: Paravirtualized features > usage > enforcement" series, thus v2. > > This series implements several unrelated features but as there are code > dependencies between them I'm sending it as one series. > > PATCH1 adds empt

[PULL 1/2] ebpf: only include in system emulators

2021-09-17 Thread Jason Wang
From: Paolo Bonzini eBPF files are being included in user emulators, which is useless and also breaks compilation because ebpf/trace-events is only processed if a system emulator is included in the build. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/566 Signed-off-by: Paolo Bonzini S

[PATCH v6 18/21] default-configs: Add loongarch linux-user support

2021-09-17 Thread Song Gao
Add loongarch64 linux-user default configs file. Signed-off-by: Song Gao Signed-off-by: XiaoJuan Yang Reviewed-by: Richard Henderson --- configs/targets/loongarch64-linux-user.mak | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 configs/targets/loongarch64-linux-user.mak diff --gi

[PATCH v6 10/21] target/loongarch: Add floating point arithmetic instruction translation

2021-09-17 Thread Song Gao
This patch implement floating point arithmetic instruction translation. This includes: - F{ADD/SUB/MUL/DIV}.{S/D} - F{MADD/MSUB/NMADD/NMSUB}.{S/D} - F{MAX/MIN}.{S/D} - F{MAXA/MINA}.{S/D} - F{ABS/NEG}.{S/D} - F{SQRT/RECIP/RSQRT}.{S/D} - F{SCALEB/LOGB/COPYSIGN}.{S/D} - FCLASS.{S/D} Signed-off-by: S

[PATCH v6 17/21] LoongArch Linux User Emulation

2021-09-17 Thread Song Gao
Implementation of linux user emulation for LoongArch. Signed-off-by: Song Gao Signed-off-by: XiaoJuan Yang --- accel/tcg/user-exec.c | 15 ++ configure | 5 + include/elf.h | 2 + linux-user/elfload.c

Re: [PATCH v3 6/6] tests/qapi-schema: Test cases for aliases

2021-09-17 Thread Markus Armbruster
Kevin Wolf writes: > Am 14.09.2021 um 15:29 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Am 14.09.2021 um 10:59 hat Markus Armbruster geschrieben: >> >> >> > +/* You can't use more than one option at the same time */ >> >> >> > +v = visitor_input_test_init(data, "{ '

[PATCH v6 11/21] target/loongarch: Add floating point comparison instruction translation

2021-09-17 Thread Song Gao
This patch implement floating point comparison instruction translation. This includes: - FCMP.cond.{S/D} Signed-off-by: Song Gao Signed-off-by: XiaoJuan Yang Reviewed-by: Richard Henderson --- target/loongarch/fpu_helper.c| 60 target/loongarch/hel

[PATCH v6 21/21] scripts: add loongarch64 binfmt config

2021-09-17 Thread Song Gao
Signed-off-by: Song Gao Signed-off-by: XiaoJuan Yang Reviewed-by: Richard Henderson --- scripts/qemu-binfmt-conf.sh | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh index 7de996d..5575bdd 100755 --- a/scripts/qemu

[PATCH v6 14/21] target/loongarch: Add floating point load/store instruction translation

2021-09-17 Thread Song Gao
This patch implement floating point load/store instruction translation. This includes: - FLD.{S/D}, FST.{S/D} - FLDX.{S/D}, FSTX.{S/D} - FLD{GT/LE}.{S/D}, FST{GT/LE}.{S/D} Signed-off-by: Song Gao Signed-off-by: XiaoJuan Yang Reviewed-by: Richard Henderson --- target/loongarch/insn_trans/trans

[PULL 2/2] virtio-net: fix use after unmap/free for sg

2021-09-17 Thread Jason Wang
When mergeable buffer is enabled, we try to set the num_buffers after the virtqueue elem has been unmapped. This will lead several issues, E.g a use after free when the descriptor has an address which belongs to the non direct access region. In this case we use bounce buffer that is allocated durin

Re: [PATCH v3 02/16] iotests/mirror-top-perms: Adjust imports

2021-09-17 Thread Hanna Reitz
On 16.09.21 06:09, John Snow wrote: We need to import things from the qemu namespace; importing the namespace alone doesn't bring the submodules with it -- unless someone else (like iotests.py) imports them too. Adjust the imports. Signed-off-by: John Snow --- tests/qemu-iotests/tests/mirror

Re: Problem with init debugging under QEMU ARM

2021-09-17 Thread Lukasz Majewski
On Mon, 13 Sep 2021 10:29:17 +0200 Lukasz Majewski wrote: > Dear QEMU community, > > I'm now trying to fix bug in glibc which became apparent on qemu > 6.0.0. > > The error is caused by glibc commit: > bca0f5cbc9257c13322b99e55235c4f21ba0bd82 > https://sourceware.org/git/?p=glibc.git;a=blobdiff

[PATCH v6 19/21] target/loongarch: Add target build suport

2021-09-17 Thread Song Gao
This patch add build loongarch-linux-user target support. Signed-off-by: Song Gao Signed-off-by: XiaoJuan Yang Reviewed-by: Richard Henderson --- meson.build | 2 +- target/loongarch/meson.build | 18 ++ target/meson.build | 1 + 3 files changed, 20

Re: [PATCH v7 7/7] spapr_numa.c: handle auto NUMA node with no distance info

2021-09-17 Thread Igor Mammedov
On Wed, 15 Sep 2021 22:30:04 -0300 Daniel Henrique Barboza wrote: > numa_complete_configuration() in hw/core/numa.c always adds a NUMA node > for the pSeries machine if none was specified, but without node distance > information for the single node created. distance is optional feature, hence ge

[PULL 0/2] Net patches

2021-09-17 Thread Jason Wang
The following changes since commit d1fe59377bbbf91dfded1f08ffe3c636e9db8dc0: Merge remote-tracking branch 'remotes/vivier2/tags/trivial-branch-for-6.2-pull-request' into staging (2021-09-16 16:02:31 +0100) are available in the git repository at: https://github.com/jasowang/qemu.git tags/ne

Re: [PATCH v3 03/16] iotests/migrate-bitmaps-postcopy-test: declare instance variables

2021-09-17 Thread Hanna Reitz
On 16.09.21 06:09, John Snow wrote: Signed-off-by: John Snow --- tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test b/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test index

Rust in Qemu BoF followup: Rust vs. qemu platform support

2021-09-17 Thread David Gibson
Hi all, At the qemu-in-rust BoF at KVM Forum, I volunteered to look into whether Rust supported all the host/build platforms that qemu does, which is obviously vital if we want to make Rust a non-optional component of the build. I've added the information to our wiki at: https://wiki.qemu

Re: [PATCH v3 04/16] iotests/migrate-bitmaps-test: delint

2021-09-17 Thread Hanna Reitz
On 16.09.21 06:09, John Snow wrote: Mostly uninteresting stuff. Move the test injections under a function named main() so that the variables used during that process aren't in the global scope. Signed-off-by: John Snow --- tests/qemu-iotests/tests/migrate-bitmaps-test | 50 +++

Re: [PULL 00/10] Linux user for 6.2 patches

2021-09-17 Thread Peter Maydell
On Thu, 16 Sept 2021 at 16:16, Laurent Vivier wrote: > > The following changes since commit 7d79344d4fa44e520e6e89f8fed9a27d3d554a9b: > > Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' > into staging (2021-09-13 13:33:21 +0100) > > are available in the Git repository at

Re: [PATCH v3 05/16] iotests/297: modify is_python_file to work from any CWD

2021-09-17 Thread Hanna Reitz
On 16.09.21 06:09, John Snow wrote: Add a directory argument to is_python_file to allow it to work correctly no matter what CWD we happen to run it from. This is done in anticipation of running the iotests from another directory (./python/). “the iotests” or just 297?  All of the iotests would

Re: Rust in Qemu BoF followup: Rust vs. qemu platform support

2021-09-17 Thread Cornelia Huck
On Fri, Sep 17 2021, David Gibson wrote: > Hi all, > > At the qemu-in-rust BoF at KVM Forum, I volunteered to look into > whether Rust supported all the host/build platforms that qemu does, > which is obviously vital if we want to make Rust a non-optional > component of the build. > > I've added

Re: [PATCH v3 06/16] iotests/297: Add get_files() function

2021-09-17 Thread Hanna Reitz
On 16.09.21 06:09, John Snow wrote: Split out file discovery into its own method to begin separating out the "environment setup" and "test execution" phases. Signed-off-by: John Snow --- tests/qemu-iotests/297 | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/t

[PATCH RESEND v2] target/riscv: Set mstatus_hs.[SD|FS] bits if Clean and V=1 in mark_fs_dirty()

2021-09-17 Thread frank . chang
From: Frank Chang When V=1, both vsstauts.FS and HS-level sstatus.FS are in effect. Modifying the floating-point state when V=1 causes both fields to be set to 3 (Dirty). However, it's possible that HS-level sstatus.FS is Clean and VS-level vsstatus.FS is Dirty at the time mark_fs_dirty() is cal

Re: [PATCH v3 07/16] iotests/297: Don't rely on distro-specific linter binaries

2021-09-17 Thread Hanna Reitz
On 16.09.21 06:09, John Snow wrote: 'pylint-3' is another Fedora-ism. Use "python3 -m pylint" or "python3 -m mypy" to access these scripts instead. This style of invocation will prefer the "correct" tool when run in a virtual environment. Note that we still check for "pylint-3" before the test b

[PATCH] travis.yml: Remove the "Release tarball" job

2021-09-17 Thread Thomas Huth
This is a leftover from the days when we were using Travis excessively, but since x86 jobs are not really usable there anymore, this job has likely never been used since many months. Let's simply remove it now. Signed-off-by: Thomas Huth --- .travis.yml | 23 --- 1 file chang

Re: [PATCH v3 11/20] nubus-device: add romfile property for loading declaration ROMs

2021-09-17 Thread Markus Armbruster
Mark Cave-Ayland writes: > On 16/09/2021 14:06, Markus Armbruster wrote: > >> Philippe Mathieu-Daudé writes: >> >>> On 9/16/21 12:05 PM, Mark Cave-Ayland wrote: The declaration ROM is located at the top-most address of the standard slot space. Signed-off-by: Mark Cave-Ayland

Re: Rust in Qemu BoF followup: Rust vs. qemu platform support

2021-09-17 Thread Marc-André Lureau
Hi On Fri, Sep 17, 2021 at 1:19 PM Cornelia Huck wrote: > On Fri, Sep 17 2021, David Gibson wrote: > > > Hi all, > > > > At the qemu-in-rust BoF at KVM Forum, I volunteered to look into > > whether Rust supported all the host/build platforms that qemu does, > > which is obviously vital if we wa

Re: [PATCH v3 08/16] iotests/297: Create main() function

2021-09-17 Thread Hanna Reitz
On 16.09.21 06:09, John Snow wrote: Instead of running "run_linters" directly, create a main() function that will be responsible for environment setup, leaving run_linters() responsible only for execution of the linters. (That environment setup will be moved over in forthcoming commits.) Signed

Re: [PATCH] travis.yml: Remove the "Release tarball" job

2021-09-17 Thread Daniel P . Berrangé
On Fri, Sep 17, 2021 at 11:48:26AM +0200, Thomas Huth wrote: > This is a leftover from the days when we were using Travis excessively, > but since x86 jobs are not really usable there anymore, this job has > likely never been used since many months. Let's simply remove it now. > > Signed-off-by: T

Re: [PATCH] ui/gtk: skip any extra draw of same guest scanout blob res

2021-09-17 Thread Gerd Hoffmann
Hi, > +bool draw_submitted; > +QemuMutex mutex; Why the mutex? I think all the code runs while holding the BQL so it should be serialized. > +#ifdef CONFIG_GBM > +if (dmabuf) { > +qemu_mutex_lock(&dmabuf->mutex); > +if (!dmabuf->draw_submitted) { >

Re: [PATCH v3 09/16] iotests/297: Separate environment setup from test execution

2021-09-17 Thread Hanna Reitz
On 16.09.21 06:09, John Snow wrote: Move environment setup into main(), leaving pure test execution behind in run_linters(). Signed-off-by: John Snow Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/297 | 36 +--- 1 file changed, 21 insertions

Re: [PATCH v3 10/16] iotests/297: Add 'directory' argument to run_linters

2021-09-17 Thread Hanna Reitz
On 16.09.21 06:09, John Snow wrote: Allow run_linters to work well if it's executed from a different directory. Signed-off-by: John Snow Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/297 | 3 +++ 1 file changed, 3 insertions(+) Reviewed-by: Hanna Reitz

Re: [PATCH v3 11/16] iotests/297: return error code from run_linters()

2021-09-17 Thread Hanna Reitz
On 16.09.21 06:09, John Snow wrote: This turns run_linters() into a bit of a hybrid test; returning non-zero on failed execution while also printing diffable information. This is done for the benefit of the avocado simple test runner, which will soon be attempting to execute this test from a diff

Re: Rust in Qemu BoF followup: Rust vs. qemu platform support

2021-09-17 Thread David Gibson
On Fri, Sep 17, 2021 at 11:17:01AM +0200, Cornelia Huck wrote: > On Fri, Sep 17 2021, David Gibson wrote: > > > Hi all, > > > > At the qemu-in-rust BoF at KVM Forum, I volunteered to look into > > whether Rust supported all the host/build platforms that qemu does, > > which is obviously vital if

Re: Rust in Qemu BoF followup: Rust vs. qemu platform support

2021-09-17 Thread David Gibson
On Fri, Sep 17, 2021 at 01:54:22PM +0400, Marc-André Lureau wrote: > Hi > > On Fri, Sep 17, 2021 at 1:19 PM Cornelia Huck wrote: > > > On Fri, Sep 17 2021, David Gibson wrote: > > > > > Hi all, > > > > > > At the qemu-in-rust BoF at KVM Forum, I volunteered to look into > > > whether Rust suppo

Re: Rust in Qemu BoF followup: Rust vs. qemu platform support

2021-09-17 Thread Philippe Mathieu-Daudé
Le ven. 17 sept. 2021 10:58, David Gibson a écrit : > Hi all, > > At the qemu-in-rust BoF at KVM Forum, I volunteered to look into > whether Rust supported all the host/build platforms that qemu does, > which is obviously vital if we want to make Rust a non-optional > component of the build > Co

Re: [PATCH v3 14/16] iotests/linters: Add workaround for mypy bug #9852

2021-09-17 Thread Hanna Reitz
On 16.09.21 06:09, John Snow wrote: This one is insidious: if you use the invocation "from {namespace} import {subpackage}" as mirror-top-perms does, mypy will fail on every-other invocation *if* the package being imported is a package. Now, I could just edit mirror-top-perms to avoid this invoc

Re: plugins: Missing Store Exclusive Memory Accesses

2021-09-17 Thread Alex Bennée
Aaron Lindsay writes: > Hello, > > I recently noticed that the plugin interface does not appear to be > emitting callbacks to functions registered via > `qemu_plugin_register_vcpu_mem_cb` for AArch64 store exclusives. This > would include instructions like `stxp w16, x2, x3, [x4]` (encoding: >

Re: [PATCH] travis.yml: Remove the "Release tarball" job

2021-09-17 Thread Alex Bennée
Thomas Huth writes: > This is a leftover from the days when we were using Travis excessively, > but since x86 jobs are not really usable there anymore, this job has > likely never been used since many months. Let's simply remove it now. > > Signed-off-by: Thomas Huth Queued to testing/next, t

Re: [PATCH 0/2] gitlab: some minor CI tweaks

2021-09-17 Thread Alex Bennée
Daniel P. Berrangé writes: > Addressing a few issues raised by Peter on IRC yesterday Queued to testing/next, thanks. -- Alex Bennée

Re: [PATCH v3 16/16] iotests/linters: check mypy files all at once

2021-09-17 Thread Hanna Reitz
On 16.09.21 06:09, John Snow wrote: We can circumvent the '__main__' redefinition problem by passing --scripts-are-modules. Take mypy out of the loop per-filename and check everything in one go: it's quite a bit faster. Is it possible to pull this to the beginning of the series?  Just because

Re: [PATCH] travis.yml: Remove the "Release tarball" job

2021-09-17 Thread Philippe Mathieu-Daudé
Le ven. 17 sept. 2021 11:48, Thomas Huth a écrit : > This is a leftover from the days when we were using Travis excessively, > but since x86 jobs are not really usable there anymore, this job has > likely never been used since many months. Let's simply remove it now. > > Signed-off-by: Thomas Hut

Re: [PATCH v5 01/16] tcg: Expand usadd/ussub with umin/umax

2021-09-17 Thread Matheus K. Ferst
On 15/09/2021 18:30, Richard Henderson wrote: [E-MAIL EXTERNO] Não clique em links ou abra anexos, a menos que você possa confirmar o remetente e saber que o conteúdo é seguro. Em caso de e-mail suspeito entre imediatamente em contato com o DTI. For usadd, we only have to consider overflow. S

Re: Rust in Qemu BoF followup: Rust vs. qemu platform support

2021-09-17 Thread Daniel P . Berrangé
On Fri, Sep 17, 2021 at 06:58:37PM +1000, David Gibson wrote: > Hi all, > > At the qemu-in-rust BoF at KVM Forum, I volunteered to look into > whether Rust supported all the host/build platforms that qemu does, > which is obviously vital if we want to make Rust a non-optional > component of the bu

Re: [PATCH] travis.yml: Remove the "Release tarball" job

2021-09-17 Thread Thomas Huth
On 17/09/2021 13.25, Philippe Mathieu-Daudé wrote: Le ven. 17 sept. 2021 11:48, Thomas Huth > a écrit : This is a leftover from the days when we were using Travis excessively, but since x86 jobs are not really usable there anymore, this job has likely never b

[PATCH v2 0/2] Require hypervisor privilege for tlbie[l] when PSR=0 and HR=1.

2021-09-17 Thread matheus . ferst
From: Matheus Ferst While working on FreeBSD radix support, Leandro Lupori (CC'ed) noticed that the latest build still fails in KVM but works in TCG[1]. This difference occurs because the current implementation of "tlbiel" does not validate the instruction parameters and always check for supervis

[PATCH v2 1/2] target/ppc: add LPCR[HR] to DisasContext and hflags

2021-09-17 Thread matheus . ferst
From: Matheus Ferst Add a Host Radix field (hr) in DisasContext with LPCR[HR] value to allow us to decide between Radix and HPT while validating instructions arguments. Note that PowerISA v3.1 does not require LPCR[HR] and PATE.HR to match if the thread is in ultravisor/hypervisor real addressing

[PATCH v2 2/2] target/ppc: Check privilege level based on PSR and LPCR[HR] in tlbie[l]

2021-09-17 Thread matheus . ferst
From: Matheus Ferst PowerISA v3.0B made tlbie[l] hypervisor privileged when PSR=0 and HR=1. To allow the check at translation time, we'll use the HR bit of LPCR to check the MMU mode instead of the PATE.HR. Signed-off-by: Matheus Ferst --- target/ppc/translate.c | 26 +-

[PATCH 0/1] s390x:clp: implementing CLP immediate commands

2021-09-17 Thread Pierre Morel
CLP immediate commands allow to query the Logical Processor available on the machine and to check for a specific one. I do not see any reason to not implement it. The check for an immediate command is done on bit 0 of the RRF i3 field so let's implement a new clp_immediate_cmd() to handle CLP imm

[PATCH 1/1] s390x:clp: implementing CLP immediate commands

2021-09-17 Thread Pierre Morel
CLP immediate commands allow to query the Logical Processor available on the machine and to check for a specific one. Let's add these commands. Signed-off-by: Pierre Morel --- hw/s390x/s390-pci-inst.c | 33 include/hw/s390x/s390-pci-inst.h | 5 + ta

Re: [PATCH 0/2] hmp: Unbreak "change vnc", tidy up set_password's doc

2021-09-17 Thread Markus Armbruster
Routing to qemu-trivial.

Re: [PATCH 01/15] python/aqmp: add greeting property to QMPClient

2021-09-17 Thread Hanna Reitz
On 17.09.21 07:40, John Snow wrote: Expose the greeting as a read-only property of QMPClient so it can be retrieved at-will. Signed-off-by: John Snow --- python/qemu/aqmp/qmp_client.py | 5 + 1 file changed, 5 insertions(+) Reviewed-by: Hanna Reitz

Re: [PATCH 02/15] python/aqmp: add .empty() method to EventListener

2021-09-17 Thread Hanna Reitz
On 17.09.21 07:40, John Snow wrote: Synchronous clients may want to know if they're about to block waiting for an event or not. A method such as this is necessary to implement a compatible interface for the old QEMUMonitorProtocol using the new async internals. Signed-off-by: John Snow --- py

[PATCH v2 1/2] vhost-user: fix VirtQ notifier cleanup

2021-09-17 Thread Xueming Li
When vhost-user device stop and unmmap notifier address, vCPU thread that writing the notifier via old flatview failed with accessing invalid address. To avoid this concurrent issue, wait memory flatview update by draining rcu callbacks before unmaping notifiers. Fixes: 44866521bd6e ("vhost-user:

[PATCH v2 2/2] vhost-user: remove VirtQ notifier restore

2021-09-17 Thread Xueming Li
When vhost-user vdpa client restart, VQ notifier resources become invalid, no need to keep mmap, vdpa client will set VQ notifier after reconnect. Removes VQ notifier restore and related flags. Fixes: 44866521bd6e ("vhost-user: support registering external host notifiers") Cc: tiwei@intel.com

[PATCH v2 0/2] Improve vhost-user VQ notifier unmap

2021-09-17 Thread Xueming Li
When vDPA applicaiton in client mode shutdown, unmapped VQ notifier might being accessed by vCPU thread under high tx traffic, it will crash VM in rare conditon. This patch try to fix it with better RCU sychronization of new flatview. v2: no RCU draining on vCPU thread Xueming Li (2): vhost-use

Re: [PATCH 03/15] python/aqmp: Return cleared events from EventListener.clear()

2021-09-17 Thread Hanna Reitz
On 17.09.21 07:40, John Snow wrote: This serves two purposes: (1) It is now possible to discern whether or not clear() removed any event(s) from the queue with absolute certainty, and (2) It is now very easy to get a List of all pending events in one chunk, which is useful for the sync bridge.

Re: [PATCH] travis.yml: Remove the "Release tarball" job

2021-09-17 Thread Philippe Mathieu-Daudé
On 9/17/21 1:42 PM, Thomas Huth wrote: > On 17/09/2021 13.25, Philippe Mathieu-Daudé wrote: >> Le ven. 17 sept. 2021 11:48, Thomas Huth > > a écrit : >> >>     This is a leftover from the days when we were using Travis >> excessively, >>     but since x86 jobs are not reall

Re: [PATCH 04/15] python/qmp: clear events on get_events() call

2021-09-17 Thread Hanna Reitz
On 17.09.21 07:40, John Snow wrote: All callers in the tree *already* clear the events after a call to get_events(). Do it automatically instead and update callsites to remove the manual clear call. These semantics are quite a bit easier to emulate with async QMP, and nobody appears to be abusin

  1   2   3   >