Re: [PATCH v2 11/53] target/hexagon: delete unused hexagon_debug() method

On 9/14/21 4:20 PM, Daniel P. Berrangé wrote: > This method isn't used in any code and its functionality is already > available via the 'info registers' HMP command. > > Signed-off-by: Daniel P. Berrangé > --- > target/hexagon/cpu.c | 5 - > target/hexagon/internal.h | 1 - > 2 files ch

Re: [PATCH v2 17/53] target/mips: convert to use format_state instead of dump_state

On 9/14/21 4:20 PM, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > target/mips/cpu.c | 85 +-- > 1 file changed, 45 insertions(+), 40 deletions(-) > > diff --git a/target/mips/cpu.c b/target/mips/cpu.c > index d426918291..9ced90d

Re: [PATCH v4 05/12] job: @force parameter for job_cancel_sync()

14.09.2021 20:20, Hanna Reitz wrote: On 08.09.21 18:33, Vladimir Sementsov-Ogievskiy wrote: 07.09.2021 15:42, Hanna Reitz wrote: Callers should be able to specify whether they want job_cancel_sync() to force-cancel the job or not. In fact, almost all invocations do not care about consistency o

Re: [PATCH v4 07/10] qcow2-refcount: check_refcounts_l2(): check reserved bits

14.09.2021 20:15, Hanna Reitz wrote: On 14.09.21 14:24, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Tested-by: Kirill Tkhai Reviewed-by: Hanna Reitz ---   block/qcow2.h  |  1 +   block/qcow2-refcount.c | 12 +++-   2

Re: [PATCH v2 18/53] target/nios2: convert to use format_state instead of dump_state

On 9/14/21 4:20 PM, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > target/nios2/cpu.c | 2 +- > target/nios2/cpu.h | 2 +- > target/nios2/translate.c | 20 ++-- > 3 files changed, 12 insertions(+), 12 deletions(-) > > diff --git a/target/nios2

Re: [PATCH v2 07/53] target/alpha: convert to use format_state instead of dump_state

On 9/14/21 4:19 PM, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > target/alpha/cpu.c| 2 +- > target/alpha/cpu.h| 2 +- > target/alpha/helper.c | 28 > 3 files changed, 18 insertions(+), 14 deletions(-) > > diff --git a/target/alpha/

Re: [PATCH v2 09/53] target/avr: convert to use format_state instead of dump_state

On 9/14/21 4:19 PM, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > target/avr/cpu.c | 57 > 1 file changed, 29 insertions(+), 28 deletions(-) > > diff --git a/target/avr/cpu.c b/target/avr/cpu.c > index ea14175ca5..17ff21f8b

Re: [PATCH v2] nbd/server: Suppress Broken pipe errors on abrupt disconnection

14.09.2021 19:32, Richard W.M. Jones wrote: On Tue, Sep 14, 2021 at 06:21:58PM +0300, Vladimir Sementsov-Ogievskiy wrote: 14.09.2021 17:52, Richard W.M. Jones wrote: On the server side when the server receives NBD_CMD_DISC it must complete any in-flight requests, but there's no requirement for

Re: [PATCH v2 12/53] target/hexagon: convert to use format_state instead of dump_state

On 9/14/21 4:20 PM, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > target/hexagon/cpu.c | 65 > 1 file changed, 29 insertions(+), 36 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2 15/53] target/m68k: convert to use format_state instead of dump_state

On 9/14/21 4:20 PM, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > target/m68k/cpu.c | 2 +- > target/m68k/cpu.h | 2 +- > target/m68k/translate.c | 92 ++--- > 3 files changed, 51 insertions(+), 45 deletions(-) > swit

Re: [PATCH v2 16/53] target/microblaze: convert to use format_state instead of dump_state

On 9/14/21 4:20 PM, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > target/microblaze/cpu.c | 2 +- > target/microblaze/cpu.h | 2 +- > target/microblaze/translate.c | 45 ++- > 3 files changed, 25 insertions(+), 24 deletions(-)

Re: [PATCH v2 13/53] target/hppa: convert to use format_state instead of dump_state

On 9/14/21 4:20 PM, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > target/hppa/cpu.c| 2 +- > target/hppa/cpu.h| 2 +- > target/hppa/helper.c | 25 ++--- > 3 files changed, 16 insertions(+), 13 deletions(-) > @@ -110,20 +111,22 @@ void hppa_cp

Re: [PATCH v2 19/53] target/openrisc: convert to use format_state instead of dump_state

On 9/14/21 4:20 PM, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > target/openrisc/cpu.c | 2 +- > target/openrisc/cpu.h | 2 +- > target/openrisc/translate.c | 8 > 3 files changed, 6 insertions(+), 6 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2 16/53] target/microblaze: convert to use format_state instead of dump_state

On Wed, Sep 15, 2021 at 9:21 AM Philippe Mathieu-Daudé wrote: > On 9/15/21 9:18 AM, Philippe Mathieu-Daudé wrote: > > On 9/14/21 4:20 PM, Daniel P. Berrangé wrote: > >> Signed-off-by: Daniel P. Berrangé > >> --- > >> target/microblaze/cpu.c | 2 +- > >> target/microblaze/cpu.h | 2

Re: [PATCH v2 22/53] target/rx: convert to use format_state instead of dump_state

On 9/14/21 4:20 PM, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > target/rx/cpu.c | 2 +- > target/rx/cpu.h | 2 +- > target/rx/translate.c | 14 -- > 3 files changed, 10 insertions(+), 8 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2 16/53] target/microblaze: convert to use format_state instead of dump_state

On 9/15/21 9:18 AM, Philippe Mathieu-Daudé wrote: > On 9/14/21 4:20 PM, Daniel P. Berrangé wrote: >> Signed-off-by: Daniel P. Berrangé >> --- >> target/microblaze/cpu.c | 2 +- >> target/microblaze/cpu.h | 2 +- >> target/microblaze/translate.c | 45 ++---

Re: [PATCH v2 24/53] target/sh: convert to use format_state instead of dump_state

On 9/14/21 4:20 PM, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > target/sh4/cpu.c | 2 +- > target/sh4/cpu.h | 2 +- > target/sh4/translate.c | 36 > 3 files changed, 22 insertions(+), 18 deletions(-) Reviewed-by: Philip

Re: [PATCH v2 25/53] target/sparc: convert to use format_state instead of dump_state

On 9/14/21 4:20 PM, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > target/sparc/cpu.c | 85 +- > target/sparc/cpu.h | 2 +- > 2 files changed, 47 insertions(+), 40 deletions(-) > > diff --git a/target/sparc/cpu.c b/target/sparc/

Re: [PATCH v2 26/53] target/tricore: convert to use format_state instead of dump_state

On 9/14/21 4:20 PM, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > target/tricore/cpu.c | 2 +- > target/tricore/cpu.h | 2 +- > target/tricore/translate.c | 24 > 3 files changed, 14 insertions(+), 14 deletions(-) > -void tricore_cpu

Re: [PATCH v2 27/53] target/xtensa: convert to use format_state instead of dump_state

On 9/14/21 4:20 PM, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > target/xtensa/cpu.c | 2 +- > target/xtensa/cpu.h | 2 +- > target/xtensa/translate.c | 45 --- > 3 files changed, 25 insertions(+), 24 deletions(-) > -void

Re: [PATCH v2 10/53] target/cris: convert to use format_state instead of dump_state

On 9/14/21 4:19 PM, Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > target/cris/cpu.c | 2 +- > target/cris/cpu.h | 2 +- > target/cris/translate.c | 33 + > 3 files changed, 19 insertions(+), 18 deletions(-) > > diff --git a/ta

Re: [PATCH 2/2] gitlab: Add cross-riscv64-system, cross-riscv64-user

On 9/14/21 8:58 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > .gitlab-ci.d/crossbuilds.yml | 14 ++ > 1 file changed, 14 insertions(+) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 1/2] tests/docker: promote debian-riscv64-cross to a full image

On 9/14/21 8:58 PM, Richard Henderson wrote: > From: Alex Bennée > > To be able to cross build QEMU itself we need to include a few more > libraries. These are only available in Debian's unstable ports repo > for now so we need to base the riscv64 image on sid with the the > minimal libs needed t

Re: [PATCH v2 0/2] hw/arm/raspi: Remove deprecated raspi2/raspi3 aliases

On 9/15/21 2:34 AM, John Snow wrote: > On Fri, Aug 27, 2021 at 2:30 PM Philippe Mathieu-Daudé > wrote: > > On 8/27/21 8:01 PM, Willian Rampazzo wrote: > > Hi, Phil, > > > > On Thu, Aug 26, 2021 at 1:49 PM Philippe Mathieu-Daudé > mailto:f4...@amsat.org>

Deprecate 32-bit hosts? (was: Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type)

On 14/09/2021 17.22, Richard Henderson wrote: On 9/14/21 5:26 AM, Peter Maydell wrote: (2) RAM blocks should have a length that fits inside a signed 32-bit type on 32-bit hosts (at least I assume this is where the 2047MB limit is coming from; in theory this ought to be improveable

Re: [PATCH v4 00/12] mirror: Handle errors after READY cancel

07.09.2021 15:42, Hanna Reitz wrote: Hi, v1 cover letter: https://lists.nongnu.org/archive/html/qemu-block/2021-07/msg00705.html v2 cover letter: https://lists.nongnu.org/archive/html/qemu-block/2021-07/msg00747.html v3 cover letter: https://lists.nongnu.org/archive/html/qemu-block/2021-08/msg

Re: Deprecate 32-bit hosts? (was: Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type)

On 9/15/21 9:42 AM, Thomas Huth wrote: > On 14/09/2021 17.22, Richard Henderson wrote: >> On 9/14/21 5:26 AM, Peter Maydell wrote: >>> (2) RAM blocks should have a length that fits inside a >>> signed 32-bit type on 32-bit hosts (at least I assume this >>> is where the 2047MB limit is com

Re: [PATCH v2 27/53] target/xtensa: convert to use format_state instead of dump_state

On Wed, Sep 15, 2021 at 12:32 AM Philippe Mathieu-Daudé wrote: > On 9/14/21 4:20 PM, Daniel P. Berrangé wrote: > > if ((flags & CPU_DUMP_FPU) && > > xtensa_option_enabled(env->config, XTENSA_OPTION_FP_COPROCESSOR)) { > > -qemu_fprintf(f, "\n"); > > +g_string_append_pr

Re: [PATCH v2 49/53] target/xtensa: convert to use format_tlb callback

On Tue, Sep 14, 2021 at 7:35 AM Daniel P. Berrangé wrote: > > Change the "info tlb" implementation to use the format_tlb callback. > > Signed-off-by: Daniel P. Berrangé > --- > target/xtensa/cpu.h| 2 +- > target/xtensa/mmu_helper.c | 126 + > target

Re: [PATCH v11 03/16] target/riscv: clwz must ignore high bits (use shift-left & changed logic)

On 2021/9/14 下午6:24, Philipp Tomsich wrote: On Tue 14. Sep 2021 at 11:15, LIU Zhiwei > wrote: On 2021/9/11 下午10:00, Philipp Tomsich wrote: > Assume clzw being executed on a register that is not sign-extended, such > as for the following sequence

Re: [PATCH 11/20] nubus-device: add romfile property for loading declaration ROMs

On 14/09/2021 21:23, Mark Cave-Ayland wrote: On 12/09/2021 18:39, Philippe Mathieu-Daudé wrote: On 9/12/21 9:49 AM, Mark Cave-Ayland wrote: The declaration ROM is located at the top-most address of the standard slot space. Signed-off-by: Mark Cave-Ayland ---   hw/nubus/nubus-device.c  | 43

Re: [PATCH 1/2] tests/docker: promote debian-riscv64-cross to a full image

Philippe Mathieu-Daudé writes: > On 9/14/21 8:58 PM, Richard Henderson wrote: >> From: Alex Bennée >> >> To be able to cross build QEMU itself we need to include a few more >> libraries. These are only available in Debian's unstable ports repo >> for now so we need to base the riscv64 image o

Re: [PATCH] qemu-img: Add -F shorthand to convert

13.09.2021 16:17, Eric Blake wrote: Although we have long supported 'qemu-img convert -o backing_file=foo,backing_fmt=bar', the fact that we have a shortcut -B for backing_file but none for backing_fmt has made it more likely that users accidentally run into: qemu-img: warning: Deprecated use of

Re: [PATCH] gitlab-ci: Make more custom runner jobs manual, and don't allow failure

On Tue, Sep 14, 2021 at 08:17:19PM +0100, Peter Maydell wrote: > On Mon, 13 Sept 2021 at 11:19, Peter Maydell wrote: > > > > Currently we define a lot of jobs for our custom runners: > > for both aarch64 and s390x we have > > - all-linux-static > > - all > > - alldbg > > - clang (manual) > >

Re: [PATCH] qemu-img: Add -F shorthand to convert

On Mon, 2021-09-13 at 08:17 -0500, Eric Blake wrote: > Although we have long supported 'qemu-img convert -o > backing_file=foo,backing_fmt=bar', the fact that we have a shortcut -B > for backing_file but none for backing_fmt has made it more likely that > users accidentally run into: > > qemu-img:

Re: [PATCH] virtio-balloon: Fix page-poison subsection name

Note this also correspounds to: https://gitlab.com/qemu-project/qemu/-/issues/485 -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

Re: Deprecate 32-bit hosts? (was: Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type)

On Wed, Sep 15, 2021 at 09:42:48AM +0200, Thomas Huth wrote: > On 14/09/2021 17.22, Richard Henderson wrote: > > On 9/14/21 5:26 AM, Peter Maydell wrote: > > > (2) RAM blocks should have a length that fits inside a > > > signed 32-bit type on 32-bit hosts (at least I assume this > > > is

Re: [PATCH] gitlab-ci: Make more custom runner jobs manual, and don't allow failure

On 9/15/21 10:29 AM, Daniel P. Berrangé wrote: > On Tue, Sep 14, 2021 at 08:17:19PM +0100, Peter Maydell wrote: >> On Mon, 13 Sept 2021 at 11:19, Peter Maydell >> wrote: >>> >>> Currently we define a lot of jobs for our custom runners: >>> for both aarch64 and s390x we have >>> - all-linux-stati

[PATCH] target/riscv: csr: Rename HCOUNTEREN_CY and friends

The macro name HCOUNTEREN_CY suggests it is for CSR HCOUNTEREN, but in fact it applies to M-mode and S-mode CSR too. Rename these macros to have the COUNTEREN_ prefix. Signed-off-by: Bin Meng --- target/riscv/cpu_bits.h | 8 target/riscv/csr.c | 24 2 fil

Re: [PATCH v2 09/53] target/avr: convert to use format_state instead of dump_state

On Wed, Sep 15, 2021 at 09:13:14AM +0200, Philippe Mathieu-Daudé wrote: > On 9/14/21 4:19 PM, Daniel P. Berrangé wrote: > > Signed-off-by: Daniel P. Berrangé > > --- > > target/avr/cpu.c | 57 > > 1 file changed, 29 insertions(+), 28 deletions(-) >

Re: Deprecate 32-bit hosts? (was: Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type)

On 9/15/21 10:37 AM, Daniel P. Berrangé wrote: > On Wed, Sep 15, 2021 at 09:42:48AM +0200, Thomas Huth wrote: >> On 14/09/2021 17.22, Richard Henderson wrote: >>> On 9/14/21 5:26 AM, Peter Maydell wrote: (2) RAM blocks should have a length that fits inside a signed 32-bit type on 32-

Re: [PATCH v2 27/53] target/xtensa: convert to use format_state instead of dump_state

On Wed, Sep 15, 2021 at 09:32:38AM +0200, Philippe Mathieu-Daudé wrote: > On 9/14/21 4:20 PM, Daniel P. Berrangé wrote: > > Signed-off-by: Daniel P. Berrangé > > --- > > target/xtensa/cpu.c | 2 +- > > target/xtensa/cpu.h | 2 +- > > target/xtensa/translate.c | 45 ++

Re: [PATCH v2 09/53] target/avr: convert to use format_state instead of dump_state

On 9/15/21 10:49 AM, Daniel P. Berrangé wrote: > On Wed, Sep 15, 2021 at 09:13:14AM +0200, Philippe Mathieu-Daudé wrote: >> On 9/14/21 4:19 PM, Daniel P. Berrangé wrote: >>> Signed-off-by: Daniel P. Berrangé >>> --- >>> target/avr/cpu.c | 57 >>> 1

Re: [RFC 1/1] docs/deve/ci-plan: define a high-level plan for the QEMU GitLab CI

On Tue, Sep 14, 2021 at 03:48:30PM -0300, Willian Rampazzo wrote: > This adds a high-level plan for the QEMU GitLab CI based on use cases. > The idea is to have a base for evolving the QEMU CI. It sets high-level > characteristics for the QEMU CI use cases, which helps guide its > development. > >

Re: [PATCH v2] nbd/server: Suppress Broken pipe errors on abrupt disconnection

On Wed, Sep 15, 2021 at 10:15:20AM +0300, Vladimir Sementsov-Ogievskiy wrote: > 14.09.2021 19:32, Richard W.M. Jones wrote: > >On Tue, Sep 14, 2021 at 06:21:58PM +0300, Vladimir Sementsov-Ogievskiy wrote: > >>14.09.2021 17:52, Richard W.M. Jones wrote: > >>>On the > >>>server side when the server r

Re: [PATCH v2 27/53] target/xtensa: convert to use format_state instead of dump_state

On 9/15/21 10:52 AM, Daniel P. Berrangé wrote: > On Wed, Sep 15, 2021 at 09:32:38AM +0200, Philippe Mathieu-Daudé wrote: >> On 9/14/21 4:20 PM, Daniel P. Berrangé wrote: >>> Signed-off-by: Daniel P. Berrangé >>> --- >>> target/xtensa/cpu.c | 2 +- >>> target/xtensa/cpu.h | 2 +- >>>

Re: Deprecate 32-bit hosts? (was: Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type)

On Wed, Sep 15, 2021 at 10:51:56AM +0200, Philippe Mathieu-Daudé wrote: > On 9/15/21 10:37 AM, Daniel P. Berrangé wrote: > > On Wed, Sep 15, 2021 at 09:42:48AM +0200, Thomas Huth wrote: > >> On 14/09/2021 17.22, Richard Henderson wrote: > >>> On 9/14/21 5:26 AM, Peter Maydell wrote: > (2) RAM

Re: [PATCH v2] nbd/server: Suppress Broken pipe errors on abrupt disconnection

15.09.2021 12:00, Richard W.M. Jones wrote: On Wed, Sep 15, 2021 at 10:15:20AM +0300, Vladimir Sementsov-Ogievskiy wrote: 14.09.2021 19:32, Richard W.M. Jones wrote: On Tue, Sep 14, 2021 at 06:21:58PM +0300, Vladimir Sementsov-Ogievskiy wrote: 14.09.2021 17:52, Richard W.M. Jones wrote: On th

Re: high cpu usage in idle state

On 9/15/21 9:46 AM, Ali Vatankhah wrote: > Dear qemu developers > I built an image for e5500 cpu with yocto and run with qemu ppce500 machine: > qemu-system-ppc64 -nographic -M ppce500 -cpu e5500 -kernel uImage > -initrd core-image-minimal.rootfs.ext2.gz -append 'root=/dev/ram rw'  > It works well,

Re: [PATCH v2 0/1] Update check-python-tox test for pylint 2.10

On Wed, Sep 15, 2021 at 01:30:10AM -0400, John Snow wrote: > V2: It's not safe to use sys.stderr.encoding to determine a "console > encoding", because that uses the "current" stderr and not a > hypothetically generic one -- and doing this causes the acceptance tests > to fail. > > Use UTF-8 instea

Re: [PATCH v3 6/6] tests/qapi-schema: Test cases for aliases

Am 14.09.2021 um 15:29 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 14.09.2021 um 10:59 hat Markus Armbruster geschrieben: > >> >> > +/* You can't use more than one option at the same time */ > >> >> > +v = visitor_input_test_init(data, "{ 'foo': 42, 'nested': { > >>

Re: [PATCH v9 07/11] hvf: arm: Implement PSCI handling

On Mon, 13 Sep 2021 13:30:57 +0100, Peter Maydell wrote: > > On Mon, 13 Sept 2021 at 13:02, Alexander Graf wrote: > > > > > > On 13.09.21 13:44, Peter Maydell wrote: > > > On Mon, 13 Sept 2021 at 12:07, Alexander Graf wrote: > > >> To keep your train of thought though, what would you do if we e

Re: [PATCH 0/3] target/arm: Set FPSCR.LTPSIZE for user-mode

Hi Peter, Thanks for the prompt patches! On Tue, Sep 14, 2021 at 2:08 PM Peter Maydell wrote: > This patchset fixes https://gitlab.com/qemu-project/qemu/-/issues/613 > which is a bug where we weren't setting FPSCR.LTPSIZE correctly > out of reset for the user-mode emulator. The effect is that >

[PATCH v2 00/20] nubus: bus, device, bridge, IRQ and address space improvements

This patchset is the next set of changes required to boot MacOS on the q800 machine. The main aim of these patches is to improve the Nubus support so that devices can be plugged into the Nubus from the command line i.e. -device nubus-macfb[,slot=num][,romfile=decl.rom] At the moment the onl

[PATCH v2 01/20] nubus-device: rename slot_nb variable to slot

This is in preparation for creating a qdev property of the same name. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé --- hw/nubus/nubus-device.c | 14 +++--- include/hw/nubus/nubus.h | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/nubus/n

[PATCH v2 02/20] nubus-device: expose separate super slot memory region

According to "Designing Cards and Drivers for the Macintosh Family" each physical nubus slot can access 2 separate address ranges: a super slot memory region which is 256MB and a standard slot memory region which is 16MB. Currently a Nubus device uses the physical slot number to determine whethe

[PATCH v2 06/20] nubus: implement BusClass get_dev_path()

Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé --- hw/nubus/nubus-bus.c | 16 1 file changed, 16 insertions(+) diff --git a/hw/nubus/nubus-bus.c b/hw/nubus/nubus-bus.c index dbd930d5cd..755601ad55 100644 --- a/hw/nubus/nubus-bus.c +++ b/hw/nubus/nubus-bus.c

[PATCH v2 03/20] nubus-device: add device slot parameter

This prepares for allowing Nubus devices to be placed in a specific slot instead of always being auto-allocated by the bus itself. Signed-off-by: Mark Cave-Ayland --- hw/nubus/nubus-device.c | 6 ++ include/hw/nubus/nubus.h | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git

[PATCH v2 07/20] nubus: add trace-events for empty slot accesses

Increase the max_access_size to 4 bytes for empty Nubus slot and super slot accesses to allow tracing of the Nubus enumeration process by the guest OS. Signed-off-by: Mark Cave-Ayland --- hw/nubus/nubus-bus.c | 10 +++--- hw/nubus/trace-events | 7 +++ hw/nubus/trace.h | 1 + mes

[PATCH v2 16/20] nubus-bridge: embed the NubusBus object directly within nubus-bridge

Since nubus-bridge is a container for NubusBus then it should be embedded directly within the bridge device using qbus_create_inplace(). Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé --- hw/m68k/q800.c | 2 +- hw/nubus/mac-nubus-bridge.c | 7 --- hw/nubus/

[PATCH v2 04/20] nubus: use bitmap to manage available slots

Convert nubus_device_realize() to use a bitmap to manage available slots to allow for future Nubus devices to be plugged into arbitrary slots from the command line. Update mac_nubus_bridge_init() to only allow slots 0x9 to 0xe on a Macintosh machines as documented in "Desigining Cards and Driver

[PATCH v2 05/20] nubus: move slot bitmap checks from NubusDevice realize() to BusClass check_address()

Allow Nubus to manage the slot allocations itself using the BusClass check_address() virtual function rather than managing this during NubusDevice realize(). Signed-off-by: Mark Cave-Ayland --- hw/nubus/nubus-bus.c| 37 + hw/nubus/nubus-device.c | 29

[PATCH v2 09/20] macfb: don't register declaration ROM

The macfb device is an on-board framebuffer and so is initialised by the system declaration ROM included within the MacOS toolbox ROM. Signed-off-by: Mark Cave-Ayland --- hw/display/macfb.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/hw/display/macfb.c b/hw/display/macfb.c index d81

[PATCH v2 20/20] q800: configure nubus available slots for Quadra 800

Slot 0x9 is reserved for use by the in-built framebuffer whilst only slots 0xc, 0xd and 0xe physically exist on the Quadra 800. Signed-off-by: Mark Cave-Ayland --- hw/m68k/q800.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/m68k/q800.c b/hw/m68k/q800.c index fbc45a301f..65c804

[PATCH v2 08/20] nubus: generate bus error when attempting to access empty slots

According to "Designing Cards and Drivers for the Macintosh Family" any attempt to access an unimplemented address location on Nubus generates a bus error. MacOS uses a custom bus error handler to detect empty Nubus slots, and with the current implementation assumes that all slots are occupied as

[PATCH v2 13/20] nubus-bridge: introduce separate NubusBridge structure

This is to allow the Nubus bridge to store its own additional state. Also update the comment in the file header to reflect that nubus-bridge is not specific to the Macintosh. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé --- hw/nubus/nubus-bridge.c | 4 ++-- in

[PATCH v2 10/20] nubus-device: remove nubus_register_rom() and nubus_register_format_block()

Since there is no need to generate a dummy declaration ROM, remove both nubus_register_rom() and nubus_register_format_block(). These will shortly be replaced with a mechanism to optionally load a declaration ROM from disk to allow real images to be used within QEMU. Signed-off-by: Mark Cave-Aylan

[PATCH v2 19/20] q800: wire up nubus IRQs

Nubus IRQs are routed to the CPU through the VIA2 device so wire up the IRQs using gpios accordingly. Signed-off-by: Mark Cave-Ayland --- hw/m68k/q800.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/m68k/q800.c b/hw/m68k/q800.c index e34df1a829..fbc45a301f 100644 --- a/hw/m68k/q800

[PATCH v2 14/20] mac-nubus-bridge: rename MacNubusState to MacNubusBridge

This better reflects that the mac-nubus-bridge device is derived from the nubus-bridge device, and that the structure represents the state of the bridge device and not the Nubus itself. Also update the comment in the file header to reflect that mac-nubus-bridge is specific to the Macintosh. Signed

[PATCH v2 11/20] nubus-device: add romfile property for loading declaration ROMs

The declaration ROM is located at the top-most address of the standard slot space. Signed-off-by: Mark Cave-Ayland --- hw/nubus/nubus-device.c | 43 +++- include/hw/nubus/nubus.h | 6 ++ 2 files changed, 48 insertions(+), 1 deletion(-) diff --git a/hw/n

[PATCH v2 12/20] nubus: move nubus to its own 32-bit address space

According to "Designing Cards and Drivers for the Macintosh Family" the Nubus has its own 32-bit address space based upon physical slot addressing. Move Nubus to its own 32-bit address space and then use memory region aliases to map available slot and super slot ranges into the q800 system address

[PATCH v2 15/20] nubus: move NubusBus from mac-nubus-bridge to nubus-bridge

Now that Nubus has its own address space rather than mapping directly into the system bus, move the Nubus reference from MacNubusBridge to NubusBridge. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé --- hw/m68k/q800.c | 2 +- hw/nubus/mac-nubus-bridge.c

[PATCH v2 17/20] nubus-bridge: make slot_available_mask a qdev property

This is to allow Macintosh machines to further specify which slots are available since the number of addressable slots may not match the number of physical slots present in the machine. Signed-off-by: Mark Cave-Ayland --- hw/nubus/nubus-bridge.c | 7 +++ 1 file changed, 7 insertions(+) diff

[PATCH v2 18/20] nubus: add support for slot IRQs

Each Nubus slot has an IRQ line that can be used to request service from the CPU. Connect the IRQs to the Nubus bridge so that they can be wired up using qdev gpios accordingly, and introduce a new nubus_set_irq() function that can be used by Nubus devices to control the slot IRQ. Signed-off-by:

Re: SMMU Stage 2 translation in QEMU

Hi Shashi, On 9/14/21 5:57 PM, shashi.mall...@linaro.org wrote: > Hi Eric, > On Mon, 2021-09-13 at 10:19 +0200, Eric Auger wrote: >> Hi Shashi, >> >> On 9/10/21 3:32 PM, shashi.mall...@linaro.org wrote: >>> So that would be the driver code running in guest OS because i see >>> tables being setup b

Re: [PATCH v2 04/20] nubus: use bitmap to manage available slots

On 9/15/21 12:10 PM, Mark Cave-Ayland wrote: > Convert nubus_device_realize() to use a bitmap to manage available slots to > allow > for future Nubus devices to be plugged into arbitrary slots from the command > line. > > Update mac_nubus_bridge_init() to only allow slots 0x9 to 0xe on a Macinto

Re: [PATCH v4 00/10] qcow2 check: check some reserved bits and subcluster bitmaps

On 14.09.21 14:24, Vladimir Sementsov-Ogievskiy wrote: Hi all! Here are some good refactorings and new (qemu-img check) checks for qcow2. Thanks, applied to my block branch: https://gitlab.com/hreitz/qemu/-/commits/block/ (Patch 6 is here: https://gitlab.com/hreitz/qemu/-/commit/93c40e7dab2

Re: [PATCH v2 07/20] nubus: add trace-events for empty slot accesses

On 9/15/21 12:10 PM, Mark Cave-Ayland wrote: > Increase the max_access_size to 4 bytes for empty Nubus slot and super slot > accesses to allow tracing of the Nubus enumeration process by the guest OS. I forgot to reply to v1, this is OK but I'd rather have 2 different patches here, tracing first t

Re: [PATCH v2 20/20] q800: configure nubus available slots for Quadra 800

On Wed, 15 Sep 2021, Mark Cave-Ayland wrote: Slot 0x9 is reserved for use by the in-built framebuffer whilst only slots 0xc, 0xd and 0xe physically exist on the Quadra 800. Signed-off-by: Mark Cave-Ayland --- hw/m68k/q800.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/m68k/q80

[PATCH] configure/optionrom: Fix MSYS2 multiboot.bin issue

This patch enables native builds on MSYS2 with symlinks disabled. Signed-off-by: Helge Konetzka --- Without this patch these builds fail with: make[1]: *** No rule to make target 'multiboot.bin', needed by 'all'. Stop. make: *** [Makefile:189: pc-bios/optionrom/all] Error 2 make: *** Waiting

Re: [PATCH v9 07/11] hvf: arm: Implement PSCI handling

On 15.09.21 11:46, Marc Zyngier wrote: > On Mon, 13 Sep 2021 13:30:57 +0100, > Peter Maydell wrote: >> On Mon, 13 Sept 2021 at 13:02, Alexander Graf wrote: >>> >>> On 13.09.21 13:44, Peter Maydell wrote: On Mon, 13 Sept 2021 at 12:07, Alexander Graf wrote: > To keep your train of thou

Re: [PATCH] qemu-img: Add -F shorthand to convert

On 13.09.21 15:17, Eric Blake wrote: Although we have long supported 'qemu-img convert -o backing_file=foo,backing_fmt=bar', the fact that we have a shortcut -B for backing_file but none for backing_fmt has made it more likely that users accidentally run into: qemu-img: warning: Deprecated use o

Re: [PATCH v2 20/20] q800: configure nubus available slots for Quadra 800

On 9/15/21 12:50 PM, BALATON Zoltan wrote: > On Wed, 15 Sep 2021, Mark Cave-Ayland wrote: >> Slot 0x9 is reserved for use by the in-built framebuffer whilst only >> slots >> 0xc, 0xd and 0xe physically exist on the Quadra 800. >> >> Signed-off-by: Mark Cave-Ayland >> --- >> hw/m68k/q800.c | 9

Re: [RFC PATCH 1/1] QEMU plugin interface extension

Florian Hauschild writes: > This extension covers functions: > * to read and write guest memory > * to read and write guest registers > * to flush tb cache > * to control single stepping of qemu from plugin Next time please split the functionality into separate patches to aid review.

Re: [PATCH v4 00/10] qcow2 check: check some reserved bits and subcluster bitmaps

15.09.2021 13:26, Hanna Reitz wrote: On 14.09.21 14:24, Vladimir Sementsov-Ogievskiy wrote: Hi all! Here are some good refactorings and new (qemu-img check) checks for qcow2. Thanks, applied to my block branch: https://gitlab.com/hreitz/qemu/-/commits/block/ (Patch 6 is here: https://gitla

Re: [PATCH v2 04/20] nubus: use bitmap to manage available slots

On 15/09/2021 11:39, Philippe Mathieu-Daudé wrote: On 9/15/21 12:10 PM, Mark Cave-Ayland wrote: Convert nubus_device_realize() to use a bitmap to manage available slots to allow for future Nubus devices to be plugged into arbitrary slots from the command line. Update mac_nubus_bridge_init()

Re: [PATCH v2 20/20] q800: configure nubus available slots for Quadra 800

On 15/09/2021 11:50, BALATON Zoltan wrote: On Wed, 15 Sep 2021, Mark Cave-Ayland wrote: Slot 0x9 is reserved for use by the in-built framebuffer whilst only slots 0xc, 0xd and 0xe physically exist on the Quadra 800. Signed-off-by: Mark Cave-Ayland --- hw/m68k/q800.c | 9 + 1 file chang

Re: [PATCH v4 23/33] sgx-epc: Add the reset interface for sgx-epc virt device

On Tue, Sep 14, 2021 at 08:53:48AM +0200, Philippe Mathieu-Daudé wrote: > On 7/19/21 1:21 PM, Yang Zhong wrote: > > If the VM is reset, we need make sure sgx virt epc in clean status. > > Once the VM is reset, and sgx epc virt device will be reseted by > > reset callback registered by qemu_register

Re: [RFC PATCH 0/4] block layer: split block APIs in graph and I/O

On 13/09/21 15:10, Stefan Hajnoczi wrote: On Wed, Sep 08, 2021 at 09:10:17AM -0400, Emanuele Giuseppe Esposito wrote: Currently, block layer APIs like block-backend.h contain a mix of functions that are either running in the main loop and under the BQL, or are thread-safe functions and run in io

Re: [PATCH] gitlab-ci: Make more custom runner jobs manual, and don't allow failure

On Wed, 15 Sept 2021 at 09:29, Daniel P. Berrangé wrote: > Urgh, my bad, I completely forget this behaviour when reviewing. > When we only have > > when: manual > > then the job has to be manually started, and it still contributes > to pipeline status, so it /must/ triggered manually. > > If we

Re: [RFC PATCH 3/4] include/sysemu/block-backend: split header into I/O and graph API

On 13/09/21 15:27, Stefan Hajnoczi wrote: +/* + * I/O API functions. These functions are thread-safe, and therefore + * can run in any AioContext. "can run in any AioContext" makes me wonder what the exact requirements are. Can they run in any*thread* (regardless of whether an AioContext even e

Re: [PATCH] gitlab-ci: Make more custom runner jobs manual, and don't allow failure

On Wed, Sep 15, 2021 at 01:12:23PM +0100, Peter Maydell wrote: > On Wed, 15 Sept 2021 at 09:29, Daniel P. Berrangé wrote: > > Urgh, my bad, I completely forget this behaviour when reviewing. > > When we only have > > > > when: manual > > > > then the job has to be manually started, and it still

Re: [PATCH] gitlab-ci: Make more custom runner jobs manual, and don't allow failure

On Wed, 15 Sept 2021 at 13:16, Daniel P. Berrangé wrote: > > On Wed, Sep 15, 2021 at 01:12:23PM +0100, Peter Maydell wrote: > > On Wed, 15 Sept 2021 at 09:29, Daniel P. Berrangé > > wrote: > > > Urgh, my bad, I completely forget this behaviour when reviewing. > > > When we only have > > > > > >

[PATCH] gitlab-ci: Mark manual-only jobs as allow_failure

If a gitlab CI job is marked as manual-only but is not marked as allow_failure, then gitlab considers that the pipeline is "blocked" until the job has been manually triggered. We need to mark these manual-only jobs as also allow_failure: true so that gitlab doesn't insist that they have run before

Re: [PATCH] gitlab-ci: Mark manual-only jobs as allow_failure

On Wed, Sep 15, 2021 at 01:34:12PM +0100, Peter Maydell wrote: > If a gitlab CI job is marked as manual-only but is not marked > as allow_failure, then gitlab considers that the pipeline is > "blocked" until the job has been manually triggered. We need > to mark these manual-only jobs as also allow

Re: [PATCH v4 00/33] Qemu SGX virtualization

On Tue, Sep 14, 2021 at 08:51:47AM +0200, Philippe Mathieu-Daudé wrote: > On 7/19/21 1:21 PM, Yang Zhong wrote: > > > This series is Qemu SGX virtualization implementation rebased on latest > > Qemu release. The numa support for SGX will be sent in another patchset > > once this basic SGX patchset

Re: [PATCH V2] util: Remove redundant checks in the openpty()

Le 14/09/2021 à 09:43, Alex Chen a écrit : > Hi all, > > This patch has been reviewed by Peter. who can help merge it? > > Thanks, > Alex > > On 2020/11/2 18:55, AlexChen wrote: >> As we can see from the following function call stack, amaster and aslave >> can not be NULL: char_pty_open() -> qem

Re: [PATCH v2] hw/i386/acpi-build: Fix a typo

Le 11/09/2021 à 10:20, Philippe Mathieu-Daudé a écrit : > Fix 'hotplugabble' -> 'hotpluggable' typo. > > Reviewed-by: Ani Sinha > Signed-off-by: Philippe Mathieu-Daudé > --- > v1 still had a typo =) (Volker Rümelin) > --- > hw/i386/acpi-build.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 d

Re: [PATCH v2] hw/i386/acpi-build: Fix a typo

Le 15/09/2021 à 14:48, Laurent Vivier a écrit : > Le 11/09/2021 à 10:20, Philippe Mathieu-Daudé a écrit : >> Fix 'hotplugabble' -> 'hotpluggable' typo. >> >> Reviewed-by: Ani Sinha >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> v1 still had a typo =) (Volker Rümelin) >> --- >> hw/i386/acpi-b

Re: [PATCH v2 0/1] Update check-python-tox test for pylint 2.10

On Wed, Sep 15, 2021 at 5:10 AM Daniel P. Berrangé wrote: > On Wed, Sep 15, 2021 at 01:30:10AM -0400, John Snow wrote: > > V2: It's not safe to use sys.stderr.encoding to determine a "console > > encoding", because that uses the "current" stderr and not a > > hypothetically generic one -- and doi

  1   2   3   4   >