Re: [PULL 0/6] Vga 20210910 patches

2021-09-14 Thread Gerd Hoffmann
On Fri, Sep 10, 2021 at 05:52:55PM +0100, Peter Maydell wrote: > On Fri, 10 Sept 2021 at 14:19, Gerd Hoffmann wrote: > > > > The following changes since commit bd662023e683850c085e98c8ff8297142c2dd9f2: > > > > Merge remote-tracking branch > > 'remotes/mcayland/tags/qemu-openbios-20210908' into

Re: [PATCH 03/22] qapi: Convert simple union KeyValue to flat one

2021-09-14 Thread Gerd Hoffmann
On Mon, Sep 13, 2021 at 02:39:13PM +0200, Markus Armbruster wrote: > Simple unions predate flat unions. Having both complicates the QAPI > schema language and the QAPI generator. We haven't been using simple > unions in new code for a long time, because they are less flexible and > somewhat awkwa

Re: [PATCH 04/22] qapi: Convert simple union InputEvent to flat one

2021-09-14 Thread Gerd Hoffmann
On Mon, Sep 13, 2021 at 02:39:14PM +0200, Markus Armbruster wrote: > Simple unions predate flat unions. Having both complicates the QAPI > schema language and the QAPI generator. We haven't been using simple > unions in new code for a long time, because they are less flexible and > somewhat awkwa

Re: [PATCH V2] util: Remove redundant checks in the openpty()

2021-09-14 Thread Alex Chen
Hi all, This patch has been reviewed by Peter. who can help merge it? Thanks, Alex On 2020/11/2 18:55, AlexChen wrote: > As we can see from the following function call stack, amaster and aslave > can not be NULL: char_pty_open() -> qemu_openpty_raw() -> openpty(). > In addition, according to the

Re: [PATCH v2 04/17] iotests.py: rewrite default luks support in qemu_img

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
13.09.2021 14:16, Hanna Reitz wrote: On 20.07.21 13:38, Vladimir Sementsov-Ogievskiy wrote: Move the logic to more generic qemu_img_pipe_and_status(). Also behave better when we have several -o options. And reuse argument parser of course. Signed-off-by: Vladimir Sementsov-Ogievskiy ---   test

Re: [PATCH v2 04/17] iotests.py: rewrite default luks support in qemu_img

2021-09-14 Thread Hanna Reitz
On 14.09.21 09:44, Vladimir Sementsov-Ogievskiy wrote: 13.09.2021 14:16, Hanna Reitz wrote: On 20.07.21 13:38, Vladimir Sementsov-Ogievskiy wrote: Move the logic to more generic qemu_img_pipe_and_status(). Also behave better when we have several -o options. And reuse argument parser of course.

Re: [PATCH v2] docs: add supported host CPU architectures section

2021-09-14 Thread Marc-André Lureau
Hi On Mon, Sep 13, 2021 at 6:28 PM Peter Maydell wrote: > On Mon, 13 Sept 2021 at 14:10, wrote: > > > > From: Marc-André Lureau > > > > I was looking for such documentation, but couldn't find it. Add it to > > the build-platform.rst document. > > > > Signed-off-by: Marc-André Lureau > > --- >

Re: [qemu-web RFC PATCH] Add Sponsors page

2021-09-14 Thread Daniel P . Berrangé
On Tue, Sep 14, 2021 at 07:41:47AM +0200, Thomas Huth wrote: > On 13/09/2021 20.25, Philippe Mathieu-Daudé wrote: > > Add a page listing QEMU sponsors and displaying their logos. > > > > Logo sources: > > - https://www.rackspace.com/es/newsroom/media-kit > > - https://developer.arm.com/solutions/i

Re: [qemu-web PATCH] Gemfile: Add webrick bundle dependency

2021-09-14 Thread Daniel P . Berrangé
On Tue, Sep 14, 2021 at 07:17:11AM +0200, Thomas Huth wrote: > On 13/09/2021 20.29, Philippe Mathieu-Daudé wrote: > > Without the webrick bundle, jekyll fails to start: > > > >$ bundle exec jekyll serve > >Ignoring ffi-1.11.1 because its extensions are not built. Try: gem > > pristine ffi

Re: [PATCH v6 1/6] spapr_numa.c: split FORM1 code into helpers

2021-09-14 Thread Greg Kurz
On Fri, 10 Sep 2021 16:55:34 -0300 Daniel Henrique Barboza wrote: > The upcoming FORM2 NUMA affinity will support asymmetric NUMA topologies > and doesn't need be concerned with all the legacy support for older > pseries FORM1 guests. > > We're also not going to calculate associativity domains b

Re: [qemu-web RFC PATCH] Add Sponsors page

2021-09-14 Thread Philippe Mathieu-Daudé
On 9/14/21 10:20 AM, Daniel P. Berrangé wrote: > On Tue, Sep 14, 2021 at 07:41:47AM +0200, Thomas Huth wrote: >> On 13/09/2021 20.25, Philippe Mathieu-Daudé wrote: >>> Add a page listing QEMU sponsors and displaying their logos. >>> >>> Logo sources: >>> - https://www.rackspace.com/es/newsroom/medi

Re: [PATCH v6 2/6] spapr_numa.c: scrap 'legacy_numa' concept

2021-09-14 Thread Greg Kurz
On Fri, 10 Sep 2021 16:55:35 -0300 Daniel Henrique Barboza wrote: > When first introduced, 'legacy_numa' was a way to refer to guests that > either wouldn't be affected by associativity domain calculations, namely > the ones with only 1 NUMA node, and pre 5.2 guests that shouldn't be > affected b

Re: [PATCH v3 05/10] qcow2-refcount: fix_l2_entry_by_zero(): also zero L2 entry bitmap

2021-09-14 Thread Hanna Reitz
On 24.05.21 16:20, Vladimir Sementsov-Ogievskiy wrote: We'll reuse the function to fix wrong L2 entry bitmap. Support it now. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- block/qcow2-refcount.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions

Re: [PATCH v3 5/6] qapi: Add support for aliases

2021-09-14 Thread Markus Armbruster
Kevin Wolf writes: > Am 06.09.2021 um 17:24 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Introduce alias definitions for object types (structs and unions). This >> > allows using the same QAPI type and visitor for many syntax variations >> > that exist in the external repres

Re: [PATCH 1/2] vhost-user: fix VirtQ notifier cleanup

2021-09-14 Thread Xueming(Steven) Li
On Mon, 2021-09-13 at 00:20 +0800, Xueming Li wrote: > When vhost-user device cleanup and unmmap notifier address, VM cpu > thread that writing the notifier failed with accessing invalid address. > > To avoid this concurrent issue, wait memory flatview update by draining > rcu callbacks, then u

[PATCH v2] target/ppc: Fix 64-bit decrementer

2021-09-14 Thread Cédric Le Goater
The current way the mask is built can overflow with a 64-bit decrementer. Use sextract64() instead. Cc: Luis Fernando Fujita Pires Fixes: a8dafa525181 ("target/ppc: Implement large decrementer support for TCG") Signed-off-by: Cédric Le Goater --- v2: replaced MAKE_64BIT_MASK by sextract64 hw

Re: [PATCH v3 06/10] qcow2-refcount: check_refcounts_l2(): check l2_bitmap

2021-09-14 Thread Hanna Reitz
On 24.05.21 16:20, Vladimir Sementsov-Ogievskiy wrote: Check subcluster bitmap of the l2 entry for different types of clusters: - for compressed it must be zero - for allocated check consistency of two parts of the bitmap - for unallocated all subclusters should be unallocated (or zero

Re: [PATCH v3 6/6] tests/qapi-schema: Test cases for aliases

2021-09-14 Thread Markus Armbruster
Kevin Wolf writes: > Am 06.09.2021 um 17:28 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> > +/* Can still specify the real member name with alias support */ >> > +v = visitor_input_test_init(data, "{ 'foo': 42 }"); >> > +visit_type_AliasStruct1(v, NULL, &tmp, &error_abo

Re: [PATCH v3 07/10] qcow2-refcount: check_refcounts_l2(): check reserved bits

2021-09-14 Thread Hanna Reitz
On 24.05.21 16:20, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Tested-by: Kirill Tkhai --- block/qcow2.h | 1 + block/qcow2-refcount.c | 12 +++- 2 files changed, 12 insertions(+), 1 deletion(-) Reviewed-by: Ha

Re: [PATCH v3 08/10] qcow2-refcount: improve style of check_refcounts_l1()

2021-09-14 Thread Hanna Reitz
On 24.05.21 16:20, Vladimir Sementsov-Ogievskiy wrote: - use g_autofree for l1_table - better name for size in bytes variable - reduce code blocks nesting - whitespaces, braces, newlines Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-refcount.c | 98 +-

Re: [PATCH v3 09/10] qcow2-refcount: check_refcounts_l1(): check reserved bits

2021-09-14 Thread Hanna Reitz
On 24.05.21 16:20, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Tested-by: Kirill Tkhai --- block/qcow2.h | 1 + block/qcow2-refcount.c | 6 ++ 2 files changed, 7 insertions(+) Reviewed-by: Hanna Reitz

Re: [PATCH v3 10/10] qcow2-refcount: check_refblocks(): add separate message for reserved

2021-09-14 Thread Hanna Reitz
On 24.05.21 16:20, Vladimir Sementsov-Ogievskiy wrote: Split checking for reserved bits out of aligned offset check. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Tested-by: Kirill Tkhai --- block/qcow2.h | 1 + block/qcow2-refcount.c | 10 +- 2 fil

Re: [PATCH v11 03/16] target/riscv: clwz must ignore high bits (use shift-left & changed logic)

2021-09-14 Thread LIU Zhiwei
On 2021/9/11 下午10:00, Philipp Tomsich wrote: Assume clzw being executed on a register that is not sign-extended, such as for the following sequence that uses (1ULL << 63) | 392 as the operand to clzw: bseti a2, zero, 63 addia2, a2, 392 clzwa3, a2 The correct re

Re: [PATCH v2] target/ppc: Fix 64-bit decrementer

2021-09-14 Thread Peter Maydell
On Tue, 14 Sept 2021 at 09:56, Cédric Le Goater wrote: > > The current way the mask is built can overflow with a 64-bit decrementer. > Use sextract64() instead. > > Cc: Luis Fernando Fujita Pires > Fixes: a8dafa525181 ("target/ppc: Implement large decrementer support for > TCG") > Signed-off-by:

Re: [PATCH] qemu-img: Allow target be aligned to sector size

2021-09-14 Thread Hanna Reitz
On 19.08.21 12:12, Hanna Reitz wrote: We cannot write to images opened with O_DIRECT unless we allow them to be resized so they are aligned to the sector size: Since 9c60a5d1978, bdrv_node_refresh_perm() ensures that for nodes whose length is not aligned to the request alignment and where someone

Re: [PULL v4 00/23] target-arm queue

2021-09-14 Thread Peter Maydell
On Mon, 13 Sept 2021 at 21:05, Peter Maydell wrote: > > v3->v4: Windows headers define an INT type which clashed > with an enum value name in arm_gicv3_its.c... > > The following changes since commit eae587e8e3694b1aceab23239493fb4c7e1a80f5: > > Merge remote-tracking branch 'remotes/armbru/tags/

Re: [PATCH v3 4/6] qapi: Apply aliases in qobject-input-visitor

2021-09-14 Thread Kevin Wolf
Am 14.09.2021 um 08:58 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 06.09.2021 um 17:16 hat Markus Armbruster geschrieben: > >> Kevin Wolf writes: > >> > >> > When looking for an object in a struct in the external representation, > >> > check not only the currently visited s

Re: [PATCH v2] target/ppc: Fix 64-bit decrementer

2021-09-14 Thread Cédric Le Goater
On 9/14/21 11:19 AM, Peter Maydell wrote: > On Tue, 14 Sept 2021 at 09:56, Cédric Le Goater wrote: >> >> The current way the mask is built can overflow with a 64-bit decrementer. >> Use sextract64() instead. >> >> Cc: Luis Fernando Fujita Pires >> Fixes: a8dafa525181 ("target/ppc: Implement large

Re: [qemu-web PATCH] Update FUSE block export blog post

2021-09-14 Thread Hanna Reitz
On 07.09.21 19:52, Eric Blake wrote: On Mon, Sep 06, 2021 at 06:29:16PM +0200, Hanna Reitz wrote: Because I forgot to CC Thomas on the discussion adding this post, it was merged prematurely. This patch updates the post to incorporate the feedback I received on it: Overall, nice! I see it's a

Re: [PATCH v3 6/6] tests/qapi-schema: Test cases for aliases

2021-09-14 Thread Kevin Wolf
Am 14.09.2021 um 10:59 hat Markus Armbruster geschrieben: > >> > +/* You can't use more than one option at the same time */ > >> > +v = visitor_input_test_init(data, "{ 'foo': 42, 'nested': { 'foo': > >> > 42 } }"); > >> > +visit_type_AliasStruct3(v, NULL, &tmp, &err); > >> > +erro

Re: [PATCH v11 03/16] target/riscv: clwz must ignore high bits (use shift-left & changed logic)

2021-09-14 Thread Philipp Tomsich
On Tue 14. Sep 2021 at 11:15, LIU Zhiwei wrote: > > On 2021/9/11 下午10:00, Philipp Tomsich wrote: > > Assume clzw being executed on a register that is not sign-extended, such > > as for the following sequence that uses (1ULL << 63) | 392 as the operand > > to clzw: > > bseti a2, zero, 63 >

Re: [PATCH v2] target/ppc: Fix 64-bit decrementer

2021-09-14 Thread Peter Maydell
On Tue, 14 Sept 2021 at 10:47, Cédric Le Goater wrote: > > On 9/14/21 11:19 AM, Peter Maydell wrote: > > On Tue, 14 Sept 2021 at 09:56, Cédric Le Goater wrote: > >> > >> The current way the mask is built can overflow with a 64-bit decrementer. > >> Use sextract64() instead. > >> > >> Cc: Luis Fer

[PATCH v3 00/17] iotests: support zstd

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
These series makes tests pass with IMGOPTS='compression_type=zstd' Also, python iotests start to support IMGOPTS (they didn't before). v3: 02-04,06,08,14,17: add Hanna's r-b 07 iotests.py: filter out successful output of qemu-img create fix subject handle 149, 237 and 296 iotests

[PATCH v3 04/17] iotests.py: rewrite default luks support in qemu_img

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
Move the logic to more generic qemu_img_pipe_and_status(). Also behave better when we have several -o options. And reuse argument parser of course. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Hanna Reitz --- tests/qemu-iotests/iotests.py | 36 +-- 1

[PATCH v3 06/17] iotest 065: explicit compression type

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
The test checks different options. It of course fails if set IMGOPTS='compression_type=zstd'. So, let's be explicit in what compression type we want and independent of IMGOPTS. Test both existing compression types. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Hanna Reitz --- tests/q

[PATCH v3 02/17] iotests.py: qemu_img*("create"): support IMGOPTS='compression_type=zstd'

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
Adding support of IMGOPTS (like in bash tests) allows user to pass a lot of different options. Still, some may require additional logic. Now we want compression_type option, so add some smart logic around it: ignore compression_type=zstd in IMGOPTS, if test want qcow2 in compatibility mode. As wel

[PATCH v3 05/17] iotest 303: explicit compression type

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
The test prints qcow2 header fields which depends on chosen compression type. So, let's be explicit in what compression type we want and independent of IMGOPTS. Test both existing compression types. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- tests/qemu-iotests/303

[PATCH v3 01/17] iotests.py: img_info_log(): rename imgopts argument

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
We are going to support IMGOPTS environment variable like in bash tests. Corresponding global variable in iotests.py should be called imgopts. So to not interfere with function argument, rename it in advance. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- tests/qemu-iote

[PATCH v3 03/17] iotests: drop qemu_img_verbose() helper

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
qemu_img_verbose() has a drawback of not going through generic qemu_img_pipe_and_status(). qemu_img_verbose() is not very popular, so update the only two users to qemu_img_log() and drop qemu_img_verbose() at all. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Hanna Reitz --- tests/qe

[PATCH v3 07/17] iotests.py: filter out successful output of qemu-img create

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
The only "feature" of this "Formatting ..." line is that we have to update it every time we add new option. Let's drop it. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/149.out| 21 - tests/qemu-iotests/237.out| 3 --- tests/qemu-iotests/255.out

[PATCH v3 09/17] iotest 302: use img_info_log() helper

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
Instead of qemu_img_log("info", ..) use generic helper img_info_log(). img_info_log() has smarter logic. For example it use filter_img_info() to filter output, which in turns filter a compression type. So it will help us in future when we implement a possibility to use zstd compression by default

[PATCH v3 08/17] iotests.py: filter compression type out

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
We want iotests pass with both the default zlib compression and with IMGOPTS='compression_type=zstd'. Actually the only test that is interested in real compression type in test output is 287 (test for qcow2 compression type) and it's in bash. So for now we can safely filter out compression type in

[PATCH v3 17/17] iotests: declare lack of support for compresion_type in IMGOPTS

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
compression_type can't be used if we want to create image with compat=0.10. So, skip these tests, not many of them. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Hanna Reitz --- tests/qemu-iotests/031 | 5 +++-- tests/qemu-iotests/051 | 5 +++-- tests/qemu-iotests/061 | 6 +- tes

[PATCH v3 13/17] iotest 39: use _qcow2_dump_header

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
_qcow2_dump_header has filter for compression type, so this change makes test pass with IMGOPTS='compression_type=zstd'. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- tests/qemu-iotests/039 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-i

[PATCH v3 10/17] qcow2: simple case support for downgrading of qcow2 images with zstd

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
If image doesn't have any compressed cluster we can easily switch to zlib compression, which may allow to downgrade the image. That's mostly needed to support IMGOPTS='compression_type=zstd' in some iotests which do qcow2 downgrade. While being here also fix checkpatch complain against '#' in pri

[PATCH v3 11/17] iotests/common.rc: introduce _qcow2_dump_header helper

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
We'll use it in tests instead of explicit qcow2.py. Then we are going to add some filtering in _qcow2_dump_header. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- tests/qemu-iotests/common.rc | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tests/qemu-iotes

[PATCH v3 14/17] iotests: bash tests: filter compression type

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
We want iotests pass with both the default zlib compression and with IMGOPTS='compression_type=zstd'. Actually the only test that is interested in real compression type in test output is 287 (test for qcow2 compression type), so implement specific option for it. Signed-off-by: Vladimir Sementsov-

[PATCH v3 12/17] iotests: massive use _qcow2_dump_header

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
We are going to add filtering in _qcow2_dump_header and want all tests use it. The patch is generated by commands: cd tests/qemu-iotests sed -ie 's/$PYTHON qcow2.py "$TEST_IMG" dump-header\($\| \)/_qcow2_dump_header\1/' ??? tests/* (the difficulty is to avoid converting dump-header-exts) Si

Re: [PATCH] vhost-vsock: fix migration issue when seqpacket is supported

2021-09-14 Thread Stefano Garzarella
On Mon, Sep 13, 2021 at 09:46:48AM -0400, Michael S. Tsirkin wrote: On Mon, Sep 13, 2021 at 02:51:42PM +0200, Stefano Garzarella wrote: On Fri, Sep 10, 2021 at 02:35:53AM -0400, Michael S. Tsirkin wrote: > On Thu, Sep 09, 2021 at 10:02:12AM +0100, Daniel P. Berrangé wrote: > > On Thu, Sep 09, 20

[PATCH v3 16/17] iotest 214: explicit compression type

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
The test-case "Corrupted size field in compressed cluster descriptor" heavily depends on zlib compression type. So, make it explicit. This way test passes with IMGOPTS='compression_type=zstd'. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- tests/qemu-iotests/214 | 2 +-

[PATCH v3 15/17] iotests 60: more accurate set dirty bit in qcow2 header

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
Don't touch other incompatible bits, like compression-type. This makes the test pass with IMGOPTS='compression_type=zstd'. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- tests/qemu-iotests/060 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu

Re: [PULL 00/14] aspeed queue

2021-09-14 Thread Peter Maydell
On Mon, 13 Sept 2021 at 17:13, Cédric Le Goater wrote: > > The following changes since commit eae587e8e3694b1aceab23239493fb4c7e1a80f5: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2021-09-13' > into staging (2021-09-13 11:00:30 +0100) > > are available in the Git repository

Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type

2021-09-14 Thread Cédric Le Goater
Hello Peter D, > +static void aspeed_machine_fuji_class_init(ObjectClass *oc, void *data) > +{ > +MachineClass *mc = MACHINE_CLASS(oc); > +AspeedMachineClass *amc = ASPEED_MACHINE_CLASS(oc); > + > +mc->desc = "Facebook Fuji BMC (Cortex-A7)"; > +amc->soc_name = "ast2600-a3"; > +

Re: [PULL 00/14] aspeed queue

2021-09-14 Thread Cédric Le Goater
On 9/14/21 12:51 PM, Peter Maydell wrote: > On Mon, 13 Sept 2021 at 17:13, Cédric Le Goater wrote: >> >> The following changes since commit eae587e8e3694b1aceab23239493fb4c7e1a80f5: >> >> Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2021-09-13' >> into staging (2021-09-13 11:00:3

Re: [PATCH v3 5/6] qapi: Add support for aliases

2021-09-14 Thread Markus Armbruster
Markus Armbruster writes: > Kevin Wolf writes: > >> Am 06.09.2021 um 17:24 hat Markus Armbruster geschrieben: >>> Kevin Wolf writes: >>> >>> > Introduce alias definitions for object types (structs and unions). This >>> > allows using the same QAPI type and visitor for many syntax variations >>

Re: [PATCH] hw/virtio: Update vring after modifying its queue size

2021-09-14 Thread Alexander Bulekov
On 210826 0042, Philippe Mathieu-Daudé wrote: > When a ring queue size is modified, we need to call > virtio_queue_update_rings() to re-init the memory region > caches. Otherwise the region might have outdated memory > size, and later load/store access might trigger an > assertion, such: > > qem

Re: [PATCH v3 06/10] qcow2-refcount: check_refcounts_l2(): check l2_bitmap

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
14.09.2021 11:54, Hanna Reitz wrote: On 24.05.21 16:20, Vladimir Sementsov-Ogievskiy wrote: Check subcluster bitmap of the l2 entry for different types of clusters:   - for compressed it must be zero   - for allocated check consistency of two parts of the bitmap   - for unallocated all subclust

Re: [RFC v3 12/32] rust: provide a common crate for QEMU

2021-09-14 Thread Marc-André Lureau
Hi Paolo On Mon, Sep 13, 2021 at 9:18 PM Paolo Bonzini wrote: > On 07/09/21 14:19, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > This crates provides common bindings and facilities for QEMU C API > > shared by various projects. > > > > Most importantly, it defines the co

Re: [PULL 00/14] aspeed queue

2021-09-14 Thread Philippe Mathieu-Daudé
On 9/14/21 12:58 PM, Cédric Le Goater wrote: > On 9/14/21 12:51 PM, Peter Maydell wrote: >> On Mon, 13 Sept 2021 at 17:13, Cédric Le Goater wrote: >>> >>> The following changes since commit eae587e8e3694b1aceab23239493fb4c7e1a80f5: >>> >>> Merge remote-tracking branch 'remotes/armbru/tags/pull-q

Re: [PATCH v3 06/10] qcow2-refcount: check_refcounts_l2(): check l2_bitmap

2021-09-14 Thread Hanna Reitz
On 14.09.21 13:22, Vladimir Sementsov-Ogievskiy wrote: 14.09.2021 11:54, Hanna Reitz wrote: On 24.05.21 16:20, Vladimir Sementsov-Ogievskiy wrote: Check subcluster bitmap of the l2 entry for different types of clusters:   - for compressed it must be zero   - for allocated check consistency of

Re: [PATCH] vhost-vsock: fix migration issue when seqpacket is supported

2021-09-14 Thread Michael S. Tsirkin
On Tue, Sep 14, 2021 at 12:42:09PM +0200, Stefano Garzarella wrote: > On Mon, Sep 13, 2021 at 09:46:48AM -0400, Michael S. Tsirkin wrote: > > On Mon, Sep 13, 2021 at 02:51:42PM +0200, Stefano Garzarella wrote: > > > On Fri, Sep 10, 2021 at 02:35:53AM -0400, Michael S. Tsirkin wrote: > > > > On Thu,

[PULL 2/5] multifd: Unconditionally unregister yank function

2021-09-14 Thread Juan Quintela
From: Lukas Straub To: qemu-devel Cc: "Dr. David Alan Gilbert" , Juan Quintela , Peter Xu , Leonardo Bras Soares Passos Date: Wed, 4 Aug 2021 21:26:32 +0200 (5 weeks, 11 hours, 52 minutes ago) [[PGP Signed Part:No public key for 35AB0B289C5DB258 created at 2021-08-04T21:26:32+0200 using RSA

[PULL 3/5] migration/rdma: Try to register On-Demand Paging memory region

2021-09-14 Thread Juan Quintela
From: Li Zhijian Previously, for the fsdax mem-backend-file, it will register failed with Operation not supported. In this case, we can try to register it with On-Demand Paging[1] like what rpma_mr_reg() does on rpma[2]. [1]: https://community.mellanox.com/s/article/understanding-on-demand-pagi

[PULL 4/5] migration/rdma: advise prefetch write for ODP region

2021-09-14 Thread Juan Quintela
From: Li Zhijian To: , CC: , Li Zhijian , "Marcel Apfelbaum" Date: Mon, 23 Aug 2021 11:33:58 +0800 (2 weeks, 3 days, 3 hours ago) The responder mr registering with ODP will sent RNR NAK back to the requester in the face of the page fault. - ibv_poll_cq wc.status=13 RNR retry counter e

[PULL 1/5] multifd: Implement yank for multifd send side

2021-09-14 Thread Juan Quintela
From: Lukas Straub To: qemu-devel Cc: "Dr. David Alan Gilbert" , Juan Quintela , Peter Xu , Leonardo Bras Soares Passos Date: Wed, 1 Sep 2021 17:58:57 +0200 (1 week, 15 hours, 17 minutes ago) [[PGP Signed Part:No public key for 35AB0B289C5DB258 created at 2021-09-01T17:58:57+0200 using RSA]

[PULL 0/5] Migration.next patches

2021-09-14 Thread Juan Quintela
The following changes since commit c6f5e042d89e79206cd1ce5525d3df219f13c3cc: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20210913-3' into staging (2021-09-13 21:06:15 +0100) are available in the Git repository at: https://github.com/juanquintela/qemu.git tags/migrat

[PULL 5/5] migration/ram: Don't passs RAMState to migration_clear_memory_region_dirty_bitmap_*()

2021-09-14 Thread Juan Quintela
From: David Hildenbrand The parameter is unused, let's drop it. Reviewed-by: Peter Xu Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Juan Quintela Signed-off-by: David Hildenbrand Signed-off-by: Juan Quintela --- migration/ram.c | 13 + 1 file changed, 5 insertions(+), 8 dele

Re: [PATCH v6 3/6] spapr: introduce spapr_numa_associativity_reset()

2021-09-14 Thread Greg Kurz
On Fri, 10 Sep 2021 16:55:36 -0300 Daniel Henrique Barboza wrote: > Introducing a new NUMA affinity, FORM2, requires a new mechanism to > switch between affinity modes after CAS. Also, we want FORM2 data > structures and functions to be completely separated from the existing > FORM1 code, allowin

Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type

2021-09-14 Thread Peter Delevoryas
> On Sep 14, 2021, at 3:56 AM, Cédric Le Goater wrote: > >  > Hello Peter D, > >> +static void aspeed_machine_fuji_class_init(ObjectClass *oc, void *data) >> +{ >> +MachineClass *mc = MACHINE_CLASS(oc); >> +AspeedMachineClass *amc = ASPEED_MACHINE_CLASS(oc); >> + >> +mc->desc = "Fa

Re: [PATCH v3 06/10] qcow2-refcount: check_refcounts_l2(): check l2_bitmap

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
14.09.2021 14:46, Hanna Reitz wrote: On 14.09.21 13:22, Vladimir Sementsov-Ogievskiy wrote: 14.09.2021 11:54, Hanna Reitz wrote: On 24.05.21 16:20, Vladimir Sementsov-Ogievskiy wrote: Check subcluster bitmap of the l2 entry for different types of clusters:   - for compressed it must be zero  

Re: [PATCH v3 06/10] qcow2-refcount: check_refcounts_l2(): check l2_bitmap

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
14.09.2021 15:00, Vladimir Sementsov-Ogievskiy wrote: 14.09.2021 14:46, Hanna Reitz wrote: On 14.09.21 13:22, Vladimir Sementsov-Ogievskiy wrote: 14.09.2021 11:54, Hanna Reitz wrote: On 24.05.21 16:20, Vladimir Sementsov-Ogievskiy wrote: Check subcluster bitmap of the l2 entry for different t

[RFC PATCH v2] accel/tcg: re-factor plugin_inject_cb so we can assert insn_idx is valid

2021-09-14 Thread Alex Bennée
Coverity doesn't know enough about how we have arranged our plugin TCG ops to know we will always have incremented insn_idx before injecting the callback. Let us assert it for the benefit of Coverity and protect ourselves from accidentally breaking the assumption and triggering harder to grok error

[PATCH 0/3] target/arm: Set FPSCR.LTPSIZE for user-mode

2021-09-14 Thread Peter Maydell
This patchset fixes https://gitlab.com/qemu-project/qemu/-/issues/613 which is a bug where we weren't setting FPSCR.LTPSIZE correctly out of reset for the user-mode emulator. The effect is that when using an M-profile CPU with the low-overhead-branch or MVE extensions (ie the Cortex-M55) with the l

[PATCH 3/3] target/arm: Consolidate ifdef blocks in reset

2021-09-14 Thread Peter Maydell
Move an ifndef CONFIG_USER_ONLY code block up in arm_cpu_reset() so it can be merged with another earlier one. Signed-off-by: Peter Maydell --- target/arm/cpu.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index

[PATCH 1/3] target/arm: Don't skip M-profile reset entirely in user mode

2021-09-14 Thread Peter Maydell
Currently all of the M-profile specific code in arm_cpu_reset() is inside a !defined(CONFIG_USER_ONLY) ifdef block. This is unintentional: it happened because originally the only M-profile-specific handling was the setup of the initial SP and PC from the vector table, which is system-emulation onl

Re: [PATCH v6 4/6] spapr_numa.c: parametrize FORM1 macros

2021-09-14 Thread Greg Kurz
On Fri, 10 Sep 2021 16:55:37 -0300 Daniel Henrique Barboza wrote: > The next preliminary step to introduce NUMA FORM2 affinity is to make > the existing code independent of FORM1 macros and values, i.e. > MAX_DISTANCE_REF_POINTS, NUMA_ASSOC_SIZE and VCPU_ASSOC_SIZE. This patch > accomplishes that

[PATCH 2/3] target/arm: Always clear exclusive monitor on reset

2021-09-14 Thread Peter Maydell
There's no particular reason why the exclusive monitor should be only cleared on reset in system emulation mode. It doesn't hurt if it isn't cleared in user mode, but we might as well reduce the amount of code we have that's inside an ifdef. Signed-off-by: Peter Maydell --- target/arm/cpu.c | 6

[PATCH 2/2] qga-win: Detect Windows 11 by build number

2021-09-14 Thread Kostiantyn Kostiuk
Windows 10 and 11 have the same major and minor versions. So, the only way to determine the correct version is to use the build number. After this commit, the guest agent will return the proper "version" and "version-id" for Windows 11. The "pretty-name" is read from the registry and will be incor

Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type

2021-09-14 Thread Joel Stanley
On Tue, 14 Sept 2021 at 11:59, Peter Delevoryas wrote: > > > > On Sep 14, 2021, at 3:56 AM, Cédric Le Goater wrote: > > > >  > > Hello Peter D, > > > >> +static void aspeed_machine_fuji_class_init(ObjectClass *oc, void *data) > >> +{ > >> +MachineClass *mc = MACHINE_CLASS(oc); > >> +Aspe

[PATCH 1/2] qga-win: Detect OS based on Windows 10 by first build number

2021-09-14 Thread Kostiantyn Kostiuk
Windows Server 2016, 2019, 2022 are based on Windows 10 and have the same major and minor versions. So, the only way to detect the proper version is to use the build number. Before this commit, the guest agent use the last build number for each OS, but it causes problems when new OS releases. Ther

[PATCH v4 05/10] qcow2-refcount: fix_l2_entry_by_zero(): also zero L2 entry bitmap

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
We'll reuse the function to fix wrong L2 entry bitmap. Support it now. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Reviewed-by: Hanna Reitz --- block/qcow2-refcount.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/block/qcow2-ref

[PATCH v4 04/10] qcow2-refcount: introduce fix_l2_entry_by_zero()

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
Split fix_l2_entry_by_zero() out of check_refcounts_l2() to be reused in further patch. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Reviewed-by: Hanna Reitz --- block/qcow2-refcount.c | 87 +- 1 file changed, 60 insertions(+), 27

[PATCH v4 00/10] qcow2 check: check some reserved bits and subcluster bitmaps

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
Hi all! Here are some good refactorings and new (qemu-img check) checks for qcow2. 06 qcow2-refcount: check_refcounts_l2(): check l2_bitmap don't fix unallocated cluster with allocated subclusters (no strong opinion how to do it correctly) drop Eric's r-b keep Kirill's t-b (I

[PATCH v4 02/10] qcow2: compressed read: simplify cluster descriptor passing

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
Let's pass the whole L2 entry and not bother with L2E_COMPRESSED_OFFSET_SIZE_MASK. It also helps further refactoring that adds generic qcow2_parse_compressed_l2_entry() helper. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Reviewed-by: Alberto Garcia Reviewed-by: Hanna Re

[PATCH v4 06/10] qcow2-refcount: check_refcounts_l2(): check l2_bitmap

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
Check subcluster bitmap of the l2 entry for different types of clusters: - for compressed it must be zero - for allocated check consistency of two parts of the bitmap - for unallocated all subclusters should be unallocated (or zero-plain) Signed-off-by: Vladimir Sementsov-Ogievskiy Tested-

[PATCH v4 01/10] qcow2-refcount: improve style of check_refcounts_l2()

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
- don't use same name for size in bytes and in entries - use g_autofree for l2_table - add whitespace - fix block comment style Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Reviewed-by: Hanna Reitz --- block/qcow2-refcount.c | 47 +

[PATCH v4 03/10] qcow2: introduce qcow2_parse_compressed_l2_entry() helper

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
Add helper to parse compressed l2_entry and use it everywhere instead of open-coding. Note, that in most places we move to precise coffset/csize instead of sector-aligned. Still it should work good enough for updating refcounts. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake

[PATCH v4 07/10] qcow2-refcount: check_refcounts_l2(): check reserved bits

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Tested-by: Kirill Tkhai Reviewed-by: Hanna Reitz --- block/qcow2.h | 1 + block/qcow2-refcount.c | 12 +++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/block/qcow2.h b/block/qcow2.h index c

[PATCH v4 09/10] qcow2-refcount: check_refcounts_l1(): check reserved bits

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Tested-by: Kirill Tkhai Reviewed-by: Hanna Reitz --- block/qcow2.h | 1 + block/qcow2-refcount.c | 6 ++ 2 files changed, 7 insertions(+) diff --git a/block/qcow2.h b/block/qcow2.h index b8b1093b61..58fd7f1678 10

[PATCH] tools/virtiofsd: Add fstatfs64 syscall to the seccomp allowlist

2021-09-14 Thread Thomas Huth
The virtiofsd currently crashes on s390x when doing something like this in the guest: mkdir -p /mnt/myfs mount -t virtiofs myfs /mnt/myfs touch /mnt/myfs/foo.txt stat -f /mnt/myfs/foo.txt The problem is that the fstatfs64 syscall is called in this case from the virtiofsd. We have to put it on

[PATCH v4 08/10] qcow2-refcount: improve style of check_refcounts_l1()

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
- use g_autofree for l1_table - better name for size in bytes variable - reduce code blocks nesting - whitespaces, braces, newlines Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Hanna Reitz --- block/qcow2-refcount.c | 98 +- 1 file changed

Re: [PATCH v6 5/6] spapr: move FORM1 verifications to post CAS

2021-09-14 Thread Greg Kurz
On Fri, 10 Sep 2021 16:55:38 -0300 Daniel Henrique Barboza wrote: > FORM2 NUMA affinity is prepared to deal with empty (memory/cpu less) > NUMA nodes. This is used by the DAX KMEM driver to locate a PAPR SCM > device that has a different latency than the original NUMA node from the > regular memo

[PATCH v4 10/10] qcow2-refcount: check_refblocks(): add separate message for reserved

2021-09-14 Thread Vladimir Sementsov-Ogievskiy
Split checking for reserved bits out of aligned offset check. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Tested-by: Kirill Tkhai Reviewed-by: Hanna Reitz --- block/qcow2.h | 1 + block/qcow2-refcount.c | 10 +- 2 files changed, 10 insertions(+), 1 de

Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type

2021-09-14 Thread Peter Maydell
On Tue, 14 Sept 2021 at 13:14, Joel Stanley wrote: > The upstream device tree uses 2G: > > https://elixir.bootlin.com/linux/v5.15-rc1/source/arch/arm/boot/dts/ast2600-facebook-netbmc-common.dtsi#L20 > > It's unfortunate we limit the defaults given very few (no one?) is > using this model on a mach

Re: [PULL 00/44] tcg patch queue, v2

2021-09-14 Thread Peter Maydell
On Tue, 14 Sept 2021 at 01:14, Richard Henderson wrote: > > Version 2 drops the bswap patch that caused such problems > on the various BSDs; I'll have to look at that further. > In the meantime I've also been collecting more pending > patches, and I might as well include them now. > > > r~ > > > T

[PATCH v3] docs: add supported host CPU architectures section

2021-09-14 Thread marcandre . lureau
From: Marc-André Lureau I was looking for such documentation, but couldn't find it. Add it to the build-platform.rst document. Signed-off-by: Marc-André Lureau --- docs/about/build-platforms.rst | 33 + docs/about/deprecated.rst | 2 ++ meson.build

Re: [PATCH v3] docs: add supported host CPU architectures section

2021-09-14 Thread Peter Maydell
On Tue, 14 Sept 2021 at 13:25, wrote: > > From: Marc-André Lureau > > I was looking for such documentation, but couldn't find it. Add it to > the build-platform.rst document. > > Signed-off-by: Marc-André Lureau > --- > docs/about/build-platforms.rst | 33 + > do

Re: [qemu-web RFC PATCH] Add Sponsors page

2021-09-14 Thread Stefan Hajnoczi
On Tue, Sep 14, 2021 at 10:26:45AM +0200, Philippe Mathieu-Daudé wrote: > On 9/14/21 10:20 AM, Daniel P. Berrangé wrote: > > On Tue, Sep 14, 2021 at 07:41:47AM +0200, Thomas Huth wrote: > >> On 13/09/2021 20.25, Philippe Mathieu-Daudé wrote: > >>> Add a page listing QEMU sponsors and displaying the

Re: [RFC v6] virtio/vsock: add two more queues for datagram types

2021-09-14 Thread Stefan Hajnoczi
On Mon, Sep 13, 2021 at 10:18:43PM +, Jiang Wang wrote: > Datagram sockets are connectionless and unreliable. > The sender does not know the capacity of the receiver > and may send more packets than the receiver can handle. > > Add two more dedicate virtqueues for datagram sockets, > so that i

Re: [PATCH] tools/virtiofsd: Add fstatfs64 syscall to the seccomp allowlist

2021-09-14 Thread Vivek Goyal
On Tue, Sep 14, 2021 at 02:32:14PM +0200, Thomas Huth wrote: > The virtiofsd currently crashes on s390x when doing something like > this in the guest: > > mkdir -p /mnt/myfs > mount -t virtiofs myfs /mnt/myfs > touch /mnt/myfs/foo.txt > stat -f /mnt/myfs/foo.txt > > The problem is that the fs

  1   2   3   4   >