Re: [PATCH v4 3/7] python/aqmp-tui: Add AQMP TUI draft

2021-08-22 Thread John Snow
On Thu, Aug 19, 2021 at 1:39 PM G S Niteesh Babu wrote: > Added a draft of AQMP TUI. > > Implements the follwing basic features: > 1) Command transmission/reception. > 2) Shows events asynchronously. > 3) Shows server status in the bottom status bar. > > Also added type annotations and necessary

Re: [PATCH v3 59/66] accel/tcg: Handle SIGBUS in handle_cpu_signal

2021-08-22 Thread Richard Henderson
On 8/20/21 2:34 AM, Peter Maydell wrote: On Wed, 18 Aug 2021 at 21:13, Richard Henderson wrote: We've been registering host SIGBUS, but then treating it exactly like SIGSEGV. Handle BUS_ADRALN via cpu_unaligned_access, but allow other SIGBUS si_codes to continue into the host-to-guest signal

Re: [PATCH v3 63/66] tcg/tci: Support raising sigbus for user-only

2021-08-22 Thread Richard Henderson
On 8/20/21 3:14 AM, Peter Maydell wrote: @@ -296,7 +296,7 @@ static uint64_t tci_qemu_ld(CPUArchState *env, target_ulong taddr, uintptr_t ra = (uintptr_t)tb_ptr; #ifdef CONFIG_SOFTMMU -switch (mop) { +switch (mop & (MO_BSWAP | MO_SSIZE)) { case MO_UB: return help

Re: [PATCH 2/2] migration/rdma: advise prefetch write for ODP region

2021-08-22 Thread Marcel Apfelbaum
Hi, On Sat, Jul 31, 2021 at 5:03 PM Li Zhijian wrote: > > The responder mr registering with ODP will sent RNR NAK back to > the requester in the face of the page fault. > - > ibv_poll_cq wc.status=13 RNR retry counter exceeded! > ibv_poll_cq wrid=WRITE RDMA! > - > ibv_advise_mr(3)

Re: [PATCH 1/2] migration/rdma: Try to register On-Demand Paging memory region

2021-08-22 Thread Marcel Apfelbaum
Hi On Sat, Jul 31, 2021 at 5:00 PM Li Zhijian wrote: > > Previously, for the fsdax mem-backend-file, it will register failed with > Operation not supported. In this case, we can try to register it with > On-Demand Paging[1] like what rpma_mr_reg() does on rpma[2]. > > [1]: > https://community.me

Re: [PATCH 2/5] qemu/qarray.h: weak scalar type check in QARRAY_CREATE()

2021-08-22 Thread Christian Schoenebeck
On Sonntag, 22. August 2021 06:11:58 CEST Richard Henderson wrote: > On 8/21/21 1:30 PM, Christian Schoenebeck wrote: > > Unfortunately something like > > > >_Static_assert(typeof(a) == typeof(b), "type mismatch"); > > > > is currently not suported by C. So for the time being at least > > che

Re: [PATCH v3 63/66] tcg/tci: Support raising sigbus for user-only

2021-08-22 Thread Peter Maydell
On Sun, 22 Aug 2021 at 08:59, Richard Henderson wrote: > > On 8/20/21 3:14 AM, Peter Maydell wrote: > >> @@ -377,11 +381,11 @@ static uint64_t tci_qemu_ld(CPUArchState *env, > >> target_ulong taddr, > >> static void tci_qemu_st(CPUArchState *env, target_ulong taddr, uint64_t > >> val, > >>

Re: [PATCH 1/5] qemu/qarray.h: introduce QArray

2021-08-22 Thread Christian Schoenebeck
On Samstag, 21. August 2021 22:18:18 CEST Christian Schoenebeck wrote: > Implements deep auto free of arrays while retaining common C-style > squared bracket access. > > Signed-off-by: Christian Schoenebeck > --- As I'm going to send a v2 anyway, I'll also just do some minor API comment changes

Re: [qemu-web PATCH] Add a blog post about FUSE block exports

2021-08-22 Thread Thomas Huth
On 20/08/2021 09.56, Hanna Reitz wrote: On 19.08.21 18:23, Stefan Hajnoczi wrote: On Thu, Aug 19, 2021 at 12:25:01PM +0200, Hanna Reitz wrote: This post explains when FUSE block exports are useful, how they work, and that it is fun to export an image file on its own path so it looks like your i

[PATCH v2 0/5] introduce QArray

2021-08-22 Thread Christian Schoenebeck
Patches 1 and 2 introduce include/qemu/qarray.h which implements a deep auto free mechanism for arrays. Unlike GArray it does not require special macros, function calls or member dereferencing to access the individual array elements. So existing C-style array code can be retained with only very lit

[PATCH v2 1/5] qemu/qarray.h: introduce QArray

2021-08-22 Thread Christian Schoenebeck
Implements deep auto free of arrays while retaining common C-style squared bracket access. Signed-off-by: Christian Schoenebeck --- include/qemu/qarray.h | 150 ++ 1 file changed, 150 insertions(+) create mode 100644 include/qemu/qarray.h diff --git a/in

[PATCH v2 3/5] 9pfs: make V9fsString usable via QArray API

2021-08-22 Thread Christian Schoenebeck
Signed-off-by: Christian Schoenebeck --- fsdev/9p-marshal.c | 2 ++ fsdev/9p-marshal.h | 3 +++ 2 files changed, 5 insertions(+) diff --git a/fsdev/9p-marshal.c b/fsdev/9p-marshal.c index a01bba6908..fbfc2a62cd 100644 --- a/fsdev/9p-marshal.c +++ b/fsdev/9p-marshal.c @@ -18,6 +18,8 @@ #includ

[PATCH v2 5/5] 9pfs: use QArray in v9fs_walk()

2021-08-22 Thread Christian Schoenebeck
Signed-off-by: Christian Schoenebeck --- hw/9pfs/9p.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c index b59572fa79..91062ee4d6 100644 --- a/hw/9pfs/9p.c +++ b/hw/9pfs/9p.c @@ -1707,13 +1707,14 @@ static void coroutine_fn v9fs_

[PATCH v2 2/5] qemu/qarray.h: check scalar type in QARRAY_CREATE()

2021-08-22 Thread Christian Schoenebeck
Make sure at compile time that the scalar type of the array requested to be created via QARRAY_CREATE() matches the scalar type of the passed auto reference variable (unique pointer). Suggested-by: Richard Henderson Signed-off-by: Christian Schoenebeck --- include/qemu/qarray.h | 6 ++ 1 fi

[PATCH v2 4/5] 9pfs: make V9fsPath usable via QArray API

2021-08-22 Thread Christian Schoenebeck
Signed-off-by: Christian Schoenebeck --- fsdev/file-op-9p.h | 2 ++ hw/9pfs/9p.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/fsdev/file-op-9p.h b/fsdev/file-op-9p.h index 42f677cf38..7630f0e538 100644 --- a/fsdev/file-op-9p.h +++ b/fsdev/file-op-9p.h @@ -18,6 +18,7 @@ #include

[PATCH] virtio-vga, stubs: Fix qemu failing on virio-vga with blobs on when qemu compiled with modules enabled

2021-08-22 Thread Max
>From f972dab518c6581a83f397c35b3d09b2ef6de674 Mon Sep 17 00:00:00 2001 From: max Date: Sun, 22 Aug 2021 14:02:48 +0300 Subject: [PATCH] virtio-vga, stubs: Fix qemu failing on virio-vga with blobs on when qemu compiled with modules enabled Resolves: https://gitlab.com/qemu-project/qemu/-/issues/

Testing a microcontroller emulation by loading the binary on incomplete Flash emulation

2021-08-22 Thread Gautam Bhat
Hi, I am to implement a very simple microcontroller for my understanding of Qemu development. This microcontroller runs its code from programmable flash which is bit-, byte- and word addressable. To do some initial tests of my nascent microcontroller implementation I would like to load a very simp

[PATCH 2/3] hw/arm/virt: Honor highmem setting when computing highest_gpa

2021-08-22 Thread Marc Zyngier
Even when the VM is configured with highmem=off, the highest_gpa field includes devices that are above the 4GiB limit, which is what highmem=off is supposed to enforce. This leads to failures in virt_kvm_type() on systems that have a crippled IPA range, as the reported IPA space is larger than what

[PATCH 1/3] hw/arm/virt: KVM: Probe for KVM_CAP_ARM_VM_IPA_SIZE when creating scratch VM

2021-08-22 Thread Marc Zyngier
Although we probe for the IPA limits imposed by KVM (and the hardware) when computing the memory map, we still use the old style '0' when creating a scratch VM in kvm_arm_create_scratch_host_vcpu(). On systems that are severely IPA challenged (such as the Apple M1), this results in a failure as KV

[PATCH 3/3] docs/system/arm/virt: Fix documentation for the 'highmem' option

2021-08-22 Thread Marc Zyngier
The documentation for the 'highmem' option indicates that it controls the placement of both devices and RAM. The actual behaviour of QEMU seems to be that RAM is allowed to go beyond the 4GiB limit, and that only devices are constraint by this option. Align the documentation with the actual behavi

[PATCH 0/3] target/arm: Reduced-IPA space and highmem=off fixes

2021-08-22 Thread Marc Zyngier
With the availability of a fruity range of arm64 systems, it becomes obvious that QEMU doesn't deal very well with limited IPA ranges when used as a front-end for KVM. This short series aims at making usable on such systems: - the first patch makes the creation of a scratch VM IPA-limit aware - th

Re: [PATCH 0/3] target/arm: Reduced-IPA space and highmem=off fixes

2021-08-22 Thread Marc Zyngier
On 2021-08-22 15:44, Marc Zyngier wrote: With the availability of a fruity range of arm64 systems, it becomes obvious that QEMU doesn't deal very well with limited IPA ranges when used as a front-end for KVM. This short series aims at making usable on such systems: - the first patch makes the cr

vmgenid no maintainers

2021-08-22 Thread Ani Sinha
Hi : All of you have contributed to vmgenid device at some point. Unfortunately, this code currently has no maintainers. I had looked into this feature as a part of another project for a previous company, hence noticed it. Will any of you would want to be the maintainer of this codebase in Qemu? I

Re: [For 6.1 PATCH] hw/arm: xilinx_zynq: Disconnect the UART clocks temporarily

2021-08-22 Thread Bin Meng
On Sun, Aug 22, 2021 at 2:14 AM Peter Maydell wrote: > > On Sat, 21 Aug 2021 at 16:45, Bin Meng wrote: > > > > As of today, when booting upstream U-Boot for Xilinx Zynq, the UART > > does not receive anything. Initial debugging shows that the UART clock > > frequency is 0 somehow which prevents t

Re: Testing a microcontroller emulation by loading the binary on incomplete Flash emulation

2021-08-22 Thread Peter Maydell
On Sun, 22 Aug 2021 at 15:37, Gautam Bhat wrote: > > Hi, > > I am to implement a very simple microcontroller for my understanding > of Qemu development. This microcontroller runs its code from > programmable flash which is bit-, byte- and word addressable. To do > some initial tests of my nascent

Re: [PATCH v3 63/66] tcg/tci: Support raising sigbus for user-only

2021-08-22 Thread Richard Henderson
On 8/22/21 5:32 AM, Peter Maydell wrote: On Sun, 22 Aug 2021 at 08:59, Richard Henderson wrote: On 8/20/21 3:14 AM, Peter Maydell wrote: @@ -377,11 +381,11 @@ static uint64_t tci_qemu_ld(CPUArchState *env, target_ulong taddr, static void tci_qemu_st(CPUArchState *env, target_ulong taddr,

Re: [PATCH V2] block/rbd: implement bdrv_co_block_status

2021-08-22 Thread Ilya Dryomov
On Tue, Aug 10, 2021 at 3:41 PM Peter Lieven wrote: > > the qemu rbd driver currently lacks support for bdrv_co_block_status. > This results mainly in incorrect progress during block operations (e.g. > qemu-img convert with an rbd image as source). > > This patch utilizes the rbd_diff_iterate2 cal

Re: [PATCH 2/2] migration/rdma: advise prefetch write for ODP region

2021-08-22 Thread lizhij...@fujitsu.com
Hi Marcel On 22/08/2021 16:39, Marcel Apfelbaum wrote: > Hi, > > On Sat, Jul 31, 2021 at 5:03 PM Li Zhijian wrote: >> The responder mr registering with ODP will sent RNR NAK back to >> the requester in the face of the page fault. >> - >> ibv_poll_cq wc.status=13 RNR retry counter exceede

[PATCH v3] hw/i386/acpi-build: Get NUMA information from struct NumaState

2021-08-22 Thread Jingqi Liu
Since commits aa57020774b ("numa: move numa global variable nb_numa_nodes into MachineState") and 7e721e7b10e ("numa: move numa global variable numa_info into MachineState"), we can get NUMA information completely from MachineState::numa_state. Remove PCMachineState::numa_nodes and PCMachineState:

Re: [PATCH 2/2] docs/about: Unify the subject format

2021-08-22 Thread wangyanan (Y)
On 2021/8/20 18:18, Cornelia Huck wrote: On Fri, Aug 20 2021, Yanan Wang wrote: Unify the subject format in deprecated.rst to "since X.Y". Unify the subject format in removed-features.rst to "removed in X.Y". It seems unlikely that we will ever deprecate something in a stable release, and e

Re: [PATCH 1/2] migration/rdma: Try to register On-Demand Paging memory region

2021-08-22 Thread lizhij...@fujitsu.com
On 22/08/2021 16:53, Marcel Apfelbaum wrote: > Hi > > On Sat, Jul 31, 2021 at 5:00 PM Li Zhijian wrote: >> Previously, for the fsdax mem-backend-file, it will register failed with >> Operation not supported. In this case, we can try to register it with >> On-Demand Paging[1] like what rpma_mr_re

[PATCH 0/3] hw/arm: xilinx_zynq: Fix upstream U-Boot boot failure

2021-08-22 Thread Bin Meng
As of today, when booting upstream U-Boot for Xilinx Zynq, the UART does not receive anything. Debugging shows that the UART input clock frequency is zero which prevents the UART from receiving anything as. per the logic in uart_receive(). Note the U-Boot can still output data to the UART tx fifo,

[PATCH 1/3] hw/misc: zynq_slcr: Correctly compute output clocks in the reset exit phase

2021-08-22 Thread Bin Meng
As of today, when booting upstream U-Boot for Xilinx Zynq, the UART does not receive anything. Debugging shows that the UART input clock frequency is zero which prevents the UART from receiving anything as per the logic in uart_receive(). >From zynq_slcr_reset_exit() comment, it intends to compute

[PATCH 3/3] hw/char: cadence_uart: Move clock/reset check to uart_can_receive()

2021-08-22 Thread Bin Meng
Currently the clock/reset check is done in uart_receive(), but we can move the check to uart_can_receive() which is earlier. Signed-off-by: Bin Meng --- hw/char/cadence_uart.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/hw/char/cadence_uart.c b/hw/char/caden

[PATCH 2/3] hw/char: cadence_uart: Disable transmit when input clock is disabled

2021-08-22 Thread Bin Meng
At present when input clock is disabled, any character transmitted to tx fifo can still show on the serial line, which is wrong. Fixes: b636db306e06 ("hw/char/cadence_uart: add clock support") Signed-off-by: Bin Meng --- hw/char/cadence_uart.c | 5 + 1 file changed, 5 insertions(+) diff --

[PATCH v2 0/3] docs/about: some documentation clean-up/fix

2021-08-22 Thread Yanan Wang
This series makes some clean-up and fix for docs/about, including removing the duplicated section, unifying the subject format, and adding the missed release record in the subject. v1->v2: - update the commit message, combined with Cornelia's comment - add the missing release record in the subject

[PATCH v2 3/3] docs/about: Add the missing release record in the subject

2021-08-22 Thread Yanan Wang
Commit 29e0447551 (docs/about/removed-features: Document removed CLI options from QEMU v3.1) has recorded some CLI options as replaced/removed from QEMU v3.1, but one of the subjects has missed the release record. Let's fix it. Reported-by: Cornelia Huck Signed-off-by: Yanan Wang --- docs/about

[PATCH v2 2/3] docs/about: Unify the subject format

2021-08-22 Thread Yanan Wang
There is a mixture of "since/removed in X.Y" vs "since/removed in X.Y.Z" in the subjects in deprecated.rst/removed-features.rst. It will be better to use an unified format. It seems unlikely that we will ever deprecate something in a stable release, and even more unlikely that we'll remove somethin

[PATCH v2 1/3] docs/about: Remove the duplicated doc

2021-08-22 Thread Yanan Wang
There are two places describing the same thing about deprecation of invalid topologies of -smp CLI, so remove the duplicated one. Signed-off-by: Yanan Wang Reviewed-by: Cornelia Huck --- docs/about/removed-features.rst | 13 - 1 file changed, 13 deletions(-) diff --git a/docs/about

Re: [PATCH v4 02/21] tests/tcg/riscv64: Add test for division

2021-08-22 Thread Bin Meng
On Sat, Aug 21, 2021 at 1:43 AM Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > tests/tcg/riscv64/test-div.c | 58 +++ > tests/tcg/riscv64/Makefile.target | 5 +++ > 2 files changed, 63 insertions(+) > create mode 100644 tests/tcg/riscv64/

[PATCH v2 0/2] enable fsdax rdma migration

2021-08-22 Thread Li Zhijian
Previous qemu are facing 2 problems when migrating a fsdax memory backend with RDMA protocol. (1) ibv_reg_mr failed with Operation not supported (2) requester(source) side could receive RNR NAK. For the (1), we can try to register memory region with ODP feature which has already been implemented i

[PATCH v2 2/2] migration/rdma: advise prefetch write for ODP region

2021-08-22 Thread Li Zhijian
The responder mr registering with ODP will sent RNR NAK back to the requester in the face of the page fault. - ibv_poll_cq wc.status=13 RNR retry counter exceeded! ibv_poll_cq wrid=WRITE RDMA! - ibv_advise_mr(3) helps to make pages present before the actual IO is conducted so that t

[PATCH v2 1/2] migration/rdma: Try to register On-Demand Paging memory region

2021-08-22 Thread Li Zhijian
Previously, for the fsdax mem-backend-file, it will register failed with Operation not supported. In this case, we can try to register it with On-Demand Paging[1] like what rpma_mr_reg() does on rpma[2]. [1]: https://community.mellanox.com/s/article/understanding-on-demand-paging--odp-x [2]: http

Re: [PATCH v2 1/2] migration: allow multifd for socket protocol only

2021-08-22 Thread lizhij...@fujitsu.com
kindly ping On 31/07/2021 22:05, Li Zhijian wrote: > multifd with unsupported protocol will cause a segment fault. > (gdb) bt > #0 0x563b4a93faf8 in socket_connect (addr=0x0, errp=0x7f7f02675410) at > ../util/qemu-sockets.c:1190 > #1 0x563b4a797a03 in qio_channel_socket_connect_syn

Re: [PATCH v4 03/21] target/riscv: Clean up division helpers

2021-08-22 Thread Bin Meng
On Sat, Aug 21, 2021 at 1:46 AM Richard Henderson wrote: > > Utilize the condition in the movcond more; this allows some of > the setcond that were feeding into movcond to be removed. > Do not write into source1 and source2. Re-name "condN" to "tempN" > and use the temporaries for more than holdi

Re: [PATCH 1/3] hw/misc: zynq_slcr: Correctly compute output clocks in the reset exit phase

2021-08-22 Thread Alistair Francis
On Mon, Aug 23, 2021 at 12:09 PM Bin Meng wrote: > > As of today, when booting upstream U-Boot for Xilinx Zynq, the UART > does not receive anything. Debugging shows that the UART input clock > frequency is zero which prevents the UART from receiving anything as > per the logic in uart_receive().

Re: [PATCH 2/3] hw/char: cadence_uart: Disable transmit when input clock is disabled

2021-08-22 Thread Alistair Francis
On Mon, Aug 23, 2021 at 12:11 PM Bin Meng wrote: > > At present when input clock is disabled, any character transmitted > to tx fifo can still show on the serial line, which is wrong. > > Fixes: b636db306e06 ("hw/char/cadence_uart: add clock support") > Signed-off-by: Bin Meng > --- > > hw/char/

Re: [PATCH 2/3] hw/char: cadence_uart: Disable transmit when input clock is disabled

2021-08-22 Thread Bin Meng
On Mon, Aug 23, 2021 at 12:43 PM Alistair Francis wrote: > > On Mon, Aug 23, 2021 at 12:11 PM Bin Meng wrote: > > > > At present when input clock is disabled, any character transmitted > > to tx fifo can still show on the serial line, which is wrong. > > > > Fixes: b636db306e06 ("hw/char/cadence_

Re: [PATCH v4 15/21] target/riscv: Reorg csr instructions

2021-08-22 Thread Bin Meng
On Sat, Aug 21, 2021 at 1:43 AM Richard Henderson wrote: > > Introduce csrr and csrw helpers, for read-only and write-only insns. > > Note that we do not properly implement this in riscv_csrrw, in that > we cannot distinguish true read-only (rs1 == 0) from any other zero > write_mask another sourc

[PATCH] hw/arm/smmuv3: Simplify range invalidation

2021-08-22 Thread Liu, Renwei
Simplify range invalidation which can avoid to iterate over all iotlb entries multi-times. For instance invalidations patterns like "invalidate 32 4kB pages starting from 0xffacd000" need to iterate over all iotlb entries 6 times (num_pages: 1, 2, 16, 8, 4, 1). It only needs to iterate over all iot

Re: [PATCH v2 1/3] docs/about: Remove the duplicated doc

2021-08-22 Thread Thomas Huth
On 23/08/2021 05.00, Yanan Wang wrote: There are two places describing the same thing about deprecation of invalid topologies of -smp CLI, so remove the duplicated one. Signed-off-by: Yanan Wang Reviewed-by: Cornelia Huck --- docs/about/removed-features.rst | 13 - 1 file change

Re: [PATCH v2 2/3] docs/about: Unify the subject format

2021-08-22 Thread Thomas Huth
On 23/08/2021 05.00, Yanan Wang wrote: There is a mixture of "since/removed in X.Y" vs "since/removed in X.Y.Z" in the subjects in deprecated.rst/removed-features.rst. It will be better to use an unified format. It seems unlikely that we will ever deprecate something in a stable release, and even

Re: [PATCH v2 3/3] docs/about: Add the missing release record in the subject

2021-08-22 Thread Thomas Huth
On 23/08/2021 05.00, Yanan Wang wrote: Commit 29e0447551 (docs/about/removed-features: Document removed CLI options from QEMU v3.1) has recorded some CLI options as replaced/removed from QEMU v3.1, but one of the subjects has missed the release record. Let's fix it. Reported-by: Cornelia Huck S

Re: [PATCH v4 02/21] tests/tcg/riscv64: Add test for division

2021-08-22 Thread Alistair Francis
On Mon, Aug 23, 2021 at 1:19 PM Bin Meng wrote: > > On Sat, Aug 21, 2021 at 1:43 AM Richard Henderson > wrote: > > > > Signed-off-by: Richard Henderson Reviewed-by: Alistair Francis Alistair > > --- > > tests/tcg/riscv64/test-div.c | 58 +++ > > tests/tcg/ri

Re: [PATCH v4 03/21] target/riscv: Clean up division helpers

2021-08-22 Thread Alistair Francis
On Sat, Aug 21, 2021 at 3:48 AM Richard Henderson wrote: > > Utilize the condition in the movcond more; this allows some of > the setcond that were feeding into movcond to be removed. > Do not write into source1 and source2. Re-name "condN" to "tempN" > and use the temporaries for more than holdi

Re: [PATCH v4 10/21] target/riscv: Move gen_* helpers for RVB

2021-08-22 Thread Alistair Francis
On Sat, Aug 21, 2021 at 3:53 AM Richard Henderson wrote: > > Move these helpers near their use by the trans_* > functions within insn_trans/trans_rvb.c.inc. > > Reviewed-by: Bin Meng > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Richard Henderson Reviewed-by: Alistair Francis Alista

Re: [PATCH v4 11/21] target/riscv: Add DisasExtend to gen_unary

2021-08-22 Thread Alistair Francis
On Sat, Aug 21, 2021 at 3:50 AM Richard Henderson wrote: > > Use ctx->w for ctpopw, which is the only one that can > re-use the generic algorithm for the narrow operation. > > Signed-off-by: Richard Henderson Reviewed-by: Alistair Francis Alistair > --- > target/riscv/translate.c

Re: [PATCH v4 12/21] target/riscv: Use DisasExtend in shift operations

2021-08-22 Thread Alistair Francis
On Sat, Aug 21, 2021 at 3:56 AM Richard Henderson wrote: > > These operations are greatly simplified by ctx->w, which allows > us to fold gen_shiftw into gen_shift. Split gen_shifti into > gen_shift_imm_{fn,tl} like we do for gen_arith_imm_{fn,tl}. > > Reviewed-by: Bin Meng > Signed-off-by: Rich

Re: [PATCH v4 13/21] target/riscv: Use get_gpr in branches

2021-08-22 Thread Alistair Francis
On Sat, Aug 21, 2021 at 3:58 AM Richard Henderson wrote: > > Narrow the scope of t0 in trans_jalr. > > Reviewed-by: Bin Meng > Signed-off-by: Richard Henderson Reviewed-by: Alistair Francis Alistair > --- > target/riscv/insn_trans/trans_rvi.c.inc | 25 ++--- > 1 file cha

Re: [PATCH 2/3] hw/char: cadence_uart: Disable transmit when input clock is disabled

2021-08-22 Thread Alistair Francis
On Mon, Aug 23, 2021 at 2:53 PM Bin Meng wrote: > > On Mon, Aug 23, 2021 at 12:43 PM Alistair Francis > wrote: > > > > On Mon, Aug 23, 2021 at 12:11 PM Bin Meng wrote: > > > > > > At present when input clock is disabled, any character transmitted > > > to tx fifo can still show on the serial li