Re: [PATCH v2] hw/intc/sifive_clint: Fix overflow in sifive_clint_write_timecmp()

2021-08-16 Thread Alistair Francis
On Tue, Aug 17, 2021 at 4:39 AM David Hoppenbrouwers wrote: > > `next` is an `uint64_t` value, but `timer_mod` takes an `int64_t`. This > resulted in high values such as `UINT64_MAX` being converted to `-1`, > which caused an immediate timer interrupt. > > By limiting `next` to `INT64_MAX` no over

[PATCH RFC v6 03/12] target/riscv: Implement function kvm_arch_init_vcpu

2021-08-16 Thread Yifei Jiang
Get isa info from kvm while kvm init. Signed-off-by: Yifei Jiang Signed-off-by: Mingwang Li Reviewed-by: Alistair Francis --- target/riscv/kvm.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/target/riscv/kvm.c b/target/riscv/kvm.c index 687dd4b

[PATCH RFC v6 12/12] target/riscv: Support virtual time context synchronization

2021-08-16 Thread Yifei Jiang
Add virtual time context description to vmstate_riscv_cpu. After cpu being loaded, virtual time context is updated to KVM. Signed-off-by: Yifei Jiang Signed-off-by: Mingwang Li --- target/riscv/machine.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/target/riscv/machine.c

[PATCH RFC v6 10/12] target/riscv: Add kvm_riscv_get/put_regs_timer

2021-08-16 Thread Yifei Jiang
Add kvm_riscv_get/put_regs_timer to synchronize virtual time context from KVM. To set register of RISCV_TIMER_REG(state) will occur a error from KVM on kvm_timer_state == 0. It's better to adapt in KVM, but it doesn't matter that adaping in QEMU. Signed-off-by: Yifei Jiang Signed-off-by: Mingwan

[PATCH RFC v6 07/12] target/riscv: Support setting external interrupt by KVM

2021-08-16 Thread Yifei Jiang
Extend riscv_cpu_update_mip() to support setting external interrupt by KVM. It will call kvm_riscv_set_irq() to change the IRQ state in the KVM module When kvm is enabled and the MIP_SEIP bit is set in "mask" In addition, bacause target/riscv/cpu_helper.c is used to TCG, so move riscv_cpu_update_m

[PATCH RFC v6 05/12] target/riscv: Implement kvm_arch_put_registers

2021-08-16 Thread Yifei Jiang
Put GPR CSR and FP registers to kvm by KVM_SET_ONE_REG ioctl Signed-off-by: Yifei Jiang Signed-off-by: Mingwang Li Reviewed-by: Alistair Francis --- target/riscv/kvm.c | 141 - 1 file changed, 140 insertions(+), 1 deletion(-) diff --git a/target/ris

[PATCH RFC v6 00/12] Add riscv kvm accel support

2021-08-16 Thread Yifei Jiang
This series adds both riscv32 and riscv64 kvm support, and implements migration based on riscv. It is based on temporarily unaccepted kvm: https://github.com/kvm-riscv/linux (lastest version v19). This series depends on above pending changes which haven't yet been accepted, so this QEMU patch seri

[PATCH RFC v6 06/12] target/riscv: Support start kernel directly by KVM

2021-08-16 Thread Yifei Jiang
Get kernel and fdt start address in virt.c, and pass them to KVM when cpu reset. In addition, add kvm_riscv.h to place riscv specific interface. Signed-off-by: Yifei Jiang Signed-off-by: Mingwang Li Reviewed-by: Alistair Francis --- hw/riscv/boot.c | 11 +++ hw/riscv/virt.c

[PATCH RFC v6 02/12] target/riscv: Add target/riscv/kvm.c to place the public kvm interface

2021-08-16 Thread Yifei Jiang
Add target/riscv/kvm.c to place kvm_arch_* function needed by kvm/kvm-all.c. Meanwhile, add kvm support in meson.build file. Signed-off-by: Yifei Jiang Signed-off-by: Mingwang Li Reviewed-by: Alistair Francis --- meson.build | 2 + target/riscv/kvm.c | 133

[PATCH RFC v6 04/12] target/riscv: Implement kvm_arch_get_registers

2021-08-16 Thread Yifei Jiang
Get GPR CSR and FP registers from kvm by KVM_GET_ONE_REG ioctl. Signed-off-by: Yifei Jiang Signed-off-by: Mingwang Li Reviewed-by: Alistair Francis --- target/riscv/kvm.c | 150 - 1 file changed, 149 insertions(+), 1 deletion(-) diff --git a/target/

[PATCH RFC v6 11/12] target/riscv: Implement virtual time adjusting with vm state changing

2021-08-16 Thread Yifei Jiang
We hope that virtual time adjusts with vm state changing. When a vm is stopped, guest virtual time should stop counting and kvm_timer should be stopped. When the vm is resumed, guest virtual time should continue to count and kvm_timer should be restored. Signed-off-by: Yifei Jiang Signed-off-by:

Re: [PATCH] hw/arm/Kconfig: no need to enable ACPI_MEMORY_HOTPLUG explicitly

2021-08-16 Thread Ani Sinha
ping ... On Thu, 12 Aug 2021, Ani Sinha wrote: > ACPI_MEMORY_HOTPLUG is implicitly turned on when ACPI_HW_REDUCED is selected. > ACPI_HW_REDUCED is already enabled. No need to turn on ACPI_MEMORY_HOTPLUG > explicitly. This is a minor cleanup. > > Signed-off-by: Ani Sinha > --- > hw/arm/Kconfig

Re: [PATCH v3 09/13] python/aqmp-tui: Add QMP connection manager

2021-08-16 Thread John Snow
On Fri, Jul 30, 2021 at 4:19 PM G S Niteesh Babu wrote: > Instead of manually connecting and disconnecting from the > server. We now rely on the runstate to manage the QMP > connection. > > Along with this the ability to reconnect on certain exceptions > has also been added. > > Signed-off-by: G

Re: [PATCH v2] hw/i386/acpi-build: Get NUMA information from struct NumaState

2021-08-16 Thread Liu, Jingqi
On 8/16/2021 6:05 PM, Philippe Mathieu-Daudé wrote: On 8/6/21 5:19 AM, Jingqi Liu wrote: Maybe prepend with: Since commits aa57020774b ("numa: move numa global variable nb_numa_nodes into MachineState") and 7e721e7b10e ("numa: move numa global variable numa_info into MachineState"), we can .

Re: [PATCH 0/5] ebpf: Added ebpf helper for libvirtd.

2021-08-16 Thread Jason Wang
On Mon, Aug 16, 2021 at 7:58 PM Yuri Benditovich wrote: > > Jason, > Can you please review the series? WIll do it this week. Thanks > > Thanks, > Yuri > > On Thu, Jul 22, 2021 at 11:38 AM Andrew Melnichenko wrote: > > > > ping > > > > On Tue, Jul 13, 2021 at 6:38 PM Andrew Melnychenko > > wr

Re: [PATCH] net/colo: check vnet_hdr_support flag when using virtio-net

2021-08-16 Thread Tao Xu
On 8/16/2021 10:58 AM, Jason Wang wrote: 在 2021/8/6 下午2:08, Tao Xu 写道: When COLO use only one vnet_hdr_support parameter between COLO network filter(filter-mirror, filter-redirector or filter-rewriter and colo-compare, packet will not be parsed correctly. Acquire network driver related to COL

Re: [PATCH v3 2/6] block: block-status cache for data regions

2021-08-16 Thread Hanna Reitz
On 16.08.21 23:38, Eric Blake wrote: On Thu, Aug 12, 2021 at 10:41:44AM +0200, Hanna Reitz wrote: As we have attempted before (https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg06451.html, "file-posix: Cache lseek result for data regions"; https://lists.nongnu.org/archive/html/qemu-block/

RE: [PATCH v4 1/3] target-arm: Add support for Fujitsu A64FX

2021-08-16 Thread ishii.shuuic...@fujitsu.com
> On Thu, 12 Aug 2021 at 10:25, Andrew Jones wrote: > > On second thought, do we want the QMP CPU model expansion query to > > show that this CPU type has sve,sve128,sve256,sve512? If so, then our > > SVE work isn't complete, because we need those properties, set true by > > default, but forbidd

<    1   2   3