Re: [PATCH v2] hw/display/xlnx_dp: fix an out-of-bounds read in xlnx_dp_read

2021-08-06 Thread Qiang Liu
On Wed, Aug 4, 2021 at 3:43 PM Thomas Huth wrote: > > On 04/08/2021 08.51, Qiang Liu wrote: > > xlnx_dp_read allows an out-of-bounds read at its default branch because > > of an improper index. > > > > According to > > https://www.xilinx.com/html_docs/registers/ug1087/ug1087-zynq-ultrascale-regist

Re: [PATCH v2] hw/display/xlnx_dp: fix an out-of-bounds read in xlnx_dp_read

2021-08-06 Thread Thomas Huth
On 06/08/2021 09.00, Qiang Liu wrote: On Wed, Aug 4, 2021 at 3:43 PM Thomas Huth wrote: On 04/08/2021 08.51, Qiang Liu wrote: xlnx_dp_read allows an out-of-bounds read at its default branch because of an improper index. According to https://www.xilinx.com/html_docs/registers/ug1087/ug1087-zy

Re: [PATCH v1 03/12] s390x/tcg: convert real to absolute address for RRBE, SSKE and ISKE

2021-08-06 Thread Thomas Huth
On 06/08/2021 08.52, David Hildenbrand wrote: According to the PoP: "When the enhanced-DAT facility 1 is not installed, or    when the facility is installed but the multiple-block    control is zero, general register R 2 contains a real    address. When the enhanced-DAT facility 1 is    install

Re: [PATCH v1 03/12] s390x/tcg: convert real to absolute address for RRBE, SSKE and ISKE

2021-08-06 Thread David Hildenbrand
On 06.08.21 09:11, Thomas Huth wrote: On 06/08/2021 08.52, David Hildenbrand wrote: According to the PoP: "When the enhanced-DAT facility 1 is not installed, or    when the facility is installed but the multiple-block    control is zero, general register R 2 contains a real    address. When

Re: [PATCH] Use EGL device extension in display initialization.

2021-08-06 Thread Marc-André Lureau
Hi On Fri, Aug 6, 2021 at 2:28 AM Eugene Huang wrote: > This patch enables running generic EGL devices such as Nvidia’s in > headless mode. It assumes single device. More work is needed to support > multiple devices. > > > > Signed-off-by: Eugene Huang > Thanks for the patch. It isn't correctl

Re: [PATCH 1/2] virtio: add a way to disable a queue

2021-08-06 Thread Laurent Vivier
On 06/08/2021 08:25, Jason Wang wrote: > > 在 2021/8/2 下午4:42, Laurent Vivier 写道: >> On 02/08/2021 06:50, Jason Wang wrote: >>> 在 2021/7/30 上午3:19, Laurent Vivier 写道: Add virtio_queue_disable()/virtio_queue_enable() to disable/enable a queue by setting vring.num to 0 (or num_default). >>>

Re: [PATCH v1 05/12] s390x/mmu_helper: no need to pass access type to mmu_translate_asce()

2021-08-06 Thread Thomas Huth
On 05/08/2021 17.27, David Hildenbrand wrote: The access type is unused. Signed-off-by: David Hildenbrand --- target/s390x/mmu_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c index 0620b1803e..167f1b1455 1

Re: [PATCH v1 06/12] s390x/mmu_helper: fixup mmu_translate() documentation

2021-08-06 Thread Thomas Huth
On 05/08/2021 17.27, David Hildenbrand wrote: Looks like we forgot to adjust documentation of one parameter. Signed-off-by: David Hildenbrand --- target/s390x/mmu_helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helpe

Re: [PATCH v1 05/12] s390x/mmu_helper: no need to pass access type to mmu_translate_asce()

2021-08-06 Thread David Hildenbrand
On 06.08.21 09:30, Thomas Huth wrote: Fixes: 81d7e3bc45 ("s390x/mmu: Inject DAT exceptions from a single place") Reviewed-by: Thomas Huth I'm usually a bit careful with Fixes tags if we're not fixing real BUGs. At least in the kernel people will really complain if you do that (because it mig

Re: [PATCH v1 05/12] s390x/mmu_helper: no need to pass access type to mmu_translate_asce()

2021-08-06 Thread Thomas Huth
On 06/08/2021 09.34, David Hildenbrand wrote: On 06.08.21 09:30, Thomas Huth wrote: Fixes: 81d7e3bc45 ("s390x/mmu: Inject DAT exceptions from a single place") Reviewed-by: Thomas Huth I'm usually a bit careful with Fixes tags if we're not fixing real BUGs. At least in the kernel people will

Re: [PATCH v1 05/12] s390x/mmu_helper: no need to pass access type to mmu_translate_asce()

2021-08-06 Thread David Hildenbrand
On 06.08.21 09:36, Thomas Huth wrote: On 06/08/2021 09.34, David Hildenbrand wrote: On 06.08.21 09:30, Thomas Huth wrote: Fixes: 81d7e3bc45 ("s390x/mmu: Inject DAT exceptions from a single place") Reviewed-by: Thomas Huth I'm usually a bit careful with Fixes tags if we're not fixing real BUG

Re: [RESEND RFC] hw/arm/smmuv3: add device properties to disable cached iotlb

2021-08-06 Thread chenxiang (M)
Hi Eric, 在 2021/8/5 16:10, Eric Auger 写道: Hi Chenxiang, On 8/5/21 9:48 AM, chenxiang (M) wrote: Hi Eric, 在 2021/8/5 0:26, Eric Auger 写道: Hi Chenxiang, On 8/4/21 10:49 AM, chenxiang wrote: From: Xiang Chen It splits invalidations into ^2 range invalidations in the patch 6d9cd115b(" hw/ar

Re: [PATCH for-6.2 v4 06/14] machine: Prefer cores over sockets in smp parsing since 6.2

2021-08-06 Thread wangyanan (Y)
On 2021/8/6 12:41, Pankaj Gupta wrote: In the real SMP hardware topology world, it's much more likely that we have high cores-per-socket counts and few sockets totally. While the current preference of sockets over cores in smp parsing results in a virtual cpu topology with low cores-per-sockets c

Re: [PATCH v1 07/12] s390x/mmu_helper: move address validation into mmu_translate*()

2021-08-06 Thread Thomas Huth
On 05/08/2021 17.27, David Hildenbrand wrote: Let's move address validation into mmu_translate() and mmu_translate_real(). This allows for checking whether an absolute address is valid before looking up the storage key. We can now get rid of the ram_size check. Interestingly, we're already handl

Re: [PATCH v1 07/12] s390x/mmu_helper: move address validation into mmu_translate*()

2021-08-06 Thread David Hildenbrand
On 06.08.21 10:18, Thomas Huth wrote: On 05/08/2021 17.27, David Hildenbrand wrote: Let's move address validation into mmu_translate() and mmu_translate_real(). This allows for checking whether an absolute address is valid before looking up the storage key. We can now get rid of the ram_size che

Re: [PATCH v1 07/12] s390x/mmu_helper: move address validation into mmu_translate*()

2021-08-06 Thread Thomas Huth
On 05/08/2021 17.27, David Hildenbrand wrote: Let's move address validation into mmu_translate() and mmu_translate_real(). This allows for checking whether an absolute address is valid before looking up the storage key. We can now get rid of the ram_size check. Interestingly, we're already handl

Re: [PATCH v1 07/12] s390x/mmu_helper: move address validation into mmu_translate*()

2021-08-06 Thread Thomas Huth
On 06/08/2021 10.20, David Hildenbrand wrote: On 06.08.21 10:18, Thomas Huth wrote: On 05/08/2021 17.27, David Hildenbrand wrote: Let's move address validation into mmu_translate() and mmu_translate_real(). This allows for checking whether an absolute address is valid before looking up the stor

Re: [PATCH v1 07/12] s390x/mmu_helper: move address validation into mmu_translate*()

2021-08-06 Thread David Hildenbrand
On 06.08.21 10:22, Thomas Huth wrote: On 06/08/2021 10.20, David Hildenbrand wrote: On 06.08.21 10:18, Thomas Huth wrote: On 05/08/2021 17.27, David Hildenbrand wrote: Let's move address validation into mmu_translate() and mmu_translate_real(). This allows for checking whether an absolute addr

Re: [PATCH v1 08/12] s390x/mmu_helper: avoid setting the storage key if nothing changed

2021-08-06 Thread Thomas Huth
On 05/08/2021 17.28, David Hildenbrand wrote: Avoid setting the key if nothing changed. Signed-off-by: David Hildenbrand --- target/s390x/mmu_helper.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c index 3

Re: [PATCH v1 07/12] s390x/mmu_helper: move address validation into mmu_translate*()

2021-08-06 Thread Thomas Huth
On 06/08/2021 10.23, David Hildenbrand wrote: On 06.08.21 10:22, Thomas Huth wrote: On 06/08/2021 10.20, David Hildenbrand wrote: On 06.08.21 10:18, Thomas Huth wrote: On 05/08/2021 17.27, David Hildenbrand wrote: Let's move address validation into mmu_translate() and mmu_translate_real(). Th

Re: [PATCH for-6.1 v5 1/1] machine: Disallow specifying topology parameters as zero

2021-08-06 Thread wangyanan (Y)
A gentle ping ... Will this patch be picked up soon for 6.1 or is there anything else to tweak? Thanks, Yanan On 2021/7/23 17:57, Yanan Wang wrote: In the SMP configuration, we should either specify a topology parameter with a reasonable value (equal to or greater than 1) or just leave it om

Re: [PATCH v1 09/12] hw/s390x/s390-skeys: use memory mapping to detect which storage keys to migrate

2021-08-06 Thread Thomas Huth
On 05/08/2021 17.28, David Hildenbrand wrote: Let's use the guest_phys_blocks API to get physical memory regions that are well defined inside our physical address space and migrate the storage keys of these. This is a prepearation for having memory besides initial ram defined in s/prepearation

Re: [PATCH v1 10/12] hw/s390x/s390-skeys: use memory mapping to detect which storage keys to dump

2021-08-06 Thread Thomas Huth
On 05/08/2021 17.28, David Hildenbrand wrote: Handle it similar to migration. Assert that we're holding the BQL, to make sure we don't see concurrent modifications. Signed-off-by: David Hildenbrand --- hw/s390x/s390-skeys.c | 50 ++- 1 file changed, 30

Re: [PATCH v1 11/12] hw/s390x/s390-skeys: check if an address is valid before dumping the key

2021-08-06 Thread Thomas Huth
On 05/08/2021 17.28, David Hildenbrand wrote: Let's validate the given address and report a proper error in case it's not. All call paths now properly check the validity of the given GFN. Remove the TODO. The errors inside the getter and setter should only trigger if something really goes wrong

Re: [PATCH v1 11/12] hw/s390x/s390-skeys: check if an address is valid before dumping the key

2021-08-06 Thread David Hildenbrand
On 06.08.21 10:53, Thomas Huth wrote: On 05/08/2021 17.28, David Hildenbrand wrote: Let's validate the given address and report a proper error in case it's not. All call paths now properly check the validity of the given GFN. Remove the TODO. The errors inside the getter and setter should only

Re: Win32 and ACCEL macro/function

2021-08-06 Thread Daniel P . Berrangé
On Thu, Aug 05, 2021 at 11:00:24PM -0400, Eduardo Habkost wrote: > Hello, > > I'm looking for help dealing with a naming conflict when building > QEMU for Windows hosts. > > The summary is: I'm trying to replace the ACCEL() macro in > include/qemu/accel.h with an inline function, but the ACCEL na

[PULL 0/2] Linux user for 6.1 patches

2021-08-06 Thread Laurent Vivier
030912e01c0385b6b09e76549c1a8a04b624f49a: linux-user/elfload: byteswap i386 registers when dumping core (2021-08-05 12:17:30 +0200) linux-user pull request 20210806 Fix endianness and addresses in i386 linux-user target

[PULL 1/2] linux-user: fix guest/host address mixup in i386 setup_rt_frame()

2021-08-06 Thread Laurent Vivier
From: Ilya Leoshkevich setup_rt_frame() passes siginfo and ucontext host addresses to guest signal handlers, causing problems when e.g. emulating x86_64 on s390x. Signed-off-by: Ilya Leoshkevich Reviewed-by: Richard Henderson Message-Id: <20210803171858.148394-1-...@linux.ibm.com> Signed-off-b

[PULL 2/2] linux-user/elfload: byteswap i386 registers when dumping core

2021-08-06 Thread Laurent Vivier
From: Ilya Leoshkevich Core dumps from emulating x86_64 on big-endian hosts contain incorrect register values. Signed-off-by: Ilya Leoshkevich Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210803172013.148446-1-...@linux.ibm.com> Signed-off-by: Laurent Vivier

Re: [PATCH for-6.2 v4 06/14] machine: Prefer cores over sockets in smp parsing since 6.2

2021-08-06 Thread Pankaj Gupta
> >> In the real SMP hardware topology world, it's much more likely that > >> we have high cores-per-socket counts and few sockets totally. While > >> the current preference of sockets over cores in smp parsing results > >> in a virtual cpu topology with low cores-per-sockets counts and a > >> larg

[PATCH for-6.2 v3 01/12] job: Context changes in job_completed_txn_abort()

2021-08-06 Thread Max Reitz
Finalizing the job may cause its AioContext to change. This is noted by job_exit(), which points at job_txn_apply() to take this fact into account. However, job_completed() does not necessarily invoke job_txn_apply() (through job_completed_txn_success()), but potentially also job_completed_txn_ab

[PATCH for-6.2 v3 00/12] mirror: Handle errors after READY cancel

2021-08-06 Thread Max Reitz
Hi, v1 cover letter: https://lists.nongnu.org/archive/html/qemu-block/2021-07/msg00705.html v2 cover letter: https://lists.nongnu.org/archive/html/qemu-block/2021-07/msg00747.html Changes in v3: - Patch 1: After adding patch 11, I got a failed assertion in tests/unit/test-block-iothread (faili

[PATCH for-6.2 v3 06/12] jobs: Give Job.force_cancel more meaning

2021-08-06 Thread Max Reitz
We largely have two cancel modes for jobs: First, there is actual cancelling. The job is terminated as soon as possible, without trying to reach a consistent result. Second, we have mirror in the READY state. Technically, the job is not really cancelled, but it just is a different completion mo

[PATCH for-6.2 v3 02/12] mirror: Keep s->synced on error

2021-08-06 Thread Max Reitz
An error does not take us out of the READY phase, which is what s->synced signifies. It does of course mean that source and target are no longer in sync, but that is what s->actively_sync is for -- s->synced never meant that source and target are in sync, only that they were at some point (and at

[PATCH for-6.2 v3 03/12] mirror: Drop s->synced

2021-08-06 Thread Max Reitz
As of HEAD^, there is no meaning to s->synced other than whether the job is READY or not. job_is_ready() gives us that information, too. Suggested-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Kevin Wol

[PATCH for-6.2 v3 07/12] job: Add job_cancel_requested()

2021-08-06 Thread Max Reitz
Most callers of job_is_cancelled() actually want to know whether the job is on its way to immediate termination. For example, we refuse to pause jobs that are cancelled; but this only makes sense for jobs that are really actually cancelled. A mirror job that is cancelled during READY with force=f

[PATCH for-6.2 v3 05/12] job: @force parameter for job_cancel_sync{, _all}()

2021-08-06 Thread Max Reitz
Callers should be able to specify whether they want job_cancel_sync() to force-cancel the job or not. In fact, almost all invocations do not care about consistency of the result and just want the job to terminate as soon as possible, so they should pass force=true. The replication block driver is

[PATCH for-6.2 v3 04/12] job: Force-cancel jobs in a failed transaction

2021-08-06 Thread Max Reitz
When a transaction is aborted, no result matters, and so all jobs within should be force-cancelled. Signed-off-by: Max Reitz --- job.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/job.c b/job.c index 3fe23bb77e..24e7c4fcb7 100644 --- a/job.c +++ b/job.c @@ -766,7 +76

Re: [PATCH v1 12/12] hw/s390x/s390-skeys: lazy storage key enablement under TCG

2021-08-06 Thread Thomas Huth
On 05/08/2021 17.28, David Hildenbrand wrote: Let's enable storage keys lazily under TCG, just as we do under KVM. Only fairly old Linux versions actually make use of storage keys, so it can be kind of wasteful to allocate quite some memory and track changes and references if nobody cares. We ha

[PATCH for-6.2 v3 09/12] mirror: Check job_is_cancelled() earlier

2021-08-06 Thread Max Reitz
We must check whether the job is force-cancelled early in our main loop, most importantly before any `continue` statement. For example, we used to have `continue`s before our current checking location that are triggered by `mirror_flush()` failing. So, if `mirror_flush()` kept failing, force-canc

Re: [PATCH v8] tests/tcg/s390x: Test SIGILL and SIGSEGV handling

2021-08-06 Thread Ilya Leoshkevich
On Fri, 2021-08-06 at 07:25 +0200, Thomas Huth wrote: > On 05/08/2021 00.51, Ilya Leoshkevich wrote: > > Verify that s390x-specific uc_mcontext.psw.addr is reported > > correctly > > and that signal handling interacts properly with debugging. > > > > Signed-off-by: Ilya Leoshkevich > > --- > > >

[PATCH for-6.2 v3 08/12] mirror: Use job_is_cancelled()

2021-08-06 Thread Max Reitz
mirror_drained_poll() returns true whenever the job is cancelled, because "we [can] be sure that it won't issue more requests". However, this is only true for force-cancelled jobs, so use job_is_cancelled(). Signed-off-by: Max Reitz --- block/mirror.c | 2 +- 1 file changed, 1 insertion(+), 1 d

[PATCH for-6.2 v3 10/12] mirror: Stop active mirroring after force-cancel

2021-08-06 Thread Max Reitz
Once the mirror job is force-cancelled (job_is_cancelled() is true), we should not generate new I/O requests. This applies to active mirroring, too, so stop it once the job is cancelled. (We must still forward all I/O requests to the source, though, of course, but those are not really I/O request

[PATCH for-6.2 v3 11/12] mirror: Do not clear .cancelled

2021-08-06 Thread Max Reitz
Clearing .cancelled before leaving the main loop when the job has been soft-cancelled is no longer necessary since job_is_cancelled() only returns true for jobs that have been force-cancelled. Therefore, this only makes a differences in places that call job_cancel_requested(). In block/mirror.c,

[PATCH for-6.2 v3 12/12] iotests: Add mirror-ready-cancel-error test

2021-08-06 Thread Max Reitz
Test what happens when there is an I/O error after a mirror job in the READY phase has been cancelled. Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy Tested-by: Vladimir Sementsov-Ogievskiy --- .../tests/mirror-ready-cancel-error | 143 ++ .../test

Re: [RFC PATCH v4 3/4] Adding Andes AX25 and A25 CPU model

2021-08-06 Thread Bin Meng
On Fri, Aug 6, 2021 at 2:12 PM Ruinland Chuan-Tzu Tsa(蔡傳資) wrote: > > Hi Bin and Alistair, > > >> Adding Andes AX25 and A25 CPU model into cpu.h and cpu.c without > > > The latest RISC-V core from Andes is AX45 and A45. Should we just > > support the latest one? > > Maybe we can have them all ? >

Re: [RFC PATCH 00/13] Support UXL field in mstatus

2021-08-06 Thread Alistair Francis
On Thu, Aug 5, 2021 at 5:15 PM LIU Zhiwei wrote: > > > On 2021/8/5 下午2:01, Alistair Francis wrote: > > On Thu, Aug 5, 2021 at 12:55 PM LIU Zhiwei wrote: > >> This patch set implements UXL field in mstatus register. Programmer can > >> change > >> UXLEN by writting to this field. So that you can

Re: How does qemu detect the completion of interrupt execution?

2021-08-06 Thread Peter Maydell
On Fri, 6 Aug 2021 at 07:24, Duo jia wrote: > I am simulating a device. When an interrupt occurs, another interrupt > comes, and the second interrupt will not be triggered because the > first interrupt has not yet finished. > > I want to know whether qemu can detect whether the interrupt has been

Re: [PATCH v3] hw/acpi: add an assertion check for non-null return from acpi_get_i386_pci_host

2021-08-06 Thread Igor Mammedov
On Thu, 5 Aug 2021 18:13:21 -0400 "Michael S. Tsirkin" wrote: > On Thu, Aug 05, 2021 at 07:42:35PM +0530, Ani Sinha wrote: > > Also to be noted that there is a stub for acpi_get_i386_pci_host() which > > simply returns NULL. This activates when CONFIG_PC is disabled. It is this > > stub that gets

Re: intermittent failure, s390 host, x86-64 guest, vhost-user-blk test

2021-08-06 Thread Peter Maydell
On Thu, 5 Aug 2021 at 18:39, Peter Maydell wrote: > > On Wed, 4 Aug 2021 at 15:33, Peter Maydell wrote: > > > > On Wed, 4 Aug 2021 at 14:43, Michael S. Tsirkin wrote: > > > > > > On Wed, Aug 04, 2021 at 01:40:37PM +0100, Peter Maydell wrote: > > > > Saw this intermittent as part of my ad-hoc CI

Re: [PATCH v3] hw/acpi: add an assertion check for non-null return from acpi_get_i386_pci_host

2021-08-06 Thread Igor Mammedov
On Thu, 5 Aug 2021 19:42:35 +0530 (IST) Ani Sinha wrote: > On Thu, 5 Aug 2021, Ani Sinha wrote: > > > > > > > On Thu, 5 Aug 2021, Ani Sinha wrote: > > > > > > > > > > > On Thu, 5 Aug 2021, Igor Mammedov wrote: > > > > > > > On Mon, 26 Jul 2021 22:27:43 +0530 > > > > Ani Sinha wrote: > > > >

Re: [PATCH RFC 1/6] i386/pc: Account IOVA reserved ranges above 4G boundary

2021-08-06 Thread Joao Martins
[sorry for the thread necromancy -- got preempted in other stuff and am slowly coming back to this] On 6/28/21 3:32 PM, Igor Mammedov wrote: > On Wed, 23 Jun 2021 14:04:19 +0100 > Joao Martins wrote: > >> On 6/23/21 12:39 PM, Igor Mammedov wrote: >>> On Wed, 23 Jun 2021 10:37:38 +0100 >>> Joao

Re: [PATCH for-6.2 1/6] acpi: Delete broken ACPI_GED_X86 macro

2021-08-06 Thread Igor Mammedov
On Thu, 5 Aug 2021 15:34:26 -0400 Eduardo Habkost wrote: > The macro never worked and never will, because the > AcpiGedX86State type never existed. > > Signed-off-by: Eduardo Habkost Reviewed-by: Igor Mammedov > --- > Cc: "Michael S. Tsirkin" > Cc: Igor Mammedov > Cc: qemu-devel@nongnu.or

Re: [PATCH v3] hw/acpi: add an assertion check for non-null return from acpi_get_i386_pci_host

2021-08-06 Thread Ani Sinha
On Fri, 6 Aug 2021, Igor Mammedov wrote: > On Thu, 5 Aug 2021 19:42:35 +0530 (IST) > Ani Sinha wrote: > > > On Thu, 5 Aug 2021, Ani Sinha wrote: > > > > > > > > > > > On Thu, 5 Aug 2021, Ani Sinha wrote: > > > > > > > > > > > > > > > On Thu, 5 Aug 2021, Igor Mammedov wrote: > > > > > > > > > O

Re: [PATCH for-6.2 6/6] Use PCI_HOST_BRIDGE macro

2021-08-06 Thread Igor Mammedov
On Thu, 5 Aug 2021 15:34:31 -0400 Eduardo Habkost wrote: > OBJECT_CHECK(PciHostState, ..., TYPE_PCI_HOST_BRIDGE) is exactly > what the PCI_HOST_BRIDGE macro does. We can just use the macro > instead of using OBJECT_CHECK manually. > > Signed-off-by: Eduardo Habkost Reviewed-by: Igor Mammedov

Re: [PATCH v7 09/10] hw/arm/virt: add ITS support in virt GIC

2021-08-06 Thread Igor Mammedov
On Thu, 5 Aug 2021 18:30:01 -0400 Shashi Mallela wrote: > Included creation of ITS as part of virt platform GIC > initialization. This Emulated ITS model now co-exists with kvm > ITS and is enabled in absence of kvm irq kernel support in a > platform. > > Signed-off-by: Shashi Mallela > Review

Re: [PATCH v7 08/10] tests/data/acpi/virt: Add IORT files for ITS

2021-08-06 Thread Igor Mammedov
On Thu, 5 Aug 2021 18:30:00 -0400 Shashi Mallela wrote: > Added expected IORT files applicable with latest GICv3 > ITS changes.Temporarily differences in these files are > okay. > > Signed-off-by: Shashi Mallela Acked-by: Igor Mammedov > --- > tests/data/acpi/virt/IORT |

Re: [PATCH v7 10/10] tests/data/acpi/virt: Update IORT files for ITS

2021-08-06 Thread Igor Mammedov
On Thu, 5 Aug 2021 18:30:02 -0400 Shashi Mallela wrote: > Updated expected IORT files applicable with latest GICv3 > ITS changes. > > Full diff of new file disassembly: > > /* > * Intel ACPI Component Architecture > * AML/ASL+ Disassembler version 20180629 (64-bit version) > * Copyright (c)

Re: [PATCH v1] s390x/tcg: fix and optimize SPX (SET PREFIX)

2021-08-06 Thread Cornelia Huck
On Thu, Aug 05 2021, David Hildenbrand wrote: > We not only invalidate the translation of the range 0x0-0x2000, we also > invalidate the translation of the new prefix range and the translation > of the old prefix range -- because real2abs would return different > results for all of these ranges w

Re: [PATCH v1] s390x/ioinst: Fix wrong MSCH alignment check on little endian

2021-08-06 Thread Cornelia Huck
On Thu, Aug 05 2021, David Hildenbrand wrote: > schib->pmcw.chars is 32bit, not 16bit. This fixes the kvm-unit-tests > "css" test, which fails with: > > FAIL: Channel Subsystem: measurement block format1: Unaligned MB origin: > Program interrupt: expected(21) == received(0) > > Because we end

Re: [PATCH v6 02/11] qapi: wrap Sequence[str] in an object

2021-08-06 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Mon, Aug 2, 2021 at 1:21 PM Markus Armbruster wrote: > >> marcandre.lur...@redhat.com writes: >> >> > From: Marc-André Lureau >> > >> > Except for the special casing assert in _make_implicit_object_type(), >> > which needs to handle schema objects, it's a m

Re: [PATCH v1 03/12] s390x/tcg: convert real to absolute address for RRBE, SSKE and ISKE

2021-08-06 Thread Cornelia Huck
On Fri, Aug 06 2021, David Hildenbrand wrote: > On 06.08.21 09:11, Thomas Huth wrote: >> On 06/08/2021 08.52, David Hildenbrand wrote: According to the PoP: "When the enhanced-DAT facility 1 is not installed, or    when the facility is installed but the multiple-block >>

Re: [PATCH v1] s390x/tcg: fix and optimize SPX (SET PREFIX)

2021-08-06 Thread David Hildenbrand
On 06.08.21 13:17, Cornelia Huck wrote: On Thu, Aug 05 2021, David Hildenbrand wrote: We not only invalidate the translation of the range 0x0-0x2000, we also invalidate the translation of the new prefix range and the translation of the old prefix range -- because real2abs would return differen

Re: [PATCH v1] s390x/ioinst: Fix wrong MSCH alignment check on little endian

2021-08-06 Thread David Hildenbrand
On 06.08.21 13:19, Cornelia Huck wrote: On Thu, Aug 05 2021, David Hildenbrand wrote: schib->pmcw.chars is 32bit, not 16bit. This fixes the kvm-unit-tests "css" test, which fails with: FAIL: Channel Subsystem: measurement block format1: Unaligned MB origin: Program interrupt: expected(2

Re: [PATCH v1 03/12] s390x/tcg: convert real to absolute address for RRBE, SSKE and ISKE

2021-08-06 Thread David Hildenbrand
On 06.08.21 13:25, Cornelia Huck wrote: On Fri, Aug 06 2021, David Hildenbrand wrote: On 06.08.21 09:11, Thomas Huth wrote: On 06/08/2021 08.52, David Hildenbrand wrote: According to the PoP: "When the enhanced-DAT facility 1 is not installed, or    when the facility is installed but the

Re: [PATCH for-6.2 3/6] s390-sclp-events-bus: Set instance_size

2021-08-06 Thread Cornelia Huck
On Thu, Aug 05 2021, Eduardo Habkost wrote: > We have a SCLPEventsBus struct defined, but the struct is not > used at the TypeInfo definition. This works today but will break > silently if anybody adds a new field to SCLPEventsBus. > > Set instance_size properly to avoid problems in the future.

Re: [PATCH for-6.2 v2] s390-sclp-events-bus: Use OBJECT_DECLARE_SIMPLE_TYPE

2021-08-06 Thread Cornelia Huck
On Thu, Aug 05 2021, Eduardo Habkost wrote: > We have a SCLPEventsBus struct type defined, but no QOM type > checkers are declared for the type. > > Use OBJECT_DECLARE_SIMPLE_TYPE to declare the struct type and > have a SCLP_EVENT_BUS typecast wrapper defined. > > Signed-off-by: Eduardo Habkost

Re: [PATCH for-6.2 5/6] s390x: event-facility: Use SCLP_EVENT_BUS macro

2021-08-06 Thread Cornelia Huck
On Fri, Aug 06 2021, David Hildenbrand wrote: > On 06.08.21 06:15, Thomas Huth wrote: >> On 05/08/2021 21.34, Eduardo Habkost wrote: >>> Use the SCLP_EVENT_BUS macro instead of manually calling >>> OBJECT_CHECK. >>> >>> Signed-off-by: Eduardo Habkost >>> --- >>> Cc: Cornelia Huck >>> Cc: Thomas

Re: [PULL 0/2] Linux user for 6.1 patches

2021-08-06 Thread Peter Maydell
--- > linux-user pull request 20210806 > > Fix endianness and addresses in i386 linux-user target > Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/6.1 for any user-visible changes. -- PMM

[PATCH] qapi: Fix crash on redefinition with a different condition

2021-08-06 Thread Markus Armbruster
QAPISchema._make_implicit_object_type() asserts that when an implicit object type is used multiple times, @ifcond is the same for all uses. It will be for legitimate uses, i.e. simple union branch wrapper types. A comment explains this. The assertion fails when a command or event is redefined wit

Re: [PATCH] bcm2836: Remove redundant typedef and macros

2021-08-06 Thread Daniel P . Berrangé
On Thu, Aug 05, 2021 at 05:47:39PM -0400, Eduardo Habkost wrote: > commit 58b350280e97 ("hw/arm/bcm2836: Restrict BCM283XInfo > declaration to C source") didn't just move the struct > BCM283XClass definition to bcm2836.c. It also introduced a > typedef (BCM283XClass) and two type checking macros >

Re: [RFC PATCH v4 1/4] Add options to config/meson files for custom CSR

2021-08-06 Thread Jessica Clarke
> On Fri, Aug 6, 2021 at 10:39 AM Bin Meng wrote: > > > > On Fri, Aug 6, 2021 at 1:57 AM Ruinland Chuan-Tzu Tsai > > wrote: > > > > > > From: Ruinland ChuanTzu Tsai > > > > > > Adding option `riscv_custom` to configure script, meson.build and > > > meson_options.txt so as to toggle custom CSR an

[RFC PATCH v4 4/4] Enable custom CSR logic for Andes AX25 and A25

2021-08-06 Thread Jessica Clarke
> From: Ruinalnd ChuanTzu Tsai > > In this patch we enabled custom CSR logic for Andes AX25 and A25 logic. > Hence csr_andes.inc.c and andes_cpu_bits.h is added. > > Signed-off-by: Dylan Jhong > --- > target/riscv/andes_cpu_bits.h | 124 + > target/riscv/cpu.c

Re: [PATCH v7 04/10] hw/intc: GICv3 ITS Command processing

2021-08-06 Thread shashi . mallela
Thanks for sharing the observations Neil. Will take care of it in the next patch-set. On Fri, 2021-08-06 at 10:58 +0200, Neil Armstrong wrote: > Hi, > > On 06/08/2021 00:29, Shashi Mallela wrote: > > Added ITS command queue handling for MAPTI,MAPI commands,handled > > ITS > > translation which tr

Re: [PATCH v7 04/10] hw/intc: GICv3 ITS Command processing

2021-08-06 Thread Neil Armstrong
Hi, On 06/08/2021 00:29, Shashi Mallela wrote: > Added ITS command queue handling for MAPTI,MAPI commands,handled ITS > translation which triggers an LPI via INT command as well as write > to GITS_TRANSLATER register,defined enum to differentiate between ITS > command interrupt trigger and GITS_TR

Re: [RFC PATCH v4 4/4] Enable custom CSR logic for Andes AX25 and A25

2021-08-06 Thread Jessica Clarke
On 6 Aug 2021, at 14:06, Jessica Clarke wrote: > >> From: Ruinalnd ChuanTzu Tsai >> >> In this patch we enabled custom CSR logic for Andes AX25 and A25 logic. >> Hence csr_andes.inc.c and andes_cpu_bits.h is added. >> >> Signed-off-by: Dylan Jhong >> --- >> target/riscv/andes_cpu_bits.h | 12

Re: [PATCH v1 12/12] hw/s390x/s390-skeys: lazy storage key enablement under TCG

2021-08-06 Thread David Hildenbrand
On 06.08.21 11:42, Thomas Huth wrote: On 05/08/2021 17.28, David Hildenbrand wrote: Let's enable storage keys lazily under TCG, just as we do under KVM. Only fairly old Linux versions actually make use of storage keys, so it can be kind of wasteful to allocate quite some memory and track changes

Re: [PATCH v1 12/12] hw/s390x/s390-skeys: lazy storage key enablement under TCG

2021-08-06 Thread Thomas Huth
On 06/08/2021 15.18, David Hildenbrand wrote: On 06.08.21 11:42, Thomas Huth wrote: On 05/08/2021 17.28, David Hildenbrand wrote: Let's enable storage keys lazily under TCG, just as we do under KVM. Only fairly old Linux versions actually make use of storage keys, so it can be kind of wasteful

Re: [RFC PATCH v4 1/4] Add options to config/meson files for custom CSR

2021-08-06 Thread Bin Meng
On Fri, Aug 6, 2021 at 8:58 PM Jessica Clarke wrote: > > > On Fri, Aug 6, 2021 at 10:39 AM Bin Meng wrote: > > > > > > On Fri, Aug 6, 2021 at 1:57 AM Ruinland Chuan-Tzu Tsai > > > wrote: > > > > > > > > From: Ruinland ChuanTzu Tsai > > > > > > > > Adding option `riscv_custom` to configure scrip

Re: [PATCH v3] hw/acpi: add an assertion check for non-null return from acpi_get_i386_pci_host

2021-08-06 Thread Philippe Mathieu-Daudé
On 8/6/21 12:52 PM, Ani Sinha wrote: > On Fri, 6 Aug 2021, Igor Mammedov wrote: >> On Thu, 5 Aug 2021 19:42:35 +0530 (IST) >> Ani Sinha wrote: >>> On Thu, 5 Aug 2021, Ani Sinha wrote: On Thu, 5 Aug 2021, Ani Sinha wrote: > On Thu, 5 Aug 2021, Igor Mammedov wrote: >> On Mon, 26 Jul 202

Re: [RFC PATCH v4 1/4] Add options to config/meson files for custom CSR

2021-08-06 Thread Jessica Clarke
On 6 Aug 2021, at 14:54, Bin Meng wrote: > On Fri, Aug 6, 2021 at 8:58 PM Jessica Clarke wrote: >> >>> On Fri, Aug 6, 2021 at 10:39 AM Bin Meng wrote: On Fri, Aug 6, 2021 at 1:57 AM Ruinland Chuan-Tzu Tsai wrote: > > From: Ruinland ChuanTzu Tsai > > Adding op

Re: [PATCH] target/i386: VMRUN and VMLOAD canonicalizations

2021-08-06 Thread Paolo Bonzini
On 04/08/21 13:30, Lara Lazier wrote: APM2 requires that VMRUN and VMLOAD canonicalize (sign extend to 63 from 48/57) all base addresses in the segment registers that have been respectively loaded. Signed-off-by: Lara Lazier --- target/i386/cpu.c | 19 +++ t

[PATCH v1 3/4] gitlab-ci: Remove superfluous "dnf install" statement

2021-08-06 Thread Alex Bennée
From: Thomas Huth The container already features meson and ninja, so there is no need to try to install it with dnf again. Signed-off-by: Thomas Huth Reviewed-by: Willian Rampazzo Message-Id: <20210730143809.717079-3-th...@redhat.com> Signed-off-by: Alex Bennée --- .gitlab-ci.d/buildtest.yml

[PATCH for 6.1-rc3 v1 0/4] gitlab and plugins pre-PR

2021-08-06 Thread Alex Bennée
Hi, There isn't much in my queue but I figured I best post it now so I can cut a PR from it next week. I'll be off most of August so this will likely be the last PR for 6.1 from me. Mahmoud Mandour (1): plugins/execlog: removed unintended "s" at the end of log lines. Thomas Huth (3): gitlab-

[PATCH v1 4/4] gitlab-ci: Fix ..._RUNNER_AVAILABLE variables and document them

2021-08-06 Thread Alex Bennée
From: Thomas Huth The patch that recently introduced the S390X_RUNNER_AVAILABLE variable in custom-runners.yml missed that the bottom half of the file is rather about aarch64 than s390x. Thus rename the S390X_RUNNER_AVAILABLE to AARCH64_RUNNER_AVAILABLE in those jobs. Finally mention both variab

[PATCH v1 1/4] plugins/execlog: removed unintended "s" at the end of log lines.

2021-08-06 Thread Alex Bennée
From: Mahmoud Mandour Signed-off-by: Mahmoud Mandour Signed-off-by: Alex Bennée Message-Id: <20210803151428.125323-1-ma.mando...@gmail.com> --- contrib/plugins/execlog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/plugins/execlog.c b/contrib/plugins/execlog.c in

[PATCH v1 2/4] gitlab-ci: Merge "build-disabled" with "build-without-default-features"

2021-08-06 Thread Alex Bennée
From: Thomas Huth Both jobs are testing more or less the same thing (building QEMU with features disabled), so we are wasting precious CI cycles here by doing this twice. Merge the jobs by using --without-default-features by default and just adding some additional --disable-... switches which are

Re: [PATCH v1 12/12] hw/s390x/s390-skeys: lazy storage key enablement under TCG

2021-08-06 Thread Cornelia Huck
On Fri, Aug 06 2021, David Hildenbrand wrote: > On 06.08.21 11:42, Thomas Huth wrote: >> On 05/08/2021 17.28, David Hildenbrand wrote: >>> -static void qemu_s390_skeys_init(Object *obj) >>> +static int qemu_s390_skeys_enabled(S390SKeysState *ss) >>>{ >>> -QEMUS390SKeysState *skeys = QEMU_

Re: [PATCH v3 01/10] virtiofsd: Limit setxattr()'s creds-dropped region

2021-08-06 Thread Vivek Goyal
On Fri, Jul 30, 2021 at 05:01:25PM +0200, Max Reitz wrote: > We only need to drop/switch our credentials for the (f)setxattr() call > alone, not for the openat() or fchdir() around it. > > (Right now, this may not be that big of a problem, but with inodes being > identified by file handles instead

Re: [PATCH v1] s390x/ioinst: Fix wrong MSCH alignment check on little endian

2021-08-06 Thread Philippe Mathieu-Daudé
On 8/6/21 1:30 PM, David Hildenbrand wrote: > On 06.08.21 13:19, Cornelia Huck wrote: >> On Thu, Aug 05 2021, David Hildenbrand wrote: >> >>> schib->pmcw.chars is 32bit, not 16bit. This fixes the kvm-unit-tests >>> "css" test, which fails with: >>> >>>    FAIL: Channel Subsystem: measurement block

Re: [PATCH v1 12/12] hw/s390x/s390-skeys: lazy storage key enablement under TCG

2021-08-06 Thread Thomas Huth
On 06/08/2021 16.13, Cornelia Huck wrote: On Fri, Aug 06 2021, David Hildenbrand wrote: On 06.08.21 11:42, Thomas Huth wrote: On 05/08/2021 17.28, David Hildenbrand wrote: -static void qemu_s390_skeys_init(Object *obj) +static int qemu_s390_skeys_enabled(S390SKeysState *ss) { -QEMUS3

Re: [PATCH v8] tests/tcg/s390x: Test SIGILL and SIGSEGV handling

2021-08-06 Thread Alex Bennée
Ilya Leoshkevich writes: > Verify that s390x-specific uc_mcontext.psw.addr is reported correctly > and that signal handling interacts properly with debugging. > > Signed-off-by: Ilya Leoshkevich Acked-by: Alex Bennée > --- > > v7: https://lists.nongnu.org/archive/html/qemu-devel/2021-08/msg

Re: [PATCH v1] s390x/ioinst: Fix wrong MSCH alignment check on little endian

2021-08-06 Thread David Hildenbrand
On 06.08.21 16:17, Philippe Mathieu-Daudé wrote: On 8/6/21 1:30 PM, David Hildenbrand wrote: On 06.08.21 13:19, Cornelia Huck wrote: On Thu, Aug 05 2021, David Hildenbrand wrote: schib->pmcw.chars is 32bit, not 16bit. This fixes the kvm-unit-tests "css" test, which fails with:    FAIL: Cha

Re: [PATCH v3 02/10] virtiofsd: Add TempFd structure

2021-08-06 Thread Vivek Goyal
On Fri, Jul 30, 2021 at 05:01:26PM +0200, Max Reitz wrote: > We are planning to add file handles to lo_inode objects as an > alternative to lo_inode.fd. That means that everywhere where we > currently reference lo_inode.fd, we will have to open a temporary file > descriptor that needs to be closed

Re: [PATCH v2] hw/display/xlnx_dp: fix an out-of-bounds read in xlnx_dp_read

2021-08-06 Thread Alexander Bulekov
On 210804 1451, Qiang Liu wrote: > xlnx_dp_read allows an out-of-bounds read at its default branch because > of an improper index. > > According to > https://www.xilinx.com/html_docs/registers/ug1087/ug1087-zynq-ultrascale-registers.html > (DP Module), registers 0x3A4/0x3A4/0x3AC are allowed. > >

[PATCH] vhost-user: add missing space in error message

2021-08-06 Thread Alyssa Ross
This would previously give error messages like > Received unexpected msg type.Expected 0 received 1 Signed-off-by: Alyssa Ross --- hw/virtio/vhost-user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c index 29ea2b4fce..ad9fc40

[PATCH] hw/char/pl011: add support for sending break

2021-08-06 Thread Jan Luebbe
Break events are currently only handled by chardev/char-serial.c, so we just ignore errors, which results in no behaviour change for other chardevs. Signed-off-by: Jan Luebbe --- hw/char/pl011.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/char/pl011.c b/hw/char/pl011.c index dc8

Re: [PATCH v1] s390x/ioinst: Fix wrong MSCH alignment check on little endian

2021-08-06 Thread Cornelia Huck
On Fri, Aug 06 2021, David Hildenbrand wrote: > On 06.08.21 16:17, Philippe Mathieu-Daudé wrote: >> On 8/6/21 1:30 PM, David Hildenbrand wrote: >>> On 06.08.21 13:19, Cornelia Huck wrote: On Thu, Aug 05 2021, David Hildenbrand wrote: > schib->pmcw.chars is 32bit, not 16bit. This fi

[PATCH] meson: fix logic for gnutls check

2021-08-06 Thread Alyssa Ross
The logic before was if not get_option('gnutls').auto() or have_system Which is equivalent to if get_option('gnutls').enabled() or get_option('gnutls').disabled() or have_system This means that the check for gnutls is performed even if gnutls is disabled, which means that the b

[PATCH 1/6] docs/about/removed-features: Document removed CLI options from QEMU v2.12

2021-08-06 Thread Thomas Huth
These CLI options had been removed/replaced in QEMU v2.12. Still, some people might want to update from older versions to the recent QEMU version, so we should give some recommendations for the replacements in our documentation. Signed-off-by: Thomas Huth --- docs/about/removed-features.rst | 37

  1   2   3   >