Question about delaying dirty log stop to next vm_start

2021-08-02 Thread Yi Sun
Hi, Jay, We are testing some live migration cases recently. We found your below patch delays the dirty log stop to the next vm_start. commit 1931076077254a2886daa7c830c7838ebd1f81ef Author: Jay Zhou Date: Fri Jul 28 18:28:53 2017 +0800 migration: optimize the downtime We understand this

Re: [PATCH v3] target/i386: Added VGIF feature

2021-08-02 Thread Paolo Bonzini
On 30/07/21 09:07, Lara Lazier wrote: v2->v3: moved guest check into virtual_gif_enabled VGIF allows STGI and CLGI to execute in guest mode and control virtual interrupts in guest mode. When the VGIF feature is enabled then: * executing STGI in the guest sets bit 9 of the VMCB offset 60h. *

Re: "make check-acceptance" takes way too long

2021-08-02 Thread Daniel P . Berrangé
On Fri, Jul 30, 2021 at 04:12:27PM +0100, Peter Maydell wrote: > "make check-acceptance" takes way way too long. I just did a run > on an arm-and-aarch64-targets-only debug build and it took over > half an hour, and this despite it skipping or cancelling 26 out > of 58 tests! > > I think that ~10

Re: [PATCH 1/2] virtio: add a way to disable a queue

2021-08-02 Thread Laurent Vivier
On 02/08/2021 06:50, Jason Wang wrote: > > 在 2021/7/30 上午3:19, Laurent Vivier 写道: >> Add virtio_queue_disable()/virtio_queue_enable() to disable/enable a queue >> by setting vring.num to 0 (or num_default). >> This is needed to be able to disable a guest driver from the host side > > > I suspect

Re: migration-test hang, s390x host, aarch64 guest

2021-08-02 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > migration-test hung again during 'make check'. ccing in Peter Xu > Process tree: > > ubuntu 42067 0.0 0.0 5460 3156 ?S13:55 0:00 >\_ bash -o pipefail -c echo > 'MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0

[PATCH v2] hw/pcie-root-port: Fix hotplug for PCI devices requiring IO

2021-08-02 Thread Marcel Apfelbaum
Q35 has now ACPI hotplug enabled by default for PCI(e) devices. As opposed to native PCIe hotplug, guests like Fedora 34 will not assign IO range to pcie-root-ports not supporting native hotplug, resulting into a regression. Reproduce by: qemu-bin -M q35 -device pcie-root-port,id=p1 -monitor s

Re: Windows on ARM64 not able to use attached TPM 2

2021-08-02 Thread Philippe Mathieu-Daudé
Cc'ing Marc-André who is your EDK2 co-maintainer. On 8/1/21 2:28 AM, Stefan Berger wrote: > Hello! > >  I maintain the TPM support in QEMU and the TPM emulator (swtpm). I have > a report from a user who would like to use QEMU on ARM64 (aarch64) with > EDK2 and use an attached TPM 2 but it doesn't

Re: [PATCH v2] hw/pcie-root-port: Fix hotplug for PCI devices requiring IO

2021-08-02 Thread Daniel P . Berrangé
On Mon, Aug 02, 2021 at 12:00:57PM +0300, Marcel Apfelbaum wrote: > Q35 has now ACPI hotplug enabled by default for PCI(e) devices. > As opposed to native PCIe hotplug, guests like Fedora 34 > will not assign IO range to pcie-root-ports not supporting > native hotplug, resulting into a regression.

Re: QEMU on x64

2021-08-02 Thread Paolo Bonzini
On 30/07/21 19:36, Christopher Caulfield wrote: Hi QEMU community, This is Christopher from the debugging experiences team at Microsoft focused on kernel debugging. I am reaching out with a few questions about QEMU on x64. 1. Is it possible for the QEMU-x86-64 GDB Server to send the full se

Re: [PATCH v4 02/13] plugins/api: added a boolean parsing plugin api

2021-08-02 Thread Alex Bennée
Mahmoud Mandour writes: > This call will help boolean argument parsing since arguments are now > passed to plugins as a name and value. > > Signed-off-by: Mahmoud Mandour Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH v6 02/11] qapi: wrap Sequence[str] in an object

2021-08-02 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Except for the special casing assert in _make_implicit_object_type(), > which needs to handle schema objects, it's a mechanical change. > > Signed-off-by: Marc-André Lureau > --- > docs/sphinx/qapidoc.py | 10 +++--- > sc

Re: [PATCH-for-6.1?] target/mips: Remove MOVZ/MOVN opcodes from Loongson 2E

2021-08-02 Thread Philippe Mathieu-Daudé
On 7/31/21 4:41 PM, Philippe Mathieu-Daudé wrote: > Per the "Godson-2E User Manual v0.6", the Loongson 2E processor > does not implement the MOVZ/MOVN instructions I'm confused because I can't find MOVZ/MOVN in the 2E manual and the 2F explicits the difference. However looking at binutils, these o

Re: [PATCH-for-6.1 1/3] hw/sd/sdcard: Document out-of-range addresses for SEND_WRITE_PROT

2021-08-02 Thread Alexander Bulekov
On 210728 2017, Philippe Mathieu-Daudé wrote: > Per the 'Physical Layer Simplified Specification Version 3.01', > Table 4-22: 'Block Oriented Write Protection Commands' > > SEND_WRITE_PROT (CMD30) > > If the card provides write protection features, this command asks > the card to send the s

Re: [PATCH-for-6.2 3/3] hw/sd/sdcard: Rename Write Protect Group variables

2021-08-02 Thread Alexander Bulekov
On 210728 2017, Philippe Mathieu-Daudé wrote: > 'wp_groups' holds a bitmap, rename it as 'wp_group_bmap'. > 'wpgrps_size' is the bitmap size (in bits), rename it as > 'wp_group_bits'. > > Patch created mechanically using: > > $ sed -i -e s/wp_groups/wp_group_bmap/ \ >-e s/wpgrps_siz

Re: Windows on ARM64 not able to use attached TPM 2

2021-08-02 Thread Eric Auger
and also adding Ard if he is aware of any limitation the TPM2 integration may suffer for Windows support. On my end I am only able to test on Linux atm. Thanks Eric On 8/2/21 11:04 AM, Philippe Mathieu-Daudé wrote: > Cc'ing Marc-André who is your EDK2 co-maintainer. > > On 8/1/21 2:28 AM, Stefan

Re: [PATCH v6 03/11] qapi: add QAPISchemaIfCond.is_present()

2021-08-02 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > docs/sphinx/qapidoc.py | 8 > scripts/qapi/schema.py | 7 +-- > tests/qapi-schema/test-qapi.py | 2 +- > 3 files changed, 10 insertions(+), 7 deletions(-) > >

Re: [PATCH] hw/char/virtio-serial-bus: fix: Unpop throttled VirtQueueElement to queue before discard vq data

2021-08-02 Thread Stefan Hajnoczi
On Fri, Jul 30, 2021 at 01:58:41AM +, AIERPATIJIANG1 [艾尔帕提江·阿布都赛买提] wrote: > Ports enter a "throttled" state when writing to the chardev would block. > The current output VirtQueueElement is kept around until the chardev > becomes writable again. > > Because closing the virtio serial device do

Re: [PATCH for-6.1? v2 5/7] job: Add job_cancel_requested()

2021-08-02 Thread Max Reitz
On 27.07.21 17:47, Vladimir Sementsov-Ogievskiy wrote: 27.07.2021 18:39, Max Reitz wrote: On 27.07.21 15:04, Vladimir Sementsov-Ogievskiy wrote: 26.07.2021 17:46, Max Reitz wrote: Most callers of job_is_cancelled() actually want to know whether the job is on its way to immediate termination. 

Re: [PATCH v6 04/11] qapi: _make_enum_members() to work with pre-built QAPISchemaIfCond

2021-08-02 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Instead of lowering the expression back to its original form, and having > to convert it again, special-case the 'if' condition to be pre-built. > > Signed-off-by: Marc-André Lureau > --- > scripts/qapi/schema.py | 11 ---

Re: [PULL 0/5] Net patches

2021-08-02 Thread Peter Maydell
On Mon, 2 Aug 2021 at 05:33, Jason Wang wrote: > > The following changes since commit 0c633cf0c221922a0a9f9d0b8866cbb111f5e192: > > Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-tcg-20210730' > into staging (2021-07-31 21:29:57 +0100) > > are available in the git repository at: > >

Re: [PATCH-for-6.1 2/3] hw/sd/sdcard: Fix assertion accessing out-of-range addresses with CMD30

2021-08-02 Thread Philippe Mathieu-Daudé
Peter, Bin, could you review this (trivial) patch? This is a regression since 6.1 I'd like to get fixed for v6.1.0-rc2. On 7/28/21 8:17 PM, Philippe Mathieu-Daudé wrote: > OSS-Fuzz found sending illegal addresses when querying the write > protection bits triggers the assertion added in commit 8481

Re: [PATCH v4 06/13] plugins/hwprofile: adapt to the new plugin arguments scheme

2021-08-02 Thread Alex Bennée
Mahmoud Mandour writes: > Parsing boolean arguments correctly (e.g. pattern=on or source=false). > Introduced a new "track" argument that takes a [read|write] value. This > substitutes passing read or write to "arg=" that is deprecated. > > Also, matches are now taken one by one through the "ma

Re: [PATCH v4 13/13] docs/deprecated: deprecate passing plugin args through `arg=`

2021-08-02 Thread Alex Bennée
Mahmoud Mandour writes: > Signed-off-by: Mahmoud Mandour > --- > docs/system/deprecated.rst | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst > index e2e0090878..7ae6f1f727 100644 > --- a/docs/system/deprecated.rst > +++ b/

Re: [PATCH v3 0/5] plugins/cache: multicore cache modelling and minor tweaks

2021-08-02 Thread Alex Bennée
Mahmoud Mandour writes: > Hello, > > This series introduce some minor improvements/bug fixes in the cache > plugins and multicore cache modelling. > > Multi-core cache modelling is handled such that for full-system > emulation, a private L1 cache is maintained to each core available to > the sy

[PULL 00/21] target-arm queue

2021-08-02 Thread Peter Maydell
t repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20210802 for you to fetch changes up to 4a64939db76b10d8d41d2af3c6aad8142da55450: docs: Move user-facing barrier docs into system manual (2021-08-02

[PULL 09/21] docs/devel/ebpf_rss.rst: Format literals correctly

2021-08-02 Thread Peter Maydell
In rST markup, single backticks `like this` represent "interpreted text", which can be handled as a bunch of different things if tagged with a specific "role": https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#interpreted-text (the most common one for us is "reference to a URL, whi

[PULL 01/21] docs: Add documentation of Arm 'mainstone' board

2021-08-02 Thread Peter Maydell
Add brief documentation of the Arm 'mainstone' board. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Message-id: 20210722175229.29065-2-peter.mayd...@linaro.org --- docs/system/arm/mainstone.rst | 25 + docs/system/target-arm.rst| 1 + MAINTAINERS

[PULL 20/21] ui/input-barrier: Move TODOs from barrier.txt to a comment

2021-08-02 Thread Peter Maydell
docs/barrier.txt has a couple of TODO notes about things to be implemented in this device; move them into a comment in the source code. Signed-off-by: Peter Maydell Reviewed-by: Paolo Bonzini Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Message-id: 20210727204112.12579-3-pet

[PULL 04/21] MAINTAINERS: Don't list Andrzej Zaborowski for various components

2021-08-02 Thread Peter Maydell
Andrzej Zaborowski is listed as an "Odd Fixes" maintainer for the nSeries, Palm and PXA2XX boards, as well as the "Maintained" status Arm 32-bit TCG backend. Andrzej's last email to qemu-devel was back in 2017, and the email before that was all the way back in 2013. We don't really need to fill h

[PULL 02/21] docs: Add documentation of Arm 'kzm' board

2021-08-02 Thread Peter Maydell
Add brief documentation of the Arm 'kzm' board. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Message-id: 20210722175229.29065-3-peter.mayd...@linaro.org --- docs/system/arm/kzm.rst| 18 ++ docs/system/target-arm.rst | 1 + MAINTAINERS| 1 + 3

[PULL 10/21] docs/devel/migration.rst: Format literals correctly

2021-08-02 Thread Peter Maydell
In rST markup, single backticks `like this` represent "interpreted text", which can be handled as a bunch of different things if tagged with a specific "role": https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#interpreted-text (the most common one for us is "reference to a URL, whi

[PULL 18/21] docs: Move bootindex.txt into system section and rstify

2021-08-02 Thread Peter Maydell
Move bootindex.txt into the system section of the manual and turn it into rST format. To make the document make more sense in the context of the system manual, expand the title and introductory paragraphs to give more context. Signed-off-by: Peter Maydell Reviewed-by: Markus Armbruster Message-

[PULL 03/21] docs: Add documentation of Arm 'imx25-pdk' board

2021-08-02 Thread Peter Maydell
Add brief documentation of the Arm 'imx25-pdk' board. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Message-id: 20210722175229.29065-4-peter.mayd...@linaro.org --- docs/system/arm/imx25-pdk.rst | 19 +++ docs/system/target-arm.rst| 1 + MAINTAINERS

[PULL 11/21] docs/devel: Format literals correctly

2021-08-02 Thread Peter Maydell
In rST markup, single backticks `like this` represent "interpreted text", which can be handled as a bunch of different things if tagged with a specific "role": https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#interpreted-text (the most common one for us is "reference to a URL, whi

[PULL 05/21] docs: Remove stale TODO comments about license and version

2021-08-02 Thread Peter Maydell
Since commits 13f934e79fa and 3a50c8f3067aaf, our HTML docs include a footer to all pages stating the license and version. We can therefore delete the TODO comments suggesting we should do that from our .rst files. Signed-off-by: Peter Maydell Reviewed-by: Marc-André Lureau Reviewed-by: Cleber

[PULL 08/21] docs/devel/build-system.rst: Correct typo in example code

2021-08-02 Thread Peter Maydell
One of the example meson.build fragments incorrectly quotes some symbols as 'CONFIG_FOO`; the correct syntax here is 'CONFIG_FOO'. (This isn't a rST formatting mistake because the example is displayed literally; it's just the wrong kind of quote.) Signed-off-by: Peter Maydell Reviewed-by: Richard

[PULL 06/21] docs: Move licence/copyright from HTML output to rST comments

2021-08-02 Thread Peter Maydell
Our built HTML documentation now has a standard footer which gives the license for QEMU (and its documentation as a whole). In almost all pages, we either don't bother to state the copyright/license for the individual rST sources, or we put it in an rST comment. There are just three pages which ren

[PULL 15/21] docs/about/removed-features: Fix markup error

2021-08-02 Thread Peter Maydell
The section describing the removed feature "-usbdevice ccid" had a typo so the markup started with single backtick and ended with double backtick; fix it. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-id: 20210726142338.31872-10-peter.ma

[PULL 12/21] docs/system/s390x/protvirt.rst: Format literals correctly

2021-08-02 Thread Peter Maydell
In rST markup, single backticks `like this` represent "interpreted text", which can be handled as a bunch of different things if tagged with a specific "role": https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#interpreted-text (the most common one for us is "reference to a URL, whi

[PULL 07/21] docs/devel/build-system.rst: Format literals correctly

2021-08-02 Thread Peter Maydell
In rST markup, single backticks `like this` represent "interpreted text", which can be handled as a bunch of different things if tagged with a specific "role": https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#interpreted-text (the most common one for us is "reference to a URL, whi

Re: [PATCH-for-6.1 1/3] hw/sd/sdcard: Document out-of-range addresses for SEND_WRITE_PROT

2021-08-02 Thread Peter Maydell
On Wed, 28 Jul 2021 at 19:18, Philippe Mathieu-Daudé wrote: > > Per the 'Physical Layer Simplified Specification Version 3.01', > Table 4-22: 'Block Oriented Write Protection Commands' > > SEND_WRITE_PROT (CMD30) > > If the card provides write protection features, this command asks > the car

[PULL 13/21] docs/system/arm/cpu-features.rst: Format literals correctly

2021-08-02 Thread Peter Maydell
In rST markup, single backticks `like this` represent "interpreted text", which can be handled as a bunch of different things if tagged with a specific "role": https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#interpreted-text (the most common one for us is "reference to a URL, whi

[PULL 14/21] docs: Format literals correctly

2021-08-02 Thread Peter Maydell
In rST markup, single backticks `like this` represent "interpreted text", which can be handled as a bunch of different things if tagged with a specific "role": https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#interpreted-text (the most common one for us is "reference to a URL, whi

[PULL 16/21] docs/tools/virtiofsd.rst: Delete stray backtick

2021-08-02 Thread Peter Maydell
The documentation of the posix_acl option has a stray backtick at the end of the text (which is rendered literally into the HTML). Delete it. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Acked-by: Dr. David Alan Gilbert Message-id: 20210726142

[PULL 21/21] docs: Move user-facing barrier docs into system manual

2021-08-02 Thread Peter Maydell
The remaining text in docs/barrier.txt is user-facing description of what the device is and how to use it. Move this into the system manual and rstify it. Signed-off-by: Peter Maydell Reviewed-by: Paolo Bonzini Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Message-id: 2021072

[PULL 17/21] hw/arm/boot: Report error if there is no fw_cfg device in the machine

2021-08-02 Thread Peter Maydell
If the user provides both a BIOS/firmware image and also a guest kernel filename, arm_setup_firmware_boot() will pass the kernel image to the firmware via the fw_cfg device. However we weren't checking whether there really was a fw_cfg device present, and if there wasn't we would crash. This crash

Re: [PATCH for-6.2 01/10] docs: qom: Replace old GTK-Doc #symbol syntax with `symbol`

2021-08-02 Thread Peter Maydell
On Thu, 29 Jul 2021 at 19:00, Eduardo Habkost wrote: > > Replace leftover of GTK-Doc #name syntax with `name`, and use > default-role:: any, so we can add references to other functions, > types, and macros. > > There are 3 cases that required extra care: > - #TypeInfo.class_init: kernel-doc doesn'

Re: [PATCH for-6.2 05/10] docs: qom: Add subsection headings to declaration/definition macros section

2021-08-02 Thread Peter Maydell
On Thu, 29 Jul 2021 at 19:01, Eduardo Habkost wrote: > > Add two new subsection headings to make the separation between > "declaration macros" and "definition macros" more visible. > > Signed-off-by: Eduardo Habkost > --- > docs/devel/qom.rst | 6 ++ > 1 file changed, 6 insertions(+) Review

[PULL 19/21] docs: Move the protocol part of barrier.txt into interop

2021-08-02 Thread Peter Maydell
Most of docs/barrier.txt is describing the protocol implemented by the input-barrier device. Move this into the interop section of the manual, and rstify it. Signed-off-by: Peter Maydell Reviewed-by: Paolo Bonzini Reviewed-by: Laurent Vivier Message-id: 20210727204112.12579-2-peter.mayd...@lina

Re: [PATCH for-6.2 03/10] docs: qom: Fix autoptr expansion example

2021-08-02 Thread Peter Maydell
On Thu, 29 Jul 2021 at 18:59, Eduardo Habkost wrote: > > The wrong type name was being used. The autoptr cleanup function > will be declared for the instance type, not the class type. > > Signed-off-by: Eduardo Habkost > --- > docs/devel/qom.rst | 2 +- > 1 file changed, 1 insertion(+), 1 delet

Re: [PATCH for-6.2 06/10] docs: qom: Remove unnecessary class typedefs from example

2021-08-02 Thread Peter Maydell
On Thu, 29 Jul 2021 at 19:01, Eduardo Habkost wrote: > > When there's no specific class struct used for a QOM type, we > normally don't define a typedef for it. Remove the typedef from > the minimal example, as it is unnecessary. > > Signed-off-by: Eduardo Habkost > --- > docs/devel/qom.rst | 3

Re: [PATCH-for-6.1?] target/mips: Remove MOVZ/MOVN opcodes from Loongson 2E

2021-08-02 Thread Maciej W. Rozycki
On Mon, 2 Aug 2021, Philippe Mathieu-Daudé wrote: > > Per the "Godson-2E User Manual v0.6", the Loongson 2E processor > > does not implement the MOVZ/MOVN instructions > > I'm confused because I can't find MOVZ/MOVN in the 2E manual and > the 2F explicits the difference. However looking at binuti

Re: [PATCH-for-6.1 2/3] hw/sd/sdcard: Fix assertion accessing out-of-range addresses with CMD30

2021-08-02 Thread Peter Maydell
On Wed, 28 Jul 2021 at 19:19, Philippe Mathieu-Daudé wrote: > > OSS-Fuzz found sending illegal addresses when querying the write > protection bits triggers the assertion added in commit 84816fb63e5 > ("hw/sd/sdcard: Assert if accessing an illegal group"): > > qemu-fuzz-i386-target-generic-fuzz-s

Re: Windows on ARM64 not able to use attached TPM 2

2021-08-02 Thread Ard Biesheuvel
On Mon, 2 Aug 2021 at 11:51, Eric Auger wrote: > > and also adding Ard if he is aware of any limitation the TPM2 > integration may suffer for Windows support. On my end I am only able to > test on Linux atm. > I never tested Windows with the TPM2 support, so I cannot answer this, unfortunately.

Re: [PATCH-for-6.1 0/3] hw/sd/sdcard: Fix assertion accessing out-of-range addresses with CMD30

2021-08-02 Thread Peter Maydell
On Wed, 28 Jul 2021 at 19:17, Philippe Mathieu-Daudé wrote: > > Fix an assertion reported by OSS-Fuzz, add corresponding qtest. > > The change simple enough for the next rc. > > Philippe Mathieu-Daudé (3): > hw/sd/sdcard: Document out-of-range addresses for SEND_WRITE_PROT > hw/sd/sdcard: Fix

Re: [PATCH for-6.2 08/10] docs: qom: Show actual typecast functions in examples

2021-08-02 Thread Peter Maydell
On Thu, 29 Jul 2021 at 19:03, Eduardo Habkost wrote: > > For clarity and to avoid encouraging people to copy the examples, > show the actual typecast functions being defined by > OBJECT_DECLARE* macros in the examples. > > Signed-off-by: Eduardo Habkost > --- > docs/devel/qom.rst | 24 ++

Re: [PATCH for-6.2 09/10] docs: qom: Remove OBJECT_CHECK macro examples

2021-08-02 Thread Peter Maydell
On Thu, 29 Jul 2021 at 19:05, Eduardo Habkost wrote: > > We shouldn't encourage people to keep defining typecast macros > manually, when we have the OBJECT_DECLARE* macros. Remove the > section showing how to define them, and replace with a section > explaining how typecasting works. > > Signed-o

Re: [PATCH for-6.2 10/10] MAINTAINERS: Add qom.rst to QOM section

2021-08-02 Thread Peter Maydell
On Thu, 29 Jul 2021 at 19:05, Eduardo Habkost wrote: > > Add qom.rst to the QOM section of MAINTAINERS. > > Signed-off-by: Eduardo Habkost > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 42ac45c3e50..dc3f04242eb 100644 > --- a/MAINTA

Re: [PATCH for-6.2 04/10] docs: qom: Fix "API Reference" heading level

2021-08-02 Thread Peter Maydell
On Thu, 29 Jul 2021 at 18:58, Eduardo Habkost wrote: > > The API reference section was being rendered as a subsection of > the "Standard type declaration and definition macros" subsection. > Fix that. > > Signed-off-by: Eduardo Habkost > --- > docs/devel/qom.rst | 2 +- > 1 file changed, 1 inser

Re: [PATCH 1/6] coverity-model: update address_space_read/write models

2021-08-02 Thread Peter Maydell
On Sat, 31 Jul 2021 at 07:29, Paolo Bonzini wrote: > > Use void * for consistency with the actual function; provide a model > for MemoryRegionCache functions and for address_space_rw. These > let Coverity understand the bounds of the data that various functions > read and write even at very high

Re: [PATCH 2/6] coverity-model: make g_free a synonym of free

2021-08-02 Thread Peter Maydell
On Sat, 31 Jul 2021 at 07:29, Paolo Bonzini wrote: > > Recently, Coverity has started complaining about using g_free() to free > memory areas allocated by GLib functions not included in model.c, > such as g_strfreev. This unfortunately goes against the GLib > documentation, which suggests that g_

Re: [PATCH for-6.2 07/10] docs: qom: Fix OBJECT_DECLARE_SIMPLE_TYPE documentation

2021-08-02 Thread Peter Maydell
On Thu, 29 Jul 2021 at 19:03, Eduardo Habkost wrote: > > The OBJECT_DECLARE_SIMPLE_TYPE documentation was inaccurate: it > doesn't define a class struct or class type checking helpers. > > OBJECT_DECLARE_TYPE expansion looks very similar to the existing > example, though. Rewrite that section to

Re: [PATCH 3/6] coverity-model: remove model for more allocation functions

2021-08-02 Thread Peter Maydell
On Sat, 31 Jul 2021 at 07:29, Paolo Bonzini wrote: > > These models are not needed anymore now that Coverity does not check > anymore that the result is used with "g_free". Coverity understands > GCC attributes and uses them to detect leaks. > > Signed-off-by: Paolo Bonzini > --- > scripts/cove

Re: [PATCH 4/6] coverity-model: clean up the models for array allocation functions

2021-08-02 Thread Peter Maydell
On Sat, 31 Jul 2021 at 07:31, Paolo Bonzini wrote: > > sz is only used in one place, so replace it with nmemb * size in > that one place. > > Signed-off-by: Paolo Bonzini > --- > scripts/coverity-scan/model.c | 13 +++-- > 1 file changed, 3 insertions(+), 10 deletions(-) > > diff --git a

Re: [PATCH 5/6] coverity-model: constrain g_malloc/g_malloc0/g_realloc as never returning NULL

2021-08-02 Thread Peter Maydell
On Sat, 31 Jul 2021 at 07:32, Paolo Bonzini wrote: > > g_malloc/g_malloc0/g_realloc only return NULL if the size is 0; we do not need > to cover that in the model, and so far have expected __coverity_alloc__ > to model a non-NULL return value. But that apparently does not work > anymore, so add s

Re: [PATCH 6/6] coverity-model: write models fully for non-array allocation functions

2021-08-02 Thread Peter Maydell
On Sat, 31 Jul 2021 at 07:33, Paolo Bonzini wrote: > > Coverity seems to have issues figuring out the properties of g_malloc0 > and other non *_n functions. While this was "fixed" by removing the > custom second argument to __coverity_mark_as_afm_allocated__, inline > the code from the array-base

Re: [PATCH v2] block/io_uring: resubmit when result is -EAGAIN

2021-08-02 Thread Kevin Wolf
Am 29.07.2021 um 11:10 hat Fabian Ebner geschrieben: > Linux SCSI can throw spurious -EAGAIN in some corner cases in its > completion path, which will end up being the result in the completed > io_uring request. > > Resubmitting such requests should allow block jobs to complete, even > if such spu

Re: [PATCH 0/6] Updates for Coverity modeling file

2021-08-02 Thread Peter Maydell
On Sat, 31 Jul 2021 at 07:29, Paolo Bonzini wrote: > > Recently, an update to the Coverity tools caused it to introduce hundreds > of new complaints about using g_free() to free memory areas allocated > by GLib functions. The solution adopted here (patch 2) is to just > make g_free a synonym of f

Re: "make check-acceptance" takes way too long

2021-08-02 Thread Alex Bennée
Daniel P. Berrangé writes: > On Fri, Jul 30, 2021 at 04:12:27PM +0100, Peter Maydell wrote: >> "make check-acceptance" takes way way too long. I just did a run >> on an arm-and-aarch64-targets-only debug build and it took over >> half an hour, and this despite it skipping or cancelling 26 out >

[PATCH] linux-user/syscall: add support for CLONE_PIDFD

2021-08-02 Thread Andreas Schwab
Add basic support for CLONE_PIDFD, only fork-like clone without additional flags. This is enough to make Qt/forkfd working. Signed-off-by: Andreas Schwab --- linux-user/syscall.c | 52 ++-- 1 file changed, 50 insertions(+), 2 deletions(-) diff --git a/li

Re: "make check-acceptance" takes way too long

2021-08-02 Thread Alex Bennée
Daniel P. Berrangé writes: > On Fri, Jul 30, 2021 at 04:12:27PM +0100, Peter Maydell wrote: >> "make check-acceptance" takes way way too long. I just did a run >> on an arm-and-aarch64-targets-only debug build and it took over >> half an hour, and this despite it skipping or cancelling 26 out >

Re: "make check-acceptance" takes way too long

2021-08-02 Thread Daniel P . Berrangé
On Mon, Aug 02, 2021 at 01:47:37PM +0100, Alex Bennée wrote: > > Daniel P. Berrangé writes: > > > On Fri, Jul 30, 2021 at 04:12:27PM +0100, Peter Maydell wrote: > >> "make check-acceptance" takes way way too long. I just did a run > >> on an arm-and-aarch64-targets-only debug build and it took o

Re: "make check-acceptance" takes way too long

2021-08-02 Thread Daniel P . Berrangé
On Mon, Aug 02, 2021 at 01:55:44PM +0100, Alex Bennée wrote: > > Daniel P. Berrangé writes: > > > On Fri, Jul 30, 2021 at 04:12:27PM +0100, Peter Maydell wrote: > >> "make check-acceptance" takes way way too long. I just did a run > >> on an arm-and-aarch64-targets-only debug build and it took o

Re: "make check-acceptance" takes way too long

2021-08-02 Thread Peter Maydell
On Mon, 2 Aug 2021 at 13:57, Alex Bennée wrote: > > > Daniel P. Berrangé writes: > > > On Fri, Jul 30, 2021 at 04:12:27PM +0100, Peter Maydell wrote: > >> "make check-acceptance" takes way way too long. I just did a run > >> on an arm-and-aarch64-targets-only debug build and it took over > >> hal

[PATCH 0/5] seccomp: fix hole in blocking forks

2021-08-02 Thread Daniel P . Berrangé
Blocking the 'fork' syscall on Linux is not sufficient to block the 'fork' C library function, because the latter is essentially always implemented using the 'clone' syscall these days. Blocking 'clone' is difficult as that also blocks pthread creation, so it needs careful filtering. Daniel P. Be

[PATCH 2/5] seccomp: add unit test for seccomp filtering

2021-08-02 Thread Daniel P . Berrangé
The handling of some syscalls / libc function is quite subtle. For example, 'fork' at a libc level doesn't always correspond to 'fork' at a syscall level, since the 'clone' syscall is preferred usually. The unit test will help to detect these kind of problems. A point of difficulty in writing a te

[PATCH 1/5] seccomp: allow action to be customized per syscall

2021-08-02 Thread Daniel P . Berrangé
We're currently tailoring whether to use kill process or return EPERM based on the syscall set. This is not flexible enough for future requirements where we also need to be able to return a variety of actions on a per-syscall granularity. Signed-off-by: Daniel P. Berrangé --- softmmu/qemu-seccom

Re: "make check-acceptance" takes way too long

2021-08-02 Thread Daniel P . Berrangé
On Mon, Aug 02, 2021 at 02:00:19PM +0100, Peter Maydell wrote: > On Mon, 2 Aug 2021 at 13:57, Alex Bennée wrote: > > > > > > Daniel P. Berrangé writes: > > > > > On Fri, Jul 30, 2021 at 04:12:27PM +0100, Peter Maydell wrote: > > >> "make check-acceptance" takes way way too long. I just did a run

[PATCH 3/5] seccomp: fix blocking of process spawning

2021-08-02 Thread Daniel P . Berrangé
When '-sandbox on,spawn=deny' is given, we are supposed to block the ability to spawn processes. We naively blocked the 'fork' syscall, forgetting that any modern libc will use the 'clone' syscall instead. We can't simply block the 'clone' syscall though, as that will break thread creation. We thu

[PATCH 4/5] seccomp: block use of clone3 syscall

2021-08-02 Thread Daniel P . Berrangé
Modern glibc will use clone3 instead of clone, when it detects that it is available. We need to compare flags in order to decide whether to allow clone (thread create vs process fork), but in clone3 the flags are hidden inside a struct. Seccomp can't currently match on data inside a struct, so our

[PATCH 5/5] seccomp: block setns, unshare and execveat syscalls

2021-08-02 Thread Daniel P . Berrangé
setns/unshare are used to change namespaces which is not something QEMU needs to be able todo. execveat is a new variant of execve so should be blocked just like execve already is. Signed-off-by: Daniel P. Berrangé --- softmmu/qemu-seccomp.c | 5 + 1 file changed, 5 insertions(+) diff --gi

Re: [PATCH for-6.2 00/43] Unaligned accesses for user-only

2021-08-02 Thread Peter Maydell
On Thu, 29 Jul 2021 at 01:50, Richard Henderson wrote: > > This began with Peter wanting a cpu_ldst.h interface that can handle > alignment info for Arm M-profile system mode, which will also compile > for user-only without ifdefs. This is patch 32. > > Once I had that interface, I thought I migh

[Bug 1890160] Re: Abort in vmxnet3_validate_queues

2021-08-02 Thread Thomas Huth
Fixed here: https://gitlab.com/qemu-project/qemu/-/commit/9010b0c7a9a097590e183 ** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1890160

Re: [PATCH-for-6.1?] target/mips: Remove MOVZ/MOVN opcodes from Loongson 2E

2021-08-02 Thread Philippe Mathieu-Daudé
On 8/2/21 2:18 PM, Maciej W. Rozycki wrote: > On Mon, 2 Aug 2021, Philippe Mathieu-Daudé wrote: > >>> Per the "Godson-2E User Manual v0.6", the Loongson 2E processor >>> does not implement the MOVZ/MOVN instructions >> >> I'm confused because I can't find MOVZ/MOVN in the 2E manual and >> the 2F e

Re: [PATCH-for-6.1 1/3] hw/sd/sdcard: Document out-of-range addresses for SEND_WRITE_PROT

2021-08-02 Thread Philippe Mathieu-Daudé
On 8/2/21 2:00 PM, Peter Maydell wrote: > On Wed, 28 Jul 2021 at 19:18, Philippe Mathieu-Daudé wrote: >> >> Per the 'Physical Layer Simplified Specification Version 3.01', >> Table 4-22: 'Block Oriented Write Protection Commands' >> >> SEND_WRITE_PROT (CMD30) >> >> If the card provides write p

Re: Windows on ARM64 not able to use attached TPM 2

2021-08-02 Thread Philippe Mathieu-Daudé
Adding Leif who might add someone who knows ;) On 8/2/21 2:09 PM, Ard Biesheuvel wrote: > On Mon, 2 Aug 2021 at 11:51, Eric Auger wrote: >> >> and also adding Ard if he is aware of any limitation the TPM2 >> integration may suffer for Windows support. On my end I am only able to >> test on Linux

Re: "make check-acceptance" takes way too long

2021-08-02 Thread Thomas Huth
On 02/08/2021 15.04, Daniel P. Berrangé wrote: On Mon, Aug 02, 2021 at 02:00:19PM +0100, Peter Maydell wrote: On Mon, 2 Aug 2021 at 13:57, Alex Bennée wrote: Daniel P. Berrangé writes: On Fri, Jul 30, 2021 at 04:12:27PM +0100, Peter Maydell wrote: "make check-acceptance" takes way way to

Re: "make check-acceptance" takes way too long

2021-08-02 Thread Thomas Huth
On 02/08/2021 15.00, Daniel P. Berrangé wrote: On Mon, Aug 02, 2021 at 01:55:44PM +0100, Alex Bennée wrote: Daniel P. Berrangé writes: On Fri, Jul 30, 2021 at 04:12:27PM +0100, Peter Maydell wrote: "make check-acceptance" takes way way too long. I just did a run on an arm-and-aarch64-target

Re: [PATCH v2] hw/pcie-root-port: Fix hotplug for PCI devices requiring IO

2021-08-02 Thread Marcel Apfelbaum
Hi Daniel, On Mon, Aug 2, 2021 at 12:05 PM Daniel P. Berrangé wrote: > On Mon, Aug 02, 2021 at 12:00:57PM +0300, Marcel Apfelbaum wrote: > > Q35 has now ACPI hotplug enabled by default for PCI(e) devices. > > As opposed to native PCIe hotplug, guests like Fedora 34 > > will not assign IO range t

Re: Windows on ARM64 not able to use attached TPM 2

2021-08-02 Thread Philippe Mathieu-Daudé
On 8/2/21 11:04 AM, Philippe Mathieu-Daudé wrote: > Cc'ing Marc-André who is your EDK2 co-maintainer. Oops sorry, I meant your EDK2 "co-designated Package Reviewer" R: Package Reviewer: Cc address for patches and questions. Reviewers help maintainers review code, but don't have push access

[PATCH v4 0/2] plugins/cache: multicore cache modelling

2021-08-02 Thread Mahmoud Mandour
Hello, This series introduce multicore cache modelling in contrib/plugins/cache.c Multi-core cache modelling is handled such that for full-system emulation, a private L1 cache is maintained to each core available to the system. For multi-threaded userspace emulation, a static number of cores is m

[PATCH v4 1/2] plugins/cache: supported multicore cache modelling

2021-08-02 Thread Mahmoud Mandour
Multicore L1 cache modelling is introduced and is supported for both full system emulation and linux-user. For full-system emulation, L1 icache and dcache are maintained for each available core, since this information is exposed to the plugin through `qemu_plugin_n_vcpus()`. For linux-user, a sta

[PATCH v4 2/2] docs/devel/tcg-plugins: added cores arg to cache plugin

2021-08-02 Thread Mahmoud Mandour
Signed-off-by: Mahmoud Mandour --- docs/devel/tcg-plugins.rst | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/docs/devel/tcg-plugins.rst b/docs/devel/tcg-plugins.rst index 7e54f12837..863828809d 100644 --- a/docs/devel/tcg-plugins.rst +++ b/docs/devel/tcg-plugins

Re: "make check-acceptance" takes way too long

2021-08-02 Thread Gerd Hoffmann
Hi, > > Ok, so that would require a bootloader build too, which is likely going > > to be arch specific, so probably the most tedious part. > > Maybe we could use buildroot for this. I've used buildroot for my images in > the QEMU Advent Calendar, and it was really a great help. See also: > >

[PATCH v5] docs/deprecated: deprecate passing plugin args through `arg=`

2021-08-02 Thread Mahmoud Mandour
Signed-off-by: Mahmoud Mandour --- v4 -> v5: 1. Mentioned that short-form booleans are still usable but not preferable. docs/system/deprecated.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst index e2e0090878..43ae15

Re: [PULL 00/21] target-arm queue

2021-08-02 Thread Peter Maydell
-request' into > staging (2021-08-02 09:47:07 +0100) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20210802 > > for you to fetch changes up to 4a64939db76b10d8d41d2af3c6aad8142da55450: > &

QEMU Developer Survey for KVM Forum 2021

2021-08-02 Thread Alex Bennée
Hi, For the QEMU keynote at KVM Forum I'd like to get a rough idea of if our working habits have changed over the last two years. To that end I've prepared a totally anonymous 5 question survey which should only take a few minutes to complete: https://forms.gle/2MrrZ73bPHCG69Z18 I'll present

Re: [PATCH v6 05/11] qapi: introduce QAPISchemaIfCond.cgen()

2021-08-02 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Instead of building prepocessor conditions from a list of string, use > the result generated from QAPISchemaIfCond.cgen() and hide the > implementation details. > > Signed-off-by: Marc-André Lureau Please mention that the patch c

Re: [PATCH] hw/char/virtio-serial-bus: fix: Unpop throttled VirtQueueElement to queue before discard vq data

2021-08-02 Thread Laurent Vivier
On 30/07/2021 03:58, AIERPATIJIANG1 [艾尔帕提江·阿布都赛买提] wrote: > Ports enter a "throttled" state when writing to the chardev would block. > The current output VirtQueueElement is kept around until the chardev > becomes writable again. > > Because closing the virtio serial device does not reset the queu

[PATCH v1] softmmu/physmem: fix wrong assertion in qemu_ram_alloc_internal()

2021-08-02 Thread David Hildenbrand
When adding RAM_NORESERVE, we forgot to remove the old assertion when adding the updated one, most probably when reworking the patches or rebasing. We can easily crash QEMU by adding -object memory-backend-ram,id=mem0,size=500G,reserve=off to the QEMU cmdline: qemu-system-x86_64: ../softmmu/phy

  1   2   3   >