RE: [PATCH 0/4] Add support for Fujitsu A64FX processor

2021-07-20 Thread ishii.shuuic...@fujitsu.com
Hi, peter Thank you for your comment. > Hi; it looks like something with your outgoing email setup still disagrees > with QEMU's mailing list server :-( As far as I can tell these emails didn't > make it to the list, so only people on the direct-cc list will have > seen them :-( As you said, it

Re: [PATCH v1 1/9] s390x: smp: s390x dedicated smp parsing

2021-07-20 Thread Pierre Morel
On 7/19/21 5:52 PM, Daniel P. Berrangé wrote: On Mon, Jul 19, 2021 at 05:43:29PM +0200, Cornelia Huck wrote: (restored cc:s) On Fri, Jul 16 2021, Pierre Morel wrote: On 7/16/21 11:14 AM, Daniel P. Berrangé wrote: I increasingly worry that we're making a mistake by going down the route of

Re: [PATCH v1 2/9] s390x: toplogy: adding drawers and books to smp parsing

2021-07-20 Thread Pierre Morel
On 7/19/21 5:50 PM, Cornelia Huck wrote: On Fri, Jul 16 2021, Daniel P. Berrangé wrote: On Fri, Jul 16, 2021 at 12:44:49PM +0200, Cornelia Huck wrote: On Fri, Jul 16 2021, Daniel P. Berrangé wrote: On Fri, Jul 16, 2021 at 11:10:04AM +0200, Cornelia Huck wrote: On Thu, Jul 15 2021, Mark

Re: [PATCH] tests/qtest/migration-test.c: use 127.0.0.1 instead of 0

2021-07-20 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > OpenBSD doesn't like :0 as an address, switch to using 127.0.0.1 > in baddest; it's really testing the :0 port number that isn't allowed > on anything. > > (The test doesn't currently run anyway because of the userfault >

Re: random crash in migration-test, i386 guest, x86-64 host:

2021-07-20 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Mon, 19 Jul 2021 at 13:43, Peter Maydell wrote: > > > > Random crash in migration-tests: > > > > MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} > > QTEST_QEMU_IMG=./qemu-img G_TEST_DBUS_DAEMON=/mnt/nvmedisk/linaro/qem > > u-f

Re: Failing iotest 206

2021-07-20 Thread Thomas Huth
On 20/07/2021 03.12, Eric Blake wrote: On Mon, Jul 19, 2021 at 10:06:01AM +0200, Thomas Huth wrote: Hi, iotest 206 fails for me with: --- 206.out +++ 206.out.bad @@ -99,55 +99,19 @@ {"execute": "blockdev-create", "arguments": {"job-id": "job0", "options": {"driver": "qcow2", "encrypt":

Re: [PATCH v1 2/9] s390x: toplogy: adding drawers and books to smp parsing

2021-07-20 Thread Cornelia Huck
On Tue, Jul 20 2021, Pierre Morel wrote: > On 7/19/21 5:50 PM, Cornelia Huck wrote: >> On Fri, Jul 16 2021, Daniel P. Berrangé wrote: >>> Is the book/drawer thing architecture specific, or is it machine >>> type / CPU specific. ie do /all/ the s390x machine types / CPUS >>> QEMU support the book

Re: [PATCH] io_uring: move LuringState typedef to block/aio.h

2021-07-20 Thread Stefano Garzarella
On Mon, Jul 12, 2021 at 03:10:30PM +0200, Paolo Bonzini wrote: The LuringState typedef is defined twice, in include/block/raw-aio.h and block/io_uring.c. Move it in include/block/aio.h, which is included everywhere the typedef is needed, since include/block/aio.h already has to define the forwar

Re: Failing iotest 206

2021-07-20 Thread Daniel P . Berrangé
On Mon, Jul 19, 2021 at 08:12:58PM -0500, Eric Blake wrote: > On Mon, Jul 19, 2021 at 10:06:01AM +0200, Thomas Huth wrote: > > Hi, > > > > iotest 206 fails for me with: > > > > > --- 206.out > > +++ 206.out.bad > > @@ -99,55 +99,19 @@ > > > > {"execute": "blockdev-create", "arguments": {"job-

Re: [PATCH v1 1/9] s390x: smp: s390x dedicated smp parsing

2021-07-20 Thread Pierre Morel
On 7/20/21 9:37 AM, Pierre Morel wrote: On 7/19/21 5:52 PM, Daniel P. Berrangé wrote: On Mon, Jul 19, 2021 at 05:43:29PM +0200, Cornelia Huck wrote: (restored cc:s) On Fri, Jul 16 2021, Pierre Morel wrote: On 7/16/21 11:14 AM, Daniel P. Berrangé wrote: I increasingly worry that we're

Re: [PATCH v1 2/9] s390x: toplogy: adding drawers and books to smp parsing

2021-07-20 Thread Pierre Morel
On 7/20/21 10:20 AM, Cornelia Huck wrote: On Tue, Jul 20 2021, Pierre Morel wrote: On 7/19/21 5:50 PM, Cornelia Huck wrote: On Fri, Jul 16 2021, Daniel P. Berrangé wrote: Is the book/drawer thing architecture specific, or is it machine type / CPU specific. ie do /all/ the s390x machine t

Re: [PATCH v1 2/9] s390x: toplogy: adding drawers and books to smp parsing

2021-07-20 Thread Cornelia Huck
On Tue, Jul 20 2021, Pierre Morel wrote: > On 7/20/21 10:20 AM, Cornelia Huck wrote: >> On Tue, Jul 20 2021, Pierre Morel wrote: >> >>> On 7/19/21 5:50 PM, Cornelia Huck wrote: On Fri, Jul 16 2021, Daniel P. Berrangé wrote: > Is the book/drawer thing architecture specific, or is it ma

Re: [PULL 0/6] Block patches for 6.1-rc0

2021-07-20 Thread Peter Maydell
On Mon, 19 Jul 2021 at 18:27, Max Reitz wrote: > > The following changes since commit 7457b407edd6e8555e4b46488aab2f13959fccf8: > > Merge remote-tracking branch > 'remotes/thuth-gitlab/tags/pull-request-2021-07-19' into staging (2021-07-19 > 11:34:08 +0100) > > are available in the Git reposit

Re: Error in accel/tcg?

2021-07-20 Thread Peter Maydell
On Mon, 19 Jul 2021 at 23:20, Kenneth Adam Miller wrote: > > Hello, > > I get the following error: > > -c ../accel/tcg/cputlb.c > ../qemu/accel/tcg/cputlb.c: In function 'tlb_flush_page_by_mmuidx': > ../qemu/accel/tcg/cputlb.c:602:23: error: comparison is always true due to > limited range of da

Re: [PATCH 0/4] Add support for Fujitsu A64FX processor

2021-07-20 Thread Peter Maydell
On Tue, 20 Jul 2021 at 08:35, ishii.shuuic...@fujitsu.com wrote: > > Hi, peter > Thank you for your comment. > > > Hi; it looks like something with your outgoing email setup still disagrees > > with QEMU's mailing list server :-( As far as I can tell these emails > > didn't > > make it to the li

Re: [PATCH v1 2/9] s390x: toplogy: adding drawers and books to smp parsing

2021-07-20 Thread Daniel P . Berrangé
On Tue, Jul 20, 2021 at 10:46:31AM +0200, Pierre Morel wrote: > > > On 7/20/21 10:20 AM, Cornelia Huck wrote: > > On Tue, Jul 20 2021, Pierre Morel wrote: > > > > > On 7/19/21 5:50 PM, Cornelia Huck wrote: > > > > On Fri, Jul 16 2021, Daniel P. Berrangé wrote: > > > > > Is the book/drawer thin

Re: [PATCH 5/6] tests/acceptance/virtio-gpu.py: use virtio-vga-gl

2021-07-20 Thread Marc-André Lureau
On Wed, Jul 14, 2021 at 9:47 PM Cleber Rosa wrote: > Since 49afbca3b, the use of an optional virgl renderer is not > available anymore, and since b36eb8860f, the way to choose a GL based > rendered is to use the "virtio-vga-gl" device. > > Signed-off-by: Cleber Rosa > Reviewed-by: Marc-André Lu

Re: [PATCH v2 2/2] gitlab: enable a very minimal build with the tricore container

2021-07-20 Thread Alex Bennée
Richard Henderson writes: > On 7/19/21 11:48 AM, Alex Bennée wrote: >> diff --git a/tests/docker/dockerfiles/debian-tricore-cross.docker >> b/tests/docker/dockerfiles/debian-tricore-cross.docker >> index 985925134c..4ea9112289 100644 >> --- a/tests/docker/dockerfiles/debian-tricore-cross.docke

Re: [PATCH v1 1/2] hw/tricore: fix inclusion of tricore_testboard

2021-07-20 Thread Alex Bennée
Peter Maydell writes: > On Mon, 19 Jul 2021 at 20:52, Alex Bennée wrote: >> >> We inadvertently added a symbol clash causing the build not to include >> the testboard needed for check-tcg. >> >> Fixes: f4063f9c31 ("meson: Introduce target-specific Kconfig") >> Signed-off-by: Alex Bennée >> --

Re: [PATCH v1 1/2] hw/tricore: fix inclusion of tricore_testboard

2021-07-20 Thread Peter Maydell
On Tue, 20 Jul 2021 at 10:47, Alex Bennée wrote: > > > Peter Maydell writes: > > > On Mon, 19 Jul 2021 at 20:52, Alex Bennée wrote: > >> > >> We inadvertently added a symbol clash causing the build not to include > >> the testboard needed for check-tcg. > >> > >> Fixes: f4063f9c31 ("meson: Intro

[RFC] Rust vhost-user-scsi implementation

2021-07-20 Thread Gaelan Steele
Hi all, I've been working as one of QEMU's Google Summer of Code interns to implement a vhost-user-scsi daemon in Rust. That work's now reached a point where it's usable to attach read-only raw disk images to a VM, and I'd like to get some feedback from the QEMU community, especially anyone with e

Re: [PATCH for-6.2 17/34] target/arm: Implement MVE VMLAS

2021-07-20 Thread Peter Maydell
On Sat, 17 Jul 2021 at 21:40, Richard Henderson wrote: > > On 7/17/21 3:06 AM, Peter Maydell wrote: > > On Fri, 16 Jul 2021 at 23:12, Richard Henderson > > wrote: > >> > >> On 7/13/21 6:37 AM, Peter Maydell wrote: > >>> Implement the MVE VMLAS insn, which multiplies a vector by a vector > >>> and

Re: random crash in migration-test, i386 guest, x86-64 host:

2021-07-20 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Mon, 19 Jul 2021 at 13:43, Peter Maydell wrote: > > > > Random crash in migration-tests: > > > > MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} > > QTEST_QEMU_IMG=./qemu-img G_TEST_DBUS_DAEMON=/mnt/nvmedisk/linaro/qem > > u-f

Re: [PATCH 3/3] linux-aio: limit the batch size using `aio-max-batch` parameter

2021-07-20 Thread Stefan Hajnoczi
On Mon, Jul 19, 2021 at 12:35:53PM +0200, Stefano Garzarella wrote: > On Tue, Jul 13, 2021 at 03:58:04PM +0100, Stefan Hajnoczi wrote: > > On Wed, Jul 07, 2021 at 05:00:19PM +0200, Stefano Garzarella wrote: > > > @@ -371,7 +375,7 @@ static int laio_do_submit(int fd, struct qemu_laiocb > > > *laioc

Re: [PATCH v1 1/2] hw/tricore: fix inclusion of tricore_testboard

2021-07-20 Thread Alex Bennée
Peter Maydell writes: > On Tue, 20 Jul 2021 at 10:47, Alex Bennée wrote: >> >> >> Peter Maydell writes: >> >> > On Mon, 19 Jul 2021 at 20:52, Alex Bennée wrote: >> >> >> >> We inadvertently added a symbol clash causing the build not to include >> >> the testboard needed for check-tcg. >> >>

Re: [PATCH v1 1/2] hw/tricore: fix inclusion of tricore_testboard

2021-07-20 Thread Alex Bennée
Alex Bennée writes: > Peter Maydell writes: > >> On Tue, 20 Jul 2021 at 10:47, Alex Bennée wrote: >>> >>> >>> Peter Maydell writes: >>> >>> > On Mon, 19 Jul 2021 at 20:52, Alex Bennée wrote: >>> >> >>> >> We inadvertently added a symbol clash causing the build not to include >>> >> the test

Re: [PATCH 0/4] Add support for Fujitsu A64FX processor

2021-07-20 Thread Philippe Mathieu-Daudé
Hi Ishii, On 7/20/21 9:34 AM, ishii.shuuic...@fujitsu.com wrote: > Hi, peter > Thank you for your comment. > >> Hi; it looks like something with your outgoing email setup still disagrees >> with QEMU's mailing list server :-( As far as I can tell these emails didn't >> make it to the list, so on

Re: [PATCH v3 0/3] vhost-user: warn when guest RAM is not shared

2021-07-20 Thread Kevin Wolf
Am 14.07.2021 um 11:29 hat Stefan Hajnoczi geschrieben: > v3: > * Rebased > v2: > * Clarify that object-memory-memfd enables share=on by default [Marc-André] > * Rebased > > vhost-user requires -object memory-backend-*,share=on option so that QEMU uses > mmap(MAP_SHARED) on guest RAM that is sh

[PATCH v2 04/17] iotests.py: rewrite default luks support in qemu_img

2021-07-20 Thread Vladimir Sementsov-Ogievskiy
Move the logic to more generic qemu_img_pipe_and_status(). Also behave better when we have several -o options. And reuse argument parser of course. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 36 +-- 1 file changed, 17 insertion

Re: [PULL v3 05/19] hw/acpi/ich9: Set ACPI PCI hot-plug as default on Q35

2021-07-20 Thread Laurent Vivier
On 16/07/2021 17:15, Michael S. Tsirkin wrote: > From: Julia Suvorova > > Q35 has three different types of PCI devices hot-plug: PCIe Native, > SHPC Native and ACPI hot-plug. This patch changes the default choice > for cold-plugged bridges from PCIe Native to ACPI Hot-plug with > ability to use S

[PATCH v2 00/17] iotests: support zstd

2021-07-20 Thread Vladimir Sementsov-Ogievskiy
These series makes tests pass with IMGOPTS='compression_type=zstd' Also, python iotests start to support IMGOPTS (they didn't before). v2: 01: add Max's r-b 02: simplify a lot: just add separate -o for IMGOPTS. also, don't bother with catching compat=0.10 03,04: new 05: add Max's r-b 06:

[PATCH v2 10/17] qcow2: simple case support for downgrading of qcow2 images with zstd

2021-07-20 Thread Vladimir Sementsov-Ogievskiy
If image doesn't have any compressed cluster we can easily switch to zlib compression, which may allow to downgrade the image. That's mostly needed to support IMGOPTS='compression_type=zstd' in some iotests which do qcow2 downgrade. While being here also fix checkpatch complain against '#' in pri

[PATCH v2 03/17] iotests: drop qemu_img_verbose() helper

2021-07-20 Thread Vladimir Sementsov-Ogievskiy
qemu_img_verbose() has a drawback of not going through generic qemu_img_pipe_and_status(). qemu_img_verbose() is not very popular, so update the only two users to qemu_img_log() and drop qemu_img_verbose() at all. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/044| 5

[PATCH v2 06/17] iotest 065: explicit compression type

2021-07-20 Thread Vladimir Sementsov-Ogievskiy
The test checks different options. It of course fails if set IMGOPTS='compression_type=zstd'. So, let's be explicit in what compression type we want and independent of IMGOPTS. Test both existing compression types. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/065 | 16 +

[PATCH v2 02/17] iotests.py: qemu_img*("create"): support IMGOPTS='compression_type=zstd'

2021-07-20 Thread Vladimir Sementsov-Ogievskiy
Adding support of IMGOPTS (like in bash tests) allows user to pass a lot of different options. Still, some may require additional logic. Now we want compression_type option, so add some smart logic around it: ignore compression_type=zstd in IMGOPTS, if test want qcow2 in compatibility mode. As wel

[PATCH v2 14/17] iotests: bash tests: filter compression type

2021-07-20 Thread Vladimir Sementsov-Ogievskiy
We want iotests pass with both the default zlib compression and with IMGOPTS='compression_type=zstd'. Actually the only test that is interested in real compression type in test output is 287 (test for qcow2 compression type), so implement specific option for it. Signed-off-by: Vladimir Sementsov-

[PATCH v2 07/17] iotests.py: filter out successful output of qemu-img crate

2021-07-20 Thread Vladimir Sementsov-Ogievskiy
The only "feature" of this "Formatting ..." line is that we have to update it every time we add new option. Let's drop it. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/255.out| 4 tests/qemu-iotests/274.out| 29 - tests/qemu-iotests

[PATCH v3 3/3] gitlab: enable a very minimal build with the tricore container

2021-07-20 Thread Alex Bennée
Rather than base of the shared Debian 10 container which would require us to bring in even more dependencies just bring in what is needed for building tricore-softmmu in GitLab. We don't even remove the container from the DOCKER_PARTIAL_IMAGES lest we cause more confusion. Signed-off-by: Alex Benn

[PATCH v2 01/17] iotests.py: img_info_log(): rename imgopts argument

2021-07-20 Thread Vladimir Sementsov-Ogievskiy
We are going to support IMGOPTS environment variable like in bash tests. Corresponding global variable in iotests.py should be called imgopts. So to not interfere with function argument, rename it in advance. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- tests/qemu-iote

[PATCH v2 11/17] iotests/common.rc: introduce _qcow2_dump_header helper

2021-07-20 Thread Vladimir Sementsov-Ogievskiy
We'll use it in tests instead of explicit qcow2.py. Then we are going to add some filtering in _qcow2_dump_header. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- tests/qemu-iotests/common.rc | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tests/qemu-iotes

[PATCH v2 08/17] iotests.py: filter compression type out

2021-07-20 Thread Vladimir Sementsov-Ogievskiy
We want iotests pass with both the default zlib compression and with IMGOPTS='compression_type=zstd'. Actually the only test that is interested in real compression type in test output is 287 (test for qcow2 compression type) and it's in bash. So for now we can safely filter out compression type in

Re: [RFC] Rust vhost-user-scsi implementation

2021-07-20 Thread Philippe Mathieu-Daudé
On 7/20/21 11:55 AM, Gaelan Steele wrote: > Hi all, > > I've been working as one of QEMU's Google Summer of Code interns to > implement a vhost-user-scsi daemon in Rust. That work's now reached a > point where it's usable to attach read-only raw disk images to a VM, > and I'd like to get some feed

[PATCH v2 05/17] iotest 303: explicit compression type

2021-07-20 Thread Vladimir Sementsov-Ogievskiy
The test prints qcow2 header fields which depends on chosen compression type. So, let's be explicit in what compression type we want and independent of IMGOPTS. Test both existing compression types. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- tests/qemu-iotests/303

[PATCH v2 12/17] iotests: massive use _qcow2_dump_header

2021-07-20 Thread Vladimir Sementsov-Ogievskiy
We are going to add filtering in _qcow2_dump_header and want all tests use it. The patch is generated by commands: cd tests/qemu-iotests sed -ie 's/$PYTHON qcow2.py "$TEST_IMG" dump-header\($\| \)/_qcow2_dump_header\1/' ??? tests/* (the difficulty is to avoid converting dump-header-exts) Si

[PATCH v2 09/17] iotest 302: use img_info_log() helper

2021-07-20 Thread Vladimir Sementsov-Ogievskiy
Instead of qemu_img_log("info", ..) use generic helper img_info_log(). img_info_log() has smarter logic. For example it use filter_img_info() to filter output, which in turns filter a compression type. So it will help us in future when we implement a possibility to use zstd compression by default

Re: [PATCH] tests/qtest/migration-test.c: use 127.0.0.1 instead of 0

2021-07-20 Thread Philippe Mathieu-Daudé
On 7/19/21 8:52 PM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > OpenBSD doesn't like :0 as an address, switch to using 127.0.0.1 > in baddest; it's really testing the :0 port number that isn't allowed > on anything. > > (The test doesn't currently run anyway because

[PATCH v2 17/17] iotests: declare lack of support for compresion_type in IMGOPTS

2021-07-20 Thread Vladimir Sementsov-Ogievskiy
compression_type can't be used if we want to create image with compat=0.10. So, skip these tests, not many of them. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/031 | 5 +++-- tests/qemu-iotests/051 | 5 +++-- tests/qemu-iotests/061 | 6 +- tests/qemu-iotests/112 | 3 ++

[PATCH v3 2/3] tests/tcg/configure.sh: add handling for assembler only builds

2021-07-20 Thread Alex Bennée
Up until this point we only handled local compilers or assumed we had everything in the container. This falls down when we are building QEMU inside the container. This special handling only affects tricore for now but I put it in a case just in case we add any other "special" targets. Setting CROS

[PATCH v2 13/17] iotest 39: use _qcow2_dump_header

2021-07-20 Thread Vladimir Sementsov-Ogievskiy
_qcow2_dump_header has filter for compression type, so this change makes test pass with IMGOPTS='compression_type=zstd'. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- tests/qemu-iotests/039 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-i

Re: [PATCH v2 2/2] hw/registerfields: Use 64-bit bitfield for FIELD_DP64

2021-07-20 Thread Philippe Mathieu-Daudé
On 7/20/21 12:02 AM, Joe Komlodi wrote: > If we have a field that's wider than 32-bits, we need a data type wide enough > to > be able to create the bitfield used to deposit the value. > > Signed-off-by: Joe Komlodi > --- > include/hw/registerfields.h | 2 +- > 1 file changed, 1 insertion(+), 1

[PATCH v2 16/17] iotest 214: explicit compression type

2021-07-20 Thread Vladimir Sementsov-Ogievskiy
The test-case "Corrupted size field in compressed cluster descriptor" heavily depends on zlib compression type. So, make it explicit. This way test passes with IMGOPTS='compression_type=zstd'. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- tests/qemu-iotests/214 | 2 +-

[PATCH v2 15/17] iotests 60: more accurate set dirty bit in qcow2 header

2021-07-20 Thread Vladimir Sementsov-Ogievskiy
Don't touch other incompatible bits, like compression-type. This makes the test pass with IMGOPTS='compression_type=zstd'. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- tests/qemu-iotests/060 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu

Re: [PATCH for-6.1 v5 08/15] hw/core: Introduce TCGCPUOps.debug_check_breakpoint

2021-07-20 Thread Philippe Mathieu-Daudé
On 7/20/21 3:17 AM, Richard Henderson wrote: > New hook to return true when an architectural breakpoint is > to be recognized and false when it should be suppressed. > > First use must wait until other pieces are in place. > > Signed-off-by: Richard Henderson > --- > include/hw/core/tcg-cpu-ops

[PATCH v3 1/3] hw/tricore: fix inclusion of tricore_testboard

2021-07-20 Thread Alex Bennée
We inadvertently added a symbol clash causing the build not to include the testboard needed for check-tcg. Fixes: f4063f9c31 ("meson: Introduce target-specific Kconfig") Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée --

Re: [PATCH for-6.1 v5 03/15] target/alpha: Drop goto_tb path in gen_call_pal

2021-07-20 Thread Philippe Mathieu-Daudé
On 7/20/21 3:17 AM, Richard Henderson wrote: > We are certain of a page crossing here, entering the > PALcode image, so the call to use_goto_tb that should > have been here will never succeed. > > We are shortly going to add an assert to tcg_gen_goto_tb > that would trigger for this case. > > Sig

Re: [PATCH for-6.1 v5 14/15] accel/tcg: Hoist tb_cflags to a local in translator_loop

2021-07-20 Thread Philippe Mathieu-Daudé
On 7/20/21 3:17 AM, Richard Henderson wrote: > The access internal to tb_cflags() is atomic. > Avoid re-reading it as such for the multiple uses. > > Reviewed-by: Alex Bennée > Signed-off-by: Richard Henderson > --- > accel/tcg/translator.c | 9 - > 1 file changed, 4 insertions(+), 5 de

Re: [PATCH for-6.1 v5 09/15] target/arm: Implement debug_check_breakpoint

2021-07-20 Thread Philippe Mathieu-Daudé
On 7/20/21 3:17 AM, Richard Henderson wrote: > Reuse the code at the bottom of helper_check_breakpoints, > which is what we currently call from *_tr_breakpoint_check. > > Signed-off-by: Richard Henderson > --- > target/arm/internals.h| 3 +++ > target/arm/cpu.c | 1 + > target/arm/c

[PATCH for 6.1 v3 0/3] tricore fixes

2021-07-20 Thread Alex Bennée
Hi, This fixes check-tcg for tricore and adds a test to the gitlab matrix so we don't miss it breaking again. v3 - added new patch for configure.sh - changed symbol for board The following need review: - gitlab: enable a very minimal build with the tricore container - tests/tcg/configure.

[PATCH] mips/tlb_helper: Add support for 'info tlb' cmd

2021-07-20 Thread Arkadiy
From: NDNF This adds hmp 'info tlb' command support for the mips platform. 1k pages are not supported. Signed-off-by: NDNF --- hmp-commands-info.hx | 3 ++- target/mips/cpu.h| 3 +++ target/mips/meson.build | 1 + target/mips/monitor.c| 26 ++ target/mip

Re: [PATCH RFC server 01/11] vfio-user: build library

2021-07-20 Thread Jag Raman
> On Jul 19, 2021, at 4:24 PM, John Levon wrote: > > On Mon, Jul 19, 2021 at 04:00:03PM -0400, Jagannathan Raman wrote: > >> add the libvfio-user library as a submodule. build it as part of QEMU >> >> diff --git a/meson.build b/meson.build >> index 6e4d2d8..f2f9f86 100644 >> --- a/meson.build

Re: [PATCH v5 05/10] ACPI ERST: support for ACPI ERST feature

2021-07-20 Thread Igor Mammedov
On Wed, 30 Jun 2021 15:07:16 -0400 Eric DeVolder wrote: > This change implements the support for the ACPI ERST feature. Drop this > > This implements a PCI device for ACPI ERST. This implments the s/implments/implements/ > non-NVRAM "mode" of operation for ERST. add here why non-NVRAM "mode" i

Re: [PATCH RFC server 01/11] vfio-user: build library

2021-07-20 Thread Marc-André Lureau
Hi On Tue, Jul 20, 2021 at 4:12 PM Jag Raman wrote: > > > > On Jul 19, 2021, at 4:24 PM, John Levon wrote: > > > > On Mon, Jul 19, 2021 at 04:00:03PM -0400, Jagannathan Raman wrote: > > > >> add the libvfio-user library as a submodule. build it as part of QEMU > >> > >> diff --git a/meson.build

Re: [PATCH v1 2/9] s390x: toplogy: adding drawers and books to smp parsing

2021-07-20 Thread Pierre Morel
On 7/20/21 11:19 AM, Daniel P. Berrangé wrote: On Tue, Jul 20, 2021 at 10:46:31AM +0200, Pierre Morel wrote: On 7/20/21 10:20 AM, Cornelia Huck wrote: On Tue, Jul 20 2021, Pierre Morel wrote: On 7/19/21 5:50 PM, Cornelia Huck wrote: On Fri, Jul 16 2021, Daniel P. Berrangé wrote: Is t

[PATCH v6 01/12] target/hexagon: update MAINTAINERS for idef-parser

2021-07-20 Thread Alessandro Di Federico via
From: Alessandro Di Federico Signed-off-by: Alessandro Di Federico Reviewed-by: Richard Henderson --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4256ad1adb..6c825a9eb4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -194,6 +194,8 @@ He

[PATCH v6 05/12] target/hexagon: introduce new helper functions

2021-07-20 Thread Alessandro Di Federico via
From: Niccolò Izzo These helpers will be employed by the idef-parser generated code. Signed-off-by: Alessandro Di Federico Signed-off-by: Niccolò Izzo --- target/hexagon/genptr.h | 15 +- target/hexagon/macros.h | 9 target/hexagon/genptr.c | 113 ++

Re: [RFC PATCH] tcg/plugins: implement a qemu_plugin_user_exit helper

2021-07-20 Thread Mahmoud Mandour
On Mon, Jul 19, 2021, 14:37 Alex Bennée wrote: > In user-mode emulation there is a small race between preexit_cleanup > and exit_group() which means we may end up calling instrumented > instructions before the kernel reaps child threads. To solve this we > implement a new helper which ensures the

[PATCH v6 03/12] target/hexagon: make slot number an unsigned

2021-07-20 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel Acked-by: Richard Henderson --- target/hexagon/macros.h | 2 +- target/hexagon/genptr.c | 24 +--- 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/target/hexagon/macr

[PATCH v6 06/12] target/hexagon: expose next PC in DisasContext

2021-07-20 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel Reviewed-by: Richard Henderson Reviewed-by: Taylor Simpson --- target/hexagon/translate.h | 1 + target/hexagon/translate.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/target/h

[PATCH v6 04/12] target/hexagon: make helper functions non-static

2021-07-20 Thread Alessandro Di Federico via
From: Paolo Montesel Make certain helper functions non-static, making them available outside genptr.c. These functions are required by code generated by the idef-parser. This commit also makes some op_helper.c non-static in order to avoid having them marked as unused when using the idef-parser g

[PATCH v6 11/12] target/hexagon: import additional tests

2021-07-20 Thread Alessandro Di Federico via
From: Niccolò Izzo Signed-off-by: Alessandro Di Federico Signed-off-by: Niccolò Izzo --- tests/tcg/hexagon/Makefile.target | 30 +- tests/tcg/hexagon/crt.S| 26 tests/tcg/hexagon/test_abs.S | 20 ++ tests/tcg/hexagon/test_bitcnt.S| 42 +++

[PATCH v6 02/12] target/hexagon: import README for idef-parser

2021-07-20 Thread Alessandro Di Federico via
From: Alessandro Di Federico Signed-off-by: Alessandro Di Federico --- target/hexagon/idef-parser/README.rst | 447 ++ target/hexagon/README | 5 + 2 files changed, 452 insertions(+) create mode 100644 target/hexagon/idef-parser/README.rst diff --git

[PATCH v6 09/12] target/hexagon: import parser for idef-parser

2021-07-20 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/idef-parser/parser-helpers.h | 346 +++ target/hexagon/idef-parser/parser-helpers.c | 2396 + target/hexagon/idef-parser/idef-parser.y | 975 +++ target/he

[PATCH v6 10/12] target/hexagon: call idef-parser functions

2021-07-20 Thread Alessandro Di Federico via
From: Alessandro Di Federico Extend gen_tcg_funcs.py in order to emit calls to the functions emitted by the idef-parser, if available. Signed-off-by: Alessandro Di Federico Reviewed-by: Taylor Simpson --- target/hexagon/gen_helper_funcs.py | 5 +- target/hexagon/gen_helper_protos.py | 5 +-

[PATCH v6 07/12] target/hexagon: prepare input for the idef-parser

2021-07-20 Thread Alessandro Di Federico via
From: Alessandro Di Federico Introduce infrastructure necessary to produce a file suitable for being parsed by the idef-parser. Signed-off-by: Alessandro Di Federico --- target/hexagon/gen_idef_parser_funcs.py | 114 ++ target/hexagon/idef-parser/macros.inc | 153

[PATCH v6 00/12] target/hexagon: introduce idef-parser

2021-07-20 Thread Alessandro Di Federico via
From: Alessandro Di Federico This patchset introduces the idef-parser for target/hexagon. It's the sixth iteration of the patchset and includes fixes suggested in previous iterations. `idef-parser` is a build-time tool built using flex and bison. Its aim is to generate a large part of the tiny

[PATCH v6 08/12] target/hexagon: import lexer for idef-parser

2021-07-20 Thread Alessandro Di Federico via
From: Paolo Montesel Signed-off-by: Alessandro Di Federico Signed-off-by: Paolo Montesel --- target/hexagon/idef-parser/idef-parser.h | 258 +++ target/hexagon/idef-parser/idef-parser.lex| 642 ++ target/hexagon/meson.build| 4 + tests/docker/

[PATCH v6 12/12] gitlab-ci: do not use qemu-project Docker registry

2021-07-20 Thread Alessandro Di Federico via
From: Alessandro Di Federico This commit is necessary in order to use container built by the current run of the CI. If we don't do this, we use official containers which are not affected by the additional dependencies we're introducing. This should be considered as a temporary solution in order

Re: [PATCH 0/6] plugins/cache: multicore cache emulation and minor

2021-07-20 Thread Alex Bennée
Mahmoud Mandour writes: > Hello, > > This series introduce some minor improvements/bug fixes in the cache > plugins and multicore cache modelling. Queued patches 1,2 and 6 for-6.1/fixes-for-rc1 as they are bug fixes, thanks. -- Alex Bennée

Re: [RFC] Rust vhost-user-scsi implementation

2021-07-20 Thread Alex Bennée
Gaelan Steele writes: > Hi all, > > I've been working as one of QEMU's Google Summer of Code interns to > implement a vhost-user-scsi daemon in Rust. That work's now reached a > point where it's usable to attach read-only raw disk images to a VM, > and I'd like to get some feedback from the QEM

[PATCH 06/16] i386: Never free migration blocker objects instead of sometimes

2021-07-20 Thread Markus Armbruster
invtsc_mig_blocker has static storage duration. When a CPU with certain features is initialized, and invtsc_mig_blocker is still null, we add a migration blocker and store it in invtsc_mig_blocker. The object is freed when migrate_add_blocker() fails, leaving invtsc_mig_blocker dangling. It is n

[PATCH 09/16] migration: Unify failure check for migrate_add_blocker()

2021-07-20 Thread Markus Armbruster
Most callers check the return value. Some check whether it set an error. Functionally equivalent, but the former tends to be easier on the eyes, so do that everywhere. Prior art: commit c6ecec43b2 "qemu-option: Check return value instead of @err where convenient". Signed-off-by: Markus Armbrust

[PATCH 08/16] whpx nvmm: Drop useless migrate_del_blocker()

2021-07-20 Thread Markus Armbruster
There is nothing to delete after migrate_add_blocker() failed. Trying anyway is safe, but useless. Don't. Cc: Sunil Muthuswamy Cc: Kamil Rytarowski Cc: Reinoud Zandijk Signed-off-by: Markus Armbruster --- target/i386/nvmm/nvmm-all.c | 1 - target/i386/whpx/whpx-all.c | 1 - 2 files changed,

[PATCH 02/16] spapr: Plug memory leak when we can't add a migration blocker

2021-07-20 Thread Markus Armbruster
Fixes: 2500fb423adb17995485de0b4d507cf2f09e3a7f Cc: Aravinda Prasad Cc: Ganesh Goudar Cc: David Gibson Signed-off-by: Markus Armbruster --- hw/ppc/spapr_events.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/ppc/spapr_events.c b/hw/ppc/spapr_events.c index 0cfc19be19

[PATCH 03/16] spapr: Explain purpose of ->fwnmi_migration_blocker more clearly

2021-07-20 Thread Markus Armbruster
spapr_mce_req_event() makes an effort to prevent migration from degrading the reporting of FWNMIs. It adds a migration blocker when it receives one, and deletes it when it's done handling it. This is a best effort. Commit 2500fb423a "migration: Include migration support for machine check handlin

[PATCH 05/16] vhost-scsi: Plug memory leak on migrate_add_blocker() failure

2021-07-20 Thread Markus Armbruster
Cc: Michael S. Tsirkin Signed-off-by: Markus Armbruster --- hw/scsi/vhost-scsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c index 8c611bfd2d..039caf2614 100644 --- a/hw/scsi/vhost-scsi.c +++ b/hw/scsi/vhost-scsi.c @@ -208,7

[PATCH 10/16] migration: Handle migration_incoming_setup() errors consistently

2021-07-20 Thread Markus Armbruster
Commit b673eab4e2 "multifd: Make multifd_load_setup() get an Error parameter" changed migration_incoming_setup() to take an Error ** argument, and adjusted the callers accordingly. It neglected to change adjust multifd_load_setup(): it still exit()s on error. Clean that up. The error now gets pr

[PATCH 07/16] vfio: Avoid error_propagate() after migrate_add_blocker()

2021-07-20 Thread Markus Armbruster
When migrate_add_blocker(blocker, &errp) is followed by error_propagate(errp, err), we can often just as well do migrate_add_blocker(..., errp). This is the case in vfio_migration_probe(). Prior art: commit 386f6c07d2 "error: Avoid error_propagate() after migrate_add_blocker()". Cc: Kirti Wankhe

[PATCH 04/16] multi-process: Fix pci_proxy_dev_realize() error handling

2021-07-20 Thread Markus Armbruster
The Error ** argument must be NULL, &error_abort, &error_fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing it in between is wrong: if the first call sets an error, it no longer points to NULL for the second call. pci_proxy_dev_realize

[PATCH 12/16] vhost: Clean up how VhostOpts method vhost_get_config() fails

2021-07-20 Thread Markus Armbruster
vhost_user_get_config() can fail without setting an error. Unclean. Its caller vhost_dev_get_config() compensates by substituting a generic error then. Goes back to commit 50de51387f "vhost: Distinguish errors in vhost_dev_get_config()". Clean up by moving the generic error from vhost_dev_get_co

[PATCH 11/16] microvm: Drop dead error handling in microvm_machine_state_init()

2021-07-20 Thread Markus Armbruster
Stillborn in commit 0ebf007dda "hw/i386: Introduce the microvm machine type". Cc: Sergio Lopez Signed-off-by: Markus Armbruster --- hw/i386/microvm.c | 5 - 1 file changed, 5 deletions(-) diff --git a/hw/i386/microvm.c b/hw/i386/microvm.c index aba0c83219..f257ec5a0b 100644 --- a/hw/i386/m

[PATCH 14/16] Remove superfluous ERRP_GUARD()

2021-07-20 Thread Markus Armbruster
Macro ERRP_GUARD() is only needed when we want to dereference @errp or pass it to error_prepend() or error_append_hint(). Delete superfluous ones. Signed-off-by: Markus Armbruster --- hw/remote/mpqemu-link.c | 3 --- qga/commands-posix-ssh.c | 17 - qga/commands-win32.c |

[PATCH 16/16] vl: Don't continue after -smp help.

2021-07-20 Thread Markus Armbruster
We continue after -smp help: $ qemu-system-x86_64 -smp help -display none -monitor stdio smp-opts options: cores= cpus= dies= maxcpus= sockets= threads= QEMU 6.0.50 monitor - type 'help' for more information (qemu) Other options, such as -object

[PATCH 15/16] vl: Clean up -smp error handling

2021-07-20 Thread Markus Armbruster
The Error ** argument must be NULL, &error_abort, &error_fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing it in between is wrong: if the first call sets an error, it no longer points to NULL for the second call. machine_parse_propert

[PATCH 01/16] error: Use error_fatal to simplify obvious fatal errors (again)

2021-07-20 Thread Markus Armbruster
We did this with scripts/coccinelle/use-error_fatal.cocci before, in commit 50beeb68094 and 007b06578ab. This commit cleans up rarer variations that don't seem worth matching with Coccinelle. Cc: Thomas Huth Cc: Cornelia Huck Cc: Peter Xu Cc: Juan Quintela Cc: Stefan Hajnoczi Cc: Paolo Bonzi

[PATCH resend v2 4/5] softmmu/memory_mapping: factor out adding physical memory ranges

2021-07-20 Thread David Hildenbrand
Let's factor out adding a MemoryRegionSection to the list, to be reused in RamDiscardManager context next. Cc: Marc-André Lureau Cc: Paolo Bonzini Cc: "Michael S. Tsirkin" Cc: Eduardo Habkost Cc: Alex Williamson Cc: Dr. David Alan Gilbert Cc: Igor Mammedov Cc: Claudio Fontana Cc: Thomas Hu

[PATCH 13/16] vhost: Clean up how VhostOpts method vhost_backend_init() fails

2021-07-20 Thread Markus Armbruster
vhost_user_backend_init() can fail without setting an error. Unclean. Its caller vhost_dev_init() compensates by substituting a generic error then. Goes back to commit 28770ff935 "vhost: Distinguish errors in vhost_backend_init()". Clean up by moving the generic error from vhost_dev_init() to al

Re: [PATCH v3 0/3] vhost-user: warn when guest RAM is not shared

2021-07-20 Thread Stefan Hajnoczi
On Tue, Jul 20, 2021 at 01:32:43PM +0200, Kevin Wolf wrote: > Am 14.07.2021 um 11:29 hat Stefan Hajnoczi geschrieben: > > v3: > > * Rebased > > v2: > > * Clarify that object-memory-memfd enables share=on by default [Marc-André] > > * Rebased > > > > vhost-user requires -object memory-backend-*,

Re: [PULL v3 05/19] hw/acpi/ich9: Set ACPI PCI hot-plug as default on Q35

2021-07-20 Thread Laurent Vivier
On 20/07/2021 13:38, Laurent Vivier wrote: > On 16/07/2021 17:15, Michael S. Tsirkin wrote: >> From: Julia Suvorova >> >> Q35 has three different types of PCI devices hot-plug: PCIe Native, >> SHPC Native and ACPI hot-plug. This patch changes the default choice >> for cold-plugged bridges from PCI

[PATCH resend v2 2/5] softmmu/memory_mapping: reuse qemu_get_guest_simple_memory_mapping()

2021-07-20 Thread David Hildenbrand
Let's reuse qemu_get_guest_simple_memory_mapping(), which does exactly what we want. Cc: Marc-André Lureau Cc: Paolo Bonzini Cc: "Michael S. Tsirkin" Cc: Eduardo Habkost Cc: Alex Williamson Cc: Dr. David Alan Gilbert Cc: Igor Mammedov Cc: Claudio Fontana Cc: Thomas Huth Cc: "Alex Bennée"

[PATCH 00/16] Various error handling fixes and cleanups

2021-07-20 Thread Markus Armbruster
I doubt the fixes are 6.1 material at this late stage. If you disagree, let me know. Cc: Alex Williamson Cc: Aravinda Prasad Cc: Cornelia Huck Cc: Daniel P. Berrangé Cc: David Gibson Cc: Dr. David Alan Gilbert Cc: Eduardo Habkost Cc: Elena Ufimtseva Cc: Ganesh Goudar Cc: Gerd Hoffmann C

  1   2   3   4   5   >