Hi, peter
Thank you for your comment.
> Hi; it looks like something with your outgoing email setup still disagrees
> with QEMU's mailing list server :-( As far as I can tell these emails didn't
> make it to the list, so only people on the direct-cc list will have
> seen them :-(
As you said, it
On 7/19/21 5:52 PM, Daniel P. Berrangé wrote:
On Mon, Jul 19, 2021 at 05:43:29PM +0200, Cornelia Huck wrote:
(restored cc:s)
On Fri, Jul 16 2021, Pierre Morel wrote:
On 7/16/21 11:14 AM, Daniel P. Berrangé wrote:
I increasingly worry that we're making a mistake by going down the
route of
On 7/19/21 5:50 PM, Cornelia Huck wrote:
On Fri, Jul 16 2021, Daniel P. Berrangé wrote:
On Fri, Jul 16, 2021 at 12:44:49PM +0200, Cornelia Huck wrote:
On Fri, Jul 16 2021, Daniel P. Berrangé wrote:
On Fri, Jul 16, 2021 at 11:10:04AM +0200, Cornelia Huck wrote:
On Thu, Jul 15 2021, Mark
"Dr. David Alan Gilbert (git)" wrote:
> From: "Dr. David Alan Gilbert"
>
> OpenBSD doesn't like :0 as an address, switch to using 127.0.0.1
> in baddest; it's really testing the :0 port number that isn't allowed
> on anything.
>
> (The test doesn't currently run anyway because of the userfault
>
* Peter Maydell (peter.mayd...@linaro.org) wrote:
> On Mon, 19 Jul 2021 at 13:43, Peter Maydell wrote:
> >
> > Random crash in migration-tests:
> >
> > MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
> > QTEST_QEMU_IMG=./qemu-img G_TEST_DBUS_DAEMON=/mnt/nvmedisk/linaro/qem
> > u-f
On 20/07/2021 03.12, Eric Blake wrote:
On Mon, Jul 19, 2021 at 10:06:01AM +0200, Thomas Huth wrote:
Hi,
iotest 206 fails for me with:
--- 206.out
+++ 206.out.bad
@@ -99,55 +99,19 @@
{"execute": "blockdev-create", "arguments": {"job-id": "job0", "options":
{"driver": "qcow2", "encrypt":
On Tue, Jul 20 2021, Pierre Morel wrote:
> On 7/19/21 5:50 PM, Cornelia Huck wrote:
>> On Fri, Jul 16 2021, Daniel P. Berrangé wrote:
>>> Is the book/drawer thing architecture specific, or is it machine
>>> type / CPU specific. ie do /all/ the s390x machine types / CPUS
>>> QEMU support the book
On Mon, Jul 12, 2021 at 03:10:30PM +0200, Paolo Bonzini wrote:
The LuringState typedef is defined twice, in include/block/raw-aio.h and
block/io_uring.c. Move it in include/block/aio.h, which is included
everywhere the typedef is needed, since include/block/aio.h already has
to define the forwar
On Mon, Jul 19, 2021 at 08:12:58PM -0500, Eric Blake wrote:
> On Mon, Jul 19, 2021 at 10:06:01AM +0200, Thomas Huth wrote:
> > Hi,
> >
> > iotest 206 fails for me with:
> >
>
> > --- 206.out
> > +++ 206.out.bad
> > @@ -99,55 +99,19 @@
> >
> > {"execute": "blockdev-create", "arguments": {"job-
On 7/20/21 9:37 AM, Pierre Morel wrote:
On 7/19/21 5:52 PM, Daniel P. Berrangé wrote:
On Mon, Jul 19, 2021 at 05:43:29PM +0200, Cornelia Huck wrote:
(restored cc:s)
On Fri, Jul 16 2021, Pierre Morel wrote:
On 7/16/21 11:14 AM, Daniel P. Berrangé wrote:
I increasingly worry that we're
On 7/20/21 10:20 AM, Cornelia Huck wrote:
On Tue, Jul 20 2021, Pierre Morel wrote:
On 7/19/21 5:50 PM, Cornelia Huck wrote:
On Fri, Jul 16 2021, Daniel P. Berrangé wrote:
Is the book/drawer thing architecture specific, or is it machine
type / CPU specific. ie do /all/ the s390x machine t
On Tue, Jul 20 2021, Pierre Morel wrote:
> On 7/20/21 10:20 AM, Cornelia Huck wrote:
>> On Tue, Jul 20 2021, Pierre Morel wrote:
>>
>>> On 7/19/21 5:50 PM, Cornelia Huck wrote:
On Fri, Jul 16 2021, Daniel P. Berrangé wrote:
> Is the book/drawer thing architecture specific, or is it ma
On Mon, 19 Jul 2021 at 18:27, Max Reitz wrote:
>
> The following changes since commit 7457b407edd6e8555e4b46488aab2f13959fccf8:
>
> Merge remote-tracking branch
> 'remotes/thuth-gitlab/tags/pull-request-2021-07-19' into staging (2021-07-19
> 11:34:08 +0100)
>
> are available in the Git reposit
On Mon, 19 Jul 2021 at 23:20, Kenneth Adam Miller
wrote:
>
> Hello,
>
> I get the following error:
>
> -c ../accel/tcg/cputlb.c
> ../qemu/accel/tcg/cputlb.c: In function 'tlb_flush_page_by_mmuidx':
> ../qemu/accel/tcg/cputlb.c:602:23: error: comparison is always true due to
> limited range of da
On Tue, 20 Jul 2021 at 08:35, ishii.shuuic...@fujitsu.com
wrote:
>
> Hi, peter
> Thank you for your comment.
>
> > Hi; it looks like something with your outgoing email setup still disagrees
> > with QEMU's mailing list server :-( As far as I can tell these emails
> > didn't
> > make it to the li
On Tue, Jul 20, 2021 at 10:46:31AM +0200, Pierre Morel wrote:
>
>
> On 7/20/21 10:20 AM, Cornelia Huck wrote:
> > On Tue, Jul 20 2021, Pierre Morel wrote:
> >
> > > On 7/19/21 5:50 PM, Cornelia Huck wrote:
> > > > On Fri, Jul 16 2021, Daniel P. Berrangé wrote:
> > > > > Is the book/drawer thin
On Wed, Jul 14, 2021 at 9:47 PM Cleber Rosa wrote:
> Since 49afbca3b, the use of an optional virgl renderer is not
> available anymore, and since b36eb8860f, the way to choose a GL based
> rendered is to use the "virtio-vga-gl" device.
>
> Signed-off-by: Cleber Rosa
>
Reviewed-by: Marc-André Lu
Richard Henderson writes:
> On 7/19/21 11:48 AM, Alex Bennée wrote:
>> diff --git a/tests/docker/dockerfiles/debian-tricore-cross.docker
>> b/tests/docker/dockerfiles/debian-tricore-cross.docker
>> index 985925134c..4ea9112289 100644
>> --- a/tests/docker/dockerfiles/debian-tricore-cross.docke
Peter Maydell writes:
> On Mon, 19 Jul 2021 at 20:52, Alex Bennée wrote:
>>
>> We inadvertently added a symbol clash causing the build not to include
>> the testboard needed for check-tcg.
>>
>> Fixes: f4063f9c31 ("meson: Introduce target-specific Kconfig")
>> Signed-off-by: Alex Bennée
>> --
On Tue, 20 Jul 2021 at 10:47, Alex Bennée wrote:
>
>
> Peter Maydell writes:
>
> > On Mon, 19 Jul 2021 at 20:52, Alex Bennée wrote:
> >>
> >> We inadvertently added a symbol clash causing the build not to include
> >> the testboard needed for check-tcg.
> >>
> >> Fixes: f4063f9c31 ("meson: Intro
Hi all,
I've been working as one of QEMU's Google Summer of Code interns to
implement a vhost-user-scsi daemon in Rust. That work's now reached a
point where it's usable to attach read-only raw disk images to a VM,
and I'd like to get some feedback from the QEMU community, especially
anyone with e
On Sat, 17 Jul 2021 at 21:40, Richard Henderson
wrote:
>
> On 7/17/21 3:06 AM, Peter Maydell wrote:
> > On Fri, 16 Jul 2021 at 23:12, Richard Henderson
> > wrote:
> >>
> >> On 7/13/21 6:37 AM, Peter Maydell wrote:
> >>> Implement the MVE VMLAS insn, which multiplies a vector by a vector
> >>> and
* Peter Maydell (peter.mayd...@linaro.org) wrote:
> On Mon, 19 Jul 2021 at 13:43, Peter Maydell wrote:
> >
> > Random crash in migration-tests:
> >
> > MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
> > QTEST_QEMU_IMG=./qemu-img G_TEST_DBUS_DAEMON=/mnt/nvmedisk/linaro/qem
> > u-f
On Mon, Jul 19, 2021 at 12:35:53PM +0200, Stefano Garzarella wrote:
> On Tue, Jul 13, 2021 at 03:58:04PM +0100, Stefan Hajnoczi wrote:
> > On Wed, Jul 07, 2021 at 05:00:19PM +0200, Stefano Garzarella wrote:
> > > @@ -371,7 +375,7 @@ static int laio_do_submit(int fd, struct qemu_laiocb
> > > *laioc
Peter Maydell writes:
> On Tue, 20 Jul 2021 at 10:47, Alex Bennée wrote:
>>
>>
>> Peter Maydell writes:
>>
>> > On Mon, 19 Jul 2021 at 20:52, Alex Bennée wrote:
>> >>
>> >> We inadvertently added a symbol clash causing the build not to include
>> >> the testboard needed for check-tcg.
>> >>
Alex Bennée writes:
> Peter Maydell writes:
>
>> On Tue, 20 Jul 2021 at 10:47, Alex Bennée wrote:
>>>
>>>
>>> Peter Maydell writes:
>>>
>>> > On Mon, 19 Jul 2021 at 20:52, Alex Bennée wrote:
>>> >>
>>> >> We inadvertently added a symbol clash causing the build not to include
>>> >> the test
Hi Ishii,
On 7/20/21 9:34 AM, ishii.shuuic...@fujitsu.com wrote:
> Hi, peter
> Thank you for your comment.
>
>> Hi; it looks like something with your outgoing email setup still disagrees
>> with QEMU's mailing list server :-( As far as I can tell these emails didn't
>> make it to the list, so on
Am 14.07.2021 um 11:29 hat Stefan Hajnoczi geschrieben:
> v3:
> * Rebased
> v2:
> * Clarify that object-memory-memfd enables share=on by default [Marc-André]
> * Rebased
>
> vhost-user requires -object memory-backend-*,share=on option so that QEMU uses
> mmap(MAP_SHARED) on guest RAM that is sh
Move the logic to more generic qemu_img_pipe_and_status(). Also behave
better when we have several -o options. And reuse argument parser of
course.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/iotests.py | 36 +--
1 file changed, 17 insertion
On 16/07/2021 17:15, Michael S. Tsirkin wrote:
> From: Julia Suvorova
>
> Q35 has three different types of PCI devices hot-plug: PCIe Native,
> SHPC Native and ACPI hot-plug. This patch changes the default choice
> for cold-plugged bridges from PCIe Native to ACPI Hot-plug with
> ability to use S
These series makes tests pass with
IMGOPTS='compression_type=zstd'
Also, python iotests start to support IMGOPTS (they didn't before).
v2:
01: add Max's r-b
02: simplify a lot: just add separate -o for IMGOPTS.
also, don't bother with catching compat=0.10
03,04: new
05: add Max's r-b
06:
If image doesn't have any compressed cluster we can easily switch to
zlib compression, which may allow to downgrade the image.
That's mostly needed to support IMGOPTS='compression_type=zstd' in some
iotests which do qcow2 downgrade.
While being here also fix checkpatch complain against '#' in pri
qemu_img_verbose() has a drawback of not going through generic
qemu_img_pipe_and_status(). qemu_img_verbose() is not very popular, so
update the only two users to qemu_img_log() and drop qemu_img_verbose()
at all.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/044| 5
The test checks different options. It of course fails if set
IMGOPTS='compression_type=zstd'. So, let's be explicit in what
compression type we want and independent of IMGOPTS. Test both existing
compression types.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/065 | 16 +
Adding support of IMGOPTS (like in bash tests) allows user to pass a
lot of different options. Still, some may require additional logic.
Now we want compression_type option, so add some smart logic around it:
ignore compression_type=zstd in IMGOPTS, if test want qcow2 in
compatibility mode. As wel
We want iotests pass with both the default zlib compression and with
IMGOPTS='compression_type=zstd'.
Actually the only test that is interested in real compression type in
test output is 287 (test for qcow2 compression type), so implement
specific option for it.
Signed-off-by: Vladimir Sementsov-
The only "feature" of this "Formatting ..." line is that we have to
update it every time we add new option. Let's drop it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/255.out| 4
tests/qemu-iotests/274.out| 29 -
tests/qemu-iotests
Rather than base of the shared Debian 10 container which would require
us to bring in even more dependencies just bring in what is needed for
building tricore-softmmu in GitLab. We don't even remove the container
from the DOCKER_PARTIAL_IMAGES lest we cause more confusion.
Signed-off-by: Alex Benn
We are going to support IMGOPTS environment variable like in bash
tests. Corresponding global variable in iotests.py should be called
imgopts. So to not interfere with function argument, rename it in
advance.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
---
tests/qemu-iote
We'll use it in tests instead of explicit qcow2.py. Then we are going
to add some filtering in _qcow2_dump_header.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
---
tests/qemu-iotests/common.rc | 10 ++
1 file changed, 10 insertions(+)
diff --git a/tests/qemu-iotes
We want iotests pass with both the default zlib compression and with
IMGOPTS='compression_type=zstd'.
Actually the only test that is interested in real compression type in
test output is 287 (test for qcow2 compression type) and it's in bash.
So for now we can safely filter out compression type in
On 7/20/21 11:55 AM, Gaelan Steele wrote:
> Hi all,
>
> I've been working as one of QEMU's Google Summer of Code interns to
> implement a vhost-user-scsi daemon in Rust. That work's now reached a
> point where it's usable to attach read-only raw disk images to a VM,
> and I'd like to get some feed
The test prints qcow2 header fields which depends on chosen compression
type. So, let's be explicit in what compression type we want and
independent of IMGOPTS. Test both existing compression types.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
---
tests/qemu-iotests/303
We are going to add filtering in _qcow2_dump_header and want all tests
use it.
The patch is generated by commands:
cd tests/qemu-iotests
sed -ie 's/$PYTHON qcow2.py "$TEST_IMG" dump-header\($\|
\)/_qcow2_dump_header\1/' ??? tests/*
(the difficulty is to avoid converting dump-header-exts)
Si
Instead of qemu_img_log("info", ..) use generic helper img_info_log().
img_info_log() has smarter logic. For example it use filter_img_info()
to filter output, which in turns filter a compression type. So it will
help us in future when we implement a possibility to use zstd
compression by default
On 7/19/21 8:52 PM, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert"
>
> OpenBSD doesn't like :0 as an address, switch to using 127.0.0.1
> in baddest; it's really testing the :0 port number that isn't allowed
> on anything.
>
> (The test doesn't currently run anyway because
compression_type can't be used if we want to create image with
compat=0.10. So, skip these tests, not many of them.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/031 | 5 +++--
tests/qemu-iotests/051 | 5 +++--
tests/qemu-iotests/061 | 6 +-
tests/qemu-iotests/112 | 3 ++
Up until this point we only handled local compilers or assumed we had
everything in the container. This falls down when we are building QEMU
inside the container.
This special handling only affects tricore for now but I put it in a
case just in case we add any other "special" targets. Setting
CROS
_qcow2_dump_header has filter for compression type, so this change
makes test pass with IMGOPTS='compression_type=zstd'.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
---
tests/qemu-iotests/039 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-i
On 7/20/21 12:02 AM, Joe Komlodi wrote:
> If we have a field that's wider than 32-bits, we need a data type wide enough
> to
> be able to create the bitfield used to deposit the value.
>
> Signed-off-by: Joe Komlodi
> ---
> include/hw/registerfields.h | 2 +-
> 1 file changed, 1 insertion(+), 1
The test-case "Corrupted size field in compressed cluster descriptor"
heavily depends on zlib compression type. So, make it explicit. This
way test passes with IMGOPTS='compression_type=zstd'.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
---
tests/qemu-iotests/214 | 2 +-
Don't touch other incompatible bits, like compression-type. This makes
the test pass with IMGOPTS='compression_type=zstd'.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
---
tests/qemu-iotests/060 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu
On 7/20/21 3:17 AM, Richard Henderson wrote:
> New hook to return true when an architectural breakpoint is
> to be recognized and false when it should be suppressed.
>
> First use must wait until other pieces are in place.
>
> Signed-off-by: Richard Henderson
> ---
> include/hw/core/tcg-cpu-ops
We inadvertently added a symbol clash causing the build not to include
the testboard needed for check-tcg.
Fixes: f4063f9c31 ("meson: Introduce target-specific Kconfig")
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Peter Maydell
Reviewed-by: Richard Henderson
Signed-off-by: Alex Bennée
--
On 7/20/21 3:17 AM, Richard Henderson wrote:
> We are certain of a page crossing here, entering the
> PALcode image, so the call to use_goto_tb that should
> have been here will never succeed.
>
> We are shortly going to add an assert to tcg_gen_goto_tb
> that would trigger for this case.
>
> Sig
On 7/20/21 3:17 AM, Richard Henderson wrote:
> The access internal to tb_cflags() is atomic.
> Avoid re-reading it as such for the multiple uses.
>
> Reviewed-by: Alex Bennée
> Signed-off-by: Richard Henderson
> ---
> accel/tcg/translator.c | 9 -
> 1 file changed, 4 insertions(+), 5 de
On 7/20/21 3:17 AM, Richard Henderson wrote:
> Reuse the code at the bottom of helper_check_breakpoints,
> which is what we currently call from *_tr_breakpoint_check.
>
> Signed-off-by: Richard Henderson
> ---
> target/arm/internals.h| 3 +++
> target/arm/cpu.c | 1 +
> target/arm/c
Hi,
This fixes check-tcg for tricore and adds a test to the gitlab matrix
so we don't miss it breaking again.
v3
- added new patch for configure.sh
- changed symbol for board
The following need review:
- gitlab: enable a very minimal build with the tricore container
- tests/tcg/configure.
From: NDNF
This adds hmp 'info tlb' command support for the mips platform.
1k pages are not supported.
Signed-off-by: NDNF
---
hmp-commands-info.hx | 3 ++-
target/mips/cpu.h| 3 +++
target/mips/meson.build | 1 +
target/mips/monitor.c| 26 ++
target/mip
> On Jul 19, 2021, at 4:24 PM, John Levon wrote:
>
> On Mon, Jul 19, 2021 at 04:00:03PM -0400, Jagannathan Raman wrote:
>
>> add the libvfio-user library as a submodule. build it as part of QEMU
>>
>> diff --git a/meson.build b/meson.build
>> index 6e4d2d8..f2f9f86 100644
>> --- a/meson.build
On Wed, 30 Jun 2021 15:07:16 -0400
Eric DeVolder wrote:
> This change implements the support for the ACPI ERST feature.
Drop this
>
> This implements a PCI device for ACPI ERST. This implments the
s/implments/implements/
> non-NVRAM "mode" of operation for ERST.
add here why non-NVRAM "mode" i
Hi
On Tue, Jul 20, 2021 at 4:12 PM Jag Raman wrote:
>
>
> > On Jul 19, 2021, at 4:24 PM, John Levon wrote:
> >
> > On Mon, Jul 19, 2021 at 04:00:03PM -0400, Jagannathan Raman wrote:
> >
> >> add the libvfio-user library as a submodule. build it as part of QEMU
> >>
> >> diff --git a/meson.build
On 7/20/21 11:19 AM, Daniel P. Berrangé wrote:
On Tue, Jul 20, 2021 at 10:46:31AM +0200, Pierre Morel wrote:
On 7/20/21 10:20 AM, Cornelia Huck wrote:
On Tue, Jul 20 2021, Pierre Morel wrote:
On 7/19/21 5:50 PM, Cornelia Huck wrote:
On Fri, Jul 16 2021, Daniel P. Berrangé wrote:
Is t
From: Alessandro Di Federico
Signed-off-by: Alessandro Di Federico
Reviewed-by: Richard Henderson
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 4256ad1adb..6c825a9eb4 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -194,6 +194,8 @@ He
From: Niccolò Izzo
These helpers will be employed by the idef-parser generated code.
Signed-off-by: Alessandro Di Federico
Signed-off-by: Niccolò Izzo
---
target/hexagon/genptr.h | 15 +-
target/hexagon/macros.h | 9
target/hexagon/genptr.c | 113 ++
On Mon, Jul 19, 2021, 14:37 Alex Bennée wrote:
> In user-mode emulation there is a small race between preexit_cleanup
> and exit_group() which means we may end up calling instrumented
> instructions before the kernel reaps child threads. To solve this we
> implement a new helper which ensures the
From: Paolo Montesel
Signed-off-by: Alessandro Di Federico
Signed-off-by: Paolo Montesel
Acked-by: Richard Henderson
---
target/hexagon/macros.h | 2 +-
target/hexagon/genptr.c | 24 +---
2 files changed, 14 insertions(+), 12 deletions(-)
diff --git a/target/hexagon/macr
From: Paolo Montesel
Signed-off-by: Alessandro Di Federico
Signed-off-by: Paolo Montesel
Reviewed-by: Richard Henderson
Reviewed-by: Taylor Simpson
---
target/hexagon/translate.h | 1 +
target/hexagon/translate.c | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/target/h
From: Paolo Montesel
Make certain helper functions non-static, making them available outside
genptr.c. These functions are required by code generated by the
idef-parser.
This commit also makes some op_helper.c non-static in order to avoid
having them marked as unused when using the idef-parser g
From: Niccolò Izzo
Signed-off-by: Alessandro Di Federico
Signed-off-by: Niccolò Izzo
---
tests/tcg/hexagon/Makefile.target | 30 +-
tests/tcg/hexagon/crt.S| 26
tests/tcg/hexagon/test_abs.S | 20 ++
tests/tcg/hexagon/test_bitcnt.S| 42 +++
From: Alessandro Di Federico
Signed-off-by: Alessandro Di Federico
---
target/hexagon/idef-parser/README.rst | 447 ++
target/hexagon/README | 5 +
2 files changed, 452 insertions(+)
create mode 100644 target/hexagon/idef-parser/README.rst
diff --git
From: Paolo Montesel
Signed-off-by: Alessandro Di Federico
Signed-off-by: Paolo Montesel
---
target/hexagon/idef-parser/parser-helpers.h | 346 +++
target/hexagon/idef-parser/parser-helpers.c | 2396 +
target/hexagon/idef-parser/idef-parser.y | 975 +++
target/he
From: Alessandro Di Federico
Extend gen_tcg_funcs.py in order to emit calls to the functions emitted
by the idef-parser, if available.
Signed-off-by: Alessandro Di Federico
Reviewed-by: Taylor Simpson
---
target/hexagon/gen_helper_funcs.py | 5 +-
target/hexagon/gen_helper_protos.py | 5 +-
From: Alessandro Di Federico
Introduce infrastructure necessary to produce a file suitable for being
parsed by the idef-parser.
Signed-off-by: Alessandro Di Federico
---
target/hexagon/gen_idef_parser_funcs.py | 114 ++
target/hexagon/idef-parser/macros.inc | 153
From: Alessandro Di Federico
This patchset introduces the idef-parser for target/hexagon.
It's the sixth iteration of the patchset and includes fixes suggested in
previous iterations.
`idef-parser` is a build-time tool built using flex and bison. Its aim
is to generate a large part of the tiny
From: Paolo Montesel
Signed-off-by: Alessandro Di Federico
Signed-off-by: Paolo Montesel
---
target/hexagon/idef-parser/idef-parser.h | 258 +++
target/hexagon/idef-parser/idef-parser.lex| 642 ++
target/hexagon/meson.build| 4 +
tests/docker/
From: Alessandro Di Federico
This commit is necessary in order to use container built by the current
run of the CI. If we don't do this, we use official containers which are
not affected by the additional dependencies we're introducing.
This should be considered as a temporary solution in order
Mahmoud Mandour writes:
> Hello,
>
> This series introduce some minor improvements/bug fixes in the cache
> plugins and multicore cache modelling.
Queued patches 1,2 and 6 for-6.1/fixes-for-rc1 as they are bug fixes, thanks.
--
Alex Bennée
Gaelan Steele writes:
> Hi all,
>
> I've been working as one of QEMU's Google Summer of Code interns to
> implement a vhost-user-scsi daemon in Rust. That work's now reached a
> point where it's usable to attach read-only raw disk images to a VM,
> and I'd like to get some feedback from the QEM
invtsc_mig_blocker has static storage duration. When a CPU with
certain features is initialized, and invtsc_mig_blocker is still null,
we add a migration blocker and store it in invtsc_mig_blocker.
The object is freed when migrate_add_blocker() fails, leaving
invtsc_mig_blocker dangling. It is n
Most callers check the return value. Some check whether it set an
error. Functionally equivalent, but the former tends to be easier on
the eyes, so do that everywhere.
Prior art: commit c6ecec43b2 "qemu-option: Check return value instead
of @err where convenient".
Signed-off-by: Markus Armbrust
There is nothing to delete after migrate_add_blocker() failed. Trying
anyway is safe, but useless. Don't.
Cc: Sunil Muthuswamy
Cc: Kamil Rytarowski
Cc: Reinoud Zandijk
Signed-off-by: Markus Armbruster
---
target/i386/nvmm/nvmm-all.c | 1 -
target/i386/whpx/whpx-all.c | 1 -
2 files changed,
Fixes: 2500fb423adb17995485de0b4d507cf2f09e3a7f
Cc: Aravinda Prasad
Cc: Ganesh Goudar
Cc: David Gibson
Signed-off-by: Markus Armbruster
---
hw/ppc/spapr_events.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/ppc/spapr_events.c b/hw/ppc/spapr_events.c
index 0cfc19be19
spapr_mce_req_event() makes an effort to prevent migration from
degrading the reporting of FWNMIs. It adds a migration blocker when
it receives one, and deletes it when it's done handling it. This is a
best effort.
Commit 2500fb423a "migration: Include migration support for machine
check handlin
Cc: Michael S. Tsirkin
Signed-off-by: Markus Armbruster
---
hw/scsi/vhost-scsi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c
index 8c611bfd2d..039caf2614 100644
--- a/hw/scsi/vhost-scsi.c
+++ b/hw/scsi/vhost-scsi.c
@@ -208,7
Commit b673eab4e2 "multifd: Make multifd_load_setup() get an Error
parameter" changed migration_incoming_setup() to take an Error **
argument, and adjusted the callers accordingly. It neglected to
change adjust multifd_load_setup(): it still exit()s on error. Clean
that up.
The error now gets pr
When migrate_add_blocker(blocker, &errp) is followed by
error_propagate(errp, err), we can often just as well do
migrate_add_blocker(..., errp). This is the case in
vfio_migration_probe().
Prior art: commit 386f6c07d2 "error: Avoid error_propagate() after
migrate_add_blocker()".
Cc: Kirti Wankhe
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call.
pci_proxy_dev_realize
vhost_user_get_config() can fail without setting an error. Unclean.
Its caller vhost_dev_get_config() compensates by substituting a
generic error then. Goes back to commit 50de51387f "vhost:
Distinguish errors in vhost_dev_get_config()".
Clean up by moving the generic error from vhost_dev_get_co
Stillborn in commit 0ebf007dda "hw/i386: Introduce the microvm machine
type".
Cc: Sergio Lopez
Signed-off-by: Markus Armbruster
---
hw/i386/microvm.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/hw/i386/microvm.c b/hw/i386/microvm.c
index aba0c83219..f257ec5a0b 100644
--- a/hw/i386/m
Macro ERRP_GUARD() is only needed when we want to dereference @errp or
pass it to error_prepend() or error_append_hint(). Delete superfluous
ones.
Signed-off-by: Markus Armbruster
---
hw/remote/mpqemu-link.c | 3 ---
qga/commands-posix-ssh.c | 17 -
qga/commands-win32.c |
We continue after -smp help:
$ qemu-system-x86_64 -smp help -display none -monitor stdio
smp-opts options:
cores=
cpus=
dies=
maxcpus=
sockets=
threads=
QEMU 6.0.50 monitor - type 'help' for more information
(qemu)
Other options, such as -object
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call.
machine_parse_propert
We did this with scripts/coccinelle/use-error_fatal.cocci before, in
commit 50beeb68094 and 007b06578ab. This commit cleans up rarer
variations that don't seem worth matching with Coccinelle.
Cc: Thomas Huth
Cc: Cornelia Huck
Cc: Peter Xu
Cc: Juan Quintela
Cc: Stefan Hajnoczi
Cc: Paolo Bonzi
Let's factor out adding a MemoryRegionSection to the list, to be reused in
RamDiscardManager context next.
Cc: Marc-André Lureau
Cc: Paolo Bonzini
Cc: "Michael S. Tsirkin"
Cc: Eduardo Habkost
Cc: Alex Williamson
Cc: Dr. David Alan Gilbert
Cc: Igor Mammedov
Cc: Claudio Fontana
Cc: Thomas Hu
vhost_user_backend_init() can fail without setting an error. Unclean.
Its caller vhost_dev_init() compensates by substituting a generic
error then. Goes back to commit 28770ff935 "vhost: Distinguish errors
in vhost_backend_init()".
Clean up by moving the generic error from vhost_dev_init() to al
On Tue, Jul 20, 2021 at 01:32:43PM +0200, Kevin Wolf wrote:
> Am 14.07.2021 um 11:29 hat Stefan Hajnoczi geschrieben:
> > v3:
> > * Rebased
> > v2:
> > * Clarify that object-memory-memfd enables share=on by default [Marc-André]
> > * Rebased
> >
> > vhost-user requires -object memory-backend-*,
On 20/07/2021 13:38, Laurent Vivier wrote:
> On 16/07/2021 17:15, Michael S. Tsirkin wrote:
>> From: Julia Suvorova
>>
>> Q35 has three different types of PCI devices hot-plug: PCIe Native,
>> SHPC Native and ACPI hot-plug. This patch changes the default choice
>> for cold-plugged bridges from PCI
Let's reuse qemu_get_guest_simple_memory_mapping(), which does exactly
what we want.
Cc: Marc-André Lureau
Cc: Paolo Bonzini
Cc: "Michael S. Tsirkin"
Cc: Eduardo Habkost
Cc: Alex Williamson
Cc: Dr. David Alan Gilbert
Cc: Igor Mammedov
Cc: Claudio Fontana
Cc: Thomas Huth
Cc: "Alex Bennée"
I doubt the fixes are 6.1 material at this late stage. If you
disagree, let me know.
Cc: Alex Williamson
Cc: Aravinda Prasad
Cc: Cornelia Huck
Cc: Daniel P. Berrangé
Cc: David Gibson
Cc: Dr. David Alan Gilbert
Cc: Eduardo Habkost
Cc: Elena Ufimtseva
Cc: Ganesh Goudar
Cc: Gerd Hoffmann
C
1 - 100 of 411 matches
Mail list logo