And change the default to true so that '-incoming defer' can enable
multifd first.
Signed-off-by: Li Zhijian
---
migration/migration.c | 8
migration/multifd.c | 2 +-
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/migration/migration.c b/migration/migration.c
index d6d
multifd with unsupported protocal will cause a segment fault.
(gdb) bt
#0 0x563b4a93faf8 in socket_connect (addr=0x0, errp=0x7f7f02675410) at
../util/qemu-sockets.c:1190
#1 0x563b4a797a03 in qio_channel_socket_connect_sync (ioc=0x563b4d16e8c0,
addr=0x0, errp=0x7f7f02675410) at ../io/c
On Wed, 14 Jul 2021 at 22:36, Alex Williamson
wrote:
>
> The following changes since commit a9649a719a44894b81f38dc1c5c1888ee684acef:
>
> Merge remote-tracking branch
> 'remotes/cleber-gitlab/tags/python-next-pull-request' into staging
> (2021-07-14 18:09:09 +0100)
>
> are available in the Git
Passing arguments to plugins had to be done through "arg=".
This is redundant and introduces confusion especially when the argument
has a name and value (e.g. `-plugin plugin_name,arg="argname=argvalue"`).
This allows passing plugin arguments directly e.g:
`-plugin plugin_name,argname=argvalu
Hello,
This series removes passing arguments to plugins through "arg=" since
it's redundant and reduces readability especially when the argument
itself is composed of a name and a value.
Also, passing arguments through "arg=" still works but is marked as
deprecated and will produce a deprecation
This call will help boolean argument parsing since arguments are now
passed to plugins as a name and value.
Signed-off-by: Mahmoud Mandour
---
include/qemu/qemu-plugin.h | 13 +
plugins/api.c | 5 +
2 files changed, 18 insertions(+)
diff --git a/include/qemu/qemu-p
Signed-off-by: Mahmoud Mandour
---
contrib/plugins/hotblocks.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/contrib/plugins/hotblocks.c b/contrib/plugins/hotblocks.c
index 4b08340143..062200a7a4 100644
--- a/contrib/plugins/hotblocks.c
+++ b/contrib/plugins/
Since plugin arguments now expect boolean arguments, a plugin argument
name "sortby" now expects a value of "read", "write", or "address".
"io" arg is now expected to be passed as a full-form boolean parameter,
i.e. "io=on|true|yes|off|false|no"
Signed-off-by: Mahmoud Mandour
---
contrib/plugin
Signed-off-by: Mahmoud Mandour
---
contrib/plugins/lockstep.c | 31 ++-
docs/devel/tcg-plugins.rst | 2 +-
2 files changed, 23 insertions(+), 10 deletions(-)
diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c
index 7fd35eb669..a41ffe83fa 100644
---
Signed-off-by: Mahmoud Mandour
---
docs/devel/tcg-plugins.rst | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/docs/devel/tcg-plugins.rst b/docs/devel/tcg-plugins.rst
index 4ab9dc4bb1..be1256d50c 100644
--- a/docs/devel/tcg-plugins.rst
+++ b/docs/devel/tcg-pl
Signed-off-by: Mahmoud Mandour
---
docs/system/deprecated.rst | 6 ++
1 file changed, 6 insertions(+)
diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst
index e2e0090878..aaf0ee5777 100644
--- a/docs/system/deprecated.rst
+++ b/docs/system/deprecated.rst
@@ -126,6 +126,12 @
Parsing boolean arguments correctly (e.g. pattern=on or source=false).
Introduced a new "track" argument that takes a [read|write] value. This
substitutes passing read or write to "arg=" that is deprecated.
Also, matches are now taken one by one through the "match" argument.
Signed-off-by: Mahmou
Correctly parsing plugin argument since they now must be provided as
full-form boolean parameters, e.g.:
-plugin ./contrib/plugins/libhowvec.so,verbose=on,inline=on
Also, introduced the argument "count" that accepts one opt to count
individually at a time.
Signed-off-by: Mahmoud Mandour
---
On Fri, Jul 16, 2021 at 10:04 AM Mahmoud Mandour
wrote:
> Hello,
>
> This series removes passing arguments to plugins through "arg=" since
> it's redundant and reduces readability especially when the argument
> itself is composed of a name and a value.
>
> Also, passing arguments through "arg=" s
On Wed, Jul 14, 2021 at 9:57 AM Akihiko Odaki
wrote:
> ui/egl-headless is only built when CONFIG_OPENGL is defined because it
> depends on CONFIG_OPENGL without condition. Remove a redundant
> conditonal in ui/egl-headless.c
>
> Signed-off-by: Akihiko Odaki
>
Reviewed-by: Marc-André Lureau
--
On Wed, Jul 14, 2021 at 9:58 AM Akihiko Odaki
wrote:
> Some code in ui/spice used CONFIG_OPENGL for OpenGL conditionals, but
> SPICE also depends on CONFIG_GBM and SPICE server whose version is
> 0.13.1 or later for OpenGL. Always use HAVE_SPICE_GL, which defines the
> precise condition.
>
> Sign
+/*
+ * CLEAR_BITMAP_SHIFT_MIN should always guarantee this... this
+ * can make things easier sometimes since then start address
+ * of the small chunk will always be 64 pages aligned so the
+ * bitmap will always be aligned to unsigned long. We should
+ * even be able to
On Wed, 14 Jul 2021 at 20:46, Tianrui Wei wrote:
>
> For redistributor to send sgi, we must test NSACR bits in secure mode.
> However, current implementation inverts the security check, wrongly
> skipping this it when the CPU is in secure state, and only carrying out
> the check when the CPU is no
On Fri, Jul 16, 2021 at 07:41:16AM +0100, Peter Maydell wrote:
> On Thu, 15 Jul 2021 at 22:21, Michael S. Tsirkin wrote:
> >
> > On Wed, Jul 14, 2021 at 09:31:21PM +0100, Peter Maydell wrote:
> > > On Tue, 13 Jul 2021 at 23:10, Michael S. Tsirkin wrote:
> > > >
> > > > The following changes since
On Wed, 14 Jul 2021 at 19:06, Richard Henderson
wrote:
>
> Rename from sve_zcr_get_valid_len and make accessible
> from outside of helper.c.
>
> Signed-off-by: Richard Henderson
> ---
> target/arm/cpu.h| 2 ++
> target/arm/helper.c | 8 +---
> 2 files changed, 7 insertions(+), 3 deletion
On Wed, Jul 14 2021, Pierre Morel wrote:
> We need a s390x dedicated SMP parsing to handle s390x specificities.
>
> In this patch we only handle threads, cores and sockets for
> s390x:
> - do not support threads, we always have 1 single thread per core
> - the sockets are filled one after the oth
Peter Maydell writes:
> On Tue, 13 Jul 2021 at 17:19, Eduardo Habkost wrote:
>>
>> From: Vitaly Kuznetsov
>>
>> To make Hyper-V features appear in e.g. QMP query-cpu-model-expansion we
>> need to expand and set the corresponding CPUID leaves early. Modify
>> x86_cpu_get_supported_feature_word()
On Thu, Jul 15 2021, Markus Armbruster wrote:
> Pierre Morel writes:
>
>> On 7/15/21 8:16 AM, Markus Armbruster wrote:
>>> Pierre Morel writes:
>>>
Drawers and Books are levels 4 and 3 of the S390 CPU
topology.
We allow the user to define these levels and we will
store the
On Fri, Jul 16, 2021 at 10:54:08AM +0200, Cornelia Huck wrote:
> On Wed, Jul 14 2021, Pierre Morel wrote:
>
> > We need a s390x dedicated SMP parsing to handle s390x specificities.
> >
> > In this patch we only handle threads, cores and sockets for
> > s390x:
> > - do not support threads, we alwa
On Wed, 14 Jul 2021 at 19:06, Richard Henderson
wrote:
>
> Mirror the behavour of /proc/sys/abi/sve_default_vector_length
> under the real linux kernel. We have no way of passing along
> a real default across exec like the kernel can, but this is a
> decent way of adjusting the startup vector len
On Fri, Jul 16, 2021 at 11:10:04AM +0200, Cornelia Huck wrote:
> On Thu, Jul 15 2021, Markus Armbruster wrote:
>
> > Pierre Morel writes:
> >
> >> On 7/15/21 8:16 AM, Markus Armbruster wrote:
> >>> Pierre Morel writes:
> >>>
> Drawers and Books are levels 4 and 3 of the S390 CPU
> to
On Wed, Jul 14 2021, Pierre Morel wrote:
> Interception of the PTF instruction depending on the new
> KVM_CAP_S390_CPU_TOPOLOGY KVM extension.
Wasn't that the capability that you dropped?
Is PTF supposed to be always intercepting? If that isn't configurable,
wouldn't older QEMUs generate except
On Thu, Jul 15, 2021 at 08:16:32AM +0200, Markus Armbruster wrote:
> Pierre Morel writes:
>
> > Drawers and Books are levels 4 and 3 of the S390 CPU
> > topology.
> > We allow the user to define these levels and we will
> > store the values inside the S390CcwMachineState.
>
> Double-checking: ar
On Wed, Jul 14 2021, Pierre Morel wrote:
> The maximum nested topology entries is used by the guest to know
> how many nested topology are available on the machine.
>
> As we now implemented drawers and books above sockets and core
> we can set the maximum nested topology reported by SCLP to 4.
On Thu, 15 Jul 2021 at 08:16, Alistair Francis wrote:
>
> The following changes since commit a9649a719a44894b81f38dc1c5c1888ee684acef:
>
> Merge remote-tracking branch
> 'remotes/cleber-gitlab/tags/python-next-pull-request' into staging
> (2021-07-14 18:09:09 +0100)
>
> are available in the Gi
On 05.07.21 11:15, Vladimir Sementsov-Ogievskiy wrote:
We are going to support IMGOPTS environment variable like in bash
tests. Corresponding global variable in iotests.py should be called
imgopts. So to not interfere with function argument, rename it in
advance.
Signed-off-by: Vladimir Sementso
On 05.07.21 11:15, Vladimir Sementsov-Ogievskiy wrote:
Adding support of IMGOPTS (like in bash tests) allows user to pass a
lot of different options. Still, some may require additional logic.
Now we want compression_type option, so add some smart logic around it:
ignore compression_type=zstd in
From: Hyman Huang(黄勇)
introduce dirty-bitmap mode as the third method of calc-dirty-rate.
implement dirty-bitmap dirtyrate calculation, which can be used
to measuring dirtyrate in the absence of dirty-ring.
introduce "dirty_bitmap:-b" option in hmp calc_dirty_rate to
indicate dirty bitmap method
From: Hyman Huang(黄勇)
v4:
- drop the first commit:
"KVM: introduce kvm_get_manual_dirty_log_protect"
- clear dirty log unconditionally so that the first commit
can be dropped.
- rename global var DirtyRateDirtyPages to total_dirty_pages
- stat the dirty pages along with the existing loop i
From: Hyman Huang(黄勇)
introduce global var total_dirty_pages to stat dirty pages
along with memory_global_dirty_log_sync.
Signed-off-by: Hyman Huang(黄勇)
---
include/exec/ram_addr.h | 4
migration/dirtyrate.c | 7 +++
2 files changed, 11 insertions(+)
diff --git a/include/exec/ram_a
From: Hyman Huang(黄勇)
v5:
- let recording dirty pages after memory_global_dirty_log_sync
make dirtyrate result more accurate
v4:
- drop the first commit:
"KVM: introduce kvm_get_manual_dirty_log_protect"
- clear dirty log unconditionally so that the first commit
can be dropped.
- rename
From: Hyman Huang(黄勇)
introduce global var total_dirty_pages to stat dirty pages
along with memory_global_dirty_log_sync.
Signed-off-by: Hyman Huang(黄勇)
---
include/exec/ram_addr.h | 4
migration/dirtyrate.c | 7 +++
2 files changed, 11 insertions(+)
diff --git a/include/exec/ram_a
From: Hyman Huang(黄勇)
introduce dirty-bitmap mode as the third method of calc-dirty-rate.
implement dirty-bitmap dirtyrate calculation, which can be used
to measuring dirtyrate in the absence of dirty-ring.
introduce "dirty_bitmap:-b" option in hmp calc_dirty_rate to
indicate dirty bitmap method
16.07.2021 13:07, Max Reitz wrote:
On 05.07.21 11:15, Vladimir Sementsov-Ogievskiy wrote:
Adding support of IMGOPTS (like in bash tests) allows user to pass a
lot of different options. Still, some may require additional logic.
Now we want compression_type option, so add some smart logic around
On 05.07.21 11:15, Vladimir Sementsov-Ogievskiy wrote:
The test prints qcow2 header fields which depends on chosen compression
type. So, let's be explicit in what compression type we want and
independent of IMGOPTS. Test both existing compression types.
Signed-off-by: Vladimir Sementsov-Ogievski
On Fri, Jul 16 2021, Daniel P. Berrangé wrote:
> On Fri, Jul 16, 2021 at 11:10:04AM +0200, Cornelia Huck wrote:
>> On Thu, Jul 15 2021, Markus Armbruster wrote:
>>
>> > Pierre Morel writes:
>> >
>> >> On 7/15/21 8:16 AM, Markus Armbruster wrote:
>> >>> Pierre Morel writes:
>> >>>
>> Dra
On 7/16/21 10:54 AM, Cornelia Huck wrote:
On Wed, Jul 14 2021, Pierre Morel wrote:
We need a s390x dedicated SMP parsing to handle s390x specificities.
In this patch we only handle threads, cores and sockets for
s390x:
- do not support threads, we always have 1 single thread per core
- the
On Fri, Jul 16, 2021 at 12:44:49PM +0200, Cornelia Huck wrote:
> On Fri, Jul 16 2021, Daniel P. Berrangé wrote:
>
> > On Fri, Jul 16, 2021 at 11:10:04AM +0200, Cornelia Huck wrote:
> >> On Thu, Jul 15 2021, Markus Armbruster wrote:
> >>
> >> > Pierre Morel writes:
> >> >
> >> >> On 7/15/21 8:1
On 7/16/21 11:14 AM, Daniel P. Berrangé wrote:
On Fri, Jul 16, 2021 at 10:54:08AM +0200, Cornelia Huck wrote:
On Wed, Jul 14 2021, Pierre Morel wrote:
We need a s390x dedicated SMP parsing to handle s390x specificities.
In this patch we only handle threads, cores and sockets for
s390x:
-
On 05.07.21 11:15, Vladimir Sementsov-Ogievskiy wrote:
The test checks different options. It of course fails if set
IMGOPTS='compression_type=zstd'. So, let's be explicit in what
compression type we want and independent of IMGOPTS. Test both existing
compression types.
Signed-off-by: Vladimir Se
On 7/16/21 11:23 AM, Daniel P. Berrangé wrote:
On Thu, Jul 15, 2021 at 08:16:32AM +0200, Markus Armbruster wrote:
Pierre Morel writes:
Drawers and Books are levels 4 and 3 of the S390 CPU
topology.
We allow the user to define these levels and we will
store the values inside the S390CcwMach
From: Hyman Huang(黄勇)
introduce global var total_dirty_pages to stat dirty pages
along with memory_global_dirty_log_sync.
Signed-off-by: Hyman Huang(黄勇)
---
include/exec/ram_addr.h | 9 +
migration/dirtyrate.c | 7 +++
2 files changed, 16 insertions(+)
diff --git a/include/exec/
From: Hyman Huang(黄勇)
introduce dirty-bitmap mode as the third method of calc-dirty-rate.
implement dirty-bitmap dirtyrate calculation, which can be used
to measuring dirtyrate in the absence of dirty-ring.
introduce "dirty_bitmap:-b" option in hmp calc_dirty_rate to
indicate dirty bitmap method
From: Hyman Huang(黄勇)
v6:
- pre-check if dirty tracking for dirtyrate is running
before stating the dirty pages
v5:
- let recording dirty pages after memory_global_dirty_log_sync
make dirtyrate result more accurate
v4:
- drop the first commit:
"KVM: introduce kvm_get_manual_dirty_log_prot
On 7/16/21 11:24 AM, Cornelia Huck wrote:
On Wed, Jul 14 2021, Pierre Morel wrote:
The maximum nested topology entries is used by the guest to know
how many nested topology are available on the machine.
As we now implemented drawers and books above sockets and core
we can set the maximum n
On 05.07.21 11:15, Vladimir Sementsov-Ogievskiy wrote:
We want iotests pass with both the default zlib compression and with
IMGOPTS='compression_type=zstd'.
Actually the only test that is interested in real compression type in
test output is 287 (test for qcow2 compression type) and it's in bash
On Mon, 12 Jul 2021 16:43:33 -0300
Daniel Henrique Barboza wrote:
> qapi_event_send_device_unplug_error() deals with @device being NULL
s/qapi_event_send_device_unplug_error/qapi_event_send_mem_unplug_error ?
since I only see qapi_event_send_mem_unplug_error() in the diff.
> by replacing it wi
On Mon, 12 Jul 2021 16:43:34 -0300
Daniel Henrique Barboza wrote:
> As done in hw/acpi/memory_hotplug.c, avoid sending
> qapi_event_send_mem_unplug_error() if dev->id is NULL.
>
> Suggested-by: Markus Armbruster
> Signed-off-by: Daniel Henrique Barboza
> ---
Reviewed-by: Greg Kurz
> hw/ppc
On 7/16/21 11:22 AM, Cornelia Huck wrote:
On Wed, Jul 14 2021, Pierre Morel wrote:
Interception of the PTF instruction depending on the new
KVM_CAP_S390_CPU_TOPOLOGY KVM extension.
Wasn't that the capability that you dropped?
yes,
Is PTF supposed to be always intercepting? If that is
On 16.07.21 08:54, Christian Borntraeger wrote:
On 12.07.21 14:26, Alex Bennée wrote:
Aside from a minor bloat to file size the ability to have TCG plugins
has no real impact on performance unless a plugin is actively loaded.
Even then the libempty.so plugin shows only a minor degradation in
16.07.2021 14:15, Max Reitz wrote:
On 05.07.21 11:15, Vladimir Sementsov-Ogievskiy wrote:
We want iotests pass with both the default zlib compression and with
IMGOPTS='compression_type=zstd'.
Actually the only test that is interested in real compression type in
test output is 287 (test for qcow
On 05.07.21 11:15, Vladimir Sementsov-Ogievskiy wrote:
Instead of qemu_img_log("info", ..) use generic helper img_info_log().
img_info_log() has smarter logic. For example it use filter_img_info()
to filter output, which in turns filter a compression type. So it will
help us in future when we im
> -Original Message-
> From: Peter Xu
> Sent: 15 July 2021 19:35
> To: Thanos Makatos
> Cc: Paolo Bonzini ; Markus Armbruster
> ; QEMU Devel Mailing List de...@nongnu.org>; John Levon ; John G
> Johnson
> Subject: Re: Question on memory commit during MR finalize()
>
> On Thu, Jul 15, 2
On Fri, Jul 16 2021, Pierre Morel wrote:
> On 7/16/21 11:22 AM, Cornelia Huck wrote:
>> On Wed, Jul 14 2021, Pierre Morel wrote:
>>
>>> Interception of the PTF instruction depending on the new
>>> KVM_CAP_S390_CPU_TOPOLOGY KVM extension.
>>
>> Wasn't that the capability that you dropped?
>
> y
Coverity reports potential NULL pointer dereference in
get_supported_hv_cpuid_legacy() when 'cs->kvm_state' is NULL. While
'cs->kvm_state' can indeed be NULL in hv_cpuid_get_host(),
kvm_hyperv_expand_features() makes sure that it only happens when
KVM_CAP_SYS_HYPERV_CPUID is supported and KVM_CAP_S
QEMU coding style requires braces around bodies of ifs.
Reported-by: Peter Maydell
Signed-off-by: Vitaly Kuznetsov
---
target/i386/kvm/kvm.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c
index e69abe48e3f8..28ca682b1089 1
On Thu, 15 Jul 2021 at 13:32, Markus Armbruster wrote:
>
> The following changes since commit a9649a719a44894b81f38dc1c5c1888ee684acef:
>
> Merge remote-tracking branch
> 'remotes/cleber-gitlab/tags/python-next-pull-request' into staging
> (2021-07-14 18:09:09 +0100)
>
> are available in the G
On 05.07.21 11:15, Vladimir Sementsov-Ogievskiy wrote:
If image doesn't have any compressed cluster we can easily switch to
zlib compression, which may allow to downgrade the image.
That's mostly needed to support IMGOPTS='compression_type=zstd' in some
iotests which do qcow2 downgrade.
While b
Igor Mammedov writes:
> On Thu, 8 Jul 2021 17:02:22 -0400
> Eduardo Habkost wrote:
>
>> On Tue, Jun 08, 2021 at 02:08:17PM +0200, Vitaly Kuznetsov wrote:
>> > For the beginning, just test 'hv-passthrough' and a couple of custom
>> > Hyper-V enlightenments configurations through QMP. Later, it w
16.07.2021 14:39, Max Reitz wrote:
On 05.07.21 11:15, Vladimir Sementsov-Ogievskiy wrote:
Instead of qemu_img_log("info", ..) use generic helper img_info_log().
img_info_log() has smarter logic. For example it use filter_img_info()
to filter output, which in turns filter a compression type. So
On Mon, Jul 12, 2021 at 10:39:50AM +0100, Peter Maydell wrote:
On Sun, 11 Jul 2021 at 23:55, Coiby Xu wrote:
On Mon, Jul 12, 2021 at 06:20:33AM +0800, Coiby Xu wrote:
>On Sun, Jul 11, 2021 at 04:53:51PM +0100, Peter Maydell wrote:
>>On Sat, 10 Jul 2021 at 14:30, Peter Maydell wrote:
>>>
>>>I'
Subject: s/compressiont_type/compression_type/
On 05.07.21 11:15, Vladimir Sementsov-Ogievskiy wrote:
Like it is done in iotests.py in qemu_img_create_prepare_args(), let's
not follow compression_type=zstd of IMGOPTS if test creates image in
old format.
Signed-off-by: Vladimir Sementsov-Ogievsk
On Mon, 12 Jul 2021 16:43:35 -0300
Daniel Henrique Barboza wrote:
> The error_report() call in drc_unisolate_logical() is not considering
> that drc->dev->id can be NULL, and the underlying functions error_report()
> calls to do its job (vprintf(), g_strdup_printf() ...) has undefined
> behavior
On Mon, 12 Jul 2021 16:43:36 -0300
Daniel Henrique Barboza wrote:
> Clarify that @device is optional and that 'path' is the device
> path from QOM.
>
> This change follows Markus' suggestion verbatim, provided in full
> context here:
>
> https://lists.gnu.org/archive/html/qemu-devel/2021-07/msg
For the beginning, just test 'hv-passthrough' and a couple of custom
Hyper-V enlightenments configurations through QMP. Later, it would
be great to complement this by checking CPUID values from within the
guest.
Signed-off-by: Vitaly Kuznetsov
---
- Changes since "[PATCH v8 0/9] i386: KVM: expan
On 05.07.21 11:15, Vladimir Sementsov-Ogievskiy wrote:
We'll use it in tests instead of explicit qcow2.py. Then we are going
to add some filtering in _qcow2_dump_header.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/common.rc | 10 ++
1 file changed, 10 insertion
On 05.07.21 11:15, Vladimir Sementsov-Ogievskiy wrote:
We are going to add filtering in _qcow2_dump_header and want all tests
use it.
The patch is generated by commands:
cd tests/qemu-iotests
sed -ie 's/$PYTHON qcow2.py "$TEST_IMG" dump-header\($\|
\)/_qcow2_dump_header\1/' ??? tests/*
(
On Mon, 12 Jul 2021 16:43:37 -0300
Daniel Henrique Barboza wrote:
> At this moment we only provide one event to report a hotunplug error,
> MEM_UNPLUG_ERROR. As of Linux kernel 5.12 and QEMU 6.0.0, the pseries
> machine is now able to report unplug errors for other device types, such
> as CPUs.
>
On Mon, 12 Jul 2021 16:43:38 -0300
Daniel Henrique Barboza wrote:
> Linux Kernel 5.12 is now unisolating CPU DRCs in the device_removal
> error path, signalling that the hotunplug process wasn't successful.
> This allow us to send a DEVICE_UNPLUG_ERROR in drc_unisolate_logical()
> to signal this
On Mon, 12 Jul 2021 16:43:39 -0300
Daniel Henrique Barboza wrote:
> MEM_UNPLUG_ERROR is deprecated since the introduction of
> DEVICE_UNPLUG_ERROR. Keep emitting both while the deprecation of
> MEM_UNPLUG_ERROR is pending.
>
> CC: Michael S. Tsirkin
> CC: Igor Mammedov
> Signed-off-by: Daniel
Christian Borntraeger writes:
> On 16.07.21 08:54, Christian Borntraeger wrote:
>> On 12.07.21 14:26, Alex Bennée wrote:
>>> Aside from a minor bloat to file size the ability to have TCG plugins
>>> has no real impact on performance unless a plugin is actively loaded.
>>> Even then the libempty
On 05.07.21 11:15, Vladimir Sementsov-Ogievskiy wrote:
We want iotests pass with both the default zlib compression and with
IMGOPTS='compression_type=zstd'.
Actually the only test that is interested in real compression type in
test output is 287 (test for qcow2 compression type), so implement
sp
On 05.07.21 11:15, Vladimir Sementsov-Ogievskiy wrote:
_qcow2_dump_header has filter for compression type, so this change
makes test pass with IMGOPTS='compression_type=zstd'.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/039 | 2 +-
1 file changed, 1 insertion(+), 1 del
On 05.07.21 11:15, Vladimir Sementsov-Ogievskiy wrote:
The test-case "Corrupted size field in compressed cluster descriptor"
heavily depends on zlib compression type. So, make it explicit. This
way test passes with IMGOPTS='compression_type=zstd'.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
On 05.07.21 11:15, Vladimir Sementsov-Ogievskiy wrote:
Don't touch other incompatible bits, like compression-type. This makes
the test pass with IMGOPTS='compression_type=zstd'.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/060 | 2 +-
1 file changed, 1 insertion(+), 1 d
On Fri, 16 Jul 2021 at 09:41, Michael S. Tsirkin wrote:
>
> On Fri, Jul 16, 2021 at 07:41:16AM +0100, Peter Maydell wrote:
> > On Thu, 15 Jul 2021 at 22:21, Michael S. Tsirkin wrote:
> > >
> > > On Wed, Jul 14, 2021 at 09:31:21PM +0100, Peter Maydell wrote:
> > > > On Tue, 13 Jul 2021 at 23:10, M
On Fri, Jul 16, 2021 at 11:42:02AM +, Thanos Makatos wrote:
> > -Original Message-
> > From: Peter Xu
> > Sent: 15 July 2021 19:35
> > To: Thanos Makatos
> > Cc: Paolo Bonzini ; Markus Armbruster
> > ; QEMU Devel Mailing List > de...@nongnu.org>; John Levon ; John G
> > Johnson
> >
16.07.2021 15:38, Max Reitz wrote:
Subject: s/compressiont_type/compression_type/
On 05.07.21 11:15, Vladimir Sementsov-Ogievskiy wrote:
Like it is done in iotests.py in qemu_img_create_prepare_args(), let's
not follow compression_type=zstd of IMGOPTS if test creates image in
old format.
Signe
Am 11.07.2021 um 17:53 hat Peter Maydell geschrieben:
> On Sat, 10 Jul 2021 at 14:30, Peter Maydell wrote:
> >
> > I've noticed recently that intermittently 'make check' will hang on
> > my aarch32 test system (really an aarch64 box with an aarch32 chroot).
> >
> > I think from grep that this must
16.07.2021 16:17, Max Reitz wrote:
On 05.07.21 11:15, Vladimir Sementsov-Ogievskiy wrote:
We want iotests pass with both the default zlib compression and with
IMGOPTS='compression_type=zstd'.
Actually the only test that is interested in real compression type in
test output is 287 (test for qcow
On 16.07.21 16:24, Vladimir Sementsov-Ogievskiy wrote:
16.07.2021 15:38, Max Reitz wrote:
Subject: s/compressiont_type/compression_type/
On 05.07.21 11:15, Vladimir Sementsov-Ogievskiy wrote:
Like it is done in iotests.py in qemu_img_create_prepare_args(), let's
not follow compression_type=zst
On 7/16/21 4:28 AM, Christian Borntraeger wrote:
--extra-ldflags="-Wl,--build-id -pie -Wl,-z,relro -Wl,-z,now"
FWIW, -pie should not be buried in --extra-ldflags, but as --enable-pie on the normal
configure line.
r~
On 16.07.21 16:51, Richard Henderson wrote:
On 7/16/21 4:28 AM, Christian Borntraeger wrote:
--extra-ldflags="-Wl,--build-id -pie -Wl,-z,relro -Wl,-z,now"
Full configure line is
../configure --prefix=/usr --libdir=/usr/lib64 --sysconfdir=/etc
--interp-prefix=/usr/qemu-%M
On Fri, Jul 16, 2021 at 03:12:53PM +0100, Peter Maydell wrote:
> On Fri, 16 Jul 2021 at 09:41, Michael S. Tsirkin wrote:
> >
> > On Fri, Jul 16, 2021 at 07:41:16AM +0100, Peter Maydell wrote:
> > > On Thu, 15 Jul 2021 at 22:21, Michael S. Tsirkin wrote:
> > > >
> > > > On Wed, Jul 14, 2021 at 09:
On Fri, Jul 16, 2021 at 03:12:53PM +0100, Peter Maydell wrote:
> On Fri, 16 Jul 2021 at 09:41, Michael S. Tsirkin wrote:
> >
> > On Fri, Jul 16, 2021 at 07:41:16AM +0100, Peter Maydell wrote:
> > > On Thu, 15 Jul 2021 at 22:21, Michael S. Tsirkin wrote:
> > > >
> > > > On Wed, Jul 14, 2021 at 09:
The following changes since commit bd306cfeeececee73ff2cdb3de1229ece72f3b28:
Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20210714.0'
into staging (2021-07-15 21:39:04 +0100)
are available in the Git repository at:
git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/f
From: Julia Suvorova
Implement notifications and gpe to support q35 ACPI PCI hot-plug.
Use 0xcc4 - 0xcd7 range for 'acpi-pci-hotplug' io ports.
Signed-off-by: Julia Suvorova
Reviewed-by: Igor Mammedov
Reviewed-by: Marcel Apfelbaum
Message-Id: <20210713004205.775386-2-jus...@redhat.com>
Review
From: Viresh Kumar
This allows is to instantiate a vhost-user-i2c device as part of a PCI
bus. It is mostly boilerplate which looks pretty similar to the
vhost-user-fs-pci device.
Reviewed-by: Alex Bennée
Signed-off-by: Viresh Kumar
Message-Id:
<8a083eaa57d93feaab12acd1f94b225879212f20.162580
From: Julia Suvorova
Instead of changing the hot-plug type in _OSC register, do not
set the 'Hot-Plug Capable' flag. This way guest will choose ACPI
hot-plug if it is preferred and leave the option to use SHPC with
pcie-pci-bridge.
The ability to control hot-plug for each downstream port is reta
From: Julia Suvorova
Add acpi_pcihp to ich9_pm as part of
'acpi-pci-hotplug-with-bridge-support' option. Set default to false.
Signed-off-by: Julia Suvorova
Signed-off-by: Marcel Apfelbaum
Reviewed-by: Igor Mammedov
Message-Id: <20210713004205.775386-3-jus...@redhat.com>
Reviewed-by: Michael
From: Julia Suvorova
Q35 has three different types of PCI devices hot-plug: PCIe Native,
SHPC Native and ACPI hot-plug. This patch changes the default choice
for cold-plugged bridges from PCIe Native to ACPI Hot-plug with
ability to use SHPC and PCIe Native for hot-plugged bridges.
This is a lis
From: Julia Suvorova
Add ACPI hot-plug registers to DSDT Q35 tables.
Changes in the tables:
+Scope (_SB.PCI0)
+{
+OperationRegion (PCST, SystemIO, 0x0CC4, 0x08)
+Field (PCST, DWordAcc, NoLock, WriteAsZeros)
+{
+PCIU, 32,
+PCID, 32
+
From: Xingang Wang
Add a bypass_iommu property for pci_expander_bridge, the property
is used to indicate whether pxb root bus will bypass iommu. By
default the bypass_iommu is disabled, and it can be enabled with:
qemu -device pxb-pcie,bus_nr=0x10,addr=0x1,bypass_iommu=true
Signed-off-by: Xingan
From: Xingang Wang
Add a new bypass_iommu property for PCI host and use it to check
whether devices attached to the PCI root bus will bypass iommu.
In pci_device_iommu_address_space(), check the property and
avoid getting iommu address space for devices bypass iommu.
Signed-off-by: Xingang Wang
From: Julia Suvorova
All DSDT Q35 tables will be modified because ACPI hot-plug is enabled
by default.
Signed-off-by: Julia Suvorova
Reviewed-by: Igor Mammedov
Reviewed-by: Marcel Apfelbaum
Message-Id: <20210713004205.775386-5-jus...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by:
1 - 100 of 207 matches
Mail list logo