Re: [PATCH v3 0/8] dp8393x: fixes and improvements

2021-07-12 Thread Finn Thain
On Sun, 11 Jul 2021, Philippe Mathieu-Daudé wrote: > > > If I'm right that the big_endian flag should go away, commit > > b1600ff195 ("hw/mips/jazz: specify correct endian for dp8393x device") > > has already taken mainline in the wrong direction and amounts to > > churn. > > We might figure

Re: [PATCH v3 00/33] Qemu SGX virtualization

2021-07-12 Thread Yang Zhong
On Fri, Jul 09, 2021 at 08:48:09PM +0300, Jarkko Sakkinen wrote: > On Fri, Jul 09, 2021 at 07:09:22PM +0800, Yang Zhong wrote: > > Since Sean Christopherson has left Intel and i am responsible for Qemu SGX > > upstream work. His @intel.com address will be bouncing and his new email( > > sea...@goog

Re: [PATCH v2 2/6] block: block-status cache for data regions

2021-07-12 Thread Max Reitz
On 06.07.21 19:04, Kevin Wolf wrote: Am 23.06.2021 um 17:01 hat Max Reitz geschrieben: As we have attempted before (https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg06451.html, "file-posix: Cache lseek result for data regions"; https://lists.nongnu.org/archive/html/qemu-block/2021-02/msg

Re: [PATCH v2 3/6] block: Clarify that @bytes is no limit on *pnum

2021-07-12 Thread Max Reitz
On 28.06.21 21:10, Eric Blake wrote: +++ b/include/block/block_int.h @@ -347,6 +347,11 @@ struct BlockDriver {    * clamped to bdrv_getlength() and aligned to request_alignment,    * as well as non-NULL pnum, map, and file; in turn, the driver    * must return an error or set pnum

Re: [PATCH 01/20] Hexagon HVX (target/hexagon) README

2021-07-12 Thread Rob Landley
On 7/5/21 6:34 PM, Taylor Simpson wrote: > Signed-off-by: Taylor Simpson > --- > target/hexagon/README | 83 > ++- > 1 file changed, 82 insertions(+), 1 deletion(-) I'm poking at the hexagon toolchain build script you checked into the test directo

Re: [PATCH 0/3] softmmu/vl: Deprecate old and crufty display options

2021-07-12 Thread Peter Krempa
On Tue, Jul 06, 2021 at 16:54:10 +0200, Thomas Huth wrote: > -display sdl uses a hand-crafted parser in vl.c, which is quite ugly > since the other parts of -display have been QAPIfied already. A straight > conversion to QAPI is not advisable since the "alt_grab" and "ctrl_grab" > parameters are no

Re: [PATCH] block: Add option to use driver whitelist even in tools

2021-07-12 Thread Kevin Wolf
Am 09.07.2021 um 19:45 hat Eric Blake geschrieben: > On Fri, Jul 09, 2021 at 06:41:41PM +0200, Kevin Wolf wrote: > > Currently, the block driver whitelists are only applied for the system > > emulator. All other binaries still give unrestricted access to all block > > drivers. There are use cases w

[PATCH v1] vfio: Fix CID 1458134 in vfio_register_ram_discard_listener()

2021-07-12 Thread David Hildenbrand
CID 1458134: Integer handling issues (BAD_SHIFT) In expression "1 << ctz64(container->pgsizes)", left shifting by more than 31 bits has undefined behavior. The shift amount, "ctz64(container->pgsizes)", is 64. Commit 5e3b981c330c ("vfio: Support for RamDiscardManager in the !vIOMM

Re: [RFC PATCH 0/6] job: replace AioContext lock with job_mutex

2021-07-12 Thread Emanuele Giuseppe Esposito
On 08/07/2021 15:04, Stefan Hajnoczi wrote: On Thu, Jul 08, 2021 at 01:32:12PM +0200, Paolo Bonzini wrote: On 08/07/21 12:36, Stefan Hajnoczi wrote: What is very clear from this patch is that it is strictly related to the brdv_* and lower level calls, because they also internally check or ev

Re: [RFC PATCH 0/6] job: replace AioContext lock with job_mutex

2021-07-12 Thread Emanuele Giuseppe Esposito
On 08/07/2021 15:09, Stefan Hajnoczi wrote: On Wed, Jul 07, 2021 at 06:58:07PM +0200, Emanuele Giuseppe Esposito wrote: This is a continuation on the work to reduce (and possibly get rid of) the usage of AioContext lock, by introducing smaller granularity locks to keep the thread safety. T

Re: [RFC PATCH 2/6] job: _locked functions and public job_lock/unlock for next patch

2021-07-12 Thread Emanuele Giuseppe Esposito
On 08/07/2021 12:50, Stefan Hajnoczi wrote: On Wed, Jul 07, 2021 at 06:58:09PM +0200, Emanuele Giuseppe Esposito wrote: diff --git a/job.c b/job.c index 872bbebb01..96fb8e9730 100644 --- a/job.c +++ b/job.c @@ -32,6 +32,10 @@ #include "trace/trace-root.h" #include "qapi/qapi-events-job.h"

Re: [RFC PATCH 4/6] job.h: categorize job fields

2021-07-12 Thread Emanuele Giuseppe Esposito
On 08/07/2021 13:02, Stefan Hajnoczi wrote: On Wed, Jul 07, 2021 at 06:58:11PM +0200, Emanuele Giuseppe Esposito wrote: -/** AioContext to run the job coroutine in */ +/** + * AioContext to run the job coroutine in. + * Atomic. + */ AioContext *aio_context; This is

Re: [RFC PATCH 5/6] job: use global job_mutex to protect struct Job

2021-07-12 Thread Emanuele Giuseppe Esposito
On 08/07/2021 14:56, Stefan Hajnoczi wrote: On Wed, Jul 07, 2021 at 06:58:12PM +0200, Emanuele Giuseppe Esposito wrote: This lock is going to replace most of the AioContext locks in the job and blockjob, so that a Job can run in an arbitrary AioContext. Signed-off-by: Emanuele Giuseppe Espos

Re: [RFC PATCH 3/6] job: minor changes to simplify locking

2021-07-12 Thread Emanuele Giuseppe Esposito
On 08/07/2021 12:55, Stefan Hajnoczi wrote: On Wed, Jul 07, 2021 at 06:58:10PM +0200, Emanuele Giuseppe Esposito wrote: @@ -406,15 +410,18 @@ void *job_create(const char *job_id, const JobDriver *driver, JobTxn *txn, error_setg(errp, "Invalid job ID '%s'", job_id);

Re: [PATCH v1] vfio: Fix CID 1458134 in vfio_register_ram_discard_listener()

2021-07-12 Thread Igor Mammedov
On Mon, 12 Jul 2021 10:31:35 +0200 David Hildenbrand wrote: > CID 1458134: Integer handling issues (BAD_SHIFT) > In expression "1 << ctz64(container->pgsizes)", left shifting by more > than 31 bits has undefined behavior. The shift amount, > "ctz64(container->pgsizes)", is 64. >

Re: retrying failed gitlab CI external jobs (travis)

2021-07-12 Thread Daniel P . Berrangé
On Sat, Jul 10, 2021 at 05:29:24PM +0100, Peter Maydell wrote: > On Sat, 10 Jul 2021 at 14:34, Peter Maydell wrote: > > > > Hi; we now have travis's CI hooked into gitlab, which is nice. However, > > unlike the gitlab native CI jobs, there's no UI for saying "retry this" > > when the "travis CI" p

Re: [PATCH v1] vfio: Fix CID 1458134 in vfio_register_ram_discard_listener()

2021-07-12 Thread Pankaj Gupta
> CID 1458134: Integer handling issues (BAD_SHIFT) > In expression "1 << ctz64(container->pgsizes)", left shifting by more > than 31 bits has undefined behavior. The shift amount, > "ctz64(container->pgsizes)", is 64. > > Commit 5e3b981c330c ("vfio: Support for RamDiscardManager in

Re: [PATCH v3 05/33] vl: Add sgx compound properties to expose SGX EPC sections to guest

2021-07-12 Thread Yang Zhong
On Fri, Jul 09, 2021 at 06:07:13PM +0200, Paolo Bonzini wrote: > On 09/07/21 13:09, Yang Zhong wrote: > >+sgx_epc = g_malloc0(sizeof(*sgx_epc)); > >+pcms->sgx_epc = sgx_epc; > >+ > > No need to malloc this, it's small. > Thanks Paolo, i will use g_new0() to replace this malloc, thanks!

Re: intermittent hang in qos-test for qemu-system-i386 on 32-bit arm host

2021-07-12 Thread Peter Maydell
On Sun, 11 Jul 2021 at 23:55, Coiby Xu wrote: > > On Mon, Jul 12, 2021 at 06:20:33AM +0800, Coiby Xu wrote: > >On Sun, Jul 11, 2021 at 04:53:51PM +0100, Peter Maydell wrote: > >>On Sat, 10 Jul 2021 at 14:30, Peter Maydell > >>wrote: > >>> > >>>I've noticed recently that intermittently 'make chec

Re: About two-dimensional page translation (e.g., Intel EPT) and shadow page table in Linux QEMU/KVM

2021-07-12 Thread Maxim Levitsky
On Sun, 2021-07-11 at 15:13 -0500, harry harry wrote: > Hi all, > > I hope you are very well! May I know whether it is possible to enable > two-dimensional page translation (e.g., Intel EPT) mechanisms and > shadow page table mechanisms in Linux QEMU/KVM at the same time on a > physical server? Fo

Re: [PULL v2 00/48] Misc patches for QEMU 6.1 soft freeze

2021-07-12 Thread Peter Maydell
On Sat, 10 Jul 2021 at 20:01, Paolo Bonzini wrote: > > The following changes since commit 05de778b5b8ab0b402996769117b88c7ea5c7c61: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2021-07-09 14:30:01 +0100) > > are available in the Git repository at: > > https

Re: [PATCH v3 4/4] replication: Remove workaround

2021-07-12 Thread Vladimir Sementsov-Ogievskiy
11.07.2021 23:33, Lukas Straub wrote: On Fri, 9 Jul 2021 10:49:23 +0300 Vladimir Sementsov-Ogievskiy wrote: 07.07.2021 21:15, Lukas Straub wrote: Remove the workaround introduced in commit 6ecbc6c52672db5c13805735ca02784879ce8285 "replication: Avoid blk_make_empty() on read-only child". It i

Re: [PATCH 2/4] qemu-options: re-arrange CPU topology options

2021-07-12 Thread Daniel P . Berrangé
On Mon, Jun 28, 2021 at 12:30:45PM +0100, Daniel P. Berrangé wrote: > The list of CPU topology options are presented in a fairly arbitrary > order currently. Re-arrange them so that they're ordered from largest to > smallest unit > > Signed-off-by: Daniel P. Berrangé > --- > qemu-options.hx | 8

Re: [PULL 4/4] hw/sd: sdhci: Enable 64-bit system bus capability in the default SD/MMC host controller

2021-07-12 Thread Philippe Mathieu-Daudé
On 7/11/21 11:10 PM, Philippe Mathieu-Daudé wrote: > From: Joanne Koong > > The default SD/MMC host controller uses SD spec v2.00. 64-bit system bus > capability > was added in v2. > > In this change, we arrive at 0x157834b4 by computing (0x057834b4 | (1ul << > 28)) > where 28 represents the B

Re: [PULL 0/4] SD/MMC patches for 2021-07-11

2021-07-12 Thread Philippe Mathieu-Daudé
On 7/11/21 11:10 PM, Philippe Mathieu-Daudé wrote: > The following changes since commit 9516034d05a8c71ef157a59f525e4c4f7ed79827: > > Merge remote-tracking branch 'remotes/cminyard/tags/for-qemu-6.1-2' into > staging (2021-07-11 14:32:49 +0100) > > are available in the Git repository at: > >

[PULL 0/3] SD/MMC patches for 2021-07-12

2021-07-12 Thread Philippe Mathieu-Daudé
The following changes since commit d1987c8114921eb30859854de664f879b5626da7: Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' into staging (2021-07-11 22:20:51 +0100) are available in the Git repository at: https://github.com/philmd/qemu.git tags/sdmmc-202

[PATCH v6 2/6] qmp: add QMP command x-debug-virtio-status

2021-07-12 Thread Jonah Palmer
From: Laurent Vivier This new command shows the status of a VirtIODevice (features, endianness and number of virtqueues) Next patch will improve output by decoding feature bits. Signed-off-by: Laurent Vivier Signed-off-by: Jonah Palmer --- hw/virtio/virtio-stub.c | 5 hw/virtio/virtio.

[PATCH v6 1/6] qmp: add QMP command x-debug-query-virtio

2021-07-12 Thread Jonah Palmer
From: Laurent Vivier This new command lists all the instances of VirtIODevice with their path and virtio type. Signed-off-by: Laurent Vivier Reviewed-by: Eric Blake Signed-off-by: Jonah Palmer --- hw/virtio/meson.build | 2 ++ hw/virtio/virtio-stub.c| 14 + hw/virtio/virtio

[PATCH v6 6/6] hmp: add virtio commands

2021-07-12 Thread Jonah Palmer
From: Laurent Vivier This patch implements HMP version of the virtio QMP commands Signed-off-by: Laurent Vivier Signed-off-by: Jonah Palmer --- docs/system/monitor.rst | 2 + hmp-commands-virtio.hx | 162 ++ hmp-commands.hx | 10 +++ hw/virtio/v

[PATCH v6 4/6] qmp: add QMP command x-debug-virtio-queue-status

2021-07-12 Thread Jonah Palmer
From: Laurent Vivier This new command shows internal status of a VirtQueue. (vrings and indexes). Signed-off-by: Laurent Vivier Signed-off-by: Jonah Palmer --- hw/virtio/virtio-stub.c | 6 +++ hw/virtio/virtio.c | 37 ++ qapi/virtio.json| 102 ++

[PATCH v6 5/6] qmp: add QMP command x-debug-virtio-queue-element

2021-07-12 Thread Jonah Palmer
From: Laurent Vivier This new command shows the information of a VirtQueue element. Signed-off-by: Laurent Vivier Signed-off-by: Jonah Palmer --- hw/virtio/virtio-stub.c | 9 hw/virtio/virtio.c | 135 qapi/virtio.json| 94 +

[PATCH v6 0/6] hmp, qmp: Add some commands to introspect virtio devices

2021-07-12 Thread Jonah Palmer
This series introduces new QMP/HMP commands to dump the status of a virtio device at different levels. [Jonah: Rebasing previous patchset from March for Qemu 6.1 (here: https://lore.kernel.org/qemu-devel/1616084984-11263-1-git-send-email-jonah.pal...@oracle.com/) from Laurent's original qmp/hmp v

[PATCH v6 3/6] qmp: decode feature bits in virtio-status

2021-07-12 Thread Jonah Palmer
From: Laurent Vivier Display feature names instead of a features bitmap for host, guest, and backend. Decode features according to device type, transport features are on the first line. Undecoded bits (if any) are stored in a separate field. Signed-off-by: Laurent Vivier Signed-off-by: Jonah P

Re: [PATCH v1 3/3] hw/riscv: virt: Add optional ACLINT support to virt machine

2021-07-12 Thread Anup Patel
On Mon, Jul 12, 2021 at 11:45 AM Bin Meng wrote: > > On Mon, Jul 12, 2021 at 1:39 PM Anup Patel wrote: > > > > On Mon, Jun 14, 2021 at 5:52 PM Bin Meng wrote: > > > > > > On Sun, Jun 13, 2021 at 12:14 AM Anup Patel wrote: > > > > > > > > We extend virt machine to emulate ACLINT devices only whe

Re: retrying failed gitlab CI external jobs (travis)

2021-07-12 Thread Peter Maydell
On Mon, 12 Jul 2021 at 10:22, Daniel P. Berrangé wrote: > WRT missing job for commit fc32b91a, I see there is a Travis stage > reported here: > > https://gitlab.com/qemu-project/qemu/-/pipelines/334907106/builds > > So I presume there was some delay in running the Travis jobs and > thus they onl

Re: retrying failed gitlab CI external jobs (travis)

2021-07-12 Thread Daniel P . Berrangé
On Mon, Jul 12, 2021 at 12:03:02PM +0100, Peter Maydell wrote: > On Mon, 12 Jul 2021 at 10:22, Daniel P. Berrangé wrote: > > WRT missing job for commit fc32b91a, I see there is a Travis stage > > reported here: > > > > https://gitlab.com/qemu-project/qemu/-/pipelines/334907106/builds > > > > So

Re: [PATCH v3 4/4] replication: Remove workaround

2021-07-12 Thread Lukas Straub
On Mon, 12 Jul 2021 13:06:19 +0300 Vladimir Sementsov-Ogievskiy wrote: > 11.07.2021 23:33, Lukas Straub wrote: > > On Fri, 9 Jul 2021 10:49:23 +0300 > > Vladimir Sementsov-Ogievskiy wrote: > > > >> 07.07.2021 21:15, Lukas Straub wrote: > >>> Remove the workaround introduced in commit > >>>

Re: [PATCH 00/41] tcg patch queue

2021-07-12 Thread Peter Maydell
On Sat, 10 Jul 2021 at 16:33, Richard Henderson wrote: > > The following changes since commit 05de778b5b8ab0b402996769117b88c7ea5c7c61: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2021-07-09 14:30:01 +0100) > > are available in the Git repository at: > > h

[PATCH v5 0/5] replication: Bugfix and properly attach children

2021-07-12 Thread Lukas Straub
Hello Everyone, A while ago Kevin noticed that the replication driver doesn't properly attach the children it wants to use. Instead, it directly copies the BdrvChilds from it's backing file, which is wrong. Ths Patchset fixes the problem, fixes a potential crash in replication_co_writev due to miss

[PATCH v5 1/5] replication: Remove s->active_disk

2021-07-12 Thread Lukas Straub
s->active_disk is bs->file. Remove it and use local variables instead. Signed-off-by: Lukas Straub Reviewed-by: Vladimir Sementsov-Ogievskiy --- block/replication.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/block/replication.c b/blo

[PATCH v5 2/5] replication: Reduce usage of s->hidden_disk and s->secondary_disk

2021-07-12 Thread Lukas Straub
In preparation for the next patch, initialize s->hidden_disk and s->secondary_disk later and replace access to them with local variables in the places where they aren't initialized yet. Signed-off-by: Lukas Straub Reviewed-by: Vladimir Sementsov-Ogievskiy --- block/replication.c | 45 ++

[PATCH v5 3/5] replication: Properly attach children

2021-07-12 Thread Lukas Straub
The replication driver needs access to the children block-nodes of it's child so it can issue bdrv_make_empty() and bdrv_co_pwritev() to manage the replication. However, it does this by directly copying the BdrvChilds, which is wrong. Fix this by properly attaching the block-nodes with bdrv_attach

[PATCH v5 4/5] replication: Assert that children are writable

2021-07-12 Thread Lukas Straub
Assert that the children are writable where it's needed. While there is no test-case for the BLOCK_REPLICATION_FAILOVER_FAILED state, this at least ensures that s->secondary_disk is always writable in case replication might go into that state. Signed-off-by: Lukas Straub --- block/replication.c

[PATCH v5 5/5] replication: Remove workaround

2021-07-12 Thread Lukas Straub
Remove the workaround introduced in commit 6ecbc6c52672db5c13805735ca02784879ce8285 "replication: Avoid blk_make_empty() on read-only child". It is not needed anymore since s->hidden_disk is guaranteed to be writable when secondary_do_checkpoint() runs. Because replication_start(), _do_checkpoint(

Re: [PATCH] migration/rdma: prevent from double free the same mr

2021-07-12 Thread Dr. David Alan Gilbert
* lizhij...@fujitsu.com (lizhij...@fujitsu.com) wrote: > > > On 09/07/2021 03:11, Dr. David Alan Gilbert wrote: > > * Li Zhijian (lizhij...@cn.fujitsu.com) wrote: > >> backtrace: > >> '0x75f44ec2 in __ibv_dereg_mr_1_1 (mr=0x7fff1007d390) at > >> /home/lizhijian/rdma-core/libibverbs/verbs

Re: question on vhost, limiting kernel threads and NPROC

2021-07-12 Thread Stefan Hajnoczi
On Fri, Jul 09, 2021 at 11:25:37AM -0500, Mike Christie wrote: > Hi, > > The goal of this email is to try and figure how we want to track/limit the > number of kernel threads created by vhost devices. > > Background: > --- > For vhost-scsi, we've hit a issue where the single vhost worker

[PATCH] disable modular TCG on Darwin

2021-07-12 Thread Paolo Bonzini
Accelerator modularity does not work on Darwin: ld: illegal thread local variable reference to regular symbol _current_cpu for architecture x86_64 clang: error: linker command failed with exit code 1 (use -v to see invocation) Fix by avoiding modular TCG builds. Signed-off-by: Paolo Bonzini --

Re: [PATCH 2/4] qemu-options: re-arrange CPU topology options

2021-07-12 Thread wangyanan (Y)
On 2021/7/12 18:10, Daniel P. Berrangé wrote: On Mon, Jun 28, 2021 at 12:30:45PM +0100, Daniel P. Berrangé wrote: The list of CPU topology options are presented in a fairly arbitrary order currently. Re-arrange them so that they're ordered from largest to smallest unit Signed-off-by: Daniel P.

[PULL for 6.1 00/40] testing and plugin updates

2021-07-12 Thread Alex Bennée
The following changes since commit 86108e23d798bcd3fce35ad271b198f8a8611746: Merge remote-tracking branch 'remotes/vivier2/tags/trivial-branch-for-6.1-pull-request' into staging (2021-07-11 18:49:25 +0100) are available in the Git repository at: https://github.com/stsquad/qemu.git tags/pul

[PULL 01/40] Jobs based on custom runners: documentation and configuration placeholder

2021-07-12 Thread Alex Bennée
From: Cleber Rosa As described in the included documentation, the "custom runner" jobs extend the GitLab CI jobs already in place. One of their primary goals of catching and preventing regressions on a wider number of host systems than the ones provided by GitLab's shared runners. This sets the

[PULL 02/40] Jobs based on custom runners: build environment docs and playbook

2021-07-12 Thread Alex Bennée
From: Cleber Rosa To run basic jobs on custom runners, the environment needs to be properly set up. The most common requirement is having the right packages installed. The playbook introduced here covers the QEMU's project s390x and aarch64 machines. At the time this is being proposed, those m

[PULL 06/40] build: validate that system capstone works before using it

2021-07-12 Thread Alex Bennée
From: Daniel P. Berrangé Some versions of capstone have shipped a broken pkg-config file which puts the -I path without the trailing '/capstone' suffix. This breaks the ability to "#include ". Upstream and most distros have fixed this, but a few stragglers remain, notably FreeBSD. Signed-off-by:

[PULL 04/40] Jobs based on custom runners: add job definitions for QEMU's machines

2021-07-12 Thread Alex Bennée
From: Cleber Rosa The QEMU project has two machines (aarch64 and s390x) that can be used for jobs that do build and run tests. This introduces those jobs, which are a mapping of custom scripts used for the same purpose. Signed-off-by: Cleber Rosa Signed-off-by: Alex Bennée Reviewed-by: Willia

[PULL 05/40] tests/tcg: also disable the signals test for plugins

2021-07-12 Thread Alex Bennée
This will be more important when plugins is enabled by default. Fixes: eba61056e4 ("tests/tcg: generalise the disabling of the signals test") Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20210709143005.1554-6-alex.ben...@linaro.org> diff --git a/tests/tcg/multiarch/Mak

[PULL 03/40] Jobs based on custom runners: docs and gitlab-runner setup playbook

2021-07-12 Thread Alex Bennée
From: Cleber Rosa To have the jobs dispatched to custom runners, gitlab-runner must be installed, active as a service and properly configured. The variables file and playbook introduced here should help with those steps. The playbook introduced here covers the Linux distributions and has been p

[PULL 07/40] gitlab: support for FreeBSD 12, 13 and macOS 11 via cirrus-run

2021-07-12 Thread Alex Bennée
From: Daniel P. Berrangé This adds support for running 4 jobs via Cirrus CI runners: * FreeBSD 12 * FreeBSD 13 * macOS 11 with default XCode * macOS 11 with latest XCode The gitlab job uses a container published by the libvirt-ci project (https://gitlab.com/libvirt/libvirt-ci) that contains

[PULL 29/40] configure: don't allow plugins to be enabled for a non-TCG build

2021-07-12 Thread Alex Bennée
Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20210709143005.1554-30-alex.ben...@linaro.org> diff --git a/configure b/configure index 650d9c0735..7f906be68d 100755 --- a/configure +++ b/configure @@ -1098,6 +1098,7 @@ for opt do --enable-cap-ng) cap_ng="enabled" ;;

[PULL 09/40] hw/usb/ccid: remove references to NSS

2021-07-12 Thread Alex Bennée
From: Daniel P. Berrangé The NSS package was previously pre-requisite for building CCID related features, however, this became obsolete when the libcacard library was spun off to a separate project: commit 7b02f5447c64d1854468f758398c9f6fe9e5721f Author: Marc-André Lureau Date: Su

[PULL 36/40] plugins: Added a new cache modelling plugin

2021-07-12 Thread Alex Bennée
From: Mahmoud Mandour Added a cache modelling plugin that uses a static configuration used in many of the commercial microprocessors and uses random eviction policy. The purpose of the plugin is to identify the most cache-thrashing instructions for both instruction cache and data cache. Signed-

[PULL 32/40] tcg/plugins: enable by default for most TCG builds

2021-07-12 Thread Alex Bennée
Aside from a minor bloat to file size the ability to have TCG plugins has no real impact on performance unless a plugin is actively loaded. Even then the libempty.so plugin shows only a minor degradation in performance caused by the extra book keeping the TCG has to do to keep track of instructions

Re: [PULL v2 00/48] Misc patches for QEMU 6.1 soft freeze

2021-07-12 Thread Daniel P . Berrangé
On Mon, Jul 12, 2021 at 11:01:55AM +0100, Peter Maydell wrote: > On Sat, 10 Jul 2021 at 20:01, Paolo Bonzini wrote: > > > > The following changes since commit 05de778b5b8ab0b402996769117b88c7ea5c7c61: > > > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > > (2021-07

[PULL 08/40] cirrus: delete FreeBSD and macOS jobs

2021-07-12 Thread Alex Bennée
From: Daniel P. Berrangé The builds for these two platforms can now be performed from GitLab CI using cirrus-run. Signed-off-by: Daniel P. Berrangé Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Reviewed-by: Willian Rampazzo Reviewed-by: Wainer dos Santos Moschetta Message-Id: <2021062

[PULL 31/40] configure: stop user enabling plugins on Windows for now

2021-07-12 Thread Alex Bennée
There are some patches on the list that enable plugins on Windows but they still need some changes to be ready: https://patchew.org/QEMU/20201013002806.1447-1-luoyongg...@gmail.com/ In the meantime lets stop the user from being able to configure the support so they don't get confused by the wei

[PULL 34/40] contrib/plugins: add execlog to log instruction execution and memory access

2021-07-12 Thread Alex Bennée
From: Alexandre Iooss Log instruction execution and memory access to a file. This plugin can be used for reverse engineering or for side-channel analysis using QEMU. Signed-off-by: Alexandre Iooss Signed-off-by: Alex Bennée Reviewed-by: Alex Bennée Message-Id: <20210702081307.1653644-2-erdn..

[PULL 26/40] tests/tcg: make test-mmap a little less aggressive

2021-07-12 Thread Alex Bennée
The check_aligned_anonymous_unfixed_mmaps and check_aligned_anonymous_unfixed_colliding_mmaps do a lot of mmap's and copying of data. This is especially unfriendly to targets like hexagon which have quite large pages and need to do sanity checks on each memory access. While we are at it clean-up t

[PULL 33/40] contrib/plugins: enable -Wall for building plugins

2021-07-12 Thread Alex Bennée
Lets spot the obvious errors. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Message-Id: <20210709143005.1554-34-alex.ben...@linaro.org> diff --git a/contrib/plugins/Makefile b/contrib/plugins/Makefile index b9d7935e5e..3431bc1ce9 100644 --- a/contrib/plugin

[PULL 22/40] tests/docker: expand ubuntu2004 package list

2021-07-12 Thread Alex Bennée
From: Daniel P. Berrangé This is the fully expanded list of build pre-requisites QEMU can conceivably use in any scenario. Signed-off-by: Daniel P. Berrangé Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Message-Id: <20210623142245.307776-15-berra...@

[PULL 10/40] tests/docker: don't use BUILDKIT in GitLab either

2021-07-12 Thread Alex Bennée
From: Daniel P. Berrangé Using BUILDKIT breaks with certain container registries such as CentOS, with docker build reporting an error such as failed to solve with frontend dockerfile.v0: failed to build LLB: failed to load cache key: unexpected status code https://registry.centos.org/v2/

[PULL 25/40] tests/vm: update openbsd to release 6.9

2021-07-12 Thread Alex Bennée
From: Brad Smith tests/vm: update openbsd to release 6.9 Signed-off-by: Brad Smith Signed-off-by: Alex Bennée Tested-by: Gerd Hoffmann Acked-by: Philippe Mathieu-Daudé Message-Id: Message-Id: <20210709143005.1554-26-alex.ben...@linaro.org> diff --git a/tests/vm/openbsd b/tests/vm/openbsd i

[PULL 11/40] tests/docker: use project specific container registries

2021-07-12 Thread Alex Bennée
From: Daniel P. Berrangé Since Docker Hub has started to enforce pull rate limits on clients, it is preferrable to use project specific container registries where they are available. Fedora and OpenSUSE projects provide registries. The images in these registries are also refreshed on a more regu

[PULL 27/40] plugins: fix-up handling of internal hostaddr for 32 bit

2021-07-12 Thread Alex Bennée
The compiler rightly complains when we build on 32 bit that casting uint64_t into a void is a bad idea. We are really dealing with a host pointer at this point so treat it as such. This does involve a uintptr_t cast of the result of the TLB addend as we know that has to point to the host memory. S

[PULL 20/40] tests/docker: expand fedora package list

2021-07-12 Thread Alex Bennée
From: Daniel P. Berrangé This is the fully expanded list of build pre-requisites QEMU can conceivably use in any scenario. Signed-off-by: Daniel P. Berrangé Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Message-Id: <20210623142245.307776-13-berra...@

[PULL 35/40] docs/devel: tcg-plugins: add execlog plugin description

2021-07-12 Thread Alex Bennée
From: Alexandre Iooss This adds description of the execlog TCG plugin with an example. Signed-off-by: Alexandre Iooss Signed-off-by: Alex Bennée Message-Id: <20210702081307.1653644-3-erdn...@crans.org> Message-Id: <20210709143005.1554-36-alex.ben...@linaro.org> diff --git a/docs/devel/tcg-plu

[PULL 15/40] tests/docker: fix mistakes in centos package lists

2021-07-12 Thread Alex Bennée
From: Daniel P. Berrangé mesa-libEGL-devel is not used in QEMU at all, but mesa-libgbm-devel is. spice-glib-devel is not use in QEMU at all, but spice-protocol is. We also need the -devel package for spice-server, not the runtime. There is no need to specifically refer to python36, we can just

[PULL 13/40] tests/docker: remove FEATURES env var from templates

2021-07-12 Thread Alex Bennée
From: Daniel P. Berrangé In preparation for switching to auto-generated dockerfiles, remove the FEATURES env variable. The equivalent functionality can be achieved in most cases by just looking for existance of a binary. The cases which don't correspond to binaries are simply dropped because con

[PULL 16/40] tests/docker: fix mistakes in fedora package list

2021-07-12 Thread Alex Bennée
From: Daniel P. Berrangé libblockdev-mpath-devel is not used by QEMU, rather it wants device-mapper-multipath-devel. Signed-off-by: Daniel P. Berrangé Signed-off-by: Alex Bennée Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Message-Id:

[PULL 24/40] tests/vm: update NetBSD to 9.2

2021-07-12 Thread Alex Bennée
From: Brad Smith tests/vm: update NetBSD to 9.2 Signed-off-by: Brad Smith Signed-off-by: Alex Bennée Tested-by: Gerd Hoffmann Reviewed-by: Wainer dos Santos Moschetta Acked-by: Philippe Mathieu-Daudé Message-Id: Message-Id: <20210709143005.1554-25-alex.ben...@linaro.org> diff --git a/test

[PULL 37/40] plugins/cache: Enable cache parameterization

2021-07-12 Thread Alex Bennée
From: Mahmoud Mandour Enabled configuring both icache and dcache parameters using plugin parameters. Signed-off-by: Mahmoud Mandour Signed-off-by: Alex Bennée Message-Id: <20210623125458.450462-3-ma.mando...@gmail.com> Message-Id: <20210709143005.1554-38-alex.ben...@linaro.org> diff --git a/c

[PULL 18/40] tests/docker: remove mingw packages from Fedora

2021-07-12 Thread Alex Bennée
From: Daniel P. Berrangé There are dedicated containers providing mingw packages for Fedora. Signed-off-by: Daniel P. Berrangé Signed-off-by: Alex Bennée Reviewed-by: Alex Bennée Message-Id: <20210623142245.307776-11-berra...@redhat.com> Message-Id: <20210709143005.1554-19-alex.ben...@linaro.

[PULL 30/40] configure: add an explicit static and plugins check

2021-07-12 Thread Alex Bennée
Moving this check earlier will make the later re-factor for enabling by default a bit neater. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20210709143005.1554-31-alex.ben...@linaro.org> diff --git a/configure b/configure index 7f906be68d..2c9c6ab870 100755 --- a/config

[PULL 23/40] tests/docker: expand opensuse-leap package list

2021-07-12 Thread Alex Bennée
From: Daniel P. Berrangé This is the fully expanded list of build pre-requisites QEMU can conceivably use in any scenario. Signed-off-by: Daniel P. Berrangé Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Message-Id: <20210623142245.307776-16-berra...@

[PULL 17/40] tests/docker: fix mistakes in ubuntu package lists

2021-07-12 Thread Alex Bennée
From: Daniel P. Berrangé librados-dev is not required by QEMU directly, only librbd-dev. glusterfs-common is not directly needed by QEMU. QEMU uses ncursesw only on non-Windows hosts. The clang package is clang 10. flex and bison are not required by QEMU. Standardize on nmap ncat implementat

[PULL 38/40] plugins/cache: Added FIFO and LRU eviction policies

2021-07-12 Thread Alex Bennée
From: Mahmoud Mandour Implemented FIFO and LRU eviction policies. Now one of the three eviction policies can be chosen as an argument. On not specifying an argument, LRU is used by default. Signed-off-by: Mahmoud Mandour Signed-off-by: Alex Bennée Message-Id: <20210623125458.450462-4-ma.mando.

[PULL 40/40] MAINTAINERS: Added myself as a reviewer for TCG Plugins

2021-07-12 Thread Alex Bennée
From: Mahmoud Mandour Signed-off-by: Mahmoud Mandour Signed-off-by: Alex Bennée Message-Id: <20210623125458.450462-6-ma.mando...@gmail.com> Message-Id: <20210709143005.1554-41-alex.ben...@linaro.org> diff --git a/MAINTAINERS b/MAINTAINERS index 97ad270762..af7764e04a 100644 --- a/MAINTAINERS +

Re: [PULL for 6.1 00/40] testing and plugin updates

2021-07-12 Thread Alex Bennée
Alex Bennée writes: > The following changes since commit 86108e23d798bcd3fce35ad271b198f8a8611746: > > Merge remote-tracking branch > 'remotes/vivier2/tags/trivial-branch-for-6.1-pull-request' into staging > (2021-07-11 18:49:25 +0100) > > are available in the Git repository at: > > https

[PULL 39/40] docs/devel: Added cache plugin to the plugins docs

2021-07-12 Thread Alex Bennée
From: Mahmoud Mandour Signed-off-by: Mahmoud Mandour Signed-off-by: Alex Bennée Message-Id: <20210628053808.17422-1-ma.mando...@gmail.com> Message-Id: <20210709143005.1554-40-alex.ben...@linaro.org> diff --git a/docs/devel/tcg-plugins.rst b/docs/devel/tcg-plugins.rst index 179867e9c1..7e54f128

[PULL 21/40] tests/docker: expand ubuntu1804 package list

2021-07-12 Thread Alex Bennée
From: Daniel P. Berrangé This is the fully expanded list of build pre-requisites QEMU can conceivably use in any scenario. Signed-off-by: Daniel P. Berrangé Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Message-Id: <20210623142245.307776-14-berra...@

[PULL 01/22] crypto: remove conditional around 3DES crypto test cases

2021-07-12 Thread Daniel P . Berrangé
The main method checks whether the cipher choice is supported at runtime, so there is no need for compile time conditions. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrangé --- tests/unit/test-crypto-cipher.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/unit/test-crypto-ci

Re: [PATCH] disable modular TCG on Darwin

2021-07-12 Thread Alex Bennée
Paolo Bonzini writes: > Accelerator modularity does not work on Darwin: > > ld: illegal thread local variable reference to regular symbol _current_cpu > for architecture x86_64 > clang: error: linker command failed with exit code 1 (use -v to see > invocation) > > Fix by avoiding modular TCG bu

[PULL 28/40] meson.build: move TCG plugin summary output

2021-07-12 Thread Alex Bennée
Let's put it with the rest of the TCG related output with the accelerator. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20210709143005.1554-29-alex.ben...@linaro.org> diff --git a/meson.build b/meson.build index cea8196e53..ef0d54bb

[PULL 03/22] crypto: skip essiv ivgen tests if AES+ECB isn't available

2021-07-12 Thread Daniel P . Berrangé
Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrangé --- tests/unit/test-crypto-ivgen.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/tests/unit/test-crypto-ivgen.c b/tests/unit/test-crypto-ivgen.c index f581e6aba7..29630ed348 100644 --- a/tests/unit/tes

[PULL 19/40] tests/docker: expand centos8 package list

2021-07-12 Thread Alex Bennée
From: Daniel P. Berrangé This is the fully expanded list of build pre-requisites QEMU can conceivably use in any scenario. [AJB: added centos-release-advanced-virtualization/epel-release] Signed-off-by: Daniel P. Berrangé Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewe

[PATCH] hw: aspeed_gpio: Fix memory size

2021-07-12 Thread Joel Stanley
The macro used to calculate the maximum memory size of the MMIO region had a mistake, causing all GPIO models to create a mapping of 0x9D8. The intent was to have it be 0x9D8 - 0x800. This extra size doesn't matter on ast2400 and ast2500, which have a 4KB region set aside for the GPIO controller.

[PULL 04/22] crypto: use &error_fatal in crypto tests

2021-07-12 Thread Daniel P . Berrangé
Using error_fatal provides better diagnostics when tests failed, than using asserts, because we see the text of the error message. Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrangé --- tests/unit/test-crypto-hash.c | 13 +++-- tests/unit/test-crypto-hmac.c | 28 -

[PATCH] meson: fix condition for io_uring stubs

2021-07-12 Thread Paolo Bonzini
CONFIG_LINUX_IO_URING is not included in config-host.mak and therefore is not usable in "when" clauses. Just include it unconditionally, it will be quietly elided by the linker if liburing is not available (including on non-Linux). At this point, the difference between libraries that have config-

[PULL 05/22] crypto: fix gcrypt min version 1.8 regression

2021-07-12 Thread Daniel P . Berrangé
The min gcrypt was bumped: commit b33a84632a3759c00320fd80923aa963c11207fc Author: Daniel P. Berrangé Date: Fri May 14 13:04:08 2021 +0100 crypto: bump min gcrypt to 1.8.0, dropping RHEL-7 support but this was accidentally lost in conflict resolution for commit 5761251138cb69c310

[PULL 14/40] tests/docker: fix sorting in package lists

2021-07-12 Thread Alex Bennée
From: Daniel P. Berrangé This will make diffs in later patches clearer. Signed-off-by: Daniel P. Berrangé Signed-off-by: Alex Bennée Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Message-Id: <20210623142245.307776-7-berra...@redhat.com

[PULL 00/22] Crypto and more patches

2021-07-12 Thread Daniel P . Berrangé
The following changes since commit bd38ae26cea0d1d6a97f930248df149204c210a2: Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-tcg-20210710' into staging (2021-07-12 11:02:39 +0100) are available in the Git repository at: https://gitlab.com/berrange/qemu tags/crypto-and-more-pull-r

[PULL 11/22] crypto: replace 'des-rfb' cipher with 'des'

2021-07-12 Thread Daniel P . Berrangé
Currently the crypto layer exposes support for a 'des-rfb' algorithm which is just normal single-DES, with the bits in each key byte reversed. This special key munging is required by the RFB protocol password authentication mechanism. Since the crypto layer is generic shared code, it makes more se

[PULL 10/22] crypto: delete built-in XTS cipher mode support

2021-07-12 Thread Daniel P . Berrangé
The built-in AES+XTS implementation is used for the LUKS encryption When building system emulators it is reasonable to expect that an external crypto library is being used instead. The performance of the builtin XTS implementation is terrible as it has no CPU acceleration support. It is thus not wo

  1   2   3   4   >