Re: [PATCH] tests/migration: fix unix socket migration

Ping cc the author and maintainer 在 2021/6/26 0:33, Hyman 写道: 在 2021/4/29 1:26, Wainer dos Santos Moschetta 写道: Cleber, Maybe you could review then queue this one? Ping it seems that this patch has been left out :) - Wainer On 4/20/21 10:16 PM, Hyman Huang wrote: 在 2021/3/10 0:55, P

Re: [PATCH 1/4] hw/nvme: remove NvmeCtrl parameter from ns setup/check functions

On 7/6/21 11:33 AM, Klaus Jensen wrote: From: Klaus Jensen The nvme_ns_setup and nvme_ns_check_constraints should not depend on the controller state. Refactor and remove it. Signed-off-by: Klaus Jensen --- hw/nvme/nvme.h | 2 +- hw/nvme/ctrl.c | 2 +- hw/nvme/ns.c | 37 +++

Re: [PATCH 2/4] hw/nvme: mark nvme-subsys non-hotpluggable

On 7/6/21 11:33 AM, Klaus Jensen wrote: From: Klaus Jensen We currently lack the infrastructure to handle subsystem hotplugging, so disable it. Signed-off-by: Klaus Jensen --- hw/nvme/subsys.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/nvme/subsys.c b/hw/nvme/subsys.c index 192

Re: [PATCH 3/4] hw/nvme: unregister controller with subsystem at exit

On 7/6/21 11:33 AM, Klaus Jensen wrote: From: Klaus Jensen Make sure the controller is unregistered from the subsystem when device is removed. Signed-off-by: Klaus Jensen --- hw/nvme/nvme.h | 1 + hw/nvme/ctrl.c | 4 hw/nvme/subsys.c | 5 + 3 files changed, 10 insertions(+)

Re: [PATCH 4/4] hw/nvme: fix controller hot unplugging

On 7/6/21 11:33 AM, Klaus Jensen wrote: From: Klaus Jensen Prior to this patch the nvme-ns devices are always children of the NvmeBus owned by the NvmeCtrl. This causes the namespaces to be unrealized when the parent device is removed. However, when subsystems are involved, this is not what we

Re: [PATCH v1] block/raw-format: implement .bdrv_get_specific_info handler

Am 07.07.2021 um 07:35 hat Or Ozeri geschrieben: > When using the raw format, allow exposing specific info by the underlying > storage. > In particular, this will enable RBD images using the raw format to indicate > a LUKS2 encrypted image in the output of qemu-img info. > > Signed-off-by: Or Oze

[PATCH] Fix libpmem configuration option

For some reason, libpmem option setting was set to work in an opposite way (--enable-libpmem disabled it and vice versa). Fixing this so configuration works properly. Signed-off-by: Miroslav Rezanina --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure

Re: Plugin virtual-to-physical translation incorrect for some IO accesses

On 7/6/21 11:56 PM, Aaron Lindsay wrote: > On Jul 06 23:10, Philippe Mathieu-Daudé wrote: >> +Peter/Paolo >> >> On 7/6/21 10:47 PM, Aaron Lindsay wrote: >>> Hello, >>> >>> I previously supplied a patch which modified the plugin interface such >>> that it will return physical addresses for IO region

Re: [PATCH] tcg: Add separator in INDEX_op_call dump

On 7/7/21 2:04 AM, Richard Henderson wrote: > We lost the ',' following the called function name. > > Fixes: 3e92aa34434 > Signed-off-by: Richard Henderson > --- > tcg/tcg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH] Fix libdaxctl option

On 7/7/21 8:35 AM, Thomas Huth wrote: > On 07/07/2021 08.31, Miroslav Rezanina wrote: >> For some reason, libdaxctl option setting was set to work in an opposite >> way (--enable-libdaxctl disabled it and vice versa). Fixing this so >> configuration works properly. >> >> Signed-off-by: Miroslav Rez

Re: [PATCH] Fix libpmem configuration option

On 7/7/21 9:51 AM, Miroslav Rezanina wrote: > For some reason, libpmem option setting was set to work in an opposite > way (--enable-libpmem disabled it and vice versa). Fixing this so > configuration works properly. > > Signed-off-by: Miroslav Rezanina > --- > configure | 4 ++-- > 1 file chang

Re: [PATCH v2 13/36] linux-user/arm: Drop v1 signal frames

On 7/7/21 1:49 AM, Richard Henderson wrote: > Version 2 signal frames are used from 2.6.12. > Since cbc14e6f286, we have set UNAME_MINIMUM_RELEASE to 2.6.32, > which means that version 1 signal frames are never used. > > Cc: qemu-...@nongnu.org > Suggested-by: Peter Maydell > Signed-off-by: Richa

Re: [PATCH v2 14/36] linux-user/arm: Drop "_v2" from symbols in signal.c

On 7/7/21 1:49 AM, Richard Henderson wrote: > Since we no longer support "v1", there's no need to > distinguish "v2". > > Cc: qemu-...@nongnu.org > Signed-off-by: Richard Henderson > --- > linux-user/arm/signal.c | 155 +--- > 1 file changed, 65 insertions(+),

Re: [PATCH v2 04/36] linux-user: Tidy loader_exec

On 7/7/21 1:49 AM, Richard Henderson wrote: > Reorg the if cases to reduce indentation. > Test for 4 bytes in the file before checking the signatures. > > Signed-off-by: Richard Henderson > --- > linux-user/linuxload.c | 42 +- > 1 file changed, 21 inserti

Re: [PATCH] tests/migration: fix unix socket migration

On 3/9/21 5:00 PM, huang...@chinatelecom.cn wrote: > From: Hyman > > The test aborts and error message as the following be throwed: > "No such file or directory: '/var/tmp/qemu-migrate-{pid}.migrate", > when the unix socket migration test nearly done. The reason is > qemu removes the unix socket

Re: [PATCH v1 00/39] final pre-PR for 6.1 (testing and plugins)

On 7/6/21 4:57 PM, Alex Bennée wrote: > Hi, > > This is a roll-up of a number of testing series: > > - Cleber's ansible playbooks for installing runners > - Daniel's Cirrus cleanups > - Most of Daniels' docker clean-ups (but without lcitool) > - Disable signals test for all arches Two ot

Re: [RFC v3] virtio/vsock: add two more queues for datagram types

On Tue, Jul 06, 2021 at 10:26:07PM +, Jiang Wang wrote: Datagram sockets are connectionless and unreliable. The sender does not know the capacity of the receiver and may send more packets than the receiver can handle. Add two more dedicate virtqueues for datagram sockets, so that it will not

RE: [PATCH] migration: Move bitmap_mutex out of migration_bitmap_clear_dirty()

On Wednesday, July 7, 2021 1:47 AM, Peter Xu wrote: > On Sat, Jul 03, 2021 at 02:53:27AM +, Wang, Wei W wrote: > > + do { > > +page_to_clear = start + (i++ << block->clear_bmap_shift); > > Why "i" needs to be shifted? Just move to the next clear chunk, no? For example, (1 <<

RE: [PATCH] migration: Move bitmap_mutex out of migration_bitmap_clear_dirty()

On Wednesday, July 7, 2021 2:00 AM, Peter Xu wrote: > On Fri, Jul 02, 2021 at 02:29:41AM +, Wang, Wei W wrote: > > With that, if free page opt is off, the mutex is skipped, isn't it? > > Yes, but when free page is on, it'll check once per page. As I mentioned I > still > don't think it's the

RE: [PATCH v1] block/raw-format: implement .bdrv_get_specific_info handler

Would you suggest to do this child traversal on bdrv_query_image_info, and have it returned as part of the ImageInfo struct?In that case, I would add *driver-specific to ImageInfo, in addition to the existing *format-specific?Or should I just do the traversal in img_info (qemu-img.c), avoiding the

Re: [PATCH 3/4] dp8393x: Store CAM registers as 16-bit

On 07/07/2021 00:48, Finn Thain wrote: On Mon, 5 Jul 2021, Mark Cave-Ayland wrote: From: Philippe Mathieu-Daudé Per the DP83932C datasheet from July 1995: 4.0 SONIC Registers 4.1 THE CAM UNIT The Content Addressable Memory (CAM) consists of sixteen 48-bit entries for comple

Re: [PATCH 00/53] acpi: refactor error prone build_header() and packed structures usage in ACPI tables

On Mon, 5 Jul 2021 14:00:51 -0400 "Michael S. Tsirkin" wrote: > On Mon, Jul 05, 2021 at 09:56:18AM +0200, Igor Mammedov wrote: > > On Fri, 2 Jul 2021 10:47:20 -0400 > > "Michael S. Tsirkin" wrote: > > > > > On Fri, Jun 25, 2021 at 05:17:24AM -0400, Igor Mammedov wrote: > > > > Highlights: >

Re: [PATCH v4 1/3] qapi/qdev.json: add DEVICE_UNPLUG_ERROR QAPI event

On Tue, 6 Jul 2021 21:33:12 -0300 Daniel Henrique Barboza wrote: > At this moment we only provide one event to report a hotunplug error, > MEM_UNPLUG_ERROR. As of Linux kernel 5.12 and QEMU 6.0.0, the pseries > machine is now able to report unplug errors for other device types, such > as CPUs. >

[PATCH v5] MAINTAINERS: Added myself as a reviewer for TCG Plugins

Signed-off-by: Mahmoud Mandour --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5f55404f2f..1c4970c88b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2966,6 +2966,7 @@ F: include/tcg/ TCG Plugins M: Alex Bennée +R: Mahmoud Mandour S: Maint

Re: [PATCH v4 2/3] spapr: use DEVICE_UNPLUG_ERROR to report unplug errors

On Tue, 6 Jul 2021 21:33:13 -0300 Daniel Henrique Barboza wrote: > Linux Kernel 5.12 is now unisolating CPU DRCs in the device_removal > error path, signalling that the hotunplug process wasn't successful. > This allow us to send a DEVICE_UNPLUG_ERROR in drc_unisolate_logical() > to signal this

Re: [PATCH v4 3/3] memory_hotplug.c: send DEVICE_UNPLUG_ERROR in acpi_memory_hotplug_write()

On Tue, 6 Jul 2021 21:33:14 -0300 Daniel Henrique Barboza wrote: > MEM_UNPLUG_ERROR is deprecated since the introduction of > DEVICE_UNPLUG_ERROR. Keep emitting both while the deprecation of > MEM_UNPLUG_ERROR is pending. > > CC: Michael S. Tsirkin > CC: Igor Mammedov > Reviewed-by: David Gib

Re: [PATCH] hw/ide: Fix crash when plugging a piix3-ide device into the x-remote machine

On Tue, Jul 06, 2021 at 10:37:03AM +0200, Philippe Mathieu-Daudé wrote: > Stefan, IIRC the multi-process conclusion was we have to reject > PCI devices briding another (non-PCI) bus, such ISA / I2C / USB > / SD / ... because QEMU register the bus type globally and the > command line machinery resol

Re: [PATCH] docs: Add '-device intel-iommu' entry

Hi Peter, On 6/11/21 8:55 PM, Peter Xu wrote: > The parameters of intel-iommu device are non-trivial to understand. Add an > entry for it so that people can reference to it when using. > > There're actually a few more options there, but I hide them explicitly because > they shouldn't be used by

[PING] [PATCH v0] vhost: make SET_VRING_ADDR, SET_[PROTOCOL_]FEATEURES send replies

On 02.07.2021 12:41, Denis Plotnikov wrote: ping ping! On 25.06.2021 11:52, Denis Plotnikov wrote: On vhost-user-blk migration, qemu normally sends a number of commands to enable logging if VHOST_USER_PROTOCOL_F_LOG_SHMFD is negotiated. Qemu sends VHOST_USER_SET_FEATURES to enable buffers log

Re: [PATCH 4/4] hw/nvme: fix controller hot unplugging

On Jul 7 09:49, Hannes Reinecke wrote: On 7/6/21 11:33 AM, Klaus Jensen wrote: From: Klaus Jensen Prior to this patch the nvme-ns devices are always children of the NvmeBus owned by the NvmeCtrl. This causes the namespaces to be unrealized when the parent device is removed. However, when subs

Re: [PATCH 1/4] dp8393x: don't force 32-bit register access

On 07/07/2021 00:51, Finn Thain wrote: On Mon, 5 Jul 2021, Mark Cave-Ayland wrote: Commit 3fe9a838ec "dp8393x: Always use 32-bit accesses" set .impl.min_access_size and .impl.max_access_size to 4 to try and fix the Linux jazzsonic driver which uses 32-bit accesses. The problem with forcing

Re: [PATCH 4/4] hw/nvme: fix controller hot unplugging

On Jul 6 11:33, Klaus Jensen wrote: From: Klaus Jensen Prior to this patch the nvme-ns devices are always children of the NvmeBus owned by the NvmeCtrl. This causes the namespaces to be unrealized when the parent device is removed. However, when subsystems are involved, this is not what we wan

Re: [RFC PATCH 8/8] target/i386: Move X86XSaveArea into TCG

On Tuesday, 2021-07-06 at 18:09:42 -07, Richard Henderson wrote: > On 7/5/21 3:46 AM, David Edmondson wrote: >> Given that TCG is now the only consumer of X86XSaveArea, move the >> structure definition and associated offset declarations and checks to a >> TCG specific header. >> >> Signed-off-by:

Re: [PATCH v0] vhost: make SET_VRING_ADDR, SET_[PROTOCOL_]FEATEURES send replies

On Fri, Jun 25, 2021 at 11:52:10AM +0300, Denis Plotnikov wrote: > On vhost-user-blk migration, qemu normally sends a number of commands > to enable logging if VHOST_USER_PROTOCOL_F_LOG_SHMFD is negotiated. > Qemu sends VHOST_USER_SET_FEATURES to enable buffers logging and > VHOST_USER_SET_FEATURES

Re: [RFC PATCH 6/6] dp8393x: Rewrite dp8393x_get() / dp8393x_put()

On 07/07/2021 02:30, Finn Thain wrote: On Mon, 5 Jul 2021, Mark Cave-Ayland wrote: On 05/07/2021 02:36, Finn Thain wrote: Unfortunately I don't have a test mips64el image available to see if this combination works for Linux. Phil, do you have a suitable test kernel and rootfs image available

RE: [PATCH] docs: Add '-device intel-iommu' entry

> From: Peter Xu < pet...@redhat.com > > Sent: Saturday, June 12, 2021 2:55 AM > > The parameters of intel-iommu device are non-trivial to understand. Add > an > entry for it so that people can reference to it when using. > > There're actually a few more options there, but I hide them explicitly

Re: [PATCH v2 2/6] export/fuse: Add allow-other option

Am 25.06.2021 um 16:23 hat Max Reitz geschrieben: > Without the allow_other mount option, no user (not even root) but the > one who started qemu/the storage daemon can access the export. Allow > users to configure the export such that such accesses are possible. > > While allow_other is probably

Re: [PATCH v2 6/6] iotests/fuse-allow-other: Test allow-other

Am 25.06.2021 um 16:23 hat Max Reitz geschrieben: > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/tests/fuse-allow-other | 175 ++ > tests/qemu-iotests/tests/fuse-allow-other.out | 88 + > 2 files changed, 263 insertions(+) > create mode 100755 tests/qemu-iotes

Re: [PATCH 4/4] hw/nvme: fix controller hot unplugging

On 7/7/21 11:53 AM, Klaus Jensen wrote: On Jul  7 09:49, Hannes Reinecke wrote: On 7/6/21 11:33 AM, Klaus Jensen wrote: From: Klaus Jensen Prior to this patch the nvme-ns devices are always children of the NvmeBus owned by the NvmeCtrl. This causes the namespaces to be unrealized when the par

[PATCH v7 07/14] target/s390x: start moving TCG-only code to tcg/

move everything related to translate, as well as HELPER code in tcg/ mmu_helper.c stays put for now, as it contains both TCG and KVM code. After the reshuffling, update MAINTAINERS accordingly. Make use of the new directory: target/s390x/tcg/ Signed-off-by: Claudio Fontana Signed-off-by: Cho,

[PATCH v7 00/14] s390x cleanup

this is the next version of a cleanup series for s390x. v6 -> v7: * "hw/s390x: rename tod-qemu.c to tod-tcg.c" #2 - change the comment at the top of the file: "TCG implementation" instead of "QEMU implementation" (Thomas) * "hw/s390x: only build tod-tcg from the CONFIG_TCG build" #3

[PATCH v7 01/14] target/s390x: meson: add target_user_arch

the lack of target_user_arch makes it hard to fully leverage the build system in order to separate user code from sysemu code. Provide it, so that we can avoid the proliferation of #ifdef in target code. Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen Acked-by: Cornelia Huck Reviewe

[PATCH v7 12/14] target/s390x: remove kvm-stub.c

all function calls are protected by kvm_enabled(), so we do not need the stubs. Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen Reviewed-by: Cornelia Huck Reviewed-by: Thomas Huth --- MAINTAINERS | 1 - target/s390x/kvm-stub.c | 121 -

[PATCH v7 02/14] hw/s390x: rename tod-qemu.c to tod-tcg.c

we stop short of renaming the actual qom object though, so type remains TYPE_QEMU_S390_TOD, ie "s390-tod-qemu". Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen Reviewed-by: David Hildenbrand Reviewed-by: Cornelia Huck Reviewed-by: Thomas Huth --- hw/s390x/meson.build

[PATCH v7 05/14] target/s390x: remove tcg-stub.c

now that we protect all calls to the tcg-specific functions with if (tcg_enabled()), we do not need the TCG stub anymore. Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen Reviewed-by: David Hildenbrand Reviewed-by: Cornelia Huck Reviewed-by: Thomas Huth --- target/s390x/meson.build

[PATCH v7 08/14] target/s390x: move sysemu-only code out to cpu-sysemu.c

move sysemu-only code out to cpu-sysemu.c Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen Acked-by: Cornelia Huck Reviewed-by: Thomas Huth --- target/s390x/cpu-sysemu.c | 309 ++ target/s390x/cpu.c| 285 +--

[PATCH v7 13/14] target/s390x: move kvm files into kvm/

move kvm files into kvm/ After the reshuffling, update MAINTAINERS accordingly. Make use of the new directory: target/s390x/kvm/ Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen Reviewed-by: Cornelia Huck --- MAINTAINERS| 3 +-- hw/intc/s390_flic_kvm.c

[PATCH v7 06/14] target/s390x: rename internal.h to s390x-internal.h

The internal.h file is renamed to s390x-internal.h, because of the risk of collision with other files with the same name. Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen Acked-by: David Hildenbrand Acked-by: Cornelia Huck --- target/s390x/arch_dump.c | 2 +- ta

[PATCH v7 03/14] hw/s390x: tod: make explicit checks for accelerators when initializing

replace general "else" with specific checks for each possible accelerator. Handle qtest as a NOP, and error out for an unknown accelerator used in combination with tod. Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen Reviewed-by: David Hildenbrand Reviewed-by: Cornelia Huck Reviewe

[PATCH v7 09/14] target/s390x: split cpu-dump from helper.c

Splitting this functionality also allows us to make helper.c sysemu-only. Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen Acked-by: Cornelia Huck --- target/s390x/cpu-dump.c | 134 ++ target/s390x/cpu.c | 43 +++ target/s390x/helper.c

[PATCH] osdep: fix HAVE_BROKEN_SIZE_MAX case

While config-host.mak entries are expanded to "1" for compatibility with create-config.sh, tests done directly in meson.build expand to the empty string and cannot be placed to the right of the && operator. Adjust osdep.h after commit e46bd55d9c ("configure: convert HAVE_BROKEN_SIZE_MAX to meson",

[PATCH v7 04/14] hw/s390x: only build tod-tcg from the CONFIG_TCG build

this will allow in later patches to remove unneeded stubs in target/s390x. Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen Reviewed-by: David Hildenbrand Reviewed-by: Cornelia Huck Reviewed-by: Thomas Huth --- hw/s390x/meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 delet

[PATCH v7 10/14] target/s390x: make helper.c sysemu-only

Now that we have moved cpu-dump functionality out of helper.c, we can make the module sysemu-only. Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen Acked-by: Cornelia Huck Reviewed-by: Thomas Huth --- target/s390x/helper.c| 9 + target/s390x/meson.build | 2 +- 2 files c

[PATCH v7 14/14] target/s390x: split sysemu part of cpu models

split sysemu part of cpu models, also create a tiny _user.c with just the (at least for now), empty implementation of apply_cpu_model. Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen Reviewed-by: Thomas Huth --- MAINTAINERS | 1 + target/s390x/cpu_models.c

[PATCH v7 11/14] target/s390x: use kvm_enabled() to wrap call to kvm_s390_get_hpage_1m

this will allow to remove the kvm stubs. Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen Reviewed-by: Thomas Huth --- target/s390x/diag.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/s390x/diag.c b/target/s390x/diag.c index c17a2498a7..8405f69df0 1006

Re: [PATCH v2 0/6] export/fuse: Allow other users access to the export

Am 25.06.2021 um 16:23 hat Max Reitz geschrieben: > Max Reitz (6): > export/fuse: Pass default_permissions for mount > export/fuse: Add allow-other option > export/fuse: Give SET_ATTR_SIZE its own branch > export/fuse: Let permissions be adjustable > iotests/308: Test +w on read-only FUSE

Re: [PATCH] osdep: fix HAVE_BROKEN_SIZE_MAX case

On Wed, Jul 07, 2021 at 12:56:00PM +0200, Paolo Bonzini wrote: > While config-host.mak entries are expanded to "1" for compatibility with > create-config.sh, tests done directly in meson.build expand to the empty > string and cannot be placed to the right of the && operator. Adjust > osdep.h after

Re: [PATCH] ui/gtk: Fix relative mouse with multiple monitors

Ping https://lore.kernel.org/qemu-devel/20210629132410.286813-1-denniswoelf...@gmx.de On 29.06.21 15:24, Dennis Wölfing wrote: To handle relative mouse input the event handler needs to move the mouse away from the screen edges. Failing to do so results in the mouse getting stuck at invisible wal

Re: [RFC PATCH] hw/display/virtio-gpu: Fix memory leak (CID 1453811)

Hi On Mon, May 31, 2021 at 2:20 PM Philippe Mathieu-Daudé wrote: > To avoid leaking memory on the error path, reorder the > code as: > - check the parameters first > - check resource already existing > - finally allocate memory > > Reported-by: Coverity (CID 1453811: RESOURCE_LEAK) > Fixes: e093

Re: [PATCH v7 01/14] target/s390x: meson: add target_user_arch

On 07/07/2021 12.53, Cho, Yu-Chen wrote: the lack of target_user_arch makes it hard to fully leverage the build system in order to separate user code from sysemu code. Provide it, so that we can avoid the proliferation of #ifdef in target code. Signed-off-by: Claudio Fontana Signed-off-by: Cho

Re: [PATCH v7 06/14] target/s390x: rename internal.h to s390x-internal.h

On 07/07/2021 12.53, Cho, Yu-Chen wrote: The internal.h file is renamed to s390x-internal.h, because of the risk of collision with other files with the same name. Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen Acked-by: David Hildenbrand Acked-by: Cornelia Huck --- target/s390x

Re: [PATCH] trace: add hardware interrupt calls tracing

Ping? https://patchwork.kernel.org/project/qemu-devel/patch/20210625073844.1229-3-mark.cave-ayl...@ilande.co.uk/ вт, 29 июн. 2021 г. в 16:38, Arkadiy : > From: NDNF > > Adds hardware interrupt call tracing. This is necessary to debugging Qemu > and > virtual devices. It was decided to use func

Re: [PATCH] tcg: Move tb_phys_invalidate_count to tb_ctx (#457)

On Tue, Jul 06, 2021 at 08:55:32PM -0700, Richard Henderson wrote: > We can call do_tb_phys_invalidate from an iocontext, which has > no per-thread tcg_ctx. Move this to tb_ctx, which is global. > The actual update still takes place with a lock held, so only > an atomic set is required, not an ato

Re: Plugin virtual-to-physical translation incorrect for some IO accesses

On Jul 07 09:53, Philippe Mathieu-Daudé wrote: > On 7/6/21 11:56 PM, Aaron Lindsay wrote: > > On Jul 06 23:10, Philippe Mathieu-Daudé wrote: > >> +Peter/Paolo > >> > >> On 7/6/21 10:47 PM, Aaron Lindsay wrote: > >>> Hello, > >>> > >>> I previously supplied a patch which modified the plugin interfac

Re: [PATCH v7 07/14] target/s390x: start moving TCG-only code to tcg/

On 07/07/2021 12.53, Cho, Yu-Chen wrote: move everything related to translate, as well as HELPER code in tcg/ mmu_helper.c stays put for now, as it contains both TCG and KVM code. After the reshuffling, update MAINTAINERS accordingly. Make use of the new directory: target/s390x/tcg/ Signed-of

Re: [PATCH v7 09/14] target/s390x: split cpu-dump from helper.c

On 07/07/2021 12.53, Cho, Yu-Chen wrote: Splitting this functionality also allows us to make helper.c sysemu-only. Maybe add a sentence that you move some other functions to cpu.c now. Anyway: Reviewed-by: Thomas Huth

Re: [PATCH v7 13/14] target/s390x: move kvm files into kvm/

On 07/07/2021 12.53, Cho, Yu-Chen wrote: move kvm files into kvm/ After the reshuffling, update MAINTAINERS accordingly. Make use of the new directory: target/s390x/kvm/ Signed-off-by: Claudio Fontana Signed-off-by: Cho, Yu-Chen Reviewed-by: Cornelia Huck --- MAINTAINERS

Re: [PATCH v7 00/14] s390x cleanup

On Wed, Jul 07 2021, "Cho, Yu-Chen" wrote: > this is the next version of a cleanup series for s390x. This seems to be in good shape now, I guess we can do any remaining cleanups on top. I'll give it a whirl and queue it if nothing shows up.

[PATCH] vl: fix leak of qdict_crumple return value

Coverity reports that qemu_parse_config_group is returning without unrefing the "crumpled" dictionary in case its top level item is a list. But actually the contract with qemu_record_config_group is the same as for qemu_parse_config_group itself: if those function need to stash the dictionary they

[PATCH] qemu-config: never call the callback after an error, fix leak

Ensure that the callback to qemu_config_foreach is never called upon an error, by moving the invocation before the "out" label and ensuring all error cases jump to the label. The qobject_unref however needs to be done in all cases (which Coverity is already complaining about). The leak is basical

Re: [PATCH v0] vhost: make SET_VRING_ADDR, SET_[PROTOCOL_]FEATEURES send replies

On 07.07.2021 13:10, Michael S. Tsirkin wrote: On Fri, Jun 25, 2021 at 11:52:10AM +0300, Denis Plotnikov wrote: On vhost-user-blk migration, qemu normally sends a number of commands to enable logging if VHOST_USER_PROTOCOL_F_LOG_SHMFD is negotiated. Qemu sends VHOST_USER_SET_FEATURES to enable

Re: [PATCH v1] block/raw-format: implement .bdrv_get_specific_info handler

Am 07.07.2021 um 10:50 hat Or Ozeri geschrieben: > Would you suggest to do this child traversal on bdrv_query_image_info, and > have > it returned as part of the ImageInfo struct? > In that case, I would add *driver-specific to ImageInfo, in addition to the > existing *format-specific? No, extend

Re: [PATCH V4 00/25] Live Update

Hi Steve On Tue, Jul 6, 2021 at 8:58 PM Steve Sistare wrote: > Provide the cprsave, cprexec, and cprload commands for live update. These > save and restore VM state, with minimal guest pause time, so that qemu may > be updated to a new version in between. > > cprsave stops the VM and saves vmst

Re: [PATCH V4 00/25] Live Update

On 7/7/2021 8:31 AM, Marc-André Lureau wrote: > Hi Steve > > On Tue, Jul 6, 2021 at 8:58 PM Steve Sistare > wrote: > >[...] > It doesn't apply on master, could you rebase and resend? > thanks > -- > Marc-André Lureau Will do, sorry about that - steve

RE: [PATCH] migration: Move bitmap_mutex out of migration_bitmap_clear_dirty()

On Wednesday, July 7, 2021 1:40 AM, Peter Xu wrote: > On Tue, Jul 06, 2021 at 12:05:49PM +0200, David Hildenbrand wrote: > > On 06.07.21 11:41, Wang, Wei W wrote: > > > On Monday, July 5, 2021 9:42 PM, David Hildenbrand wrote: > > > > On 03.07.21 04:53, Wang, Wei W wrote: > > > > > On Friday, July

Re: [PATCH 11/18] crypto: rename des-rfb cipher to just des

Daniel P. Berrangé writes: > Currently the crypto layer exposes support for a 'des-rfb' > algorithm which is just normal single-DES, with the bits > in each key byte reversed. This special key munging is > required by the RFB protocol password authentication > mechanism. > > Since the crypto laye

Re: [PATCH] tcg: Move tb_phys_invalidate_count to tb_ctx (#457)

On Tue, Jul 06, 2021 at 08:55:32PM -0700, Richard Henderson wrote: > We can call do_tb_phys_invalidate from an iocontext, which has > no per-thread tcg_ctx. Move this to tb_ctx, which is global. > The actual update still takes place with a lock held, so only > an atomic set is required, not an ato

[PATCH] hw: timer: Add i.MX sysctr timer implementation

From: Viorica Mancas The System Counter (SYS_CTR) is a programmable system counter, which provides a shared time base to multiple processors. It is intended for applications where the counter is always powered on, and supports multiple unrelated clocks. This system counter can be found on NXP i

[Bug 1757363] Re: infinite loop due to improper deal with "eret" on mips32

This seems to affect me too; I have a loop on interrupt handler after the first interrupt called. The version of qemu is latest 3.1 from upstream, so this is not Ubuntu issue. However, have you done with it? Just commenting out env->CP0_Status &= ~(1 << CP0St_EXL); does not help. -- You recei

Re: [PATCH] block/replication.c: Properly attach children

06.07.2021 19:11, Lukas Straub wrote: The replication driver needs access to the children block-nodes of it's child so it can issue bdrv_make_empty to manage the replication. However, it does this by directly copying the BdrvChilds, which is wrong. Fix this by properly attaching the block-nodes

[PATCH for 6.1 v2 0/5] custom device configs

Hi, This is the second edition of the custom config patches. The first 3 patches are well reviewed but the last two could do with some attention. I assume this should be merged through Paolo's tree? The final two need review: - configure: allow the selection of alternate config in the build -

[PATCH v2 1/5] meson: Introduce target-specific Kconfig

From: Philippe Mathieu-Daudé Add a target-specific Kconfig. We need the definitions in Kconfig so the minikconf tool can verify they exits. However CONFIG_FOO is only enabled for target foo via the meson.build rules. Two architecture have a particularity, ARM and MIPS. As their translators have

[PATCH v2 4/5] configs: rename default-configs to configs and reorganise

In preparation for offering variation to our build configurations lets move everything and rename it to default. Common included base configs are also renamed. During the cleanup the stale usb.mak and pci.mak references were removed from MAINTAINERS. Signed-off-by: Alex Bennée Cc: Paolo Bonzini

[PATCH v2 2/5] hw/arm: add dependency on OR_IRQ for XLNX_VERSAL

We need this functionality due to: /* XRAM IRQs get ORed into a single line. */ object_initialize_child(OBJECT(s), "xram-irq-orgate", &s->lpd.xram.irq_orgate, TYPE_OR_IRQ); Fixes: a55b441b2ca ("hw/arm: versal: Add support for the XRAMs") Signed-off-by: Alex Be

[PATCH v2 3/5] hw/arm: move CONFIG_V7M out of default-devices

We currently select CONFIG_V7M for a bunch of our m-profile devices. The last sticking point is translate.c which cannot be compiled without expecting v7m support. Express this dependency in Kconfig rather than in default devices as a stepping stone to a fully configurable translate.c. While we ar

[PATCH v2 5/5] configure: allow the selection of alternate config in the build

While the default config works well enough it does end up enabling a lot of stuff. For more minimal builds we can select a different list of devices and let Kconfig work out what we want. For example: ../../configure --without-default-features \ --target-list=arm-softmmu,aarch64-softmmu \

Re: [PATCH] blockdev: fix drive-backup transaction endless drained section

Forgotten thing :( Kevin, could you please queue it in your block branch? For me not to bother Peter with one-patch pull request. 08.06.2021 20:18, Vladimir Sementsov-Ogievskiy wrote: drive_backup_prepare() does bdrv_drained_begin() in hope that bdrv_drained_end() will be called in drive_backu

[PATCH 0/2] numa: Parse initiator= attribute before cpus= attribute

See 2/2 for explanation. The first patch is just cosmetics. Michal Privoznik (2): numa: Report expected initiator numa: Parse initiator= attribute before cpus= attribute hw/core/machine.c | 3 ++- hw/core/numa.c| 45 +++-- 2 files changed, 25 inse

[PATCH 1/2] numa: Report expected initiator

When setting up NUMA with HMAT enabled there's a check performed in machine_set_cpu_numa_node() that reports an error when a NUMA node has a CPU but the node's initiator is not itself. The error message reported contains only the expected value and not the actual value (which is different because a

[PATCH 2/2] numa: Parse initiator= attribute before cpus= attribute

When parsing cpus= attribute of -numa object couple of checks is performed, such as correct initiator setting (see the if() statement at the end of for() loop in machine_set_cpu_numa_node()). However, with the current code cpus= attribute is parsed before initiator= attribute and thus the check ma

[PATCH v2 1/2] linux-user/s390x: signal with SIGFPE on compare-and-trap

Currently when a compare-and-trap instruction is executed, qemu will always raise a SIGILL signal. On real hardware, a SIGFPE is raised. Change the PGM_DATA case in cpu_loop to follow the behavior in linux kernel /arch/s390/kernel/traps.c. * Only raise SIGILL if DXC == 0 * If DXC matches an IEEE

[PATCH v2 0/2] linux-user/s390x: signal with SIGFPE on compare-and-trap

qemu-s390x signals with SIGILL on compare-and-trap instructions. This breaks OpenJDK which expects SIGFPE in its implementation of implicit exceptions. This patch depends on [PATCH v6 0/2] target/s390x: Fix SIGILL and SIGFPE psw.addr reporting https://lore.kernel.org/qemu-devel/20210705210434.4582

[PATCH v2 2/2] tests/tcg: Test that compare-and-trap raises SIGFPE

Signed-off-by: Jonathan Albrecht --- tests/tcg/s390x/Makefile.target | 1 + tests/tcg/s390x/trap.c | 102 2 files changed, 103 insertions(+) create mode 100644 tests/tcg/s390x/trap.c diff --git a/tests/tcg/s390x/Makefile.target b/tests/tcg/s390x/Makef

Re: [PATCH 11/18] crypto: rename des-rfb cipher to just des

On Wed, Jul 07, 2021 at 02:47:15PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > Currently the crypto layer exposes support for a 'des-rfb' > > algorithm which is just normal single-DES, with the bits > > in each key byte reversed. This special key munging is > > required by

Re: [PATCH v4] memory: Directly dispatch alias accesses on origin memory region

Peter Xu already reviewed, but Cc'ing Peter Maydell too due to his last comment on v3: https://www.mail-archive.com/qemu-devel@nongnu.org/msg800482.html On 4/18/21 7:57 AM, Philippe Mathieu-Daudé wrote: > Since commit 2cdfcf272d ("memory: assign MemoryRegionOps to all > regions"), all newly create

Re: [PATCH v7 0/9] i386: KVM: expand Hyper-V features early

On Thu, Jun 03, 2021 at 01:48:26PM +0200, Vitaly Kuznetsov wrote: > Changes since v6 [Eduardo]: > - First 14 patches of v6 made it upstream! > - New patches addressing feedback on the already merged patches added: > i386: make hyperv_expand_features() return bool > i386: hardcode supported eVMC

Re: [PATCH v8 0/9] i386: KVM: expand Hyper-V features early

On Tue, Jun 08, 2021 at 02:08:08PM +0200, Vitaly Kuznetsov wrote: > Changes since v7: > - Make eVMCS version check future proof [Eduardo] > - Collect R-b tags [Eduardo] > - Drop 'if (!strcmp(arch, "i386") || !strcmp(arch, "x86_64"))' check from > qtest > [Eduardo] > - s/priviliges/privileges/ [Er

Re: Plugin virtual-to-physical translation incorrect for some IO accesses

On Jul 07 07:35, Aaron Lindsay wrote: > On Jul 07 09:53, Philippe Mathieu-Daudé wrote: > > On 7/6/21 11:56 PM, Aaron Lindsay wrote: > > > On Jul 06 23:10, Philippe Mathieu-Daudé wrote: > > >> +Peter/Paolo > > >> > > >> On 7/6/21 10:47 PM, Aaron Lindsay wrote: > > >>> Hello, > > >>> > > >>> I previo

[PATCH v1 1/2] migration/postcopy-ram: define type for "struct PostcopyNotifyData"

Let's define a proper type, just as we do for PrecopyNotifyData already. Cc: Wei Wang Cc: Michael S. Tsirkin Cc: Philippe Mathieu-Daudé Cc: Alexander Duyck Cc: Juan Quintela Cc: "Dr. David Alan Gilbert" Cc: Peter Xu Signed-off-by: David Hildenbrand --- hw/virtio/vhost-user.c | 2 +- mig

[PATCH v1 2/2] virtio-balloon: disallow postcopy with VIRTIO_BALLOON_F_FREE_PAGE_HINT

Postcopy never worked properly with 'free-page-hint=on', as there are at least two issues: 1) With postcopy, the guest will never receive a VIRTIO_BALLOON_CMD_ID_DONE and consequently won't release free pages back to the OS once migration finishes. The issue is that for postcopy, we won'

  1   2   3   4   >